[PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION

2020-09-24 Thread Dikshita Agarwal
From: Stanimir Varbanov - return correct width and height for G_SELECTION - if requested rectangle wxh doesn't match with capture port wxh adjust the rectangle to supported wxh. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/venc.c | 20 1 file cha

[PATCH 0/2] Venus: fix handling of crop and s_fmt

2020-09-24 Thread Dikshita Agarwal
Dikshita Agarwal (1): venus: venc: update output format based on capture format. Stanimir Varbanov (1): venus: venc: fix handlig of S_SELECTION and G_SELECTION drivers/media/platform/qcom/venus/venc.c | 48 ++-- 1 file changed, 27 insertions(+), 21 deletions(-) -

[PATCH 1/2] venus: venc: update output format based on capture format.

2020-09-24 Thread Dikshita Agarwal
update output format parameters when s_fmt is called on capture port as recommended in encoder spec. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/venc.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/media/platf

Re: [PATCH v2 1/1] KVM: x86: fix MSR_IA32_TSC read for nested migration

2020-09-24 Thread Paolo Bonzini
On 21/09/20 12:38, Maxim Levitsky wrote: > MSR reads/writes should always access the L1 state, since the (nested) > hypervisor should intercept all the msrs it wants to adjust, and these > that it doesn't should be read by the guest as if the host had read it. > > However IA32_TSC is an exception.

Re: [PATCH 07/13] x86: Secure Launch kernel early boot stub

2020-09-24 Thread Arvind Sankar
On Thu, Sep 24, 2020 at 10:58:35AM -0400, Ross Philipson wrote: > The Secure Launch (SL) stub provides the entry point for Intel TXT (and > later AMD SKINIT) to vector to during the late launch. The symbol > sl_stub_entry is that entry point and its offset into the kernel is > conveyed to the launc

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Joe Perches
On Thu, 2020-09-24 at 10:19 -0700, Nick Desaulniers wrote: > Hello maintainers, > Would you mind please picking up this patch? KernelCI has been > erroring for over a week without it. As it's trivial and necessary, why not go through Linus directly? https://lore.kernel.org/patchwork/patch/130754

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-24 Thread Mathieu Desnoyers
- On Sep 24, 2020, at 1:09 PM, rostedt rost...@goodmis.org wrote: > From: "Steven Rostedt (VMware)" > > As tracepoints are discouraged from being added in a header because it can > cause side effects if other tracepoints are in headers, the common > workaround is to add a function call that

Re: [PATCH v2 0/2] Add new controls for QP and layer bitrate

2020-09-24 Thread Nicolas Dufresne
Le lundi 21 septembre 2020 à 18:33 +0530, Dikshita Agarwal a écrit : > This series adds frame specific min/max qp controls for hevc and layer > wise bitrate control for h264. Any chance you could append your driver changes with this set ? I don't think new APIs ever make it without a driver using

Re: [RFC PATCH v2] sched/fair: select idle cpu from idle cpumask in sched domain

2020-09-24 Thread Tim Chen
On 9/24/20 10:13 AM, Phil Auld wrote: > On Thu, Sep 24, 2020 at 09:37:33AM -0700 Tim Chen wrote: >> >> >> On 9/22/20 12:14 AM, Vincent Guittot wrote: >> >> >> And a quick test with hackbench on my octo cores arm64 gives for 12 >> >> Vincent, >> >> Is it octo (=10) or octa (=8) cores

Re: [RFC PATCH v2] sched/fair: select idle cpu from idle cpumask in sched domain

2020-09-24 Thread Phil Auld
On Thu, Sep 24, 2020 at 10:43:12AM -0700 Tim Chen wrote: > > > On 9/24/20 10:13 AM, Phil Auld wrote: > > On Thu, Sep 24, 2020 at 09:37:33AM -0700 Tim Chen wrote: > >> > >> > >> On 9/22/20 12:14 AM, Vincent Guittot wrote: > >> > > >> > >> And a quick test with hackbench on my octo cor

Re: [PATCH v4] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-24 Thread Borislav Petkov
On Thu, Sep 24, 2020 at 12:23:27PM -0500, Smita Koralahalli Channabasappa wrote: > > Even though it's not defined in the UEFI spec, it doesn't mean a > > structure definition cannot be created. Created for what? That structure better have a big fat comment above it, what firmware generates its lay

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

2020-09-24 Thread Thomas Gleixner
On Thu, Sep 24 2020 at 08:32, Steven Rostedt wrote: > On Thu, 24 Sep 2020 08:57:52 +0200 > Thomas Gleixner wrote: > >> > Now as for migration disabled nesting, at least now we would have >> > groupings of this, and perhaps the theorists can handle that. I mean, >> > how is this much different that

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-24 Thread Peter Xu
On Thu, Sep 24, 2020 at 01:51:52PM -0300, Jason Gunthorpe wrote: > > Regarding the solution here, I think we can also cover read-only fast-gup > > too > > in the future - IIUC what we need to do is to make it pte_protnone() > > instead of > > pte_wrprotect(), then in the fault handler we should i

Re: [PATCH v19 00/20] per memcg lru_lock

2020-09-24 Thread Daniel Jordan
On Thu, Sep 24, 2020 at 11:28:15AM +0800, Alex Shi wrote: > The new version rebased on v5.9-rc6 with line by line review by Hugh Dickins. These thpscale numbers are from a proto-v19, which now seems to be gone from Alex Shi's github. Once again, this is a regression test where memcg is enabled bu

Re: [PATCH] tasklet: Introduce tasklet tracepoints

2020-09-24 Thread Thomas Gleixner
On Sat, Sep 05 2020 at 14:04, Muchun Song wrote: > Introduce tracepoints for tasklets just like softirq does. What does softirq? > In this case, we can calculate tasklet latency and know what tasklet > run. I rather see people working on removal of tasklets. Thanks, tglx

[PATCH v6 3/5] dmaengine: idxd: Add shared workqueue support

2020-09-24 Thread Dave Jiang
Add shared workqueue support that includes the support of Shared Virtual memory (SVM) or in similar terms On Demand Paging (ODP). The shared workqueue uses the enqcmds command in kernel and will respond with retry if the workqueue is full. Shared workqueue only works when there is PASID support fro

[PATCH v6 2/5] x86/asm: Add enqcmds() to support ENQCMDS instruction

2020-09-24 Thread Dave Jiang
Currently, the MOVDIR64B instruction is used to atomically submit 64-byte work descriptors to devices. Although it can encounter errors like device queue full, command not accepted, device not ready, etc when writing to a device MMIO, MOVDIR64B can not report back on errors from the device itself.

[PATCH v6 4/5] dmaengine: idxd: Clean up descriptors with fault error

2020-09-24 Thread Dave Jiang
Add code to "complete" a descriptor when the descriptor or its completion address hit a fault error when SVA mode is being used. This error can be triggered due to bad programming by the user. A lock is introduced in order to protect the descriptor completion lists since the fault handler will run

[PATCH v6 0/5] Add shared workqueue support for idxd driver

2020-09-24 Thread Dave Jiang
v6: Boris: - Fixup MOBDIR64B inline asm input/output constraints v5: Boris: - Fixup commit headers - Fixup var names for movdir64b() - Move enqcmds() to special_insns.h - Fix up comments for enqcmds() - Change enqcmds() to reflect instruction return. 0 as success, -EAGAIN for fail. DavidL: - Fix

[PATCH v6 5/5] dmaengine: idxd: Add ABI documentation for shared wq

2020-09-24 Thread Dave Jiang
Add the sysfs attribute bits in ABI/stable for shared wq support. Signed-off-by: Jing Lin Signed-off-by: Dave Jiang Reviewed-by: Tony Luck Reviewed-by: Dan Williams --- Documentation/ABI/stable/sysfs-driver-dma-idxd | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documenta

Re: [PATCH v2 2/3] KVM: VMX: Replace MSR_IA32_RTIT_OUTPUT_BASE_MASK with helper function

2020-09-24 Thread Sean Christopherson
On Wed, Sep 23, 2020 at 07:07:22PM +0200, Paolo Bonzini wrote: > On 23/09/20 18:36, Sean Christopherson wrote: > > +static inline bool pt_output_base_valid(struct kvm_vcpu *vcpu, u64 base) > > +{ > > + /* The base must be 128-byte aligned and a legal physical address. */ > > + return !(base & (

[PATCH v6 1/5] x86/asm: Carve out a generic movdir64b() helper for general usage

2020-09-24 Thread Dave Jiang
The MOVDIR64B instruction can be used by other wrapper instructions. Move the asm code to special_insns.h and have iosubmit_cmds512() call the asm function. Signed-off-by: Dave Jiang Reviewed-by: Tony Luck --- arch/x86/include/asm/io.h| 17 +++-- arch/x86/include/asm/spe

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Gustavo A. R. Silva
On Thu, Sep 24, 2020 at 10:19:08AM -0700, Nick Desaulniers wrote: > Hello maintainers, > Would you mind please picking up this patch? KernelCI has been > erroring for over a week without it. > I can add this to my -next tree and queue it up for the next merge window. Thanks -- Gustavo

Re: [PATCH RFT/RFC 37/49] staging: media: zoran: add fallthrough keyword

2020-09-24 Thread LABBE Corentin
On Mon, Sep 21, 2020 at 01:59:45PM +0300, Dan Carpenter wrote: > On Mon, Sep 21, 2020 at 10:20:12AM +, Corentin Labbe wrote: > > This patch adds fallthrough keyword where appropriate. > > > > Signed-off-by: Corentin Labbe > > --- > > drivers/staging/media/zoran/zoran_device.c | 6 ++ > >

[PATCH] KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgd()

2020-09-24 Thread Sean Christopherson
Explicitly check that kvm_x86_ops.tlb_remote_flush() points at Hyper-V's implementation for PV flushing instead of assuming that a non-NULL implementation means running on Hyper-V. Wrap the related logic in ifdeffery as hv_remote_flush_tlb() is defined iff CONFIG_HYPERV!=n. Short term, the explic

Re: [PATCH v38 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call

2020-09-24 Thread Borislav Petkov
On Tue, Sep 15, 2020 at 02:28:39PM +0300, Jarkko Sakkinen wrote: > diff --git a/arch/x86/entry/vdso/vsgx_enter_enclave.S > b/arch/x86/entry/vdso/vsgx_enter_enclave.S > new file mode 100644 > index ..adbd59d41517 > --- /dev/null > +++ b/arch/x86/entry/vdso/vsgx_enter_enclave.S Why not

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Joe Perches
On Thu, 2020-09-24 at 10:40 -0700, Joe Perches wrote: > On Thu, 2020-09-24 at 10:19 -0700, Nick Desaulniers wrote: > > Hello maintainers, > > Would you mind please picking up this patch? KernelCI has been > > erroring for over a week without it. > > As it's trivial and necessary, why not go throu

Re: [PATCH 1/2] genirq/cpuhotplug: Reduce logging level for couple of prints

2020-09-24 Thread Thomas Gleixner
On Wed, Sep 23 2020 at 17:08, Prasad Sodagudi wrote: > During the cpu hot plug stress testing, couple of messages > continuous flooding on to the console is causing timers > migration delay. Delayed time migrations from hot plugging > core is causing device instability with watchdog. So reduce > lo

Re: [PATCH v3] nfs: remove incorrect fallthrough label

2020-09-24 Thread Anna Schumaker
On Thu, Sep 24, 2020 at 2:08 PM Joe Perches wrote: > > On Thu, 2020-09-24 at 10:40 -0700, Joe Perches wrote: > > On Thu, 2020-09-24 at 10:19 -0700, Nick Desaulniers wrote: > > > Hello maintainers, > > > Would you mind please picking up this patch? KernelCI has been > > > erroring for over a week

Re: [PATCH] modpost: allow modpost to fail on warnings

2020-09-24 Thread Pierre-Louis Bossart
I think [1] should be an error instead of a warning by default. would the following patch be what you have in mind? No. error() does not exist. merror() exists, but the difference from warn() is just a prefix. If any error happens, modpost should return the error code. Sorry, I am not

Re: [PATCH v4 11/23] device-dax: Kill dax_kmem_res

2020-09-24 Thread David Hildenbrand
On 24.09.20 15:54, Dan Williams wrote: > On Thu, Sep 24, 2020 at 12:26 AM David Hildenbrand wrote: >> >> On 23.09.20 23:41, Dan Williams wrote: >>> On Wed, Sep 23, 2020 at 1:04 AM David Hildenbrand wrote: On 08.09.20 17:33, Joao Martins wrote: > [Sorry for the late response] > >

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-24 Thread Jason Gunthorpe
On Thu, Sep 24, 2020 at 01:55:31PM -0400, Peter Xu wrote: > On Thu, Sep 24, 2020 at 01:51:52PM -0300, Jason Gunthorpe wrote: > > > Regarding the solution here, I think we can also cover read-only fast-gup > > > too > > > in the future - IIUC what we need to do is to make it pte_protnone() > > > i

Re: [RFC PATCH 6/9] surface_aggregator: Add dedicated bus and device type

2020-09-24 Thread Maximilian Luz
On 9/24/20 9:12 AM, Greg Kroah-Hartman wrote: On Wed, Sep 23, 2020 at 11:12:49PM +0200, Maximilian Luz wrote: On 9/23/20 7:33 PM, Greg Kroah-Hartman wrote: On Wed, Sep 23, 2020 at 05:15:08PM +0200, Maximilian Luz wrote: [...] Overall, nice work on this patch, the integration to the driver co

Re: [RFC PATCH 1/9] misc: Add Surface Aggregator subsystem

2020-09-24 Thread Maximilian Luz
On 9/24/20 8:48 AM, Greg Kroah-Hartman wrote: On Wed, Sep 23, 2020 at 10:34:23PM +0200, Maximilian Luz wrote: In short: Concurrent execution of the counter functions works, as far as I can tell at least, and, as you see by the long answer, I have to spend some time and think about the duplicate-

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-24 Thread Saeed Mahameed
On Thu, 2020-09-24 at 09:03 -0700, Jakub Kicinski wrote: > On Wed, 23 Sep 2020 22:49:37 -0700 Saeed Mahameed wrote: > > 2) Another problematic scenario which i see is repeated in many > > drivers: > > > > shutdown/suspend() > > rtnl_lock() > > netif_device_detach()//Mark !present; > >

Re: [PATCH 00/10] rpmsg: Make RPMSG name service modular

2020-09-24 Thread Mathieu Poirier
On Thu, Sep 24, 2020 at 08:53:56AM +0200, Guennadi Liakhovetski wrote: > Hi Mathieu, > > Sorry for a delayed response, after I'd sent that my message I've > subscribed to remoteproc and it seems during that transition some > messages were only delivered from the list and not directly to me > or

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-24 Thread Axel Rasmussen
On Thu, Sep 24, 2020 at 10:42 AM Mathieu Desnoyers wrote: > > - On Sep 24, 2020, at 1:09 PM, rostedt rost...@goodmis.org wrote: > > > From: "Steven Rostedt (VMware)" > > > > As tracepoints are discouraged from being added in a header because it can > > cause side effects if other tracepoints

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-24 Thread Thomas Gleixner
On Thu, Sep 24 2020 at 08:33, Greg KH wrote: > On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote: >> +config CONSOLE_FLUSH_ON_HOTPLUG >> +bool "Enable console flush configurable in hot plug code path" >> +depends on HOTPLUG_CPU >> +def_bool n > > n is the default, no need

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-24 Thread Mathieu Desnoyers
- On Sep 24, 2020, at 2:19 PM, Axel Rasmussen axelrasmus...@google.com wrote: > On Thu, Sep 24, 2020 at 10:42 AM Mathieu Desnoyers > wrote: >> >> - On Sep 24, 2020, at 1:09 PM, rostedt rost...@goodmis.org wrote: >> >> > From: "Steven Rostedt (VMware)" >> > >> > As tracepoints are discou

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Randy Dunlap
Hi, On 9/24/20 8:18 AM, Srinivasan Raju wrote: > diff --git a/drivers/staging/purelifi/Kconfig > b/drivers/staging/purelifi/Kconfig > new file mode 100644 > index ..db24bdf884a3 > --- /dev/null > +++ b/drivers/staging/purelifi/Kconfig > @@ -0,0 +1,42 @@ > +config WLAN_VENDOR_PURELIFI

RE: [PATCH v2 4/9] iommu/ioasid: Add reference couting functions

2020-09-24 Thread Shameerali Kolothum Thodi
Hi Jacob, > -Original Message- > From: iommu [mailto:iommu-boun...@lists.linux-foundation.org] On Behalf Of > Jacob Pan > Sent: 22 August 2020 05:35 > To: io...@lists.linux-foundation.org; LKML ; > Jean-Philippe Brucker ; Lu Baolu > ; Joerg Roedel ; David > Woodhouse > Cc: Tian, Kevin ; R

Re: [PATCH v9 3/7] iommu/uapi: Introduce enum type for PASID data format

2020-09-24 Thread Jacob Pan
Hi Joerg, On Thu, 24 Sep 2020 10:40:16 +0200, Joerg Roedel wrote: > > On Fri, 18 Sep 2020 11:44:50 +0200, Joerg Roedel > > wrote: > > > On Fri, Sep 11, 2020 at 02:57:52PM -0700, Jacob Pan wrote: > > > > There can be multiple vendor-specific PASID data formats used in > > > > UAPI structures.

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-24 Thread Steven Rostedt
On Thu, 24 Sep 2020 13:42:25 -0400 (EDT) Mathieu Desnoyers wrote: > > Signed-off-by: Steven Rostedt (VMware) > > --- > > Documentation/trace/tracepoints.rst | 25 ++ > > include/linux/tracepoint-defs.h | 33 + > > 2 files changed, 58 insertions(+

Re: [PATCH v6 1/5] x86/asm: Carve out a generic movdir64b() helper for general usage

2020-09-24 Thread Borislav Petkov
On Thu, Sep 24, 2020 at 11:00:37AM -0700, Dave Jiang wrote: > The MOVDIR64B instruction can be used by other wrapper instructions. Move > the asm code to special_insns.h and have iosubmit_cmds512() call the > asm function. > > Signed-off-by: Dave Jiang > Reviewed-by: Tony Luck Suggested-by: Mic

Re: PATCH reiser4 support for Linux 5.8.10

2020-09-24 Thread Edward Shishkin
On 09/24/2020 07:21 PM, David Niklas wrote: I'm a kernel dev newbie. Please double check my work if in doubt. The patch for reiser4 support for Linux 5.8.1 didn't apply to 5.8.10. It needed only a one line change, but because of all the fuzzy matching and offset matching I thought I'd make a new

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-24 Thread Peter Xu
On Thu, Sep 24, 2020 at 03:15:01PM -0300, Jason Gunthorpe wrote: > On Thu, Sep 24, 2020 at 01:55:31PM -0400, Peter Xu wrote: > > On Thu, Sep 24, 2020 at 01:51:52PM -0300, Jason Gunthorpe wrote: > > > > Regarding the solution here, I think we can also cover read-only > > > > fast-gup too > > > > in

[PATCH] quota: clear padding in v2r1_mem2diskdqb()

2020-09-24 Thread Eric Dumazet
Freshly allocated memory contains garbage, better make sure to init all struct v2r1_disk_dqblk fields to avoid KMSAN report: BUG: KMSAN: uninit-value in qtree_entry_unused+0x137/0x1b0 fs/quota/quota_tree.c:218 CPU: 0 PID: 23373 Comm: syz-executor.1 Not tainted 5.9.0-rc4-syzkaller #0 Hardware name

Re: [RFC PATCH 8/9] surface_aggregator: Add DebugFS interface

2020-09-24 Thread Maximilian Luz
On 9/24/20 8:46 AM, Greg Kroah-Hartman wrote: On Thu, Sep 24, 2020 at 12:06:54AM +0200, Maximilian Luz wrote: On 9/23/20 8:29 PM, Greg Kroah-Hartman wrote: On Wed, Sep 23, 2020 at 08:03:38PM +0200, Maximilian Luz wrote: On 9/23/20 6:14 PM, Greg Kroah-Hartman wrote: [...] So the -EFAULT ret

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-24 Thread Jason Gunthorpe
On Thu, Sep 24, 2020 at 02:34:18PM -0400, Peter Xu wrote: > > >// RDONLY gup > > >pin_user_pages(buf, !WRITE); > > >// pte of buf duplicated on both sides > > >fork(); > > >mprotect(buf, WRITE); > > >*buf = 1; > > >// buf page replaced as cow

[PATCH v2 2/2] KVM: VMX: Do not perform emulation for INVD intercept

2020-09-24 Thread Tom Lendacky
From: Tom Lendacky The INVD instruction is emulated as a NOP, just skip the instruction instead. Signed-off-by: Tom Lendacky --- arch/x86/kvm/vmx/vmx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 8646a797b7a8..f807

[PATCH v2 0/2] INVD intercept change to skip instruction

2020-09-24 Thread Tom Lendacky
From: Tom Lendacky This series updates the INVD intercept support for both SVM and VMX to skip the instruction rather than emulating it, since emulation of this instruction is just a NOP. For SVM, it requires creating a dedicated INVD intercept routine that invokes kvm_skip_emulated_instruction(

[PATCH v2 1/2] KVM: SVM: Add a dedicated INVD intercept routine

2020-09-24 Thread Tom Lendacky
From: Tom Lendacky The INVD instruction intercept performs emulation. Emulation can't be done on an SEV guest because the guest memory is encrypted. Provide a dedicated intercept routine for the INVD intercept. And since the instruction is emulated as a NOP, just skip it instead. Fixes: 1654efc

Re: [RFC PATCH 8/9] surface_aggregator: Add DebugFS interface

2020-09-24 Thread Maximilian Luz
On 9/24/20 9:41 AM, Arnd Bergmann wrote: On Thu, Sep 24, 2020 at 12:23 AM Maximilian Luz wrote: On 9/23/20 8:51 PM, Arnd Bergmann wrote: On Wed, Sep 23, 2020 at 8:29 PM Maximilian Luz wrote: On 9/23/20 6:48 PM, Arnd Bergmann wrote: The version I showed avoids the pointers and is compatible

Re: [PATCH 5/5] mm/thp: Split huge pmds/puds if they're pinned when fork()

2020-09-24 Thread Peter Xu
On Wed, Sep 23, 2020 at 01:19:08PM -0700, John Hubbard wrote: > On 9/23/20 8:44 AM, Peter Xu wrote: > > On Wed, Sep 23, 2020 at 04:01:14PM +0200, Jan Kara wrote: > > > On Wed 23-09-20 09:50:04, Peter Xu wrote: > ... > > > > > But the problem is that if you apply mm->has_pinned check on file > > >

Re: [PATCH v1 0/6] seccomp: Implement constant action bitmaps

2020-09-24 Thread Andrea Arcangeli
Hello, I'm posting this only for the record, feel free to ignore. On Wed, Sep 23, 2020 at 04:29:17PM -0700, Kees Cook wrote: > rfc: > https://lore.kernel.org/lkml/20200616074934.1600036-1-keesc...@chromium.org/ > alternative: > https://lore.kernel.org/containers/cover.1600661418.git.yifei...@il

Re: [PATCH v6 2/5] x86/asm: Add enqcmds() to support ENQCMDS instruction

2020-09-24 Thread Borislav Petkov
On Thu, Sep 24, 2020 at 11:00:38AM -0700, Dave Jiang wrote: > +/** > + * enqcmds - copy a 512 bits data unit to single MMIO location You forgot to fix this. > + * @dst: destination, in MMIO space (must be 512-bit aligned) > + * @src: source > + * > + * The ENQCMDS instruction allows software to w

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

2020-09-24 Thread Steven Rostedt
On Thu, 24 Sep 2020 19:55:10 +0200 Thomas Gleixner wrote: > On Thu, Sep 24 2020 at 08:32, Steven Rostedt wrote: > > On Thu, 24 Sep 2020 08:57:52 +0200 > > Thomas Gleixner wrote: > > > >> > Now as for migration disabled nesting, at least now we would have > >> > groupings of this, and perhaps t

Re: [RFC PATCH 0/9] Add support for Microsoft Surface System Aggregator Module

2020-09-24 Thread Maximilian Luz
On 9/24/20 10:26 AM, Arnd Bergmann wrote: On Thu, Sep 24, 2020 at 1:28 AM Maximilian Luz wrote: On 9/23/20 9:43 PM, Arnd Bergmann wrote: On Wed, Sep 23, 2020 at 5:43 PM Maximilian Luz wrote: On 9/23/20 5:30 PM, Arnd Bergmann wrote: On Wed, Sep 23, 2020 at 5:15 PM Maximilian Luz wrote: H

Re: [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl"

2020-09-24 Thread Tom Rix
On 9/24/20 9:59 AM, Xu Yilun wrote: > Now the DFL device drivers could be made as independent modules and put > in different subsystems according to their functionalities. So the name > should be descriptive and unique in the whole kernel. > > The patch changes the naming of dfl bus related struc

Re: [PATCH net-next RFC v5 01/15] devlink: Add reload action option to devlink reload command

2020-09-24 Thread Moshe Shemesh
On 9/23/2020 9:25 PM, Jakub Kicinski wrote: On Fri, 18 Sep 2020 19:06:37 +0300 Moshe Shemesh wrote: Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward compatib

Re: [PATCH v5 2/3] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

2020-09-24 Thread Dan Williams
On Tue, Sep 1, 2020 at 1:33 AM Roger Pau Monne wrote: > > This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also > being used by non DAX devices. > FWIW I would not call this MEMORY_DEVICE_GENERIC. This is really MEMORY_DEVICE_SIMPLE and the kernel-doc can clarify in contrast to th

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-24 Thread Mathieu Desnoyers
- On Sep 24, 2020, at 2:30 PM, rostedt rost...@goodmis.org wrote: > On Thu, 24 Sep 2020 13:42:25 -0400 (EDT) > Mathieu Desnoyers wrote: > >> > Signed-off-by: Steven Rostedt (VMware) >> > --- >> > Documentation/trace/tracepoints.rst | 25 ++ >> > include/linux/tracepoin

Re: [PATCH V2 1/3] efi: Support for MOK variable config table

2020-09-24 Thread Lenny Szubowicz
On 9/21/20 12:55 PM, Arvind Sankar wrote: On Mon, Sep 21, 2020 at 06:27:17PM +0200, Ard Biesheuvel wrote: On Mon, 21 Sep 2020 at 18:19, Arvind Sankar wrote: On Fri, Sep 04, 2020 at 09:31:05PM -0400, Lenny Szubowicz wrote: + /* + * The EFI MOK config table must fit within a single EF

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Dan Carpenter
On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > + > +#include > +#include > + > +#include "def.h" > +#include "chip.h" > +#include "mac.h" > +#include "usb.h" > +#include "log.h" > + > +void purelifi_chip_init(struct purelifi_chip *chip, > + struct ieee80211

Re: [PATCH v38 10/24] mm: Add vm_ops->mprotect()

2020-09-24 Thread Haitao Huang
On Wed, 23 Sep 2020 08:50:56 -0500, Jarkko Sakkinen wrote: On Tue, Sep 22, 2020 at 09:43:02AM -0700, Sean Christopherson wrote: On Tue, Sep 22, 2020 at 08:35:15AM +0300, Jarkko Sakkinen wrote: > On Tue, Sep 22, 2020 at 08:30:06AM +0300, Jarkko Sakkinen wrote: > > On Mon, Sep 21, 2020 at 02:1

Re: [PATCH v2 seccomp 1/6] seccomp: Move config option SECCOMP to arch/Kconfig

2020-09-24 Thread Kees Cook
On Thu, 24 Sep 2020 07:44:15 -0500, YiFei Zhu wrote: > In order to make adding configurable features into seccomp > easier, it's better to have the options at one single location, > considering easpecially that the bulk of seccomp code is > arch-independent. An quick look also show that many SECCOM

Re: [RFC PATCH 0/9] Add support for Microsoft Surface System Aggregator Module

2020-09-24 Thread Maximilian Luz
On 9/24/20 10:30 AM, Andy Shevchenko wrote: On Wed, Sep 23, 2020 at 6:32 PM Arnd Bergmann wrote: On Wed, Sep 23, 2020 at 5:15 PM Maximilian Luz wrote: Hello, The Surface System Aggregator Module (we'll refer to it as Surface Aggregator or SAM below) is an embedded controller (EC) found on

Re: [PATCH v1 0/6] seccomp: Implement constant action bitmaps

2020-09-24 Thread Jann Horn
On Thu, Sep 24, 2020 at 8:57 PM Andrea Arcangeli wrote: > > Hello, > > I'm posting this only for the record, feel free to ignore. > > On Wed, Sep 23, 2020 at 04:29:17PM -0700, Kees Cook wrote: > > rfc: > > https://lore.kernel.org/lkml/20200616074934.1600036-1-keesc...@chromium.org/ > > alternativ

[PATCH v11 1/6] docs: IOMMU user API

2020-09-24 Thread Jacob Pan
IOMMU UAPI is newly introduced to support communications between guest virtual IOMMU and host IOMMU. There has been lots of discussions on how it should work with VFIO UAPI and userspace in general. This document is intended to clarify the UAPI design and usage. The mechanics of how future extensi

[PATCH v11 3/6] iommu/uapi: Use named union for user data

2020-09-24 Thread Jacob Pan
IOMMU UAPI data size is filled by the user space which must be validated by the kernel. To ensure backward compatibility, user data can only be extended by either re-purpose padding bytes or extend the variable sized union at the end. No size change is allowed before the union. Therefore, the minim

[PATCH v11 2/6] iommu/uapi: Add argsz for user filled data

2020-09-24 Thread Jacob Pan
As IOMMU UAPI gets extended, user data size may increase. To support backward compatibiliy, this patch introduces a size field to each UAPI data structures. It is *always* the responsibility for the user to fill in the correct size. Padding fields are adjusted to ensure 8 byte alignment. Specific

[PATCH v11 0/6] IOMMU user API enhancement

2020-09-24 Thread Jacob Pan
IOMMU user API header was introduced to support nested DMA translation and related fault handling. The current UAPI data structures consist of three areas that cover the interactions between host kernel and guest: - fault handling - cache invalidation - bind guest page tables, i.e. guest PASID

[PATCH v11 4/6] iommu/uapi: Rename uapi functions

2020-09-24 Thread Jacob Pan
User APIs such as iommu_sva_unbind_gpasid() may also be used by the kernel. Since we introduced user pointer to the UAPI functions, in-kernel callers cannot share the same APIs. In-kernel callers are also trusted, there is no need to validate the data. We plan to have two flavors of the same API f

[PATCH v11 5/6] iommu/uapi: Handle data and argsz filled by users

2020-09-24 Thread Jacob Pan
IOMMU user APIs are responsible for processing user data. This patch changes the interface such that user pointers can be passed into IOMMU code directly. Separate kernel APIs without user pointers are introduced for in-kernel users of the UAPI functionality. IOMMU UAPI data has a user filled args

[PATCH v11 6/6] iommu/vt-d: Check UAPI data processed by IOMMU core

2020-09-24 Thread Jacob Pan
IOMMU generic layer already does sanity checks on UAPI data for version match and argsz range based on generic information. This patch adjusts the following data checking responsibilities: - removes the redundant version check from VT-d driver - removes the check for vendor specific data size - ad

Re: [PATCH v2] mm/hmm/test: use after free in dmirror_allocate_chunk()

2020-09-24 Thread Ralph Campbell
On 9/24/20 6:46 AM, Dan Carpenter wrote: The error handling code does this: err_free: kfree(devmem); ^ err_release: release_mem_region(devmem->pagemap.range.start, range_len(&devmem->pagemap.range)); The problem is that

[PATCH v3 0/7] Netronix embedded controller driver for Kobo and Tolino ebook readers

2020-09-24 Thread Jonathan Neuschäfer
This patchset adds basic support for the embedded controller found on older ebook reader boards designed by/with the ODM Netronix Inc.[1] and sold by Kobo or Tolino, for example the Kobo Aura and the Tolino Shine. These drivers are based on information contained in the vendor kernel sources, but in

[PATCH v3 2/7] dt-bindings: mfd: Add binding for Netronix embedded controller

2020-09-24 Thread Jonathan Neuschäfer
This EC is found in e-book readers of multiple brands (e.g. Kobo, Tolino), and is typically implemented as a TI MSP430 microcontroller. It controls different functions of the system, such as power on/off, RTC, PWM for the backlight. The exact functionality provided can vary between boards. Signed

[PATCH v3 1/7] dt-bindings: Add vendor prefix for Netronix, Inc.

2020-09-24 Thread Jonathan Neuschäfer
Netronix, Inc. (http://www.netronixinc.com/) makes ebook reader board designs, which are for example used in Kobo and Tolino devices. An alternative prefix for Netronix would be "ntx", which is already used in code released by Netronix. It is shorter, but perhaps less clear. Signed-off-by: Jonath

[PATCH v3 3/7] mfd: Add base driver for Netronix embedded controller

2020-09-24 Thread Jonathan Neuschäfer
The Netronix embedded controller is a microcontroller found in some e-book readers designed by the ODM Netronix, Inc. It contains RTC, battery monitoring, system power management, and PWM functionality. This driver implements register access and version detection. Third-party hardware documentati

[PATCH v2 4/4] mm: convert page kmemcg type to a page memcg flag

2020-09-24 Thread Roman Gushchin
PageKmemcg flag is currently defined as a page type (like buddy, offline, table and guard). Semantically it means that the page was accounted as a kernel memory by the page allocator and has to be uncharged on the release. As a side effect of defining the flag as a page type, the accounted page ca

[PATCH v2 1/4] mm: memcontrol: use helpers to access page's memcg data

2020-09-24 Thread Roman Gushchin
Currently there are many open-coded reads and writes of the page->mem_cgroup pointer, as well as a couple of read helpers, which are barely used. It creates an obstacle on a way to reuse some bits of the pointer for storing additional bits of information. In fact, we already do this for slab pages

[PATCH v3 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2020-09-24 Thread Jonathan Neuschäfer
The Netronix EC provides a PWM output which is used for the backlight on some ebook readers. This patches adds a driver for the PWM output. The .get_state callback is not implemented, because the PWM state can't be read back from the hardware. Signed-off-by: Jonathan Neuschäfer --- v3: - Relice

[PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-09-24 Thread Jonathan Neuschäfer
With this driver, mainline Linux can keep its time and date in sync with the vendor kernel. Advanced functionality like alarm and automatic power-on is not yet supported. Signed-off-by: Jonathan Neuschäfer --- v3: - Add email address to copyright line - Remove OF compatible string and don't inc

[PATCH v3 6/7] MAINTAINERS: Add entry for Netronix embedded controller

2020-09-24 Thread Jonathan Neuschäfer
Let's make sure I'll notice when there are patches for the NTXEC drivers. Signed-off-by: Jonathan Neuschäfer --- v3: - Remove pwm and rtc bindings v2: - https://lore.kernel.org/lkml/20200905144503.1067124-2-j.neuschae...@gmx.net/ - No changes --- MAINTAINERS | 9 + 1 file changed, 9 ins

Re: [PATCH v38 10/24] mm: Add vm_ops->mprotect()

2020-09-24 Thread Sean Christopherson
On Thu, Sep 24, 2020 at 02:11:37PM -0500, Haitao Huang wrote: > On Wed, 23 Sep 2020 08:50:56 -0500, Jarkko Sakkinen > wrote: > >I'll categorically deny noexec in the next patch set version. > > > >/Jarkko > > There are use cases supported currently in which enclave binary is received > via IPC/RP

[PATCH v2 2/4] mm: memcontrol/slab: use helpers to access slab page's memcg_data

2020-09-24 Thread Roman Gushchin
To gather all direct accesses to struct page's memcg_data field in one place, let's introduce 4 new helper functions to use in the slab accounting code: struct obj_cgroup **page_obj_cgroups(struct page *page); struct obj_cgroup **page_obj_cgroups_check(struct page *page); bool set_page_obj_cg

[PATCH v2 3/4] mm: introduce page memcg flags

2020-09-24 Thread Roman Gushchin
The lowest bit in page->memcg_data is used to distinguish between struct memory_cgroup pointer and a pointer to a objcgs array. All checks and modifications of this bit are open-coded. Let's formalize it using page memcg flags, defined in page_memcg_flags enum, and replace all open-coded accesses

Re: [PATCH net-next RFC v5 02/15] devlink: Add reload action limit level

2020-09-24 Thread Moshe Shemesh
On 9/23/2020 9:36 PM, Jakub Kicinski wrote: On Fri, 18 Sep 2020 19:06:38 +0300 Moshe Shemesh wrote: Add reload action limit level to demand restrictions on actions. Reload action limit levels supported: none (default): No constrains on actions. Driver implementation may includ

[PATCH v2 0/4] mm: allow mapping accounted kernel pages to userspace

2020-09-24 Thread Roman Gushchin
Currently a non-slab kernel page which has been charged to a memory cgroup can't be mapped to userspace. The underlying reason is simple: PageKmemcg flag is defined as a page type (like buddy, offline, etc), so it takes a bit from a page->mapped counter. Pages with a type set can't be mapped to use

Re: [PATCH net-next RFC v5 03/15] devlink: Add reload action stats

2020-09-24 Thread Moshe Shemesh
On 9/23/2020 9:42 PM, Jakub Kicinski wrote: External email: Use caution opening links or attachments On Fri, 18 Sep 2020 19:06:39 +0300 Moshe Shemesh wrote: Add reload action stats to hold the history per reload action type and limit level. For example, the number of times fw_activate has b

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-24 Thread Steven Rostedt
On Thu, 24 Sep 2020 15:08:30 -0400 (EDT) Mathieu Desnoyers wrote: > - On Sep 24, 2020, at 2:30 PM, rostedt rost...@goodmis.org wrote: > > > On Thu, 24 Sep 2020 13:42:25 -0400 (EDT) > > Mathieu Desnoyers wrote: > > > >> > Signed-off-by: Steven Rostedt (VMware) > >> > --- > >> > Documenta

Re: [PATCH net-next RFC v5 04/15] devlink: Add reload actions stats to dev get

2020-09-24 Thread Moshe Shemesh
On 9/23/2020 9:50 PM, Jakub Kicinski wrote: On Fri, 18 Sep 2020 19:06:40 +0300 Moshe Shemesh wrote: Expose devlink reload actions stats to the user through devlink dev get command. Examples: $ devlink dev show pci/:82:00.0: stats: reload_action_stats: driver_reinit 2

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

2020-09-24 Thread Daniel Bristot de Oliveira
On 9/24/20 10:27 AM, pet...@infradead.org wrote: > So my current todo list is: > > - Change RT PULL > - Change DL PULL > - Add migrate_disable() tracer; exactly like preempt/irqoff, except >measuring task-runtime instead of cpu-time. > - Add a mode that measures actual interference. > - A

Re: [RFC PATCH 0/9] Add support for Microsoft Surface System Aggregator Module

2020-09-24 Thread Arnd Bergmann
On Thu, Sep 24, 2020 at 8:59 PM Maximilian Luz wrote: > On 9/24/20 10:26 AM, Arnd Bergmann wrote: > > On Thu, Sep 24, 2020 at 1:28 AM Maximilian Luz > > wrote: > > Note that drivers that connect to the bus typically don't live in the > > same subdirectory as the driver that operates the bus. E.

Re: [PATCH v38 10/24] mm: Add vm_ops->mprotect()

2020-09-24 Thread Dave Hansen
On 9/24/20 12:28 PM, Sean Christopherson wrote: > On Thu, Sep 24, 2020 at 02:11:37PM -0500, Haitao Huang wrote: >> On Wed, 23 Sep 2020 08:50:56 -0500, Jarkko Sakkinen >> wrote: >>> I'll categorically deny noexec in the next patch set version. >>> >>> /Jarkko >> There are use cases supported curren

Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header

2020-09-24 Thread Steven Rostedt
On Thu, 24 Sep 2020 15:35:17 -0400 Steven Rostedt wrote: > > I'm ok with tracepoint_enabled(). However, I would have placed it in > > tracepoint.h rather than tracepoint-defs.h, and we should figure out > > why people complain that tracepoint.h is including headers too > > eagerly. > > I could

[PATCH v3 1/5] KVM: VMX: Use precomputed MAXPHYADDR for RTIT base MSR check

2020-09-24 Thread Sean Christopherson
Use cpuid_maxphyaddr() instead of cpuid_query_maxphyaddr() for the RTIT base MSR check. There is no reason to recompute MAXPHYADDR as the precomputed version is synchronized with CPUID updates, and MSR_IA32_RTIT_OUTPUT_BASE is not written between stuffing CPUID and refreshing vcpu->arch.maxphyaddr

[PATCH v3 3/5] KVM: VMX: Replace MSR_IA32_RTIT_OUTPUT_BASE_MASK with helper function

2020-09-24 Thread Sean Christopherson
Replace the subtly not-a-constant MSR_IA32_RTIT_OUTPUT_BASE_MASK with a proper helper function to check whether or not the specified base is valid. Blindly referencing the local 'vcpu' is especially nasty. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 11 +++ 1 file ch

[PATCH v3 2/5] KVM: x86: Unexport cpuid_query_maxphyaddr()

2020-09-24 Thread Sean Christopherson
Stop exporting cpuid_query_maxphyaddr() now that it's not being abused by VMX. Signed-off-by: Sean Christopherson --- arch/x86/kvm/cpuid.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 3fd6eec202d7..dc95b638911e 100644 --- a/arch/x86/kvm/cpu

<    5   6   7   8   9   10   11   12   13   14   >