Re: NVFS XFS metadata (was: [PATCH] pmem: export the symbols __copy_user_flushcache and __copy_from_user_flushcache)

2020-09-24 Thread Mikulas Patocka
On Tue, 22 Sep 2020, Matthew Wilcox wrote: > > > The NVFS indirect block tree has a fan-out of 16, > > > > No. The top level in the inode contains 16 blocks (11 direct and 5 > > indirect). And each indirect block can have 512 pointers (4096/8). You can > > format the device with larger block

[PATCH 02/13] x86: Secure Launch main header file

2020-09-24 Thread Ross Philipson
Introduce the main Secure Launch header file used in the early SL stub and the early setup code. Signed-off-by: Ross Philipson --- include/linux/slaunch.h | 544 1 file changed, 544 insertions(+) create mode 100644 include/linux/slaunch.h diff -

[PATCH 08/13] x86: Secure Launch kernel late boot stub

2020-09-24 Thread Ross Philipson
The routine slaunch_setup is called out of the x86 specific setup_arch routine during early kernel boot. After determining what platform is present, various operations specific to that platform occur. This includes finalizing setting for the platform late launch and verifying that memory protection

Re: [RFC PATCH 1/3] sched: fix exit_mm vs membarrier (v2)

2020-09-24 Thread Mathieu Desnoyers
- On Aug 16, 2020, at 11:23 AM, Boqun Feng boqun.f...@gmail.com wrote: > Hi Mathieu, > > On Fri, Aug 14, 2020 at 12:43:56PM -0400, Mathieu Desnoyers wrote: >> exit_mm should issue memory barriers after user-space memory accesses, >> before clearing current->mm, to order user-space memory acce

[PATCH 00/13] x86: Trenchboot secure dynamic launch Linux kernel support

2020-09-24 Thread Ross Philipson
The Trenchboot project focus on boot security has led to the enabling of the Linux kernel to be directly invocable by the x86 Dynamic Launch instruction(s) for establishing a Dynamic Root of Trust for Measurement (DRTM). The dynamic launch will be initiated by a boot loader with associated support

Re: [PATCH 07/13] block: lift setting the readahead size into the block layer

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 2:51am -0400, Christoph Hellwig wrote: > Drivers shouldn't really mess with the readahead size, as that is a VM > concept. Instead set it based on the optimal I/O size by lifting the > algorithm from the md driver when registering the disk. Also set > bdi->io_pages there

[PATCH v1 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator

2020-09-24 Thread cy_huang
From: ChiYuan Huang Add support for Richtek RTMV20 load switch regulator. Signed-off-by: ChiYuan Huang --- drivers/regulator/Kconfig| 9 + drivers/regulator/Makefile | 1 + drivers/regulator/rtmv20-regulator.c | 512 +++ 3 files changed

[PATCH v1 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20

2020-09-24 Thread cy_huang
From: ChiYuan Huang Add DT-binding document for Richtek RTMV20 Signed-off-by: ChiYuan Huang --- .../regulator/richtek,rtmv20-regulator.yaml| 183 + 1 file changed, 183 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtmv20-regu

Re: [PATCH] latency improvement in __smp_call_single_queue

2020-09-24 Thread George Prekas
On 9/24/2020 3:42 AM, pet...@infradead.org wrote: > On Wed, Sep 23, 2020 at 10:00:41AM -0500, George Prekas wrote: >> If an interrupt arrives between llist_add and >> send_call_function_single_ipi in the following code snippet, then the >> remote CPU will not receive the IPI in a timely manner and

Re: [PATCH v5 1/5] x86/asm: Carve out a generic movdir64b() helper for general usage

2020-09-24 Thread Dave Jiang
On 9/24/2020 6:07 AM, Borislav Petkov wrote: On Wed, Sep 23, 2020 at 04:10:43PM -0700, Dave Jiang wrote: +/* The dst parameter must be 64-bytes aligned */ +static inline void movdir64b(void *dst, const void *src) +{ + /* +* Note that this isn't an "on-stack copy", just definitio

Re: [PATCH] mm: swapfile: avoid split_swap_cluster() NULL pointer dereference

2020-09-24 Thread Rafael Aquini
On Thu, Sep 24, 2020 at 03:45:52PM +0800, Huang, Ying wrote: > Rafael Aquini writes: > > > On Thu, Sep 24, 2020 at 11:51:17AM +0800, Huang, Ying wrote: > >> Rafael Aquini writes: > >> > The bug here is quite simple: split_swap_cluster() misses checking for > >> > lock_cluster() returning NULL be

Re: [RFC PATCH 05/11] drivers/acpi: convert seqno counter_atomic

2020-09-24 Thread Shuah Khan
On 9/24/20 5:13 AM, Rafael J. Wysocki wrote: On Wed, Sep 23, 2020 at 3:44 AM Shuah Khan wrote: counter_atomic is introduced to be used when a variable is used as a simple counter and doesn't guard object lifetimes. This clearly differentiates atomic_t usages that guard object lifetimes. count

Re: [PATCH 4/5] mm: Do early cow for pinned pages during fork() for ptes

2020-09-24 Thread Peter Xu
On Wed, Sep 23, 2020 at 01:25:52PM -0700, Linus Torvalds wrote: > IOW, the third patch would be something (COMPLETELY UNTESTED) like the > attached. Thanks. I'll rework on top. -- Peter Xu

Re: [PATCH] PCI: dwc: Move allocate and map page for msi out of dw_pcie_msi_init()

2020-09-24 Thread Rob Herring
On Thu, Sep 24, 2020 at 8:33 AM Ard Biesheuvel wrote: > > On Thu, 24 Sep 2020 at 15:45, Ard Biesheuvel wrote: > > > > On Thu, 24 Sep 2020 at 15:28, Rob Herring wrote: > > > > > > On Thu, Sep 24, 2020 at 5:00 AM Ard Biesheuvel wrote: > > > > > > > > On Wed, 23 Sep 2020 at 08:28, Jisheng Zhang >

[PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
We are seeing the following error after S3 resume: [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 [ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete [ 704.902817] e1000e :00:1f.6 eno1: Setting page 0x6020 [ 704.903075] e1000e :00:1f.6 eno1: reading PHY page

Re: [PATCH] PCI: aardvark: Update comment about disabling link training

2020-09-24 Thread Bjorn Helgaas
On Thu, Sep 24, 2020 at 10:46:18AM +0200, Pali Rohár wrote: > It is not HW bug or workaround for some cards but it is requirement by PCI > Express spec. After fundamental reset is needed 100ms delay prior enabling > link training. So update comment in code to reflect this requirement. > > Signed-o

[PATCH] hv: clocksource: Add notrace attribute to read_hv_sched_clock_*() functions

2020-09-24 Thread Mohammed Gamal
When selecting function_graph tracer with the command: # echo function_graph > /sys/kernel/debug/tracing/current_tracer The kernel crashes with the following stack trace: [69703.122389] BUG: stack guard page was hit at 1056545c (stack is fa3f8fed..05d39503) [69703.122403

Re: [PATCH] lockdep: Optimize the memory usage of circular queue

2020-09-24 Thread Boqun Feng
Ping ;-) Regards, Boqun On Thu, Sep 17, 2020 at 04:01:50PM +0800, Boqun Feng wrote: > Qian Cai reported a BFS_EQUEUEFULL warning [1] after read recursive > deadlock detection merged into tip tree recently. Unlike the previous > lockep graph searching, which iterate every lock class (every node in

[PATCH 0/2] Enable runtime PM for SOF device

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta This enables runtime PM for SOF device. Next patchseries will provide PM suspend/resume handlers for i.MX8 specific devices. Daniel Baluta (2): ASoC: SOF: Activate runtime PM with SOF OF device ASoC: SOF: Add .prepare/.complete callbacks sound/soc/sof/sof-of-dev.c | 6 +

[PATCH 2/2] ASoC: SOF: Add .prepare/.complete callbacks

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta Use SOF defined callbacks (snd_sof_prepare/snd_sof_complete) in order to update internal SOF system suspend target. Reviewed-by: Kai Vehmanen Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Daniel Baluta --- sound/soc/sof/sof-of-dev.c | 2 ++ 1 f

[PATCH 1/2] ASoC: SOF: Activate runtime PM with SOF OF device

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta SOF boots the DSP at probe and keeps it up all the time. With this change, after booting if no one is using the DSP the SOF core will turn off the DSP to save power. Reviewed-by: Kai Vehmanen Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Daniel B

Re: [RFC-PATCH 2/4] mm: Add __rcu_alloc_page_lockless() func.

2020-09-24 Thread Uladzislau Rezki
On Thu, Sep 24, 2020 at 01:16:32PM +0200, Peter Zijlstra wrote: > On Thu, Sep 24, 2020 at 10:16:14AM +0200, Uladzislau Rezki wrote: > > Other option is if we had unconditionally enabled PREEMPT_COUNT config. > > It would be easy to identify a context type and invoke a page allocator > > if a contex

Re: [PATCH 4/5] mm: Do early cow for pinned pages during fork() for ptes

2020-09-24 Thread Peter Xu
On Thu, Sep 24, 2020 at 02:48:00PM +0300, Kirill Tkhai wrote: > > +/* > > + * Duplicate the page for this PTE. Returns zero if page copied (so we > > need to > > + * retry on the same PTE again to arm the copied page very soon), or > > negative > > + * if error happened. In all cases, the old p

Re: [PATCH] KVM: SVM: Use a separate vmcb for the nested L2 guest

2020-09-24 Thread Maxim Levitsky
On Thu, 2020-09-17 at 15:23 -0400, Cathy Avery wrote: > svm->vmcb will now point to either a separate vmcb L1 ( not nested ) or L2 > vmcb ( nested ). > > Issues: > > 1) There is some wholesale copying of vmcb.save and vmcb.contol >areas which will need to be refined. > > 2) There is a worka

[PATCH v5 0/2] perf: Make tsc testing as a common testing case

2020-09-24 Thread Leo Yan
This patch set is to follow up the building failure which was found by Arnaldo: CC /tmp/build/perf/tests/llvm-src-prologue.o CC /tmp/build/perf/tests/llvm-src-relocation.o tests/perf-time-to-tsc.c:24:10: fatal error: arch-tests.h: No such file or directory 24 | #inc

[PATCH v5 1/2] perf tests tsc: Make tsc testing as a common testing

2020-09-24 Thread Leo Yan
x86 arch provides the testing for conversion between tsc and perf time, the testing is located in x86 arch folder. Move this testing out from x86 arch folder and place it into the common testing folder, so allows to execute tsc testing on other architectures (e.g. Arm64). This patch removes the i

[PATCH v5 2/2] perf tests tsc: Add checking helper is_supported()

2020-09-24 Thread Leo Yan
So far tsc is enabled on x86_64, i386 and Arm64 architectures, add checking helper to skip this testing for other architectures. Signed-off-by: Leo Yan --- tools/perf/tests/builtin-test.c | 1 + tools/perf/tests/perf-time-to-tsc.c | 13 + tools/perf/tests/tests.h| 1

Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL

2020-09-24 Thread Sekhar Nori
Hi Necip, On 14/09/20 6:08 PM, Necip Fazil Yildiran wrote: > When ARCH_DAVINCI is enabled and PINCTRL is disabled, it results > in the following Kbuild warning: > > WARNING: unmet direct dependencies detected for PINCTRL_SINGLE > Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y] > Sel

Re: [RFC-PATCH 2/4] mm: Add __rcu_alloc_page_lockless() func.

2020-09-24 Thread Uladzislau Rezki
On Thu, Sep 24, 2020 at 01:19:07PM +0200, Peter Zijlstra wrote: > On Thu, Sep 24, 2020 at 10:16:14AM +0200, Uladzislau Rezki wrote: > > The key point is "enough". We need pages to make a) fast progress b) support > > single argument of kvfree_rcu(one_arg). Not vice versa. That "enough" > > depends

[PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Srinivasan Raju
From: Srini This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices, which provide lightweight, highspeed secure and fully networked wireless communications via light. This driver implementation has been based on the zd1211rw driver Driver is based on 802.11 softMAC

Re: [PATCH] PCI: aardvark: Update comment about disabling link training

2020-09-24 Thread Pali Rohár
On Thursday 24 September 2020 10:11:06 Bjorn Helgaas wrote: > On Thu, Sep 24, 2020 at 10:46:18AM +0200, Pali Rohár wrote: > > It is not HW bug or workaround for some cards but it is requirement by PCI > > Express spec. After fundamental reset is needed 100ms delay prior enabling > > link training.

Re: [PATCH 0/3] drm: commit_work scheduling

2020-09-24 Thread Rob Clark
On Thu, Sep 24, 2020 at 1:49 AM Daniel Vetter wrote: > > On Wed, Sep 23, 2020 at 07:33:17PM -0700, Rob Clark wrote: > > On Wed, Sep 23, 2020 at 8:25 AM Daniel Vetter wrote: > > > > > > On Tue, Sep 22, 2020 at 07:48:10AM -0700, Rob Clark wrote: > > > > On Mon, Sep 21, 2020 at 11:59 PM Daniel Vette

Re: [RESEND PATCHv1] MAINTAINERS: altera: change maintainer for Altera drivers

2020-09-24 Thread Richard Gong
Hi, Sorry for asking. This patch was submitted on July and is pending for approval. Would you mind reviewing that? Regards, Richard On 7/24/20 10:59 AM, richard.g...@linux.intel.com wrote: From: Richard Gong Thor is moving to a new position and I will take over the maintainership. Add mys

Re: [RFC PATCH 2/3] sched: membarrier: cover kthread_use_mm (v2)

2020-09-24 Thread Mathieu Desnoyers
- On Aug 24, 2020, at 10:06 PM, Boqun Feng boqun.f...@gmail.com wrote: > On Mon, Aug 24, 2020 at 11:27:49AM -0400, Mathieu Desnoyers wrote: >> - On Aug 16, 2020, at 11:29 AM, Boqun Feng boqun.f...@gmail.com wrote: >> >> > On Fri, Aug 14, 2020 at 12:43:57PM -0400, Mathieu Desnoyers wrote:

Re: [PATCH v3 2/2] USB: misc: Add onboard_usb_hub driver

2020-09-24 Thread Alan Stern
On Wed, Sep 23, 2020 at 06:10:12PM -0700, Matthias Kaehlcke wrote: > The main issue this driver addresses is that a USB hub needs to be > powered before it can be discovered. For discrete onboard hubs (an > example for such a hub is the Realtek RTS5411) this is often solved > by supplying the hub w

[PATCH 1/3] spi: spi-mtk-nor: make use of full capability of prg mode

2020-09-24 Thread Chuanhong Guo
"program" mode on this controller can trigger up to 56 bits of data shifting. During the operation, data in PRGDATA[0-5] will be shifted out from MOSI, and data from MISO will be continuously filling SHREG[0-9]. Currently this mode is used to implement transfer_one_message for 6-byte full-duplex tr

[PATCH 0/3] spi: spi-mtk-nor: make use of full capability of program mode

2020-09-24 Thread Chuanhong Guo
"program" mode on this controller can trigger up to 56 bits of data shifting. During the operation, data in PRGDATA[0-5] will be shifted out from MOSI, and data from MISO will be continuously filling SHREG[0-9]. Currently this mode is used to implement transfer_one_message for 6-byte full-duplex tr

[PATCH 3/3] spi: spi-mtk-nor: fix op checks in supports_op

2020-09-24 Thread Chuanhong Guo
commit a59b2c7c56bf7 ("spi: spi-mtk-nor: support standard spi properties") tries to inverse the logic of supports_op when adding spi_mem_default_supports_op check, but it didn't get it done properly. There are two regressions introduced by this commit: 1. reading ops supported by program mode is re

[PATCH 2/3] spi: spi-mtk-nor: add helper for checking prg mode ops

2020-09-24 Thread Chuanhong Guo
op checking/resizing logic for the newly added mtk_nor_spi_mem_prg is more complicated. Add two helper functions for them: mtk_nor_match_prg: check whether an op is supported by prg mode. mtk_nor_adj_prg_size: adjust data size for mtk_nor_spi_mem_prg. mtk_nor_match_prg isn't called yet because sup

Re: [PATCH v2] fs: Kill DCACHE_DONTCACHE dentry even if DCACHE_REFERENCED is set

2020-09-24 Thread Ira Weiny
On Thu, Sep 24, 2020 at 01:59:58PM +0800, Hao Li wrote: > If DCACHE_REFERENCED is set, fast_dput() will return true, and then > retain_dentry() have no chance to check DCACHE_DONTCACHE. As a result, > the dentry won't be killed and the corresponding inode can't be evicted. > In the following exampl

Re: [PATCH 4/6] seccomp: Emulate basic filters for constant action results

2020-09-24 Thread Paul Moore
On Thu, Sep 24, 2020 at 3:46 AM Kees Cook wrote: > On Thu, Sep 24, 2020 at 01:47:47AM +0200, Jann Horn wrote: > > On Thu, Sep 24, 2020 at 1:29 AM Kees Cook wrote: > > > This emulates absolutely the most basic seccomp filters to figure out > > > if they will always give the same results for a give

Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers

2020-09-24 Thread Peilin Ye
Hi! On Thu, Sep 24, 2020 at 02:42:18PM +, David Laight wrote: > > On Thu, Sep 24, 2020 at 09:38:22AM -0400, Peilin Ye wrote: > > > Hi all, > > > > > > syzbot has reported [1] a global out-of-bounds read issue in > > > fbcon_get_font(). A malicious user may resize `vc_font.height` to a large >

Re: [Intel-wired-lan] [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Paul Menzel
Dear Kai-Heng, Thank you for sending version 2. Am 24.09.20 um 17:09 schrieb Kai-Heng Feng: We are seeing the following error after S3 resume: I’d be great if you added the system and used hardware, you are seeing this with. [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 [

[PATCH v10 0/3] Add trusted_for(2) (was O_MAYEXEC)

2020-09-24 Thread Mickaël Salaün
Hi, This tenth patch series renames the syscall from introspect_access(2) to trusted_for(2) and the sysctl from fs.introspect_policy to fs.trust_policy. Indeed, the final goal is to enable the kernel to be a global policy manager by entrusting processes with access control at their level. To rea

Re: [RFC PATCH 05/11] drivers/acpi: convert seqno counter_atomic

2020-09-24 Thread Rafael J. Wysocki
On Thu, Sep 24, 2020 at 5:08 PM Shuah Khan wrote: > > On 9/24/20 5:13 AM, Rafael J. Wysocki wrote: > > On Wed, Sep 23, 2020 at 3:44 AM Shuah Khan > > wrote: > >> > >> counter_atomic is introduced to be used when a variable is used as > >> a simple counter and doesn't guard object lifetimes. This

[PATCH v10 2/3] arch: Wire up trusted_for(2)

2020-09-24 Thread Mickaël Salaün
From: Mickaël Salaün Wire up trusted_for(2) for all architectures. Signed-off-by: Mickaël Salaün Reviewed-by: Thibaut Sautereau Cc: Al Viro Cc: Andrew Morton Cc: Arnd Bergmann Cc: Kees Cook Cc: Vincent Strubel --- Changes since v9: * Rename introspect_access(2) to trusted_for(2). * Incre

Re: [PATCH] scripts/kallsyms: skip ppc compiler stub *.long_branch.* / *.plt_branch.*

2020-09-24 Thread Masahiro Yamada
On Wed, Sep 23, 2020 at 5:43 AM Guenter Roeck wrote: > > On Wed, Sep 23, 2020 at 02:48:56AM +0900, Masahiro Yamada wrote: > > PowerPC allmodconfig often fails to build as follows: > > > > LD .tmp_vmlinux.kallsyms1 > > KSYM.tmp_vmlinux.kallsyms1.o > > LD .tmp_vmlinux.kalls

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Greg Kroah-Hartman
On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > +PUREILIFI USB DRIVER > +M: pureLiFi Ltd I need a real person here, having aliases as maintainers results in a lack of accountability :( > --- /dev/null > +++ b/drivers/staging/purelifi/TODO > @@ -0,0 +1,5 @@ > +TODO: > + -

Re: [PATCH] hv: clocksource: Add notrace attribute to read_hv_sched_clock_*() functions

2020-09-24 Thread Vitaly Kuznetsov
Mohammed Gamal writes: > When selecting function_graph tracer with the command: > # echo function_graph > /sys/kernel/debug/tracing/current_tracer > > The kernel crashes with the following stack trace: > > [69703.122389] BUG: stack guard page was hit at 1056545c (stack is > fa3f

Re: [PATCH] staging: Initial driver submission for pureLiFi devices

2020-09-24 Thread Greg Kroah-Hartman
On Thu, Sep 24, 2020 at 08:48:51PM +0530, Srinivasan Raju wrote: > +++ b/drivers/staging/purelifi/chip.c > @@ -0,0 +1,184 @@ > +// SPDX-License-Identifier: GNU General Public License v2.0 or later That's not a valid SPDX identifier :) > +/* Copyright (c) 2015-2020 pureLiFi Ltd > + * All rights

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-24 Thread Thomas Gleixner
On Tue, Sep 15 2020 at 19:56, qianjun kernel wrote: > > +#define SOFTIRQ_PENDING_MASK ((1UL << NR_SOFTIRQS) - 1) > > +/* > + * The pending_next_bit is recorded for the next processing order when > + * the loop is broken. This per cpu variable is to solve the following > + * scenarios: > + * Assum

[PATCH v10 1/3] fs: Add trusted_for(2) syscall implementation and related sysctl

2020-09-24 Thread Mickaël Salaün
From: Mickaël Salaün The trusted_for() syscall enables user space tasks to check that files are trusted to be executed or interpreted by user space. This may allow script interpreters to check execution permission before reading commands from a file, or dynamic linkers to allow shared object loa

Re: [RFC-PATCH 2/4] mm: Add __rcu_alloc_page_lockless() func.

2020-09-24 Thread Paul E. McKenney
On Thu, Sep 24, 2020 at 01:19:07PM +0200, Peter Zijlstra wrote: > On Thu, Sep 24, 2020 at 10:16:14AM +0200, Uladzislau Rezki wrote: > > The key point is "enough". We need pages to make a) fast progress b) support > > single argument of kvfree_rcu(one_arg). Not vice versa. That "enough" > > depends

[PATCH v10 3/3] selftest/interpreter: Add tests for trusted_for(2) policies

2020-09-24 Thread Mickaël Salaün
From: Mickaël Salaün Test that checks performed by trusted_for(2) on file descriptors are consistent with noexec mount points and file execute permissions, according to the policy configured with the fs.trust_policy sysctl. Signed-off-by: Mickaël Salaün Reviewed-by: Thibaut Sautereau Cc: Al Vi

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

2020-09-24 Thread Petko Manolov
On 20-09-24 13:09:05, Oliver Neukum wrote: > Am Mittwoch, den 23.09.2020, 17:48 +0300 schrieb Petko Manolov: > > > One possible fix is to add yet another argument to usb_control_msg_recv(), > > which would be the GFP_XYZ flag to pass on to kmemdup(). Up to Greg, of > > course. > > submitted. T

Re: [PATCH 1/2] docs: cdomain.py: add support for two new Sphinx 3.1+ tags

2020-09-24 Thread Jonathan Corbet
So I'm just getting into this and trying to understand what's really going on, but one thing jumped at me: On Thu, 24 Sep 2020 13:22:04 +0200 Mauro Carvalho Chehab wrote: > +# Namespace to be prepended to the full name > +namespace = None > + > +# > +# Handle trivial newer c domain tags that are

Re: [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-24 Thread Eric Biggers
On Thu, Sep 24, 2020 at 09:46:49AM -0400, Mike Snitzer wrote: > > > Can you help me better understand the expected consumer of this code? > > > If you have something _real_ please be explicit. It makes justifying > > > supporting niche code like this more tolerable. > > > > So the motivation for t

[PATCH v1] Bluetooth: send proper config param to unknown config request

2020-09-24 Thread Archie Pusaka
From: Archie Pusaka When receiving an L2CAP_CONFIGURATION_REQ with an unknown config type, currently we will reply with L2CAP_CONFIGURATION_RSP with a list of unknown types as the config param. However, this is not a correct format of config param. As described in the bluetooth spec v5.2, Vol 3,

Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers

2020-09-24 Thread Dan Carpenter
Smatch has a tool to show where struct members are set. `~/smatch/smatch_data/db/smdb.py where console_font height` It's not perfect and this output comes from allmodconfig on yesterday's linux-next. regards, dan carpenter drivers/video/console/vgacon.c | vgacon_init| (struc

[PATCH] kbuild: split the build log of kallsyms

2020-09-24 Thread Masahiro Yamada
Currently, the build log shows KSYM + object name. Precisely speaking, kallsyms generates a .S file and then the compiler compiles it into a .o file. Split the build log into two. [Before] GEN modules.builtin LD .tmp_vmlinux.kallsyms1 KSYM.tmp_vmlinux.kallsyms1.o LD .tm

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-24 Thread Randy Dunlap
On 9/24/20 3:24 AM, Eli Cohen wrote: > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: --- linux-next-20200917.orig/drivers/vdpa/Kconfig +++ linux-next-20200917/drivers/vdpa/Kconfig @@ -31,7 +31,7 @@ config IFCVF config MLX5_VDPA bool "MLX5 VDPA

Re: [PATCH 5/5] mm/thp: Split huge pmds/puds if they're pinned when fork()

2020-09-24 Thread Peter Xu
On Wed, Sep 23, 2020 at 09:07:49AM -0700, Yang Shi wrote: > For tmpfs map, the pmd split just clears the pmd entry without > reinstalling ptes (oppositely anonymous map would reinstall ptes). It > looks this patch intends to copy at pte level by splitting pmd. But > I'm afraid this may not work for

[PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc

2020-09-24 Thread Sebastian Andrzej Siewior
ctags creates a warning: |ctags: Warning: include/linux/seqlock.h:738: null expansion of name pattern "\2" The DEFINE_SEQLOCK() macro is passed to ctags and being told to expect an argument. Add a dummy argument to keep ctags quiet. Signed-off-by: Sebastian Andrzej Siewior --- include/linux/s

Re: [PATCH v2] brcmfmac: check return value of driver_for_each_device()

2020-09-24 Thread Kalle Valo
Zhang Changzhong wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning: > variable 'ret' set but not used [-Wunused-but-set-variable] > 1576 | int ret; >| ^~~ > > driver_for_each_device() has been de

Re: [PATCH v3] usb: dwc3: Stop active transfers before halting the controller

2020-09-24 Thread Alan Stern
On Thu, Sep 24, 2020 at 10:39:24AM +0300, Felipe Balbi wrote: > >>> + /* > >>> + * Synchronize and disable any further event handling while controller > >>> + * is being enabled/disabled. > >>> + */ > >>> + disable_irq(dwc->irq_gadget); > >> > >> why isn't dwc3_gadget_disable_irq() enough? > >>

Re: [PATCH 03/13] bcache: inherit the optimal I/O size

2020-09-24 Thread Martin K. Petersen
Christoph, > Inherit the optimal I/O size setting just like the readahead window, > as any reason to do larger I/O does not apply to just readahead. Looks fine. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] rtw88: Fix probe error handling race with firmware loading

2020-09-24 Thread Kalle Valo
Andreas Färber wrote: > In case of rtw8822be, a probe failure after successful rtw_core_init() > has been observed to occasionally lead to an oops from rtw_load_firmware_cb(): > > [3.924268] pci 0001:01:00.0: [10ec:b822] type 00 class 0xff > [3.930531] pci 0001:01:00.0: reg 0x10: [io

Re: [PATCH -next] zd1201: simplify the return expression of zd1201_set_maxassoc()

2020-09-24 Thread Kalle Valo
Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao Patch applied to wireless-drivers-next.git, thanks. 5acbf34e2a2c zd1201: simplify the return expression of zd1201_set_maxassoc() -- https://patchwork.kernel.org/patch/11789771/ https://wireless.wiki.ker

Re: [PATCH 04/13] aoe: set an optimal I/O size

2020-09-24 Thread Martin K. Petersen
Christoph, > aoe forces a larger readahead size, but any reason to do larger I/O is > not limited to readahead. Also set the optimal I/O size, and remove > the local constants in favor of just using SZ_2G. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

RE: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes

2020-09-24 Thread Leo Li
> -Original Message- > From: Michael Walle > Sent: Thursday, September 24, 2020 6:31 AM > To: Leo Li > Cc: linux-arm-ker...@lists.infradead.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org; Shawn Guo > ; Rob Herring ; Marc Kleine- > Budde ; Jo

Re: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Andrew Lunn
On Thu, Sep 24, 2020 at 11:09:58PM +0800, Kai-Heng Feng wrote: > We are seeing the following error after S3 resume: > [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 > [ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete > [ 704.902817] e1000e :00:1f.6 eno1: Setting

Re: [PATCH v3 2/2] USB: misc: Add onboard_usb_hub driver

2020-09-24 Thread Matthias Kaehlcke
Hi Alan, On Thu, Sep 24, 2020 at 11:27:58AM -0400, Alan Stern wrote: > On Wed, Sep 23, 2020 at 06:10:12PM -0700, Matthias Kaehlcke wrote: > > The main issue this driver addresses is that a USB hub needs to be > > powered before it can be discovered. For discrete onboard hubs (an > > example for su

Re: [PATCH 4/8] mfd: wm: Constify static struct resource

2020-09-24 Thread Charles Keepax
On Tue, Sep 22, 2020 at 09:26:55PM +0200, Rikard Falkeborn wrote: > Constify a number of static struct resource. The only usage of the > structs are to assign their address to the resources field in the > mfd_cell struct. This allows the compiler to put them in read-only > memory. Done with the hel

Re: [PATCH v38 23/24] docs: x86/sgx: Document SGX micro architecture and kernel internals

2020-09-24 Thread Borislav Petkov
On Thu, Sep 24, 2020 at 02:28:01PM +0300, Jarkko Sakkinen wrote: > On Wed, Sep 23, 2020 at 03:50:05PM +0200, Borislav Petkov wrote: > > > +This leaf function takes an RSA-3072 signature of the enclave > > > measurement and an > > > +optional cryptographic token. Linux does not take advantage of la

Re: [PATCH v3 6/8] iommu/arm-smmu: Add impl hook for inherit boot mappings

2020-09-24 Thread Bjorn Andersson
On Mon 21 Sep 16:08 CDT 2020, Will Deacon wrote: > On Sat, Sep 12, 2020 at 10:25:59PM -0500, Bjorn Andersson wrote: > > On Fri 11 Sep 12:13 CDT 2020, Robin Murphy wrote: > > > On 2020-09-04 16:55, Bjorn Andersson wrote: > > > > Add a new operation to allow platform implementations to inherit any >

Re: [PATCH] ipvs: adjust the debug order of src and dst

2020-09-24 Thread Simon Horman
On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote: > From: ylg > > adjust the debug order of src and dst when tcp state changes > > Signed-off-by: ylg Hi, This sounds reasonable to me but please provide your real name in the Signed-off-by name, which should be consistent with the

Re: [PATCH 06/13] md: update the optimal I/O size on reshape

2020-09-24 Thread Martin K. Petersen
Christoph, > The raid5 and raid10 drivers currently update the read-ahead size, but > not the optimal I/O size on reshape. To prepare for deriving the > read-ahead size from the optimal I/O size make sure it is updated as > well. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Or

Re: [PATCH v38 17/24] x86/sgx: ptrace() support for the SGX driver

2020-09-24 Thread Borislav Petkov
On Thu, Sep 24, 2020 at 02:51:28PM +0300, Jarkko Sakkinen wrote: > On Wed, Sep 23, 2020 at 06:17:33PM +0200, Borislav Petkov wrote: > > > Add 'access' implementation to vm_ops with the help of these functions. > > > > "Add an ->access virtual MM function for accessing the enclave's memory... " >

Re: [PATCH 07/13] block: lift setting the readahead size into the block layer

2020-09-24 Thread Martin K. Petersen
Christoph, > Drivers shouldn't really mess with the readahead size, as that is a VM > concept. Instead set it based on the optimal I/O size by lifting the > algorithm from the md driver when registering the disk. Also set > bdi->io_pages there as well by applying the same scheme based on > max

Re: [PATCH] xen-blkback: add a parameter for disabling of persistent grants

2020-09-24 Thread Konrad Rzeszutek Wilk
.snip.. > > For the reason, I'd like to suggest to keep this as is for now and expand it > > with the 'exceptions list' idea or something better, if a real use case > > comes > > out later. > > I agree. I'm happy to take patches to implement more fine grained > control, but that shouldn't prevent

Re: BUG: Bad page state in process dirtyc0w_child

2020-09-24 Thread Linus Torvalds
On Thu, Sep 24, 2020 at 5:06 AM Gerald Schaefer wrote: > > It's all good now, no more occurrences with unlock_page() before > wp_page_reuse(). Thanks for the confirmation. When you pointed at that unlock_page() change, I was pretty sure that was it ("D'oh!"), but it's always good to have that ver

Re: [PATCH v3] sched/deadline: Fix sched_dl_global_validate()

2020-09-24 Thread Peng Liu
Hi Peter, Thanks for looking at this. On Thu, Sep 24, 2020 at 12:57:14PM +0200, Peter Zijlstra wrote: > On Sat, Sep 19, 2020 at 09:42:49AM +0800, Peng Liu wrote: > > When user changes sched_rt_{runtime, period}_us, then > > > > sched_rt_handler() > > --> sched_dl_bandwidth_validate() >

Re: [PATCH] sound/soc/codecs: fix spelling typo in comments

2020-09-24 Thread Joe Perches
On Thu, 2020-09-24 at 13:33 +0100, Mark Brown wrote: > On Thu, Sep 24, 2020 at 02:43:59PM +0800, Wang Qing wrote: > > Modify the comment typo: "compliment" -> "complement". > > These are both English words, with rather different meanings. > and compliment appears to be the one that > is used in

Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send()

2020-09-24 Thread Greg KH
On Thu, Sep 24, 2020 at 06:40:26PM +0300, Petko Manolov wrote: > On 20-09-24 13:09:05, Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 17:48 +0300 schrieb Petko Manolov: > > > > > One possible fix is to add yet another argument to > > > usb_control_msg_recv(), > > > which would be the GFP_

Re: [PATCH v38 18/24] x86/vdso: Add support for exception fixup in vDSO functions

2020-09-24 Thread Borislav Petkov
On Thu, Sep 24, 2020 at 03:09:01PM +0300, Jarkko Sakkinen wrote: > This is not technically SGX specific patch. Is SGX documentation the > correct place for this? So what is it then? It is SGX implementation-specific. Why would you not put it in the documentation?! > From checkpatch I only get: P

Re: [PATCH v2 seccomp 2/6] asm/syscall.h: Add syscall_arches[] array

2020-09-24 Thread YiFei Zhu
On Thu, Sep 24, 2020 at 9:37 AM YiFei Zhu wrote: > > Try with a slghtly older gcc. > > I think that entire optimisation (discarding const arrays) > > is very recent. > > Will try, will take a while to get an old GCC to run, however :/ Possibly one of the oldest I can easily get to work is GCC 6.5

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 08:47:05AM -0700, Randy Dunlap wrote: > On 9/24/20 3:24 AM, Eli Cohen wrote: > > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: > --- linux-next-20200917.orig/drivers/vdpa/Kconfig > +++ linux-next-20200917/drivers/vdpa/Kconfig > @@ -31,7 +

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-24 Thread Jakub Kicinski
On Wed, 23 Sep 2020 22:49:37 -0700 Saeed Mahameed wrote: > 2) Another problematic scenario which i see is repeated in many > drivers: > > shutdown/suspend() > rtnl_lock() > netif_device_detach()//Mark !present; > stop()->carrier_off()->linkwatch_event() > // at this point device is

Re: [PATCH] kbuild: explicitly specify the build id style

2020-09-24 Thread Masahiro Yamada
On Wed, Sep 23, 2020 at 8:21 AM Bill Wendling wrote: > > ld's --build-id defaults to "sha1" style, while lld defaults to "fast". > The build IDs are very different between the two, which may confuse > programs that reference them. > > Signed-off-by: Bill Wendling > --- > Makefile

Re: [Intel-wired-lan] [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Andrew Lunn
On Thu, Sep 24, 2020 at 05:32:12PM +0200, Paul Menzel wrote: > Dear Kai-Heng, > > > Thank you for sending version 2. > > Am 24.09.20 um 17:09 schrieb Kai-Heng Feng: > > We are seeing the following error after S3 resume: > > I’d be great if you added the system and used hardware, you are seeing

Re: [PATCH 5/9] gpio: mockup: use pr_fmt()

2020-09-24 Thread Joe Perches
On Thu, 2020-09-24 at 13:38 +0200, Bartosz Golaszewski wrote: > We don't need a custom logging helper. Let's use the standard pr_fmt() > macro which allows us to use all pr_*() routines with custom format. [] > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c [] > @@ -577,7 +577

Re: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
Hi Andrew, > On Sep 24, 2020, at 23:53, Andrew Lunn wrote: > > On Thu, Sep 24, 2020 at 11:09:58PM +0800, Kai-Heng Feng wrote: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1000e :00:1f.6 eno1: MDI Writ

Re: [PATCH 1/3] sched/topology,schedutil: wrap sched domains rebuild

2020-09-24 Thread Ionela Voinescu
Hey, On Thursday 24 Sep 2020 at 14:34:46 (+0100), Quentin Perret wrote: > On Thursday 24 Sep 2020 at 13:39:35 (+0100), Ionela Voinescu wrote: > > @@ -433,6 +437,7 @@ static bool build_perf_domains(const struct cpumask > > *cpu_map) > > } > > #else > > static void free_pd(struct perf_domain *pd

Re: [PATCH 0/3] condition EAS enablement on FI support

2020-09-24 Thread Ionela Voinescu
On Thursday 24 Sep 2020 at 14:37:27 (+0100), Quentin Perret wrote: > On Thursday 24 Sep 2020 at 13:39:34 (+0100), Ionela Voinescu wrote: > > Given the maturity gained by cpufreq-based Frequency Invariance (FI) > > support following the patches at [1], this series conditions Energy > > Aware Schedul

Re: [PATCH] x86/irq: Use printk_deferred() on raw_spin_lock() protected sections

2020-09-24 Thread Joe Perches
On Thu, 2020-09-24 at 12:28 +0200, Peter Zijlstra wrote: > On Mon, Sep 21, 2020 at 06:22:12PM +0200, Daniel Bristot de Oliveira wrote: > > While testing hotplug I got this BUG: > > It was caused by printk() inside a code section protected by a > > raw_spin_lock() that ended up calling a serial cons

Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes

2020-09-24 Thread Ionela Voinescu
On Thursday 24 Sep 2020 at 14:39:25 (+0100), Quentin Perret wrote: > On Thursday 24 Sep 2020 at 13:39:37 (+0100), Ionela Voinescu wrote: > > For arm64 this affects the task scheduler behavior which builds its > > scheduling domain hierarchy well before the late counter-based FI init. > > During tha

Re: [PATCH V2 1/4] cpufreq: stats: Defer stats update to cpufreq_stats_record_transition()

2020-09-24 Thread Lukasz Luba
On 9/24/20 1:39 PM, Viresh Kumar wrote: On 24-09-20, 13:07, Rafael J. Wysocki wrote: On Thu, Sep 24, 2020 at 1:00 PM Lukasz Luba wrote: On 9/24/20 11:24 AM, Rafael J. Wysocki wrote: On Thu, Sep 24, 2020 at 11:25 AM Lukasz Luba wrote: I wonder if we could just drop the reset feature. Is

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

2020-09-24 Thread Kalle Valo
Hi Stephen, Stephen Rothwell writes: > On Wed, 19 Aug 2020 09:52:47 +0300 Kalle Valo wrote: >> >> Doh, I have checked carefully the commit ids but of course I missed >> checking the trailing. I really need to automate this. Stephen, are your >> scripts checking these available somewhere? > > I

Re: [PATCH v1 1/2] regulator: rtmv20: Adds support for Richtek RTMV20 load switch regulator

2020-09-24 Thread Mark Brown
On Thu, Sep 24, 2020 at 11:04:50PM +0800, cy_huang wrote: > +static int rtmv20_apply_properties(struct rtmv20_priv *priv) > +{ > + const struct { > + int offset; > + int len; > + unsigned int reg; > + unsigned int mask; > + } props[] = { > +

Re: [PATCH] sound/soc/codecs: fix spelling typo in comments

2020-09-24 Thread Mark Brown
On Thu, Sep 24, 2020 at 09:01:21AM -0700, Joe Perches wrote: > On Thu, 2020-09-24 at 13:33 +0100, Mark Brown wrote: > > and compliment appears to be the one that > > is used in the datasheet for this part... > It's difficult to fix datasheet typos. Right, and if we search for the thing in the d

<    3   4   5   6   7   8   9   10   11   12   >