Re: [PATCH v2 2/2] Input: atmel_mxt_ts - wake mXT1386 from deep-sleep mode

Hi Dmitry On 2020/09/20 4:49, Dmitry Osipenko wrote: 18.09.2020 18:55, Wang, Jiada пишет: ...   +static void mxt_wake(struct mxt_data *data) +{ +    struct i2c_client *client = data->client; +    struct device *dev = &data->client->dev; +    struct device_node *np = dev->of_node; +    union i2

[PATCH] sgl_alloc_order: memory leak

Noticed that when sgl_alloc_order() failed with order > 0 that free memory on my machine shrank. That function shouldn't call sgl_free() on its error path since that is only correct when order==0 . Signed-off-by: Douglas Gilbert --- lib/scatterlist.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v2 2/2] Input: atmel_mxt_ts - wake mXT1386 from deep-sleep mode

On Sat, Sep 19, 2020 at 10:28 PM Wang, Jiada wrote: > > Hi Dmitry > > On 2020/09/20 4:49, Dmitry Osipenko wrote: > > 18.09.2020 18:55, Wang, Jiada пишет: > > ... > +static void mxt_wake(struct mxt_data *data) > +{ > +struct i2c_client *client = data->client; > +struc

Re: [PATCH] misc: mic: scif: Fix error handling path

On 9/19/20 7:51 PM, Souptick Joarder wrote: Inside __scif_pin_pages(), when map_flags != SCIF_MAP_KERNEL it will call pin_user_pages_fast() to map nr_pages. However, pin_user_pages_fast() might fail with a return value -ERRNO. The return value is stored in pinned_pages->nr_pages. which in turn i

Re: [PATCH v3 1/6] Bluetooth: Update Adv monitor count upon removal

Hi Howard, > This fixes the count of Adv monitor upon monitor removal. > > The following test was performed. > - Start two btmgmt consoles, issue a btmgmt advmon-remove command on one > console and observe a MGMT_EV_ADV_MONITOR_REMOVED event on the other. > > Signed-off-by: Miao-chen Chou > Sig

Re: [PATCH v3 2/6] Bluetooth: Set scan parameters for ADV Monitor

Hi Howard, > Set scan parameters when there is at least one Advertisement monitor. > > Signed-off-by: Howard Chung > Reviewed-by: Alain Michaud > Reviewed-by: Manish Mandlik > Reviewed-by: Abhishek Pandit-Subedi > Reviewed-by: Miao-chen Chou > --- > > (no changes since v1) > > net/bluetoot

Re: [PATCH] Bluetooth: Fix the vulnerable issue on enc key size

Hi Alex, > When someone attacks the service provider, it creates connection, > authenticates. Then it requests key size of one byte and it identifies > the key with brute force methods. > > After l2cap info req/resp exchange is complete. the attacker sends l2cap > connect with specific PSM. > >

Re: [PATCH v1] Bluetooth: btusb: Enable wide band speech support for BTUSB_QCA_ROME

Hi Rocky, > QCA Rome supports wide band speech, this patch enables the wide band > speech support by set the BTUSB_WIDEBAND_SPEECH flag. > > Signed-off-by: Rocky Liao > --- > drivers/bluetooth/btusb.c | 54 ++- > 1 file changed, 36 insertions(+), 18 deletions(-

Re: [PATCH v1] Bluetooth: Check for encryption key size on connect

Hi Archie, > When receiving connection, we only check whether the link has been > encrypted, but not the encryption key size of the link. > > This patch adds check for encryption key size, and reject L2CAP > connection which size is below the specified threshold (default 7) > with security block.

Re: [PATCH v3 3/6] Bluetooth: Interleave with allowlist scan

Hi Howard, > This patch implements the interleaving between allowlist scan and > no-filter scan. It'll be used to save power when at least one monitor is > registered and at least one pending connection or one device to be > scanned for. > > The durations of the allowlist scan and the no-filter s

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

On Sat, Sep 19 2020 at 12:37, Daniel Vetter wrote: > On Sat, Sep 19, 2020 at 12:35 PM Daniel Vetter wrote: >> I think it should be the case, but I want to double check: Will >> copy_*_user be allowed within a kmap_temporary section? This would >> allow us to ditch an absolute pile of slowpaths. >

Re: [Intel-gfx] [PATCH v3 0/6] Convert the intel iommu driver to the dma-iommu api

Hi Logan, On 2020/9/19 4:47, Logan Gunthorpe wrote: Hi Lu, On 2020-09-11 9:21 p.m., Lu Baolu wrote: Tom Murphy has almost done all the work. His latest patch series was posted here. https://lore.kernel.org/linux-iommu/20200903201839.7327-1-murph...@tcd.ie/ Thanks a lot! This series is a fol

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

On Sat, Sep 19 2020 at 10:18, Linus Torvalds wrote: > On Sat, Sep 19, 2020 at 2:50 AM Thomas Gleixner wrote: >> >> this provides a preemptible variant of kmap_atomic & related >> interfaces. This is achieved by: > > Ack. This looks really nice, even apart from the new capability. > > The only thin

Re: [PATCH 04/12] bdi: initialize ->ra_pages and ->io_pages in bdi_init

On Thu, Sep 17, 2020 at 12:04:59PM +0200, Jan Kara wrote: > On Thu 10-09-20 16:48:24, Christoph Hellwig wrote: > > Set up a readahead size by default, as very few users have a good > > reason to change it. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: David Sterba [btrfs] > > Acked-by:

Re: [PATCH] MIPS: kexec: Add crashkernel=YM handling

于 2020年9月19日 GMT+08:00 上午9:55:46, Youling Tang 写到: >When the kernel crashkernel parameter is specified with just a size, >we are supposed to allocate a region from RAM to store the crashkernel. >However, MIPS merely reserves physical address zero with no checking >that there is even RAM there.

[PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret

The variable ret is being initialized with '-ENOMEM' that is meaningless. So remove it. Signed-off-by: Jing Xiangfeng --- arch/powerpc/kvm/book3s_64_vio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c index

[RESEND PATCH] KVM: use struct_size() and flex_array_size() helpers in kvm_io_bus_unregister_dev()

Make use of the struct_size() helper to avoid any potential type mistakes and protect against potential integer overflows Make use of the flex_array_size() helper to calculate the size of a flexible array member within an enclosing structure Suggested-by: Gustavo A. R. Silva Signed-off-by: Rustam

Re: [PATCH v3 0/10] libperf and arm64 userspace counter access support

Rob, V3 fails to build on ThunderX2: $ make BUILD: Doing 'make -j224' parallel build Auto-detecting system features: ... dwarf: [ on ] ...dwarf_getlocations: [ on ] ... glibc: [ on ] ... gtk2: [ OFF ] ...

Re: [PATCH] Only allow to set crash_kexec_post_notifiers on boot time

On 09/18/20 at 05:47pm, Andrew Morton wrote: > On Fri, 18 Sep 2020 11:25:46 +0800 Dave Young wrote: > > > crash_kexec_post_notifiers enables running various panic notifier > > before kdump kernel booting. This increases risks of kdump failure. > > It is well documented in kernel-parameters.txt. W

[PATCH v2 1/3] erofs: avoid unnecessary variable `err'

variable `err' in z_erofs_submit_queue() isn't useful here, remove it instead. Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- no change since v1. fs/erofs/zdata.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index ac6cb73df192..e

[PATCH v2 2/3] erofs: fold in should_decompress_synchronously()

should_decompress_synchronously() has one single condition for now, so fold it instead. Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- no change since v1. fs/erofs/zdata.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c in

[PATCH v2 3/3] erofs: add REQ_RAHEAD flag to readahead requests

Let's add REQ_RAHEAD flag so it'd be easier to identify readahead I/O requests in blktrace. Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- change since v1: since "erofs: add REQ_RAHEAD flag to readahead requests" is dropped, lifting up related code to this patch and rebase for now. fs/ero

Re: [PATCH 06/12] block: lift setting the readahead size into the block layer

On Thu, Sep 17, 2020 at 12:35:40PM +0200, Jan Kara wrote: > > diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c > > index 81722cdcf0cb21..95eb35324e1a61 100644 > > --- a/block/blk-sysfs.c > > +++ b/block/blk-sysfs.c > > @@ -245,7 +245,6 @@ queue_max_sectors_store(struct request_queue *q, const >

RE: [PATCH 1/4] scsi: ufs-mediatek: Eliminate error message for unbound mphy

> > Some MediaTek platforms does not have to bind MPHY so users > shall not see any unnecessary logs. Simply remove logs for this > case. > > Fixes: fc4983018fea ("scsi: ufs-mediatek: Allow unbound mphy") > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman

[PATCH net-next] net: neterion: Remove set but not used variable

Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/neterion/vxge/vxge-traffic.c: In function vxge_hw_vpath_intr_disable: drivers/net/ethernet/neterion/vxge/vxge-traffic.c:160:6: warning: variable ‘val64’ set but not used [-Wunused-but-set-variable] drivers/net/ethernet/neterion

Re: [PATCH] scsi: remove redundant initialization of variable ret

On Fri, 18 Sep 2020, Jing Xiangfeng wrote: > The variable ret is being initialized with '-ENOMEM' that is > meaningless. So remove it. > Acked-by: Finn Thain

[PATCH v3 2/2] dma-heap: Add a system-uncached heap

This adds a heap that allocates non-contiguous buffers that are marked as writecombined, so they are not cached by the CPU. This is useful, as most graphics buffers are usually not touched by the CPU or only written into once by the CPU. So when mapping the buffer over and over between devices, we

[PATCH v3 1/2] dma-heap: Keep track of the heap device struct

Keep track of the heap device struct. This will be useful for special DMA allocations and actions. Cc: Sumit Semwal Cc: Andrew F. Davis Cc: Benjamin Gaignard Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Robin Murphy Cc: Ezequiel Garcia Cc: Simon Ser Cc: Jame

RE: [PATCH 2/4] scsi: ufs-mediatek: Fix HOST_PA_TACTIVATE quirk

> > Simply add HOST_PA_TACTIVATE quirk back since it was incorrectly > removed before. > > Fixes: 47d054580a75 ("scsi: ufs-mediatek: fix HOST_PA_TACTIVATE quirk for > Samsung UFS Devices") > Signed-off-by: Stanley Chu Reviewed-by: Avri Altman

Re: [PATCH 3/3] platform/x86: Intel PMT Crashlog capability driver

Hi, Thanks for the patches. On 11.09.2020 22:45, David E. Box wrote: > From: Alexander Duyck > > Add support for the Intel Platform Monitoring Technology crashlog > interface. This interface provides a few sysfs values to allow for > controlling the crashlog telemetry interface as well as a ch

Re: [RFC PATCH 6/6] security/fbfam: Mitigate a fork brute force attack

On Fri, Sep 18, 2020 at 02:35:12PM -0700, Kees Cook wrote: > On Fri, Sep 18, 2020 at 06:02:16PM +0200, John Wood wrote: > > On Thu, Sep 10, 2020 at 04:56:19PM -0700, Kees Cook wrote: > > > On Thu, Sep 10, 2020 at 01:21:07PM -0700, Kees Cook wrote: > > > > + pr_warn("fbfam: Offending p

[PATCH] mtd: rawnand: ams-delta: Fix non-OF build warning

Commit 7c2f66a960fc ("mtd: rawnand: ams-delta: Add module device tables") introduced an OF module device table but wrapped a reference to it with of_match_ptr() which resolves to NULL in non-OF configs. That resulted in a clang compiler warning on unused variable in non-OF builds. Fix it. drivers

[PATCH v2 3/4] selftests/seccomp: powerpc: Set syscall return during ptrace syscall exit

Some archs (like powerpc) only support changing the return code during syscall exit when ptrace is used. Test entry vs exit phases for which portions of the syscall number and return values need to be set at which different phases. For non-powerpc, all changes are made during ptrace syscall entry,

[PATCH v2 2/4] selftests/seccomp: Allow syscall nr and ret value to be set separately

In preparation for setting syscall nr and ret values separately, refactor the helpers to take a pointer to a value, so that a NULL can indicate "do not change this respective value". This is done to keep the regset read/write happening once and in one code path. Signed-off-by: Kees Cook --- tool

[PATCH v2 0/4] selftests/seccomp: Refactor change_syscall()

v1: https://lore.kernel.org/lkml/20200912110820.597135-1-keesc...@chromium.org v2: - Took Acked patches into -next - refactored powerpc syscall setting implementation - refactored clone3 args implementation Hi, This finishes the refactoring of the seccomp selftest logic used in for ptrace syscall

[PATCH v2 1/4] selftests/seccomp: Record syscall during ptrace entry

In preparation for performing actions during ptrace syscall exit, save the syscall number during ptrace syscall entry. Some architectures do no have the syscall number available during ptrace syscall exit. Suggested-by: Thadeu Lima de Souza Cascardo Link: https://lore.kernel.org/linux-kselftest/

[PATCH v2 4/4] selftests/clone3: Avoid OS-defined clone_args

As the UAPI headers start to appear in distros, we need to avoid outdated versions of struct clone_args to be able to test modern features; rename to "struct __clone_args". Additionally update the struct size macro names to match UAPI names. Signed-off-by: Kees Cook --- tools/testing/selftests/c

[PATCH] entry: Fix typo in comments for syscall_enter_from_user_mode()

Just to help myself and others with finding the correct function names, fix a typo for "usermode" vs "user_mode". Signed-off-by: Kees Cook --- include/linux/entry-common.h | 2 +- kernel/entry/common.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/en

KMSAN: uninit-value in btrfs_clean_tree_block

Hello, syzbot found the following issue on: HEAD commit:c5a13b33 kmsan: clang-format core git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=1081d69b90 kernel config: https://syzkaller.appspot.com/x/.config?x=20f149ad694ba

[PATCH] checkpatch: extend author Signed-off-by check for split From: header

Checkpatch did not handle cases where the author From: header was split into two lines. The author string went empty and checkpatch generated a false NO_AUTHOR_SIGN_OFF warning. Support split From: headers in AUTHOR_SIGN_OFF check by adding an additional clause to resolve author identity in such c

RE: [PATCH 3/4] scsi: ufs-mediatek: Fix flag of unipro low-power mode

> > Forcibly leave UniPro low-power mode if UIC commands is failed. > This makes hba_enable_delay_us as correct (default) value for > re-enabling the host. > > At the same time, change type of parameter "lpm" in function > ufs_mtk_unipro_set_pm() to "bool". Semantically, better leave it u32 as it

Re: [PATCH v2] RISC-V: Remove any memblock representing unusable memory area

On Thu, Sep 17, 2020 at 04:40:55PM -0700, Atish Patra wrote: > RISC-V limits the physical memory size by -PAGE_OFFSET. Any memory beyond > that size from DRAM start is unusable. Just remove any memblock pointing > to those memory region without worrying about computing the maximum size. > > Signed

Re: [PATCH v2 0/9] ARM: remove set_fs callers and implementation

On Fri, Sep 18, 2020 at 02:46:15PM +0200, Arnd Bergmann wrote: > Hi Christoph, Russell, > > Here is an updated series for removing set_fs() from arch/arm, > based on the previous feedback. > > I have tested the oabi-compat changes using the LTP tests for the three > modified syscalls using an Arm

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > > So we do have an open-source library called hl-thunk, which uses our > > > driver and indeed that was part of the requirement. > > > It is similar to libdrm.

Re: [PATCH v6 08/12] mm,hwpoison: Rework soft offline for in-use pages

On 2020-09-19 02:23, Andrew Morton wrote: On Fri, 18 Sep 2020 09:58:22 +0200 osalva...@suse.de wrote: I just found out yesterday that the patchset Naoya sent has diverged from mine in some aspects that lead to some bugs [1]. This was due to a misunderstanding so no blame here. So, patch#8 and p

Re: [PATCH] MIPS: kexec: Add crashkernel=YM handling

On 09/19/2020 03:02 PM, Jiaxun Yang wrote: 于 2020年9月19日 GMT+08:00 上午9:55:46, Youling Tang 写到: When the kernel crashkernel parameter is specified with just a size, we are supposed to allocate a region from RAM to store the crashkernel. However, MIPS merely reserves physical address zero with

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

On Sat, Sep 19, 2020 at 11:20:03AM +0300, Leon Romanovsky wrote: > On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > > > So we do have an open-source library called hl-thunk, which uses our > > > > driver and

general protection fault in perf_misc_flags

Hello, syzbot found the following issue on: HEAD commit:92ab97ad Merge tag 'sh-for-5.9-part2' of git://git.libc.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1069669b90 kernel config: https://syzkaller.appspot.com/x/.config?x=cd992d74d6c7e62 dash

[PATCH v4 2/2] PHY: Ingenic: Add USB PHY driver using generic PHY framework.

Used the generic PHY framework API to create the PHY, this driver supoorts USB OTG PHY used in JZ4770 SoC, JZ4780 SoC, X1000 SoC, and X1830 SoC. Tested-by: 周正 (Zhou Zheng) Co-developed-by: 漆鹏振 (Qi Pengzhen) Signed-off-by: 漆鹏振 (Qi Pengzhen) Signed-off-by: 周琰杰 (Zhou Yanjie) --- Notes: v1->v

[PATCH v4 1/2] USB: PHY: JZ4770: Remove unnecessary function calls.

Remove unnecessary "of_match_ptr()", because Ingenic SoCs all depend on Device Tree. Suggested-by: Paul Cercueil Signed-off-by: 周琰杰 (Zhou Yanjie) --- Notes: v3: New patch. v3->v4: No change. drivers/usb/phy/phy-jz4770.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v4 0/2] Use the generic PHY framework for Ingenic USB PHY.

v3->v4: Only add new generic-PHY driver, without removing the old one. Because the jz4740-musb driver is not ready to use the generic PHY framework. When the jz4740-musb driver is modified to use the generic PHY framework, the old jz4770-phy driver can be "retired". 周琰杰 (Zhou Yanjie) (2): USB: P

[PATCH 1/2] staging: rtl8712: clean up comparsions to NULL

Clean up comparsions to NULL Reported by checkpatch. if (x == NULL) -> if (!x) if (x != NULL) -> if (x) Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl871x_cmd.c | 4 ++-- drivers/staging/rtl8712/rtl871x_io.c | 2 +- drivers/staging/rtl8712/rtl871x_ioctl_linux.c

[PATCH 2/2] staging: rtl8712: use shorter array initializations

Use empty brace syntax to initialize zero valued arrays. Simplifies and shortens the code a little bit. Signed-off-by: Michael Straube --- drivers/staging/rtl8712/rtl871x_xmit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/d

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

On Sat, Sep 19, 2020 at 10:30:12AM +0200, Greg Kroah-Hartman wrote: > On Sat, Sep 19, 2020 at 11:20:03AM +0300, Leon Romanovsky wrote: > > On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > > > > So we do ha

[PATCH 1/2] staging: rtl8188eu: clean up block comment style issues

Clean up block comment style issues to follow kernel coding style and clear checkpatch warnings. WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines Signed-off-by: Michael Straube -

[PATCH 2/2] staging: rtl8188eu: clean up alignment style issues

Clean up alignment style issues to follow kernel coding style and clear checkpatch issues. CHECK: Alignment should match open parenthesis Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- drivers/staging/rtl8188eu/hal/phy.c | 21 ++-- drivers/

Re: [PATCH 11/14] PM: rewrite is_hibernate_resume_dev to not require an inode

On Thu 2020-09-17 18:57:17, Christoph Hellwig wrote: > Just check the dev_t to help simplifying the code. > > Signed-off-by: Christoph Hellwig Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/b

Re: [PATCH 13/14] PM: mm: cleanup swsusp_swap_check

On Thu 2020-09-17 18:57:19, Christoph Hellwig wrote: > Use blkdev_get_by_dev instead of bdget + blkdev_get. > > Signed-off-by: Christoph Hellwig Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses

Re: [PATCH leds v2 12/50] leds: bcm6328: cosmetic: use reverse christmas tree

On Fri 2020-09-18 00:33:00, Marek Behún wrote: > Only a cosmetic change: use reverse christmas tree variables > declaration. Yeah. Don't do that. Code changes for no reason. Pavel -- (english) http://www.livejournal.com/~pavelmachek

Re: [PATCH v3] pinctrl: renesas: r8a7790: Add VIN1-B and VIN2-G pins, groups and functions

Hi! Thanks for the patch. Verified it against data sheet, the magic numbers check out. Reviewed-by: Ulrich Hecht CU Uli > On 09/17/2020 9:59 PM Lad Prabhakar > wrote: > > > Add pins, groups and functions for the VIN1-B [data/sync/field/clkenb/clk] > and VIN2-G8. > > Signed-off-by: Lad P

[PATCH v2] scsi: arcmsr: Remove the superfluous break

Remove the superfluous break, as there is a 'return' before it. Fixes: 6b3937227479 ("arcmsr: fix command timeout under heavy load") Signed-off-by: Jing Xiangfeng --- drivers/scsi/arcmsr/arcmsr_hba.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/

[PATCH v2 1/1] libnvdimm/namespace: avoid repeated judgment in nvdimm_namespace_disk_name()

The judgment (suffix ? suffix : "") appears three times, we do this just because the initial value of local variable "suffix" is NULL, should be replaced with empty string "" to avoid null pointer reference. It's easy to get rid of it as below: - const char *suffix = NULL; + const char

Re: [PATCH v5 2/3] leds: pwm: Allow automatic labels for DT based devices

On Sat 2020-09-19 07:31:44, Alexander Dahl wrote: > If LEDs are configured through device tree and the property 'label' is > omitted, the label is supposed to be generated from the properties > 'function' and 'color' if present. While this works fine for e.g. the > 'leds-gpio' driver, it did not f

Re: [PATCH v5 1/3] leds: pwm: Remove platform_data support

Hi! > Since commit 141f15c66d94 ("leds: pwm: remove header") that platform > interface is not usable from outside and there seems to be no in tree > user anymore. All in-tree users of the leds-pwm driver seem to use DT > currently. Getting rid of the old platform interface will allow the > leds-

[PATCH -next] leds: pca9532 - simplify the return expression of pca9532_remove

Simplify the return expression. Signed-off-by: Liu Shixin --- drivers/leds/leds-pca9532.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 7d515d5e57bd..88d2edf285c2 100644 --- a/drivers/leds/leds-pca9532.c

[PATCH -next] drm/lima: simplify the return expression of lima_devfreq_target

Simplify the return expression. Signed-off-by: Liu Shixin --- drivers/gpu/drm/lima/lima_devfreq.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c index bbe02817721b..5914442936ed 100644 --- a/dri

[PATCH -next] drm/omap: dsi: simplify the return expression of dsi_init_pll_data

Simplify the return expression. Signed-off-by: Liu Shixin --- drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index eeccf40bae41..cac0d1993dab 100644 --- a/drivers/g

[PATCH -next] mtd: vmu-flash: simplify the return expression of probe_maple_vmu

Simplify the return expression. Signed-off-by: Liu Shixin --- drivers/mtd/maps/vmu-flash.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c index 177bf134e189..588e82de581c 100644 --- a/drivers/mtd/maps/vmu-flas

[PATCH -next] rtc: meson: simplify the return expression of meson_vrtc_probe

Simplify the return expression. Signed-off-by: Liu Shixin --- drivers/rtc/rtc-meson-vrtc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-meson-vrtc.c b/drivers/rtc/rtc-meson-vrtc.c index 89e5ba0dae69..e6bd0808a092 100644 --- a/drivers/rtc/rtc-meson-vrt

[patch RFC 08/15] mips/mm/highmem: Switch to generic kmap atomic

Signed-off-by: Thomas Gleixner Cc: Thomas Bogendoerfer Cc: linux-m...@vger.kernel.org --- Note: Completely untested --- arch/mips/Kconfig |1 arch/mips/include/asm/highmem.h |4 +- arch/mips/mm/highmem.c | 77 arch/mips/m

[patch RFC 07/15] microblaze/mm/highmem: Switch to generic kmap atomic

Signed-off-by: Thomas Gleixner Cc: Michal Simek --- Note: Completely untested --- arch/microblaze/Kconfig |1 arch/microblaze/include/asm/highmem.h |6 ++ arch/microblaze/mm/Makefile |1 arch/microblaze/mm/highmem.c | 78 --

[patch RFC 10/15] powerpc/mm/highmem: Switch to generic kmap atomic

Signed-off-by: Thomas Gleixner Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-...@lists.ozlabs.org --- Note: Completely untested --- arch/powerpc/Kconfig |1 arch/powerpc/include/asm/highmem.h |6 ++- arch/powerpc/mm/Makefile |

[patch RFC 02/15] highmem: Provide generic variant of kmap_atomic*

The kmap_atomic* interfaces in all architectures are pretty much the same except for post map operations (flush) and pre- and post unmap operations. Provide a generic variant for that. Signed-off-by: Thomas Gleixner --- include/linux/highmem.h | 87 --- mm/Kcon

[patch RFC 03/15] x86/mm/highmem: Use generic kmap atomic implementation

Convert X86 to the generic kmap atomic implementation. Make the iomap_atomic() naming convention consistent while at it. Signed-off-by: Thomas Gleixner --- arch/x86/Kconfig |3 +- arch/x86/include/asm/fixmap.h |1 arch/x86/include/asm/highmem.h | 12 ++-- arch/x86/

[patch RFC 09/15] nds32/mm/highmem: Switch to generic kmap atomic

The mapping code is odd and looks broken. See FIXME in the comment. Signed-off-by: Thomas Gleixner Cc: Nick Hu Cc: Greentime Hu Cc: Vincent Chen --- Note: Completely untested --- arch/nds32/Kconfig.cpu |1 arch/nds32/include/asm/highmem.h | 21 + arch/nds32/mm

[patch RFC 05/15] ARM: highmem: Switch to generic kmap atomic

Signed-off-by: Thomas Gleixner Cc: Russell King Cc: Arnd Bergmann Cc: linux-arm-ker...@lists.infradead.org --- Note: Completely untested --- arch/arm/Kconfig |1 arch/arm/include/asm/highmem.h | 30 +++--- arch/arm/mm/Makefile |1 arch/arm/mm/highmem.c

[patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

First of all, sorry for the horribly big Cc list! Following up to the discussion in: https://lore.kernel.org/r/20200914204209.256266...@linutronix.de this provides a preemptible variant of kmap_atomic & related interfaces. This is achieved by: - Consolidating all kmap atomic implementations

[patch RFC 06/15] csky/mm/highmem: Switch to generic kmap atomic

Signed-off-by: Thomas Gleixner Cc: Guo Ren Cc: linux-c...@vger.kernel.org --- Note: Completely untested --- arch/csky/Kconfig |1 arch/csky/include/asm/highmem.h |4 +- arch/csky/mm/highmem.c | 75 3 files changed, 5 inse

[patch RFC 01/15] mm/highmem: Un-EXPORT __kmap_atomic_idx()

Nothing in modules can use that. Signed-off-by: Thomas Gleixner --- mm/highmem.c |2 -- 1 file changed, 2 deletions(-) --- a/mm/highmem.c +++ b/mm/highmem.c @@ -108,8 +108,6 @@ static inline wait_queue_head_t *get_pkm atomic_long_t _totalhigh_pages __read_mostly; EXPORT_SYMBOL(_totalhigh_

[patch RFC 04/15] arc/mm/highmem: Use generic kmap atomic implementation

Adopt the map ordering to match the other architectures and the generic code. Signed-off-by: Thomas Gleixner Cc: Vineet Gupta Cc: linux-snps-...@lists.infradead.org --- Note: Completely untested --- arch/arc/Kconfig |1 arch/arc/include/asm/highmem.h |8 ++- arch/arc/

[patch RFC 14/15] sched: highmem: Store temporary kmaps in task struct

Instead of storing the map per CPU provide and use per task storage. That prepares for temporary kmaps which are preemptible. The context switch code is preparatory and not yet in use because kmap_atomic() runs with preemption disabled. Will be made usable in the next step. Signed-off-by: Thomas

[patch RFC 15/15] mm/highmem: Provide kmap_temporary*

Now that the kmap atomic index is stored in task struct provide a preemptible variant. On context switch the maps of an outgoing task are removed and the map of the incoming task are restored. That's obviously slow, but highmem is slow anyway. The kmap_temporary and iomap_temporary interfaces can

[patch RFC 13/15] mm/highmem: Remove the old kmap_atomic cruft

Signed-off-by: Thomas Gleixner --- include/linux/highmem.h | 65 ++-- mm/highmem.c| 28 +--- 2 files changed, 28 insertions(+), 65 deletions(-) --- a/include/linux/highmem.h +++ b/include/linux/highmem.h @@ -94,27 +94,6

[patch RFC 12/15] xtensa/mm/highmem: Switch to generic kmap atomic

Signed-off-by: Thomas Gleixner Cc: Chris Zankel Cc: Max Filippov Cc: linux-xte...@linux-xtensa.org --- Note: Completely untested --- arch/xtensa/Kconfig |1 arch/xtensa/include/asm/highmem.h |9 +++ arch/xtensa/mm/highmem.c | 44 +++-

[patch RFC 11/15] sparc/mm/highmem: Switch to generic kmap atomic

Signed-off-by: Thomas Gleixner Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- Note: Completely untested --- arch/sparc/Kconfig |1 arch/sparc/include/asm/highmem.h |7 +- arch/sparc/mm/Makefile |3 - arch/sparc/mm/highmem.c | 115 -

Re: [PATCH leds v2 03/50] leds: fsg: compile if COMPILE_TEST=y

On Fri 2020-09-18 00:32:51, Marek Behún wrote: > This driver can be compiled on other platforms with small change if > COMPILE_TEST=y. > > Signed-off-by: Marek Behún > +++ b/drivers/leds/leds-fsg.c > @@ -16,7 +16,13 @@ > #include > #include > #include > + > +#if IS_ENABLED(MACH_FSG) > #in

Re: [PATCH leds v2 31/50] leds: lm36274: use devres LED registering function

Hi! > By using devres version of LED registering function we can remove the > .remove method from this driver. Please see a0972fff09479dd09b731360a3a0b09e4fb4d415. And yes, Johan should have added a comment instead of placing it in changelog. Feel free to add the comment. There was more than one

Re: [PATCH leds v2 48/50] leds: ns2: reorder headers alphabetically

On Fri 2020-09-18 00:33:36, Marek Behún wrote: > Reorder #includes alphabetically. No. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.

Hi

Hi dear, I'm Jessica Vail, from the United States,please i wish to have a communication with you. I wait for your answer. Jessica Vail.

Re: [PATCH] MIPS: kexec: Add crashkernel=YM handling

于 2020年9月19日 GMT+08:00 下午4:29:39, Youling Tang 写到: > > >On 09/19/2020 03:02 PM, Jiaxun Yang wrote: >> >> 于 2020年9月19日 GMT+08:00 上午9:55:46, Youling Tang 写到: >>> When the kernel crashkernel parameter is specified with just a size, >>> we are supposed to allocate a region from RAM to store the cr

Re: [PATCH leds v2 50/50] leds: parse linux,default-trigger DT property in LED core

Hi! > Do parsing of `linux,default-trigger` DT property to LED core. Currently > it is done in many different drivers and the code is repeated. > > This patch removes the parsing from 21 drivers: > an30259a, aw2013, bcm6328, bcm6358, cr0014114, el15203000, gpio, > is31fl319x, is31fl32xx, lm35

Re: [PATCH leds v2 25/50] leds: is31fl319x: compute aggregated max current separately

Hi! > Parse `led-max-current` property of child nodes and compute aggregated > value in a separate function. The controller cannot set this value > separately for every LED, so there is no need to store this value for > every LED. > > Signed-off-by: Marek Behún > Cc: H. Nikolaus Schaller Nikol

Re: [PATCH 03/20] dt-bindings: ata: renesas,rcar-sata: Add r8a774e1 support

Hi Jens, On Thu, Jul 16, 2020 at 6:19 PM Lad Prabhakar wrote: > > Document SATA support for the RZ/G2H, no driver change required. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > --- > Documentation/devicetree/bindings/ata/renesas,rcar-sata.yaml | 1 + > 1 file cha

Re: [PATCH -next] leds: pca9532 - simplify the return expression of pca9532_remove

On Sat 2020-09-19 18:08:53, Liu Shixin wrote: > Simplify the return expression. Thanks, applied. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog

Re: [PATCH v2] kbuild: preprocess module linker script

+++ Masahiro Yamada [08/09/20 13:27 +0900]: There was a request to preprocess the module linker script like we do for the vmlinux one. (https://lkml.org/lkml/2020/8/21/512) The difference between vmlinux.lds and module.lds is that the latter is needed for external module builds, thus must be cle

Re: [PATCH v2 0/2] dt-bindings: can: document R8A774E1

Hi Wolfgang, Marc, David, On Thu, Aug 27, 2020 at 4:30 PM Lad Prabhakar wrote: > > Hi All, > > Both the patches are part of series [1] (patch 18/20, 19/20), > rest of the patches have been acked/merged so just sending > two patches from the series. > > [1] https://lkml.org/lkml/2020/7/15/515 > >

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

On Sat, Sep 19, 2020 at 11:50 AM Thomas Gleixner wrote: > > First of all, sorry for the horribly big Cc list! > > Following up to the discussion in: > > https://lore.kernel.org/r/20200914204209.256266...@linutronix.de > > this provides a preemptible variant of kmap_atomic & related > interfaces.

Re: [PATCH 1/8] dt-bindings: serial: renesas,scif: Document r8a774e1 bindings

Hi Greg, On Wed, Jul 8, 2020 at 6:48 PM Lad Prabhakar wrote: > > RZ/G2H (R8A774E1) SoC also has the R-Car gen3 compatible SCIF ports, > so document the SoC specific bindings. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/serial/renesas,scif.yaml | 1 + > 1 file chan

Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends

On Sat, Sep 19, 2020 at 12:35 PM Daniel Vetter wrote: > > On Sat, Sep 19, 2020 at 11:50 AM Thomas Gleixner wrote: > > > > First of all, sorry for the horribly big Cc list! > > > > Following up to the discussion in: > > > > https://lore.kernel.org/r/20200914204209.256266...@linutronix.de > > > >

Re: [PATCH 2/8] dt-bindings: serial: renesas,hscif: Document r8a774e1 bindings

Hi Greg, On Wed, Jul 8, 2020 at 6:48 PM Lad Prabhakar wrote: > > RZ/G2H (R8A774E1) SoC also has the R-Car gen3 compatible HSCIF ports, > so document the SoC specific bindings. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/serial/renesas,hscif.yaml | 1 + > 1 file ch

  1   2   3   4   >