[PATCH v3 3/3] dt-bindings: dw-apb-ictl: support hierarchy irq domain

2020-09-09 Thread Zhen Lei
Add support to use dw-apb-ictl as primary interrupt controller. Signed-off-by: Zhen Lei --- .../interrupt-controller/snps,dw-apb-ictl.txt | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ic

[PATCH v3 2/3] irqchip: dw-apb-ictl: support hierarchy irq domain

2020-09-09 Thread Zhen Lei
Add support to use dw-apb-ictl as primary interrupt controller. Suggested-by: Marc Zyngier Signed-off-by: Zhen Lei Tested-by: Haoyu Lv --- drivers/irqchip/Kconfig | 2 +- drivers/irqchip/irq-dw-apb-ictl.c | 76 +++ 2 files changed, 69 insertions(+), 9 del

[PATCH v3 0/3] irqchip: dw-apb-ictl: support hierarchy irq domain

2020-09-09 Thread Zhen Lei
v2 --> v3: 1. change (1 << hwirq) to BIT(hwirq). 2. change __exception_irq_entry to __irq_entry, so we can "#include " instead of "#include ". Ohterwise, an compilation error will be reported on arch/csky. drivers/irqchip/irq-dw-apb-ictl.c:20:10: fatal error: asm/exception.h: No such fi

Re: [PATCH 4/5] drm_dp_cec: add plumbing in preparation for MST support

2020-09-09 Thread Sam McNally
On Wed, 2 Sep 2020 at 04:12, Lyude Paul wrote: > > Super minor nitpicks: > > On Tue, 2020-09-01 at 16:22 +1000, Sam McNally wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > [sa...@chromium.org: > > - rebased > > - removed polling-related changes > > - moved the calls to d

[PATCH v3 1/3] irqchip: dw-apb-ictl: prepare for support hierarchy irq domain

2020-09-09 Thread Zhen Lei
Rename some functions and variables in advance, to make the next patch looks more clear. The details are as follows: 1. rename dw_apb_ictl_handler() to dw_apb_ictl_handle_irq_cascaded(). 2. change (1 << hwirq) to BIT(hwirq). In function dw_apb_ictl_init(): 1. rename local variable irq to parent_ir

Re: [PATCH 02/19] amiflop: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > The Amiga floppy driver does not have a ->revalidate_disk method, so it > can just use bdev_check_media_change without any additional changes. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > drivers/block/amiflop.c | 2

Re: [PATCH 04/19] floppy: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_change instead of check_disk_change and > call floppy_revalidate manually. Given that floppy_revalidate only > deals with media change events, the extra call into ->revalidate_disk > from bdev_disk_changed is not required

Re: [PATCH 05/19] swim: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_change instead of check_disk_change and > call floppy_revalidate manually. Given that floppy_revalidate only > deals with media change events, the extra call into ->revalidate_disk > from bdev_disk_changed is not required

Re: Question: Why is there no notification when a file is opened using filp_open()?

2020-09-09 Thread Xiaoming Ni
On 2020/9/9 11:44, Amir Goldstein wrote: On Tue, Sep 8, 2020 at 8:19 PM Matthew Wilcox wrote: On Tue, Sep 08, 2020 at 04:18:29PM +0300, Amir Goldstein wrote: On Tue, Sep 8, 2020 at 3:53 PM Xiaoming Ni wrote: For example, in fs/coredump.c, do_coredump() calls filp_open() to generate core fil

RCU: Question rcu_preempt_blocked_readers_cgp in rcu_gp_fqs_loop func

2020-09-09 Thread Zhang, Qiang
When config preempt RCU, and then there are multiple levels node, the current task is preempted in rcu read critical region. the current task be add to "rnp->blkd_tasks" link list, and the "rnp->gp_tasks" may be assigned a value . these rnp is leaf node in RCU tree. But in "rcu_gp_fqs_

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-09-09 Thread Greg Kroah-Hartman
On Wed, Sep 09, 2020 at 08:29:25AM +0200, Krzysztof Kozlowski wrote: > On Wed, 26 Aug 2020 at 18:18, Joe Perches wrote: > > > > On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote: > > > On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote: > > > > On Wed, 2020-08-26 at 13:44 +0300, An

Re: [PATCHv3] soc: qcom: llcc: Support chipsets that can write to llcc registers

2020-09-09 Thread Sai Prakash Ranjan
Hi, On 2020-09-09 00:02, Stephen Boyd wrote: Quoting Sai Prakash Ranjan (2020-09-07 22:36:48) From: "Isaac J. Manjarres" Older chipsets may not be allowed to configure certain LLCC registers as that is handled by the secure side software. However, this is not the case for newer chipsets and t

Re: [PATCH 03/19] ataflop: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_change instead of check_disk_change and > call floppy_revalidate manually. Given that floppy_revalidate only > deals with media change events, the extra call into ->revalidate_disk > from bdev_disk_changed is not required

Re: [PATCH 4/5] drm_dp_cec: add plumbing in preparation for MST support

2020-09-09 Thread Sam McNally
On Tue, 8 Sep 2020 at 18:41, Hans Verkuil wrote: > > On 01/09/2020 08:22, Sam McNally wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > [sa...@chromium.org: > > - rebased > > - removed polling-related changes > > - moved the calls to drm_dp_cec_(un)set_edid() into the next

Re: [PATCH 01/19] block: add a bdev_check_media_change helper

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Like check_disk_changed, except that it does not call ->revalidate_disk > but leaves that to the caller. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > block/genhd.c | 29 - > fs/bl

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-09 Thread Michal Hocko
On Tue 08-09-20 10:41:10, Rik van Riel wrote: > On Tue, 2020-09-08 at 16:35 +0200, Michal Hocko wrote: > > > A global knob is insufficient. 1G pages will become a very precious > > resource as it requires a pre-allocation (reservation). So it really > > has > > to be an opt-in and the question is

Re: [PATCH V2 2/5] iommu: Add iommu_dma_free_cpu_cached_iovas function

2020-09-09 Thread Christoph Hellwig
> +static inline void iommu_dma_free_cpu_cached_iovas(unsigned int cpu, > + struct iommu_domain > *domain) This adds a crazy long line. Which is rather pointless as other bits of code in the patch use the more compact two tab indentations for the p

Re: [PATCH V2 5/5] DO NOT MERGE: iommu: disable list appending in dma-iommu

2020-09-09 Thread Christoph Hellwig
On Wed, Sep 09, 2020 at 09:43:09AM +0800, Lu Baolu wrote: > + /* > +* The Intel graphic device driver is used to assume that the > returned > +* sg list is not combound. This blocks the efforts of converting > the This adds pointless overly long lines. > +* Intel IOM

Re: [PATCHv3] soc: qcom: llcc: Support chipsets that can write to llcc registers

2020-09-09 Thread Sai Prakash Ranjan
Hi, On 2020-09-08 20:30, Doug Anderson wrote: Hi, On Mon, Sep 7, 2020 at 10:36 PM Sai Prakash Ranjan wrote: --- a/include/linux/soc/qcom/llcc-qcom.h +++ b/include/linux/soc/qcom/llcc-qcom.h @@ -73,6 +73,7 @@ struct llcc_edac_reg_data { * @bitmap: Bit map to track the active slice ids * @

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-09-09 Thread Krzysztof Kozlowski
On Wed, 9 Sep 2020 at 09:02, Greg Kroah-Hartman wrote: > > On Wed, Sep 09, 2020 at 08:29:25AM +0200, Krzysztof Kozlowski wrote: > > On Wed, 26 Aug 2020 at 18:18, Joe Perches wrote: > > > > > > On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote: > > > > On Wed, Aug 26, 2020 at 08:44:30AM -07

Re: [PATCH v4 9/9] mfd: mt6360: Merge different sub-devices I2C read/write

2020-09-09 Thread Gene Chen
Lee Jones 於 2020年9月8日 週二 下午7:48寫道: > > On Tue, 01 Sep 2020, Gene Chen wrote: > > > Lee Jones 於 2020年8月28日 週五 下午6:40寫道: > > > > > > On Mon, 17 Aug 2020, Gene Chen wrote: > > > > > > > From: Gene Chen > > > > > > > > Remove unuse register definition. > > > > > > This should be in a separate patch.

Re: [PATCH 06/19] swim: simplify media change handling

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > floppy_revalidate mostly duplicates work already done in floppy_open > despite only beeing called from floppy_open. Remove the function and > just clear the ->ejected flag directly under the right condition. > > Signed-off-by: Christoph Hellwig > Rev

Re: [PATCH] block: Fix potential page reference leak in __bio_iov_append_get_pages()

2020-09-09 Thread Johannes Thumshirn
On 05/09/2020 11:41, Miaohe Lin wrote: > When bio_add_hw_page() failed, we left page reference still held in pages. I'd add "from iov_iter_get_pages()" to the above sentence. Otherwise Reviewed-by: Johannes Thumshirn

Re: [PATCH 5/5] drm_dp_cec: add the implementation of MST support

2020-09-09 Thread Sam McNally
On Tue, 8 Sep 2020 at 18:08, Hans Verkuil wrote: > > Hi Sam, > > On 01/09/2020 08:22, Sam McNally wrote: > > With DP v2.0 errata E5, CEC tunneling can be supported through an MST > > topology. > > Oh wow, this is finally supported in the spec. Very nice to see this. > Also very nice to see that my

Re: [PATCH 07/19] swim3: use bdev_check_media_changed

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_changed instead of check_disk_change and > call floppy_revalidate manually. Given that floppy_revalidate only > deals with media change events, the extra call into ->revalidate_disk > from bdev_disk_changed is not require

Re: [PATCH 08/19] xsysace: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_change instead of check_disk_change and > call ace_revalidate_disk manually. Given that ace_revalidate_disk only > deals with media change events, the extra call into ->revalidate_disk > from bdev_disk_changed is not requ

RE: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds board

2020-09-09 Thread Meenakshi Aggarwal
> -Original Message- > From: Shawn Guo > Sent: Saturday, September 5, 2020 1:24 PM > To: Meenakshi Aggarwal > Cc: robh...@kernel.org; Varun Sethi ; Leo Li > ; linux-arm-ker...@lists.infradead.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei > ; Kuldeep Sin

RE: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix driving parameter

2020-09-09 Thread 吳昊澄 Ricky
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Wednesday, September 09, 2020 6:29 AM > To: 吳昊澄 Ricky > Cc: a...@arndb.de; gre...@linuxfoundation.org; bhelg...@google.com; > ulf.hans...@linaro.org; rui_f...@realsil.com.cn; linux-kernel@vger.kernel.org; > puran

Re: [PATCH 09/19] xsysace: simplify media change handling

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Pass a struct ace_device to ace_revalidate_disk, move the media changed > check into the one caller that needs it, and give the routine a better > name. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/xsysace.c | 26 ++-

Re: [PATCH for-next] io_uring: return EBADFD when ring isn't in the right state

2020-09-09 Thread Stefano Garzarella
On Tue, Sep 08, 2020 at 11:02:48AM -0600, Jens Axboe wrote: > On 9/8/20 10:52 AM, Stefano Garzarella wrote: > > This patch uniforms the returned error (EBADFD) when the ring state > > (enabled/disabled) is not the expected one. > > > > The changes affect io_uring_enter() and io_uring_register() sy

Re: [f2fs-dev] Question about STEP_DECOMPRESS_NOWQ

2020-09-09 Thread Chao Yu
Hi Daeho, On 2020/9/9 12:43, Daeho Jeong wrote: Hi Chao, I have a question about the below flag for decompression. STEP_DECOMPRESS_NOWQ, /* handle normal cluster data inplace */ According to the comment, you added this for using inplace I added this for the condition that: in comp

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-09 Thread Michal Hocko
On Tue 08-09-20 12:58:59, Roman Gushchin wrote: > On Tue, Sep 08, 2020 at 11:09:25AM -0400, Zi Yan wrote: > > On 7 Sep 2020, at 3:20, Michal Hocko wrote: > > > > > On Fri 04-09-20 14:10:45, Roman Gushchin wrote: > > >> On Fri, Sep 04, 2020 at 09:42:07AM +0200, Michal Hocko wrote: > > > [...] > > >

Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Merge Samsung Exynos Sysreg bindings

2020-09-09 Thread Lee Jones
On Wed, 02 Sep 2020, Krzysztof Kozlowski wrote: > The Samsung Exynos System Registers (Sysreg) bindings are quite simple - > just additional compatible to the syscon. They do not have any value so > merge them into generic MFD syscon bindings. > > Suggested-by: Sylwester Nawrocki > Signed-off-b

Re: [PATCH v2 2/7] kernel/resource: move and rename IORESOURCE_MEM_DRIVER_MANAGED

2020-09-09 Thread Greg Kroah-Hartman
On Tue, Sep 08, 2020 at 10:10:07PM +0200, David Hildenbrand wrote: > IORESOURCE_MEM_DRIVER_MANAGED currently uses an unused PnP bit, which is > always set to 0 by hardware. This is far from beautiful (and confusing), > and the bit only applies to SYSRAM. So let's move it out of the > bus-specific (

Re: [PATCH v2 2/2] dt-bindings: mfd: syscon: Document Exynos3 and Exynos5433 compatibles

2020-09-09 Thread Lee Jones
On Wed, 02 Sep 2020, Krzysztof Kozlowski wrote: > Document Samsung Exynos3 and Exynos5433 compatibles for system > registers. > > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Rebase on first patch > --- > Documentation/devicetree/bin

linux-next: build warning after merge of the staging tree

2020-09-09 Thread Stephen Rothwell
Hi all, After merging the staging tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/iio/adc/stm32-adc-core.c: In function 'stm32_adc_core_switches_probe': drivers/iio/adc/stm32-adc-core.c:598:5: warning: ignoring return value of 'dev_err_probe' declared with

[Linux-kernel-mentees] [PATCH net v2] Bluetooth: Fix slab-out-of-bounds read in hci_le_direct_adv_report_evt()

2020-09-09 Thread Peilin Ye
`num_reports` is not being properly checked. A malformed event packet with a large `num_reports` number makes hci_le_direct_adv_report_evt() read out of bounds. Fix it. Cc: sta...@vger.kernel.org Fixes: 2f010b55884e ("Bluetooth: Add support for handling LE Direct Advertising Report events") Repor

Re: [PATCH v2 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends

2020-09-09 Thread Greg Kroah-Hartman
On Tue, Sep 08, 2020 at 10:10:08PM +0200, David Hildenbrand wrote: > We soon want to pass flags, e.g., to mark added System RAM resources. > mergeable. Prepare for that. What are these random "flags", and how do we know what should be passed to them? Why not make this an enumerated type so that w

[PATCH V4 0/3] percpu_ref & block: reduce memory footprint of percpu_ref in fast path

2020-09-09 Thread Ming Lei
Hi, The 1st patch removes memory footprint of percpu_ref in fast path from 7 words to 2 words, since it is often used in fast path and embedded in user struct. The 2nd patch moves .q_usage_counter to 1st cacheline of 'request_queue'. Simple test on null_blk shows ~2% IOPS boost on one 16cores(tw

[PATCH V4 2/3] percpu_ref: reduce memory footprint of percpu_ref in fast path

2020-09-09 Thread Ming Lei
'struct percpu_ref' is often embedded into one user structure, and the instance is usually referenced in fast path, however actually only 'percpu_count_ptr' is needed in fast path. So move other fields into one new structure of 'percpu_ref_data', and allocate it dynamically via kzalloc(), then mem

[PATCH V4 1/3] percpu_ref: add percpu_ref_is_initialized for MD

2020-09-09 Thread Ming Lei
MD code uses perpcu-refcount internal to check if this percpu-refcount variable is initialized, this way is a hack. Add percpu_ref_is_initialized for MD so that the hack can be avoided. Acked-by: Song Liu Suggested-by: Jens Axboe Tested-by: Veronika Kabatova Cc: Song Liu Cc: linux-r...@vger.k

[PATCH V4 3/3] block: move 'q_usage_counter' into front of 'request_queue'

2020-09-09 Thread Ming Lei
The field of 'q_usage_counter' is always fetched in fast path of every block driver, and move it into front of 'request_queue', so it can be fetched into 1st cacheline of 'request_queue' instance. Tested-by: Veronika Kabatova Reviewed-by: Christoph Hellwig Cc: Sagi Grimberg Cc: Tejun Heo Cc: C

[PATCH] misc: rtsx: Fix memory leak in rtsx_pci_probe

2020-09-09 Thread Keita Suzuki
When mfd_add_devices() fail, pcr->slots should also be freed. However, the current implementation does not free the member, leading to a memory leak. Fix this by adding a new goto label that frees pcr->slots. Signed-off-by: Keita Suzuki --- drivers/misc/cardreader/rtsx_pcr.c | 4 +++- 1 file ch

Re: [RFC PATCH v8 0/3] Add support for AT_INTERPRETED (was O_MAYEXEC)

2020-09-09 Thread Mickaël Salaün
On 08/09/2020 20:50, Al Viro wrote: > On Tue, Sep 08, 2020 at 09:59:53AM +0200, Mickaël Salaün wrote: >> Hi, >> >> This height patch series rework the previous O_MAYEXEC series by not >> adding a new flag to openat2(2) but to faccessat2(2) instead. As >> suggested, this enables to perform the ac

Re: linux-next: build failure after merge of the driver-core tree

2020-09-09 Thread Greg KH
On Wed, Sep 09, 2020 at 03:47:09PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the driver-core tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > lib/test_firmware.c: In function 'trigger_request_platform_store': > lib/test_firmware.c:517:35: error: 'efi_e

[PATCH v2 1/4] dp/dp_mst: Add support for sink event notify messages

2020-09-09 Thread Sam McNally
Sink event notify messages are used for MST CEC IRQs. Add parsing support for sink event notify messages in preparation for handling MST CEC IRQs. Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++- include/drm/drm_dp_mst

[PATCH v2 4/4] drm_dp_cec: add MST support

2020-09-09 Thread Sam McNally
With DP v2.0 errata E5, CEC tunneling can be supported through an MST topology. There are some minor differences for CEC tunneling through an MST topology compared to CEC tunneling to an SST port: - CEC IRQs are delivered via a sink event notify message - CEC-related DPCD registers are accessed vi

[PATCH v2 3/4] drm_dp_mst_topology: export two functions

2020-09-09 Thread Sam McNally
From: Hans Verkuil These are required for the CEC MST support. Signed-off-by: Hans Verkuil Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 6 ++ include/drm/drm_dp_mst_helper.h | 4 2 files changed, 6 insertions(+), 4 deletions(-)

[PATCH v2 2/4] drm_dp_mst_topology: use correct AUX channel

2020-09-09 Thread Sam McNally
From: Hans Verkuil For adapters behind an MST hub use the correct AUX channel. Signed-off-by: Hans Verkuil [sa...@chromium.org: rebased, removing redundant changes] Signed-off-by: Sam McNally --- (no changes since v1) drivers/gpu/drm/drm_dp_mst_topology.c | 36 +++ 1

Re: [PATCH] block: Fix potential page reference leak in __bio_iov_append_get_pages()

2020-09-09 Thread linmiaohe
Johannes Thumshirn wrote: >On 05/09/2020 11:41, Miaohe Lin wrote: >> When bio_add_hw_page() failed, we left page reference still held in pages. > >I'd add "from iov_iter_get_pages()" to the above sentence. > Sounds good. Will add it in v2. >Otherwise >Reviewed-by: Johannes Thumshirn Many Thank

Re: [PATCH] ARM: aspeed: g5: Do not set sirq polarity

2020-09-09 Thread Joel Stanley
On Thu, 27 Aug 2020 at 06:27, Jeremy Kerr wrote: > > Hi Joel, > > > A feature was added to the aspeed vuart driver to configure the vuart > > interrupt (sirq) polarity according to the LPC/eSPI strapping register. > > > > Systems that depend on a active low behaviour (sirq_polarity set to 0) > > s

Re: [PATCHv3] soc: qcom: llcc: Support chipsets that can write to llcc registers

2020-09-09 Thread Sai Prakash Ranjan
On 2020-09-09 12:38, Stephen Boyd wrote: Quoting Sai Prakash Ranjan (2020-09-09 00:04:00) Hi, On 2020-09-09 00:02, Stephen Boyd wrote: > Quoting Sai Prakash Ranjan (2020-09-07 22:36:48) >> From: "Isaac J. Manjarres" >> >> Older chipsets may not be allowed to configure certain LLCC registers >>

linux-next: build warning after merge of the driver-core tree

2020-09-09 Thread Stephen Rothwell
Hi all, After merging the driver-core tree, today's linux-next build produced this warning: drivers/mmc/host/davinci_mmc.c: In function 'davinci_mmcsd_probe': drivers/mmc/host/davinci_mmc.c:1243:4: warning: ignoring return value of 'dev_err_probe' declared with attribute 'warn_unused_result' [-W

Re: [PATCH 10/19] paride/pcd: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > The pcd driver does not have a ->revalidate_disk method, so it can just > use bdev_check_media_change without any additional changes. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > drivers/block/paride/pcd.c | 2 +- >

[Linux-kernel-mentees] [PATCH v2] Bluetooth: Fix memory leak in read_adv_mon_features()

2020-09-09 Thread Peilin Ye
read_adv_mon_features() is leaking memory. Free `rp` before returning. Fixes: e5e1e7fd470c ("Bluetooth: Add handler of MGMT_OP_READ_ADV_MONITOR_FEATURES") Reported-and-tested-by: syzbot+f7f6e564f4202d860...@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=f7f6e564f4202d8601

Re: [PATCH 11/19] gdrom: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > The Sega GD-ROM driver does not have a ->revalidate_disk method, so it > can just use bdev_check_media_change without any additional changes. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > drivers/cdrom/gdrom.c | 2 +-

Re: [PATCH 12/19] ide-cd: use bdev_check_media_changed

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_changed instead of check_disk_change and > call idecd_revalidate_disk manually. Given that idecd_revalidate_disk > only re-reads the TOC, and we already do the same at probe time, the > extra call into ->revalidate_disk f

Re: linux-next: build failure after merge of the driver-core tree

2020-09-09 Thread Greg KH
On Wed, Sep 09, 2020 at 03:47:09PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the driver-core tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > lib/test_firmware.c: In function 'trigger_request_platform_store': > lib/test_firmware.c:517:35: error: 'efi_e

Re: drivers: mfd: lm3533: Support for DT bindings

2020-09-09 Thread Lee Jones
On Thu, 03 Sep 2020, SUNGOLD wrote: > Hi, I am a high school student and a Linux enthusiast and for my free time, > I'm trying to mainline a spare device I had, it's a Xiaomi Mi 4i > (xiaomi-ferrari), till now I've got some basic bringup (had to bring up > touchscreen Atmel mXT336T using the downs

Re: [PATCH v2 2/7] kernel/resource: move and rename IORESOURCE_MEM_DRIVER_MANAGED

2020-09-09 Thread David Hildenbrand
On 09.09.20 09:16, Greg Kroah-Hartman wrote: > On Tue, Sep 08, 2020 at 10:10:07PM +0200, David Hildenbrand wrote: >> IORESOURCE_MEM_DRIVER_MANAGED currently uses an unused PnP bit, which is >> always set to 0 by hardware. This is far from beautiful (and confusing), >> and the bit only applies to SY

Re: [PATCH v2 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends

2020-09-09 Thread David Hildenbrand
On 09.09.20 09:17, Greg Kroah-Hartman wrote: > On Tue, Sep 08, 2020 at 10:10:08PM +0200, David Hildenbrand wrote: >> We soon want to pass flags, e.g., to mark added System RAM resources. >> mergeable. Prepare for that. > > What are these random "flags", and how do we know what should be passed > t

Re: [PATCH 13/19] ide-cd: remove idecd_revalidate_disk

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Just merge the trivial function into its only caller. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > drivers/ide/ide-cd.c | 17 + > 1 file changed, 5 insertions(+), 12 deletions(-) > Reviewed-by: Hann

Re: [PATCH v7 0/9] Add UEFI support for RISC-V

2020-09-09 Thread Ard Biesheuvel
On Wed, 9 Sep 2020 at 04:16, Palmer Dabbelt wrote: > > On Fri, 28 Aug 2020 10:20:27 PDT (-0700), Atish Patra wrote: > > This series adds UEFI support for RISC-V. > > > > Linux kernel: v5.9-rc2 > > U-Boot: v2020.07 > > OpenSBI: master > > > > Patch 1-3 are generic riscv feature addition required fo

Re: [PATCH] rtl8xxxu: prevent potential memory leak

2020-09-09 Thread Kalle Valo
Chris Chiu wrote: > Free the skb if usb_submit_urb fails on rx_urb. And free the urb > no matter usb_submit_urb succeeds or not in rtl8xxxu_submit_int_urb. > > Signed-off-by: Chris Chiu Patch applied to wireless-drivers-next.git, thanks. 86279456a4d4 rtl8xxxu: prevent potential memory leak -

Re: [PATCH] mwifiex: remove function pointer check

2020-09-09 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > clang static analyzer reports this problem > > init.c:739:8: warning: Called function pointer > is null (null dereference) > ret = adapter->if_ops.check_fw_status( ... > ^ > > In mwifiex_dnld_fw,

Re: [PATCH 1/3] dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute

2020-09-09 Thread Neil Armstrong
Hi, On 08/09/2020 21:50, Rob Herring wrote: > On Mon, Sep 07, 2020 at 09:34:00AM +0200, Neil Armstrong wrote: >> The Amlogic AXG MIPI + PCIe Analog PHY should be a subnode of the hhi mfd >> node like the axg-clkc node. >> >> Thus the reg attribute is not needed. > > If the phy registers have an a

Re: [PATCH v4 2/2] mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC

2020-09-09 Thread Lee Jones
On Wed, 09 Sep 2020, Xu Yilun wrote: > > > > > + * m10bmc_raw_read - read m10bmc register per addr > > > > > + * m10bmc_sys_read - read m10bmc system register per offset > > > > > + */ > > > > > +static inline int > > > > > +m10bmc_raw_read(struct intel_m10bmc *m10bmc, unsigned int addr, > > > > >

Re: [PATCH v2] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy

2020-09-09 Thread Kalle Valo
Keita Suzuki wrote: > When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy, > the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be > freed in the caller function. > > Fix this by calling wlc_phy_detach_lcnphy in the error handler of > wlc_phy_txpwr_srom_read_lcnp

Re: [PATCH 14/19] ide-gd: stop using the disk events mechanism

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > ide-gd is only using the disk events mechanism to be able to force an > invalidation and partition scan on opening removable media. Just open > code the logic without invoving the block layer. > > Signed-off-by: Christoph Hellwig > --- > drivers/ide

Re: [PATCH v2] rtlwifi: switch from 'pci_' to 'dma_' API

2020-09-09 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > The only file where some GFP_ flags ar

[PATCH v3 03/11] usb: gadget: bdc: prefer pointer dereference to pointer type

2020-09-09 Thread Chunfeng Yun
Prefer kzalloc(sizeof(*bd_table)...) over kzalloc(sizeof(struct bd_table) Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc_ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 06/11] usb: gadget: bdc: add identifier name for function declaraion

2020-09-09 Thread Chunfeng Yun
This is used to avoid the warning of function arguments, e.g. WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian ---

[PATCH v3 02/11] usb: gadget: bdc: remove bdc_ep_set_halt() declaration

2020-09-09 Thread Chunfeng Yun
No definition for bdc_ep_set_halt(), so remove it. Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc_cmd.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/bdc

[PATCH v3 05/11] usb: gadget: bdc: fix check warning of block comments alignment

2020-09-09 Thread Chunfeng Yun
fix the warning: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc.h | 2 +- drivers/usb/gadget/udc/

[PATCH v3 08/11] usb: gadget: bdc: use the BIT macro to define bit filed

2020-09-09 Thread Chunfeng Yun
Prefer using the BIT macro to define bit fileds Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc.h | 84 1 file changed, 42 insertions(+), 42

[PATCH v3 04/11] usb: gadget: bdc: fix warning of embedded function name

2020-09-09 Thread Chunfeng Yun
Use '"%s...", __func__' to replace embedded function name Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc_dbg.c | 2 +- drivers/usb/gadget/udc/bdc/bdc_ep.c | 6 +++--- 2 files chang

[PATCH v3 07/11] usb: gadget: bdc: avoid precedence issues

2020-09-09 Thread Chunfeng Yun
Add () around macro argument to avoid precedence issues Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) di

Re: [PATCH 15/19] md: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > The md driver does not have a ->revalidate_disk method, so it can just > use bdev_check_media_change without any additional changes. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > drivers/md/md.c | 2 +- > 1 file chan

[PATCH v3 10/11] usb: gadget: bdc: fix checkpatch.pl spacing error

2020-09-09 Thread Chunfeng Yun
fix checkpatch.pl error: ERROR:SPACING: space prohibited before that ',' Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 11/11] usb: gadget: bdc: fix checkpatch.pl repeated word warning

2020-09-09 Thread Chunfeng Yun
fix the warning: WARNING:REPEATED_WORD: Possible repeated word: 'and' Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc_ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 16/19] sd: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_change instead of check_disk_change and > call sd_revalidate_disk manually. As sd also calls sd_revalidate_disk > manually during probe and open, , the extra call into ->revalidate_disk > from bdev_disk_changed is not req

[PATCH v3 09/11] usb: gadget: bdc: fix checkpatch.pl tab warning

2020-09-09 Thread Chunfeng Yun
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements WARNING:TABSTOP: Statements should start on a tabstop Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc_cmd.

Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

2020-09-09 Thread Greg Kroah-Hartman
On Wed, Sep 09, 2020 at 09:08:14AM +0200, Krzysztof Kozlowski wrote: > On Wed, 9 Sep 2020 at 09:02, Greg Kroah-Hartman > wrote: > > > > On Wed, Sep 09, 2020 at 08:29:25AM +0200, Krzysztof Kozlowski wrote: > > > On Wed, 26 Aug 2020 at 18:18, Joe Perches wrote: > > > > > > > > On Wed, 2020-08-26 at

Re: [PATCH v4 9/9] mfd: mt6360: Merge different sub-devices I2C read/write

2020-09-09 Thread Lee Jones
On Wed, 09 Sep 2020, Gene Chen wrote: > Lee Jones 於 2020年9月8日 週二 下午7:48寫道: > > > > On Tue, 01 Sep 2020, Gene Chen wrote: > > > > > Lee Jones 於 2020年8月28日 週五 下午6:40寫道: > > > > > > > > On Mon, 17 Aug 2020, Gene Chen wrote: > > > > > > > > > From: Gene Chen > > > > > > > > > > Remove unuse registe

Re: [PATCH 17/19] sr: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Switch to use bdev_check_media_change instead of check_disk_change and > call sr_block_revalidate_disk manually. Also add an explicit call to > sr_block_revalidate_disk just before disk_add() to ensure we always > read check for a ready unit and read t

Re: Question: Why is there no notification when a file is opened using filp_open()?

2020-09-09 Thread Amir Goldstein
On Wed, Sep 9, 2020 at 10:00 AM Xiaoming Ni wrote: > > On 2020/9/9 11:44, Amir Goldstein wrote: > > On Tue, Sep 8, 2020 at 8:19 PM Matthew Wilcox wrote: > >> > >> On Tue, Sep 08, 2020 at 04:18:29PM +0300, Amir Goldstein wrote: > >>> On Tue, Sep 8, 2020 at 3:53 PM Xiaoming Ni wrote: > For ex

Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node

2020-09-09 Thread Jon Hunter
On 02/09/2020 17:23, Krzysztof Kozlowski wrote: > On Wed, 2 Sep 2020 at 16:45, Naresh Kamboju wrote: >> >> On Thu, 27 Aug 2020 at 15:44, Matthias Brugger >> wrote: >>> >>> >>> >>> On 12/11/2019 12:03, Pi-Hsun Shih wrote: From: Eddie Huang Add scp node to mt8183 and mt8183-evb >

[PATCH v2] drm/dp_mst: Add ddc i2c device links for DP MST connectors

2020-09-09 Thread Sam McNally
DP MST DDC I2C devices are not parented to their connectors. This makes it challenging to associate the ddc i2c device with its connector from userspace. With further refactoring, this can be changed, but in the meantime, follow the pattern of commit e1a29c6c5955 ("drm: Add ddc link in sysfs create

Re: [PATCH] scripts: coccicheck: Do not use shift command when rule is specified

2020-09-09 Thread Sumera Priyadarsini
On Wed, Sep 09, 2020 at 08:52:19AM +0200, Markus Elfring wrote: > I find it helpful to avoid typos (like the following) in the change > description. > > > > … Makfeile. … > > … Makefile. … > > > > … paasing … > > … passing … > > > > …, resuting … > > …, resulting … > > > > This patch mo

[PATCH v3 01/11] usb: gadget: bdc: fix improper SPDX comment style for header file

2020-09-09 Thread Chunfeng Yun
For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used). Cc: Florian Fainelli Signed-off-by: Chunfeng Yun Acked-by: Florian Fainelli --- v3: add acked-by Florian v2: add Cc Florian --- drivers/usb/gadget/ud

Re: [PATCH 18/19] sr: simplify sr_block_revalidate_disk

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Both callers have a valid CD struture available, so rely on that instead > of getting another reference. Also move the function to avoid a forward > declaration. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > drivers

Re: [PATCH 19/19] block: remove check_disk_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > Remove the now unused check_disk_change helper. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > fs/block_dev.c| 20 > include/linux/genhd.h | 1 - > 2 files changed, 21 deletions(-) > Rev

Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360

2020-09-09 Thread Gene Chen
Jonathan Cameron 於 2020年9月8日 週二 下午9:00寫道: > > ... > > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#in

Re: [PATCH] mm: don't rely on system state to detect hot-plug operations

2020-09-09 Thread Michal Hocko
[reposting because the malformed cc list confused my email client] On Tue 08-09-20 19:08:35, Laurent Dufour wrote: > In register_mem_sect_under_node() the system_state’s value is checked to > detect whether the operation the call is made during boot time or during an > hot-plug operation. Unfortun

Re: linux-next: build warning after merge of the driver-core tree

2020-09-09 Thread Greg KH
On Wed, Sep 09, 2020 at 05:23:17PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the driver-core tree, today's linux-next build produced > this warning: > > drivers/mmc/host/davinci_mmc.c: In function 'davinci_mmcsd_probe': > drivers/mmc/host/davinci_mmc.c:1243:4: warning: ignoring r

Re: linux-next: build warning after merge of the staging tree

2020-09-09 Thread Greg KH
On Wed, Sep 09, 2020 at 05:16:21PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the staging tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/iio/adc/stm32-adc-core.c: In function 'stm32_adc_core_switches_probe': > drivers/iio/adc/stm32-adc

Re: linux-next: build warning after merge of the tty tree

2020-09-09 Thread Greg KH
On Wed, Sep 09, 2020 at 03:56:54PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/tty/serial/8250/8250_bcm2835aux.c: In function > 'bcm2835aux_serial_probe': > drivers/tty/serial/8250

Re: [PATCH v2 4/4] drm_dp_cec: add MST support

2020-09-09 Thread Hans Verkuil
On 09/09/2020 09:20, Sam McNally wrote: > With DP v2.0 errata E5, CEC tunneling can be supported through an MST > topology. > > There are some minor differences for CEC tunneling through an MST > topology compared to CEC tunneling to an SST port: > - CEC IRQs are delivered via a sink event notify

Re: [PATCH] mm: don't rely on system state to detect hot-plug operations

2020-09-09 Thread Laurent Dufour
Le 09/09/2020 à 09:40, Michal Hocko a écrit : [reposting because the malformed cc list confused my email client] On Tue 08-09-20 19:08:35, Laurent Dufour wrote: In register_mem_sect_under_node() the system_state’s value is checked to detect whether the operation the call is made during boot tim

Re: [PATCH] add the FPGA Device Feature List (DFL) EMIF support

2020-09-09 Thread Xu Yilun
On Tue, Sep 08, 2020 at 11:03:35AM +0200, Krzysztof Kozlowski wrote: > On Tue, Sep 08, 2020 at 04:27:24PM +0800, Xu Yilun wrote: > > This patch depend on the patchsets: "Modularization of DFL private > > feature drivers" & "add dfl bus support to MODULE_DEVICE_TABLE()" > > The need for bus I under

  1   2   3   4   5   6   7   8   9   10   >