[PATCH v2 04/10] phy: qcom-qmp: Move 'serdes' and 'cfg' into 'struct qcom_phy'

2020-09-02 Thread Stephen Boyd
The serdes I/O region is where the PLL for the phy is controlled. Sometimes the PLL is shared between multiple phys, for example in the PCIe case where there are three phys inside the same wrapper. Other times the PLL is for a single phy, i.e. some USB3 phys. To complete the trifecta we have the US

[PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy

2020-09-02 Thread Stephen Boyd
Add support for the USB3 + DisplayPort (DP) "combo" phy to the qmp phy driver. We already have support for the USB3 part of the combo phy, so most additions are for the DP phy. Split up the qcom_qmp_phy{enable,disable}() functions into the phy init, power on, power off, and exit functions that the

[PATCH v2 02/10] phy: qcom-qmp: Move phy mode into struct qmp_phy

2020-09-02 Thread Stephen Boyd
The phy mode pertains to the phy itself, i.e. 'struct qmp_phy', not the wrapper, i.e. 'struct qcom_qmp'. Move the phy mode into the phy structure to more accurately reflect what is going on. This also cleans up 'struct qcom_qmp' so that it can eventually be the place where qmp wrapper wide data is

[PATCH v2 08/10] phy: qcom-qmp: Add support for sc7180 DP phy

2020-09-02 Thread Stephen Boyd
Add the necessary compatible strings and phy data for the sc7180 USB3+DP combo phy. Cc: Jeykumar Sankaran Cc: Chandan Uddaraju Cc: Vara Reddy Cc: Tanmay Shah Cc: Bjorn Andersson Cc: Manu Gautam Cc: Sandeep Maheswaram Cc: Douglas Anderson Cc: Sean Paul Cc: Jonathan Marek Cc: Dmitry Barysh

[PATCH v2 03/10] phy: qcom-qmp: Remove 'initialized' in favor of 'init_count'

2020-09-02 Thread Stephen Boyd
We already track if any phy inside the qmp wrapper has been initialized by means of the struct qcom_qmp::init_count member. Let's drop the duplicate 'initalized' member to simplify the code a bit. Cc: Jeykumar Sankaran Cc: Chandan Uddaraju Cc: Vara Reddy Cc: Tanmay Shah Reviewed-by: Bjorn Ande

Re: [v2,5/6] reset-controller: ti: Introduce force-update method

2020-09-02 Thread Suman Anna
Hi Crystal, On 8/10/20 1:57 AM, Crystal Guo wrote: > On Tue, 2020-08-04 at 15:03 +0800, Philipp Zabel wrote: >> Hi Crystal, >> >> On Mon, 2020-08-03 at 14:15 +0800, Crystal Guo wrote: >>> Introduce force-update method for assert and deassert interface, >>> which force the write operation in case t

Re: [PATCH net] net: dp83867: Fix WoL SecureOn password

2020-09-02 Thread David Miller
From: Dan Murphy Date: Wed, 2 Sep 2020 14:27:04 -0500 > Fix the registers being written to as the values were being over written > when writing the same registers. > > Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN") > Signed-off-by: Dan Murphy Applied and queued up for -stable,

Re: [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs

2020-09-02 Thread rishabhb
On 2020-09-01 15:05, Mathieu Poirier wrote: Hi Rishabh, On Thu, Aug 27, 2020 at 12:48:48PM -0700, Rishabh Bhatnagar wrote: From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This pa

[PATCH v3] x86/asm: Replace __force_order with memory clobber

2020-09-02 Thread Arvind Sankar
The CRn accessor functions use __force_order as a dummy operand to prevent the compiler from reordering CRn reads/writes with respect to each other. The fact that the asm is volatile should be enough to prevent this: volatile asm statements should be executed in program order. However GCC 4.9.x an

Re: [v4,2/4] dt-binding: reset-controller: ti: add 'mediatek,infra-reset' to compatible

2020-09-02 Thread Suman Anna
Hi Rob, On 8/26/20 6:09 AM, Crystal Guo wrote: > On Wed, 2020-08-26 at 03:02 +0800, Rob Herring wrote: >> On Mon, Aug 17, 2020 at 11:03:22AM +0800, Crystal Guo wrote: >>> The TI syscon reset controller provides a common reset management, >>> and is suitable for MTK SoCs. Add compatible 'mediatek,i

Re: [PATCH v2] KVM: fix memory leak in kvm_io_bus_unregister_dev()

2020-09-02 Thread Gustavo A. R. Silva
Hi, On 9/2/20 17:57, Rustam Kovhaev wrote: > when kmalloc() fails in kvm_io_bus_unregister_dev(), before removing > the bus, we should iterate over all other devices linked to it and call > kvm_iodevice_destructor() for them > > Reported-and-tested-by: syzbot+f196caa45793d6374...@syzkaller.appspo

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread kernel test robot
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-bcm_sf2-Ensure-that-MDIO-diversion-is-used/20200903-050536 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/

Re: [v4,4/4] arm64: dts: mt8192: add infracfg_rst node

2020-09-02 Thread Suman Anna
Hi Crystal, On 8/16/20 10:03 PM, Crystal Guo wrote: > add infracfg_rst node which is for MT8192 platform > > Signed-off-by: Crystal Guo I understand you are posting these together for complete reference, but driver subsystem maintainers typically don't pick dts patches. In anycase, can you clar

Hello,

2020-09-02 Thread SgtKayla Manthey
Grüße, mein Name ist Kayla. Haben Sie bitte meine vorherige Nachricht erhalten? Schreiben Sie mir zurück.

Re: [PATCH v4 2/4] media: dt-bindings: media: i2c: Add bindings for GC5035

2020-09-02 Thread Tomasz Figa
Self-review, On Thu, Sep 3, 2020 at 12:48 AM Tomasz Figa wrote: > > Add YAML device tree bindings for Galaxycore Inc. GC5035 imaging sensor. > > Signed-off-by: Tomasz Figa > --- > .../devicetree/bindings/media/i2c/gc5035.yaml | 142 ++ > 1 file changed, 142 insertions(+) > crea

Re: [v4,3/4] reset-controller: ti: introduce a new reset handler

2020-09-02 Thread Suman Anna
Hi Crystal, On 8/16/20 10:03 PM, Crystal Guo wrote: > Introduce ti_syscon_reset() to integrate assert and deassert together. > If some modules need do serialized assert and deassert operations > to reset itself, reset_control_reset can be called for convenience. There are multiple changes in this

[PATCH] mmc: sdhci-msm: Prefer asynchronous probe

2020-09-02 Thread Douglas Anderson
Turning on initcall debug on one system showed this: initcall sdhci_msm_driver_init+0x0/0x28 returned 0 after 34782 usecs The lion's share of this time (~33 ms) was in mmc_power_up(). This shouldn't be terribly surprising since there are a few calls to delay based on "power_delay_ms" and the de

Re: [PATCH v11 6/9] x86/cet: Add PTRACE interface for CET

2020-09-02 Thread Andy Lutomirski
> On Sep 2, 2020, at 3:13 PM, Yu, Yu-cheng wrote: > > On 9/2/2020 1:03 PM, Jann Horn wrote: >>> On Tue, Aug 25, 2020 at 2:30 AM Yu-cheng Yu wrote: >>> Add REGSET_CET64/REGSET_CET32 to get/set CET MSRs: >>> >>> IA32_U_CET (user-mode CET settings) and >>> IA32_PL3_SSP (user-mode Shado

Re: [PATCH 02/13] x86/debug: Allow a single level of #DB recursion

2020-09-02 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 9f58fdde95c9 ("x86/db: Split out dr6/7 handling"). The bot has tested the following trees: v5.8.5. v5.8.5: Failed to apply! Possible dependencies: 0b085e68f407 ("x86/entry: Conso

Re: [PATCH][next] RDMA/ucma: fix memory leak of mc on an xa_alloc failure

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 05:28:05PM +0100, Colin King wrote: > From: Colin Ian King > > Currently when an xa_alloc failure occurs the error exit path leaks > the allocated object mc. Fix this by adding an error return path > that frees mc and rename error exit paths err3 to err4 and err2 to err3.

Re: [PATCH v2] mm/doc: editorial pass on page migration

2020-09-02 Thread Randy Dunlap
On 9/2/20 3:52 PM, Ralph Campbell wrote: > Add Sphinx reference links to HMM and CPUSETS, and numerous small > editorial changes to make the page_migration.rst document more readable. > > Signed-off-by: Ralph Campbell Reviewed-by: Randy Dunlap Thanks. > --- > > The patch applies cleanly to t

[PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-02 Thread Xie He
PVC devices are virtual devices in this driver stacked on top of the actual HDLC device. They are the devices normal users would use. PVC devices have two types: normal PVC devices and Ethernet-emulating PVC devices. When transmitting data with PVC devices, the ndo_start_xmit function will prepend

[PATCH v3] rpmsg: Avoid double-free in mtk_rpmsg_register_device

2020-09-02 Thread Nicolas Boichat
If rpmsg_register_device fails, it will call mtk_rpmsg_release_device which already frees mdev. Fixes: 7017996951fd ("rpmsg: add rpmsg support for mt8183 SCP.") Signed-off-by: Nicolas Boichat Reviewed-by: Mathieu Poirier --- Changes in v3: - 12-char Fixes tag (Mathieu Poirier) Changes in v2:

Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device

2020-09-02 Thread Nicolas Boichat
On Thu, Sep 3, 2020 at 12:55 AM Mathieu Poirier wrote: > > On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote: > > If rpmsg_register_device fails, it will call > > mtk_rpmsg_release_device which already frees mdev. > > > > Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 S

[PATCH] f2fs: Documentation edits/fixes

2020-09-02 Thread Randy Dunlap
+++ 1 file changed, 23 insertions(+), 30 deletions(-) --- linux-next-20200902.orig/Documentation/filesystems/f2fs.rst +++ linux-next-20200902/Documentation/filesystems/f2fs.rst @@ -127,14 +127,14 @@ active_logs=%u Support configuring the

[PATCH v3 4/6] tracing: add trace_export support for trace_marker

2020-09-02 Thread Tingwei Zhang
Add the support to route trace_marker buffer to other destination via trace_export. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --- include/linux/trace.h | 1 + kernel/trace/trace.c | 9 + 2 files changed, 10 insertions(+) diff --git a/include/linux/trace.h b/inc

[PATCH v3 3/6] tracing: add trace_export support for event trace

2020-09-02 Thread Tingwei Zhang
Only function traces can be exported to other destinations currently. This patch exports event trace as well. Move trace export related function to the beginning of file so other trace can call trace_process_export() to export. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --

[PATCH v3 1/6] stm class: ftrace: change dependency to TRACING

2020-09-02 Thread Tingwei Zhang
We will support copying event trace to STM. Change STM_SOURCE_FTRACE to depend on TRACING since we will support multiple tracers. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --- drivers/hwtracing/stm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 2/6] tracing: add flag to control different traces

2020-09-02 Thread Tingwei Zhang
More traces like event trace or trace marker will be supported. Add flag for difference traces, so that they can be controlled separately. Move current function trace to it's own flag instead of global ftrace enable flag. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --- inc

[PATCH v3 5/6] stm class: ftrace: enable supported trace export flag

2020-09-02 Thread Tingwei Zhang
Set flags for trace_export. Export function trace, event trace and trace marker to stm. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --- drivers/hwtracing/stm/ftrace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwtracing/stm/ftrace.c b/drivers/hwtracing/s

[PATCH v3 0/6] tracing: export event trace and trace_marker

2020-09-02 Thread Tingwei Zhang
Ftrace has ability to export trace packets to other destination. Currently, only function trace can be exported. This series extends the support to event trace and trace_maker. STM is one possible destination to export ftrace. Use separate channel for each CPU to avoid mixing up packets from differ

[PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU

2020-09-02 Thread Tingwei Zhang
To avoid mixup of packets from differnt ftrace packets simultaneously, use different channel for packets from different CPU. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --- drivers/hwtracing/stm/ftrace.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v3 1/3] perf dso: Use libbfd to read build_id and .gnu_debuglink section

2020-09-02 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 21, 2020 at 06:52:36PM +0200, Remi Bernon escreveu: > Wine generates PE binaries for most of its modules and perf is unable > to parse these files to get build_id or .gnu_debuglink section. > > Using libbfd when available, instead of libelf, makes it possible to > resolve debug file lo

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Gustavo A. R. Silva
Hi Alex, On 9/2/20 11:24, Alex Dewar wrote: > In ucma_process_join(), if the call to xa_alloc() fails, the function > will return without freeing mc. Fix this by jumping to the correct line. > > In the process I renamed the jump labels to something more memorable for > extra clarity. > > Address

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Jason Gunthorpe
On Wed, Sep 02, 2020 at 07:34:26PM -0500, Gustavo A. R. Silva wrote: > Hi Alex, > > On 9/2/20 11:24, Alex Dewar wrote: > > In ucma_process_join(), if the call to xa_alloc() fails, the function > > will return without freeing mc. Fix this by jumping to the correct line. > > > > In the process I re

Re: [PATCH] RDMA/ucma: Fix resource leak on error path

2020-09-02 Thread Gustavo A. R. Silva
On 9/2/20 19:32, Jason Gunthorpe wrote: >>> Addresses-Coverity: ("Resource leak") >> >> If you are using a public Coverity scan, please also include the Coverity ID. >> In this case ID 1496814, something like: >> >> Addresses-Coverity-ID: 1496814 ("Resource leak") > > Thanks, I fixed it up >

Re: [PATCH v11 6/9] x86/cet: Add PTRACE interface for CET

2020-09-02 Thread Jann Horn
On Thu, Sep 3, 2020 at 12:13 AM Yu, Yu-cheng wrote: > On 9/2/2020 1:03 PM, Jann Horn wrote: > > On Tue, Aug 25, 2020 at 2:30 AM Yu-cheng Yu wrote: > >> Add REGSET_CET64/REGSET_CET32 to get/set CET MSRs: > >> > >> IA32_U_CET (user-mode CET settings) and > >> IA32_PL3_SSP (user-mode Shado

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-02 Thread Cong Wang
On Tue, Sep 1, 2020 at 11:35 PM Yunsheng Lin wrote: > > On 2020/9/2 12:41, Cong Wang wrote: > > On Tue, Sep 1, 2020 at 6:42 PM Yunsheng Lin wrote: > >> > >> On 2020/9/2 2:24, Cong Wang wrote: > >>> On Mon, Aug 31, 2020 at 5:59 PM Yunsheng Lin > >>> wrote: > > Currently there is concur

Re: [PATCH 14/38] media: vivid: move the devnode creation logic to a separate function

2020-09-02 Thread kernel test robot
Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [cannot apply to v5.9-rc3 next-20200902] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documente

Re: [PATCH v2] mmc: mmc_spi: Allow the driver to be built when CONFIG_HAS_DMA is unset

2020-09-02 Thread Rich Felker
On Wed, Sep 02, 2020 at 05:51:16PM +0200, Geert Uytterhoeven wrote: > Hi Rich, > > On Wed, Sep 2, 2020 at 5:43 PM Rich Felker wrote: > > On Wed, Sep 02, 2020 at 10:31:47AM +0200, Ulf Hansson wrote: > > > On Tue, 1 Sep 2020 at 17:40, Christoph Hellwig wrote: > > > > On Tue, Sep 01, 2020 at 05:36:

Re: [PATCH 01/10] USB: move snd_usb_pipe_sanity_check into the USB core

2020-09-02 Thread Alan Stern
On Wed, Sep 02, 2020 at 01:01:03PM +0200, Greg Kroah-Hartman wrote: > snd_usb_pipe_sanity_check() is a great function, so let's move it into > the USB core so that other parts of the kernel, including the USB core, > can call it. > > Name it usb_pipe_type_check() to match the existing > usb_urb_ep

Re: [RFC v2 2/2] KVM: VMX: Enable bus lock VM exit

2020-09-02 Thread Xiaoyao Li
On 9/3/2020 6:44 AM, Sean Christopherson wrote: On Tue, Sep 01, 2020 at 10:43:12AM +0200, Vitaly Kuznetsov wrote: @@ -6809,6 +6824,19 @@ static fastpath_t vmx_vcpu_run(struct kvm_vcpu *vcpu) if (unlikely(vmx->exit_reason.failed_vmentry)) return EXIT_FASTPATH_NONE; + /*

[PATCH v3 00/22] Improvements for Tegra I2C driver

2020-09-02 Thread Dmitry Osipenko
Hello! This series performs a small refactoring of the Tegra I2C driver code and hardens the atomic-transfer mode. Changelog: v3: - Optimized "Make tegra_i2c_flush_fifos() usable in atomic transfer" patch by pre-checking FIFO state before starting to poll using ktime API, which may b

[PATCH v3 01/22] i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer

2020-09-02 Thread Dmitry Osipenko
The tegra_i2c_flush_fifos() shouldn't sleep in atomic transfer and jiffies are not updating if interrupts are disabled. Hence let's use proper delay functions and use ktime API in order not to hang atomic transfer. Note that this patch doesn't fix any known problem because normally FIFO is flushed

[PATCH v3 17/22] i2c: tegra: Improve driver module description

2020-09-02 Thread Dmitry Osipenko
Use proper spelling of "NVIDIA" and don't designate driver as Tegra2-only since newer SoC generations are supported as well. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/driv

[PATCH v3 18/22] i2c: tegra: Reorder location of functions in the code

2020-09-02 Thread Dmitry Osipenko
Reorder location of functions in the code in order to have definition of functions closer to the place of the invocation. This change makes easier to navigate around the code and removes the need to have a prototype for tegra_i2c_init(). Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-

[PATCH v3 07/22] i2c: tegra: Use dev_err_probe()

2020-09-02 Thread Dmitry Osipenko
Use dev_err_probe() to replace the manual -EPROBE_DEFER handling, making code cleaner. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/drivers/i2

[PATCH v3 19/22] i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg()

2020-09-02 Thread Dmitry Osipenko
The code related to packet header setting up is a bit messy and makes tegra_i2c_xfer_msg() more difficult to read than it could be. Let's factor the packet header setup from tegra_i2c_xfer_msg() to clean up code a tad. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 100 +

[PATCH v3 16/22] i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear()

2020-09-02 Thread Dmitry Osipenko
Rename variable "reg" to "val" in order to better reflect the actual usage of the variable in the code and to make naming consistent with the rest of the code. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH v3 14/22] i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load()

2020-09-02 Thread Dmitry Osipenko
Improve coding style of the tegra_i2c_wait_for_config_load() function by making code a bit more narrow, adhering to the common kernel coding style. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletio

[PATCH v3 15/22] i2c: tegra: Clean up whitespaces and newlines

2020-09-02 Thread Dmitry Osipenko
Clean up couple places in the code by removing unnecessary and adding necessary whitespaces / newlines. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-te

[PATCH v3 13/22] i2c: tegra: Check errors for both positive and negative values

2020-09-02 Thread Dmitry Osipenko
The driver's code is inconsistent in regards to the error values checking. The correct way should be to check both positive and negative values. This patch cleans up the error-checks in the code. Note that the pm_runtime_get_sync() could return positive value on success, hence only relevant parts o

[PATCH v3 20/22] i2c: tegra: Remove "dma" variable

2020-09-02 Thread Dmitry Osipenko
The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in regards to readability and generation of the code, hence let's remove it to clean up code a tad. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 11 +-- 1 file changed, 5 insertions(+), 6 deleti

[PATCH v3 22/22] i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member

2020-09-02 Thread Dmitry Osipenko
The "non_hs_mode" divisor value is fixed, thus there is no need to have the variable i2c_dev.clk_divisor_non_hs_mode struct member. Let's remove it and move the mode selection into tegra_i2c_init() where it can be united with the timing selection. Signed-off-by: Dmitry Osipenko --- drivers/i2c/b

[PATCH v3 21/22] i2c: tegra: Initialization div-clk rate unconditionally

2020-09-02 Thread Dmitry Osipenko
It doesn't make sense to conditionalize the div-clk rate changes because rate is fixed and it won't ever change once it's set at the driver's probe time. All further changes are NO-OPs because CCF caches rate and skips rate-change if rate is unchanged. Signed-off-by: Dmitry Osipenko --- drivers/

[PATCH v3 12/22] i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg()

2020-09-02 Thread Dmitry Osipenko
Factor out error recovery code from tegra_i2c_xfer_msg() in order to make this function easier to read and follow. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 46 ++ 1 file changed, 30 insertions(+), 16 deletio

[PATCH v3 11/22] i2c: tegra: Remove likely/unlikely from the code

2020-09-02 Thread Dmitry Osipenko
The likely/unlikely annotations should be used only in a hot paths of performance-critical code. The I2C driver doesn't have such paths, and thus, there is no justification for usage of likely/unlikely annotations in the code. Hence remove them. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry

[PATCH v3 10/22] i2c: tegra: Drop '_timeout' from wait/poll function names

2020-09-02 Thread Dmitry Osipenko
Drop '_timeout' postfix from the wait/poll completion function names in order to make the names shorter, making code cleaner a tad. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 33 +++-- 1 file changed, 15 insertion

[PATCH v3 09/22] i2c: tegra: Clean up probe function

2020-09-02 Thread Dmitry Osipenko
The driver's probe function code is difficult to read and follow. This patch reorders code of the probe function, forming logical groups that are easy to work with. The clock and hardware initializations are factored out into separate functions in order to keep code clean and ease error unwinding.

[PATCH v3 06/22] i2c: tegra: Improve formatting of function variables

2020-09-02 Thread Dmitry Osipenko
Reorder the definition of variables in the code in order to make code easier to read. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 51 ++ 1 file changed, 21 insertions(+), 30 deletions(-) diff --git a/drivers/i

[PATCH v3 04/22] i2c: tegra: Don't ignore tegra_i2c_flush_fifos() error

2020-09-02 Thread Dmitry Osipenko
The tegra_i2c_flush_fifos() may fail and transfer should be aborted in this case. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/bu

[PATCH v3 08/22] i2c: tegra: Runtime PM always available on Tegra

2020-09-02 Thread Dmitry Osipenko
The runtime PM is guaranteed to be always available on Tegra after commit 40b2bb1b132a ("ARM: tegra: enforce PM requirement"). Hence let's remove all the RPM-availability checking and handling from the code. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-

[PATCH v3 05/22] i2c: tegra: Use reset_control_reset()

2020-09-02 Thread Dmitry Osipenko
Use a single reset_control_reset() instead of assert/deasset couple in order to make code cleaner a tad. Note that the reset_control_reset() uses 1 microsecond delay instead of 2 that was used previously, but this shouldn't matter. In addition don't ignore potential error of the reset. Reviewed-by

[PATCH v3 03/22] i2c: tegra: Clean up messages in the code

2020-09-02 Thread Dmitry Osipenko
This patch unifies style of all messages in the driver by starting them with a lowercase letter and using consistent capitalization and wording for all messages. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 63 -- 1 file changed, 30 insertio

[PATCH v3 02/22] i2c: tegra: Add missing newline before returns

2020-09-02 Thread Dmitry Osipenko
Some places in the code are missing a newline before return, making code more difficult to read and creating inconsistency of the code. This patch adds the missing newlines. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 6 ++ 1 file changed

[PATCH 1/2] docs: Add automatic cross-reference for C types

2020-09-02 Thread Nícolas F . R . A . Prado
In order to cross-reference C types in the documentation, Sphinx requires the syntax :c:type:`type_name`, or even :c:type:`struct type_name ` in order to have the link text different from the target text. Extend automarkup to enable automatic cross-reference of C types by matching any "struct|unio

[PATCH 2/2] kernel-doc: Update "cross-referencing from rST" section to use automarkup

2020-09-02 Thread Nícolas F . R . A . Prado
Update text and examples in the "Cross-referencing from reStructuredText" section to reflect that no additional syntax is needed anymore. Signed-off-by: Nícolas F. R. A. Prado --- Documentation/doc-guide/kernel-doc.rst | 33 +- 1 file changed, 17 insertions(+), 16 deletio

[PATCH 0/2] docs: Add automatic cross-reference for C types

2020-09-02 Thread Nícolas F . R . A . Prado
In order to cross-reference C types in the documentation, Sphinx requires the syntax :c:type:`type_name`, or even :c:type:`struct type_name ` in order to have the link text different from the target text. This patch series removes the need for that markup. The first commit extends the automarkup s

[PATCH] perf stat: Turn off summary for interval mode by default

2020-09-02 Thread Jin Yao
There's a risk that outputting interval mode summaries by default breaks CSV consumers. It already broke pmu-tools/toplev. So now we turn off the summary by default but we create a new option '--summary' to enable the summary. This is active even when not using CSV mode. Before: root@kbl-ppc:~

Re: [f2fs-dev] [PATCH] f2fs: change i_compr_blocks of inode to atomic value

2020-09-02 Thread Chao Yu
On 2020/9/2 14:29, Daeho Jeong wrote: From: Daeho Jeong writepages() can be concurrently invoked for the same file by different threads such as a thread fsyncing the file and a kworker kernel thread. So, changing i_compr_blocks without protection is racy and we need to protect it by changing it

Re: [PATCH v1 00/12] Improvements for Tegra I2C driver

2020-09-02 Thread Dmitry Osipenko
03.09.2020 00:20, Michał Mirosław пишет: > BTW, I wonder if you could expose i2c_in_atomic_xfer_mode() and use it > to differentiate atomic_xfer from normal and get rid of the internal > flag and .master_xfer_atomic callback. The atomic transfer uses 90% of the code path that a non-atomic transfer

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread Andrew Lunn
On Wed, Sep 02, 2020 at 02:03:27PM -0700, Florian Fainelli wrote: > Registering our slave MDIO bus outside of the OF infrastructure is > necessary in order to avoid creating double references of the same > Device Tree nodes, however it is not sufficient to guarantee that the > MDIO bus diversion is

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-02 Thread Yunsheng Lin
On 2020/9/2 17:20, Eric Dumazet wrote: > > > On 9/2/20 1:14 AM, Yunsheng Lin wrote: >> On 2020/9/2 15:32, Eric Dumazet wrote: >>> >>> >>> On 9/1/20 11:34 PM, Yunsheng Lin wrote: >>> I am not familiar with TCQ_F_CAN_BYPASS. From my understanding, the problem is that there is no orde

Re: [PATCH] f2fs: Documentation edits/fixes

2020-09-02 Thread Chao Yu
On 2020/9/3 8:08, Randy Dunlap wrote: From: Randy Dunlap Correct grammar and spelling. Drop duplicate section for resize.f2fs. Change one occurrence of F2fs to F2FS for consistency. Signed-off-by: Randy Dunlap Cc: Jaegeuk Kim Cc: Chao Yu Cc: linux-f2fs-de...@lists.sourceforge.net Review

Re: [PATCH v2] scsi: Don't call memset after dma_alloc_coherent()

2020-09-02 Thread Martin K. Petersen
Alex, > Nvm, someone's already beaten me to the punch! Yep, that one was already fixed up. Thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH v2] mmc: sdhci-of-esdhc: Don't walk device-tree on every interrupt

2020-09-02 Thread Chris Packham
Commit b214fe592ab7 ("mmc: sdhci-of-esdhc: add erratum eSDHC7 support") added code to check for a specific compatible string in the device-tree on every esdhc interrupat. Instead of doing this record the quirk in struct sdhci_esdhc and lookup the struct in esdhc_irq. Signed-off-by: Chris Packham

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-02 Thread Yunsheng Lin
On 2020/9/3 8:35, Cong Wang wrote: > On Tue, Sep 1, 2020 at 11:35 PM Yunsheng Lin wrote: >> >> On 2020/9/2 12:41, Cong Wang wrote: >>> On Tue, Sep 1, 2020 at 6:42 PM Yunsheng Lin wrote: On 2020/9/2 2:24, Cong Wang wrote: > On Mon, Aug 31, 2020 at 5:59 PM Yunsheng Lin > wrote:

Re: [PATCH V2] kvm x86/mmu: use KVM_REQ_MMU_SYNC to sync when needed

2020-09-02 Thread Sean Christopherson
On Wed, Sep 02, 2020 at 04:12:55PM +0200, Vitaly Kuznetsov wrote: > Lai Jiangshan writes: > > > From: Lai Jiangshan > > > > When kvm_mmu_get_page() gets a page with unsynced children, the spt > > pagetable is unsynchronized with the guest pagetable. But the > > guest might not issue a "flush" op

Re: [PATCH v2] power: supply: charger-manager: Fix info message in check_charging_duration()

2020-09-02 Thread Jonathan Bakker
On 2020-09-02 9:46 a.m., Colin Ian King wrote: > On 02/09/2020 17:43, Gustavo A. R. Silva wrote: >> On Wed, Sep 02, 2020 at 09:29:31AM -0700, Randy Dunlap wrote: >>> On 9/2/20 9:23 AM, Gustavo A. R. Silva wrote: A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: M

Re: [RFC v2 2/2] KVM: VMX: Enable bus lock VM exit

2020-09-02 Thread Sean Christopherson
On Thu, Sep 03, 2020 at 08:52:41AM +0800, Xiaoyao Li wrote: > On 9/3/2020 6:44 AM, Sean Christopherson wrote: > > On Tue, Sep 01, 2020 at 10:43:12AM +0200, Vitaly Kuznetsov wrote: > > > > + vcpu->arch.bus_lock_detected = true; > > > > + } else { > > > > +

Re: [RFC net-next] udp: add a GSO type for UDPv6

2020-09-02 Thread tanhuazhong
On 2020/9/2 22:33, Willem de Bruijn wrote: On Wed, Sep 2, 2020 at 2:18 PM Huazhong Tan wrote: In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled separately, for example, checksum offload, so add new GSO type SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands for UDPv4

Re: [RFC net-next] udp: add a GSO type for UDPv6

2020-09-02 Thread tanhuazhong
On 2020/9/3 6:43, David Miller wrote: From: Huazhong Tan Date: Wed, 2 Sep 2020 20:15:11 +0800 In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled separately, for example, checksum offload, so add new GSO type SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands for UDPv4

RE: [PATCH V2 1/4] gpio: mxc: Support module build

2020-09-02 Thread Anson Huang
Hi, Linus Do you have chance to take a look at this patch series? Thanks, Anson > Subject: Re: [PATCH V2 1/4] gpio: mxc: Support module build > > On Mon, Jul 27, 2020 at 2:23 PM Anson Huang > wrote: > > > Subject: Re: [PATCH V2 1/4] gpio: mxc: Support module build > > > > > > > So, cou

Re: [PATCH] KVM: Check the allocation of pv cpu mask

2020-09-02 Thread Haiwei Li
On 20/9/2 01:35, kernel test robot wrote: Hi Haiwei, Thank you for the patch! Yet something to improve: [auto build test ERROR on kvm/linux-next] [also build test ERROR on linus/master v5.9-rc3 next-20200828] [cannot apply to linux/master vhost/linux-next] [If your patch is applied to the wr

{standard input}:3239: Error: operand out of range (130 is not between -128 and 127)

2020-09-02 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: fc3abb53250a90ba2150eebd182137c136f4d25a commit: 751465913f045a1120188ec91ed46d90ea5fd539 drm/bridge: Add a drm_bridge_state object date: 7 months ago config: arc-randconfig-r021-20200902 (attached as

Re: [PATCH v5 00/21] kprobes: Unify kretprobe trampoline handlers and make kretprobe lockless

2020-09-02 Thread Masami Hiramatsu
On Wed, 2 Sep 2020 15:42:52 +0200 pet...@infradead.org wrote: > On Wed, Sep 02, 2020 at 10:19:26PM +0900, Masami Hiramatsu wrote: > > On Wed, 2 Sep 2020 11:36:13 +0200 > > pet...@infradead.org wrote: > > > > > On Wed, Sep 02, 2020 at 05:17:55PM +0900, Masami Hiramatsu wrote: > > > > > > > > Ok,

Re: [f2fs-dev] [PATCH] f2fs: change i_compr_blocks of inode to atomic value

2020-09-02 Thread Daeho Jeong
And how about this atomic64 to just atomic? As you mentioned before, we don't need a 64bit value for i_compr_blocks of inode. 2020년 9월 3일 (목) 오전 10:08, Chao Yu 님이 작성: > > On 2020/9/2 14:29, Daeho Jeong wrote: > > From: Daeho Jeong > > > > writepages() can be concurrently invoked for the same file

RE: [PATCH] arm64: topology: Stop using MPIDR for topology information

2020-09-02 Thread Zengtao (B)
> -Original Message- > From: Valentin Schneider [mailto:valentin.schnei...@arm.com] > Sent: Wednesday, September 02, 2020 6:52 PM > To: Zengtao (B) > Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > Catalin Marinas; Will Deacon; Sudeep Holla; Robin Murphy; Jeremy Li

Re: [PATCH] Makefile: add -fuse-ld=lld to KBUILD_HOSTLDFLAGS when LLVM=1

2020-09-02 Thread Masahiro Yamada
On Thu, Sep 3, 2020 at 7:40 AM Nick Desaulniers wrote: > > On Fri, Aug 21, 2020 at 10:14 PM Masahiro Yamada wrote: > > > > On Fri, Aug 21, 2020 at 7:10 AM 'Nick Desaulniers' via Clang Built > > Linux wrote: > > > > > > While moving Android kernels over to use LLVM=1, we observe the failure > > >

Re: [RFC PATCH] USB: misc: Add usb_hub_pwr driver

2020-09-02 Thread Peter Chen
On 20-09-02 10:45:36, Matthias Kaehlcke wrote: > > > > Hi Matthias, > > > > I did similar several years ago [1], but the concept (power sequence) > > doesn't be accepted by power maintainer. > > Yeah, I saw that, I think I even reviewed or tested some early version > of it :) > > > Your patch i

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-02 Thread Cong Wang
On Wed, Sep 2, 2020 at 6:22 PM Yunsheng Lin wrote: > > On 2020/9/3 8:35, Cong Wang wrote: > > On Tue, Sep 1, 2020 at 11:35 PM Yunsheng Lin wrote: > >> > >> On 2020/9/2 12:41, Cong Wang wrote: > >>> On Tue, Sep 1, 2020 at 6:42 PM Yunsheng Lin > >>> wrote: > > On 2020/9/2 2:24, Cong Wan

[PATCH 2/5] clk: ingenic: Use readl_poll_timeout instead of custom loop

2020-09-02 Thread Paul Cercueil
Use the readl_poll_timeout() function instead of rolling our own busy-wait loops. This makes the code simpler. Signed-off-by: Paul Cercueil --- drivers/clk/ingenic/cgu.c | 55 +-- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/drivers/clk/inge

[PATCH 1/5] clk: ingenic: Use to_clk_info() macro for all clocks

2020-09-02 Thread Paul Cercueil
The to_clk_info() previously had a BUG_ON() to check that it was only called for PLL clocks. Yet, all the other clocks were doing the exact same thing the macro does, in-line. Move the to_clk_info() macro to the top of the file, remove the hardcoded BUG_ON(), and use it everywhere it makes sense.

[PATCH 4/5] clk: ingenic: Don't tag custom clocks with CLK_SET_RATE_PARENT

2020-09-02 Thread Paul Cercueil
The custom clocks have custom functions to round, get or set their rate. Therefore, we can't assume that they need the CLK_SET_RATE_PARENT flag. Signed-off-by: Paul Cercueil --- drivers/clk/ingenic/cgu.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/c

[PATCH 3/5] clk: ingenic: Don't use CLK_SET_RATE_GATE for PLL

2020-09-02 Thread Paul Cercueil
CLK_SET_RATE_GATE means that the clock must be gated when being reclocked. This is not the case for the PLLs in Ingenic SoCs. Signed-off-by: Paul Cercueil --- drivers/clk/ingenic/cgu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/clk/ingenic/cgu.c b/driver

[PATCH 5/5] clk: ingenic: Respect CLK_SET_RATE_PARENT in .round_rate

2020-09-02 Thread Paul Cercueil
Clocks that don't have a divider are in our case all marked with the CLK_SET_RATE_PARENT flag. In this case, the .round_rate implementation should modify the value pointed to by parent_rate, in order to propagate the rate change to the parent, as explained in the documentation of clk_set_rate(). S

Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-02 Thread Florian Fainelli
On 9/2/2020 6:13 PM, Andrew Lunn wrote: On Wed, Sep 02, 2020 at 02:03:27PM -0700, Florian Fainelli wrote: Registering our slave MDIO bus outside of the OF infrastructure is necessary in order to avoid creating double references of the same Device Tree nodes, however it is not sufficient to gu

Re: [PATCH] signal: clean up codestyle

2020-09-02 Thread linmiaohe
Christian Brauner wrote: >On Wed, Sep 02, 2020 at 01:34:59AM +, linmiaohe wrote: >> Christian Brauner wrote: >> >On Tue, Sep 01, 2020 at 06:39:05PM +0200, Oleg Nesterov wrote: >> >> On 09/01, Christian Brauner wrote: >> >Christian >> >> Sorry for I did not get the imply. > >No need to apolog

Re: [PATCH v2] use cpu_to_le{16,32} instead of __constant_cpu_to_*

2020-09-02 Thread Joe Perches
On Wed, 2020-09-02 at 23:29 +0200, Rene Rebe wrote: > As per recommendation, convert a few remaining __constant_cpu_to_le{16,32} > instances in the qla2xxx, qla4xxx and cifs to just cpu_to_le{16,32}. [] > diff --git a/drivers/scsi/qla2xxx/qla_target.c > b/drivers/scsi/qla2xxx/qla_target.c [] > @@

[PATCH v2] KVM: Check the allocation of pv cpu mask

2020-09-02 Thread Haiwei Li
From: Haiwei Li check the allocation of per-cpu __pv_cpu_mask. Initialize ops only when successful. Signed-off-by: Haiwei Li --- arch/x86/kernel/kvm.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c in

<    1   2   3   4   5   6   7   8   9   10   >