drivers/usb/host/ehci-hcd.c:1286: warning: "PLATFORM_DRIVER" redefined

2020-08-27 Thread kernel test robot
: 8 months ago config: sparc-randconfig-r004-20200827 (attached as .config) compiler: sparc-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git

Re: [PATCH] scripts: Add intended executable mode and SPDX license

2020-08-27 Thread Greg KH
pending symbols") added the file xen-hypercalls.sh without the > executable bit. > > Set to usual modes for these files and provide the SPDX license for > spdxcheck-test.sh. No functional changes. > > Signed-off-by: Mrinal Pandey > --- > applies cleanly on next-20200

Re: [PATCH v2 2/3] block: Add a new helper to attempt to merge a bio

2020-08-27 Thread Christoph Hellwig
On Tue, Aug 18, 2020 at 01:45:29PM +0800, Baolin Wang wrote: > Meanwhile move the blk_mq_bio_list_merge() into blk-merge.c and > rename it as a generic name. That should probably a separate patch. > + if (blk_attempt_bio_merge(q, rq, bio, nr_segs, false) == > BIO_MERGE_OK) > +

Re: [PATCH] MAINTAINERS: add LLVM maintainers

2020-08-27 Thread Lukas Bulwahn
On Tue, 25 Aug 2020, 'Nick Desaulniers' via Clang Built Linux wrote: > Nominate Nathan and myself to be point of contact for clang/LLVM related > support, after a poll at the LLVM BoF at Linux Plumbers Conf 2020. > > While corporate sponsorship is beneficial, its important to not entrust > the

Re: [PATCH v2 3/3] block: Remove blk_mq_attempt_merge() function

2020-08-27 Thread Christoph Hellwig
On Tue, Aug 18, 2020 at 01:45:30PM +0800, Baolin Wang wrote: > The small blk_mq_attempt_merge() function is only called by > __blk_mq_sched_bio_merge(), just open code it. > > Signed-off-by: Baolin Wang Looks good, Reviewed-by: Christoph Hellwig

Re: WARNING: at drivers/opp/core.c:678 dev_pm_opp_set_rate+0x4cc/0x5d4 - on arm x15

2020-08-27 Thread Viresh Kumar
On 27-08-20, 15:04, Naresh Kamboju wrote: > While boot testing arm x15 devices the Kernel warning noticed with linux next > tag 20200825. > > BAD: next-20200825 > GOOD: next-20200824 > > metadata: > git branch: master > git repo: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux

Re: Kernel panic : Unable to handle kernel paging request at virtual address - dead address between user and kernel address ranges

2020-08-27 Thread Arnd Bergmann
On Thu, Aug 27, 2020 at 11:08 AM Viresh Kumar wrote: > > +Rajendra > > On 27-08-20, 14:02, Naresh Kamboju wrote: > > arm64 dragonboard db410c boot failed while running linux next 20200827 > > kernel. > > > > metadata: > > git branch: master > >

Re: [PATCH] driver/pci: reduce the single block time in pci_read_config

2020-08-27 Thread Jiang Biao
kindly ping :) On Mon, 24 Aug 2020 at 13:20, Jiang Biao wrote: > > From: Jiang Biao > > pci_read_config() could block several ms in kernel space, mainly > caused by the while loop to call pci_user_read_config_dword(). > Singel pci_user_read_config_dword() loop could consume 130us+, >

Re: [PATCH] scripts: Add intended executable mode and SPDX license

2020-08-27 Thread Lukas Bulwahn
and commit 9b4ade226f74 ("xen: build infrastructure for generating > > hypercall depending symbols") added the file xen-hypercalls.sh without the > > executable bit. > > > > Set to usual modes for these files and provide the SPDX license for > > spdx

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-27 Thread Stefan Wahren
Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: > Hi Stefan, > > Thank you for your review. > > > On 8/26/20 7:04 PM, Stefan Wahren wrote: >> Hi Hoeguen, >> >> Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: >>> There is a problem that the output does not work at a resolution >>> exceeding FHD. To solve this

Re: [PATCH 5/7 net-next] vxlan: add VXLAN_NL2FLAG macro

2020-08-27 Thread Michal Kubecek
On Thu, Aug 27, 2020 at 08:50:19AM +0200, Fabian Frederick wrote: > Replace common flag assignment with a macro. > This could yet be simplified with changelink/supported but it would > remove clarity > > Signed-off-by: Fabian Frederick > --- [...] > diff --git a/include/net/vxlan.h b/include/net/

Re: [PATCH 19/35] kasan: don't allow SW_TAGS with ARM64_MTE

2020-08-27 Thread Vincenzo Frascino
Hi Andrey, On 8/27/20 9:04 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:01PM +0200, Andrey Konovalov wrote: >> Software tag-based KASAN provides its own tag checking machinery that >> can conflict with MTE. Don't allow enabling software tag-based KASAN >> when MTE is enabled. >> >> S

Re: [RESEND PATCH v4] iommu/mediatek: check 4GB mode by reading infracfg

2020-08-27 Thread Matthias Brugger
On 26/08/2020 10:56, Miles Chen wrote: In previous discussion [1] and [2], we found that it is risky to use max_pfn or totalram_pages to tell if 4GB mode is enabled. Check 4GB mode by reading infracfg register, remove the usage of the un-exported symbol max_pfn. This is a step towards buildi

Re: [PATCH 21/35] arm64: mte: Add in-kernel tag fault handler

2020-08-27 Thread Catalin Marinas
On Fri, Aug 14, 2020 at 07:27:03PM +0200, Andrey Konovalov wrote: > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > index 5e832b3387f1..c62c8ba85c0e 100644 > --- a/arch/arm64/mm/fault.c > +++ b/arch/arm64/mm/fault.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-08-27 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for the review comments. On 8/25/2020 7:21 PM, Vinod Koul wrote: On 18-08-20, 15:00, Reddy, MallikarjunaX wrote: + +intel,chans: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: + The channels included o

Re: [PATCH v10 1/4] media: open.rst: better document device node naming

2020-08-27 Thread Sakari Ailus
Hi Mauro, Thanks for working on this! On Thu, Aug 27, 2020 at 09:21:45AM +0200, Mauro Carvalho Chehab wrote: > Right now, only kAPI documentation describes the device naming. > However, such description is needed at the uAPI too. Add it, > and describe how to get an unique identifier for a given

Re: [PATCH] fs: Kill DCACHE_DONTCACHE dentry even if DCACHE_REFERENCED is set

2020-08-27 Thread Li, Hao
On 2020/8/27 14:37, Dave Chinner wrote: > On Fri, Aug 21, 2020 at 09:59:53AM +0800, Hao Li wrote: >> Currently, DCACHE_REFERENCED prevents the dentry with DCACHE_DONTCACHE >> set from being killed, so the corresponding inode can't be evicted. If >> the DAX policy of an inode is changed, we can't ma

Re: [tip: sched/core] sched/topology: Move sd_flag_debug out of linux/sched/topology.h

2020-08-27 Thread Andy Shevchenko
On Thu, Aug 27, 2020 at 12:27 PM wrote: > > On Thu, Aug 27, 2020 at 11:50:07AM +0300, Andy Shevchenko wrote: > > On Thu, Aug 27, 2020 at 10:57 AM tip-bot2 for Valentin Schneider > > wrote: > > > > > > The following commit has been merged into the sched/core branch of tip: > > > > > Fixes: b6e862f

[PATCH 4/4] qla2xxx: Handle incorrect entry_type entries

2020-08-27 Thread Daniel Wagner
It was observed on an ISP8324 16Gb HBA with fw=8.08.203 (d0d5) that pkt->entry_type was MBX_IOCB_TYPE/0x39 with an sp->type SRB_SCSI_CMD which is invalid and should not be possible. A careful code review of the crash dump didn't reveal any short comings. Reading the entry_type from the crash dump

Re: [PATCH] mwifiex: switch from 'pci_' to 'dma_' API

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'mwifiex_p

[PATCH 1/4] qla2xxx: Reset done and free callback pointer on release

2020-08-27 Thread Daniel Wagner
Reset ->done and ->free when releasing the srb. There is a hidden use-after-free bug in the driver which corrupts the srb memory pool which originates from the cleanup callbacks. By explicitly resetting the callbacks to NULL, we workaround the memory corruption. An extensive search didn't bring an

[PATCH 2/4] qla2xxx: Simplify return value logic in qla2x00_get_sp_from_handle()

2020-08-27 Thread Daniel Wagner
Refactor qla2x00_get_sp_from_handle() to avoid the unecessary goto if early returns are used. With this we can also avoid preinitilzing the sp pointer. Signed-off-by: Daniel Wagner --- drivers/scsi/qla2xxx/qla_isr.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/driv

[PATCH 3/4] qla2xxx: Drop unused function argument from qla2x00_get_sp_from_handle()

2020-08-27 Thread Daniel Wagner
Commit 7c3df1320e5e ("[SCSI] qla2xxx: Code changes to support new dynamic logging infrastructure.") removed the use of the func argument. Signed-off-by: Daniel Wagner --- drivers/scsi/qla2xxx/qla_gbl.h | 3 +-- drivers/scsi/qla2xxx/qla_isr.c | 36 drivers/sc

[PATCH 0/4] qla2xxx: A couple crash fixes

2020-08-27 Thread Daniel Wagner
Hi, The first crash we observed is due memory corruption in the srb memory pool. Unforuntatly, I couldn't find the source of the problem but the workaround by resetting the cleanup callbacks 'fixes' this problem (patch #1). I think as intermeditate step this should be merged until the real cause c

Re: [PATCH] mwifiex: Clean up some err and dbg messages

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The error message if 'pci_set_consistent_dma_mask()' fails is misleading. > The function call uses 32 bits, but the error message reports 64. > > Moreover, according to the comment above 'dma_set_mask_and_coherent()' > definition, such an error can never happen. > >

Re: [PATCH v2 5/7][next] printk: ringbuffer: add finalization/extension support

2020-08-27 Thread John Ogness
On 2020-08-26, Petr Mladek wrote: >> This series makes a very naive assumption that the previous >> descriptor is either in the reserved or committed queried states. The >> fact is, it can be in any of the 4 queried states. Adding support for >> finalization of all the states then gets quite compl

Re: [PATCH] scripts: Add intended executable mode and SPDX license

2020-08-27 Thread Greg KH
ut the > > > executable bit. > > > > > > Set to usual modes for these files and provide the SPDX license for > > > spdxcheck-test.sh. No functional changes. > > > > > > Signed-off-by: Mrinal Pandey > > > --- > > > applies cl

[PATCH 0/5] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port

2020-08-27 Thread Srinivasa Rao Mandadapu
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc. It includes machine driver, cpu driver, platform driver updates for HDMI path support, device tree documention, lpass variant structure optimization and configuration changes. These patches depends on the DP patch s

Re: [PATCH][next] mwifiex: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH v3] exfat: integrates dir-entry getting and validation

2020-08-27 Thread Tetsuhiro Kohada
- /* validiate cached dentries */ - for (i = 1; i < num_entries; i++) { - ep = exfat_get_dentry_cached(es, i); - if (!exfat_validate_entry(exfat_get_entry_type(ep), &mode)) + ep = exfat_get_dentry_cached(es, ENTRY_STREAM); + if (!ep || ep->typ

Re: [PATCH v2] iio: stm32-dac: Replace indio_dev->mlock with own device lock

2020-08-27 Thread Alexandru Ardelean
On Thu, Aug 27, 2020 at 12:03 PM Fabrice Gasnier wrote: > > On 8/27/20 10:55 AM, Alexandru Ardelean wrote: > > On Wed, Aug 26, 2020 at 3:03 PM Alexandru Ardelean > > wrote: > >> From: Sergiu Cuciurean > >> > >> As part of the general cleanup of indio_dev->mlock, this change replaces > >> it with

Re: [PATCH v2] mwifiex: don't call del_timer_sync() on uninitialized timer

2020-08-27 Thread Kalle Valo
Tetsuo Handa wrote: > syzbot is reporting that del_timer_sync() is called from > mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without > checking timer_setup() from mwifiex_usb_tx_init() was called [1]. > > Ganapathi Bhat proposed a possibly cleaner fix, but it seems that > that fi

Re: [PATCH v2] opp: Power on (virtual) power domains managed by the OPP core

2020-08-27 Thread Viresh Kumar
On 26-08-20, 11:33, Stephan Gerhold wrote: > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index 8b3c3986f589..7e53a7b94c59 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > > #include "opp

Re: [PATCH 22/35] arm64: mte: Enable in-kernel MTE

2020-08-27 Thread Catalin Marinas
On Fri, Aug 14, 2020 at 07:27:04PM +0200, Andrey Konovalov wrote: > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 4d3abb51f7d4..4d94af19d8f6 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -1670,6 +1670,9 @@ static voi

[PATCH v3 1/2] iommu/vt-d:Add support for detecting ACPI device in RMRR

2020-08-27 Thread FelixCuioc
Some ACPI devices need to issue dma requests to access the reserved memory area.BIOS uses the device scope type ACPI_NAMESPACE_DEVICE in RMRR to report these ACPI devices. This patch add support for detecting ACPI devices in RMRR. Signed-off-by: FelixCuioc --- drivers/iommu/intel/dmar.c | 76 ++

[PATCH v3 2/2] iommu/vt-d:Add support for probing ACPI device in RMRR

2020-08-27 Thread FelixCuioc
After acpi device in RMRR is detected,it is necessary to establish a mapping for these devices. In acpi_device_create_direct_mappings(),create a mapping for the acpi device in RMRR. Add a helper to achieve the acpi namespace device can access the RMRR region. Signed-off-by: FelixCuioc --- driver

[PATCH v3 0/2] Add support for ACPI device in RMRR

2020-08-27 Thread FelixCuioc
BIOS allocate reserved memory ranges that may be DMA targets. BIOS may report each such reserved memory region through the RMRR structures,along with the devices that requires access to the specified reserved memory region. The purpose of this series is to achieve ACPI device in RMRR access reserv

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_sdio_probe

2020-08-27 Thread Kalle Valo
Dinghao Liu wrote: > When devm_clk_get() returns -EPROBE_DEFER, sdio_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 8692b047e86cf ("staging: wilc1000: look for rtc_clk clock") > Signed-off-by: Dinghao Liu > Acked-by: Ajay Singh Patch applied to wireless-drivers

Re: [PATCH] rtw88: switch from 'pci_' to 'dma_' API

2020-08-27 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'rtw_pci_i

Re: [PATCH][next] rtw88: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_bus_probe

2020-08-27 Thread Kalle Valo
Dinghao Liu wrote: > When devm_clk_get() returns -EPROBE_DEFER, spi_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode") > Signed-off-by: Dinghao Liu > Acked-by: Ajay Singh Patch applied to wirel

Re: [PATCH v4 09/17] arm64: dts: mt8183: add encoder node

2020-08-27 Thread Matthias Brugger
On 21/08/2020 12:36, Alexandre Courbot wrote: Now that the MT8183 encoder driver is ready, add its DT node. Also pull the iommu and scp ones, which the encoder depends upon. Please don't do that. Instead of pulling in other DT nodes, it would be handy to get a reference of the series this i

[PATCH] opp: Drop unnecessary check frmo dev_pm_opp_attach_genpd()

2020-08-27 Thread Viresh Kumar
Since commit c0ab9e0812da ("opp: Allocate genpd_virt_devs from dev_pm_opp_attach_genpd()"), the allocation of the virtual devices is moved to dev_pm_opp_attach_genpd() and this check isn't required anymore as it will always fail. Drop it. Signed-off-by: Viresh Kumar --- drivers/opp/core.c | 6 --

Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding

2020-08-27 Thread Cristian Ciocaltea
On Wed, Aug 26, 2020 at 04:48:38PM -0600, Rob Herring wrote: > On Wed, Aug 26, 2020 at 3:42 PM Cristian Ciocaltea > wrote: > > > > Hi Rob, > > > > Thanks for the review! > > > > On Tue, Aug 25, 2020 at 04:09:13PM -0600, Rob Herring wrote: > > > On Wed, Aug 19, 2020 at 07:37:56PM +0300, Cristian Ci

Re: [PATCH v4 09/17] arm64: dts: mt8183: add encoder node

2020-08-27 Thread Alexandre Courbot
On Thu, Aug 27, 2020 at 7:03 PM Matthias Brugger wrote: > > > > On 21/08/2020 12:36, Alexandre Courbot wrote: > > Now that the MT8183 encoder driver is ready, add its DT node. Also pull > > the iommu and scp ones, which the encoder depends upon. > > Please don't do that. Instead of pulling in othe

Re: [PATCH 1/4] qla2xxx: Reset done and free callback pointer on release

2020-08-27 Thread Martin Wilck
On Thu, 2020-08-27 at 11:58 +0200, Daniel Wagner wrote: > Reset ->done and ->free when releasing the srb. There is a hidden > use-after-free bug in the driver which corrupts the srb memory pool > which originates from the cleanup callbacks. By explicitly resetting > the callbacks to NULL, we workar

[tip: x86/cleanups] x86/mpparse: Remove duplicate io_apic.h include

2020-08-27 Thread tip-bot2 for Wang Hai
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: e33ab2064836600603289ad2ed0ca3424f395fa8 Gitweb: https://git.kernel.org/tip/e33ab2064836600603289ad2ed0ca3424f395fa8 Author:Wang Hai AuthorDate:Wed, 19 Aug 2020 19:29:10 +08:00 Committer:

Re: Kernel panic : Unable to handle kernel paging request at virtual address - dead address between user and kernel address ranges

2020-08-27 Thread Viresh Kumar
On 27-08-20, 11:48, Arnd Bergmann wrote: > > > [3.680477] dev_pm_opp_put_clkname+0x30/0x58 > > > [3.683431] sdhci_msm_probe+0x284/0x9a0 > > dev_pm_opp_put_clkname() is part of the error handling in the > probe function, so I would deduct there are two problems: > > - something failed du

[PATCH 13/23] nvidia: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/video/fbdev/nvidia/nvidia.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

Re: [PATCH v21 4/4] arm64: dts: mt8183: add scp node

2020-08-27 Thread Matthias Brugger
On 12/11/2019 12:03, Pi-Hsun Shih wrote: From: Eddie Huang Add scp node to mt8183 and mt8183-evb Signed-off-by: Erin Lo Signed-off-by: Pi-Hsun Shih Signed-off-by: Eddie Huang Sorry I somehow oversaw this. Next time please don't doubt to ping me. Bjorn, do I understand correctly that y

[PATCH 04/23] fore200e: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/atm/fore200e.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/driver

[PATCH 15/23] media/staging: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- .../staging/media/atomisp/pci/hive_isp_css_include/assert_support.h | 6 +- 1 file changed, 1 inse

[PATCH 00/23] clean up the code related to ASSERT()

2020-08-27 Thread Chunguang Xu
The kernel has not yet defined ASSERT(). Indeed, BUG() and WARN() are very clear and can cover most application scenarios. However, some applications require more debugging information and similar behavior to assert(), which cannot be directly provided by BUG() and WARN(). Therefore, many modules

[PATCH 19/23] block/sx8: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/block/sx8.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/b

[PATCH 08/23] jfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- fs/jfs/jfs_debug.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/f

[PATCH 21/23] ext4: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- fs/ext4/mballoc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/fs/ext

Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais > Sig

[PATCH 23/23] ALSA: asihpi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- sound/pci/asihpi/hpidebug.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a

[PATCH 22/23] rbd: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/block/rbd.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/driver

[PATCH 09/23] cachefiles: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- fs/cachefiles/internal.h | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/f

[PATCH 20/23] skb: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/block/skd_main.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/dr

[PATCH 16/23] sym53c8xx: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/scsi/sym53c8xx_2/sym_hipd.h | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) dif

[PATCH 12/23] rivafb: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/video/fbdev/riva/fbdev.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --g

Re: [PATCH] Platform lockdown information in sysfs (v2)

2020-08-27 Thread Arnd Bergmann
On Thu, Aug 20, 2020 at 4:51 PM Daniel Gutson wrote: > > This patch exports information about the platform lockdown > firmware configuration in the sysfs filesystem. > In this initial patch, I include some configuration attributes > for the system SPI chip. > > This initial version exports the BIO

[PATCH 17/23] 8139too: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/net/ethernet/realtek/8139too.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) dif

[PATCH 18/23] net:hns: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/net/ethernet/hisilicon/hns/hnae.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-)

[PATCH 14/23] fbdev/cirrusfb:: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/video/fbdev/cirrusfb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [PATCH 14/30] wireless: ath: ath6kl: wmi: Remove unused variable 'rate'

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath6kl/wmi.c: In function > ‘ath6kl_wmi_bitrate_reply_rx’: > drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ set > but not used [-Wunused-but-set-variable] > > Cc: Kalle V

[PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- fs/afs/internal.h | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/fs/afs/i

Re: [ANNOUNCE] v5.9-rc2-rt1

2020-08-27 Thread Daniel Wagner
On Thu, Aug 27, 2020 at 11:27:43AM +0200, Sebastian Andrzej Siewior wrote: > So v5.9-rc2-rt1 with PREEMPT_RT=y enabled leads to the problem and > v5.9-rc2-rt1 with PREEMPT_PREEMPT=y boots fine? Yes. But it must be something with uboot related since it's not the kernel printing the error message. I

Re: [PATCH 02/16] wireless: ath9k: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais > Sig

[PATCH 10/23] btrfs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- fs/btrfs/ctree.h | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/fs/b

[PATCH 01/23] include/asm-generic/bug.h: add ASSERT_FAIL() and ASSERT_WARN() wrapper

2020-08-27 Thread Chunguang Xu
The kernel has not yet defined ASSERT(). Indeed, BUG() and WARN() are very clear and can cover most application scenarios. However, some applications require more debugging information and similar behavior to assert(), which cannot be directly provided by BUG() and WARN(). Therefore, many modules

Re: [PATCH 17/30] wireless: ath: ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280'

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/ath9k/ar9002_initvals.h:900:18: warning: > ‘ar9280PciePhy_clkreq_off_L1_9280’ defined but not used > [-Wunused-const-variable=] > > Cc: QCA ath9k Development > Cc: Kalle Valo > Cc: "David S. Mi

Re: [PATCH 4/4] qla2xxx: Handle incorrect entry_type entries

2020-08-27 Thread Martin Wilck
On Thu, 2020-08-27 at 11:58 +0200, Daniel Wagner wrote: > It was observed on an ISP8324 16Gb HBA with fw=8.08.203 (d0d5) that > pkt->entry_type was MBX_IOCB_TYPE/0x39 with an sp->type SRB_SCSI_CMD > which is invalid and should not be possible. > > A careful code review of the crash dump didn't rev

Re: [PATCH] ath9k_htc: Do not select MAC80211_LEDS by default

2020-08-27 Thread Kalle Valo
Krzysztof Kozlowski wrote: > The ath9k_htc driver hides all LEDs related code behind > CONFIG_MAC80211_LEDS ifdefs so it does not really require the > MAC80211_LEDS. The code builds and works just fine. Convert the > "select" into "imply" to allow disabling LED trigger when not needed. > > Sig

[PATCH 07/23] lib/mpi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- lib/mpi/mpi-internal.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/m

[PATCH 06/23] rxrpc: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- net/rxrpc/ar-internal.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/net

Re: [PATCH] ath9k: Do not select MAC80211_LEDS by default

2020-08-27 Thread Kalle Valo
Krzysztof Kozlowski wrote: > The ath9k driver hides all LEDs related code behind CONFIG_MAC80211_LEDS > ifdefs so it does not really require the MAC80211_LEDS. The code builds > fine. Convert the "select" into "imply" to allow disabling LED trigger > when not needed. > > Signed-off-by: Krzyszt

[PATCH 02/23] ia64: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- arch/ia64/hp/common/sba_iommu.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 03/23] KVM: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- arch/x86/kvm/ioapic.h | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/arch

[PATCH 05/23] scsi: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

2020-08-27 Thread Chunguang Xu
Since ASSERT_FAIL() and ASSERT_WARN() have been provided, ASSERT() may be realized through them, thus reducing code redundancy and facilitating problem analysis. Signed-off-by: Chunguang Xu --- drivers/scsi/megaraid/mega_common.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-)

Re: [PATCH] ath11k: return error if firmware request fails

2020-08-27 Thread Kalle Valo
Alex Dewar wrote: > In ath11k_qmi_prepare_bdf_download(), ath11k_core_firmware_request() is > called, but the returned pointer is not checked for errors. Rather the > variable ret (which will always be zero) is checked by mistake. Fix > this and replace the various gotos with simple returns for c

Re: [PATCH 21/28] wireless: ath: wil6210: debugfs: Fix a couple of formatting issues in 'wil6210_debugfs_init'

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > gets confused if the variable does not follow the type/attribute > definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function pa

Re: [PATCH][next] carl9170: Use fallthrough pseudo-keyword

2020-08-27 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH 03/16] wireless: ath: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Kalle Valo
Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais > Ack

[PATCH] fs: Optimized fget to improve performance

2020-08-27 Thread Shaokun Zhang
From: Yuqi Jin It is well known that the performance of atomic_add is better than that of atomic_cmpxchg. The initial value of @f_count is 1. While @f_count is increased by 1 in __fget_files, it will go through three phases: > 0, < 0, and = 0. When the fixed value 0 is used as the condition for t

Re: [PATCH] lib: kunit: add list_sort test conversion to KUnit

2020-08-27 Thread Marco Elver
On Wed, Jul 29, 2020 at 04:23PM -0300, Vitor Massaru Iha wrote: > This adds the conversion of the runtime tests of test_list_sort, > from `lib/test_list_sort.c` to KUnit tests. > > Please apply this commit first (linux-kselftest/kunit-fixes): > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit

Re: [PATCH v2 4/7] KVM: x86: allow kvm_x86_ops.set_efer to return a value

2020-08-27 Thread Maxim Levitsky
On Thu, 2020-08-20 at 17:43 -0700, Sean Christopherson wrote: > On Thu, Aug 20, 2020 at 02:43:56PM -0700, Jim Mattson wrote: > > On Thu, Aug 20, 2020 at 6:34 AM Maxim Levitsky wrote: > > > This will be used later to return an error when setting this msr fails. > > > > > > For VMX, it already has

Re: [PATCH v4 09/17] arm64: dts: mt8183: add encoder node

2020-08-27 Thread Matthias Brugger
Hi Alexandre, On 27/08/2020 12:10, Alexandre Courbot wrote: On Thu, Aug 27, 2020 at 7:03 PM Matthias Brugger wrote: On 21/08/2020 12:36, Alexandre Courbot wrote: Now that the MT8183 encoder driver is ready, add its DT node. Also pull the iommu and scp ones, which the encoder depends upon.

Re: [ANNOUNCE] v5.9-rc2-rt1

2020-08-27 Thread Sebastian Andrzej Siewior
On 2020-08-27 12:16:22 [+0200], Daniel Wagner wrote: > The -rt kernel is roughly 6MB larger. Just need to check the memory > ranges u-boot is using. so that 6MiB sounded bad but then it is ~36MiB in total so…. Is this full debug and so on? Sebastian

Re: [PATCH 8/9] dt-bindings: net: renesas,ravb: Add support for r8a774e1 SoC

2020-08-27 Thread Lad, Prabhakar
Hi David, On Mon, Jul 13, 2020 at 10:36 PM Lad Prabhakar wrote: > > From: Marian-Cristian Rotariu > > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + > 1

Re: [PATCH 20/35] arm64: mte: Add in-kernel MTE helpers

2020-08-27 Thread Vincenzo Frascino
Hi Catalin, On 8/27/20 10:38 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:02PM +0200, Andrey Konovalov wrote: >> diff --git a/arch/arm64/include/asm/mte.h b/arch/arm64/include/asm/mte.h >> index 1c99fcadb58c..733be1cb5c95 100644 >> --- a/arch/arm64/include/asm/mte.h >> +++ b/arch/arm

Re: [PATCH v4 09/17] arm64: dts: mt8183: add encoder node

2020-08-27 Thread Alexandre Courbot
Hi Matthias, On Thu, Aug 27, 2020 at 7:23 PM Matthias Brugger wrote: > > Hi Alexandre, > > On 27/08/2020 12:10, Alexandre Courbot wrote: > > On Thu, Aug 27, 2020 at 7:03 PM Matthias Brugger > > wrote: > >> > >> > >> > >> On 21/08/2020 12:36, Alexandre Courbot wrote: > >>> Now that the MT8183 en

Re: [PATCH v10 01/16] s390/vfio-ap: add version vfio_ap module

2020-08-27 Thread Cornelia Huck
On Wed, 26 Aug 2020 10:49:47 -0400 Tony Krowiak wrote: > On 8/25/20 6:04 AM, Cornelia Huck wrote: > > On Fri, 21 Aug 2020 15:56:01 -0400 > > Tony Krowiak wrote: > > > >> Let's set a version for the vfio_ap module so that automated regression > >> tests can determine whether dynamic configurati

Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding

2020-08-27 Thread Marc Zyngier
On 2020-08-27 11:06, Cristian Ciocaltea wrote: On Wed, Aug 26, 2020 at 04:48:38PM -0600, Rob Herring wrote: On Wed, Aug 26, 2020 at 3:42 PM Cristian Ciocaltea wrote: [...] Ultimately the GIC trigger type has to be something. Is it fixed or passed thru? If the latter, just use 0 (IRQ_TYPE_NO

Re: [PATCH v2 0/3] Add Actions Semi S500 pinctrl support

2020-08-27 Thread Cristian Ciocaltea
On Thu, Aug 27, 2020 at 10:41:23AM +0200, Linus Walleij wrote: > On Mon, Aug 3, 2020 at 4:21 PM Cristian Ciocaltea > wrote: > > > This patchset adds pinctrl support for Actions Semi S500 SoC. > > > > Pinmux functions are only accessible for pin groups while pinconf > > parameters are available fo

Re: [PATCH 1/4] arm: dts: owl-s500: Fix incorrect PPI interrupt specifiers

2020-08-27 Thread Cristian Ciocaltea
On Thu, Aug 27, 2020 at 08:29:06AM +0200, Peter Korsgaard wrote: > > "Cristian" == Cristian Ciocaltea writes: > > > The PPI interrupts for cortex-a9 were incorrectly specified, fix them. > > Fixes: fdfe7f4f9d85 ("ARM: dts: Add Actions Semi S500 and LeMaker Guitar") > > Signed-off-by: Crist

drivers/net/wireless/realtek/rtw88/rtw8821c.c:71:8: warning: type qualifiers ignored on function return type

2020-08-27 Thread kernel test robot
weeks ago config: arm-randconfig-r012-20200827 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git

Re: [PATCH 24/35] arm64: mte: Switch GCR_EL1 in kernel entry and exit

2020-08-27 Thread Catalin Marinas
On Fri, Aug 14, 2020 at 07:27:06PM +0200, Andrey Konovalov wrote: > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > index cde127508e38..a17fefb0571b 100644 > --- a/arch/arm64/kernel/entry.S > +++ b/arch/arm64/kernel/entry.S > @@ -172,6 +172,29 @@ alternative_else_nop_endif > #

<    1   2   3   4   5   6   7   8   9   10   >