Re: [PATCH V2 2/3] pwm: imx27: Use dev_err_probe() to simplify error handling

2020-08-11 Thread Uwe Kleine-König
On Tue, Aug 11, 2020 at 02:24:31PM +0800, Anson Huang wrote: > dev_err_probe() can reduce code size, uniform error handling and record the > defer probe reason etc., use it to simplify the code. > > Signed-off-by: Anson Huang Acked-by: Uwe Kleine-König Best regards Uwe -- Pengutronix e.K.

Re: [PATCH] x86/paravirt: Add missing noinstr to arch_local*() helpers

2020-08-11 Thread Marco Elver
On Fri, 7 Aug 2020 at 17:19, Marco Elver wrote: > On Fri, Aug 07, 2020 at 02:08PM +0200, Marco Elver wrote: > > On Fri, 7 Aug 2020 at 14:04, Jürgen Groß wrote: > > > > > > On 07.08.20 13:38, Marco Elver wrote: > > > > On Fri, Aug 07, 2020 at 12:35PM +0200, Jürgen Groß wrote: ... > > > >> I think

Re: [PATCH V2 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling

2020-08-11 Thread Uwe Kleine-König
On Tue, Aug 11, 2020 at 02:24:30PM +0800, Anson Huang wrote: > dev_err_probe() can reduce code size, uniform error handling and record the > defer probe reason etc., use it to simplify the code. > > Signed-off-by: Anson Huang Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K.

[PATCH] erofs: avoid duplicated permission check for "trusted." xattrs

2020-08-11 Thread Gao Xiang
Don't recheck it since xattr_permission() already checks CAP_SYS_ADMIN capability. Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for "trusted." xattrs") Reported-by: Hongyu Jin [ Gao Xiang: since it could cause some complex Android overlay permission issue as well on andr

Re: general protection fault in qrtr_endpoint_post

2020-08-11 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 8ff41cc21714704ef0158a546c3c4d07fae2c952 Author: Dan Carpenter Date: Tue Jun 30 11:46:15 2020 + net: qrtr: Fix an out of bounds read qrtr_endpoint_post() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10f1cfe690

Re: [PATCH v2 1/5] dt-bindings: ARM: Mediatek: Document bindings for MT8192

2020-08-11 Thread Weiyi Lu
On Wed, 2020-07-29 at 11:53 +0200, Enric Balletbo Serra wrote: > Hi Weiyu, > > Thanks for the patch, some comments below. I am not sure what > maintainers think but your patches, in general, are really big and I'm > wondering if wouldn't be better split by functionalities. Will make > your series

Re: [PATCH] soc: imx: gpcv2: Use dev_err_probe() to simplify error handling

2020-08-11 Thread Guido Günther
Hi, On Tue, Aug 11, 2020 at 11:04:42AM +0800, Anson Huang wrote: > dev_err_probe() can reduce code size, uniform error handling and record the > defer probe reason etc., use it to simplify the code. > > Signed-off-by: Anson Huang > --- > drivers/soc/imx/gpcv2.c | 15 +-- > 1 file cha

Re: [PATCH v2 5/5] clk: mediatek: Add MT8192 clock support

2020-08-11 Thread Weiyi Lu
On Wed, 2020-07-29 at 11:32 +0200, Enric Balletbo Serra wrote: > Hi Weiyi, > > Thank you for your patch. Some few comment below, I'll focus on > clk-mt8192-mm file, but I think can apply to other files too. > > [snip] > > > diff --git a/drivers/clk/mediatek/clk-mt8192-mm.c > > b/drivers/clk/med

Re: [PATCH] x86/paravirt: Add missing noinstr to arch_local*() helpers

2020-08-11 Thread Jürgen Groß
On 11.08.20 09:00, Marco Elver wrote: On Fri, 7 Aug 2020 at 17:19, Marco Elver wrote: On Fri, Aug 07, 2020 at 02:08PM +0200, Marco Elver wrote: On Fri, 7 Aug 2020 at 14:04, Jürgen Groß wrote: On 07.08.20 13:38, Marco Elver wrote: On Fri, Aug 07, 2020 at 12:35PM +0200, Jürgen Groß wrote: .

[PATCH V2 1/2] thermal: imx: Use dev_err_probe() to simplify error handling

2020-08-11 Thread Anson Huang
dev_err_probe() can reduce code size, uniform error handling and record the defer probe reason etc., use it to simplify the code. Signed-off-by: Anson Huang --- changes since V1: - remove redundant return value print. --- drivers/thermal/imx_thermal.c | 22 ++ 1 file

[PATCH V2 2/2] thermal: imx8mm: Use dev_err_probe() to simplify error handling

2020-08-11 Thread Anson Huang
dev_err_probe() can reduce code size, uniform error handling and record the defer probe reason etc., use it to simplify the code. Signed-off-by: Anson Huang --- changes since V1: - remove redundant return value print. --- drivers/thermal/imx8mm_thermal.c | 10 +++--- 1 file changed,

Re: Re: [PATCH] riscv: Setup exception vector for K210 properly

2020-08-11 Thread 邱文博
The serial port did not print anything after early console. [0.00] Sorting __ex_table... [0.00] mem auto-init: stack:off, heap alloc:off, heap free:off [0.00] Memory: 6480K/8192K available (1024K kernel code, 111K rwdata, 170K rodata, 101K init, 97K bss, 1712K reserved, 0

Re: [Linux-kernel-mentees] [PATCH net] ipvs: Fix uninit-value in do_ip_vs_set_ctl()

2020-08-11 Thread Julian Anastasov
Hello, On Tue, 11 Aug 2020, Peilin Ye wrote: > On Mon, Aug 10, 2020 at 08:57:19PM -0700, Cong Wang wrote: > > On Mon, Aug 10, 2020 at 3:10 PM Peilin Ye wrote: > > > > > > do_ip_vs_set_ctl() is referencing uninitialized stack value when `len` is > > > zero. Fix it. > > > > Which exact

Re: [PATCH v11 12/12] dmaengine: imx-sdma: add uart rom script

2020-08-11 Thread Frieder Schrempf
On 10.08.20 12:57, Robin Gong wrote: On 2020/08/10 15:33 Frieder Schrempf wrote: Hi Robin, This patch seems to break UART DMA in case the ROM firmware is used. In that case sdma->script_number is set to SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1, so the ROM scripts at uart_2_mcu_addr and uartsh_2_mcu_add

Re: [PATCH 5.7 00/79] 5.7.15-rc1 review

2020-08-11 Thread Naresh Kamboju
On Mon, 10 Aug 2020 at 20:52, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.7.15 release. > There are 79 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

Re: [PATCH v4] coccinelle: api: add kzfree script

2020-08-11 Thread Denis Efremov
On 8/11/20 2:45 AM, Eric Biggers wrote: > On Fri, Jul 17, 2020 at 10:39:20PM +0200, Julia Lawall wrote: >> >> >> On Fri, 17 Jul 2020, Denis Efremov wrote: >> >>> Check for memset()/memzero_explicit() followed by kfree()/vfree()/kvfree(). >>> >>> Signed-off-by: Denis Efremov >> >> Applied. > >

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-11 Thread Felipe Balbi
Hi, Wesley Cheng writes: > On 8/10/2020 5:27 AM, Felipe Balbi wrote: >> Wesley Cheng writes: >> >> Hi, >> >>> Some devices have USB compositions which may require multiple endpoints >>> that support EP bursting. HW defined TX FIFO sizes may not always be >>> sufficient for these compositions

drivers/video/fbdev/tridentfb.c:736:9: sparse: sparse: incorrect type in argument 2 (different address spaces)

2020-08-11 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 086ba2ec163b638abd2a90ef3e8bab0238d02e56 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 8 weeks ago config: riscv-randconfig-s032-20200810 (attached

Re: [f2fs-dev] [PATCH] f2fs: change virtual mapping way for compression pages

2020-08-11 Thread Gao Xiang
On Tue, Aug 11, 2020 at 12:37:53PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > By profiling f2fs compression works, I've found vmap() callings are > bottlenecks of f2fs decompression path. Changing these with > vm_map_ram(), we can enhance f2fs decompression speed pretty much. > > [Verific

Re: [PATCH v36 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call

2020-08-11 Thread Jethro Beekman
On 2020-08-11 00:23, Sean Christopherson wrote: > Another thought would be to wrap sgx_enclave_exception in a struct to give > room for supporting additional exit information (if such a thing ever pops > up) and to allow the caller to opt in to select behavior, e.g. Jethro's > request to invoke the

Re: [Linux-kernel-mentees] [PATCH net] ipvs: Fix uninit-value in do_ip_vs_set_ctl()

2020-08-11 Thread Peilin Ye
On Tue, Aug 11, 2020 at 09:58:46AM +0300, Julian Anastasov wrote: > > Hello, > > On Tue, 11 Aug 2020, Peilin Ye wrote: > > > On Mon, Aug 10, 2020 at 08:57:19PM -0700, Cong Wang wrote: > > > On Mon, Aug 10, 2020 at 3:10 PM Peilin Ye wrote: > > > > > > > > do_ip_vs_set_ctl() is referencing

Re: [PATCH v4 0/6] mm / virtio-mem: support ZONE_MOVABLE

2020-08-11 Thread David Hildenbrand
On 11.08.20 04:21, Andrew Morton wrote: > On Mon, 10 Aug 2020 09:56:32 +0200 David Hildenbrand wrote: > >> On 04.08.20 21:41, David Hildenbrand wrote: >>> @Andrew can we give this a churn and consider it for v5.9 in case there >>> are no more comments? >> >> @Andrew, Ping, so I assume we'll targe

[PATCH] driver core: Let dev_err_probe() use the symbolic error code

2020-08-11 Thread Uwe Kleine-König
This makes the error message: error -EIO: ... instead of error -5: ... Signed-off-by: Uwe Kleine-König --- drivers/base/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index ac1046a382bc..33734d8831c7 100

Re: [PATCH v2 4/4] mm/hugetl.c: warn out if expected count of huge pages adjustment is not achieved

2020-08-11 Thread Michal Hocko
On Mon 10-08-20 20:35:25, Mike Kravetz wrote: > Cc: Michal > > On 8/10/20 7:11 PM, Baoquan He wrote: > > Hi Mike, > > > > On 07/23/20 at 11:21am, Mike Kravetz wrote: > >> On 7/23/20 2:11 AM, Baoquan He wrote: > > ... > But is kernel expected to warn for all such situations where the user > >

Re: [PATCH v2 1/3] perf bench numa: use numa_node_to_cpus() to bind tasks to nodes

2020-08-11 Thread Namhyung Kim
Hello, On Mon, Aug 10, 2020 at 3:22 PM Alexander Gordeev wrote: > > It is currently assumed that each node contains at most > nr_cpus/nr_nodes CPUs and node CPU ranges do not overlap. > That assumption is generally incorrect as there are archs > where a CPU number does not depend on to its node n

Re: [PATCH v2 2/3] perf bench numa: fix number of processes in "2x3-convergence" test

2020-08-11 Thread Namhyung Kim
On Mon, Aug 10, 2020 at 3:22 PM Alexander Gordeev wrote: > > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Signed-off-by: Alexander Gordeev Acked-by: Namhyung Kim Thanks Namhyung > --

Re: [PATCH v2 4/5] clk: mediatek: Add configurable enable control to mtk_pll_data

2020-08-11 Thread Nicolas Boichat
On Tue, Aug 11, 2020 at 2:43 PM Weiyi Lu wrote: > [...] > > > + writel(r, pll->en_addr); > > > > > > r = readl(pll->pwr_addr) | CON0_ISO_EN; > > > writel(r, pll->pwr_addr); > > > @@ -327,6 +327,10 @@ static struct clk *mtk_clk_register_pll(const struct > > > mtk_pll_data *da

Re: [PATCH 5.4 00/67] 5.4.58-rc1 review

2020-08-11 Thread Naresh Kamboju
On Mon, 10 Aug 2020 at 20:57, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.58 release. > There are 67 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

[PATCH] init/Kconfig: Fix CPU number in LOG_CPU_MAX_BUF_SHIFT description

2020-08-11 Thread Paul Menzel
Currently, LOG_BUF_SHIFT defaults to 17, which is 2 ^ 17 bytes = 128 KB, and LOG_CPU_MAX_BUF_SHIFT defaults to 12, which is 2 ^ 12 bytes = 4 KB. Half of 128 KB is 64 KB, so more than 16 CPUs are required for the value to be used, as then the sum of contributions is greater than 64 KB for the first

[PATCH v12 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2020-08-11 Thread Robin Gong
There are two ways for SDMA accessing SPBA devices: one is SDMA->AIPS ->SPBA(masterA port), another is SDMA->SPBA(masterC port). Please refer to the 'Figure 58-1. i.MX 6Dual/6Quad SPBA connectivity' of i.mx6DQ Reference Manual. SDMA provide the corresponding app_2_mcu/mcu_2_app and shp_2_mcu/mcu_

[PATCH v12 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2020-08-11 Thread Robin Gong
There are two ways for SDMA accessing SPBA devices: one is SDMA->AIPS ->SPBA(masterA port), another is SDMA->SPBA(masterC port). Please refer to the 'Figure 58-1. i.MX 6Dual/6Quad SPBA connectivity' of i.mx6DQ Reference Manual. SDMA provide the corresponding app_2_mcu/mcu_2_app and shp_2_mcu/mcu_2_

[PATCH v12 03/12] Revert "dmaengine: imx-sdma: refine to load context only once"

2020-08-11 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong Acked-by: Sascha Hauer --- drivers/dma/imx-sdma.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers

[PATCH v12 00/12] add ecspi ERR009165 for i.mx6/7 soc family

2020-08-11 Thread Robin Gong
There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO transfer to be send twice in DMA mode. Please get more information from: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding new sdma ram script which works in XCH mode as PIO inside sdma instead of SMC mode, me

[PATCH v12 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context

2020-08-11 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/d

[PATCH v12 10/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2020-08-11 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx

[PATCH v12 09/12] spi: imx: add new i.mx6ul compatible name in binding doc

2020-08-11 Thread Robin Gong
ERR009165 fixed from i.mx6ul, add its compatible name in binding doc. Signed-off-by: Robin Gong Acked-by: Mark Brown Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi/fsl

[PATCH v12 07/12] spi: imx: fix ERR009165

2020-08-11 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-imx.c b

[PATCH v12 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script

2020-08-11 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index cf02c3e..d5d5d40 100644 --- a/drivers/dma/imx-sdma.c +++

[PATCH v12 11/12] dma: imx-sdma: add i.mx6ul compatible name

2020-08-11 Thread Robin Gong
Add i.mx6ul compatible name in binding doc. Signed-off-by: Robin Gong Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree/bindin

[PATCH v12 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul

2020-08-11 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/s

[PATCH v12 12/12] dmaengine: imx-sdma: add uart rom script

2020-08-11 Thread Robin Gong
For the compatibility of NXP internal legacy kernel before 4.19 which is based on uart ram script and upstreaming kernel based on uart rom script, add both uart ram/rom script in latest sdma firmware. By default uart rom script used. Besides, add two multi-fifo scripts for SAI/PDM on i.mx8m/8mm and

[PATCH v12 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script

2020-08-11 Thread Robin Gong
Add 'fw_loaded' and 'is_ram_script' to check if the script used by channel is ram script and it's loaded or not, so that could prevent meaningless following malloc dma descriptor and bd allocate in sdma_transfer_init(), otherwise memory may be consumed out potentially without free in case that spi

Re: [PATCH] x86/paravirt: Add missing noinstr to arch_local*() helpers

2020-08-11 Thread Peter Zijlstra
On Fri, Aug 07, 2020 at 05:19:03PM +0200, Marco Elver wrote: > My hypothesis here is simply that kvm_wait() may be called in a place > where we get the same case I mentioned to Peter, > > raw_local_irq_save(); /* or other IRQs off without tracing */ > ... > kvm_wait() /* IRQ sta

Re: [PATCH v3 2/2] ASoC: Intel: Add period size constraint on strago board

2020-08-11 Thread Takashi Iwai
On Tue, 11 Aug 2020 04:29:24 +0200, Yu-Hsuan Hsu wrote: > > Lu, Brent 於 2020年8月11日 週二 上午10:17寫道: > > > > > > > > Sorry for the late reply. CRAS does not set the period size when using it. > > > The default period size is 256, which consumes the samples quickly(about > > > 49627 > > > fps when th

[PATCH V2] serial: qcom_geni_serial: To correct QUP Version detection logic

2020-08-11 Thread Paras Sharma
The current implementation reduces the sampling rate by half if qup HW version greater is than 2.5 by checking if the geni SE major version is greater than 2 and geni SE minor version is greater than 5. This implementation fails when the version is 3 or greater. Hence by adding the another check

Re: [PATCH] riscv: Setup exception vector for K210 properly

2020-08-11 Thread Damien Le Moal
On 2020/08/11 16:06, 邱文博 wrote: > The serial port did not print anything after early console. > > [0.00] Sorting __ex_table... > [0.00] mem auto-init: stack:off, heap alloc:off, heap free:off > [0.00] Memory: 6480K/8192K available (1024K kernel code, 111K rwdata, > 170K r

MFD for v5.9

2020-08-11 Thread Lee Jones
Good morning Linus, Enjoy! The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git mfd-next-5.9 for you to fetch changes up to e

[PATCH] coccinelle: api: update kzfree script to kfree_sensitive

2020-08-11 Thread Denis Efremov
Commit 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()") renames kzfree to kfree_sensitive and uses memzero_explicit(...) instead of memset(..., 0, ...) internally. Update cocci script to reflect these changes. Signed-off-by: Denis Efremov --- Julia, I think you can squash this

[Linux-kernel-mentees] [PATCH net-next v2] ipvs: Fix uninit-value in do_ip_vs_set_ctl()

2020-08-11 Thread Peilin Ye
do_ip_vs_set_ctl() is referencing uninitialized stack value when `len` is zero. Fix it. Reported-by: syzbot+23b5f9e7caf61d9a3...@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?id=46ebfb92a8a812621a001ef04d90dfa459520fe2 Suggested-by: Julian Anastasov Signed-off-by: Peilin Ye

[GIT PULL] Backlight for v5.9

2020-08-11 Thread Lee Jones
Good morning Linus, Enjoy! The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git backlight-next-5.9 for you to fetch ch

Re: [PATCH v1 2/2] perf/core: Fake regs for leaked kernel samples

2020-08-11 Thread Jin, Yao
Hi Peter, On 8/6/2020 10:26 AM, Jin, Yao wrote: Hi Peter, On 8/5/2020 8:44 PM, pet...@infradead.org wrote: On Wed, Aug 05, 2020 at 10:15:26AM +0800, Jin, Yao wrote: Hi Peter, On 8/4/2020 7:49 PM, pet...@infradead.org wrote: On Fri, Jul 31, 2020 at 10:56:17AM +0800, Jin Yao wrote: @@ -6973,

Re: [PATCH v4 2/4] iio:temperature:mlx90632: Adding extended calibration option

2020-08-11 Thread Crt Mori
On Sun, 9 Aug 2020 at 23:05, Crt Mori wrote: > > On Sun, 9 Aug 2020 at 15:32, Jonathan Cameron wrote: > > > > On Sat, 8 Aug 2020 23:57:59 +0200 > > Crt Mori wrote: > > > > > Hi, > > > I am very sorry you missed them, I thought you saw it (reply on v3 of > > > the patch). Maybe something happened

Re: [PATCH 1/2 v3] rseq/membarrier: add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ

2020-08-11 Thread Peter Zijlstra
On Tue, Aug 11, 2020 at 08:27:33AM +0200, Peter Zijlstra wrote: > SYSCALL_DEFINE2(membarrier, int, cmd, int, flags) > { > + int cflags = 0, int cpuid = -1; > + > if (unlikely(flags) && cmd != MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ) > return -EINVAL; > + > + if (cmd & (M

[PATCH] Revert "mm/vmstat.c: do not show lowmem reserve protection information of empty zone"

2020-08-11 Thread Baoquan He
This reverts commit 26e7deadaae1755faf1f6d1a68988c4b8348df59. Sonny reported that one of their tests started failing on the latest kernel on their Chrome OS platform. The root cause is that the above commit removed the protection line of empty zone, while the parser used in the test relies on the

Re: [f2fs-dev] [PATCH] f2fs: change virtual mapping way for compression pages

2020-08-11 Thread Chao Yu
On 2020/8/11 15:15, Gao Xiang wrote: On Tue, Aug 11, 2020 at 12:37:53PM +0900, Daeho Jeong wrote: From: Daeho Jeong By profiling f2fs compression works, I've found vmap() callings are bottlenecks of f2fs decompression path. Changing these with vm_map_ram(), we can enhance f2fs decompression sp

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-08-11 Thread Martin Kepplinger
On 10.08.20 16:13, Alan Stern wrote: > On Mon, Aug 10, 2020 at 02:03:17PM +0200, Martin Kepplinger wrote: >> On 09.08.20 17:26, Alan Stern wrote: >>> This is a somewhat fragile approach. You don't know for certain that >>> scsi_noretry_cmd will be called. Also, scsi_noretry_cmd can be called >>

Re: [PATCH] init/Kconfig: Fix CPU number in LOG_CPU_MAX_BUF_SHIFT description

2020-08-11 Thread Petr Mladek
On Tue 2020-08-11 09:31:45, Paul Menzel wrote: > Currently, LOG_BUF_SHIFT defaults to 17, which is 2 ^ 17 bytes = 128 KB, > and LOG_CPU_MAX_BUF_SHIFT defaults to 12, which is 2 ^ 12 bytes = 4 KB. > > Half of 128 KB is 64 KB, so more than 16 CPUs are required for the value > to be used, as then the

Re: [PATCH] x86/paravirt: Add missing noinstr to arch_local*() helpers

2020-08-11 Thread Jürgen Groß
On 11.08.20 09:41, Peter Zijlstra wrote: On Fri, Aug 07, 2020 at 05:19:03PM +0200, Marco Elver wrote: My hypothesis here is simply that kvm_wait() may be called in a place where we get the same case I mentioned to Peter, raw_local_irq_save(); /* or other IRQs off without tracing */

Re: [PATCH AUTOSEL 4.4 03/16] fs/btrfs: Add cond_resched() for try_release_extent_mapping() stalls

2020-08-11 Thread David Sterba
On Mon, Aug 10, 2020 at 03:14:30PM -0400, Sasha Levin wrote: > From: "Paul E. McKenney" > > [ Upstream commit 9f47eb5461aaeb6cb8696f9d11503ae90e4d5cb0 ] > > Very large I/Os can cause the following RCU CPU stall warning: > > RIP: 0010:rb_prev+0x8/0x50 > Code: 49 89 c0 49 89 d1 48 89 c2 48 89 f8

Re: [PATCH v6 07/18] nitro_enclaves: Init misc device providing the ioctl interface

2020-08-11 Thread Paraschiv, Andra-Irina
On 10/08/2020 08:22, Alexander Graf wrote: On 05.08.20 11:10, Andra Paraschiv wrote: The Nitro Enclaves driver provides an ioctl interface to the user space for enclave lifetime management e.g. enclave creation / termination and setting enclave resources such as memory and CPU. This ioctl

Re: [PATCH] drm: amdgpu: Use the correct size when allocating memory

2020-08-11 Thread Dan Carpenter
On Mon, Aug 10, 2020 at 08:41:14PM +0200, Marion & Christophe JAILLET wrote: > > Le 10/08/2020 à 17:42, Dan Carpenter a écrit : > > On Sun, Aug 09, 2020 at 10:34:06PM +0200, Christophe JAILLET wrote: > > > When '*sgt' is allocated, we must allocated 'sizeof(**sgt)' bytes instead > > > of 'sizeof(*

Re: [PATCH v1 2/2] perf/core: Fake regs for leaked kernel samples

2020-08-11 Thread Peter Zijlstra
On Tue, Aug 11, 2020 at 03:50:43PM +0800, Jin, Yao wrote: > Could I post v2 which basically refers to your patch but removes some > conditions since I see some issues in test if we use these conditions. > > 1. Remove '!event->attr.exclude_hv || !event->attr.exclude_host || > !event->attr.excl

Re: [PATCH v4 5/6] at24: Support probing while off

2020-08-11 Thread Sakari Ailus
Hi Bartosz, On Mon, Aug 10, 2020 at 08:12:00PM +0200, Bartosz Golaszewski wrote: > On Mon, Aug 10, 2020 at 10:26 AM Sakari Ailus wrote: > > > > [snip] > > > > > > > Rafael: I think that there are two issues with patch 1/5: > > > 1. It adds a very specific boolean flag to a structure that's mean

Re: [PATCH V2] PCI: imx6: Do not output error message when devm_clk_get() failed with -EPROBE_DEFER

2020-08-11 Thread Lucas Stach
Am Dienstag, den 11.08.2020, 09:29 +0800 schrieb Anson Huang: > When devm_clk_get() returns -EPROBE_DEFER, i.MX6 PCI driver should > NOT print error message, use dev_err_probe() to handle it. > > Signed-off-by: Anson Huang Reviewed-by: Lucas Stach > --- > drivers/pci/controller/dwc/pci-imx6.c

Re: [PATCH] selftests/socket: Introduce simple SCM_RIGHTS tests

2020-08-11 Thread Michael Kerrisk (man-pages)
Hi, On Mon, 10 Aug 2020 at 23:52, Kees Cook wrote: > > This makes sure that simple SCM_RIGHTS fd passing works as expected, to > avoid any future regressions. This is mostly code from Michael Kerrisk's > examples on how to set up and perform fd passing with SCM_RIGHTS. Add > a test script and wir

Re: [PATCH] drm: amdgpu: Use the correct size when allocating memory

2020-08-11 Thread Dan Carpenter
On Tue, Aug 11, 2020 at 10:57:02AM +0300, Dan Carpenter wrote: > On Mon, Aug 10, 2020 at 08:41:14PM +0200, Marion & Christophe JAILLET wrote: > > > > Le 10/08/2020 à 17:42, Dan Carpenter a écrit : > > > On Sun, Aug 09, 2020 at 10:34:06PM +0200, Christophe JAILLET wrote: > > > > When '*sgt' is allo

Re: [PATCH V5 0/3] Intel Platform Monitoring Technology

2020-08-11 Thread Lee Jones
On Mon, 10 Aug 2020, David E. Box wrote: > Friendly ping. Don't do that. Sending contentless pings is seldom helpful. If you think your set has been dropped please just send a [RESEND]. This is probably worth doing anyway, since you've sent v2, v3, v4 and now v5 has reply-tos of one another.

RE: [PATCH v7 0/7] Add support for O_MAYEXEC

2020-08-11 Thread David Laight
> On 11/08/2020 00:28, Al Viro wrote: > > On Mon, Aug 10, 2020 at 10:09:09PM +, David Laight wrote: > >>> On Mon, Aug 10, 2020 at 10:11:53PM +0200, Mickaël Salaün wrote: > It seems that there is no more complains nor questions. Do you want me > to send another series to fix the order

Re: [PATCH v2 1/3] perf bench numa: use numa_node_to_cpus() to bind tasks to nodes

2020-08-11 Thread Alexander Gordeev
On Tue, Aug 11, 2020 at 04:26:50PM +0900, Namhyung Kim wrote: > Hello, > > On Mon, Aug 10, 2020 at 3:22 PM Alexander Gordeev > wrote: > > > > It is currently assumed that each node contains at most > > nr_cpus/nr_nodes CPUs and node CPU ranges do not overlap. > > That assumption is generally inco

Re: [PATCH] bfq: fix blkio cgroup leakage

2020-08-11 Thread Dmitry Monakhov
Paolo Valente writes: >> Il giorno 9 lug 2020, alle ore 10:19, Dmitry Monakhov >> ha scritto: >> >> Paolo Valente writes: >> Il giorno 8 lug 2020, alle ore 19:48, Dmitry Monakhov ha scritto: Paolo Valente writes: > Hi, > sorry for the delay. The commi

Re: [PATCH 1/2] perf: Add closing sibling events' file descriptors

2020-08-11 Thread Alexey Budankov
On 10.08.2020 23:36, Peter Zijlstra wrote: > On Mon, Aug 10, 2020 at 07:45:18AM -0700, Andi Kleen wrote: > >> Unfortunately we're kind of stuck with the old NFILE=1024 default >> even though it makes little sense on modern servers. > > Why can't that be changed? It seems to me all of userspace

Re: [PATCH] x86/paravirt: Add missing noinstr to arch_local*() helpers

2020-08-11 Thread Peter Zijlstra
On Tue, Aug 11, 2020 at 09:57:55AM +0200, Jürgen Groß wrote: > On 11.08.20 09:41, Peter Zijlstra wrote: > > On Fri, Aug 07, 2020 at 05:19:03PM +0200, Marco Elver wrote: > > > > > My hypothesis here is simply that kvm_wait() may be called in a place > > > where we get the same case I mentioned to P

Re: [PATCH v6 08/18] nitro_enclaves: Add logic for creating an enclave VM

2020-08-11 Thread Paraschiv, Andra-Irina
On 10/08/2020 09:11, Alexander Graf wrote: On 05.08.20 11:10, Andra Paraschiv wrote: Add ioctl command logic for enclave VM creation. It triggers a slot allocation. The enclave resources will be associated with this slot and it will be used as an identifier for triggering enclave run. Retu

[PATCH v2] ata: sata_rcar: Fix DMA boundary mask

2020-08-11 Thread Geert Uytterhoeven
Before commit 9495b7e92f716ab2 ("driver core: platform: Initialize dma_parms for platform devices"), the R-Car SATA device didn't have DMA parameters. Hence the DMA boundary mask supplied by its driver was silently ignored, as __scsi_init_queue() doesn't check the return value of dma_set_seg_bound

Re: [PATCH] x86/paravirt: Add missing noinstr to arch_local*() helpers

2020-08-11 Thread Jürgen Groß
On 11.08.20 10:12, Peter Zijlstra wrote: On Tue, Aug 11, 2020 at 09:57:55AM +0200, Jürgen Groß wrote: On 11.08.20 09:41, Peter Zijlstra wrote: On Fri, Aug 07, 2020 at 05:19:03PM +0200, Marco Elver wrote: My hypothesis here is simply that kvm_wait() may be called in a place where we get the sa

Re: [RFC-PATCH 1/2] mm: Add __GFP_NO_LOCKS flag

2020-08-11 Thread Michal Hocko
On Mon 10-08-20 21:25:26, Michal Hocko wrote: > On Mon 10-08-20 18:07:39, Uladzislau Rezki wrote: [...] > > The problem that i see is we can not use the page allocator from atomic > > contexts, what is our case: > > > > > > local_irq_save(flags) or preempt_disable() or raw_spinlock(); > >

[tip:timers/urgent] BUILD SUCCESS b0294f30256bb6023b2044fd607855123863d98f

2020-08-11 Thread kernel test robot
randconfig-a006-20200811 x86_64 randconfig-a001-20200811 x86_64 randconfig-a003-20200811 x86_64 randconfig-a005-20200811 x86_64 randconfig-a004-20200811 x86_64 randconfig-a002-20200811 i386 randconfig-a005-20200810 i386

Re: [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}

2020-08-11 Thread Greg Kroah-Hartman
On Tue, Aug 11, 2020 at 10:00:20AM +0200, Markus Elfring wrote: > > +This variable can be used to run scripts for the entire kernel, a > > +specific directory, or for a single file. > > I imagine that this wording can be improved another bit (as I indicated it > before). Hi, This is the semi-fr

Re: [PATCH v17 14/21] mm/compaction: do page isolation first in compaction

2020-08-11 Thread Alex Shi
在 2020/8/10 下午10:41, Alexander Duyck 写道: > On Mon, Aug 10, 2020 at 6:10 AM Alex Shi wrote: >> >> >> >> 在 2020/8/7 下午10:51, Alexander Duyck 写道: >>> I wonder if this entire section shouldn't be restructured. This is the >>> only spot I can see where we are resetting the LRU flag instead of >>> pu

Re: [v3] documentation: coccinelle: Improve command example for make C={1, 2}

2020-08-11 Thread Greg Kroah-Hartman
On Tue, Aug 11, 2020 at 09:03:09AM +0200, Markus Elfring wrote: > >>> the usage of the makefile C variable flag by coccicheck. > >> > >> * Can it be confusing to denote an item as a variable and a flag? > >> > >> * Would you really like to stress here that a flag can be variable? > > > > This is no

[RFC] kthread: add object debug support

2020-08-11 Thread Qianli Zhao
From: Qianli Zhao Add debugobject support to track the life time of kthread_work which is used to detect reinitialization/free active object problems Add kthread_init_work_onstack/kthread_init_delayed_work_onstack for kthread onstack support Signed-off-by: Qianli Zhao --- include/linux/kthread

Re: [PATCH V2] serial: qcom_geni_serial: To correct QUP Version detection logic

2020-08-11 Thread Greg Kroah-Hartman
On Tue, Aug 11, 2020 at 01:13:14PM +0530, Paras Sharma wrote: > The current implementation reduces the sampling rate by half > if qup HW version greater is than 2.5 by checking if the geni > SE major version is greater than 2 and geni SE minor version > is greater than 5. > > This implementation f

Re: [PATCH v3 2/2] ASoC: Intel: Add period size constraint on strago board

2020-08-11 Thread Yu-Hsuan Hsu
Takashi Iwai 於 2020年8月11日 週二 下午3:43寫道: > > On Tue, 11 Aug 2020 04:29:24 +0200, > Yu-Hsuan Hsu wrote: > > > > Lu, Brent 於 2020年8月11日 週二 上午10:17寫道: > > > > > > > > > > > Sorry for the late reply. CRAS does not set the period size when using > > > > it. > > > > The default period size is 256, which

Re: [PATCH 4.19 00/48] 4.19.139-rc1 review

2020-08-11 Thread Naresh Kamboju
On Mon, 10 Aug 2020 at 21:00, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.139 release. > There are 48 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Re

heads up: clock_gettime(CLOCK_MONOTONIC, ...) is not monotonic with Xen PVM

2020-08-11 Thread Ulrich Windl
Hi! I'm not subscribed to the kernel list, and my kernels are somewhat outdated, but I'd like to let you know: I found an issue where clock_gettime(CLOCK_MONOTONIC, ...) returned the identical value to two subsequent calls, while the resolution claimed is 1 ns. Environment: Xen Host x86-64 usin

Re: [PATCH 1/4] vdpa: introduce config op to get valid iova range

2020-08-11 Thread Michael S. Tsirkin
On Tue, Aug 11, 2020 at 10:53:09AM +0800, Jason Wang wrote: > > On 2020/8/10 下午8:05, Michael S. Tsirkin wrote: > > On Thu, Aug 06, 2020 at 03:43:54PM +0300, Eli Cohen wrote: > > > On Thu, Aug 06, 2020 at 08:29:22AM -0400, Michael S. Tsirkin wrote: > > > > On Thu, Aug 06, 2020 at 03:03:55PM +0300,

Re: [PATCH] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-11 Thread David Hildenbrand
On 10.08.20 18:10, Charan Teja Reddy wrote: > The following race is observed with the repeated online, offline and a > delay between two successive online of memory blocks of movable zone. > > P1P2 > > Online the first memory block in > the movable zone

include/linux/spinlock_api_smp.h:104:29: sparse: sparse: context imbalance in 'vpe_to_cpuid_lock' - wrong count at exit

2020-08-11 Thread kernel test robot
: arm64-randconfig-s032-20200811 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version

[RFC PATCH] sched/numa: fix bug in update_task_scan_period

2020-08-11 Thread 丁天琛
When p->numa_faults_locality[2] > 0, numa_scan_period is doubled, but this array will never be cleared, which causes scanning period always reaching its max value. This patch clears numa_faults_locality after numa_scan_period being doubled to fix this bug. Signed-off-by: Tianchen Ding Signed-off-

Re: [PATCH v1 2/2] perf/core: Fake regs for leaked kernel samples

2020-08-11 Thread Jin, Yao
Hi Peter, On 8/11/2020 3:59 PM, Peter Zijlstra wrote: On Tue, Aug 11, 2020 at 03:50:43PM +0800, Jin, Yao wrote: Could I post v2 which basically refers to your patch but removes some conditions since I see some issues in test if we use these conditions. 1. Remove '!event->attr.exclude_hv || !

Re: [PATCH 4.19 00/48] 4.19.139-rc1 review

2020-08-11 Thread Pavel Machek
On Mon 2020-08-10 17:21:22, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.139 release. > There are 48 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Respon

Re: [PATCH v3 2/2] x86/kvm: Expose new features for supported cpuid

2020-08-11 Thread Paolo Bonzini
On 11/08/20 01:59, Luck, Tony wrote: > > Part 1: Add TSXLDTRK to cpufeatures.h Part 2: Add TSXLDTRK to > arch/x86/kvm/cpuid.c (on top of the version that Paolo committed with > SERIALIZE) > > Paolo: The 5.9 merge window is still open this week. Will you send > the KVM serialize patch to Linus bef

[PATCH] KVM: MIPS/VZ: Fix build error caused by 'kvm_run' cleanup

2020-08-11 Thread XingxingSu
Commit c34b26b98caca48ec9ee9 ("KVM: MIPS: clean up redundant 'kvm_run' parameters") remove the 'kvm_run' parameter in kvm_vz_gpsi_lwc2. The following build error: arch/mips/kvm/vz.c: In function ???kvm_trap_vz_handle_gpsi???: arch/mips/kvm/vz.c:1243:43: error: ???run??? undeclared (first use in t

Re: [PATCH] Revert "mm/vmstat.c: do not show lowmem reserve protection information of empty zone"

2020-08-11 Thread David Hildenbrand
On 11.08.20 09:54, Baoquan He wrote: > This reverts commit 26e7deadaae1755faf1f6d1a68988c4b8348df59. > > Sonny reported that one of their tests started failing on the latest > kernel on their Chrome OS platform. The root cause is that the above > commit removed the protection line of empty zone, w

Re: [PATCH] fs: autofs: delete repeated words in comments

2020-08-11 Thread Ian Kent
On Mon, 2020-08-10 at 19:18 -0700, Randy Dunlap wrote: > Drop duplicated words {the, at} in comments. > > Signed-off-by: Randy Dunlap > Cc: Ian Kent > Cc: aut...@vger.kernel.org Acked-by: Ian Kent > --- > fs/autofs/dev-ioctl.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH] x86/paravirt: Add missing noinstr to arch_local*() helpers

2020-08-11 Thread Jürgen Groß
On 11.08.20 10:12, Peter Zijlstra wrote: On Tue, Aug 11, 2020 at 09:57:55AM +0200, Jürgen Groß wrote: On 11.08.20 09:41, Peter Zijlstra wrote: On Fri, Aug 07, 2020 at 05:19:03PM +0200, Marco Elver wrote: My hypothesis here is simply that kvm_wait() may be called in a place where we get the sa

Re: [PATCH v3 2/2] ASoC: Intel: Add period size constraint on strago board

2020-08-11 Thread Takashi Iwai
On Tue, 11 Aug 2020 10:25:22 +0200, Yu-Hsuan Hsu wrote: > > Takashi Iwai 於 2020年8月11日 週二 下午3:43寫道: > > > > On Tue, 11 Aug 2020 04:29:24 +0200, > > Yu-Hsuan Hsu wrote: > > > > > > Lu, Brent 於 2020年8月11日 週二 上午10:17寫道: > > > > > > > > > > > > > > Sorry for the late reply. CRAS does not set the peri

Re: [PATCH] riscv: Setup exception vector for K210 properly

2020-08-11 Thread Anup Patel
On Tue, Aug 11, 2020 at 12:07 PM Qiu Wenbo wrote: > > Exception vector is missing on nommu platform and it is a big issue. > This patch is tested in Sipeed MAIX Bit Dev Board. > > Fixes: 79b1feba5455 ("RISC-V: Setup exception vector early") > Signed-off-by: Qiu Wenbo > --- > arch/riscv/kernel/sm

Re: [PATCH 1/2] arm: dts: mt7623: move more display-related nodes to mt7623n.dtsi

2020-08-11 Thread Frank Wunderlich
Hi Am 11. August 2020 01:28:25 MESZ schrieb Chun-Kuang Hu : >Sorry I does not notice that mt7623a and mt7623n are different SoC. >Because they are different SoC, I think the first step is to upstream >mt7623a.dtsi and mt7623n.dtsi independently. That means in each dtsi, >it include all devices of

[PATCH] sched/fair: Optimize dequeue_task_fair()

2020-08-11 Thread Jiang Biao
Similar optimization as what has been done in commit, 7d148be69e3a(sched/fair: Optimize enqueue_task_fair()) dequeue_task_fair jumps to dequeue_throttle label when cfs_rq_of(se) is throttled which means that se can't be NULL. We can move the label after the if (!se) statement and remove the if(!se

  1   2   3   4   5   6   7   8   9   10   >