Re: [PATCH RESEND 1/2] scsi: megaraid: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
On Tue, Jul 28, 2020 at 11:40:12PM -0400, Martin K. Petersen wrote: > > Hello Suraj! > > > The legacy API wrappers in include/linux/pci-dma-compat.h > > should go away as it creates unnecessary midlayering > > for include/linux/dma-mapping.h APIs, instead use dma-mapping.h > > APIs directly. > >

KASAN: use-after-free Write in __alloc_skb (3)

2020-07-29 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:68845a55 Merge branch 'akpm' into master (patches from And.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10f85f7890 kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267 das

include/linux/spinlock.h:383:9: sparse: sparse: context imbalance in 'ip_set_test' - unexpected unlock

2020-07-29 Thread kernel test robot
randconfig-s031-20200729 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version:

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-07-29 Thread Alan Stern
On Wed, Jul 29, 2020 at 06:43:48PM +0200, Martin Kepplinger wrote: > > > Am 29. Juli 2020 17:44:42 MESZ schrieb James Bottomley > : > >On Wed, 2020-07-29 at 17:40 +0200, Martin Kepplinger wrote: > >> On 29.07.20 16:53, James Bottomley wrote: > >> > On Wed, 2020-07-29 at 07:46 -0700, James Bottom

Re: [PATCH] KVM: x86: Deflect unknown MSR accesses to user space

2020-07-29 Thread Jim Mattson
On Wed, Jul 29, 2020 at 2:06 AM Alexander Graf wrote: > > > > On 28.07.20 19:13, Jim Mattson wrote: > > This sounds similar to Peter Hornyack's RFC from 5 years ago: > > https://www.mail-archive.com/kvm@vger.kernel.org/msg124448.html. > > Yeah, looks very similar. Do you know the history why it n

Re: [PATCH v5 2/4] power: supply: bq27xxx_battery: Add the BQ27z561 Battery monitor

2020-07-29 Thread Dan Murphy
Sebastian On 7/29/20 11:56 AM, Sebastian Reichel wrote: Hi, On Wed, Jul 29, 2020 at 10:55:54AM -0500, Dan Murphy wrote: +<<< HEAD Need to remove this artifact from a rebase. Not sure how this got here as it does not appear in my source. You don't see it in your source, since you removed

Re: Should perf version match kernel version?

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 29, 2020 at 08:57:04PM +0300, Vitaly Chikunov escreveu: > On Wed, Jul 29, 2020 at 01:27:32PM -0300, Arnaldo Carvalho de Melo wrote: > > On July 29, 2020 1:02:20 PM GMT-03:00, pet...@infradead.org wrote: > > >On Wed, Jul 29, 2020 at 06:56:47PM +0300, Vitaly Chikunov wrote: > > >> It seem

Re: Kernel panic - not syncing: IO-APIC + timer doesn't work!

2020-07-29 Thread Tom Lendacky
On 7/29/20 4:50 AM, Thomas Gleixner wrote: > Scott, > > Scott Branden writes: >> On 2020-07-28 1:22 a.m., Thomas Gleixner wrote: >>> Scott Branden writes: Bios now updated to latest.  Same kernel panic issue.  Log below. I think it is related to power cycling quickly. Should

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-07-29 Thread James Bottomley
On Wed, 2020-07-29 at 14:25 -0400, Alan Stern wrote: > On Wed, Jul 29, 2020 at 06:43:48PM +0200, Martin Kepplinger wrote: [...] > > > > --- a/drivers/scsi/scsi_error.c > > > > +++ b/drivers/scsi/scsi_error.c > > > > @@ -554,16 +554,8 @@ int scsi_check_sense(struct scsi_cmnd > > > > *scmd) > > > >

[PATCH v6 1/4] dt-bindings: power: Add BQ27Z561 compatible

2020-07-29 Thread Dan Murphy
Add the Texas Instruments bq27z561 battery monitor to the bq27xxx binding. Acked-by: Rob Herring Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/power/supply/bq27xxx.y

Re: [PATCH][next] drm: xln: fix spelling mistake "failes" -> "failed"

2020-07-29 Thread Hyun Kwon
Hi Colin, Thanks for the patch. On Tue, Jul 28, 2020 at 03:37:39PM -0700, Laurent Pinchart wrote: > Hi Colin, > > Thank you for the patch. > > On Fri, Jul 24, 2020 at 12:12:58PM +0100, Colin King wrote: > > From: Colin Ian King > > > > There is a spelling mistake in a dev_dbg messages. Fix it

[PATCH v6 4/4] power: supply: bq27xxx_battery: Add the BQ28z610 Battery monitor

2020-07-29 Thread Dan Murphy
Add the Texas Instruments BQ28z610 battery monitor. The register address map is laid out the same as compared to other devices within the file. The battery status register bits are similar to the bq27z561 but they are different compared to other fuel gauge devices within this file. Signed-off-by:

[PATCH v6 2/4] power: supply: bq27xxx_battery: Add the BQ27Z561 Battery monitor

2020-07-29 Thread Dan Murphy
Add the Texas Instruments BQ27Z561 battery monitor. The register address map is laid out the same as compared to other devices within the file. The battery status register has differing bits to determine if the battery is full, discharging or dead. Signed-off-by: Dan Murphy --- drivers/power/su

Inverted mount options completely broken (iversion,relatime)

2020-07-29 Thread Josef Bacik
Hello, Eric reported a problem to me where we were clearing SB_I_VERSION on remount of a btrfs file system. After digging through I discovered it's because we expect the proper flags that we want to be passed in via the mount() syscall, and because we didn't have "iversion" in our show_option

[PATCH v6 3/4] dt-bindings: power: Add BQ28z610 compatible

2020-07-29 Thread Dan Murphy
Add the Texas Instruments bq28z610 battery monitor to the bq27xxx binding. Acked-by: Rob Herring Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/power/supply/bq27xxx.y

Re: [PATCH -next] drm: xlnx: Fix typo in parameter description

2020-07-29 Thread Hyun Kwon
Hi Wei, Thanks for the patch. On Tue, Jul 28, 2020 at 03:33:49PM -0700, Laurent Pinchart wrote: > Hi Wei, > > Thank you for the patch. > > On Sat, Jul 25, 2020 at 06:34:29AM +, Wei Yongjun wrote: > > Fix typo in parameter description. > > > > Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver

drivers/vfio/pci/vfio_pci_nvlink2.c:100:9: error: implicit declaration of function 'mm_iommu_put'; did you mean

2020-07-29 Thread kernel test robot
-20200729 (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout

Re: [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()

2020-07-29 Thread Mike Kravetz
On 7/29/20 11:08 AM, David Hildenbrand wrote: > I have no clue what you mean with "reintroducing this abandoning of > pageblocks". All this patch is changing is not doing the dump_page() - > or am I missing something important? My apologies!!! I got confused when I saw 'Return -EBUSY' removed fro

Re: [PATCH] net/mlx5e: fix bpf_prog reference count leaks in mlx5e_alloc_rq

2020-07-29 Thread Markus Elfring
… > The refcount leak issues take place in two error handling paths. Can an other wording be a bit nicer for the commit message? > Fix the issue by … I suggest to replace this wording by the tag “Fixes”. Regards, Markus

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-29 Thread Eugenio Perez Martin
On Tue, Jul 21, 2020 at 4:55 AM Jason Wang wrote: > > > On 2020/7/20 下午7:16, Eugenio Pérez wrote: > > On Mon, Jul 20, 2020 at 11:27 AM Michael S. Tsirkin wrote: > >> On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: > >>> On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin >

Re: [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()

2020-07-29 Thread David Hildenbrand
> Am 29.07.2020 um 20:36 schrieb Mike Kravetz : > > On 7/29/20 11:08 AM, David Hildenbrand wrote: >> I have no clue what you mean with "reintroducing this abandoning of >> pageblocks". All this patch is changing is not doing the dump_page() - >> or am I missing something important? > > My apo

Re: Inverted mount options completely broken (iversion,relatime)

2020-07-29 Thread Eric Sandeen
On 7/29/20 11:32 AM, Josef Bacik wrote: > Hello, > > Eric reported a problem to me where we were clearing SB_I_VERSION on remount > of a btrfs file system.  After digging through I discovered it's because we > expect the proper flags that we want to be passed in via the mount() syscall, > and b

Re: [PATCH v1 2/2] timer: mt6873: porting Mediatek timer driver to loadable module

2020-07-29 Thread Saravana Kannan
On Wed, Jul 29, 2020 at 6:02 AM Thomas Gleixner wrote: > > Freddy, > > Freddy Hsin writes: > > again, please be more careful with subject lines. git log $FILE will > give you a hint. > > > porting Mediatek timer driver to loadable module > > Repeating the sentence in the subject line is not givin

Re: [git pull] drm fixes for 5.8-rc8

2020-07-29 Thread Linus Torvalds
On Tue, Jul 28, 2020 at 9:44 PM Dave Airlie wrote: > > If you feel this is too much I'm happy to respin with the > core/drm_fb_helper and nouveau fixes. we have one outstanding nouveau > regression fix, that I'll follow this up with in the next day or so > once Ben and James get it reviewed. This

Re: [PATCH v4 2/5] irqchip/irq-pruss-intc: Add a PRUSS irqchip driver for PRUSS interrupts

2020-07-29 Thread David Lechner
On 7/28/20 4:18 AM, Grzegorz Jaszczyk wrote: The Programmable Real-Time Unit Subsystem (PRUSS) contains a local interrupt controller (INTC) that can handle various system input events and post interrupts back to the device-level initiators. The INTC can support upto 64 input events with individua

Re: [PATCH RFC] x86/bus_lock: Enable bus lock detection

2020-07-29 Thread Sean Christopherson
On Wed, Jul 29, 2020 at 11:09:16AM -0700, Yu, Fenghua wrote: > > > Some CPUs have ability to notify the kernel by an #DB trap after the > > > instruction acquires a bus lock and is executed. This allows the > > > kernel to enforce user application throttling or mitigations and also > > > provides a

Re: [PATCH 4/5] PCI: aardvark: Implement driver 'remove' function and allow to build it as module

2020-07-29 Thread Rob Herring
On Wed, Jul 15, 2020 at 04:25:56PM +0200, Marek Behún wrote: > From: Pali Rohár > > Providing driver's 'remove' function allows kernel to bind and unbind devices > from aardvark driver. It also allows to build aardvark driver as a module. > > Compiling aardvark as a module simplifies development

Re: Inverted mount options completely broken (iversion,relatime)

2020-07-29 Thread Josef Bacik
On 7/29/20 2:41 PM, Eric Sandeen wrote: On 7/29/20 11:32 AM, Josef Bacik wrote: Hello, Eric reported a problem to me where we were clearing SB_I_VERSION on remount of a btrfs file system.  After digging through I discovered it's because we expect the proper flags that we want to be passed in

Re: [PATCH v4 3/5] irqchip/irq-pruss-intc: Add logic for handling reserved interrupts

2020-07-29 Thread David Lechner
On 7/28/20 4:18 AM, Grzegorz Jaszczyk wrote: From: Suman Anna The PRUSS INTC has a fixed number of output interrupt lines that are connected to a number of processors or other PRUSS instances or other devices (like DMA) on the SoC. The output interrupt lines 2 through 9 are usually connected to

Re: [PATCH 1/1] vt_ioctl: prevent VT_RESIZEX font height change from causing potential out-of-bounds access

2020-07-29 Thread George Kennedy
Hi Greg, I will re-work this patch based on comments from Dan. Thank you, George On 7/29/2020 8:53 AM, Greg KH wrote: On Wed, Jul 29, 2020 at 08:39:41AM -0400, George Kennedy wrote: Add a VT_RESIZEX check to ensure that changing the font height will not cause a potential out-of-bounds access.

Re: [PATCH v2 1/5] perf record: Set PERF_RECORD_PERIOD if attr->freq is set.

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:30AM -0700, Ian Rogers escreveu: > From: David Sharp > > evsel__config() would only set PERF_RECORD_PERIOD if it set attr->freq There is no such thing as 'PERF_RECORD_PERIOD', its PERF_SAMPLE_PERIOD, also... > from perf record options. When it is set by libpfm even

[PATCH v2] drivers/virt/fsl_hypervisor: Correcting error handling path

2020-07-29 Thread Souptick Joarder
First, when memory allocation for sg_list_unaligned failed, there is no point of calling put_pages() as we haven't pinned any pages. Second, if get_user_pages_fast() failed we should unpinned num_pinned pages, no point of checking till num_pages. This will address both. Signed-off-by: Souptick J

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:31AM -0700, Ian Rogers escreveu: > From: Stephane Eranian > > Before: > $ perf record -c 1 --pfm-events=cycles:period=7 > > Would yield a cycles event with period=1, instead of 7. I tried the equivalent without libpfm and it works: $ perf record

Re: [PATCH 1/2] PCI: dwc: Add support to handle prefetchable memory separately

2020-07-29 Thread Rob Herring
On Tue, Jun 02, 2020 at 03:39:39PM +0530, Vidya Sagar wrote: > Add required structure members to struct pcie_port to handle prefetchable > memory aperture separately from non-prefetchable memory aperture so that > any dependency on the order of their appearance in the 'ranges' property > of the res

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:33AM -0700, Ian Rogers escreveu: > If events in a group explicitly set a frequency or period with leader > sampling, don't disable the samples on those events. > > Prior to 5.8: > perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' > would clear

Re: [PATCH ghak90 V9 06/13] audit: add contid support for signalling the audit daemon

2020-07-29 Thread Richard Guy Briggs
On 2020-07-05 11:10, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs wrote: > > > > Add audit container identifier support to the action of signalling the > > audit daemon. > > > > Since this would need to add an element to the audit_sig_info struct, > > a new record type AU

Re: [PATCH] net/mlx5e: fix bpf_prog refcnt leaks in mlx5e_alloc_rq

2020-07-29 Thread Saeed Mahameed
On Wed, 2020-07-29 at 20:33 +0800, Xin Xiong wrote: > The function invokes bpf_prog_inc(), which increases the refcount of > a > bpf_prog object "rq->xdp_prog" if the object isn't NULL. > > The refcount leak issues take place in two error handling paths. When > mlx5_wq_ll_create() or mlx5_wq_cyc_c

Re: [PATCH 3/7] ARM: s3c: Remove plat-samsung/.../samsung-time.h

2020-07-29 Thread Krzysztof Kozlowski
On Wed, Jul 29, 2020 at 07:49:02PM +0200, Tomasz Figa wrote: > 2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > > > Remove the arch/arm/plat-samsung/include/plat/samsung-time.h header and > > move the contents to common.h headers in mach-s3c24xx and mach-s3c64xx. > > The definition of declared functio

Re: [PATCH 5/7] ARM: samsung: Kill useless HAVE_S3C2410_WATCHDOG

2020-07-29 Thread Krzysztof Kozlowski
On Wed, Jul 29, 2020 at 07:36:38PM +0200, Tomasz Figa wrote: > 2020年7月29日(水) 19:02 Guenter Roeck : > > > > On Wed, Jul 29, 2020 at 06:09:40PM +0200, Krzysztof Kozlowski wrote: > > > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs does > > > not have sense, because: > > > 1. All ARM

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-29 Thread Melissa Wen
Melissa Wen On Sat, Jul 25, 2020 at 3:12 PM Daniel Vetter wrote: > > On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote: > > > > On 07/25, Daniel Vetter wrote: > > > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > > > > > > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote:

[PATCH] nvmet-passthru: Reject commands with non-sgl flags set

2020-07-29 Thread Logan Gunthorpe
Any command with a non-SGL flag set (like fuse flags) should be rejected. Fixes: c1fef73f793b ("nvmet: add passthru code to process commands") Signed-off-by: Logan Gunthorpe --- Note: this patch may be squashed with the patch noted in the fixes tag, currently in nvme-5.9. drivers/nvme/target/p

[PATCH v2] lib: kunit: Convert test_sort to KUnit test

2020-07-29 Thread Vitor Massaru Iha
This adds the conversion of the test_sort.c to KUnit test. Please apply this commit first (linux-kselftest/kunit-fixes): 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space Code Style Documentation: [0] Fix these warnings Reported-by l...@intel

Re: [PATCH v3 12/19] firmware_loader: Use security_post_load_data()

2020-07-29 Thread Kees Cook
On Wed, Jul 29, 2020 at 02:10:18PM -0400, Mimi Zohar wrote: > Actually, the partial firmware read should be calling > security_kernel_read_file(). Yup, it does[1], and when "whole_file" is true, it will call security_kernel_post_read_file() with the buffer contents at the end. > The sysfs firmwar

Re: 回复: INFO: rcu detected stall in tc_modify_qdisc

2020-07-29 Thread Vinicius Costa Gomes
Hi, "Zhang, Qiang" writes: > > 发件人: linux-kernel-ow...@vger.kernel.org > 代表 syzbot > 发送时间: 2020年7月29日 13:53 > 收件人: da...@davemloft.net; fweis...@gmail.com; j...@mojatatu.com; > j...@resnulli.us; linux-kernel@vger.kernel.org; mi...@kernel.org; > net..

Re: [PATCH 6/7] ARM: s3c64xx: Switch to generic watchdog driver reset

2020-07-29 Thread Krzysztof Kozlowski
On Wed, Jul 29, 2020 at 07:33:33PM +0200, Tomasz Figa wrote: > Hi Krzysztof, > > 2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > > > Similarly to commit f6361c6b3880 ("ARM: S3C24XX: remove separate restart > > code"), the platform watchdog reset code can be removed in favor of > > a generic watchdog

[PATCH] nvme: Use spin_lock_irqsave() when taking the ctrl->lock

2020-07-29 Thread Logan Gunthorpe
When locking the ctrl->lock spinlock IRQs need to be disabled to avoid a dead lock. The new spin_lock() calls recently added produce the following lockdep warning when running the blktest nvme/003: WARNING: inconsistent lock state --

Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down

2020-07-29 Thread David Miller
From: Jisheng Zhang Date: Wed, 29 Jul 2020 17:49:09 +0800 > mvneta has switched to phylink, so the comment should look > like "We may have called phylink_speed_down before". > > Signed-off-by: Jisheng Zhang > --- > Since v1: > - drop patch2 which tries to avoid link flapping when changing mtu

Re: linux-next: build failure after merge of the vfs tree

2020-07-29 Thread Al Viro
On Wed, Jul 29, 2020 at 08:33:05AM +0200, Christoph Hellwig wrote: > Thanks, > > I've sent out a fixed version. #work.quota-compat and #for-next rebuilt (and pushed) with it...

Re: [Intel-gfx] [PATCH v12 2/3] drm/i915: add syncobj timeline support

2020-07-29 Thread Kees Cook
On Wed, Jul 29, 2020 at 10:51:23AM -0700, Linus Torvalds wrote: > On Wed, Jul 29, 2020 at 5:24 AM Daniel Vetter wrote: > > > > Do we have a access_ok_array or so? Instead of duplicating overflow checks > > everywhere and getting it all wrong ... > > I really really think you should get away from

Re: [PATCH v5 1/2] remoteproc: Add remoteproc character device interface

2020-07-29 Thread Bjorn Andersson
On Wed 29 Jul 10:40 PDT 2020, Siddharth Gupta wrote: > Add the character device interface into remoteproc framework. > This interface can be used in order to boot/shutdown remote > subsystems and provides a basic ioctl based interface to implement > supplementary functionality. An ioctl call is im

Re: [PATCH v2] lib: kunit: Convert test_sort to KUnit test

2020-07-29 Thread Andy Shevchenko
On Wed, Jul 29, 2020 at 04:11:51PM -0300, Vitor Massaru Iha wrote: > This adds the conversion of the test_sort.c to KUnit test. > > Please apply this commit first (linux-kselftest/kunit-fixes): > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of > CONFIG options with sp

Re: [PATCH v5 2/2] remoteproc: core: Register the character device interface

2020-07-29 Thread Bjorn Andersson
On Wed 29 Jul 10:40 PDT 2020, Siddharth Gupta wrote: > Add the character device during rproc_add. This would create > a character device node at /dev/remoteproc. Userspace > applications can interact with the remote processor using this > interface. > Reviewed-by: Bjorn Andersson > Signed-off-

Re: [PATCH 2/2] mm, util: account_locked_vm() does not hold mmap_lock

2020-07-29 Thread Hugh Dickins
On Sun, 26 Jul 2020, Pengfei Li wrote: > Since mm->locked_vm is already an atomic counter, account_locked_vm() > does not need to hold mmap_lock. I am worried that this patch, already added to mmotm, along with its 1/2 making locked_vm an atomic64, might be rushed into v5.9 with just that two-lin

[PATCH v4 3/3] staging: rtl8723bs: Align macro definitions

2020-07-29 Thread Aditya Jain
Adjust spacing in macro definitions to align them and improve readbility Signed-off-by: Aditya Jain --- drivers/staging/rtl8723bs/include/hal_phy_cfg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/hal_phy_cfg.h b/drivers/staging/rtl

[PATCH v4 0/3] Fix coding style issues in staging

2020-07-29 Thread Aditya Jain
Hey everyone, Following the comments received I've updated the patch. The patch cleans up coding style issues in the file drivers/staging/rtl8723bs/include/hal_phy_cfg.h Changelog: v1: Fixed ERROR: "foo * bar" should be "foo *bar" reported by checkpatch.pl v1 -> v2: Cleaned up multiline fun

[PATCH v4 2/3] staging: rtl8723bs: Clean up function declations

2020-07-29 Thread Aditya Jain
Clean up multiline function declartions in hal_phy_cfg.h to improve code readablility Signed-off-by: Aditya Jain --- .../staging/rtl8723bs/include/hal_phy_cfg.h | 110 +- 1 file changed, 29 insertions(+), 81 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/hal_phy_c

[PATCH] MAINTAINERS: Drop Vincent Sanders from Simtec S3C boards

2020-07-29 Thread Krzysztof Kozlowski
Vincent Sanders' email bounces with code 550 (user does not exist) so remove the entry from Simtec S3C24xx boards. Cc: Simtec Linux Team Cc: linux-samsung-...@vger.kernel.org Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MA

Re: kernel BUG at include/linux/swapops.h:LINE!

2020-07-29 Thread Kirill A. Shutemov
On Mon, Jul 27, 2020 at 01:03:10PM +0100, Matthew Wilcox wrote: > On Mon, Jul 27, 2020 at 01:31:40PM +0300, Kirill A. Shutemov wrote: > > On Sun, Jul 26, 2020 at 05:49:04PM +0100, Matthew Wilcox wrote: > > > On Fri, Jul 24, 2020 at 02:13:11PM +0300, Kirill A. Shutemov wrote: > > > > On Thu, Jul 23,

[PATCH v4 1/3] staging: rtl8723bs: Fix coding style errors

2020-07-29 Thread Aditya Jain
Fixing ERROR: "foo *bar" should be "foo *bar" in hal_phy_cfg.h as reported by checkpatch.pl Signed-off-by: Aditya Jain --- .../staging/rtl8723bs/include/hal_phy_cfg.h| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/h

Re: [PATCH v4 4/5] irqchip/irq-pruss-intc: Implement irq_{get,set}_irqchip_state ops

2020-07-29 Thread David Lechner
On 7/28/20 4:18 AM, Grzegorz Jaszczyk wrote: From: David Lechner This implements the irq_get_irqchip_state and irq_set_irqchip_state callbacks for the TI PRUSS INTC driver. The set callback can be used by drivers to "kick" a PRU by injecting a PRU system event. Example: We could improve this

[PATCH] lib: kunit: add list_sort test conversion to KUnit

2020-07-29 Thread Vitor Massaru Iha
This adds the conversion of the runtime tests of test_list_sort, from `lib/test_list_sort.c` to KUnit tests. Please apply this commit first (linux-kselftest/kunit-fixes): 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space Code Style Documentati

Re: [PATCH v2] PCI: Fix kerneldoc of pci_vc_do_save_buffer()

2020-07-29 Thread Bjorn Helgaas
On Wed, Jul 29, 2020 at 08:26:20AM +0200, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/pci/vc.c:188: warning: Excess function parameter 'name' > description in 'pci_vc_do_save_buffer' > > Signed-off-by: Krzysztof Kozlowski This looks great, but wou

Re: [PATCH 6/7] ARM: s3c64xx: Switch to generic watchdog driver reset

2020-07-29 Thread Krzysztof Kozlowski
On Wed, Jul 29, 2020 at 09:15:44PM +0200, Krzysztof Kozlowski wrote: > On Wed, Jul 29, 2020 at 07:33:33PM +0200, Tomasz Figa wrote: > > Hi Krzysztof, > > > > 2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > > > > > Similarly to commit f6361c6b3880 ("ARM: S3C24XX: remove separate restart > > > code"),

Re: [PATCH v2] PCI: Fix kerneldoc of pci_vc_do_save_buffer()

2020-07-29 Thread Krzysztof Kozlowski
On Wed, Jul 29, 2020 at 02:24:16PM -0500, Bjorn Helgaas wrote: > On Wed, Jul 29, 2020 at 08:26:20AM +0200, Krzysztof Kozlowski wrote: > > Fix W=1 compile warnings (invalid kerneldoc): > > > > drivers/pci/vc.c:188: warning: Excess function parameter 'name' > > description in 'pci_vc_do_save_bu

Re: [RFC][PATCH] locking/refcount: Provide __refcount API to obtain the old value

2020-07-29 Thread Kees Cook
On Wed, Jul 29, 2020 at 01:37:31PM +0200, pet...@infradead.org wrote: > On Wed, Jul 29, 2020 at 01:11:20PM +0200, pet...@infradead.org wrote: > > > Subject: locking/refcount: Provide __refcount API to obtain the old value > > From: Peter Zijlstra > > Date: Wed Jul 29 13:00:57 CEST 2020 > > > > D

Re: [PATCH v4 5/5] irqchip/irq-pruss-intc: Add support for ICSSG INTC on K3 SoCs

2020-07-29 Thread David Lechner
On 7/28/20 4:18 AM, Grzegorz Jaszczyk wrote: From: Suman Anna The K3 AM65x and J721E SoCs have the next generation of the PRU-ICSS IP, commonly called ICSSG. The PRUSS INTC present within the ICSSG supports more System Events (160 vs 64), more Interrupt Channels and Host Interrupts (20 vs 10) c

Re: [RFC][PATCH] locking/refcount: Provide __refcount API to obtain the old value

2020-07-29 Thread Kees Cook
On Wed, Jul 29, 2020 at 01:11:20PM +0200, pet...@infradead.org wrote: > Subject: locking/refcount: Provide __refcount API to obtain the old value > From: Peter Zijlstra > Date: Wed Jul 29 13:00:57 CEST 2020 > > David requested means to obtain the old/previous value from the > refcount API for tra

Re: [PATCH v5 1/5] dt-bindings: media: venus: Add an optional power domain for perf voting

2020-07-29 Thread Bjorn Andersson
On Wed 29 Jul 00:16 PDT 2020, Rajendra Nayak wrote: > Venus needs to vote for the performance state of a power domain (cx) > to be able to support DVFS. This 'cx' power domain is controlled by > rpmh and is a common power domain (scalable) not specific to > venus alone. This is optional in the sen

Re: [PATCH v5 2/5] media: venus: core: Fix error handling in probe

2020-07-29 Thread Bjorn Andersson
On Wed 29 Jul 00:16 PDT 2020, Rajendra Nayak wrote: > Post a successful pm_ops->core_get, an error in probe > should exit by doing a pm_ops->core_put which seems > to be missing. So fix it. > > Signed-off-by: Rajendra Nayak > Acked-by: Stanimir Varbanov Reviewed-by: Bjorn Andersson > --- >

Re: [PATCH 1/2] PCI/switechtec: Add missing __iomem and __user tags to fix sparse warnings

2020-07-29 Thread Bjorn Helgaas
On Tue, Jul 28, 2020 at 01:24:33PM -0600, Logan Gunthorpe wrote: > Fix a number of missing __iomem and __user tags in the ioctl functions of > the switchtec driver. This fixes a number of sparse warnings of the form: > > sparse: sparse: incorrect type in ... (different address spaces) > > Fixes

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-07-29 Thread Richard Guy Briggs
On 2020-07-05 11:10, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs wrote: > > > > Create a new audit record AUDIT_CONTAINER_ID to document the audit > > container identifier of a process if it is present. > > > > Called from audit_log_exit(), syscalls are covered. > > > >

Re: [PATCH RFC] x86/bus_lock: Enable bus lock detection

2020-07-29 Thread Fenghua Yu
Hi, Sean, On Wed, Jul 29, 2020 at 11:46:14AM -0700, Sean Christopherson wrote: > On Wed, Jul 29, 2020 at 11:09:16AM -0700, Yu, Fenghua wrote: > > > > Some CPUs have ability to notify the kernel by an #DB trap after the > > > > instruction acquires a bus lock and is executed. This allows the > > >

Re: [PATCH 1/7] clk: samsung: s3c64xx: Declare s3c64xx_clk_init() in shared header

2020-07-29 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2020-07-29 09:09:36) > diff --git a/include/linux/clk/samsung.h b/include/linux/clk/samsung.h > new file mode 100644 > index ..b6b253c46c22 > --- /dev/null > +++ b/include/linux/clk/samsung.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/*

Re: [PATCH] powerpc: fix function annotations to avoid section mismatch warnings with gcc-10

2020-07-29 Thread Vladis Dronov
Hello, - Original Message - > From: "Segher Boessenkool" > To: "Vladis Dronov" > Cc: linuxppc-...@lists.ozlabs.org, "Aneesh Kumar K . V" > , linux-kernel@vger.kernel.org, > "Paul Mackerras" > Sent: Wednesday, July 29, 2020 4:49:49 PM > Subject: Re: [PATCH] powerpc: fix function annotat

Re: [PATCH 01/17] dt-bindings: clocks: imx8mp: Rename audiomix ids clocks to audio_blk_ctrl

2020-07-29 Thread Stephen Boyd
Quoting Abel Vesa (2020-07-29 05:07:47) > In the reference manual the actual name is Audio BLK_CTRL. > Lets make it more obvious here by renaming from audiomix to audio_blk_ctrl. And this is safe because there aren't any users of the defines?

[PATCH 0/1] virtio-scsi: fix missing unplug events when all LUNs are unplugged at the same time

2020-07-29 Thread Maxim Levitsky
virtio-scsi currently has limit of 8 outstanding notifications so when more that 8 LUNs are unplugged, some are missed. Commit 5ff843721467 ("scsi: virtio_scsi: unplug LUNs when events missed") Fixed this by checking the 'event overflow' bit and manually scanned the bus to see which LUNs are still

[PATCH 1/1] scsi: virtio-scsi: handle correctly case when all LUNs were unplugged

2020-07-29 Thread Maxim Levitsky
Commit 5ff843721467 ("scsi: virtio_scsi: unplug LUNs when events missed"), almost fixed the case of mass unpluging of LUNs, but it missed a corner case in which all the LUNs are unplugged at the same time. In this case INQUIRY ends with DID_BAD_TARGET. Detect this and unplug the LUN. Signed-off-b

Re: Regression in nvme driver

2020-07-29 Thread Keith Busch
On Wed, Jul 29, 2020 at 07:29:08PM +, Lach wrote: > Hello > > I caught a regression in the nvme driver, which shows itself on some > controllers (In my case, at 126h:2263) Fix is staged for the next 5.8 pull; https://git.kernel.dk/cgit/linux-block/commit/?h=block-5.8&id=5bedd3afee8eb01ccd

Re: [PATCH] uapi, seg6_iptunnel: Add missing include in seg6_iptunnel.h

2020-07-29 Thread David Miller
From: Ioana-Ruxandra Stancioi Date: Wed, 29 Jul 2020 10:49:03 + > From: Ioana-Ruxandra Stăncioi > > Include in uapi/linux/seg6_iptunnel.h to fix the > following linux/seg6_iptunnel.h compilation error: > >invalid application of 'sizeof' to incomplete type 'struct ipv6hdr' >hea

Re: [PATCH 10/17] Documentation: bindings: clk: Add bindings for i.MX BLK_CTRL

2020-07-29 Thread Stephen Boyd
Quoting Abel Vesa (2020-07-29 05:07:56) > diff --git a/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > new file mode 100644 > index ..036d3d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/fs

Re: add file system helpers that take kernel pointers for the init code v4

2020-07-29 Thread Al Viro
On Tue, Jul 28, 2020 at 06:33:53PM +0200, Christoph Hellwig wrote: > Hi Al and Linus, > > currently a lot of the file system calls in the early in code (and the > devtmpfs kthread) rely on the implicit set_fs(KERNEL_DS) during boot. > This is one of the few last remaining places we need to deal wi

Re: [PATCH] clk: mmp: avoid missing prototype warning

2020-07-29 Thread Stephen Boyd
Quoting Arnd Bergmann (2020-07-29 04:34:39) > The kernel test robot points out two harmless warnings in the > mmp clk drivers: > > drivers/clk/mmp/clk-pxa168.c:68:13: warning: no previous prototype for > 'pxa168_clk_init' [-Wmissing-prototypes] > drivers/clk/mmp/clk-pxa910.c:66:13: warning: no pr

Re: kernel BUG at include/linux/swapops.h:LINE!

2020-07-29 Thread Matthew Wilcox
On Wed, Jul 29, 2020 at 10:21:51PM +0300, Kirill A. Shutemov wrote: > On Mon, Jul 27, 2020 at 01:03:10PM +0100, Matthew Wilcox wrote: > > > It would be interesting to know if the migration entires ever got removed > > > for pfn. I mean if remove_migration_pte() got called for it. > > > > > > It ca

Re: [RFC PATCH 02/14] coresight: Introduce device access abstraction

2020-07-29 Thread Mathieu Poirier
On Wed, Jul 22, 2020 at 06:20:28PM +0100, Suzuki K Poulose wrote: > We are about to introduce support for sysreg access to ETMv4.4+ > component. Since there are generic routines that access the > registers (e.g, CS_LOCK/UNLOCK , claim/disclaim operations, timeout) > and in order to preserve the log

Re: [PATCH] PCI: Mark AMD Navi10 GPU rev 0x00 ATS as broken

2020-07-29 Thread Bjorn Helgaas
On Tue, Jul 28, 2020 at 06:45:53PM +0800, Kai-Heng Feng wrote: > We are seeing AMD Radeon Pro W5700 doesn't work when IOMMU is enabled: > [3.375841] iommu ivhd0: AMD-Vi: Event logged [IOTLB_INV_TIMEOUT > device=63:00.0 address=0x42b5b01a0] > [3.375845] iommu ivhd0: AMD-Vi: Event logged [IO

Re: [PATCH] perf bench: Add benchmark of find_next_bit

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 08:51:52AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Jul 24, 2020 at 12:19:59AM -0700, Ian Rogers escreveu: > > for_each_set_bit, or similar functions like for_each_cpu, may be hot > > within the kernel. If many bits were set then one could imagine on > > Intel a "

Re: [PATCH v2] lib: kunit: Convert test_sort to KUnit test

2020-07-29 Thread Brendan Higgins
On Wed, Jul 29, 2020 at 12:19 PM Andy Shevchenko wrote: > > On Wed, Jul 29, 2020 at 04:11:51PM -0300, Vitor Massaru Iha wrote: > > This adds the conversion of the test_sort.c to KUnit test. > > > > Please apply this commit first (linux-kselftest/kunit-fixes): > > 3f37d14b8a3152441f36b6bc7400099667

Re: [PATCH RFC] x86/bus_lock: Enable bus lock detection

2020-07-29 Thread Sean Christopherson
On Wed, Jul 29, 2020 at 07:42:59PM +, Fenghua Yu wrote: > > Smushing the two into a single option is confusing, e.g. from the table > > below it's not at all clear what will happen if sld=fatal, both features > > are supported, and the kernel generates a split lock. > > > > Given that both SLD

Re: [PATCH 0/7] ARM: samsung: Cleanup of various S3C bits

2020-07-29 Thread Arnd Bergmann
On Wed, Jul 29, 2020 at 6:11 PM Krzysztof Kozlowski wrote: > > Hi, > > I tried to cleanup few warnings in S3C machine code which lead to > finding some bigger issues. > > Patches touch mostly the ARM Samsung machine code except patch #1 (clk) > and #5 (watchdog). They are independent from each ot

Re: [PATCH v3 1/4] iommu: Check IOMMU_DEV_FEAT_AUX feature in aux api's

2020-07-29 Thread Alex Williamson
On Tue, 14 Jul 2020 13:57:00 +0800 Lu Baolu wrote: > The iommu aux-domain api's work only when IOMMU_DEV_FEAT_AUX is enabled > for the device. Add this check to avoid misuse. Shouldn't this really be the IOMMU driver's responsibility to test? If nothing else, iommu_dev_feature_enabled() needs t

kernel BUG at mm/internal.h:LINE! (2)

2020-07-29 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:68845a55 Merge branch 'akpm' into master (patches from And.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17c86c5490 kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267 das

Re: [PATCH v3 2/4] iommu: Add iommu_aux_at(de)tach_group()

2020-07-29 Thread Alex Williamson
On Thu, 16 Jul 2020 09:07:46 +0800 Lu Baolu wrote: > Hi Jacob, > > On 7/16/20 12:01 AM, Jacob Pan wrote: > > On Wed, 15 Jul 2020 08:47:36 +0800 > > Lu Baolu wrote: > > > >> Hi Jacob, > >> > >> On 7/15/20 12:39 AM, Jacob Pan wrote: > >>> On Tue, 14 Jul 2020 13:57:01 +0800 > >>> Lu Baolu wr

Re: [PATCH ghak90 V9 02/13] audit: add container id

2020-07-29 Thread Richard Guy Briggs
On 2020-07-05 11:09, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs wrote: > > > > Implement the proc fs write to set the audit container identifier of a > > process, emitting an AUDIT_CONTAINER_OP record to document the event. > > > > This is a write from the container orc

Re: [PATCH v5 3/5] media: venus: core: Add support for opp tables/perf voting

2020-07-29 Thread Bjorn Andersson
On Wed 29 Jul 00:16 PDT 2020, Rajendra Nayak wrote: > Add support to add OPP tables and perf voting on the OPP powerdomain. > This is needed so venus votes on the corresponding performance state > for the OPP powerdomain along with setting the core clock rate. > > Signed-off-by: Rajendra Nayak >

Re: [PATCH RFC] x86/bus_lock: Enable bus lock detection

2020-07-29 Thread peterz
On Wed, Jul 29, 2020 at 01:00:33PM -0700, Sean Christopherson wrote: > Why do they need to be exclusive? We've already established that BLD catches > things that SLD does not. What's wrong with running sld=fatal and > bld=ratelimit > so that split locks never happen and kill applications, and no

[PATCH] lib: kunit: add test_min_heap test conversion to KUnit

2020-07-29 Thread Vitor Massaru Iha
This adds the conversion of the runtime tests of test_min_heap, from `lib/test_min_heap.c` to KUnit tests. Please apply this commit first (linux-kselftest/kunit-fixes): 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space Signed-off-by: Vitor Mas

[PATCH v3 0/6] PCI: Minor kerneldoc warning fixes

2020-07-29 Thread Krzysztof Kozlowski
Hi, Changes since v2: 1. Fix almost all warnings, except: drivers/pci/controller/pci-hyperv.c:2534: warning: Function parameter or member 'version' not described in 'hv_pci_protocol_negotiation' drivers/pci/controller/pci-hyperv.c:2534: warning: Function parameter or member 'num_version' n

[PATCH v3 2/6] PCI: endpoint: Fix kerneldoc

2020-07-29 Thread Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc): drivers/pci/endpoint/pci-epc-core.c:18: warning: cannot understand function prototype: 'struct class *pci_epc_class; ' drivers/pci/endpoint/pci-ep-cfs.c:17: warning: Function parameter or member 'functions_idr' not described in 'DEFINE_IDR'

[PATCH v3 1/6] PCI: Fix kerneldoc

2020-07-29 Thread Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc): drivers/pci/ats.c:196: warning: Function parameter or member 'pdev' not described in 'pci_enable_pri' drivers/pci/ats.c:196: warning: Function parameter or member 'reqs' not described in 'pci_enable_pri' drivers/pci/of.c:262: warning: Fun

[PATCH v3 5/6] PCI: rockchip: Fix kerneldoc

2020-07-29 Thread Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc): drivers/pci/controller/pcie-rockchip-ep.c:50: warning: Function parameter or member 'epc' not described in 'rockchip_pcie_ep' Signed-off-by: Krzysztof Kozlowski --- drivers/pci/controller/pcie-rockchip-ep.c | 1 + 1 file changed, 1 insertion(+)

<    1   2   3   4   5   6   7   8   9   10   >