Re: [PATCH 6/7] modules: return licensing information from find_symbol

2020-07-29 Thread Jessica Yu
+++ Christoph Hellwig [29/07/20 08:27 +0200]: Report the GPLONLY status through a new argument. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 2 +- kernel/module.c| 16 +++- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/include/linux/module.h

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-29 Thread Kazlauskas, Nicholas
On 2020-07-28 5:08 a.m., dan...@ffwll.ch wrote: On Mon, Jul 27, 2020 at 10:49:48PM -0400, Kazlauskas, Nicholas wrote: On 2020-07-27 5:32 p.m., Daniel Vetter wrote: On Mon, Jul 27, 2020 at 11:11 PM Mazin Rezk wrote: On Monday, July 27, 2020 4:29 PM, Daniel Vetter wrote: On Mon, Jul 27, 202

Error: invalid switch -me200

2020-07-29 Thread kernel test robot
-r014-20200729 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 417d3d495f1cfb0a2f7b60d00829925126fdcfd9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod

[PATCH v2 2/2] thermal: qcom-spmi-temp-alarm: add support for GEN2 rev 1 PMIC peripherals

2020-07-29 Thread Guru Das Srinagesh
From: David Collins Add support for TEMP_ALARM GEN2 PMIC peripherals with digital major revision 1. This revision utilizes a different temperature threshold mapping than earlier revisions. Signed-off-by: David Collins Signed-off-by: Guru Das Srinagesh --- Changes from v1: - Added space paddin

[PATCH v2 1/2] thermal: qcom-spmi-temp-alarm: Don't suppress negative temp

2020-07-29 Thread Guru Das Srinagesh
From: Veera Vegivada Currently driver is suppressing the negative temperature readings from the vadc. Consumers of the thermal zones need to read the negative temperature too. Don't suppress the readings. Fixes: c610afaa21d3c6e ("thermal: Add QPNP PMIC temperature alarm driver") Signed-off-by: V

Re: [patch V5 05/15] entry: Provide infrastructure for work before transitioning to guest mode

2020-07-29 Thread Qian Cai
_ioctl_run+0xb52/0x1320 [kvm] [ 765.487229] Modules linked in: vfio_pci vfio_virqfd vfio_iommu_type1 vfio loop nls_ascii nls_cp437 vfat fat [ 766.118568] CPU: 13 PID: 3377 Comm: qemu-kvm Not tainted 5.8.0-rc7-next-20200729 #2 [ 766.147011] ? kthread_create_worker_on_cpu+0xc0/0xc0 [ 766.147016] ret_from_

Re: [PATCH v5 2/4] power: supply: bq27xxx_battery: Add the BQ27z561 Battery monitor

2020-07-29 Thread Sebastian Reichel
Hi, On Wed, Jul 29, 2020 at 10:55:54AM -0500, Dan Murphy wrote: > > +<<< HEAD > > Need to remove this artifact from a rebase. > > Not sure how this got here as it does not appear in my source. You don't see it in your source, since you removed it in patch 4. -- Sebastian signature.asc De

Re: [PATCH 2/2] power: supply: Fix kerneldoc of power_supply_temp2resist_simple()

2020-07-29 Thread Sebastian Reichel
Hi, On Wed, Jul 29, 2020 at 09:43:48AM +0200, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/power/supply/power_supply_core.c:747: warning: Function parameter > or member 'temp' not described in 'power_supply_temp2resist_simple' > drivers/power/sup

Re: [PATCH 1/2] power: supply: cpcap-battery: Fix kerneldoc of cpcap_battery_read_accumulated()

2020-07-29 Thread Sebastian Reichel
Hi, On Wed, Jul 29, 2020 at 09:43:47AM +0200, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/power/supply/cpcap-battery.c:292: warning: Function parameter or > member 'ccd' not described in 'cpcap_battery_read_accumulated' > drivers/power/supply/cp

Re: [PATCH -next] irqchip/imx-intmux: Fix irqdata regs save in imx_intmux_runtime_suspend()

2020-07-29 Thread Marc Zyngier
On 2020-07-29 16:58, Wei Yongjun wrote: Gcc report warning as follows: drivers/irqchip/irq-imx-intmux.c:316:29: warning: variable 'irqchip_data' set but not used [-Wunused-but-set-variable] 316 | struct intmux_irqchip_data irqchip_data; | ^~~~ irqda

Re: [PATCH 5/7] ARM: samsung: Kill useless HAVE_S3C2410_WATCHDOG

2020-07-29 Thread Guenter Roeck
On Wed, Jul 29, 2020 at 06:09:40PM +0200, Krzysztof Kozlowski wrote: > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs does > not have sense, because: > 1. All ARMv7 and ARMv8 Samsung SoCs have watchdog, > 2. All architecture Kconfigs were selecting it (if WATCHDOG framework is >

[PATCH v2 1/3] kconfig: qconf: use if_changed for qconf.moc rule

2020-07-29 Thread Masahiro Yamada
Regenerate qconf.moc when the moc command is changed. This also allows 'make mrproper' to clean it up. Previously, it was not cleaned up because 'clean-files += qconf.moc' was missing. Now 'make mrproper' correctly cleans it up because files listed in 'targets' are cleaned. Signed-off-by: Masahir

[PATCH v2 2/3] kconfig: qconf: compile moc object separately

2020-07-29 Thread Masahiro Yamada
Currently, qconf.moc is included from qconf.cc but they can be compiled independently. When you modify qconf.cc, qconf.moc does not need recompiling. Rename qconf.moc to qconf.moc.cc, and split it out as an independent compilation unit. Signed-off-by: Masahiro Yamada --- Changes in v2: - New

[PATCH v2 3/3] kconfig: qconf: use delete[] instead of delete to free array

2020-07-29 Thread Masahiro Yamada
cppcheck reports "Mismatching allocation and deallocation". $ cppcheck scripts/kconfig/qconf.cc Checking scripts/kconfig/qconf.cc ... scripts/kconfig/qconf.cc:1242:10: error: Mismatching allocation and deallocation: data [mismatchAllocDealloc] delete data; ^ scripts/kconfig/qconf.cc:12

Re: [PATCH] ext4: Fix comment typo "the the".

2020-07-29 Thread Jan Kara
On Sat 25-04-20 02:16:24, kyoungho koo wrote: > I have found double typed comments "the the". So i modified it to > one "the" > > Signed-off-by: kyoungho koo Ted, this seems to have fallen through the cracks... Honza > --- > fs/e

Re: [PATCH] remoteproc: virtio: support sharing vdev buffer

2020-07-29 Thread Mathieu Poirier
Hi Peng, On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote: > Support sharing vdev buffer between multiple vdevs by using name > "vdevbuffer". > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/remoteproc_virtio.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH 2/7] modules: mark find_symbol static

2020-07-29 Thread Christoph Hellwig
On Wed, Jul 29, 2020 at 06:24:35PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 29, 2020 at 06:13:18PM +0200, Jessica Yu wrote: > > +++ Christoph Hellwig [29/07/20 08:27 +0200]: > > > find_symbol is only used in module.c. > > > > > > Signed-off-by: Christoph Hellwig > > > > CCing the livepatch

Re: [PATCH 6/7] modules: return licensing information from find_symbol

2020-07-29 Thread Christoph Hellwig
On Wed, Jul 29, 2020 at 06:48:00PM +0200, Jessica Yu wrote: > Just a small nit. Most of module.c uses license rather than licence - > could we unify the spelling to remain consistent? Sigh, American vs. > British English.. :) Sure, I can fix that up.

Re: [RFC PATCH v5 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-29 Thread Dmitry Osipenko
28.07.2020 19:04, Sowjanya Komatineni пишет: ... >>> +void tegra_mipi_cancel_calibration(struct tegra_mipi_device *device) >>> +{ >> Doesn't MIPI_CAL need to be reset here? > No need to reset MIPI CAL Could you please explain why. There is a calibration state-machine that apparently needs to be re

Re: [PATCH v3 4/5] mm: memcg: charge memcg percpu memory to the parent cgroup

2020-07-29 Thread Michal Koutný
Hello. On Tue, Jun 23, 2020 at 11:45:14AM -0700, Roman Gushchin wrote: > Because the size of memory cgroup internal structures can dramatically > exceed the size of object or page which is pinning it in the memory, it's > not a good idea to simple ignore it. It actually breaks the isolation > be

Re: [PATCH 1/6] dt-bindings: display: Document NewVision NV3052C DT node

2020-07-29 Thread Laurent Pinchart
Hi Paul, Thank you for the patch. On Mon, Jul 27, 2020 at 06:46:08PM +0200, Paul Cercueil wrote: > Add documentation for the Device Tree node for LCD panels based on the > NewVision NV3052C controller. > > Signed-off-by: Paul Cercueil > --- > .../display/panel/newvision,nv3052c.yaml | 69

RE: [Intel-wired-lan] [PATCH 4/4] ixgbe/ixgbe_ethtool.c: Remove unnecessary usages of memset.

2020-07-29 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Suraj Upadhyay > Sent: Tuesday, July 14, 2020 12:42 PM > To: Kirsher, Jeffrey T ; da...@davemloft.net; > k...@kernel.org > Cc: net...@vger.kernel.org; kernel-janit...@vger.kernel.org; intel-wired- > l...@lists.osuosl.org; linux-ke

[PATCH] kconfig: qconf: remove "goBack" debug message

2020-07-29 Thread Masahiro Yamada
Every time the goback icon is clicked, the annoying message "goBack" is displayed on the console. I guess this line is the left-over debug code of commit af737b4defe1 ("kconfig: qconf: simplify the goBack() logic"). Signed-off-by: Masahiro Yamada --- scripts/kconfig/qconf.cc | 1 - 1 file chan

Re: [PATCH 1/2] firmware: qcom_scm: Add memory protect virtual address ranges

2020-07-29 Thread Elliot Berman
++ On 7/24/2020 8:04 AM, Stanimir Varbanov wrote: > Hi, > > Gentle ping for review. > > On 7/9/20 2:58 PM, Stanimir Varbanov wrote: >> This adds a new SCM memprotect command to set virtual address ranges. >> >> Signed-off-by: Stanimir Varbanov >> --- >> drivers/firmware/qcom_scm.c | 24 +++

Re: [PATCH rdma-next 0/4] Fix bugs around RDMA CM destroying state

2020-07-29 Thread Jason Gunthorpe
On Thu, Jul 23, 2020 at 10:07:03AM +0300, Leon Romanovsky wrote: > This small series simplifies some of the RDMA CM state transitions > connected with DESTROYING states and in the process resolves a bug > discovered by syzkaller. > > Thanks > > Jason Gunthorpe (4): > RDMA/cma: Simplify DEVICE_

Re: [PATCH] atm: Fix atm_dev reference count leaks in atmtcp_remove_persistent()

2020-07-29 Thread Markus Elfring
… > The refcount leaks issues occur in two error handling paths. Can it be nicer to use the term “reference count” for the commit message? > Fix the issue by … I suggest to replace this wording by the tag “Fixes”. … > +++ b/drivers/atm/atmtcp.c > @@ -433,9 +433,15 @@ static int atmtcp_remove

Re: [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units

2020-07-29 Thread Mathieu Poirier
On Wed, Jul 22, 2020 at 06:20:40PM +0100, Suzuki K Poulose wrote: > Document the bindings for ETMv4.4 and later with only system register > access. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > Documentati

Re: [PATCH 2/7] modules: mark find_symbol static

2020-07-29 Thread Joe Lawrence
On 7/29/20 12:24 PM, Greg Kroah-Hartman wrote: On Wed, Jul 29, 2020 at 06:13:18PM +0200, Jessica Yu wrote: +++ Christoph Hellwig [29/07/20 08:27 +0200]: find_symbol is only used in module.c. Signed-off-by: Christoph Hellwig CCing the livepatching ML, as this may or may not impact its users.

Re: mmotm 2020-07-27-18-18 uploaded (mm/page_alloc.c)

2020-07-29 Thread Randy Dunlap
On 7/29/20 9:14 AM, David Hildenbrand wrote: > On 29.07.20 16:38, David Hildenbrand wrote: >> On 29.07.20 16:18, Michael S. Tsirkin wrote: >>> On Tue, Jul 28, 2020 at 03:31:43PM -0700, Andrew Morton wrote: On Wed, 29 Jul 2020 08:20:53 +1000 Stephen Rothwell wrote: > Hi Andrew,

Re: Re: Re: [PATCH v18 02/14] mm: Introduce Data Access MONitor (DAMON)

2020-07-29 Thread SeongJae Park
On Wed, 29 Jul 2020 08:31:29 -0700 Shakeel Butt wrote: > On Sat, Jul 18, 2020 at 6:31 AM SeongJae Park wrote: > > > > On Fri, 17 Jul 2020 19:47:50 -0700 Shakeel Butt wrote: > > > > > On Mon, Jul 13, 2020 at 1:43 AM SeongJae Park wrote: > > > > > > > > From: SeongJae Park > > > > > > > > DAMON

[char-misc-next] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

2020-07-29 Thread Tomas Winkler
wired_cmd_repeater_auth_stream_req_in has a variable length array at the end. we use struct_size() overflow macro to determine the size for the allocation and sending size. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Cc: Ramalingam C Cc: Gustavo A. R. Si

Re: [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()

2020-07-29 Thread Mike Kravetz
On 6/30/20 7:26 AM, David Hildenbrand wrote: > Right now, if we have two isolations racing, we might trigger the > WARN_ON_ONCE() and to dump_page(NULL), dereferencing NULL. Let's just > return directly. Just curious, what call path has the WARN_ON_ONCE()/dump_page(NULL)? > > In the future, we m

Re: [PATCH 6/7] ARM: s3c64xx: Switch to generic watchdog driver reset

2020-07-29 Thread Tomasz Figa
Hi Krzysztof, 2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > Similarly to commit f6361c6b3880 ("ARM: S3C24XX: remove separate restart > code"), the platform watchdog reset code can be removed in favor of > a generic watchdog driver which already handles reset. > > This allows removal of a bunch of

INVESTMENT PROPOSAL.

2020-07-29 Thread Daouda Ali
It’s my pleasure to contact you through this media because I need an investment assistance in your country. However I have a profitable investment proposal with good interest to share with you, amounted the sum of (Twenty Eight Million Four Hundred Thousand United State Dollar ($28.400.000.00). If

Re: [PATCH v4 1/5] dt-bindings: irqchip: Add PRU-ICSS interrupt controller bindings

2020-07-29 Thread David Lechner
On 7/28/20 4:18 AM, Grzegorz Jaszczyk wrote: From: Suman Anna The Programmable Real-Time Unit and Industrial Communication Subsystem (PRU-ICSS or simply PRUSS) contains an interrupt controller (INTC) that can handle various system input events and post interrupts back to the device-level initia

Re: [PATCH 5/7] ARM: samsung: Kill useless HAVE_S3C2410_WATCHDOG

2020-07-29 Thread Tomasz Figa
2020年7月29日(水) 19:02 Guenter Roeck : > > On Wed, Jul 29, 2020 at 06:09:40PM +0200, Krzysztof Kozlowski wrote: > > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs does > > not have sense, because: > > 1. All ARMv7 and ARMv8 Samsung SoCs have watchdog, > > 2. All architecture Kconfigs

[PATCH v2] hv_utils: Add validation for untrusted Hyper-V values

2020-07-29 Thread Andres Beltran
For additional robustness in the face of Hyper-V errors or malicious behavior, validate all values that originate from packets that Hyper-V has sent to the guest in the host-to-guest ring buffer. Ensure that invalid values cannot cause indexing off the end of the icversion_data array in vmbus_prep_

Re: [PATCH 1/7] clk: samsung: s3c64xx: Declare s3c64xx_clk_init() in shared header

2020-07-29 Thread Tomasz Figa
2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > The s3c64xx_clk_init() is defined and used by clk-s3c64xx driver and > also used in mach-s3c64xx machine code. Move the declaration to a > header to fix W=1 build warning: > > drivers/clk/samsung/clk-s3c64xx.c:391:13: warning: no previous prototype

[PATCH v5 0/2] Add character device interface to remoteproc

2020-07-29 Thread Siddharth Gupta
This patch series adds a character device interface to remoteproc framework. Currently there is only a sysfs interface which the userspace clients can use. If a usersapce application crashes after booting the remote processor through the sysfs interface the remote processor does not get any indicat

[PATCH v5 1/2] remoteproc: Add remoteproc character device interface

2020-07-29 Thread Siddharth Gupta
Add the character device interface into remoteproc framework. This interface can be used in order to boot/shutdown remote subsystems and provides a basic ioctl based interface to implement supplementary functionality. An ioctl call is implemented to enable the shutdown on release feature which will

[PATCH v5 2/2] remoteproc: core: Register the character device interface

2020-07-29 Thread Siddharth Gupta
Add the character device during rproc_add. This would create a character device node at /dev/remoteproc. Userspace applications can interact with the remote processor using this interface. Signed-off-by: Rishabh Bhatnagar Signed-off-by: Siddharth Gupta --- drivers/remoteproc/remoteproc_core.c |

Re: [PATCH v3 18/19] firmware: Add request_partial_firmware_into_buf()

2020-07-29 Thread Kees Cook
On Wed, Jul 29, 2020 at 08:22:17AM +0200, Takashi Iwai wrote: > On Wed, 29 Jul 2020 03:17:39 +0200, > Luis Chamberlain wrote: > > > > Long ago Takashi had some points about this strategy breaking > > compressed file use. Was that considered? > > As long as I read the patch, it tries to skip both

[PATCH] MAINTAINERS: edac: socfpga: transfer SoCFPGA EDAC maintainership

2020-07-29 Thread Dinh Nguyen
Thor Thayer is leaving Intel and will no longer be able to maintain the EDAC for SoCFPGA, thus transfer maintainership to Dinh Nguyen. Signed-off-by: Dinh Nguyen --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f0569cf304ca..c53f

Re: [PATCH 2/7] ARM: s3c64xx: Include header to fix -Wmissing-prototypes

2020-07-29 Thread Tomasz Figa
2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > Include the spi-s3c64xx.h header to fix W=1 build warning: > > arch/arm/mach-s3c64xx/setup-spi.c:11:5: warning: > no previous prototype for 's3c64xx_spi0_cfg_gpio' > [-Wmissing-prototypes] >11 | int s3c64xx_spi0_cfg_gpio(void) > > S

[PATCH] Revert "kconfig: qconf: Change title for the item window"

2020-07-29 Thread Masahiro Yamada
This reverts commit 5752ff07fd90d764d96e3c586cc95c09598abfdd. It added pointless dead code to ConfigList:ConfigList(). The constructor of ConfigList has the initializer, mode(singleMode). if (mode == symbolMode) setHeaderLabels(QStringList() << "Item" << "Name" << "N" << "M" << "

Re: [RFC PATCH v5 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 10:08 AM, Dmitry Osipenko wrote: 28.07.2020 19:04, Sowjanya Komatineni пишет: ... +void tegra_mipi_cancel_calibration(struct tegra_mipi_device *device) +{ Doesn't MIPI_CAL need to be reset here? No need to reset MIPI CAL Could you please explain why. There is a calibration state-

Re: [PATCH 3/7] ARM: s3c: Remove plat-samsung/.../samsung-time.h

2020-07-29 Thread Tomasz Figa
2020年7月29日(水) 18:11 Krzysztof Kozlowski : > > Remove the arch/arm/plat-samsung/include/plat/samsung-time.h header and > move the contents to common.h headers in mach-s3c24xx and mach-s3c64xx. > The definition of declared functions is already in common.c in mach > directories, so it is logically to

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Sergey Senozhatsky
On (20/07/29 22:28), Herbert Xu wrote: > This miniseries breaks a header loop involving qspinlock_types.h. > The issue is that qspinlock_types.h includes atomic.h, which then > eventually includes kernel.h which could lead back to the original > file via spinlock_types.h. > > The first patch moves

[PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

2020-07-29 Thread Matthias Kaehlcke
For disabled paths the 'interconnect_summary' in debugfs currently shows the orginally requested bandwidths. This is confusing, since the bandwidth requests aren't active. Instead show the bandwidths for disabled paths/requests as zero. Signed-off-by: Matthias Kaehlcke --- drivers/interconnect/

Re: [Intel-gfx] [PATCH v12 2/3] drm/i915: add syncobj timeline support

2020-07-29 Thread Linus Torvalds
On Wed, Jul 29, 2020 at 5:24 AM Daniel Vetter wrote: > > Do we have a access_ok_array or so? Instead of duplicating overflow checks > everywhere and getting it all wrong ... I really really think you should get away from access_ok() entirely. Please just get rid of it, and use "copy_from_user()"

Re: [PATCH v17 18/21] mm/lru: introduce the relock_page_lruvec function

2020-07-29 Thread Alexander Duyck
On Sat, Jul 25, 2020 at 6:00 AM Alex Shi wrote: > > Use this new function to replace repeated same code, no func change. > > Signed-off-by: Alex Shi > Cc: Johannes Weiner > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: Andrey Ryabinin > Cc: Matthew Wilcox > Cc: Mel Gorman > Cc: Konstantin K

Re: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

2020-07-29 Thread Rafael J. Wysocki
On Wednesday, July 29, 2020 7:46:08 AM CEST Francisco Jerez wrote: > > --==-=-= > Content-Type: multipart/mixed; boundary="=-=-=" > > --=-=-= > Content-Type: text/plain; charset=utf-8 > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > "Rafael J. Wysocki" writes: >

Re: [char-misc-next] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

2020-07-29 Thread Gustavo A. R. Silva
On 7/29/20 12:32, Tomas Winkler wrote: > wired_cmd_repeater_auth_stream_req_in has a variable > length array at the end. we use struct_size() overflow > macro to determine the size for the allocation and sending > size. > > Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible

Re: [PATCH v1 0/4] [RFC] Implement Trampoline File Descriptor

2020-07-29 Thread Madhavan T. Venkataraman
On 7/29/20 3:36 AM, David Laight wrote: > From: Madhavan T. Venkataraman >> Sent: 28 July 2020 19:52 > ... >> trampfd faults are instruction faults that go through a different code path >> than >> the one that calls handle_mm_fault(). Perhaps, it is the handle_mm_fault() >> that >> is time con

Re: Should perf version match kernel version?

2020-07-29 Thread Vitaly Chikunov
Peter, Arnaldo, On Wed, Jul 29, 2020 at 01:27:32PM -0300, Arnaldo Carvalho de Melo wrote: > > > On July 29, 2020 1:02:20 PM GMT-03:00, pet...@infradead.org wrote: > >On Wed, Jul 29, 2020 at 06:56:47PM +0300, Vitaly Chikunov wrote: > >> Hi, > >> > >> It seems that most distros try to have perf v

[PATCH] erofs: fix extended inode could cross boundary

2020-07-29 Thread Gao Xiang
Each ondisk inode should be aligned with inode slot boundary (32-byte alignment) because of nid calculation formula, so all compact inodes (32 byte) cannot across page boundary. However, extended inode is now 64-byte form, which can across page boundary in principle if the location is specified on

drivers/tty/synclinkmp.c:3642:29: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-07-29 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6ba1b005ffc388c2aeaddae20da29e4810dea298 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 6 weeks ago config: microblaze-randconfig-s032-20200729

[PATCH v4 15/17] firmware: Store opt_flags in fw_priv

2020-07-29 Thread Kees Cook
Instead of passing opt_flags around so much, store it in the private structure so it can be examined by internals without needing to add more arguments to functions. Co-developed-by: Scott Branden Signed-off-by: Scott Branden Signed-off-by: Kees Cook --- drivers/base/firmware_loader/fallback.c

[PATCH v4 08/17] fs/kernel_read_file: Add file_size output argument

2020-07-29 Thread Kees Cook
In preparation for adding partial read support, add an optional output argument to kernel_read_file*() that reports the file size so callers can reason more easily about their reading progress. Acked-by: Scott Branden Reviewed-by: Mimi Zohar Reviewed-by: Luis Chamberlain Signed-off-by: Kees Coo

[PATCH v4 14/17] fs/kernel_file_read: Add "offset" arg for partial reads

2020-07-29 Thread Kees Cook
To perform partial reads, callers of kernel_read_file*() must have a non-NULL file_size argument and a preallocated buffer. The new "offset" argument can then be used to seek to specific locations in the file to fill the buffer to, at most, "buf_size" per call. Where possible, the LSM hooks can re

[PATCH v4 16/17] firmware: Add request_partial_firmware_into_buf()

2020-07-29 Thread Kees Cook
From: Scott Branden Add request_partial_firmware_into_buf() to allow for portions of a firmware file to be read into a buffer. This is needed when large firmware must be loaded in portions from a file on memory constrained systems. Signed-off-by: Scott Branden Co-developed-by: Kees Cook Signed

[PATCH v4 13/17] IMA: Add support for file reads without contents

2020-07-29 Thread Kees Cook
From: Scott Branden When the kernel_read_file LSM hook is called with contents=false, IMA can appraise the file directly, without requiring a filled buffer. When such a buffer is available, though, IMA can continue to use it instead of forcing a double read here. Signed-off-by: Scott Branden Li

[PATCH] lib: kunit: add bitfield test conversion to KUnit

2020-07-29 Thread Vitor Massaru Iha
This adds the conversion of the runtime tests of test_bitfield, from `lib/test_bitfield.c` to KUnit tests. Please apply this commit first (linux-kselftest/kunit-fixes): 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space Code Style Documentation

[PATCH v4 11/17] module: Call security_kernel_post_load_data()

2020-07-29 Thread Kees Cook
Now that there is an API for checking loaded contents for modules loaded without a file, call into the LSM hooks. Cc: Jessica Yu Signed-off-by: Kees Cook --- kernel/module.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/kernel/module.c b/kernel/module.c ind

[PATCH v4 09/17] LSM: Introduce kernel_post_load_data() hook

2020-07-29 Thread Kees Cook
There are a few places in the kernel where LSMs would like to have visibility into the contents of a kernel buffer that has been loaded or read. While security_kernel_post_read_file() (which includes the buffer) exists as a pairing for security_kernel_read_file(), no such hook exists to pair with s

[PATCH v4 01/17] test_firmware: Test platform fw loading on non-EFI systems

2020-07-29 Thread Kees Cook
On non-EFI systems, it wasn't possible to test the platform firmware loader because it will have never set "checked_fw" during __init. Instead, allow the test code to override this check. Additionally split the declarations into a private header file so it there is greater enforcement of the symbol

[PATCH v4 04/17] fs/kernel_read_file: Split into separate include file

2020-07-29 Thread Kees Cook
From: Scott Branden Move kernel_read_file* out of linux/fs.h to its own linux/kernel_read_file.h include file. That header gets pulled in just about everywhere and doesn't really need functions not related to the general fs interface. Suggested-by: Christoph Hellwig Signed-off-by: Scott Branden

[PATCH v4 07/17] fs/kernel_read_file: Switch buffer size arg to size_t

2020-07-29 Thread Kees Cook
In preparation for further refactoring of kernel_read_file*(), rename the "max_size" argument to the more accurate "buf_size", and correct its type to size_t. Add kerndoc to explain the specifics of how the arguments will be used. Note that with buf_size now size_t, it can no longer be negative (an

[PATCH v4 06/17] fs/kernel_read_file: Remove redundant size argument

2020-07-29 Thread Kees Cook
In preparation for refactoring kernel_read_file*(), remove the redundant "size" argument which is not needed: it can be included in the return code, with callers adjusted. (VFS reads already cannot be larger than INT_MAX.) Acked-by: Scott Branden Reviewed-by: Mimi Zohar Reviewed-by: Luis Chamber

[PATCH v4 00/17] Introduce partial kernel_read_file() support

2020-07-29 Thread Kees Cook
v4: - add more reviews (mimi, luis) - adjusted comment (mimi) - fixed build error when not building firmware tests (0day, sfr) - fixed needless .xz read (tiwai) - rebased to driver-core-next v3: https://lore.kernel.org/lkml/20200724213640.389191-1-keesc...@chromium.org/ v2: lost to the ether v1: ht

[PATCH v4 10/17] firmware_loader: Use security_post_load_data()

2020-07-29 Thread Kees Cook
Now that security_post_load_data() is wired up, use it instead of the NULL file argument style of security_post_read_file(), and update the security_kernel_load_data() call to indicate that a security_kernel_post_load_data() call is expected. Wire up the IMA check to match earlier logic. Perhaps a

[PATCH v4 02/17] fs/kernel_read_file: Remove FIRMWARE_PREALLOC_BUFFER enum

2020-07-29 Thread Kees Cook
FIRMWARE_PREALLOC_BUFFER is a "how", not a "what", and confuses the LSMs that are interested in filtering between types of things. The "how" should be an internal detail made uninteresting to the LSMs. Fixes: a098ecd2fa7d ("firmware: support loading into a pre-allocated buffer") Fixes: fd90bc559bf

[PATCH v4 05/17] fs/kernel_read_file: Split into separate source file

2020-07-29 Thread Kees Cook
These routines are used in places outside of exec(2), so in preparation for refactoring them, move them into a separate source file, fs/kernel_read_file.c. Acked-by: Scott Branden Reviewed-by: Mimi Zohar Reviewed-by: Luis Chamberlain Signed-off-by: Kees Cook --- fs/Makefile | 3 +-

Hello, Please

2020-07-29 Thread Mr. Scott Donald
-- Dear Friend, I'm Mr. Scott Donald a Successful businessMan dealing with Exportation, I got your mail contact through search to let you know my intension and my Ugly Situation Am a dying Man here in Los Angeles California Hospital Bed in (USA), I Lost my Wife and my only Daughter for Covid-19 a

[PATCH v4 03/17] fs/kernel_read_file: Remove FIRMWARE_EFI_EMBEDDED enum

2020-07-29 Thread Kees Cook
The "FIRMWARE_EFI_EMBEDDED" enum is a "where", not a "what". It should not be distinguished separately from just "FIRMWARE", as this confuses the LSMs about what is being loaded. Additionally, there was no actual validation of the firmware contents happening. Fixes: e4c2c0ff00ec ("firmware: Add ne

[PATCH v4 12/17] LSM: Add "contents" flag to kernel_read_file hook

2020-07-29 Thread Kees Cook
As with the kernel_load_data LSM hook, add a "contents" flag to the kernel_read_file LSM hook that indicates whether the LSM can expect a matching call to the kernel_post_read_file LSM hook with the full contents of the file. With the coming addition of partial file read support for kernel_read_fil

Re: [PATCH V2] dmaengine: bcm-sba-raid: add missing put_device() call in sba_probe()

2020-07-29 Thread Markus Elfring
> if of_find_device_by_node() succeed, sba_probe() doesn't have a > corresponding put_device(). … Wording adjustment: If a of_find_device_by_node() call succeeded, sba_probe() did not contain a corresponding put_device() call. … Regards, Markus

Re: [RFC PATCH 01/14] coresight: etm4x: Skip save/restore before device registration

2020-07-29 Thread Mathieu Poirier
Hi Suzuki, I have starte to review this - comments will be scattered over a few days. On Wed, Jul 22, 2020 at 06:20:27PM +0100, Suzuki K Poulose wrote: > Skip cpu save/restore before the coresight device is registered. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose

[PATCH] erofs: fold in used-once helper erofs_workgroup_unfreeze_final()

2020-07-29 Thread Gao Xiang
It's expected that erofs_workgroup_unfreeze_final() won't be used in other places. Let's fold it to simplify the code. Signed-off-by: Gao Xiang --- fs/erofs/utils.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/fs/erofs/utils.c b/fs/erofs/utils.c index 52d0b

[PATCH 0/7] scsi: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
Hii Maintainers, This patchset replaces the pci-dma-compat wrappers with their dma-mapping counterparts. Thus, removing possible midlayering and unnecessary legacy code and API. Most of the task is fairly trivially scriptable and done with coccinelle. But the handling of pci_z/alloc_consis

Re: [PATCH v17 00/21] per memcg lru lock

2020-07-29 Thread Hugh Dickins
On Wed, 29 Jul 2020, Alex Shi wrote: > > Is there any comments or suggestion for this patchset? > Any hints will be very appreciated. Alex: it is now v5.8-rc7, obviously too late for this patchset to make v5.9, so I'm currently concentrated on checking some patches headed for v5.9 (and some bugfi

[PATCH 1/7] scsi: aacraid: Remove pci-dma-compat wrapper APIs

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile-tested. - PCI_DMA_BIDIRECTIONAL

Re: [PATCH v2 1/2] usb: xhci: define IDs for various ASMedia host controllers

2020-07-29 Thread Sergei Shtylyov
Hello! On 7/28/20 7:24 AM, Forest Crossman wrote: > Not all ASMedia host controllers have a device ID that matches its part > number. #define some of these IDs to make it clearer at a glance which > chips require what quirks. > > Signed-off-by: Forest Crossman > --- > drivers/usb/host/xhci-pci

[PATCH 2/7] scsi: aic7xxx: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. And has been hand modified to replace each GF

[tip:locking/core 9/30] arch/mips/include/asm/smp.h:28:19: error: static declaration of 'raw_smp_processor_id' follows non-static declaration

2020-07-29 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core head: b5e6a027bd327daa679ca55182a920659e2cbb90 commit: 859247d39fb008ea812e8f0c398a58a20c12899e [9/30] seqlock: lockdep assert non-preemptibility on seqcount_t write config: mips-allyesconfig (attached as .config) c

[PATCH 3/7] scsi: dc395x: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile tested. - PCI_DMA_BIDIRECTIONAL

Re: [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()

2020-07-29 Thread David Hildenbrand
On 29.07.20 19:31, Mike Kravetz wrote: > On 6/30/20 7:26 AM, David Hildenbrand wrote: >> Right now, if we have two isolations racing, we might trigger the >> WARN_ON_ONCE() and to dump_page(NULL), dereferencing NULL. Let's just >> return directly. > > Just curious, what call path has the WARN_ON_O

[PATCH v4 17/17] test_firmware: Test partial read support

2020-07-29 Thread Kees Cook
From: Scott Branden Add additional hooks to test_firmware to pass in support for partial file read using request_firmware_into_buf(): buf_size: size of buffer to request firmware into partial: indicates that a partial file request is being made file_offset: to indicate of

RE: [PATCH RFC] x86/bus_lock: Enable bus lock detection

2020-07-29 Thread Yu, Fenghua
Hi, Sean, > > A bus lock [1] is acquired either through split locked access to > > writeback (WB) memory or by using locks to uncacheable (UC) memory > > (e.g. direct device > > Does SLD not detect the lock to UC memory? The statement might not be accurate. Split Lock Detection doesn't detect bu

Re: [PATCH v3 12/19] firmware_loader: Use security_post_load_data()

2020-07-29 Thread Mimi Zohar
On Wed, 2020-07-29 at 12:29 -0400, Mimi Zohar wrote: > On Tue, 2020-07-28 at 12:43 -0700, Kees Cook wrote: > > On Mon, Jul 27, 2020 at 06:57:45AM -0400, Mimi Zohar wrote: > > > On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > > > > Now that security_post_load_data() is wired up, use it instead

[PATCH net-next] fib: fix fib_rules_ops indirect calls wrappers

2020-07-29 Thread Brian Vazquez
This patch fixes: commit b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops") which didn't consider the case when CONFIG_IPV6_MULTIPLE_TABLES is not set. Reported-by: Stephen Rothwell Fixes: b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_

[PATCH 4/7] scsi: mpt3sas: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile tested. - PCI_DMA_BIDIRECTIONAL

Re: [PATCH v4 4/5] arm64: dts: sdm845: Add OPP tables and power-domains for venus

2020-07-29 Thread Doug Anderson
Hi, On Tue, Jul 28, 2020 at 1:11 PM Lina Iyer wrote: > > On Tue, Jul 28 2020 at 13:51 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2020-07-28 09:52:12) > >> On Mon, Jul 27 2020 at 18:45 -0600, Stephen Boyd wrote: > >> >Quoting Lina Iyer (2020-07-24 09:28:25) > >> >> On Fri, Jul 24 2020 at 03:

[PATCH 5/7] scsi: hpsa: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile tested. - PCI_DMA_BIDIRECTIONAL

Re: [PATCH 2/6] arch: x86: Wrap TIF_IA32 checks

2020-07-29 Thread Gabriel Krisman Bertazi
Andy Lutomirski writes: > On Tue, Jul 28, 2020 at 9:46 PM Gabriel Krisman Bertazi > wrote: >> >> Andy Lutomirski writes: >> >> > On Tue, Jul 28, 2020 at 1:22 PM Gabriel Krisman Bertazi >> > wrote: >> >> >> >> In preparation to remove TIF_IA32, add wrapper that check the process >> >> has IA32

Re: linux-next: build failure after merge of the net-next tree

2020-07-29 Thread Brian Vazquez
Hi Stephen, thanks for reaching out and reporting the issue. I have just sent the fix for review in net-next: http://patchwork.ozlabs.org/project/netdev/patch/20200729181018.3221288-1-bria...@google.com/ cheers, Brian On Wed, Jul 29, 2020 at 4:27 AM Stephen Rothwell wrote: > > Hi all, > > After

{standard input}:2272: Error: inappropriate arguments for opcode 'mpydu'

2020-07-29 Thread kernel test robot
months ago config: arc-randconfig-r014-20200729 (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout

[PATCH 6/7] scsi: qla2xxx: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile tested. - PCI_DMA_BIDIRECTIONAL

[PATCH 7/7] scsi: megaraid: Remove pci-dma-compat wrapper APIs

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. And has been hand modified to replace each GF

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-07-29 Thread Douglas Gilbert
On 2020-07-29 10:32 a.m., Alan Stern wrote: On Wed, Jul 29, 2020 at 04:12:22PM +0200, Martin Kepplinger wrote: On 28.07.20 22:02, Alan Stern wrote: On Tue, Jul 28, 2020 at 09:02:44AM +0200, Martin Kepplinger wrote: Hi Alan, Any API cleanup is of course welcome. I just wanted to remind you tha

<    1   2   3   4   5   6   7   8   9   10   >