Re: [PATCH v4 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml

2020-07-09 Thread Rob Herring
On Wed, Jul 08, 2020 at 12:07:47PM +0800, Chris Ruehl wrote: > Add documentation for the newly added DTS support in the shtc1 driver. > To align with the drivers logic to have high precision by default > a boolean sensirion,low_precision is used to switch to low precision. > > Signed-off-by: Chris

Re: [PATCH v3 04/16] dt-bindings: pinctrl: sunxi: make gpio banks supplies required

2020-07-09 Thread Rob Herring
On Wed, Jul 08, 2020 at 03:19:30PM +0800, Frank Lee wrote: > Since we don't really have to care about the existing DT for boards, > it would be great to make the gpio banks supplies required. > > Signed-off-by: Frank Lee > --- > .../devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml

Re: [PATCH] ASoC: Intel: boards: eve: Fix DMIC records zero

2020-07-09 Thread Pierre-Louis Bossart
On 7/9/20 10:25 AM, vamshi.krishna.go...@intel.com wrote: From: Brent Lu Add a dapm route to provide ssp mclk/sclk early for DMIC on SSP0(rt5514) and Headset on SSP1(rt5663) since sclk for both codecs are different the struct now defines SSP0 and SSP1 mclk , sclk separately This change ensu

Re: [PATCH v3 06/16] dt-bindings: nvmem: SID: add binding for A100's SID controller

2020-07-09 Thread Rob Herring
On Wed, 08 Jul 2020 15:19:32 +0800, Frank Lee wrote: > Add a binding for A100's SID controller. > > Signed-off-by: Frank Lee > --- > Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 3 +++ > 1 file changed, 3 insertions(+) > My bot found errors running 'make dt_binding_c

Re: [PATCH 2/5] iommu/arm-smmu: Emulate bypass by using context banks

2020-07-09 Thread Rob Clark
On Thu, Jul 9, 2020 at 9:48 AM Bjorn Andersson wrote: > > On Thu 09 Jul 09:17 PDT 2020, Rob Clark wrote: > > > On Wed, Jul 8, 2020 at 10:01 PM Bjorn Andersson > > wrote: > [..] > > > @@ -678,7 +680,11 @@ static int arm_smmu_init_domain_context(struct > > > iommu_domain *domain, > > > if

[PATCH 1/2] mm/migrate: optimize migrate_vma_setup() for holes

2020-07-09 Thread Ralph Campbell
When migrating system memory to device private memory, if the source address range is a valid VMA range and there is no memory or a zero page, the source PFN array is marked as valid but with no PFN. This lets the device driver allocate private memory and clear it, then insert the new device privat

[PATCH 2/2] mm/migrate: add migrate-shared test for migrate_vma_*()

2020-07-09 Thread Ralph Campbell
Add a migrate_vma_*() self test for mmap(MAP_SHARED) to verify that !vma_anonymous() ranges won't be migrated. Signed-off-by: Ralph Campbell --- tools/testing/selftests/vm/hmm-tests.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/tools/testing/selftests/vm/hmm-t

[PATCH 0/2] mm/migrate: optimize migrate_vma_setup() for holes

2020-07-09 Thread Ralph Campbell
A simple optimization for migrate_vma_*() when the source vma is not an anonymous vma and a new test case to exercise it. This is based on linux-mm and is for Andrew Morton's tree. Ralph Campbell (2): mm/migrate: optimize migrate_vma_setup() for holes mm/migrate: add migrate-shared test for mi

Re: [PATCH] kernel/smp: Fix an off by one in csd_lock_wait_toolong()

2020-07-09 Thread Paul E. McKenney
On Thu, Jul 09, 2020 at 01:48:18PM +0300, Dan Carpenter wrote: > The __per_cpu_offset[] array has "nr_cpu_ids" elements so change the > > >= to prevent a read one element beyond the end of the array. > > Fixes: 0504bc41a62c ("kernel/smp: Provide CSD lock timeout diagnostics") > Signed-off-by: Dan

Re: [PATCH v6 11/14] dt-bindings: PCI: Add EP mode dt-bindings for TI's J721E SoC

2020-07-09 Thread Rob Herring
On Wed, 08 Jul 2020 15:00:15 +0530, Kishon Vijay Abraham I wrote: > Add PCIe EP mode dt-bindings for TI's J721E SoC. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Rob Herring > --- > .../bindings/pci/ti,j721e-pci-ep.yaml | 89 +++ > 1 file changed, 89 insertio

Re: [PATCH] thermal/int340x_thermal: Prevent page fault on .set_mode() op

2020-07-09 Thread Srinivas Pandruvada
On Wed, 2020-07-08 at 15:46 +0200, Bartosz Szczepanek wrote: > Starting from commit "thermal/int340x_thermal: Don't require IDSP to > exist", priv->current_uuid_index is initialized to -1. This value may > be passed to int3400_thermal_run_osc() from int3400_thermal_set_mode, > contributing to page

Re: [PATCH 2/4] dt-bindings: i3c: Describe Silvaco master binding

2020-07-09 Thread Rob Herring
On Thu, 09 Jul 2020 10:01:57 +0200, Miquel Raynal wrote: > Silvaco provide a dual-role I3C master. > > Description is rather simple: it needs a register mapping, three > clocks and an interrupt. > > Signed-off-by: Miquel Raynal > --- > .../bindings/i3c/svc,i3c-master.yaml | 59

Re: [PATCH] rculist : Introduce list/hlist_for_each_entry_srcu() macros

2020-07-09 Thread Madhuparna Bhowmik
On Wed, Jul 08, 2020 at 08:33:49AM -0400, j...@joelfernandes.org wrote: > > > On July 3, 2020 10:08:28 AM EDT, madhuparnabhowmi...@gmail.com wrote: > >From: Madhuparna Bhowmik > > > >list/hlist_for_each_entry_rcu() provides an optional cond argument > >to specify the lock held in the updater sid

[PATCH v4 3/6] gpio: max77620: Don't set of_node

2020-07-09 Thread Dmitry Osipenko
The gpiochip_add_data() takes care of setting the of_node to the parent's device of_node, hence there is no need to do it manually in the driver's code. This patch corrects the parent's device pointer and removes the unnecessary setting of the of_node. Suggested-by: Andy Shevchenko Reviewed-by: A

Re: [PATCH] KVM: nSVM: vmentry ignores EFER.LMA and possibly RFLAGS.VM

2020-07-09 Thread Jim Mattson
On Thu, Jul 9, 2020 at 2:55 AM Paolo Bonzini wrote: > > AMD doesn't specify (unlike Intel) that EFER.LME, CR0.PG and > EFER.LMA must be consistent, and for SMM state restore they say that > "The EFER.LMA register bit is set to the value obtained by logically > ANDing the SMRAM values of EFER.LME,

[PATCH v4 5/6] gpio: max77620: Use irqchip template

2020-07-09 Thread Dmitry Osipenko
This change addresses one of the GPIO-core TODOs for the MAX77620 driver which requires modern drivers to use the irqchip template. Instead of using the GPIO's irqchip-helpers for creating the IRQ domain, the gpio_irq_chip structure is now filled by the driver itself and then gpiochip_add_data() ta

[PATCH v4 4/6] gpio: max77620: Don't shadow error code of platform_get_irq()

2020-07-09 Thread Dmitry Osipenko
The platform_get_irq() returns a positive interrupt number on success and negative error code on failure (zero shouldn't ever happen in practice, it would produce a noisy warning). Hence let's return the error code directly instead of overriding it with -ENODEV. Suggested-by: Andy Shevchenko Revi

[PATCH v4 0/6] Improvements for MAX77620 GPIO driver

2020-07-09 Thread Dmitry Osipenko
Hello! This series addresses a problem that I discovered on Nexus 7 device where GPIO interrupts may be left enabled after bootloader and the driver isn't prepared to this. It also makes a small improvements to the code, fixes the non-released interrupt bug and converts driver to use irqchip templ

[PATCH v4 6/6] gpio: max77620: Initialize hardware state of interrupts

2020-07-09 Thread Dmitry Osipenko
I noticed on Nexus 7 that after rebooting from downstream kernel to upstream, the GPIO interrupt is triggering non-stop despite interrupts being disabled for all of GPIOs. This happens because Nexus 7 uses a soft-reboot, meaning that bootloader should take care of resetting hardware, but the bootlo

[PATCH v4 2/6] gpio: max77620: Fix missing release of interrupt

2020-07-09 Thread Dmitry Osipenko
The requested interrupt is never released by the driver. Fix this by using the resource-managed variant of request_threaded_irq(). Fixes: ab3dd9cc24d4 ("gpio: max77620: Fix interrupt handling") Cc: # 5.5+ Reviewed-by: Andy Shevchenko Acked-by: Laxman Dewangan Signed-off-by: Dmitry Osipenko ---

[PATCH v4 1/6] gpio: max77620: Replace 8 with MAX77620_GPIO_NR

2020-07-09 Thread Dmitry Osipenko
The MAX77620_GPIO_NR enum value represents the total number of GPIOs, let's use it instead of a raw value in order to improve the code's readability a tad. Reviewed-by: Andy Shevchenko Acked-by: Laxman Dewangan Signed-off-by: Dmitry Osipenko --- drivers/gpio/gpio-max77620.c | 6 +++--- 1 file

[PATCH] KVM: nVMX: fixes for preemption timer migration

2020-07-09 Thread Paolo Bonzini
Commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer migration", 2020-06-01) accidentally broke nVMX live migration from older version by changing the userspace ABI. Restore it and, while at it, ensure that vmx->nested.has_preemption_timer_deadline is always initialized according to the KVM_S

Re: [PATCH] scsi: virtio_scsi: Remove unnecessary condition checks

2020-07-09 Thread Markus Elfring
> kmem_cache_destroy and mempool_destroy can correctly handle > null pointer parameter, so there is no need to check if the > parameter is null before calling kmem_cache_destroy and > mempool_destroy. Can another imperative wording be preferred for the change description? … > +++ b/drivers/scsi/

Re: [PATCH 0/2] clk: meson8b: add two missing gate clocks

2020-07-09 Thread Jerome Brunet
On Mon 29 Jun 2020 at 22:39, Martin Blumenstingl wrote: > While trying to figure out how to set up the video clocks on the 32-bit > SoCs I found that the current clock tree is missing two gates. This adds > the missing gates based on evidence found in the public S805 datasheet, > the GXBB cloc

Re: [PATCH v3 04/16] dt-bindings: pinctrl: sunxi: make gpio banks supplies required

2020-07-09 Thread Ondřej Jirman
Hello, On Wed, Jul 08, 2020 at 03:19:30PM +0800, Frank Lee wrote: > Since we don't really have to care about the existing DT for boards, > it would be great to make the gpio banks supplies required. What if the borad doesn't use one of the banks? How would I describe such a board if defining supp

Re: [PATCH v8 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-09 Thread Matthias Kaehlcke
Hi Sandeep, On Thu, Jul 09, 2020 at 09:30:11PM +0530, Sandeep Maheswaram wrote: > Add interconnect support in dwc3-qcom driver to vote for bus > bandwidth. > > This requires for two different paths - from USB master to > DDR slave. The other is from APPS master to USB slave. > > Signed-off-by: S

[PATCH v4] clk: tegra: pll: Improve PLLM enable-state detection

2020-07-09 Thread Dmitry Osipenko
Power Management Controller (PMC) can override the PLLM clock settings, including the enable-state. Although PMC could only act as a second level gate, meaning that PLLM needs to be enabled by the Clock and Reset Controller (CaR) anyways if we want it to be enabled. Hence, when PLLM is overridden b

Re: [PATCH] KVM: nVMX: fixes for preemption timer migration

2020-07-09 Thread Jim Mattson
On Thu, Jul 9, 2020 at 10:15 AM Paolo Bonzini wrote: > > Commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer migration", > 2020-06-01) accidentally broke nVMX live migration from older version > by changing the userspace ABI. Restore it and, while at it, ensure > that vmx->nested.has_preemp

Re: [PATCH] KVM: nVMX: fixes for preemption timer migration

2020-07-09 Thread Paolo Bonzini
On 09/07/20 19:23, Jim Mattson wrote: > On Thu, Jul 9, 2020 at 10:15 AM Paolo Bonzini wrote: >> >> Commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer migration", >> 2020-06-01) accidentally broke nVMX live migration from older version >> by changing the userspace ABI. Restore it and, while

Re: [PATCH] KVM: nSVM: vmentry ignores EFER.LMA and possibly RFLAGS.VM

2020-07-09 Thread Paolo Bonzini
On 09/07/20 19:12, Jim Mattson wrote: >> + >> + /* The processor ignores EFER.LMA, but svm_set_efer needs it. */ >> + efer &= ~EFER_LMA; >> + if ((nested_vmcb->save.cr0 & X86_CR0_PG) >> + && (nested_vmcb->save.cr4 & X86_CR4_PAE) >> + && (efer & EFER_LME)) >> +

Re: [PATCH] scsi: virtio_scsi: Remove unnecessary condition checks

2020-07-09 Thread Paolo Bonzini
On 09/07/20 19:16, Markus Elfring wrote: >> +mempool_destroy(virtscsi_cmd_pool); >> +virtscsi_cmd_pool = NULL; >> +kmem_cache_destroy(virtscsi_cmd_cache); >> +virtscsi_cmd_cache = NULL; >> return ret; >> } > > How do you think about to add a jump target so that the execution

Re: [PATCH v19 08/12] landlock: Add syscall implementation

2020-07-09 Thread Arnd Bergmann
On Wed, Jul 8, 2020 at 7:50 PM Mickaël Salaün wrote: > On 08/07/2020 15:49, Arnd Bergmann wrote: > > On Wed, Jul 8, 2020 at 3:04 PM Mickaël Salaün wrote: > >> On 08/07/2020 10:57, Arnd Bergmann wrote: > >>> On Tue, Jul 7, 2020 at 8:10 PM Mickaël Salaün wrote: > >>> > >>> It looks like all you ne

Re: [PATCH v8 1/2] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-07-09 Thread Matthias Kaehlcke
Hi, inline one more thing I forgot to comment on in my previous mail On Thu, Jul 09, 2020 at 09:30:11PM +0530, Sandeep Maheswaram wrote: > Add interconnect support in dwc3-qcom driver to vote for bus > bandwidth. > > This requires for two different paths - from USB master to > DDR slave. The oth

[PATCH v2] KVM: nVMX: fixes for preemption timer migration

2020-07-09 Thread Paolo Bonzini
Commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer migration", 2020-06-01) accidentally broke nVMX live migration from older version by changing the userspace ABI. Restore it and, while at it, ensure that vmx->nested.has_preemption_timer_deadline is always initialized according to the KVM_S

Re: [PATCH] KVM: nVMX: fixes for preemption timer migration

2020-07-09 Thread Bandan Das
Jim Mattson writes: > On Thu, Jul 9, 2020 at 10:15 AM Paolo Bonzini wrote: >> >> Commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer migration", >> 2020-06-01) accidentally broke nVMX live migration from older version >> by changing the userspace ABI. Restore it and, while at it, ensure >

Re: [PATCH v1 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64

2020-07-09 Thread Catalin Marinas
On Thu, Jul 09, 2020 at 05:10:54PM +0800, Zhenyu Ye wrote: > Add __TLBI_VADDR_RANGE macro and rewrite __flush_tlb_range(). > > Signed-off-by: Zhenyu Ye > --- > arch/arm64/include/asm/tlbflush.h | 156 -- > 1 file changed, 126 insertions(+), 30 deletions(-) > > diff -

[PATCH 00/11] perf intel-pt: Add support for decoding FUP/TIP only

2020-07-09 Thread Adrian Hunter
Hi Here are some fixes and small improvements for Intel PT. Adrian Hunter (11): perf intel-pt: Fix FUP packet state perf intel-pt: Fix duplicate branch after CBR perf tools: Improve aux_output not supported error perf auxtrace: Add optional error flags to the itrace 'e' o

[PATCH 11/11] perf intel-pt: Add support for decoding PSB+ only

2020-07-09 Thread Adrian Hunter
A single q option decodes ip from only FUP/TIP packets. Make it so that repeating the q option (i.e. qq) decodes only PSB+, getting ip if there is a FUP packet within PSB+ (i.e. between PSB and PSBEND). Example: $ perf record -e intel_pt//u grep -rI pudding drivers [ perf record: Woken up 52 ti

[PATCH 05/11] perf intel-pt: Use itrace error flags to suppress some errors

2020-07-09 Thread Adrian Hunter
The itrace "e" option may be followed by a number which has the following effect for Intel PT: 1 Suppress overflow events 2 Suppress trace data lost events The values may be combined by bitwise OR'ing them. Suppressing those errors can be useful for testing and debuggin

[PATCH 02/11] perf intel-pt: Fix duplicate branch after CBR

2020-07-09 Thread Adrian Hunter
CBR events can result in a duplicate branch event, because the state type defaults to a branch. Fix by clearing the state type. Example: trace 'sleep' and hope for a frequency change Before: $ perf record -e intel_pt//u sleep 0.1 [ perf record: Woken up 1 times to write data ] [ perf r

[PATCH 04/11] perf auxtrace: Add optional error flags to the itrace 'e' option

2020-07-09 Thread Adrian Hunter
Allow the 'e' option to be followed by an architecture-specific number which flags what kind of errors will or will not be reported. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt | 3 +++ tools/perf/util/auxtrace.c | 2 ++ tools/perf/util/auxtrace.h | 2 +

[PATCH 06/11] perf auxtrace: Add optional log flags to the itrace 'd' option

2020-07-09 Thread Adrian Hunter
Allow the 'd' option to be followed by an architecture-specific number which flags what kind of debug messages will or will not be logged. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt | 3 +++ tools/perf/util/auxtrace.c | 2 ++ tools/perf/util/auxtrace.h

[PATCH 10/11] perf intel-pt: Add support for decoding FUP/TIP only

2020-07-09 Thread Adrian Hunter
Use the new itrace 'q' option to add support for a mode of decoding that ignores TNT, does not walk object code, but gets the ip from FUP and TIP packets. Example: $ perf record -e intel_pt//u grep -rI pudding drivers [ perf record: Woken up 52 times to write data ] [ perf record: Captured and

[PATCH 01/11] perf intel-pt: Fix FUP packet state

2020-07-09 Thread Adrian Hunter
While walking code towards a FUP ip, the packet state is INTEL_PT_STATE_FUP or INTEL_PT_STATE_FUP_NO_TIP. That was mishandled resulting in the state becoming INTEL_PT_STATE_IN_SYNC prematurely. The result was an occasional lost EXSTOP event. Signed-off-by: Adrian Hunter Cc: sta...@vger.kernel.org

[PATCH 03/11] perf tools: Improve aux_output not supported error

2020-07-09 Thread Adrian Hunter
For example: Before: $ perf record -e '{intel_pt/branch=0/,branch-loads/aux-output/ppp}' -- ls -l Error: branch-loads: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat' After: $ perf record -e '{intel_pt/branch=0/,branch-loads/aux-output/ppp}' -- ls -l Err

[PATCH 08/11] perf intel-pt: Time filter logged perf events

2020-07-09 Thread Adrian Hunter
Change the debug logging (when used with the --time option) to time filter logged perf events, but allow that to be overridden by using "d2" instead of plain "d". By default that can greatly reduce the size of the log file. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt

[PATCH 07/11] perf intel-pt: Use itrace debug log flags to suppress some messages

2020-07-09 Thread Adrian Hunter
The "d" option may be followed by a number which has the following effect: 1 Suppress logging of perf events Suppressing perf events is useful for decreasing the size of the log. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/perf-intel-pt.txt | 4 +++- tools/perf/util

[PATCH 09/11] perf auxtrace: Add itrace 'q' option for quicker, less detailed decoding

2020-07-09 Thread Adrian Hunter
The 'q' option is for modes of decoding that are quicker because they skip or omit decoding some aspects of trace data. If supported, the 'q' option may be repeated to increase the effect. Signed-off-by: Adrian Hunter --- tools/perf/Documentation/itrace.txt | 3 +++ tools/perf/util/auxtrace.c

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-09 Thread Michael S. Tsirkin
On Thu, Jul 09, 2020 at 06:46:13PM +0200, Eugenio Perez Martin wrote: > On Wed, Jul 1, 2020 at 4:10 PM Jason Wang wrote: > > > > > > On 2020/7/1 下午9:04, Eugenio Perez Martin wrote: > > > On Wed, Jul 1, 2020 at 2:40 PM Jason Wang wrote: > > >> > > >> On 2020/7/1 下午6:43, Eugenio Perez Martin wrote:

Re: [PATCH v8 2/2] arm64: dts: qcom: sc7180: Add maximum speed property for DWC3 USB node

2020-07-09 Thread Matthias Kaehlcke
On Thu, Jul 09, 2020 at 09:30:12PM +0530, Sandeep Maheswaram wrote: > Adding maximum speed property for DWC3 USB node which can be used > for setting interconnect bandwidth. > > Signed-off-by: Sandeep Maheswaram > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH V4] mm/vmstat: Add events for THP migration without split

2020-07-09 Thread Zi Yan
On 9 Jul 2020, at 12:39, Randy Dunlap wrote: > On 7/9/20 9:34 AM, Zi Yan wrote: >> On 9 Jul 2020, at 11:34, Randy Dunlap wrote: >> >>> Hi, >>> >>> I have a few comments on this. >>> >>> a. I reported it very early and should have been Cc-ed. >>> >>> b. A patch that applies to mmotm or linux-next w

[PATCH 05/24] scsi: aacraid: dpcsup: Demote partially documented function header

2020-07-09 Thread Lee Jones
This should be populated by someone who knows the meaning of all the params. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/dpcsup.c:272: warning: Function parameter or member 'isAif' not described in 'aac_intr_normal' drivers/scsi/aacraid/dpcsup.c:272: warning: Function

[PATCH 06/24] scsi: aic94xx: aic94xx_seq: Document 'lseq' and repair asd_update_port_links() header

2020-07-09 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_seq.c:587: warning: Function parameter or member 'lseq' not described in 'asd_init_lseq_mip' drivers/scsi/aic94xx/aic94xx_seq.c:674: warning: Function parameter or member 'lseq' not described in 'asd_init_lseq_mdp'

[PATCH 01/24] scsi: aacraid: aachba: Repair two kerneldoc headers

2020-07-09 Thread Lee Jones
The function headers for aac_get_config_status() and aac_get_containers() have suffered bitrot where the documentation hasn't kept up with the API. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'dev' not described in 'a

[PATCH 04/24] scsi: aacraid: dpcsup: Remove unused variable 'status'

2020-07-09 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/dpcsup.c: In function ‘aac_aif_callback’: drivers/scsi/aacraid/dpcsup.c:232:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 232 | int status; | ^~ Cc: Adaptec OEM Raid Solutions Cc: "PMC-Sie

[PATCH 02/24] scsi: aacraid: commctrl: Fix a few kerneldoc issues

2020-07-09 Thread Lee Jones
Functions must follow imediately after the header documenting them and all parameters must be present. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/commctrl.c:43: warning: Excess function parameter 'dev' description in 'AAC_DEBUG_PREAMBLE' drivers/scsi/aacraid/commctrl

[PATCH 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header

2020-07-09 Thread Lee Jones
This is the only use of kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member 'vscsi' not described in 'virtscsi_complete_cmd' drivers/scsi/virtio_scsi.c:109: warning:

[PATCH 22/24] scsi: aic7xxx: aic79xx_osm: Remove unused variables 'wait' and 'paused'

2020-07-09 Thread Lee Jones
It looks like they have never actually been used. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_dev_reset’: drivers/scsi/aic7xxx/aic79xx_osm.c:782:9: warning: variable ‘wait’ set but not used [-Wunused-but-set-variable] drivers/scs

[PATCH 13/24] scsi: ipr: Remove a bunch of set but checked variables

2020-07-09 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/scsi/ipr.c:73: drivers/scsi/ipr.c: In function ‘ipr_mask_and_clear_interrupts’: drivers/scsi/ipr.c:740:15: warning: variable ‘int_reg’ set but not used [-Wunused-but-set-variable] drivers/scsi/ipr.c: In function ‘i

[PATCH 15/24] scsi: myrs: Demote obvious misuse of kerneldoc to standard comment blocks

2020-07-09 Thread Lee Jones
No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/myrs.c:94: warning: Function parameter or member 'cmd_blk' not described in 'myrs_reset_cmd' drivers/scsi/myrs.c:105: warning: Function parameter or member 'cs'

[PATCH 17/24] scsi: be2iscsi: be_iscsi: Fix API/documentation slip

2020-07-09 Thread Lee Jones
And add descriptions for a couple of missing function parameters. Fixes the following W=1 kernel build warning(s): drivers/scsi/be2iscsi/be_iscsi.c:38: warning: Function parameter or member 'ep' not described in 'beiscsi_session_create' drivers/scsi/be2iscsi/be_iscsi.c:173: warning: Function p

[PATCH 20/24] scsi: lpfc: lpfc_nvme: Correct some pretty obvious misdocumentation

2020-07-09 Thread Lee Jones
Either due to API slippage before the driver was mainlined or copy/paste errors. Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_nvme.c:254: warning: Function parameter or member 'pnvme_lport' not described in 'lpfc_nvme_create_queue' drivers/scsi/lpfc/lpfc_nvme.c:254:

[PATCH 14/24] scsi: ipr: Fix struct packed-not-aligned issues

2020-07-09 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/scsi/ipr.h:1687:1: warning: alignment 1 of ‘struct ipr_dump_location_entry’ is less than 4 [-Wpacked-not-aligned] 1687 | }__attribute__((packed)); | ^ drivers/scsi/ipr.h:1711:1: warning: alignment 1 of ‘struct ipr_driver_dump’ is less

[PATCH 18/24] scsi: be2iscsi: be_main: Fix misdocumentation of 'pcontext'

2020-07-09 Thread Lee Jones
Also demote unintentional kerneldoc header. Fixes the following W=1 kernel build warning(s): drivers/scsi/be2iscsi/be_main.c:986: warning: Function parameter or member 'pcontext' not described in 'alloc_wrb_handle' drivers/scsi/be2iscsi/be_main.c:986: warning: Excess function parameter 'pwrb_

[PATCH 11/24] scsi: ipr: Fix a mountain of kerneldoc misdemeanours

2020-07-09 Thread Lee Jones
Mainly misspellings and/or missing function parameter descriptions. Fixes the following W=1 kernel build warning(s): drivers/scsi/ipr.c:10100:15: warning: variable ‘int_reg’ set but not used [-Wunused-but-set-variable] drivers/scsi/ipr.c:679: warning: Function parameter or member 'fast_done' n

[PATCH 24/24] scsi: aic7xxx: aic79xx_osm: Remove set but unused variabes 'saved_scsiid' and 'saved_modes'

2020-07-09 Thread Lee Jones
Haven't been used since 2006. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_queue_abort_cmd’: drivers/scsi/aic7xxx/aic79xx_osm.c:2155:17: warning: variable ‘saved_modes’ set but not used [-Wunused-but-set-variable] drivers/scsi/aic

[PATCH 16/24] scsi: megaraid: Fix a whole bunch of function header formatting issues

2020-07-09 Thread Lee Jones
Plus a couple of API catch-ups. Fixes the following W=1 kernel build warning(s): drivers/scsi/megaraid.c:133: warning: Function parameter or member 'adapter' not described in 'mega_setup_mailbox' drivers/scsi/megaraid.c:356: warning: Function parameter or member 'adapter' not described in 'me

[PATCH 19/24] scsi: be2iscsi: be_mgmt: Add missing function parameter description

2020-07-09 Thread Lee Jones
Also promote fully documented function header to kerneldoc. Fixes the following W=1 kernel build warning(s): drivers/scsi/be2iscsi/be_mgmt.c:112: warning: Function parameter or member 'phba' not described in 'mgmt_open_connection' Cc: Subbu Seetharaman Cc: Ketan Mukadam Cc: Jitendra Bhivare

[PATCH 23/24] scsi: aic7xxx: aic79xx_osm: Fix 'amount_xferred' set but not used issue

2020-07-09 Thread Lee Jones
'amount_xferred' is used, but only in certain circumstances. Place the same stipulations on the defining/allocating of 'amount_xferred' as is placed when using it. We've been careful not to change any of the ordering semantics here. Fixes the following W=1 kernel build warning(s): drivers/scsi

[PATCH 21/24] scsi: aic7xxx: aic79xx_osm: Remove unused variable 'ahd'

2020-07-09 Thread Lee Jones
Hasn't been used since 2005. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_slave_configure’: drivers/scsi/aic7xxx/aic79xx_osm.c:703:20: warning: variable ‘ahd’ set but not used [-Wunused-but-set-variable] Cc: Hannes Reinecke Signe

Re: [PATCH v3 2/9] KVM: nSVM: stop dereferencing vcpu->arch.mmu to get the context in kvm_init_shadow{,_npt}_mmu()

2020-07-09 Thread Paolo Bonzini
On 09/07/20 16:53, Vitaly Kuznetsov wrote: > Now as kvm_init_shadow_npt_mmu() is separated from kvm_init_shadow_mmu() > we always know the MMU context we need to use so there is no need to > dereference vcpu->arch.mmu pointer. > > Suggested-by: Paolo Bonzini > Signed-off-by: Vitaly Kuznetsov > -

Re: [PATCH v19 08/12] landlock: Add syscall implementation

2020-07-09 Thread Christian Brauner
On Thu, Jul 09, 2020 at 07:26:18PM +0200, Arnd Bergmann wrote: > On Wed, Jul 8, 2020 at 7:50 PM Mickaël Salaün wrote: > > On 08/07/2020 15:49, Arnd Bergmann wrote: > > > On Wed, Jul 8, 2020 at 3:04 PM Mickaël Salaün wrote: > > >> On 08/07/2020 10:57, Arnd Bergmann wrote: > > >>> On Tue, Jul 7, 20

[PATCH] EDAC-TI: Replace HTTP links with HTTPS ones

2020-07-09 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH 03/24] scsi: aacraid: dpcsup: Fix logical bug when !DBG

2020-07-09 Thread Lee Jones
When DBG is not enabled FIB_COUNTER_INCREMENT() results in an empty statement, leaving the contents of if() and else() empty. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/dpcsup.c: In function ‘aac_response_normal’: drivers/scsi/aacraid/dpcsup.c:105:50: warning: suggest

[PATCH 07/24] scsi: aacraid: commsup: Fix a bunch of function header issues

2020-07-09 Thread Lee Jones
Some parameters not documented. Others misspelled. Also, functions must follow directly after the header that documents them. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/commsup.c:223: warning: Function parameter or member 'scmd' not described in 'aac_fib_alloc_tag'

[PATCH 08/24] scsi: aic94xx: aic94xx_scb: Fix a couple of formatting and bitrot issues

2020-07-09 Thread Lee Jones
Kerneldoc format should be '@.*: ', else the checker gets confused. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_scb.c:137: warning: Function parameter or member 'phy' not described in 'asd_get_attached_sas_addr' drivers/scsi/aic94xx/aic94xx_scb.c:137: warning:

[PATCH 10/24] scsi: pm8001: pm8001_ctl: Provide descriptions for the many undocumented 'attr's

2020-07-09 Thread Lee Jones
... even if they are completely unused. Fixes the following W=1 kernel build warning(s): drivers/scsi/pm8001/pm8001_ctl.c:56: warning: Function parameter or member 'attr' not described in 'pm8001_ctl_mpi_interface_rev_show' drivers/scsi/pm8001/pm8001_ctl.c:81: warning: Function parameter or me

[PATCH 00/24] Set 3: Fix another set of SCSI related W=1 warnings

2020-07-09 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Slowly working through the SCSI related ones. There are many. This brings the total of W=1 SCSI wanings from 1690 in v5.8-rc1 to 1109. Lee Jones

[PATCH 09/24] scsi: aacraid: rx: Fill in the very parameter descriptions for rx_sync_cmd()

2020-07-09 Thread Lee Jones
... and document aac_rx_ioremap() 'dev' param. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/rx.c:156: warning: Function parameter or member 'p2' not described in 'rx_sync_cmd' drivers/scsi/aacraid/rx.c:156: warning: Function parameter or member 'p3' not described in '

Re: [PATCH v3 3/9] KVM: nSVM: reset nested_run_pending upon nested_svm_vmrun_msrpm() failure

2020-07-09 Thread Paolo Bonzini
On 09/07/20 16:53, Vitaly Kuznetsov wrote: > WARN_ON_ONCE(svm->nested.nested_run_pending) in nested_svm_vmexit() > will fire if nested_run_pending remains '1' but it doesn't really > need to, we are already failing and not going to run nested guest. > > Signed-off-by: Vitaly Kuznetsov > --- > ar

Re: [PATCH 05/11] perf intel-pt: Use itrace error flags to suppress some errors

2020-07-09 Thread Andi Kleen
On Thu, Jul 09, 2020 at 08:36:22PM +0300, Adrian Hunter wrote: > The itrace "e" option may be followed by a number which has the > following effect for Intel PT: > 1 Suppress overflow events > 2 Suppress trace data lost events > The values may be combined by bitwise OR'ing t

Re: [PATCH v3 6/9] KVM: nSVM: move kvm_set_cr3() after nested_svm_uninit_mmu_context()

2020-07-09 Thread Paolo Bonzini
On 09/07/20 16:53, Vitaly Kuznetsov wrote: > Note, the change is effectively a nop: when !npt_enabled, > nested_svm_uninit_mmu_context() does nothing (as we don't do > nested_svm_init_mmu_context()) and with npt_enabled we don't > do kvm_set_cr3() but we're about to switch to nested_svm_load_cr3().

Re: [PATCH 06/11] perf auxtrace: Add optional log flags to the itrace 'd' option

2020-07-09 Thread Andi Kleen
> flags what kind of errors will or will not be reported. > + > + If supported, The 'd' option may be followed by an architecture-specific > + number which flags what kind of debug messages will or will not be > logged. Would need documentation here. Also in the include used by the

Re: [PATCH 09/11] perf auxtrace: Add itrace 'q' option for quicker, less detailed decoding

2020-07-09 Thread Andi Kleen
> + > + If supported, the 'q' option may be repeated to increase the effect. Need better documentation here. What does it mean for PT?

Re: [PATCH 10/11] perf intel-pt: Add support for decoding FUP/TIP only

2020-07-09 Thread Andi Kleen
On Thu, Jul 09, 2020 at 08:36:27PM +0300, Adrian Hunter wrote: > +The q option does not decode TNT packets, and does not walk object code, but > +gets the ip from FUP and TIP packets. The q option can be used with the b > and i > +options but the period is not used. The q option decodes more qui

Re: [PATCH v2] Makefile: Add clang-tidy and static analyzer support to makefile

2020-07-09 Thread Nathan Huckleberry
On Wed, Jul 8, 2020 at 2:11 PM Nick Desaulniers wrote: > > On Wed, Jul 8, 2020 at 11:21 AM 'Nathan Huckleberry' via Clang Built > Linux wrote: > > > > This patch adds clang-tidy and the clang static-analyzer as make > > targets. The goal of this patch is to make static analysis tools > > usable a

Re: [PATCH v3 7/9] KVM: nSVM: implement nested_svm_load_cr3() and use it for host->guest switch

2020-07-09 Thread Paolo Bonzini
On 09/07/20 16:53, Vitaly Kuznetsov wrote: > + if (nested_npt_enabled(svm)) > + nested_svm_init_mmu_context(&svm->vcpu); > + > ret = nested_svm_load_cr3(&svm->vcpu, nested_vmcb->save.cr3, > nested_npt_enabled(svm)); This needs to be done in svm

Re: [PATCH v3 06/14] vfio/type1: Add VFIO_IOMMU_PASID_REQUEST (alloc/free)

2020-07-09 Thread Jacob Pan
On Thu, 9 Jul 2020 08:27:51 -0600 Alex Williamson wrote: > > So I'm wondering can we fall back to prior proposal which only free > > one PASID for a free request. how about your opinion? > > Doesn't it still seem like it would be a useful user interface to have > a mechanism to free all pasids

Re: [PATCH v3 7/9] KVM: nSVM: implement nested_svm_load_cr3() and use it for host->guest switch

2020-07-09 Thread Paolo Bonzini
On 09/07/20 19:57, Paolo Bonzini wrote: > On 09/07/20 16:53, Vitaly Kuznetsov wrote: >> +if (nested_npt_enabled(svm)) >> +nested_svm_init_mmu_context(&svm->vcpu); >> + >> ret = nested_svm_load_cr3(&svm->vcpu, nested_vmcb->save.cr3, >>nested_npt_e

Re: [PATCH 11/11] perf intel-pt: Add support for decoding PSB+ only

2020-07-09 Thread Andi Kleen
> diff --git a/tools/perf/Documentation/perf-intel-pt.txt > b/tools/perf/Documentation/perf-intel-pt.txt > index 758295a7e3d6..849474629fe7 100644 > --- a/tools/perf/Documentation/perf-intel-pt.txt > +++ b/tools/perf/Documentation/perf-intel-pt.txt > @@ -973,6 +973,9 @@ useful only if the control

[RFC v2 2/4] selftests: futex: Add futex2 wake/wait test

2020-07-09 Thread André Almeida
Add a simple test to test wake/wait mechanism using futex2 interface. Create helper files so more tests can evaluate futex2. While 32bit ABIs from glibc aren't able to use 64 bit sized time variables, add a temporary workaround that implements the required types and calls the appropriated syscalls,

[RFC v2 0/4] futex2: Add new futex interface

2020-07-09 Thread André Almeida
Hello, This RFC is a followup to the previous discussion initiated from my last patch "futex: Implement mechanism to wait on any of several futexes"[1]. As stated in the thread, the correct approach to move forward with the wait multiple operation would be to create a new syscall that would have a

[RFC v2 1/4] futex2: Add new futex interface

2020-07-09 Thread André Almeida
Add a new futex interface into the kernel, namely futex2. This first piece of work just introduces the new interface without new feature for now, using all mechanisms of the old interface in order to work. This way we can properly formalize the expectations around the new design, while being able t

[RFC v2 3/4] selftests: futex: Add futex2 timeout test

2020-07-09 Thread André Almeida
Adapt existing futex wait timeout file to test the same mechanism for futex2. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_timeout.c | 38 ++- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/futex/functional/futex_wai

[RFC v2 4/4] selftests: futex: Add futex2 wouldblock test

2020-07-09 Thread André Almeida
Adapt existing futex wait wouldblock file to test the same mechanism for futex2. Signed-off-by: André Almeida --- .../futex/functional/futex_wait_wouldblock.c | 33 --- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/futex/functional/futex_

Re: [PATCH v3 0/9] KVM: nSVM: fixes for CR3/MMU switch upon nested guest entry/exit

2020-07-09 Thread Paolo Bonzini
On 09/07/20 16:53, Vitaly Kuznetsov wrote: > This is a successor of "[PATCH v2 0/3] KVM: nSVM: fix #TF from CR3 switch > when entering guest" and "[PATCH] KVM: x86: drop erroneous mmu_check_root() > from fast_pgd_switch()". > > The snowball is growing fast! It all started with an intention to fix

Re: [PATCH 12/24] scsi: virtio_scsi: Demote seemingly unintentional kerneldoc header

2020-07-09 Thread Paolo Bonzini
On 09/07/20 19:45, Lee Jones wrote: > This is the only use of kerneldoc in the sourcefile and no > descriptions are provided. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/virtio_scsi.c:109: warning: Function parameter or member > 'vscsi' not described in 'virtscsi_compl

Re: [PATCH v2 2/3] media: rockchip: Introduce driver for Rockhip's camera interface

2020-07-09 Thread Dafna Hirschfeld
hi, On 29.05.20 15:04, Maxime Chevallier wrote: Introduce a driver for the camera interface on some Rockchip platforms. This controller supports CSI2, Parallel and BT656 interfaces, but for now only the parallel interface could be tested, hence it's the only one that's supported in the first v

[PATCH] HYPERBUS SUPPORT: Replace HTTP links with HTTPS ones

2020-07-09 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH 15/17] initramfs: switch initramfs unpacking to struct file based APIs

2020-07-09 Thread Linus Torvalds
On Thu, Jul 9, 2020 at 8:18 AM Christoph Hellwig wrote: > > There is no good reason to mess with file descriptors from in-kernel > code, switch the initramfs unpacking to struct file based write > instead. As we don't have nice helper for chmod or chown on a struct > file or struct path use the p

<    3   4   5   6   7   8   9   10   11   12   >