[REPORT] possible circular locking dependency when booting a VM on arm64 host

2020-07-09 Thread Zenghui Yu
Hi All, I had seen the following lockdep splat when booting a guest on my Kunpeng 920 with GICv4 enabled. I can also trigger the same splat on v5.5 so it should already exist in the kernel for a while. I'm not sure what the exact problem is and hope someone can have a look! Thanks, Zenghui [

Re: [Ksummit-discuss] [Tech-board-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-09 Thread Mauro Carvalho Chehab
Em Tue, 7 Jul 2020 01:58:21 +0200 Tibor Raschko escreveu: > > Allowlist/denylist terms are intuitive and action based which have a > > globally uniform meaning. > > Nobody has a problem understanding "blacklist" and "whitelist". These > are universally understood words even outside of computin

Re: [RESEND PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-07-09 Thread Enric Balletbo i Serra
Hi again, On 8/7/20 17:12, Enric Balletbo i Serra wrote: > Hi Boris, > > Thank you to spend some time to review the patches. > > On 1/7/20 13:41, Boris Brezillon wrote: >> On Mon, 18 May 2020 19:39:09 +0200 >> Enric Balletbo i Serra wrote: >> >>> The mtk_dpi driver uses an empty implementation

[PATCH] kernel/smp: Fix an off by one in csd_lock_wait_toolong()

2020-07-09 Thread Dan Carpenter
The __per_cpu_offset[] array has "nr_cpu_ids" elements so change the > >= to prevent a read one element beyond the end of the array. Fixes: 0504bc41a62c ("kernel/smp: Provide CSD lock timeout diagnostics") Signed-off-by: Dan Carpenter --- kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v5 1/2] virtio: let arch validate VIRTIO features

2020-07-09 Thread Pierre Morel
On 2020-07-09 11:58, Halil Pasic wrote: On Thu, 9 Jul 2020 10:39:18 +0200 Pierre Morel wrote: An architecture may need to validate the VIRTIO devices features based on architecture specifics. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Acked

Re: [PATCH v3 5/6] powerpc/pseries: implement paravirt qspinlocks for SPLPAR

2020-07-09 Thread Michael Ellerman
Nicholas Piggin writes: > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/include/asm/paravirt.h | 28 > arch/powerpc/include/asm/qspinlock.h | 66 +++ > arch/powerpc/include/asm/qspinlock_paravirt.h | 7 ++ > arch/powerpc/platforms/pseries/Kconf

Re: [PATCH v5] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-09 Thread Thomas Gleixner
Abhishek Bhardwaj writes: > This change adds a new kernel configuration that sets the l1d cache > flush setting at compile time rather than at run time. > > The reasons for this change are as follows - > > - Kernel command line arguments are getting unwieldy. These parameters > are not a scalabl

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
On 2020-07-09 10:57, Cornelia Huck wrote: On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_features() i

[PATCH] mm: Close race between munmap() and expand_upwards()/downwards()

2020-07-09 Thread Kirill A. Shutemov
VMA with VM_GROWSDOWN or VM_GROWSUP flag set can change their size under mmap_read_lock(). It can lead to race with __do_munmap(): Thread AThread B __do_munmap() detach_vmas_to_be_unmapped() mmap_write_downgrade() expand_downwards

RE: [REPORT] possible circular locking dependency when booting a VM on arm64 host

2020-07-09 Thread Salil Mehta
Hi Yuzenghui, I will try to reproduce it today at our platform. Just one question is it easily reproducible or is a rare occurrence? Thanks Salil > From: yuzenghui > Sent: Thursday, July 9, 2020 11:41 AM > To: Marc Zyngier ; Thomas Gleixner ; > Linux > Kernel Mailing List ; > linux-arm-ker...@li

[PATCH v2 0/2] Convert mtk-dpi to drm_bridge API

2020-07-09 Thread Enric Balletbo i Serra
The mtk-dpi driver still uses the drm_encoder API which is now somewhat deprecated. We started to move all the Mediatek drivers to the drm_bridge API, like we did for the mtk-dsi driver [1], this is another small step to be able to fully convert the DRM Mediatek drivers to the drm_bridge API. A dum

Re: [PATCH v2] PCI: dwc: convert to devm_platform_ioremap_resource_byname()

2020-07-09 Thread Lorenzo Pieralisi
On Thu, Jul 09, 2020 at 12:40:13AM +0800, Dejin Zheng wrote: > Use devm_platform_ioremap_resource_byname() to simplify codes. > it contains platform_get_resource_byname() and devm_ioremap_resource(). > > Signed-off-by: Dejin Zheng > Reviewed-by: Gustavo Pimentel > Reviewed-by: Rob Herring > ---

[PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-07-09 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu -

[PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-07-09 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- Changes in v2: - Maintain error message when attach to bridge fails. (Boris) drivers/gpu/drm/mediatek/mtk_dp

Re: [PATCH v4 2/5] KVM: x86: Extract kvm_update_cpuid_runtime() from kvm_update_cpuid()

2020-07-09 Thread Paolo Bonzini
On 09/07/20 06:34, Xiaoyao Li wrote: > Beside called in kvm_vcpu_ioctl_set_cpuid*(), kvm_update_cpuid() is also > called 5 places else in x86.c and 1 place else in lapic.c. All those 6 > places only need the part of updating guest CPUIDs (OSXSAVE, OSPKE, APIC, > KVM_FEATURE_PV_UNHALT, ...) based on

Re: [PATCH 2/2] powerpc/powernv/idle: save-restore DAWR0,DAWRX0 for P10

2020-07-09 Thread Gautham R Shenoy
On Fri, Jul 03, 2020 at 06:16:40PM +0530, Pratik Rajesh Sampat wrote: > Additional registers DAWR0, DAWRX0 may be lost on Power 10 for > stop levels < 4. Adding Ravi Bangoria to the cc. > Therefore save the values of these SPRs before entering a "stop" > state and restore their values on wakeup

Re: [PATCH 1/2] powerpc/powernv/idle: Exclude mfspr on HID1,4,5 on P9 and above

2020-07-09 Thread Gautham R Shenoy
On Fri, Jul 03, 2020 at 06:16:39PM +0530, Pratik Rajesh Sampat wrote: > POWER9 onwards the support for the registers HID1, HID4, HID5 has been > receded. > Although mfspr on the above registers worked in Power9, In Power10 > simulator is unrecognized. Moving their assignment under the > check for m

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Petr Mladek
On Thu 2020-07-09 12:20:35, John Ogness wrote: > On 2020-07-09, Sergey Senozhatsky wrote: > > On (20/07/09 15:14), kernel test robot wrote: > > [..] > > > > Took me a while to find the FAIL-ed test: > > > >> kmsg01.c:393: INFO: TEST: read returns EPIPE when messages get overwritten > >> kmsg01.c:3

Re: [PATCH v5 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-09 Thread Pierre Morel
On 2020-07-09 11:55, Halil Pasic wrote: On Thu, 9 Jul 2020 10:57:33 +0200 Cornelia Huck wrote: On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been n

Re: [PATCH] kernel/smp: Fix an off by one in csd_lock_wait_toolong()

2020-07-09 Thread Peter Zijlstra
On Thu, Jul 09, 2020 at 01:48:18PM +0300, Dan Carpenter wrote: > The __per_cpu_offset[] array has "nr_cpu_ids" elements so change the > > >= to prevent a read one element beyond the end of the array. > > Fixes: 0504bc41a62c ("kernel/smp: Provide CSD lock timeout diagnostics") I don't have a copy

Re: [PATCH] arm64: kernel: Add module symbols _text, _etext.

2020-07-09 Thread Christoph Hellwig
On Thu, Jul 09, 2020 at 10:49:51AM +0100, Will Deacon wrote: > On Thu, Jul 09, 2020 at 05:23:45PM +0900, sanggil2@samsung.com wrote: > > From: Sanggil Kim > > > > We have a solution to protect kernel code section(autually from _text to > > _etext) by not MMU. In order to do this, we have to k

Re: [PATCH v3 5/6] powerpc/pseries: implement paravirt qspinlocks for SPLPAR

2020-07-09 Thread Peter Zijlstra
On Thu, Jul 09, 2020 at 08:53:16PM +1000, Michael Ellerman wrote: > Nicholas Piggin writes: > > > Signed-off-by: Nicholas Piggin > > --- > > arch/powerpc/include/asm/paravirt.h | 28 > > arch/powerpc/include/asm/qspinlock.h | 66 +++ > > arch/powerpc/

[PATCH v3 0/4] DVFS support for dpu and dsi

2020-07-09 Thread Rajendra Nayak
Changes in v3 - Added dev_pm_opp_put_clkname() in the error path Changes in v2 - Patch 2: Dropped dsi_link_clk_set_rate_6g_v2 and dsi_link_clk_disable_6g_v2 as suggested by Matthias These patches add DVFS support for DPU and DSI. These patches have no other dependency. Patch 1 and 2 will need t

[PATCH v3 2/4] drm/msm: dsi: Use OPP API to set clk/perf state

2020-07-09 Thread Rajendra Nayak
On SDM845 and SC7180 DSI needs to express a performance state requirement on a power domain depending on the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. dev_pm_opp_set_rate() is designed to be equivalent to clk_set_rate

Re: chrome-platform/for-kernelci bisection: baseline.bootrr.rockchip-dp-probed on rk3399-gru-kevin

2020-07-09 Thread Guillaume Tucker
On 09/07/2020 10:17, Enric Balletbo i Serra wrote: > Hi, > > On 8/7/20 22:32, Guenter Roeck wrote: >> On 7/8/20 11:59 AM, kernelci.org bot wrote: >>> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >>> * This automated bisection report was sent to you on the basis * >>> * that y

[PATCH v3 1/4] drm/msm/dpu: Use OPP API to set clk/perf state

2020-07-09 Thread Rajendra Nayak
On some qualcomm platforms DPU needs to express a performance state requirement on a power domain depending on the clock rates. Use OPP table from DT to register with OPP framework and use dev_pm_opp_set_rate() to set the clk/perf state. Signed-off-by: Rajendra Nayak Reviewed-by: Rob Clark Revie

[PATCH 0/4] Add interconnect sync state support

2020-07-09 Thread Georgi Djakov
Bootloaders often leave some system resources enabled such as clocks, regulators, interconnects etc. We want to keep these resources enabled until all their consumers are probed. These resources are often shared, so we must wait for all the consumers to come up, before deciding whether to turn them

[PATCH v3 4/4] arm64: dts: sc7180: Add DSI and MDP OPP tables and power-domains

2020-07-09 Thread Rajendra Nayak
Add the OPP tables for DSI and MDP based on the perf state/clk requirements, and add the power-domains property to specify the scalable power domain. Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 49

[PATCH v3 3/4] arm64: dts: sdm845: Add DSI and MDP OPP tables and power-domains

2020-07-09 Thread Rajendra Nayak
Add the OPP tables for DSI and MDP based on the perf state/clk requirements, and add the power-domains property to specify the scalable power domain. Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 59

[PATCH 3/4] interconnect: qcom: smd845: Use icc_sync_state

2020-07-09 Thread Georgi Djakov
Lowering the bandwidth on the bus might have negative consequences if it's done before all consumers had a chance to cast their vote. Let's return the maximum amount of bandwidth as initial value. This bandwidth level would be maintained until all consumers have probed. Signed-off-by: Georgi Djako

[PATCH 2/4] interconnect: Add get_bw() callback

2020-07-09 Thread Georgi Djakov
The interconnect controller hardware may support querying the current bandwidth settings, so add a callback for providers to implement this functionality if supported. Signed-off-by: Georgi Djakov --- drivers/interconnect/core.c | 3 ++- include/linux/interconnect-provider.h | 2 ++ 2

[PATCH 4/4] interconnect: qcom: osm-l3: Use icc_sync_state

2020-07-09 Thread Georgi Djakov
Lowering the bandwidth on the bus might have negative consequences if it's done before all consumers had a chance to cast their vote. Let's return the maximum amount of bandwidth as initial value. This bandwidth level would be maintained until all consumers have probed. Signed-off-by: Georgi Djako

[PATCH 1/4] interconnect: Add sync state support

2020-07-09 Thread Georgi Djakov
The bootloaders often do some initial configuration of the interconnects in the system and we want to keep this configuration until all consumers have probed and expressed their bandwidth needs. This is because we don't want to change the configuration by starting to disable unused paths until ever

Re: [PATCH] scsi: fcoe: add missed kfree() in an error path

2020-07-09 Thread Jing Xiangfeng
On 2020/7/9 15:22, Markus Elfring wrote: fcoe_fdmi_info() misses to call kfree() in an error path. Add the missed function call to fix it. I suggest to use an additional jump target for the completion of the desired exception handling. … +++ b/drivers/scsi/fcoe/fcoe.c @@ -830,6 +830,7 @@

Re: [PATCH v4 0/5] Refactor handling flow of KVM_SET_CPUID*

2020-07-09 Thread Paolo Bonzini
On 09/07/20 06:34, Xiaoyao Li wrote: > 4 Patches of v3 has been queued into kvm/queue branch. This v4 contains > the rest to refactor the flow of KVM_SET_CPUID* as: > > 1. cpuid check: check if userspace provides legal CPUID settings; > > 2. cpuid update: Update userspace provided CPUID settings.

Re: [PATCH v4 2/2] Add Intel LGM soc DMA support.

2020-07-09 Thread Andy Shevchenko
On Thu, Jul 09, 2020 at 02:01:06PM +0800, Amireddy Mallikarjuna reddy wrote: > Add DMA controller driver for Lightning Mountain(LGM) family of SoCs. > > The main function of the DMA controller is the transfer of data from/to any > DPlus compliant peripheral to/from the memory. A memory to memory c

Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting

2020-07-09 Thread Rajendra Nayak
On 7/1/2020 4:50 PM, Rajendra Nayak wrote: On 6/1/2020 11:26 AM, Rajendra Nayak wrote: On 5/28/2020 1:06 AM, Rob Herring wrote: On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote: Add an optional power domain which when specified can be used for setting the performance state of

RE: [PATCH v1 0/2] scsi: ufs: Fix and simplify setup_xfer_req vop and request's completion timestamp

2020-07-09 Thread Avri Altman
Looks good to me. Thanks, Avri > > Hi, > This small series fixes and simplifies setup_xfer_req vop and request's > completion timestamp. > > Stanley Chu (2): > scsi: ufs: Simplify completion timestamp for SCSI and query commands > scsi: ufs: Fix and simplify setup_xfer_req variant operatio

Re: [PATCH 0/2] Remove kiocb ki_complete

2020-07-09 Thread Matthew Wilcox
On Thu, Jul 09, 2020 at 11:17:05AM +0100, Christoph Hellwig wrote: > I really don't like this series at all. If saves a single pointer > but introduces a complicated machinery that just doesn't follow any > natural flow. And there doesn't seem to be any good reason for it to > start with. Jens d

Re: [PATCH 2/2] KVM: PPC: Book3S HV: rework secure mem slot dropping

2020-07-09 Thread Michael Ellerman
Laurent Dufour writes: > Le 08/07/2020 à 13:25, Bharata B Rao a écrit : >> On Fri, Jul 03, 2020 at 05:59:14PM +0200, Laurent Dufour wrote: >>> When a secure memslot is dropped, all the pages backed in the secure device >>> (aka really backed by secure memory by the Ultravisor) should be paged out

Re: [PATCH v5 1/4] riscv: Move kernel mapping to vmalloc zone

2020-07-09 Thread Alex Ghiti
Hi Palmer, Le 7/9/20 à 1:05 AM, Palmer Dabbelt a écrit : On Sun, 07 Jun 2020 00:59:46 PDT (-0700), a...@ghiti.fr wrote: This is a preparatory patch for relocatable kernel. The kernel used to be linked at PAGE_OFFSET address and used to be loaded physically at the beginning of the main memory.

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-09 Thread Mauro Carvalho Chehab
Em Mon, 06 Jul 2020 06:30:01 -0700 Joe Perches escreveu: > On Mon, 2020-07-06 at 09:04 -0400, Matthew Wilcox wrote: > > On Mon, Jul 6, 2020 at 8:59 AM Joe Perches wrote: > > > On Mon, 2020-07-06 at 08:51 -0400, Matthew Wilcox wrote: > > > > In terms of number of lines of code using the word,

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Petr Mladek
On Thu 2020-07-09 12:59:06, Petr Mladek wrote: > On Thu 2020-07-09 12:20:35, John Ogness wrote: > > On 2020-07-09, Sergey Senozhatsky wrote: > > > On (20/07/09 15:14), kernel test robot wrote: > > > [..] > > > > > > Took me a while to find the FAIL-ed test: > > > > > >> kmsg01.c:393: INFO: TEST: r

Re: [PATCH v5 17/17] x86/perf, static_call: Optimize x86_pmu methods

2020-07-09 Thread Peter Zijlstra
On Wed, Jun 24, 2020 at 05:30:41PM +0200, Peter Zijlstra wrote: > Replace many of the indirect calls with static_call(). > > XXX run performance numbers So I finally got around to doing that, and the average PMI time, as measured by perf_sample_event_took()*: PRE:3283.03 [ns] POST: 3145.12

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread John Ogness
On 2020-07-09, Petr Mladek wrote: > I though more about it. IMHO, it will be better to modify > prb_first_seq() to do the same cycle as prb_next_seq() > and return seq number of the first valid entry. Exactly! Here is a patch that does just that. I added a prb_first_valid_seq() function and made

Re: [PATCH v2] ALSA: Use fallthrough pseudo-keyword

2020-07-09 Thread Takashi Iwai
On Wed, 08 Jul 2020 22:32:36 +0200, Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html

Re: [PATCH 2/2] doc, mm: clarify /proc//oom_score value range

2020-07-09 Thread Yafang Shao
On Thu, Jul 9, 2020 at 5:58 PM Michal Hocko wrote: > > On Thu 09-07-20 17:01:06, Yafang Shao wrote: > > On Thu, Jul 9, 2020 at 4:18 PM Michal Hocko wrote: > > > > > > On Thu 09-07-20 15:41:11, Yafang Shao wrote: > > > > On Thu, Jul 9, 2020 at 2:26 PM Michal Hocko wrote: > > > > > > > > > > From:

Re: [PATCH 2/2] powerpc/powernv/idle: save-restore DAWR0,DAWRX0 for P10

2020-07-09 Thread Pratik Sampat
On 09/07/20 2:39 pm, Gautham R Shenoy wrote: On Fri, Jul 03, 2020 at 06:16:40PM +0530, Pratik Rajesh Sampat wrote: Additional registers DAWR0, DAWRX0 may be lost on Power 10 for stop levels < 4. Adding Ravi Bangoria to the cc. Therefore save the values of these SPRs before entering a "st

Re: [PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-09 Thread Mark Brown
On Wed, Jul 08, 2020 at 04:39:39PM -0700, Douglas Anderson wrote: > In the patch ("spi: spi-geni-qcom: Avoid clock setting if not needed") > we avoid a whole pile of clock code. As part of that, we should have > restored the clock at runtime resume. Do that. Acked-by: Mark Brown signature.asc

[PATCH] hwmon: corsair-cpro: add fan_target

2020-07-09 Thread Marius Zachmann
This adds fan_target entries to the corsair-cpro driver. Reading the attribute from the device does not seem possible, so it returns the last set value. (same as pwm) Furthermore: - removes unnecessary kernel.h include. - send_usb_cmd now has one more argument which is needed for the fan_target

Re: [PATCH] Replace HTTP links with HTTPS ones: XDP (eXpress Data Path)

2020-07-09 Thread Jesper Dangaard Brouer
On Wed, 8 Jul 2020 20:58:39 +0200 "Alexander A. Klimov" wrote: > Am 08.07.20 um 16:02 schrieb Jonathan Corbet: > > On Wed, 8 Jul 2020 15:57:37 +0200 > > "Alexander A. Klimov" wrote: > > > >> Documentation/arm/ixp4xx.rst | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH v4 08/10] net: eth: altera: add support for ptp and timestamping

2020-07-09 Thread Richard Cochran
On Wed, Jul 08, 2020 at 03:23:59PM +0800, Ooi, Joyce wrote: > @@ -222,6 +223,32 @@ static void tse_get_regs(struct net_device *dev, struct > ethtool_regs *regs, > buf[i] = csrrd32(priv->mac_dev, i * 4); > } > > +static int tse_get_ts_info(struct net_device *dev, > +

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-09 Thread Lorenzo Pieralisi
On Thu, Jul 02, 2020 at 10:30:36AM +0200, Pali Rohár wrote: > When there is no PCIe card connected and advk_pcie_rd_conf() or > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated > root bridge, the aardvark driver throws the following error message: > > advk-pcie d007

Re: [PATCH v3 0/2] synquacer: add TPM support

2020-07-09 Thread Jarkko Sakkinen
On Thu, Jul 09, 2020 at 08:34:27AM +0900, Masahisa Kojima wrote: > Hi Jakko, > > > Overally the code looks great. You've run it through checkpatch.pl? > > Yes, I have run checkpatch.pl and removed errors. OK, cool. /Jarkko

Re: [PATCH v2] kernel: Implement selective syscall userspace redirection

2020-07-09 Thread Matthew Wilcox
On Thu, Jul 09, 2020 at 12:38:40AM -0400, Gabriel Krisman Bertazi wrote: > The proposed interface looks like this: > > prctl(PR_SET_SYSCALL_USER_DISPATCH, , , [selector]) > > Dispatcher is the address of a syscall instruction that is allowed to > by-pass the blockage, such that in fast paths yo

Re: [PATCH] kernel/smp: Fix an off by one in csd_lock_wait_toolong()

2020-07-09 Thread Sebastian Andrzej Siewior
On 2020-07-09 12:59:06 [+0200], Peter Zijlstra wrote: > On Thu, Jul 09, 2020 at 01:48:18PM +0300, Dan Carpenter wrote: > > The __per_cpu_offset[] array has "nr_cpu_ids" elements so change the > > > >= to prevent a read one element beyond the end of the array. > > > > Fixes: 0504bc41a62c ("kernel/s

Re: [REPORT] possible circular locking dependency when booting a VM on arm64 host

2020-07-09 Thread Zenghui Yu
On 2020/7/9 18:54, Salil Mehta wrote: Hi Yuzenghui, I will try to reproduce it today at our platform. Just one question is it easily reproducible or is a rare occurrence? Salil, it's 100% reproducible once you start a guest. You don't even need to assign hostdev to the VM. Thanks, Zenghui

[PATCH bpf] selftests: bpf: fix detach from sockmap tests

2020-07-09 Thread Lorenz Bauer
Fix sockmap tests which rely on old bpf_prog_dispatch behaviour. In the first case, the tests check that detaching without giving a program succeeds. Since these are not the desired semantics, invert the condition. In the second case, the clean up code doesn't supply the necessary program fds. Rep

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-07-09 Thread Rafael J. Wysocki
On Thu, Jul 9, 2020 at 11:31 AM Enric Balletbo i Serra wrote: > > Hi Rafael, > > On 11/6/20 13:06, Enric Balletbo i Serra wrote: > > Hi, > > > > On 11/6/20 0:43, Dmitry Torokhov wrote: > >> On Wed, Jun 10, 2020 at 09:52:12PM +, mario.limoncie...@dell.com wrote: > -Original Message

[PATCH 0/2] Venus - fix firmware load failure

2020-07-09 Thread Stanimir Varbanov
Hi, These two patches fixed the problem with "failed to reset venus core" seen with various firmware versions (including the one from linux-firmware) on sdm845 and sdm850. regards, Stan Stanimir Varbanov (2): firmware: qcom_scm: Add memory protect virtual address ranges venus: firmware: Set

[PATCH 1/2] firmware: qcom_scm: Add memory protect virtual address ranges

2020-07-09 Thread Stanimir Varbanov
This adds a new SCM memprotect command to set virtual address ranges. Signed-off-by: Stanimir Varbanov --- drivers/firmware/qcom_scm.c | 24 drivers/firmware/qcom_scm.h | 1 + include/linux/qcom_scm.h| 8 +++- 3 files changed, 32 insertions(+), 1 deletion(-) d

[PATCH 2/2] venus: firmware: Set virtual address ranges

2020-07-09 Thread Stanimir Varbanov
In order to boot some of the new Venus firmware versions TZ call to set virtual address ranges is needed. Add virtual address ranges for CP and CP_NONPIX in resource structure and use them when loading and booting the firmware on remote processor. Signed-off-by: Stanimir Varbanov --- drivers/med

Re: [PATCH v3 0/2] synquacer: add TPM support

2020-07-09 Thread Jarkko Sakkinen
On Thu, Jul 09, 2020 at 08:46:35AM +0900, Masahisa Kojima wrote: > Hi Jarkko, > > > Hi Jakko, > I apologize for mis-spelling of your name. > Same mistake also appears in my another reply to "[PATCH v3 1/2] tpm: > tis: add support for MMIO TPM on SynQuacer" No worries :-) /Jarkko

RE: [REPORT] possible circular locking dependency when booting a VM on arm64 host

2020-07-09 Thread Salil Mehta
> From: yuzenghui > Sent: Thursday, July 9, 2020 12:50 PM > To: Salil Mehta > Cc: Marc Zyngier ; Thomas Gleixner ; > Linux > Kernel Mailing List ; > linux-arm-ker...@lists.infradead.org; Zhuangyuzeng (Yisen) > ; Wanghaibin (D) > Subject: Re: [REPORT] possible circular locking dependency when boo

Re: [PATCH] irqdomain/treewide: Keep firmware node unconditionally allocated

2020-07-09 Thread Marc Zyngier
Hi Thomas, Catching up on email... On 2020-07-09 10:53, Thomas Gleixner wrote: Quite some non OF/ACPI users of irqdomains allocate firmware nodes of type IRQCHIP_FWNODE_NAMED or IRQCHIP_FWNODE_NAMED_ID and free them right after creating the irqdomain. The only purpose of these FW nodes is to

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-07-09 Thread Rafael J. Wysocki
On Wed, Jun 10, 2020 at 11:21 PM Enric Balletbo i Serra wrote: > > Hi Rafael, > > Many thanks for your feedback. See my answers inline. > > On 5/6/20 13:17, Rafael J. Wysocki wrote: > > On Tuesday, April 14, 2020 4:35:38 PM CEST Enric Balletbo i Serra wrote: > >> Hi Rafael, > >> > >> On 13/4/20 22

[PATCH v2] scsi: fcoe: add missed kfree() in an error path

2020-07-09 Thread Jing Xiangfeng
fcoe_fdmi_info() misses to call kfree() in an error path. Add a label 'free_fdmi' and jump to it. Fixes: f07d46bbc9ba ("fcoe: Fix smatch warning in fcoe_fdmi_info function") Signed-off-by: Jing Xiangfeng --- drivers/scsi/fcoe/fcoe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -

Re: [PATCH] clk: rockchip: mark pclk_uart2 as critical on rk3328

2020-07-09 Thread Johan Jonker
Hi Elaine, Robin, Thank you for your help! This patch can go in the garbage bin. It turns out that with SERIAL_8250 also SERIAL_8250_DW must be selected... ;) It's not in the Kconfig help description. Shouldn't that be automatically be included for Rockchip? Example: config SERIAL_8250 t

[PATCH] media: atmel: atmel-isc: rework component offsets

2020-07-09 Thread Eugen Hristev
The component offsets were computed in a negative way: they were subtracted from the actual color component value. So, a higher offset was reducing the component value. This is not really desirable, as the offset is a 2's complements number with 1 bit for sign and 12 value bits, so we would like to

[PATCH resend v2 0/8] virt: vbox: Add support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl

2020-07-09 Thread Hans de Goede
Hi Greg, As requested by Arnd, here is a resend of v2 of my vboxguest driver patch-set, adding support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl, with Arnd's Acked-by added. Can you pick this up and merge it into the next branch of your char/misc tree? Regards, Hans

[PATCH resend v2 2/8] virt: vbox: Fix guest capabilities mask check

2020-07-09 Thread Hans de Goede
Check the passed in capabilities against VMMDEV_GUEST_CAPABILITIES_MASK instead of against VMMDEV_EVENT_VALID_EVENT_MASK. This tightens the allowed mask from 0x7ff to 0x7. Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration") Cc: sta...@vger.kernel.org Acked-by: Arn

[PATCH resend v2 1/8] virt: vbox: Fix VBGL_IOCTL_VMMDEV_REQUEST_BIG and _LOG req numbers to match upstream

2020-07-09 Thread Hans de Goede
Until this commit the mainline kernel version (this version) of the vboxguest module contained a bug where it defined VBGL_IOCTL_VMMDEV_REQUEST_BIG and VBGL_IOCTL_LOG using _IOC(_IOC_READ | _IOC_WRITE, 'V', ...) instead of _IO(V, ...) as the out of tree VirtualBox upstream version does. Since the

[PATCH resend v2 5/8] virt: vbox: Add support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl

2020-07-09 Thread Hans de Goede
Add support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl, this is necessary for automatic resizing of the guest resolution to match the VM-window size to work with the new VMSVGA virtual GPU which is now the new default in VirtualBox. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=

[PATCH resend v2 7/8] virt: vbox: Log unknown ioctl requests as error

2020-07-09 Thread Hans de Goede
Every now and then upstream adds new ioctls without notifying us, log unknown ioctl requests as an error to catch these. Acked-by: Arnd Bergmann Signed-off-by: Hans de Goede --- Changes in v2: - Rate-limit the error logging to avoid userspace potentially DOS-ing the log --- drivers/virt/vboxgue

[PATCH resend v2 8/8] virt: vbox: Fix some comments which talk about the "session spinlock"

2020-07-09 Thread Hans de Goede
The session lock is a mutex, not a spinlock, fix the comments to match. Acked-by: Arnd Bergmann Signed-off-by: Hans de Goede --- drivers/virt/vboxguest/vboxguest_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/vir

[PATCH resend v2 3/8] virt: vbox: Rename guest_caps struct members to set_guest_caps

2020-07-09 Thread Hans de Goede
Rename guest_caps[_tracker] struct members to set_guest_caps[_tracker] this is a preparation patch for adding support for the VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl. Acked-by: Arnd Bergmann Signed-off-by: Hans de Goede --- drivers/virt/vboxguest/vboxguest_core.c | 20 ++-- drivers/

[PATCH resend v2 6/8] virt: vbox: Add a few new vmmdev request types to the userspace whitelist

2020-07-09 Thread Hans de Goede
Upstream VirtualBox has defined and is using a few new request types for vmmdev requests passed through /dev/vboxguest to the hypervisor. Add the defines for these to vbox_vmmdev_types.h and add add them to the whitelists of vmmdev requests which userspace is allowed to make. BugLink: https://bug

[PATCH resend v2 4/8] virt: vbox: Add vbg_set_host_capabilities() helper function

2020-07-09 Thread Hans de Goede
Add vbg_set_host_capabilities() helper function, this is a preparation patch for adding support for the VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl. Acked-by: Arnd Bergmann Signed-off-by: Hans de Goede --- drivers/virt/vboxguest/vboxguest_core.c | 79 ++--- 1 file changed, 46 inser

[SchedulerTaskPacking] Small background task packing

2020-07-09 Thread Parth Shah
> A) Name: Small background task packing > B) Target behaviour: All fair task wakeup follows a procedure of finding an idle CPU and waking the task on this idle CPU. There are two major wakeup paths: 1. Slow-path: Wake up the task on an idle CPU which is in the shallowest idle states by searchin

Re: [PATCH] ACPI: Use fallthrough pseudo-keyword

2020-07-09 Thread Rafael J. Wysocki
On Tue, Jul 7, 2020 at 10:04 PM Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/html/late

RE: [PATCH v4] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-07-09 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > [mailto:linux-crypto-ow...@vger.kernel.org] On Behalf Of Sebastian Andrzej > Siewior > Sent: Thursday, July 9, 2020 7:17 PM > To: Song Bao Hua (Barry Song) > Cc: a...@linux-foundation.org; herb...@gondor.apana.org.au; > da

Re: [PATCH v3 00/21] KVM: Cleanup and unify kvm_mmu_memory_cache usage

2020-07-09 Thread Paolo Bonzini
On 03/07/20 04:35, Sean Christopherson wrote: > The only interesting delta from v2 is that patch 18 is updated to handle > a conflict with arm64's p4d rework. Resolution was straightforward > (famous last words). > > > This series resurrects Christoffer Dall's series[1] to provide a common > MMU

Re: [PATCH v1 2/2] romfs: address performance regression since v3.10

2020-07-09 Thread Sven Van Asbroeck
Hello Al, You are the closest I could find to a romfs maintainer. get_maintainer.pl doesn't appear to list any. This attempted performance regression fix didn't generate much feedback (to say the least). It's however a real issue for us when supporting a legacy product where we don't have the lux

Re: [PATCH 1/9] timer: Move trigger_dyntick_cpu() to enqueue_timer()

2020-07-09 Thread Anna-Maria Behnsen
Hi Frederic, On Tue, 7 Jul 2020, Frederic Weisbecker wrote: > Consolidate the code by calling trigger_dyntick_cpu() from > enqueue_timer() instead of calling it from all its callers. Looks good, but maybe you could also update the comments in the code (see remarks below)? > Signed-off-by: Frede

Re: [PATCH v2] cpuidle: change enter_s2idle() prototype

2020-07-09 Thread Rafael J. Wysocki
On Mon, Jul 6, 2020 at 5:13 AM Neal Liu wrote: > > Control Flow Integrity(CFI) is a security mechanism that disallows > changes to the original control flow graph of a compiled binary, > making it significantly harder to perform such attacks. > > init_state_node() assign same function callback to

Re: [PATCH v3] PCI: aardvark: Don't touch PCIe registers if no card connected

2020-07-09 Thread Pali Rohár
On Thursday 09 July 2020 12:35:09 Lorenzo Pieralisi wrote: > On Thu, Jul 02, 2020 at 10:30:36AM +0200, Pali Rohár wrote: > > When there is no PCIe card connected and advk_pcie_rd_conf() or > > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated > > root bridge, the aardvark d

[PATCH] HARDWARE RANDOM NUMBER GENERATOR CORE: Replace HTTP links with HTTPS ones

2020-07-09 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH 2/7] mailbox: keembay-scmi-mailbox: Add support for Keem Bay mailbox

2020-07-09 Thread Daniele Alessandrelli
Hi Sudeep, Thanks for your review. On Wed, 2020-07-08 at 21:34 +0100, Sudeep Holla wrote: > On Tue, Jun 16, 2020 at 04:56:08PM +0100, Daniele Alessandrelli > wrote: > > From: Paul Murphy > > > > Keem Bay SoC has a ARM trusted firmware-based secure monitor which > > acts > > as the SCP for the p

Re: [printk] 18a2dc6982: ltp.kmsg01.fail

2020-07-09 Thread Petr Mladek
On Thu 2020-07-09 13:23:07, John Ogness wrote: > On 2020-07-09, Petr Mladek wrote: > > I though more about it. IMHO, it will be better to modify > > prb_first_seq() to do the same cycle as prb_next_seq() > > and return seq number of the first valid entry. > > Exactly! > > Here is a patch that do

Re: [PATCH v2] genpd: Fix up terminology with parent/child

2020-07-09 Thread Rafael J. Wysocki
On Thu, Jul 9, 2020 at 1:32 AM Kees Cook wrote: > > The genpd infrastructure uses the terms master/slave, but such uses have > no external exposures (not even in Documentation/driver-api/pm/*) and are > not mandated by nor associated with any external specifications. Change > the language used thr

Re: [PATCH net-next v2 08/12] bridge: mrp: Implement the MRP Interconnect API

2020-07-09 Thread Nikolay Aleksandrov
On 09/07/2020 13:00, Horatiu Vultur wrote: > Thie patch adds support for MRP Interconnect. Similar with the MRP ring, > if the HW can't generate MRP_InTest frames, then the SW will try to > generate them. And if also the SW fails to generate the frames then an > error is return to userspace. > > T

RE: [PATCH] arm64: mm: free unused memmap for sparse memory model that define VMEMMAP

2020-07-09 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: liwei (CM) > Sent: Wednesday, July 8, 2020 7:52 PM > To: Song Bao Hua (Barry Song) ; > catalin.mari...@arm.com; w...@kernel.org > Cc: fengbaopeng ; nsaenzjulie...@suse.de; > steve.cap...@arm.com; r...@linux.ibm.com; > linux-arm-ker...@lists.infradead.org; linu

[PATCH] powerpc/watchpoint/ptrace: Introduce PPC_DEBUG_FEATURE_DATA_BP_DAWR_ARCH_31

2020-07-09 Thread Ravi Bangoria
PPC_DEBUG_FEATURE_DATA_BP_DAWR_ARCH_31 can be used to determine whether we are running on an ISA 3.1 compliant machine. Which is needed to determine DAR behaviour, 512 byte boundary limit etc. This was requested by Pedro Miraglia Franco de Carvalho for extending watchpoint features in gdb. Note tha

Re: [PATCH v4 1/2] linux/bits.h: fix unsigned less than zero warnings

2020-07-09 Thread Herbert Xu
Rikard Falkeborn wrote: > When calling the GENMASK and GENMASK_ULL macros with zero lower bit and > an unsigned unknown high bit, some gcc versions warn due to the > comparisons of the high and low bit in GENMASK_INPUT_CHECK. > > To silence the warnings, only perform the check if both inputs are

printk of non NULL terminated strings ?

2020-07-09 Thread Joakim Tjernlund
Is there a format (or other function) that lets me print strings without an \0 terminator using an explicit length arg instead? Something like: printk("%s...", str, str_len); /* replace ... */ or some other funktion perhaps ? Jocke

Re: [PATCH] freezer: Add unsafe versions of freezable_schedule_timeout_interruptible for NFS

2020-07-09 Thread Rafael J. Wysocki
On Mon, Jul 6, 2020 at 11:57 AM wrote: > > From: He Zhe > > commit 0688e64bc600 ("NFS: Allow signal interruption of NFS4ERR_DELAYed > operations") > introduces nfs4_delay_interruptible which also needs an _unsafe version to > avoid the following call trace for the same reason explained in > comm

[rcu:dev.2020.07.06a] BUILD SUCCESS 3b69dc4d0fad073eb5554dacdccddf6c21577802

2020-07-09 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.07.06a branch HEAD: 3b69dc4d0fad073eb5554dacdccddf6c21577802 lib: Add backtrace_idle parameter to force backtrace of idle CPUs elapsed time: 730m configs tested: 111 configs skipped: 7 The following

[PATCH v2] bus: fsl-mc: fix invalid free in fsl_mc_device_add

2020-07-09 Thread trix
From: Tom Rix clang static analysis flags this error fsl-mc-bus.c:695:2: warning: Attempt to free released memory [unix.Malloc] kfree(mc_dev); ^ The problem block of code is mc_bus = kzalloc(sizeof(*mc_bus), GFP_KERNEL); if (!mc_bus)

Re: [PATCH] powercap: idle_inject: Fix the comment about play_idle

2020-07-09 Thread Rafael J. Wysocki
On Sun, Jun 21, 2020 at 10:04 AM Frank Lee wrote: > > From: Yangtao Li > > After commit 333cff6c963fbc ("powercap/drivers/idle_inject: Specify > idle state max latency"), we convert to use play_idle_precise() with > max allowed latency to specify the idle state. > > Some function comments still u

Re: [LKP] [x86, sched] 1567c3e346: vm-scalability.median -15.8% regression

2020-07-09 Thread Giovanni Gherdovich
On Tue, 2020-07-07 at 10:58 +0800, Xing Zhengjun wrote: > > On 6/12/2020 4:11 PM, Xing Zhengjun wrote: > > Hi Giovanni, > > > > I test the regression, it still existed in v5.7. Do you have time > > to take a look at this? Thanks. > > > > Ping... > Hello, I haven't sat down to reproduce

<    1   2   3   4   5   6   7   8   9   10   >