[PATCH 19/23] proc: switch over direct seq_read method calls to seq_read_iter

2020-07-07 Thread Christoph Hellwig
Switch over all instances used directly as methods using these sed expressions: sed -i -e 's/\.proc_read\(\s*=\s*\)seq_read/\.proc_read_iter\1seq_read_iter/g' Signed-off-by: Christoph Hellwig --- arch/alpha/kernel/srm_env.c| 2 +- arch/arm/mm/alignment.c

[PATCH 11/23] fs: implement kernel_read using __kernel_read

2020-07-07 Thread Christoph Hellwig
Consolidate the two in-kernel read helpers to make upcoming changes easier. The only difference are the missing call to rw_verify_area in kernel_read, and an access_ok check that doesn't make sense for kernel buffers to start with. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 13 +

[PATCH 04/23] fs: unexport __kernel_write

2020-07-07 Thread Christoph Hellwig
This is a very special interface that skips sb_writes protection, and not used by modules anymore. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/read_write.c b/fs/read_write.c index bbfa9b12b15eb7..2c601d853ff3d8 100644 --- a/fs/read_w

[PATCH 17/23] proc: cleanup the compat vs no compat file ops

2020-07-07 Thread Christoph Hellwig
Instead of providing a special no-compat version provide a special compat version for operations with ->compat_ioctl. Signed-off-by: Christoph Hellwig --- fs/proc/inode.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/proc/inode.c b/fs/proc/inode.c index 016b13

[PATCH 16/23] proc: remove a level of indentation in proc_get_inode

2020-07-07 Thread Christoph Hellwig
Just return early on inode allocation failure. Signed-off-by: Christoph Hellwig --- fs/proc/inode.c | 72 + 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/fs/proc/inode.c b/fs/proc/inode.c index 28d6105e908e4c..016b1302cbabc0 10064

[PATCH 05/23] fs: check FMODE_WRITE in __kernel_write

2020-07-07 Thread Christoph Hellwig
Add a WARN_ON_ONCE if the file isn't actually open for write. This matches the check done in vfs_write, but actually warn warns as a kernel user calling write on a file not opened for writing is a pretty obvious programming error. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 2 ++ 1 f

[PATCH 08/23] fs: don't change the address limit for ->write_iter in __kernel_write

2020-07-07 Thread Christoph Hellwig
If we write to a file that implements ->write_iter there is no need to change the address limit if we send a kvec down. Implement that case, and prefer it over using plain ->write with a changed address limit if available. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 34 ++

[PATCH 07/23] fs: remove __vfs_write

2020-07-07 Thread Christoph Hellwig
Fold it into the two callers. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 46 ++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 5110cd1e6e2771..96e8e354f99b45 100644 --- a/fs/read_writ

[PATCH 01/23] cachefiles: switch to kernel_write

2020-07-07 Thread Christoph Hellwig
__kernel_write doesn't take a sb_writers references, which we need here. Signed-off-by: Christoph Hellwig Reviewed-by: David Howells --- fs/cachefiles/rdwr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c index e7726f5f1241c2..308

[PATCH 03/23] bpfilter: switch to kernel_write

2020-07-07 Thread Christoph Hellwig
While pipes don't really need sb_writers projection, __kernel_write is an interface better kept private, and the additional rw_verify_area does not hurt here. Signed-off-by: Christoph Hellwig --- net/bpfilter/bpfilter_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net

[PATCH 06/23] fs: implement kernel_write using __kernel_write

2020-07-07 Thread Christoph Hellwig
Consolidate the two in-kernel write helpers to make upcoming changes easier. The only difference are the missing call to rw_verify_area in kernel_write, and an access_ok check that doesn't make sense for kernel buffers to start with. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 17 +++

Re: [PATCH v10 1/4] unicode: Add utf8_casefold_hash

2020-07-07 Thread Gabriel Krisman Bertazi
Daniel Rosenberg writes: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. > > The existing d_hash implementations for casefolding allocates memory > within rcu-walk, by avoiding it we can be more efficient and avo

[PATCH 20/23] sysctl: Convert to iter interfaces

2020-07-07 Thread Christoph Hellwig
From: "Matthew Wilcox (Oracle)" Using the read_iter/write_iter interfaces allows for in-kernel users to set sysctls without using set_fs(). Also, the buffer is a string, so give it the real type of 'char *', not void *. Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Christoph Hellwig -

Re: [PATCH 1/3] mm: memcg/slab: remove unused argument by charge_slab_page()

2020-07-07 Thread Shakeel Butt
On Tue, Jul 7, 2020 at 10:36 AM Roman Gushchin wrote: > > charge_slab_page() is not using the gfp argument anymore, > remove it. > > Signed-off-by: Roman Gushchin Reviewed-by: Shakeel Butt

Re: [PATCH 2/3] mm: slab: rename (un)charge_slab_page() to (un)account_slab_page()

2020-07-07 Thread Shakeel Butt
On Tue, Jul 7, 2020 at 10:36 AM Roman Gushchin wrote: > > charge_slab_page() and uncharge_slab_page() are not related anymore > to memcg charging and uncharging. In order to make their names > less confusing, let's rename them to account_slab_page() and > unaccount_slab_page() respectively. > > Si

Re: [PATCH net-next] dropwatch: Support monitoring of dropped frames

2020-07-07 Thread Eric Dumazet
On 7/7/20 10:15 AM, izabela.bakoll...@gmail.com wrote: > From: Izabela Bakollari > > Dropwatch is a utility that monitors dropped frames by having userspace > record them over the dropwatch protocol over a file. This augument > allows live monitoring of dropped frames using tools like tcpdump.

[PATCH 21/23] fs: don't allow kernel reads and writes without iter ops

2020-07-07 Thread Christoph Hellwig
Don't allow calling ->read or ->write with set_fs as a preparation for killing off set_fs. While I've not triggered any of these cases in my setups as all the usual suspect (file systems, pipes, sockets, block devices, system character devices) use the iter ops this is almost going to be guarantee

Re: [PATCH 3/3] mm: kmem: switch to static_branch_likely() in memcg_kmem_enabled()

2020-07-07 Thread Shakeel Butt
On Tue, Jul 7, 2020 at 10:36 AM Roman Gushchin wrote: > > Currently memcg_kmem_enabled() is optimized for the kernel memory > accounting being off. It was so for a long time, and arguably the > reason behind was that the kernel memory accounting was initially an > opt-in feature. However, now it's

Re: [PATCH v10 06/17] mtd: spi-nor: sfdp: get command opcode extension type from BFPT

2020-07-07 Thread Tudor.Ambarus
On 6/23/20 9:30 PM, Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Some devices in DTR mode expect an extra command byte called the > extension. The extension can either be same as the opcode, bitwise > inverse of the opcod

[PATCH 22/23] fs: default to generic_file_splice_read for files having ->read_iter

2020-07-07 Thread Christoph Hellwig
If a file implements the ->read_iter method, the iter based splice read works and is always preferred over the ->read based one. Use it by default in do_splice_to and remove all the direct assignment of generic_file_splice_read to file_operations. Signed-off-by: Christoph Hellwig --- fs/adfs/fi

Re: [PATCH 03/11] media: exynos4-is: Fix nullptr when no CSIS device present

2020-07-07 Thread Tomasz Figa
Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:42PM -0700, Jonathan Bakker wrote: > Not all devices use the CSIS device, some may use the FIMC directly in > which case the CSIS device isn't registered. This leads to a nullptr > exception when starting the stream as the CSIS device is always > referen

Re: [PATCH 2/2] ARM: dts: am335x: add support for Moxa UC-8100A-ME open platform

2020-07-07 Thread Tony Lindgren
* Johnson CH Chen (陳昭勳) [200707 03:24]: > UC-8100A-ME is advanced of UC-8100-ME-T, and UC-8100-ME-T is deprecated. > > UC-8100A-ME provides larger RAM and eMMC, better input current than > UC-8100-ME-T's, and it supports selectable LTE module for US/EU/APAC. So what about the existing users of U

Re: [PATCH 3/5] net: fec: initialize clock with 0 rather than current kernel time

2020-07-07 Thread Sergey Organov
Vladimir Oltean writes: > On Tue, Jul 07, 2020 at 08:09:07PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >> > On Tue, Jul 07, 2020 at 07:07:08PM +0300, Sergey Organov wrote: >> >> Vladimir Oltean writes: >> >> > >> >> > What do you mean 'no ticking', and what do you mean by 'non

[PATCH 23/23] fs: don't allow splice read/write without explicit ops

2020-07-07 Thread Christoph Hellwig
Don't allow calling ->read or ->write with set_fs as a preparation for killing off set_fs. While I've not triggered any of these cases in my setups as all the usual suspect (file systems, pipes, sockets, block devices, system character devices) use the iter ops this is almost going to be guarantee

Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL

2020-07-07 Thread Mike Rapoport
On Tue, Jul 07, 2020 at 02:26:08PM +0200, David Hildenbrand wrote: > On 07.07.20 14:13, Mike Rapoport wrote: > > On Tue, Jul 07, 2020 at 01:54:54PM +0200, Michal Hocko wrote: > >> On Tue 07-07-20 13:59:15, Jia He wrote: > >>> This exports memory_add_physaddr_to_nid() for module driver to use. > >>>

[RFC] Kill THP deferred split queue?

2020-07-07 Thread Yang Shi
Hi folks, The THP deferred split queue is used to store PTE mapped THP (i.e. partial unmapped THP) then they will get split by deferred split shrinker when memory pressure kicks in. Now the page reclaim could handle such cases nicely without calling the shrinker. Since the THPs on deferred split

[PATCH][next] Input: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fal

Re: [EXTERNAL] Re: [PATCH v15 2/4] dt-bindings: power: Convert battery.txt to battery.yaml

2020-07-07 Thread Ricardo Rivera-Matos
On 7/7/20 9:40 AM, Rob Herring wrote: On Mon, Jul 6, 2020 at 12:45 PM Ricardo Rivera-Matos wrote: Rob On 7/2/20 3:53 PM, Rob Herring wrote: On Wed, 01 Jul 2020 16:10:42 -0500, Ricardo Rivera-Matos wrote: From: Dan Murphy Convert the battery.txt file to yaml and fix up the examples. Sign

Re: [PATCH 04/11] media: exynos4-is: Correct missing entity function initialization

2020-07-07 Thread Tomasz Figa
Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:43PM -0700, Jonathan Bakker wrote: > Commit bae4500399c4 ("[media] exynos4-is: Add missing entity function > initialization") tried to suppress the warnings such as > > s5p-fimc-md camera: Entity type for entity FIMC.0 was not initialized! > > However,

Re: [PATCH 05/10] Documentation: filesystems: fsverity: drop doubled word

2020-07-07 Thread Eric Biggers
On Fri, Jul 03, 2020 at 02:43:20PM -0700, Randy Dunlap wrote: > Drop the doubled word "the". > > Signed-off-by: Randy Dunlap > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: Eric Biggers > Cc: Theodore Y. Ts'o > Cc: linux-fscr...@vger.kernel.org > --- > Documentation/filesystems/fs

Re: [RFC PATCH v4 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64

2020-07-07 Thread Robin Murphy
On 2020-07-07 18:46, Catalin Marinas wrote: On Tue, Jul 07, 2020 at 06:43:35PM +0100, Marc Zyngier wrote: On 2020-07-07 18:36, Catalin Marinas wrote: On Mon, Jun 01, 2020 at 10:47:13PM +0800, Zhenyu Ye wrote: @@ -59,6 +69,47 @@ __ta; \

Re: linux-next: Tree for Jul 7 (scsi/lpfc/lpfc_init.c)

2020-07-07 Thread James Smart
On 7/7/2020 10:09 AM, Randy Dunlap wrote: On 7/7/20 1:08 AM, Stephen Rothwell wrote: Hi all, Changes since 20200706: on i386: when CONFIG_ACPI is not set/enabled: ../drivers/scsi/lpfc/lpfc_init.c:1265:15: error: implicit declaration of function 'get_cpu_idle_time'; did you mean 'get_cpu_d

Re: [PATCH 05/11] media: exynos4-is: Improve support for sensors with multiple pads

2020-07-07 Thread Tomasz Figa
Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:44PM -0700, Jonathan Bakker wrote: > Commit 1c9f5bd7cb8a ("[media] s5p-fimc: Add support for sensors with > multiple pads") caught the case where a sensor with multiple pads was > connected via CSIS, but missed the case where the sensor was directly > con

[PATCH] staging: rtl8188eu: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fal

[PATCH v19 00/12] Landlock LSM

2020-07-07 Thread Mickaël Salaün
Hi, This new patch series is a light update of the previous one, with some minor fixes and cosmetic changes. All reviews have been taken into account. The SLOC count is 1299 for security/landlock/ and 1752 for tools/testing/selftest/landlock/ . Test coverage for security/landlock/ is 93.6% of l

[PATCH v19 06/12] fs,security: Add sb_delete hook

2020-07-07 Thread Mickaël Salaün
The sb_delete security hook is called when shutting down a superblock, which may be useful to release kernel objects tied to the superblock's lifetime (e.g. inodes). This new hook is needed by Landlock to release (ephemerally) tagged struct inodes. This comes from the unprivileged nature of Landl

[PATCH v19 01/12] landlock: Add object management

2020-07-07 Thread Mickaël Salaün
A Landlock object enables to identify a kernel object (e.g. an inode). A Landlock rule is a set of access rights allowed on an object. Rules are grouped in rulesets that may be tied to a set of processes (i.e. subjects) to enforce a scoped access-control (i.e. a domain). Because Landlock's goal i

Re: [PATCH 4.19 10/36] nvme: fix possible deadlock when I/O is blocked

2020-07-07 Thread Pavel Machek
Hi! > From: Sagi Grimberg > > [ Upstream commit 3b4b19721ec652ad2c4fe51dfbe5124212b5f581 ] > > Revert fab7772bfbcf ("nvme-multipath: revalidate nvme_ns_head gendisk > in nvme_validate_ns") > > When adding a new namespace to the head disk (via nvme_mpath_set_live) > we will see partition scan w

[PATCH v19 04/12] landlock: Add ptrace restrictions

2020-07-07 Thread Mickaël Salaün
Using ptrace(2) and related debug features on a target process can lead to a privilege escalation. Indeed, ptrace(2) can be used by an attacker to impersonate another task and to remain undetected while performing malicious activities. Thanks to ptrace_may_access(), various part of the kernel ca

[PATCH v19 03/12] landlock: Set up the security framework and manage credentials

2020-07-07 Thread Mickaël Salaün
A process credentials point to a Landlock domain, which is underneath implemented with a ruleset. In the following commits, this domain is used to check and enforce the ptrace and filesystem security policies. A domain is inherited from a parent to its child the same way a thread inherits a seccom

[PATCH v19 08/12] landlock: Add syscall implementation

2020-07-07 Thread Mickaël Salaün
This system call, inspired from seccomp(2) and bpf(2), is designed to be used by unprivileged processes to sandbox themselves. It has the same usage restrictions as seccomp(2): the caller must have the no_new_privs attribute set or have CAP_SYS_ADMIN in the current user namespace. Here are the mo

[PATCH v19 09/12] arch: Wire up landlock() syscall

2020-07-07 Thread Mickaël Salaün
Wire up the landlock() system call for all architectures. Signed-off-by: Mickaël Salaün Cc: Arnd Bergmann Cc: James Morris Cc: Jann Horn Cc: Kees Cook Cc: Serge E. Hallyn --- Changes since v18: * Increase the syscall number because of the new faccessat2(2). Changes since v14: * Add all arc

[PATCH v19 12/12] landlock: Add user and kernel documentation

2020-07-07 Thread Mickaël Salaün
This documentation can be built with the Sphinx framework. Signed-off-by: Mickaël Salaün Reviewed-by: Vincent Dagonneau Cc: James Morris Cc: Jann Horn Cc: Kees Cook Cc: Serge E. Hallyn --- Changes since v15: * Add current limitations. Changes since v14: * Fix spelling (contributed by Randy

[PATCH v19 02/12] landlock: Add ruleset and domain management

2020-07-07 Thread Mickaël Salaün
A Landlock ruleset is mainly a red-black tree with Landlock rules as nodes. This enables quick update and lookup to match a requested access e.g., to a file. A ruleset is usable through a dedicated file descriptor (cf. following commit implementing the syscall) which enables a process to create a

Re: memory leak in inotify_update_watch

2020-07-07 Thread Catalin Marinas
On Tue, Jul 07, 2020 at 05:24:11PM +0200, Jan Kara wrote: > On Mon 06-07-20 08:42:24, syzbot wrote: > > syzbot found the following crash on: > > > > HEAD commit:7cc2a8ea Merge tag 'block-5.8-2020-07-01' of git://git.ker.. > > git tree: upstream > > console output: https://syzkaller.appsp

[PATCH v19 07/12] landlock: Support filesystem access-control

2020-07-07 Thread Mickaël Salaün
Thanks to the Landlock objects and ruleset, it is possible to identify inodes according to a process's domain. To enable an unprivileged process to express a file hierarchy, it first needs to open a directory (or a file) and pass this file descriptor to the kernel through landlock(2). When checki

[PATCH v19 05/12] LSM: Infrastructure management of the superblock

2020-07-07 Thread Mickaël Salaün
From: Casey Schaufler Move management of the superblock->sb_security blob out of the individual security modules and into the security infrastructure. Instead of allocating the blobs from within the modules the modules tell the infrastructure how much space is required, and the space is allocated

[PATCH v19 11/12] samples/landlock: Add a sandbox manager example

2020-07-07 Thread Mickaël Salaün
Add a basic sandbox tool to launch a command which can only access a whitelist of file hierarchies in a read-only or read-write way. Signed-off-by: Mickaël Salaün Cc: James Morris Cc: Jann Horn Cc: Kees Cook Cc: Serge E. Hallyn --- Changes since v16: * Switch syscall attribute pointer and si

[PATCH v19 10/12] selftests/landlock: Add initial tests

2020-07-07 Thread Mickaël Salaün
Test landlock syscall, ptrace hooks semantic and filesystem access-control. Test coverage for security/landlock/ is 93.6% of lines. The code not covered only deals with internal kernel errors (e.g. memory allocation) and race conditions. Signed-off-by: Mickaël Salaün Reviewed-by: Vincent Dagonn

[PATCH] ASoC: amd: fixed kernel warnings

2020-07-07 Thread Vijendar Mukunda
This patch will fix unused variables kernel warnings when CONFIG_ACPI is disabled. Reported-by: Randy Dunlap Signed-off-by: Vijendar Mukunda --- sound/soc/amd/renoir/rn-pci-acp3x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/

Re: [PATCH 06/11] media: exynos4-is: Properly set JPEG options when not using CSIS

2020-07-07 Thread Tomasz Figa
Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:45PM -0700, Jonathan Bakker wrote: > Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture") > added support for JPEG capture, but missed setting a register when the > CSIS device wasn't in use. nit: Since this isn't really about using the

Re: [PATCH] ASoC: amd: add ACPI dependency check

2020-07-07 Thread Mukunda,Vijendar
On 07/07/20 9:05 pm, Randy Dunlap wrote: On 7/7/20 7:17 AM, Mark Brown wrote: On Tue, 7 Jul 2020 16:16:41 +0530, Vijendar Mukunda wrote: Add ACPI dependency for evaluating DMIC hardware runtime. Applied to https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.o

Re: [PATCH][next] Input: Use fallthrough pseudo-keyword

2020-07-07 Thread Dmitry Torokhov
On Tue, Jul 07, 2020 at 01:08:57PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] > https://www.kernel.org/doc/h

Re: [PATCH v4 12/18] nitro_enclaves: Add logic for enclave start

2020-07-07 Thread Paraschiv, Andra-Irina
On 06/07/2020 14:21, Alexander Graf wrote: On 22.06.20 22:03, Andra Paraschiv wrote: After all the enclave resources are set, the enclave is ready for beginning to run. Add ioctl command logic for starting an enclave after all its resources, memory regions and CPUs, have been set. The enc

Re: [PATCH] ASoC: amd: fixed kernel warnings

2020-07-07 Thread Randy Dunlap
On 7/7/20 11:37 AM, Vijendar Mukunda wrote: > This patch will fix unused variables kernel warnings when > CONFIG_ACPI is disabled. > > Reported-by: Randy Dunlap > Signed-off-by: Vijendar Mukunda Acked-by: Randy Dunlap # build-tested Thanks. > --- > sound/soc/amd/renoir/rn-pci-acp3x.c | 2 ++

Re: [PATCH][next] Input: Use fallthrough pseudo-keyword

2020-07-07 Thread Gustavo A. R. Silva
On Tue, Jul 07, 2020 at 11:26:54AM -0700, Dmitry Torokhov wrote: > On Tue, Jul 07, 2020 at 01:08:57PM -0500, Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > > fall-throu

[PATCH] powerpc/signal64: Don't opencode page prefaulting

2020-07-07 Thread Christophe Leroy
Instead of doing a __get_user() from the first and last location into a tmp var which won't be used, use fault_in_pages_readable() Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/signal_64.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/si

Re: [PATCH v2 2/2] i2c: imx: Fix external abort on interrupt in exit paths

2020-07-07 Thread Krzysztof Kozlowski
On Sun, Jun 14, 2020 at 12:29:04PM +0200, Krzysztof Kozlowski wrote: > If interrupt comes late, during probe error path or device remove (could > be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler > i2c_imx_isr() will access registers with the clock being disabled. This > leads to extern

Re: [RFT PATCH] ia64: Fix build error with !COREDUMP

2020-07-07 Thread Krzysztof Kozlowski
On Thu, Jun 04, 2020 at 10:18:42PM +0200, Krzysztof Kozlowski wrote: > Fix linkage error when CONFIG_BINFMT_ELF is selected but CONFIG_COREDUMP > is not: > > ia64-linux-ld: arch/ia64/kernel/elfcore.o: in function > `elf_core_write_extra_phdrs': > elfcore.c:(.text+0x172): undefined referen

Re: [PATCH 07/11] media: exynos4-is: Add support for multiple sensors on one port

2020-07-07 Thread Tomasz Figa
On Sat, Apr 25, 2020 at 07:26:46PM -0700, Jonathan Bakker wrote: > On some devices, there may be multiple camera sensors attached > to the same port. Make sure we probe all of them, not just the > first one. > > Signed-off-by: Jonathan Bakker > --- > drivers/media/platform/exynos4-is/media-dev.

Re: [PATCH 08/11] media: exynos4-is: Remove inh_sensor_ctrls

2020-07-07 Thread Tomasz Figa
On Sat, Apr 25, 2020 at 07:26:47PM -0700, Jonathan Bakker wrote: > This is a no-op as it is never set and is a remnant from non-DT days > that can be safely removed. > > Signed-off-by: Jonathan Bakker > --- > drivers/media/platform/exynos4-is/fimc-capture.c | 13 + > drivers/media/pl

Re: [PATCH 09/11] media: exynos4-is: Remove unused struct member input_index

2020-07-07 Thread Tomasz Figa
On Sat, Apr 25, 2020 at 07:26:48PM -0700, Jonathan Bakker wrote: > This is no longer used since the conversion to DT > > Signed-off-by: Jonathan Bakker > --- > drivers/media/platform/exynos4-is/fimc-core.h | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Tomasz Figa Best regards, Toma

Re: [RFC v3 1/2] fs: Add IOCB_NOIO flag for generic_file_read_iter

2020-07-07 Thread Jens Axboe
On 7/7/20 8:44 AM, Andreas Gruenbacher wrote: > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 3f881a892ea7..1ab2ea19e883 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -315,6 +315,7 @@ enum rw_hint { > #define IOCB_SYNC(1 << 5) > #define IOCB_WRITE

[PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-07 Thread Kuogee Hsieh
add event thread to execute events serially from event queue. Also timeout mode is supported which allow an event be deferred to be executed at later time. Both link and phy compliant tests had been done successfully. This change depends-on following series: https://lore.kernel.org/dri-d

Re: [PATCH] libnvdimm/security: Fix key lookup permissions

2020-07-07 Thread Dave Jiang
On 6/23/2020 9:35 PM, Dan Williams wrote: As of commit 8c0637e950d6 ("keys: Make the KEY_NEED_* perms an enum rather than a mask") lookup_user_key() needs an explicit declaration of what it wants to do with the key. Add KEY_NEED_SEARCH to fix a warning with the below signature, and fixes the i

Re: [PATCH 10/11] media: exynos4-is: Prevent duplicate call to media_pipeline_stop

2020-07-07 Thread Tomasz Figa
Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:49PM -0700, Jonathan Bakker wrote: > media_pipeline_stop can be called from both release and streamoff, > so make sure they're both protected under the streaming flag and > not just one of them. First of all, thanks for the patch. Shouldn't it be that r

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-07 Thread Joel Fernandes
On Tue, Jul 07, 2020 at 07:34:41PM +0200, Uladzislau Rezki wrote: > On Mon, Jul 06, 2020 at 02:06:45PM -0700, Paul E. McKenney wrote: > > On Thu, Jul 02, 2020 at 10:19:08PM +0200, Sebastian Andrzej Siewior wrote: > > > On 2020-07-02 09:48:26 [-0700], Paul E. McKenney wrote: > > > > On Thu, Jul 02,

Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing

2020-07-07 Thread Tomasz Figa
Hi Jonathan, On Sat, Apr 25, 2020 at 07:26:50PM -0700, Jonathan Bakker wrote: > According to the binding doc[1], port A should be reg = 0 > and port B reg = 1. Unfortunately, the driver was treating 0 > as invalid and 1 as camera port A. Match the binding doc and > make 0=A and 1=B. > > [1] Doc

Re: [PATCH v2 1/8] dt-bindings: pwm: samsung: Do not require interrupts on Exynos SoCs

2020-07-07 Thread Krzysztof Kozlowski
On Mon, Jul 06, 2020 at 11:41:57AM +0200, Uwe Kleine-König wrote: > On Thu, Jul 02, 2020 at 05:51:42PM +0200, Krzysztof Kozlowski wrote: > > The bindings required interrupts for all SoCs but actually only the PWM > > timer clocksource (for S3C/S5P SoCs) was using them. This PWM timer > > clocksour

Re: [RFC PATCH for 5.8 3/4] rseq: Introduce RSEQ_FLAG_RELIABLE_CPU_ID

2020-07-07 Thread Carlos O'Donell
On 7/7/20 8:06 AM, Mathieu Desnoyers wrote: > - On Jul 7, 2020, at 7:32 AM, Florian Weimer f...@deneb.enyo.de wrote: > >> * Mathieu Desnoyers: >> >>> Those are very good points. One possibility we have would be to let >>> glibc do the rseq registration without the RSEQ_FLAG_RELIABLE_CPU_ID >>>

Re: [PATCH v4 10/11] mm/memory-failure: remove a wrapper for alloc_migration_target()

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 17:03:50, Vlastimil Babka wrote: > On 7/7/20 1:48 PM, Michal Hocko wrote: > > On Tue 07-07-20 16:44:48, Joonsoo Kim wrote: > >> From: Joonsoo Kim > >> > >> There is a well-defined standard migration target callback. Use it > >> directly. > >> > >> Signed-off-by: Joonsoo Kim > >>

[RFC PATCH] mm: avoid access flag update TLB flush for retried page fault

2020-07-07 Thread Yang Shi
Recently we found regression when running will_it_scale/page_fault3 test on ARM64. Over 70% down for the multi processes cases and over 20% down for the multi threads cases. It turns out the regression is caused by commit 89b15332af7c0312a41e50846819ca6613b58b4c ("mm: drop mmap_sem before calling

Re: [PATCH 1/3] usb: dwc2: override PHY input signals with usb role switch support

2020-07-07 Thread Martin Blumenstingl
Hi Amelie, On Tue, Jul 7, 2020 at 6:13 PM Amelie DELAUNAY wrote: > > Hi Martin, > > On 7/4/20 7:42 PM, Martin Blumenstingl wrote: > > Hello Amelie, > > > > thank you for this patch - I am hoping that it will help us on Amlogic > > Meson8, Meson8b, Meson8m2 and GXBB SoCs as well. > > On these SoCs

Re: [PATCH] mtd: rawnand: ingenic: cleanup ARRAY_SIZE() vs sizeof() use

2020-07-07 Thread Miquel Raynal
On Wed, 2020-06-24 at 13:26:40 UTC, Dan Carpenter wrote: > The ARRAY_SIZE() is the number of elements but we want to use sizeof() > here for the number of bytes. Fortunately, they are the same thing > because it's an array of u8 so this has no effect on runtime. > > Signed-off-by: Dan Carpenter

[PATCH] perf/x86/intel/lbr: Enable NO_{CYCLES,FLAGS} for all LBR formats

2020-07-07 Thread kan . liang
From: Kan Liang An option to disable reading branch flags/cycles was introduced in commit b16a5b52eb90 ("perf/x86: Add option to disable reading branch flags/cycles"). Currently, the option is only supported by the LBR_FORMAT_INFO format. For the other LBR formats, including the legacy LBR, Archi

Re: [RFC PATCH for 5.8 3/4] rseq: Introduce RSEQ_FLAG_RELIABLE_CPU_ID

2020-07-07 Thread Mathieu Desnoyers
- On Jul 7, 2020, at 2:53 PM, Carlos O'Donell car...@redhat.com wrote: > On 7/7/20 8:06 AM, Mathieu Desnoyers wrote: >> - On Jul 7, 2020, at 7:32 AM, Florian Weimer f...@deneb.enyo.de wrote: >> >>> * Mathieu Desnoyers: >>> Those are very good points. One possibility we have would be

Re: [PATCH v5 5/6] mtd: rawnand: stm32_fmc2: use regmap APIs

2020-07-07 Thread Miquel Raynal
On Fri, 2020-06-12 at 15:22:41 UTC, Christophe Kerello wrote: > This patch uses regmap APIs to access all FMC2 registers. > > Signed-off-by: Christophe Kerello > Reviewed-by: Miquel Raynal Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel

Re: [PATCH v5 3/6] dt-bindings: memory-controller: add STM32 FMC2 EBI controller documentation

2020-07-07 Thread Miquel Raynal
On Fri, 2020-06-12 at 15:22:39 UTC, Christophe Kerello wrote: > This patch adds the documentation of the device tree bindings for the STM32 > FMC2 EBI controller. > > Signed-off-by: Christophe Kerello > Reviewed-by: Rob Herring Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linu

Re: [PATCH v5 2/6] dt-bindings: mtd: update STM32 FMC2 NAND controller documentation

2020-07-07 Thread Miquel Raynal
On Fri, 2020-06-12 at 15:22:38 UTC, Christophe Kerello wrote: > These bindings can be used on SOCs where the FMC2 NAND controller is > in standalone. In case that the FMC2 embeds 2 controllers (an external > bus controller and a raw NAND controller), the register base address, > the clock and the r

Re: [PATCH v5 1/6] mtd: rawnand: stm32_fmc2: do not display errors if the driver is deferred

2020-07-07 Thread Miquel Raynal
On Fri, 2020-06-12 at 15:22:37 UTC, Christophe Kerello wrote: > A MDMA issue has been solved on Kernel 5.7. The effect of this fix is > that the MDMA driver is now deferred and the FMC2 NFC driver is also > deferred. All is working fine but there is a FMC2 log in the console: > stm32_fmc2_nfc 58002

Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver

2020-07-07 Thread Miquel Raynal
On Fri, 2020-06-12 at 15:22:40 UTC, Christophe Kerello wrote: > The driver adds the support for the STMicroelectronics FMC2 EBI controller > found on STM32MP SOCs. > > Signed-off-by: Christophe Kerello Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. M

Re: [PATCH v5 6/6] mtd: rawnand: stm32_fmc2: get resources from parent node

2020-07-07 Thread Miquel Raynal
On Fri, 2020-06-12 at 15:22:42 UTC, Christophe Kerello wrote: > FMC2 EBI support has been added. Common resources (registers base > address and clock) can now be shared between the 2 drivers using > "st,stm32mp1-fmc2-nfc" compatible string. It means that the > common resources should now be found i

Re: [PATCH v4 06/11] mm/migrate: make a standard migration target allocation function

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 16:49:51, Vlastimil Babka wrote: > On 7/7/20 9:44 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > There are some similar functions for migration target allocation. Since > > there is no fundamental difference, it's better to keep just one rather > > than keeping all var

Re: [PATCH 5/5] nvme-pci: Use standard block status macro

2020-07-07 Thread Keith Busch
On Fri, Jul 03, 2020 at 10:49:24AM +0800, Baolin Wang wrote: > static blk_status_t nvme_map_data(struct nvme_dev *dev, struct request *req, > @@ -844,7 +844,7 @@ static blk_status_t nvme_map_metadata(struct nvme_dev > *dev, struct request *req, > if (dma_mapping_error(dev->dev, iod->meta_dm

Re: [PATCH v2] powerpc/uaccess: Use flexible addressing with __put_user()/__get_user()

2020-07-07 Thread Christophe Leroy
Le 07/07/2020 à 14:44, Christophe Leroy a écrit : Le 30/06/2020 à 03:19, Michael Ellerman a écrit : Michael Ellerman writes: Christophe Leroy writes: Hi Michael, I see this patch is marked as "defered" in patchwork, but I can't see any related discussion. Is it normal ? Because it us

Re: [PATCH v4 16/18] nitro_enclaves: Add sample for ioctl interface usage

2020-07-07 Thread Paraschiv, Andra-Irina
On 06/07/2020 14:39, Alexander Graf wrote: On 22.06.20 22:03, Andra Paraschiv wrote: Signed-off-by: Alexandru Vasile Signed-off-by: Andra Paraschiv --- Changelog v3 -> v4 * Update usage details to match the updates in v4. * Update NE ioctl interface usage. v2 -> v3 * Remove the includ

[PATCH v3 09/13] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w'

2020-07-07 Thread Pierre-Louis Bossart
From: Lee Jones Looks like 'w' has remained unchecked since the driver's inception. Fixes the following W=1 kernel build warning(s): sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’: sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-

[PATCH v3 07/13] ASoC: codecs: da7219: fix 'defined but not used' warning

2020-07-07 Thread Pierre-Louis Bossart
fix W=1 warning sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match' defined but not used [-Wunused-const-variable=] 1711 | static const struct acpi_device_id da7219_acpi_match[] = { |^ Reviewed-by: Adam Thomson Signed-off-by:

[PATCH v3 08/13] ASoC: codecs: jz4770: Remove defined but never used variable 'mic_boost_tlv'

2020-07-07 Thread Pierre-Louis Bossart
From: Lee Jones Fixes the following W=1 kernel build warning(s): In file included from include/sound/tlv.h:10, from sound/soc/codecs/jz4770.c:19: sound/soc/codecs/jz4770.c:306:35: warning: ‘mic_boost_tlv’ defined but not used [-Wunused-const-variable=] 306 | static const DECLARE_TLV_DB_SCAL

[PATCH v3 12/13] ASoC: codecs: max98390: fix 'defined but not used' warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning and removed unused table. In this case this a duplicate of static const struct of_device_id max98390_of_match[] = { { .compatible = "maxim,max98390", }, {} }; MODULE_DEVICE_TABLE(of, max98390_of_match); already used in the rest of the code. Signed-off-by: Pierre-L

[PATCH v3 05/13] ASoC: uniphier: aio-core: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning - wrong parameter description and bad format Reviewed-by: Masahiro Yamada Signed-off-by: Pierre-Louis Bossart --- sound/soc/uniphier/aio-core.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.

[PATCH v3 04/13] ASoC: tegra: tegra20_das: remove always-true comparison

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning: sound/soc//tegra/tegra20_das.c:101:11: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 101 | if ((reg >= TEGRA20_DAS_DAP_CTRL_SEL) && | ^~ Reviewed-by: Jon Hunter Signed-off-by: Pierre-Louis Bossart --- sound/soc/tegra/tegra20_

[PATCH v3 02/13] ASoC: samsung: spdif: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warnings - typos with structure fields Reviewed-by: Sylwester Nawrocki Signed-off-by: Pierre-Louis Bossart --- sound/soc/samsung/spdif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c index 759fc6644329..4a

[PATCH v3 01/13] ASoC: atmel: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning Kernel-doc is not used in one file and missing argument in the second. Acked-by: Alexandre Belloni Signed-off-by: Pierre-Louis Bossart --- sound/soc/atmel/atmel-pcm-dma.c | 2 +- sound/soc/atmel/atmel_ssc_dai.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v3 10/13] ASoC: codecs: cros_ec_codec: fix 'defined but not used' warning

2020-07-07 Thread Pierre-Louis Bossart
fix W=1 warning sound/soc/codecs/cros_ec_codec.c:1056:36: warning: 'cros_ec_codec_acpi_id' defined but not used [-Wunused-const-variable=] 1056 | static const struct acpi_device_id cros_ec_codec_acpi_id[] = { |^ Signed-off-by: Pierre-

[PATCH v3 03/13] ASoC: samsung: pcm: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warnings - missing fields in structure Credits to Sylwester Nawrocki for the pclk and cclk descriptions. Reviewed-by: Sylwester Nawrocki Signed-off-by: Pierre-Louis Bossart --- sound/soc/samsung/pcm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/soc/samsung/pcm.c b/so

[PATCH v3 11/13] ASoC: codecs: es8316: fix 'defined but not used' warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning sound/soc/codecs/es8316.c:842:36: warning: 'es8316_acpi_match' defined but not used [-Wunused-const-variable=] 842 | static const struct acpi_device_id es8316_acpi_match[] = { |^ Signed-off-by: Pierre-Louis Bossart ---

[PATCH v3 06/13] ASoC: codecs: da7210: fix kernel-doc

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning, the kernel-doc syntax was probably from Doxygen? Acked-by: Adam Thomson Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/da7210.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c index

[PATCH v3 13/13] ASoC: codecs: rt*: fix 'defined but not used' warning

2020-07-07 Thread Pierre-Louis Bossart
Fix W=1 warning when ACPI is not defined Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/rt274.c | 2 ++ sound/soc/codecs/rt286.c | 2 ++ sound/soc/codecs/rt298.c | 2 ++ sound/soc/codecs/rt5660.c | 2 ++ sound/soc/codecs/rt5677-spi.c | 2 ++ 5 files changed, 10 inser

[PATCH v4 1/2] remoteproc: Add remoteproc character device interface

2020-07-07 Thread Siddharth Gupta
Add the character device interface into remoteproc framework. This interface can be used in order to boot/shutdown remote subsystems and provides a basic ioctl based interface to implement supplementary functionality. An ioctl call is implemented to enable the shutdown on release feature which will

<    5   6   7   8   9   10   11   12   13   14   >