Re: [PATCH v4 05/11] mm/migrate: clear __GFP_RECLAIM for THP allocation for migration

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 16:44:43, Joonsoo Kim wrote: > From: Joonsoo Kim > > In mm/migrate.c, THP allocation for migration is called with the provided > gfp_mask | GFP_TRANSHUGE. This gfp_mask contains __GFP_RECLAIM and it > would be conflict with the intention of the GFP_TRANSHUGE. > > GFP_TRANSHUGE/GF

Re: [PATCH v2] PCI: controller: convert to devm_platform_ioremap_resource_byname()

2020-07-07 Thread Lorenzo Pieralisi
On Tue, Jul 07, 2020 at 12:31:17PM +0100, Lorenzo Pieralisi wrote: > On Wed, Jun 03, 2020 at 01:16:01AM +0800, Dejin Zheng wrote: > > Use devm_platform_ioremap_resource_byname() to simplify codes. > > it contains platform_get_resource_byname() and devm_ioremap_resource(). > > > > Signed-off-by: De

Re: [PATCH v6 1/7] net/scm: Regularize compat handling of scm_detach_fds()

2020-07-07 Thread Christian Brauner
On Mon, Jul 06, 2020 at 01:17:14PM -0700, Kees Cook wrote: > Duplicate the cleanups from commit 2618d530dd8b ("net/scm: cleanup > scm_detach_fds") into the compat code. > > Move the check added in commit 1f466e1f15cf ("net: cleanly handle kernel > vs user buffers for ->msg_control") to before the

Re: [PATCH v7] Add basic SoC Support for Mediatek MT6779 SoC

2020-07-07 Thread Linus Walleij
On Thu, Jul 2, 2020 at 2:57 PM Hanks Chen wrote: > Change since v7: > Commit "dt-bindings: pinctrl: add bindings for MediaTek" > -- fix typo and change order of patch > Commit "clk: mediatek: add UART0 clock support" > -- add fixes tag and real name > Commit "arm64: dts: add dts nodes for MT6779"

[PATCH] staging: rtl8723bs: Using comparison to true is error prone

2020-07-07 Thread John Oldman
clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error pron Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 70 ++--- 1 file changed, 32 insertions(+), 38 deletions(-) d

Re: [PATCH] platform/chrome: cros_ec_proto: Convert EC error codes to Linux error codes

2020-07-07 Thread Guenter Roeck
On 7/7/20 3:10 AM, Enric Balletbo i Serra wrote: > Hi Prashant and Guenter, > > Thank you to spend your time on look at this. > > On 4/7/20 16:26, Guenter Roeck wrote: >> The EC reports a variety of error codes. Most of those, with the exception >> of EC_RES_INVALID_VERSION, are converted to -EPR

Re: [PATCH v2 2/3] xen/privcmd: Mark pages as dirty

2020-07-07 Thread Jürgen Groß
On 07.07.20 13:30, Souptick Joarder wrote: On Tue, Jul 7, 2020 at 3:08 PM Jürgen Groß wrote: On 06.07.20 20:16, Souptick Joarder wrote: pages need to be marked as dirty before unpinned it in unlock_pages() which was oversight. This is fixed now. Signed-off-by: Souptick Joarder Suggested-by:

Re: [PATCH 0/2][RFC] Makes sd->flags sysctl writable

2020-07-07 Thread Chen Yu
Hi Peter, On Mon, Jul 06, 2020 at 10:00:49PM +0200, Peter Zijlstra wrote: > On Tue, Jul 07, 2020 at 03:36:13AM +0800, Chen Yu wrote: > > It was found that recently the flags of sched domain could > > not be customized via sysctl, which might make it a little > > inconenient for performance tuning/d

Re: [mm] 4e2c82a409: ltp.overcommit_memory01.fail

2020-07-07 Thread Qian Cai
> On Jul 7, 2020, at 6:28 AM, Michal Hocko wrote: > > Would you have any examples? Because I find this highly unlikely. > OVERCOMMIT_NEVER only works when virtual memory is not largerly > overcommited wrt to real memory demand. And that tends to be more of > an exception rather than a rule. "M

Re: [PATCH v4 06/11] mm/migrate: make a standard migration target allocation function

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 16:44:44, Joonsoo Kim wrote: > From: Joonsoo Kim > > There are some similar functions for migration target allocation. Since > there is no fundamental difference, it's better to keep just one rather > than keeping all variants. This patch implements base migration target > alloc

Re: [PATCH v2 1/2] drm: drm_fourcc: add NV20 and NV30 YUV formats【请注意,邮件由linux-rockchip-bounces+sandy.huang=rock-chips....@lists.infradead.org代发】

2020-07-07 Thread Huang Jiachai
在 2020/7/7 6:30, Jonas Karlman 写道: DRM_FORMAT_NV20 and DRM_FORMAT_NV30 formats is the 2x1 and non-subsampled variant of NV15, a 10-bit 2-plane YUV format that has no padding between components. Instead, luminance and chrominance samples are grouped into 4s so that each group is packed into an in

[PATCH v10 4/4] ext4: Use generic casefolding support

2020-07-07 Thread Daniel Rosenberg
This switches ext4 over to the generic support provided in the previous patch. Since casefolded dentries behave the same in ext4 and f2fs, we decrease the maintenance burden by unifying them, and any optimizations will immediately apply to both. Signed-off-by: Daniel Rosenberg --- fs/ext4/dir.c

[PATCH v10 3/4] f2fs: Use generic casefolding support

2020-07-07 Thread Daniel Rosenberg
This switches f2fs over to the generic support provided in the previous patch. Since casefolded dentries behave the same in ext4 and f2fs, we decrease the maintenance burden by unifying them, and any optimizations will immediately apply to both. Signed-off-by: Daniel Rosenberg --- fs/f2fs/dir.c

[PATCH v10 2/4] fs: Add standard casefolding support

2020-07-07 Thread Daniel Rosenberg
This adds general supporting functions for filesystems that use utf8 casefolding. It provides standard dentry_operations and adds the necessary structures in struct super_block to allow this standardization. The new dentry operations are functionally equivalent to the existing operations in ext4 a

[PATCH v10 0/4] Prepare for upcoming Casefolding/Encryption patches

2020-07-07 Thread Daniel Rosenberg
This lays the ground work for enabling casefolding and encryption at the same time for ext4 and f2fs. A future set of patches will enable that functionality. These unify the highly similar dentry_operations that ext4 and f2fs both use for casefolding. In addition, they improve d_hash by not requir

[PATCH v10 1/4] unicode: Add utf8_casefold_hash

2020-07-07 Thread Daniel Rosenberg
This adds a case insensitive hash function to allow taking the hash without needing to allocate a casefolded copy of the string. The existing d_hash implementations for casefolding allocates memory within rcu-walk, by avoiding it we can be more efficient and avoid worrying about a failed allocatio

[PATCH] ASoC: fsl: mpc8610_hpcd: Add missing of_node_put()

2020-07-07 Thread Yi Wang
From: Liao Pingfang After finishing using device node got from of_find_compatible_node(), of_node_put() needs to be called. Signed-off-by: Liao Pingfang --- sound/soc/fsl/mpc8610_hpcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_h

Re: [PATCH v6 2/7] fs: Move __scm_install_fd() to __receive_fd()

2020-07-07 Thread Christian Brauner
On Mon, Jul 06, 2020 at 01:17:15PM -0700, Kees Cook wrote: > In preparation for users of the "install a received file" logic outside > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > net/core/scm.c to __receive_fd() in fs/file.c, and provide a wrapper > named receive_fd_u

Re: [PATCH v2 1/3] xen/privcmd: Corrected error handling path

2020-07-07 Thread Jürgen Groß
On 07.07.20 13:40, Souptick Joarder wrote: On Tue, Jul 7, 2020 at 3:05 PM Jürgen Groß wrote: On 06.07.20 20:16, Souptick Joarder wrote: Previously, if lock_pages() end up partially mapping pages, it used to return -ERRNO due to which unlock_pages() have to go through each pages[i] till *nr_pa

Re: [PATCH v2 2/2] drm: rockchip: add NV15, NV20 and NV30 support【请注意,邮件由linux-rockchip-bounces+sandy.huang=rock-chips....@lists.infradead.org代发】

2020-07-07 Thread Huang Jiachai
在 2020/7/7 6:30, Jonas Karlman 写道: Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399. Also add support for 10-bit 4:4:4 format while at it. V2: Added NV30 support Signed-off-by: Jonas Karlman --- dr

[PATCH] arm64/module-plts: Consider the special case where plt_max_entries is 0

2020-07-07 Thread Peng Hao
If plt_max_entries is 0, a warning is triggered. WARNING: CPU: 200 PID: 3000 at arch/arm64/kernel/module-plts.c:97 module_emit_plt_entry+0xa4/0x150 Signed-off-by: Peng Hao --- arch/arm64/kernel/module-plts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel

Re: [PATCH v4 07/11] mm/gup: use a standard migration target allocation callback

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 16:44:45, Joonsoo Kim wrote: [...] > @@ -1551,9 +1552,12 @@ struct page *alloc_migration_target(struct page *page, > unsigned long private) > > gfp_mask |= htlb_alloc_mask(h); > return alloc_huge_page_nodemask(h, nid, mtc->nmask, > -

[PATCH v15 00/20] per memcg lock

2020-07-07 Thread Alex Shi
The new version which bases on v5.8-rc4, used open version __pagevec_lru_add according to Matthew Wilcox's suggestion. Current lru_lock is one for each of node, pgdat->lru_lock, that guard for lru lists, but now we had moved the lru lists into memcg for long time. Still using per node lru_lock is

[PATCH v15 03/21] mm/compaction: correct the comments of compact_defer_shift

2020-07-07 Thread Alex Shi
There is no compact_defer_limit. It should be compact_defer_shift in use. and add compact_order_failed explanation. Signed-off-by: Alex Shi Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- include/linux/mmzone.h | 1 + mm/compaction.c| 2 +- 2 files changed,

[PATCH v15 15/21] mm/swap: serialize memcg changes during pagevec_lru_move_fn

2020-07-07 Thread Alex Shi
Hugh Dickins' found a memcg change bug on original version: If we want to change the pgdat->lru_lock to memcg's lruvec lock, we have to serialize mem_cgroup_move_account during pagevec_lru_move_fn. The possible bad scenario would like: cpu 0 cpu 1 lruvec =

[PATCH v15 08/21] mm/memcg: add debug checking in lock_page_memcg

2020-07-07 Thread Alex Shi
Add a debug checking in lock_page_memcg, then we could get alarm if anything wrong here. Suggested-by: Johannes Weiner Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgro...@vger.kernel.org Cc: linux...@kvack.org Cc: linux-kernel@vger.

[PATCH v15 18/21] mm/vmscan: use relock for move_pages_to_lru

2020-07-07 Thread Alex Shi
From: Hugh Dickins Use the relock function to replace relocking action. And try to save few lock times. Signed-off-by: Hugh Dickins Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Tejun Heo Cc: Andrey Ryabinin Cc: Jann Horn Cc: Mel Gorman Cc: Johannes Weiner Cc: Matthew Wilcox Cc: Hugh Di

Re: [PATCH] irq: Request and release resources for chained IRQs

2020-07-07 Thread Linus Walleij
On Thu, Jun 18, 2020 at 8:42 PM Thomas Gleixner wrote: > David Heidelberg writes: > > is there chance to get this patch included or could be this issue > > solved with different approach? > > Included into what? This patch is incorrect as I pointed out in review > here: > > > https://lore.kern

[PATCH v15 20/21] mm/lru: revise the comments of lru_lock

2020-07-07 Thread Alex Shi
From: Hugh Dickins Since we changed the pgdat->lru_lock to lruvec->lru_lock, it's time to fix the incorrect comments in code. Also fixed some zone->lru_lock comment error from ancient time. etc. Signed-off-by: Hugh Dickins Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Tejun Heo Cc: Andrey Ry

[PATCH v15 16/21] mm/lru: replace pgdat lru_lock with lruvec lock

2020-07-07 Thread Alex Shi
This patch moves per node lru_lock into lruvec, thus bring a lru_lock for each of memcg per node. So on a large machine, each of memcg don't have to suffer from per node pgdat->lru_lock competition. They could go fast with their self lru_lock. After move memcg charge before lru inserting, page iso

[PATCH v15 19/21] mm/pgdat: remove pgdat lru_lock

2020-07-07 Thread Alex Shi
Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore. Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Konstantin Khlebnikov Cc: Hugh Dickins Cc: Johannes Weiner Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org Cc: cgro...@vger.kernel.org --- include/linux/mmzone.h | 1 -

[PATCH v15 17/21] mm/lru: introduce the relock_page_lruvec function

2020-07-07 Thread Alex Shi
Use this new function to replace repeated same code, no func change. Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Andrew Morton Cc: Thomas Gleixner Cc: Andrey Ryabinin Cc: Matthew Wilcox Cc: Mel Gorman Cc: Konstantin Khlebnikov Cc: Hugh Dickins Cc: Tejun Heo Cc: linux-kernel@vger.kern

[PATCH v15 06/21] mm/thp: clean up lru_add_page_tail

2020-07-07 Thread Alex Shi
Since the first parameter is only used by head page, it's better to make it explicit. Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Johannes Weiner Cc: Matthew Wilcox Cc: Hugh Dickins Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/huge_memory.c | 12 ++-- 1 file chang

[PATCH v15 12/21] mm/lru: introduce TestClearPageLRU

2020-07-07 Thread Alex Shi
Combine PageLRU check and ClearPageLRU into a function by new introduced func TestClearPageLRU. This function will be used as page isolation precondition to prevent other isolations some where else. Then there are may non PageLRU page on lru list, need to remove BUG checking accordingly. Hugh Dick

[PATCH v15 07/21] mm/thp: narrow lru locking

2020-07-07 Thread Alex Shi
lru_lock and page cache xa_lock have no reason with current sequence, put them together isn't necessary. let's narrow the lru locking, but left the local_irq_disable to block interrupt re-entry and statistic update. Hugh Dickins point: split_huge_page_to_list() was already silly,to be using the _i

[PATCH v15 13/21] mm/compaction: do page isolation first in compaction

2020-07-07 Thread Alex Shi
Johannes Weiner has suggested: "So here is a crazy idea that may be worth exploring: Right now, pgdat->lru_lock protects both PageLRU *and* the lruvec's linked list. Can we make PageLRU atomic and use it to stabilize the lru_lock instead, and then use the lru_lock only serialize list operations?

[PATCH v15 09/21] mm/swap: fold vm event PGROTATED into pagevec_move_tail_fn

2020-07-07 Thread Alex Shi
Fold the PGROTATED event collection into pagevec_move_tail_fn call back func like other funcs does in pagevec_lru_move_fn. Now all usage of pagevec_lru_move_fn are same and no needs of the 3rd parameter. It's simply the calling. [l...@intel.com: found a build issue in the original patch, thanks]

[PATCH v15 14/21] mm/mlock: reorder isolation sequence during munlock

2020-07-07 Thread Alex Shi
This patch reorder the isolation steps during munlock, move the lru lock to guard each pages, unfold __munlock_isolate_lru_page func, to do the preparation for lru lock change. __split_huge_page_refcount doesn't exist, but we still have to guard PageMlocked and PageLRU in __split_huge_page_tail, t

[PATCH v15 10/21] mm/lru: move lru_lock holding in func lru_note_cost_page

2020-07-07 Thread Alex Shi
It's a clean up patch w/o function changes. Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/memory.c | 3 --- mm/swap.c | 2 ++ mm/swap_state.c | 2 -- mm/workingset.c | 2 -- 4 files changed, 2 insertions(+

[PATCH v15 11/21] mm/lru: move lock into lru_note_cost

2020-07-07 Thread Alex Shi
This patch move lru_lock into lru_note_cost. It's a bit ugly and may cost more locking, but it's necessary for later per pgdat lru_lock to per memcg lru_lock change. Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/swa

[PATCH v15 02/21] mm/page_idle: no unlikely double check for idle page counting

2020-07-07 Thread Alex Shi
As func comments mentioned, few isolated page missing be tolerated. So why not do further to drop the unlikely double check. That won't cause more idle pages, but reduce a lock contention. This is also a preparation for later new page isolation feature. Signed-off-by: Alex Shi Cc: Andrew Morton

[PATCH v15 05/21] mm/thp: move lru_add_page_tail func to huge_memory.c

2020-07-07 Thread Alex Shi
The func is only used in huge_memory.c, defining it in other file with a CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird. Let's move it THP. And make it static as Hugh Dickin suggested. Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Johannes Weiner Cc: Matthew Wilcox Cc: Hugh Dicki

[PATCH v15 04/21] mm/compaction: rename compact_deferred as compact_should_defer

2020-07-07 Thread Alex Shi
The compact_deferred is a defer suggestion check, deferring action does in defer_compaction not here. so, better rename it to avoid confusing. Signed-off-by: Alex Shi Cc: Steven Rostedt Cc: Ingo Molnar Cc: Andrew Morton Cc: Vlastimil Babka Cc: Mike Kravetz Cc: linux-kernel@vger.kernel.org Cc

[PATCH v15 01/21] mm/vmscan: remove unnecessary lruvec adding

2020-07-07 Thread Alex Shi
We don't have to add a freeable page into lru and then remove from it. This change saves a couple of actions and makes the moving more clear. The SetPageLRU needs to be kept here for list intergrity. Otherwise: #0 mave_pages_to_lru #1 release_pages

Re: [PATCH v4 10/11] mm/memory-failure: remove a wrapper for alloc_migration_target()

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 16:44:48, Joonsoo Kim wrote: > From: Joonsoo Kim > > There is a well-defined standard migration target callback. Use it > directly. > > Signed-off-by: Joonsoo Kim > --- > mm/memory-failure.c | 18 ++ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff -

Re: [PATCH v6 3/7] fs: Add receive_fd() wrapper for __receive_fd()

2020-07-07 Thread Christian Brauner
On Mon, Jul 06, 2020 at 01:17:16PM -0700, Kees Cook wrote: > For both pidfd and seccomp, the __user pointer is not used. Update > __receive_fd() to make writing to ufd optional via a NULL check. However, > for the receive_fd_user() wrapper, ufd is NULL checked so an -EFAULT > can be returned to avo

Re: [PATCH v2 3/3] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()

2020-07-07 Thread Jürgen Groß
On 06.07.20 20:16, Souptick Joarder wrote: In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. This is case 5 as per document [1]. [1] Documentation/core-api/pin_user_pages.rst [2]

Re: [PATCH v3 4/4] PCI/ACS: Enable PCI_ACS_TB for untrusted/external-facing devices

2020-07-07 Thread kernel test robot
Hi Rajat, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pci/next] [also build test WARNING on iommu/next pm/linux-next v5.8-rc4 next-20200707] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v7] Add basic SoC Support for Mediatek MT6779 SoC

2020-07-07 Thread Hanks Chen
On Tue, 2020-07-07 at 13:41 +0200, Linus Walleij wrote: > On Thu, Jul 2, 2020 at 2:57 PM Hanks Chen wrote: > > > Change since v7: > > Commit "dt-bindings: pinctrl: add bindings for MediaTek" > > -- fix typo and change order of patch > > Commit "clk: mediatek: add UART0 clock support" > > -- add f

Re: [PATCH v4 11/11] mm/memory_hotplug: remove a wrapper for alloc_migration_target()

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 16:44:49, Joonsoo Kim wrote: > From: Joonsoo Kim > > To calculate the correct node to migrate the page for hotplug, we need > to check node id of the page. Wrapper for alloc_migration_target() exists > for this purpose. > > However, Vlastimil informs that all migration source pag

Re: [PATCH] ubifs: Fix wrong orphan node deletion in ubifs_jnl_update()

2020-07-07 Thread Richard Weinberger
On Thu, Jul 2, 2020 at 5:21 PM Zhihao Cheng wrote: > > There a wrong orphan node deleting in error handling path in > ubifs_jnl_update(), which may cause following error msg: > > UBIFS error (ubi0:0 pid 1522): ubifs_delete_orphan [ubifs]: > missing orphan ino 65 > > Fix this by checking whethe

Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 13:59:15, Jia He wrote: > This exports memory_add_physaddr_to_nid() for module driver to use. > > memory_add_physaddr_to_nid() is a fallback option to get the nid in case > NUMA_NO_NID is detected. > > Suggested-by: David Hildenbrand > Signed-off-by: Jia He > --- > arch/arm64/m

Re: [PATCH 0/2][RFC] Makes sd->flags sysctl writable

2020-07-07 Thread Chen Yu
Hi Valentin, On Mon, Jul 06, 2020 at 11:11:32PM +0100, Valentin Schneider wrote: > > On 06/07/20 21:00, Peter Zijlstra wrote: > > On Tue, Jul 07, 2020 at 03:36:13AM +0800, Chen Yu wrote: > >> It was found that recently the flags of sched domain could > >> not be customized via sysctl, which might

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-07 Thread Zhihao Cheng
在 2020/7/7 19:26, Richard Weinberger 写道: On Wed, Jul 1, 2020 at 1:28 PM Zhihao Cheng wrote: There is a potential space leak problem while linking tmpfile, in which case, inode node (with nlink=0) is valid in tnc (on flash), which leads to space leak. Meanwhile, the corresponding data nodes won'

Re: [PATCH] ubifs: Fix wrong orphan node deletion in ubifs_jnl_update()

2020-07-07 Thread Zhihao Cheng
在 2020/7/7 19:52, Richard Weinberger 写道: On Thu, Jul 2, 2020 at 5:21 PM Zhihao Cheng wrote: There a wrong orphan node deleting in error handling path in ubifs_jnl_update(), which may cause following error msg: UBIFS error (ubi0:0 pid 1522): ubifs_delete_orphan [ubifs]: missing orphan ino

Re: [PATCH v3 05/10] pinctrl: ocelot: Add Sparx5 SoC support

2020-07-07 Thread Linus Walleij
On Mon, Jun 15, 2020 at 3:33 PM Lars Povlsen wrote: > This add support for Sparx5 pinctrl, using the ocelot drives as > basis. It adds pinconfig support as well, as supported by the > platform. > > Reviewed-by: Alexandre Belloni > Signed-off-by: Lars Povlsen This one patch applied to the pinct

Re: [PATCH v15 05/21] mm/thp: move lru_add_page_tail func to huge_memory.c

2020-07-07 Thread Alex Shi
在 2020/7/7 下午7:46, Alex Shi 写道: > > +static void lru_add_page_tail(struct page *page, struct page *page_tail, > + struct lruvec *lruvec, struct list_head *list) > +{ > + VM_BUG_ON_PAGE(!PageHead(page), page); > + VM_BUG_ON_PAGE(PageCompound(page_tail), page)

Re: [PATCH v3 1/7] pinctrl: qcom: spmi-gpio: Add pm660(l) compatibility

2020-07-07 Thread Linus Walleij
On Mon, Jun 22, 2020 at 9:26 PM Konrad Dybcio wrote: > Add support for pm660(l) SPMI GPIOs. The PMICs feature > 13 and 12 GPIOs respectively, though with a lot of > holes inbetween. > > Signed-off-by: Konrad Dybcio Patch applied. Yours, Linus Walleij

Re: [PATCH v3 2/7] Documentation: Document pm660(l) SPMI GPIOs compatible

2020-07-07 Thread Linus Walleij
On Mon, Jun 22, 2020 at 9:26 PM Konrad Dybcio wrote: > Signed-off-by: Konrad Dybcio Patch applied. Yours, Linus Walleij

Re: [mm] 4e2c82a409: ltp.overcommit_memory01.fail

2020-07-07 Thread Michal Hocko
On Tue 07-07-20 07:43:48, Qian Cai wrote: > > > > On Jul 7, 2020, at 6:28 AM, Michal Hocko wrote: > > > > Would you have any examples? Because I find this highly unlikely. > > OVERCOMMIT_NEVER only works when virtual memory is not largerly > > overcommited wrt to real memory demand. And that te

Re: [RFC PATCH for 5.8 3/4] rseq: Introduce RSEQ_FLAG_RELIABLE_CPU_ID

2020-07-07 Thread Mathieu Desnoyers
- On Jul 7, 2020, at 7:32 AM, Florian Weimer f...@deneb.enyo.de wrote: > * Mathieu Desnoyers: > >> Those are very good points. One possibility we have would be to let >> glibc do the rseq registration without the RSEQ_FLAG_RELIABLE_CPU_ID >> flag. On kernels with the bug present, the cpu_id f

Re: [PATCH 1/3] spi: spi-geni-qcom: Avoid clock setting if not needed

2020-07-07 Thread Mark Brown
On Wed, Jul 01, 2020 at 05:45:07PM -0700, Douglas Anderson wrote: > Every SPI transfer could have a different clock rate. The > spi-geni-qcom controller code to deal with this was never very well > optimized and has always had a lot of code plus some calls into the This doesn't apply against curr

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-07 Thread Richard Weinberger
- Ursprüngliche Mail - > Perhaps I misunderstood what commit 32fe905c17f001 ("ubifs: Fix > O_TMPFILE corner case in ubifs_link()") wanted to fix. > I think orphan area is used to remind filesystem don't forget to delete > inodes (whose nlink is 0) in next unclean rebooting. Generally, the f

Re: [PATCH v1 0/9] s390: implement and optimize vmemmap_free()

2020-07-07 Thread Heiko Carstens
On Fri, Jul 03, 2020 at 03:39:08PM +0200, David Hildenbrand wrote: > This series is based on the latest s390/features branch [1]. It implements > vmemmap_free(), consolidating it with vmem_add_range(), and optimizes it by > - Freeing empty page tables (now also done for idendity mapping). > - Handl

Re: [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500 PWM devices

2020-07-07 Thread Linus Walleij
On Mon, Jun 22, 2020 at 10:34 AM Lee Jones wrote: > As per 'struct mfd_cell ab8500_devs[]' there are not 1, but 3 PWM > devices on the AB8500. Until now, each of them have referenced > the same Device Tree node. This change ensures each device has > their own. > > Due to recent `dtc` checks [0]

Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL

2020-07-07 Thread Mike Rapoport
On Tue, Jul 07, 2020 at 01:54:54PM +0200, Michal Hocko wrote: > On Tue 07-07-20 13:59:15, Jia He wrote: > > This exports memory_add_physaddr_to_nid() for module driver to use. > > > > memory_add_physaddr_to_nid() is a fallback option to get the nid in case > > NUMA_NO_NID is detected. > > > > Sug

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Mark Brown
On Tue, Jul 07, 2020 at 06:56:53AM +, Harrosh, Boaz wrote: > Kees Cook wrote: > > I have struggled with this as well. The parts of speech change, and my > > grammar senses go weird. whitelist = adjective noun. allow-list = verb > > noun. verbing the adj/noun combo feels okay, but verbing a ver

Re: [PATCH v1 0/9] s390: implement and optimize vmemmap_free()

2020-07-07 Thread David Hildenbrand
On 07.07.20 14:08, Heiko Carstens wrote: > On Fri, Jul 03, 2020 at 03:39:08PM +0200, David Hildenbrand wrote: >> This series is based on the latest s390/features branch [1]. It implements >> vmemmap_free(), consolidating it with vmem_add_range(), and optimizes it by >> - Freeing empty page tables (

Re: [PATCH v3 1/1] watchdog: Add common nowayout parameter to booke_wdt driver

2020-07-07 Thread Timothy Myers
From: linux-watchdog-ow...@vger.kernel.org on behalf of Guenter Roeck Sent: Monday, July 6, 2020 5:18 PM To: Timothy Myers ; Wim Van Sebroeck ; linux-watch...@vger.kernel.org Cc: linux-kernel@vger.kernel.org ; David Boike Subject: Re: [PATCH v3 1/1] watchdog: Add common nowayout paramet

Re: [PATCH 1/1] ARM: dts: ux500: Supply nodes for the other 2 AB8500 PWM devices

2020-07-07 Thread Linus Walleij
On Tue, Jul 7, 2020 at 2:11 PM Linus Walleij wrote: > On Mon, Jun 22, 2020 at 10:34 AM Lee Jones wrote: > > > As per 'struct mfd_cell ab8500_devs[]' there are not 1, but 3 PWM > > devices on the AB8500. Until now, each of them have referenced > > the same Device Tree node. This change ensures e

Re: [RFC PROPOSAL] memcg: per-memcg user space reclaim interface

2020-07-07 Thread Michal Hocko
On Fri 03-07-20 07:23:14, Shakeel Butt wrote: > On Thu, Jul 2, 2020 at 11:35 PM Michal Hocko wrote: > > > > On Thu 02-07-20 08:22:22, Shakeel Butt wrote: > > [...] > > > Interface options: > > > -- > > > > > > 1) memcg interface e.g. 'echo 10M > memory.reclaim' > > > > > > + simple

Re: [PATCH] net: usb: qmi_wwan: add support for Quectel EG95 LTE modem

2020-07-07 Thread Bjørn Mork
AceLan Kao writes: > Add support for Quectel Wireless Solutions Co., Ltd. EG95 LTE modem > > T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 5 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=2c7c ProdID=0195 Rev=03.18 > S: Manufacturer=Android > S: Pr

Re: [PATCH RESEND v2] dt-bindings: pinctrl: Convert ingenic,pinctrl.txt to YAML

2020-07-07 Thread Linus Walleij
On Mon, Jun 22, 2020 at 1:38 PM Paul Cercueil wrote: > Convert the ingenic,pinctrl.txt doc file to ingenic,pinctrl.yaml. > > In the process, some compatible strings now require a fallback, as the > corresponding SoCs are pin-compatible with their fallback variant. > > Signed-off-by: Paul Cercueil

Re: [PATCH v4 05/11] mm/migrate: clear __GFP_RECLAIM for THP allocation for migration

2020-07-07 Thread Vlastimil Babka
On 7/7/20 9:44 AM, js1...@gmail.com wrote: > From: Joonsoo Kim > > In mm/migrate.c, THP allocation for migration is called with the provided > gfp_mask | GFP_TRANSHUGE. This gfp_mask contains __GFP_RECLAIM and it > would be conflict with the intention of the GFP_TRANSHUGE. > > GFP_TRANSHUGE/GFP_

Re: [PATCH 1/2] pinctrl: ingenic: Enhance support for IRQ_TYPE_EDGE_BOTH

2020-07-07 Thread Linus Walleij
On Mon, Jun 22, 2020 at 11:46 PM Paul Cercueil wrote: > Ingenic SoCs don't natively support registering an interrupt for both > rising and falling edges. This has to be emulated in software. > > Until now, this was emulated by switching back and forth between > IRQ_TYPE_EDGE_RISING and IRQ_TYPE_E

Re: [PATCH v6 4/7] pidfd: Replace open-coded partial receive_fd()

2020-07-07 Thread Christian Brauner
On Mon, Jul 06, 2020 at 01:17:17PM -0700, Kees Cook wrote: > The sock counting (sock_update_netprioidx() and sock_update_classid()) was > missing from pidfd's implementation of received fd installation. Replace > the open-coded version with a call to the new receive_fd() > helper. > > Thanks to Va

[RFC v2 3/5] perf jevents: Add support for parsing perchip/percore events

2020-07-07 Thread Kajol Jain
Added the "PerChip" field in enum so that perf knows they are per chip events. Added the "PerCore" field in enum so that perf knows they are per core events and add these fields to pmu_event structure. Similar to the way we had "PerPkg field to specify perpkg events. Signed-off-by: Kajol Jain

[RFC v2 1/5] perf/pmu-events/jevents: Add enum to store aggregation like PerPkg

2020-07-07 Thread Kajol Jain
Initially, every time we want to add new terms like chip, core, thread etc, we need to create corrsponding fields in pmu_events and event struct. This patch adds an enum called 'aggr_mode_class' which store all these aggregation like perpkg/percore. It also adds new field 'aggr_mode' to capture the

[RFC v2 0/5] tools/perf/pmu-events/jevents.c

2020-07-07 Thread Kajol Jain
Patchset enhance current runtime parameter support. It introduces new fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is used to specify perpkg events. The "PerCore" and "PerChip" specifies whether its core or chip events. Based on which we can decide which runtime paramet

[RFC v2 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam

2020-07-07 Thread Kajol Jain
This patch adds passing of pmu_event as a parameter in function 'arch_get_runtimeparam' which can be used to get details like if the event is percore/perchip. Signed-off-by: Kajol Jain --- tools/perf/arch/powerpc/util/header.c | 7 +-- tools/perf/util/metricgroup.c | 5 ++--- tools/

[RFC v2 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events

2020-07-07 Thread Kajol Jain
This patch adds hv_24x7 core level events in nest_metric.json file and also add PerChip/PerCore field in metric events. Result: power9 platform: command:# ./perf stat --metric-only -M PowerBUS_Frequency -C 0 -I 1000 1.706011.92.0 2.00

Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL

2020-07-07 Thread David Hildenbrand
On 07.07.20 14:13, Mike Rapoport wrote: > On Tue, Jul 07, 2020 at 01:54:54PM +0200, Michal Hocko wrote: >> On Tue 07-07-20 13:59:15, Jia He wrote: >>> This exports memory_add_physaddr_to_nid() for module driver to use. >>> >>> memory_add_physaddr_to_nid() is a fallback option to get the nid in case

[PATCH] dma-pool: use single atomic pool for both DMA zones

2020-07-07 Thread Nicolas Saenz Julienne
When allocating atomic DMA memory for a device, the dma-pool core queries __dma_direct_optimal_gfp_mask() to check which atomic pool to use. It turns out the GFP flag returned is only an optimistic guess. The pool selected might sometimes live in a zone higher than the device's view of memory. As

Re: [PATCH v6 0/2] sched: Optionally skip uclamp logic in fast path

2020-07-07 Thread Vincent Guittot
On Mon, 6 Jul 2020 at 12:41, Qais Yousef wrote: > > On 07/03/20 14:09, Vincent Guittot wrote: > > I have run the perf bench sched pipe that have have already run > > previously with this v6 and the results are similar to my previous > > tests: > > The impact is -1.61% similarly to v2 which is bett

[PATCH] staging: rtl8723bs: Using comparison to true is error prone

2020-07-07 Thread John Oldman
clear below issues reported by checkpatch.pl: CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 70 ++--- 1 file changed, 32 insertions(+), 38 deletions(-)

Re: [PATCH v2 0/2] gpio: aggregator: Misc parsing improvements

2020-07-07 Thread Linus Walleij
On Wed, Jul 1, 2020 at 1:42 PM Geert Uytterhoeven wrote: > This patch series contains two improvements for the parsing code in the > GPIO Aggregator. > > The second one converts the driver to use bitmap_parselist() for parsing > GPIO offsets and/or ranges, as suggested by Andy[1]. This should ha

Re: [PATCH 06/10] mfd: ab3100-core: Fix incompatible types in comparison expression warning

2020-07-07 Thread Linus Walleij
On Wed, Jun 24, 2020 at 5:07 PM Lee Jones wrote: > Smatch reports: > > drivers/mfd/ab3100-core.c:501:20: error: incompatible types in comparison > expression (different type sizes): > drivers/mfd/ab3100-core.c:501:20:unsigned int * > drivers/mfd/ab3100-core.c:501:20:unsigned long * >

[PATCH 2/2] powerpc/signal_32: Simplify loop in PPC64 save_general_regs()

2020-07-07 Thread Christophe Leroy
save_general_regs() which does special handling when i == PT_SOFTE. Rewrite it to minimise the specific part, especially the __put_user() and associated error handling is the same so make it common. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/signal_32.c | 13 - 1 file c

Re: [PATCH v2 1/6] iommu/arm-smmu: Add auxiliary domain support for arm-smmuv2

2020-07-07 Thread Robin Murphy
On 2020-06-26 21:04, Jordan Crouse wrote: Support auxiliary domains for arm-smmu-v2 to initialize and support multiple pagetables for a single SMMU context bank. Since the smmu-v2 hardware doesn't have any built in support for switching the pagetable base it is left as an exercise to the caller t

[PATCH 1/2] powerpc/signal_32: Remove !FULL_REGS() special handling in PPC64 save_general_regs()

2020-07-07 Thread Christophe Leroy
Since commit ("1bd79336a426 powerpc: Fix various syscall/signal/swapcontext bugs"), getting save_general_regs() called without FULL_REGS() is very unlikely and generates a warning. The 32-bit version of save_general_regs() doesn't take care of it at all and copies all registers anyway since that c

Re: [PATCH 07/10] mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue

2020-07-07 Thread Linus Walleij
On Wed, Jun 24, 2020 at 5:07 PM Lee Jones wrote: > Smatch reports: > > drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in > comparison expression (different type sizes): > drivers/mfd/ab8500-debugfs.c:1804:20:unsigned int * > drivers/mfd/ab8500-debugfs.c:1804:20:unsign

RE: objtool clac/stac handling change..

2020-07-07 Thread David Laight
From: Al Viro > Sent: 04 July 2020 03:12 ... > BTW, looking at csum_and_copy_{to,from}_user() callers (all 3 of them, > all in lib/iov_iter.c) we have this: > 1) len is never 0 > 2) sum (initial value of csum) is always 0 > 3) failure (reported via *err_ptr) is always treateds as

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-07 Thread Zhihao Cheng
在 2020/7/7 20:09, Richard Weinberger 写道: - Ursprüngliche Mail - Perhaps I misunderstood what commit 32fe905c17f001 ("ubifs: Fix O_TMPFILE corner case in ubifs_link()") wanted to fix. I think orphan area is used to remind filesystem don't forget to delete inodes (whose nlink is 0) in next

Re: [PATCH v6 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-07-07 Thread Qais Yousef
On 07/07/20 12:30, Valentin Schneider wrote: > > On 07/07/20 10:34, Qais Yousef wrote: > > On 07/06/20 16:49, Valentin Schneider wrote: > >> > >> On 06/07/20 15:28, Qais Yousef wrote: > >> > CC: linux-fsde...@vger.kernel.org > >> > --- > >> > > >> > Peter > >> > > >> > I didn't do the > >> > > >>

Re: [PATCH v6 5/7] fs: Expand __receive_fd() to accept existing fd

2020-07-07 Thread Christian Brauner
On Mon, Jul 06, 2020 at 01:17:18PM -0700, Kees Cook wrote: > Expand __receive_fd() with support for replace_fd() for the coming seccomp > "addfd" ioctl(). Add new wrapper receive_fd_replace() for the new behavior > and update existing wrappers to retain old behavior. > > Thanks to Colin Ian King

Re: [PATCH 03/10] mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc

2020-07-07 Thread Linus Walleij
On Thu, Jun 25, 2020 at 8:46 AM Lee Jones wrote: > Each function parameter should be documented in kerneldoc format. > > Squashes the following W=1 warnings: > > drivers/mfd/db8500-prcmu.c:2281: warning: Function parameter or member > 'reset_code' not described in 'db8500_prcmu_system_reset' >

Urgent Attention

2020-07-07 Thread Mr Anthony Ehimare
Good Day, I am Anthony Ehimare a banker I have something very important to discuss with you about an unpaid inheritance fund left in my bank for a long time by a late customer who has the same last name with you I do not know if he was a member of your family.The Lawyer that contacted you in the p

Re: [PATCH 04/10] mfd: db8500-prcmu: Remove incorrect function header from .probe() function

2020-07-07 Thread Linus Walleij
On Thu, Jun 25, 2020 at 8:46 AM Lee Jones wrote: > Not only is the current header incorrect, the isn't actually a > need to document the ubiquitous platform probe call. > > Cc: > Cc: Linus Walleij > Signed-off-by: Lee Jones Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 04/10] mfd: ab3100-otp: Add missing colon(s) for all documented kerneldoc arguments

2020-07-07 Thread Linus Walleij
On Thu, Jun 25, 2020 at 6:31 PM Lee Jones wrote: > Kerneldoc validation gets confused if syntax isn't "@.*: ". > > Adding the missing colons squashes the following W=1 warnings: > > drivers/mfd/ab3100-otp.c:60: warning: Function parameter or member 'dev' not > described in 'ab3100_otp' > drive

Re: [RESEND 05/10] regulator: ab8500: Remove unused embedded struct expand_register

2020-07-07 Thread Linus Walleij
On Thu, Jun 25, 2020 at 9:17 PM Lee Jones wrote: > Used primarily for the AB8540 which lost support in early 2018. > It is now deemed safe to remove this legacy data structure. > > Also fixes W=1 issue: > > drivers/regulator/ab8500.c:88: warning: Function parameter or member > 'expand_register

<    1   2   3   4   5   6   7   8   9   10   >