[PATCH] Security: Documentation: fix: `make htmldocs` warnings

2020-07-06 Thread Puranjay Mohan
Remove extra ')' after function name to fix warnings. It solves following warning : WARNING: Unparseable C cross-reference: 'groups_sort)' Invalid C declaration: Expected end of definition. [error at 11] Signed-off-by: Puranjay Mohan --- Documentation/security/credentials.rst | 2 +- 1 file chan

Re: [PATCH 2/3] Linux: Use rseq in sched_getcpu if available (v9)

2020-07-06 Thread Mathieu Desnoyers
- On Jul 6, 2020, at 1:50 PM, Florian Weimer fwei...@redhat.com wrote: > * Mathieu Desnoyers: > >> Now we need to discuss how we introduce that fix in a way that will >> allow user-space to trust the __rseq_abi.cpu_id field's content. > > I don't think that's necessary. We can mention it in

Re: [PATCH] pinctrl: initialise nsp-mux earlier.

2020-07-06 Thread Ray Jui
On 6/30/2020 9:44 PM, Florian Fainelli wrote: > > > On 6/30/2020 9:37 PM, Mark Tomlinson wrote: >> On Tue, 2020-06-30 at 20:14 -0700, Florian Fainelli wrote: >>> Sorry, it looks like I made a mistake in my testing (or I was lucky), and this patch doesn't fix the issue. What is happening i

Re: [PATCH V5 0/4] Signaling api support in glink/rpmsg clients

2020-07-06 Thread Mathieu Poirier
Hi Deepak, On Fri, Jun 26, 2020 at 08:16:55PM +0530, Deepak Kumar Singh wrote: > Change from version 5 > [V5,4/4] rpmsg: char: Add signal callback and POLLPRI support > Updated for sparse warning. Replaced POLLPRI => EPOLLPRI to fix > warning. > > Change from version 4 > I am taking over these pa

Re: [PATCH] tpm: Define TPM2_SPACE_BUFFER_SIZE to replace the use of PAGE_SIZE

2020-07-06 Thread Stefan Berger
On 7/3/20 11:56 PM, Jarkko Sakkinen wrote: On Thu, Jul 02, 2020 at 04:55:44PM -0700, Jerry Snitselaar wrote: On Fri Jul 03 20, Jarkko Sakkinen wrote: The size of the buffers for storing context's and sessions can vary from arch to arch as PAGE_SIZE can be anything between 4 kB and 256 kB (the m

Re: [PATCH v2] pinctrl: nsp: Set irq handler based on trig type

2020-07-06 Thread Ray Jui
Hi Mark, On 7/2/2020 6:18 PM, Mark Tomlinson wrote: > Rather than always using handle_simple_irq() as the gpio_irq_chip > handler, set a more appropriate handler based on the IRQ trigger type > requested. This is important for level triggered interrupts which need > to be masked during handling. A

[PATCH v2 0/3] Few bug fixes and Convert to pin_user_pages*()

2020-07-06 Thread Souptick Joarder
This series contains few clean up, minor bug fixes and Convert get_user_pages() to pin_user_pages(). I'm compile tested this, but unable to run-time test, so any testing help is much appriciated. v2: Addressed few review comments and compile issue. Patch[1/2] from v1 split into 2

Re: [PATCH 1/2] x86: Expose SERIALIZE for supported cpuid

2020-07-06 Thread kernel test robot
Hi Cathy, Thank you for the patch! Yet something to improve: [auto build test ERROR on kvm/linux-next] [also build test ERROR on tip/auto-latest linux/master linus/master v5.8-rc4 next-20200706] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[PATCH v2 2/3] xen/privcmd: Mark pages as dirty

2020-07-06 Thread Souptick Joarder
pages need to be marked as dirty before unpinned it in unlock_pages() which was oversight. This is fixed now. Signed-off-by: Souptick Joarder Suggested-by: John Hubbard Cc: John Hubbard Cc: Boris Ostrovsky Cc: Paul Durrant --- drivers/xen/privcmd.c | 5 - 1 file changed, 4 insertions(+),

[PATCH v2 3/3] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()

2020-07-06 Thread Souptick Joarder
In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. This is case 5 as per document [1]. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages":

[PATCH v2 1/3] xen/privcmd: Corrected error handling path

2020-07-06 Thread Souptick Joarder
Previously, if lock_pages() end up partially mapping pages, it used to return -ERRNO due to which unlock_pages() have to go through each pages[i] till *nr_pages* to validate them. This can be avoided by passing correct number of partially mapped pages & -ERRNO separately, while returning from lock_

Re: [PATCH] arm64: tegra: Re-order PCIe aperture mappings

2020-07-06 Thread Jon Hunter
On 06/07/2020 18:14, Vidya Sagar wrote: > Re-order Tegra194's PCIe aperture mappings to have IO window moved to > 64-bit aperture and have the entire 32-bit aperture used for accessing > the configuration space. This makes it to use the entire 32MB of the 32-bit > aperture for ECAM purpose while

Re: [PATCH 2/3] Linux: Use rseq in sched_getcpu if available (v9)

2020-07-06 Thread Florian Weimer
* Mathieu Desnoyers: > - On Jul 6, 2020, at 1:50 PM, Florian Weimer fwei...@redhat.com wrote: > >> * Mathieu Desnoyers: >> >>> Now we need to discuss how we introduce that fix in a way that will >>> allow user-space to trust the __rseq_abi.cpu_id field's content. >> >> I don't think that's n

PHY reset handling during DT parsing

2020-07-06 Thread Maxime Ripard
Hi, I came across an issue today on an Allwinner board, but I believe it's a core issue. That board is using the stmac driver together with a phy that happens to have a reset GPIO, except that that GPIO will never be claimed, and the PHY will thus never work. You can find an example of such a bo

Re: [PATCH] Security: Documentation: fix: `make htmldocs` warnings

2020-07-06 Thread Jonathan Corbet
On Mon, 6 Jul 2020 23:30:10 +0530 Puranjay Mohan wrote: > Remove extra ')' after function name to fix warnings. > It solves following warning : > WARNING: Unparseable C cross-reference: 'groups_sort)' > Invalid C declaration: Expected end of definition. [error at 11] > > Signed-off-by: Puranjay

Re: [Linux v5.8-rc4] objtool warnings with gcc-10

2020-07-06 Thread Sedat Dilek
On Mon, Jul 6, 2020 at 10:39 AM Peter Zijlstra wrote: > > On Mon, Jul 06, 2020 at 09:09:55AM +0200, Sedat Dilek wrote: > > [ Please CC me I am not subscribed to this mailing-list ] > > > > Hi Josh and Peter, > > > > today I switched over from Linux v5.7.y to Linux v5.8-rc4 and built > > the first

Re: [PATCH] kbuild: introduce ccflags-remove-y and asflags-remove-y

2020-07-06 Thread Masahiro Yamada
Hi Anders, On Mon, Jul 6, 2020 at 8:24 PM Anders Roxell wrote: > > The full log can be found here [1]. > > Without this patch for 'trace_selftest_dynamic' for instance, CC_FLAGS_FTRACE > was removed from kernel/trace/*, and then added back to > kernel/trace/trace_selftest_dynamic. > While with

drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_generic.c:121:2: note: in expansion of macro 'if'

2020-07-06 Thread kernel test robot
-20200706 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout

[PATCH v9 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

2020-07-06 Thread Stefan Berger
From: Stefan Berger This series of patches adds an optional extensions for the TPM2 ACPI table with additional fields found in the TPM2 TCG ACPI specification (reference is in the patch) that allow access to the log's address and its size. We then modify the code that so far only enables access t

[PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-06 Thread Stefan Berger
From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area. This allows non-UEFI systems, such as SeaBIOS, to pass an event log when using a TPM2. Signed-off-by: Stef

[PATCH v9 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-07-06 Thread Stefan Berger
From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we define a new structure acpi_tpm2_phy that holds these optional new fields. The new fie

[PATCH v3 3/6] x86/asm: add enqcmds() to support ENQCMDS instruction

2020-07-06 Thread Dave Jiang
Currently, the MOVDIR64B instruction is used to atomically submit 64-byte work descriptors to devices. Although it can encounter errors like faults, MOVDIR64B can not report back on errors from the device itself. This means that MOVDIR64B users need to separately interact with a device to see if a

[PATCH v3 0/6] Add shared workqueue support for idxd driver

2020-07-06 Thread Dave Jiang
V3: - Rebased against latest dmaengine/next tree. - Updated API doc with new kernel version and dates. - Changed to allow driver to load without ENQCMD support. - Break out some patches that can be sent ahead of this series for inclusion. v2: - Dropped device feature enabling (GregKH) - Dropped PC

[PATCH v3 2/6] x86/asm: move the raw asm in iosubmit_cmds512() to special_insns.h

2020-07-06 Thread Dave Jiang
The MOVDIR64B instruction can be used by other wrapper instructions. Move the core asm code to special_insns.h and have iosubmit_cmds512() call the core asm function. Signed-off-by: Dave Jiang Reviewed-by: Tony Luck --- arch/x86/include/asm/io.h| 17 +++-- arch/x86/inc

Re: [PATCH] Security: Documentation: fix: `make htmldocs` warnings

2020-07-06 Thread Puranjay Mohan
On Mon, Jul 6, 2020 at 11:44 PM Jonathan Corbet wrote: > > On Mon, 6 Jul 2020 23:30:10 +0530 > Puranjay Mohan wrote: > > > Remove extra ')' after function name to fix warnings. > > It solves following warning : > > WARNING: Unparseable C cross-reference: 'groups_sort)' > > Invalid C declaration:

[PATCH v3 5/6] dmaengine: idxd: clean up descriptors with fault error

2020-07-06 Thread Dave Jiang
Add code to "complete" a descriptor when the descriptor or its completion address hit a fault error when SVA mode is being used. This error can be triggered due to bad programming by the user. A lock is introduced in order to protect the descriptor completion lists since the fault handler will run

[PATCH v3 4/6] dmaengine: idxd: add shared workqueue support

2020-07-06 Thread Dave Jiang
Add shared workqueue support that includes the support of Shared Virtual memory (SVM) or in similar terms On Demand Paging (ODP). The shared workqueue uses the enqcmds command in kernel and will respond with retry if the workqueue is full. Shared workqueue only works when there is PASID support fro

[PATCH v3 1/6] x86/cpufeatures: Enumerate ENQCMD and ENQCMDS instructions

2020-07-06 Thread Dave Jiang
From: Fenghua Yu Work submission instruction comes in two flavors. ENQCMD can be called both in ring 3 and ring 0 and always uses the contents of PASID MSR when shipping the command to the device. ENQCMDS allows a kernel driver to submit commands on behalf of a user process. The driver supplies t

[PATCH v3 6/6] dmaengine: idxd: add ABI documentation for shared wq

2020-07-06 Thread Dave Jiang
Add the sysfs attribute bits in ABI/stable for shared wq support. Signed-off-by: Jing Lin Signed-off-by: Dave Jiang Reviewed-by: Tony Luck Reviewed-by: Dan Williams --- Documentation/ABI/stable/sysfs-driver-dma-idxd | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documen

Re: [PATCH 3/5] net: fec: initialize clock with 0 rather than current kernel time

2020-07-06 Thread Sergey Organov
Vladimir Oltean writes: > Hi Sergey, > > On Mon, Jul 06, 2020 at 05:26:14PM +0300, Sergey Organov wrote: >> Initializing with 0 makes it much easier to identify time stamps from >> otherwise uninitialized clock. >> >> Initialization of PTP clock with current kernel time makes little sense as >>

[PATCH v2] ARM: stacktrace: Fix unwind_frame for clang-built kernels

2020-07-06 Thread Nathan Huckleberry
Since clang does not push pc and sp in function prologues, the current implementation of unwind_frame does not work. By using the previous frame's lr/fp instead of saved pc/sp we get valid unwinds on clang-built kernels. The bounds check on next frame pointer must be changed as well since there ar

Re: [PATCH] media: uvcvideo: Ensure all probed info is returned to v4l2

2020-07-06 Thread Adam Goode
On Fri, Apr 24, 2020 at 1:37 AM Adam Goode wrote: > > bFrameIndex and bFormatIndex can be negotiated by the camera during > probing, resulting in the camera choosing a different format than > expected. v4l2 can already accommodate such changes, but the code was > not updating the proper fields. >

next/master bisection: baseline.login on qemu_arm64-virt-gicv3

2020-07-06 Thread kernelci.org bot
this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/master bisection: baseline.login on qemu_arm64-virt-gicv3 Summary: Start: 5680d14d59bd Add linux-next specific files for 20200706 Plain log: https://storage.ke

Re: [PATCH 00/22] add support for Clang LTO

2020-07-06 Thread Peter Zijlstra
On Mon, Jul 06, 2020 at 09:26:33AM -0700, Paul E. McKenney wrote: > And perhaps more constructively, we do need to prioritize address and data > dependencies over control dependencies. For one thing, there are a lot > more address/data dependencies in existing code than there are control > depend

Re: [Tech-board-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Shuah Khan
On 7/4/20 2:02 PM, Dan Williams wrote: Recent events have prompted a Linux position statement on inclusive terminology. Given that Linux maintains a coding-style and its own idiomatic set of terminology here is a proposal to answer the call to replace non-inclusive terminology. Hi Dan, Thanks

Re: [LKP] [xfs] a5949d3fae: aim7.jobs-per-min -33.6% regression

2020-07-06 Thread Darrick J. Wong
On Wed, Jul 01, 2020 at 03:49:52PM +0800, Xing Zhengjun wrote: > > > On 6/10/2020 11:07 AM, Xing Zhengjun wrote: > > Hi Darrick, > > > >    Do you have time to take a look at this? Thanks. > > > > > Ping... Yes, that decrease is the expected end result of making the write path take a longer

clone302.c:88: FAIL: invalid parenttid: clone3() should fail with EFAULT: EINVAL (22)

2020-07-06 Thread Naresh Kamboju
LTP clone302 test case failed on linux next 20200706 tag. This is a regression on arm64, arm, x86_64, and i386. The expected error code is EFAULT but got EINVAL. This is already addressed here in this email thread by Christian Brauner https://lore.kernel.org/linux-m68k/20200627122332

Re: [PATCH 1/5] net: fec: properly support external PTP PHY for hardware time stamping

2020-07-06 Thread Sergey Organov
Vladimir Oltean writes: > On Mon, Jul 06, 2020 at 06:21:59PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> > Hi Sergey, >> > >> > On Mon, Jul 06, 2020 at 05:26:12PM +0300, Sergey Organov wrote: >> >> When external PTP-aware PHY is in use, it's that PHY that is to time >> >> stamp

[PATCH] thermal: ti-soc-thermal: Fix bogus thermal shutdowns for omap4430

2020-07-06 Thread Tony Lindgren
We can sometimes get bogus thermal shutdowns on omap4430 at least with droid4 running idle with a battery charger connected: thermal thermal_zone0: critical temperature reached (143 C), shutting down Dumping out the register values shows we can occasionally get a 0x7f value that is outside the TR

[PATCH v1] Security: Documentation: Replace deprecated :c:func: Usage

2020-07-06 Thread Puranjay Mohan
Replace :c:func: with ``func()`` as the previous usage is deprecated. Remove an extra ')' to fix broken cross reference. Signed-off-by: Puranjay Mohan --- V1: Change the subject line and remove deprecated :c:func: usage --- Documentation/security/credentials.rst | 6 +++--- 1 file changed, 3 ins

Re: [PATCH 18/18] arm64: lto: Strengthen READ_ONCE() to acquire when CLANG_LTO=y

2020-07-06 Thread Will Deacon
On Mon, Jul 06, 2020 at 05:08:20PM +0100, Dave Martin wrote: > On Tue, Jun 30, 2020 at 06:37:34PM +0100, Will Deacon wrote: > > diff --git a/arch/arm64/include/asm/rwonce.h > > b/arch/arm64/include/asm/rwonce.h > > new file mode 100644 > > index ..515e360b01a1 > > --- /dev/null > > +++

Re: [PATCH 18/18] arm64: lto: Strengthen READ_ONCE() to acquire when CLANG_LTO=y

2020-07-06 Thread Will Deacon
On Mon, Jul 06, 2020 at 05:00:23PM +0100, Dave Martin wrote: > On Thu, Jul 02, 2020 at 08:23:02AM +0100, Will Deacon wrote: > > On Wed, Jul 01, 2020 at 06:07:25PM +0100, Dave P Martin wrote: > > > Also, can you illustrate code that can only be unsafe with Clang LTO? > > > > I don't have a concrete

Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages

2020-07-06 Thread Harry Cutts
On Sun, 5 Jul 2020 at 10:09, Maciej S. Szmigiero wrote: > > These messages appear each time the mouse wakes from sleep, in my case > (Logitech M705), every minute or so. > Let's downgrade them to the "debug" level so they don't fill the kernel log > by default. > > While we are at it, let's make c

Re: [PATCH -next] smp: Make symbol 'csd_bug_count' static

2020-07-06 Thread Paul E. McKenney
On Mon, Jul 06, 2020 at 09:49:41PM +0800, Wei Yongjun wrote: > The sparse tool complains as follows > > kernel/smp.c:107:10: warning: > symbol 'csd_bug_count' was not declared. Should it be static? > > This variable is not used outside of smp.c, s this commit marks > it static. > > Reported-by:

Re: [PATCH v3 0/6] powerpc: queued spinlocks and rwlocks

2020-07-06 Thread Waiman Long
On 7/6/20 12:35 AM, Nicholas Piggin wrote: v3 is updated to use __pv_queued_spin_unlock, noticed by Waiman (thank you). Thanks, Nick Nicholas Piggin (6): powerpc/powernv: must include hvcall.h to get PAPR defines powerpc/pseries: move some PAPR paravirt functions to their own file powe

[PATCH] mfd: motorola-cpcap: Disable interrupt for suspend

2020-07-06 Thread Tony Lindgren
Otherwise we get spammed with errors on resume after rtcwake: cpcap-core spi0.0: Failed to read IRQ status: -108 Note that rtcwake is still capable of waking up the system with this patch. Cc: Merlijn Wajer Cc: Pavel Machek Cc: Sebastian Reichel Signed-off-by: Tony Lindgren --- This has alw

Re: [PATCH v1] Security: Documentation: Replace deprecated :c:func: Usage

2020-07-06 Thread Jonathan Corbet
On Tue, 7 Jul 2020 00:04:37 +0530 Puranjay Mohan wrote: > Replace :c:func: with ``func()`` as the previous usage is deprecated. > Remove an extra ')' to fix broken cross reference. > > Signed-off-by: Puranjay Mohan > --- > V1: Change the subject line and remove deprecated :c:func: usage > ---

Re: [PATCH net-next v2 3/3] net: ethtool: Remove PHYLIB direct dependency

2020-07-06 Thread Jakub Kicinski
On Sun, 5 Jul 2020 21:27:58 -0700 Florian Fainelli wrote: > + ops = ethtool_phy_ops; > + if (!ops || !ops->start_cable_test) { nit: don't think member-by-member checking is necessary. We don't expect there to be any alternative versions of the ops, right? > + ret = -EOPNOTSUP

Re: [PATCH 00/22] add support for Clang LTO

2020-07-06 Thread Paul E. McKenney
On Mon, Jul 06, 2020 at 08:29:26PM +0200, Peter Zijlstra wrote: > On Mon, Jul 06, 2020 at 09:26:33AM -0700, Paul E. McKenney wrote: > > > And perhaps more constructively, we do need to prioritize address and data > > dependencies over control dependencies. For one thing, there are a lot > > more

Re: [PATCH v3 6/6] Documentation: Describe console mouse reporting

2020-07-06 Thread Randy Dunlap
On 7/6/20 4:00 AM, Tammo Block wrote: > This patch adds a description of the kernel interface(s) used for vt > console mouse reporting and describes the protocols and bitmasks. > > Signed-off-by: Tammo Block > --- > .../admin-guide/console-mouse-reporting.rst | 88 +++ > Docume

Re: [EXTERNAL] Re: [PATCH v15 2/4] dt-bindings: power: Convert battery.txt to battery.yaml

2020-07-06 Thread Ricardo Rivera-Matos
Rob On 7/2/20 3:53 PM, Rob Herring wrote: On Wed, 01 Jul 2020 16:10:42 -0500, Ricardo Rivera-Matos wrote: From: Dan Murphy Convert the battery.txt file to yaml and fix up the examples. Signed-off-by: Dan Murphy --- .../bindings/power/supply/battery.txt | 86 +- .../bindi

Re: [PATCH net-next v2 3/3] net: ethtool: Remove PHYLIB direct dependency

2020-07-06 Thread Florian Fainelli
On 7/6/2020 11:40 AM, Jakub Kicinski wrote: > On Sun, 5 Jul 2020 21:27:58 -0700 Florian Fainelli wrote: >> +ops = ethtool_phy_ops; >> +if (!ops || !ops->start_cable_test) { > > nit: don't think member-by-member checking is necessary. We don't > expect there to be any alternative versio

Re: next/master bisection: baseline.login on qemu_arm64-virt-gicv3

2020-07-06 Thread Dave Jiang
files for 20200706 Plain log: https://storage.kernelci.org/next/master/next-20200706/arm64/defconfig+CONFIG_RANDOMIZE_BASE=y/gcc-8/lab-collabora/baseline-qemu_arm64-virt-gicv3.txt HTML log: https://storage.kernelci.org/next/master/next-20200706/arm64/defconfig+CONFIG_RANDOMIZE_BASE=y

Re: [PATCH v2 2/7] PCI: Set "untrusted" flag for truly external devices only

2020-07-06 Thread Greg Kroah-Hartman
On Mon, Jul 06, 2020 at 11:41:26AM -0500, Bjorn Helgaas wrote: > On Tue, Jun 30, 2020 at 09:55:54AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 29, 2020 at 09:49:38PM -0700, Rajat Jain wrote: > > > The "ExternalFacing" devices (root ports) are still internal devices that > > > sit on the inter

[PATCH v2] Security: Documentation: Replace deprecated :c:func: Usage

2020-07-06 Thread Puranjay Mohan
Replace :c:func: with ``func()`` as the previous usage is deprecated. Remove an extra ')' to fix broken cross reference. Signed-off-by: Puranjay Mohan --- V2: Remove ``quotes`` around function names V1: Change the subject line and remove deprecated :c:func: usage --- Documentation/security/crede

Re: [kernel/smp] 5408b78b7a: BUG:KASAN:out-of-bounds_in_c

2020-07-06 Thread Qian Cai
On Sun, Jul 05, 2020 at 10:37:03AM -0700, Paul E. McKenney wrote: > Good catch, but someone beat you to it. This commit contains the fix: > > 0504bc41a62c ("kernel/smp: Provide CSD lock timeout diagnostics") Well, I can still reproduce this on next-20200706 which co

Re: [PATCH] bpf: lsm: Disable or enable BPF LSM at boot time

2020-07-06 Thread Daniel Borkmann
On 7/6/20 6:57 PM, Lorenzo Fontana wrote: This option adds a kernel parameter 'bpf_lsm', which allows the BPF LSM to be disabled at boot. The purpose of this option is to allow a single kernel image to be distributed with the BPF LSM built in, but not necessarily enabled. Signed-off-by: Lorenzo

Re: [PATCH] platform/chrome: cros_ec_proto: Convert EC error codes to Linux error codes

2020-07-06 Thread Prashant Malani
Hi Guenter, On Sat, Jul 04, 2020 at 07:26:07AM -0700, Guenter Roeck wrote: > The EC reports a variety of error codes. Most of those, with the exception > of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the actual > error code gets lost. Convert all EC errors to Linux error codes to

Re: [PATCH net-next v2 3/3] net: ethtool: Remove PHYLIB direct dependency

2020-07-06 Thread Jakub Kicinski
On Mon, 6 Jul 2020 11:45:38 -0700 Florian Fainelli wrote: > On 7/6/2020 11:40 AM, Jakub Kicinski wrote: > > On Sun, 5 Jul 2020 21:27:58 -0700 Florian Fainelli wrote: > >> + ops = ethtool_phy_ops; > >> + if (!ops || !ops->start_cable_test) { > > > > nit: don't think member-by-member checking

Re: [PATCH v3 6/6] dmaengine: idxd: add ABI documentation for shared wq

2020-07-06 Thread Dave Hansen
On 7/6/20 11:22 AM, Dave Jiang wrote: > +What:/sys/bus/dsa/devices/dsa/pasid_enabled > +Date:Jul 5, 2020 > +KernelVersion: 5.9.0 > +Contact: dmaeng...@vger.kernel.org > +Description: To indicate if PASID (process address space identifier) is > +

Re: [PATCH] ARM: dts: socfpga: Align L2 cache-controller nodename with dtschema

2020-07-06 Thread Dinh Nguyen
On 6/26/20 3:06 AM, Krzysztof Kozlowski wrote: > Fix dtschema validator warnings like: > l2-cache@f000: $nodename:0: > 'l2-cache@f000' does not match > '^(cache-controller|cpu)(@[0-9a-f,]+)*$' > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/socfpga.dtsi

Re: [PATCH] arm64: dts: spcfpga: Align GIC, NAND and UART nodenames with dtschema

2020-07-06 Thread Dinh Nguyen
On 6/29/20 3:16 AM, Krzysztof Kozlowski wrote: > Fix dtschema validator warnings like: > intc@fffc1000: $nodename:0: > 'intc@fffc1000' does not match '^interrupt-controller(@[0-9a-f,]+)*$' > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/altera/socfpga_stratix10.

Re: [PATCH] bpf: lsm: Disable or enable BPF LSM at boot time

2020-07-06 Thread KP Singh
On Mon, Jul 6, 2020 at 8:51 PM Daniel Borkmann wrote: > > On 7/6/20 6:57 PM, Lorenzo Fontana wrote: > > This option adds a kernel parameter 'bpf_lsm', > > which allows the BPF LSM to be disabled at boot. > > The purpose of this option is to allow a single kernel > > image to be distributed with th

arch/arm64/kernel/efi.c:88:21: sparse: sparse: cast to non-scalar

2020-07-06 Thread kernel test robot
-20200706 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.2-14

Re: [PATCH v3 8/9] vfio/fsl-mc: trigger an interrupt via eventfd

2020-07-06 Thread kernel test robot
Hi Diana, I love your patch! Perhaps something to improve: [auto build test WARNING on vfio/next] [also build test WARNING on linux/master linus/master v5.8-rc4 next-20200706] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as

[PATCH] Replace HTTP links with HTTPS ones: Ext4

2020-07-06 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH] Replace HTTP links with HTTPS ones: LKMM

2020-07-06 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [Tech-board-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Mark Brown
On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: > +'blacklist'. Recommended replacements for 'slave' are: 'secondary', > +'subordinate', 'replica', 'responder', 'follower', 'proxy', or I'd second the suggestion of device as an option here. > +Of course it is around this point someo

Re: [PATCH v2] drivers/net/wan/lapbether: Fixed the value of hard_header_len

2020-07-06 Thread David Miller
From: Xie He Date: Sun, 5 Jul 2020 17:45:21 -0700 > When this driver transmits data, > first this driver will remove a pseudo header of 1 byte, > then the lapb module will prepend the LAPB header of 2 or 3 bytes, > then this driver will prepend a length field of 2 bytes, > then the under

Re: [PATCH 1/2] rkvdec: h264: Refuse to decode unsupported bitstream

2020-07-06 Thread Ezequiel Garcia
On Mon, 2020-07-06 at 09:45 +, Jonas Karlman wrote: > On 2020-06-26 19:11, Ezequiel Garcia wrote: > > The hardware only supports 4:2:2, 4:2:0 or 4:0:0 (monochrome), > > 8-bit or 10-bit depth content. > > > > Verify that the PPS refers to a supported bitstream, and refuse > > This should be SP

Re: [PATCH 18/18] arm64: lto: Strengthen READ_ONCE() to acquire when CLANG_LTO=y

2020-07-06 Thread Marco Elver
On Mon, 6 Jul 2020 at 20:35, Will Deacon wrote: > On Mon, Jul 06, 2020 at 05:00:23PM +0100, Dave Martin wrote: > > On Thu, Jul 02, 2020 at 08:23:02AM +0100, Will Deacon wrote: > > > On Wed, Jul 01, 2020 at 06:07:25PM +0100, Dave P Martin wrote: > > > > Also, can you illustrate code that can only b

Re: [PATCH v1 0/3] ethernet: sun: use generic power management

2020-07-06 Thread David Miller
From: Vaibhav Gupta Date: Mon, 6 Jul 2020 14:27:43 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from sun ethernet drivers. > > The callbacks performing suspend() and resume() operations are

Re: [PATCH net-next 01/12] switchdev: mrp: Extend switchdev API for MRP Interconnect

2020-07-06 Thread David Miller
From: Horatiu Vultur Date: Mon, 6 Jul 2020 11:18:31 +0200 > +/* SWITCHDEV_OBJ_ID_IN_TEST_MRP */ > +struct switchdev_obj_in_test_mrp { > + struct switchdev_obj obj; > + /* The value is in us and a value of 0 represents to stop */ > + u32 interval; > + u8 max_miss; > + u32 in_id

Re: [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen

2020-07-06 Thread Ilya K
(sorry for resending - the previous message got sent as HTML and bounced off the mailing list) This actually made me retest it just now - it most definitely works, both by tapping and by actually clicking the button. 06.07.2020, 20:22, "Lyude Paul" : > FWIW it's not placebo, it's why I always i

Re: [PATCH net-next 02/12] bridge: uapi: mrp: Extend MRP attributes for MRP interconnect

2020-07-06 Thread David Miller
From: Horatiu Vultur Date: Mon, 6 Jul 2020 11:18:32 +0200 > +struct br_mrp_in_state { > + __u16 in_id; > + __u32 in_state; > +}; Put the __u32 first then the __u16. > +struct br_mrp_in_role { > + __u16 in_id; > + __u32 ring_id; > + __u32 in_role; > + __u32 i_ifindex; > +

Re: [RFC PATCH 00/10] Netronix embedded controller driver for Kobo and Tolino ebook readers

2020-07-06 Thread Andreas Kemnade
On Sat, 4 Jul 2020 22:58:08 +0200 Jonathan Neuschäfer wrote: > On Tue, Jun 30, 2020 at 10:14:47PM +0200, Andreas Kemnade wrote: > > On Tue, 30 Jun 2020 09:15:23 +0200 > > Jonathan Neuschäfer wrote: > > > > > On Tue, Jun 30, 2020 at 08:40:51AM +0200, Andreas Kemnade wrote: > > > [...] > > >

Re: [PATCH v5 4/7] pidfd: Replace open-coded partial fd_install_received()

2020-07-06 Thread Kees Cook
On Mon, Jul 06, 2020 at 06:12:45PM +0200, Christian Brauner wrote: > On Mon, Jul 06, 2020 at 08:34:06AM -0700, Kees Cook wrote: > > Yup, this was a mistake in my refactoring of the pidfs changes. > > I already did. Er, what? (I had a typo in my quote: s/pidfs/pidfd/.) I was trying to say that thi

Re: [PATCH] hwmon:max6697: Allow max6581 to create tempX_offset

2020-07-06 Thread Guenter Roeck
On Mon, Jul 06, 2020 at 05:54:33PM +, Chu Lin wrote: > Per max6581, reg 4d and reg 4e is used for temperature read offset. > This patch will let the user specify the temperature read offset for > max6581. This patch is tested on max6581 and only applies to max6581. > Please version your patch

Re: [PATCH net 0/4] net: hns3: fixes for -net

2020-07-06 Thread David Miller
From: Huazhong Tan Date: Mon, 6 Jul 2020 19:25:58 +0800 > There are some fixes about reset issue and a use-after-free > of self-test. Series applied, thank you.

Re: [PATCH v9 11/15] perf stat: implement control commands handling

2020-07-06 Thread Jiri Olsa
On Mon, Jul 06, 2020 at 05:47:54PM +0300, Alexey Budankov wrote: > > On 06.07.2020 15:34, Jiri Olsa wrote: > > On Fri, Jul 03, 2020 at 10:47:22AM +0300, Alexey Budankov wrote: > >> > >> Implement handling of 'enable' and 'disable' control commands > >> coming from control file descriptor. process_

[PATCH 0/2][RFC] Makes sd->flags sysctl writable

2020-07-06 Thread Chen Yu
It was found that recently the flags of sched domain could not be customized via sysctl, which might make it a little inconenient for performance tuning/debugging. echo 343 > /proc/sys/kernel/sched_domain/cpu0/domain0/flags bash: flags: Permission denied 343 stands for: (SD_BALANCE_NEWIDLE SD_BAL

[PATCH 2/2][RFC] sched/debug: Make sd->flags sysctl writable again

2020-07-06 Thread Chen Yu
The flags of sched domain in sysctl was limited to read-only in a recent change. However this might bring inconvenience to some performance tuning/function test which are sensitive to load balance. Since the user might want to evaluate the impact of different combination of sched domain flags on th

[PATCH 1/2][RFC] sched/topology: Add update_domain_cpu()

2020-07-06 Thread Chen Yu
Introduce update_domain_cpu(), which is a wrapper of update_top_cache_domain(). In update_domain_cpu() the cpu hotplug lock is to protect against the rebuild of sched domain, and the rcu read lock is to protect against the dereference of domain tree(rq->sd) in update_top_cache_domain(). This patch

[PATCH] net: sfp: Unique GPIO interrupt names

2020-07-06 Thread Chris Healy
Dynamically generate a unique GPIO interrupt name, based on the device name and the GPIO name. For example: 103: 0 sx1503q 12 Edge sff2-los 104: 0 sx1503q 13 Edge sff3-los The sffX indicates the SFP the loss of signal GPIO is associated with. Signed-off-by: Chr

Re: [PATCH 00/22] add support for Clang LTO

2020-07-06 Thread Peter Zijlstra
On Mon, Jul 06, 2020 at 11:39:33AM -0700, Paul E. McKenney wrote: > On Mon, Jul 06, 2020 at 08:29:26PM +0200, Peter Zijlstra wrote: > > On Mon, Jul 06, 2020 at 09:26:33AM -0700, Paul E. McKenney wrote: > > If they do not consider their Linux OS running correctly :-) > > Many of them really do not

Re: [PATCH] platform/chrome: cros_ec_proto: Convert EC error codes to Linux error codes

2020-07-06 Thread Guenter Roeck
On Mon, Jul 06, 2020 at 11:52:30AM -0700, Prashant Malani wrote: > Hi Guenter, > > On Sat, Jul 04, 2020 at 07:26:07AM -0700, Guenter Roeck wrote: > > The EC reports a variety of error codes. Most of those, with the exception > > of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the a

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-06 Thread Joel Fernandes
On Thu, Jul 02, 2020 at 09:45:06PM +0200, Uladzislau Rezki wrote: > On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > > On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > > > This is not going to work together with the "wait context validator" > > > > (CONFIG_PRO

Re: [PATCH 18/18] arm64: lto: Strengthen READ_ONCE() to acquire when CLANG_LTO=y

2020-07-06 Thread Paul E. McKenney
On Mon, Jul 06, 2020 at 09:23:26PM +0200, Marco Elver wrote: > On Mon, 6 Jul 2020 at 20:35, Will Deacon wrote: > > On Mon, Jul 06, 2020 at 05:00:23PM +0100, Dave Martin wrote: > > > On Thu, Jul 02, 2020 at 08:23:02AM +0100, Will Deacon wrote: > > > > On Wed, Jul 01, 2020 at 06:07:25PM +0100, Dave

Re: [PATCH 1/4] dma-mapping: add a new dma_need_sync API

2020-07-06 Thread Jonathan Lemon
On Mon, Jun 29, 2020 at 03:03:56PM +0200, Christoph Hellwig wrote: > Add a new API to check if calls to dma_sync_single_for_{device,cpu} are > required for a given DMA streaming mapping. > > +:: > + > + bool > + dma_need_sync(struct device *dev, dma_addr_t dma_addr); > + > +Returns %true i

Re: [PATCH net-next] selftests: mptcp: capture pcap on both sides

2020-07-06 Thread David Miller
From: Matthieu Baerts Date: Mon, 6 Jul 2020 14:44:08 +0200 > When investigating performance issues that involve latency / loss / > reordering it is useful to have the pcap from the sender-side as it > allows to easier infer the state of the sender's congestion-control, > loss-recovery, etc. > >

Re: [RESEND PATCH v2 00/13] Enable GPU for SM8150 and SM8250

2020-07-06 Thread Dmitry Baryshkov
On 03/07/2020 18:03, Dmitry Baryshkov wrote: On 30/06/2020 00:17, Jonathan Marek wrote: This series adds the missing clock drivers and dts nodes to enable the GPU on both SM8150 and SM8250. Note an extra patch [1] is still required for GPU to work on SM8250. Changes in V2: * Added "clk: qcom:

Re: [PATCH v3] usb: gadget: function: fix missing spinlock in f_uac1_legacy

2020-07-06 Thread Greg KH
On Sun, Jul 05, 2020 at 08:40:27PM +0800, qiang.zh...@windriver.com wrote: > From: Zhang Qiang > > Add a missing spinlock protection for play_queue, because > the play_queue may be destroyed when the "playback_work" > work func and "f_audio_out_ep_complete" callback func > operate this paly_queue

Re: [PATCH tip/core/rcu 03/17] rcu/tree: Skip entry into the page allocator for PREEMPT_RT

2020-07-06 Thread Uladzislau Rezki
On Mon, Jul 06, 2020 at 03:42:32PM -0400, Joel Fernandes wrote: > On Thu, Jul 02, 2020 at 09:45:06PM +0200, Uladzislau Rezki wrote: > > On Thu, Jul 02, 2020 at 04:12:16PM +0200, Sebastian Andrzej Siewior wrote: > > > On 2020-06-30 11:35:34 [-0700], Paul E. McKenney wrote: > > > > > This is not goin

Re: [PATCH net-next v2 3/3] net: ethtool: Remove PHYLIB direct dependency

2020-07-06 Thread Andrew Lunn
On Mon, Jul 06, 2020 at 11:40:00AM -0700, Jakub Kicinski wrote: > On Sun, 5 Jul 2020 21:27:58 -0700 Florian Fainelli wrote: > > + ops = ethtool_phy_ops; > > + if (!ops || !ops->start_cable_test) { > > nit: don't think member-by-member checking is necessary. We don't > expect there to be any a

Re: [PATCH v2 0/8] selftests/harness: Switch to TAP output

2020-07-06 Thread Shuah Khan
On 7/4/20 11:46 PM, Kees Cook wrote: On Mon, Jun 22, 2020 at 11:16:43AM -0700, Kees Cook wrote: Hi, v2: - switch harness from XFAIL to SKIP - pass skip reason from test into TAP output - add acks/reviews v1: https://lore.kernel.org/lkml/20200611224028.3275174-1-keesc...@chromium.org/ I finall

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-07-06 Thread Greg Kroah-Hartman
On Mon, Jul 06, 2020 at 05:56:04PM +0200, Marc Gonzalez wrote: > Hello Greg, > > Would you agree to take this series? Given the lack of testing of the patch, it doesn't seem wise to add this, right? Please get some testing, and some more users, and I'll be glad to consider it. thanks, greg k-h

Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

2020-07-06 Thread Geert Uytterhoeven
Hi Adrian, On Mon, Jul 6, 2020 at 6:18 PM Mark Brown wrote: > On Mon, Jul 06, 2020 at 11:22:43AM +0200, Adrian Fiergolski wrote: > > The implementation is transparent for the SPI devices and doesn't require > > their modifications. It is based on a virtual SPI device (spi-daisy_chain) > > and def

drivers/video/fbdev/aty/mach64_cursor.c:156:23: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-07-06 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5c82ec00dd00c7a2b02d4b42cf59ae87592cb75f commit: 80591e61a0f7e88deaada69844e4a31280c4a38f kbuild: tell sparse about the $ARCH date: 8 months ago config: riscv-randconfig-s031-20200706 (attached as .config

Re: [PATCH] net/amd: Remove needless assignment and the extra brank lines

2020-07-06 Thread David Miller
From: Tang Bin Date: Mon, 6 Jul 2020 22:47:01 +0800 > The variable 'err = -ENODEV;' in au1000_probe() is > duplicate, so remove redundant one. And remove the > extra blank lines in the file au1000_eth.c > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied to net-next, thanks.

Re: [PATCH 0/2][RFC] Makes sd->flags sysctl writable

2020-07-06 Thread Peter Zijlstra
On Tue, Jul 07, 2020 at 03:36:13AM +0800, Chen Yu wrote: > It was found that recently the flags of sched domain could > not be customized via sysctl, which might make it a little > inconenient for performance tuning/debugging. What specific goals do you have? This is a debug interface.

<    3   4   5   6   7   8   9   10   11   12   >