Re: [PATCH 09/12] ima: Use correct type for the args_p member of ima_rule_entry.lsm elements

2020-06-25 Thread Mimi Zohar
On Mon, 2020-06-22 at 19:32 -0500, Tyler Hicks wrote: > Make args_p be of the char pointer type rather than have it be a void > pointer that gets casted to char pointer when it is used. It is a simple > NUL-terminated string as returned by match_strdup(). > > Signed-off-by: Tyler Hicks Thanks!

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-25 Thread James Bottomley
On Thu, 2020-06-25 at 14:19 -0700, Jerry Snitselaar wrote: > On Fri Jun 26 20, Jarkko Sakkinen wrote: > > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote: > > > On Thu Jun 25 20, Jarkko Sakkinen wrote: > > > > Acer C720 running Linux v5.3 reports this in klog: > > > > > > > > tpm_

Re: [klibc] process '/usr/bin/rsync' started with executable stack

2020-06-25 Thread Thorsten Glaser
Kees Cook dixit: >3) fix the use of trampolines in klibc AIUI done in klibc, but post-2.0.7 bye, //mirabilos -- FWIW, I'm quite impressed with mksh interactively. I thought it was much *much* more bare bones. But it turns out it beats the living hell out of ksh93 in that respect. I'd even consi

Re: [PATCH] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 08:13:09AM -0400, Stefan Berger wrote: > On 6/25/20 12:24 AM, Jarkko Sakkinen wrote: > > Re-allocate context and session buffers when needed. Scale them in page > > increments so that the reallocation is only seldomly required, and thus > > causes minimal stress to the syste

[PATCH V3] firmware: imx: Move i.MX SCU soc driver into imx firmware folder

2020-06-25 Thread Anson Huang
The i.MX SCU soc driver depends on SCU firmware driver, so it has to use platform driver model for proper defer probe operation, since it has no device binding in DT file, a simple platform device is created together inside the platform driver. To make it more clean, we can just move the entire SCU

Re: Enabling interrupts in QEMU TPM TIS

2020-06-25 Thread Stefan Berger
On 6/25/20 1:28 PM, Jason Gunthorpe wrote: On Thu, Jun 25, 2020 at 10:56:43AM -0400, Stefan Berger wrote: Hello!  I want to enable IRQs now in QEMU's TPM TIS device model and I need to work with the following patch to Linux TIS. I am wondering whether the changes there look reasonable to you?

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 08:41:18AM -0400, Stefan Berger wrote: > On 6/25/20 12:38 AM, Jarkko Sakkinen wrote: > > Re-allocate context and session buffers when needed. Scale them in page > > increments so that the reallocation is only seldomly required, and thus > > causes minimal stress to the syste

Re: [PATCH v6 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 08:42:21AM -0400, Stefan Berger wrote: > From: Stefan Berger > > Recent extensions of the TPM2 ACPI table added 3 more fields > including 12 bytes of start method specific parameters and Log Area > Minimum Length (u32) and Log Area Start Address (u64). So, we define > a ne

Re: [PATCH] Ability to read the MKTME status from userspace (patch v2)

2020-06-25 Thread Borislav Petkov
On Thu, Jun 25, 2020 at 06:16:12PM -0300, Daniel Gutson wrote: > What didn't become clear from the thread last time is the direction to > proceed. Concrete suggestion? Here are two: https://lkml.kernel.org/r/20200619161752.gg32...@zn.tnic https://lkml.kernel.org/r/20200619161026.gf32...@zn.tnic

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Stefan Berger
On 6/25/20 5:25 PM, Jarkko Sakkinen wrote: On Thu, Jun 25, 2020 at 08:41:18AM -0400, Stefan Berger wrote: On 6/25/20 12:38 AM, Jarkko Sakkinen wrote: Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus c

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Jerry Snitselaar
On Thu Jun 25 20, Jarkko Sakkinen wrote: Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus causes minimal stress to the system. Add a static maximum limit of four pages for buffer sizes. Cc: James Botto

Re: [PATCH] RISC-V: Use a local variable instead of smp_processor_id()

2020-06-25 Thread Palmer Dabbelt
On Mon, 22 Jun 2020 16:47:25 PDT (-0700), Atish Patra wrote: From: Greentime Hu Store the smp_processor_id() in a local variable to save some pointer chasing. Signed-off-by: Greentime Hu Signed-off-by: Atish Patra --- arch/riscv/kernel/smpboot.c | 7 --- 1 file changed, 4 insertions(+),

Re: [PATCH] Ability to read the MKTME status from userspace (patch v2)

2020-06-25 Thread Dave Hansen
On 6/25/20 2:10 PM, Daniel Gutson wrote: > The intent of this patch is to provide visibility of the > MKTME status to userspace. This is an important factor for > firmware security related applilcations. We need more specifics than this. It's an important factor for what, exactly? Who will consu

[PATCH 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-06-25 Thread Bhanu Prakash Maiya
Add DT compatible string in Documentation/devicetree/bindings/mfd/cros_ec.txt Signed-off-by: Bhanu Prakash Maiya --- Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt

[PATCH 1/2] cros: platform/chrome: Add cros-ec-uart driver for uart support

2020-06-25 Thread Bhanu Prakash Maiya
This patch enables uart transport layer for cros_ec framework. The cros-ec-uart binds with EC device working on uart transport to send request and receive response. Signed-off-by: Bhanu Prakash Maiya --- MAINTAINERS| 1 + drivers/platform/chrome/Kconfig| 1

Re: [hugetlbfs] c0d0381ade: vm-scalability.throughput -33.4% regression

2020-06-25 Thread Mike Kravetz
On 6/22/20 3:01 PM, Mike Kravetz wrote: > On 6/21/20 5:55 PM, kernel test robot wrote: >> Greeting, >> >> FYI, we noticed a -33.4% regression of vm-scalability.throughput due to >> commit: >> >> >> commit: c0d0381ade79885c04a04c303284b040616b116e ("hugetlbfs: use >> i_mmap_rwsem for more pmd shar

Re: [PATCH v6 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 08:42:22AM -0400, Stefan Berger wrote: > From: Stefan Berger > > In case a TPM2 is attached, search for a TPM2 ACPI table when trying > to get the event log from ACPI. If one is found, use it to get the > start and length of the log area. This allows non-UEFI systems, such

[tip:x86/misc] BUILD SUCCESS a7e1f67ed29f0c339e2aa7483d13b085127566ab

2020-06-25 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/misc branch HEAD: a7e1f67ed29f0c339e2aa7483d13b085127566ab x86/msr: Filter MSR writes elapsed time: 727m configs tested: 105 configs skipped: 94 The following configs have been built successfully. More configs may b

[tip:master] BUILD SUCCESS 489eb109cb9da24d05cc23a6c8fa4832766ddcca

2020-06-25 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master branch HEAD: 489eb109cb9da24d05cc23a6c8fa4832766ddcca Merge branch 'WIP.core/headers' elapsed time: 727m configs tested: 117 configs skipped: 6 The following configs have been built successfully. More configs may

Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 11:27:28AM -0400, Don Porter wrote: > On 5/29/20 11:27 AM, Wojtek Porczyk wrote: > > On Thu, May 28, 2020 at 11:38:01AM -0700, Andy Lutomirski wrote: > > > One useful test for the actual kernel patches would be to run your SGX > > > workload on a loaded core. That is, do so

Re: [PATCH] Ability to read the MKTME status from userspace (patch v2)

2020-06-25 Thread Dave Hansen
On 6/25/20 2:27 PM, Borislav Petkov wrote: > On Thu, Jun 25, 2020 at 06:16:12PM -0300, Daniel Gutson wrote: >> What didn't become clear from the thread last time is the direction to >> proceed. Concrete suggestion? > Here are two: > > https://lkml.kernel.org/r/20200619161752.gg32...@zn.tnic > http

Re: [PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-25 Thread Stefan Berger
On 6/25/20 12:38 AM, Jarkko Sakkinen wrote: Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus causes minimal stress to the system. Add a static maximum limit of four pages for buffer sizes. Cc: James Bo

Re: [PATCH] Ability to read the MKTME status from userspace (patch v2)

2020-06-25 Thread Andy Lutomirski
On Thu, Jun 25, 2020 at 2:38 PM Dave Hansen wrote: > > On 6/25/20 2:27 PM, Borislav Petkov wrote: > > On Thu, Jun 25, 2020 at 06:16:12PM -0300, Daniel Gutson wrote: > >> What didn't become clear from the thread last time is the direction to > >> proceed. Concrete suggestion? > > Here are two: > >

drivers/infiniband/hw/hfi1/pio_copy.c:421:24: sparse: sparse: cast removes address space '__iomem' of expression

2020-06-25 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 908f7d12d3ba51dfe0449b9723199b423f97ca9a commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 7 days ago config: x86_64-randconfig-s022-20200625

Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 11:30:54AM -0400, Don Porter wrote: > We are merging the changes to Graphene to run a patched 5.7 kernel with > these patches, so it should work for you (or anyone else) once all of the > changes are merged. I'd be happy to talk, perhaps off this thread, about > how we can

Re: [PATCH] ring-buffer: speed up buffer resets by avoiding synchronize_rcu for each CPU

2020-06-25 Thread Anton Blanchard
Hi Nick, > On a 144 thread system, `perf ftrace` takes about 20 seconds to start > up, due to calling synchronize_rcu() for each CPU. > > cat /proc/108560/stack > 0xc0003e7eb336f470 > __switch_to+0x2e0/0x480 > __wait_rcu_gp+0x20c/0x220 > synchronize_rcu+0x9c/0xc0 > ring_buff

[PATCH v5 0/9] clocksource/drivers/timer-atmel-tcb: add sama5d2 support

2020-06-25 Thread Alexandre Belloni
Hello, This series mainly adds sama5d2 support where we need to avoid using clock index 0 because that clock is never enabled by the driver. There is also a rework of the 32khz clock handling so it is not used for clockevents on 32 bit counter because the increased rate improves the resolution an

[PATCH v5 7/9] clocksource/drivers/timer-atmel-tcb: stop using the 32kHz for clockevents

2020-06-25 Thread Alexandre Belloni
Stop using the slow clock as the clock source for 32 bit counters because even at 10MHz, they are able to handle delays up to two minutes. This provides a way better resolution. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 61 ++- 1 file ch

[PATCH v5 4/9] ARM: at91: add atmel tcb capabilities

2020-06-25 Thread Alexandre Belloni
From: Kamel Bouhara Some atmel socs have extra tcb capabilities that allow using a generic clock source or enabling a quadrature decoder. Signed-off-by: Kamel Bouhara Signed-off-by: Alexandre Belloni --- include/soc/at91/atmel_tcb.h | 5 + 1 file changed, 5 insertions(+) diff --git a/inc

[PATCH v5 1/9] dt-bindings: atmel-tcb: convert bindings to json-schema

2020-06-25 Thread Alexandre Belloni
Convert Atmel Timer Counter Blocks bindings to DT schema format using json-schema. Also move it out of mfd as it is not and has never been related to mfd. Signed-off-by: Alexandre Belloni Reviewed-by: Rob Herring --- .../devicetree/bindings/mfd/atmel-tcb.txt | 56 .../soc/microch

[PATCH v5 8/9] clocksource/drivers/timer-atmel-tcb: allow selecting first divider

2020-06-25 Thread Alexandre Belloni
The divider selection algorithm never allowed to get index 0. It was also continuing to look for dividers, trying to find the slow clock selection. This is not necessary anymore. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 6 ++ 1 file changed, 2 insertions(+

[PATCH v5 3/9] ARM: dts: at91: sama5d2: add TCB GCLK

2020-06-25 Thread Alexandre Belloni
The sama5d2 tcbs take an extra input clock, their gclk. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/sama5d2.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index 31d8766ec7ef..d7f2570

[PATCH v5 5/9] clocksource/drivers/timer-atmel-tcb: rework 32khz clock selection

2020-06-25 Thread Alexandre Belloni
On all the supported SoCs, the slow clock is always ATMEL_TC_TIMER_CLOCK5, avoid looking it up and pass it directly to setup_clkevents. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drive

[PATCH v5 6/9] clocksource/drivers/timer-atmel-tcb: fill tcb_config

2020-06-25 Thread Alexandre Belloni
Use the tcb_config and struct atmel_tcb_config to get the timer counter width. This is necessary because atmel_tcb_config will be extended later on. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-

[PATCH v5 2/9] dt-bindings: microchip: atmel,at91rm9200-tcb: add sama5d2 compatible

2020-06-25 Thread Alexandre Belloni
The sama5d2 TC block TIMER_CLOCK1 is different from the at91sam9x5 one. Instead of being MCK / 2, it is the TCB GCLK. Cc: Rob Herring Signed-off-by: Alexandre Belloni --- .../soc/microchip/atmel,at91rm9200-tcb.yaml | 42 +++ 1 file changed, 33 insertions(+), 9 deletions(-) di

Re: [PATCH] Ability to read the MKTME status from userspace (patch v2)

2020-06-25 Thread Dave Hansen
On 6/25/20 2:39 PM, Andy Lutomirski wrote: > What about MKTME platforms that (using hypothetical future kernel > support) have encryption enabled for a node but have disabled it for > specific pages using madvise()? Or that have any other nontrivial > policy like that? I think it's fine if the ma

[PATCH v5 9/9] clocksource/drivers/timer-atmel-tcb: add sama5d2 support

2020-06-25 Thread Alexandre Belloni
The first divisor for the sama5d2 is actually the gclk selector. Because the currently remaining divisors are fitting the use case, currently ensure it is skipped. Signed-off-by: Alexandre Belloni --- drivers/clocksource/timer-atmel-tcb.c | 11 ++- 1 file changed, 10 insertions(+), 1 del

Re: [PATCH for-5.9 0/2] clean io_wq->do_work()

2020-06-25 Thread Jens Axboe
On 6/25/20 9:20 AM, Pavel Begunkov wrote: > Small io-wq cleanups after getting rid of per-work callbacks. > > Pavel Begunkov (2): > io-wq: compact io-wq flags numbers > io-wq: return next work from ->do_work() directly > > fs/io-wq.c| 8 +++- > fs/io-wq.h| 10 +- > fs/io

linux-next: Fixes tag needs some work in the hwmon-fixes tree

2020-06-25 Thread Stephen Rothwell
Hi all, In commit a899847a6012 ("hwmon: (acpi_power_meter) Fix potential memory leak in acpi_power_meter_add()") Fixes tag Fixes: commit de584afa5e188 ("hwmon driver for ACPI 4.0 power meters") has these problem(s): - leading word 'commit' unexpected -- Cheers, Stephen Rothwell pgp

[RFC PATCH] kvm,x86: Exit to user space in case of page fault error

2020-06-25 Thread Vivek Goyal
Page fault error handling behavior in kvm seems little inconsistent when page fault reports error. If we are doing fault synchronously then we capture error (-EFAULT) returned by __gfn_to_pfn_memslot() and exit to user space and qemu reports error, "error: kvm run failed Bad address". But if we ar

[PATCH v7 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-25 Thread Stefan Berger
From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we define a new structure acpi_tpm2_phy that holds these optional new fields. The new fie

[PATCH v7 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-06-25 Thread Stefan Berger
From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area. This allows non-UEFI systems, such as SeaBIOS, to pass an event log when using a TPM2. Signed-off-by: Stef

[PATCH v7 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

2020-06-25 Thread Stefan Berger
From: Stefan Berger This series of patches adds an optional extensions for the TPM2 ACPI table with additional fields found in the TPM2 TCG ACPI specification (reference is in the patch) that allow access to the log's address and its size. We then modify the code that so far only enables access t

Re: [PATCH 05/12] ima: Fail rule parsing when buffer hook functions have an invalid action

2020-06-25 Thread Mimi Zohar
On Mon, 2020-06-22 at 19:32 -0500, Tyler Hicks wrote: > Buffer based hook functions, such as KEXEC_CMDLINE and KEY_CHECK, can > only measure. The process_buffer_measurement() function quietly ignores > all actions except measure so make this behavior clear at the time of > policy load. > > The par

Re: [PATCH] platform/chrome: cros_ec_spi: Document missing function parameters

2020-06-25 Thread Gwendal Grignou
Reviewed-by: Gwendal Grignou On Thu, Jun 25, 2020 at 10:02 AM Enric Balletbo i Serra wrote: > > Kerneldoc expects all kernel function members to be documented. > > Fixes the following W=1 level warnings: > > cros_ec_spi.c:153: warning: Function parameter or member 'ec_dev' not > described in

Re: [PATCH] platform/chrome: cros_ec_rpmsg: Document missing struct parameters

2020-06-25 Thread Gwendal Grignou
Reviewed-by: Gwendal Grignou On Thu, Jun 25, 2020 at 10:03 AM Enric Balletbo i Serra wrote: > > Kerneldoc expects all kernel structure member to be documented. > > Fixes the following W=1 level warnings: > > cros_ec_rpmsg.c:49: warning: Function parameter or member 'ept' not > described in 'c

Re: [PATCH 06/12] ima: Fail rule parsing when the KEXEC_CMDLINE hook is combined with an invalid cond

2020-06-25 Thread Mimi Zohar
On Mon, 2020-06-22 at 19:32 -0500, Tyler Hicks wrote: > The KEXEC_CMDLINE hook function only supports the pcr conditional. Make > this clear at policy load so that IMA policy authors don't assume that > other conditionals are supported. > > Since KEXEC_CMDLINE's inception, ima_match_rules() has al

Re: [PATCH v3] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3

2020-06-25 Thread Jarkko Sakkinen
On Fri, Jun 26, 2020 at 12:37:54AM +0800, Pengfei Xu wrote: > Python 2 is no longer supported by the Python upstream project, so > upgrade TPM2 tests to Python 3. > > Signed-off-by: Pengfei Xu > --- > tools/testing/selftests/tpm2/test_smoke.sh | 4 +- > tools/testing/selftests/tpm2/test_space.s

[PATCH v2 0/2] mm: Expand CONFIG_SLAB_FREELIST_HARDENED to include SLAB

2020-06-25 Thread Kees Cook
Hi, In reviewing Vlastimil Babka's latest slub debug series, I realized[1] that several checks under CONFIG_SLAB_FREELIST_HARDENED weren't being applied to SLAB. Fix this by expanding the Kconfig coverage, and adding a simple double-free test for SLAB. v2: - rebase to -mmots - drop SLOB support (

[PATCH v2 1/2] mm: Expand CONFIG_SLAB_FREELIST_HARDENED to include SLAB

2020-06-25 Thread Kees Cook
Include SLAB caches when performing kmem_cache pointer verification. A defense against such corruption[1] should be applied to all the allocators. With this added, the "SLAB_FREE_CROSS" and "SLAB_FREE_PAGE" LKDTM tests now pass on SLAB: lkdtm: Performing direct entry SLAB_FREE_CROSS lkdtm: Att

[PATCH v2 2/2] slab: Add naive detection of double free

2020-06-25 Thread Kees Cook
Similar to commit ce6fa91b9363 ("mm/slub.c: add a naive detection of double free or corruption"), add a very cheap double-free check for SLAB under CONFIG_SLAB_FREELIST_HARDENED. With this added, the "SLAB_FREE_DOUBLE" LKDTM test passes under SLAB: lkdtm: Performing direct entry SLAB_FREE_DOUBLE

[PATCH 2/2] staging: qlge: fix else after return or break

2020-06-25 Thread Coiby Xu
Remove unnecessary elses after return or break. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 23 ++- drivers/staging/qlge/qlge_main.c | 8 drivers/staging/qlge/qlge_mpi.c | 4 ++-- 3 files changed, 16 insertions(+), 19 deletions(-) diff --git a/

[PATCH 1/2] staging: qlge: fix trailing */ in block comment

2020-06-25 Thread Coiby Xu
Remove trailing "*/" in block comments. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_main.c | 3 ++- drivers/staging/qlge/qlge_mpi.c | 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c inde

Re: [PATCH 1/2] fix trailing */ in block comment

2020-06-25 Thread Coiby Xu
On Thu, Jun 25, 2020 at 08:25:10PM +0300, Dan Carpenter wrote: The subject isn't right (no subsystem prefix) and we need a commit message. regards, dan carpenter Thank you for pointing out the exact problems! -- Best regards, Coiby

Re: [PATCH v12 3/9] tpm: tpm_tis: Add retry in case of protocol failure.

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 05:46:43PM +0300, amirmi...@gmail.com wrote: > From: Amir Mizinski > > Added a retry mechanism on any protocol error when sending a command or > receiving a response. This was changed to comply with > the TCG PC Client Device Driver Design Principles for TPM 2.0. We don't

Re: [klibc] process '/usr/bin/rsync' started with executable stack

2020-06-25 Thread Kees Cook
On Thu, Jun 25, 2020 at 09:16:10PM +, Thorsten Glaser wrote: > Kees Cook dixit: > > >3) fix the use of trampolines in klibc > > AIUI done in klibc, but post-2.0.7 Ah-ha, I see it. Ben got it fixed in Feb. :) https://git.kernel.org/pub/scm/libs/klibc/klibc.git/commit/?id=9d8d648e604026b32cad

Re: [PATCH v12 4/9] tpm: tpm_tis: Add verify_data_integrity handle to tpm_tis_phy_ops

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 05:46:44PM +0300, amirmi...@gmail.com wrote: > From: Amir Mizinski > > When using I2C bus protocol, the TPM has the ability to report data > integrity on incoming or outgoing command parameter bytes. > According to the TCG specs, if this data validation functionality is >

Re: [PATCH] sched/cfs: change initial value of runnable_avg

2020-06-25 Thread Holger Hoffstätte
On 2020-06-25 12:42, Holger Hoffstätte wrote: Nevermind, it turned out to be something else after all. I'm not entirely sure *what* exactly yet, but for some reason my loadavg is high again for no good reason. Sorry for the false alarm. -h

Re: [PATCH] proc: Avoid a thundering herd of threads freeing proc dentries

2020-06-25 Thread Junxiao Bi
On 6/22/20 5:47 PM, Matthew Wilcox wrote: On Sun, Jun 21, 2020 at 10:15:39PM -0700, Junxiao Bi wrote: On 6/20/20 9:27 AM, Matthew Wilcox wrote: On Fri, Jun 19, 2020 at 05:42:45PM -0500, Eric W. Biederman wrote: Junxiao Bi writes: Still high lock contention. Collect the following hot path.

Re: [PATCH 2/2] staging: qlge: fix else after return or break

2020-06-25 Thread Joe Perches
On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote: > Remove unnecessary elses after return or break. unrelated trivia: > diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c [] > @@ -1391,12 +1391,11 @@ static void ql_dump_cam_entries(struct ql_adapter > *qdev) >

Re: [v2] drm/msm/dpu: add support for dither block in display

2020-06-25 Thread Doug Anderson
Hi, On Thu, Jun 25, 2020 at 5:17 AM Kalyan Thota wrote: > > This change enables dither block for primary interface > in display. > > Enabled for 6bpc in the current version. > > Changes in v1: > - Remove redundant error checks (Rob). > > Signed-off-by: Kalyan Thota > --- > drivers/gpu/drm/msm/

[GIT PULL] tracing: Fixes for 5.8-rc2

2020-06-25 Thread Steven Rostedt
Linus, tracing: Four small fixes - Fixed a ringbuffer bug for nested events having time go backwards - Fix a config dependency for boot time tracing to depend on synthetic events instead of histograms. - Fix trigger format parsing to handle multiple spaces - Fix bootconfig to handle fail

Re: [PATCH v2 1/2] i2c: fsi: Fix the port number field in status register

2020-06-25 Thread Wolfram Sang
On Tue, Jun 09, 2020 at 03:15:54PM -0500, Eddie James wrote: > The port number field in the status register was not correct, so fix it. > > Fixes: d6ffb6300116 ("i2c: Add FSI-attached I2C master algorithm") > Signed-off-by: Eddie James > Signed-off-by: Joel Stanley Applied to for-current, thank

Re: [PATCH v33 10/21] mm: Introduce vm_ops->may_mprotect()

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 07:14:16PM +0200, Borislav Petkov wrote: > On Thu, Jun 18, 2020 at 01:08:32AM +0300, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Add vm_ops()->may_mprotect() to check additional constraints. > > > > SGX uses this callback to add two constraints: > > > >

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-25 Thread Wei Yang
On Thu, Jun 25, 2020 at 12:46:43PM -0700, Dan Williams wrote: >On Wed, Jun 24, 2020 at 10:53 PM David Hildenbrand wrote: >> >> >> >> > Am 25.06.2020 um 01:47 schrieb Dan Williams : >> > >> > On Wed, Jun 24, 2020 at 3:44 PM Wei Yang >> > wrote: >> > [..] >> >>> So, you are right that there is a m

RE: [PATCH v6 2/4] dt-bindings: arm-smmu: Add binding for Tegra194 SMMU

2020-06-25 Thread Krishna Reddy
>> + - nvdia,tegra194-smmu-500 >The -500 suffix here seems a bit redundant since there's no other type of SMMU >in Tegra194, correct? Yeah, there is only one type of SMMU supported in T194. It was added to be synonymous with mmu-500. Can be removed. -KR

[Patch v2] mm/sparse: never partially remove memmap for early section

2020-06-25 Thread Wei Yang
For early sections, its memmap is handled specially even sub-section is enabled. The memmap could only be populated as a whole. Quoted from the comment of section_activate(): * The early init code does not consider partially populated * initial sections, it simply assumes that memory will

[Patch v4 2/3] PCI: Restrict probe functions to housekeeping CPUs

2020-06-25 Thread Nitesh Narayan Lal
From: Alex Belits pci_call_probe() prevents the nesting of work_on_cpu() for a scenario where a VF device is probed from work_on_cpu() of the PF. Replace the cpumask used in pci_call_probe() from all online CPUs to only housekeeping CPUs. This is to ensure that there are no additional latency ov

[Patch v4 3/3] net: Restrict receive packets queuing to housekeeping CPUs

2020-06-25 Thread Nitesh Narayan Lal
From: Alex Belits With the existing implementation of store_rps_map(), packets are queued in the receive path on the backlog queues of other CPUs irrespective of whether they are isolated or not. This could add a latency overhead to any RT workload that is running on the same CPU. Ensure that st

[Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2020-06-25 Thread Nitesh Narayan Lal
From: Alex Belits The current implementation of cpumask_local_spread() does not respect the isolated CPUs, i.e., even if a CPU has been isolated for Real-Time task, it will return it to the caller for pinning of its IRQ threads. Having these unwanted IRQ threads on an isolated CPU adds up to a la

[PATCH v4 0/3] Preventing job distribution to isolated CPUs

2020-06-25 Thread Nitesh Narayan Lal
This patch-set is originated from one of the patches that have been posted earlier as a part of "Task_isolation" mode [1] patch series by Alex Belits . There are only a couple of changes that I am proposing in this patch-set compared to what Alex has posted earlier. Context === On a broad l

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-25 Thread Wei Yang
On Thu, Jun 25, 2020 at 07:53:37AM +0200, David Hildenbrand wrote: > > >> Am 25.06.2020 um 01:47 schrieb Dan Williams : >> >> On Wed, Jun 24, 2020 at 3:44 PM Wei Yang >> wrote: >> [..] So, you are right that there is a mismatch here, but I think the comprehensive fix is to allow early

Re: [PATCH v33 10/21] mm: Introduce vm_ops->may_mprotect()

2020-06-25 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 11:06:46AM -0700, Sean Christopherson wrote: > On Thu, Jun 25, 2020 at 06:30:50PM +0100, Matthew Wilcox wrote: > > On Thu, Jun 25, 2020 at 07:14:16PM +0200, Borislav Petkov wrote: > > > On Thu, Jun 18, 2020 at 01:08:32AM +0300, Jarkko Sakkinen wrote: > > > > diff --git a/mm/

Re: [RFC][PATCH] objtool,x86_64: Replace recordmcount with objtool

2020-06-25 Thread Sami Tolvanen
On Thu, Jun 25, 2020 at 10:02:35PM +0200, Peter Zijlstra wrote: > On Thu, Jun 25, 2020 at 09:15:03AM -0700, Sami Tolvanen wrote: > > On Thu, Jun 25, 2020 at 09:45:30AM +0200, Peter Zijlstra wrote: > > > > At least for x86_64 I can do a really quick take for a recordmcount pass > > > in objtool, bu

Re: [PATCH 11/12] ima: Use the common function to detect LSM conditionals in a rule

2020-06-25 Thread Mimi Zohar
On Mon, 2020-06-22 at 19:32 -0500, Tyler Hicks wrote: > Make broader use of ima_rule_contains_lsm_cond() to check if a given > rule contains an LSM conditional. This is a code cleanup and has no > user-facing change. > > Signed-off-by: Tyler Hicks Reviewed-by: Mimi Zohar Mimi

Re: [PATCH] riscv: Fixup __vdso_gettimeofday broke dynamic ftrace

2020-06-25 Thread Palmer Dabbelt
On Tue, 23 Jun 2020 02:50:54 PDT (-0700), guo...@kernel.org wrote: From: Guo Ren For linux-5.8-rc1, enable ftrace of riscv will cause boot panic: [2.388980] Run /sbin/init as init process [2.529938] init[39]: unhandled signal 4 code 0x1 at 0x003ff449e000 [2.531078] CPU: 0 PID:

Re: Enabling interrupts in QEMU TPM TIS

2020-06-25 Thread Stefan Berger
On 6/25/20 5:26 PM, Stefan Berger wrote: On 6/25/20 1:28 PM, Jason Gunthorpe wrote: On Thu, Jun 25, 2020 at 10:56:43AM -0400, Stefan Berger wrote: Hello!   I want to enable IRQs now in QEMU's TPM TIS device model and I need to work with the following patch to Linux TIS. I am wondering whether

[UPDATE][PATCH v3 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency

2020-06-25 Thread Srinivas Pandruvada
By default intel_pstate driver disables energy efficiency by setting MSR_IA32_POWER_CTL bit 19 for Kaby Lake desktop CPU model in HWP mode. This CPU model is also shared by Coffee Lake desktop CPUs. This allows these systems to reach maximum possible frequency. But this adds power penalty, which so

Re: [PATCH 12/12] ima: Support additional conditionals in the KEXEC_CMDLINE hook function

2020-06-25 Thread Mimi Zohar
On Mon, 2020-06-22 at 19:32 -0500, Tyler Hicks wrote: > Take the properties of the kexec kernel's inode and the current task > ownership into consideration when matching a KEXEC_CMDLINE operation to > the rules in the IMA policy. This allows for some uniformity when > writing IMA policy rules for K

Re: [PATCH 12/12] ima: Support additional conditionals in the KEXEC_CMDLINE hook function

2020-06-25 Thread Tyler Hicks
On 2020-06-25 18:56:44, Mimi Zohar wrote: > On Mon, 2020-06-22 at 19:32 -0500, Tyler Hicks wrote: > > Take the properties of the kexec kernel's inode and the current task > > ownership into consideration when matching a KEXEC_CMDLINE operation to > > the rules in the IMA policy. This allows for som

Re: [PATCH v2 1/2] net: macb: call pm_runtime_put_sync on failure path

2020-06-25 Thread David Miller
From: Claudiu Beznea Date: Wed, 24 Jun 2020 13:08:17 +0300 > Call pm_runtime_put_sync() on failure path of at91ether_open. > > Fixes: e6a41c23df0d ("net: macb: ensure interface is not suspended on > at91rm9200") > Signed-off-by: Claudiu Beznea Applied and queued up for -stable.

Re: [PATCH v2 2/2] net: macb: free resources on failure path of at91ether_open()

2020-06-25 Thread David Miller
From: Claudiu Beznea Date: Wed, 24 Jun 2020 13:08:18 +0300 > DMA buffers were not freed on failure path of at91ether_open(). > Along with changes for freeing the DMA buffers the enable/disable > interrupt instructions were moved to at91ether_start()/at91ether_stop() > functions and the operations

Re: [PATCH] soc: qcom: rpmh: Remove serialization of TCS commands

2020-06-25 Thread Doug Anderson
Hi, On Thu, Jun 25, 2020 at 3:22 AM Maulik Shah wrote: > > Hi, > > On 6/19/2020 9:57 AM, Doug Anderson wrote: > > Hi, > > > > On Fri, May 29, 2020 at 3:52 AM Maulik Shah wrote: > >> From: Lina Iyer > >> > >> Requests sent to RPMH can be sent as fire-n-forget or response required, > >> with the

Re: [PATCH net-next v11 0/5] RGMII Internal delay common property

2020-06-25 Thread David Miller
From: Dan Murphy Date: Wed, 24 Jun 2020 07:16:00 -0500 > The RGMII internal delay is a common setting found in most RGMII capable PHY > devices. It was found that many vendor specific device tree properties exist > to do the same function. This creates a common property to be used for PHY's > th

[PATCH] mm/page_alloc: fallbacks at most has 3 elements

2020-06-25 Thread Wei Yang
MIGRAGE_TYPES is used to be the mark of end and there are at most 3 elements for the one dimension array. Reduce to 3 to save little memory. Signed-off-by: Wei Yang --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index da

Re: [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()'

2020-06-25 Thread Russell King - ARM Linux admin
On Thu, Jun 25, 2020 at 10:47:30PM +0200, Christophe JAILLET wrote: > The dev_id used in 'request_irq()' and 'free_irq()' should match. > Use 'info' in both cases. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Christophe JAILLET Acked-by: Russell King Thanks Christophe. > ---

Re: [PATCH net] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket

2020-06-25 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 24 Jun 2020 17:34:18 -0300 > If a socket is set ipv6only, it will still send IPv4 addresses in the > INIT and INIT_ACK packets. This potentially misleads the peer into using > them, which then would cause association termination. > > The fix is to not add

RE: [PATCH v6 1/4] iommu/arm-smmu: add NVIDIA implementation for dual ARM MMU-500 usage

2020-06-25 Thread Krishna Reddy
>Should NVIDIA_TEGRA194_SMMU be a separate value for smmu->model, perhaps? That >way we avoid this somewhat odd check here. NVIDIA haven't made any changes to arm,mmu-500. It is only used in different topology. New model would be mis-leading here. As suggested by Robin, It can just be moved to

Re: [PATCH RFC] seccomp: Implement syscall isolation based on memory areas

2020-06-25 Thread Robert O'Callahan
rr (https://rr-project.org, https://arxiv.org/abs/1705.05937) grapples with a similar problem. We need to intercept commonly-executed system calls and wrap them with our own processing, with minimal overhead. I think our basic approach might work for Wine without kernel changes. We use SECCOMP_SET

Re: [PATCH v2] Bluetooth: btusb: Reset port on cmd timeout

2020-06-25 Thread Abhishek Pandit-Subedi
Thanks for the heads up Oliver -- I will send a patch with a comment on this. On Thu, Jun 25, 2020 at 3:22 AM Oliver Neukum wrote: > > Am Mittwoch, den 24.06.2020, 11:11 -0700 schrieb Abhishek Pandit- > Subedi: > > QCA_ROME sometimes gets into a state where it is unresponsive to > > commands. Sin

Re: Enabling interrupts in QEMU TPM TIS

2020-06-25 Thread Jason Gunthorpe
On Thu, Jun 25, 2020 at 06:48:09PM -0400, Stefan Berger wrote: > On 6/25/20 5:26 PM, Stefan Berger wrote: > > On 6/25/20 1:28 PM, Jason Gunthorpe wrote: > > > On Thu, Jun 25, 2020 at 10:56:43AM -0400, Stefan Berger wrote: > > > > Hello! > > > > > > > >   I want to enable IRQs now in QEMU's TPM TIS

Re: [PATCH net-next 0/8] net: phy: mscc: multiple improvements

2020-06-25 Thread David Miller
From: Antoine Tenart Date: Thu, 25 Jun 2020 17:42:03 +0200 > This series contains various improvements to the MSCC PHY driver, fixing > sparse and smatch warnings, using functions provided by the PHY core, > and improving the driver consistency and maintenance. > > I don't think any of those imp

Re: [fedora-arm] Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

2020-06-25 Thread Peter Robinson
> I'm having troubles with the Banana Pi-R1 router with newer kernels. No > config changes, config works well since a lot of lernel updates ... > Banana Pi-R1 is configured via systemd-networkd and uses the DSA > (Distributed Switch Architecture) with b53 switch. No visible difference > in interfac

Re: [PATCH v3] PCI: Lock the pci_cfg_wait queue for the consistency of data

2020-06-25 Thread Bjorn Helgaas
On Wed, Jun 24, 2020 at 06:23:09PM -0500, Bjorn Helgaas wrote: > On Tue, Dec 10, 2019 at 11:15:27AM +0800, Xiang Zheng wrote: > > 7ea7e98fd8d0 ("PCI: Block on access to temporarily unavailable pci > > device") suggests that the "pci_lock" is sufficient, and all the > > callers of pci_wait_cfg() are

Re: [GIT PULL] tracing: Fixes for 5.8-rc2

2020-06-25 Thread pr-tracker-bot
The pull request you sent on Thu, 25 Jun 2020 18:21:49 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > trace-v5.8-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/42e9c85f5c7296c4ec02644a2b3debc7120e2bf4 Thank you! -- Deet-doot-do

[PATCH] Bluetooth: btusb: Comment on unbalanced pm reference

2020-06-25 Thread Abhishek Pandit-Subedi
Add a comment clarifying that a PM reference in btusb_qca_cmd_timeout is not unbalanced because it results in a device reset. Signed-off-by: Abhishek Pandit-Subedi --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btu

Re: [PATCH 0/4] KVM: SVM: Code move follow-up

2020-06-25 Thread Krish Sadhukhan
On 6/25/20 1:03 AM, Joerg Roedel wrote: From: Joerg Roedel Hi, here is small series to follow-up on the review comments for moving the kvm-amd module code to its own sub-directory. The comments were only about renaming structs and symbols, so there are no functional changes in these patches.

Re: [PATCH 4/4] KVM: SVM: Rename svm_nested_virtualize_tpr() to nested_svm_virtualize_tpr()

2020-06-25 Thread Krish Sadhukhan
On 6/25/20 1:03 AM, Joerg Roedel wrote: From: Joerg Roedel Match the naming with other nested svm functions. No functional changes. Signed-off-by: Joerg Roedel --- arch/x86/kvm/svm/svm.c | 6 +++--- arch/x86/kvm/svm/svm.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff -

Re: [Tee-dev] [PATCHv8 1/3] optee: use uuid for sysfs driver entry

2020-06-25 Thread James Bottomley
On Thu, 2020-06-25 at 19:54 +0530, Sumit Garg wrote: > On Wed, 24 Jun 2020 at 20:51, James Bottomley > wrote: > > > > On Wed, 2020-06-24 at 16:17 +0530, Sumit Garg wrote: > > > Apologies for delay in my reply as I was busy with some other > > > stuff. > > > > > > On Fri, 19 Jun 2020 at 20:30, Ja

Re: [PATCH 1/2] xen/privcmd: Corrected error handling path and mark pages dirty

2020-06-25 Thread Boris Ostrovsky
On 6/24/20 11:02 PM, Souptick Joarder wrote: > Previously, if lock_pages() end up partially mapping pages, it used > to return -ERRNO due to which unlock_pages() have to go through > each pages[i] till *nr_pages* to validate them. This can be avoided > by passing correct number of partially mapped

<    4   5   6   7   8   9   10   11   12   >