[PATCH v12 1/9] tpm: Make read{16, 32}() and write32() in tpm_tis_phy_ops optional

2020-06-25 Thread amirmizi6
From: Amir Mizinski Only tpm_tis can use memory-mapped I/O, which is truly mapped into the kernel's memory space. Therefore, using ioread16/ioread32/iowrite32 turns into a straightforward pointer dereference. Every other driver requires more complicated operations to read more than one byte at a

[PATCH v12 9/9] tpm: tpm_tis: add tpm_tis_i2c driver

2020-06-25 Thread amirmizi6
From: Amir Mizinski Implements the functionality needed to communicate with an I2C TPM according to the TCG TPM I2C Interface Specification. Signed-off-by: Amir Mizinski Tested-by: Eddie James Tested-by: Joel Stanley --- drivers/char/tpm/Kconfig | 12 ++ drivers/char/tpm/Makefile

[PATCH v12 6/9] tpm: Handle an exception for TPM Firmware Update mode.

2020-06-25 Thread amirmizi6
From: Amir Mizinski An extra precaution for TPM Firmware Update Mode. For example if TPM power was cut while in Firmware update, platform should ignore "selftest" failure and skip TPM initialization sequence. Suggested-by: Benoit Houyere Signed-off-by: Amir Mizinski --- drivers/char/tpm/tpm2-

[PATCH v12 2/9] tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception

2020-06-25 Thread amirmizi6
From: Amir Mizinski Detected the following incorrect implementation of the send command: polling on the TPM_STS.stsValid field followed by checking the TPM_STS.expect field only once. Since TPM_STS.stsValid represents the TPM_STS.expect validity, both fields should be polled at the same time. Th

[PATCH v12 8/9] tpm: Add YAML schema for TPM TIS I2C options

2020-06-25 Thread amirmizi6
From: Amir Mizinski Added a YAML schema to support tpm tis i2c related dt-bindings for the I2c PTP based physical layer. This patch adds the documentation for corresponding device tree bindings of I2C based Physical TPM. Refer to the 'I2C Interface Definition' section in 'TCG PC Client PlatformT

[PATCH v12 3/9] tpm: tpm_tis: Add retry in case of protocol failure.

2020-06-25 Thread amirmizi6
From: Amir Mizinski Added a retry mechanism on any protocol error when sending a command or receiving a response. This was changed to comply with the TCG PC Client Device Driver Design Principles for TPM 2.0. When sending a command, a loop is added in "tpm_tis_send_main()" that calls "tpm_tis_se

[PATCH v12 5/9] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()"

2020-06-25 Thread amirmizi6
From: Amir Mizinski Using this function while reading/writing data resulted in an aborted operation. After investigating the issue according to the TCG TPM Profile (PTP) Specifications, I found that "request to cancel" should occur only if TPM_STS.commandReady bit is lit. Note that i couldn't fin

[PATCH v12 7/9] tpm: tpm_tis: verify TPM_STS register is valid after locality request

2020-06-25 Thread amirmizi6
From: Amir Mizinski Issue could result when the TPM does not update TPM_STS register after a locality request (TPM_STS Initial value = 0xFF) and a TPM_STS register read occurs (tpm_tis_status(chip)). Checking the next condition("if ((status & TPM_STS_COMMAND_READY) == 0)"), the status will be at

[PATCH 1/2] iommu/amd: Add helper functions to update domain->pt_root

2020-06-25 Thread Joerg Roedel
From: Joerg Roedel Do not call atomic64_set() directly to update the domain page-table root and use two new helper functions. This makes it easier to implement additional work necessary when the page-table is updated. Signed-off-by: Joerg Roedel --- drivers/iommu/amd/iommu.c | 31

[PATCH v12 4/9] tpm: tpm_tis: Add verify_data_integrity handle to tpm_tis_phy_ops

2020-06-25 Thread amirmizi6
From: Amir Mizinski When using I2C bus protocol, the TPM has the ability to report data integrity on incoming or outgoing command parameter bytes. According to the TCG specs, if this data validation functionality is enabled via the TPM_DATA_CSUM_ENABLE register, the TPM will update the TPM_DATA_C

Re: [PATCH v8 09/13] perf stat: implement control commands handling

2020-06-25 Thread Alexey Budankov
On 25.06.2020 15:12, Jiri Olsa wrote: > On Wed, Jun 24, 2020 at 04:39:11PM +0300, Alexey Budankov wrote: >> >> >> On 23.06.2020 17:54, Jiri Olsa wrote: >>> On Wed, Jun 17, 2020 at 11:41:30AM +0300, Alexey Budankov wrote: Implement handling of 'enable' and 'disable' control commands c

[PATCH 2/2] iommu/amd: Use 'unsigned long' for domain->pt_root

2020-06-25 Thread Joerg Roedel
From: Joerg Roedel Using atomic64_t can be quite expensive, so use unsigned long instead. This is safe because the write becomes visible atomically. Signed-off-by: Joerg Roedel --- drivers/iommu/amd/amd_iommu_types.h | 2 +- drivers/iommu/amd/iommu.c | 10 -- 2 files changed

Re: [PATCH] scsi: sd: add runtime pm to open / release

2020-06-25 Thread Alan Stern
On Thu, Jun 25, 2020 at 10:16:06AM +0200, Martin Kepplinger wrote: > On 24.06.20 15:33, Bart Van Assche wrote: > > On 2020-06-23 04:10, Martin Kepplinger wrote: > >> This add a very conservative but simple implementation for runtime PM > >> to the sd scsi driver: > >> Resume when opened (mounted) a

[PATCH 0/2] iommu/amd: Don't use atomic64_t for domain->pt_root

2020-06-25 Thread Joerg Roedel
From: Joerg Roedel Hi, a previous discussion pointed out that using atomic64_t for that purpose is a bit of overkill. This patch-set replaces it with unsigned long and introduces some helpers first to make the change more easy. Qian, can you please test these patches in your environment? You ca

[PATCH] kconfig: qconf: Fix find on split mode

2020-06-25 Thread Mauro Carvalho Chehab
The logic handling find on split mode is currently broken. Fix it, making it work again as expected. Reported-by: Maxim Levitsky Signed-off-by: Mauro Carvalho Chehab --- scripts/kconfig/qconf.cc | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/scripts/kco

Re: [RFC 2/7] fixup! media: uapi: h264: update reference lists

2020-06-25 Thread Nicolas Dufresne
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit : > Align v4l2_h264_reference to 32-bits, giving some room > for future extensions. > > Signed-off-by: Ezequiel Garcia > --- > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 3 +++ > drivers/media/v4l2-core/v4l2-ctrls.c

Re: [PATCH] irqchip/gic: Atomically update affinity

2020-06-25 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: 04c8b0f82c7d ("irqchip/gic: Make locking a BL_SWITCHER only feature"). The bot has tested the following trees: v5.7.5, v5.4.48, v4.19.129, v4.14.185, v4.9.228. v5.7.5: Build OK! v5

Re: [PATCH v5 3/3] media: vimc: Add a control to display info on test image

2020-06-25 Thread Kieran Bingham
Hi Kaaira, On 24/06/2020 14:51, Hans Verkuil wrote: > On 24/06/2020 15:43, Kaaira Gupta wrote: >> Add a control in VIMC to display information such as the correct order of >> colors for a given test pattern, brightness, hue, saturation, contrast, >> width and height at sensor over test image. >> >

Re: [PATCH 0/5] drm/etnaviv: Ignore MC bit when checking for runtime suspend

2020-06-25 Thread Guido Günther
Hi, On Tue, Mar 03, 2020 at 12:55:04PM +0100, Lucas Stach wrote: > On Mo, 2020-03-02 at 20:13 +0100, Guido Günther wrote: > > At least GC7000 fails to enter runtime suspend for long periods of time > > since > > the MC becomes busy again even when the FE is idle. The rest of the series > > makes d

Re: [RFC 5/7] media: uapi: h264: pad v4l2_ctrl_h264_pps to 64-bit

2020-06-25 Thread Nicolas Dufresne
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit : > The struct does not contain 64-bit types, and therefore > doesn't suffer from compatibility issues. > > However, having it aligned to 64-bits is cleaner and > has the advantage of allowing future extensions. This one seems a bit ran

Re: [RFC PATCH v2] sched_pair_cpu: Introduce scheduler task pairing system call

2020-06-25 Thread Mathieu Desnoyers
- On Jun 24, 2020, at 3:50 PM, Peter Zijlstra pet...@infradead.org wrote: > On Wed, Jun 24, 2020 at 02:31:33PM -0400, Mathieu Desnoyers wrote: > [...] > >> >> + /* >> >> + * Consume CPU time as long as an associated task is running on another >> >> + * CPU. >> >> + */ >> >> + while (READ_

Enabling interrupts in QEMU TPM TIS

2020-06-25 Thread Stefan Berger
Hello!  I want to enable IRQs now in QEMU's TPM TIS device model and I need to work with the following patch to Linux TIS. I am wondering whether the changes there look reasonable to you? Windows works with the QEMU modifications as-is, so maybe it's a bug in the TIS code (which I had not run

Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus

2020-06-25 Thread Lee Jones
On Thu, 25 Jun 2020, Masahiro Yamada wrote: > On Thu, Jun 25, 2020 at 3:16 AM Lee Jones wrote: > > > > On Thu, 25 Jun 2020, Masahiro Yamada wrote: > > > > > On Tue, Jun 23, 2020 at 9:24 PM Lee Jones wrote: > > > > > > > > On Tue, 23 Jun 2020, Masahiro Yamada wrote: > > > > > > > > > 'make ARCH=a

Re: [PATCH v8 09/13] perf stat: implement control commands handling

2020-06-25 Thread Alexey Budankov
On 25.06.2020 15:14, Jiri Olsa wrote: > On Wed, Jun 24, 2020 at 05:10:10PM +0300, Alexey Budankov wrote: >> >> On 23.06.2020 17:54, Jiri Olsa wrote: >>> On Wed, Jun 17, 2020 at 11:41:30AM +0300, Alexey Budankov wrote: >>> >>> SNIP >>> while (1) { if (forks) @@

Re: [PATCH v2] Fix undefined operation VMXOFF during reboot and crash

2020-06-25 Thread David P. Reed
Correction to my comment below. On Thursday, June 25, 2020 10:45am, "David P. Reed" said: > [Sorry: this is resent because my mailer included HTML, rejected by LKML] > Thanks for the response, Sean ... I had thought everyone was too busy to > follow up > from the first version. >   > I confess I

[PATCH 1/2] irqchip/gicv3: Spell out when pseudo-NMIs are enabled

2020-06-25 Thread Alexandru Elisei
When NMIs cannot be enabled, the driver prints a message stating that unambiguously. When they are enabled, the only feedback we get is a message regarding the use of synchronization for ICC_PMR_EL1 writes, which is not as useful for a user who is not intimately familiar with how NMIs are implement

[PATCH 2/2] irqchip/gic-v3: Support pseudo-NMIs when SCR_EL3.FIQ == 0

2020-06-25 Thread Alexandru Elisei
The GIC's internal view of the priority mask register and the assigned interrupt priorities are based on whether GIC security is enabled and whether firmware routes Group 0 interrupts to EL3. At the moment, we support priority masking when ICC_PMR_EL1 and interrupt priorities are either both modifi

[PATCH 0/2] irqchip/gic-v3: Support pseudo-NMIs when SCR_EL3.FIQ == 0

2020-06-25 Thread Alexandru Elisei
Trusted Firmware-A's default interrupt routing model is to clear SCR_EL3.FIQ, which is the only case that GICv3 doesn't support. This series tries to fix that by detecting it at runtime and using a different priority value for ICC_PMR_EL1 when masking regular interrupts. As a result, we will be abl

RE: [PATCH 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency

2020-06-25 Thread Doug Smythies
Hi Srinivas, I saw your V3. I do not understand your reluctance to use arch/x86/include/asm/msr-index.h as the place to define anything MSR related. Please explain. One more comment about 1/3 of the way down below. ... Doug On 2020.06.23 08:53 Doug Smythies wrote: > On 2020.06.22 22:13 Sriniv

[PATCH RFC] s390x/vmem: get rid of memory segment list

2020-06-25 Thread David Hildenbrand
I can't come up with a satisfying reason why we still need the memory segment list. We used to represent in the list: - boot memory - standby memory added via add_memory() - loaded dcss segments When loading/unloading dcss segments, we already track them in a separate list and check for overlaps (

Re: [RFC 4/7] media: uapi: h264: increase size of fields

2020-06-25 Thread Nicolas Dufresne
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit : > Slice header syntax element 'first_mb_in_slice' can point > to the last macroblock, currently the field can only reference > 65536 macroblocks which is insufficient for 8K videos. > > DPB entry PicNum maximum value is 2*MaxFrameNum f

Re: [RFC 6/7] media: uapi: h264: Clean slice invariants syntax elements

2020-06-25 Thread Nicolas Dufresne
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit : > The H.264 specification requires in its "Slice header semantics" > section that the following values shall be the same in all slice headers: > > pic_parameter_set_id > frame_num > field_pic_flag > bottom_field_flag > idr_pi

Re: Search function in xconfig is partially broken after recent changes

2020-06-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Jun 2020 15:53:46 +0300 Maxim Levitsky escreveu: > On Thu, 2020-06-25 at 13:17 +0200, Mauro Carvalho Chehab wrote: > > Em Thu, 25 Jun 2020 12:59:15 +0200 > > Mauro Carvalho Chehab escreveu: > > > > > Hi Maxim, > > > > > > Em Thu, 25 Jun 2020 12:25:10 +0300 > > > Maxim Levitsky es

Re: [RFC 3/7] media: uapi: h264: clarify pic_order_cnt_bit_size field

2020-06-25 Thread Nicolas Dufresne
Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit : > From: Philipp Zabel > > Since pic_order_cnt_bit_size is not a syntax element itself, explicitly > state that it is the total size in bits of the pic_order_cnt_lsb, > delta_pic_order_cnt_bottom, delta_pic_order_cnt[0], and > delta_pi

Re: [PATCH v5 0/7] arm_pmu: Use NMI for perf interrupt

2020-06-25 Thread Alexandru Elisei
Hi, On 6/17/20 12:38 PM, Alexandru Elisei wrote: > The series makes the arm_pmu driver use NMIs for the perf interrupt when > NMIs are available on the platform (currently, only arm64 + GICv3). To make > it easier to play with the patches, I've pushed a branch at [1]: > > $ git clone -b pmu-nmi-v5

Re: [PATCH] mm: Skip opportunistic reclaim for dma pinned pages

2020-06-25 Thread Michal Hocko
On Thu 25-06-20 12:00:47, Chris Wilson wrote: > Quoting Michal Hocko (2020-06-25 08:57:25) > > On Wed 24-06-20 20:14:17, Chris Wilson wrote: > > > A general rule of thumb is that shrinkers should be fast and effective. > > > They are called from direct reclaim at the most incovenient of times when

Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx firmware folder

2020-06-25 Thread Arnd Bergmann
On Thu, Jun 25, 2020 at 2:54 PM Anson Huang wrote: > > Subject: Re: [PATCH V2] firmware: imx: Move i.MX SCU soc driver into imx > > firmware folder > > On Thu, Jun 25, 2020 at 2:27 AM Anson Huang > > wrote: > > This makes separate loadable modules out of the driver when > > CONFIG_IMX_SCU=m, in

Re: [PATCH v3 04/17] arm64: dts: sc7180: Add OPP table for all qup devices

2020-06-25 Thread Matthias Kaehlcke
Hi Rajendra, On Tue, Apr 28, 2020 at 07:02:52PM +0530, Rajendra Nayak wrote: > qup has a requirement to vote on the performance state of the CX domain > in sc7180 devices. Add OPP tables for these and also add power-domains > property for all qup instances. > > Signed-off-by: Rajendra Nayak > --

pending output optimization: was: [PATCH v3 3/3] printk: use the lockless ringbuffer

2020-06-25 Thread Petr Mladek
On Thu 2020-06-18 16:55:19, John Ogness wrote: > Replace the existing ringbuffer usage and implementation with > lockless ringbuffer usage. Even though the new ringbuffer does not > require locking, all existing locking is left in place. Therefore, > this change is purely replacing the underlining

Re: [PATCH v1] driver core: Fix suspend/resume order issue with deferred probe

2020-06-25 Thread Rafael J. Wysocki
On Thu, Jun 25, 2020 at 5:24 AM Saravana Kannan wrote: > > Under the following conditions: > - driver A is built in and can probe device-A > - driver B is a module and can probe device-B > - device-A is supplier of device-B > > Without this patch: > 1. device-A is added. > 2. device-B is added. >

syslog size unread: was: [PATCH v3 3/3] printk: use the lockless ringbuffer

2020-06-25 Thread Petr Mladek
On Thu 2020-06-18 16:55:19, John Ogness wrote: > Replace the existing ringbuffer usage and implementation with > lockless ringbuffer usage. Even though the new ringbuffer does not > require locking, all existing locking is left in place. Therefore, > this change is purely replacing the underlining

Re: [PATCH v3 0/2] sched: Optionally skip uclamp logic in fast path

2020-06-25 Thread Lukasz Luba
Hi Qais, On 6/24/20 6:26 PM, Qais Yousef wrote: This series attempts to address the report that uclamp logic could be expensive sometimes and shows a regression in netperf UDP_STREAM under certain conditions. The first patch is a fix for how struct uclamp_rq is initialized which is required by

Re: [PATCH] regulator: rename da903x to da903x-regulator

2020-06-25 Thread Mark Brown
On Wed, 24 Jun 2020 12:10:10 -0500, Seth Forshee wrote: > This module shares the same name as its parent PMIC driver, which > confuses tools like kmod. Rename the regulator driver to avoid > such problems. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-ne

[PATCH 1/2] io-wq: compact io-wq flags numbers

2020-06-25 Thread Pavel Begunkov
Renumerate IO_WQ flags, so they take adjacent bits Signed-off-by: Pavel Begunkov --- fs/io-wq.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/io-wq.h b/fs/io-wq.h index 071f1a997800..04239dfb12b0 100644 --- a/fs/io-wq.h +++ b/fs/io-wq.h @@ -5,10 +5,10 @@ struct i

[PATCH for-5.9 0/2] clean io_wq->do_work()

2020-06-25 Thread Pavel Begunkov
Small io-wq cleanups after getting rid of per-work callbacks. Pavel Begunkov (2): io-wq: compact io-wq flags numbers io-wq: return next work from ->do_work() directly fs/io-wq.c| 8 +++- fs/io-wq.h| 10 +- fs/io_uring.c | 53 --

[PATCH 2/2] io-wq: return next work from ->do_work() directly

2020-06-25 Thread Pavel Begunkov
It's easier to return next work from ->do_work() than having an in-out argument. Looks nicer and easier to compile. Also, merge io_wq_assign_next() into its only user. Signed-off-by: Pavel Begunkov --- fs/io-wq.c| 8 +++- fs/io-wq.h| 2 +- fs/io_uring.c | 53 ---

Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups

2020-06-25 Thread Randy Dunlap
On 6/24/20 11:24 PM, Richard Weinberger wrote: > - Ursprüngliche Mail - >> Von: "Kees Cook" >> An: "Randy Dunlap" >> CC: "Richard Weinberger" , "richard" >> , "Greg Kroah-Hartman" >> , "Prasad Sodagudi" , >> "Sami Tolvanen" , >> "Amit Daniel Kachhap" , "linux-kselftest" >> , "clang-bui

Re: record_printk_text tricks: was: [PATCH v3 3/3] printk: use the lockless ringbuffer

2020-06-25 Thread Petr Mladek
On Thu 2020-06-25 14:09:46, Petr Mladek wrote: > On Thu 2020-06-18 16:55:19, John Ogness wrote: > > Replace the existing ringbuffer usage and implementation with > > lockless ringbuffer usage. Even though the new ringbuffer does not > > require locking, all existing locking is left in place. Theref

Re: [PATCH v6 6/6] spi: spi-qcom-qspi: Use OPP API to set clk/perf state

2020-06-25 Thread Matthias Kaehlcke
On Wed, Jun 24, 2020 at 11:12:45AM -0700, Matthias Kaehlcke wrote: > On Wed, Jun 24, 2020 at 07:00:05PM +0100, Mark Brown wrote: > > On Wed, Jun 24, 2020 at 10:55:36AM -0700, Matthias Kaehlcke wrote: > > > On Wed, Jun 24, 2020 at 06:44:17PM +0100, Mark Brown wrote: > > > > > > Wait, so *some* of t

Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-06-25 Thread Don Porter
On 5/29/20 11:27 AM, Wojtek Porczyk wrote: On Thu, May 28, 2020 at 11:38:01AM -0700, Andy Lutomirski wrote: One useful test for the actual kernel patches would be to run your SGX workload on a loaded core. That is, do something like taskset -c 0 graphene_thing and, simultaneously, write a trivi

Re: [RFC 2/7] fixup! media: uapi: h264: update reference lists

2020-06-25 Thread Tomasz Figa
On Tue, Jun 23, 2020 at 8:29 PM Ezequiel Garcia wrote: > > Align v4l2_h264_reference to 32-bits, giving some room > for future extensions. > > Signed-off-by: Ezequiel Garcia > --- > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 3 +++ > drivers/media/v4l2-core/v4l2-ctrls.c | 16

Re: [RFC 4/7] media: uapi: h264: increase size of fields

2020-06-25 Thread Ezequiel Garcia
On Thu, 2020-06-25 at 11:01 -0400, Nicolas Dufresne wrote: > Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit : > > Slice header syntax element 'first_mb_in_slice' can point > > to the last macroblock, currently the field can only reference > > 65536 macroblocks which is insufficient fo

Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-06-25 Thread Don Porter
On 5/28/20 11:10 PM, Jarkko Sakkinen wrote: On Fri, May 29, 2020 at 06:07:23AM +0300, Jarkko Sakkinen wrote: Is there something then readily available to test such workload with SGX enabled? Or should I go patching Graphene? Not sure what I should take from that comment :-) For me the main poi

Re: [PATCH v33 03/21] x86/mm: x86/sgx: Signal SIGSEGV with PF_SGX

2020-06-25 Thread Sean Christopherson
On Thu, Jun 25, 2020 at 10:59:31AM +0200, Borislav Petkov wrote: > On Thu, Jun 18, 2020 at 01:08:25AM +0300, Jarkko Sakkinen wrote: > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > > index 66be9bd60307..25d48aae36c1 100644 > > --- a/arch/x86/mm/fault.c > > +++ b/arch/x86/mm/fault.c > >

[PATCH 1/1] staging: media: soc_camera: Adding parentheses to macro defination at line 241, Clearing alignment issues at lines 410 and 1270, fixing return values at EPOLLERR

2020-06-25 Thread B K Karthik
staging: media: soc_camera: soc_camera.c: Clearing coding-style problem "Macros with complex values should be enclosed in parentheses" in line 241 by adding parentheses. staging: media: soc_camera: soc_camera.c: Clearing coding-style problem "Alignment should match open parenthesis" by adding tab

[PATCH 1/2] fix trailing */ in block comment

2020-06-25 Thread Coiby Xu
Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_main.c | 3 ++- drivers/staging/qlge/qlge_mpi.c | 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 1650de13842f..aaecf2b0f9a1 100644 --- a

[PATCH 2/2] fix else after return or break

2020-06-25 Thread Coiby Xu
Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 23 ++- drivers/staging/qlge/qlge_main.c | 8 drivers/staging/qlge/qlge_mpi.c | 4 ++-- 3 files changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging

Re: [PATCH 2/2] iommu/amd: Use 'unsigned long' for domain->pt_root

2020-06-25 Thread Qian Cai
On Thu, Jun 25, 2020 at 04:52:27PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Using atomic64_t can be quite expensive, so use unsigned long instead. > This is safe because the write becomes visible atomically. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/amd/amd_iommu_types.h

[PATCH 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-06-25 Thread Andres Beltran
Currently, pointers to guest memory are passed to Hyper-V as transaction IDs in storvsc. In the face of errors or malicious behavior in Hyper-V, storvsc should not expose or trust the transaction IDs returned by Hyper-V to be valid guest memory addresses. Instead, use small integers generated by vm

Re: [rcu:rcu/next 35/35] kernel/rcu/tree.c:251:8: error: implicit declaration of function 'arch_atomic_add_return'; did you mean

2020-06-25 Thread Paul E. McKenney
On Thu, Jun 25, 2020 at 04:11:25PM +0200, Peter Zijlstra wrote: > On Thu, Jun 25, 2020 at 01:29:26PM +0200, Peter Zijlstra wrote: > > I fear the same. Let me see if I can quickly modify the atomic scripts > > to generate the required fallbacks. > > Something like so ought to work, I suppose. Than

[PATCH 1/3] Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus hardening

2020-06-25 Thread Andres Beltran
Currently, VMbus drivers use pointers into guest memory as request IDs for interactions with Hyper-V. To be more robust in the face of errors or malicious behavior from a compromised Hyper-V, avoid exposing guest memory addresses to Hyper-V. Also avoid Hyper-V giving back a bad request ID that is t

[PATCH 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-06-25 Thread Andres Beltran
Currently, pointers to guest memory are passed to Hyper-V as transaction IDs in netvsc. In the face of errors or malicious behavior in Hyper-V, netvsc should not expose or trust the transaction IDs returned by Hyper-V to be valid guest memory addresses. Instead, use small integers generated by vmbu

[PATCH 0/3] Drivers: hv: vmbus: vmbus_requestor data structure

2020-06-25 Thread Andres Beltran
From: Andres Beltran (Microsoft) Currently, VMbus drivers use pointers into guest memory as request IDs for interactions with Hyper-V. To be more robust in the face of errors or malicious behavior from a compromised Hyper-V, avoid exposing guest memory addresses to Hyper-V. Also avoid Hyper-V giv

[PATCH v4 0/2] sched: Optionally skip uclamp logic in fast path

2020-06-25 Thread Qais Yousef
This series attempts to address the report that uclamp logic could be expensive sometimes and shows a regression in netperf UDP_STREAM under certain conditions. The first patch is a fix for how struct uclamp_rq is initialized which is required by the 2nd patch which contains the real 'fix'. Worth

[PATCH v4 1/2] sched/uclamp: Fix initialization of struct uclamp_rq

2020-06-25 Thread Qais Yousef
struct uclamp_rq was zeroed out entirely in assumption that in the first call to uclamp_rq_inc() they'd be initialized correctly in accordance to default settings. But when next patch introduces a static key to skip uclamp_rq_{inc,dec}() until userspace opts in to use uclamp, schedutil will fail t

[PATCH v4 2/2] sched/uclamp: Protect uclamp fast path code with static key

2020-06-25 Thread Qais Yousef
There is a report that when uclamp is enabled, a netperf UDP test regresses compared to a kernel compiled without uclamp. https://lore.kernel.org/lkml/20200529100806.ga3...@suse.de/ While investigating the root cause, there were no sign that the uclamp code is doing anything particularly expensiv

[PATCH net-next 3/8] net: phy: mscc: ptp: fix a smatch error

2020-06-25 Thread Antoine Tenart
The following error was reported by smatch: vsc85xx_ts_read_csr() error: uninitialized symbol 'blk_hw'. In practice this is very unlikely, as all the block identifiers given to this functions are handled and described in an enum. The smatch error is fixed by doing what is already done in vsc85xx_t

[PATCH net-next 8/8] net: phy: mscc: improve vsc8514/8584_config_init consistency

2020-06-25 Thread Antoine Tenart
All PHY read and write return values are checked for errors in vsc8514_config_init and vsc8584_config_init, except for one. Fix this. Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc_main.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/ph

[PATCH net-next 7/8] net: phy: mscc: remove useless page configuration in the config init

2020-06-25 Thread Antoine Tenart
In the middle of vsc8584_config_init and vsc8514_config_init, the page is set to 'standard'. This is the default value, and the page isn't set to another value before. Those pages configuration can be safely removed. Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc_main.c | 7 ---

[PATCH net-next 4/8] net: phy: mscc: ptp: fix a typo in a comment

2020-06-25 Thread Antoine Tenart
This patch fixes a typo in a comment, s/Ths/This/. The patch is cosmetic only. Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mscc/mscc_ptp.c b/drivers/net/phy/mscc/mscc_ptp.c index 030a56c9a06

[PATCH net-next 1/8] net: phy: mscc: macsec: fix sparse warnings

2020-06-25 Thread Antoine Tenart
This patch fixes the following sparse warnings when building MACsec support in the MSCC PHY driver. mscc_macsec.c:393:42: warning: cast from restricted sci_t mscc_macsec.c:395:42: warning: restricted sci_t degrades to integer mscc_macsec.c:402:42: warning: restricted __be16 degrades to integ

[PATCH net-next 6/8] net: phy: mscc: restore the base page in vsc8514/8584_config_init

2020-06-25 Thread Antoine Tenart
In the vsc8584_config_init and vsc8514_config_init, the base page is set to 'GPIO', configuration is done, and the page is never explicitly restored to the standard page. No bug was triggered as it turns out helpers called in those config_init functions do modify the base page, and set it back to s

[PATCH net-next 0/8] net: phy: mscc: multiple improvements

2020-06-25 Thread Antoine Tenart
Hello, This series contains various improvements to the MSCC PHY driver, fixing sparse and smatch warnings, using functions provided by the PHY core, and improving the driver consistency and maintenance. I don't think any of those improvements and fixes is worth backporting to stable trees. Than

[PATCH net-next 2/8] net: phy: mscc: fix a possible double unlock

2020-06-25 Thread Antoine Tenart
On vsc8584_ptp_init failure we jump to the 'err' label, which unlocks the MDIO bus lock. But vsc8584_ptp_init isn't called with the MDIO bus lock taken, which could result in a double unlock. Fix this. Fixes: ab2bf9339357 ("net: phy: mscc: 1588 block initialization") Reported-by: kernel test robot

[PATCH net-next 5/8] net: phy: mscc: do not access the MDIO bus lock directly

2020-06-25 Thread Antoine Tenart
This patch improves the MSCC driver by using the provided phy_lock_mdio_bus and phy_unlock_mdio_bus helpers instead of locking and unlocking the MDIO bus lock directly. The patch is only cosmetic but should improve maintenance and consistency. Signed-off-by: Antoine Tenart --- drivers/net/phy/ms

Re: [PATCH v2] Kernel selftests: TPM2: upgrade TPM2 tests from Python 2 to Python 3

2020-06-25 Thread Pengfei Xu
On 2020-06-25 at 02:14:57 +0300, Jarkko Sakkinen wrote: > On Tue, Jun 23, 2020 at 07:41:55PM +0800, Pengfei Xu wrote: > > I tried to use bytes(parm, encoding='UTF-8') way, it met the situation > > that sometimes parm is string, sometimes parm is bytes. > > We need to do right things right, i.e

[PATCH v3 0/3] ALSA: compress: Document stream states and fix gapless SM

2020-06-25 Thread Vinod Koul
Srini found issue with gapless implementation which prompted to look deeper into SM for compressed stream. So documenting SM was first step, so first two patches add that. Last patch fixes the issue by keeping track on partial_drain and then moving state to 'running' in snd_compr_drain_notify() fo

[PATCH v3 2/3] ALSA: compress: document the compress gapless audio state machine

2020-06-25 Thread Vinod Koul
Also documented the galpess transitions. Please note that these are not really stream states, but show how the stream steps in gapless mode Signed-off-by: Vinod Koul --- .../sound/designs/compress-offload.rst| 32 +++ 1 file changed, 32 insertions(+) diff --git a/Documen

[PATCH v3 3/3] ALSA: compress: fix partial_drain completion state

2020-06-25 Thread Vinod Koul
On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING state, so set that for partially draining streams in snd_compr_drain_notify() and use a flag for partially draining streams While at it, add locks for stream state change in snd_compr_drain_notify() as well. Fixes: f44f2a5417b2 (

[PATCH v3 1/3] ALSA: compress: document the compress audio state machine

2020-06-25 Thread Vinod Koul
So we had some discussions of the stream states, so I thought it is a good idea to document the state transitions, so add it documentation Signed-off-by: Vinod Koul --- .../sound/designs/compress-offload.rst| 51 +++ 1 file changed, 51 insertions(+) diff --git a/Document

Re: [PATCH] [v2] media: venus: core: Fix runtime PM imbalance in venus_probe

2020-06-25 Thread Stanimir Varbanov
Hi Dinghao, On 6/24/20 9:30 AM, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. For other error > paths after this call, things are

Re: [PATCH 4.14 000/139] 4.14.186-rc3 review

2020-06-25 Thread Guenter Roeck
On Wed, Jun 24, 2020 at 07:26:56PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.186 release. > There are 139 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kn

Re: [PATCH 4.19 000/207] 4.19.130-rc3 review

2020-06-25 Thread Guenter Roeck
On Wed, Jun 24, 2020 at 07:27:18PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.130 release. > There are 207 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kn

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

2020-06-25 Thread Guenter Roeck
On Mon, Jun 22, 2020 at 11:50:52AM +0530, Sai Prakash Ranjan wrote: > On 2020-06-21 13:03, Bjorn Andersson wrote: > > On Tue 16 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote: > > > > > Hi Bjorn, > > > > > > > Hi Sai, > > > > > On 2020-02-12 03:54, Sai Prakash Ranjan wrote: > > > > This series co

Re: [PATCH v8 04/13] perf stat: factor out body of event handling loop for system wide

2020-06-25 Thread Alexey Budankov
On 25.06.2020 15:17, Jiri Olsa wrote: > On Wed, Jun 24, 2020 at 05:27:41PM +0300, Alexey Budankov wrote: >> >> On 23.06.2020 17:56, Jiri Olsa wrote: >>> On Wed, Jun 17, 2020 at 11:37:43AM +0300, Alexey Budankov wrote: Introduce process_timeout() and process_interval() functions that >>>

[PATCH -next] scsi: ufs: ufs-exynos: Fix build warning

2020-06-25 Thread Alim Akhtar
While building for x86_64 allmodconfig, below warning reported WARNING: modpost: missing MODULE_LICENSE() in drivers/scsi/ufs/ufs-exynos.o Add the missing license/author/description tags. Fixes: 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs") Reported-by: Stephen Ro

Re: [PATCH] mm: Skip opportunistic reclaim for dma pinned pages

2020-06-25 Thread Matthew Wilcox
On Thu, Jun 25, 2020 at 03:40:44PM +0200, Jan Kara wrote: > On Thu 25-06-20 12:42:09, Matthew Wilcox wrote: > > Why are DMA pinned pages still on the LRU list at all? I never got an > > answer to this that made sense to me. By definition, a page which is > > pinned for DMA is being accessed, and

Re: [PATCH 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency

2020-06-25 Thread srinivas pandruvada
Hi Doug, On Thu, 2020-06-25 at 07:59 -0700, Doug Smythies wrote: > Hi Srinivas, > > I saw your V3. > I do not understand your reluctance to use > > arch/x86/include/asm/msr-index.h I don't have reluctance. That was the guidance from x86 core maintainers years back. But may have changed. So chec

[PATCH] brcmfmac: Transform compatible string for FW loading

2020-06-25 Thread matthias . bgg
From: Matthias Brugger The driver relies on the compatible string from DT to determine which FW configuration file it should load. The DTS spec allows for '/' as part of the compatible string. We change this to '-' so that we will still be able to load the config file, even when the compatible ha

Re: [PATCH 0/4] platform/chrome: typec: Add mux support

2020-06-25 Thread Prashant Malani
Thanks Enric! On Thu, Jun 25, 2020 at 4:56 AM Enric Balletbo i Serra wrote: > > Hi Prashant, > > On 28/5/20 13:36, Prashant Malani wrote: > > This series adds mux control support for USB and DP alternate modes on > > devices using the cros-ec-typec driver with Type C switch handles > > provided b

Re: [PATCH] efi/libstub: EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER should not default to yes

2020-06-25 Thread Ard Biesheuvel
On Tue, 23 Jun 2020 at 17:09, Geert Uytterhoeven wrote: > > EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER is deprecated, so it should not > be enabled by default. > > In light of commit 4da0b2b7e67524cc ("efi/libstub: Re-enable command > line initrd loading for x86"), keep the default for X86. > > Fixes:

Re: [PATCH 02/22] kbuild: add support for Clang LTO

2020-06-25 Thread Sami Tolvanen
On Wed, Jun 24, 2020 at 07:26:47PM -0700, Nathan Chancellor wrote: > Hi Sami, > > On Wed, Jun 24, 2020 at 01:31:40PM -0700, 'Sami Tolvanen' via Clang Built > Linux wrote: > > This change adds build system support for Clang's Link Time > > Optimization (LTO). With -flto, instead of ELF object file

Re: [PATCH 04/22] kbuild: lto: fix recordmcount

2020-06-25 Thread Sami Tolvanen
On Thu, Jun 25, 2020 at 09:45:30AM +0200, Peter Zijlstra wrote: > On Wed, Jun 24, 2020 at 02:45:30PM -0700, Sami Tolvanen wrote: > > On Wed, Jun 24, 2020 at 11:27:37PM +0200, Peter Zijlstra wrote: > > > On Wed, Jun 24, 2020 at 01:31:42PM -0700, Sami Tolvanen wrote: > > > > With LTO, LLVM bitcode wo

Re: [PATCH v3 09/10] kallsyms: Hide layout

2020-06-25 Thread Kristen Carlson Accardi
On Wed, 2020-06-24 at 08:18 -0700, Kees Cook wrote: > On Wed, Jun 24, 2020 at 12:21:16PM +0200, Jann Horn wrote: > > On Tue, Jun 23, 2020 at 7:26 PM Kristen Carlson Accardi > > wrote: > > > This patch makes /proc/kallsyms display alphabetically by symbol > > > name rather than sorted by address in

Re: [PATCH 05/22] kbuild: lto: postpone objtool

2020-06-25 Thread Sami Tolvanen
On Thu, Jun 25, 2020 at 09:47:16AM +0200, Peter Zijlstra wrote: > On Wed, Jun 24, 2020 at 02:49:25PM -0700, Sami Tolvanen wrote: > > On Wed, Jun 24, 2020 at 11:19:08PM +0200, Peter Zijlstra wrote: > > > On Wed, Jun 24, 2020 at 01:31:43PM -0700, Sami Tolvanen wrote: > > > > diff --git a/include/linu

Re: [PATCH 1/2] KVM: X86: Move ignore_msrs handling upper the stack

2020-06-25 Thread Sean Christopherson
On Thu, Jun 25, 2020 at 10:09:13AM +0200, Paolo Bonzini wrote: > On 25/06/20 08:15, Sean Christopherson wrote: > > IMO, kvm_cpuid() is simply buggy. If KVM attempts to access a non-existent > > MSR then it darn well should warn. > > > > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c > >

[PATCH v3] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3

2020-06-25 Thread Pengfei Xu
Python 2 is no longer supported by the Python upstream project, so upgrade TPM2 tests to Python 3. Signed-off-by: Pengfei Xu --- tools/testing/selftests/tpm2/test_smoke.sh | 4 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- tools/testing/selftests/tpm2/tpm2.py | 56 +++

Re: [GIT PULL] s390 updates for 5.8-rc3

2020-06-25 Thread pr-tracker-bot
The pull request you sent on Thu, 25 Jun 2020 14:03:27 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git tags/s390-5.8-3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/908f7d12d3ba51dfe0449b9723199b423f97ca9a Thank you! -- Deet-doot-dot, I am a b

Re: [GIT PULL] sound fixes for 5.8-rc3

2020-06-25 Thread pr-tracker-bot
The pull request you sent on Thu, 25 Jun 2020 13:34:48 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > tags/sound-5.8-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a4d3712b510534ef2ab5b15429aa94283c233a31 Thank you! -- Deet-doot-dot, I

[PATCH 07/10] mfd: si476x-cmd: Add missing colon(s) for all documented kerneldoc arguments

2020-06-25 Thread Lee Jones
Kerneldoc validation gets confused if syntax isn't "@.*: ". Adding the missing colons squashes the following W=1 warnings: drivers/mfd/si476x-cmd.c:525: warning: Function parameter or member 'dout' not described in 'si476x_core_cmd_dig_audio_pin_c drivers/mfd/si476x-cmd.c:525: warning: Functio

<    1   2   3   4   5   6   7   8   9   10   >