Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

2020-06-24 Thread Greg KH
On Thu, Jun 25, 2020 at 07:46:18AM +0100, Lee Jones wrote: > Kerneldoc valication gets confused if syntax isn't "@.*: ". > > Adding the missing colons squashes the following W=1 warnings: > > drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not > described in 'atmel_smc_

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

2020-06-24 Thread Greg KH
On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/mfd/wm8350-core.c:136: warning: Function parameter or member > 'wm8350' not described in 'wm8350_reg_lock' > drivers/mfd/wm83

[PATCH 2/2] net: ethernet: mvneta: Add back interface mode validation

2020-06-24 Thread Sascha Hauer
When writing the serdes configuration register was moved to mvneta_config_interface() the whole code block was removed from mvneta_port_power_up() in the assumption that its only purpose was to write the serdes configuration register. As mentioned by Russell King its purpose was also to check for v

[PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes

2020-06-24 Thread Sascha Hauer
In mvneta_config_interface() the RGMII modes are catched by the default case which is an error return. The RGMII modes are valid modes for the driver, so instead of returning an error add a break statement to return successfully. This avoids this warning for non comphy SoCs which use RGMII, like S

[PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

2020-06-24 Thread Phu Luu
Assign the .throttle and .unthrottle functions to be generic function in the driver structure to prevent data loss that can otherwise occur if the host does not enable USB throttling. Signed-off-by: Phu Luu Signed-off-by: Brant Merryman --- 06/09/2020: Patch v3 1/2 Modified based on feedback fro

[PATCH] dt-bindings: pci: convert QCOM pci bindings to YAML

2020-06-24 Thread Sivaprakash Murugesan
Convert QCOM pci bindings to YAML schema Signed-off-by: Sivaprakash Murugesan --- .../devicetree/bindings/pci/qcom,pcie.txt | 330 --- .../devicetree/bindings/pci/qcom,pcie.yaml | 470 + 2 files changed, 470 insertions(+), 330 deletions(-) delete

Re: [PATCH v2] swiotlb: Adjust SWIOTBL bounce buffer size for SEV guests.

2020-06-24 Thread Ashish Kalra
On Wed, Jun 24, 2020 at 12:23:57AM +, Ashish Kalra wrote: > Hello Konrad, > > On Tue, Jun 23, 2020 at 09:38:43AM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Apr 27, 2020 at 06:53:18PM +, Ashish Kalra wrote: > > > Hello Konrad, > > > > > > On Mon, Mar 30, 2020 at 10:25:51PM +, Ashi

linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-06-24 Thread Stephen Rothwell
Hi all, In commit 46da547e21d6 ("scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()") Fixes tag Fixes: 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset") has these problem(s): - Subject does not match target commit subject Just use

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-24 Thread Sam Ravnborg
Hi Enric. On Tue, Jun 23, 2020 at 05:16:43PM +0200, Enric Balletbo i Serra wrote: > Hi Sam, > > Many thanks for your feedback. See my answers below. > > On 20/6/20 23:42, Sam Ravnborg wrote: > > Hi Enric. > > > > On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote: > >> The g

Re: [PATCH v3 2/2] USB: serial: cp210x: Proper RTS control when buffers fill

2020-06-24 Thread gre...@linuxfoundation.org
On Wed, Jun 24, 2020 at 07:03:04AM +, Phu Luu wrote: > CP210x hardware disables auto-RTS but leaves auto-CTS when > in hardware flow control mode and UART on cp210x hardware > is disabled. This allows data to flow out, but new data > will not come into the port. When re-opening the port, if > a

Re: [PATCH v3 08/10] x86: Add support for function granular KASLR

2020-06-24 Thread Kees Cook
On Tue, Jun 23, 2020 at 10:23:25AM -0700, Kristen Carlson Accardi wrote: > This commit contains the changes required to re-layout the kernel text > sections generated by -ffunction-sections shortly after decompression. > Documentation of the feature is also added. > [...] > Signed-off-by: Kristen C

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-06-24 Thread SeongJae Park
On Wed, 24 Jun 2020 17:07:42 +1000 Stephen Rothwell wrote: > > [-- Attachment #1: Type: text/plain, Size: 385 bytes --] > > Hi all, > > In commit > > 46da547e21d6 ("scsi: lpfc: Avoid another null dereference in > lpfc_sli4_hba_unset()") > > Fixes tag > > Fixes: 1ffdd2c0440d ("scsi: lp

Re: Strange problem with SCTP+IPv6

2020-06-24 Thread Xin Long
On Wed, Jun 24, 2020 at 5:48 AM Michael Tuexen wrote: > > > On 23. Jun 2020, at 23:31, Marcelo Ricardo Leitner > > wrote: > > > > On Tue, Jun 23, 2020 at 11:24:59PM +0200, Michael Tuexen wrote: > >>> On 23. Jun 2020, at 23:21, Marcelo Ricardo Leitner > >>> wrote: > >>> > >>> On Tue, Jun 23, 20

Re: linux-next: build failure after merge of the drm-misc tree

2020-06-24 Thread Stephen Rothwell
Hi Dave, On Wed, 24 Jun 2020 15:47:49 +1000 Dave Airlie wrote: > > My bad, my local builds passed, as I had made the change but forgot > the commit --amend > > Pushed out a new head with it in it now. Excellent, thanks. -- Cheers, Stephen Rothwell pgpwhIJQqFVu5.pgp Description: OpenPGP digi

[PATCH v2] scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()

2020-06-24 Thread SeongJae Park
From: SeongJae Park Commit cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp with general hdw_queues per cpu") has introduced static checker warnings for potential null dereferences in 'lpfc_sli4_hba_unset()' and commit 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning in lp

RE: [PATCH V6 0/9] Support i.MX8 SoCs pinctrl drivers built as module

2020-06-24 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 24, 2020 2:24 PM > > There are more and mroe requirements that SoC specific modules should be > built as module in order to support generic kernel image, such as Android GKI > concept. > > This patch series supports i.MX8 SoCs pinctrl drivers to be bui

GCC_PLUGIN_RANDSTRUCT being set breaks 5.8-rc2 build

2020-06-24 Thread Caleb Jorden
Hi everyone, I was trying to test out the 5.8-rc2 kernel using my standard machine-specific config, but my build kept failing. I ended up comparing against the x86_64_defconfig configuration (which worked) using the config-bisect.pl script, and discovered that if GCC_PLUGIN_RANDSTRUCT is set, I g

Re: [PATCH v3 09/10] kallsyms: Hide layout

2020-06-24 Thread Kees Cook
On Tue, Jun 23, 2020 at 10:23:26AM -0700, Kristen Carlson Accardi wrote: > This patch makes /proc/kallsyms display alphabetically by symbol > name rather than sorted by address in order to hide the newly > randomized address layout. > > Signed-off-by: Kristen Carlson Accardi > Reviewed-by: Tony L

Re: [RESEND PATCH] mm: fix migrate_vma_setup() src_owner and normal pages

2020-06-24 Thread Christoph Hellwig
On Tue, Jun 23, 2020 at 10:05:19AM -0700, Ralph Campbell wrote: > > On 6/23/20 4:40 AM, Christoph Hellwig wrote: >> On Mon, Jun 22, 2020 at 03:20:08PM -0700, Ralph Campbell wrote: >>> The caller of migrate_vma_setup() does not know what type of page is >>> stored in the CPU's page tables. Pages wit

Re: [PATCH 1/2] block: add initial kdoc over the request_queue

2020-06-24 Thread Johannes Thumshirn
On 24/06/2020 00:04, Luis Chamberlain wrote: > + * o make_request block drivers (multiqueue) I don't think the differentiation between singlequeue and multiqueue is usefull, given that the single queue block layer is gone for quite some time now.

[PATCH v4 2/3] hwmon: add Documentation

2020-06-24 Thread Marius Zachmann
Signed-off-by: Marius Zachmann --- Documentation/hwmon/corsair-cpro.rst | 40 Documentation/hwmon/index.rst| 1 + 2 files changed, 41 insertions(+) create mode 100644 Documentation/hwmon/corsair-cpro.rst diff --git a/Documentation/hwmon/corsair-cpro.rst b/

[PATCH v4 3/3] hwmon: add driver

2020-06-24 Thread Marius Zachmann
Signed-off-by: Marius Zachmann --- MAINTAINERS | 6 + drivers/hwmon/Kconfig| 10 + drivers/hwmon/Makefile | 1 + drivers/hwmon/corsair-cpro.c | 489 +++ 4 files changed, 506 insertions(+) create mode 100644 drivers/hwmon/corsair

[PATCH v4 0/3] hwmon: Add Corsair Commander Pro driver

2020-06-24 Thread Marius Zachmann
This is v4 of a driver for the Corsair Commander Pro. It provides sysfs attributes for: - Reading fan speed - Reading temp sensors - Reading voltage values - Writing pwm and reading last written pwm - Reading fan and temp connection status It is an usb driver, so it needs to be ignored by usbhid.

[PATCH v4 1/3] input: add to hid_ignore_list

2020-06-24 Thread Marius Zachmann
Signed-off-by: Marius Zachmann --- drivers/hid/hid-quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index ca8b5c261c7c..7b7bc7737c53 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -699,6 +699,8 @@ static co

Re: linux-next: Fixes tag needs some work in the scsi-fixes tree

2020-06-24 Thread Stephen Rothwell
Hi SeongJae, On Wed, 24 Jun 2020 09:14:47 +0200 SeongJae Park wrote: > > Oops, sorry for the mistake. I will send the fixed version in reply to this. Unless Martin says otherwise, I am not sure it is worth fixing. Just remember for next time. -- Cheers, Stephen Rothwell pgpQ6W27QwTmT.pgp D

Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups

2020-06-24 Thread Richard Weinberger
- Ursprüngliche Mail - >>> Regardless, it seems arch/x86/um/asm/desc.h is not needed any more? > >> True that, we can rip the file. > > Has anyone fixed the uml build errors? I didn't realize that this is a super urgent issue. ;-) Kees, if you want you can carry a patch in your series,

Re: [PATCH 2/2] block: move request_queue member docs to kdoc

2020-06-24 Thread Johannes Thumshirn
On 24/06/2020 00:03, Luis Chamberlain wrote: > + * @debugfs_mutex: used to protect access to the @ebugfs_dir > * @debugfs_mutex: used to protect access to the @debugfs_dir This line is duplicated and one of dups has a typo 'ebugfs_dir'

Re: [RESEND PATCH 2/3] nouveau: fix mixed normal and device private page migration

2020-06-24 Thread Christoph Hellwig
On Mon, Jun 22, 2020 at 04:38:53PM -0700, Ralph Campbell wrote: > The OpenCL function clEnqueueSVMMigrateMem(), without any flags, will > migrate memory in the given address range to device private memory. The > source pages might already have been migrated to device private memory. > In that case,

Re: [dm-devel] [dm-crypt] [RFC PATCH 1/1] Add DM_CRYPT_FORCE_INLINE flag to dm-crypt target

2020-06-24 Thread Damien Le Moal
On 2020/06/24 14:27, Eric Biggers wrote: > On Wed, Jun 24, 2020 at 05:21:24AM +, Damien Le Moal wrote: @@ -1458,13 +1459,18 @@ static void crypt_alloc_req_skcipher(struct crypt_config *cc, skcipher_request_set_tfm(ctx->r.req, cc->cipher_tfm.tfms[key_index]); >>>

Re: [PATCH v3 09/10] kallsyms: Hide layout

2020-06-24 Thread Kees Cook
On Tue, Jun 23, 2020 at 10:23:26AM -0700, Kristen Carlson Accardi wrote: > +static int kallsyms_open(struct inode *inode, struct file *file) > +{ > + int ret; > + struct list_head *list; > + > + list = __seq_open_private(file, &kallsyms_sorted_op, sizeof(*list)); > + if (!list) > +

Re: [PATCH v2 1/2] sched/uclamp: Fix initialization of strut uclamp_rq

2020-06-24 Thread Patrick Bellasi
Hi Qais, On Fri, Jun 19, 2020 at 19:20:10 +0200, Qais Yousef wrote... > struct uclamp_rq was zeroed out entirely in assumption that in the first > call to uclamp_rq_inc() they'd be initialized correctly in accordance to > default settings. > > But when next patch introduces a static key to sk

RE: [PATCH v1] scsi: ufs: Disable WriteBooster capability in non-supported UFS device

2020-06-24 Thread Avri Altman
> > > If UFS device is not qualified to enter the detection of WriteBooster > probing by disallowed UFS version or device quirks, then WriteBooster > capability in host shall be disabled to prevent any WriteBooster > operations in the future. Fixes: ? > > Signed-off-by: Stanley Chu > ---

[PATCH] net: macb: free resources on failure path of at91ether_open()

2020-06-24 Thread Claudiu Beznea
DMA buffers were not freed on failure path of at91ether_open(). Along with changes for freeing the DMA buffers the enable/disable interrupt instructions were moved to at91ether_start()/at91ether_stop() functions and the operations on at91ether_stop() were done in their reverse order (compared with

Re: [PATCH][next] dmaengine: ti: k3-udma: Use struct_size() in kzalloc()

2020-06-24 Thread Vinod Koul
On 23-06-20, 22:56, Joe Perches wrote: > On Wed, 2020-06-24 at 11:25 +0530, Vinod Koul wrote: > > On 19-06-20, 17:43, Gustavo A. R. Silva wrote: > > > Make use of the struct_size() helper instead of an open-coded version > > > in order to avoid any potential type mistakes. > > > > > > This code wa

[PATCH v3 09/14] irqchip/mscc-ocelot: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 19d99164480a ("irqchip: Add a driver for the Microsemi Ocelot controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-mscc-ocelot.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 02/14] irqchip/csky-apb-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: edff1b4835b7 ("irqchip: add C-SKY APB bus interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-apb-intc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v3 03/14] irqchip/csky-mpintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: d8a5f5f79122 ("irqchip: add C-SKY SMP interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-mpintc.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/

[PATCH v3 05/14] irqchip/davinci-cp-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0fc3d74cf946 ("irqchip: davinci-cp-intc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-cp-intc.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-)

[PATCH v3 00/14] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
When I test the irqchip code of Loongson, I read the related code of other chips in drivers/irqchip and I find some potential resource leaks in the error path, I think it is better to fix them. v2: - Split the first patch into a new patch series which includes small patches and add "Fixes" t

[PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0145beed9d26 ("irqchip: davinci-aintc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-aintc.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff

[PATCH v3 01/14] irqchip/ath79-misc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 07ba4b061a79 ("irqchip/ath79-misc: Move the MISC driver from arch/mips/ath79/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ath79-misc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff -

[PATCH v3 07/14] irqchip/dw-apb-ictl: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 350d71b94fc9 ("irqchip: add DesignWare APB ICTL interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-dw-apb-ictl.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH v3 10/14] irqchip/nvic: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 292ec080491d ("irqchip: Add support for ARMv7-M NVIC") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-nvic.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-nvic.c b

Re: linux-next: build failures after merge of the hid tree

2020-06-24 Thread Jiri Kosina
On Wed, 24 Jun 2020, Jiri Kosina wrote: > > > I don't know what caused it, but commit > > > > > > 470376737e88 ("HID: allow building hid.ko as an external module") > > > > > > did not fix it. BTW, I build with "make O=...". > > That's actually the patch that almost certainly broke it. > > C

[PATCH v3 08/14] irqchip/ls1x: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ls1x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-

[PATCH v3 11/14] irqchip/omap-intc: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 8598066cddd1 ("arm: omap: irq: move irq.c to drivers/irqchip/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-omap-intc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-omap-in

Re: [PATCH v2 06/12] arm64: dts: qcom: msm8994: Add SCM node

2020-06-24 Thread Bjorn Andersson
On Tue 23 Jun 16:30 PDT 2020, Konrad Dybcio wrote: > >Shouldn't this be "qcom,scm-msm8992", "qcom,scm" ? > > > >(Or rather "qcom,scm-msm8994", "qcom,scm") > > Some DTs only have the SoC-specific one, and some also > have the generic one. But I can add the generic one if > you wish. > > I went wi

Re: [PATCH V3 1/3] clk: vc5: Allow Versaclock driver to support multiple instances

2020-06-24 Thread Geert Uytterhoeven
Hi Adam, On Wed, Jun 3, 2020 at 5:44 PM Adam Ford wrote: > Currently, the Versaclock driver is only expecting one instance and > uses hard-coded names for the various clock names. Unfortunately, > this is a problem when there is more than one instance of the driver, > because the subsequent inst

Re: [PATCH v2 2/2] sched/uclamp: Protect uclamp fast path code with static key

2020-06-24 Thread Patrick Bellasi
On Fri, Jun 19, 2020 at 19:20:11 +0200, Qais Yousef wrote... [...] > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 4265861e13e9..9ab22f699613 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -793,6 +793,25 @@ unsigned int sysctl_sched_uclamp_util_max = > S

[PATCH v3 06/14] irqchip/digicolor: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 8041dfbd31cf ("irqchip: Conexant CX92755 interrupts controller driver") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-digicolor.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/dri

Re: [PATCH 1/2] dmaengine: fsl-edma: Add lockdep assert for exported function

2020-06-24 Thread Vinod Koul
On 11-06-20, 14:17, Krzysztof Kozlowski wrote: > Add lockdep assert for an exported function expected to be called under > spin lock. Since this function is called in different modules, the > lockdep assert will be self-documenting note about need for locking. Applied all to fixes, thanks -- ~Vi

Re: [PATCH v2] dma-pool: Fix too large DMA pools on medium systems

2020-06-24 Thread Christoph Hellwig
Hi Guenter, can you try the patch below? This just converts the huge allocations in mptbase to use GFP_KERNEL. Christophe (added to Cc) actually has a scripted conversion for the rest that he hasn't posted yet, so I'll aim for the minimal version here. diff --git a/drivers/message/fusion/mptba

Re: [PATCH v3 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-06-24 Thread Reddy, MallikarjunaX
Thanks Thomas for the review. My comments inline. On 6/23/2020 6:49 PM, Langer, Thomas wrote: Hi, I have some questions about the binding. Sorry I missed to ask during internal review, as I was busy with other tasks at that time. See my questions below. -Original Message- From: devi

Re: [PATCH] dmaengine: stm32-dmamux: fix pm_runtime_get_sync fialure cases

2020-06-24 Thread Vinod Koul
On 03-06-20, 14:36, Navid Emamdoost wrote: s/fialure/failure > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put_sync if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost > --- > drivers/dma/stm32-dmamux

Re: [PATCH] engine: stm32-dma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-24 Thread Vinod Koul
On 03-06-20, 13:34, Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. pls fix subsystem name as dmaengine: ... > > Signed-off-by: Navid Emamdoost > --- > drivers

Re: [PATCH v3 00/10] Function Granular KASLR

2020-06-24 Thread Kees Cook
On Tue, Jun 23, 2020 at 10:23:17AM -0700, Kristen Carlson Accardi wrote: > Function Granular Kernel Address Space Layout Randomization (fgkaslr) I've built and booted this successfully with both GCC/bfd and Clang/lld: gcc (Ubuntu 9.3.0-10ubuntu2) 9.3.0 GNU ld (GNU Binutils for Ubuntu) 2.34 clang

[PATCH v2] scsi: ufs: Disable WriteBooster capability in non-supported UFS device

2020-06-24 Thread Stanley Chu
If UFS device is not qualified to enter the detection of WriteBooster probing by disallowed UFS version or device quirks, then WriteBooster capability in host shall be disabled to prevent any WriteBooster operations in the future. Fixes: 3d17b9b5ab11 ("scsi: ufs: Add write booster feature support"

Re: [PATCH v1] dmaengine: pl330: Make sure the debug is idle before doing DMAGO

2020-06-24 Thread Vinod Koul
On 04-06-20, 09:36, Sugar Zhang wrote: > According to the datasheet of pl330: > > Example 2-1 Using DMAGO with the debug instruction registers > > 1. Create a program for the DMA channel > 2. Store the program in a region of system memory > 3. Poll the DBGSTATUS Register to ensure that the debug

Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

2020-06-24 Thread Johan Hovold
On Wed, Jun 24, 2020 at 07:01:33AM +, Phu Luu wrote: > Assign the .throttle and .unthrottle functions to be generic function > in the driver structure to prevent data loss that can otherwise occur > if the host does not enable USB throttling. > > Signed-off-by: Phu Luu > Signed-off-by: Brant

Re: [PATCH] dma_async_tx_descriptor: Fix null pointer dereference

2020-06-24 Thread Vinod Koul
On 03-06-20, 22:59, gaurav singh wrote: > The check: if (chan && (!len || !dest || !src)) indicates that chan can be > NULL, however chan is dereferenced in multiple locations later without > check. In the function: sf_pdma_alloc_desc() and later: chan->desc = desc; > This can cause segmentation fa

[PATCH v3 02/14 RESEND] irqchip/csky-apb-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: edff1b4835b7 ("irqchip: add C-SKY APB bus interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-apb-intc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v3 01/14 RESEND] irqchip/ath79-misc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 07ba4b061a79 ("irqchip/ath79-misc: Move the MISC driver from arch/mips/ath79/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ath79-misc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff -

[PATCH v3 03/14 RESEND] irqchip/csky-mpintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: d8a5f5f79122 ("irqchip: add C-SKY SMP interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-csky-mpintc.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/

[PATCH v3 09/14 RESEND] irqchip/mscc-ocelot: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 19d99164480a ("irqchip: Add a driver for the Microsemi Ocelot controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-mscc-ocelot.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
[git send-email failed due to too many commands, so only cc the major related email and resend it, sorry for that] When I test the irqchip code of Loongson, I read the related code of other chips in drivers/irqchip and I find some potential resource leaks in the error path, I think it is better

[PATCH v3 07/14 RESEND] irqchip/dw-apb-ictl: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 350d71b94fc9 ("irqchip: add DesignWare APB ICTL interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-dw-apb-ictl.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH v3 10/14 RESEND] irqchip/nvic: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 292ec080491d ("irqchip: Add support for ARMv7-M NVIC") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-nvic.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-nvic.c b

RE: [PATCH v2] scsi: ufs: Disable WriteBooster capability in non-supported UFS device

2020-06-24 Thread Avri Altman
> > If UFS device is not qualified to enter the detection of WriteBooster > probing by disallowed UFS version or device quirks, then WriteBooster > capability in host shall be disabled to prevent any WriteBooster > operations in the future. > > Fixes: 3d17b9b5ab11 ("scsi: ufs: Add write booster

RE: [PATCH v1] scsi: ufs: Disable WriteBooster capability in non-supported UFS device

2020-06-24 Thread Stanley Chu
Hi Avri, On Wed, 2020-06-24 at 07:26 +, Avri Altman wrote: > > > > > > If UFS device is not qualified to enter the detection of WriteBooster > > probing by disallowed UFS version or device quirks, then WriteBooster > > capability in host shall be disabled to prevent any WriteBooster > > oper

[PATCH v3 11/14 RESEND] irqchip/omap-intc: Fix potential resource leak

2020-06-24 Thread Tiezhu Yang
There exists potential resource leak in the error path, fix it. Fixes: 8598066cddd1 ("arm: omap: irq: move irq.c to drivers/irqchip/") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-omap-intc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-omap-in

[PATCH v3 08/14 RESEND] irqchip/ls1x: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-ls1x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-

[PATCH v3 05/14 RESEND] irqchip/davinci-cp-intc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0fc3d74cf946 ("irqchip: davinci-cp-intc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-cp-intc.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-)

Re: [PATCH] dmaengine: stm32-mdma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-24 Thread Vinod Koul
On 03-06-20, 13:28, Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost > --- > drivers/dma/stm32-mdma.c | 8 ++-- > 1 file c

[PATCH v3 06/14 RESEND] irqchip/digicolor: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 8041dfbd31cf ("irqchip: Conexant CX92755 interrupts controller driver") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-digicolor.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/dri

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Lee Jones
On Tue, 23 Jun 2020, Frank Rowand wrote: > On 2020-06-23 14:59, Lee Jones wrote: > > Suggestion #2 > > > >> 2) Modify patch 1/3. The small part of the patch to modify is: > >> > >> +static int mfd_match_of_node_to_dev(struct platform_device *pdev, > >> +

Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-24 Thread Arnd Bergmann
On Wed, Jun 24, 2020 at 4:19 AM Aisheng Dong wrote: > > Isn't that what we want? > > No, if user set MXC_CLK to m, the build will break for i.MX6&7. > > > Why does ARCH_MXC being enabled mandate that it is > > builtin? Is some architecture level code calling into the clk driver? > > > It's mainly

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Michael Walle
Hi, Am 2020-06-24 08:41, schrieb Lee Jones: On Tue, 23 Jun 2020, Frank Rowand wrote: On 2020-06-11 14:10, Lee Jones wrote: > Currently, when a child platform device (sometimes referred to as a > sub-device) is registered via the Multi-Functional Device (MFD) API, > the framework attempts to ma

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-24 Thread David Hildenbrand
On 23.06.20 17:18, Michal Hocko wrote: > On Tue 23-06-20 17:42:58, Wei Yang wrote: >> For early sections, we assumes its memmap will never be partially >> removed. But current behavior breaks this. >> >> Let's correct it. >> >> Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") >> Si

Re: [PATCH] engine: stm32-dma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-24 Thread Navid Emamdoost
Hi, On Wed, Jun 24, 2020 at 2:39 AM Vinod Koul wrote: > > On 03-06-20, 13:34, Navid Emamdoost wrote: > > Calling pm_runtime_get_sync increments the counter even in case of > > failure, causing incorrect ref count. Call pm_runtime_put if > > pm_runtime_get_sync fails. > > pls fix subsystem name as

Re: [dm-devel] [dm-crypt] [RFC PATCH 1/1] Add DM_CRYPT_FORCE_INLINE flag to dm-crypt target

2020-06-24 Thread Damien Le Moal
On 2020/06/24 14:05, Eric Biggers wrote: > On Fri, Jun 19, 2020 at 05:41:32PM +0100, Ignat Korchagin wrote: >> Sometimes extra thread offloading imposed by dm-crypt hurts IO latency. This >> is >> especially visible on busy systems with many processes/threads. Moreover, >> most >> Crypto API impl

Re: [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT

2020-06-24 Thread Jacopo Mondi
Hello On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH wrote: > From: Steve Longerbeam > +Niklas, +Laurent Niklas, Laurent, how does this play with CAP_IO_MC ? Thanks j > This commit enables VIDIOC_ENUMINPUT, VIDIOC_G_INPUT, and VIDIOC_S_INPUT > ioctls for use via v4l2 subdevice

[PATCH v3 04/14 RESEND] irqchip/davinci-aintc: Fix potential resource leaks

2020-06-24 Thread Tiezhu Yang
There exists potential resource leaks in the error path, fix them. Fixes: 0145beed9d26 ("irqchip: davinci-aintc: move the driver to drivers/irqchip") Signed-off-by: Tiezhu Yang --- drivers/irqchip/irq-davinci-aintc.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff

drivers/net/wireless/st/cw1200/txrx.c:766:15: sparse: struct ieee80211_sta __rcu COPYING CREDITS Documentation Kbuild Kconfig LICENSES MAINTAINERS Makefile README arch block certs crypto drivers fs in

2020-06-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3e08a95294a4fb3702bb3d35ed08028433c37fe6 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 6 days ago config: x86_64-randconfig-s021-20200624

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-24 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 02:44:33PM -0700, Paul E. McKenney wrote: > On Tue, Jun 23, 2020 at 10:46:46PM +0200, Peter Zijlstra wrote: > > On Fri, Jun 19, 2020 at 03:15:55PM -0700, Paul E. McKenney wrote: > > > > > Just following up because I don't see this anywhere. If I am supposed > > > to take t

linux-next: Signed-off-by missing for commit in the hid tree

2020-06-24 Thread Stephen Rothwell
Hi all, Commit 6d7ccae2e093 ("Revert "HID: allow building hid.ko as an external module"") is missing a Signed-off-by from its author and committer. Reverts are commits as well and need SOB tags and (preferably) an explanatory commit message. -- Cheers, Stephen Rothwell pgpORdUwLTdtc.pgp D

Re: [PATCH v3 1/1] fs: move kernel_read_file* to its own include file

2020-06-24 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v2 01/13] dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP'

2020-06-24 Thread Vinod Koul
On 09-06-20, 09:14, Sugar Zhang wrote: > There is no reason to limit the performance on the 'NO-FLUSHP' SoCs, > cuz these platforms are just that the 'FLUSHP' instruction is broken. Lets not use terms like cuz... 'because' is perfect term :) It can rephrased to: There is no reason to limit the pe

Re: linux-next: Signed-off-by missing for commit in the hid tree

2020-06-24 Thread Jiri Kosina
On Wed, 24 Jun 2020, Stephen Rothwell wrote: > Commit > > 6d7ccae2e093 ("Revert "HID: allow building hid.ko as an external module"") > > is missing a Signed-off-by from its author and committer. > > Reverts are commits as well and need SOB tags and (preferably) an > explanatory commit message

Re: [PATCH v3 5/5] iommu/uapi: Support both kernel and user unbind guest PASID

2020-06-24 Thread Lu Baolu
Hi Jacob, On 2020/6/24 1:03, Jacob Pan wrote: Guest SVA unbind data can come from either kernel and user space, if a either kernel or user space user pointer is passed in, IOMMU driver must copy from data from user. copy data from user If the unbind data is assembled in kernel, data can

Re: [PATCH 02/10] media: mtk-vcodec: add SCP firmware ops

2020-06-24 Thread Tiffany Lin
On Tue, 2020-06-16 at 22:17 +0900, Alexandre Courbot wrote: > On Mon, Jun 8, 2020 at 7:47 PM Tiffany Lin wrote: > > > > On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > > > From: Yunfei Dong > > > > > > Add support for communicating with the SCP firmware, which will be used > > > by

Re: [PATCH 9/9] mm, slab/slub: move and improve cache_from_obj()

2020-06-24 Thread Vlastimil Babka
On 6/18/20 12:10 PM, Vlastimil Babka wrote: > 8< > From b8df607d92b37e5329ce7bda62b2b364cc249893 Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Thu, 18 Jun 2020 11:52:03 +0200 > Subject: [PATCH] mm, slab/slub: improve error reporting and overhead of > cache_from_obj() > Anothe

Re: [PATCH v3 9/9] arm64/build: Warn on orphan section placement

2020-06-24 Thread Will Deacon
On Tue, Jun 23, 2020 at 06:49:40PM -0700, Kees Cook wrote: > We don't want to depend on the linker's orphan section placement > heuristics as these can vary between linkers, and may change between > versions. All sections need to be explicitly named in the linker > script. > > Avoid .eh_frame* by

Re: [PATCH] dmaengine: stm32-dmamux: fix pm_runtime_get_sync fialure cases

2020-06-24 Thread Navid Emamdoost
On Wed, Jun 24, 2020 at 2:40 AM Vinod Koul wrote: > > On 03-06-20, 14:36, Navid Emamdoost wrote: > > s/fialure/failure > > > Calling pm_runtime_get_sync increments the counter even in case of > > failure, causing incorrect ref count. Call pm_runtime_put_sync if > > pm_runtime_get_sync fails. > > >

Re: [PATCH v2 1/2] nvme: Add Arbitration Burst support

2020-06-24 Thread Baolin Wang
On Wed, Jun 24, 2020 at 08:52:58AM +0200, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 02:49:57PM +0800, Baolin Wang wrote: > > >From the NVMe spec, "In order to make efficient use of the non-volatile > > memory, it is often advantageous to execute multiple commands from a > > Submission Queu

[PATCH v4 2/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Jisheng Zhang
Call phy_disable_interrupts() in phy_init_hw() to "have a defined init state as we don't know in which state the PHY is if the PHY driver is loaded. We shouldn't assume that it's the chip power-on defaults, BIOS or boot loader could have changed this. Or in case of dual-boot systems the other OS co

[PATCH v4 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Jisheng Zhang
We face an issue with rtl8211f, a pin is shared between INTB and PMEB, and the PHY Register Accessible Interrupt is enabled by default, so the INTB/PMEB pin is always active in polling mode case. As Heiner pointed out "I was thinking about calling phy_disable_interrupts() in phy_init_hw(), to have

[PATCH v4 1/2] net: phy: make phy_disable_interrupts() non-static

2020-06-24 Thread Jisheng Zhang
We face an issue with rtl8211f, a pin is shared between INTB and PMEB, and the PHY Register Accessible Interrupt is enabled by default, so the INTB/PMEB pin is always active in polling mode case. As Heiner pointed out "I was thinking about calling phy_disable_interrupts() in phy_init_hw(), to have

Re: brocken devfreq simple_ondemand for Odroid XU3/4?

2020-06-24 Thread Willy Wolff
Hi Krzysztof, Thanks to look at it. mem_gov is /sys/class/devfreq/10c2.memory-controller/governor Here some numbers after increasing the running time: Running using simple_ondemand: Before: From : To

Re: linux-next: build failures after merge of the hid tree

2020-06-24 Thread Cristian Klein
On Wed, Jun 24, 2020 at 09:30:23AM +0200, Jiri Kosina wrote: > On Wed, 24 Jun 2020, Jiri Kosina wrote: > > > > > I don't know what caused it, but commit > > > > > > > > 470376737e88 ("HID: allow building hid.ko as an external module") > > > > > > > > did not fix it. BTW, I build with "make O=

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-24 Thread Ignat Korchagin
On Wed, Jun 24, 2020 at 6:22 AM Mike Snitzer wrote: > > On Wed, Jun 24 2020 at 12:54am -0400, > Damien Le Moal wrote: > > > On 2020/06/24 0:23, Mike Snitzer wrote: > > > On Tue, Jun 23 2020 at 11:07am -0400, > > > Ignat Korchagin wrote: > > > > > >> Do you think it may be better to break it in t

<    5   6   7   8   9   10   11   12   13   14   >