[PATCH v3 2/6] dt-bindings: power: supply: Extend max17040 compatibility

2020-06-24 Thread Iskren Chernev
Maxim max17040 is a fuel gauge from a larger family utilising the Model Gauge technology. Document all different compatible strings that the max17040 driver recognizes. Some devices in the wild report double the capacity. The maxim,double-soc (from State-Of-Charge) property fixes that. Signed-off

Re: [PATCH 10/22] gpiolib: cdev: fix minor race in GET_LINEINFO_WATCH

2020-06-24 Thread Kent Gibson
On Wed, Jun 24, 2020 at 05:46:33PM +0300, Andy Shevchenko wrote: > On Tue, Jun 23, 2020 at 7:03 AM Kent Gibson wrote: > > > > Merge separate usage of test_bit/set_bit into test_and_set_bit to remove > > the possibility of a race between the test and set. > > > > Similarly test_bit and clear_bit. >

[PATCH v3 4/6] dt-bindings: power: supply: max17040: Add maxim,rcomp

2020-06-24 Thread Iskren Chernev
To compensate for the battery chemistry and operating conditions the chips support a compensation value. Specify one or two byte compensation via the maxim,rcomp byte array. Signed-off-by: Iskren Chernev --- .../devicetree/bindings/power/supply/max17040_battery.txt | 6 ++ 1 file changed,

Re: Null-ptr-deref due to "vfs, fsinfo: Add an RCU safe per-ns mount list"

2020-06-24 Thread Qian Cai
067.486969][T72863] general protection fault, probably for non-canonical address 0xdc00: [#1] SMP KASAN PTI [ 9067.543973][T72863] KASAN: null-ptr-deref in range [0x-0x0007] [ 9067.586640][T72863] CPU: 24 PID: 72863 Comm: runc:[2:INIT] Not tainted 5.8.0

[PATCH v3 3/6] power: supply: max17040: Support compatible devices

2020-06-24 Thread Iskren Chernev
The max17040 fuel gauge is part of a family of 8 chips that have very similar mode of operations and registers. This change adds: - compatible strings for all supported devices and handling for the minor differences between them; - handling for devices reporting double capacity via maxim,double-

[PATCH v3 5/6] power: supply: max17040: Support setting rcomp

2020-06-24 Thread Iskren Chernev
The Maxim ModelGauge family supports fine-tuning by setting a compensation value (named rcomp in the docs). The value is affected by battery chemistry and ambient temperature. Add support for reading maxim,rcomp from DT and configuring the device with the supplied value. Temperature adjustment is

Re: [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq

2020-06-24 Thread Peter Zijlstra
On Thu, Jun 18, 2020 at 02:18:23PM -0700, Doug Anderson wrote: > Hi, > > On Fri, Jun 12, 2020 at 5:52 AM Qais Yousef wrote: > > > > On 06/10/20 15:18, Douglas Anderson wrote: > > > + struct sched_attr sched_attr = { > > > + .sched_policy = SCHED_FIFO, > > > + .sched

[PATCH] afs: Fix storage of cell names

2020-06-24 Thread David Howells
The cell name stored in the afs_cell struct is a 64-char + NUL buffer - when it needs to be able to handle up to AFS_MAXCELLNAME (256 chars) + NUL. Fix this by changing the array to a pointer and allocating the string. Found using Coverity. Fixes: 989782dcdc91 ("afs: Overhaul cell database manag

Re: [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq

2020-06-24 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 05:40:21PM +0100, Qais Yousef wrote: > On 06/22/20 11:21, Doug Anderson wrote: > > [...] > > > > If you propose something that will help the discussion. I think based on > > > the > > > same approach Peter has taken to prevent random RT priorities. In uclamp > > > case >

drivers/pci/switch/switchtec.c:1075:23: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-06-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3e08a95294a4fb3702bb3d35ed08028433c37fe6 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 6 days ago config: arm-randconfig-s031-20200624 (attached

Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-24 Thread Steven Rostedt
On Wed, 24 Jun 2020 16:45:24 +0800 Nicolas Boichat wrote: > trace_printk is only meant as a debugging tool, and should never be > compiled into production code without source code changes, as > indicated by the warning that shows up on boot if any trace_printk > is called: > ** NOTICE NOTICE N

Re: [PATCH stable 4.9 00/21] Unbreak 32-bit DVB applications on 64-bit kernels

2020-06-24 Thread Greg KH
On Wed, Jun 24, 2020 at 08:41:06AM -0700, Florian Fainelli wrote: > > > On 6/23/2020 12:13 PM, Greg KH wrote: > > On Fri, Jun 05, 2020 at 09:24:57AM -0700, Florian Fainelli wrote: > >> Hi all, > >> > >> This long patch series was motivated by backporting Jaedon's changes > >> which add a proper i

Re: [PATCH] [perf] intel_pt_recording_options: Remove redundant intel_pt_evsel null check

2020-06-24 Thread Adrian Hunter
On 24/06/20 3:42 pm, Jiri Olsa wrote: > On Tue, Jun 23, 2020 at 07:48:50PM -0400, Gaurav Singh wrote: >> intel_pt_evsel cannot be NULL here since its already being >> dereferenced above. Remove this redundant check. >> >> Signed-off-by: Gaurav Singh >> --- >> tools/perf/arch/x86/util/intel-pt.c |

Re: [PATCH] [perf] intel_pt_recording_options: Remove redundant intel_pt_evsel null check

2020-06-24 Thread Adrian Hunter
On 24/06/20 2:48 am, Gaurav Singh wrote: > intel_pt_evsel cannot be NULL here since its already being > dereferenced above. Remove this redundant check. > > Signed-off-by: Gaurav Singh Acked-by: Adrian Hunter > --- > tools/perf/arch/x86/util/intel-pt.c | 24 +++- > 1 file

Re: [PATCH 5.7 000/474] 5.7.6-rc2 review

2020-06-24 Thread Greg Kroah-Hartman
On Wed, Jun 24, 2020 at 11:32:40AM +0100, Jon Hunter wrote: > > On 24/06/2020 07:10, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.7.6 release. > > There are 474 patches in this series, all will be posted as a response > > to this one. If anyone has any issu

Re: [PATCH 09/15] net: phy: delay PHY driver probe until PHY registration

2020-06-24 Thread Florian Fainelli
On 6/24/2020 6:48 AM, Bartosz Golaszewski wrote: > śr., 24 cze 2020 o 11:43 Mark Brown napisał(a): >> >> On Tue, Jun 23, 2020 at 12:49:15PM -0700, Florian Fainelli wrote: >>> On 6/22/20 6:51 AM, Mark Brown wrote: >> If the bus includes power management for the devices on the bus the c

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Luis Chamberlain
On Wed, Jun 24, 2020 at 05:54:46PM +0200, Christian Borntraeger wrote: > > > On 24.06.20 16:43, Christoph Hellwig wrote: > > On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: > >> Does anyone have an idea why "umh: fix processed error when UMH_WAIT_PROC > >> is used" breaks

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-24 Thread Dan Williams
On Tue, Jun 23, 2020 at 11:14 PM Wei Yang wrote: > > On Tue, Jun 23, 2020 at 05:18:28PM +0200, Michal Hocko wrote: > >On Tue 23-06-20 17:42:58, Wei Yang wrote: > >> For early sections, we assumes its memmap will never be partially > >> removed. But current behavior breaks this. > >> > >> Let's cor

wait_on_page_bit_common(TASK_KILLABLE, EXCLUSIVE) can miss wakeup?

2020-06-24 Thread Oleg Nesterov
Suppose that 2 threads T1 and T2 call __lock_page_killable() and sleep in wait_on_page_bit_common() -> io_schedule(). T1 is killed, it does test_and_set_bit_lock() but the page is still locked. unlock_page() calls __wake_up_common(nr_exclusive = 1), this wakes T1 up. T2 is not woken. T1 checks s

[PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning

2020-06-24 Thread Ethan Edwards
`sizeof buf` changed to `sizeof(buf)` Signed-off-by: Ethan Edwards --- security/selinux/ss/conditional.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c index 0cc7cdd58465..90a2f5927e55 100644 --- a/se

clean up kernel_{read,write} & friends v5

2020-06-24 Thread Christoph Hellwig
Hi Al, this series fixes a few issues and cleans up the helpers that read from or write to kernel space buffers, and ensures that we don't change the address limit if we are using the ->read_iter and ->write_iter methods that don't need the changed address limit. I did not add your suggested comm

[PATCH 08/14] fs: don't change the address limit for ->write_iter in __kernel_write

2020-06-24 Thread Christoph Hellwig
If we write to a file that implements ->write_iter there is no need to change the address limit if we send a kvec down. Implement that case, and prefer it over using plain ->write with a changed address limit if available. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 34 ++

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Luis Chamberlain
On Wed, Jun 24, 2020 at 01:17:25PM +, Luis Chamberlain wrote: > I found however an LTP bug indicating the need to test for > s390 wait macros [0] in light of a recent bug in glibc for s390. > I am asking for references to that issue given I cannot find > any mention of this on glibc yet. > > [

[PATCH 12/14] fs: remove __vfs_read

2020-06-24 Thread Christoph Hellwig
Fold it into the two callers. Signed-off-by: Christoph Hellwig --- fs/read_write.c| 43 +-- include/linux/fs.h | 1 - 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index a0a0b5d1d9249c..6a2170eaee64

[PATCH 14/14] fs: don't change the address limit for ->read_iter in __kernel_read

2020-06-24 Thread Christoph Hellwig
If we read to a file that implements ->read_iter there is no need to change the address limit if we send a kvec down. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/fs/read_write.

[PATCH 10/14] integrity/ima: switch to using __kernel_read

2020-06-24 Thread Christoph Hellwig
__kernel_read has a bunch of additional sanity checks, and this moves the set_fs out of non-core code. Signed-off-by: Christoph Hellwig --- security/integrity/iint.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/security/integrity/iint.c b/security/integrity/

[PATCH 02/14] autofs: switch to kernel_write

2020-06-24 Thread Christoph Hellwig
While pipes don't really need sb_writers projection, __kernel_write is an interface better kept private, and the additional rw_verify_area does not hurt here. Signed-off-by: Christoph Hellwig Acked-by: Ian Kent --- fs/autofs/waitq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH 11/14] fs: implement kernel_read using __kernel_read

2020-06-24 Thread Christoph Hellwig
Consolidate the two in-kernel read helpers to make upcoming changes easier. The only difference are the missing call to rw_verify_area in kernel_read, and an access_ok check that doesn't make sense for kernel buffers to start with. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 13 +

[PATCH 01/14] cachefiles: switch to kernel_write

2020-06-24 Thread Christoph Hellwig
__kernel_write doesn't take a sb_writers references, which we need here. Signed-off-by: Christoph Hellwig Reviewed-by: David Howells --- fs/cachefiles/rdwr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c index e7726f5f1241c2..308

[PATCH 13/14] fs: implement default_file_splice_read using __kernel_read

2020-06-24 Thread Christoph Hellwig
default_file_splice_read goes through great lenght to create an iovec array and iov_iter for all the reads, but is a helper only useful for files not implementing ->read_iter as we have the much better generic_file_splice_read version available for those. Remove the iters and just call __kernel_re

[PATCH 03/14] bpfilter: switch to kernel_write

2020-06-24 Thread Christoph Hellwig
While pipes don't really need sb_writers projection, __kernel_write is an interface better kept private, and the additional rw_verify_area does not hurt here. Signed-off-by: Christoph Hellwig --- net/bpfilter/bpfilter_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net

[PATCH 07/14] fs: remove __vfs_write

2020-06-24 Thread Christoph Hellwig
Fold it into the two callers. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 46 ++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 5110cd1e6e2771..96e8e354f99b45 100644 --- a/fs/read_writ

[PATCH 09/14] fs: add a __kernel_read helper

2020-06-24 Thread Christoph Hellwig
This is the counterpart to __kernel_write, and skip the rw_verify_area call compared to kernel_read. Signed-off-by: Christoph Hellwig --- fs/read_write.c| 23 +++ include/linux/fs.h | 1 + 2 files changed, 24 insertions(+) diff --git a/fs/read_write.c b/fs/read_write.c

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Lee Jones
On Wed, 24 Jun 2020, Frank Rowand wrote: > On 2020-06-24 02:46, Lee Jones wrote: > > On Tue, 23 Jun 2020, Frank Rowand wrote: > > > >> On 2020-06-23 14:59, Lee Jones wrote: > > < big snip > > > Thanks for the replies in the above portion. NP. > But yes or no to my solution #2 (with some

[PATCH 04/14] fs: unexport __kernel_write

2020-06-24 Thread Christoph Hellwig
This is a very special interface that skips sb_writes protection, and not used by modules anymore. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/read_write.c b/fs/read_write.c index bbfa9b12b15eb7..2c601d853ff3d8 100644 --- a/fs/read_w

[PATCH v5 2/7] ASoC: tas2562: Update shutdown GPIO property

2020-06-24 Thread Dan Murphy
Update the shutdown GPIO property to be shutdown from shut-down. Fixes: c173dba44c2d2 ("ASoC: tas2562: Introduce the TAS2562 amplifier") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2562.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2562.c b/s

[PATCH v5 0/7] TAS2562 issue fixes and slot programming

2020-06-24 Thread Dan Murphy
Hello This series fixes issues tih the shut-down gpio device tree allocation and a code format issue found. While working on a project slot programming for the tx and rx paths needed to be enabled. In addition the vsense slot programming needed to be configurable and not directly a simpler adder

[PATCH v5 2/2] arm64: dts: meson-khadas-vim3: add Khadas MCU nodes

2020-06-24 Thread Neil Armstrong
Add the Khadas MCU node with active FAN thermal nodes for all the Khadas VIM3 variants. Signed-off-by: Neil Armstrong Reviewed-by: Amit Kucheria --- Hi Kevin, The bindings has been reviewed and merged by Lee, could you apply this one via the amlogic tree ? Thanks, Neil .../boot/dts/amlogic/m

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-24 Thread Steev Klimaszewski
On 6/23/20 8:53 PM, Stanley Chu wrote: > Hi Steev, > > Please help try below simple patch to see if above WriteBooster messages > can be eliminated. > > > --- > drivers/scsi/ufs/ufshcd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshc

[PATCH 06/14] fs: implement kernel_write using __kernel_write

2020-06-24 Thread Christoph Hellwig
Consolidate the two in-kernel write helpers to make upcoming changes easier. The only difference are the missing call to rw_verify_area in kernel_write, and an access_ok check that doesn't make sense for kernel buffers to start with. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 17 +++

[PATCH v5 1/7] dt-bindings: tas2562: Fix shut-down gpio property

2020-06-24 Thread Dan Murphy
Fix the shut-down gpio property to be shut-down-gpio and fix the example. Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/sound/tas2562.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/tas2562.txt b/Documentation

[PATCH 05/14] fs: check FMODE_WRITE in __kernel_write

2020-06-24 Thread Christoph Hellwig
Add a WARN_ON_ONCE if the file isn't actually open for write. This matches the check done in vfs_write, but actually warn warns as a kernel user calling write on a file not opened for writing is a pretty obvious programming error. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 2 ++ 1 f

[PATCH v5 5/7] dt-bindings: tas2562: Add voltage sense slot property

2020-06-24 Thread Dan Murphy
Add a property to configure the slot for the voltage sense monitoring of the device. Vsense data will be sent to the processor via the slot defined by the property Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/sound/tas2562.txt | 3 +++ 1 file changed, 3 insertions(+) diff --g

[PATCH v5 1/2] thermal: add support for the MCU controlled FAN on Khadas boards

2020-06-24 Thread Neil Armstrong
The new Khadas VIM2 and VIM3 boards controls the cooling fan via the on-board microcontroller. This implements the FAN control as thermal devices and as cell of the Khadas MCU MFD driver. Signed-off-by: Neil Armstrong Reviewed-by: Amit Kucheria --- Hi Daniel, Is it ok Lee applies this patch vi

Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG

2020-06-24 Thread Fangrui Song
On 2020-06-24, Arvind Sankar wrote: On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote: When linking vmlinux with LLD, the synthetic sections .symtab, .strtab, and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section so there will be no warnings when --orphan-handling=w

[PATCH v5 3/7] ASoC: tas2562: Fix format issue for extra space before a comma

2020-06-24 Thread Dan Murphy
Fix the issue found that there is an extra space before a comma in the volume control. Fixes: bf726b1c86f2c ("ASoC: tas2562: Add support for digital volume control") Signed-off-by: Dan Murphy --- arch/arm/boot/compressed/fdt.h | 66 + arch/arm/boot/compressed/libfdt.h | 20

[PATCH v5 0/2] *mfd: Add support for Khadas Microcontroller

2020-06-24 Thread Neil Armstrong
The new Khadas VIM2, VIM3 and Edge boards embeds an on-board microcontroller connected via I2C. This Microcontroller is present on the Khadas VIM1, VIM2, VIM3 and Edge boards. It has multiple boot control features like password check, power-on options, power-off control and system FAN control on

[PATCH v5 4/7] ASoC: tas2562: Add rx and tx slot programming

2020-06-24 Thread Dan Murphy
Add programming for the tdm slots for both tx and rx offsets. Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2562.c | 17 - sound/soc/codecs/tas2562.h | 4 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas256

[PATCH v5 6/7] ASoC: tas2562: Add voltage sense slot configuration

2020-06-24 Thread Dan Murphy
Add Vsense slot configuration based on the device tree. Adding this property enables the slot programming to be moved to the tdm_set_slot callback. This in affect sets the slots for the Isense and Vsense and enabling this these modes are now based on whether these features were powered on or not.

[PATCH v5 7/7] dt-bindings: tas2562: Convert the tas2562 binding to yaml

2020-06-24 Thread Dan Murphy
Convert the TAS2562 text file to yaml format. Signed-off-by: Dan Murphy --- .../devicetree/bindings/sound/tas2562.txt | 37 - .../devicetree/bindings/sound/tas2562.yaml| 77 +++ 2 files changed, 77 insertions(+), 37 deletions(-) delete mode 100644 Documentation/d

Re: [PATCH] btrfs: tests: remove if duplicate in __check_free_space_extents()

2020-06-24 Thread David Sterba
On Mon, Jun 22, 2020 at 11:18:41PM +0300, Denis Efremov wrote: > num_extents is already checked in the next if condition and can > be safely removed. > > Signed-off-by: Denis Efremov Added to misc-next, thanks.

Re: [PATCH v5 1/2] thermal: add support for the MCU controlled FAN on Khadas boards

2020-06-24 Thread Daniel Lezcano
On 24/06/2020 18:15, Neil Armstrong wrote: > The new Khadas VIM2 and VIM3 boards controls the cooling fan via the > on-board microcontroller. > > This implements the FAN control as thermal devices and as cell of the Khadas > MCU MFD driver. > > Signed-off-by: Neil Armstrong > Reviewed-by: Amit K

Re: wait_on_page_bit_common(TASK_KILLABLE, EXCLUSIVE) can miss wakeup?

2020-06-24 Thread Oleg Nesterov
On 06/24, Oleg Nesterov wrote: > Suppose that 2 threads T1 and T2 call __lock_page_killable() and sleep in > wait_on_page_bit_common() -> io_schedule(). > > T1 is killed, it does test_and_set_bit_lock() but the page is still locked. > > unlock_page() calls __wake_up_common(nr_exclusive = 1), this w

Re: [PATCH v2] dma-pool: Fix too large DMA pools on medium systems

2020-06-24 Thread Guenter Roeck
On Wed, Jun 24, 2020 at 09:38:15AM +0200, Christoph Hellwig wrote: > Hi Guenter, > > can you try the patch below? This just converts the huge allocations > in mptbase to use GFP_KERNEL. Christophe (added to Cc) actually has > a scripted conversion for the rest that he hasn't posted yet, so I'll

Re: wait_on_page_bit_common(TASK_KILLABLE, EXCLUSIVE) can miss wakeup?

2020-06-24 Thread Linus Torvalds
On Wed, Jun 24, 2020 at 9:11 AM Oleg Nesterov wrote: > > T1 checks signal_pending_state() and returns EINTR. > > T2 will sleep until another thread does lock/unlock ? Yeah, this is a nasty pattern with any exclusive wait, we've had this bug before where an exclusive wait exits without taking the

Re: [PATCH 05/15] net: phy: reset the PHY even if probe() is not implemented

2020-06-24 Thread Bartosz Golaszewski
wt., 23 cze 2020 o 21:14 Florian Fainelli napisał(a): > > On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Currently we only call phy_device_reset() if the PHY driver implements > > the probe() callback. This is not mandatory and many drivers (e.g. > > realtek)

Re: [PATCH 10/10] mfd: wm831x-core: Supply description wm831x_reg_{un}lock args

2020-06-24 Thread Charles Keepax
On Wed, Jun 24, 2020 at 04:07:04PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/mfd/wm831x-core.c:119: warning: Function parameter or member > 'wm831x' not described in 'wm831x_reg_lock' > drivers/mfd/wm83

Re: [dm-crypt] [RFC PATCH 1/1] Add DM_CRYPT_FORCE_INLINE flag to dm-crypt target

2020-06-24 Thread Eric Biggers
On Wed, Jun 24, 2020 at 09:24:07AM +0100, Ignat Korchagin wrote: > On Wed, Jun 24, 2020 at 6:04 AM Eric Biggers wrote: > > > > On Fri, Jun 19, 2020 at 05:41:32PM +0100, Ignat Korchagin wrote: > > > Sometimes extra thread offloading imposed by dm-crypt hurts IO latency. > > > This is > > > especia

Re: [PATCH 09/10] mfd: wm8400-core: Supply description for wm8400_reset_codec_reg_cache's arg

2020-06-24 Thread Charles Keepax
On Wed, Jun 24, 2020 at 04:07:03PM +0100, Lee Jones wrote: > Kerneldoc syntax is used, but not complete. Descriptions required. > > Prevents warnings like: > > drivers/mfd/wm8400-core.c:113: warning: Function parameter or member > 'wm8400' not described in 'wm8400_reset_codec_reg_cache' > > C

Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight

2020-06-24 Thread Sam Ravnborg
Hi Lee. On Wed, Jun 24, 2020 at 04:43:21PM +0100, Lee Jones wrote: > On Wed, 24 Jun 2020, Sam Ravnborg wrote: > > > Hi Lee. > > > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > > > Attempting to clean-up W=1 kernel builds, which are currently > > > overwhelmingly riddled with nig

Re: [RFC PATCH 0/2] MTE support for KVM guest

2020-06-24 Thread Catalin Marinas
On Wed, Jun 24, 2020 at 03:59:35PM +0100, Steven Price wrote: > On 24/06/2020 15:21, Catalin Marinas wrote: > > On Wed, Jun 24, 2020 at 12:16:28PM +0100, Steven Price wrote: > > > On 23/06/2020 18:48, Catalin Marinas wrote: > > > > On Wed, Jun 17, 2020 at 01:38:42PM +0100, Steven Price wrote: > > >

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Frank Rowand
On 2020-06-24 11:14, Lee Jones wrote: > On Wed, 24 Jun 2020, Frank Rowand wrote: > >> On 2020-06-24 02:46, Lee Jones wrote: >>> On Tue, 23 Jun 2020, Frank Rowand wrote: >>> On 2020-06-23 14:59, Lee Jones wrote: >> >> < big snip > >> >> Thanks for the replies in the above portion. > > NP. >

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Dave Martin
On Wed, Jun 24, 2020 at 04:26:46PM +0100, Will Deacon wrote: > On Wed, Jun 24, 2020 at 02:48:55PM +0100, Dave Martin wrote: > > On Wed, Jun 24, 2020 at 12:26:47PM +0100, Will Deacon wrote: > > > On Wed, Jun 24, 2020 at 12:46:32PM +0200, Ard Biesheuvel wrote: > > > > On Wed, 24 Jun 2020 at 12:44, Wi

Re: [RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-24 Thread Uwe Kleine-König
Hello, On Wed, Jun 24, 2020 at 03:39:52PM +, Roy Im wrote: > On Wed, Jun 24, 2020 at 10:37 PM, Uwe Kleine-König wrote: > > On Wed, Jun 24, 2020 at 12:04:24PM +0900, Roy Im wrote: > > > period2freq = 100 / state.period; > > > if (period2freq < DA7280_MIN_PWM_FREQ_KHZ ||

drivers/edac/thunderx_edac.c:428:14: sparse: sparse: incorrect type in assignment (different address spaces)

2020-06-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3e08a95294a4fb3702bb3d35ed08028433c37fe6 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 6 days ago config: arm64-randconfig-s031-20200624 (attached

Re: [PATCH v5 3/7] ASoC: tas2562: Fix format issue for extra space before a comma

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 11:14:55AM -0500, Dan Murphy wrote: > Fix the issue found that there is an extra space before a comma in the > volume control. > > Fixes: bf726b1c86f2c ("ASoC: tas2562: Add support for digital volume control") > Signed-off-by: Dan Murphy > --- > arch/arm/boot/compressed/f

[PATCH 01/11] uptr: add a new "universal pointer" type

2020-06-24 Thread Christoph Hellwig
Add a uptr_t type that can hold a pointer to either a user or kernel memory region, and simply helpers to copy to and from it. For architectures like x86 that have non-overlapping user and kernel address space it just is a union and uses a TASK_SIZE check to select the proper copy routine. For ar

[PATCH 04/11] sysctl: switch to ->{read,write}_uptr

2020-06-24 Thread Christoph Hellwig
This allows the sysctl handler to safely take kernel space pointers, as required for the new code to set sysctl parameters at boot time. Signed-off-by: Christoph Hellwig --- fs/proc/proc_sysctl.c | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) dif

[PATCH 03/11] fs: add new read_uptr and write_uptr file operations

2020-06-24 Thread Christoph Hellwig
Add two new file operations that are identical to ->read and ->write except that they can also safely take kernel pointers using the uptr_t type. Signed-off-by: Christoph Hellwig --- fs/internal.h | 4 ++-- fs/read_write.c| 18 ++ include/linux/fs.h | 3 +++ 3 files ch

[PATCH 05/11] fs: refactor new_sync_read

2020-06-24 Thread Christoph Hellwig
Pass the read_iter method as a parameter and mark the function non-static. This allows reusing it for additional callsites e.g. in procfs. Signed-off-by: Christoph Hellwig --- fs/read_write.c| 8 +--- include/linux/fs.h | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --gi

[PATCH 07/11] seq_file: add seq_read_iter

2020-06-24 Thread Christoph Hellwig
iov_iter based variant for reading a seq_file. seq_read is reimplemented on top of the iter variant. Signed-off-by: Christoph Hellwig --- fs/seq_file.c| 34 +- include/linux/seq_file.h | 1 + 2 files changed, 22 insertions(+), 13 deletions(-) diff -

[PATCH 09/11] proc: switch over direct seq_read method calls to seq_read_iter

2020-06-24 Thread Christoph Hellwig
Switch over all instances used directly as methods using these sed expressions: sed -i -e 's/\.proc_read\(\s*=\s*\)seq_read/\.proc_read_iter\1seq_read_iter/g' Signed-off-by: Christoph Hellwig --- arch/alpha/kernel/srm_env.c| 2 +- arch/arm/mm/alignment.c

[PATCH 06/11] proc: add a read_iter method to proc proc_ops

2020-06-24 Thread Christoph Hellwig
This will allow proc files to implement iter read semantics. Signed-off-by: Christoph Hellwig --- fs/proc/inode.c | 28 include/linux/proc_fs.h | 1 + 2 files changed, 29 insertions(+) diff --git a/fs/proc/inode.c b/fs/proc/inode.c index 28d6105e908e4c..fa8

[RFC] stop using ->read and ->write for kernel access

2020-06-24 Thread Christoph Hellwig
Hi Al and Linus, as part of removing set_fs entirely (for which I have a working prototype), we need to stop calling ->read and ->write with kernel pointers under set_fs. My previous "clean up kernel_{read,write} & friends v5" series, on which this one builds, consolidate those calls into the __ḵ

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Dave Martin
On Wed, Jun 24, 2020 at 05:48:41PM +0200, Ard Biesheuvel wrote: > On Wed, 24 Jun 2020 at 17:45, Kees Cook wrote: > > > > On Wed, Jun 24, 2020 at 05:31:06PM +0200, Ard Biesheuvel wrote: > > > On Wed, 24 Jun 2020 at 17:21, Kees Cook wrote: > > > > > > > > On Wed, Jun 24, 2020 at 12:46:32PM +0200, A

[PATCH 10/11] fs: don't allow kernel reads and writes using ->read and ->write

2020-06-24 Thread Christoph Hellwig
Don't allow calling ->read or ->write with set_fs as a preparation for killing off set_fs. While I've not triggered any of these cases in my setups as all the usual suspect (file systems, pipes, sockets, block devices, system character devices) use the iter ops this is almost going to be guarantee

Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus

2020-06-24 Thread Masahiro Yamada
On Tue, Jun 23, 2020 at 9:24 PM Lee Jones wrote: > > On Tue, 23 Jun 2020, Masahiro Yamada wrote: > > > 'make ARCH=arm dtbs_check' emits the following warning: > > > > support-card@1,1f0: $nodename:0: 'support-card@1,1f0' does not > > match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > > >

[PATCH 11/11] fs: don't allow splice read/write without explicit ops

2020-06-24 Thread Christoph Hellwig
Now that __kernel_write or __kernel_write don't just work on all file operations instances there is not much of a point of providing default splice methods. Renamed the existing default ones to simple_ and wire them up for the few instancas actually implementing ->read_uptr and ->write_uptr. Sign

[PATCH 02/11] fs: factor out a set_fmode_can_read_write helper

2020-06-24 Thread Christoph Hellwig
Add a helper to set the FMODE_CAN_READ and FMODE_CAN_WRITE logic instead of duplicating it in two places. Signed-off-by: Christoph Hellwig --- fs/file_table.c | 7 +-- fs/internal.h | 10 ++ fs/open.c | 8 +--- 3 files changed, 12 insertions(+), 13 deletions(-) diff --

Re: [PATCH] sched/cfs: change initial value of runnable_avg

2020-06-24 Thread Valentin Schneider
On 24/06/20 16:44, Vincent Guittot wrote: > Some performance regression on reaim benchmark have been raised with > commit 070f5e860ee2 ("sched/fair: Take into account runnable_avg to > classify group") > > The problem comes from the init value of runnable_avg which is initialized > with max va

Re: [PATCH net-next v3 0/2] realtek ethernet : use generic power management.

2020-06-24 Thread Vaibhav Gupta
On Wed, 20 May 2020 at 04:02, David Miller wrote: > > From: Vaibhav Gupta > Date: Mon, 18 May 2020 20:32:12 +0530 > > > The purpose of this patch series is to remove legacy power management > > callbacks > > from realtek ethernet drivers. > > > > The callbacks performing suspend() and resume() o

Re: [PATCH v2 0/3] ethernet: amd: Convert to generic power management

2020-06-24 Thread Vaibhav Gupta
On Wed, 24 Jun 2020 at 09:01, David Miller wrote: > > From: Vaibhav Gupta > Date: Mon, 22 Jun 2020 16:43:57 +0530 > > > Linux Kernel Mentee: Remove Legacy Power Management. > > > > The purpose of this patch series is to remove legacy power management > > callbacks > > from amd ethernet drivers.

Re: [PATCH 09/15] net: phy: delay PHY driver probe until PHY registration

2020-06-24 Thread Bartosz Golaszewski
On Wed, Jun 24, 2020 at 6:06 PM Florian Fainelli wrote: > [snip!] > > > > This has evolved into several new concepts being proposed vs my > > use-case which is relatively simple. The former will probably take > > several months of development, reviews and discussions and it will > > block suppor

Re: wait_on_page_bit_common(TASK_KILLABLE, EXCLUSIVE) can miss wakeup?

2020-06-24 Thread Linus Torvalds
On Wed, Jun 24, 2020 at 9:20 AM Oleg Nesterov wrote: > > If T1 is killed it is TASK_RUNNING, try_to_wake_up() should return 0. Hmm. I already acknowledge your bug, but yeah, this is subtle. But I think the bug still exists. So the requirement is: - bit_is_set returns false so we don't call io

Re: [PATCH] hwmon:max6697: Make sure the OVERT mask is set correctly

2020-06-24 Thread Guenter Roeck
On Tue, Jun 23, 2020 at 10:13:08PM +, Chu Lin wrote: > Per the datasheet for max6697, OVERT mask and ALERT mask is different. > For example, the 7th bit of OVERT is the local channel but for alert > mask, the 6th bit is the local channel. Therefore, we can't apply the > same mask for both reg.

Re: [PATCH RESEND] media: cros-ec-cec: do not bail on device_init_wakeup failure

2020-06-24 Thread Dariusz Marcinkiewicz
Hi. On Wed, Jun 24, 2020 at 4:45 PM Guenter Roeck wrote: > > On Mon, Jun 22, 2020 at 12:23 PM Hans Verkuil > > wrote: > > > > > > > Signed-off-by: Dariusz Marcinkiewicz > > > > > > This can be CCed to stable, I guess? > > > > > > > That issue is not a recent regression but has been in there s

Re: [PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Laurent Pinchart
Hi Vinod, On Wed, Jun 24, 2020 at 08:41:21PM +0530, Vinod Koul wrote: > Hi Laurent, > > Mostly this looks fine to me, some minor nitpicks below: > > On 13-05-20, 20:22, Laurent Pinchart wrote: > > +config PHY_XILINX_ZYNQMP > > + tristate "Xilinx ZynqMP PHY driver" > > + depends on ARCH_ZYNQM

[PATCH] staging: most: avoid null pointer dereference when iface is null

2020-06-24 Thread Colin King
From: Colin Ian King In the case where the pointer iface is null then the reporting of this error will dereference iface when printing an error message causing which is not ideal. Since the majority of callers to most_register_interface report an error when -EINVAL is returned a simple fix is to

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 18:29, Dave Martin wrote: > > On Wed, Jun 24, 2020 at 05:48:41PM +0200, Ard Biesheuvel wrote: > > On Wed, 24 Jun 2020 at 17:45, Kees Cook wrote: > > > > > > On Wed, Jun 24, 2020 at 05:31:06PM +0200, Ard Biesheuvel wrote: > > > > On Wed, 24 Jun 2020 at 17:21, Kees Cook wrot

Re: [PATCH] sched/cfs: change initial value of runnable_avg

2020-06-24 Thread Vincent Guittot
On Wed, 24 Jun 2020 at 18:32, Valentin Schneider wrote: > > > On 24/06/20 16:44, Vincent Guittot wrote: > > Some performance regression on reaim benchmark have been raised with > > commit 070f5e860ee2 ("sched/fair: Take into account runnable_avg to > > classify group") > > > > The problem comes

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: > On 6/24/20 9:00 AM, Jens Axboe wrote: > > On 6/23/20 7:46 PM, Matthew Wilcox wrote: > >> I'd be quite happy to add a gfp_t to struct readahead_control. > >> The other thing I've been looking into for other reasons is adding > >> a memall

Re: [RFC PATCH v2] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()

2020-06-24 Thread Souptick Joarder
On Wed, Jun 24, 2020 at 9:07 PM Boris Ostrovsky wrote: > > On 6/23/20 9:36 PM, Souptick Joarder wrote: > > On Tue, Jun 23, 2020 at 11:11 PM Boris Ostrovsky > > wrote: > >> On 6/23/20 7:58 AM, Souptick Joarder wrote: > >>> In 2019, we introduced pin_user_pages*() and now we are converting > >>> ge

Re: wait_on_page_bit_common(TASK_KILLABLE, EXCLUSIVE) can miss wakeup?

2020-06-24 Thread Oleg Nesterov
On 06/24, Linus Torvalds wrote: > > That said, I'm not entirely happy with your patch. Neither me, > The real problem, I feel, is that > > if (likely(bit_is_set)) > io_schedule(); > > anti-pattern. Without that, we wouldn't have the bug. > > Normally, we'd

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Jens Axboe
On 6/24/20 10:41 AM, Matthew Wilcox wrote: > On Wed, Jun 24, 2020 at 09:35:19AM -0600, Jens Axboe wrote: >> On 6/24/20 9:00 AM, Jens Axboe wrote: >>> On 6/23/20 7:46 PM, Matthew Wilcox wrote: I'd be quite happy to add a gfp_t to struct readahead_control. The other thing I've been looking

Re: [PATCH v2 0/2] remove workarounds for gcc bug wrt unnamed fields in initializers

2020-06-24 Thread Christoph Hellwig
This looks good to me, but I'd rather wait a few releases to avoid too mush backporting pain.

[PATCH v8.1 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Laurent Pinchart
From: Anurag Kumar Vulisha Xilinx ZynqMP SoCs have a Gigabit Transceiver with four lanes. All the high speed peripherals such as USB, SATA, PCIE, Display Port and Ethernet SGMII can rely on any of the four GT lanes for PHY layer. This patch adds driver for that ZynqMP GT core. Signed-off-by: Anu

[PATCH V7 3/4] rpmsg: glink: Add support for rpmsg glink chrdev

2020-06-24 Thread Deepak Kumar Singh
RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 38

[PATCH V7 2/4] rpmsg: Guard against null endpoint ops in destroy

2020-06-24 Thread Deepak Kumar Singh
From: Chris Lew In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar

[PATCH V7 4/4] rpmsg: glink: Expose rpmsg name attr for glink

2020-06-24 Thread Deepak Kumar Singh
From: Chris Lew Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 26 +

[PATCH V7 1/4] rpmsg: glink: Use complete_all for open states

2020-06-24 Thread Deepak Kumar Singh
From: Chris Lew The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Arun Kumar Neela

<    1   2   3   4   5   6   7   8   9   10   >