[PATCH 09/10] mfd: wm8400-core: Supply description for wm8400_reset_codec_reg_cache's arg

2020-06-24 Thread Lee Jones
Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm8400-core.c:113: warning: Function parameter or member 'wm8400' not described in 'wm8400_reset_codec_reg_cache' Cc: Cc: Mark Brown Cc: patc...@opensource.cirrus.com Signed-off-by: Lee Jo

[PATCH 00/10] Fix a bunch of W=1 warnings in MFD

2020-06-24 Thread Lee Jones
Attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (10): mfd: twl4030-irq: Fix incorrect type in assignment warning mfd: twl4030-irq: Fix cast to restricted __le32 warning mfd: tps6586x: Fix cast to restricted __le32 wa

Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file

2020-06-24 Thread Yannick FERTRE
Hello Angelo, thank for patch. Reviewed-by: Yannick Fertre On 4/3/20 3:30 PM, Angelo Ribeiro wrote: > dw-mipi-dsi does not use any definition from drm_probe_helper. > > Coverity output: > Event unnecessary_header: > Including .../include/drm/drm_probe_helper.h does not provide any > needed sy

[PATCH 03/10] mfd: tps6586x: Fix cast to restricted __le32 warning

2020-06-24 Thread Lee Jones
Silences Sparse warning(s): drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 d

[PATCH v2 1/4] media: staging: tegra-vde: Balance runtime PM use-count on resume failure

2020-06-24 Thread Dmitry Osipenko
The RPM's use-count is getting incremented regardless of the pm_runtime_get_sync() success or fail. It's up to a driver how to handle the failed RPM. In the case of VDE driver, the RPM's use-count should be restored if runtime-resume fails. Use pm_runtime_put_noidle(), which is the most straight-fo

[PATCH v2 0/4] Tegra Video Decoder driver power management corrections

2020-06-24 Thread Dmitry Osipenko
Hello, This small series addresses a Runtime PM issue that was discovered during of Tegra VI driver reviewing by balancing RPM usage count on RPM resume failure. Secondly it fixes reboot on some Tegra devices due to bootloader expecting VDE power partition to be ON at the boot time, which wasn't h

Re: [PATCH 1/1] clk: qcom: smd: Add support for MSM8992/4 rpm clocks

2020-06-24 Thread Konrad Dybcio
I should also note that for quite some time a hack [1] has been needed on some platforms for the RPMCC to register. This includes 8992/94, 8956/76 and possibly many more. With that commit, RPMCC registers fine. [1] https://github.com/kholk/kernel-upstream/commit/5df7bb6e337c0a41b2cc6477cddc718d

[PATCH v2 4/4] media: staging: tegra-vde: Power-cycle hardware on probe

2020-06-24 Thread Dmitry Osipenko
VDE partition is left turned ON after bootloader on most devices, hence let's ensure that it's turned OFF in order to lower power leakage while hardware is idling by turning it ON and OFF during of the driver's probe. Signed-off-by: Dmitry Osipenko --- drivers/staging/media/tegra-vde/vde.c | 8 +

Re: move block bits out of fs.h

2020-06-24 Thread Jens Axboe
On 6/20/20 1:16 AM, Christoph Hellwig wrote: > Hi Jens, > > this series removes various remaining block bits out of fs.h and cleans > up a few loose ends around that. > > Diffstat: > drivers/tty/sysrq.c |2 > fs/adfs/super.c |1 > fs/affs/file.c |1

[PATCH v2 2/4] media: staging: tegra-vde: Runtime PM is always available on Tegra

2020-06-24 Thread Dmitry Osipenko
Runtime PM is always available on Tegra nowadays since commit 40b2bb1b132a ("ARM: tegra: enforce PM requirement"), hence the case of unavailable RPM doesn't need to be handled. Signed-off-by: Dmitry Osipenko --- drivers/staging/media/tegra-vde/vde.c | 16 1 file changed, 16 dele

[PATCH v2 3/4] media: staging: tegra-vde: Turn ON power domain on shutdown

2020-06-24 Thread Dmitry Osipenko
On some devices bootloader isn't ready to a clamped VDE power, and thus, machine hangs on a warm reboot (CPU reset). The VDE power partition is turned ON by default on a cold boot, hence VDE driver should keep power partition enabled on system's reboot too. This fixes hang on a warm reboot on a Teg

Re: [PATCH][next] drm: amdgpu: fix premature goto because of missing braces

2020-06-24 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jun 24, 2020 at 10:32 AM Nirmoy wrote: > > Acked-by: Nirmoy Das > > > Thanks, > > Nirmoy > > On 6/24/20 4:14 PM, Colin King wrote: > > From: Colin Ian King > > > > Currently the goto statement is skipping over a lot of setup code > > because it is outside of an i

Re: [PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Vinod Koul
Hi Laurent, Mostly this looks fine to me, some minor nitpicks below: On 13-05-20, 20:22, Laurent Pinchart wrote: > +config PHY_XILINX_ZYNQMP > + tristate "Xilinx ZynqMP PHY driver" > + depends on ARCH_ZYNQMP Can we add COMPILE_TEST here so that this driver gets wider compile coverage? >

Re: brocken devfreq simple_ondemand for Odroid XU3/4?

2020-06-24 Thread Sylwester Nawrocki
Hi All, On 24.06.2020 12:32, Lukasz Luba wrote: > I had issues with devfreq governor which wasn't called by devfreq > workqueue. The old DELAYED vs DEFERRED work discussions and my patches > for it [1]. If the CPU which scheduled the next work went idle, the > devfreq workqueue will not be kicked

Re: move block bits out of fs.h

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 09:09:42AM -0600, Jens Axboe wrote: > Applied for 5.9 - I kept this in a separate topic branch, fwiw. There's the > potential for some annoying issues with this, so would rather have it in > a branch we can modify easily, if we need to. Hmm, I have a bunch of things buildin

Re: [PATCH 4.14 000/135] 4.14.186-rc2 review

2020-06-24 Thread Guenter Roeck
On Wed, Jun 24, 2020 at 08:09:52AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.186 release. > There are 135 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kn

Re: [PATCH 4.19 000/203] 4.19.130-rc2 review

2020-06-24 Thread Guenter Roeck
On Wed, Jun 24, 2020 at 08:10:06AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.130 release. > There are 203 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kn

Re: [PATCH 5.4 000/311] 5.4.49-rc2 review

2020-06-24 Thread Guenter Roeck
On Wed, Jun 24, 2020 at 08:10:19AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.49 release. > There are 311 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: move block bits out of fs.h

2020-06-24 Thread Jens Axboe
On 6/24/20 9:12 AM, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 09:09:42AM -0600, Jens Axboe wrote: >> Applied for 5.9 - I kept this in a separate topic branch, fwiw. There's the >> potential for some annoying issues with this, so would rather have it in >> a branch we can modify easily, if

Re: [PATCH 5.7 000/474] 5.7.6-rc2 review

2020-06-24 Thread Guenter Roeck
On Wed, Jun 24, 2020 at 08:10:33AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.7.6 release. > There are 474 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know.

Re: move block bits out of fs.h

2020-06-24 Thread Christoph Hellwig
On Wed, Jun 24, 2020 at 09:14:11AM -0600, Jens Axboe wrote: > On 6/24/20 9:12 AM, Christoph Hellwig wrote: > > On Wed, Jun 24, 2020 at 09:09:42AM -0600, Jens Axboe wrote: > >> Applied for 5.9 - I kept this in a separate topic branch, fwiw. There's the > >> potential for some annoying issues with th

Re: linux-next: build warnings after merge of the imx-mxs tree

2020-06-24 Thread Tim Harvey
On Tue, Jun 23, 2020 at 4:50 PM Stephen Rothwell wrote: > > Hi all, > > After merging the imx-mxs tree, today's linux-next build (arm > multi_v7_defconfig) produced these warnings: > > arch/arm/boot/dts/imx6qdl-gw53xx.dtsi:350.4-27: Warning (reg_format): > /soc/pcie@1ffc000/pcie@0,0,0/pcie@1,0,0:

[PATCH v5 5/7] hwmon: pmbus: adm1266: read blackbox

2020-06-24 Thread alexandru.tachici
From: Alexandru Tachici Use the nvmem kernel api to expose the black box chip functionality to userspace. Signed-off-by: Alexandru Tachici --- drivers/hwmon/pmbus/adm1266.c | 134 ++ 1 file changed, 134 insertions(+) diff --git a/drivers/hwmon/pmbus/adm1266.c b

[PATCH v5 7/7] dt-bindings: hwmon: Add bindings for ADM1266

2020-06-24 Thread alexandru.tachici
From: Alexandru Tachici Add bindings for the Analog Devices ADM1266 sequencer. Signed-off-by: Alexandru Tachici --- .../bindings/hwmon/adi,adm1266.yaml | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1266.y

[PATCH v5 3/7] hwmon: pmbus: adm1266: Add support for GPIOs

2020-06-24 Thread alexandru.tachici
From: Alexandru Tachici Adm1266 exposes 9 GPIOs and 16 PDIOs which are currently read-only. They are controlled by the internal sequencing engine. This patch makes adm1266 driver expose GPIOs and PDIOs to user-space using GPIO provider kernel api. Signed-off-by: Alexandru Tachici --- drivers/

[PATCH v5 2/7] hwmon: pmbus: adm1266: Add Block process call

2020-06-24 Thread alexandru.tachici
From: Alexandru Tachici PmBus devices support Block Write-Block Read Process Call described in SMBus specification v 2.0 with the exception that Block writes and reads are permitted to have up 255 data bytes instead of max 32 bytes (SMBus). This patch adds Block WR process call support for ADM12

[PATCH v5 1/7] hwmon: pmbus: adm1266: add support

2020-06-24 Thread alexandru.tachici
From: Alexandru Tachici Add pmbus probing driver for the adm1266 Cascadable Super Sequencer with Margin Control and Fault Recording. Driver is using the pmbus_core, creating sysfs files under hwmon for inputs: vh1->vh4 and vp1->vp13. Signed-off-by: Alexandru Tachici --- Documentation/hwmon/adm

[PATCH v5 6/7] hwmon: pmbus: adm1266: debugfs for blackbox info

2020-06-24 Thread alexandru.tachici
From: Alexandru Tachici Add a debugfs file to print information in the BLACKBOX_INFORMATION register. Contains information about the number of stored records, logic index and id of the latest record. Signed-off-by: Alexandru Tachici --- drivers/hwmon/pmbus/adm1266.c | 56 ++

[PATCH v5 0/7] hwmon: pmbus: adm1266: add support

2020-06-24 Thread alexandru.tachici
From: Alexandru Tachici Add PMBus probing driver for the adm1266 Cascadable Super Sequencer with Margin Control and Fault Recording. Driver is using the pmbus_core, creating sysfs files under hwmon for inputs: vh1->vh4 and vp1->vp13. 1. Add PMBus probing driver for inputs vh1->vh4 and vp1->vp13.

Re: [PATCH v2 0/4] Tegra Video Decoder driver power management corrections

2020-06-24 Thread Hans Verkuil
On 24/06/2020 17:08, Dmitry Osipenko wrote: > Hello, > > This small series addresses a Runtime PM issue that was discovered during > of Tegra VI driver reviewing by balancing RPM usage count on RPM resume > failure. Secondly it fixes reboot on some Tegra devices due to bootloader > expecting VDE p

Re: move block bits out of fs.h

2020-06-24 Thread Jens Axboe
On 6/24/20 9:14 AM, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 09:14:11AM -0600, Jens Axboe wrote: >> On 6/24/20 9:12 AM, Christoph Hellwig wrote: >>> On Wed, Jun 24, 2020 at 09:09:42AM -0600, Jens Axboe wrote: Applied for 5.9 - I kept this in a separate topic branch, fwiw. There's the

Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types

2020-06-24 Thread Robin Murphy
On 2020-06-24 16:04, Mark Brown wrote: On Wed, Jun 24, 2020 at 03:25:33PM +0100, Robin Murphy wrote: And yeah, anyone who pipes up suggesting that places where an ERR_PTR value could be passed to probe_err() could simply refactor IS_ERR() checks with more uses of the god-awful PTR_ERR_OR_ZERO()

[PATCH v5 4/7] hwmon: pmbus: adm1266: Add ioctl commands

2020-06-24 Thread alexandru.tachici
From: Alexandru Tachici Add two ioctl commands for reading the current state of the adm1266 sequencer and sending commands. Signed-off-by: Alexandru Tachici --- Documentation/hwmon/adm1266.rst | 15 +++ .../userspace-api/ioctl/ioctl-number.rst | 1 + drivers/hwmon/pmbus/adm

Re: [PATCH][next] drm/amdgpu: ensure 0 is returned for success in jpeg_v2_5_wait_for_idle

2020-06-24 Thread Alex Deucher
On Wed, Jun 24, 2020 at 10:54 AM Colin King wrote: > > From: Colin Ian King > > In the cases where adev->jpeg.num_jpeg_inst is zero or the condition > adev->jpeg.harvest_config & (1 << i) is always non-zero the variable > ret is never set to an error condition and the function returns > an uninit

Re: [PATCH 2/6] arm64/vdso: Zap vvar pages when switching to a time namespace

2020-06-24 Thread Christian Brauner
On Wed, Jun 24, 2020 at 01:33:17AM -0700, Andrei Vagin wrote: > The order of vvar pages depends on whether a task belongs to the root > time namespace or not. In the root time namespace, a task doesn't have a > per-namespace page. In a non-root namespace, the VVAR page which contains > the system-w

Re: [PATCH v3 09/10] kallsyms: Hide layout

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 12:21:16PM +0200, Jann Horn wrote: > On Tue, Jun 23, 2020 at 7:26 PM Kristen Carlson Accardi > wrote: > > This patch makes /proc/kallsyms display alphabetically by symbol > > name rather than sorted by address in order to hide the newly > > randomized address layout. > [...

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-24 Thread Peter Zijlstra
On Wed, Jun 24, 2020 at 01:32:46PM +0200, Marco Elver wrote: > From: Marco Elver > Date: Wed, 24 Jun 2020 11:23:22 +0200 > Subject: [PATCH] kcsan: Make KCSAN compatible with new IRQ state tracking > > The new IRQ state tracking code does not honor lockdep_off(), and as > such we should again perm

Re: [PATCH] drm/radeon: fix array out-of-bounds read and write issues

2020-06-24 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jun 24, 2020 at 8:07 AM Colin King wrote: > > From: Colin Ian King > > There is an off-by-one bounds check on the index into arrays > table->mc_reg_address and table->mc_reg_table_entry[k].mc_data[j] that > can lead to reads and writes outside of arrays. Fix the b

Re: [Tee-dev] [PATCHv8 1/3] optee: use uuid for sysfs driver entry

2020-06-24 Thread James Bottomley
On Wed, 2020-06-24 at 16:17 +0530, Sumit Garg wrote: > Apologies for delay in my reply as I was busy with some other stuff. > > On Fri, 19 Jun 2020 at 20:30, James Bottomley > wrote: [...] > > it's about consistency with what the kernel types mean. When some > > checker detects your using little

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 12:46:32PM +0200, Ard Biesheuvel wrote: > I'm not sure if there is a point to having PAC and/or BTI in the EFI > stub, given that it runs under the control of the firmware, with its > memory mappings and PAC configuration etc. Is BTI being ignored when the firmware runs? -

[PATCH v3] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

2020-06-24 Thread Sven Van Asbroeck
On imx6, the ethernet reference clock (clk_enet_ref) can be generated by either the imx6, or an external source (e.g. an oscillator or the PHY). When generated by the imx6, the clock source (from ANATOP) must be routed to the input of clk_enet_ref via two pads on the SoC, typically via a dedicated

Re: [PATCH net v2 0/2] bridge: mrp: Update MRP_PORT_ROLE

2020-06-24 Thread Vladimir Oltean
Hi Horatiu, On Wed, 24 Jun 2020 at 14:34, Horatiu Vultur wrote: > > The 06/23/2020 14:38, David Miller wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > From: Horatiu Vultur > > Date: Tue, 23 Jun 2020 11:05:39 +0200 > > > > > This

Re: [PATCH 2/2] watchdog: rti: tweak min_hw_heartbeat_ms to match initial allowed window

2020-06-24 Thread Jan Kiszka
On 24.06.20 13:45, Tero Kristo wrote: If the RTI watchdog has been started by someone (like bootloader) when the driver probes, we must adjust the initial ping timeout to match the currently running watchdog window to avoid generating watchdog reset. Signed-off-by: Tero Kristo --- drivers/wat

Re: [PATCH v2 0/4] Tegra Video Decoder driver power management corrections

2020-06-24 Thread Dmitry Osipenko
24.06.2020 18:16, Hans Verkuil пишет: > On 24/06/2020 17:08, Dmitry Osipenko wrote: >> Hello, >> >> This small series addresses a Runtime PM issue that was discovered during >> of Tegra VI driver reviewing by balancing RPM usage count on RPM resume >> failure. Secondly it fixes reboot on some Tegra

Re: Writing to a const pointer: is this supposed to happen?

2020-06-24 Thread Kars Mulder
On Wednesday, June 24, 2020 15:10 CEST, Greg Kroah-Hartman wrote: > Have you hit any runtime issues with this code doing this? These > strings should be held in writable memory, right? Or do you see a > codepath where that is not the case? I haven't ran into any issues with it; I was just looki

Re: [PATCH v2] media: venus: core: Fix runtime PM imbalance in venus_probe

2020-06-24 Thread Markus Elfring
I propose to combine two tags in the previous patch subject. > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. For other error > paths after this call,

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Will Deacon
On Wed, Jun 24, 2020 at 02:48:55PM +0100, Dave Martin wrote: > On Wed, Jun 24, 2020 at 12:26:47PM +0100, Will Deacon wrote: > > On Wed, Jun 24, 2020 at 12:46:32PM +0200, Ard Biesheuvel wrote: > > > On Wed, 24 Jun 2020 at 12:44, Will Deacon wrote: > > > > For the kernel Image, how do we remove thes

Re: [RESEND PATCH v5 1/5] driver core: add probe_err log helper

2020-06-24 Thread Mark Brown
On Wed, Jun 24, 2020 at 04:00:34PM +0100, Robin Murphy wrote: > Be thankful... And count me in as one of those miserable users; here's one > of mine being bad enough without even printing any specific messages about > deferring ;) > [robin@weasel-cheese ~]$ dmesg | grep dwmmc > [3.046297] dwm

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 17:21, Kees Cook wrote: > > On Wed, Jun 24, 2020 at 12:46:32PM +0200, Ard Biesheuvel wrote: > > I'm not sure if there is a point to having PAC and/or BTI in the EFI > > stub, given that it runs under the control of the firmware, with its > > memory mappings and PAC configura

Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight

2020-06-24 Thread Sam Ravnborg
Hi Lee. On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > Attempting to clean-up W=1 kernel builds, which are currently > overwhelmingly riddled with niggly little warnings. > > Lee Jones (8): > backlight: lms501kf03: Remove unused const variables > backlight: lcd: Add missing kern

Re: [PATCH v2 2/2] cpufreq: Specify default governor on command line

2020-06-24 Thread Quentin Perret
On Wednesday 24 Jun 2020 at 14:51:04 (+0200), Rafael J. Wysocki wrote: > On Wed, Jun 24, 2020 at 7:50 AM Viresh Kumar wrote: > > > @@ -2789,7 +2796,13 @@ static int __init cpufreq_core_init(void) > > > cpufreq_global_kobject = kobject_create_and_add("cpufreq", > > > &cpu_subsys.dev_root->ko

Re: [PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-06-24 Thread Yannick FERTRE
Hello Angelo, thanks for the patch. Tested-by: Yannick Fertre Tested OK on STM32MP1-DISCO, DSI v1.31 Best regards On 4/6/20 3:49 PM, Angelo Ribeiro wrote: > Add support for the video pattern generator (VPG) BER pattern mode and > configuration in runtime. > > This enables using the debugfs int

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-24 Thread Jens Axboe
On 6/24/20 9:00 AM, Jens Axboe wrote: > On 6/23/20 7:46 PM, Matthew Wilcox wrote: >> On Wed, Jun 24, 2020 at 11:02:53AM +1000, Dave Chinner wrote: >>> On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: The read-ahead shouldn't block, so allow it to be done even if IOCB_NOWAIT is

Re: [PATCH v3 9/9] arm64/build: Warn on orphan section placement

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 08:57:12AM +0100, Will Deacon wrote: > On Tue, Jun 23, 2020 at 06:49:40PM -0700, Kees Cook wrote: > > We don't want to depend on the linker's orphan section placement > > heuristics as these can vary between linkers, and may change between > > versions. All sections need to

Re: [PATCH v5 4/7] hwmon: pmbus: adm1266: Add ioctl commands

2020-06-24 Thread Guenter Roeck
On 6/24/20 8:17 AM, alexandru.tach...@analog.com wrote: > From: Alexandru Tachici > > Add two ioctl commands for reading the current state > of the adm1266 sequencer and sending commands. > Please note that I am not going to a accept any ioctls for hwmon drivers, much less unprivileged commands

RE: [PATCH v2 2/2] cpufreq: intel_pstate: Allow raw energy performance preference value

2020-06-24 Thread Doug Smythies
Hi Srinivas, I have immediate need for this. I have been using a tool I wrote myself for this which I can now retire. (it wasn't very good anyway). Yours remembers for each governor, and is way better. Thanks. On 2020.06.23 11:27 Srinivas Pandruvada wrote: > Currently using attribute "energy_per

Re: [RFC][PATCH v5 01/51] objtool: Factor out reasons to build objtool

2020-06-24 Thread Miroslav Benes
Hi, this is a nice improvement. > diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile > index 7770edcda3a0..aa0c6d3d2d46 100644 > --- a/tools/objtool/Makefile > +++ b/tools/objtool/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > include ../scripts/Makefile.include >

Re: [RFC PATCH v2] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()

2020-06-24 Thread Boris Ostrovsky
On 6/23/20 9:36 PM, Souptick Joarder wrote: > On Tue, Jun 23, 2020 at 11:11 PM Boris Ostrovsky > wrote: >> On 6/23/20 7:58 AM, Souptick Joarder wrote: >>> In 2019, we introduced pin_user_pages*() and now we are converting >>> get_user_pages*() to the new API as appropriate. [1] & [2] could >>> be

Re: [PATCH v2 0/2] introduce fallback to pio in spi core

2020-06-24 Thread Mark Brown
On Wed, 17 Jun 2020 06:42:07 +0800, Robin Gong wrote: > Introudce fallback pio way at spi core level so that the tx/rx buffer > mapped by spi core for dma could be unmap and fallback pio again. Hence no > need the below patch where 'dma_sync_sg_for_devic' to sync fresh data back > into 'device' mem

Re: [PATCH 1/2] ASoC: fsl-asoc-card: Add WM8524 support

2020-06-24 Thread Mark Brown
On Tue, 23 Jun 2020 14:52:46 +0800, Shengjiu Wang wrote: > WM8524 only supports playback mode, and only works at > slave mode. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: fsl-asoc-card: Add WM8524 support commit: 3cd99026740

Re: [PATCH 0/2] Some fixes for spi-altera

2020-06-24 Thread Mark Brown
On Wed, 24 Jun 2020 09:31:24 +0800, Xu Yilun wrote: > Two fixes for indirect access support patchset. > > Xu Yilun (2): > spi: altera: fix driver matching failure of the device ID "spi_altera" > spi: altera: fix module autoload > > drivers/spi/spi-altera.c | 4 +++- > 1 file changed, 3 inser

Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG

2020-06-24 Thread Arvind Sankar
On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote: > When linking vmlinux with LLD, the synthetic sections .symtab, .strtab, > and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section > so there will be no warnings when --orphan-handling=warn is used more > widely. (They ar

RE: [RESEND PATCH V13 3/3] Input: new da7280 haptic driver

2020-06-24 Thread Roy Im
On Wed, Jun 24, 2020 at 10:37 PM, Uwe Kleine-König wrote: > On Wed, Jun 24, 2020 at 12:04:24PM +0900, Roy Im wrote: > > Hello Uwe, > > > > On Tue, June 23, 2020 11:41 PM, Uwe Kleine-König wrote: > > > > > > Hello, > > > > > > On Mon, Jun 15, 2020 at 08:40:23PM +0900, Roy Im wrote: > > > > Adds supp

Re: [PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-24 Thread Kent Gibson
On Wed, Jun 24, 2020 at 05:33:26PM +0300, Andy Shevchenko wrote: > On Tue, Jun 23, 2020 at 7:04 AM Kent Gibson wrote: > > > > Add a new version of the uAPI to address existing 32/64bit alignment > > I think using - would be nice, like 32/64-bit (or at least space like > 32/64 bit) as a common pra

Re: [PATCH stable 4.9 00/21] Unbreak 32-bit DVB applications on 64-bit kernels

2020-06-24 Thread Florian Fainelli
On 6/23/2020 12:13 PM, Greg KH wrote: > On Fri, Jun 05, 2020 at 09:24:57AM -0700, Florian Fainelli wrote: >> Hi all, >> >> This long patch series was motivated by backporting Jaedon's changes >> which add a proper ioctl compatibility layer for 32-bit applications >> running on 64-bit kernels. We

Re: [PATCH v3 3/5] iommu/uapi: Use named union for user data

2020-06-24 Thread Jacob Pan
On Wed, 24 Jun 2020 14:29:57 +0800 Lu Baolu wrote: > > case IOMMU_CACHE_INV_TYPE_IOTLB: > > /* HW will ignore LSB bits based on > > address mask */ if (inv_info->granularity == IOMMU_INV_GRANU_ADDR && > > size && > > -

Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight

2020-06-24 Thread Lee Jones
On Wed, 24 Jun 2020, Sam Ravnborg wrote: > Hi Lee. > > On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > > Attempting to clean-up W=1 kernel builds, which are currently > > overwhelmingly riddled with niggly little warnings. > > > > Lee Jones (8): > > backlight: lms501kf03: Remove u

Re: [Tee-dev] [PATCHv8 1/3] optee: use uuid for sysfs driver entry

2020-06-24 Thread Jerome Forissier
On 6/24/20 5:21 PM, James Bottomley wrote: > On Wed, 2020-06-24 at 16:17 +0530, Sumit Garg wrote: >> Apologies for delay in my reply as I was busy with some other stuff. >> >> On Fri, 19 Jun 2020 at 20:30, James Bottomley >> wrote: > [...] >>> it's about consistency with what the kernel types m

[PATCH] sched/cfs: change initial value of runnable_avg

2020-06-24 Thread Vincent Guittot
Some performance regression on reaim benchmark have been raised with commit 070f5e860ee2 ("sched/fair: Take into account runnable_avg to classify group") The problem comes from the init value of runnable_avg which is initialized with max value. This can be a problem if the newly forked task is

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 05:31:06PM +0200, Ard Biesheuvel wrote: > On Wed, 24 Jun 2020 at 17:21, Kees Cook wrote: > > > > On Wed, Jun 24, 2020 at 12:46:32PM +0200, Ard Biesheuvel wrote: > > > I'm not sure if there is a point to having PAC and/or BTI in the EFI > > > stub, given that it runs under t

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 17:45, Kees Cook wrote: > > On Wed, Jun 24, 2020 at 05:31:06PM +0200, Ard Biesheuvel wrote: > > On Wed, 24 Jun 2020 at 17:21, Kees Cook wrote: > > > > > > On Wed, Jun 24, 2020 at 12:46:32PM +0200, Ard Biesheuvel wrote: > > > > I'm not sure if there is a point to having PAC

Re: [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq

2020-06-24 Thread Joel Fernandes
On Tue, Jun 23, 2020 at 12:40 PM Qais Yousef wrote: > > On 06/22/20 11:21, Doug Anderson wrote: > > [...] > > > > If you propose something that will help the discussion. I think based on > > > the > > > same approach Peter has taken to prevent random RT priorities. In uclamp > > > case > > > I t

Re: [PATCH] ACPI: Eliminate usage of uninitialized_var() macro

2020-06-24 Thread Rafael J. Wysocki
On Monday, June 15, 2020 6:00:47 AM CEST Jason Yan wrote: > This is an effort to eliminate the uninitialized_var() macro[1]. > > The use of this macro is the wrong solution because it forces off ANY > analysis by the compiler for a given variable. It even masks "unused > variable" warnings. > > Q

Re: [PATCH] ACPI: avoid relocations for table signature array

2020-06-24 Thread Rafael J. Wysocki
On Wednesday, June 17, 2020 10:25:05 AM CEST Ard Biesheuvel wrote: > On architectures that implement KASLR using the ELF native RELA relocation > format (such as arm64), every absolute reference in the code incurs an > overhead of 24 bytes in the .rela section. So storing a 41 element array > of 4

[PATCH] Staging: rtl8188eu: Fix alignment coding style issue

2020-06-24 Thread Peilin Ye
Fix "Alignment should match open parenthesis" issues reported by checkpatch.pl for all files under drivers/staging/rtl8188eu/core. Line rtw_mlme_ext.c:373 is left overlength for readability. Signed-off-by: Peilin Ye --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 +-- drivers/staging/rt

Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes

2020-06-24 Thread Frank Rowand
On 2020-06-24 02:46, Lee Jones wrote: > On Tue, 23 Jun 2020, Frank Rowand wrote: > >> On 2020-06-23 14:59, Lee Jones wrote: < big snip > Thanks for the replies in the above portion. But yes or no to my solution #2 (with some slight changes to make it better (more gracious handling o

[PATCH v5 13/17] static_call: Add static_call_cond()

2020-06-24 Thread Peter Zijlstra
Extend the static_call infrastructure to optimize the following common pattern: if (func_ptr) func_ptr(args...) For the trampoline (which is in effect a tail-call), we patch the JMP.d32 into a RET, which then directly consumes the trampoline call. For the in-line sites we

[PATCH v5 09/17] x86/static_call: Add out-of-line static call implementation

2020-06-24 Thread Peter Zijlstra
From: Josh Poimboeuf Add the x86 out-of-line static call implementation. For each key, a permanent trampoline is created which is the destination for all static calls for the given key. The trampoline has a direct jump which gets patched by static_call_update() when the destination function cha

[PATCH v5 11/17] static_call: Simple self-test

2020-06-24 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- arch/Kconfig |6 ++ kernel/static_call.c | 28 2 files changed, 34 insertions(+) --- a/arch/Kconfig +++ b/arch/Kconfig @@ -103,6 +103,12 @@ config STATIC_KEYS_SELFTEST help Boot time self

[PATCH v5 08/17] static_call: Avoid kprobes on inline static_call()s

2020-06-24 Thread Peter Zijlstra
Similar to how we disallow kprobes on any other dynamic text (ftrace/jump_label) also disallow kprobes on inline static_call()s. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/kernel/kprobes/opt.c |4 +- include/linux/static_call.h | 11 +++ kernel/kprobes.c |2 +

[PATCH v5 03/17] module: Properly propagate MODULE_STATE_COMING failure

2020-06-24 Thread Peter Zijlstra
Now that notifiers got unbroken; use the proper interface to handle notifier errors and propagate them. There were already MODULE_STATE_COMING notifiers that failed; notably: - jump_label_module_notifier() - tracepoint_module_notify() - bpf_event_notify() By propagating this error, we fix tho

[PATCH v5 15/17] static_call: Allow early init

2020-06-24 Thread Peter Zijlstra
In order to use static_call() to wire up x86_pmu, we need to initialize earlier; copy some of the tricks from jump_label to enable this. Primarily we overload key->next to store a sites pointer when there are no modules, this avoids having to use kmalloc() to initialize the sites and allows us to

[PATCH v5 12/17] x86/alternatives: Teach text_poke_bp() to emulate RET

2020-06-24 Thread Peter Zijlstra
Future patches will need to poke a RET instruction, provide the infrastructure required for this. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/text-patching.h | 19 +++ arch/x86/kernel/alternative.c|5 + 2 files changed, 24 insertions(+) --- a

[PATCH v5 10/17] x86/static_call: Add inline static call implementation for x86-64

2020-06-24 Thread Peter Zijlstra
From: Josh Poimboeuf Add the inline static call implementation for x86-64. The generated code is identical to the out-of-line case, except we move the trampoline into it's own section. Objtool uses the trampoline naming convention to detect all the call sites. It then annotates those call sites

[PATCH v5 05/17] compiler.h: Make __ADDRESSABLE() symbol truly unique

2020-06-24 Thread Peter Zijlstra
From: Josh Poimboeuf The __ADDRESSABLE() macro uses the __LINE__ macro to create a temporary symbol which has a unique name. However, if the macro is used multiple times from within another macro, the line number will always be the same, resulting in duplicate symbols. Make the temporary symbol

[PATCH v5 06/17] static_call: Add basic static call infrastructure

2020-06-24 Thread Peter Zijlstra
From: Josh Poimboeuf Static calls are a replacement for global function pointers. They use code patching to allow direct calls to be used instead of indirect calls. They give the flexibility of function pointers, but with improved performance. This is especially important for cases where retpo

[PATCH v5 04/17] jump_label,module: Fix module lifetime for __jump_label_mod_text_reserved

2020-06-24 Thread Peter Zijlstra
Nothing ensures the module exists while we're iterating mod->jump_entries in __jump_label_mod_text_reserved(), take a module reference to ensure the module sticks around. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Steven Rostedt (VMware) --- kernel/jump_label.c | 10 -- 1 file

[PATCH v5 14/17] static_call: Handle tail-calls

2020-06-24 Thread Peter Zijlstra
GCC can turn our static_call(name)(args...) into a tail call, in which case we get a JMP.d32 into the trampoline (which then does a further tail-call). Teach objtool to recognise and mark these in .static_call_sites and adjust the code patching to deal with this. Signed-off-by: Peter Zijlstra (In

[PATCH v5 01/17] notifier: Fix broken error handling pattern

2020-06-24 Thread Peter Zijlstra
The current notifiers have the following error handling pattern all over the place: int err, nr; err = __foo_notifier_call_chain(&chain, val_up, v, -1, &nr); if (err & NOTIFIER_STOP_MASK) __foo_notifier_call_chain(&chain, val_down, v, nr-1, NULL) And aside

[PATCH v5 02/17] module: Fix up module_notifier return values

2020-06-24 Thread Peter Zijlstra
While auditing all module notifiers I noticed a whole bunch of fail wrt the return value. Notifiers have a 'special' return semantics. As is; NOTIFY_DONE vs NOTIFY_OK is a bit vague; but notifier_from_errno(0) results in NOTIFY_OK and NOTIFY_DONE has a comment that says "Don't care". >From this I

[PATCH v5 00/17] Add static_call()

2020-06-24 Thread Peter Zijlstra
Hi all, Hopefully for the last time... static_call(), is the idea of static_branch() applied to indirect function calls. Remove a data load (indirection) by modifying the text. The inline implementation still relies on objtool to generate the .static_call_sites section, mostly because this is a

[PATCH v5 17/17] x86/perf, static_call: Optimize x86_pmu methods

2020-06-24 Thread Peter Zijlstra
Replace many of the indirect calls with static_call(). XXX run performance numbers Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/events/core.c | 140 +++-- 1 file changed, 100 insertions(+), 40 deletions(-) --- a/arch/x86/events/core.c +++ b/ar

[PATCH v5 16/17] tracepoint: Optimize using static_call()

2020-06-24 Thread Peter Zijlstra
From: "Steven Rostedt (VMware)" Currently the tracepoint site will iterate a vector and issue indirect calls to however many handlers are registered (ie. the vector is long). Using static_call() it is possible to optimize this for the common case of only having a single handler registered. In th

[PATCH v5 07/17] static_call: Add inline static call infrastructure

2020-06-24 Thread Peter Zijlstra
From: Josh Poimboeuf Add infrastructure for an arch-specific CONFIG_HAVE_STATIC_CALL_INLINE option, which is a faster version of CONFIG_HAVE_STATIC_CALL. At runtime, the static call sites are patched directly, rather than using the out-of-line trampolines. Compared to out-of-line static calls,

Re: [PATCH v2 0/6] Remove default DMA window before creating DDW

2020-06-24 Thread Leonardo Bras
On Wed, 2020-06-24 at 03:24 -0300, Leonardo Bras wrote: > Patch #5: > Instead of destroying the created DDW if it doesn't map the whole > partition, make use of it instead of the default DMA window. > > Patch #6: > Changes the way iommu_bypass_supported_pSeriesLP() check for > iommu_bypass: inste

Re: [PATCH 1/5] f2fs: fix to wait page writeback before update

2020-06-24 Thread Jaegeuk Kim
On 06/22, Chao Yu wrote: > On 2020/6/22 0:38, Jaegeuk Kim wrote: > > On 06/20, Chao Yu wrote: > >> On 2020/6/20 6:47, Jaegeuk Kim wrote: > >>> On 06/19, Chao Yu wrote: > On 2020/6/19 13:49, Jaegeuk Kim wrote: > > On 06/19, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2020/6/19

[PATCH v3 1/6] power: supply: max17040: Use regmap i2c

2020-06-24 Thread Iskren Chernev
Rewrite i2c operations from i2c client read/write to regmap i2c. As a result, most private functions now accept the private driver data instead of an i2c client pointer. Signed-off-by: Iskren Chernev --- drivers/power/supply/Kconfig| 1 + drivers/power/supply/max17040_battery.c | 2

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-06-24 Thread Christian Borntraeger
On 24.06.20 16:43, Christoph Hellwig wrote: > On Wed, Jun 24, 2020 at 01:11:54PM +0200, Christian Borntraeger wrote: >> Does anyone have an idea why "umh: fix processed error when UMH_WAIT_PROC is >> used" breaks the >> linux-bridge on s390? > > Are we even sure this is s390 specific and doesn

[PATCH v3 0/6] power: supply: max17040 support compatible devices

2020-06-24 Thread Iskren Chernev
The max17040 fuel gauge is part of a family of 8 chips that have very similar mode of operations and registers. This patch set adds: - compatible strings for all supported devices and handles the minor differences between them; - handling for devices reporting double capacity via maxim,double-so

[PATCH v3 6/6] power: supply: max17040: Support soc alert

2020-06-24 Thread Iskren Chernev
max17048 and max17049 support SOC alerts (interrupts when battery capacity changes by +/- 1%). At the moment the driver polls for changes every second. Using the alerts removes the need for polling. Signed-off-by: Iskren Chernev --- drivers/power/supply/max17040_battery.c | 82 ++

<    1   2   3   4   5   6   7   8   9   10   >