Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Joerg Roedel
On Tue, Jun 23, 2020 at 03:03:22PM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 02:12:37PM +0200, Joerg Roedel wrote: > > On Tue, Jun 23, 2020 at 01:50:14PM +0200, Peter Zijlstra wrote: > > > If SNP is the sole reason #VC needs to be IST, then I'd strongly urge > > > you to only make it I

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Will Deacon
On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > We don't want to depend on the linker's orphan section placement > heuristics as these can vary between linkers, and may change between > versions. All sections need to be explicitly named in the linker > script. > > Explicitly include d

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 03:59:16PM +0200, Peter Zijlstra wrote: > So basically when your exception frame points to your own IST, you die. > That sounds like something we should have in generic IST code. Something like this... #DF already dies and NMI is 'magic' --- arch/x86/entry/common.c

Re: [PATCH v7 01/13] tools/libperf: introduce notion of static polled file descriptors

2020-06-23 Thread Jiri Olsa
On Mon, Jun 22, 2020 at 05:04:21PM +0300, Alexey Budankov wrote: SNIP > > there might be some loose ends (interface change), but > > I think this would solve our problems with fdarray > > Your first patch accomodated in v8 actually avoids fds typing > and solves pos (=fdarr

Re: [PATCH v8 12/13] perf record: implement control commands handling

2020-06-23 Thread Jiri Olsa
On Wed, Jun 17, 2020 at 11:43:58AM +0300, Alexey Budankov wrote: > > Implement handling of 'enable' and 'disable' control commands > coming from control file descriptor. > > Signed-off-by: Alexey Budankov > --- > tools/perf/builtin-record.c | 16 > 1 file changed, 16 insertions

Re: [PATCH v7 03/13] perf evlist: implement control command handling functions

2020-06-23 Thread Jiri Olsa
On Wed, Jun 03, 2020 at 06:54:47PM +0300, Alexey Budankov wrote: SNIP > + case EVLIST_CTL_CMD_ACK: > + case EVLIST_CTL_CMD_UNSUPPORTED: > + default: > + pr_debug("ctlfd: unsupported %d\n", *cmd); > +

Re: [PATCH v8 09/13] perf stat: implement control commands handling

2020-06-23 Thread Jiri Olsa
On Wed, Jun 17, 2020 at 11:41:30AM +0300, Alexey Budankov wrote: SNIP > > while (1) { > if (forks) > @@ -581,8 +617,17 @@ static int dispatch_events(bool forks, int timeout, int > interval, int *times, st > if (done || stop || child) > br

Re: [PATCH v8 09/13] perf stat: implement control commands handling

2020-06-23 Thread Jiri Olsa
On Wed, Jun 17, 2020 at 11:41:30AM +0300, Alexey Budankov wrote: > > Implement handling of 'enable' and 'disable' control commands > coming from control file descriptor. process_evlist() function > checks for events on control fds and makes required operations. > If poll event splits initiated tim

Re: [PATCH v8 03/13] perf evlist: implement control command handling functions

2020-06-23 Thread Jiri Olsa
On Wed, Jun 17, 2020 at 11:36:46AM +0300, Alexey Budankov wrote: SNIP > + memset(cmd_data, 0, data_size--); > + > + do { > + err = read(evlist->ctl_fd.fd, &c, 1); > + if (err > 0) { > + if (c == '\n' || c == '\0') > +

Re: [PATCH v8 07/13] perf stat: factor out event handling loop into dispatch_events()

2020-06-23 Thread Jiri Olsa
On Wed, Jun 17, 2020 at 11:40:03AM +0300, Alexey Budankov wrote: > > Consolidate event dispatching loops for fork, attach and system > wide monitoring use cases into common dispatch_events() function. > > Signed-off-by: Alexey Budankov > --- > tools/perf/builtin-stat.c | 35

Re: [PATCH v8 03/13] perf evlist: implement control command handling functions

2020-06-23 Thread Jiri Olsa
On Wed, Jun 17, 2020 at 11:36:46AM +0300, Alexey Budankov wrote: SNIP > +static int evlist__ctlfd_recv(struct evlist *evlist, enum evlist_ctl_cmd > *cmd, > + char *cmd_data, size_t data_size) > +{ > + int err; > + char c; > + size_t bytes_read = 0; > + > +

Re: [PATCH v8 04/13] perf stat: factor out body of event handling loop for system wide

2020-06-23 Thread Jiri Olsa
On Wed, Jun 17, 2020 at 11:37:43AM +0300, Alexey Budankov wrote: > > Introduce process_timeout() and process_interval() functions that > factor out body of event handling loop for attach and system wide > monitoring use cases. > > Signed-off-by: Alexey Budankov > --- > tools/perf/builtin-stat.c

[PATCH 1/2] gpio: aggregator: Drop pre-initialization in get_arg()

2020-06-23 Thread Geert Uytterhoeven
In get_arg(), the variable start is pre-initialized, but overwritten again in the first statement. Rework the assignment to not rely on pre-initialization, to make the code easier to read. Signed-off-by: Geert Uytterhoeven --- drivers/gpio/gpio-aggregator.c | 4 ++-- 1 file changed, 2 insertion

[PATCH 2/2] gpio: aggregator: Use bitmap_parselist() for parsing GPIO offsets

2020-06-23 Thread Geert Uytterhoeven
Replace the custom code to parse GPIO offsets and/or GPIO offset ranges by a call to bitmap_parselist(), and an iteration over the returned bit mask. This should have no impact on the format of the configuration parameters written to the "new_device" virtual file in sysfs. Suggested-by: Andy Shev

[PATCH 0/2] gpio: aggregator: Misc parsing improvements

2020-06-23 Thread Geert Uytterhoeven
Hi Linus, Bartosz, Andy, This patch series contains two improvements for the parsing code in the GPIO Aggregator. The second one converts the driver to use bitmap_parselist() for parsing GPIO offsets and/or ranges, as suggested by Andy[1]. Note that I'm not super happy with the mask[] arr

Re: [PATCH 12/13] ARM: dts: mmp3: Add the GPU

2020-06-23 Thread Lubomir Rintel
On Tue, Jun 23, 2020 at 03:35:24PM +0200, Pavel Machek wrote: > On Tue 2020-06-16 20:23:40, Lubomir Rintel wrote: > > There's a GC2000 3D core accompanied by a GC300 2D core. > > According to the next patch, it is GC200... Good catch, thanks. The other patch is wrong, it actually is GC2000 -- wil

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Joerg Roedel
On Tue, Jun 23, 2020 at 04:53:44PM +0200, Peter Zijlstra wrote: > +noinstr void idtentry_validate_ist(struct pt_regs *regs) > +{ > + if ((regs->sp & ~(EXCEPTION_STKSZ-1)) == > + (_RET_IP_ & ~(EXCEPTION_STKSZ-1))) > + die("IST stack recursion", regs, 0); > +} Yes, this is a

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Ard Biesheuvel
On Tue, 23 Jun 2020 at 16:52, Will Deacon wrote: > > On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > > We don't want to depend on the linker's orphan section placement > > heuristics as these can vary between linkers, and may change between > > versions. All sections need to be explic

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Ahmed S. Darwish
On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote: ... > -#define lockdep_assert_irqs_disabled() do { > \ > - WARN_ONCE(debug_locks && !current->lockdep_recursion && \ > - current->hardirqs_enabled,

Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

2020-06-23 Thread Sven Van Asbroeck
Hi Fabio, On Tue, Jun 23, 2020 at 10:19 AM Fabio Estevam wrote: > > You should limit this to imx6 quad plus only, so you would better > check against "fsl,imx6qp". Excellent suggestion, thank you ! I tried to determine if running on a plus by using the method from imx6q_init_machine(). But yes,

Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init

2020-06-23 Thread Markus Elfring
>>> Fix this by … >> >> Please replace the beginning of this sentence with the tag “Fixes”. >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 > > No, not really. The comment you (p

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Sun, Jun 21 2020 at 8:45pm -0400, Damien Le Moal wrote: > On 2020/06/20 1:56, Mike Snitzer wrote: > > On Fri, Jun 19 2020 at 12:41pm -0400, > > Ignat Korchagin wrote: > > > >> This is a follow up from the long-forgotten [1], but with some more > >> convincing > >> evidence. Consider the fo

Re: [PATCH v2] kvm: Fix false positive RCU usage warning

2020-06-23 Thread Joel Fernandes
On Tue, Jun 23, 2020 at 09:39:53AM +0200, Paolo Bonzini wrote: > On 16/05/20 10:22, madhuparnabhowmi...@gmail.com wrote: > > From: Madhuparna Bhowmik > > > > Fix the following false positive warnings: > > > > [ 9403.765413][T61744] = > > [ 9403.786541][T61744] WARNING

Re: [PATCH v8 03/13] perf evlist: implement control command handling functions

2020-06-23 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 23, 2020 at 04:56:01PM +0200, Jiri Olsa escreveu: > On Wed, Jun 17, 2020 at 11:36:46AM +0300, Alexey Budankov wrote: > > SNIP > > > + memset(cmd_data, 0, data_size--); > > + > > + do { > > + err = read(evlist->ctl_fd.fd, &c, 1); > > + if (err > 0) { > > +

Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2020-06-23 Thread Bjorn Helgaas
On Fri, Jun 19, 2020 at 10:26:54AM +0800, Zhangfei Gao wrote: > Have studied _DSM method, two issues we met comparing using quirk. > > 1. Need change definition of either pci_host_bridge or pci_dev, like adding > member can_stall, > while pci system does not know stall now. > > a, pci devices do

Re: [PATCH kcsan 0/10] KCSAN updates for v5.9

2020-06-23 Thread Marco Elver
On Tue, 23 Jun 2020 at 15:43, Paul E. McKenney wrote: > > On Tue, Jun 23, 2020 at 08:31:15AM +0200, Marco Elver wrote: > > On Tue, 23 Jun 2020 at 02:43, Paul E. McKenney wrote: > > > > > > Hello! > > > > > > This series provides KCSAN updates: > > > > > > 1. Annotate a data race in vm_area_d

Re: linux-next: Tree for Jun 23 (objtool (2))

2020-06-23 Thread Randy Dunlap
On 6/22/20 11:28 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20200622: > on x86_64: arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_timed_out()+0x24: unreachable instruction kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x14: unreachable instruction Full randconfi

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Ignat Korchagin
Do you think it may be better to break it in two flags: one for read path and one for write? So, depending on the needs and workflow these could be enabled independently? Regards, Ignat On Tue, Jun 23, 2020 at 4:01 PM Mike Snitzer wrote: > > On Sun, Jun 21 2020 at 8:45pm -0400, > Damien Le Moal

[PATCH] efi/libstub: EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER should not default to yes

2020-06-23 Thread Geert Uytterhoeven
EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER is deprecated, so it should not be enabled by default. In light of commit 4da0b2b7e67524cc ("efi/libstub: Re-enable command line initrd loading for x86"), keep the default for X86. Fixes: cf6b83664895a5c7 ("efi/libstub: Make initrd file loader configurable")

Re: [PATCH 1/2][v3] PM / s2idle: Clear _TIF_POLLING_NRFLAG before suspend to idle

2020-06-23 Thread Rafael J. Wysocki
On Tue, Jun 23, 2020 at 8:30 AM Chen Yu wrote: > > Suspend to idle was found to not work on Goldmont CPU recently. > And the issue was triggered due to: > > 1. On Goldmont the CPU in idle can only be woken up via IPIs, >not POLLING mode: >Commit 08e237fa56a1 ("x86/cpu: Add workaround for M

Re: [PATCH v8 03/13] perf evlist: implement control command handling functions

2020-06-23 Thread Jiri Olsa
On Tue, Jun 23, 2020 at 12:03:45PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 23, 2020 at 04:56:01PM +0200, Jiri Olsa escreveu: > > On Wed, Jun 17, 2020 at 11:36:46AM +0300, Alexey Budankov wrote: > > > > SNIP > > > > > + memset(cmd_data, 0, data_size--); > > > + > > > + do { > > > +

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-06-23 Thread Enric Balletbo i Serra
Hi Sam, Many thanks for your feedback. See my answers below. On 20/6/20 23:42, Sam Ravnborg wrote: > Hi Enric. > > On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote: >> The get_edid() callback can be triggered anytime by an ioctl, i.e >> >> drm_mode_getconnector (ioctl) >>

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 04:49:40PM +0200, Joerg Roedel wrote: > > We're talking about the 3rd case where the only reason things 'work' is > > because we'll have to panic(): > > > > - #MC > > Okay, #MC is special and can only be handled on a best-effort basis, as > #MC could happen anytime, also

Re: linux-next: build failure after merge of the printk tree

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 04:28:58PM +0200, Petr Mladek wrote: > PS: And yes, it makes sense to push both patches via a single tree to > make sure that the lockdep.h split is done first. That's what I got you tip/locking/header for, pull that topic branch into your tree.

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-23 Thread Michal Hocko
On Tue 23-06-20 17:42:58, Wei Yang wrote: > For early sections, we assumes its memmap will never be partially > removed. But current behavior breaks this. > > Let's correct it. > > Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > Signed-off-by: Wei Yang Can a user trigger thi

Re: krzysztof/for-next bisection: baseline.dmesg.crit on bcm2837-rpi-3-b

2020-06-23 Thread Guillaume Tucker
On 23/06/2020 15:23, kernelci.org bot wrote: > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Tue, Jun 23 2020 at 11:07am -0400, Ignat Korchagin wrote: > Do you think it may be better to break it in two flags: one for read > path and one for write? So, depending on the needs and workflow these > could be enabled independently? If there is a need to split, then sure. But I think Damie

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Andrew Cooper
On 23/06/2020 14:03, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 02:12:37PM +0200, Joerg Roedel wrote: >> On Tue, Jun 23, 2020 at 01:50:14PM +0200, Peter Zijlstra wrote: >>> If SNP is the sole reason #VC needs to be IST, then I'd strongly urge >>> you to only make it IST if/when you try and mak

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 04:59:14PM +0200, Joerg Roedel wrote: > On Tue, Jun 23, 2020 at 04:53:44PM +0200, Peter Zijlstra wrote: > > +noinstr void idtentry_validate_ist(struct pt_regs *regs) > > +{ > > + if ((regs->sp & ~(EXCEPTION_STKSZ-1)) == > > + (_RET_IP_ & ~(EXCEPTION_STKSZ-1))) > > +

Re: [PATCH AUTOSEL 4.14 090/108] ovl: verify permissions in ovl_path_open()

2020-06-23 Thread Naresh Kamboju
On Thu, 18 Jun 2020 at 07:18, Sasha Levin wrote: > > From: Miklos Szeredi > > [ Upstream commit 56230d956739b9cb1cbde439d76227d77979a04d ] > > Check permission before opening a real file. > > ovl_path_open() is used by readdir and copy-up routines. > > ovl_permission() theoretically already check

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 05:00:31PM +0200, Ahmed S. Darwish wrote: > On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote: > ... > > -#define lockdep_assert_irqs_disabled() do { > > \ > > - WARN_ONCE(debug_locks && !current->lockdep_recursion && \

Re: [PATCH v2] kvm: Fix false positive RCU usage warning

2020-06-23 Thread Madhuparna Bhowmik
On Tue, Jun 23, 2020 at 09:39:53AM +0200, Paolo Bonzini wrote: > On 16/05/20 10:22, madhuparnabhowmi...@gmail.com wrote: > > From: Madhuparna Bhowmik > > > > Fix the following false positive warnings: > > > > [ 9403.765413][T61744] = > > [ 9403.786541][T61744] WARNING

Re: [v1,net-next 4/4] net: enetc add tc flower offload flow metering policing action

2020-06-23 Thread kernel test robot
submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Po-Liu/net-qos-add-tc-police-offloading-action-with-max-frame-size-limit/20200623-153724 base:27f11fea33608cbd321a97cbecfa2ef97dcc1821 config: parisc

Re: [PATCH v2] kvm: Fix false positive RCU usage warning

2020-06-23 Thread Madhuparna Bhowmik
On Tue, Jun 23, 2020 at 11:02:36AM -0400, Joel Fernandes wrote: > On Tue, Jun 23, 2020 at 09:39:53AM +0200, Paolo Bonzini wrote: > > On 16/05/20 10:22, madhuparnabhowmi...@gmail.com wrote: > > > From: Madhuparna Bhowmik > > > > > > Fix the following false positive warnings: > > > > > > [ 9403.76

Re: [PATCH AUTOSEL 5.7 319/388] ovl: verify permissions in ovl_path_open()

2020-06-23 Thread Naresh Kamboju
On Thu, 18 Jun 2020 at 08:03, Sasha Levin wrote: > > From: Miklos Szeredi > > [ Upstream commit 56230d956739b9cb1cbde439d76227d77979a04d ] > > Check permission before opening a real file. > > ovl_path_open() is used by readdir and copy-up routines. > > ovl_permission() theoretically already check

Re: [RESEND PATCH v2 1/2] PM / domains: Introduce multi PM domains helpers

2020-06-23 Thread kernel test robot
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on pm/linux-next] [also build test WARNING on shawnguo/for-next linux/master linus/master v5.8-rc2 next-20200623] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH] x86/mce, edac/mce_amd: Print PPIN in machine check records

2020-06-23 Thread Borislav Petkov
On Tue, Jun 23, 2020 at 08:00:59AM -0500, Smita Koralahalli wrote: > For AMD processors that support Protected Processor Identification Not only AMD processors - Intel support it too. I've made the commit message vendor-agnostic. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes

Re: Strange problem with SCTP+IPv6

2020-06-23 Thread Xin Long
On Tue, Jun 23, 2020 at 9:29 PM Corey Minyard wrote: > > On Tue, Jun 23, 2020 at 06:13:30PM +0800, Xin Long wrote: > > On Tue, Jun 23, 2020 at 2:34 AM Michael Tuexen > > wrote: > > > > > > > On 22. Jun 2020, at 20:32, Marcelo Ricardo Leitner > > > > wrote: > > > > > > > > On Mon, Jun 22, 2020 a

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Andrew Cooper
On 23/06/2020 16:16, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 04:49:40PM +0200, Joerg Roedel wrote: >>> We're talking about the 3rd case where the only reason things 'work' is >>> because we'll have to panic(): >>> >>> - #MC >> Okay, #MC is special and can only be handled on a best-effort b

Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Christian Borntraeger
On 23.06.20 15:14, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. For historical reasons, many kvm-related function parameters > retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This > patch does a unified cleanup of

[tip: ras/core] x86/mce, EDAC/mce_amd: Print PPIN in machine check records

2020-06-23 Thread tip-bot2 for Smita Koralahalli
The following commit has been merged into the ras/core branch of tip: Commit-ID: bb2de0adca217a114ce023489426e24152e4bfcf Gitweb: https://git.kernel.org/tip/bb2de0adca217a114ce023489426e24152e4bfcf Author:Smita Koralahalli AuthorDate:Tue, 23 Jun 2020 08:00:59 -05:00 Commit

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Fri, Jun 19 2020 at 9:23pm -0400, Herbert Xu wrote: > On Fri, Jun 19, 2020 at 02:39:39PM -0400, Mikulas Patocka wrote: > > > > I'm looking at this and I'd like to know why does the crypto API fail in > > hard-irq context and why does it work in tasklet context. What's the exact > > reason b

Re: [PATCH AUTOSEL 4.19 138/172] ovl: verify permissions in ovl_path_open()

2020-06-23 Thread Naresh Kamboju
On Thu, 18 Jun 2020 at 07:16, Sasha Levin wrote: > > From: Miklos Szeredi > > [ Upstream commit 56230d956739b9cb1cbde439d76227d77979a04d ] > > Check permission before opening a real file. > > ovl_path_open() is used by readdir and copy-up routines. > > ovl_permission() theoretically already check

[PATCH 7/7] iommu/vt-d: Disable multiple GPASID-dev bind

2020-06-23 Thread Jacob Pan
For the unlikely use case where multiple aux domains from the same pdev are attached to a single guest and then bound to a single process (thus same PASID) within that guest, we cannot easily support this case by refcounting the number of users. As there is only one SL page table per PASID while we

[PATCH 5/7] iommu/vt-d: Fix devTLB flush for vSVA

2020-06-23 Thread Jacob Pan
From: Liu Yi L For guest SVA usage, in order to optimize for less VMEXIT, guest request of IOTLB flush also includes device TLB. On the host side, IOMMU driver performs IOTLB and implicit devTLB invalidation. When PASID-selective granularity is requested by the guest we need to derive the equiva

[PATCH 3/7] iommu/vt-d: Fix PASID devTLB invalidation

2020-06-23 Thread Jacob Pan
DevTLB flush can be used for both DMA request with and without PASIDs. The former uses PASID#0 (RID2PASID), latter uses non-zero PASID for SVA usage. This patch adds a check for PASID value such that devTLB flush with PASID is used for SVA case. This is more efficient in that multiple PASIDs can b

I'm being accused of "killing foss", how do I respond?

2020-06-23 Thread nipponmail
Dear RMS, a commentator is now accusing me of being the executioner of "foss" : oh it's you, the schizo who killed foss by trying to defend it and thinks he's a lawyer Later the commentator clarifies : You went on a mailing list for some foss project with the intention of exposing a patent

[PATCH 4/7] iommu/vt-d: Handle non-page aligned address

2020-06-23 Thread Jacob Pan
From: Liu Yi L Address information for device TLB invalidation comes from userspace when device is directly assigned to a guest with vIOMMU support. VT-d requires page aligned address. This patch checks and enforce address to be page aligned, otherwise reserved bits can be set in the invalidation

[PATCH 1/7] iommu/vt-d: Enforce PASID devTLB field mask

2020-06-23 Thread Jacob Pan
From: Liu Yi L Set proper masks to avoid invalid input spillover to reserved bits. Signed-off-by: Liu Yi L Signed-off-by: Jacob Pan --- include/linux/intel-iommu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h

[PATCH 0/7] iommu/vt-d: Misc tweaks and fixes for vSVA

2020-06-23 Thread Jacob Pan
Hi Baolu and all, This a series to address some of the issues we found in vSVA support. Most of the patches deal with exception handling, we also removed some bits that are not currently supported. Many thanks to Kevin Tian's review. Jacob & Yi Jacob Pan (4): iommu/vt-d: Remove global page su

[PATCH 2/7] iommu/vt-d: Remove global page support in devTLB flush

2020-06-23 Thread Jacob Pan
Global pages support is removed from VT-d spec 3.0 for dev TLB invalidation. This patch is to remove the bits for vSVA. Similar change already made for the native SVA. See the link below. Link: https://lkml.org/lkml/2019/8/26/651 Signed-off-by: Jacob Pan --- drivers/iommu/intel/dmar.c | 4 +---

Re: [PATCH 1/2] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy

2020-06-23 Thread Sascha Hauer
On Tue, Jun 23, 2020 at 12:53:40AM +0100, Russell King - ARM Linux admin wrote: > On Tue, Jun 16, 2020 at 10:31:39AM +0200, Sascha Hauer wrote: > > The MVNETA_SERDES_CFG register is only available on older SoCs like the > > Armada XP. On newer SoCs like the Armada 38x the fields are moved to > > co

[PATCH 6/7] iommu/vt-d: Warn on out-of-range invalidation address

2020-06-23 Thread Jacob Pan
For guest requested IOTLB invalidation, address and mask are provided as part of the invalidation data. VT-d HW silently ignores any address bits below the mask. SW shall also allow such case but give warning if address does not align with the mask. This patch relax the fault handling from error to

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Joerg Roedel
On Tue, Jun 23, 2020 at 05:23:26PM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 04:59:14PM +0200, Joerg Roedel wrote: > > On Tue, Jun 23, 2020 at 04:53:44PM +0200, Peter Zijlstra wrote: > > > +noinstr void idtentry_validate_ist(struct pt_regs *regs) > > > +{ > > > + if ((regs->sp & ~(EXCE

Re: [PATCH v2] kvm: Fix false positive RCU usage warning

2020-06-23 Thread Paul E. McKenney
On Tue, Jun 23, 2020 at 09:00:36PM +0530, Madhuparna Bhowmik wrote: > On Tue, Jun 23, 2020 at 11:02:36AM -0400, Joel Fernandes wrote: > > On Tue, Jun 23, 2020 at 09:39:53AM +0200, Paolo Bonzini wrote: > > > On 16/05/20 10:22, madhuparnabhowmi...@gmail.com wrote: > > > > From: Madhuparna Bhowmik >

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 05:23:26PM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 04:59:14PM +0200, Joerg Roedel wrote: > > On Tue, Jun 23, 2020 at 04:53:44PM +0200, Peter Zijlstra wrote: > > > +noinstr void idtentry_validate_ist(struct pt_regs *regs) > > > +{ > > > + if ((regs->sp & ~(EXCE

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Andrew Cooper
On 23/06/2020 16:23, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 04:59:14PM +0200, Joerg Roedel wrote: >> On Tue, Jun 23, 2020 at 04:53:44PM +0200, Peter Zijlstra wrote: >>> +noinstr void idtentry_validate_ist(struct pt_regs *regs) >>> +{ >>> + if ((regs->sp & ~(EXCEPTION_STKSZ-1)) == >>> +

Re: [PATCH v7 00/19] The new cgroup slab memory controller

2020-06-23 Thread Roman Gushchin
On Tue, Jun 23, 2020 at 03:53:06PM +0200, Vlastimil Babka wrote: > On 6/23/20 3:58 AM, Roman Gushchin wrote: > > This is v7 of the slab cgroup controller rework. > > Hi, > > As you and Jesper did those measurements on v6, and are sending v7, it would > be > great to put some summary in the cover

Dear

2020-06-23 Thread peace maurice
-- Please can we talk? Something just came up and it's very urgent,please i need your attention. Regards Peace.

Re: [PATCH v7 09/19] mm: memcg/slab: charge individual slab objects instead of pages

2020-06-23 Thread Roman Gushchin
On Mon, Jun 22, 2020 at 10:19:25PM -0700, Shakeel Butt wrote: > On Mon, Jun 22, 2020 at 6:58 PM Roman Gushchin wrote: > > > > Switch to per-object accounting of non-root slab objects. > > > > Charging is performed using obj_cgroup API in the pre_alloc hook. > > Obj_cgroup is charged with the size

YOUR GIFT WESTERN UNION PAYMENT

2020-06-23 Thread Barr Kummar Faso
ATTN;BENEFICIARY: You are welcome to Western UNION office Burkina Faso. Am Barr Kummar Faso by name, The new director of Western Union Foreign Operation. I resumed work today and your daily transfer file was submitted as pending payment in our Western union Bank and after my verifica

Re: [PATCH AUTOSEL 5.4 219/266] ovl: verify permissions in ovl_path_open()

2020-06-23 Thread Naresh Kamboju
On Thu, 18 Jun 2020 at 06:51, Sasha Levin wrote: > > From: Miklos Szeredi > > [ Upstream commit 56230d956739b9cb1cbde439d76227d77979a04d ] > > Check permission before opening a real file. > > ovl_path_open() is used by readdir and copy-up routines. > > ovl_permission() theoretically already check

Re: [PATCH] rcu/tree: Force quiescent state on callback overload

2020-06-23 Thread Joel Fernandes
On Mon, Jun 22, 2020 at 12:07:27AM +0530, Neeraj Upadhyay wrote: > On callback overload, we want to force quiescent state immediately, > for the first and second fqs. Enforce the same, by including > RCU_GP_FLAG_OVLD flag, in fqsstart check. > > Signed-off-by: Neeraj Upadhyay > --- Reviewed-by:

Re: [PATCH v2] kvm: Fix false positive RCU usage warning

2020-06-23 Thread Joel Fernandes
On Tue, Jun 23, 2020 at 08:39:01AM -0700, Paul E. McKenney wrote: > On Tue, Jun 23, 2020 at 09:00:36PM +0530, Madhuparna Bhowmik wrote: > > On Tue, Jun 23, 2020 at 11:02:36AM -0400, Joel Fernandes wrote: > > > On Tue, Jun 23, 2020 at 09:39:53AM +0200, Paolo Bonzini wrote: > > > > On 16/05/20 10:22,

Re: [PATCH 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-06-23 Thread Qais Yousef
Hi Vincent On 06/11/20 14:01, Vincent Guittot wrote: > On Thu, 11 Jun 2020 at 12:24, Qais Yousef wrote: [...] > > > Strange because I have been able to trace them. > > > > On your arm platform? I can certainly see them on x86. > > yes on my arm platform Sorry for not getting back to you earli

[kbuild] Re: [PATCH v7 33/36] rapidio: fix common struct sg_table related issues

2020-06-23 Thread Dan Carpenter
Hi Marek, url: https://github.com/0day-ci/linux/commits/Marek-Szyprowski/DRM-fix-struct-sg_table-nents-vs-orig_nents-misuse/20200619-184302 base:ce2cc8efd7a40cbd17841add878cb691d0ce0bba config: i386-randconfig-m021-20200623 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If

RE: [PATCH 1/1] power_supply: wilco_ec: Add permanent long life charging mode

2020-06-23 Thread Crag.Wang
> -Original Message- > From: Limonciello, Mario > Sent: Tuesday, June 23, 2020 9:48 PM > To: Crag Wang; Sebastian Reichel > Cc: math...@chromium.org; Wang, Crag; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: RE: [PATCH 1/1] power_supply: wilco_ec: Add permanent long

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Borislav Petkov
On Tue, Jun 23, 2020 at 12:51:03PM +0100, Andrew Cooper wrote: > Crashing out hard if the hypervisor is misbehaving is acceptable.  In a > cloud, I as a customer would (threaten to?) take my credit card > elsewhere, while for enterprise, I'd shout at my virtualisation vendor > until a fix happened

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 04:39:26PM +0100, Andrew Cooper wrote: > On 23/06/2020 16:23, Peter Zijlstra wrote: > > On Tue, Jun 23, 2020 at 04:59:14PM +0200, Joerg Roedel wrote: > >> Yes, this is a start, it doesn't cover the case where the NMI stack is > >> in-between, so I think you need to walk dow

RE: [PATCH 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency

2020-06-23 Thread Doug Smythies
On 2020.06.22 22:13 Srinivas Pandruvada wrote: > By default intel_pstate driver disables energy efficiency by setting > MSR_IA32_POWER_CTL bit 19 for Kaby Lake desktop CPU model in HWP mode. > This CPU model is also shared by Coffee Lake desktop CPUs. This allows > these systems to reach maximum p

Re: [PATCH tip/core/rcu 13/14] tools/memory-model/README: Expand dependency of klitmus7

2020-06-23 Thread Paul E. McKenney
On Tue, Jun 23, 2020 at 11:37:32PM +0900, Akira Yokosawa wrote: > On Mon, 22 Jun 2020 17:52:30 -0700, paul...@kernel.org wrote: > > From: Akira Yokosawa > > > > klitmus7 is independent of the memory model but depends on the > > build-target kernel release. > > It occasionally lost compatibility d

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-06-23 Thread Eugenio Perez Martin
On Tue, Jun 23, 2020 at 10:25 AM Michael S. Tsirkin wrote: > > On Tue, Jun 23, 2020 at 09:00:57AM +0200, Eugenio Perez Martin wrote: > > On Tue, Jun 23, 2020 at 4:51 AM Jason Wang wrote: > > > > > > > > > On 2020/6/23 上午12:00, Michael S. Tsirkin wrote: > > > > On Wed, Jun 17, 2020 at 11:19:26AM +

Re: [PATCH 1/7] irqchip: Fix potential resource leaks

2020-06-23 Thread Markus Elfring
> There exists some potential resource leaks in the error path, fix them. Will the tag “Fixes” become relevant for the commit message? … > +++ b/drivers/irqchip/irq-nvic.c > @@ -94,6 +94,7 @@ static int __init nvic_of_init(struct device_node *node, > > if (!nvic_irq_domain) { >

Re: [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq

2020-06-23 Thread Qais Yousef
On 06/22/20 11:19, Doug Anderson wrote: [...] > > Hmm I thought OEMs who ship stuff that are based on Chrome OS would have to > > do > > the final tuning here, which would be based on the recommendation of the SoC > > vendor. And I'm being overly generic here to think not only SoC from Intel > >

Re: [PATCH v2 5/9] docs: move nommu-mmap.txt to admin-guide and rename to ReST

2020-06-23 Thread Mike Rapoport
On Tue, Jun 23, 2020 at 11:52:58AM +0200, Mauro Carvalho Chehab wrote: > The nommu-mmap.txt file provides description of user visible > behaviuour. So, move it to the admin-guide. > > As it is already at the ReST, also rename it. > > Suggested-by: Mike Rapoport > Suggested-by: Jonathan Corbet >

[PATCH v4] ima: extend boot_aggregate with kernel measurements

2020-06-23 Thread Maurizio Drocco
Registers 8-9 are used to store measurements of the kernel and its command line (e.g., grub2 bootloader with tpm module enabled). IMA should include them in the boot aggregate. Registers 8-9 should be only included in non-SHA1 digests to avoid ambiguity. Signed-off-by: Maurizio Drocco --- Changel

ERROR: "min_low_pfn" undefined!

2020-06-23 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dd0d718152e4c65b173070d48ea9dfc06894c3e5 commit: b35b9a10362d203451d920d01ab8d6cd55cbaf2a mtd: spi-nor: Move m25p80 code in spi-nor.c date: 11 months ago config: microblaze-randconfig-r033-20200623

Re: [PATCH] kvm: x86 mmu: avoid mmu_page_hash lookup for direct_map-only VM

2020-06-23 Thread Sean Christopherson
On Mon, Jun 22, 2020 at 11:53:48PM -0700, Sean Christopherson wrote: > If we do get agressive and zap all children (or if my analysis is wrong), > and prevent the mixed level insansity, then a simpler approach would be to > skip the lookup if the MMU is direct. I.e. no need for the per-VM toggle.

Re: Strange problem with SCTP+IPv6

2020-06-23 Thread Corey Minyard
On Tue, Jun 23, 2020 at 11:40:21PM +0800, Xin Long wrote: > On Tue, Jun 23, 2020 at 9:29 PM Corey Minyard wrote: > > > > On Tue, Jun 23, 2020 at 06:13:30PM +0800, Xin Long wrote: > > > On Tue, Jun 23, 2020 at 2:34 AM Michael Tuexen > > > wrote: > > > > > > > > > On 22. Jun 2020, at 20:32, Marcelo

Re: [v1,net-next 4/4] net: enetc add tc flower offload flow metering policing action

2020-06-23 Thread kernel test robot
submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Po-Liu/net-qos-add-tc-police-offloading-action-with-max-frame-size-limit/20200623-153724 base:27f11fea33608cbd321a97cbecfa2ef97dcc1821 config: i386

Re: [PATCH v4 2/2] ASoC: tas2562: Update shutdown GPIO property

2020-06-23 Thread Dan Murphy
Hello On 6/12/20 12:14 PM, Dan Murphy wrote: Update the shutdown GPIO property to be shutdown from shut-down. I have some other patches that go on top of this patchset I am wondering if I should re-submit with those patches on top or indicate in a cover letter the dependency Dan

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Peter Zijlstra
On Tue, Jun 23, 2020 at 05:38:55PM +0200, Joerg Roedel wrote: > On Tue, Jun 23, 2020 at 05:23:26PM +0200, Peter Zijlstra wrote: > > Reliability of that depends on the unwinder, I wouldn't want the guess > > uwinder to OOPS me by accident. > > It doesn't use the full unwinder, it just assumes that

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Dave Hansen
On 6/23/20 8:52 AM, Peter Zijlstra wrote: > Isn't current #MC unconditionally fatal from kernel? But yes, I was > sorta aware people want that changed. Not unconditionally. copy_to_iter_mcsafe() is a good example of one thing we _can_ handle.

[PATCH] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket

2020-06-23 Thread minyard
From: Corey Minyard If a socket was set ipv6only, it would still send IPv4 addresses in the init and init ack packets. So don't add IPv4 addresses to ipv6only sockets. Based on a patch by Xin Long Signed-off-by: Corey Minyard --- I have tested this and it seem to fix the issue. However, I'm

Re: [PATCH v6] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

2020-06-23 Thread Manikandan
On Tue, Jun 23, 2020 at 07:07:11AM -0700, Guenter Roeck wrote: > On Mon, Jun 22, 2020 at 09:07:27PM +0530, Manikandan Elumalai wrote: > > The adm1278 temp attribute need it for openbmc platform . > > This feature not enabled by default, so PMON_CONFIG needs to enable it. > > > > Reported-by: kerne

Re: Should SEV-ES #VC use IST? (Re: [PATCH] Allow RDTSC and RDTSCP from userspace)

2020-06-23 Thread Borislav Petkov
On Tue, Jun 23, 2020 at 04:32:22PM +0100, Andrew Cooper wrote: > MSR_MCG_STATUS.MCIP, and yes - any #MC before that point will > immediately Shutdown.  Any #MC between that point and IRET will clobber > its IST stack and end up sad. Well, at some point we should simply accept that we're living a l

Re: [PATCH v2] arm64/module: Optimize module load time by optimizing PLT counting

2020-06-23 Thread Will Deacon
On Mon, Jun 22, 2020 at 06:18:02PM -0700, Saravana Kannan wrote: > When loading a module, module_frob_arch_sections() tries to figure out > the number of PLTs that'll be needed to handle all the RELAs. While > doing this, it tries to dedupe PLT allocations for multiple > R_AARCH64_CALL26 relocation

[PATCH] docs: sysctl/kernel: document random

2020-06-23 Thread Stephen Kitt
This documents the random directory, based on the behaviour seen in drivers/char/random.c. Signed-off-by: Stephen Kitt --- Documentation/admin-guide/sysctl/kernel.rst | 32 + 1 file changed, 32 insertions(+) diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documen

RE: [PATCH 11/17] hexagon: switch to copy_thread_tls()

2020-06-23 Thread Brian Cain
... > Cc: Brian Cain > Cc: linux-hexa...@vger.kernel.org > Signed-off-by: Christian Brauner > --- > arch/hexagon/Kconfig | 1 + > arch/hexagon/kernel/process.c | 6 +++--- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig in

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Ahmed S. Darwish
On Tue, Jun 23, 2020 at 05:24:50PM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 05:00:31PM +0200, Ahmed S. Darwish wrote: > > On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote: > > ... > > > -#define lockdep_assert_irqs_disabled() do { > > > \ >

<    2   3   4   5   6   7   8   9   10   11   >