On Mon, 2020-06-15 at 08:46 +0200, SeongJae Park wrote:
> So, I agree this patch is imperfect for many cases, but better than nothing.
Not necessarily.
Having people strain for unusual equivalents
to generally well known terms is not good.
blacklist/whitelist is well understood.
Would you do th
On Sat, Jun 13, 2020 at 11:44:22AM -0700, Jonathan Bakker wrote:
> A couple of new drivers have now been added, so we can add support for
> them in the device tree for Aries. These are the accelerometer (bma023)
> and the light/proximity sensor (gp2a).
>
> Additionally, the fuelgauge definition w
On Thu, Jun 11, 2020 at 12:20:32PM -0700, David Rientjes wrote:
> When a coherent mapping is created in dma_direct_alloc_pages(), it needs
> to be decrypted if the device requires unencrypted DMA before returning.
>
> Fixes: 3acac065508f ("dma-mapping: merge the generic remapping helpers
> into dm
On Mon, Jun 15, 2020 at 06:31:28AM +, Aisheng Dong wrote:
> > From: Andy Duan
> > Sent: Monday, June 15, 2020 10:49 AM
> >
> > From: wu000...@umn.edu Sent: Sunday, June 14,
> > 2020 6:12 AM
> > > From: Qiushi Wu
> > >
> > > pm_runtime_get_sync() increments the runtime PM usage counter even
>
On Mon, Jun 15, 2020 at 06:33:40AM +, Aisheng Dong wrote:
> > From: Wolfram Sang
> > Sent: Sunday, June 14, 2020 5:12 PM
> >
> > On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote:
> > > pm_runtime_get_sync() increments the runtime PM usage counter even the
> > > call returns an erro
On 13/6/20 2:35 am, Luc Van Oostenryck wrote:
On Sat, Jun 13, 2020 at 01:33:16AM +1000, Greg Ungerer wrote:
arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted
__le32
This one I am not sure about yet.
Still investigating.
swab32(__raw_readl(addr)) ?
Keepi
On Sun, Jun 14, 2020 at 06:34:33PM +0300, Vladimir Oltean wrote:
> On Sun, 14 Jun 2020 at 18:12, Krzysztof Kozlowski wrote:
> >
> > On Sun, Jun 14, 2020 at 04:43:28PM +0300, Vladimir Oltean wrote:
> > > On Sun, 14 Jun 2020 at 16:39, Vladimir Oltean wrote:
> > > >
> > > > On Sun, 14 Jun 2020 at 14
On Fri, Jun 12, 2020 at 04:57:37PM +1000, Herbert Xu wrote:
> The header file linux/uio.h includes crypto/hash.h which pulls in
> most of the Crypto API. Since linux/uio.h is used throughout the
> kernel this means that every tiny bit of change to the Crypto API
> causes the entire kernel to get r
On 15/06/20 06:20, Paul E. McKenney wrote:
>
> I get the following conflict when rebasing 39a8c47635b0 ("kvm/svm:
> Disable KCSAN for svm_vcpu_run()") onto v5.8-rc1:
>
> <<< 6c410247efb2d3907b508a2448ab9ab1c86d938c
> static fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
> ===
> static __n
> /* Write UIC Cmd */
> ufshcd_writel(hba, uic_cmd->command & COMMAND_OPCODE_MASK,
> REG_UIC_COMMAND);
> @@ -4825,11 +4847,15 @@ static irqreturn_t ufshcd_uic_cmd_compl(struct
> ufs_hba *hba, u32 intr_status)
> ufshcd_get_uic_cmd_result(
Hi Linus,
On Fri, Jun 12, 2020 at 08:07:32AM +0800, Philip Li wrote:
> On Thu, Jun 11, 2020 at 01:24:09PM -0700, Linus Torvalds wrote:
> >
> > IOW, rather than the above "just run all fo the lkp scripts",
> > something like how to run the actual individual test would be good.
> >
> > IOW how do
On Mon, Jun 15, 2020 at 4:59 AM Randy Dunlap wrote:
> From: Randy Dunlap
>
> Remove SH-5 documentation index entries following the removal
> of SH-5 source code.
>
> Error: Cannot open file ../arch/sh/mm/tlb-sh5.c
> Error: Cannot open file ../arch/sh/mm/tlb-sh5.c
> Error: Cannot open file ../arch
On Sun, Jun 14, 2020 at 06:48:04PM +0300, Vladimir Oltean wrote:
> On Sun, 14 Jun 2020 at 13:57, Krzysztof Kozlowski wrote:
> >
> > If interrupt comes late, during probe error path or device remove (could
> > be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler
> > dspi_interrupt() will ac
Hi Mike,
On 15/6/20 4:22 pm, Mike Rapoport wrote:
On Mon, Jun 15, 2020 at 01:53:42PM +1000, Greg Ungerer wrote:
From: Mike Rapoport
Currently, architectures that use free_area_init() to initialize memory map
and node and zone structures need to calculate zone and hole sizes. We can
use free_a
NAND flash memory-based storage devices use Flash Translation Layer (FTL)
to translate logical addresses of I/O requests to corresponding flash
memory addresses. Mobile storage devices typically have RAM with
constrained size, thus lack in memory to keep the whole mapping table.
Therefore, mapping
On 14-06-20, 13:04, Robin Gong wrote:
> On 2020/06/12 22:16 Mark Brown wrote:
> > On Fri, Jun 12, 2020 at 01:48:41PM +, Robin Gong wrote:
> > > On 2020/06/12 18:14 Mark Brown wrote:
> >
> > > > Please look at the formatting of your e-mails - they're really hard
> > > > to read. The line le
Hi Kamal,
Kamal Dasu wrote on Fri, 12 Jun 2020 12:34:22
-0400:
> On Fri, Jun 12, 2020 at 3:07 AM Miquel Raynal
> wrote:
> >
> > Hi Kamal,
> >
> > Kamal Dasu wrote on Thu, 11 Jun 2020 12:04:29
> > -0400:
> >
> > > On Thu, Jun 11, 2020 at 3:27 AM Miquel Raynal
> > > wrote:
> > > >
> > > >
Hi Koba Ko,
On 2020/6/15 11:19, Koba Ko wrote:
hi All,
I have a machine and there's only intel gpu.
the secureboot and vt-d is enabled in BIOS.
On the Ubuntu desktop, I do s2idle first and restart the machine.
The machine can't restart successfully, so I need to press the
power button to shutdo
On Fri, Jun 12, 2020 at 02:09:31PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Fix AHCI_SHT() macro definition to not reinitialize .can_queue and
> .sdev_attrs fields.
>
> This removes gcc warnings from W=1 builds such as:
I think these warnings arg bogus, at least when used with cases like
libata
Hi Kamal,
Kamal Dasu wrote on Sat, 13 Jun 2020 02:49:31
-0400:
> Can you please accept this if there are no objections.
>
> Kamal
>
> > On May 4, 2020, at 7:54 PM, Kamal Dasu wrote:
> >
> > Check and set master panic write flag so that low level drivers
> > can use it to take required actio
Hi,
This series adds trace event for UIC commands and do a small cleanup in struct
uic_command.
v2 -> v3:
- Refactor "complete" event hooks in ufshcd_uic_cmd_compl() (Avri Altman)
v1 -> v2:
- Rename "uic_send" to "send" and "uic_complete" to "complete"
- Move "send" trace before UIC comman
Remove unused field "cmd_active" and "result" in struct ufs_command.
Signed-off-by: Stanley Chu
Reviewed-by: Alim Akhtar
---
drivers/scsi/ufs/ufshcd.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index bf97d616e597..7fa35c78342b 10
Use the ftrace infrastructure to conditionally trace UFS UIC command
events.
New trace event "ufshcd_uic_command" is created, which samples the
following UFS UIC command data:
- Device name
- Optional identification string
- UIC command opcode
- UIC command argument1
- UIC command argument2
- UIC
From: Bartosz Golaszewski
There's no reason to have these as macros. Let's convert them all to
static inlines for better readability and stronger typing.
Suggested-by: Mark Brown
Signed-off-by: Bartosz Golaszewski
---
include/linux/regmap.h | 222 +++--
1 f
This is a patch for parameters to be used for UFS features layer and HPB
module.
Signed-off-by: Daejun Park
---
drivers/scsi/ufs/ufs.h | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index c70845d41449..f3efa3424fc0 100644
--- a/d
On Sun, Jun 14, 2020 at 09:52:30AM -0600, Jens Axboe wrote:
> On 6/9/20 8:24 AM, Stefano Garzarella wrote:
> > Hi Jens,
> > Stefan and I have a proposal to share with io_uring community.
> > Before implementing it we would like to discuss it to receive feedbacks and
> > to see if it could be accept
Hi Avri,
On Mon, 2020-06-15 at 07:13 +, Avri Altman wrote:
> > /* Write UIC Cmd */
> > ufshcd_writel(hba, uic_cmd->command & COMMAND_OPCODE_MASK,
> > REG_UIC_COMMAND);
> > @@ -4825,11 +4847,15 @@ static irqreturn_t ufshcd_uic_cmd_compl(struct
> > ufs_hba *
Hi Aditya,
Aditya Pakki wrote on Sat, 13 Jun 2020 22:43:00
-0500:
> On calling pm_runtime_get_sync() the reference count of the device
> is incremented. In case of failure, decrement the
> reference count before returning the error.
>
> Signed-off-by: Aditya Pakki
Missing Fixes/Stable tags he
From: Bartosz Golaszewski
There are two spaces between arguments in regmap_fields_update_bits_base()
so remove one.
Signed-off-by: Bartosz Golaszewski
---
Hi Mark,
I noticed this while writing the previous patch, so I guess we can fix it.
Bart
drivers/base/regmap/regmap.c | 2 +-
1 file cha
2020년 6월 15일 (월) 오후 3:41, Muchun Song 님이 작성:
>
> On Mon, Jun 15, 2020 at 2:23 PM Joonsoo Kim wrote:
> >
> > 2020년 6월 14일 (일) 오후 9:39, Muchun Song 님이 작성:
> > >
> > > The function of __kmem_cache_shutdown() is that release all resources
> > > used by the slab cache, while currently it stop release r
Go all over all pending lists and cancel works there, and only then
try to match running requests. No functional changes here, just a
preparation for bulk cancellation.
Signed-off-by: Pavel Begunkov
---
fs/io-wq.c | 54 --
1 file changed, 32 in
Thanks, Borislav.
Hi Jason,
On Mon, Jun 15, 2020 at 12:01:41PM +0800, Jason Yan wrote:
> This is an effort to eliminate the uninitialized_var() macro[1].
>
> The use of this macro is the wrong solution because it forces off ANY
> analysis by the compiler for a given variable. It even masks "unused
> variable" warn
If a process is going away, io_uring_flush() will cancel only 1
request with a matching pid. Cancel all of them
Signed-off-by: Pavel Begunkov
---
fs/io-wq.c| 14 --
fs/io-wq.h| 1 -
fs/io_uring.c | 14 --
3 files changed, 12 insertions(+), 17 deletions(-)
diff -
io_uring_flush() {
...
if (fatal_signal_pending(current) || (current->flags & PF_EXITING))
io_wq_cancel_pid(ctx->io_wq, task_pid_vnr(current));
}
This cancels only the first matched request. The pathset is mainly
about fixing that. [1,2] are preps, [3/4] is the fix.
Subject: Re: [PATCH] drivers\block: Use kobj_to_dev() API>On Fri, Jun 12, 2020
at 03:10:56PM +0800, Wang Qing wrote:
>> Use kobj_to_dev() API instead of container_of().
>>
>> Signed-off-by: Wang Qing
>> ---
>> drivers/block/virtio_blk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
On 12.6.2020 20.13, Nicolas Saenz Julienne wrote:
> Some atypical users of xhci-pci might need to manually reset their xHCI
> controller before starting the HCD setup. Check if a reset controller
> device is available to the PCI bus and trigger a reset.
>
> Signed-off-by: Nicolas Saenz Julienne
Instead of waiting for each request one by one, first try to cancel all
of them in a batched manner, and then go over inflight_list/etc to reap
leftovers.
Signed-off-by: Pavel Begunkov
---
fs/io_uring.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/fs/io_uring.c b/fs/io_urin
This adds support for cancelling all io-wq works matching a predicate.
It isn't used yet, so no change in observable behaviour.
Signed-off-by: Pavel Begunkov
---
fs/io-wq.c| 60 +--
fs/io-wq.h| 2 +-
fs/io_uring.c | 2 +-
3 files changed,
On 6/12/2020 7:06 PM, Hillf Danton wrote:
On Fri, 12 Jun 2020 14:36:49 +0800 Xing Zhengjun wrote:
Hi Vincent,
We test the regression still existed in v5.7, do you have time to
look at it? Thanks.
===
Hi,
I encountered the following issue while booting 5.8-rc1 on Qemu for RV64.
I added additional dump_stack and observed that it's happening in bpf free path.
It happens always if CONFIG_DEBUG_VM is enabled. VM_BUG_ON_MM is
compiled away without that.
---
On 20-05-20, 11:42, Andrew-sh.Cheng wrote:
> - Resend depending patches of Sravana Kannan base on kernel-5.7
Saravana's patches were never accepted and I suggested him this which
he never tested I believe.
https://lore.kernel.org/lkml/20191125112812.26jk5hsdwqfnofc2@vireshk-i7/
There is no
Looks good to me.
Thanks,
Avri
>
>
> Hi,
> This series adds trace event for UIC commands and do a small cleanup in
> struct uic_command.
>
> v2 -> v3:
> - Refactor "complete" event hooks in ufshcd_uic_cmd_compl() (Avri Altman)
>
> v1 -> v2:
> - Rename "uic_send" to "send" and "uic_complete
On Thu, Jun 11, 2020 at 10:24 PM Linus Torvalds
wrote:
>
> On Wed, Jun 10, 2020 at 9:05 PM kernel test robot
> wrote:
> >
> > FYI, we noticed a 2158.6% improvement of stress-ng.vm-splice.ops_per_sec
> > due to commit:
> >
> > commit: 17839856fd588f4ab6b789f482ed3ffd7c403e1f ("gup: document and
For an exiting process it tries to cancel all its inflight requests.
Use req->task to match such instead of work.pid. We always have
req->task set, and it will be valid because we're matching only
current exiting task.
Also, remove work.pid and everything related, it's useless now
Reported-by: Er
There will be multiple places where req->task is used, so refcount-pin
it lazily with introduced *io_{get,put}_req_task(). We need to always
have valid ->task for cancellation reasons, but don't care about pinning
it in some cases. That's why it sets req->task in io_req_init() and
implements get/pu
Cancel requests of an extiting task based on ->task address. As
reported by Eric W. Biederman, using pid for this purpose is not
right.
note: rebased on top of "cancel all" patches
Pavel Begunkov (2):
io_uring: lazy get task
io_uring: cancel by ->task not pid
fs/io-wq.h| 1 -
fs/io_uri
Below is the list of build error/warning regressions/improvements in
v5.8-rc1[1] compared to v5.7[2].
Summarized:
- build errors: +4/-4
- build warnings: +66/-42
Note that there may be false regressions, as some logs are incomplete.
Still, they're build errors/warnings.
Happy fixing! ;-)
Th
On 12/06/2020 15:30, Lorenzo Pieralisi wrote:
On Mon, Feb 17, 2020 at 12:08:48PM +, John Garry wrote:
Right, and even worse is that it relies on the port driver even
existing at all.
All this iommu group assignment should be taken outside device
driver probe paths.
However we could still
Hi!
Booting 5.8-rc1 on x220, I get scary warnings:
[7.089941] EXT4-fs (sdb2): mounted filesystem with ordered data mode. Opts:
errors=remount-ro
[7.343231] BUG: using smp_processor_id() in preemptible [] code:
systemd-tmpfile/2788
[7.344052] caller is debug_smp_processor_id+
> From: Wolfram Sang
> Sent: Friday, June 12, 2020 9:00 PM
>
> On Fri, Jun 12, 2020 at 02:18:06PM +0200, Marc Kleine-Budde wrote:
> > On 6/12/20 1:51 PM, Wolfram Sang wrote:
> > >
> > >> This basically kills the concept of devm for interrupts. Some other
> > >
> > > It only works when you can ens
Hi Mauro,
On Mon, Jun 15, 2020 at 8:47 AM Mauro Carvalho Chehab
wrote:
> This file was renamed, but its reference at pfc-pinctl.txt is
pfc-pinctrl.txt
> still pointing to the old file.
>
> Fixes: 7f7d408e5a00 ("dt-bindings: gpio: rcar: Convert to json-schema")
> Signed-off-by: Mauro Carvalho Ch
On Fri 12-06-20 14:15:51, Eric W. Biederman wrote:
>
> Recently syzbot reported that unmounting proc when there is an ongoing
> inotify watch on the root directory of proc could result in a use
> after free when the watch is removed after the unmount of proc
> when the watcher exits.
>
> Commit 6
On Mon 2020-06-15 00:00:56, Joe Perches wrote:
> On Mon, 2020-06-15 at 08:46 +0200, SeongJae Park wrote:
> > So, I agree this patch is imperfect for many cases, but better than nothing.
>
> Not necessarily.
>
> Having people strain for unusual equivalents
> to generally well known terms is not go
On Fri, Jun 12, 2020 at 4:37 PM Peter Zijlstra wrote:
>
> Since many compilers cannot disable KCOV with a function attribute,
> help it to NOP out any __sanitizer_cov_*() calls injected in noinstr
> code.
>
> This turns:
>
> 12: e8 00 00 00 00 callq 17
> 13: R_X86_64_P
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: b3a9e3b9622ae10064826dccb4f7a52bd88c7407
commit: 80591e61a0f7e88deaada69844e4a31280c4a38f kbuild: tell sparse about the
$ARCH
date: 7 months ago
config: nios2-randconfig-s032-20200615 (attached as .config
> I started a seperate thread:
>
> https://lkml.org/lkml/2020/6/14/76
>
> Still, on-going discussion if the proper fix is to remove the error check.
I find that a bit of additional information can make such a link safer.
RFC: a failing pm_runtime_get increases the refcnt?
https://lore.kernel.org/
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 2c18bd525c47f882f033b0a813ecd09c93e1ecdf
Gitweb:
https://git.kernel.org/tip/2c18bd525c47f882f033b0a813ecd09c93e1ecdf
Author:Babu Moger
AuthorDate:Thu, 04 Jun 2020 14:45:16 -05:00
Committer:
It is already fixed by https://lkml.org/lkml/2020/5/31/260
On Monday, June 15, 2020 8:47:01 AM CEST Mauro Carvalho Chehab wrote:
> there are missing references causing Sphinx warnings:
>
> Documentation/translations/it_IT/process/submitting-patches.rst:384:
> WARNING: undefined label: it_emai
在 2020/6/15 15:25, Gao Xiang 写道:
Hi Jason,
On Mon, Jun 15, 2020 at 12:01:41PM +0800, Jason Yan wrote:
This is an effort to eliminate the uninitialized_var() macro[1].
The use of this macro is the wrong solution because it forces off ANY
analysis by the compiler for a given variable. It even
From: Bartosz Golaszewski
This driver may take a regular spinlock when a raw spinlock
(irq_desc->lock) is already taken which results in the following
lockdep splat:
=
[ BUG: Invalid wait context ]
5.7.0-rc7 #1 Not tainted
-
swapper/0/0 is
On Mon, Jun 15, 2020 at 9:39 AM Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v5.8-rc1[1] compared to v5.7[2].
>
> Summarized:
> - build errors: +4/-4
> - build warnings: +66/-42
>
> Note that there may be false regressions, as some logs are
Hi Johan,
Johan Jonker wrote on Sat, 13 Jun 2020 15:31:52
+0200:
> Hi Yifeng, Miquel,
>
> Some more comments about swap();
>
> On 6/9/20 9:40 AM, Yifeng Zhao wrote:
>
> [..]
>
> > +static int rk_nfc_ooblayout_free(struct mtd_info *mtd, int section,
> > +struct mtd
Hi Grygorii,
On 13/06/2020 19.43, Grygorii Strashko wrote:
> Hi Tero,
>
> Hence k3 platforms chipid module driver was merged, there is follow up series
> to add corresponding DT chipid nodes.
>
> [1] https://lkml.org/lkml/2020/5/29/979
>
> Grygorii Strashko (2):
> arm64: dts: ti: k3-am65-wak
It is possible to cause a division error and use-after-free by querying the
nmem device before the driver data is fully initialised in nvdimm_probe. E.g
by doing
(while true; do
cat /sys/bus/nd/devices/nmem*/available_slots 2>&1 > /dev/null
done) &
while true; do
for i in $(seq 0 4); d
We load nfsd module in the docker container, kernel crash as following.
The 'current->nsproxy->net_ns->gen->ptr[nfsd_net_id]' is overflow in the
nfsd_init_net.
We should use the net_ns which is being init in the nfsd_init_net,
not the 'current->nsproxy->net_ns'.
[ 939.174448] Installing knfsd (
On Mon, 2020-06-15 at 08:46 +0200, Mauro Carvalho Chehab wrote:
> Some files got renamed. Those were all fixed automatically by
>
> ./scripts/documentation-file-ref-check --fix
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt |
It's too long to be inlined.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 88 ++-
1 file changed, 40 insertions(+), 48 deletions(-)
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index e8bcfcdbedbb..cdb7f0370ca9 100644
--- a/d
Introduce names (en enum) for 0, 1, and 2 constants. We now have
VCI_HALF_BRIGHT, VCI_NORMAL, and VCI_BOLD instead.
Apart from the cleanup,
1) the enum allows for better type checking, and
2) this saves some code. No more fiddling with bits is needed in
assembly now. (OTOH, the structure is lar
This also eliminates the ifdeffery by using if and __is_defined.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 44 +++
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index f671e
Pass the length of a string to respond_string and use
tty_insert_flip_string instead of a loop with tty_insert_flip_char. This
simplifies the processing on the tty side.
The added strlens are optimized during constant folding and propagation
and the result are proper constants in assembly.
Signed
We defined macros for all the magic constants in the previous patch. So
let us use the macro in the code now.
No functional change intended.
Signed-off-by: Jiri Slaby
Cc: Thomas Winischhofer
Cc: Bartlomiej Zolnierkiewicz
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: linux-...@vger.kernel.o
do_con_write is complicated enough. Extract unicode handling to a
separate function. For do_con_write, 249 LOCs lowered to 183 lines.
Use diff -w -b to see the difference is neligible -- mostly whitespace
and use of 'return's instead of 'continue's.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/
We create a new vt_k_ioctl here and move there all the K* ioctls. This
makes vt_ioctl significantly smaller.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 294 --
1 file changed, 157 insertions(+), 137 deletions(-)
diff --git a/drivers/tty/vt/vt_
This is still a leftover from BKL, when we locked it around vt_ioctl's
code. We can return instead of breaks in the switch loop. And we can
return in case of errors too. This allows for sifting of the code to the
left in some cases.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 318 +
Synchronize with others and check perm directly in vt_k_ioctl.
We do not need to pass perm to do_fontx_ioctl and do_unimap_ioctl then.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/tty/vt
The code for setting G0 and G1 is duplicated -- for each of them. Move
the code to a separate function (vc_setGx) and distinguish the two cases
by a parameter.
Change if-else-if to switch which allows for slightly better
optimization (decision tree).
Signed-off-by: Jiri Slaby
---
drivers/tty/vt
It's too long to be inlined.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 74 +--
1 file changed, 39 insertions(+), 35 deletions(-)
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index 978c33ad6619..e8bcfcdbedbb 100644
--- a/d
We create a new vt_io_ioctl here and move there all the IO ioctls. This
makes vt_ioctl significantly smaller.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 177 +-
1 file changed, 98 insertions(+), 79 deletions(-)
diff --git a/drivers/tty/vt/vt_i
It's too long to be inlined.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 100 +-
1 file changed, 55 insertions(+), 45 deletions(-)
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index cdb7f0370ca9..f671e94a94a9 100644
--- a/d
There are two copies of some members of struct vc_data. This is because
we need to save them and restore later. Move these memebers to a
separate structure called vc_state. So now instead of members like:
vc_x, vc_y and vc_saved_x, vc_saved_y
we have
state and saved_state (of type: struct vc_st
It's too long to be inlined.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt_ioctl.c | 78 +--
1 file changed, 43 insertions(+), 35 deletions(-)
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index ecf96f5e616d..224f2a564e13 100644
--- a/d
They were used for the first parameter of put_user. But put_user accepts
constants in the parameter and also determines the type only by the
second parameter. So we can safely drop these helpers and simplify the
code a bit.
Including the removal of set_int label.
Signed-off-by: Jiri Slaby
---
d
um's put_char only calls write. And the tty layer/disciplines do the
same if put_char is NULL.
So we can safely remove this put_char wrapper.
Signed-off-by: Jiri Slaby
Cc: Jeff Dike
Cc: Richard Weinberger
Cc: Anton Ivanov
---
arch/um/drivers/line.c | 5 -
arch/um/drivers/line.h
Format add_softcursor according to CodingStyle. Until now, it was a mess
of letters.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index b1fdbf119755..f7d5a3c3845
There were too many parentheses in invert_screen, remove them and align
the code in invert_screen a bit.
No functional change intended.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/
Invert the attribute on the only place, without the need of checking
'inverse'.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index d3cd256ba0fa..72ae8ede1ac9 100644
---
All the attributes are bools, so do a simple shift instead of tests and
constants as bool is either 0 or 1.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 3aff2e3cf5a6..
Convert (!(A && !B) || C) into (!A || B || C) to improve readability.
No functional changes, as was just proven by objdump.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 893f7
All the types are unsinged ints -- even the vpar passed to the function.
So unify them and use min() to compute count instead of explicit
comparison.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/vt/vt.c
For passing of draw area among functions. This makes next patches
simpler.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 44 +---
1 file changed, 25 insertions(+), 19 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 0f61dc36
vc_con_write_normal now handles the complex normal characters
processing. It is no longer a part of do_con_write. So this patch makes
do_con_write pretty clean and obvious.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 198
1 file changed, 109 i
The code was too overcomplicated. Extract vc_sanitize_unicode to a
separate function and flatten the code. I believe the code is
straightforward now.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 121 +++-
1 file changed, 64 insertions(+), 57 deletio
Nested ternary operators spread over 4 lines are really evil for
reading. Turn the outer one to proper 'if'. Now, we see, there is a
common path, so the code can be simplified. This way, the code is
understandable now.
Checked using symbolic execution (klee), that the old and new behaviors
are the
On Mon, Jun 15, 2020 at 3:25 PM Joonsoo Kim wrote:
>
> 2020년 6월 15일 (월) 오후 3:41, Muchun Song 님이 작성:
> >
> > On Mon, Jun 15, 2020 at 2:23 PM Joonsoo Kim wrote:
> > >
> > > 2020년 6월 14일 (일) 오후 9:39, Muchun Song 님이 작성:
> > > >
> > > > The function of __kmem_cache_shutdown() is that release all resou
VT100ID is unused, but defined twice. Kill it.
VT102ID is used only in respond_ID. Define there a variable with proper
type and use that instead. Then drop both defines of VT102ID too.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 11 ---
include/linux/console.h | 6 --
2
The code currently uses bitfields to store true-false values. Switch all
of that to bools. Apart from the cleanup, it saves 20B of code as many
shifts, ANDs, and ORs became simple movzb's.
Signed-off-by: Jiri Slaby
---
drivers/tty/vt/vt.c | 32 -
drive
vc_cons was made global (non-static) in 1.3.38, almost 25 years ago.
Remove a comment which says that it would be a disadvantage to do so :P.
Signed-off-by: Jiri Slaby
---
include/linux/console_struct.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/console_s
This removes duplicated initialization of variables (after reordering
'c' initialization).
It will also allow for eliminating whole translation into a separate
function in the next patch.
Note that vc_state, vc_utf etc. are checked with every rescan now. But
they are immutable for non-control cha
Move the control characters detection to a separate function dubbed
vc_is_control. It makes the 14 subexpressions a "bit" more readable. And
also simplifies next patches.
It moves also CTRL_ACTION and CTRL_ALWAYS to this new function, as they
are used exclusively here. While at it, these are conve
1 - 100 of 1505 matches
Mail list logo
