[PATCH] drm/vc4: fix ref count leak in vc4_vec_encoder_enable

2020-06-14 Thread Navid Emamdoost
in vc4_vec_encoder_enable, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/vc4/vc4_vec.c | 8 +--- 1 file changed,

Re: [PATCH] Fix null pointer dereference in vector_user_bpf

2020-06-14 Thread Anton Ivanov
On 14/06/2020 02:19, Gaurav Singh wrote: The bpf_prog is being checked for !NULL after uml_kmalloc but later its used directly for example: bpf_prog->filter = bpf and is also later returned upon success. Fix this, do a NULL check and return right away. Signed-off-by: Gaurav Singh --- arch/um/

[PATCH] kernel/trace: Remove function callback casts

2020-06-14 Thread Oscar Carter
In an effort to enable -Wcast-function-type in the top-level Makefile to support Control Flow Integrity builds, remove all the function callback casts. To do this, use the ftrace_ops_list_func function as a wrapper when the arch not supports ftrace ops instead of the use of a function cast. Signe

[PATCH] drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails

2020-06-14 Thread Navid Emamdoost
The call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16 1 file changed, 1

[PATCH] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-06-14 Thread Navid Emamdoost
in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 +++-

[PATCH] smp: Fix a potential usage of stale nr_cpus

2020-06-14 Thread Muchun Song
The get_option() maybe return 0, it means that the nr_cpus is not initialized. Then we will use the stale nr_cpus to initialize the nr_cpu_ids. So fix it. Signed-off-by: Muchun Song --- kernel/smp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/smp.c b/kernel/smp.c

Re: [PATCH] media: bdisp: fix reference count leaks due to pm_runtime_get_sync

2020-06-14 Thread kernel test robot
Hi Aditya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v5.7 next-20200614] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use

[PATCH] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms

2020-06-14 Thread Navid Emamdoost
in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- 1 file chang

Re: [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show()

2020-06-14 Thread Greg KH
On Fri, Jun 12, 2020 at 06:45:57PM +0200, Markus Elfring wrote: > > 'files' will be immediately reassigned. 'f_flags' and 'file' will be > > overwritten in the if{} or seq_show() directly exits with an error. > > so we don't need to consume CPU resources to initialize them. > > I suggest to improv

Re: [PATCH] Fix code style in css_task_iter_next_css_set()

2020-06-14 Thread Greg KH
On Fri, Jun 12, 2020 at 09:56:26PM +0200, Markus Elfring wrote: > > One line similar code before in this function > > I suggest to improve the commit message. > How do you think about a wording variant like the following? > >Combine two assignments for the variable “l” into one statement. >

Re: [PATCH] ethernet: Fix memory leak in ethoc_probe()

2020-06-14 Thread Greg KH
On Sat, Jun 13, 2020 at 08:26:12AM +0200, Markus Elfring wrote: > > … The patch fixes this issue. > > I propose to replace this information by the tag “Fixes”. > Please choose another imperative wording for your change description. > > Regards, > Markus Hi, This is the semi-friendly patch-bot o

Re: [PATCH] NFC: Fix error handling in rawsock_connect()

2020-06-14 Thread Greg KH
On Sat, Jun 13, 2020 at 07:56:36AM +0200, Markus Elfring wrote: > > … The patch fixes this issue. > > I suggest to replace this information by the tag “Fixes”. > Please choose another imperative wording for your change description. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g

Re: [PATCH] rocker: Fix error handling in dma_rings_init()

2020-06-14 Thread Greg KH
On Sat, Jun 13, 2020 at 08:14:13AM +0200, Markus Elfring wrote: > > … The patch fixes the > > order consistent with cleanup in rocker_dma_rings_fini(). > > I suggest to choose another imperative wording for your change description. > Will the tag “Fixes” become helpful for the commit message? > >

[PATCH] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl

2020-06-14 Thread Navid Emamdoost
in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2

Re: [PATCH] RDMA/rvt: Improve exception handling in rvt_create_qp()

2020-06-14 Thread Greg KH
On Sat, Jun 13, 2020 at 09:15:12AM +0200, Markus Elfring wrote: > > … The patch fixes this issue by > > calling rvt_free_rq(). > > I suggest to choose another imperative wording for your change description. > Will the tag “Fixes” become helpful for the commit message? > > … > > +++ b/drivers/infi

Re: [PATCH] test_objagg: Fix memory leak in test_hints_case()

2020-06-14 Thread Greg KH
On Sat, Jun 13, 2020 at 08:36:36AM +0200, Markus Elfring wrote: > > … The patch fixes this issue. > > I propose to replace this information by the tag “Fixes”. > Please choose another imperative wording for your change description. > > Regards, > Markus Hi, This is the semi-friendly patch-bot o

Re: [PATCH] powerpc/powernv/pci: add ifdef to avoid dead code

2020-06-14 Thread Christophe Leroy
Hi, Le 14/06/2020 à 07:54, Greg Thelen a écrit : Commit dc3d8f85bb57 ("powerpc/powernv/pci: Re-work bus PE configuration") removed a couple pnv_ioda_setup_bus_dma() calls. The only remaining calls are behind CONFIG_IOMMU_API. Thus builds without CONFIG_IOMMU_API see: arch/powerpc/platforms/

[PATCH v16 0/1] mt8183 dpi support pin mode swap

2020-06-14 Thread Jitao Shi
Changes since v15: - Fix YAML License to (GPL-2.0-only OR BSD-2-Clause). - "dt-bindings: display: mediatek: control dpi pins mode to avoid leakage" "drm/mediatek: set dpi pin mode to gpio low to avoid leakage current" applied v15. The links are https://patchwork.kernel.org/patch/11489545/

[PATCH v16 1/1] dt-bindings: display: mediatek: convert the dpi bindings to yaml

2020-06-14 Thread Jitao Shi
Convert display/mediatek/mediatek,dpi.txt to display/mediatek/mediatek,dpi.yaml and remove the old text bindings. Signed-off-by: Jitao Shi --- .../display/mediatek/mediatek,dpi.txt | 42 .../display/mediatek/mediatek,dpi.yaml| 97 +++ 2 files changed, 97

Re: [Cocci] coccinelle issues

2020-06-14 Thread Julia Lawall
On Sat, 13 Jun 2020, Randy Dunlap wrote: > Hi, > > OK, I've not used Coccinelle and now I am trying to use it. > It seems that I am having a few issues. > The primary one is when I run spatch (via 'make coccicheck' in > the kernel source tree), it tells me: > > Python error: No module named coc

Re: [PATCH 1/3] thermal/cpu-cooling, sched/core: Cleanup thermal pressure definition

2020-06-14 Thread kernel test robot
s/Valentin-Schneider/sched-arch_topology-Thermal-pressure-configuration-cleanup/20200614-091051 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 8dc697d75c13ee2901d1a40f1d7d58163048c204 config: arm64-randconfig-r013-20200614 (attached as .config) compiler: clang version 11.

Re: general protection fault in syscall_return_slowpath

2020-06-14 Thread Dmitry Vyukov
On Tue, Mar 10, 2020 at 9:10 AM Dmitry Vyukov wrote: > > On Tue, Mar 10, 2020 at 7:15 AM Nathan Chancellor > wrote: > > > > On Mon, Mar 09, 2020 at 09:20:58AM +0100, Dmitry Vyukov wrote: > > > On Sun, Mar 8, 2020 at 7:35 PM 'Jann Horn' via syzkaller-bugs > > > wrote: > > > > > > > > On Sun, Mar

Re: [PATCH] net: fec: fix ref count leaking when pm_runtime_get_sync fails

2020-06-14 Thread Markus Elfring
> in fec_enet_mdio_read, … I am curious under which circumstances you would like to improve such commit messages. * Will the tag “Fixes” become helpful? * Which source code analysis tools did trigger to send update suggestions according to 16 similar issues for today? … > +++ b/drivers/net/e

Re: [PATCH] usb: dwc3: pci: Fix reference count leak in dwc3_pci_resume_work

2020-06-14 Thread Sergei Shtylyov
Hello! On 14.06.2020 6:15, Aditya Pakki wrote: dwc3_pci_resume_work() calls pm_runtime_get_sync() that increments the reference counter. In case of failure, decrement the reference count and return the error. In this case you still return nothing. Signed-off-by: Aditya Pakki --- driv

Re: [PATCH] usb: musb: fix reference count leak in musb_irq_work

2020-06-14 Thread Sergei Shtylyov
On 14.06.2020 6:27, Aditya Pakki wrote: musb_irq_work() calls pm_runtime_get_sync() that increments the reference counter. In case of failure, decrement the reference count and return the error. Again, *void* function, so no error returned. Signed-off-by: Aditya Pakki --- drivers/usb/m

Re: [PATCH] mtd: rawnand: brcmnand: force raw OOB writes

2020-06-14 Thread Álvaro Fernández Rojas
Hi Kamal, > El 13 jun 2020, a las 17:16, Kamal Dasu escribió: > > Alvaro, > > > On Sat, Jun 13, 2020 at 5:01 AM Álvaro Fernández Rojas > wrote: >> >> Hi Kamal, >> >>> El 12 jun 2020, a las 20:47, Kamal Dasu escribió: >>> >>> On Fri, Jun 5, 2020 at 1:07 PM Álvaro Fernández Rojas >>> wrot

Re: [PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync

2020-06-14 Thread Markus Elfring
> in macb_mdio_write, … * Will a desire evolve to improve also this commit message? * Will the tag “Fixes” become helpful? … > +++ b/drivers/net/ethernet/cadence/macb_main.c … > @@ -3840,11 +3842,14 @@ static int at91ether_open(struct net_device *dev) > > ret = macb_phylink_connect(lp);

Re: [PATCH 1/3] thermal/cpu-cooling, sched/core: Cleanup thermal pressure definition

2020-06-14 Thread kernel test robot
s/Valentin-Schneider/sched-arch_topology-Thermal-pressure-configuration-cleanup/20200614-091051 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 8dc697d75c13ee2901d1a40f1d7d58163048c204 config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 repro

[PATCH v5 0/9] bmips: add bcm6345 reset controller support

2020-06-14 Thread Álvaro Fernández Rojas
BCM63xx SoCs have a reset controller for certain components. v5: fix kbuild robot error (drop __init). v4: fix device tree bindings documentation. v3: using reset-simple isn't possible since sleeping after performing the reset is also needed. Add BCM63268 and BCM6318 support. v2: add compa

[PATCH v5 3/9] reset: add BCM6345 reset controller driver

2020-06-14 Thread Álvaro Fernández Rojas
Add support for resetting blocks through the Linux reset controller subsystem for BCM63xx SoCs. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli --- v5: fix kbuild robot error (drop __init). v4: no changes. v3: using reset-simple isn't possible since sleeping after performi

[PATCH v5 2/9] dt-bindings: reset: add BCM6345 reset controller bindings

2020-06-14 Thread Álvaro Fernández Rojas
Add device tree binding documentation for BCM6345 reset controller. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Florian Fainelli --- v5: no changes v4: change license and fix maxItems. v3: no changes v2: no changes .../bindings/reset/brcm,bcm6345-reset.yaml| 37 +

[PATCH v5 6/9] mips: bmips: dts: add BCM6362 reset controller support

2020-06-14 Thread Álvaro Fernández Rojas
BCM6362 SoCs have a reset controller for certain components. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli --- v5: no changes. v4: no changes. v3: add reset controller definitions header file. v2: no changes. arch/mips/boot/dts/brcm/bcm6362.dtsi | 6 ++ include

[PATCH v5 8/9] mips: bmips: dts: add BCM63268 reset controller support

2020-06-14 Thread Álvaro Fernández Rojas
BCM63268 SoCs have a reset controller for certain components. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli --- v5: no changes. v4: no changes. v3: add new path with BCM63268 reset controller support. arch/mips/boot/dts/brcm/bcm63268.dtsi | 6 + include/dt-bindi

[PATCH v5 7/9] mips: bmips: dts: add BCM6368 reset controller support

2020-06-14 Thread Álvaro Fernández Rojas
BCM6368 SoCs have a reset controller for certain components. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli --- v5: no changes. v4: no changes. v3: add reset controller definitions header file. v2: no changes. arch/mips/boot/dts/brcm/bcm6368.dtsi | 6 ++ include

[PATCH v5 5/9] mips: bmips: dts: add BCM6358 reset controller support

2020-06-14 Thread Álvaro Fernández Rojas
BCM6358 SoCs have a reset controller for certain components. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli --- v5: no changes. v4: no changes. v3: add reset controller definitions header file. v2: no changes. arch/mips/boot/dts/brcm/bcm6358.dtsi | 6 ++ include

[PATCH v5 1/9] mips: bmips: select ARCH_HAS_RESET_CONTROLLER

2020-06-14 Thread Álvaro Fernández Rojas
This allows to add reset controllers support. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli --- v5: no changes v4: no changes v3: no changes v2: no changes arch/mips/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 6

[PATCH v5 9/9] mips: bmips: add BCM6318 reset controller definitions

2020-06-14 Thread Álvaro Fernández Rojas
BCM6318 SoCs have a reset controller for certain components. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli --- v5: no changes. v4: no changes. v3: add new path with BCM6318 reset controller definitions. include/dt-bindings/reset/bcm6318-reset.h | 20

[PATCH v5 4/9] mips: bmips: dts: add BCM6328 reset controller support

2020-06-14 Thread Álvaro Fernández Rojas
BCM6328 SoCs have a reset controller for certain components. Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli --- v5: no changes. v4: no changes. v3: add reset controller definitions header file. v2: no changes. arch/mips/boot/dts/brcm/bcm6328.dtsi | 6 ++ include

Re: [patch V9 10/39] x86/entry: Provide helpers for execute on irqstack

2020-06-14 Thread Thomas Gleixner
Qian Cai writes: > On Sat, Jun 13, 2020 at 04:03:02PM +0200, Thomas Gleixner wrote: >> Qian, >> >> Qian Cai writes: >> > On Wed, Jun 10, 2020 at 09:38:56PM +0200, Thomas Gleixner wrote: >> > >> > Thomas, I get ahold of one of the affected systems now if you want some >> > testing there. >> >>

Re: [Cocci] [PATCH] coccinelle: api: add kvfree script

2020-06-14 Thread Denis Efremov
On 6/5/20 11:51 PM, Julia Lawall wrote: > Also, there is no need to exceed 80 characters here. You can put a > newline in the middle of a \( ... \) It's required. Looks like it's impossible to break "when" lines. ... when != if (...) { ... E = \(vmalloc\|vzalloc\|vmalloc_user\|vmalloc_node\|

RFC: a failing pm_runtime_get increases the refcnt?

2020-06-14 Thread Wolfram Sang
Hi Linux-PM, both in the I2C subsystem and also for Renesas drivers I maintain, I am starting to get boilerplate patches doing some pm_runtime_put_* variant because a failing pm_runtime_get is supposed to increase the ref counters? Really? This feels wrong and unintuitive to me. I expect there has

Re: [PATCH] i2c: xiic: Fix reference count leaks.

2020-06-14 Thread Wolfram Sang
On Sat, Jun 13, 2020 at 04:59:23PM -0500, wu000...@umn.edu wrote: > From: Qiushi Wu > > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus call pm_runtime_put_noidle() > if pm_runtime_get_sync() fails. Can you point me to a discussion where i

Re: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error

2020-06-14 Thread Wolfram Sang
On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a corresponding decrement is > needed on the error handling path to keep the counter balanced. Can you point me to a discussion w

Re: [Cocci] [PATCH] coccinelle: api: add kvfree script

2020-06-14 Thread Julia Lawall
On Sun, 14 Jun 2020, Denis Efremov wrote: > > > On 6/5/20 11:51 PM, Julia Lawall wrote: > > Also, there is no need to exceed 80 characters here. You can put a > > newline in the middle of a \( ... \) > > It's required. Looks like it's impossible to break "when" lines. That's true. Sorry for t

Re: [PATCH] Input: bma150: fix ref count leak in bma150_open

2020-06-14 Thread Markus Elfring
> in bma150_open, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Will the tag “Fixes” become helpful? … > +++ b/drivers/input/misc/bma150.c … > @@ -357,10 +357,13 @@ static int bma150_open(struct input_dev *input) >

Re: [PATCH 1/3] thermal/cpu-cooling, sched/core: Cleanup thermal pressure definition

2020-06-14 Thread kernel test robot
s/Valentin-Schneider/sched-arch_topology-Thermal-pressure-configuration-cleanup/20200614-091051 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 8dc697d75c13ee2901d1a40f1d7d58163048c204 config: sparc-allyesconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 repro

Re: [Cocci] [PATCH] coccinelle: api: add kvfree script

2020-06-14 Thread Denis Efremov
On 6/14/20 12:17 PM, Julia Lawall wrote: > > > On Sun, 14 Jun 2020, Denis Efremov wrote: > >> >> >> On 6/5/20 11:51 PM, Julia Lawall wrote: >>> Also, there is no need to exceed 80 characters here. You can put a >>> newline in the middle of a \( ... \) >> >> It's required. Looks like it's imp

Re: [PATCH] Input: bma150: fix ref count leak in bma150_open

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 8:58 AM Navid Emamdoost wrote: > > in bma150_open, pm_runtime_get_sync is called which > increments the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. ... > error = pm_runtime_get_sy

RE: [PATCH v1 2/2] scsi: ufs: Add trace event for UIC commands

2020-06-14 Thread Avri Altman
Acked-by: Avri Altman > > > Hi Avri, > > On Sat, 2020-06-13 at 10:48 +, Avri Altman wrote: > > > +static void ufshcd_add_uic_command_trace(struct ufs_hba *hba, > > > +struct uic_command *ucmd, > > > +const cha

Re: [PATCH] Input: stmfts: fix ref count leak in stmfts_input_open

2020-06-14 Thread Markus Elfring
> in stmfts_input_open, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/input/touchscreen/stmfts.c … > @@ -367,6 +367,9 @@ static int stmfts_input_open(struct input_

Re: RFC: a failing pm_runtime_get increases the refcnt?

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 12:10 PM Wolfram Sang wrote: > both in the I2C subsystem and also for Renesas drivers I maintain, I am > starting to get boilerplate patches doing some pm_runtime_put_* variant > because a failing pm_runtime_get is supposed to increase the ref > counters? Really? This feels

Re: [PATCH] hwmon: (ina3221) Fix reference count leak in ina3221_write_enable

2020-06-14 Thread Guenter Roeck
On 6/13/20 8:38 PM, Aditya Pakki wrote: > ina3221_write_enable() calls pm_runtime_get_sync() that increments > the reference counter. In case of failure, decrement the reference > count and return the error. > > Signed-off-by: Aditya Pakki > --- > drivers/hwmon/ina3221.c | 1 + > 1 file changed,

Re: RFC: a failing pm_runtime_get increases the refcnt?

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 12:34 PM Andy Shevchenko wrote: > > On Sun, Jun 14, 2020 at 12:10 PM Wolfram Sang wrote: > > both in the I2C subsystem and also for Renesas drivers I maintain, I am > > starting to get boilerplate patches doing some pm_runtime_put_* variant > > because a failing pm_runtime

Re: [PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost wrote: ... > + if (ret < 0) { > + pm_runtime_put(gpu->dev); Please, in all your patches fix this to be _put_noidle(). We wouldn't bear the flag day of fixing these parts again. Yes, I know that *now* behaviour

Re: [PATCH] ALSA: usb-audio: add quirk for Denon DCD-1500RE

2020-06-14 Thread Takashi Iwai
On Sat, 13 Jun 2020 13:40:06 +0200, Yick W. Tse wrote: > > fix error "clock source 41 is not valid, cannot use" > > > [] New USB device found, idVendor=154e, idProduct=1002, bcdDevice= 1.00 > [] New USB device strings: Mfr=1, Product=2, SerialNumber=0 > [] Product: DCD-1500RE > [] Manufacturer:

Re: [PATCH] i2c: busses: Fix reference count leaks.

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 1:17 AM wrote: > > From: Qiushi Wu > > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus call pm_runtime_put_noidle() > if pm_runtime_get_sync() fails. > FWIW, Reviewed-by: Andy Shevchenko > Signed-off-by: Qiushi Wu

RE: [PATCH 1/1] Documentation:sysfs-ufs: Add WriteBooster documentation

2020-06-14 Thread Avri Altman
> > Adds sysfs documentation for WriteBooster entries. > > Signed-off-by: Asutosh Das Acked-by: Avri Altman Maybe insert each field following the fields of the same descriptor, attributes, flags etc. Thanks, Avri > --- > Documentation/ABI/testing/sysfs-driver-ufs | 136 > +

Re: next-0519 on thinkpad x60: sound related? window manager crash

2020-06-14 Thread Takashi Iwai
On Sat, 13 Jun 2020 18:25:22 +0200, Alex Xu (Hello71) wrote: > > Excerpts from Takashi Iwai's message of June 11, 2020 1:11 pm: > > Thanks, so something still missing in the mmap handling, I guess. > > > > I've worked on two different branches for potential fixes of your > > problems. Could you

Re: RFC: a failing pm_runtime_get increases the refcnt?

2020-06-14 Thread Geert Uytterhoeven
Hi Andy, On Sun, Jun 14, 2020 at 11:43 AM Andy Shevchenko wrote: > On Sun, Jun 14, 2020 at 12:34 PM Andy Shevchenko > wrote: > > > > On Sun, Jun 14, 2020 at 12:10 PM Wolfram Sang wrote: > > > both in the I2C subsystem and also for Renesas drivers I maintain, I am > > > starting to get boilerpla

Re: RFC: a failing pm_runtime_get increases the refcnt?

2020-06-14 Thread Geert Uytterhoeven
On Sun, Jun 14, 2020 at 12:00 PM Geert Uytterhoeven wrote: > On Sun, Jun 14, 2020 at 11:43 AM Andy Shevchenko > wrote: > > On Sun, Jun 14, 2020 at 12:34 PM Andy Shevchenko > > wrote: > > > > > > On Sun, Jun 14, 2020 at 12:10 PM Wolfram Sang wrote: > > > > both in the I2C subsystem and also for

Re: [PATCH] mm/slab: Add a __GFP_ACCOUNT GFP flag check for slab allocation

2020-06-14 Thread kernel test robot
Hi Muchun, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mmotm/master] url: https://github.com/0day-ci/linux/commits/Muchun-Song/mm-slab-Add-a-__GFP_ACCOUNT-GFP-flag-check-for-slab-allocation/20200614-144049 base: git://git.cmpxchg.org/linux-mmotm.git

Re: [RFC] MFD's relationship with Device Tree (OF)

2020-06-14 Thread Michael Walle
Hi Rob, Am 2020-06-10 00:03, schrieb Rob Herring: [..] Yes, we should use 'reg' whenever possible. If we don't have 'reg', then you shouldn't have a unit-address either and you can simply match on the node name (standard DT driver matching is with compatible, device_type, and node name (w/o unit

[PATCH v2 2/2] i2c: imx: Fix external abort on interrupt in exit paths

2020-06-14 Thread Krzysztof Kozlowski
If interrupt comes late, during probe error path or device remove (could be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler i2c_imx_isr() will access registers with the clock being disabled. This leads to external abort on non-linefetch on Toradex Colibri VF50 module (with Vybrid VF5xx):

[PATCH v2 1/2] i2c: imx: Fix PM runtime inbalance in probe error path

2020-06-14 Thread Krzysztof Kozlowski
When pm_runtime_get_sync() fails in probe(), the error path should not call pm_runtime_put_noidle(). This would lead to inbalance in usage_count. Fixes: 588eb93ea49f ("i2c: imx: add runtime pm support to improve the performance") Cc: Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1

Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver

2020-06-14 Thread Chris Boot
On 14/06/2020 01:03, Finn Thain wrote: > On Sat, 13 Jun 2020, Chris Boot wrote: > >> I no longer have the time to maintain this subsystem nor the hardware to >> test patches with. > > Then why not patch MAINTAINERS, and orphan it, as per usual practice? > > $ git log --oneline MAINTAINERS | gre

Re: RFC: a failing pm_runtime_get increases the refcnt?

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 1:05 PM Geert Uytterhoeven wrote: > On Sun, Jun 14, 2020 at 12:00 PM Geert Uytterhoeven > wrote: > > On Sun, Jun 14, 2020 at 11:43 AM Andy Shevchenko > > wrote: > > > On Sun, Jun 14, 2020 at 12:34 PM Andy Shevchenko > > > wrote: > > > > > > > > On Sun, Jun 14, 2020 at 12

[PATCH 1/2] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths

2020-06-14 Thread Krzysztof Kozlowski
If interrupt comes late, during probe error path or device remove (could be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler dspi_interrupt() will access registers with the clock being disabled. This leads to external abort on non-linefetch on Toradex Colibri VF50 module (with Vybrid VF5x

[PATCH 2/2] spi: spi-fsl-dspi: Initialize completion before possible interrupt

2020-06-14 Thread Krzysztof Kozlowski
If interrupt fires early, the dspi_interrupt() could complete (dspi->xfer_done) before its initialization happens. Fixes: 4f5ee75ea171 ("spi: spi-fsl-dspi: Replace interruptible wait queue with a simple completion") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-fsl-dspi.c | 4 ++--

Re: [RESEND PATCH v10 10/10] arm64: dts: Add node for ufs exynos7

2020-06-14 Thread Krzysztof Kozlowski
On Sat, Jun 13, 2020 at 08:17:06AM +0530, Alim Akhtar wrote: > Adding dt node foe UFS and UFS-PHY for exynos7 SoC. > > Signed-off-by: Alim Akhtar > Tested-by: Paweł Chmiel > --- > .../boot/dts/exynos/exynos7-espresso.dts | 4 ++ > arch/arm64/boot/dts/exynos/exynos7.dtsi | 43 +++

Re: [External] Re: [PATCH] mm/slab: Add a __GFP_ACCOUNT GFP flag check for slab allocation

2020-06-14 Thread Muchun Song
UNT-GFP-flag-check-for-slab-allocation/20200614-144049 > base: git://git.cmpxchg.org/linux-mmotm.git master > config: xtensa-allyesconfig (attached as .config) > compiler: xtensa-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubuserconte

Re: [PATCH 2/2] spi: spi-fsl-dspi: Initialize completion before possible interrupt

2020-06-14 Thread Vladimir Oltean
On Sun, 14 Jun 2020 at 13:56, Krzysztof Kozlowski wrote: > > If interrupt fires early, the dspi_interrupt() could complete > (dspi->xfer_done) before its initialization happens. > > Fixes: 4f5ee75ea171 ("spi: spi-fsl-dspi: Replace interruptible wait queue > with a simple completion") > Cc: > Sig

Re: [PATCH 11/19] perf ftrace: add option '-u/--userstacktrace' to show userspace stacktrace

2020-06-14 Thread Changbin Du
On Wed, May 20, 2020 at 06:07:41PM -0300, Arnaldo Carvalho de Melo wrote: > Em Sun, May 10, 2020 at 11:06:20PM +0800, Changbin Du escreveu: > > This adds an option ''-u/--userstacktrace' for function tracer to display > > userspace back trace. > > Probably we should have this as a term, an option

Re: [PATCH 2/2] spi: spi-fsl-dspi: Initialize completion before possible interrupt

2020-06-14 Thread Wolfram Sang
> > If interrupt fires early, the dspi_interrupt() could complete > > (dspi->xfer_done) before its initialization happens. > > > > Fixes: 4f5ee75ea171 ("spi: spi-fsl-dspi: Replace interruptible wait queue > > with a simple completion") > > Cc: > > Signed-off-by: Krzysztof Kozlowski > > --- > >

Re: [PATCH 2/2] spi: spi-fsl-dspi: Initialize completion before possible interrupt

2020-06-14 Thread Krzysztof Kozlowski
On Sun, Jun 14, 2020 at 02:14:15PM +0300, Vladimir Oltean wrote: > On Sun, 14 Jun 2020 at 13:56, Krzysztof Kozlowski wrote: > > > > If interrupt fires early, the dspi_interrupt() could complete > > (dspi->xfer_done) before its initialization happens. > > > > Fixes: 4f5ee75ea171 ("spi: spi-fsl-dspi

[PATCH v5] ath10k: provide survey info as accumulated data

2020-06-14 Thread Sven Eckelmann
From: Venkateswara Naralasetty It is expected that the returned counters by .get_survey are monotonic increasing. But the data from ath10k gets reset to zero regularly. Channel active/busy time are then showing incorrect values (less than previous or sometimes zero) for the currently active chann

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-14 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void panfrost_job_hw_subm

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-14 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void panfrost_job_hw_subm

Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit

2020-06-14 Thread Markus Elfring
> in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void panfrost_job_hw_subm

[GIT PULL] Btrfs updates for 5.8, part 2

2020-06-14 Thread David Sterba
Hi, this reverts the direct io port to iomap infrastructure of btrfs merged in the first pull request. We found problems in invalidate page that don't seem to be fixable as regressions or without changing iomap code that would not affect other filesystems. There are 4 patches reverted in total, b

Re: next-0519 on thinkpad x60: sound related? window manager crash

2020-06-14 Thread Alex Xu (Hello71)
Excerpts from Takashi Iwai's message of June 14, 2020 5:54 am: > On Sat, 13 Jun 2020 18:25:22 +0200, > Alex Xu (Hello71) wrote: >> >> Excerpts from Takashi Iwai's message of June 11, 2020 1:11 pm: >> > Thanks, so something still missing in the mmap handling, I guess. >> > >> > I've worked on two

Re: Re: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error

2020-06-14 Thread dinghao . liu
> > Can you point me to a discussion where it was decided that this is a > proper fix? I'd think we rather should fix pm_runtime_get_sync() but > maybe there are technical reasons against it. > There is a discussion here: https://lkml.org/lkml/2020/5/20/1100 There are many use cases that suppos

Re: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-06-14 Thread Jonathan Cameron
On Mon, 8 Jun 2020 14:12:18 +0200 Linus Walleij wrote: > Hi Jonathan, > > sorry for missing this :( > > On Sun, May 31, 2020 at 4:00 PM Jonathan Cameron wrote: > > On Tue, 26 May 2020 13:13:56 +0200 > > Linus Walleij wrote: > > > > > On Tue, May 26, 2020 at 12:47 PM Dinghao Liu > > > wrot

Re: power-off delay/hang due to commit 6d25be57 (mainline)

2020-06-14 Thread Stephen Berman
On Fri, 12 Jun 2020 13:01:22 +0200 Sebastian Andrzej Siewior wrote: > + ACPI in case the ACPI folks see something obvious. [...] >> The "acpi_os_execute_deferred" messages were repeated many times in the >> above line, then every 20-30 seconds again for several minutes. Then >> suddenly a call

Re: [PATCH v4 1/4] iio: chemical: scd30: add core driver

2020-06-14 Thread Jonathan Cameron
On Sun, 7 Jun 2020 13:59:48 +0200 Tomasz Duszynski wrote: > On Sat, Jun 06, 2020 at 04:06:52PM +0100, Jonathan Cameron wrote: > > On Wed, 3 Jun 2020 10:44:38 +0200 > > Tomasz Duszynski wrote: > > > > > Add Sensirion SCD30 carbon dioxide core driver. > > > > > > Signed-off-by: Tomasz Duszynski

Re: [PATCH v2 6/6] iio: remove left-over parent assignments

2020-06-14 Thread Jonathan Cameron
On Thu, 11 Jun 2020 06:52:00 + "Ardelean, Alexandru" wrote: > On Sat, 2020-06-06 at 17:05 +0100, Jonathan Cameron wrote: > > [External] > > > > On Wed, 3 Jun 2020 14:40:23 +0300 > > Alexandru Ardelean wrote: > > > > > These were found by doing some shell magic: > > > > > > f

Re: [PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-14 Thread Markus Elfring
> in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments > the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. * Can the term “reference count” become relevant also for this commit message besides oth

[PATCH] mm: memcontrol: Fix do not put the css reference

2020-06-14 Thread Muchun Song
We should put the css reference when memory allocation failed. Fixes: f0a3a24b532d ("mm: memcg/slab: rework non-root kmem_cache lifecycle management") Signed-off-by: Muchun Song --- mm/memcontrol.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memco

Re: [PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 9:55 AM Navid Emamdoost wrote: > > in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments > the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. ... > +out: > + pm_runtime

[PATCH 0/3] mm/slub: Fix slabs_node return value

2020-06-14 Thread Muchun Song
The slabs_node() always return zero when CONFIG_SLUB_DEBUG is disabled. But some codes determine whether slab is empty by checking the return value of slabs_node(). As you know, the result is not correct. we move the nr_slabs of kmem_cache_node out of the CONFIG_SLUB_DEBUG. So we can get the corren

[PATCH 2/3] mm/slub: Use node_nr_slabs() instead of slabs_node()

2020-06-14 Thread Muchun Song
In the some code, we already get the kmem_cache_node, so we can use node_nr_slabs() directly instead of slabs_node(). Check the condition of n->nr_partial can also be removed because we can get the correct result via node_nr_slabs(). Signed-off-by: Muchun Song --- mm/slub.c | 8 1 file

[PATCH 1/3] mm/slub: Fix slabs_node return value when CONFIG_SLUB_DEBUG disabled

2020-06-14 Thread Muchun Song
The slabs_node() always return zero when CONFIG_SLUB_DEBUG is disabled. But some codes determine whether slab is empty by checking the return value of slabs_node(). As you know, the result is not correct. This problem can be reproduce by the follow code(and boot system with the cmdline of "slub_nom

[PATCH 3/3] mm/slub: Fix release all resources used by a slab cache

2020-06-14 Thread Muchun Song
The function of __kmem_cache_shutdown() is that release all resources used by the slab cache, while currently it stop release resources when the preceding node is not empty. Signed-off-by: Muchun Song --- mm/slub.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/slu

Re: RFC: a failing pm_runtime_get increases the refcnt?

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 1:00 PM Geert Uytterhoeven wrote: > > Hi Andy, > > On Sun, Jun 14, 2020 at 11:43 AM Andy Shevchenko > wrote: > > On Sun, Jun 14, 2020 at 12:34 PM Andy Shevchenko > > wrote: > > > > > > On Sun, Jun 14, 2020 at 12:10 PM Wolfram Sang wrote: > > > > both in the I2C subsystem

Re: [PATCH v4 2/2] ovl: call underlying get_unmapped_area() routine. propogate FMODE_HUGETLBFS

2020-06-14 Thread Amir Goldstein
On Fri, Jun 12, 2020 at 3:57 AM Mike Kravetz wrote: > > The core routine get_unmapped_area will call a filesystem specific version > of get_unmapped_area if it exists in file operations. If a file is on a > union/overlay, overlayfs does not contain a get_unmapped_area f_op and the > underlying fi

RE: [PATCH v1 RFC 1/2] spi: introduce fallback to pio

2020-06-14 Thread Robin Gong
On 2020/06/12 22:16 Mark Brown wrote: > On Fri, Jun 12, 2020 at 01:48:41PM +, Robin Gong wrote: > > On 2020/06/12 18:14 Mark Brown wrote: > > > > Please look at the formatting of your e-mails - they're really hard > > > to read. The line length is over 80 columns and there's no breaks betw

Re: [RFC 1/3] lib: copy_{from,to}_user using gup & kmap_atomic()

2020-06-14 Thread afzal mohammed
Hi, On Sat, Jun 13, 2020 at 02:15:52PM +0100, Russell King - ARM Linux admin wrote: > On Sat, Jun 13, 2020 at 05:34:32PM +0530, afzal mohammed wrote: > > i think C > > library cuts any size read, write to page size (if it exceeds) & > > invokes the system call. > You can't make that assumption a

[PATCH] MAINTAINERS: move *@vger.kernel.org from M: to L:

2020-06-14 Thread Alexander A. Klimov
Signed-off-by: Alexander A. Klimov --- MAINTAINERS | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 68f21d46614c..86e9276ddb1d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8995,8 +8995,6 @@ F:drivers/net/ethernet/sgi/ioc3-eth.c IOM

Re: [PATCH] drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config

2020-06-14 Thread Markus Elfring
> in amdgpu_display_crtc_set_config, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Can it be nicer to combine proposed updates for this software module as a patch series (with a cover letter)? * Would you like to add the

Re: [PATCH v5 1/4] iio: chemical: scd30: add core driver

2020-06-14 Thread Jonathan Cameron
On Tue, 9 Jun 2020 04:18:56 +0800 kernel test robot wrote: > Hi Tomasz, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on iio/togreg] > [also build test WARNING on robh/for-next linux/master v5.7] > [if your patch is applied to the wrong git tree, please drop

Re: [PATCH v5 0/4] Add support for SCD30 sensor

2020-06-14 Thread Jonathan Cameron
On Sun, 7 Jun 2020 19:58:08 +0200 Tomasz Duszynski wrote: > Following series adds support for Sensirion SCD30 sensor module capable of > measuring carbon dioxide, temperature and relative humidity. CO2 measurements > base on NDIR principle while temperature and relative humidity are measured by >

  1   2   3   4   5   >