Re: [RFC PATCH v4 02/10] vfio/pci: macros to generate module_init and module_exit for vendor modules

2020-06-04 Thread Cornelia Huck
On Sun, 17 May 2020 22:45:10 -0400 Yan Zhao wrote: > vendor modules call macro module_vfio_pci_register_vendor_handler to > generate module_init and module_exit. > It is necessary to ensure that vendor modules always call > vfio_pci_register_vendor_driver() on driver loading and > vfio_pci_unregi

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-04 Thread Al Viro
On Thu, Jun 04, 2020 at 06:10:23AM -0400, Michael S. Tsirkin wrote: > stac() > for (i = 0; i < 64; ++i) { >get_user(flags, desc[i].flags) unsafe_get_user(), please. >smp_rmb() >if (!(flags & VALID)) > break; >copy_from_user(&adesc[i], desc

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
Dear Ilia Thank you for your reply. On Thu, Jun 4, 2020 at 4:36 PM Ilia Mirkin wrote: > Starting with kernel 5.6, loading nouveau without firmware (for GPUs > where it is required, such as yours) got broken. > > You are loading nouveau without firmware, so it fails. > > The firmware needs to be

[PATCHv7 0/3] optee: register drivers on optee bus

2020-06-04 Thread Maxim Uvarov
v7: - check return value of dev_set_name() (Jarkko Sakkinen) v6: - description, comments, patches reorder and destroy workqueue (Sumit Garg) v5: - removed pr_err and fix typos in description (Jarkko Sakkinen) - added missed kfree in optee_open() v4: - sysfs entry is optee-ta-uuid (Jerome Foriss

[PATCHv7 3/3] tpm_ftpm_tee: register driver on TEE bus

2020-06-04 Thread Maxim Uvarov
OP-TEE based fTPM Trusted Application depends on tee-supplicant to provide NV RAM implementation based on RPMB secure storage. So this dependency can be resolved via TEE bus where we only invoke fTPM driver probe once fTPM device is registered on the bus which is only true after the tee-supplicant

[PATCH -next] fork: silence a false postive warning in __mmdrop

2020-06-04 Thread Qian Cai
The linux-next commit bf2c59fce407 ("sched/core: Fix illegal RCU from offline CPUs") delayed, idle->active_mm = &init_mm; into finish_cpu() instead of idle_task_exit() which results in a false positive warning that was originally designed in the commit 3eda69c92d47 ("kernel/fork.c: detect early f

[PATCHv7 2/3] optee: enable support for multi-stage bus enumeration

2020-06-04 Thread Maxim Uvarov
Some drivers (like ftpm) can operate only after tee-supplicant runs because of tee-supplicant provides things like storage services (rpmb, shm).  This patch splits probe of non tee-supplicant dependable drivers to the early stage, and after tee-supplicant run probe other drivers. Signed-off-by: Ma

[PATCHv7 1/3] optee: use uuid for sysfs driver entry

2020-06-04 Thread Maxim Uvarov
With the evolving use-cases for TEE bus, now it's required to support multi-stage enumeration process. But using a simple index doesn't suffice this requirement and instead leads to duplicate sysfs entries. So instead switch to use more informative device UUID for sysfs entry like: /sys/bus/tee/dev

Re: [PATCH 05/14] mm: workingset: let cache workingset challenge anon

2020-06-04 Thread Johannes Weiner
On Thu, Jun 04, 2020 at 03:35:27PM +0200, Vlastimil Babka wrote: > On 6/1/20 10:44 PM, Johannes Weiner wrote: > > From a8faceabc1454dfd878caee2a8422493d937a394 Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner > > Date: Mon, 1 Jun 2020 14:04:09 -0400 > > Subject: [PATCH] mm: workingset: let cache

Re: [PATCH 2/5] gcc-plugins/stackleak: Use asm instrumentation to avoid useless register saving

2020-06-04 Thread Miguel Ojeda
Hi Alexander, On Thu, Jun 4, 2020 at 3:50 PM Alexander Popov wrote: > > diff --git a/include/linux/compiler_attributes.h > b/include/linux/compiler_attributes.h > index cdf016596659..522d57ae8532 100644 > --- a/include/linux/compiler_attributes.h > +++ b/include/linux/compiler_attributes.h > @@

Re: [PATCH] regulator: mt6360: Add support for MT6360 regulator

2020-06-04 Thread Randy Dunlap
On 6/4/20 12:06 AM, Gene Chen wrote: > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > index f4b72cb..05a3b14 100644 > --- a/drivers/regulator/Kconfig > +++ b/drivers/regulator/Kconfig > @@ -680,6 +680,16 @@ config REGULATOR_MT6358 > This driver supports the control of

Re: [PATCH] iommu/mediatek: Use totalram_pages to setup enable_4GB

2020-06-04 Thread Christoph Hellwig
On Thu, Jun 04, 2020 at 01:32:40PM +0200, David Hildenbrand wrote: > Just a thought: If memory hotplug is applicable as well, you might > either want to always assume data->enable_4GB, or handle memory hotplug > events from the memory notifier, when new memory gets onlined (not sure > how tricky th

Re: [PATCH v2 3/7] selftests/ftrace: Add "requires:" list support

2020-06-04 Thread Masami Hiramatsu
Hi Steve, On Wed, 3 Jun 2020 10:33:43 -0400 Steven Rostedt wrote: > On Wed, 3 Jun 2020 08:51:13 +0900 > Masami Hiramatsu wrote: > > > On Tue, 2 Jun 2020 09:21:45 -0400 > > Steven Rostedt wrote: > > > > > On Tue, 2 Jun 2020 18:08:31 +0900 > > > Masami Hiramatsu wrote: > > > > > > > +++ b

RE: general protection fault in ima_free_template_entry

2020-06-04 Thread Roberto Sassu
> From: syzbot > [mailto:syzbot+223310b454ba6b759...@syzkaller.appspotmail.com] > Sent: Thursday, June 4, 2020 4:23 PM > Hello, > > syzbot found the following crash on: > > HEAD commit:e7b08814 Add linux-next specific files for 20200529 > git tree: linux-next > console output: https://s

Re: [PATCH v2] KVM: x86: Assign correct value to array.maxnent

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 12:16:36PM +0800, Xiaoyao Li wrote: > Delay the assignment of array.maxnent to use correct value for the case > cpuid->nent > KVM_MAX_CPUID_ENTRIES. > > Fixes: e53c95e8d41e ("KVM: x86: Encapsulate CPUID entries and metadata in > struct") > Signed-off-by: Xiaoyao Li > ---

Re: [PATCH v7 5/5] drivers/tty/serial: add LiteUART driver

2020-06-04 Thread Randy Dunlap
Hi-- On 6/4/20 3:14 AM, Mateusz Holenko wrote: > +config SERIAL_LITEUART > + tristate "LiteUART serial port support" > + depends on HAS_IOMEM > + depends on OF || COMPILE_TEST > + depends on LITEX_SOC_CONTROLLER > + select SERIAL_CORE > + help > + This driver is for t

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
On Thu, Jun 4, 2020 at 4:36 PM Ilia Mirkin wrote: > > Starting with kernel 5.6, loading nouveau without firmware (for GPUs > where it is required, such as yours) got broken. > > You are loading nouveau without firmware, so it fails. > > The firmware needs to be available to the kernel at the time

Re: [RFC 00/16] KVM protected memory extension

2020-06-04 Thread Marc Zyngier
Hi Kirill, Thanks for this. On Fri, 22 May 2020 15:51:58 +0300 "Kirill A. Shutemov" wrote: > == Background / Problem == > > There are a number of hardware features (MKTME, SEV) which protect guest > memory from some unauthorized host access. The patchset proposes a purely > software feature th

Re: [PATCH] scs: Report SCS usage in bytes rather than number of entries

2020-06-04 Thread Will Deacon
On Wed, Jun 03, 2020 at 10:06:13AM -0700, Kees Cook wrote: > On Wed, Jun 03, 2020 at 04:12:17PM +0100, Will Deacon wrote: > > Fix the SCS debug usage check so that we report the number of bytes > > usedm, rather than the number of entries. > > typo: used > > > > > Fixes: 5bbaf9d1fcb9 ("scs: Add

Re: [PATCH v2 3/7] selftests/ftrace: Add "requires:" list support

2020-06-04 Thread Steven Rostedt
On Fri, 5 Jun 2020 00:08:50 +0900 Masami Hiramatsu wrote: > > Reviewed-by: Steven Rostedt (VMware) > > Thanks, and I've already sent v3. > > https://lkml.kernel.org/r/159115200085.70027.6141550347953439240.stgit@devnote2 I tested that too, and you can keep my Reviewed-by on the patch set.

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-04 Thread Jassi Brar
On Thu, Jun 4, 2020 at 4:20 AM Sudeep Holla wrote: > > On Wed, Jun 03, 2020 at 01:32:42PM -0500, Jassi Brar wrote: > > On Wed, Jun 3, 2020 at 1:04 PM Sudeep Holla wrote: > > > > > > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > > > On 28-05-20, 13:20, Rob Herring wrote: > > >

Re: [PATCH] KVM: VMX: Always treat MSR_IA32_PERF_CAPABILITIES as a valid PMU MSR

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 09:37:59AM +0800, Xu, Like wrote: > On 2020/6/4 4:33, Sean Christopherson wrote: > >Unconditionally return true when querying the validity of > >MSR_IA32_PERF_CAPABILITIES so as to defer the validity check to > >intel_pmu_{get,set}_msr(), which can properly give the MSR a pa

Re: [PATCH] iommu/arm-smmu: Mark qcom_smmu_client_of_match as possibly unused

2020-06-04 Thread Will Deacon
On Wed, Jun 03, 2020 at 03:15:07PM -0600, Jordan Crouse wrote: > When CONFIG_OF=n of_match_device() gets pre-processed out of existence > leaving qcom-smmu_client_of_match unused. Mark it as possibly unused to > keep the compiler from warning in that case. > > Fixes: 0e764a01015d ("iommu/arm-smmu:

Re: [PATCH v3 40/75] x86/sev-es: Compile early handler code into kernel image

2020-06-04 Thread Borislav Petkov
On Thu, Jun 04, 2020 at 01:54:13PM +0200, Joerg Roedel wrote: > It is not only the trace-point, this would also eliminate exception > handling in case the MSR access triggers a #GP. The "Unhandled MSR > read/write" messages would turn into a "General Protection Fault" > message. But the early ones

Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-04 Thread James Smart
On 5/25/2020 9:21 PM, Dongli Zhang wrote: The nvme host and target verify the wwnn and wwpn format via nvme_fc_parse_traddr(). For instance, it is required that the length of wwnn to be either 21 ("nn-0x") or 19 (nn-). Add this verification to nvme-fcloop so that the input should always be in he

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Markus Elfring
> Check for memset() with 0 followed by kfree(). I suggest to simplify the SmPL code a bit like the following. > +virtual context > +virtual org > +virtual report > +virtual patch +virtual context, org, report, patch … > +@@ > + > +( > +* memset(E, 0, ...); > +| > +* memset(E, '\0', ...); > +

Re: [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage

2020-06-04 Thread Miguel Ojeda
On Thu, Jun 4, 2020 at 4:56 PM Kees Cook wrote: > > Er? That's not what it looked like to me: > > #define IS_BUILTIN(option) __is_defined(option) > #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option)) > > But just to be sure, I just tested in with a real build: > > [3.242160]

Re: [PATCH 1/5] gcc-plugins/stackleak: Exclude alloca() from the instrumentation logic

2020-06-04 Thread Alexander Popov
On 04.06.2020 17:01, Jann Horn wrote: > On Thu, Jun 4, 2020 at 3:51 PM Alexander Popov wrote: >> Some time ago Variable Length Arrays (VLA) were removed from the kernel. >> The kernel is built with '-Wvla'. Let's exclude alloca() from the >> instrumentation logic and make it simpler. The build-tim

Re: Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread SeongJae Park
On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand wrote: > On 04.06.20 09:26, SeongJae Park wrote: > > On Wed, 3 Jun 2020 18:09:21 +0200 David Hildenbrand > > wrote: > > > >> On 03.06.20 16:11, SeongJae Park wrote: > >>> From: SeongJae Park > >>> > >>> This commit implements the four callba

Re: [RFC PATCH v4 04/10] vfio/pci: let vfio_pci know number of vendor regions and vendor irqs

2020-06-04 Thread Cornelia Huck
On Sun, 17 May 2020 22:49:44 -0400 Yan Zhao wrote: > This allows a simpler VFIO_DEVICE_GET_INFO ioctl in vendor driver > > Cc: Kevin Tian > Signed-off-by: Yan Zhao > --- > drivers/vfio/pci/vfio_pci.c | 23 +-- > drivers/vfio/pci/vfio_pci_private.h | 2 ++ > includ

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Ilia Mirkin
On Thu, Jun 4, 2020 at 11:16 AM Zeno Davatz wrote: > > On Thu, Jun 4, 2020 at 4:36 PM Ilia Mirkin wrote: > > > > Starting with kernel 5.6, loading nouveau without firmware (for GPUs > > where it is required, such as yours) got broken. > > > > You are loading nouveau without firmware, so it fails.

Re: [PATCH v2 1/2] kcov, objtool: Make runtime functions noinstr-compatible

2020-06-04 Thread Peter Zijlstra
On Thu, Jun 04, 2020 at 04:56:34PM +0200, Marco Elver wrote: > While we lack a compiler attribute to add to noinstr that would disable > KCOV, make the KCOV runtime functions return if the caller is in a > noinstr section. We then whitelist __sanitizer_cov_*() functions in > objtool. > __sanitizer

Re: [GIT PULL] SELinux patches for v5.8

2020-06-04 Thread Casey Schaufler
On 6/4/2020 5:45 AM, Stephen Smalley wrote: > On Wed, Jun 3, 2020 at 6:39 PM Casey Schaufler wrote: >> On 6/3/2020 3:12 PM, James Morris wrote: >>> On Wed, 3 Jun 2020, Casey Schaufler wrote: >>> The use of security modules was expected to be rare. >>> This is not correct. Capabilities were po

Re: [PATCH] iommu/mediatek: Use totalram_pages to setup enable_4GB

2020-06-04 Thread David Hildenbrand
On 04.06.20 17:06, Christoph Hellwig wrote: > On Thu, Jun 04, 2020 at 01:32:40PM +0200, David Hildenbrand wrote: >> Just a thought: If memory hotplug is applicable as well, you might >> either want to always assume data->enable_4GB, or handle memory hotplug >> events from the memory notifier, when

Re: [PATCH v3 42/75] x86/sev-es: Setup GHCB based boot #VC handler

2020-06-04 Thread Borislav Petkov
On Thu, Jun 04, 2020 at 02:07:49PM +0200, Joerg Roedel wrote: > This are IDT entry points and the names above follow the convention for > them, like e.g. 'page_fault', 'nmi' or 'general_protection'. Should I > still add the verbs or just add a comment explaining what those symbols > are? Hmmkay, I

Re: [PATCH v2] hwmon: bt1-pvt: Define Temp- and Volt-to-N poly as maybe-unused

2020-06-04 Thread Guenter Roeck
On Wed, Jun 03, 2020 at 03:07:53AM +0300, Serge Semin wrote: > Clang-based kernel building with W=1 warns that some static const > variables are unused: > > drivers/hwmon/bt1-pvt.c:67:30: warning: unused variable 'poly_temp_to_N' > [-Wunused-const-variable] > static const struct pvt_poly poly_tem

[PATCH v1] reset: intel: fix a compile warning about REG_OFFSET redefined

2020-06-04 Thread Dejin Zheng
kernel test robot reports a compile warning about REG_OFFSET redefined in the reset-intel-gw.c after merging commit e44ab4e14d6f4 ("regmap: Simplify implementation of the regmap_read_poll_timeout() macro"). the warning is like that: drivers/reset/reset-intel-gw.c:18:0: warning: "REG_OFFSET" redefi

Re: [PATCH v2 1/5] perf/x86/rapl: move RAPL support to common x86 code

2020-06-04 Thread Stephane Eranian
On Thu, Jun 4, 2020 at 6:11 AM Johannes Hirte wrote: > > On 2020 Jun 01, Stephane Eranian wrote: > > On Mon, Jun 1, 2020 at 5:39 AM Johannes Hirte > > wrote: > > > > > > On 2020 Mai 27, Stephane Eranian wrote: > > > > > > ... > > > > diff --git a/arch/x86/events/Makefile b/arch/x86/events/Makefil

Re: [PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Vitaly Kuznetsov
Sean Christopherson writes: > On Thu, Jun 04, 2020 at 04:40:52PM +0200, Paolo Bonzini wrote: >> On 04/06/20 16:31, Vitaly Kuznetsov wrote: > > ... > >> > KVM could've handled the request correctly by going to userspace and >> > performing I/O but there doesn't seem to be a good need for such requ

Re: [GIT PULL] SELinux patches for v5.8

2020-06-04 Thread Stephen Smalley
On Thu, Jun 4, 2020 at 11:28 AM Casey Schaufler wrote: > > On 6/4/2020 5:45 AM, Stephen Smalley wrote: > > On Wed, Jun 3, 2020 at 6:39 PM Casey Schaufler > > wrote: > >> On 6/3/2020 3:12 PM, James Morris wrote: > >>> On Wed, 3 Jun 2020, Casey Schaufler wrote: > >>> > The use of security mod

Re: [PATCH v3 2/7] documentation for stats_fs

2020-06-04 Thread Emanuele Giuseppe Esposito
Hi, + +The STATS_FS_HIDDEN attribute won't affect the aggregation, it will only +block the creation of the files. Why does HIDDEN block the creation of files? instead of their visibility? The file itself is used to allow the user to view the content of a value. In order to make it hidden,

[PATCH] i2c: npcm7xx: Remove unnecessary parentheses

2020-06-04 Thread Gustavo A. R. Silva
Remove unnecessary parentheses around _bus_. This issue was found with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/i2c/busses/i2c-npcm7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-np

Re: drivers/reset/reset-intel-gw.c:18: warning: "REG_OFFSET" redefined

2020-06-04 Thread Dejin Zheng
entation of the regmap_read_poll_timeout() macro > date: 6 weeks ago > config: arm-randconfig-r035-20200604 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/m

Re: v5.7: new core kernel option missing help text

2020-06-04 Thread Valentin Schneider
On 04/06/20 14:05, Thara Gopinath wrote: > On Thu, 4 Jun 2020 at 06:56, Valentin Schneider >> >> Right, s/defconfig/arch kconfig/ or somesuch. >> > > CPU_FREQ_THERMAL also has to be enabled for this to be effective. > Since arm64 defconfig enables CPU_FREQ_THERMAL (by enabling CPU_THERMAL), >

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Denis Efremov
On 6/4/20 5:15 PM, Julia Lawall wrote: > Did you try ... here but find that some subexpressions of E could be > modified in between? Yes, I tried to use "... when != E = E1 when != &E" and results were bad. Now, I've tried forall and when strict. Here are examples: // forall added // Works wel

Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread David Hildenbrand
On 04.06.20 17:23, SeongJae Park wrote: > On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand wrote: > >> On 04.06.20 09:26, SeongJae Park wrote: >>> On Wed, 3 Jun 2020 18:09:21 +0200 David Hildenbrand >>> wrote: >>> On 03.06.20 16:11, SeongJae Park wrote: > From: SeongJae Park >

[tip:x86/entry] BUILD SUCCESS b8797e281f77cdac3988e9a97b1c76eabbabaefa

2020-06-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/entry branch HEAD: b8797e281f77cdac3988e9a97b1c76eabbabaefa Merge branch 'linus' into x86/entry, to resolve conflicts i386-tinyconfig vmlinux size: +---++--

Re: [patch V9 00/39] x86/entry: Rework leftovers (was part V)

2020-06-04 Thread Andy Lutomirski
On Thu, Jun 4, 2020 at 6:35 AM Peter Zijlstra wrote: > > On Thu, Jun 04, 2020 at 03:29:26PM +0200, Paolo Bonzini wrote: > > On 04/06/20 15:25, Peter Zijlstra wrote: > > > It being enabled through IA32_DEBUGCTL instead of through DR7 means that > > > the current code doesn't disable it and this the

Re: [PATCH v1] Bluetooth: hci_qca: Fix double free during SSR timeout

2020-06-04 Thread bgodavar
On 2020-06-04 19:27, Venkata Lakshmi Narayana Gubba wrote: Due to race conditions between qca_hw_error and qca_controller_memdump during SSR timeout,the same pointer is freed twice. Which results to double free error. Now a lock is acquired while SSR state moved to timeout. Signed-off-by: Venk

Re: [RFC 00/16] KVM protected memory extension

2020-06-04 Thread Sean Christopherson
+Jun On Thu, Jun 04, 2020 at 04:15:23PM +0100, Marc Zyngier wrote: > Hi Kirill, > > Thanks for this. > > On Fri, 22 May 2020 15:51:58 +0300 > "Kirill A. Shutemov" wrote: > > > == Background / Problem == > > > > There are a number of hardware features (MKTME, SEV) which protect guest > > memor

Re: [PATCH v2 1/2] arm64: dts: Add a device tree for the Librem 5 phone

2020-06-04 Thread Mark Brown
On Thu, Jun 04, 2020 at 10:47:55AM +0200, Martin Kepplinger wrote: > + reg_audio_pwr_en: regulator-audio-pwr-en { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_audiopwr>; > + regulator-name = "AUDIO_

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Denis Efremov wrote: > > > On 6/4/20 5:15 PM, Julia Lawall wrote: > > Did you try ... here but find that some subexpressions of E could be > > modified in between? > > Yes, I tried to use "... when != E = E1 when != &E" and results were bad. > Now, I've tried forall and when

Re: Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread SeongJae Park
On Thu, 4 Jun 2020 17:39:49 +0200 David Hildenbrand wrote: > On 04.06.20 17:23, SeongJae Park wrote: > > On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand > > wrote: > > > >> On 04.06.20 09:26, SeongJae Park wrote: > >>> On Wed, 3 Jun 2020 18:09:21 +0200 David Hildenbrand > >>> wrote: > >>

Re: [PATCH] scsi: megaraid_sas: fix kdump kernel boot hung caused by JBOD

2020-06-04 Thread Kai Liu
On 2020/06/04 Thu 16:39, Chandrakanth Patil wrote: Hi Martin, Xiaoming Gao, Kai Liu, It is a known firmware issue and has been fixed. Please update to the latest firmware available in the Broadcom support website. Please let me know if you need any further information. Hi Chandrakanth, Could

Re: [patch V9 00/39] x86/entry: Rework leftovers (was part V)

2020-06-04 Thread Peter Zijlstra
On Thu, Jun 04, 2020 at 08:42:52AM -0700, Andy Lutomirski wrote: > x86 is not an architecture. x86 is a gauntlet through which operating > system developers must run. That made my day :-) > I think we can tolerate this particular mess -- can't we just say that > a BUS LOCK DEBUG EXCEPTION is fa

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Markus Elfring wrote: > > Check for memset() with 0 followed by kfree(). > > I suggest to simplify the SmPL code a bit like the following. > > > > +virtual context > > +virtual org > > +virtual report > > +virtual patch > > +virtual context, org, report, patch This is pointl

Re: [PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 10:42:45AM +0200, gli...@google.com wrote: > Under certain circumstances (we found this out running Docker on a > Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may > return uninitialized value of |error| from ovl_copy_xattr(). > It is then returned by ovl_c

Re: [PATCH 0/6] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts

2020-06-04 Thread Manivannan Sadhasivam
On Thu, Jun 04, 2020 at 10:06:19AM -0400, Jonathan Marek wrote: > On 6/4/20 9:52 AM, Manivannan Sadhasivam wrote: > > Hi, > > > > On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: > > > Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. > > > > > > > I've tested this s

Re: [PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

2020-06-04 Thread Kees Cook
On Thu, Jun 04, 2020 at 10:57:24AM +0200, Miklos Szeredi wrote: > On Thu, Jun 4, 2020 at 10:43 AM wrote: > > > > Under certain circumstances (we found this out running Docker on a > > Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may > > return uninitialized value of |error| from

Re: [RFC PATCH] gpio: uapi: v2 proposal

2020-06-04 Thread Kent Gibson
On Thu, Jun 04, 2020 at 02:43:08PM +0200, Bartosz Golaszewski wrote: > sob., 16 maj 2020 o 08:45 Kent Gibson napisał(a): > > > > Add a new version of the uAPI to address existing 32/64bit alignment > > issues, add support for debounce, and provide some future proofing by > > adding padding reserve

Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring

2020-06-04 Thread David Hildenbrand
On 04.06.20 17:51, SeongJae Park wrote: > On Thu, 4 Jun 2020 17:39:49 +0200 David Hildenbrand wrote: > >> On 04.06.20 17:23, SeongJae Park wrote: >>> On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand >>> wrote: >>> On 04.06.20 09:26, SeongJae Park wrote: > On Wed, 3 Jun 2020 18:09:21

Re: [PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Sean Christopherson
On Thu, Jun 04, 2020 at 05:33:25PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Thu, Jun 04, 2020 at 04:40:52PM +0200, Paolo Bonzini wrote: > >> On 04/06/20 16:31, Vitaly Kuznetsov wrote: > > > > ... > > > >> > KVM could've handled the request correctly by going to usersp

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
Thank you, Ilia On Thu, Jun 4, 2020 at 5:25 PM Ilia Mirkin wrote: > There's a lot more firmware files than that ... everything in the > gp107 directory. Also this would only be necessary if nouveau is built > into the kernel. The files just have to be available whenever nouveau > is loaded -- if

Re: [PATCH RT 1/2] tasklet: Address a race resulting in double-enqueue

2020-06-04 Thread Ramon Fried
On Thu, Apr 23, 2020 at 11:55 PM wrote: > > From: Zhang Xiao > > v4.19.115-rt49-rc1 stable review patch. > If anyone has any objections, please let me know. > > --- > > > The kernel bugzilla has the following race condition reported: > > CPU0CPU1CPU2 >

Re: [PATCH -tip] kcov: Make runtime functions noinstr-compatible

2020-06-04 Thread Peter Zijlstra
On Thu, Jun 04, 2020 at 04:02:54PM +0200, Andrey Konovalov wrote: > On Thu, Jun 4, 2020 at 1:09 PM Peter Zijlstra wrote: > > That whole kcov_remote stuff confuses me. > > > > KCOV_ENABLE() has kcov_fault_in_area(), which supposedly takes the > > vmalloc faults for the current task, but who does i

Re: [PATCH 3/3] spi: bcm2835: Enable shared interrupt support

2020-06-04 Thread Florian Fainelli
On 6/4/2020 5:32 AM, Mark Brown wrote: > On Wed, Jun 03, 2020 at 08:46:55PM -0700, Florian Fainelli wrote: >> The SPI controller found in the BCM2711 and BCM7211 SoCs is instantiated >> 5 times, with all instances sharing the same interrupt line. We >> specifically match the two compatible strin

Re: [PATCH] leds: mt6360: Add LED driver for MT6360

2020-06-04 Thread Dan Murphy
Gene On 6/4/20 1:26 AM, Gene Chen wrote: From: Gene Chen Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, and 3-channel RGB LED support Register/Flash/Breath Mode Signed-off-by: Gene Chen base-commit: 098c4adf249c198519a4abebe482b1e6b8c50e47 --- drivers/leds/Kconfi

[tip:WIP.x86/mm] BUILD SUCCESS c30a3e465817f0c5a3c94678edf0fd15585cadd9

2020-06-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/mm branch HEAD: c30a3e465817f0c5a3c94678edf0fd15585cadd9 Merge branch 'linus' into WIP.x86/mm, to resolve conflict i386-tinyconfig vmlinux size: +---++-

Re: coccinelle: api: add kzfree script

2020-06-04 Thread Markus Elfring
>>> +virtual context >>> +virtual org >>> +virtual report >>> +virtual patch >> >> +virtual context, org, report, patch > > This is pointless. I find the proposed SmPL code variant more succinct. >> How does the SmPL asterisk functionality fit to the operation >> modes “org” and “report”? > > ma

Re: [PATCH 0/6] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts

2020-06-04 Thread Jonathan Marek
On 6/4/20 11:58 AM, Manivannan Sadhasivam wrote: On Thu, Jun 04, 2020 at 10:06:19AM -0400, Jonathan Marek wrote: On 6/4/20 9:52 AM, Manivannan Sadhasivam wrote: Hi, On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: Add dts nodes for apps_smmu and USB for both sm8150 and sm8250.

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > OK, I recall a discussion with Dan where he suggested that some things > > that were not actually bug fixes could also merit a Fixes tag. But it's > > probably better if he w

Re: [PATCH] x86/speculation: Check whether speculation is force disabled

2020-06-04 Thread Waiman Long
On 6/4/20 3:29 AM, Tada, Kenta (Sony) wrote: It conflicts with your new code. We can have an argument on whether IB should follow how SSB is being handled. Before that is settled, Thank you for the information. It conflicts but I think users who read the below document get confused. Documentati

Re: linux-next: build failure on powerpc 8xx with 16k pages

2020-06-04 Thread Will Deacon
[+Arnd since I think we spoke about this on IRC once] On Thu, Jun 04, 2020 at 02:35:14PM +, Christophe Leroy wrote: > Now I get the same issue at > >CC mm/mincore.o > In file included from ./include/asm-generic/bug.h:5:0, > from ./arch/powerpc/include/asm/bug.h:109,

Re: [PATCH] KVM: nVMX: Inject #GP when nested_vmx_get_vmptr() fails to read guest memory

2020-06-04 Thread Paolo Bonzini
On 04/06/20 18:02, Sean Christopherson wrote: > On Thu, Jun 04, 2020 at 05:33:25PM +0200, Vitaly Kuznetsov wrote: >> Sean Christopherson writes: >> >>> On Thu, Jun 04, 2020 at 04:40:52PM +0200, Paolo Bonzini wrote: On 04/06/20 16:31, Vitaly Kuznetsov wrote: >>> >>> ... >>> > KVM could've

[PATCH 1/2] overlayfs: add dynamic path resolving in mount options

2020-06-04 Thread Alexander Mikhalitsyn
This patch adds OVERLAY_FS_DYNAMIC_RESOLVE_PATH_OPTIONS compile-time option, and "dyn_path_opts" runtime module option. These options corresponds "dynamic path resolving in lowerdir, upperdir, workdir mount options" mode. If enabled, user may see real full paths relatively to the mount namespace in

[PATCH 2/2] overlayfs: add mnt_id paths options

2020-06-04 Thread Alexander Mikhalitsyn
This patch adds config OVERLAY_FS_PATH_OPTIONS_MNT_ID compile-time option, and "mnt_id_path_opts" runtime module option. If enabled, user may see mnt_ids for lowerdir, upperdir paths in mountinfo in separate lowerdir_mnt_id/upperdir_mnt_id options. This patch is very helpful to checkpoint/restore

[PATCH 0/2] overlayfs: C/R enhancements

2020-06-04 Thread Alexander Mikhalitsyn
This patchset aimed to make C/R of overlayfs mounts with CRIU possible. We introduce two new overlayfs module options -- dyn_path_opts and mnt_id_path_opts. If enabled this options allows to see real *full* paths in lowerdir, workdir, upperdir options, and also mnt_ids for corresponding paths. Thi

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Ilia Mirkin
On Thu, Jun 4, 2020 at 12:04 PM Zeno Davatz wrote: > > Thank you, Ilia > > On Thu, Jun 4, 2020 at 5:25 PM Ilia Mirkin wrote: > > > There's a lot more firmware files than that ... everything in the > > gp107 directory. Also this would only be necessary if nouveau is built > > into the kernel. The

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-06-04 Thread Marc Gonzalez
Looks like this series has fallen through the cracks :( Greg, you would be taking the drivers/base/devres.c changes? As mentioned in patch 2, "This patch needs testing on a platform with many clocks." (I've only tested using a trivial kernel module) On 10/03/2020 11:11, Marc Gonzalez wrote: > Di

Re: [PATCH v3 2/3] crypto: CRYPTO_CTR no longer need CRYPTO_SEQIV

2020-06-04 Thread Eric Biggers
On Fri, Apr 24, 2020 at 01:40:46PM +, Corentin Labbe wrote: > As comment of the v2, Herbert said: "The SEQIV select from CTR is historical > and no longer necessary." > > So let's get rid of it. > > Signed-off-by: Corentin Labbe > --- > crypto/Kconfig | 1 - > 1 file changed, 1 deletion(-)

[tip:master] BUILD SUCCESS 8abcfb969c86dffd06fc02bb9d727dd52977f336

2020-06-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master branch HEAD: 8abcfb969c86dffd06fc02bb9d727dd52977f336 Merge branch 'WIP.core/headers' elapsed time: 480m configs tested: 98 configs skipped: 1 The following configs have been built successfully. More configs may b

Re: [PATCH v6 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver

2020-06-04 Thread Jonathan McDowell
On Wed, Jun 03, 2020 at 03:22:34PM +0200, Ansuel Smith wrote: > This has lost in the original push for the dwc3 qcom driver. > This is needed for ipq806x SoC as without this the usb ports > doesn't work at all. FWIW I tested this on my RB3011 so feel free to add: Tested-by: Jonathan McDowell On

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
Dear Ilia On Thu, Jun 4, 2020 at 6:13 PM Ilia Mirkin wrote: > Not sure why you bother asking questions when you're just going to > dump nouveau anyways. This is the second time I've answered your > questions on this very topic, I think it'll be the last too. I will try again with the next Kerne

[tip:WIP.core/headers] BUILD SUCCESS 1d8fcbb76bb17762ca92a79a7db5af98f2fd9fe8

2020-06-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.core/headers branch HEAD: 1d8fcbb76bb17762ca92a79a7db5af98f2fd9fe8 compiler.h: Move instrumentation_begin()/end() into new header elapsed time: 482m configs tested: 98 configs skipped: 1 The following configs have

Re: [PATCH] KVM: VMX: Always treat MSR_IA32_PERF_CAPABILITIES as a valid PMU MSR

2020-06-04 Thread Paolo Bonzini
On 04/06/20 17:16, Sean Christopherson wrote: > On Thu, Jun 04, 2020 at 09:37:59AM +0800, Xu, Like wrote: >> On 2020/6/4 4:33, Sean Christopherson wrote: >>> Unconditionally return true when querying the validity of >>> MSR_IA32_PERF_CAPABILITIES so as to defer the validity check to >>> intel_pmu_{

Re: [PATCH v2] KVM: x86: Assign correct value to array.maxnent

2020-06-04 Thread Paolo Bonzini
On 04/06/20 17:12, Sean Christopherson wrote: > On Thu, Jun 04, 2020 at 12:16:36PM +0800, Xiaoyao Li wrote: >> Delay the assignment of array.maxnent to use correct value for the case >> cpuid->nent > KVM_MAX_CPUID_ENTRIES. >> >> Fixes: e53c95e8d41e ("KVM: x86: Encapsulate CPUID entries and metadata

Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-04 Thread Bartosz Golaszewski
czw., 4 cze 2020 o 16:18 Kent Gibson napisał(a): > > > > > Is this comment relevant for the character device? > > > > True - that comment should stay in gpiolib, and gpiolib-cdev should get > one of it's own. > > Any suggestions on how to maintain line history? > I know you can trick git by moving

Re: [Nouveau] NVIDIA GP107 (137000a1) - acr: failed to load firmware

2020-06-04 Thread Zeno Davatz
On Thu, Jun 4, 2020 at 6:13 PM Ilia Mirkin wrote: > Not sure why you bother asking questions when you're just going to > dump nouveau anyways. This is the second time I've answered your > questions on this very topic, I think it'll be the last too. Actually, what I will try next is emerging "x11

Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Jakub Kicinski
On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: > Add RGMII internal delay configuration for Rx and Tx. > > Signed-off-by: Dan Murphy Hi Dan, please make sure W=1 C=1 build is clean: drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal_delay’ defined but not used [-Wunused-cons

Re: [PATCH] coccinelle: api: add kzfree script

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 17:08 +0300, Denis Efremov wrote: > Check for memset() with 0 followed by kfree(). Perhaps those uses should be memzero_explicit or kvfree_sensitive.

Re: [RFC 00/16] KVM protected memory extension

2020-06-04 Thread Marc Zyngier
Hi Sean, On 2020-06-04 16:48, Sean Christopherson wrote: +Jun On Thu, Jun 04, 2020 at 04:15:23PM +0100, Marc Zyngier wrote: Hi Kirill, Thanks for this. On Fri, 22 May 2020 15:51:58 +0300 "Kirill A. Shutemov" wrote: > == Background / Problem == > > There are a number of hardware features (M

Re: [PATCH v25 03/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2020-06-04 Thread Dan Murphy
Jacek On 6/1/20 4:34 AM, Jacek Anaszewski wrote: Hi Pavel and Dan, On 5/31/20 9:06 PM, Pavel Machek wrote: Hi! +  There can only be one instance of the ti,led-bank +  property for each device node.  This is a required node is the LED +  modules are to be backed. I

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-04 Thread Julia Lawall
On Thu, 4 Jun 2020, Joe Perches wrote: > On Thu, 2020-06-04 at 15:30 +0300, Dan Carpenter wrote: > > On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > > > OK, I recall a discussion with Dan where he suggested that some things > > > that were not actually bug fixes could also merit

Re: [PATCH] rcu: Stop shrinker loop

2020-06-04 Thread Paul E. McKenney
On Thu, Jun 04, 2020 at 03:42:55PM +0200, Uladzislau Rezki wrote: > On Thu, Jun 04, 2020 at 12:23:20PM +0200, Peter Enderborg wrote: > > The count and scan can be separated in time. It is a fair chance > > that all work is already done when the scan starts. It > > then might retry. This is can be a

[PATCH] IMA: Add log statements for failure conditions

2020-06-04 Thread Lakshmi Ramasubramanian
The final log statement in process_buffer_measurement() for failure condition is at debug level. This does not log the message unless the system log level is raised which would significantly increase the messages in the system log. Change this log message to error level, and add eventname and ima_h

Re: [GIT PULL] First batch of KVM changes for Linux 5.8

2020-06-04 Thread Paolo Bonzini
On 04/06/20 00:17, Linus Torvalds wrote: > On Wed, Jun 3, 2020 at 10:39 AM Paolo Bonzini wrote: >> There could be minor conflicts depending on the order you're processing 5.8 >> pull requests. > It would have been good if you had actually pointed to the reports > from linux-next. > > As it was, t

Re: [RFC 00/16] KVM protected memory extension

2020-06-04 Thread Will Deacon
Hi Sean, On Thu, Jun 04, 2020 at 08:48:35AM -0700, Sean Christopherson wrote: > On Thu, Jun 04, 2020 at 04:15:23PM +0100, Marc Zyngier wrote: > > On Fri, 22 May 2020 15:51:58 +0300 > > "Kirill A. Shutemov" wrote: > > > > > == Background / Problem == > > > > > > There are a number of hardware fe

Re: [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints

2020-06-04 Thread Paul E. McKenney
On Thu, Jun 04, 2020 at 01:41:22PM +0200, Frederic Weisbecker wrote: > On Fri, May 22, 2020 at 10:57:39AM -0700, Paul E. McKenney wrote: > > On Wed, May 20, 2020 at 08:29:49AM -0400, Joel Fernandes wrote: > > > Reviewed-by: Joel Fernandes (Google) > > > > Thank you for looking this over, Joel! >

Re: [PATCH V2] mm/vmstat: Add events for THP migration without split

2020-06-04 Thread Matthew Wilcox
On Thu, Jun 04, 2020 at 09:51:10AM -0400, Zi Yan wrote: > On 4 Jun 2020, at 7:34, Matthew Wilcox wrote: > > On Thu, Jun 04, 2020 at 09:30:45AM +0530, Anshuman Khandual wrote: > >> +Quantifying Migration > >> += > >> +Following events can be used to quantify page migration. > >>

Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Dan Murphy
Jakub On 6/4/20 11:25 AM, Jakub Kicinski wrote: On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy Hi Dan, please make sure W=1 C=1 build is clean: drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal

<    1   2   3   4   5   6   7   8   9   10   >