Re: [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable()

2020-05-31 Thread Markus Elfring
> pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. * How do you think about to replace the word “pairing” by “corresponding”? * Will it be helpful to a

Re: [PATCH 1/2] docs: mm/gup: pin_user_pages.rst: add a "case 5"

2020-05-31 Thread Souptick Joarder
On Sat, May 30, 2020 at 5:13 AM John Hubbard wrote: > > There are four cases listed in pin_user_pages.rst. These are > intended to help developers figure out whether to use > get_user_pages*(), or pin_user_pages*(). However, the four cases > do not cover all the situations. For example, drivers/vh

Re: [PATCH 1/2] mm/gup: introduce pin_user_pages_locked()

2020-05-31 Thread Souptick Joarder
On Sun, May 31, 2020 at 12:34 PM Souptick Joarder wrote: > > On Thu, May 28, 2020 at 4:02 AM John Hubbard wrote: > > > > Introduce pin_user_pages_locked(), which is nearly identical to > > get_user_pages_locked() except that it sets FOLL_PIN and rejects > > FOLL_GET. Forget to ask, is it fine to

RE: [PATCH v2 1/5] scsi: ufs-mediatek: Fix imprecise waiting time for ref-clk control

2020-05-31 Thread Avri Altman
> > Currently ref-clk control timeout is implemented by Jiffies. However > jiffies is not accurate enough thus "false timeout" may happen. > > Use more accurate delay mechanism instead, for example, ktime. > > Signed-off-by: Stanley Chu > Reviewed-by: Andy Teng Reviewed-by: Avri Altman > -

[PATCH v8 0/7] I3C mastership handover support

2020-05-31 Thread Parshuram Thombare
Main changes between v7 and v8 are: - Document format changed from table to DOT diagram - Appropriate names for few functions - Moved mastership request process entirely to the driver - Reuse of i3c_master_add_i3c_dev_locked in core defslvs processing Main changes between v6 and v7 are: - Added

[PATCH v8 1/7] i3c: master: master initialization flow document

2020-05-31 Thread Parshuram Thombare
Document describing master initialization, mastership handover and DEFSLVS handling processes. Signed-off-by: Parshuram Thombare --- Documentation/driver-api/i3c/index.rst| 1 + .../i3c/master-initialization-flow.rst| 187 ++ 2 files changed, 188 insertions(+)

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-05-31 Thread Sedat Dilek
On Sun, May 31, 2020 at 9:04 AM Sedat Dilek wrote: > > On Sun, May 31, 2020 at 3:57 AM Jens Axboe wrote: > > > > On 5/30/20 12:57 PM, Sedat Dilek wrote: > > > Here are the numbers with your patchset: > > > > > > # cat systemd-analyze-time_5.7.0-rc7-4-amd64-clang_2nd-try.txt > > > Startup finished

[PATCH v8 2/7] i3c: master: use i3c_master_register only for main master

2020-05-31 Thread Parshuram Thombare
Removed last argument 'secondary' and restructured i3c_master_register to move code that can be common to i3c_secondary_master_register to separate function i3c_master_init. Signed-off-by: Parshuram Thombare --- drivers/i3c/master.c | 74 +--- drivers/i3c/

[PATCH v8 3/7] i3c: master: add i3c_secondary_master_register

2020-05-31 Thread Parshuram Thombare
add i3c_secondary_master_register which is used to register secondary masters. Signed-off-by: Parshuram Thombare --- drivers/i3c/master.c | 154 - include/linux/i3c/master.h | 3 + 2 files changed, 156 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v8 4/7] i3c: master: add mastership handover support

2020-05-31 Thread Parshuram Thombare
Added mastership acquire and yield functions. Signed-off-by: Parshuram Thombare --- drivers/i3c/master.c | 176 +++-- include/linux/i3c/master.h | 6 ++ 2 files changed, 173 insertions(+), 9 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/mas

[PATCH v8 5/7] i3c: master: add defslvs processing

2020-05-31 Thread Parshuram Thombare
Added defslvs processing code to the I3C master subsystem. Signed-off-by: Parshuram Thombare --- drivers/i3c/master.c | 68 -- include/linux/i3c/master.h | 7 2 files changed, 73 insertions(+), 2 deletions(-) diff --git a/drivers/i3c/master.c b/dr

[PATCH v8 6/7] i3c: master: sysfs key for acquire bus

2020-05-31 Thread Parshuram Thombare
Added support to acquire I3C bus through sysfs interface. Signed-off-by: Parshuram Thombare --- drivers/i3c/master.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index de3cb39df9ff..17c0c9a6099d 100644 --- a/drivers/i3c/maste

[PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*()

2020-05-31 Thread Souptick Joarder
In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages": https://lwn.net/Articles/807108/

[PATCH v8 7/7] i3c: master: mastership handover, defslvs processing in cdns controller driver

2020-05-31 Thread Parshuram Thombare
Added I3C bus mastership handover and DEFSLVS message handling code to Cadence's I3C master controller driver. Signed-off-by: Parshuram Thombare --- drivers/i3c/master/i3c-master-cdns.c | 329 +-- 1 file changed, 306 insertions(+), 23 deletions(-) diff --git a/drivers/i3

Re: Re: [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable()

2020-05-31 Thread dinghao . liu
Hi, Markus, > * How do you think about to replace the word “pairing” by “corresponding”? > > * Will it be helpful to add an imperative wording? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ffeb595d84811dde16a28b33

Re: [PATCH] iommu/amd: Fix event counter availability check

2020-05-31 Thread Alexander Monakov
Hi, Adding Shuah Khan to Cc: I've noticed you've seen this issue on Ryzen 2400GE; can you have a look at the patch? Would be nice to know if it fixes the problem for you too. Thanks. Alexander On Fri, 29 May 2020, Alexander Monakov wrote: > The driver performs an extra check if the IOMMU's capa

Red Hat Enterprise Linux 8 on Supercomputer Fugaku

2020-05-31 Thread Ishida Takashi
Hello everyone, Outline of the Development of the Supercomputer Fugaku > OS Red Hat Enterprise Linux 8 ON Supercomputer Fugaku https://www.r-ccs.riken.jp/en/overview/aboutus https://www.r-ccs.riken.jp/en/ https://www.r-ccs.riken.jp/en/postk/project/outline Programming Language and Library Co

[PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-05-31 Thread Christophe JAILLET
Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in 'pxa2xx_pinctrl_init()'. However, the corresponding 'pinctrl_unregister()' call in 'pxa2xx_pinctrl_exit()' has not been removed. This is n

[PATCH] bloat-o-meter: Support comparing library archives

2020-05-31 Thread Nikolay Borisov
Library archives (.a) usually contain multiple object files so their output of nm --size-sort contains lines like: 03a8 t run_test extent-map-tests.o: bloat-o-meter currently doesn't handle them which results in errors when calling .split() on them. Fix this by simply ignoring them

Re: [GIT PULL] sh: remove sh5 support

2020-05-31 Thread John Paul Adrian Glaubitz
On 5/31/20 5:20 AM, Rob Landley wrote: > On 5/30/20 3:08 AM, John Paul Adrian Glaubitz wrote: >> On 5/29/20 7:53 PM, Rich Felker wrote: >>> Frustratingly, I _still_ don't have an official tree on kernel.org for >>> the purpose of being the canonical place for linux-next to pull from, >>> due to pol

Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread Markus Elfring
> When gk20a_clk_ctor() returns an error code, pointer "clk" > should be released. Such an information is reasonable. > It's the same when gm20b_clk_new() returns from elsewhere following this call. I suggest to reconsider the interpretation of the software situation once more. Can it be that t

Re: [PATCH] drm/qxl: Replace deprecated function in qxl_display

2020-05-31 Thread Sidong Yang
On Sun, May 24, 2020 at 07:42:25AM +1000, David Airlie wrote: > On Sun, May 24, 2020 at 2:02 AM Sidong Yang wrote: > > > > Hi, Dave. > > > > I'm a newbie kernel developer interested in qxl driver. And I want to > > participate in > > contributing for QXL module. > > I wrote some simple patch for

Re: Re: [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread dinghao . liu
> > > It's the same when gm20b_clk_new() returns from elsewhere following this > > call. > > I suggest to reconsider the interpretation of the software situation once > more. > Can it be that the allocated clock object should be kept usable even after > a successful return from this function? >

I.T. X : *nix + Direct 3D is the next Amiga.

2020-05-31 Thread Ywe Cærlyn
With the event of Direct 3D coming to *nix, something I really asked about with this aswell, and really goes back to 3.D. Scene ventures in 9x, https://www.youtube.com/watch?v=IsW-YO0REVc Everything is readied on this chan, with the 3.D. Scene background! *nix + Direct 3D is the next Amiga! S

Re: The invitation need your response

2020-05-31 Thread Olusegun Ebrima
Greetings, With due respect to your personality and much sincerity of this purpose, I make this contact with you believing that you can be of great assistance to me. I'm Mr. Olusegun Ebrima, from Burkina Faso, I'm the Chairman of FOREIGN PAYMENTS CONTRACT AWARD COMMITTEE and also I currently hold

Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread Markus Elfring
> It's possible that we expect an usable clk pointer, though I could not find > the exact usage yet. I am curious if another developer would like to add helpful background information. > For security, I will release this pointer only on error paths in this > function. Do you tend to release o

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-05-31 Thread Geert Uytterhoeven
Hi Finn, On Sun, May 31, 2020 at 1:20 AM Finn Thain wrote: > The adb_driver.autopoll method is needed during ADB bus scan and device > address assignment. Implement this method so that the IOP's list of > device addresses can be updated. When the list is empty, disable SRQ > autopolling. > > Cc:

Re: [PATCH 0/4] Mac IOP driver fixes

2020-05-31 Thread Geert Uytterhoeven
Hi Finn, On Sun, May 31, 2020 at 1:16 AM Finn Thain wrote: > This patch series has several bug fixes for the IOP driver and some > improvements to the debug level log messages. Thanks for your series! > Geert, please consider pushing these fixes for v5.8, if not the > whole series. I'm afraid

[PATCH] kbuild: force to build vmlinux if CONFIG_MODVERSION=y

2020-05-31 Thread Masahiro Yamada
This code does not work as stated in the comment. $(CONFIG_MODVERSIONS) is always empty because it is expanded before include/config/auto.conf is included. Hence, 'make modules' with CONFIG_MODVERSION=y cannot record the version CRCs. This has been broken since 2003, commit ("kbuild: Enable modul

Re: Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread dinghao . liu
> > > For security, I will release this pointer only on error paths in this > > function. > > Do you tend to release objects (which are referenced by pointers)? > I just found that clk is referenced by pclk in this function. When clk is freed, pclk will be allocated in gm20b_clk_new_speedo0(

Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread Markus Elfring
> I just found that clk is referenced by pclk in this function. When clk is > freed, > pclk will be allocated in gm20b_clk_new_speedo0(). Thus we should not release > clk > in this function and there is no bug here. Can there be a need to release a clock object after a failed gk20a_clk_ctor() c

Re: [PATCH] staging: gasket: Convert get_user_pages*() --> pin_user_pages*()

2020-05-31 Thread Dan Carpenter
On Sun, May 31, 2020 at 12:53:11PM +0530, Souptick Joarder wrote: > In 2019, we introduced pin_user_pages*() and now we are converting > get_user_pages*() to the new API as appropriate. [1] & [2] could > be referred for more information. > > [1] Documentation/core-api/pin_user_pages.rst > > [2] "

Re: [PATCH] nvme-tcp: constify static struct blk_mq_ops

2020-05-31 Thread Max Gurtovoy
Looks good, Reviewed-by: Max Gurtovoy

Re: [PATCH RFC] KVM: arm64: Sidestep stage2_unmap_vm() on vcpu reset when S2FWB is supported

2020-05-31 Thread Alexandru Elisei
Hi Marc, On 5/30/20 5:31 PM, Marc Zyngier wrote: > Hi Alex, > > On 2020-05-30 11:46, Alexandru Elisei wrote: >> Hi, > > [...] > diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 48d0ec44ad77..e6378162cdef 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@

Re: Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread dinghao . liu
> > I just found that clk is referenced by pclk in this function. When clk is > > freed, > > pclk will be allocated in gm20b_clk_new_speedo0(). Thus we should not > > release clk > > in this function and there is no bug here. > > Can there be a need to release a clock object after a failed gk20a

Re: [PATCH 5.6 086/126] virtio-balloon: Revert "virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM"

2020-05-31 Thread Michael S. Tsirkin
On Tue, May 26, 2020 at 08:53:43PM +0200, Greg Kroah-Hartman wrote: > From: Michael S. Tsirkin > > [ Upstream commit 835a6a649d0dd1b1f46759eb60fff2f63ed253a7 ] > > This reverts commit 5a6b4cc5b7a1892a8d7f63d6cbac6e0ae2a9d031. > > It has been queued properly in the akpm tree, this version is jus

[PATCH] habanalabs: correctly cast u64 to void*

2020-05-31 Thread Oded Gabbay
Use the u64_to_user_ptr(x) kernel macro to correctly cast u64 to void* Reported-by: kbuild test robot Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/command_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/command_submission.c b/d

Re: [PATCH v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()

2020-05-31 Thread Michael S. Tsirkin
On Tue, May 26, 2020 at 02:11:37PM +, Sasha Levin wrote: > <20200123101000.GB24255@Red> > References: <20200526031956.1897-3-longpe...@huawei.com> > <20200123101000.GB24255@Red> > > Hi > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag > fi

[PATCH 3/4 v4] exfat: add boot region verification

2020-05-31 Thread Tetsuhiro Kohada
Add Boot-Regions verification specified in exFAT specification. Note that the checksum type is strongly related to the raw structure, so the'u32 'type is used to clarify the number of bits. Signed-off-by: Tetsuhiro Kohada --- Changes in v2: - rebase with patch 'optimize dir-cache' applied - jus

Re: PANIC: double fault in fixup_bad_iret

2020-05-31 Thread Dmitry Vyukov
On Fri, May 29, 2020 at 7:11 PM Peter Zijlstra wrote: > > Like with KCSAN, we should blanket kill KASAN/UBSAN and friends (at the > > very least in arch/x86/) until they get that function attribute stuff > > sorted. > > Something like so. > > --- > diff --git a/arch/x86/Makefile b/arch/x86/Makefil

Re: arm64: Register modification during syscall entry/exit stop

2020-05-31 Thread Will Deacon
On Wed, May 27, 2020 at 11:19:29AM +0100, Dave Martin wrote: > On Wed, May 27, 2020 at 10:55:29AM +0100, Will Deacon wrote: > > On Sun, May 24, 2020 at 02:56:35AM -0400, Keno Fischer wrote: > > > Just ran into this issue again, with what I think may be most compelling > > > example yet why this is

Re: [PATCH v6 3/6] irqchip: RISC-V per-HART local interrupt controller driver

2020-05-31 Thread Marc Zyngier
On 2020-05-31 06:36, Anup Patel wrote: On Sat, May 30, 2020 at 5:31 PM Marc Zyngier wrote: [...] > plic_set_threshold(handler, PLIC_DISABLE_THRESHOLD); Why do you need to both disable the interrupt *and* change the priority threshold? It seems to be that one of them should be enough

[PATCH] ARM: riscpc: mark a function as __init to save some memory

2020-05-31 Thread Christophe JAILLET
'ecard_bus_init()' is only called via 'postcore_initcall'. It can be marked as __init to save a few bytes of memory. Signed-off-by: Christophe JAILLET --- arch/arm/mach-rpc/ecard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/e

[PATCH 1/2] media: atomisp: get rid of a left-over wrapper function

2020-05-31 Thread Mauro Carvalho Chehab
The abstraction layer for kvfree() was removed, but there is still a left-over code there. Reported-by: kbuild test robot Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/sh_css.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/media/atomisp/

[PATCH 2/2] media: atomisp comment an unused code

2020-05-31 Thread Mauro Carvalho Chehab
There's a different table for some BYT variants that depend on something inside a FIXME ifdef. Place this also inside it, just to shut up a clang-11 warning. Reported-by: kbuild test robot Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 8 1

Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread Markus Elfring
> If gk20a_clk_ctor() never returns such an error code, > we may need not to release this clock object. Would you like to achieve complete exception handling also for this function implementation? Regards, Markus

[PATCH] ARM: smp_twd: mark a function as __init to save some memory

2020-05-31 Thread Christophe JAILLET
'twd_clk_init()' is only called via 'core_initcall'. It can be marked as __init to save a few bytes of memory. Signed-off-by: Christophe JAILLET --- For the records, this function has been introduced in commit 4fd7f9b12810 ("ARM: 7212/1: smp_twd: reconfigure clockevents after cpufreq change") ---

Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread Geert Uytterhoeven
Hi Adrian, On Fri, May 29, 2020 at 7:46 PM John Paul Adrian Glaubitz wrote: > Trying to build the kernel with CONFIG_INFINIBAND_USER_ACCESS enabled fails > > ERROR: "__get_user_unknown" [drivers/infiniband/core/ib_uverbs.ko] > undefined! > > with on SH since the kernel misses a 64-bit imple

[PATCH v4] regmap: fix alignment issue

2020-05-31 Thread Jens Thoms Toerring
The assembly and disassembly of data to be sent to or received from a device invoke functions regmap_format_XX() and regmap_parse_XX() that extract or insert data items from or into a buffer, using assignments. In some cases the functions are called with a buffer pointer with an odd address. On arc

Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread John Paul Adrian Glaubitz
Hi Geert! On 5/31/20 11:52 AM, Geert Uytterhoeven wrote: > As this is the 64-bit variant, I think this single move should be > replaced by a double move: > >"mov #0,%R1\n\t" \ >"mov #0,%S1\n\t" \ > > Same for the big endian version below. > > Disclaimer: uncompiled, untested,

Re: [PATCH net-next] mlx5: Restore err assignment in mlx5_mdev_init

2020-05-31 Thread Leon Romanovsky
On Fri, May 29, 2020 at 10:54:48PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/ethernet/mellanox/mlx5/core/main.c:1278:6: warning: variable > 'err' is used uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > if (!priv->dbg_root) { > ^

Re: [PATCH v2 1/4] iio: chemical: scd30: add core driver

2020-05-31 Thread Jonathan Cameron
On Sat, 30 May 2020 23:36:27 +0200 Tomasz Duszynski wrote: > Add Sensirion SCD30 carbon dioxide core driver. > > Signed-off-by: Tomasz Duszynski Hi Tomasz A few things inline. Includes the alignment issue on x86_32 that I fell into whilst trying to fix timestamp alignment issues. Suggested

[PATCH] RISC-V: Don't mark init section as non-executable

2020-05-31 Thread Anup Patel
The head text section (i.e. _start, secondary_start_sbi, etc) and the init section fall under same page table level-1 mapping. Currently, the runtime CPU hotplug is broken because we are marking init section as non-executable which in-turn marks head text section as non-executable. Further invest

Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread John Paul Adrian Glaubitz
On 5/31/20 11:54 AM, John Paul Adrian Glaubitz wrote: > Hi Geert! > > On 5/31/20 11:52 AM, Geert Uytterhoeven wrote: >> As this is the 64-bit variant, I think this single move should be >> replaced by a double move: >> >>"mov #0,%R1\n\t" \ >>"mov #0,%S1\n\t" \ >> >> Same for the

Re: [PATCH v2 2/4] iio: chemical: scd30: add I2C interface driver

2020-05-31 Thread Jonathan Cameron
On Sat, 30 May 2020 23:36:28 +0200 Tomasz Duszynski wrote: > Add I2C interface driver for the SCD30 sensor. > > Signed-off-by: Tomasz Duszynski Looks good to me. J > --- > MAINTAINERS | 1 + > drivers/iio/chemical/Kconfig | 11 +++ > drivers/iio/chemical/Makefile

[PATCH] MIPS: ralink: bootrom: mark a function as __init to save some memory

2020-05-31 Thread Christophe JAILLET
'bootrom_setup()' is only called via 'postcore_initcall'. It can be marked as __init to save a few bytes of memory. Signed-off-by: Christophe JAILLET --- arch/mips/ralink/bootrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/ralink/bootrom.c b/arch/mips/ralink/b

Re: [PATCH v6 3/6] irqchip: RISC-V per-HART local interrupt controller driver

2020-05-31 Thread Anup Patel
On Sun, May 31, 2020 at 3:03 PM Marc Zyngier wrote: > > On 2020-05-31 06:36, Anup Patel wrote: > > On Sat, May 30, 2020 at 5:31 PM Marc Zyngier wrote: > > [...] > > >> > plic_set_threshold(handler, PLIC_DISABLE_THRESHOLD); > >> > >> Why do you need to both disable the interrupt *and* change

[PATCH] kbuild: merge two 'ifdef CONFIG_TRIM_UNUSED_KSYMS' blocks

2020-05-31 Thread Masahiro Yamada
This hunk has two 'ifdef CONFIG_TRIM_UNUSED_KSYMS ... endif' blocks with no other code interleaved. Merge them. Signed-off-by: Masahiro Yamada --- Makefile | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index b856f84e28c9..44921d9cf3cf 10064

RE: [PATCH] habanalabs: correctly cast u64 to void*

2020-05-31 Thread Omer Shpigelman
On Sun, May 31, 2020 at 12:16 PM, Oded Gabbay wrote: > Use the u64_to_user_ptr(x) kernel macro to correctly cast u64 to void* > > Reported-by: kbuild test robot > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

Re: [PATCH v2 3/4] iio: chemical: scd30: add serial interface driver

2020-05-31 Thread Jonathan Cameron
On Sat, 30 May 2020 23:36:29 +0200 Tomasz Duszynski wrote: > Add serial interface driver for the SCD30 sensor. > > Signed-off-by: Tomasz Duszynski Ah Now I see why you had those extra elements in the iio_priv structure. Hmm. serdev_device callbacks using the top level device drvdata is a bit

Re: [PATCH v2 1/4] iio: chemical: scd30: add core driver

2020-05-31 Thread Jonathan Cameron
On Sun, 31 May 2020 10:58:40 +0100 Jonathan Cameron wrote: > On Sat, 30 May 2020 23:36:27 +0200 > Tomasz Duszynski wrote: > > > Add Sensirion SCD30 carbon dioxide core driver. > > > > Signed-off-by: Tomasz Duszynski > > Hi Tomasz > > A few things inline. Includes the alignment issue on

Re: [PATCH v2 4/4] dt-bindings: iio: scd30: add device binding file

2020-05-31 Thread Jonathan Cameron
On Sat, 30 May 2020 23:36:30 +0200 Tomasz Duszynski wrote: > Add SCD30 sensor binding file. > > Signed-off-by: Tomasz Duszynski > --- > .../iio/chemical/sensirion,scd30.yaml | 68 +++ > MAINTAINERS | 1 + > 2 files changed, 69 insertio

Re: [PATCH] iio: accel: mxc4005: add support for mxc6655

2020-05-31 Thread Jonathan Cameron
On Fri, 29 May 2020 22:05:49 +0200 Christian Oder wrote: > The mxc6655 is fully working with the existing mxc4005 driver. > Add support for it. > > Signed-off-by: Christian Oder One query on ACPI bindings. What is there already may be missleading :( > --- > drivers/iio/accel/mxc4005.c | 2

5.7-rc0: kswapd eats cpu during a disk test?!

2020-05-31 Thread Pavel Machek
Hi! This is simple cat /dev/sda > /dev/zero... on thinkpad x60 (x86-32), with spinning rust. PID USER PR NIVIRTRESSHR S %CPU %MEM TIME+ COMMAND 1000 root 20 0 0 0 0 R 53.3 0.0 57:34.93 kswapd0 27897 root 20 06976580536 R

Re: [PATCH V6 1/7] iio: adc: Convert the QCOM SPMI ADC bindings to .yaml format

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:23 +0530 Jishnu Prakash wrote: > Convert the adc bindings from .txt to .yaml format. > > Signed-off-by: Jishnu Prakash > Reviewed-by: Amit Kucheria > Reviewed-by: Rob Herring > Acked-by: Linus Walleij Jishnu, Patch is fine, but I'd like to have seen a cover letter

Re: Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

2020-05-31 Thread dinghao . liu
> > If gk20a_clk_ctor() never returns such an error code, > > we may need not to release this clock object. > > Would you like to achieve complete exception handling > also for this function implementation? > It seems that it's possible to get -ENOMEM from gk20a_clk_ctor(). The call chain is as

Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread Geert Uytterhoeven
Hi Adrian, On Sun, May 31, 2020 at 11:59 AM John Paul Adrian Glaubitz wrote: > On 5/31/20 11:54 AM, John Paul Adrian Glaubitz wrote: > > On 5/31/20 11:52 AM, Geert Uytterhoeven wrote: > >> As this is the 64-bit variant, I think this single move should be > >> replaced by a double move: > >> > >>

Re: [PATCH V6 1/7] iio: adc: Convert the QCOM SPMI ADC bindings to .yaml format

2020-05-31 Thread Jonathan Cameron
On Sun, 31 May 2020 11:36:12 +0100 Jonathan Cameron wrote: > On Thu, 28 May 2020 22:24:23 +0530 > Jishnu Prakash wrote: > > > Convert the adc bindings from .txt to .yaml format. > > > > Signed-off-by: Jishnu Prakash > > Reviewed-by: Amit Kucheria > > Reviewed-by: Rob Herring > > Acked-by: L

Re: [PATCH V6 2/7] iio: adc: Add PMIC7 ADC bindings

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:24 +0530 Jishnu Prakash wrote: > Add documentation for PMIC7 ADC peripheral. > For the PMIC7-type PMICs, ADC peripheral is present in HW for the > following PMICs: PMK8350, PM8350, PM8350b, PMR735a and PMR735b. > Of these, only the ADC peripheral on PMK8350 is exposed di

Re: [PATCH V6 4/7] iio: adc: Add support for PMIC7 ADC

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:26 +0530 Jishnu Prakash wrote: > The ADC architecture on PMIC7 is changed as compared to PMIC5. The > major change from PMIC5 is that all SW communication to ADC goes through > PMK8350, which communicates with other PMICs through PBS when the ADC > on PMK8350 works in ma

Re: [PATCH V6 3/7] iio: adc: Add info property under adc_data

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:25 +0530 Jishnu Prakash wrote: > Add info property under adc_data to support adding ADC variants > which may use different iio_info than the one defined for PMIC5. > > Signed-off-by: Jishnu Prakash Applied. Thanks, Jonathan > --- > drivers/iio/adc/qcom-spmi-adc5.c

Re: [PATCH V6 5/7] iio: adc: Update return value checks

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:27 +0530 Jishnu Prakash wrote: > Clean up some return value checks to make code more compact. > > Signed-off-by: Jishnu Prakash Applied. Thanks, J > --- > drivers/iio/adc/qcom-spmi-adc5.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff

[PATCH v2] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread John Paul Adrian Glaubitz
Trying to build the kernel with CONFIG_INFINIBAND_USER_ACCESS enabled fails ERROR: "__get_user_unknown" [drivers/infiniband/core/ib_uverbs.ko] undefined! with on SH since the kernel misses a 64-bit implementation of get_user(). Implement the missing 64-bit get_user() as __get_user_u64(), m

Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

2020-05-31 Thread John Paul Adrian Glaubitz
Hi Geert! Thanks a lot for the explanation! On 5/31/20 12:43 PM, Geert Uytterhoeven wrote: >> Hmm, this change is not the case for __put_user_asm() vs. __put_user_u64(). >> But I have to admit, I don't know what the part below "3:\n\t" is for. > > It's part of the exception handling, in case the

Re: [PATCH V6 7/7] iio: adc: Add a common read function for PMIC5 and PMIC7

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:29 +0530 Jishnu Prakash wrote: > Add a common function used for read_raw callback for both PMIC5 > and PMIC7 ADCs. > > Signed-off-by: Jishnu Prakash Hmm. I'm not completely sold on this one. Suggestions below. Jonathan > --- > drivers/iio/adc/qcom-spmi-adc5.c |

Re: [PATCH V6 6/7] iio: adc: Update debug prints

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 22:24:28 +0530 Jishnu Prakash wrote: > Change pr_err/pr_debug statements to dev_err/dev_dbg for > increased clarity. > > Signed-off-by: Jishnu Prakash > Reviewed-by: Andy Shevchenko Applied. Thanks, J > --- > drivers/iio/adc/qcom-spmi-adc5.c | 18 +- > 1 f

Re: [PATCH v6 3/6] irqchip: RISC-V per-HART local interrupt controller driver

2020-05-31 Thread Marc Zyngier
On 2020-05-31 11:06, Anup Patel wrote: On Sun, May 31, 2020 at 3:03 PM Marc Zyngier wrote: On 2020-05-31 06:36, Anup Patel wrote: > On Sat, May 30, 2020 at 5:31 PM Marc Zyngier wrote: [...] >> > plic_set_threshold(handler, PLIC_DISABLE_THRESHOLD); >> >> Why do you need to both disable

[PATCH] arm64: debug: mark a function as __init to save some memory

2020-05-31 Thread Christophe JAILLET
'debug_monitors_init()' is only called via 'postcore_initcall'. It can be marked as __init to save a few bytes of memory. Signed-off-by: Christophe JAILLET --- arch/arm64/kernel/debug-monitors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/debug-monitors.

Re: [PATCH v7 1/4] bitops: Introduce the the for_each_set_clump macro

2020-05-31 Thread Andy Shevchenko
On Sun, May 31, 2020 at 4:11 AM Syed Nayyar Waris wrote: > On Sat, May 30, 2020 at 2:50 PM Andy Shevchenko > wrote: > > On Sat, May 30, 2020 at 11:45 AM Syed Nayyar Waris > > wrote: > > > On Sat, May 30, 2020 at 3:49 AM Andy Shevchenko > > > wrote: ... > #if (l) == 0 > #define GENMASK_INPUT_

Re: [PATCH v7 3/5] dt-bindings: iio: magnetometer: ak8975: add gpio reset support

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 16:59:28 +0200 Jonathan Albrieux wrote: > Add reset-gpio support. > > Without reset's deassertion during ak8975_power_on(), driver's probe fails > on ak8975_who_i_am() while checking for device identity for AK09911 chip. > > AK09911 has an active low reset gpio to handle reg

[PATCH] staging:rtl8712: avoid skb_clone after skb allocation fail

2020-05-31 Thread Ivan Safonov
The skb allocated when out of memory is likely to be discarded during subsequent processing. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8712/rtl8712_recv.c | 29 ++ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_rec

Re: [PATCH v7 4/5] iio: magnetometer: ak8975: Fix typo, uniform measurement unit style

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 17:00:17 +0200 Jonathan Albrieux wrote: > Minor comment style edits. > > Signed-off-by: Jonathan Albrieux > Reviewed-by: Andy Shevchenko Applied > --- > drivers/iio/magnetometer/ak8975.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers

Re: [PATCH v7 5/5] iio: magnetometer: ak8975: Add gpio reset support

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 17:01:05 +0200 Jonathan Albrieux wrote: > According to AK09911 datasheet, if reset gpio is provided then > deassert reset on ak8975_power_on() and assert reset on ak8975_power_off(). > > Without reset's deassertion during ak8975_power_on(), driver's probe fails > on ak8975_wh

[PATCH] arm: allwinner: a20: Add Drejo DS167 initial support

2020-05-31 Thread stulluk
From: Sertac TULLUK Drejo DS167 is an Allwinner A20 based IoT device, which support - Allwinner A20 Cortex-A7 - Mali-400MP2 GPU - AXP209 PMIC - 1GB DDR3 RAM - 8GB eMMC - 10/100M Ethernet - SATA - HDMI - 10.1inch and 7.0inch LVDS LCD and Touch screens - CSI: OV5640 sensor - USB OTG - 2x USB2.0 - b

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-31 Thread Marc Zyngier
On 2020-05-30 17:49, Marc Zyngier wrote: Hi Ali, On Fri, 29 May 2020 12:36:42 + "Saidi, Ali" wrote: Hi Marc, > On May 29, 2020, at 3:33 AM, Marc Zyngier wrote: > > Hi Ali, > >> On 2020-05-29 02:55, Ali Saidi wrote: >> If an interrupt is disabled the ITS driver has sent a discard removin

[tip:x86/entry 2/19] include/xen/interface/hvm/hvm_op.h:33:28: error: a parameter list without types is only allowed in a function definition

2020-05-31 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/entry head: 5980d208e5ef28455e9e8b08f6250b443a2f0893 commit: 28447ea4154239025044381144f849ff749ee9ef [2/19] xen: Move xen_setup_callback_vector() definition to include/xen/hvm.h config: x86_64-randconfig-r036-20200531

Re: [PATCH v2] iio: mma8452: Add missed iio_device_unregister() call in mma8452_probe()

2020-05-31 Thread Jonathan Cameron
On Thu, 28 May 2020 14:41:21 +0800 Chuhong Yuan wrote: > The function iio_device_register() was called in mma8452_probe(). > But the function iio_device_unregister() was not called after > a call of the function mma8452_set_freefall_mode() failed. > Thus add the missed function call for one error

Re: [PATCH v2 01/12] iio: imu: inv_icm42600: add core of new inv_icm42600 driver

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:00 +0200 Jean-Baptiste Maneyrol wrote: > Core component of a new driver for InvenSense ICM-426xx devices. > It includes registers definition, main probe/setup, and device > utility functions. > > ICM-426xx devices are latest generation of 6-axis IMU, > gyroscope+acceler

Re: [PATCH 5.6 086/126] virtio-balloon: Revert "virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM"

2020-05-31 Thread Greg Kroah-Hartman
On Sun, May 31, 2020 at 05:18:06AM -0400, Michael S. Tsirkin wrote: > On Tue, May 26, 2020 at 08:53:43PM +0200, Greg Kroah-Hartman wrote: > > From: Michael S. Tsirkin > > > > [ Upstream commit 835a6a649d0dd1b1f46759eb60fff2f63ed253a7 ] > > > > This reverts commit 5a6b4cc5b7a1892a8d7f63d6cbac6e0a

Re: [PATCH v2 02/12] iio: imu: inv_icm42600: add I2C driver for inv_icm42600 driver

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:01 +0200 Jean-Baptiste Maneyrol wrote: > Add I2C driver for InvenSense ICM-426xxx devices. > > Configure bus signal slew rates as indicated in the datasheet. > > Signed-off-by: Jean-Baptiste Maneyrol Looks fine to me. J > --- > .../iio/imu/inv_icm42600/inv_icm4260

[PATCH v3 1/4] seccomp: rename "usage" to "refs" and document

2020-05-31 Thread Christian Brauner
Naming the lifetime counter of a seccomp filter "usage" suggests a little too strongly that its about tasks that are using this filter while it also tracks other references such as the user notifier or ptrace. This also updates the documentation to note this fact. We'll be introducing an actual us

[PATCH v3 4/4] tests: test seccomp filter notifications

2020-05-31 Thread Christian Brauner
This verifies we're correctly notified when a seccomp filter becomes unused when a notifier is in use. Signed-off-by: Christian Brauner --- /* v2 */ unchanged /* v3 */ At first it seemed sensible to add POLLHUP to all poll invocations but all checks test for revents to be equal to POLLIN. Hence,

[PATCH v3 2/4] seccomp: release filter after task is fully dead

2020-05-31 Thread Christian Brauner
The seccomp filter used to be released in free_task() which is called asynchronously via call_rcu() and assorted mechanisms. Since we need to inform tasks waiting on the seccomp notifier when a filter goes empty we will notify them as soon as a task has been marked fully dead in release_task(). To

[PATCH v3 3/4] seccomp: notify about unused filter

2020-05-31 Thread Christian Brauner
We've been making heavy use of the seccomp notifier to intercept and handle certain syscalls for containers. This patch allows a syscall supervisor listening on a given notifier to be notified when a seccomp filter has become unused. A container is often managed by a singleton supervisor process t

Re: [PATCH v2 04/12] iio: imu: inv_icm42600: add gyroscope IIO device

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:03 +0200 Jean-Baptiste Maneyrol wrote: > Add IIO device for gyroscope sensor with data polling interface. > Attributes: raw, scale, sampling_frequency, calibbias. > > Gyroscope in low noise mode. > > Signed-off-by: Jean-Baptiste Maneyrol Unusual to have a calibration

Re: drm/nouveau/clk/gm20b: Fix memory leaks after failed gk20a_clk_ctor() calls

2020-05-31 Thread Markus Elfring
> In this case, maybe we should check the return value of > gk20a_clk_ctor() and release clk if it returns -ENOMEM. All error situations (including failed memory allocations) can matter here. > And many other functions also have the same issue > (e.g. gm20b_clk_new_speedo0). I recommend to incr

Re: [PATCH v2 08/12] iio: imu: inv_icm42600: add device interrupt

2020-05-31 Thread Jonathan Cameron
On Wed, 27 May 2020 20:57:07 +0200 Jean-Baptiste Maneyrol wrote: > Add INT1 interrupt support. Support interrupt edge and level, > active high or low. Push-pull or open-drain configurations. > > Interrupt will be used to read data from the FIFO. > > Signed-off-by: Jean-Baptiste Maneyrol Some

Re: next-20200515: Xorg killed due to "OOM"

2020-05-31 Thread Pavel Machek
On Thu 2020-05-28 14:07:50, Michal Hocko wrote: > On Thu 28-05-20 14:03:54, Pavel Machek wrote: > > On Thu 2020-05-28 11:05:17, Michal Hocko wrote: > > > On Tue 26-05-20 11:10:54, Pavel Machek wrote: > > > [...] > > > > [38617.276517] oom_reaper: reaped process 31769 (chromium), now > > > > anon-r

Re: [PATCH 0/3] perf test: Unwind fixes

2020-05-31 Thread Arnaldo Carvalho de Melo
Em Sat, May 30, 2020 at 01:20:12AM -0700, Ian Rogers escreveu: > Fix stack frame count and memory sanitizer issues when running the > dwarf unwinding test with the elfutils/libdw unwinder (libunwind > disabled). Thanks, applied. > Ian Rogers (3): > tools compiler.h: Add attribute to disable ta

Re: [PATCH v8 0/3] perf arm-spe: Add support for synthetic events

2020-05-31 Thread Arnaldo Carvalho de Melo
Em Sat, May 30, 2020 at 08:24:39PM +0800, Leo Yan escreveu: > This patch set is to support synthetic events with enabling Arm SPE > decoder. This patch set is based Xiaojun Tan (Hisilicon) and > James Clark (Arm)'s previous patches who have contributed much for > the related task. Applied, will p

  1   2   3   4   5   6   >