Re: [PATCH] platform/x86: Add new intel_atomisp2_led driver

2020-05-30 Thread Andy Shevchenko
On Sat, May 9, 2020 at 4:07 PM Hans de Goede wrote: > > Many Bay Trail and Cherry Trail devices come with a camera attached to > Intel's Image Signal Processor. Linux currently does not have a driver for > these, so they do not work as a camera. > > Some of these camera's have a status LED which i

[PATCH v1 1/2] scsi: ufs: Support WriteBooster on Samsung UFS devices

2020-05-30 Thread Stanley Chu
Samsung UFS devices are widely used in the market, however these devices need some special handling to support WriteBooster. The major part is that Samsung UFS devices need to use specific "selector" value for WriteBooster related query operations. Therefore, introduce a device quirk to handle the

[PATCH v1 0/2] scsi: ufs: Support WriteBooster on Samsung UFS devices

2020-05-30 Thread Stanley Chu
Hi, Samsung UFS devices are widely used in the market, however these devices need some special handling to support WriteBooster. Introduce a device quirk to handle this special requirement. Currently Bean Huo is doing some nice cleanup work for device descriptor length so our series will have m

[PATCH v1 2/2] scsi: ufs-mediatek: Support WriteBooster on Samsung UFS devices

2020-05-30 Thread Stanley Chu
Add device quirk "UFS_DEVICE_QUIRK_WB_USING_SPECIAL_SELECTOR" on all Samsung UFS devices to enable WriteBooster on those devices. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufs-mediatek.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/u

Re: [PATCH 02/14] x86/hw_breakpoint: Prevent data breakpoints on direct GDT

2020-05-30 Thread Lai Jiangshan
On Sat, May 30, 2020 at 8:48 PM Andrew Cooper wrote: > > On 29/05/2020 22:27, Peter Zijlstra wrote: > > From: Lai Jiangshan > > > > A data breakpoint on the GDT is terrifying and should be avoided. > > The GDT on CPU entry area is already protected. The direct GDT > > should be also protected, al

Re: [PATCH] Revert "f2fs: fix quota_sync failure due to f2fs_lock_op"

2020-05-30 Thread Jaegeuk Kim
On 05/30, Chao Yu wrote: > On 2020/5/30 9:49, Jaegeuk Kim wrote: > > On 05/30, Chao Yu wrote: > >> On 2020/5/30 6:34, Jaegeuk Kim wrote: > >>> On 05/29, Chao Yu wrote: > Under heavy fsstress, we may triggle panic while issuing discard, > because __check_sit_bitmap() detects that discard c

Re: [PATCH] media: pci: ttpci: av7110: Fix possible buffer overflow in debiirq()

2020-05-30 Thread Markus Elfring
> To fix this possible bug, data[0] is assigned to a local variable, which > replaces the use of data[0]. How do you think about a wording variant like the following? Thus assign the first element of the data array to a local variable so that it can be used as an array index together with the

Re: [PATCH] platform/x86: Add new intel_atomisp2_led driver

2020-05-30 Thread Hans de Goede
Hi, On 5/30/20 4:56 PM, Andy Shevchenko wrote: On Sat, May 9, 2020 at 4:07 PM Hans de Goede wrote: Many Bay Trail and Cherry Trail devices come with a camera attached to Intel's Image Signal Processor. Linux currently does not have a driver for these, so they do not work as a camera. Some of

Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-05-30 Thread Ido Schimmel
On Thu, May 28, 2020 at 06:12:40PM +0300, Vadym Kochan wrote: > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely > wireless SMB deployment. > > The current implementation supports only boards designed for the Ma

Re: [PATCH] platform/x86: Add new intel_atomisp2_led driver

2020-05-30 Thread Andy Shevchenko
On Sat, May 9, 2020 at 4:07 PM Hans de Goede wrote: > > Many Bay Trail and Cherry Trail devices come with a camera attached to > Intel's Image Signal Processor. Linux currently does not have a driver for > these, so they do not work as a camera. > > Some of these camera's have a status LED which i

Re: [net-next 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x)

2020-05-30 Thread Ido Schimmel
On Sat, May 30, 2020 at 05:52:31PM +0300, Vadym Kochan wrote: > Hi Ido, > > On Sat, May 30, 2020 at 05:29:28PM +0300, Ido Schimmel wrote: > > On Thu, May 28, 2020 at 06:12:39PM +0300, Vadym Kochan wrote: > > > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > > > ports of 10GbE

Re: [PATCH] KVM: Use previously computed array_size()

2020-05-30 Thread Joe Perches
On Sat, 2020-05-30 at 17:35 +0300, Denis Efremov wrote: > array_size() is used in alloc calls to compute the allocation > size. Next, "raw" multiplication is used to compute the size > for copy_from_user(). The patch removes duplicated computation > by saving the size in a var. No security concerns

Re: [PATCH] usb: storage: alauda: fix possible buffer overflow casued by bad DMA value in alauda_read_map()

2020-05-30 Thread Alan Stern
On Sat, May 30, 2020 at 10:42:30PM +0800, Jia-Ju Bai wrote: > From: Jia-Ju Bai > > The value us->iobuf is stored in DMA memory, and it is assigned to data, > so data[6] and data[7] can be modified at anytime by malicious hardware. > In this case, data[6] ^ data[7] can be a quite large number, whi

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-30 Thread Kees Cook
On Sat, May 30, 2020 at 03:08:37PM +0100, Al Viro wrote: > On Fri, May 29, 2020 at 07:43:10PM -0700, Kees Cook wrote: > > > Can anyone clarify the expected failure mode from SCM_RIGHTS? Can we > > move the put_user() after instead? I think cleanup would just be: > > replace_fd(fd, NULL, 0) > > Bo

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-30 Thread Kees Cook
On Sat, May 30, 2020 at 03:58:27PM +0200, Christian Brauner wrote: > On Sat, May 30, 2020 at 05:17:24AM +0200, Jann Horn wrote: > > On Sat, May 30, 2020 at 4:43 AM Kees Cook wrote: > > > I mean, yes, that's certainly better, but it just seems a shame that > > > everyone has to do the get_unused/pu

Perf doesn't show build-id of the application itself

2020-05-30 Thread Mahmood Naderan
When I run the following perf command for collecting user data $ perf record -e cycles:u -j any,u -a -o perf.data.user ./test The output of build-id checking is $ perf buildid-list -f -i perf.data.user dbd41c586ea6789f3b998ed28be6ff37134e917a /lib/modules/4.19.125/build/vmlinux b5381a457906d2790

[PATCH net-next v2 1/3] bridge: mrp: Update MRP frame type

2020-05-30 Thread Horatiu Vultur
Replace u16/u32 with be16/be32 in the MRP frame types. This fixes sparse warnings like: warning: cast to restricted __be16 Signed-off-by: Horatiu Vultur --- include/uapi/linux/mrp_bridge.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/include/uapi/l

[PATCH net-next v2 0/3] bridge: mrp: Add support for MRA role

2020-05-30 Thread Horatiu Vultur
This patch series extends the MRP with the MRA role. A node that has the MRA role can behave as a MRM or as a MRC. In case there are multiple nodes in the topology that has the MRA role then only one node can behave as MRM and all the others need to be have as MRC. The node that has the higher prio

[PATCH net-next v2 3/3] bridge: mrp: Add support for role MRA

2020-05-30 Thread Horatiu Vultur
A node that has the MRA role, it can behave as MRM or MRC. Initially it starts as MRM and sends MRP_Test frames on both ring ports. If it detects that there are MRP_Test send by another MRM, then it checks if these frames have a lower priority than itself. In this case it would send MRP_Nack frame

[PATCH net-next v2 2/3] bridge: mrp: Set the priority of MRP instance

2020-05-30 Thread Horatiu Vultur
Each MRP instance has a priority, a lower value means a higher priority. The priority of MRP instance is stored in MRP_Test frame in this way all the MRP nodes in the ring can see other nodes priority. Signed-off-by: Horatiu Vultur --- include/net/switchdev.h| 1 + include/uapi/linux/if_

[PATCH 2/2] media: atomisp: re-enable warnings again

2020-05-30 Thread Mauro Carvalho Chehab
For most warnings, the current code is OK. There are still some issues with implicit-fallthough warnings. Solve those and re-enable all warnings for this driver. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/Makefile| 9 - .../staging/media/atomisp/pci/atom

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-30 Thread Kees Cook
On Sat, May 30, 2020 at 04:13:29PM +0200, Christian Brauner wrote: > On Fri, May 29, 2020 at 10:47:12PM -0700, Kees Cook wrote: > > Oh hey! Look at scm_detach_fds_compat(). It needs this too. (And it's > > missing the cgroup tracking.) That would fix: > > > > 48a87cc26c13 ("net: netprio: fd passed

[PATCH 1/2] media: atomisp: remove format duplication at mbus->fourcc table

2020-05-30 Thread Mauro Carvalho Chehab
This table used to be used also to translate between ia_css abstraction and V4L2 fourcc codes. This was removed on a past patch, but the table now contains two fields with identical values. Get rid of one of them. Signed-off-by: Mauro Carvalho Chehab --- .../staging/media/atomisp/pci/atomisp_c

Re: fatal: unable to access 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/': SSL certificate problem: certificate has expired

2020-05-30 Thread Konstantin Ryabitsev
On Sat, May 30, 2020 at 03:47:19PM +0200, Toralf Förster wrote: > > $ git pull > > 15:07:08.488836 git.c:439 trace: built-in: git pull > > 15:07:08.504295 run-command.c:663 trace: run_command: git fetch > > --update-head-ok > > 15:07:08.506481 git.c:439 trace: bui

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Paolo Bonzini
> On Fri, May 29, 2020 at 04:52:59PM -0700, Linus Torvalds wrote: >> It looks like the argument for the address being validated is that it >> comes from "gfn_to_hva()", which should only return >> host-virtual-addresses. That may be true. Yes, the access_ok is done in __kvm_set_memory_region and g

Re: [PATCH v2 2/3] seccomp: Introduce addfd ioctl to seccomp user notifier

2020-05-30 Thread Christian Brauner
On Sat, May 30, 2020 at 09:14:50AM -0700, Kees Cook wrote: > On Sat, May 30, 2020 at 04:13:29PM +0200, Christian Brauner wrote: > > On Fri, May 29, 2020 at 10:47:12PM -0700, Kees Cook wrote: > > > Oh hey! Look at scm_detach_fds_compat(). It needs this too. (And it's > > > missing the cgroup trackin

Re: [PATCH v3 02/25] dt-bindings: clock: Add a binding for the RPi Firmware clocks

2020-05-30 Thread Maxime Ripard
Hi Stephen, Thanks for your review :) On Fri, May 29, 2020 at 02:17:16PM -0700, Stephen Boyd wrote: > > + "#clock-cells": > > +const: 1 > > +description: > > > Just curious if this is the same as the | syntax? I haven't seen this > used before. It differs on how it keeps th

Re: [PATCH 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy

2020-05-30 Thread Bart Van Assche
On 2020-05-30 02:32, Simon Arlott wrote: > If the device minor cannot be allocated or the cdrom fails to be > registered then the mutex should be destroyed. Please add Fixes: and Cc: stable tags. Thanks, Bart.

Re: [PATCH 2/2] scsi: sr: Fix sr_probe() missing deallocate of device minor

2020-05-30 Thread Bart Van Assche
On 2020-05-30 02:33, Simon Arlott wrote: > If the cdrom fails to be registered then the device minor should be > deallocated. Also for this patch, please add Fixes: and Cc: stable tags. Thanks, Bart.

Re: [PATCH RFC] KVM: arm64: Sidestep stage2_unmap_vm() on vcpu reset when S2FWB is supported

2020-05-30 Thread Marc Zyngier
Hi Alex, On 2020-05-30 11:46, Alexandru Elisei wrote: Hi, [...] diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 48d0ec44ad77..e6378162cdef 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -983,8 +983,11 @@ static int kvm_arch_vcpu_ioctl_vcpu_init(struct kvm_vcpu *vcpu,

[PATCH] PM: runtime: add RPM_IDLE_SUSPEND / RPM_IDLE_NO_SUSPEND constants

2020-05-30 Thread Heiner Kallweit
runtime_idle() callback implementations have to return a non-zero value if they don't intend to suspend now. Several drivers use an errno like -EBUSY for this purpose. This can be problematic because the return value is propagated up the call chain, from rpm_idle() to __pm_runtime_idle(), and from

Re: [PATCH 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy

2020-05-30 Thread James Bottomley
On Sat, 2020-05-30 at 09:24 -0700, Bart Van Assche wrote: > On 2020-05-30 02:32, Simon Arlott wrote: > > If the device minor cannot be allocated or the cdrom fails to be > > registered then the mutex should be destroyed. > > Please add Fixes: and Cc: stable tags. This isn't really a bug, is it?

Re: [PATCH] flow_dissector: work around stack frame size warning

2020-05-30 Thread Guillaume Nault
On Fri, May 29, 2020 at 10:13:58PM +0200, Arnd Bergmann wrote: > The fl_flow_key structure is around 500 bytes, so having two of them > on the stack in one function now exceeds the warning limit after an > otherwise correct change: > > net/sched/cls_flower.c:298:12: error: stack frame size of 1056

Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq

2020-05-30 Thread Marc Zyngier
Hi Ali, On Fri, 29 May 2020 12:36:42 + "Saidi, Ali" wrote: > Hi Marc, > > > On May 29, 2020, at 3:33 AM, Marc Zyngier wrote: > > > > Hi Ali, > > > >> On 2020-05-29 02:55, Ali Saidi wrote: > >> If an interrupt is disabled the ITS driver has sent a discard removing > >> the DeviceID and

[PATCH 0/2] Add USB PHY support for Ingenic X1000 and X1830.

2020-05-30 Thread Zhou Yanjie
1.Add the USB PHY bindings for the X1000 SoC and the X1830 SoC from Ingenic. 2.Add support for probing the phy-jz4770 driver on the X1000 SoC and the X1830 SoC from Ingenic. 周琰杰 (Zhou Yanjie) (2): dt-bindings: USB: Add Ingenic X1000 and X1830 bindings. USB: PHY: JZ4770: Add support for Ing

[PATCH 1/2] dt-bindings: USB: Add Ingenic X1000 and X1830 bindings.

2020-05-30 Thread Zhou Yanjie
Add the USB PHY bindings for the X1000 SoC and the X1830 SoC from Ingenic. Signed-off-by: 周琰杰 (Zhou Yanjie) --- Documentation/devicetree/bindings/usb/ingenic,jz4770-phy.yaml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/ingenic,jz47

[PATCH 2/2] USB: PHY: JZ4770: Add support for Ingenic X1000 and X1830.

2020-05-30 Thread Zhou Yanjie
Add support for probing the phy-jz4770 driver on the X1000 SoC and the X1830 SoC from Ingenic. Signed-off-by: qipengzhen Signed-off-by: 周琰杰 (Zhou Yanjie) --- drivers/usb/phy/Kconfig | 4 +- drivers/usb/phy/phy-jz4770.c | 250 +-- 2 files changed, 1

kernel BUG at include/linux/swapops.h:LINE!

2020-05-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:9cb1fd0e Linux 5.7-rc7 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1788a54a10 kernel config: https://syzkaller.appspot.com/x/.config?x=cca7550d53ffa599 dashboard link: https://syzkaller.appspot

Re: fatal: unable to access 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/': SSL certificate problem: certificate has expired

2020-05-30 Thread Konstantin Ryabitsev
On Sat, 30 May 2020 at 12:16, Konstantin Ryabitsev wrote: > > > $ curl https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ > > > curl: (60) SSL certificate problem: certificate has expired > > > More details here: https://curl.haxx.se/docs/sslcerts.html > > > > > > curl failed to v

[PATCH v2] intel-hid: Expand DMI quirk to support HP Spectre X2 (2015)

2020-05-30 Thread Nickolai Kozachenko
HEBC method reports capabilities of 5 button array but HP Spectre X2 (2015) does not have this control method (the same was for Wacom MobileStudio Pro). Expand previous DMI quirk by Alex Hung to also enable 5 button array for this system. Signed-off-by: Nickolai Kozachenko --- Formatted patch w

Re: [PATCH] usb: gadget: f_acm: don't disable disabled EP

2020-05-30 Thread Michał Mirosław
On Sat, May 30, 2020 at 01:03:17AM +, Peter Chen wrote: > > > > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, > > > > unsigned > > intf, unsigned alt) > > > > /* we know alt == 0, so this is an activation or a reset */ > > > > > > > > if (intf == acm->

[PATCH v2] powerpc/32s: Fix another build failure with CONFIG_PPC_KUAP_DEBUG

2020-05-30 Thread Christophe Leroy
'thread' doesn't exist in kuap_check() macro. Use 'current' instead. Reported-by: kbuild test robot Fixes: a68c31fc01ef ("powerpc/32s: Implement Kernel Userspace Access Protection") Cc: sta...@vger.kernel.org Signed-off-by: Christophe Leroy --- v2: Changed author and signed-off-by ... and adde

Re: [PATCH] powerpc/32: disable KASAN with pages bigger than 16k

2020-05-30 Thread Christophe Leroy
Le 28/05/2020 à 12:17, Christophe Leroy a écrit : Mapping of early shadow area is implemented by using a single static page table having all entries pointing to the same early shadow page. The shadow area must therefore occupy full PGD entries. The shadow area has a size of 128Mbytes starting

Re: [PATCH] KVM: Use previously computed array_size()

2020-05-30 Thread Denis Efremov
On 5/30/20 6:58 PM, Joe Perches wrote: > On Sat, 2020-05-30 at 17:35 +0300, Denis Efremov wrote: >> array_size() is used in alloc calls to compute the allocation >> size. Next, "raw" multiplication is used to compute the size >> for copy_from_user(). The patch removes duplicated computation >> b

Re: [PATCH RFC] seccomp: Implement syscall isolation based on memory areas

2020-05-30 Thread Kees Cook
On Sat, May 30, 2020 at 01:59:53AM -0400, Gabriel Krisman Bertazi wrote: > Modern Windows applications are executing system call instructions > directly from the application's code without going through the WinAPI. > This breaks Wine emulation, because it doesn't have a chance to > intercept and em

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Linus Torvalds
On Sat, May 30, 2020 at 9:20 AM Paolo Bonzini wrote: > > Yes, the access_ok is done in __kvm_set_memory_region and gfn_to_hva() > returns a page-aligned address so it's obviously ok for a u32. It's not that it's "obviously ok for an u32". It is _not_ obviously ok for a user address. There's actu

[PATCH v2 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy

2020-05-30 Thread Simon Arlott
If the device minor cannot be allocated or the cdrom fails to be registered then the mutex should be destroyed. Signed-off-by: Simon Arlott Fixes: 51a858817dcd ("scsi: sr: get rid of sr global mutex") Cc: sta...@vger.kernel.org --- On 30/05/2020 17:41, James Bottomley wrote: > On Sat, 2020-05-30

[PATCH v2 2/2] scsi: sr: Fix sr_probe() missing deallocate of device minor

2020-05-30 Thread Simon Arlott
If the cdrom fails to be registered then the device minor should be deallocated. Signed-off-by: Simon Arlott Cc: sta...@vger.kernel.org --- On 30/05/2020 17:24, Bart Van Assche wrote: > On 2020-05-30 02:33, Simon Arlott wrote: >> If the cdrom fails to be registered then the device minor should be

Re: [PATCH v3 1/4] dt-bindings: clk: Add Baikal-T1 CCU PLLs binding

2020-05-30 Thread Stephen Boyd
Quoting Serge Semin (2020-05-26 15:20:53) > Baikal-T1 Clocks Control Unit is responsible for transformation of a > signal coming from an external oscillator into clocks of various > frequencies to propagate them then to the corresponding clocks > consumers (either individual IP-blocks or clock doma

Re: [PATCH v3 4/4] clk: Add Baikal-T1 CCU Dividers driver

2020-05-30 Thread Stephen Boyd
Quoting Serge Semin (2020-05-26 15:20:56) > Nearly each Baikal-T1 IP-core is supposed to have a clock source > of particular frequency. But since there are greater than five > IP-blocks embedded into the SoC, the CCU PLLs can't fulfill all the > needs. Baikal-T1 CCU provides a set of fixed and conf

Re: [PATCH v3 3/4] clk: Add Baikal-T1 CCU PLLs driver

2020-05-30 Thread Stephen Boyd
Quoting Serge Semin (2020-05-26 15:20:55) > Baikal-T1 is supposed to be supplied with a high-frequency external > oscillator. But in order to create signals suitable for each IP-block > embedded into the SoC the oscillator output is primarily connected to > a set of CCU PLLs. There are five of them

Re: [PATCH 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy

2020-05-30 Thread Bart Van Assche
On 2020-05-30 09:41, James Bottomley wrote: > On Sat, 2020-05-30 at 09:24 -0700, Bart Van Assche wrote: >> On 2020-05-30 02:32, Simon Arlott wrote: >>> If the device minor cannot be allocated or the cdrom fails to be >>> registered then the mutex should be destroyed. >> >> Please add Fixes: and Cc:

Re: [PATCH 0/9] DT: Improve validation for Marvell SoCs

2020-05-30 Thread Lubomir Rintel
On Thu, May 28, 2020 at 04:52:44PM -0600, Rob Herring wrote: > On Thu, May 21, 2020 at 11:13:47AM +0200, Lubomir Rintel wrote: > > Hi, > > > > chained to this message is a second version of remaining patches from the > > first spin of the "DT: Improve validation for Marvell SoCs" [1] patch set. >

Re: [PATCH v3 2/4] dt-bindings: clk: Add Baikal-T1 CCU Dividers binding

2020-05-30 Thread Stephen Boyd
Quoting Serge Semin (2020-05-26 15:20:54) > After being gained by the CCU PLLs the signals must be transformed to > be suitable for the clock-consumers. This is done by a set of dividers > embedded into the CCU. A first block of dividers is used to create > reference clocks for AXI-bus of high-spee

Re: [PATCH v4 4/4] scsi: ufs: add compatibility with 3.1 UFS unit descriptor length

2020-05-30 Thread Bean Huo
Avri, On Sat, 2020-05-30 at 06:56 +, Avri Altman wrote: > > > > > From: Bean Huo > > > > For UFS 3.1, the normal unit descriptor is 10 bytes larger > > than the RPMB unit, however, both descriptors share the same > > desc_idn, to cover both unit descriptors with one length, we > > choose

Re: [PATCH v4 3/4] scsi: ufs: cleanup ufs initialization path

2020-05-30 Thread Bean Huo
Hi Avri thanks your review. On Sat, 2020-05-30 at 06:37 +, Avri Altman wrote: > > - case QUERY_DESC_IDN_RFU_0: > > - case QUERY_DESC_IDN_RFU_1: > > You forgot to check that desc_id < QUERY_DESC_IDN_MAX I deleted it since I saw the caller has checked this. I will add back. > >

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Al Viro
On Sat, May 30, 2020 at 10:57:24AM -0700, Linus Torvalds wrote: > So no. I disagree. There is absolutely nothing "obviously ok" about > any of that kvm code. Quite the reverse. > > I'd argue that it's very much obviously *NOT* ok, even while it might > just happen to work. Actually, it's somewha

Re: [PATCH v9 13/19] mtd: spi-nor: sfdp: do not make invalid quad enable fatal

2020-05-30 Thread Tudor.Ambarus
On Monday, May 25, 2020 12:15:38 PM EEST Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > The Micron MT35XU512ABA flash does not support the quad enable bit. But > instead of programming the Quad Enable Require field to 000b (

Re: [PATCH v9 06/19] mtd: spi-nor: sfdp: default to addr_width of 3 for configurable widths

2020-05-30 Thread Tudor.Ambarus
On Monday, May 25, 2020 12:15:31 PM EEST Pratyush Yadav wrote: > JESD216D.01 says that when the address width can be 3 or 4, it defaults > to 3 and enters 4-byte mode when given the appropriate command. So, when > we see a configurable width, default to 3 and let flash that default to > 4 change it

Re: [PATCH v9 07/19] mtd: spi-nor: sfdp: prepare BFPT parsing for JESD216 rev D

2020-05-30 Thread Tudor.Ambarus
On Monday, May 25, 2020 12:15:32 PM EEST Pratyush Yadav wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > JESD216 rev D makes BFPT 20 DWORDs. Update the BFPT size define to > reflect that. > > The check for rev A or later compared the BFPT h

Re: Regression with PM / wakeup: Show wakeup sources stats in sysfs"

2020-05-30 Thread Florian Fainelli
On 5/29/2020 4:14 PM, Tri Vo wrote: > On Fri, May 29, 2020 at 3:37 PM Florian Fainelli wrote: >> >> On 5/29/20 3:28 PM, Tri Vo wrote: >>> On Fri, May 29, 2020 at 9:51 AM Rafael J. Wysocki >>> wrote: On 5/28/2020 10:46 PM, Florian Fainelli wrote: > Hi, > > Commit c8377adfa

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Linus Torvalds
On Sat, May 30, 2020 at 11:39 AM Al Viro wrote: > > Actually, it's somewhat less brittle than you think (on non-mips, at least) > and not due to those long-ago access_ok(). It really isn't. Your very first statement shows how broken it is: > FWIW, the kvm side of things (vhost is yet another pi

Re: [PATCHSET v5 0/12] Add support for async buffered reads

2020-05-30 Thread Sedat Dilek
Here are the numbers with your patchset: # cat systemd-analyze-time_5.7.0-rc7-4-amd64-clang_2nd-try.txt Startup finished in 7.229s (kernel) + 1min 18.304s (userspace) = 1min 25.534s graphical.target reached after 1min 18.286s in userspace # cat systemd-analyze-blame_5.7.0-rc7-4-amd64-clang_2nd-tr

Re: fatal: unable to access 'https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/': SSL certificate problem: certificate has expired

2020-05-30 Thread Toralf Förster
On 5/30/20 7:10 PM, Konstantin Ryabitsev wrote: > (and the fact that you were seeing it in the first > place suggests that you should update your openssl library, see > https://calnetweb.berkeley.edu/calnet-technologists/incommon-sectigo-certificate-service/addtrust-external-root-expiration-may-202

drivers/net/ethernet/intel/igc/igc_ptp.c:397:17: sparse: sparse: incorrect type in argument 1 (different base types)

2020-05-30 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 86852175b016f0c6873dcbc24b93d12b7b246612 commit: 81b055205e8ba2d400c8fa5845ba540a4a880a3a igc: Add support for RX timestamping date: 5 months ago config: i386-randconfig-s002-20200531 (attached as .config)

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Al Viro
On Sat, May 30, 2020 at 11:52:44AM -0700, Linus Torvalds wrote: > > It really isn't. > > Your very first statement shows how broken it is: > > > FWIW, the kvm side of things (vhost is yet another pile of fun) is > > > > [x86] kvm_hv_set_msr_pw(): > > arch/x86/kvm/hyperv.c:1027: if (_

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Al Viro
On Sat, May 30, 2020 at 11:52:44AM -0700, Linus Torvalds wrote: > And I don't understand why you mention set_fs() vs access_ok(). None > of this code has anything that messes with set_fs(). The access_ok() > is garbage and shouldn't exist, and those user accesses should all use > the checking vers

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Linus Torvalds
On Sat, May 30, 2020 at 12:14 PM Al Viro wrote: > > > And none of that code verifies that the end result is a user address. > > kvm_is_error_hva() is > return addr >= PAGE_OFFSET; Ahh, that's what I missed. It won't work on other architectures, but within x86 it's fine.

Re: [PATCH v2 4/4] irqchip: qcom-pdc: Introduce irq_set_wake call

2020-05-30 Thread Stephen Boyd
Quoting Maulik Shah (2020-05-29 02:20:32) > Hi, > > On 5/27/2020 3:45 PM, Stephen Boyd wrote: > > Quoting Maulik Shah (2020-05-23 10:11:13) > >> @@ -87,22 +88,20 @@ static void pdc_enable_intr(struct irq_data *d, bool > >> on) > >> raw_spin_unlock(&pdc_lock); > >> } > >> > >> -stati

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Al Viro
On Sat, May 30, 2020 at 08:19:40PM +0100, Al Viro wrote: > On Sat, May 30, 2020 at 11:52:44AM -0700, Linus Torvalds wrote: > > > And I don't understand why you mention set_fs() vs access_ok(). None > > of this code has anything that messes with set_fs(). The access_ok() > > is garbage and shouldn'

Re: linux-next: Signed-off-by missing for commit in the clk tree

2020-05-30 Thread Stephen Boyd
Quoting Stephen Rothwell (2020-05-29 21:56:24) > Hi all, > > Commit > > 5f2feacb7639 ("clk: vc5: Add support for IDT VersaClock 5P49V6965") > > is missing a Signed-off-by from its committer. > Thanks. I don't know what went wrong with that patch application but I've fixed it now.

[PATCH 2/2] media: atomisp: get rid of sh_css_pipe.c

2020-05-30 Thread Mauro Carvalho Chehab
There's nothing there, just comments. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/Makefile | 1 - drivers/staging/media/atomisp/pci/sh_css_pipe.c | 17 - 2 files changed, 18 deletions(-) delete mode 100644 drivers/staging/media/atomisp/pci/sh

[PATCH 1/2] staging: media: atomisp: fix stack overflow in init_pipe_defaults()

2020-05-30 Thread Mauro Carvalho Chehab
From: Arnd Bergmann When building with clang, multiple copies of the structures to be initialized are passed around on the stack and copied locally, using an insane amount of stack space: drivers/staging/media/atomisp/pci/sh_css.c:2371:1: error: stack frame size of 26864 bytes in function 'crea

[PATCH 0/2] A couple additional patches for atomisp

2020-05-30 Thread Mauro Carvalho Chehab
Patch 1 was sent by Arnd already, but, while it improved stack usage with clang, it broke compilation with gcc ;-( Each compiler seems to have different issues with different types of struct initalizers, so we ended needing some discussions in order to find something that would work for both. So,

Re: [GIT PULL] GPIO fixes for v5.7

2020-05-30 Thread pr-tracker-bot
The pull request you sent on Sat, 30 May 2020 13:09:56 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git > tags/gpio-v5.7-3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/900db15047044ef50b32e23630880f4780ec5b9e Thank you! -- Deet-doot-do

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.7-6 tag

2020-05-30 Thread pr-tracker-bot
The pull request you sent on Sun, 31 May 2020 00:05:02 +1000: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.7-6 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ffeb595d84811dde16a28b33d8a7cf26d51d51b3 Thank you! -- Deet-doot-do

Re: [PATCH v7 2/4] lib/test_bitmap.c: Add for_each_set_clump test cases

2020-05-30 Thread kbuild test robot
Hi Syed, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on b9bbe6ed63b2b9f2c9ee5cbd0f2c946a2723f4ce] url: https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-for_each_set_clump-macro/20200524-130931 base:b9bbe6ed63b2b9f2c9ee5cbd0f2c94

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Al Viro
On Sat, May 30, 2020 at 12:20:54PM -0700, Linus Torvalds wrote: > On Sat, May 30, 2020 at 12:14 PM Al Viro wrote: > > > > > And none of that code verifies that the end result is a user address. > > > > kvm_is_error_hva() is > > return addr >= PAGE_OFFSET; > > Ahh, that's what I missed. It

RE: [PATCH v4 4/4] scsi: ufs: add compatibility with 3.1 UFS unit descriptor length

2020-05-30 Thread Avri Altman
> Avri, > > > On Sat, 2020-05-30 at 06:56 +, Avri Altman wrote: > > > > > > > > From: Bean Huo > > > > > > For UFS 3.1, the normal unit descriptor is 10 bytes larger > > > than the RPMB unit, however, both descriptors share the same > > > desc_idn, to cover both unit descriptors with one l

RE: [PATCH v1 0/2] scsi: ufs: Support WriteBooster on Samsung UFS devices

2020-05-30 Thread Avri Altman
> > Hi, > Samsung UFS devices are widely used in the market, however these devices > need some special handling to support WriteBooster. Introduce a device quirk > to handle this special requirement. > > Currently Bean Huo is doing some nice cleanup work for device descriptor > length so our se

[PATCH] devres: keep both device name and resource name in pretty name

2020-05-30 Thread Vladimir Oltean
From: Vladimir Oltean Some device drivers have many memory regions, and sometimes debugging is easiest using devmem on its register map. Take for example a networking switch. Its memory map used to look like this in /proc/iomem: 1fc00-1fc3f : pcie@1f000 1fc00-1fc3f : :0

Re: [PATCH] devres: keep both device name and resource name in pretty name

2020-05-30 Thread Vladimir Oltean
On Sat, 30 May 2020 at 23:06, Vladimir Oltean wrote: > > From: Vladimir Oltean > > Some device drivers have many memory regions, and sometimes debugging is > easiest using devmem on its register map. Take for example a networking > switch. Its memory map used to look like this in /proc/iomem: > >

[PATCH] pinctrl: imxl: Fix an error handling path in 'imx1_pinctrl_core_probe()'

2020-05-30 Thread Christophe JAILLET
When 'pinctrl_register()' has been turned into 'devm_pinctrl_register()', an error handling path has not been updated. Axe a now unneeded 'pinctrl_unregister()'. Fixes: e55e025d1687 ("pinctrl: imxl: Use devm_pinctrl_register() for pinctrl registration") Signed-off-by: Christophe JAILLET --- dr

Re: [PATCH] mailbox: no error log in mbox_client_txdone() for tx done by irq

2020-05-30 Thread Jassi Brar
On Mon, May 11, 2020 at 12:52 AM wrote: > > From: Joe Zhu > > client does not know and not care about how controller implement tx done. > mbox_client_txdone() may be called when controller uses irq method. > > Signed-off-by: Joe Zhu > --- > drivers/mailbox/mailbox.c | 4 +++- > 1 file changed,

Re: [PATCH v6] support gce on mt6779 platform

2020-05-30 Thread Jassi Brar
On Thu, May 28, 2020 at 12:05 PM Dennis YC Hsieh wrote: > > This patch support gce on mt6779 platform. > > Change since v5: > - spearate address shift code in client helper and mailbox controller > - separate write_s/write_s_mask and write_s_value/write_s_mask_value so that > client can decide u

[PATCH net-next] net: phy: broadcom: don't export RDB/legacy access methods

2020-05-30 Thread Michael Walle
Don't export __bcm_phy_enable_rdb_access() and __bcm_phy_enable_legacy_access() functions. They aren't used outside this module and it was forgotten to provide a prototype for these functions. Just make them static for now. Fixes: 11ecf8c55b91 ("net: phy: broadcom: add cable test support") Reporte

RE: [PATCH v1 1/2] scsi: ufs: Support WriteBooster on Samsung UFS devices

2020-05-30 Thread Avri Altman
> @@ -2801,11 +2801,17 @@ int ufshcd_query_flag(struct ufs_hba *hba, enum > query_opcode opcode, > { > struct ufs_query_req *request = NULL; > struct ufs_query_res *response = NULL; > - int err, selector = 0; > + int err; > int timeout = QUERY_REQ_TIMEOUT; > +

Re: [PATCH net-next] net: phy: broadcom: don't export RDB/legacy access methods

2020-05-30 Thread Florian Fainelli
On 5/30/2020 1:34 PM, Michael Walle wrote: > Don't export __bcm_phy_enable_rdb_access() and > __bcm_phy_enable_legacy_access() functions. They aren't used outside this > module and it was forgotten to provide a prototype for these functions. > Just make them static for now. > > Fixes: 11ecf8c55

Re: [PATCH] mailbox: imx: Add context save/restore for suspend/resume

2020-05-30 Thread Jassi Brar
On Wed, May 27, 2020 at 8:55 PM Anson Huang wrote: > > Gentle ping... > > > > Subject: RE: [PATCH] mailbox: imx: Add context save/restore for > > suspend/resume > > > > > > > > > Subject: RE: [PATCH] mailbox: imx: Add context save/restore for > > > suspend/resume > > > > > > > From: Anson Huang >

RE: [PATCH] scsi: ufs: Remove redundant urgent_bkop_lvl initialization

2020-05-30 Thread Avri Altman
> > In ufshcd_probe_hba(), all BKOP SW tracking variables can be reset > together in ufshcd_force_reset_auto_bkops(), thus urgent_bkop_lvl > initialization in the beginning of ufshcd_probe_hba() can be merged > into ufshcd_force_reset_auto_bkops(). > > Signed-off-by: Stanley Chu Reviewed-by: A

Re: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()

2020-05-30 Thread Al Viro
On Sat, May 30, 2020 at 08:42:32PM +0100, Al Viro wrote: > On Sat, May 30, 2020 at 12:20:54PM -0700, Linus Torvalds wrote: > > On Sat, May 30, 2020 at 12:14 PM Al Viro wrote: > > > > > > > And none of that code verifies that the end result is a user address. > > > > > > kvm_is_error_hva() is > > >

[PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'

2020-05-30 Thread Christophe JAILLET
'pinctrl_unregister()' should not be called to undo 'devm_pinctrl_register_and_init()', it is already handled by the framework. This simplifies the error handling paths of the probe function. The 'imx_free_resources()' can be removed as well. Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees fo

[PATCH 2/2] Coccinelle: extend memdup_user rule with vmemdup_user()

2020-05-30 Thread Denis Efremov
Add vmemdup_user() transformations to the memdup_user.cocci rule. Commit 50fd2f298bef ("new primitive: vmemdup_user()") introduced vmemdup_user(). The function uses kvmalloc with GPF_USER flag. Signed-off-by: Denis Efremov --- scripts/coccinelle/api/memdup_user.cocci | 49 +++

[PATCH 0/2] Update memdup_user.cocci

2020-05-30 Thread Denis Efremov
Add GFP_USER to the allocation flags and handle vmemdup_user(). Denis Efremov (2): Coccinelle: extend memdup_user transformation with GFP_USER Coccinelle: extend memdup_user rule with vmemdup_user() scripts/coccinelle/api/memdup_user.cocci | 53 ++-- 1 file changed, 49 in

[PATCH 1/2] Coccinelle: extend memdup_user transformation with GFP_USER

2020-05-30 Thread Denis Efremov
Match GFP_USER allocations with memdup_user.cocci rule. Commit 6c2c97a24f09 ("memdup_user(): switch to GFP_USER") switched memdup_user() from GFP_KERNEL to GFP_USER. In most cases it is still a good idea to use memdup_user() for GFP_KERNEL allocations. The motivation behind altering memdup_user() t

Re: [PATCH v6 08/11] i2c: designware: Convert driver to using regmap API

2020-05-30 Thread Wolfram Sang
On Sat, May 30, 2020 at 01:09:30PM +0200, Wolfram Sang wrote: > On Thu, May 28, 2020 at 12:33:18PM +0300, Serge Semin wrote: > > Seeing the DW I2C driver is using flags-based accessors with two > > conditional clauses it would be better to replace them with the regmap > > API IO methods and to init

Re: [PATCH v6 00/11] i2c: designeware: Add Baikal-T1 System I2C support

2020-05-30 Thread Wolfram Sang
On Thu, May 28, 2020 at 12:33:10PM +0300, Serge Semin wrote: > Jarkko, Wolfram, the merge window is upon us, please review/merge in/whatever > the patchset. > > Initially this has been a small patchset which embedded the Baikal-T1 > System I2C support into the DW APB I2C driver as is by using a si

Re: [PATCH] cifs: remove redundant initialization of variable rc

2020-05-30 Thread Steve French
merged into cifs-2.6.git for-next On Wed, May 27, 2020 at 7:52 AM Colin King wrote: > > From: Colin Ian King > > The variable rc is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addr

[PATCH v2 net-next 0/3] Extending bpf_setsockopt with SO_BINDTODEVICE sockopt

2020-05-30 Thread Ferenc Fejes
This option makes it possible to programatically bind sockets to netdevices. With the help of this option sockets of VRF unaware applications could be distributed between multiple VRFs with an eBPF program. This lets the applications benefit from multiple possible routes. v2: - splitting up the

[PATCH v2 net-next 2/3] bpf: Allow SO_BINDTODEVICE opt in bpf_setsockopt

2020-05-30 Thread Ferenc Fejes
Extending the supported sockopts in bpf_setsockopt with SO_BINDTODEVICE. We call sock_bindtoindex with parameter lock_sk = false in this context because we already owning the socket. Signed-off-by: Ferenc Fejes --- net/core/filter.c | 27 ++- 1 file changed, 26 insertions

<    1   2   3   4   5   >