[PATCH v2 1/2] m68k,nommu: add missing __user in uaccess' __ptr() macro

2020-05-29 Thread Luc Van Oostenryck
The assembly for __get_user() & __put_user() uses a macro, __ptr(), to cast the pointer to 'unsigned long *' but the pointer is always a __user one and so this cast creates a lot of warnings when using Sparse. So, change to the cast to 'unsigned long __user *'. Reported-by: kbuild test robot Sig

[PATCH v2 2/2] m68k,nommu: fix implicit cast from __user in __{get,put}_user_asm()

2020-05-29 Thread Luc Van Oostenryck
The assembly for __get_user_asm() & __put_user_asm() uses memcpy() when the size is 8. However, the pointer is always a __user one while memcpy() expects a plain one and so this cast creates a lot of warnings when using Sparse. So, fix this by adding a cast to 'void __force *' at memcpy()'s argum

Re: [PATCH 10/30] KVM: nSVM: extract preparation of VMCB for nested run

2020-05-29 Thread Paolo Bonzini
On 29/05/20 20:27, Krish Sadhukhan wrote: >> >> +static void nested_prepare_vmcb_save(struct vcpu_svm *svm, struct >> vmcb *nested_vmcb) > > > Not a big deal, but I feel that it helps a lot in readability if we keep > the names symmetric. This one could be named prepare_nested_vmcb_save to > matc

Re: Kernel crash due to memory corruption with v5.4.26-rt17 and PowerPC e500

2020-05-29 Thread Mark Marshall
My config is attached. This is the greatly reduced config that I used when trying to narrow down the problem. We normally have much more enabled, but that had no effect on the bug in my testing. We do, unfortunately, have quite a few out-of-tree patches, but they are all in USB or Networking, wh

Re: [PATCH net-next v4 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 11:49:33AM -0500, Dan Murphy wrote: > Add the internal delay values into the header and update the binding > with the internal delay properties. > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/net/ti,dp83869.yaml | 16 > 1 file changed,

Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Paolo Bonzini
On 29/05/20 20:10, Krish Sadhukhan wrote: >> Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, >> since the map is not used elsewhere in the function.  There are >> just two calls, so move it there. > > The last sentence sounds bit incomplete. Good point---more precisely, "cal

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2020-05-29 Thread Logan Gunthorpe
On 2020-05-29 6:45 a.m., Christoph Hellwig wrote: > On Thu, May 28, 2020 at 06:00:44PM -0600, Logan Gunthorpe wrote: >>> This issue is most likely in the i915 driver and is most likely caused by >>> the driver not respecting the return value of the dma_map_ops::map_sg >>> function. You can see

Re: [PATCH v2 11/12] dt-bindings: iio: imu: Add inv_icm42600 documentation

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 08:57:10PM +0200, Jean-Baptiste Maneyrol wrote: > Document the ICM-426xxx devices devicetree bindings. > > Signed-off-by: Jean-Baptiste Maneyrol > --- > .../bindings/iio/imu/invensense,icm42600.yaml | 86 +++ > 1 file changed, 86 insertions(+) > create mo

Re: [PATCH 1/6] x86/entry: Introduce local_db_{save,restore}()

2020-05-29 Thread Peter Zijlstra
On Fri, May 29, 2020 at 10:28:33AM -0700, Andy Lutomirski wrote: > > +static __always_inline unsigned long local_db_save(void) > > +{ > > +unsigned long dr7; > > + > > +get_debugreg(&dr7, 7); > > +dr7 ^= 0x400; > > Why xor? This seems extra confusing. I'll do the normal mask thing ..

Re: [PATCH v14 1/3] dt-bindings: i2c: npcm7xx: add NPCM I2C controller

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 23:08:18 +0300, Tali Perry wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM I2C controller. > > Signed-off-by: Tali Perry > --- > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 62 +++ > 1 file changed, 62 insertions(+) > create mode 1

Re: [PATCH v3 00/28] KVM: nSVM: event fixes and migration support

2020-05-29 Thread Paolo Bonzini
On 29/05/20 19:59, Sean Christopherson wrote: >> [PATCH v3 00/28] KVM: nSVM: event fixes and migration support > You've got something funky going on with the way you generate cover letters, > looks like it doesn't count patches authored by someone else. The 'v3' is > also missing from the patches,

Re: [PATCH 1/4] dt-bindings: thermal: rcar-thermal: Add device tree support for r8a7742

2020-05-29 Thread Rob Herring
On Wed, 27 May 2020 22:18:37 +0100, Lad Prabhakar wrote: > Add thermal sensor support for r8a7742 SoC. The Renesas RZ/G1H > (r8a7742) thermal sensor module is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,rcar-gen2-thermal". > >

Re: [PATCH v2 3/3] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD

2020-05-29 Thread Tycho Andersen
On Fri, May 29, 2020 at 06:46:07PM +, Sargun Dhillon wrote: > On Fri, May 29, 2020 at 12:41:51AM -0700, Kees Cook wrote: > > On Thu, May 28, 2020 at 04:08:58AM -0700, Sargun Dhillon wrote: > > > + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0); > > > + > > > + nextid = req.id +

[PATCH v2] kasan: fix clang compilation warning due to stack protector

2020-05-29 Thread Andrey Konovalov
KASAN uses a single cc-option invocation to disable both conserve-stack and stack-protector flags. The former flag is not present in Clang, which causes cc-option to fail, and results in stack-protector being enabled. Fix by using separate cc-option calls for each flag. Also collect all flags in a

Re: [PATCH] kasan: fix clang compilation warning due to stack protector

2020-05-29 Thread Andrey Konovalov
On Fri, May 29, 2020 at 4:56 PM Marco Elver wrote: > > On Thu, 28 May 2020 at 19:20, 'Andrey Konovalov' via kasan-dev > wrote: > > > > KASAN uses a single cc-option invocation to disable both conserve-stack > > and stack-protector flags. The former flag is not present in Clang, which > > causes c

Re: [PATCH v13 3/7] dt-bindings: clock: Add documentation for X1830 bindings.

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 11:15:45 +0800, 周琰杰 (Zhou Yanjie) wrote: > Add documentation for the clock bindings of the X1830 Soc from Ingenic. > > Signed-off-by: 周琰杰 (Zhou Yanjie) > Reviewed-by: Rob Herring > --- > > Notes: > v11: > New patch, split from [3/6] in v10. > > v11->v12: > N

Re: [PATCH 3/4] dt-bindings: timer: renesas,cmt: Document r8a7742 CMT support

2020-05-29 Thread Rob Herring
On Fri, May 29, 2020 at 02:53:02PM +0200, Geert Uytterhoeven wrote: > Hi Prabhakar, > > On Wed, May 27, 2020 at 11:19 PM Lad Prabhakar > wrote: > > Document SoC specific compatible strings for r8a7742. No driver change > > is needed as the fallback strings will activate the right code. > > > > Si

Re: [PATCH net-next] vmxnet3: use correct hdr reference when packet is encapsulated

2020-05-29 Thread David Miller
From: Ronak Doshi Date: Thu, 28 May 2020 19:53:52 -0700 > 'Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload > support")' added support for encapsulation offload. However, while > preparing inner tso packet, it uses reference to outer ip headers. > > This patch fixes this issue

Re: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()

2020-05-29 Thread John Hubbard
On 2020-05-29 01:29, Dragan Cvetic wrote: Hi John, Thank you for the suggestion, please find my comment below: -Original Message- From: John Hubbard Sent: Wednesday 27 May 2020 02:26 To: LKML Cc: Souptick Joarder ; John Hubbard ; Derek Kiernan ; Dragan Cvetic ; Arnd Bergmann ; Greg

[PATCH v2 3/4] pinctrl: bcm2835: Match BCM7211 compatible string

2020-05-29 Thread Florian Fainelli
The BCM7211 SoC uses the same pinconf_ops as the ones defined for the BCM2711 SoC, match the compatible string and use the correct set of options. Signed-off-by: Florian Fainelli --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/bcm

Re: [PATCH v2] kasan: fix clang compilation warning due to stack protector

2020-05-29 Thread Marco Elver
On Fri, 29 May 2020 at 21:12, Andrey Konovalov wrote: > > KASAN uses a single cc-option invocation to disable both conserve-stack > and stack-protector flags. The former flag is not present in Clang, which > causes cc-option to fail, and results in stack-protector being enabled. > > Fix by using s

[PATCH v2 2/4] dt-bindings: pinctrl: Document optional BCM7211 wake-up interrupts

2020-05-29 Thread Florian Fainelli
BCM7211 supports wake-up interrupts in the form of optional interrupt lines, one per bank, plus the "all banks" interrupt line. Signed-off-by: Florian Fainelli --- .../devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 4/4] pinctrl: bcm2835: Add support for wake-up interrupts

2020-05-29 Thread Florian Fainelli
Leverage the IRQCHIP_MASK_ON_SUSPEND flag in order to avoid having to specifically treat the GPIO interrupts during suspend and resume, and simply implement an irq_set_wake() callback that is responsible for enabling the parent wake-up interrupt as a wake-up interrupt. To avoid allocating unnecess

[PATCH v2 0/4] pinctrl: bcm2835: Support for wake-up interrupts

2020-05-29 Thread Florian Fainelli
Hi Linus, This patch series updates the bcm2835 pinctrl driver to support the BCM7211 SoC which is quite similar to 2711 (Raspberry Pi 4) except that it also supports wake-up interrupts. Thanks! Changes in v2: - fixed patch #3 to reference the correct data structure (Stefan) - fixed patch #4 to

Re: [PATCH v6 02/11] dt-bindings: i2c: Convert DW I2C slave to the DW I2C master example

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 12:33:12 +0300, Serge Semin wrote: > dtc currently doesn't support I2C_OWN_SLAVE_ADDRESS flag set in the > i2c "reg" property. If dtc finds an i2c-slave sub-node having an address > higher than ten-bits wide it'll print an ugly warning: > > Warning (i2c_bus_reg): /example-2/i2c

[PATCH v2 1/4] dt-bindings: pinctrl: Document 7211 compatible for brcm,bcm2835-gpio.txt

2020-05-29 Thread Florian Fainelli
Document the brcm,bcm7211-gpio compatible string in the brcm,bcm2835-gpio.txt document. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-g

Re: [PATCH v6 03/11] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 12:33:13 +0300, Serge Semin wrote: > Add the "baikal,bt1-sys-i2c" compatible string to the DW I2C binding. Even > though the corresponding node is supposed to be a child of the Baikal-T1 > System Controller, its reg property is left required for compatibility. > > Signed-off-by

Re: [PATCH net-next 2/2] bridge: mrp: Add support for role MRA

2020-05-29 Thread Jakub Kicinski
On Fri, 29 May 2020 10:05:14 + Horatiu Vultur wrote: > A node that has the MRA role, it can behave as MRM or MRC. > > Initially it starts as MRM and sends MRP_Test frames on both ring ports. > If it detects that there are MRP_Test send by another MRM, then it > checks if these frames have a lo

Re: [PATCH v4 0/2] soc: ti: add k3 platforms chipid module driver

2020-05-29 Thread santosh . shilimkar
On 5/29/20 11:34 AM, Arnd Bergmann wrote: On Fri, May 29, 2020 at 8:22 PM Grygorii Strashko wrote: On 12/05/2020 15:34, Grygorii Strashko wrote: .../bindings/soc/ti/k3-socinfo.yaml | 40 + drivers/soc/ti/Kconfig| 10 ++ drivers/soc/ti/Makefile

Re: clean up kernel_{read,write} & friends v2

2020-05-29 Thread Linus Torvalds
On Fri, May 29, 2020 at 6:08 AM David Laight wrote: > > A wide monitor is for looking at lots of files. Not necessarily. Excessive line breaks are BAD. They cause real and every-day problems. They cause problems for things like "grep" both in the patterns and in the output, since grep (and a lo

Re: [PATCH net-next v4 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-29 Thread Dan Murphy
Rob On 5/29/20 2:03 PM, Rob Herring wrote: On Wed, May 27, 2020 at 11:49:33AM -0500, Dan Murphy wrote: Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83869.yaml | 16

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Bjorn Helgaas
[+cc Rafael, linux-kernel] On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: > On 28.05.2020 23:44, Heiner Kallweit wrote: > > For whatever reason with this change (and losing ASPM control) I also > > loose the PCIe PME interrupts. This prevents my network card from > > resuming fro

Re: [PATCH v4 1/4] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings

2020-05-29 Thread Rob Herring
On Thu, May 28, 2020 at 05:57:09PM +0800, EastL wrote: > Document the devicetree bindings for MediaTek Command-Queue DMA controller > which could be found on MT6779 SoC or other similar Mediatek SoCs. > > Signed-off-by: EastL Need a full name. > --- > .../devicetree/bindings/dma/mtk-cqdma.yaml

Re: [PATCH net-next v4 1/4] dt-bindings: net: Add tx and rx internal delays

2020-05-29 Thread Dan Murphy
Rob On 5/29/20 1:25 PM, Rob Herring wrote: On Wed, May 27, 2020 at 11:49:31AM -0500, Dan Murphy wrote: tx-internal-delays and rx-internal-delays are a common setting for RGMII capable devices. These properties are used when the phy-mode or phy-controller is set to rgmii-id, rgmii-rxid or rgmii

Re: [PATCH v2 1/4] dt-bindings: power: Add BQ27561 compatible

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 07:21:44 -0500, Dan Murphy wrote: > Add the Texas Instruments bq27561 battery monitor to the bq27xxx > binding. > > Signed-off-by: Dan Murphy > --- > Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

[PATCH v3] regmap: fix alignment issue

2020-05-29 Thread Jens Thoms Toerring
The assembly and disassembly of data to be sent to or received from a device invoke functions (regmap_format_XXX() and regmap_parse_XXX()) that extract or insert data items from or into a buffer, using assignments. In some cases those functions are called with buffer pointers with odd addresses. On

Re: [PATCH v2 3/4] dt-bindings: power: Add BQ28z610 compatible

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 07:21:46 -0500, Dan Murphy wrote: > Add the Texas Instruments bq28z610 battery monitor to the bq27xxx > binding. > > Signed-off-by: Dan Murphy > --- > Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

Re: linux-next: manual merge of the nfsd tree with the nfs-anna tree

2020-05-29 Thread Chuck Lever
> On May 28, 2020, at 8:59 PM, Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the nfsd tree got a conflict in: > > include/trace/events/sunrpc.h > > between commit: > > 2baebf955125 ("SUNRPC: Split the xdr_buf event class") > > from the nfs-anna tree and commit: > >

Re: [PATCH net-next v2] dt-bindings: net: rename the bindings document for MediaTek STAR EMAC

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 15:59:02 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The driver itself was renamed before getting merged into mainline, but > the binding document kept the old name. This makes both names consistent. > > Signed-off-by: Bartosz Golaszewski > --- > v1 ->

Re: [PATCH v3 1/2] dt-bindings: chrome: Add cros-ec-typec mux props

2020-05-29 Thread Prashant Malani
Hi Rob, Would you prefer these switches to be defined in the usb-connector.yaml bindings file? If there are no other concerns, I can push a fresh version of the patch with the properties defined in usb-connector.yaml. Thanks, On Tue, May 19, 2020 at 2:46 PM Prashant Malani wrote: > > Add proper

[PATCH] kunit: Fix TabError, remove defconfig code and handle when there is no kunitconfig

2020-05-29 Thread Vitor Massaru Iha
The identation before this code (`if not os.path.exists(cli_args.build_dir):``) was with spaces instead of tabs after fixed up merge conflits, this commit revert spaces to tabs: [iha@bbking linux]$ tools/testing/kunit/kunit.py run File "tools/testing/kunit/kunit.py", line 247 if not linux:

[PATCH] lan743x: Added fixed link and RGMII support

2020-05-29 Thread Roelof Berg
Microchip lan7431 is frequently connected to a phy. However, it can also be directly connected to a MII remote peer without any phy in between. For supporting such a phyless hardware setup in Linux we utilized phylib, which supports a fixed-link configuration via the device tree. And we added suppo

Re: [PATCH v7 2/5] dt-bindings: iio: magnetometer: ak8975: convert format to yaml, add maintainer

2020-05-29 Thread Rob Herring
On Thu, May 28, 2020 at 04:58:47PM +0200, Jonathan Albrieux wrote: > Converts documentation from txt format to yaml. > > Signed-off-by: Jonathan Albrieux > --- > .../bindings/iio/magnetometer/ak8975.txt | 37 - > .../iio/magnetometer/asahi-kasei,ak8975.yaml | 77 +++

Re: linux-next: Tree for May 14 (objtool 2/2)

2020-05-29 Thread Kees Cook
On Fri, May 29, 2020 at 12:54:56PM -0500, Josh Poimboeuf wrote: > On Thu, May 28, 2020 at 11:06:32PM -0700, Kees Cook wrote: > > diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan > > index 929211039bac..27bcc2568c95 100644 > > --- a/lib/Kconfig.ubsan > > +++ b/lib/Kconfig.ubsan > > @@ -63,7 +63,7

Re: [PATCH v10 1/2] dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC

2020-05-29 Thread Rob Herring
On Thu, May 28, 2020 at 11:39:28PM +0800, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan > > Add YAML file for dt-bindings to support NAND Flash Controller > on Intel's Lightning Mountain SoC. > > Signed-off-by: Ramuthevar Vadivel Murugan > > --- > .../devicetree/bindin

Re: mmotm 2020-05-13-20-30 uploaded (objtool warnings)

2020-05-29 Thread Linus Torvalds
On Fri, May 29, 2020 at 9:50 AM Josh Poimboeuf wrote: > > From staring at the asm I think the generated code is correct, it's just > that the nested likelys with ftrace profiling cause GCC to converge the > error/success paths. But objtool doesn't do register value tracking so > it's not smart en

Re: [PATCH 1/4] dt-bindings: pinctrl: Document 7211 compatible for brcm, bcm2835-gpio.txt

2020-05-29 Thread Rob Herring
On Thu, 28 May 2020 12:21:09 -0700, Florian Fainelli wrote: > Document the brcm,bcm7211-gpio compatible string in the > brcm,bcm2835-gpio.txt document. > > Signed-off-by: Florian Fainelli > --- > Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 1 + > 1 file changed, 1 insertion

drivers/gpu/drm/mgag200/mgag200_drv.c:70:5: warning: no previous prototype for function 'mgag200_driver_dumb_create'

2020-05-29 Thread kbuild test robot
onfig-r036-20200529 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2d068e534f1671459e1b135852c1b3c10502e929) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

Re: 5.6.12 MCE on AMD EPYC 7502

2020-05-29 Thread Yazen Ghannam
On Fri, May 29, 2020 at 07:57:20AM -0400, Borislav Petkov wrote: > On Fri, May 29, 2020 at 01:55:29PM +0300, Dmitry Antipov wrote: > > Hello, > > > > I'm facing the following kernel messages running Debian 9 with > > custom 5.6.12 kernel running on AMD EPYC 7502 - based hardware: > > > > [138537.

Re: [PATCH 2/4] dt-bindings: pinctrl: Document optional BCM7211 wake-up interrupts

2020-05-29 Thread Rob Herring
On Thu, May 28, 2020 at 12:21:10PM -0700, Florian Fainelli wrote: > BCM7211 supports wake-up interrupts in the form of optional interrupt > lines, one per bank, plus the "all banks" interrupt line. > > Signed-off-by: Florian Fainelli > --- > .../devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt

Re: [PATCH V2] dt-bindings: regulator: Convert anatop regulator to json-schema

2020-05-29 Thread Rob Herring
On Fri, 29 May 2020 09:59:11 +0800, Anson Huang wrote: > Convert the anatop regulator binding to DT schema format using json-schema. > > Signed-off-by: Anson Huang > --- > Changes since V1: > - remove definition of "regulator-name" which is a standrad property; > - add "unevaluatedPro

Re: [PATCH V3] dt-bindings: timer: Convert i.MX GPT to json-schema

2020-05-29 Thread Rob Herring
On Fri, 29 May 2020 10:04:42 +0800, Anson Huang wrote: > Convert the i.MX GPT binding to DT schema format using json-schema. > > Signed-off-by: Anson Huang > --- > Changes since V2: > - in compatible properties, group all the ones with the same > fallback to a single 'items' list us

Re: [PATCH 2/4] dt-bindings: pinctrl: Document optional BCM7211 wake-up interrupts

2020-05-29 Thread Florian Fainelli
On 5/29/20 12:33 PM, Rob Herring wrote: > On Thu, May 28, 2020 at 12:21:10PM -0700, Florian Fainelli wrote: >> BCM7211 supports wake-up interrupts in the form of optional interrupt >> lines, one per bank, plus the "all banks" interrupt line. >> >> Signed-off-by: Florian Fainelli >> --- >> .../dev

[PATCH] ubsan: Entirely disable alignment checks under UBSAN_TRAP

2020-05-29 Thread Kees Cook
Commit 8d58f222e85f ("ubsan: disable UBSAN_ALIGNMENT under COMPILE_TEST") tried to fix the pathological results of UBSAN_ALIGNMENT with UBSAN_TRAP (which objtool would rightly scream about), but it made an assumption about how COMPILE_TEST gets set (it is not set for randconfig). As a result, we ne

Re: Writeback bug causing writeback stalls

2020-05-29 Thread Martijn Coenen
Hi Jan, On Fri, May 29, 2020 at 5:20 PM Jan Kara wrote: > I understand. I have written a fix (attached). Currently its under testing > together with other cleanups. If everything works fine, I plan to submit > the patches on Monday. Thanks a lot for the quick fix! I ran my usual way to reproduce

Re: [PATCH v4 0/2] soc: ti: add k3 platforms chipid module driver

2020-05-29 Thread Grygorii Strashko
On 29/05/2020 22:19, santosh.shilim...@oracle.com wrote: On 5/29/20 11:34 AM, Arnd Bergmann wrote: On Fri, May 29, 2020 at 8:22 PM Grygorii Strashko wrote: On 12/05/2020 15:34, Grygorii Strashko wrote:    .../bindings/soc/ti/k3-socinfo.yaml   |  40 +    drivers/soc/ti/Kconfig

Re: [PATCH v2 3/6] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-05-29 Thread Peter Zijlstra
On Fri, May 29, 2020 at 06:16:47PM +0200, Peter Zijlstra wrote: > On Thu, May 28, 2020 at 04:05:38PM +0200, Peter Zijlstra wrote: > > +#include > > +#include > > If we change those to , in direct conflict with > what the header says about itself, all builds seem to be good again. > > s390, spar

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Heiner Kallweit
On 29.05.2020 21:21, Bjorn Helgaas wrote: > [+cc Rafael, linux-kernel] > > On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: >> On 28.05.2020 23:44, Heiner Kallweit wrote: >>> For whatever reason with this change (and losing ASPM control) I also >>> loose the PCIe PME interrupts. Th

Re: linux-next: Tree for May 29 (ocfs2)

2020-05-29 Thread Randy Dunlap
On 5/29/20 4:56 AM, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next release on Monday. > > Changes since 20200528: > on x86_64: when CONFIG_INET is not set/enabled: ld: fs/ocfs2/cluster/tcp.o: in function `o2net_accept_many': tcp.c:(.text+0x2e06): undefined reference t

Re: [PATCH] net: ethernet: mtk-star-emac: remove unused variable

2020-05-29 Thread David Miller
From: Bartosz Golaszewski Date: Fri, 29 May 2020 10:26:48 +0200 > From: Bartosz Golaszewski > > The desc pointer is set but not used. Remove it. > > Reported-by: kbuild test robot > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") > Signed-off-by: Bartosz Golaszewski Applied

Re: linux-next: Tree for May 29 (objtool warnings)

2020-05-29 Thread Randy Dunlap
On 5/29/20 4:56 AM, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next release on Monday. > > Changes since 20200528: > on x86_64: crypto/drbg.o: warning: objtool: drbg_hash_update()+0x2a6: unreachable instruction drivers/clk/clk-si5341.o: warning: objtool: si5341_synth_

Re: [PATCH net-next] net: phy: mscc: fix PHYs using the vsc8574_probe

2020-05-29 Thread David Miller
From: Antoine Tenart Date: Fri, 29 May 2020 11:49:09 +0200 > PHYs using the vsc8574_probe fail to be initialized and their > config_init return -EIO leading to errors like: > "could not attach PHY: -5". > > This is because when the conversion of the MSCC PHY driver to use the > shared PHY packag

Re: [PATCH 2/2] perf build: Allow explicitely disabling the NO_SYSCALL_TABLE variable

2020-05-29 Thread Arnaldo Carvalho de Melo
Em Fri, May 29, 2020 at 08:07:17PM +0200, Jiri Olsa escreveu: > On Fri, May 29, 2020 at 12:55:52PM -0300, Arnaldo Carvalho de Melo wrote: > > From: Arnaldo Carvalho de Melo > > > > This is useful to see if, on x86, the legacy libaudit still works, as it > > is used in architectures that don't hav

Re: [PATCH 3/4] dt-bindings: timer: renesas,cmt: Document r8a7742 CMT support

2020-05-29 Thread Geert Uytterhoeven
Hi Rob, On Fri, May 29, 2020 at 9:14 PM Rob Herring wrote: > On Fri, May 29, 2020 at 02:53:02PM +0200, Geert Uytterhoeven wrote: > > On Wed, May 27, 2020 at 11:19 PM Lad Prabhakar > > wrote: > > > Document SoC specific compatible strings for r8a7742. No driver change > > > is needed as the fallb

Re: [PATCH 8/8] blk-mq: drain I/O when all CPUs in a hctx are offline

2020-05-29 Thread Bart Van Assche
On 2020-05-29 11:13, Paul E. McKenney wrote: > On Fri, May 29, 2020 at 11:53:15AM +0800, Ming Lei wrote: >> Another pair is in blk_mq_get_tag(), and we expect the following two >> memory OPs are ordered: >> >> 1) set bit in successful test_and_set_bit_lock(), which is called >> from sbitmap_get() >

[PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Dmitry Torokhov
usbhid tries to give the device 50 milliseconds to drain its queues when opening the device, but does it naively by simply sleeping in open handler, which slows down device probing (and thus may affect overall boot time). However we do not need to sleep as we can instead mark a point of time in th

[PATCH 3/9] staging: media: atomisp: annotate an unused function

2020-05-29 Thread Arnd Bergmann
atomisp_mrfld_power() has no more callers and produces a warning: drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: error: unused function 'atomisp_mrfld_power' [-Werror,-Wunused-function] Mark the function as unused while the PM code is being debugged, expecting that it will be used agai

[PATCH 4/9] staging: media: atomisp: fix a type conversion warning

2020-05-29 Thread Arnd Bergmann
clang complains that the type conversion in the MAX() macro contains an implied integer overflow to a signed number: drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c:129:35: error: implicit conversion from 'unsigned long' to 'int32_t' (aka 'int') changes value from 184

[PATCH 8/9] staging: media: atomisp: disable all custom formats

2020-05-29 Thread Arnd Bergmann
clang points out the usage of an incorrect enum type in the list of supported image formats: drivers/staging/media/atomisp/pci/atomisp_subdev.c:49:65: error: implicit conversion from enumeration type 'enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Werror,-W

[PATCH 7/9] staging: media: atomisp: fix enum type mixups

2020-05-29 Thread Arnd Bergmann
Some function calls pass an incorrect enum type: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:858:16: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] gp_device_rst

[PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency

2020-05-29 Thread Arnd Bergmann
Without that driver, there is a link failure in ERROR: modpost: "intel_soc_pmic_exec_mipi_pmic_seq_element" [drivers/staging/media/atomisp/pci/atomisp_gmin_platform.ko] undefined! Add an explicit Kconfig dependency. Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/Kconfig | 1 +

[PATCH 6/9] staging: media: atomisp: fix type mismatch

2020-05-29 Thread Arnd Bergmann
The caller passes a variable of a different enum type: drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c:1707:64: error: implicit conversion from enumeration type 'const enum ia_css_frame_format' to different enumeration type 'enum atomisp_input_format' [-Werror,-Wenum-conversion]

[PATCH 5/9] staging: media: atomisp: fix stack overflow in init_pipe_defaults()

2020-05-29 Thread Arnd Bergmann
When building with clang, multiple copies of the structures to be initialized are passed around on the stack and copied locally, using an insane amount of stack space: drivers/staging/media/atomisp/pci/sh_css.c:2371:1: error: stack frame size of 26864 bytes in function 'create_pipe' [-Werror,-Wfr

Re: Some -serious- BPF-related litmus tests

2020-05-29 Thread Andrii Nakryiko
On Fri, May 29, 2020 at 5:36 AM Peter Zijlstra wrote: > > On Thu, May 28, 2020 at 10:14:21PM -0700, Andrii Nakryiko wrote: > > > There is another cluster of applications which are unnecessarily more > > complicated just for the fact that there is no ordering between > > correlated events that happ

[PATCH 2/9] staging: media: atomisp: declare 'struct device' before using it

2020-05-29 Thread Arnd Bergmann
In some configurations, including this header leads to a warning: drivers/staging/media/atomisp//pci/sh_css_firmware.h:41:38: error: declaration of 'struct device' will not be visible outside of this function [-Werror,-Wvisibility] Make sure the struct tag is known before declaring a function t

[PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check

2020-05-29 Thread Arnd Bergmann
Checking the pointer to a member of a struct against NULL is pointless as clang points out: drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: error: address of 'config->info' will always evaluate to 'true' Check the original pointer instead, which may also be unnecessary here, but makes a

Re: [PATCH v7 1/4] bitops: Introduce the the for_each_set_clump macro

2020-05-29 Thread Syed Nayyar Waris
On Sat, May 30, 2020 at 12:08 AM Andy Shevchenko wrote: > > On Fri, May 29, 2020 at 11:38:18PM +0530, Syed Nayyar Waris wrote: > > On Sun, May 24, 2020 at 8:15 PM kbuild test robot wrote: > > ... > > > >579 static inline unsigned long bitmap_get_value(const unsigned long > > > *map, > > >

[PATCH 3/4] selftests/lkdtm: Reset WARN_ONCE to avoid false negatives

2020-05-29 Thread Kees Cook
Since we expect to see warnings every time for many tests, just reset the WARN_ONCE flags each time the script runs. Signed-off-by: Kees Cook --- tools/testing/selftests/lkdtm/run.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/lkdtm/run.sh b/tools/testing/s

[PATCH 1/4] lkdtm: Avoid more compiler optimizations for bad writes

2020-05-29 Thread Kees Cook
It seems at least Clang is able to throw away writes it knows are destined for read-only memory, which makes things like the WRITE_RO test fail, as the write gets elided. Instead, force the variable to be volatile, and make similar changes through-out other tests in an effort to avoid needing to re

[PATCH 4/4] lkdtm: Make arch-specific tests always available

2020-05-29 Thread Kees Cook
I'd like arch-specific tests to XFAIL when on a mismatched architecture so that we can more easily compare test coverage across all systems. Lacking kernel configs or CPU features count as a FAIL, not an XFAIL. Signed-off-by: Kees Cook --- drivers/misc/lkdtm/bugs.c | 34 +++

Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 12:04 PM, Paolo Bonzini wrote: On 29/05/20 20:10, Krish Sadhukhan wrote: Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, since the map is not used elsewhere in the function.  There are just two calls, so move it there. The last sentence sounds bit incomplete.

Re: [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check

2020-05-29 Thread Nick Desaulniers
See also Nathan's 7 patch series. https://lore.kernel.org/lkml/20200527071150.3381228-1-natechancel...@gmail.com/ Might be some overlap between series? On Fri, May 29, 2020 at 1:00 PM Arnd Bergmann wrote: > > Checking the pointer to a member of a struct against NULL > is pointless as clang point

[PATCH drivers/misc 0/4] lkdtm: Various clean ups

2020-05-29 Thread Kees Cook
Hi Greg, Can you please apply these patches to your drivers/misc tree for LKDTM? It's mostly a collection of fixes and improvements and tweaks to the selftest integration. Thanks! -Kees Kees Cook (4): lkdtm: Avoid more compiler optimizations for bad writes lkdtm/heap: Avoid edge and middle

[PATCH 2/4] lkdtm/heap: Avoid edge and middle of slabs

2020-05-29 Thread Kees Cook
Har har, after I moved the slab freelist pointer into the middle of the slab, now it looks like the contents are getting poisoned. Adjust the test to avoid the freelist pointer again. Fixes: 3202fa62fb43 ("slub: relocate freelist pointer to middle of object") Cc: sta...@vger.kernel.org Signed-off-

[PATCH] cpuidle/firmware: qcom: fix smcc dependencies

2020-05-29 Thread Arnd Bergmann
Selecting QCOM_SCM for compile-tests is broken when the smcc firmware is not provided: drivers/firmware/qcom_scm-smc.o: in function `scm_smc_call': qcom_scm-smc.c:(.text+0x110): undefined reference to `__arm_smccc_smc' drivers/firmware/qcom_scm-legacy.o: in function `scm_legacy_call': qcom_scm-smc

[PATCH] ASoC: SOF: Intel: byt: fix unused-function warnings

2020-05-29 Thread Arnd Bergmann
Several functions in this driver are only referenced for baytrail-class configurations and building configurations with only merrifield enabled causes a warning: sound/soc/sof/intel/byt.c:447:12: error: unused function 'byt_suspend' [-Werror,-Wunused-function] static int byt_suspend(struct snd_so

RE: [PATCH v8 0/2] ACPI / APEI: Add support to notify the vendor specific HW errors

2020-05-29 Thread Shiju Jose
Please ignore this patch set. Resending soon. Thanks, Shiju >-Original Message- >From: Shiju Jose >Sent: 29 May 2020 18:39 >To: linux-a...@vger.kernel.org; linux-...@vger.kernel.org; linux- >ker...@vger.kernel.org; r...@rjwysocki.net; b...@alien8.de; >james.mo...@arm.com; helg...@kernel.o

[PATCH RESEND v8 0/2] ACPI / APEI: Add support to notify the vendor specific HW errors

2020-05-29 Thread Shiju Jose
Presently the vendor drivers are unable to do the recovery for the vendor specific recoverable HW errors because APEI driver does not support reporting the error to the vendor drivers. patch set 1. add new interface to the APEI driver for reporting the vendor specific non-fatal HW errors to th

[PATCH RESEND v8 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors

2020-05-29 Thread Shiju Jose
From: Yicong Yang The HiSilicon HIP PCIe controller is capable of handling errors on root port and perform port reset separately at each root port. This patch add error handling driver for HIP PCIe controller to log and report recoverable errors. Perform root port reset and restore link status a

[PATCH RESEND v8 1/2] ACPI / APEI: Add support to notify the vendor specific HW errors

2020-05-29 Thread Shiju Jose
Add support to report the vendor specific non-fatal HW errors to the drivers for the error recovery. Signed-off-by: Shiju Jose --- drivers/acpi/apei/ghes.c | 130 ++- include/acpi/ghes.h | 28 + 2 files changed, 157 insertions(+), 1 deletion(-)

Re: mmotm 2020-05-13-20-30 uploaded (objtool warnings)

2020-05-29 Thread Al Viro
On Fri, May 29, 2020 at 12:31:04PM -0700, Linus Torvalds wrote: > On Fri, May 29, 2020 at 9:50 AM Josh Poimboeuf wrote: > > > > From staring at the asm I think the generated code is correct, it's just > > that the nested likelys with ftrace profiling cause GCC to converge the > > error/success pat

Re: [PATCH v2 3/3] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD

2020-05-29 Thread Kees Cook
On Fri, May 29, 2020 at 06:46:07PM +, Sargun Dhillon wrote: > On Fri, May 29, 2020 at 12:41:51AM -0700, Kees Cook wrote: > > On Thu, May 28, 2020 at 04:08:58AM -0700, Sargun Dhillon wrote: > > > + EXPECT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0); > > > + > > > + nextid = req.id +

Re: [PATCH 3/3] power: supply: max17040: Set rcomp value

2020-05-29 Thread Jonathan Bakker
Hi Sebastian, I'm sorry, I messed up my rebase on top of the low battery alert and it somehow slipped through my pre-submit checklist. Before resubmitting, do you want the rcomp changed in any manner (where the datasheet doesn't specify if its the full 16 bits or only 8 bites for max17040 but doe

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Heiner Kallweit
On 29.05.2020 21:40, Heiner Kallweit wrote: > On 29.05.2020 21:21, Bjorn Helgaas wrote: >> [+cc Rafael, linux-kernel] >> >> On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: >>> On 28.05.2020 23:44, Heiner Kallweit wrote: For whatever reason with this change (and losing ASPM con

Re: Some -serious- BPF-related litmus tests

2020-05-29 Thread Andrii Nakryiko
On Fri, May 29, 2020 at 10:23 AM Joel Fernandes wrote: > > On Thu, May 28, 2020 at 09:38:35PM -0700, Andrii Nakryiko wrote: > > On Thu, May 28, 2020 at 2:48 PM Joel Fernandes > > wrote: > > > > > > On Mon, May 25, 2020 at 11:38:23AM -0700, Andrii Nakryiko wrote: > > > > On Mon, May 25, 2020 at 7

Re: [PATCH 1/4] lkdtm: Avoid more compiler optimizations for bad writes

2020-05-29 Thread Nick Desaulniers
On Fri, May 29, 2020 at 1:03 PM Kees Cook wrote: > > It seems at least Clang is able to throw away writes it knows are > destined for read-only memory, which makes things like the WRITE_RO test > fail, as the write gets elided. Instead, force the variable to be Heh, yep. I recall the exact patch

Re: remove kernel_setsockopt v4

2020-05-29 Thread David Miller
From: Christoph Hellwig Date: Fri, 29 May 2020 14:09:39 +0200 > now that only the dlm calls to sctp are left for kernel_setsockopt, > while we haven't really made much progress with the sctp setsockopt > refactoring, how about this small series that splits out a > sctp_setsockopt_bindx_kernel tha

[PATCH] iommu/amd: Fix event counter availability check

2020-05-29 Thread Alexander Monakov
The driver performs an extra check if the IOMMU's capabilities advertise presence of performance counters: it verifies that counters are writable by writing a hard-coded value to a counter and testing that reading that counter gives back the same value. Unfortunately it does so quite early, even b

[PATCH] flow_dissector: work around stack frame size warning

2020-05-29 Thread Arnd Bergmann
The fl_flow_key structure is around 500 bytes, so having two of them on the stack in one function now exceeds the warning limit after an otherwise correct change: net/sched/cls_flower.c:298:12: error: stack frame size of 1056 bytes in function 'fl_classify' [-Werror,-Wframe-larger-than=] I suspe

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Guenter Roeck
On Fri, May 29, 2020 at 12:59:51PM -0700, Dmitry Torokhov wrote: > usbhid tries to give the device 50 milliseconds to drain its queues > when opening the device, but does it naively by simply sleeping in open > handler, which slows down device probing (and thus may affect overall > boot time). > >

<    5   6   7   8   9   10   11   12   13   14   >