Re: [patch V4 part 2 17/18] x86/kvm/vmx: Move guest enter/exit into .noinstr.text

2020-05-06 Thread Paolo Bonzini
On 05/05/20 15:41, Thomas Gleixner wrote: > Move the functions which are inside the RCU off region into the > non-instrumentable text section. > > Signed-off-by: Thomas Gleixner > Cc: Paolo Bonzini > Cc: Sean Christopherson > --- > arch/x86/include/asm/hardirq.h |4 - > arch/x86/include/a

[PATCH v12 01/10] KVM: VMX: Introduce CET VMCS fields and flags

2020-05-06 Thread Yang Weijiang
CET(Control-flow Enforcement Technology) is a CPU feature used to prevent Return/Jump-Oriented Programming(ROP/JOP) attacks. It provides the following sub-features to defend against ROP/JOP style control-flow subversion attacks: Shadow Stack (SHSTK): A second stack for program which is used excl

[PATCH v12 04/10] KVM: x86: Refresh CPUID once guest changes XSS bits

2020-05-06 Thread Yang Weijiang
CPUID(0xd, 1) reports the current required storage size of XCR0 | XSS, when guest updates the XSS, it's necessary to update the CPUID leaf, otherwise guest will fetch old state size, and results to some WARN traces during guest running. supported_xss is initialized to host_xss & KVM_SUPPORTED_XSS

[kvm-unit-tests PATCH v2] x86: Add test cases for user-mode CET validation

2020-05-06 Thread Yang Weijiang
This unit test is intended to test user-mode CET support of KVM, it's tested on Intel new platform. Two CET features: Shadow Stack Protection(SHSTK) and Indirect-Branch Tracking(IBT) are enclosed. In SHSTK test, if the function return-address in normal stack is tampered with a value not equal to t

[PATCH v12 06/10] KVM: x86: Add userspace access interface for CET MSRs

2020-05-06 Thread Yang Weijiang
There're two different places storing Guest CET states, states managed with XSAVES/XRSTORS, as restored/saved in previous patch, can be read/write directly from/to the MSRs. For those stored in VMCS fields, they're access via vmcs_read/vmcs_write. To correctly read/write the CET MSRs, it's necessa

Re: [PATCH net-next 1/2] virtio-net: don't reserve space for vnet header for XDP

2020-05-06 Thread Jason Wang
On 2020/5/6 下午3:53, Michael S. Tsirkin wrote: On Wed, May 06, 2020 at 02:16:32PM +0800, Jason Wang wrote: We tried to reserve space for vnet header before xdp.data_hard_start. But this is useless since the packet could be modified by XDP which may invalidate the information stored in the heade

Re: [PATCH v2 1/2] perf evsel: Create counts for collecting summary data

2020-05-06 Thread Jin, Yao
Hi Jiri, On 5/5/2020 7:50 AM, Jiri Olsa wrote: On Sat, May 02, 2020 at 10:07:04AM +0800, Jin Yao wrote: It would be useful to support the overall statistics for perf-stat interval mode. For example, report the summary at the end of "perf-stat -I" output. But since perf-stat can support many ag

[PATCH v12 00/10] Introduce support for guest CET feature

2020-05-06 Thread Yang Weijiang
Control-flow Enforcement Technology (CET) provides protection against Return/Jump-Oriented Programming (ROP/JOP) attack. There're two CET sub-features: Shadow Stack (SHSTK) and Indirect Branch Tracking (IBT). SHSTK is to prevent ROP programming and IBT is to prevent JOP programming. Several parts

[PATCH v12 09/10] KVM: x86: Add #CP support in guest exception dispatch

2020-05-06 Thread Yang Weijiang
CPU defined #CP(21) to handle CET induced exception, it's accompanied with several error codes corresponding to different CET violation cases, see SDM for detailed description. The exception is classified as a contibutory exception w.r.t #DF. Signed-off-by: Yang Weijiang --- arch/x86/include/uap

[PATCH v12 07/10] KVM: VMX: Enable CET support for nested VM

2020-05-06 Thread Yang Weijiang
CET MSRs pass through guests for performance consideration. Configure the MSRs to match L0/L1 settings so that nested VM is able to run with CET. Add assertions for vmcs12 offset table initialization, these assertions can detect the mismatch of VMCS field encoding and data type at compiling time.

[PATCH v12 10/10] KVM: x86: Enable CET virtualization and advertise CET to userspace

2020-05-06 Thread Yang Weijiang
Set the feature bits so that CET capabilities can be seen in guest via CPUID enumeration. Add CR4.CET bit support in order to allow guest set CET master control bit(CR4.CET). Signed-off-by: Yang Weijiang --- arch/x86/include/asm/kvm_host.h | 3 ++- arch/x86/kvm/cpuid.c| 5 +++-- 2 fi

[PATCH v12 05/10] KVM: x86: Load guest fpu state when access MSRs managed by XSAVES

2020-05-06 Thread Yang Weijiang
From: Sean Christopherson A handful of CET MSRs are not context switched through "traditional" methods, e.g. VMCS or manual switching, but rather are passed through to the guest and are saved and restored by XSAVES/XRSTORS, i.e. in the guest's FPU state. Load the guest's FPU state if userspace i

[PATCH v12 08/10] KVM: VMX: Add VMCS dump and sanity check for CET states

2020-05-06 Thread Yang Weijiang
Dump CET VMCS states for debug purpose. Since CET kernel protection is not enabled, if related MSRs in host are filled by mistake, warn once on detecting it. Signed-off-by: Yang Weijiang --- arch/x86/kvm/vmx/vmx.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/

Re: [patch V4 part 5 02/31] x86/entry: Provide helpers for execute on irqstack

2020-05-06 Thread Thomas Gleixner
Thomas Gleixner writes: > That also allows to move the xen hypercall extra magic code and the softirq > stack switching into C. > > The mechanism is straight forward: > > 1) Store the current stack pointer on top of the interrupt stack. That's > required for the unwinder. > > 2) Switch t

[PATCH v12 03/10] KVM: VMX: Configure CET settings upon guest CR0/4 changing

2020-05-06 Thread Yang Weijiang
CR4.CET is master control bit for CET function. There're mutual constrains between CR0.WP and CR4.CET, so need to check the dependent bit while changing the control registers. The processor does not allow CR4.CET to be set if CR0.WP = 0,similarly, it does not allow CR0.WP to be cleared while CR4.C

[PATCH v12 02/10] KVM: VMX: Set guest CET MSRs per KVM and host configuration

2020-05-06 Thread Yang Weijiang
CET MSRs pass through guest directly to enhance performance. CET runtime control settings are stored in MSR_IA32_{U,S}_CET, Shadow Stack Pointer(SSP) are stored in MSR_IA32_PL{0,1,2,3}_SSP, SSP table base address is stored in MSR_IA32_INT_SSP_TAB, these MSRs are defined in kernel and re-used here.

Re: [PATCH net-next 2/2] virtio-net: fix the XDP truesize calculation for mergeable buffers

2020-05-06 Thread Jason Wang
On 2020/5/6 下午3:37, Michael S. Tsirkin wrote: On Wed, May 06, 2020 at 02:16:33PM +0800, Jason Wang wrote: We should not exclude headroom and tailroom when XDP is set. So this patch fixes this by initializing the truesize from PAGE_SIZE when XDP is set. Cc: Jesper Dangaard Brouer Signed-off-by

Re: [PATCH net-next 1/2] virtio-net: don't reserve space for vnet header for XDP

2020-05-06 Thread Jesper Dangaard Brouer
On Wed, 6 May 2020 14:16:32 +0800 Jason Wang wrote: > We tried to reserve space for vnet header before > xdp.data_hard_start. But this is useless since the packet could be > modified by XDP which may invalidate the information stored in the > header and IMHO above statements are wrong. XDP cann

Re: [PATCH 3/3] mm/swapfile.c: count won't be bigger than SWAP_MAP_MAX

2020-05-06 Thread Huang, Ying
Wei Yang writes: > On Fri, May 01, 2020 at 03:48:53PM -0700, Andrew Morton wrote: >>On Fri, 1 May 2020 01:52:59 + Wei Yang wrote: >> >>> When the condition is true, there are two possibilities: >> >>I'm struggling with this one. >> >>>1. count == SWAP_MAP_BAD >>>2. count == (SWAP_MA

[PATCH] nvme/core:disable streams when get stream params failed

2020-05-06 Thread Wu Bo
After enable nvme streams, then if get stream params failed, We should disable streams before return error in nvme_configure_directives() function. Signed-off-by: Wu Bo --- drivers/nvme/host/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c

[PATCH rdma-next v1 00/10] Enable asynchronous event FD per object

2020-05-06 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: Forgot to add patch "IB/uverbs: Move QP, SRQ, WQ type and flags to UAPI" v0: https://lore.kernel.org/lkml/20200506074049.8347-1-l...@kernel.org --- >From Yishai: This series enables

Re: [PATCH v3 07/10] dt-bindings: memory-controller: add STM32 FMC2 EBI controller documentation

2020-05-06 Thread Christophe Kerello
On 5/5/20 7:11 PM, Christophe Kerello wrote: This patch adds the documentation of the device tree bindings for the STM32 FMC2 EBI controller. Signed-off-by: Christophe Kerello --- Changes in v3: - pattern name has been modified - vendor properties have been modified - s/_/-/ - ad

[PATCH] dt-bindings: phy: usb-snps-femto-v2: Add regulator entries to example

2020-05-06 Thread Wesley Cheng
Fix errors reported by dt_binding_check, due to missing required regulators in the example node. Fixes: f06b9fc9a814 ("dt-bindings: phy: Add binding for qcom,usb-snps-femto-v2") Signed-off-by: Wesley Cheng Reported-by: Rob Herring --- Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2

Re: [PATCH] spi: sun6i: Add support for GPIO chip select lines

2020-05-06 Thread Geert Uytterhoeven
Hi Alistair, On Wed, May 6, 2020 at 3:41 AM Alistair Francis wrote: > Add a setup function that can be used to support using generic GPIO > lines for the chip select. > > Signed-off-by: Alistair Francis > --- > drivers/spi/spi-sun6i.c | 27 +++ > 1 file changed, 27 inser

Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

2020-05-06 Thread Russell King - ARM Linux admin
On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return > "0" on line 161 NAK. Look closer at what the code is doing, thanks. This warning is basically incorrect. -- RMK's Pa

Re: [PATCH] dma-buf: fix use-after-free in dmabuffs_dname

2020-05-06 Thread Charan Teja Kalla
Thank you Greg for the reply. On 5/5/2020 3:38 PM, Greg KH wrote: On Tue, Apr 28, 2020 at 01:24:02PM +0530, Charan Teja Reddy wrote: The following race occurs while accessing the dmabuf object exported as file: P1 P2 dma_buf_release() dmabuffs_dname()

Re: [PATCH v2 1/2] iopoll: Introduce read_poll_timeout_atomic macro

2020-05-06 Thread Kalle Valo
Kai-Heng Feng wrote: > Like read_poll_timeout, an atomic variant for multiple parameter read > function can be useful. > > Will be used by a later patch. > > Signed-off-by: Kai-Heng Feng Patch applied to wireless-drivers-next.git, thanks. 57a29df34146 iopoll: Introduce read_poll_timeout_atom

Re: [PATCH v2 2/2] rtw88: Use udelay instead of usleep in atomic context

2020-05-06 Thread Kalle Valo
Kai-Heng Feng wrote: > It's incorrect to use usleep in atomic context. > > Switch to a macro which uses udelay instead of usleep to prevent the issue. > > Fixes: 6343a6d4b213 ("rtw88: Add delay on polling h2c command status bit") > Signed-off-by: Kai-Heng Feng Patch applied to wireless-driver

Re: [PATCH v2] ipw2x00: Remove a memory allocation failure log message

2020-05-06 Thread Kalle Valo
Christophe JAILLET wrote: > Axe a memory allocation failure log message. This message is useless and > incorrect (vmalloc is not used here for the memory allocation) > > This has been like that since the very beginning of this driver in > commit 43f66a6ce8da ("Add ipw2200 wireless driver.") > >

Re: [PATCH v3 1/2] arm: rpi: Add function to trigger VL805's firmware load

2020-05-06 Thread Nicolas Saenz Julienne
Hi Bin, On Wed, 2020-05-06 at 13:33 +0800, Bin Meng wrote: > Hi Nicolas, > > On Wed, May 6, 2020 at 12:26 AM Nicolas Saenz Julienne > wrote: > > On the Raspberry Pi 4, after a PCI reset, VL805's (a xHCI chip) firmware > > may either be loaded directly from an EEPROM or, if not present, by the >

Re: [PATCH] rtlwifi: use true,false for bool variable in rtl_init_rfkill()

2020-05-06 Thread Kalle Valo
Jason Yan wrote: > The 'blocked' is a bool variable, and '==' expression itself is bool > too. So no need to convert it to 0/1. > > This fixes the following coccicheck warning: > > drivers/net/wireless/realtek/rtlwifi/base.c:508:13-41: WARNING: > Comparison of 0/1 to bool variable > > Signed-o

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Thomas Gleixner
Thomas Gleixner writes: Bah. I managed to lose the From: Peterz line somehow.

Re: [PATCH v2] ray_cs: use true,false for bool variable

2020-05-06 Thread Kalle Valo
Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to > bool variable > drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to > bool variable > > Signed-off-by: Jason Yan Patch applied to wireless-d

Re: [PATCH net-next 1/2] virtio-net: don't reserve space for vnet header for XDP

2020-05-06 Thread Jason Wang
On 2020/5/6 下午4:21, Jesper Dangaard Brouer wrote: On Wed, 6 May 2020 14:16:32 +0800 Jason Wang wrote: We tried to reserve space for vnet header before xdp.data_hard_start. But this is useless since the packet could be modified by XDP which may invalidate the information stored in the header

Re: [RFC, WIP, v4 08/11] media: vidtv: implement a PSI generator

2020-05-06 Thread Mauro Carvalho Chehab
Em Wed, 6 May 2020 03:28:17 -0300 "Daniel W. S. Almeida" escreveu: > >> + /* Just a sanity check, should not really happen because we stuff > >> + * the packet when we finish a section, i.e. when we write the crc at > >> + * the end. But if this happens then we have messed up the logic > >>

Re: performance bug in virtio net xdp

2020-05-06 Thread Jesper Dangaard Brouer
On Wed, 6 May 2020 04:08:27 -0400 "Michael S. Tsirkin" wrote: > So for mergeable bufs, we use ewma machinery to guess the correct buffer > size. If we don't guess correctly, XDP has to do aggressive copies. > > Problem is, xdp paths do not update the ewma at all, except > sometimes with XDP_PASS

Re: performance bug in virtio net xdp

2020-05-06 Thread Jason Wang
On 2020/5/6 下午4:08, Michael S. Tsirkin wrote: So for mergeable bufs, we use ewma machinery to guess the correct buffer size. If we don't guess correctly, XDP has to do aggressive copies. Problem is, xdp paths do not update the ewma at all, except sometimes with XDP_PASS. So whatever we happen

Re: [PATCH net v1] rtw88: fix an issue about leak system resources

2020-05-06 Thread Kalle Valo
Dejin Zheng wrote: > the related system resources were not released when pci_iomap() return > error in the rtw_pci_io_mapping() function. add pci_release_regions() to > fix it. > > Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver") > Cc: Andy Shevchenko > Signed-off-by: Dejin Zheng

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Borislav Petkov
On Tue, May 05, 2020 at 03:16:05PM +0200, Thomas Gleixner wrote: > The scheduler IPI has grown weird and wonderful over the years, time > for spring cleaning. > > Move all the non-trivial stuff out of it and into a regular smp function > call IPI. This then reduces the schedule_ipi() to most of it

Re: [PATCH v6] MIPS: Loongson: Add DMA support for LS7A

2020-05-06 Thread Huacai Chen
Hi, Tiezhu, On Wed, May 6, 2020 at 2:39 PM Tiezhu Yang wrote: > > On 04/30/2020 02:19 PM, Huacai Chen wrote: > > Hi Christoph, > > > > On Thu, Apr 30, 2020 at 10:31 AM Tiezhu Yang wrote: > >> In the current market, the most used bridge chip on the Loongson > >> platform are RS780E and LS7A, the

[PATCH v2 1/2] [media] mtk-mdp: add driver to probe mdp components

2020-05-06 Thread Eizan Miyamoto
Broadly, this patch (1) adds a driver for various MTK MDP components to go alongside the main MTK MDP driver, and (2) hooks them all together using the component framework. (1) Up until now, the MTK MDP driver controls 8 devices in the device tree on its own. When running tests for the hardware vi

[PATCH v2 0/2] Refactor MDP driver and add dummy component driver

2020-05-06 Thread Eizan Miyamoto
This series depends on all changes in the series: https://patchwork.kernel.org/patch/11530275/ We are adding a dummy MDP component driver so that all the components are properly configured with IOMMUs and LARBs. This is required for us to get hardware video decode working in 4.19, and possibly n

[PATCH v2 2/2] [media] mtk-mdp: use pm_runtime in MDP component driver

2020-05-06 Thread Eizan Miyamoto
Without this change, the MDP components are not fully integrated into the runtime power management subsystem, and the MDP driver does not work. For each of the component device drivers to be able to call pm_runtime_get/put_sync() a pointer to the component's device struct had to be added to struct

Re: [PATCH] brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame()

2020-05-06 Thread Kalle Valo
Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1781:9-12: > WARNING: Comparison to bool > drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8: > WARNING: Comparison to bool > > Signed-off-by: Jason Yan > Reviewed-

Re: [PATCH] brcmsmac: remove Comparison to bool in brcms_b_txstatus()

2020-05-06 Thread Kalle Valo
Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:1060:6-12: > WARNING: Comparison to bool > > Signed-off-by: Jason Yan Patch applied to wireless-drivers-next.git, thanks. 4f5cf93395d7 brcmsmac: remove Comparison to bool in b

Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

2020-05-06 Thread Jason Yan
在 2020/5/6 16:29, Russell King - ARM Linux admin 写道: On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: Fix the following coccicheck warning: arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 NAK. Look closer at what the code is doing, thanks.

Re: [PATCH] rtlwifi: remove comparison of 0/1 to bool variable

2020-05-06 Thread Kalle Valo
Jason Yan wrote: > The variable 'rtlpriv->rfkill.rfkill_state' is bool and can directly > assigned to bool values. > > Fix the following coccicheck warning: > > drivers/net/wireless/realtek/rtlwifi/core.c:1725:14-42: WARNING: > Comparison of 0/1 to bool variable > > Signed-off-by: Jason Yan

Re: [PATCH 03/15] mwifiex: avoid -Wstringop-overflow warning

2020-05-06 Thread Kalle Valo
Arnd Bergmann wrote: > gcc-10 reports a warning for mwifiex_cmd_802_11_key_material_v1: > > drivers/net/wireless/marvell/mwifiex/sta_cmd.c: In function > 'mwifiex_cmd_802_11_key_material_v1': > cc1: warning: writing 16 bytes into a region of size 0 [-Wstringop-overflow=] > In file included from

Re: [PATCH] libertas_tf: avoid a null dereference in pointer priv

2020-05-06 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Currently there is a check if priv is null when calling lbtf_remove_card > but not in a previous call to if_usb_reset_dev that can also dereference > priv. Fix this by also only calling lbtf_remove_card if priv is null. > > It is noteable that ther

Re: [PATCH] b43: remove Comparison of 0/1 to bool variable in phy_n.c

2020-05-06 Thread Kalle Valo
Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/broadcom/b43/phy_n.c:5510:19-32: WARNING: > Comparison of 0/1 to bool variable > > Signed-off-by: Jason Yan Patch applied to wireless-drivers-next.git, thanks. e2b9ac590810 b43: remove Comparison of 0/1 to bool

Re: [PATCH] b43: remove Comparison of 0/1 to bool variable in pio.c

2020-05-06 Thread Kalle Valo
Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/broadcom/b43/pio.c:768:10-25: WARNING: Comparison > of 0/1 to bool variable > > Signed-off-by: Jason Yan Patch applied to wireless-drivers-next.git, thanks. f8f24ece2192 b43: remove Comparison of 0/1 to bool va

Re: [PATCH] rtlwifi: rtl8188ee: remove Comparison to bool in rf.c

2020-05-06 Thread Kalle Valo
Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:476:6-14: WARNING: > Comparison to bool > drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:54:5-22: WARNING: > Comparison to bool > > Signed-off-by: Jason Yan Patch applied to w

Re: [PATCH v2 08/10] EDAC/ghes: Carve out MC device handling into separate functions

2020-05-06 Thread Robert Richter
On 27.04.20 18:38:56, Borislav Petkov wrote: > On Wed, Apr 22, 2020 at 01:58:12PM +0200, Robert Richter wrote: > > +static int ghes_mc_add_or_free(struct mem_ctl_info *mci, > > + struct list_head *dimm_list) > > No, I think we talked about this already. This function should be >

Re: [patch V4 part 2 15/18] x86/kvm/svm: Handle hardirqs proper on guest enter/exit

2020-05-06 Thread Thomas Gleixner
Paolo Bonzini writes: > On 05/05/20 15:41, Thomas Gleixner wrote: >> /* >> - * Tell context tracking that this CPU is back. >> + * VMEXIT disables interrupts (host state, see the CLI in the ASM >> + * above), > > Apart from the small inaccuracy in that CLI has moved to vmenter.S,

[PATCH] Input: elants_i2c: Provide an attribute to show calibration count

2020-05-06 Thread Johnny Chuang
From: Johnny Chuang There is an non-touch case by non-calibration after update firmware. Elan could know calibrate or not by calibration count. The value of '0x' means we didn't calibrate after update firmware. If calibrate success, it will plus one and change to '0x'. Signed-off-by: Joh

Re: KASAN: slab-out-of-bounds Read in hfa384x_usbin_callback

2020-05-06 Thread Oliver Neukum
Am Freitag, den 20.03.2020, 12:28 -0700 schrieb syzbot: > Hello, > > syzbot found the following crash on: > > HEAD commit:e17994d1 usb: core: kcov: collect coverage from usb comple.. > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.c

Re: [PATCH v2 00/10] EDAC/mc/ghes: Fixes, cleanup and reworks

2020-05-06 Thread Robert Richter
Boris, On 22.04.20 13:58:04, Robert Richter wrote: > This series contains edac fixes and a significant cleanup and rework > of the ghes driver: > > * fixes and updates for edac_mc (patches #1, #2), > > * removed smbios_handle from struct dimm_info (patch #4), > > * fix of DIMM label in error

[PATCH -next] i2c: nvidia-gpu: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread Samuel Zou
Fixes coccicheck warning: drivers/i2c/busses/i2c-nvidia-gpu.c:280:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/i2c/busses/i2c-nvidia-gpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-n

Re: [RFC, WIP, v4 09/11] media: vidtv: implement a PES packetizer

2020-05-06 Thread Mauro Carvalho Chehab
Em Wed, 6 May 2020 03:55:48 -0300 "Daniel W. S. Almeida" escreveu: > Hi Mauro, > > > > As commented, don't use WARN_ON(). At most, you could use WARN_ON_ONCE(), > > as otherwise, you may end by causing serious performance issues if > > the code starts to produce a flood of warnings at the dmesg

Re: [PATCH] dma-buf: fix use-after-free in dmabuffs_dname

2020-05-06 Thread Greg KH
On Wed, May 06, 2020 at 02:00:10PM +0530, Charan Teja Kalla wrote: > Thank you Greg for the reply. > > On 5/5/2020 3:38 PM, Greg KH wrote: > > On Tue, Apr 28, 2020 at 01:24:02PM +0530, Charan Teja Reddy wrote: > > > The following race occurs while accessing the dmabuf object exported as > > > file

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-06 Thread Jun Li
John Stultz 于2019年10月30日周三 上午5:18写道: > > On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: > > John Stultz writes: > > > From: Yu Chen > > > > > > It needs more time for the device controller to clear the CmdAct of > > > DEPCMD on Hisilicon Kirin Soc. > > > > Why does it need more time? Why i

[v4,iproute2-next 1/2] iproute2-next:tc:action: add a gate control action

2020-05-06 Thread Po Liu
Introduce a ingress frame gate control flow action. Tc gate action does the work like this: Assume there is a gate allow specified ingress frames can pass at specific time slot, and also drop at specific time slot. Tc filter chooses the ingress frames, and tc gate action would specify what slot doe

[v4,iproute2-next 2/2] iproute2-next: add gate action man page

2020-05-06 Thread Po Liu
This patch is to add the man page for the tc gate action. Signed-off-by: Po Liu --- man/man8/tc-gate.8 | 123 + 1 file changed, 123 insertions(+) create mode 100644 man/man8/tc-gate.8 diff --git a/man/man8/tc-gate.8 b/man/man8/tc-gate.8 new file mode

Re: [RFC, WIP, v4 11/11] media: vidtv: Add a MPEG Transport Stream Multiplexer

2020-05-06 Thread Mauro Carvalho Chehab
Em Wed, 6 May 2020 04:05:25 -0300 "Daniel W. S. Almeida" escreveu: > Hi Mauro! Thank you for reviewing this! > > > >> Add a MPEG Transport Stream multiplexer responsible for polling encoders, > >> interleaving packets, padding the resulting stream with NULL packets if > >> necessary and then de

Re: [PATCH] usb: gadget: audio: Fix a missing error return value in audio_bind()

2020-05-06 Thread Peter Chen
On 20-05-03 12:47:07, Christophe JAILLET wrote: > If 'usb_otg_descriptor_alloc()' fails, we must return an error code, not 0. > > Fixes: 56023ce0fd70 ("usb: gadget: audio: allocate and init otg descriptor by > otg capabilities") > Signed-off-by: Christophe JAILLET > --- > drivers/usb/gadget/leg

Re: [PATCH] dt-bindings: phy: usb-snps-femto-v2: Add regulator entries to example

2020-05-06 Thread Vinod Koul
On 06-05-20, 01:26, Wesley Cheng wrote: > Fix errors reported by dt_binding_check, due to missing required > regulators in the example node. Applied, thanks -- ~Vinod

Re: [PATCH] netfilter: fix make target xt_TCPMSS.o error.

2020-05-06 Thread Jan Engelhardt
On Wednesday 2020-05-06 08:50, Huang Qijun wrote: >When compiling netfilter, there will be an error >"No rule to make target 'net/netfilter/xt_TCPMSS.o'", >because the xt_TCPMSS.c in the makefile is uppercase, >and the file name of the source file (xt_tcpmss.c) is lowercase. >-obj-$(CONFIG_NETFIL

Kindly Acknowledge Receipt

2020-05-06 Thread JEAN MARIE
I 'm a Financial Consultant. under my network as a financial consultant, there are few private investors offering capital injection as project funding or business expansion in critical areas of Investment placements such as Real Estate, Healthcare, Transportation and Agriculture. Get back to me

[PATCH v4 06/10] dt-bindings: mtd: update STM32 FMC2 NAND controller documentation

2020-05-06 Thread Christophe Kerello
These bindings can be used on SOCs where the FMC2 NAND controller is in standalone. In case that the FMC2 embeds 2 controllers (an external bus controller and a raw NAND controller), the register base and the clock will be defined in the parent node. It is the reason why the register base address a

[PATCH v4 00/10] add STM32 FMC2 EBI controller driver

2020-05-06 Thread Christophe Kerello
The FMC2 functional block makes the interface with: synchronous and asynchronous static devices (such as PSNOR, PSRAM or other memory-mapped peripherals) and NAND flash memories. Its main purposes are: - to translate AXI transactions into the appropriate external device protocol - to meet t

[PATCH v4 05/10] mtd: rawnand: stm32_fmc2: use FIELD_PREP/FIELD_GET macros

2020-05-06 Thread Christophe Kerello
This patch removes custom macros and uses FIELD_PREP and FIELD_GET macros. Signed-off-by: Christophe Kerello Reviewed-by: Miquel Raynal --- Changes in v3: - add Miquel reviewed-by tag drivers/mtd/nand/raw/stm32_fmc2_nand.c | 177 - 1 file changed, 85 insertions

[PATCH v4 04/10] mtd: rawnand: stm32_fmc2: cleanup

2020-05-06 Thread Christophe Kerello
This patch renames functions and local variables. This cleanup is done to get all functions starting by stm32_fmc2_nfc in the FMC2 raw NAND driver when all functions will start by stm32_fmc2_ebi in the FMC2 EBI driver. Signed-off-by: Christophe Kerello Reviewed-by: Miquel Raynal --- Changes in v

[PATCH v4 07/10] dt-bindings: memory-controller: add STM32 FMC2 EBI controller documentation

2020-05-06 Thread Christophe Kerello
This patch adds the documentation of the device tree bindings for the STM32 FMC2 EBI controller. Signed-off-by: Christophe Kerello --- Changes in v4: - fix filename: st,stm32-fmc2-ebi.yaml Changes in v3: - pattern name has been modified - vendor properties have been modified - s/_/-/ -

Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()

2020-05-06 Thread Thomas Gleixner
Borislav Petkov writes: > On Tue, May 05, 2020 at 03:16:05PM +0200, Thomas Gleixner wrote: >> The scheduler IPI has grown weird and wonderful over the years, time >> for spring cleaning. >> >> Move all the non-trivial stuff out of it and into a regular smp function >> call IPI. This then reduces

[PATCH v4 09/10] mtd: rawnand: stm32_fmc2: use regmap APIs

2020-05-06 Thread Christophe Kerello
This patch uses regmap APIs to access all FMC2 registers. Signed-off-by: Christophe Kerello Reviewed-by: Miquel Raynal --- Changes in v3: - add Miquel reviewed-by tag drivers/mtd/nand/raw/Kconfig | 2 + drivers/mtd/nand/raw/stm32_fmc2_nand.c | 268 +++--

[PATCH v4 10/10] mtd: rawnand: stm32_fmc2: get resources from parent node

2020-05-06 Thread Christophe Kerello
FMC2 EBI support has been added. Common resources (registers base and clock) are now shared between the 2 drivers. It means that the common resources should now be found in the parent device when EBI node is available. Signed-off-by: Christophe Kerello --- drivers/mtd/nand/raw/Kconfig

[PATCH v4 08/10] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver

2020-05-06 Thread Christophe Kerello
The driver adds the support for the STMicroelectronics FMC2 EBI controller found on STM32MP SOCs. Signed-off-by: Christophe Kerello --- Changes in v3: - Move in memory folder - Merge MFD and BUS drivers to avoid a MFD driver drivers/memory/Kconfig | 10 + drivers/memory/Makefile

[PATCH v4 01/10] mtd: rawnand: stm32_fmc2: manage all errors cases at probe time

2020-05-06 Thread Christophe Kerello
This patch defers its probe when the expected reset control is not yet ready. This patch also handles properly all errors cases at probe time. Signed-off-by: Christophe Kerello --- Changes in v3: - rename labels used on errors drivers/mtd/nand/raw/stm32_fmc2_nand.c | 17 +++-- 1 fi

[PATCH v4 02/10] mtd: rawnand: stm32_fmc2: remove useless inline comments

2020-05-06 Thread Christophe Kerello
Remove inline comments that are useless since function label are self explanatory. Signed-off-by: Christophe Kerello Reviewed-by: Miquel Raynal --- Changes in v3: - add Miquel reviewed-by tag drivers/mtd/nand/raw/stm32_fmc2_nand.c | 40 -- 1 file changed, 40 de

[PATCH v4 03/10] mtd: rawnand: stm32_fmc2: use FMC2_TIMEOUT_MS for timeouts

2020-05-06 Thread Christophe Kerello
This patch removes the constant FMC2_TIMEOUT_US. FMC2_TIMEOUT_MS will be used each time that we need to wait (except when the timeout value is set by the framework). It was seen, during stress tests with the sequencer in an overloaded system, that we could be close to 1 second, even if we never me

Re: [PATCH] dma-buf: heaps: Remove Unneeded variable "ret" in dma_heap_dma_buf_begin_cpu_access()

2020-05-06 Thread Brian Starkey
Hi Jason, On Wed, May 06, 2020 at 02:18:51PM +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/dma-buf/heaps/heap-helpers.c:203:5-8: Unneeded variable: "ret". > Return "0" on line 216 > > Signed-off-by: Jason Yan LGTM. Reviewed-by: Brian Starkey Thanks, -Brian > -

Re: KASAN: use-after-free Read in usblp_bulk_read

2020-05-06 Thread Oliver Neukum
Am Donnerstag, den 30.04.2020, 11:11 -0400 schrieb Alan Stern: > KASAN is documented. The difficulty is that this race is obviously > hard to trigger, and without the ability to reproduce it we can't run > diagnostics to find the underlying cause. > > We can't even ask syzbot to try running te

Re: [PATCH 2/4] mm/swap: use SECTORS_PER_PAGE_SHIFT to clean up code

2020-05-06 Thread Leizhen (ThunderTown)
On 2020/5/6 11:47, Leizhen (ThunderTown) wrote: > > > On 2020/5/6 9:33, Leizhen (ThunderTown) wrote: >> >> >> On 2020/5/6 1:25, Matthew Wilcox wrote: >>> On Tue, May 05, 2020 at 07:55:41PM +0800, Zhen Lei wrote: +++ b/mm/swapfile.c @@ -177,8 +177,8 @@ static int discard_swap(struct s

Re: [RFC net-next] net: phy: at803x: add cable diagnostics support

2020-05-06 Thread Matthias May
On 03/05/2020 20:15, Michael Walle wrote: > The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding > driver support is straightforward, so lets add it. > > The PHY just do one pair at a time, so we have to start the test four > times. The cable_test_get_status() can block and therefore

Re: [PATCH v3 00/10] add STM32 FMC2 EBI controller driver

2020-05-06 Thread Christophe Kerello
Hi, Please do not spend time to review v3. V4 has been pushed to fix an issue in YAML bindings. Regards, Christophe Kerello. On 5/5/20 7:10 PM, Christophe Kerello wrote: The FMC2 functional block makes the interface with: synchronous and asynchronous static devices (such as PSNOR, PSRAM or oth

[PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread Samuel Zou
Fixes coccicheck warnings: drivers/dma/ti/k3-udma.c:1294:1-3: WARNING: PTR_ERR_OR_ZERO can be used drivers/dma/ti/k3-udma.c:1311:1-3: WARNING: PTR_ERR_OR_ZERO can be used drivers/dma/ti/k3-udma.c:1376:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --

Re: [patch V4 part 2 15/18] x86/kvm/svm: Handle hardirqs proper on guest enter/exit

2020-05-06 Thread Paolo Bonzini
On 06/05/20 10:48, Thomas Gleixner wrote: > So for instrumentation, especially interrupt disabled tracing we must > track that change otherwise a latency analysis would claim that > interrupts were disabled for the full time a task spent in user > mode. Oh okay, that's clear now. I would just rep

[PATCH v2] KVM: x86: fix DR6 delivery for various cases of #DB injection

2020-05-06 Thread Paolo Bonzini
Go through kvm_queue_exception_p so that the payload is correctly delivered through the exit qualification, and add a kvm_update_dr6 call to kvm_deliver_exception_payload that is needed on AMD. Reported-by: Peter Xu Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx/vmx.c | 6 ++ arch/x86/kv

Re: [PATCH] x86: bitops: fix build regression

2020-05-06 Thread Sedat Dilek
On Wed, May 6, 2020 at 6:30 AM Nathan Chancellor wrote: > > On Tue, May 05, 2020 at 10:44:22AM -0700, Nick Desaulniers wrote: > > From: Sedat Dilek > > > > It turns out that if your config tickles __builtin_constant_p via > > differences in choices to inline or not, this now produces invalid > >

[PATCH v3] KVM: x86: fix DR6 delivery for various cases of #DB injection

2020-05-06 Thread Paolo Bonzini
Go through kvm_queue_exception_p so that the payload is correctly delivered through the exit qualification, and add a kvm_update_dr6 call to kvm_deliver_exception_payload that is needed on AMD. Reported-by: Peter Xu Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx/vmx.c | 8 ++-- arch/x86/

[PATCH] [v4] KVM: X86: support APERF/MPERF registers

2020-05-06 Thread Li RongQing
Guest kernel reports a fixed cpu frequency in /proc/cpuinfo, this is confused to user when turbo is enable, and aperf/mperf can be used to show current cpu frequency after 7d5905dc14a "(x86 / CPU: Always show current CPU frequency in /proc/cpuinfo)" so guest should support aperf/mperf capability T

Re: [GIT PULL] vhost: fixes

2020-05-06 Thread Stefano Garzarella
On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote: > On Wed, May 06, 2020 at 03:28:47AM +, Justin He wrote: > > Hi Michael > > > > > -Original Message- > > > From: Michael S. Tsirkin > > > Sent: Monday, May 4, 2020 8:16 PM > > > To: Linus Torvalds > > > Cc: k...@vger

Re: [PATCH v2 22/91] reset: Move reset-simple header out of drivers/reset

2020-05-06 Thread Philipp Zabel
On Fri, 2020-04-24 at 17:34 +0200, Maxime Ripard wrote: > The reset-simple code can be useful for drivers outside of drivers/reset > that have a few reset controls as part of their features. Let's move it to > include/linux/reset. > > Cc: Philipp Zabel > Signed-off-by: Maxime Ripard Reviewed-by

Re: [PATCH v2 23/91] reset: simple: Add reset callback

2020-05-06 Thread Philipp Zabel
Hi Maxime, On Fri, 2020-04-24 at 17:34 +0200, Maxime Ripard wrote: > The reset-simple code lacks a reset callback that is still pretty easy to > implement. The only real thing to consider is the delay needed for a device > to be reset, so let's expose that as part of the reset-simple driver data.

[PATCH -next] rtc: pcf8523: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread Samuel Zou
Fixes coccicheck warning: drivers/rtc/rtc-pcf8523.c:361:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/rtc/rtc-pcf8523.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-p

Re: [PATCH 0/3] KVM: X86: Two fixes for KVM_SET_GUEST_DEBUG, and a selftest

2020-05-06 Thread Paolo Bonzini
On 05/05/20 22:49, Peter Xu wrote: > The first two patches try to fix two issues I found (I think) with the > selftest. The 3rd patch is the test itself. Note, we need below patches to > be > applied too for the test to work: > > KVM: X86: Declare KVM_CAP_SET_GUEST_DEBUG properly >

Re: System fails to exit s2idle by a keystroke on my laptop

2020-05-06 Thread Rafael J. Wysocki
On Mon, May 4, 2020 at 7:09 PM Chris Chiu wrote: > > Hi, > I have an Intel X5-Z8350 laptop which used to work fine on s2idle > enter/exit with kernel 5.3. After upgrading to kernel 5.4 and later, > the system can still exit s2idle by power button. However, if I try to > wake it up from a keyst

Re: [PATCH] iommu/virtio: reverse arguments to list_add

2020-05-06 Thread Jean-Philippe Brucker
On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote: > Elsewhere in the file, there is a list_for_each_entry with > &vdev->resv_regions as the second argument, suggesting that > &vdev->resv_regions is the list head. So exchange the > arguments on the list_add call to put the list head in

Re: [PATCH -next] rtc: pcf8523: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-06 Thread Alexandre Belloni
Hi, On 06/05/2020 17:34:00+0800, Samuel Zou wrote: > Fixes coccicheck warning: > > drivers/rtc/rtc-pcf8523.c:361:1-3: WARNING: PTR_ERR_OR_ZERO can be used > I'm not taking this change because it is useless and will have to be revert as soon as the probe function changes (and it will). Does it

Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09

2020-05-06 Thread Hanjun Guo
Hi Sudeep, On 2020/4/30 17:55, Sudeep Holla wrote: On Thu, Apr 30, 2020 at 02:19:59PM +0800, Xiongfeng Wang wrote: HiSilicon SoC has a separate System Control Processor(SCP) dedicated for clock frequency adjustment and has been using the cpufreq driver 'cppc-cpufreq'. New HiSilicon SoC HIP09 ad

<    1   2   3   4   5   6   7   8   9   10   >