[RFC v4][PATCH part-2 06/13] mm/dpt: Functions to populate a decorated page-table from a VA range

2020-05-04 Thread Alexandre Chartre
Provide functions to copy page-table entries from the kernel page-table to a decorated page-table for a specified VA range. These functions are based on the copy_pxx_range() functions defined in mm/memory.c. A first difference is that a level parameter can be specified to indicate the page-table le

[PATCH][next] drm/i915/gem: Fix inconsistent IS_ERR and PTR_ERR

2020-05-04 Thread Gustavo A. R. Silva
Fix inconsistent IS_ERR and PTR_ERR in __reloc_gpu_alloc(). The proper pointer to be passed as argument is ce. This bug was detected with the help of Coccinelle. Fixes: 6f576d6277ce ("drm/i915/gem: Try an alternate engine for relocations") Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm

[RFC v4][PATCH part-2 08/13] mm/dpt: Keep track of VA ranges mapped in a decorated page-table

2020-05-04 Thread Alexandre Chartre
Add functions to keep track of VA ranges mapped in a decorated page-table. This will be used when unmapping to ensure the same range is unmapped, at the same page-table level. This will also be used to handle mapping and unmapping of overlapping VA ranges. Signed-off-by: Alexandre Chartre --- ar

[RFC PATCH net-next 1/3] xfrm: bail early on slave pass over skb

2020-05-04 Thread Jarod Wilson
This is prep work for initial support of bonding hardware encryption pass-through support. The bonding driver will fill in the slave_dev pointer, and we use that to know not to skb_push() again on a given skb that was already processed on the bond device. CC: Jay Vosburgh CC: Veaceslav Falico CC

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
>>> the related system resources were not released when pci_iomap() return >>> error in the rtw_pci_io_mapping() function. add pci_release_regions() to >>> fix it. >> >> How do you think about a wording variant like the following? >> >>Subject: >>[PATCH v2] net: rtw88: Complete exception ha

[RFC PATCH net-next 0/3] bonding: support hardware crypto offload

2020-05-04 Thread Jarod Wilson
This is an initial "proof of concept" functional implementation for doing pass-through of hardware encryption from bonding device to capable slaves. This was tested using an ixgbe-driven Intel x520 NIC with libreswan and a transport mode connection, on top of an active-backup bond, using netperf an

[RFC PATCH net-next 2/3] ixgbe_ipsec: become aware of when running as a bonding slave

2020-05-04 Thread Jarod Wilson
Slave devices in a bond doing hardware encryption also need to be aware that they're slaves, so we operate on the slave instead of the bonding master to do the actual hardware encryption offload bits. CC: Jay Vosburgh CC: Veaceslav Falico CC: Andy Gospodarek CC: "David S. Miller" CC: Jeff Kirs

[RFC v4][PATCH part-2 07/13] mm/dpt: Helper functions to map module into a decorated page-table

2020-05-04 Thread Alexandre Chartre
Add helper functions to easily map a module into a decorated page-table. Signed-off-by: Alexandre Chartre --- arch/x86/include/asm/dpt.h | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/x86/include/asm/dpt.h b/arch/x86/include/asm/dpt.h index 85d2c5051acb..5a38d97a

[RFC v4][PATCH part-2 00/13] ASI - Part II (Decorated Page-Table)

2020-05-04 Thread Alexandre Chartre
This is part II of ASI RFC v4. Please refer to the cover letter of part I for an overview the ASI RFC. https://lore.kernel.org/lkml/20200504144939.11318-1-alexandre.char...@oracle.com/ This part introduces decorated page-table which encapsulate native page table (e.g. a PGD) in order to provid

Re: [PATCH] memcg: oom: ignore oom warnings from memory.max

2020-05-04 Thread Michal Hocko
On Mon 04-05-20 07:53:01, Shakeel Butt wrote: > On Mon, May 4, 2020 at 7:11 AM Michal Hocko wrote: > > > > On Mon 04-05-20 06:54:40, Shakeel Butt wrote: > > > On Sun, May 3, 2020 at 11:56 PM Michal Hocko wrote: > > > > > > > > On Thu 30-04-20 11:27:12, Shakeel Butt wrote: > > > > > Lowering memor

[RFC v4][PATCH part-2 10/13] mm/dpt: Function to copy page-table entries for percpu buffer

2020-05-04 Thread Alexandre Chartre
Provide functions to copy page-table entries from the kernel page-table to a decorated page-table for a percpu buffer. A percpu buffer have a different VA range for each cpu and all them have to be copied. Signed-off-by: Alexandre Chartre --- arch/x86/include/asm/dpt.h | 6 ++ arch/x86/mm/d

[RFC v4][PATCH part-2 09/13] mm/dpt: Functions to clear decorated page-table entries for a VA range

2020-05-04 Thread Alexandre Chartre
Provide functions to clear page-table entries in a decorated page-table for a specified VA range. Functions also check that the clearing effectively happens in the decorated page-table and there is no crossing of the decorated page-table boundary (through references to another page table), so that

[RFC v4][PATCH part-2 13/13] mm/asi: Function to init decorated page-table with ASI core mappings

2020-05-04 Thread Alexandre Chartre
Core mappings are the minimal mappings we need to be able to enter isolation and handle an isolation abort or exit. This includes the kernel code, the GDT and the percpu ASI sessions. We also need a stack so we map the current stack when entering isolation and unmap it on exit/abort. Signed-off-by

[RFC PATCH net-next 3/3] bonding: support hardware encryption offload to slaves

2020-05-04 Thread Jarod Wilson
Currently, this support is limited to active-backup mode, as I'm not sure about the feasilibity of mapping an xfrm_state's offload handle to multiple hardware devices simultaneously, and we rely on being able to pass some hints to both the xfrm and NIC driver about whether or not they're operating

Re: [PATCH v5] media: rcar-csi2: Correct the selection of hsfreqrange

2020-05-04 Thread Michael Rodin
Hello Suresh, Niklas, I think that we should not change the structs for PHTW register configuration, because there are no "max" values in the table "PHTW Set Values" from the Renesas Hardware Manual. The patch looks just wrong. A major issue is also that the Hardware Manual does not provide any al

Re: [PATCH 2/4] block/part_stat: use __this_cpu_add() instead of access by smp_processor_id()

2020-05-04 Thread Konstantin Khlebnikov
On 04/05/2020 17.03, Christoph Hellwig wrote: +#define __part_stat_add(part, field, addnd)\ + (part_stat_get(part, field) += (addnd)) Just open coding part_stat_get for the UP side would seems a little easier to read. If rewrite filed definition as #ifdef C

Re: [PATCH 1/3] vfio/type1: Support faulting PFNMAP vmas

2020-05-04 Thread Jason Gunthorpe
On Mon, May 04, 2020 at 08:06:30AM -0600, Alex Williamson wrote: > On Fri, 1 May 2020 20:50:33 -0300 > Jason Gunthorpe wrote: > > > On Fri, May 01, 2020 at 03:39:08PM -0600, Alex Williamson wrote: > > > With conversion to follow_pfn(), DMA mapping a PFNMAP range depends on > > > the range being f

[RFC v4][PATCH part-2 11/13] mm/dpt: Add decorated page-table remap function

2020-05-04 Thread Alexandre Chartre
Add a function to remap an already mapped buffer with a new address in a decorated page-table: the already mapped buffer is unmapped, and a new mapping is added for the specified new address. This is useful to track and remap a buffer which can be freed and then reallocated. Signed-off-by: Alexan

[RFC v4][PATCH part-2 02/13] mm/dpt: Track buffers allocated for a decorated page-table

2020-05-04 Thread Alexandre Chartre
Add functions to track buffers allocated for a decorated page-table. A page-table can have direct references to the kernel page table, at different levels (PGD, P4D, PUD, PMD). When freeing a page-table, we should make sure that we free parts actually allocated for the decorated page-table, and not

[RFC v4][PATCH part-3 08/14] asidrv: Sequence to test scheduling in/out with ASI

2020-05-04 Thread Alexandre Chartre
Add a sequence to test if an ASI remains active after it is scheduled out and then scheduled back in. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asidrv.c | 98 drivers/staging/asi/asidrv.h | 2 + 2 files changed, 100 insertions(+) diff --git a

[RFC v4][PATCH part-3 14/14] asidrv/asicmd: Add options to manage ASI mapped VA ranges

2020-05-04 Thread Alexandre Chartre
Add options to the asicmd CLI to list, add and clear ASI mapped VA ranges. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asicmd.c | 243 +++ 1 file changed, 243 insertions(+) diff --git a/drivers/staging/asi/asicmd.c b/drivers/staging/asi/asicmd.c inde

[RFC v4][PATCH part-3 02/14] asidrv: Introduce the ASI driver

2020-05-04 Thread Alexandre Chartre
Introduce the infrastructure for the ASI driver. This driver is meant for testing ASI. It creates a test ASI, and will allow to run some test sequences on this ASI. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/Makefile | 7 ++ drivers/staging/asi/asidrv.c | 129

[RFC v4][PATCH part-2 12/13] mm/dpt: Handle decorated page-table mapped range leaks and overlaps

2020-05-04 Thread Alexandre Chartre
When mapping a buffer in a decorated page-table, data around the buffer can also be mapped if the entire buffer is not aligned with the page directory size used for the mapping. So, data can potentially leak into the decorated page-table. In such a case, print a warning that data are leaking. Also

[RFC v4][PATCH part-3 07/14] asidrv: Sequence to test interrupt+NMI on ASI

2020-05-04 Thread Alexandre Chartre
Add a sequence to test if an ASI remains active after receiving an interrupt which is itself interrupted by an NMI. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asidrv.c | 62 +++- drivers/staging/asi/asidrv.h | 1 + 2 files changed, 62 insertions(+),

[RFC v4][PATCH part-3 03/14] asidrv: Introduce the ASIDRV_IOCTL_RUN_SEQUENCE ioctl

2020-05-04 Thread Alexandre Chartre
The ASIDRV_IOCTL_RUN_SEQUENCE ioctl runs a specified sequence with the test ASI. The ioctl returns whether the run was successful or not, and if the test ASI was active at the end of the run. For now, two test sequences are implemented: - ASIDRV_SEQ_NOP does nothing but enters and exits the test

[RFC v4][PATCH part-3 11/14] asidrv/asicmd: Introduce the asicmd command

2020-05-04 Thread Alexandre Chartre
The asicmd command is a userland CLI to interact with the ASI driver (asidrv), in particular it provides an interface for running ASI test sequences. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/Makefile | 6 ++ drivers/staging/asi/asicmd.c | 120 +++

[RFC v4][PATCH part-3 06/14] asidrv: Sequence to test NMI on ASI

2020-05-04 Thread Alexandre Chartre
Add a sequence to test if an ASI remains active after receiving an NMI. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asidrv.c | 116 ++- drivers/staging/asi/asidrv.h | 4 ++ 2 files changed, 118 insertions(+), 2 deletions(-) diff --git a/drivers/sta

[RFC v4][PATCH part-3 12/14] asidrv/asicmd: Add more test sequences for testing ASI

2020-05-04 Thread Alexandre Chartre
Add more options to the asicmd command to test access to map or unmapped memory buffer, interrupt, NMI, scheduling while using ASI. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asicmd.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/staging/asi/asicmd.c b

[RFC v4][PATCH part-3 01/14] mm/asi: Define the test ASI type

2020-05-04 Thread Alexandre Chartre
Define the test ASI type which can be used for testing or experimenting ASI. Signed-off-by: Alexandre Chartre --- arch/x86/include/asm/asi.h | 2 ++ arch/x86/mm/asi.c | 1 + drivers/staging/Makefile | 1 + 3 files changed, 4 insertions(+) diff --git a/arch/x86/include/asm/asi.h b/arc

[RFC v4][PATCH part-3 00/14] ASI - Part III (ASI Test Driver and CLI)

2020-05-04 Thread Alexandre Chartre
This is part III of ASI RFC v4. Please refer to the cover letter of part I for an overview the ASI RFC. https://lore.kernel.org/lkml/20200504144939.11318-1-alexandre.char...@oracle.com/ This part provides a driver and a CLI for testing and introspecting an ASI. The driver creates a test ASI an

Re: [PATCH 2/3] vfio-pci: Fault mmaps to enable vma tracking

2020-05-04 Thread Jason Gunthorpe
On Mon, May 04, 2020 at 08:20:55AM -0600, Alex Williamson wrote: > On Fri, 1 May 2020 20:25:50 -0300 > Jason Gunthorpe wrote: > > > On Fri, May 01, 2020 at 03:39:19PM -0600, Alex Williamson wrote: > > > Rather than calling remap_pfn_range() when a region is mmap'd, setup > > > a vm_ops handler to

[RFC v4][PATCH part-3 05/14] asidrv: Sequence to test interrupt on ASI

2020-05-04 Thread Alexandre Chartre
Add a sequence to test if an ASI remains active after receiving an interrupt. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asidrv.c | 144 +-- drivers/staging/asi/asidrv.h | 5 ++ 2 files changed, 144 insertions(+), 5 deletions(-) diff --git a/drive

[RFC v4][PATCH part-3 04/14] asidrv: Sequence to test ASI access to mapped/unmapped memory

2020-05-04 Thread Alexandre Chartre
Add a sequence to test if ASI exit or not when accessing a mapped or unmapped memory buffer. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asidrv.c | 70 drivers/staging/asi/asidrv.h | 3 ++ 2 files changed, 73 insertions(+) diff --git a/drivers/

[RFC v4][PATCH part-3 13/14] asidrv/asicmd: Add options to manage ASI page faults

2020-05-04 Thread Alexandre Chartre
Add options to the asicmd CLI to list and clear ASI page faults. Also add an option to enable/disable displaying stack trace on ASI page fault. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asicmd.c | 68 ++-- 1 file changed, 65 insertions(+), 3 deletio

[RFC v4][PATCH part-3 09/14] asidrv: Add ioctls to manage ASI page faults

2020-05-04 Thread Alexandre Chartre
Add ioctls to list and clear ASI page faults. Also add an ioctl to display or not stack trace on ASI page fault. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asidrv.c | 88 drivers/staging/asi/asidrv.h | 32 + 2 files changed, 120 inse

Re: [PATCH v6 0/6] drm/meson: add support for Amlogic Video FBC

2020-05-04 Thread Neil Armstrong
Hi Daniel, On 21/04/2020 18:15, Neil Armstrong wrote: > Amlogic uses a proprietary lossless image compression protocol and format > for their hardware video codec accelerators, either video decoders or > video input encoders. > > It considerably reduces memory bandwidth while writing and reading

[RFC v4][PATCH part-3 10/14] asidrv: Add ioctls to manage ASI mapped VA ranges

2020-05-04 Thread Alexandre Chartre
Add ioctls to list, add, clear ASI mapped VA ranges. Signed-off-by: Alexandre Chartre --- drivers/staging/asi/asidrv.c | 138 +++ drivers/staging/asi/asidrv.h | 26 +++ 2 files changed, 164 insertions(+) diff --git a/drivers/staging/asi/asidrv.c b/drivers/st

Re: [PATCH] net: ethernet: ti: Remove TI_CPTS_MOD workaround

2020-05-04 Thread Tony Lindgren
* Clay McClure [200502 23:41]: > diff --git a/arch/arm/configs/omap2plus_defconfig > b/arch/arm/configs/omap2plus_defconfig > index 3cc3ca5fa027..e00f0d871c53 100644 > --- a/arch/arm/configs/omap2plus_defconfig > +++ b/arch/arm/configs/omap2plus_defconfig > @@ -57,7 +57,6 @@ CONFIG_CPUFREQ_DT=m >

Re: [PATCH 00/10] KVM: x86: Misc anti-retpoline optimizations

2020-05-04 Thread Sean Christopherson
On Mon, May 04, 2020 at 03:25:58PM +0200, Paolo Bonzini wrote: > On 02/05/20 06:32, Sean Christopherson wrote: > > A smattering of optimizations geared toward avoiding retpolines, though > > IMO most of the patches are worthwhile changes irrespective of retpolines. > > I can split this up into sepa

[PATCH v3] staging: wilc1000: Increase the size of wid_list array

2020-05-04 Thread Oscar Carter
Increase by one the size of wid_list array as index variable can reach a value of 5. If this happens, an out-of-bounds access is performed. Also, use a #define instead of a hard-coded literal for the new array size. Addresses-Coverity-ID: 1451981 ("Out-of-bounds access") Fixes: f5a3cb90b802d ("st

Re: [PATCH 2/4] block/part_stat: use __this_cpu_add() instead of access by smp_processor_id()

2020-05-04 Thread Christoph Hellwig
On Mon, May 04, 2020 at 06:02:28PM +0300, Konstantin Khlebnikov wrote: > Then all per-cpu macro should work as is for UP case too. > Surprisingly arrow operator (struct->filed) works for arrays too =) > > > Inlining per-cpu structures should be good for tiny UP systems. > Especially if this could

[PATCH] percpu: Sync vmalloc mappings in pcpu_alloc() and free_percpu()

2020-05-04 Thread Joerg Roedel
On Thu, Apr 30, 2020 at 10:39:19PM -0400, Steven Rostedt wrote: > What's so damn special about alloc_percpu()? It's definitely not a fast > path. And it's not used often. Okay, I fixed it in the percpu code. It is definitly not a nice solution, but having to call vmalloc_sync_mappings/unmappings()

[PATCH][next] io_uring: Remove logically dead code in io_splice

2020-05-04 Thread Gustavo A. R. Silva
In case force_nonblock happens to be true, the function returns at: 2779 if (force_nonblock) 2780 return -EAGAIN; before reaching this line of code. So, the null check on force_nonblock at 2785, is never actually being executed. Addresses-Coverity-ID: 1492838 ("Logicall

Re: [PATCH v2 00/18] S5PV210 and Aries DTS improvements

2020-05-04 Thread Krzysztof Kozlowski
On Fri, May 01, 2020 at 04:50:01PM -0700, Jonathan Bakker wrote: > This patchset makes several improvements to Aries devices which are > based on S5PV210. Several pulls on GPIOs were incorrect/not specified, > sleep GPIO configurations have been added, and more devices have been > added. > > Touc

Re: [PATCH] net: ethernet: ti: Remove TI_CPTS_MOD workaround

2020-05-04 Thread Arnd Bergmann
On Sun, May 3, 2020 at 1:41 AM Clay McClure wrote: > To preserve the existing behavior of defconfigs that select TI_CPTS, we > must also select PTP_1588_CLOCK so that the dependency is satisfied. > omap2plus_defconfig and keystone_defconfig have not been updated in a > while, so some unrelated no

[PATCH RFC 1/2] tracing/block: cleanup rwbs filling in trace events

2020-05-04 Thread Konstantin Khlebnikov
Define BLK_RWBS_LEN in blktrace_api.h Bcache events use shorter 6 char buffer which could overflow. Also remove unsed "bytes" argument. Signed-off-by: Konstantin Khlebnikov --- include/linux/blktrace_api.h |4 +- include/trace/events/bcache.h | 20 +- include/trace/events/block.h

[PATCH RFC 2/2] tracing/block: add request operation and flags into trace events

2020-05-04 Thread Konstantin Khlebnikov
It's hard to fit all flags into field 'rwbs' and even harder to remove something without breaking compatibility. Let's expose all request flags using common trace event methods: __print_symbolic and __print_flags. This adds 32-bit 'req' field printed as req=OP,FLAGS,... by all events. Exact consta

Re: [PATCH] sched/fair: Fix nohz.next_balance update

2020-05-04 Thread Vincent Guittot
On Sun, 3 May 2020 at 10:34, Peng Liu wrote: > > commit c5afb6a87f23 ("sched/fair: Fix nohz.next_balance update") > During idle load balance, this_cpu(ilb) do load balance for the other > idle CPUs, also gather the earliest (nohz.)next_balance. > > Since commit: > 'b7031a02ec75 ("sched/fair: Add

Re: [PATCH] mtd: set mtd partition panic write flag

2020-05-04 Thread Kamal Dasu
On Sat, May 2, 2020 at 2:08 PM Miquel Raynal wrote: > > Hi Kamal, > > Miquel Raynal wrote on Thu, 9 Jan 2020 > 18:28:07 +0100: > > > Hi Kamal, > > > > Kamal Dasu wrote on Thu, 9 Jan 2020 10:25:59 > > -0500: > > > > > Miquel, > > > > > > Yes the issue is still open. I was trying to understand the

Re: [PATCH] ASoC: qcom: Use the defined variable to simplify code

2020-05-04 Thread Mark Brown
On Mon, 4 May 2020 14:59:47 +0800, Tang Bin wrote: > Use the defined variable "dev" to make the code cleaner. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin > --- > sound/soc/qcom/lpass-apq8016.c | 9 > sound/soc/qcom/lpass-cpu.c | 39 --

Re: [PATCH][next] io_uring: Remove logically dead code in io_splice

2020-05-04 Thread Pavel Begunkov
On 04/05/2020 18:19, Gustavo A. R. Silva wrote: > In case force_nonblock happens to be true, the function returns > at: > > 2779 if (force_nonblock) > 2780 return -EAGAIN; > > before reaching this line of code. So, the null check on force_nonblock > at 2785, is never act

Re: [PATCH 09/24] rcu/tree: cache specified number of objects

2020-05-04 Thread Paul E. McKenney
On Mon, May 04, 2020 at 02:43:23PM +0200, Uladzislau Rezki wrote: > On Fri, May 01, 2020 at 02:27:49PM -0700, Paul E. McKenney wrote: > > On Tue, Apr 28, 2020 at 10:58:48PM +0200, Uladzislau Rezki (Sony) wrote: > > > Cache some extra objects per-CPU. During reclaim process > > > some pages are cach

Re: [PATCH v2] misc: new driver sram_uapi for user level SRAM access

2020-05-04 Thread kbuild test robot
Hi Wang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on arm-soc/for-next linus/master linux/master v5.7-rc3 next-20200501] [if your patch is applied to the wrong git tree, please drop us a note to help i

Re: [PATCH][next] io_uring: Remove logically dead code in io_splice

2020-05-04 Thread Jens Axboe
On 5/4/20 9:19 AM, Gustavo A. R. Silva wrote: > In case force_nonblock happens to be true, the function returns > at: > > 2779 if (force_nonblock) > 2780 return -EAGAIN; > > before reaching this line of code. So, the null check on force_nonblock > at 2785, is never actua

Re: [PATCH] percpu: Sync vmalloc mappings in pcpu_alloc() and free_percpu()

2020-05-04 Thread Mathieu Desnoyers
- On May 4, 2020, at 11:12 AM, Joerg Roedel jroe...@suse.de wrote: > On Thu, Apr 30, 2020 at 10:39:19PM -0400, Steven Rostedt wrote: >> What's so damn special about alloc_percpu()? It's definitely not a fast >> path. And it's not used often. > > Okay, I fixed it in the percpu code. It is defi

Re: [PATCH] percpu: Sync vmalloc mappings in pcpu_alloc() and free_percpu()

2020-05-04 Thread Joerg Roedel
On Mon, May 04, 2020 at 11:28:46AM -0400, Mathieu Desnoyers wrote: > - On May 4, 2020, at 11:12 AM, Joerg Roedel jroe...@suse.de wrote: > Placing this here is inefficient. It syncs mappings for each percpu > allocation. > I would recommend moving it right after __vmalloc() is called to allocat

[PATCH] fs: jfs: fix a possible data race in metapage_writepage()

2020-05-04 Thread Jia-Ju Bai
The functions metapage_writepage() and lmPostGC() can be concurrently executed in the following call contexts: Thread1: metapage_writepage() Thread2: lbmIODone() lmPostGC() In metapage_writepage(): if (mp->log && !(mp->log->cflag & logGC_PAGEOUT)) In lmPostGC(): spin_lock_irqsave(&

Re: [PATCH 19/24] rcu/tree: Support reclaim for head-less object

2020-05-04 Thread Paul E. McKenney
On Mon, May 04, 2020 at 04:21:53PM +0200, Uladzislau Rezki wrote: > > > > > > > > If we are not doing single-pointer allocation, then that would also > > > > eliminate > > > > entering the low-level page allocator for single-pointer allocations. > > > > > > > > Or did you mean entry into the all

[PATCH] fs: jfs: fix a possible data race in txBegin()

2020-05-04 Thread Jia-Ju Bai
The functions txBegin() and txLazyCommit() can be concurrently executed in the following call contexts: Thread1: jfs_write_inode() jfs_commit_inode() txBegin() Thread2: jfs_lazycommit() txLazyCommit() In txBegin(): tblk->next = tblk->last = tblk->xflag = tblk->flag = tblk->ls

[PATCH] KVM: nVMX: Replace a BUG_ON(1) with BUG() to squash clang warning

2020-05-04 Thread Sean Christopherson
Use BUG() in the impossible-to-hit default case when switching on the scope of INVEPT to squash a warning with clang 11 due to clang treating the BUG_ON() as conditional. >> arch/x86/kvm/vmx/nested.c:5246:3: warning: variable 'roots_to_free' is used uninitialized whenever 'if' condition is

Re: [PATCH] memcg: oom: ignore oom warnings from memory.max

2020-05-04 Thread Shakeel Butt
On Mon, May 4, 2020 at 8:00 AM Michal Hocko wrote: > > On Mon 04-05-20 07:53:01, Shakeel Butt wrote: > > On Mon, May 4, 2020 at 7:11 AM Michal Hocko wrote: > > > > > > On Mon 04-05-20 06:54:40, Shakeel Butt wrote: > > > > On Sun, May 3, 2020 at 11:56 PM Michal Hocko wrote: > > > > > > > > > > On

Re: [PATCH] percpu: Sync vmalloc mappings in pcpu_alloc() and free_percpu()

2020-05-04 Thread Mathieu Desnoyers
- On May 4, 2020, at 11:31 AM, Joerg Roedel jroe...@suse.de wrote: > On Mon, May 04, 2020 at 11:28:46AM -0400, Mathieu Desnoyers wrote: >> - On May 4, 2020, at 11:12 AM, Joerg Roedel jroe...@suse.de wrote: >> Placing this here is inefficient. It syncs mappings for each percpu >> allocatio

RE: [PATCH 0/5] platform/x86: intel-vbtn: Fixes + rework to make it work on more devices

2020-05-04 Thread Mario.Limonciello
> -Original Message- > From: Hans de Goede > Sent: Saturday, May 2, 2020 1:30 PM > To: Darren Hart; Andy Shevchenko; Limonciello, Mario > Cc: Hans de Goede; linux-a...@vger.kernel.org; platform-driver- > x...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH 0/5] platform/x86

Re: [PATCH] memcg: oom: ignore oom warnings from memory.max

2020-05-04 Thread Yafang Shao
On Mon, May 4, 2020 at 11:36 PM Shakeel Butt wrote: > > On Mon, May 4, 2020 at 8:00 AM Michal Hocko wrote: > > > > On Mon 04-05-20 07:53:01, Shakeel Butt wrote: > > > On Mon, May 4, 2020 at 7:11 AM Michal Hocko wrote: > > > > > > > > On Mon 04-05-20 06:54:40, Shakeel Butt wrote: > > > > > On Sun

Re: [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time

2020-05-04 Thread Thierry Reding
On Sat, May 02, 2020 at 05:40:35PM +0300, Dmitry Osipenko wrote: > 27.04.2020 18:31, Wolfram Sang пишет: > > > >> Yes, that bug should be fixed anyway. But that doesn't justify breaking > >> suspend/resume completely, which *is* a regression. > >> > >> Look, I'm not saying that we should drop this

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-05-04 Thread Arnd Bergmann
On Sun, May 3, 2020 at 7:30 AM Leon Romanovsky wrote: > On Thu, Apr 30, 2020 at 04:37:14PM +0200, Arnd Bergmann wrote: > > On Thu, Apr 30, 2020 at 7:22 AM Leon Romanovsky wrote: > > > > While warning limit is generally 1024 bytes for 32-bit architectures, > > and 2048 bytes fro 64-bit architectur

Re: [PATCH v2] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-04 Thread Markus Elfring
> … However, the code fragment is incorrect > because the dev pointer is used before the actual check I find such information interesting. > which leads to undefined behavior. … I suggest to adjust the wording for this “conclusion”. Regards, Markus

Re: [PATCH] memcg: oom: ignore oom warnings from memory.max

2020-05-04 Thread Tetsuo Handa
On 2020/05/04 23:57, Shakeel Butt wrote: > On Mon, May 4, 2020 at 7:20 AM Tetsuo Handa > wrote: >> >> On 2020/05/04 22:54, Shakeel Butt wrote: >>> It may not be a problem for an individual or small scale deployment >>> but when "sweep before tear down" is the part of the workflow for >>> thousands

Re: linux-next: Tree for May 4 --> mm: free_area_init: allow defining max_zone_pfn in descending order does increase memory use

2020-05-04 Thread Mike Rapoport
Ho Christian, On Mon, May 04, 2020 at 04:50:06PM +0200, Christian Borntraeger wrote: > Mike, > commit 51a2f644fd020d5f090044825c388444d11029d ("mm: free_area_init: allow > defining max_zone_pfn in descending order") > does increase the memory use on s390 (e.g. 700 MB vs.1.8 GB). > > Something is

Re: [PATCH] sched/fair: Fix nohz.next_balance update

2020-05-04 Thread Valentin Schneider
On 04/05/20 16:17, Vincent Guittot wrote: > On Sun, 3 May 2020 at 10:34, Peng Liu wrote: >> >> commit c5afb6a87f23 ("sched/fair: Fix nohz.next_balance update") >> During idle load balance, this_cpu(ilb) do load balance for the other >> idle CPUs, also gather the earliest (nohz.)next_balance. >>

[PATCH v2 5/5] mfd: lochnagar: Move binding over to dtschema

2020-05-04 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Removed contains on the compatible - Moved all sub-nodes into here directly only using $ref for properties - As the regulator binding only contained subnodes that file is now deleted - Removed some pointless descriptions A little nervous

[PATCH v2 3/5] pinctrl: lochnagar: Move binding over to dtschema

2020-05-04 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Moved sub-node into MFD file leaving just the properties in here - Removed contains on the compatible - Added a required -pins suffix for pinmux/ctrl nodes - Added some extra blank lines for readability Thanks, Charles .../bindings/pinc

[PATCH v2 4/5] clk: lochnagar: Move binding over to dtschema

2020-05-04 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Moved sub-nodes into MFD file leaving just the properties in here - Removed contains on the compatible - Made clock descriptions comments rather than being in the description Thanks, Charles .../devicetree/bindings/clock/cirrus,lochnagar

[PATCH v2 2/5] ASoC: lochnagar: Move binding over to dtschema

2020-05-04 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Moved sub-node into MFD file leaving just the properties in here - Removed contains on the compatible - Removed some pointless descriptions Thanks, Charles .../devicetree/bindings/sound/cirrus,lochnagar.txt | 39 .../bin

[PATCH v2 1/5] hwmon: lochnagar: Move binding over to dtschema

2020-05-04 Thread Charles Keepax
Signed-off-by: Charles Keepax --- Changes since v1: - Moved sub-node into MFD file leaving just the properties in here - Removed contains on the compatible Thanks, Charles .../devicetree/bindings/hwmon/cirrus,lochnagar.txt | 26 .../bindings/hwmon/cirrus,lochnagar.yaml

Re: [PATCH V2 6/8] phy: tegra: xusb: Add support for charger detect

2020-05-04 Thread Thierry Reding
On Mon, May 04, 2020 at 02:32:51PM +0530, Nagarjuna Kristam wrote: > >On 28-04-2020 16:25, Thierry Reding wrote: > > > On Wed, Apr 15, 2020 at 01:55:06PM +0530, Nagarjuna Kristam wrote: [...] > > > diff --git a/drivers/phy/tegra/xusb-tegra-cd.c > > > b/drivers/phy/tegra/xusb-tegra-cd.c > > > +stat

Re: [PATCH v4 01/12] PCI: aardvark: Train link immediately after enabling training

2020-05-04 Thread Bjorn Helgaas
On Thu, Apr 30, 2020 at 10:06:14AM +0200, Pali Rohár wrote: > Adding even 100ms (PCI_PM_D3COLD_WAIT) delay between enabling link > training and starting link training causes detection issues with some > buggy cards (such as Compex WLE900VX). > > Move the code which enables link training immediatel

Re: [PATCH] arm64/cpuinfo: Drop boot_cpu_data

2020-05-04 Thread Mark Rutland
On Mon, May 04, 2020 at 08:23:08PM +0530, Anshuman Khandual wrote: > > > On 05/04/2020 06:13 PM, Mark Rutland wrote: > > On Mon, May 04, 2020 at 06:00:00PM +0530, Anshuman Khandual wrote: > >> A global boot_cpu_data is not really required. Lets drop this. > > > > I don't think it's true that thi

Re: [PATCH v4 12/12] arm64: dts: marvell: armada-37xx: Move PCIe max-link-speed property

2020-05-04 Thread Bjorn Helgaas
On Thu, Apr 30, 2020 at 10:06:25AM +0200, Pali Rohár wrote: > Move the max-link-speed property of the PCIe node from board specific > device tree files to the generic armada-37xx.dtsi. > > Armada 37xx supports only PCIe gen2 speed so max-link-speed property > should be in the genetic armada-37xx.d

Re: [PATCH] percpu: Sync vmalloc mappings in pcpu_alloc() and free_percpu()

2020-05-04 Thread Joerg Roedel
On Mon, May 04, 2020 at 11:38:43AM -0400, Mathieu Desnoyers wrote: > - On May 4, 2020, at 11:31 AM, Joerg Roedel jroe...@suse.de wrote: > > Tried this before, actually I put it into the caller of > > pcpu_mem_zalloc(), but that didn't fix the problem for me. Stevens > > test-case still hangs th

Re: [PATCH 2/3] vfio-pci: Fault mmaps to enable vma tracking

2020-05-04 Thread Alex Williamson
On Mon, 4 May 2020 12:05:56 -0300 Jason Gunthorpe wrote: > On Mon, May 04, 2020 at 08:20:55AM -0600, Alex Williamson wrote: > > On Fri, 1 May 2020 20:25:50 -0300 > > Jason Gunthorpe wrote: > > > > > On Fri, May 01, 2020 at 03:39:19PM -0600, Alex Williamson wrote: > > > > Rather than calling

Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver

2020-05-04 Thread Dmitry Osipenko
04.05.2020 17:53, Sowjanya Komatineni пишет: > > On 4/30/20 12:33 PM, Dmitry Osipenko wrote: > Hi Dmitry, > > Will update in v12 to not allow freeze in middle of a frame capture. > > Can you please confirm on above if you agree to allow freeze to > happen in b/w frame captu

Re: [PATCH][next] io_uring: Remove logically dead code in io_splice

2020-05-04 Thread Pavel Begunkov
On 04/05/2020 18:25, Jens Axboe wrote: > On 5/4/20 9:19 AM, Gustavo A. R. Silva wrote: >> In case force_nonblock happens to be true, the function returns >> at: >> >> 2779 if (force_nonblock) >> 2780 return -EAGAIN; >> >> before reaching this line of code. So, the null che

Re: [PATCH v4 08/12] PCI: aardvark: Replace custom macros by standard linux/pci_regs.h macros

2020-05-04 Thread Bjorn Helgaas
On Thu, Apr 30, 2020 at 10:06:21AM +0200, Pali Rohár wrote: > PCI-E capability macros are already defined in linux/pci_regs.h. > Remove their reimplementation in pcie-aardvark. s/PCI-E/PCIe/ I mentioned this last time, but I guess you missed it. > Signed-off-by: Pali Rohár > --- > drivers/pci/

[PATCH RFC 1/2] fs/iomap/direct-io: pass NOWAIT to bio flags

2020-05-04 Thread Konstantin Khlebnikov
This is required to avoid waiting in lower layers. Signed-off-by: Konstantin Khlebnikov --- fs/iomap/direct-io.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 20dde5aadcdd..9b53fa7651e3 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/

[PATCH RFC 2/2] fs/direct-io: pass NOWAIT to also for read requests

2020-05-04 Thread Konstantin Khlebnikov
For some reason NOWAIT currently is passed only for writes. Signed-off-by: Konstantin Khlebnikov Fixes: 03a07c92a9ed ("block: return on congested block device") --- fs/direct-io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/direct-io.c b/fs/direct-io.c index 00b

Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver

2020-05-04 Thread Sowjanya Komatineni
On 5/4/20 8:53 AM, Dmitry Osipenko wrote: 04.05.2020 17:53, Sowjanya Komatineni пишет: On 4/30/20 12:33 PM, Dmitry Osipenko wrote: Hi Dmitry, Will update in v12 to not allow freeze in middle of a frame capture. Can you please confirm on above if you agree to allow freeze to happen in b/w fr

[PATCH 3/3] KVM: x86: simplify dr6 accessors in kvm_x86_ops

2020-05-04 Thread Paolo Bonzini
kvm_x86_ops.set_dr6 is only ever called with vcpu->arch.dr6 as the second argument, and for both SVM and VMX the VMCB value is kept synchronized with vcpu->arch.dr6 on #DB; we can therefore remove the read accessor. For the write accessor we can avoid the retpoline penalty on Intel by accepting a

[PATCH 0/3] KVM: x86: cleanup and fixes for debug register accesses

2020-05-04 Thread Paolo Bonzini
The purpose of this series is to get rid of the get_dr6 accessor and, on Intel, of set_dr6 as well. This is done mostly in patch 2, since patch 3 is only the resulting cleanup. Patch 1 is a related bug fix that I found while inspecting the code. A guest debugging selftest is sorely needed if any

[PATCH 2/3] KVM: SVM: keep DR6 synchronized with vcpu->arch.dr6

2020-05-04 Thread Paolo Bonzini
Ensure that the current value of DR6 is always available in vcpu->arch.dr6, so that the get_dr6 callback can just access vcpu->arch.dr6 and becomes redundant. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/svm/svm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86

[PATCH 1/3] KVM: SVM: fill in kvm_run->debug.arch.dr[67]

2020-05-04 Thread Paolo Bonzini
The corresponding code was added for VMX in commit 42dbaa5a057 ("KVM: x86: Virtualize debug registers, 2008-12-15) but never for AMD. Fix this. Cc: sta...@vger.kernel.org Fixes: 42dbaa5a057 ("KVM: x86: Virtualize debug registers") Signed-off-by: Paolo Bonzini --- arch/x86/kvm/svm/svm.c | 2 ++ 1

Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit kernel

2020-05-04 Thread Thomas Bogendoerfer
On Fri, Apr 24, 2020 at 01:22:30PM +0100, Maciej W. Rozycki wrote: > On Thu, 23 Apr 2020, Jiaxun Yang wrote: > > > > Alternatively, have you made any attempt to verify if actually replacing > > >the setting for VMLINUX_LOAD_ADDRESS would be safe? Glancing over its use > > >there do not appear t

Re: [PATCH] KVM: nVMX: Replace a BUG_ON(1) with BUG() to squash clang warning

2020-05-04 Thread Paolo Bonzini
On 04/05/20 17:35, Sean Christopherson wrote: > Use BUG() in the impossible-to-hit default case when switching on the > scope of INVEPT to squash a warning with clang 11 due to clang treating > the BUG_ON() as conditional. > > >> arch/x86/kvm/vmx/nested.c:5246:3: warning: variable 'roots_to_free

Re: [PATCH RFC 1/2] fs/iomap/direct-io: pass NOWAIT to bio flags

2020-05-04 Thread Christoph Hellwig
On Mon, May 04, 2020 at 06:54:53PM +0300, Konstantin Khlebnikov wrote: > This is required to avoid waiting in lower layers. > > Signed-off-by: Konstantin Khlebnikov This looks sensible. Did you run this through xfstests?

Re: [PATCH] drm/i915: check to see if SIMD registers are available before using SIMD

2020-05-04 Thread Christoph Hellwig
On Sun, May 03, 2020 at 09:20:19PM +0100, Chris Wilson wrote: > > Err, why does i915 implements its own uncached memcpy instead of relying > > on core functionality to start with? > > What is this core functionality that provides movntqda? A sensible name might be memcpy_uncached or mempcy_nontem

Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings

2020-05-04 Thread Gustavo A. R. Silva
On 5/4/20 06:54, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> Hi Arnd, >> >> On 4/30/20 16:30, Arnd Bergmann wrote: >>> gcc-10 started warning about out-of-bounds access for zero-length >>> arrays: >>> >>> In file included from drivers/net/wireless/ath/ath10k/core.h:18, >>>

Re: [PATCH bpf 0/2] bpf, arm: Small JIT optimizations

2020-05-04 Thread Daniel Borkmann
On 5/1/20 4:02 AM, Luke Nelson wrote: As Daniel suggested to us, we ran our formal verification tool, Serval, over the arm JIT. The bugs we found have been patched and applied to the bpf tree [1, 2]. This patch series introduces two small optimizations that simplify the JIT and use fewer instruct

Re: [PATCH] sched/fair: Fix nohz.next_balance update

2020-05-04 Thread Dietmar Eggemann
On 04/05/2020 17:17, Vincent Guittot wrote: > On Sun, 3 May 2020 at 10:34, Peng Liu wrote: >> >> commit c5afb6a87f23 ("sched/fair: Fix nohz.next_balance update") >> During idle load balance, this_cpu(ilb) do load balance for the other >> idle CPUs, also gather the earliest (nohz.)next_balance. >>

Re: [PATCH] memcg: oom: ignore oom warnings from memory.max

2020-05-04 Thread Michal Hocko
On Mon 04-05-20 08:35:57, Shakeel Butt wrote: > On Mon, May 4, 2020 at 8:00 AM Michal Hocko wrote: > > > > On Mon 04-05-20 07:53:01, Shakeel Butt wrote: [...] > > > I am trying to see if "no eligible task" is really an issue and should > > > be warned for the "other use cases". The only real use-c

[PATCH] slub: limit count of partial slabs scanned to gather statistics

2020-05-04 Thread Konstantin Khlebnikov
To get exact count of free and used objects slub have to scan list of partial slabs. This may take at long time. Scanning holds spinlock and blocks allocations which move partial slabs to per-cpu lists and back. Example found in the wild: # cat /sys/kernel/slab/dentry/partial 14478538 N0=7329569

<    1   2   3   4   5   6   7   8   9   10   >