Re: linux-next: Fixes tag needs some work in the rdma-fixes tree

2019-10-21 Thread Doug Ledford
On Mon, 2019-10-21 at 18:41 +1100, Stephen Rothwell wrote: > Hi all, > > In commit > > 612e0486ad08 ("iw_cxgb4: fix ECN check on the passive accept") > > Fixes tag > > Fixes: 92e7ae7172 ("iw_cxgb4: Choose appropriate hw mtu index and > ISS for iWARP connections") > > has these problem(s):

[PATCH] scripts/nsdeps: escape '/' for module source files

2019-10-21 Thread Jessica Yu
When doing an out of tree build with O=, the nsdeps script constructs the absolute pathname of the module source file so that it can insert MODULE_IMPORT_NS statements in the right place. However, ${srctree} contains an unescaped path to the source tree, which, when used in a sed substitution, make

Re: [PATCH] ceph: Fix use-after-free in __ceph_remove_cap

2019-10-21 Thread Luis Henriques
Jeff Layton writes: > On Thu, 2019-10-17 at 15:46 +0100, Luis Henriques wrote: >> KASAN reports a use-after-free when running xfstest generic/531, with the >> following trace: >> >> [ 293.903362] kasan_report+0xe/0x20 >> [ 293.903365] rb_erase+0x1f/0x790 >> [ 293.903370] __ceph_remove_cap

[PATCH 0/5] debugfs: Remove casts in debugfs_create_*() callers

2019-10-21 Thread Geert Uytterhoeven
Hi all, Casting parameters in debugfs_create_*() calls prevents the compiler from performing some checks. Hence this patch series removes superfluous casts, or reworks code to no longer need the casts. All patches can be applied independently, there are no dependencies. Thanks for your c

[PATCH 5/5] ionic: Use debugfs_create_bool() to export bool

2019-10-21 Thread Geert Uytterhoeven
Currently bool ionic_cq.done_color is exported using debugfs_create_u8(), which requires a cast, preventing further compiler checks. Fix this by switching to debugfs_create_bool(), and dropping the cast. Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/pensando/ionic/ionic_debugfs.c |

Re: [PATCH 2/3] firmware/dmi: Report DMI Bios release

2019-10-21 Thread Jean Delvare
On Wed, 18 Sep 2019 11:43:20 +0200, Erwan Velu wrote: > Some vendors like HPe or Dell, encodes the release version of their BIOS encodes -> encode > in the "System BIOS {Major|Minor} Release" fields of Type 0. > > This information is useful to know which release of the bios is actually > runnin

Re: [PATCH 110/110] lib/vdso: Improve do_hres() and update vdso data unconditionally

2019-10-21 Thread Thomas Gleixner
On Mon, 21 Oct 2019, Huacai Chen wrote: > @@ -50,7 +50,7 @@ static int do_hres(const struct vdso_data *vd, clockid_t > clk, > cycles = __arch_get_hw_counter(vd->clock_mode); > ns = vdso_ts->nsec; > last = vd->cycle_last; > - if (unlikely((s64)c

Re: [PATCH 2/4] iio: adc: ad7091r5: Add scale and external VREF support

2019-10-21 Thread Jonathan Cameron
On Mon, 21 Oct 2019 20:06:06 +0300 Beniamin Bia wrote: > From: Paul Cercueil > > The scale can now be obtained with the "in_voltage_scale" file. > By default, the scale returned corresponds to the internal VREF of 2.5V. > > It is possible to use an external VREF (through the REFIN/REFOUT pin o

Re: [PATCH 3/3] firmware/dmi: Report DMI Embedded Firmware release

2019-10-21 Thread Jean Delvare
On Wed, 18 Sep 2019 11:43:21 +0200, Erwan Velu wrote: > Servers that have a BMC encodes the release version of their firmware > in the "Embedded Controller Firmware {Major|Minor} Release" fields of Type 0. > > This information is useful to know which release of the BMC is actually > running. > It

Re: [RFC PATCH 10/13] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs

2019-10-21 Thread Vaittinen, Matti
Thanks again Bart =) On Mon, 2019-10-21 at 16:36 +0200, Bartosz Golaszewski wrote: > pon., 21 paź 2019 o 09:00 Vaittinen, Matti > napisał(a): > > Hello Bartosz, > > > > + > > > > + bdgpio->chip.dev = &pdev->dev; > > > > + bdgpio->gpio.parent = pdev->dev.parent; > > > > + bdgpi

RE: [PATCH 1/2] dt-bindings: PCI: designware: Add binding for ZRX-DC PHY property

2019-10-21 Thread Pankaj Dubey
> -Original Message- > From: Andrew Murray > Sent: Monday, October 21, 2019 7:46 PM > To: Anvesh Salveru > Cc: linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; bhelg...@google.com; > gustavo.pimen...@synopsys.com; jingooh...@gmail.com; robh...@ker

Re: [PATCH v4 11/16] x86/kprobes: Convert to text-patching.h

2019-10-21 Thread Masami Hiramatsu
Hi Peter, On Fri, 18 Oct 2019 09:35:36 +0200 Peter Zijlstra wrote: > Convert kprobes to the new text-poke naming. > Looks good to me :) Acked-by: Masami Hiramatsu Thanks, > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/include/asm/kprobes.h | 14 +++ > arch/x86/i

inner loop optimization and lists

2019-10-21 Thread Ywe Cærlyn
Sometimes one uses lists and checks if listitem needs to be run. Instead of: list: if nec do item1 if nec do item2 if nec do item3 if nec do item4 if nec do item5 if nec do item6 and many checks. do $selfmod_adress. And just upd

Re: [PATCH 110/110] lib/vdso: Improve do_hres() and update vdso data unconditionally

2019-10-21 Thread Thomas Gleixner
On Mon, 21 Oct 2019, Thomas Gleixner wrote: > On Mon, 21 Oct 2019, Huacai Chen wrote: > > @@ -50,7 +50,7 @@ static int do_hres(const struct vdso_data *vd, clockid_t > > clk, > > cycles = __arch_get_hw_counter(vd->clock_mode); > > ns = vdso_ts->nsec; > > last =

Re: [PATCH 6/6 v2] MMC: JZ4740: Add support for LPM.

2019-10-21 Thread Ulf Hansson
On Sat, 19 Oct 2019 at 22:44, Ezequiel Garcia wrote: > > On Friday, October 18, 2019 13:54 -03, Zhou Yanjie > wrote: > > > > > > > > > > I also have a general question. Should we perhaps rename the driver > > > from jz4740_mmc.c to ingenic.c (and the file for the DT bindings, the > > > Kconfig,

Re: [PATCH 1/7] debugfs: Add debugfs_create_xul() for hexadecimal unsigned long

2019-10-21 Thread Geert Uytterhoeven
Hi Greg, On Mon, Oct 21, 2019 at 4:45 PM Greg Kroah-Hartman wrote: > On Mon, Oct 21, 2019 at 04:37:36PM +0200, Geert Uytterhoeven wrote: > > The existing debugfs_create_ulong() function supports objects of > > type "unsigned long", which are 32-bit or 64-bit depending on the > > platform, in deci

Re: [PATCH v1 2/2] mm/page_isolation.c: Convert SKIP_HWPOISON to MEMORY_OFFLINE

2019-10-21 Thread Michal Hocko
On Mon 21-10-19 16:19:26, David Hildenbrand wrote: > We have two types of users of page isolation: > 1. Memory offlining: Offline memory so it can be unplugged. Memory won't >be touched. > 2. Memory allocation: Allocate memory (e.g., alloc_contig_range()) to >

[PATCH] MAINTAINERS: Add Mihail to Komeda DRM driver

2019-10-21 Thread Mihail Atanassov
I'll be the main point of contact. Cc: James Qian Wang (Arm Technology China) Cc: Liviu Dudau Signed-off-by: Mihail Atanassov --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 94fb077c0817..d32f263f0022 100644 --- a/MAINTAINERS +++ b/MAINTAINER

Re: [PATCH 1/2] dt-bindings: PCI: designware: Add binding for ZRX-DC PHY property

2019-10-21 Thread Andrew Murray
On Mon, Oct 21, 2019 at 08:26:28PM +0530, Pankaj Dubey wrote: > > > > -Original Message- > > From: Andrew Murray > > Sent: Monday, October 21, 2019 7:46 PM > > To: Anvesh Salveru > > Cc: linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux- > > ker...@vger.kernel.org; bhelg...@g

Re: [PATCH v1 2/2] mm/page_isolation.c: Convert SKIP_HWPOISON to MEMORY_OFFLINE

2019-10-21 Thread David Hildenbrand
On 21.10.19 17:02, Michal Hocko wrote: On Mon 21-10-19 16:19:26, David Hildenbrand wrote: We have two types of users of page isolation: 1. Memory offlining: Offline memory so it can be unplugged. Memory won't be touched. 2. Memory allocation: Allocate memory (e.g., alloc_con

[PATCH] drm: Fix DSC throughput mode 0 mask definition

2019-10-21 Thread Siqueira, Rodrigo
Commit d7cd0e05 introduced a change at DP_DSC_THROUGHPUT_MODE_0_170 which is not aligned with the spec. This commit replace 15 << 4 by 15 << 0 for DP_DSC_THROUGHPUT_MODE_0_170 in order to make it follow the specification. Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: Nikola Cornij Cc: Jan

Re: [PATCH] Revert "Bluetooth: hci_qca: Add delay for wcn3990 stability"

2019-10-21 Thread Marcel Holtmann
Hi Jeffrey, > This reverts commit cde9dde6e11a5ab54b6462cd46d82878926783bc. > > The frame reassembly errors were root caused to a transient gpio issue. > The missing response was root caused to an issue with properly managing > RFR in the uart driver. Addressing those root causes occurs outside

Re: [PATCH 2/5] mfd: rn5t618: add irq support

2019-10-21 Thread Andreas Kemnade
On Mon, 21 Oct 2019 11:07:10 +0200 Alexandre Belloni wrote: > Hi, > > On 21/10/2019 07:41:01+0200, Andreas Kemnade wrote: > > +#if 0 > > +/* > > + * REVISIT when implementing charger: > > + * according to some other implementation it needs special treatment, > > + * inverted but experiments seem

Re: [PATCH v3 5/6] x86/ftrace: Use text_poke()

2019-10-21 Thread Josh Poimboeuf
On Wed, Oct 16, 2019 at 09:42:17AM +0200, Peter Zijlstra wrote: > > which are not compatible with livepatching. GCC upstream now has > > -flive-patching option, which disables all those interfering optimizations. > > Which, IIRC, has a significant performance impact and should thus really > not be

Re: [PATCH v4 5/6] media: sun4i: Add H3 deinterlace driver

2019-10-21 Thread Hans Verkuil
On 10/21/19 4:47 PM, Jernej Škrabec wrote: > Dne ponedeljek, 21. oktober 2019 ob 13:13:20 CEST je Hans Verkuil napisal(a): >> On 10/17/19 8:37 PM, Jernej Skrabec wrote: >>> Allwinner H3 SoC contains deinterlace unit, which has several modes of >>> operation - bypass, weave, bob and mixed (advanced)

Re: [PATCH] usbip: Fix free of unallocated memory in vhci tx

2019-10-21 Thread Julia Lawall
On Mon, 21 Oct 2019, Suwan Kim wrote: > iso_buffer should be set to NULL after use and free in the while loop. > In the case of isochronous URB in the while loop, iso_buffer is > allocated and after sending it to server, buffer is deallocated. And > then, if the next URB in the while loop is not

RE: [PATCH 1/2] dt-bindings: PCI: designware: Add binding for ZRX-DC PHY property

2019-10-21 Thread Gustavo Pimentel
On Mon, Oct 21, 2019 at 13:25:55, Anvesh Salveru wrote: > Add support for ZRX-DC compliant PHYs. If PHY is not compliant to ZRX-DC > specification, then after every 100ms link should transition to recovery > state during the low power states which increases power consumption. > > Platforms with

Re: [Letux-kernel] [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-21 Thread Alexandre Belloni
On 21/10/2019 12:31:30+0200, H. Nikolaus Schaller wrote: > >> @@ -0,0 +1,476 @@ > >> +// SPDX-License-Identifier: GPL-2.0+ > >> +/* > >> + * drivers/rtc/rtc-ricoh619.c > >> + * > >> + * Real time clock driver for RICOH R5T619 power management chip. > >> + * > >> + * Copyright (C) 2019 Andreas Kemna

Re: [PATCH] tools lib traceevent: Fix sign variable to return signed in eval_type_str()

2019-10-21 Thread Namhyung Kim
Hi Steve, On Sat, Oct 19, 2019 at 6:07 AM Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > Seems that the value returned by eval_type_str() were always unsigned, and > never signed extended. Luckily, looking at all the trace events that > actually have a signed value seldom (if ev

RE: [PATCH 2/2] PCI: dwc: Add support to handle ZRX-DC Compliant PHYs

2019-10-21 Thread Gustavo Pimentel
On Mon, Oct 21, 2019 at 13:29:53, Anvesh Salveru wrote: > Many platforms use DesignWare controller but the PHY can be different in > different platforms. If the PHY is compliant is to ZRX-DC specification > it helps in low power consumption during power states. > > If current data rate is 8.0 G

Re: [PATCH v3 1/2] clone3: add CLONE_CLEAR_SIGHAND

2019-10-21 Thread Oleg Nesterov
On 10/21, Oleg Nesterov wrote: > > On 10/14, Christian Brauner wrote: > > > > The child helper process on Linux posix_spawn must ensure that no signal > > handlers are enabled, so the signal disposition must be either SIG_DFL > > or SIG_IGN. However, it requires a sigprocmask to obtain the current

Re: [PATCH v2 02/18] mfd: cros_ec: Add sensor_count and make check_features public

2019-10-21 Thread Enric Balletbo i Serra
Hi Gwendal, Many thanks for the patches, some few comments below. On 21/10/19 7:53, Gwendal Grignou wrote: > Add a new function to return the number of MEMS sensors available in a > ChromeOS Embedded Controller. > It uses MOTIONSENSE_CMD_DUMP if available or a specific memory map ACPI > registers

Re: [PATCHv2 4/4] Bluetooth: btwilink: drop superseded driver

2019-10-21 Thread Marcel Holtmann
Hi Sebastian, >>> All users of this driver have been converted to the serdev based >>> hci_ll driver. The unused driver can be safely dropped now. >>> >>> Signed-off-by: Sebastian Reichel >>> --- >>> drivers/bluetooth/Kconfig| 11 -- >>> drivers/bluetooth/Makefile | 1 - >>> drivers/bluet

[PATCH] ARM: dts: exynos: Rename children of SysRAM node to "sram"

2019-10-21 Thread Krzysztof Kozlowski
The device node name should reflect generic class of a device so rename the children of SysRAM node to "smp-sysram". This will be also in sync with upcoming DT schema. No functional change. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250.dtsi | 4 ++-- arch/ar

Re: linux-next: Fixes tag needs some work in the rdma-fixes tree

2019-10-21 Thread Jason Gunthorpe
On Mon, Oct 21, 2019 at 10:50:33AM -0400, Doug Ledford wrote: > On Mon, 2019-10-21 at 18:41 +1100, Stephen Rothwell wrote: > > Hi all, > > > > In commit > > > > 612e0486ad08 ("iw_cxgb4: fix ECN check on the passive accept") > > > > Fixes tag > > > > Fixes: 92e7ae7172 ("iw_cxgb4: Choose appr

Re: [PATCH RFC v2 2/2] USB: ldusb: fix ring-buffer locking

2019-10-21 Thread Alan Stern
On Fri, 18 Oct 2019, Johan Hovold wrote: > The custom ring-buffer implementation was merged without any locking > whatsoever, but a spinlock was later added by commit 9d33efd9a791 > ("USB: ldusb bugfix"). > > The lock did not cover the loads from the ring-buffer entry after > determining the buff

Re: [PATCH] xen/xenbus: fix self-deadlock after killing user process

2019-10-21 Thread Jürgen Groß
On 21.10.19 14:33, James Dingwall wrote: On Tue, Oct 01, 2019 at 05:03:55PM +0200, Juergen Gross wrote: In case a user process using xenbus has open transactions and is killed e.g. via ctrl-C the following cleanup of the allocated resources might result in a deadlock due to trying to end a trans

Re: [PATCH] tty: serial: msm_serial: Fix flow control

2019-10-21 Thread Jeffrey Hugo
On Sun, Oct 20, 2019 at 12:28 AM Bjorn Andersson wrote: > > On Sat 19 Oct 14:06 PDT 2019, Jeffrey Hugo wrote: > > > hci_qca interfaces to the wcn3990 via a uart_dm on the msm8998 mtp and > > Lenovo Miix 630 laptop. As part of initializing the wcn3990, hci_qca > > disables flow, configures the uar

Re: [PATCH v4 2/2] iio: (bma400) add driver for the BMA400

2019-10-21 Thread Jonathan Cameron
On Sat, 19 Oct 2019 02:43:51 + Dan Robertson wrote: > On Fri, Oct 18, 2019 at 10:23:38AM +0300, Andy Shevchenko wrote: > > On Fri, Oct 18, 2019 at 6:44 AM Dan Robertson wrote: > > > > > + * bma400.h - Register constants and other forward declarations > > > + *needed by the bma

Re: [PATCH v5 3/9] i2c: add support for filters optional properties

2019-10-21 Thread Peter Rosin
On 2019-09-11 10:24, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > i2c-digital-filter-width-ns: > This optional timing property specifies the width of the spikes on the i2c > lines (in ns) that can be filtered out by built-in digital filters which are > embedded in some i2c control

Re: [PATCH 0/7] debugfs: Add and use debugfs_create_xul()

2019-10-21 Thread Ulf Hansson
On Mon, 21 Oct 2019 at 16:37, Geert Uytterhoeven wrote: > > Hi all, > > The existing debugfs_create_ulong() function supports objects of > type "unsigned long", which are 32-bit or 64-bit depending on the > platform, in decimal form. To format objects in hexadecimal, various > debugfs_cre

Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver

2019-10-21 Thread Andreas Kemnade
On Mon, 21 Oct 2019 15:50:28 +0200 Alexandre Belloni wrote: > On 21/10/2019 15:19:09+0200, Stefan Agner wrote: > > On 2019-10-21 07:41, Andreas Kemnade wrote: > > > Add an RTC driver for the RTC device on Ricoh MFD rc5t619, > > > which is implemented as a variant of rn5t618 > > > > > > Signed-

Re: [PATCH v5 0/9] i2c: add support for filters

2019-10-21 Thread Peter Rosin
On 2019-10-21 16:05, Wolfram Sang wrote: > On Mon, Oct 07, 2019 at 07:53:21AM +, eugen.hris...@microchip.com wrote: >> >> >> On 11.09.2019 11:24, Eugen Hristev - M18282 wrote: >>> From: Eugen Hristev >>> >>> Hello, >>> >>> This series adds support for analog and digital filters for i2c control

Re: [PATCH] lib/vdso: Make clock_getres() POSIX compliant again

2019-10-21 Thread Christophe Leroy
Le 21/10/2019 à 12:07, Thomas Gleixner a écrit : A recent commit removed the NULL pointer check from the clock_getres() implementation causing a test case to fault. POSIX requires an explicit NULL pointer check for clock_getres() aside of the validity check of the clock_id argument for obscur

[PATCH v2] apparmor: Fix use-after-free in aa_audit_rule_init

2019-10-21 Thread Navid Emamdoost
In the implementation of aa_audit_rule_init(), when aa_label_parse() fails the allocated memory for rule is released using aa_audit_rule_free(). But after this release, the return statement tries to access the label field of the rule which results in use-after-free. Before releasing the rule, copy

Re: [PATCH] apparmor: Fix use-after-free in aa_audit_rule_init

2019-10-21 Thread Navid Emamdoost
On Sun, Oct 20, 2019 at 1:51 PM John Johansen wrote: > > On 10/20/19 7:16 AM, Markus Elfring wrote: > >> … But after this release the the return statement > >> tries to access the label field of the rule which results in > >> use-after-free. Before releaseing the rule, copy errNo and return it > >

Re: [PATCH v2 4/4] KVM: x86/vPMU: Add lazy mechanism to release perf_event per vPMC

2019-10-21 Thread Paolo Bonzini
On 21/10/19 16:04, Like Xu wrote: > >> >> 2) introduce a new callback msr_idx_to_pmc that returns a struct >> kvm_pmc*, and change kvm_pmu_is_valid_msr to do > > For callback msr_idx_to_pmc, > how do we deal with the input 'MSR_CORE_PERF_FIXED_CTR_CTRL' > which may return several fixed kvm_pmcs n

[PATCH v7 00/10] arm64: Stolen time support

2019-10-21 Thread Steven Price
This series add support for paravirtualized time for arm64 guests and KVM hosts following the specification in Arm's document DEN 0057A: https://developer.arm.com/docs/den0057/a It implements support for stolen time, allowing the guest to identify time when it is forcibly not executing. Note tha

Re: [PATCH v2 00/18] cros_ec: Add sensorhub driver and FIFO processing*** SUBJECT HERE

2019-10-21 Thread Jonathan Cameron
On Sun, 20 Oct 2019 22:53:45 -0700 Gwendal Grignou wrote: Tidy up the title for v3! > This patchset adds a sensorhub driver for spreading sensor > events coming from the Embedded controller sensor FIFO: > >+---+ +--+ + >| cros_ec_accel | | cros_ec_gyr

[PATCH v7 09/10] arm/arm64: Make use of the SMCCC 1.1 wrapper

2019-10-21 Thread Steven Price
Rather than directly choosing which function to use based on psci_ops.conduit, use the new arm_smccc_1_1 wrapper instead. In some cases we still need to do some operations based on the conduit, but the code duplication is removed. No functional change. Signed-off-by: Steven Price --- arch/arm/

Re: [PATCH v3 5/6] x86/ftrace: Use text_poke()

2019-10-21 Thread Josh Poimboeuf
On Fri, Oct 18, 2019 at 03:40:58PM +0200, Petr Mladek wrote: > On Fri 2019-10-18 15:03:42, Jessica Yu wrote: > > +++ Miroslav Benes [16/10/19 15:29 +0200]: > > > On Wed, 16 Oct 2019, Miroslav Benes wrote: > > > Thinking about it more... crazy idea. I think we could leverage these new > > > ELF .tex

Re: [PATCH v2 01/18] platform: chrome: Put docs with the code

2019-10-21 Thread Jonathan Cameron
On Sun, 20 Oct 2019 22:53:46 -0700 Gwendal Grignou wrote: > To avoid doc rot, put function documentations with code, not header. > Use kernel-doc style comments for exported functions. > > Signed-off-by: Gwendal Grignou Looks good to me. Acked-by: Jonathan Cameron > --- > New in v2. > > dr

Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

2019-10-21 Thread Peter Zijlstra
On Mon, Oct 21, 2019 at 04:14:02PM +0200, Peter Zijlstra wrote: > On Mon, Oct 21, 2019 at 08:53:12AM -0500, Josh Poimboeuf wrote: > > On Fri, Oct 18, 2019 at 09:35:40AM +0200, Peter Zijlstra wrote: > > > Now that set_all_modules_text_*() is gone, nothing depends on the > > > relation between ->stat

Re: [PATCH v5 0/2] perf: add support for logging debug messages to file

2019-10-21 Thread Namhyung Kim
Hello, On Fri, Oct 18, 2019 at 9:28 AM Changbin Du wrote: > > When in TUI mode, it is impossible to show all the debug messages to > console. This make it hard to debug perf issues using debug messages. > This patch adds support for logging debug messages to file to resolve > this problem. I tho

Re: [PATCH] mmc: fix mmc dma operation

2019-10-21 Thread Jerome Brunet
On Mon 21 Oct 2019 at 16:48, Ulf Hansson wrote: > On Mon, 21 Oct 2019 at 11:17, Jerome Brunet wrote: >> >> >> On Mon 21 Oct 2019 at 09:57, Neil Armstrong wrote: >> >> > Hi, >> > >> > Thanks for the fix. >> > >> > First, you should add "mmc: meson-gx:" in the subject. >> > >> > On 21/10/2019 0

Re: [PATCH 1/7] debugfs: Add debugfs_create_xul() for hexadecimal unsigned long

2019-10-21 Thread Joe Perches
On Mon, 2019-10-21 at 16:37 +0200, Geert Uytterhoeven wrote: > The existing debugfs_create_ulong() function supports objects of > type "unsigned long", which are 32-bit or 64-bit depending on the > platform, in decimal form. To format objects in hexadecimal, various > debugfs_create_x*() functions

Re: linux-next: Fixes tag needs some work in the rdma-fixes tree

2019-10-21 Thread Matteo Croce
On Mon, Oct 21, 2019 at 5:15 PM Jason Gunthorpe wrote: > > On Mon, Oct 21, 2019 at 10:50:33AM -0400, Doug Ledford wrote: > > On Mon, 2019-10-21 at 18:41 +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > In commit > > > > > > 612e0486ad08 ("iw_cxgb4: fix ECN check on the passive accept") >

Re: [PATCH v1 1/2] mm/page_alloc.c: Don't set pages PageReserved() when offlining

2019-10-21 Thread David Hildenbrand
On 21.10.19 16:43, Michal Hocko wrote: On Mon 21-10-19 16:19:25, David Hildenbrand wrote: We call __offline_isolated_pages() from __offline_pages() after all pages were isolated and are either free (PageBuddy()) or PageHWPoison. Nothing can stop us from offlining memory at this point. In __offl

Re: [RFCv1 5/5] arm64/ARM: configs: Change CONFIG_PWM_MESON from m to y

2019-10-21 Thread Anand Moon
Hi Neil, On Mon, 21 Oct 2019 at 19:55, Neil Armstrong wrote: > > Hi Anand, > > On 21/10/2019 16:11, Anand Moon wrote: > > Hi Martin, > > > > On Fri, 18 Oct 2019 at 23:40, Martin Blumenstingl > > wrote: > >> > >> Hi Anand, > >> > >> On Fri, Oct 18, 2019 at 4:04 PM Anand Moon wrote: > >> [...] >

Re: [RFC PATCH v2 10/16] mm,hwpoison: Rework soft offline for free pages

2019-10-21 Thread Michal Hocko
On Mon 21-10-19 14:58:49, Oscar Salvador wrote: > On Fri, Oct 18, 2019 at 02:06:15PM +0200, Michal Hocko wrote: > > On Thu 17-10-19 16:21:17, Oscar Salvador wrote: > > [...] > > > +bool take_page_off_buddy(struct page *page) > > > + { > > > + struct zone *zone = page_zone(page); > > > + unsigned lo

Re: [PATCH] trace: fix race in perf_trace_buf initialization

2019-10-21 Thread Steven Rostedt
On Mon, 21 Oct 2019 10:12:43 +0530 Prateek Sood wrote: > Hi Song, > > Could you please help in this query. I have it ready to go to Linus. I'll wait a few hours, and if I don't hear anything I'll send it out. -- Steve

Re: [PATCH v2 2/8] objtool, kcsan: Add KCSAN runtime functions to whitelist

2019-10-21 Thread Marco Elver
On Mon, 21 Oct 2019 at 17:15, Dmitry Vyukov wrote: > > On Thu, Oct 17, 2019 at 4:13 PM Marco Elver wrote: > > > > This patch adds KCSAN runtime functions to the objtool whitelist. > > > > Signed-off-by: Marco Elver > > --- > > tools/objtool/check.c | 17 + > > 1 file changed, 17

Re: [PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere

2019-10-21 Thread Vivien Didelot
Hi Andrew, On Mon, 21 Oct 2019 14:31:49 +0200, Andrew Lunn wrote: > On Sat, Oct 19, 2019 at 11:19:26PM -0400, Vivien Didelot wrote: > > Do not let the drivers access the ds->ports static array directly > > while there is a dsa_to_port helper for this purpose. > > > > At the same time, un-const t

[PATCH] power: supply: cpcap-charger: Make cpcap_charger_voltage_to_regval static

2019-10-21 Thread zhong jiang
The GCC complains the following case when compiling kernel. drivers/power/supply/cpcap-charger.c:563:5: warning: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static? Signed-off-by: zhong jiang --- drivers/power/supply/cpcap-charger.c | 2 +- 1 file changed, 1 inserti

Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

2019-10-21 Thread Peter Zijlstra
On Mon, Oct 21, 2019 at 05:34:25PM +0200, Peter Zijlstra wrote: > So On IRC Josh suggested we use text_poke() for RELA. Since KLP is only > available on Power and x86, and Power does not have STRICT_MODULE_RWX, > the below should be sufficient. And... s390 also has HAVE_LIVEPATCH and STRICT_MODULE

Re: [PATCH] security/keyring: avoid pagefaults in keyring_read_iterator

2019-10-21 Thread Chris von Recklinghausen
On 10/21/2019 10:21 AM, David Howells wrote: > Chris von Recklinghausen wrote: > >> The put_user call from keyring_read_iterator caused a page fault which >> attempts to lock mm->mmap_sem and type->lock_class (key->sem) in the reverse >> order that keyring_read_iterator did, thus causing the circu

Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2019-10-21 Thread Mika Westerberg
On Mon, Oct 21, 2019 at 04:49:09PM +0200, Karol Herbst wrote: > On Mon, Oct 21, 2019 at 4:09 PM Mika Westerberg > wrote: > > > > On Mon, Oct 21, 2019 at 03:54:09PM +0200, Karol Herbst wrote: > > > > I really would like to provide you more information about such > > > > workaround but I'm not aware

[PATCH v2] tty: serial: msm_serial: Fix flow control

2019-10-21 Thread Jeffrey Hugo
hci_qca interfaces to the wcn3990 via a uart_dm on the msm8998 mtp and Lenovo Miix 630 laptop. As part of initializing the wcn3990, hci_qca disables flow, configures the uart baudrate, and then reenables flow - at which point an event is expected to be received over the uart from the wcn3990. It

Re: [PATCH v2] apparmor: Fix use-after-free in aa_audit_rule_init

2019-10-21 Thread Tyler Hicks
On 2019-10-21 10:23:47, Navid Emamdoost wrote: > In the implementation of aa_audit_rule_init(), when aa_label_parse() > fails the allocated memory for rule is released using > aa_audit_rule_free(). But after this release, the return statement > tries to access the label field of the rule which resu

Re: [PATCH v1 1/2] mm/page_alloc.c: Don't set pages PageReserved() when offlining

2019-10-21 Thread Michal Hocko
On Mon 21-10-19 17:39:36, David Hildenbrand wrote: > On 21.10.19 16:43, Michal Hocko wrote: [...] > > We still set PageReserved before onlining pages and that one should be > > good to go as well (memmap_init_zone). > > Thanks! > > memmap_init_zone() is called when onlining memory. There, set all

Re: KASAN: slab-out-of-bounds Read in handle_vmptrld

2019-10-21 Thread Paolo Bonzini
Fixed now by commit 59bb47985c1d ("mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)"). Paolo On 11/09/19 22:38, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:    1e3778cb Merge tag 'scsi-fixes' of > git://git.kernel.org/pu.. > git tree:  

Re: [PATCH] security/keyring: avoid pagefaults in keyring_read_iterator

2019-10-21 Thread Jarkko Sakkinen
On Fri, Oct 18, 2019 at 02:40:30PM -0400, Chris von Recklinghausen wrote: > under a debug kernel, the following circular locking dependency was observed: > > [ 5896.294840] == > [ 5896.294846] [ INFO: possible circular locking dependency detected

Re: [PATCH v3 4/5] net: dsa: add support for Atheros AR9331 TAG format

2019-10-21 Thread Andrew Lunn
> +static struct sk_buff *ar9331_tag_rcv(struct sk_buff *skb, > + struct net_device *ndev, > + struct packet_type *pt) > +{ > + u8 ver, port; > + u16 hdr; > + > + if (unlikely(!pskb_may_pull(skb, AR9331_HDR_LEN))) > +

Re: [PATCH v2 02/18] mfd: cros_ec: Add sensor_count and make check_features public

2019-10-21 Thread Jonathan Cameron
On Sun, 20 Oct 2019 22:53:47 -0700 Gwendal Grignou wrote: > Add a new function to return the number of MEMS sensors available in a > ChromeOS Embedded Controller. > It uses MOTIONSENSE_CMD_DUMP if available or a specific memory map ACPI > registers to find out. > > Also, make check_features publ

Re: [PATCH] trace: fix race in perf_trace_buf initialization

2019-10-21 Thread Song Liu
> On Oct 21, 2019, at 8:44 AM, Steven Rostedt wrote: > > On Mon, 21 Oct 2019 10:12:43 +0530 > Prateek Sood wrote: > >> Hi Song, >> >> Could you please help in this query. > > I have it ready to go to Linus. I'll wait a few hours, and if I don't > hear anything I'll send it out. > Sorry f

Re: [PATCH v1 1/2] mm/page_alloc.c: Don't set pages PageReserved() when offlining

2019-10-21 Thread David Hildenbrand
On 21.10.19 17:47, Michal Hocko wrote: On Mon 21-10-19 17:39:36, David Hildenbrand wrote: On 21.10.19 16:43, Michal Hocko wrote: [...] We still set PageReserved before onlining pages and that one should be good to go as well (memmap_init_zone). Thanks! memmap_init_zone() is called when onlin

[PATCH] rtc: disallow update interrupts when time is invalid

2019-10-21 Thread Alexandre Belloni
Never enable update interrupts when the time set on the rtc is invalid. In that case, also avoid enabling the emulation because it will fail for the same reason. Signed-off-by: Alexandre Belloni --- drivers/rtc/interface.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-)

[PATCH] rtc: disable uie before setting time and enable after

2019-10-21 Thread Alexandre Belloni
When setting the time in the future with the uie timer enabled, rtc_timer_do_work will loop for a while because the expiration of the uie timer was way before the current RTC time and a new timer will be enqueued until the current rtc time is reached. If the uie timer is enabled, disable it before

Re: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig

2019-10-21 Thread Dinh Nguyen
On 10/17/19 1:28 AM, Ooi, Joyce wrote: > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force in > the default defconfig > > Signed-off-by: Ooi, Joyce > --- > v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax > --- > arch/arm64/configs/defconfig | 2 ++ >

Re: [PATCH v8] tpm_crb: fix fTPM on AMD Zen+ CPUs

2019-10-21 Thread Jarkko Sakkinen
On Wed, Oct 16, 2019 at 09:28:14PM +0300, ivan.laz...@gmail.com wrote: > From: Ivan Lazeev > > Bug link: https://bugzilla.kernel.org/show_bug.cgi?id=195657 > > cmd/rsp buffers are expected to be in the same ACPI region. > For Zen+ CPUs BIOS's might report two different regions, some of > them al

[PATCH 3/4] rtc: sirfsoc: remove .remove

2019-10-21 Thread Alexandre Belloni
dpm_sysfs_remove() and device_pm_remove() are already called by device_del() on device removal so there is no need to call device_init_wakeup(dev, false) from the driver and it allows to remove the .remove callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sirfsoc.c | 8 1 f

[PATCH 4/4] rtc: sc27xx: remove .remove

2019-10-21 Thread Alexandre Belloni
dpm_sysfs_remove() and device_pm_remove() are already called by device_del() on device removal so there is no need to call device_init_wakeup(dev, false) from the driver and it allows to remove the .remove callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sc27xx.c | 7 --- 1 fil

Re: [PATCHv2] arm64: dts: altera: update QSPI reg addresses for Stratix10

2019-10-21 Thread Dinh Nguyen
On 10/16/19 4:44 AM, Ooi, Joyce wrote: > This patch updates the reg addresses for QSPI boot and QSPI rootfs in > the device tree for Stratix10 > > Signed-off-by: Ooi, Joyce > --- > v2: update the qspi_rootfs partition size > --- > arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 6 +++

[PATCH 2/4] rtc: lpc32xx: remove .remove

2019-10-21 Thread Alexandre Belloni
dpm_sysfs_remove() and device_pm_remove() are already called by device_del() on device removal so there is no need to call device_init_wakeup(dev, false) from the driver and it allows to remove the .remove callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-lpc32xx.c | 11 ---

[PATCH 1/4] rtc: ab-b5ze-s3: remove .remove

2019-10-21 Thread Alexandre Belloni
dpm_sysfs_remove() and device_pm_remove() are already called by device_del() on device removal so there is no need to call device_init_wakeup(dev, false) from the driver and it allows to remove the .remove callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ab-b5ze-s3.c | 11 -

Re: WARNING: refcount bug in find_key_to_update

2019-10-21 Thread David Howells
syzbot wrote: > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11c8adab60 How do I tell what's been passed into the add_key for the encrypted key? David

Re: [PATCH v2 03/18] platform: cros_ec: Add cros_ec_sensor_hub driver

2019-10-21 Thread Jonathan Cameron
On Sun, 20 Oct 2019 22:53:48 -0700 Gwendal Grignou wrote: > Similar to HID sensor stack, the new driver sits between cros_ec_dev > and the iio device drivers: > > EC based iio device topology would be: > iio:device1 -> > ...0/:00:1f.0/PNP0C09:00/GOOG0004:00/cros-ec-dev.6.auto/ >

Re: linux-next: Tree for Oct 18 (objtool)

2019-10-21 Thread Randy Dunlap
On 10/21/19 6:11 AM, Peter Zijlstra wrote: > On Mon, Oct 21, 2019 at 02:35:49PM +0200, Peter Zijlstra wrote: >> On Fri, Oct 18, 2019 at 08:33:11AM -0700, Randy Dunlap wrote: >>> On 10/18/19 12:03 AM, Stephen Rothwell wrote: Hi all, Changes since 20191017: >>> >>> on x86_64: >>>

Re: [PATCH v2 04/18] platform/mfd:iio: cros_ec: Register sensor through sensorhub

2019-10-21 Thread Jonathan Cameron
On Sun, 20 Oct 2019 22:53:49 -0700 Gwendal Grignou wrote: > - Remove duplicate code in mfd, since mfd just register > cros_ec_sensorhub if at least one sensor is present > - Change iio cros_ec driver to get the pointer to the cros_ec_dev > through cros_ec_sensorhub. > > Signed-off-by: Gwenda

[PATCH v2] scripts/nsdeps: use alternative sed delimiter

2019-10-21 Thread Jessica Yu
When doing an out of tree build with O=, the nsdeps script constructs the absolute pathname of the module source file so that it can insert MODULE_IMPORT_NS statements in the right place. However, ${srctree} contains an unescaped path to the source tree, which, when used in a sed substitution, make

Re: WARNING: refcount bug in find_key_to_update

2019-10-21 Thread Dmitry Vyukov
On Mon, Oct 21, 2019 at 5:59 PM David Howells wrote: > > syzbot wrote: > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11c8adab60 > > How do I tell what's been passed into the add_key for the encrypted key? Hi David, The easiest and most reliable would be to run it and dum

[PATCH v3] apparmor: Fix use-after-free in aa_audit_rule_init

2019-10-21 Thread Navid Emamdoost
In the implementation of aa_audit_rule_init(), when aa_label_parse() fails the allocated memory for rule is released using aa_audit_rule_free(). But after this release, the return statement tries to access the label field of the rule which results in use-after-free. Before releasing the rule, copy

Re: [PATCH v2] apparmor: Fix use-after-free in aa_audit_rule_init

2019-10-21 Thread Navid Emamdoost
On Mon, Oct 21, 2019 at 10:45 AM Tyler Hicks wrote: > > On 2019-10-21 10:23:47, Navid Emamdoost wrote: > > In the implementation of aa_audit_rule_init(), when aa_label_parse() > > fails the allocated memory for rule is released using > > aa_audit_rule_free(). But after this release, the return sta

Re: [PATCH 16/18] arm64: kprobes: fix kprobes without CONFIG_KRETPROBES

2019-10-21 Thread Kees Cook
On Mon, Oct 21, 2019 at 08:21:48AM +0200, Ard Biesheuvel wrote: > On Fri, 18 Oct 2019 at 18:11, Sami Tolvanen wrote: > > > > This allows CONFIG_KRETPROBES to be disabled without disabling > > kprobes entirely. > > > > Signed-off-by: Sami Tolvanen > > Can we make kretprobes work with the shadow c

Re: [PATCH] ARM: dts: exynos: Rename children of SysRAM node to "sram"

2019-10-21 Thread Alim Akhtar
On Mon, Oct 21, 2019 at 8:45 PM Krzysztof Kozlowski wrote: > > The device node name should reflect generic class of a device so rename > the children of SysRAM node to "smp-sysram". This will be also in sync Typo "smp-sram" > with upcoming DT schema. No functional change. > > Signed-off-by: Krzy

RE:PERSONAL LETTER FROM MRS RASHIA AMIRA

2019-10-21 Thread Mr Barrister Hans Erich
Greetings My name is Barrister Hans Erich. I have a client who is interested to invest in your country, she is a well known politician in her country and deserve a lucrative investment partnership with you outside her country without any delay Please can you manage such investment please Kin

Re: [PATCH v2 3/5] perf report: Sort by sampled cycles percent per block for stdio

2019-10-21 Thread Jiri Olsa
On Tue, Oct 15, 2019 at 01:33:48PM +0800, Jin Yao wrote: SNIP > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -51,6 +51,7 @@ > #include "util/util.h" // perf_tip() > #include "ui/ui.h" > #include "ui/progress.h" > +#include "util/block.h" > > #include > #inclu

Re: [PATCH v2 1/5] perf util: Create new block.h/block.c for block related functions

2019-10-21 Thread Jiri Olsa
On Tue, Oct 15, 2019 at 01:33:46PM +0800, Jin Yao wrote: SNIP > diff --git a/tools/perf/util/Build b/tools/perf/util/Build > index 39814b1806a6..3121c0055950 100644 > --- a/tools/perf/util/Build > +++ b/tools/perf/util/Build > @@ -1,4 +1,5 @@ > perf-y += annotate.o > +perf-y += block.o > perf-y

Re: [PATCH v3] apparmor: Fix use-after-free in aa_audit_rule_init

2019-10-21 Thread Tyler Hicks
On 2019-10-21 11:05:31, Navid Emamdoost wrote: > In the implementation of aa_audit_rule_init(), when aa_label_parse() > fails the allocated memory for rule is released using > aa_audit_rule_free(). But after this release, the return statement > tries to access the label field of the rule which resu

Re: [PATCH v2 3/5] perf report: Sort by sampled cycles percent per block for stdio

2019-10-21 Thread Jiri Olsa
On Mon, Oct 21, 2019 at 04:04:39PM +0200, Jiri Olsa wrote: > On Mon, Oct 21, 2019 at 02:56:57PM +0800, Jin, Yao wrote: > > SNIP > > > > > Does it seem like what the c2c does? > > > > > > well c2c has its own data output with multiline column titles, > > > hence it has its own separate dimension

<    2   3   4   5   6   7   8   9   10   11   >