Re: [PATCH v2] spi: gpio: prevent memory leak in spi_gpio_probe

> … In order to avoid leak spi_contriller_put must > be called in case of failure for devm_add_action_or_reset. How does this wording fit to the diff display that you would like to add the function call “spi_master_put(master)” in one if branch? > Fixes: 8b797490b4db ("spi: gpio: Make sure spi_m

Re: [PATCH] brcmsmac: remove a useless test

Christophe JAILLET wrote: > 'pih' is known to be non-NULL at this point, so the test can be removed. > > Signed-off-by: Christophe JAILLET > Acked-by: Arend van Spriel Patch applied to wireless-drivers-next.git, thanks. 3f1b32bdbb0a brcmsmac: remove a useless test -- https://patchwork.kern

Re: [PATCH 1/2] brcmfmac: don't WARN when there are no requests

Adrian Ratiu wrote: > When n_reqs == 0 there is nothing to do so it doesn't make sense to > search for requests and issue a warning because none is found. > > Signed-off-by: Martyn Welch > Signed-off-by: Adrian Ratiu 2 patches applied to wireless-drivers-next.git, thanks. 1524cbf36215 brcmfm

Re: [PATCH] brcmsmac: remove duplicated if condition

Denis Efremov wrote: > The nested 'li_mimo == &locale_bn' check is excessive and always > true. Thus it can be safely removed. > > Signed-off-by: Denis Efremov Patch applied to wireless-drivers-next.git, thanks. fa38b4fddc7c brcmsmac: remove duplicated if condition -- https://patchwork.kern

Re: [PATCH v3 04/10] sched/fair: rework load_balance

group_asym_packing On Tue, 1 Oct 2019 at 10:15, Dietmar Eggemann wrote: > > On 19/09/2019 09:33, Vincent Guittot wrote: > > > [...] > > > @@ -8042,14 +8104,24 @@ static inline void update_sg_lb_stats(struct lb_env > > *env, > > } > > } > > > > - /* Adjust by relative CPU

Re: [PATCH] sample/hw_breakpoint: avoid sample hw_breakpoint recursion for arm/arm64

On Mon, Sep 23, 2019 at 04:09:35PM +0800, wangxu wrote: > From: Wang Xu > > For x86/ppc, hw_breakpoint is triggered after the instruction is > executed. > > For arm/arm64, which is triggered before the instruction executed. > Arm/arm64 skips the instruction by using single step. But it only > su

Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

Hi Lukasz, On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski wrote: > Call spi_slave_abort() only when the spidev->spi is !NULL and the > structure hasn't already been kfreed. > > Reported-by: kbuild test robot > Reported-by: Julia Lawall > Reported-by: Dan Carpenter > Signed-off-by: Lukasz Maje

Re: [PATCH] iio: adc: Variables could be uninitalized if regmap_read() fails

On Sun, 29 Sep 2019 22:25:39 -0700 Yizhuo wrote: > Several functions in this file are trying to use regmap_read() to > initialize the specific variable, however, if regmap_read() fails, > the variable could be uninitialized but used directly, which is > potentially unsafe. The return value of reg

[PATCH] sched: Avoid spurious lock dependencies

On Thu, Sep 26, 2019 at 08:29:34AM -0400, Qian Cai wrote: > Oh, you were talking about took #3 while holding #2. Anyway, your patch is > working fine so far. Care to post/merge it officially or do you want me to > post > it? Does the below adequately describe the situation? --- Subject: sched:

Re: [PATCH] rsi: release skb if rsi_prepare_beacon fails

Navid Emamdoost wrote: > In rsi_send_beacon, if rsi_prepare_beacon fails the allocated skb should > be released. > > Signed-off-by: Navid Emamdoost Patch applied to wireless-drivers-next.git, thanks. d563131ef23c rsi: release skb if rsi_prepare_beacon fails -- https://patchwork.kernel.org/p

Re: [PATCH] x86/hyperv: make vapic support x2apic mode

On Tue, Oct 01, 2019 at 06:44:08AM +0800, kbuild test robot wrote: > url: > https://github.com/0day-ci/linux/commits/Roman-Kagan/x86-hyperv-make-vapic-support-x2apic-mode/20191001-044238 > config: x86_64-randconfig-e004-201939 (attached as .config) > compiler: gcc-7 (Debian 7.4

Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

Austin Kim wrote: > 'rtstatus' local variable is not used, > so remove it for clean-up. > > Signed-off-by: Austin Kim Patch applied to wireless-drivers-next.git, thanks. 6e7d59776311 rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable -- https://patchwork.kernel.org/patch/11148141/ https

Re: [PATCH] rtlwifi: prevent memory leak in rtl_usb_probe

Navid Emamdoost wrote: > In rtl_usb_probe if allocation for usb_data fails the allocated hw > should be released. In addition the allocated rtlpriv->usb_data should > be released on error handling path. > > Signed-off-by: Navid Emamdoost Patch applied to wireless-drivers-next.git, thanks. 3f9

Re: [PATCH] libertas: fix a potential NULL pointer dereference

Allen Pais wrote: > alloc_workqueue is not checked for errors and as a result, > a potential NULL dereference could occur. > > Signed-off-by: Allen Pais Patch applied to wireless-drivers-next.git, thanks. 7da413a18583 libertas: fix a potential NULL pointer dereference -- https://patchwork.k

Re: [PATCH] rtlwifi: Remove excessive check in _rtl_ps_inactive_ps()

Denis Efremov wrote: > There is no need to check "rtlhal->interface == INTF_PCI" twice in > _rtl_ps_inactive_ps(). The nested check is always true. Thus, the > expression can be simplified. > > Signed-off-by: Denis Efremov > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, t

Re: [PATCH 2/2] mwifiex: use 'total_ie_len' in mwifiex_update_bss_desc_with_ie()

Brian Norris wrote: > This is clearer than copy/pasting the magic number '+ 2' around, and it > even saves the need for one existing comment. > > Cc: Takashi Iwai > Signed-off-by: Brian Norris > Reviewed-by: Takashi Iwai Patch applied to wireless-drivers-next.git, thanks. 0a3ce169476f mwifi

[tip: x86/cleanups] x86/nmi: Remove stale EDAC include leftover

The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: abaebe11dd07adf51b53bb7c56ba35eab267654d Gitweb: https://git.kernel.org/tip/abaebe11dd07adf51b53bb7c56ba35eab267654d Author:Borislav Petkov AuthorDate:Thu, 16 Aug 2018 09:14:04 +02:00 Comm

PERINGATAN !!! PEMBERITAHUAN PEMBARUAN AKUN ZIMBRA

Pengguna Zimbra Yang Terhormat, Kata Sandi Akun Kotak Surat Zimbra Anda Akan Kedaluwarsa dalam 2 Hari KLIK DI SINI Untuk Memperbarui Rekening Akun Anda Segera Untuk Memperbarui Akun Anda. Dukungan Layanan TI Dukungan Zimbra ©

Re: [PATCH] ARM: fix __get_user_check() in case uaccess_* calls are not inlined

On Mon, Sep 30, 2019 at 8:01 AM Masahiro Yamada wrote: > KernelCI reports that bcm2835_defconfig is no longer booting since > commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING > forcibly"): > > https://lkml.org/lkml/2019/9/26/825 > > I also received a regression report from Nicolas

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

Hi Nick, On Mon, Sep 30, 2019 at 02:50:10PM -0700, Nick Desaulniers wrote: > On Mon, Sep 30, 2019 at 5:18 AM Will Deacon wrote: > > On Mon, Sep 30, 2019 at 09:05:11PM +0900, Masahiro Yamada wrote: > > > On Mon, Sep 30, 2019 at 8:26 PM Will Deacon wrote: > > > > FWIW, we've run into issues with C

hello

Hello My name is Eddy William I am a lawyer by profession. I wish to offer you the next of kin to my client. You will inherit the sum of ($14.2 Million) dollars my client left in the bank before his death. My client is a citizen of your country who died in auto crash with his wife and only son. I

Re: [RFC/RFT][PATCH v8] cpuidle: New timer events oriented governor for tickless systems

On Sun, Sep 29, 2019 at 6:05 PM Doug Smythies wrote: > > On 2019.09.26 09:32 Doug Smythies wrote: > > > If the deepest idle state is disabled, the system > > can become somewhat unstable, with anywhere between no problem > > at all, to the occasional temporary jump using a lot more > > power for a

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

On Thu, Sep 19, 2019 at 9:44 AM Chris Chiu wrote: > > On Wed, Sep 11, 2019 at 10:50 AM Chris Chiu wrote: > > > > > > Notes: > > v2: > >- Add helper functions to replace bunch of tdma settings > >- Reformat some lines to meet kernel coding style > > > > > Hi Jes, I've refactored the

Re: [PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

On 01/10/2019 11:12, Tero Kristo wrote: On 01/10/2019 08:07, Tomi Valkeinen wrote: On 30/09/2019 20:48, Tero Kristo wrote: Hmmh, after some testing, it seems there is bad stuff happening with the divider clock implementation, I am re-working it as of now. Basically what is wrong is that with

Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

Hi Geert, Thank you for a very prompt response. > Hi Lukasz, > > On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski wrote: > > Call spi_slave_abort() only when the spidev->spi is !NULL and the > > structure hasn't already been kfreed. > > > > Reported-by: kbuild test robot > > Reported-by: Julia

[tip: x86/build] arch/x86/boot: Use prefix map to avoid embedded paths

The following commit has been merged into the x86/build branch of tip: Commit-ID: 9e2276fa6eb39817dcc4cda415f0199fb7016b37 Gitweb: https://git.kernel.org/tip/9e2276fa6eb39817dcc4cda415f0199fb7016b37 Author:Bruce Ashfield AuthorDate:Thu, 26 Sep 2019 10:32:26 +01:00 Committe

Re: [PATCH] netfilter:get_next_corpse():No need to double check the *bucket

wh_...@126.com wrote: > From: Hongbin Wang > > The *bucket is in for loops,it has been checked. > > Signed-off-by: Hongbin Wang > --- > net/netfilter/nf_conntrack_core.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/net/netfilter/nf_conntrack_core.c

[GIT PULL] irqchip updates for 5.4-rc2

Hi Thomas, Here's a small set of fixes I've collected during the merge window. Nothing major, except for the SiFive PLIC driver which gets promoted to using the fasteoi flow (and now won't crash when a driver masks an interrupt). The rest is a handful of platform support and minor fixes. Please p

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

Hi Will, On Mon, Sep 30, 2019 at 9:18 PM Will Deacon wrote: > > On Mon, Sep 30, 2019 at 09:05:11PM +0900, Masahiro Yamada wrote: > > On Mon, Sep 30, 2019 at 8:26 PM Will Deacon wrote: > > > On Fri, Sep 27, 2019 at 03:38:44PM -0700, Linus Torvalds wrote: > > > > Soem of that code is pretty subtle

Re: [PATCH v2 0/2] reset: meson-audio-arb: add sm1 support

On Thu 05 Sep 2019 at 16:26, Philipp Zabel wrote: > Hi Jerome, > > On Thu, 2019-09-05 at 15:50 +0200, Jerome Brunet wrote: >> This patchset adds the new arb reset lines for the sm1 SoC family >> It has been tested on the sei610 platform. >> >> Changes since v1 [0]: >> * Fix the mistake on the

Re: [PATCH] Partially revert "compiler: enable CONFIG_OPTIMIZE_INLINING forcibly"

On Mon, Sep 30, 2019 at 8:45 PM Will Deacon wrote: > > This reverts commit ac7c3e4ff401b304489a031938dbeaab585bfe0a for ARM and > arm64. > > Building an arm64 kernel with CONFIG_OPTIMIZE_INLINING=y has been shown > to violate fixed register allocations of local variables passed to > inline assembl

RE: Galax GeForce GTX1650 EX-1 Click OC PCI-E 4 GB GDDR5 128Bit Video Card Improves 4K Video Rendering Speeds by LEAPS AND BOUNDS!

More 4K video rendering speeds with my brand new SGD$230 Galax GeForce GTX1650 4 GB GDDR5 video card with hardware encoder: [1] 2 hours 31 mins of 4K video took 2 hours 50 mins to render [2] 2 hours 26 mins of 4K video took 2 hours 44 mins to render [3] 2 hours 27 mins of 4K video took 3 hours

Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe

Hi Jiri, Sorry for the long delay. > CPU: 1 PID: 28401 Comm: kworker/u8:2 Tainted: GW 5.3.0-rc8 #3 > Hardware name: LENOVO 20K5S22R00/20K5S22R00, BIOS R0IET38W (1.16 ) 05/31/2017 > Workqueue: phy0 ieee80211_beacon_connection_loss_work [mac80211] > Call Trace: > dump_stack+0x

[tip: x86/microcode] x86/microcode/amd: Fix two -Wunused-but-set-variable warnings

The following commit has been merged into the x86/microcode branch of tip: Commit-ID: 2b730952066cd022d1f46e801f06ca6ca9878823 Gitweb: https://git.kernel.org/tip/2b730952066cd022d1f46e801f06ca6ca9878823 Author:Borislav Petkov AuthorDate:Sat, 28 Sep 2019 16:53:56 +02:00 Com

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

On 01.10.19 10:32:42, Borislav Petkov wrote: > -- > On Tue, Oct 01, 2019 at 06:56:58AM +, Robert Richter wrote: > > It is *not* the counterpart. The __* version already has the... > > Lemme cut to the chase: > > "Make the ma

Re: [PATCH 1/3] KVM: X86: Add "nopvspin" parameter to disable PV spinlocks

On 2019/10/1 16:39, Vitaly Kuznetsov wrote: Zhenzhong Duan writes: On 2019/9/30 23:41, Vitaly Kuznetsov wrote: Zhenzhong Duan writes: There are cases where a guest tries to switch spinlocks to bare metal behavior (e.g. by setting "xen_nopvspin" on XEN platform and "hv_nopvspin" on HYPER

Re: [PATCH v7 1/1] memory_hotplug: Add a bounds check to __add_pages

On 01.10.19 02:46, Alastair D'Silva wrote: > From: Alastair D'Silva > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > are allocated from firmware. These address ranges may be higher > than what older kernels permit, as we increased the maximum > permissable address in commit 4

Re: [PATCH v2 1/3] selftests: netfilter: add ipvs test script

On Fri, Sep 27, 2019 at 02:21:04PM +0800, Haishuang Yan wrote: > Test virutal server via directing routing for IPv4. > > Tested: > > # selftests: netfilter: ipvs.sh > # Testing DR mode... > # ipvs.sh: PASS > ok 6 selftests: netfilter: ipvs.sh > > Signed-off-by: Haishuang Yan > --- > v2: optimiz

Re: [PATCH 2/2] pwm: stm32: add power management support

Hello Fabrice, On Tue, Oct 01, 2019 at 10:18:31AM +0200, Fabrice Gasnier wrote: > On 10/1/19 9:04 AM, Uwe Kleine-König wrote: > > On Mon, Sep 30, 2019 at 05:39:11PM +0200, Fabrice Gasnier wrote: > >> Add suspend/resume PM sleep ops. When going to low power, enforce the PWM > >> channel isn't activ

[tip: ras/core] x86/mce/amd: Make disable_err_thresholding() static

The following commit has been merged into the ras/core branch of tip: Commit-ID: 47cd84e98f512eac5aad988f08baff432aea35ba Gitweb: https://git.kernel.org/tip/47cd84e98f512eac5aad988f08baff432aea35ba Author:Borislav Petkov AuthorDate:Sat, 28 Sep 2019 19:02:29 +02:00 Committe

Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe

On Tue, 2019-10-01 at 11:46 +0200, Johannes Berg wrote: > > ieee80211_wake_queues_by_reason() does > spin_lock_irqsave()/spin_unlock_irqrestore() - why is that "{SOFTIRQ-ON- > W} usage"? scratch that - _ieee80211_wake_txqs() unlocks that again... It does hold RCU critical section, but that's not

Re: [PATCH v2 0/2] ipvs: speedup ipvs netns dismantle

On Mon, Sep 30, 2019 at 10:08:23PM +0300, Julian Anastasov wrote: > > Hello, > > On Fri, 27 Sep 2019, Haishuang Yan wrote: > > > Implement exit_batch() method to dismantle more ipvs netns > > per round. > > > > Tested: > > $ cat add_del_unshare.sh > > #!/bin/bash > > > > for i in `seq 1

Re: [PATCH] kbuild: add $(BASH) to run scripts with bash-extension

Hi Yamada-san, On Sun, Aug 25, 2019 at 3:29 PM Masahiro Yamada wrote: > CONFIG_SHELL falls back to sh when bash is not installed on the system, > but nobody is testing such a case since bash is usually installed. > That is, shell scripts invoked by CONFIG_SHELL are only tested with > bash. > > It

xenbus hang after userspace ctrl-c of xenstore-rm

Hi, I have been investigating a problem where xenstore becomes unresponsive during domain shutdowns. My test script seems to trigger the problem but without definitively being the same. It is possible to replicate the issue in dom0 or a domU. If the test script is run in dom0 it seems that

Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

Hi Lukasz, On Tue, Oct 1, 2019 at 11:34 AM Lukasz Majewski wrote: > > On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski wrote: > > > Call spi_slave_abort() only when the spidev->spi is !NULL and the > > > structure hasn't already been kfreed. > > > > > > Reported-by: kbuild test robot > > > Repor

Re: [PATCH] nvmem: sc27xx: Change to use devm_hwspin_lock_request_specific() to request one hwlock

On 27/09/2019 04:12, Baolin Wang wrote: Change to use devm_hwspin_lock_request_specific() to help to simplify the cleanup code for drivers requesting one hwlock. Thus we can remove the redundant sc27xx_efuse_remove() and platform_set_drvdata(). Signed-off-by: Baolin Wang --- drivers/nvmem/

Re: [PATCH] net: mac80211: Disable preeemption when updating stat counters

On Fri, 2019-09-27 at 11:41 -0400, Aaron Hill wrote: > The mac80211 subsystem maintains per-cpu stat counters for receive and > transmit operations. Previously, preemption was not disabled when > updating these counters. This creates a race condition where two cpus > could attempt to update the sam

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

On Tue, Oct 1, 2019 at 11:11 AM Mika Westerberg wrote: > > On Tue, Oct 01, 2019 at 10:56:39AM +0200, Karol Herbst wrote: > > On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg > > wrote: > > > > > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > > On Mon, Sep 30, 2019 at 6:30 PM

Re: [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework

Hi Jones, I am very Thankful to your review comments. Actually The driver is not totally based on MFD. It just uses mfd_add_hotplug_devices() and mfd_remove_devices() for adding the devices automatically. Remaining code has nothing to do with MFD framework. So I thought It would not break the

Re: [PATCH] sched: Avoid spurious lock dependencies

On 01/10/2019 10:18, Peter Zijlstra wrote: > On Thu, Sep 26, 2019 at 08:29:34AM -0400, Qian Cai wrote: > >> Oh, you were talking about took #3 while holding #2. Anyway, your patch is >> working fine so far. Care to post/merge it officially or do you want me to >> post >> it? > > Does the below a

[PATCH v2] mtd: st_spi_fsm: remove unused field from struct stfsm

From: Bartosz Golaszewski The 'region' field in struct stfsm is unused and can be removed. Signed-off-by: Bartosz Golaszewski --- v1 -> v2: - fixed the commit message: it now says field instead of variable drivers/mtd/devices/st_spi_fsm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dri

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

Hi Tom, Thanks for the patch. I'd suggest that you rename the subject of this series to "PCI: cadence: ..." to be consistent with the existing commit history, e.g. git log --oneline drivers/pci/controller/pcie-cadence* - you'll also see that you don't need a full stop at the end, and you ought t

Re: [PATCH] gpiolib: sanitize flags before allocating memory in lineevent_create()

pon., 16 wrz 2019 o 11:46 Bartosz Golaszewski napisał(a): > > From: Bartosz Golaszewski > > Move all the flags sanitization before any memory allocation in > lineevent_create() in order to remove a couple unneeded gotos. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/gpio/gpiolib.c | 42

iwlwifi regression patch for stable kernel 5.3.x

Hi, the following patch to fix a regression in the iwlwifi modul is currently not in the pipeline for the stable kernel 5.3.x? https://patchwork.kernel.org/patch/11158395/ Checked Kernel: 5.3.1 Card: 03:00.0 Network controller: Intel Corporation Wireless 8260 (rev 3a) Current Firmware: iwlwifi

Re: [v6 PATCH] RISC-V: Remove unsupported isa string info print

On Tue, Oct 01, 2019 at 08:22:37AM +, Atish Patra wrote: > riscv_of_processor_hartid() or seems to be a better candidate. We > already check if "rv" is present in isa string or not. I will extend > that to check for rv64i or rv32i. Is that okay ? I'd rather lift the checks out of that into a f

Re: [PATCH 3/3] memory: samsung: exynos5422-dmc: Add support for interrupt from performance counters

Hi Krzysztof, On 9/27/19 11:19 AM, Krzysztof Kozlowski wrote: > On Wed, Sep 25, 2019 at 06:18:13PM +0200, Lukasz Luba wrote: >> Introduce a new interrupt driven mechanism for managing speed of the >> memory controller. The interrupts are generated due to performance >> counters overflow. The perfo

Re: [PATCH V2 1/2] nvmem: imx: scu: support hole region check

On 27/09/2019 03:23, Peng Fan wrote: From: Peng Fan Introduce HOLE/ECC_REGION flag and in_hole helper to ease the check of hole region. The ECC_REGION is also introduced here which is preparing for programming support. ECC_REGION could only be programmed once, so need take care. Signed-off-

Re: [PATCH v8 1/5] kasan: support backing vmalloc space with real shadow memory

Hello, Daniel. > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index a3c70e275f4e..9fb7a16f42ae 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -690,8 +690,19 @@ merge_or_add_vmap_area(struct vmap_area *va, > struct list_head *next; > struct rb_node **link; > struct rb_node *p

[tip: core/objtool] x86/insn: Fix awk regexp warnings

The following commit has been merged into the core/objtool branch of tip: Commit-ID: 700c1018b86d0d4b3f1f2d459708c0cdf42b521d Gitweb: https://git.kernel.org/tip/700c1018b86d0d4b3f1f2d459708c0cdf42b521d Author:Alexander Kapshuk AuthorDate:Tue, 24 Sep 2019 07:46:59 +03:00 Co

Re: [RFC PATCH 1/5] x86: tsc: add tsc to art helpers

Hi, (sorry for the long delay, got caught up in other tasks) Thomas Gleixner writes: > On Thu, 15 Aug 2019, Felipe Balbi wrote: >> Thomas Gleixner writes: >> > On Tue, 16 Jul 2019, Felipe Balbi wrote: >> > >> > So some information what those interfaces are used for and why they are >> > needed

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

On Tue, Oct 01, 2019 at 09:47:07AM +, Robert Richter wrote: > If you move to static inline for edac_device_handle_{ce,ue} the > symbols vanish and this breaks the abi. That's why the split in two > patches. ABI issues do not concern upstream. And that coming from me working at a company who da

Re: [PATCH 1/6] arm64: dts: rockchip: Fix rk3399-roc-pc pwm2 pin

Hi Heiko, On Mon, Sep 30, 2019 at 2:51 AM Heiko Stuebner wrote: > > Hi Jagan, > > Am Donnerstag, 19. September 2019, 07:28:17 CEST schrieb Jagan Teki: > > ROC-PC is not able to boot linux console if PWM2_d is > > unattached to any pinctrl logic. > > > > To be precise the linux boot hang with last

RE: x86/random: Speculation to the rescue

From: Linus Torvalds > Sent: 30 September 2019 17:16 > > On Mon, Sep 30, 2019 at 6:16 AM Theodore Y. Ts'o wrote: > > > > Which is to say, I'm still worried that people with deep access to the > > implementation details of a CPU might be able to reverse engineer what > > a jitter entropy scheme pr

[PATCH 3/3] thunderbolt: Drop unnecessary read when writing LC command in Ice Lake

The read is not needed as we overwrite the returned value in the next line anyway so drop it. Fixes: 3cdb9446a117 ("thunderbolt: Add support for Intel Ice Lake") Reported-by: Nicholas Johnson Signed-off-by: Mika Westerberg --- drivers/thunderbolt/nhi_ops.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 0/3] thunderbolt: Fixes for few reported issues

Hi all, This series includes fixes for a couple of issues people have reported: - Discovering DP path fails on Light Ridge based iMac with two devices (monitors) connected. - There is a lockdep splat on Dominik's system when plugging in Thunderbolt dock. - Nicholas spotted that we

[PATCH 2/3] thunderbolt: Fix lockdep circular locking depedency warning

When lockdep is enabled, plugging Thunderbolt dock on Dominik's laptop triggers following splat: == WARNING: possible circular locking dependency detected 5.3.0-rc6+ #1 Tainted: GT -

[PATCH 1/3] thunderbolt: Read DP IN adapter first two dwords in one go

When we discover existing DP tunnels the code checks whether DP IN adapter port is enabled by calling tb_dp_port_is_enabled() before it continues the discovery process. On Light Ridge (gen 1) controller reading only the first dword of the DP IN config space causes subsequent access to the same DP I

[PATCH 2/2] can: usb_8dev: fix use-after-free on disconnect

The driver was accessing its driver data after having freed it. Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from 8 devices") Cc: stable # 3.9 Cc: Bernd Krumboeck Cc: Wolfgang Grandegger Signed-off-by: Johan Hovold --- drivers/net/can/usb/usb_8dev.c | 3 +-- 1 f

[PATCH 1/2] can: mcba_usb: fix use-after-free on disconnect

The driver was accessing its driver data after having freed it. Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer") Cc: stable # 4.12 Cc: Remigiusz Kołłątaj Reported-by: syzbot+e29b17e5042bbc56f...@syzkaller.appspotmail.com Signed-off-by: Johan Hovold --- dri

[PATCH 0/2] can: fix use-after-free on USB disconnect

Syzbot reported a use-after-free on disconnect in mcba_usb and a quick grep revealed a similar issue in usb_8dev. Compile-tested only. Johan Johan Hovold (2): can: mcba_usb: fix use-after-free on disconnect can: usb_8dev: fix use-after-free on disconnect drivers/net/can/usb/mcba_usb.c | 3

Re: [PATCH v2 0/4] sched/fair: Active balancer RT/DL preemption fix

(expanded the Cc list) RT/DL folks, any thought on the thing? On 15/08/2019 15:51, Valentin Schneider wrote: > Vincent's load balance rework [1] got me thinking about how and where we > use rq.nr_running vs rq.cfs.h_nr_running checks, and this lead me to > stare intently at the active load balance

Re: KASAN: use-after-free Read in usb_kill_anchored_urbs

On Tue, Jun 11, 2019 at 10:25:05AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:69bbe8c7 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.t

Re: [PATCH 05/13] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number

Hi Gwendal and Enrico On 22/9/19 19:50, Gwendal Grignou wrote: > From: Enrico Granata > > Add a layer of sanity checking to cros_ec_register against attempting to > register IRQ values that are not strictly greater than 0. > > Signed-off-by: Enrico Granata I'll get rid of this signed-off as i

Re: [PATCH 04/13] platform: chrome: cros-ec: record event timestamp in the hard irq

Hi Gwendal, Some comments below. On 22/9/19 19:50, Gwendal Grignou wrote: > To improve sensor timestamp precision, given EC and AP are in > different time domains, the AP needs to try to record the exact > moment an event was signalled to the AP by the EC as soon as > possible after it happens. >

Re: [PATCH 02/13] platform: cros_ec: Add cros_ec_sensor_hub driver

Hi Gwendal, Some comments below. On 22/9/19 19:50, Gwendal Grignou wrote: > Similar to HID sensor stack, the new driver sits between cros_ec_dev > and the iio device drivers: > > EC based iio device topology would be: > iio:device1 -> > ...0/:00:1f.0/PNP0C09:00/GOOG0004:00/cros-ec-dev.6.auto

Re: [PATCH v2 1/2] dt-bindings: nvmem: Add Spreadtrum eFuse controller documentation

On 10/09/2019 06:52, Baolin Wang wrote: From: Freeman Liu This patch adds the binding documentation for Spreadtrum eFuse controller. Signed-off-by: Freeman Liu Signed-off-by: Baolin Wang Reviewed-by: Rob Herring --- Applied both, Thanks, srini Changes from v1: - Add reviewed tag fr

Re: KASAN: use-after-free Read in mcba_usb_disconnect

On Mon, Sep 30, 2019 at 03:39:15PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:2994c077 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.t

Re: [PATCH 06/13] platform: chrome: cros_ec: handle MKBP more events flag

Hi Gwendal and Enrico, Some comments below. On 22/9/19 19:50, Gwendal Grignou wrote: > From: Enrico Granata > > The ChromeOS EC has support for signaling to the host that > a single IRQ can serve multiple MKBP events. > > Doing this serves an optimization purpose, as it minimizes the > number

Re: [PATCH 10/15] mm: Allow find_get_page to be used for large pages

On Tue, Sep 24, 2019 at 05:52:09PM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Add FGP_PMD to indicate that we're trying to find-or-create a page that > is at least PMD_ORDER in size. The internal 'conflict' entry usage > is modelled after that in DAX, but the implementati

Re: [PATCH v3] arm64/sve: Fix wrong free for task->thread.sve_state

On Mon, Sep 30, 2019 at 04:56:00PM -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > The system which has SVE feature crashed because of > the memory pointed by task->thread.sve_state was destroyed > by someone. > > That is because sve_state is freed while the forking the > child proce

Re: [PATCH 4/6] arm64: dts: rockchip: Rename roc-pc with libretech notation

On Mon, Sep 30, 2019 at 3:02 AM Heiko Stuebner wrote: > > Hi Jagan, > > Am Donnerstag, 19. September 2019, 07:28:20 CEST schrieb Jagan Teki: > > Though the ROC-PC is manufactured by firefly, it is co-designed > > by libretch like other Libretech computer boards from allwinner, > > amlogic does. >

Re: [PATCH 1/6] arm64: dts: rockchip: Fix rk3399-roc-pc pwm2 pin

Hi On Tue, Oct 1, 2019 at 12:26 PM Jagan Teki wrote: > > Hi Heiko, > > On Mon, Sep 30, 2019 at 2:51 AM Heiko Stuebner wrote: > > > > Hi Jagan, > > > > Am Donnerstag, 19. September 2019, 07:28:17 CEST schrieb Jagan Teki: > > > ROC-PC is not able to boot linux console if PWM2_d is > > > unattached

Re: [PATCH 11/15] mm: Remove hpage_nr_pages

On Tue, Sep 24, 2019 at 05:52:10PM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This function assumed that compound pages were necessarily PMD sized. > While that may be true for some users, it's not going to be true for > all users forever, so it's better to remove it and a

[tip: x86/boot] x86/realmode: Explicitly set entry point via ENTRY in linker script

The following commit has been merged into the x86/boot branch of tip: Commit-ID: 3f5f909bc331a7ff9120b11c8e0e320d60b01c89 Gitweb: https://git.kernel.org/tip/3f5f909bc331a7ff9120b11c8e0e320d60b01c89 Author:Nick Desaulniers AuthorDate:Wed, 25 Sep 2019 11:09:06 -07:00 Committ

Re: [PATCH 12/15] mm: Support removing arbitrary sized pages from mapping

On Tue, Sep 24, 2019 at 05:52:11PM -0700, Matthew Wilcox wrote: > From: William Kucharski > > __remove_mapping() assumes that pages can only be either base pages > or HPAGE_PMD_SIZE. Ask the page what size it is. You also fixes the issue CONFIG_READ_ONLY_THP_FOR_FS=y with this patch. The new fe

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

Hi Andrew Murray, On 01/10/19 3:37 PM, Andrew Murray wrote: > Hi Tom, > > Thanks for the patch. > > I'd suggest that you rename the subject of this series to "PCI: cadence: ..." > to be consistent with the existing commit history, e.g. git log > --oneline drivers/pci/controller/pcie-cadence* -

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

On Tue, Oct 01, 2019 at 06:39:34PM +0900, Masahiro Yamada wrote: > On Mon, Sep 30, 2019 at 9:18 PM Will Deacon wrote: > > I agree that the ARM code looks dodgy with > > that call to uaccess_save_and_enable(), but there are __asmeq macros > > in there to try to catch that, so it's still very fishy.

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

On Tue, Oct 01, 2019 at 04:08:45PM +0530, Kishon Vijay Abraham I wrote: > Hi Andrew Murray, > > On 01/10/19 3:37 PM, Andrew Murray wrote: > > Hi Tom, > > > > Thanks for the patch. > > > > I'd suggest that you rename the subject of this series to "PCI: cadence: > > ..." > > to be consistent with

Re: [PATCH 13/15] mm: Add a huge page fault handler for files

On Tue, Sep 24, 2019 at 05:52:12PM -0700, Matthew Wilcox wrote: > From: William Kucharski > > Add filemap_huge_fault() to attempt to satisfy page > faults on memory-mapped read-only text pages using THP when possible. > > Signed-off-by: William Kucharski > [rebased on top of mm prep patches --

Re: [PATCH] Partially revert "compiler: enable CONFIG_OPTIMIZE_INLINING forcibly"

On Tue, Oct 01, 2019 at 06:40:26PM +0900, Masahiro Yamada wrote: > On Mon, Sep 30, 2019 at 8:45 PM Will Deacon wrote: > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 93d97f9b0157..c37c72adaeff 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -312,6 +312,7 @@ c

Re: [PATCH][next] can: fix resource leak of skb on error return paths

On Wed, Sep 18, 2019 at 11:11:56AM +0100, Colin King wrote: > From: Colin Ian King > > Currently the error return paths do not free skb and this results > in a memory leak. Fix this by freeing them before the return. > > Addresses-Coverity: ("Resource leak") > Fixes: 9d71dd0c7009 ("can: add supp

Re: [PATCH 14/15] mm: Align THP mappings for non-DAX

On Tue, Sep 24, 2019 at 05:52:13PM -0700, Matthew Wilcox wrote: > From: William Kucharski > > When we have the opportunity to use transparent huge pages to map a > file, we want to follow the same rules as DAX. > > Signed-off-by: William Kucharski > Signed-off-by: Matthew Wilcox (Oracle) > ---

[PATCH 1/2] usb: roles: Add usb_role_switch_find_by_fwnode()

Simple wrapper function that searches USB role switches with class_find_device_by_fwnode(). Signed-off-by: Heikki Krogerus --- drivers/usb/roles/class.c | 21 + include/linux/usb/role.h | 3 +++ 2 files changed, 24 insertions(+) diff --git a/drivers/usb/roles/class.c b/dri

[PATCH 2/2] extcon: axp288: Remove the build-in connection description

Getting handle to the USB role switch by first finding its software fwnode. Signed-off-by: Heikki Krogerus --- drivers/extcon/extcon-axp288.c | 38 -- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/e

Re: [PATCH 2/2] nvmem: add Rockchip OTP driver

On 25/09/2019 19:49, Heiko Stuebner wrote: From: Finley Xiao Newer Rockchip socs like the px30 use a different one-time-programmable memory controller for things like cpu-id and leakage information, so add the necessary driver for it. Signed-off-by: Finley Xiao [ported from vendor 4.4, con

[PATCH 0/2] extcon: axp288: Move to swnodes

Hi Hans, That AXP288 extcon driver is the last that uses build-in connection description. I'm replacing it with a code that finds the role mux software node instead. I'm proposing also here a little helper usb_role_switch_find_by_fwnode() that uses class_find_device_by_fwnode() to find the role s

Re: [PATCH v4 1/2] edac: Add an API for edac device to report for multiple errors

On 01.10.19 12:25:39, Borislav Petkov wrote: > On Tue, Oct 01, 2019 at 09:47:07AM +, Robert Richter wrote: > > If you move to static inline for edac_device_handle_{ce,ue} the > > symbols vanish and this breaks the abi. That's why the split in two > > patches. > > ABI issues do not concern upst

Re: [PATCH] m68k: defconfig: Update defconfigs for v5.4-rc1

On 10/01/2019 09:35 AM, Geert Uytterhoeven wrote: > Should support for ICY and LTC2990 be enabled in amiga_defconfig and/or > multi_defconfig? > > +CONFIG_I2C=m > +CONFIG_I2C_CHARDEV=m > +CONFIG_I2C_ICY=m > > +CONFIG_HWMON=m > +CONFIG_SENSORS_LTC2990=m Sounds like a good idea

Re: [PATCH 4/6] arm64: dts: rockchip: Rename roc-pc with libretech notation

On Tue, Oct 1, 2019 at 6:34 PM Jagan Teki wrote: > > On Mon, Sep 30, 2019 at 3:02 AM Heiko Stuebner wrote: > > > > Hi Jagan, > > > > Am Donnerstag, 19. September 2019, 07:28:20 CEST schrieb Jagan Teki: > > > Though the ROC-PC is manufactured by firefly, it is co-designed > > > by libretch like ot

Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

Hi Geert, > Hi Lukasz, > > On Tue, Oct 1, 2019 at 11:34 AM Lukasz Majewski wrote: > > > On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski > > > wrote: > > > > Call spi_slave_abort() only when the spidev->spi is !NULL and > > > > the structure hasn't already been kfreed. > > > > > > > > Reported

<    1   2   3   4   5   6   7   8   9   10   >