Re: [PATCH v2] staging: rtl8188eu: remove dead code/vestigial do..while loop

2019-09-27 Thread Dan Carpenter
Looks good. Thanks! regards, dan carpenter

Re: [PATCH 6/7] clk: meson: axg-audio: provide clk top signal name

2019-09-27 Thread Jerome Brunet
On Fri 27 Sep 2019 at 11:37, Neil Armstrong wrote: > On 27/09/2019 11:14, Neil Armstrong wrote: >> On 24/09/2019 17:33, Jerome Brunet wrote: >> [...] >> AUD_CLKID_TOP seems to be missing here > > Oh, yes it was exposed, do you need to it to be exposed since it's > dummy for G12A ? It is a by

hello

2019-09-27 Thread joe akaba
Hello My name is Joe Akaba I am a lawyer by profession. I wish to offer you the next of kin to my client. You will inherit the sum of ($8.5 Million) dollars my client left in the bank before his death. My client is a citizen of your country who died in auto crash with his wife and only son. I wil

Re: [PATCH 7/7] clk: meson: axg_audio: add sm1 support

2019-09-27 Thread Jerome Brunet
On Fri 27 Sep 2019 at 11:36, Neil Armstrong wrote: >> >> static struct clk_regmap spdifout_clk_sel = >> AUD_MST_MCLK_MUX(spdifout_clk, AUDIO_CLK_SPDIFOUT_CTRL); >> @@ -502,7 +522,6 @@ static struct clk_regmap tdmout_c_lrclk = >> AUD_TDM_LRLCK(out_c, AUDIO_CLK_TDMOUT_C_CTRL); >> >

Re: [PATCH] checkpatch: Warn if DT bindings are not in schema format

2019-09-27 Thread Rob Herring
On Fri, Sep 13, 2019 at 4:48 PM Joe Perches wrote: > > On Fri, 2019-09-13 at 16:13 -0500, Rob Herring wrote: > > DT bindings are moving to using a json-schema based schema format > > instead of freeform text. Add a checkpatch.pl check to encourage using > > the schema for new bindings. It's not ye

Re: [PATCH] nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs

2019-09-27 Thread Markus Elfring
> @@ -433,6 +435,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app, > err = nfp_repr_init(app, repr, > port_id, port, priv->nn->dp.netdev); > if (err) { > + kfree(repr_priv); > nfp_port_free(p

Re: [PATCH 6/7] clk: meson: axg-audio: provide clk top signal name

2019-09-27 Thread Neil Armstrong
On 27/09/2019 15:58, Jerome Brunet wrote: > > On Fri 27 Sep 2019 at 11:37, Neil Armstrong wrote: > >> On 27/09/2019 11:14, Neil Armstrong wrote: >>> On 24/09/2019 17:33, Jerome Brunet wrote: >>> > > [...] > >>> AUD_CLKID_TOP seems to be missing here >> >> Oh, yes it was exposed, do you need to

Re: [PATCH v2 2/2] ptp: Add a ptp clock driver for IDT ClockMatrix.

2019-09-27 Thread Vincent Cheng
On Fri, Sep 27, 2019 at 08:25:18AM EDT, Andrew Lunn wrote: >> +static s32 idtcm_xfer(struct idtcm *idtcm, >> + u8 regaddr, >> + u8 *buf, >> + u16 count, >> + bool write) >> +{ >> +struct i2c_client *client = idtcm->client; >> +

[PATCH] rtc: rv3028: add clkout support

2019-09-27 Thread Parthiban Nallathambi
rv3028 provides clkout (enabled by default). Add clkout to clock framework source and control from device tree for variable frequency with enable and disable functionality. Signed-off-by: Parthiban Nallathambi --- drivers/rtc/rtc-rv3028.c | 156 +++ 1 file cha

Re: WARNING in pvr2_i2c_core_done

2019-09-27 Thread Alan Stern
On Fri, 27 Sep 2019, Greg Kroah-Hartman wrote: > > It turns out the reason for this error is simple: The driver > > unregisters its subdevices in the release handler instead of in the > > disconnect handler. There probably is documentation about this > > somewhere, but I don't know exactly whe

Re: Documentation for plain accesses and data races

2019-09-27 Thread Alan Stern
On Fri, 27 Sep 2019, Andrea Parri wrote: > On Fri, Sep 06, 2019 at 02:11:29PM -0400, Alan Stern wrote: > > Folks: > > > > I have spent some time writing up a section for > > tools/memory-model/Documentation/explanation.txt on plain accesses and > > data races. The initial version is below. > >

Re: [PATCH] kasan: fix the missing underflow in memmove and memcpy with CONFIG_KASAN_GENERIC=y

2019-09-27 Thread Walter Wu
On Fri, 2019-09-27 at 15:07 +0200, Dmitry Vyukov wrote: > On Fri, Sep 27, 2019 at 5:43 AM Walter Wu wrote: > > > > memmove() and memcpy() have missing underflow issues. > > When -7 <= size < 0, then KASAN will miss to catch the underflow issue. > > It looks like shadow start address and shadow end

Re: [PATCH 1/2] KVM: nVMX: Always write vmcs02.GUEST_CR3 during nested VM-Enter

2019-09-27 Thread Sean Christopherson
On Thu, Sep 26, 2019 at 04:39:28PM -0700, Jim Mattson wrote: > On Thu, Sep 26, 2019 at 2:43 PM Sean Christopherson > wrote: > > - vmcs_writel(GUEST_CR3, guest_cr3); > > + if (!skip_cr3) > > + vmcs_writel(GUEST_CR3, guest_cr3); > > Is this part of the change necessary, or

Re: [PATCH 2/2] KVM: VMX: Skip GUEST_CR3 VMREAD+VMWRITE if the VMCS is up-to-date

2019-09-27 Thread Sean Christopherson
On Fri, Sep 27, 2019 at 02:11:27PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > Skip the VMWRITE to update GUEST_CR3 if CR3 is not available, i.e. has > > not been read from the VMCS since the last VM-Enter. If vcpu->arch.cr3 > > is stale, kvm_read_cr3(vcpu) will refresh vc

Re: [PATCH] nfp: flower: prevent memory leak in nfp_flower_spawn_phy_reprs

2019-09-27 Thread Markus Elfring
> In nfp_flower_spawn_phy_reprs, in the for loop over eth_tbl if any of > intermediate allocations or initializations fail memory is leaked. > requiered releases are added. I suggest to improve also this change description. > @@ -542,6 +545,7 @@ nfp_flower_spawn_phy_reprs(struct nfp_app *app, st

Re: [PATCH 1/2] KVM: nVMX: Always write vmcs02.GUEST_CR3 during nested VM-Enter

2019-09-27 Thread Sean Christopherson
On Fri, Sep 27, 2019 at 03:06:02AM +0300, Liran Alon wrote: > > > > On 27 Sep 2019, at 0:43, Sean Christopherson > > wrote: > > > > Write the desired L2 CR3 into vmcs02.GUEST_CR3 during nested VM-Enter > > isntead of deferring the VMWRITE until vmx_set_cr3(). If the VMWRITE > > is deferred, t

[GIT PULL] 9p updates for 5.4

2019-09-27 Thread Dominique Martinet
Hi Linus, Some of the usual small fixes and cleanup. I didn't get the target version wrong this time! :) The following changes since commit 089cf7f6ecb266b6a4164919a2e69bd2f938374a: Linux 5.3-rc7 (2019-09-02 09:57:40 -0700) are available in the Git repository at: https://github.com/marti

[PATCH v6 9/9] powerpc/ima: update ima arch policy to check for blacklist

2019-09-27 Thread Nayna Jain
This patch updates the arch specific policies for PowernV systems to add check against blacklisted hashes before doing the verification. Signed-off-by: Nayna Jain --- arch/powerpc/kernel/ima_arch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ima_ar

[PATCH v6 8/9] ima: deprecate permit_directio, instead use appraise_flag

2019-09-27 Thread Nayna Jain
This patch deprecates the existing permit_directio flag, instead adds it as possible value to appraise_flag parameter. For eg. appraise_flag=permit_directio Signed-off-by: Nayna Jain --- Documentation/ABI/testing/ima_policy | 4 ++-- security/integrity/ima/ima_policy.c | 2 ++ 2 files changed,

Re: [PATCH] ASoC: amd: acp3x: clean up an indentation issue

2019-09-27 Thread Dan Carpenter
On Fri, Sep 27, 2019 at 11:43:31AM +0100, Colin Ian King wrote: > On 27/09/2019 11:38, Colin King wrote: > > From: Colin Ian King > > > > There is a return statement that is indented too deeply, remove > > the extraneous tab. > > > > Signed-off-by: Colin Ian King > > --- > > sound/soc/amd/rave

Re: [PATCH] checkpatch: Warn if DT bindings are not in schema format

2019-09-27 Thread Joe Perches
On Fri, 2019-09-27 at 09:02 -0500, Rob Herring wrote: > On Fri, Sep 13, 2019 at 4:48 PM Joe Perches wrote: > > On Fri, 2019-09-13 at 16:13 -0500, Rob Herring wrote: > > > DT bindings are moving to using a json-schema based schema format > > > instead of freeform text. Add a checkpatch.pl check to

Re: [PATCH v4 1/2] fpga: fpga-mgr: Add readback support

2019-09-27 Thread Thor Thayer
Hi Kedar & Moritz, On 9/27/19 12:13 AM, Appana Durga Kedareswara Rao wrote: Hi Alan, Did you get a chance to send your framework changes to upstream? @Moritz Fischer: If Alan couldn't send his patch series, Can we take this patch series?? Please let me know your thoughts on this. Regards, Ked

[PATCH v8 0/3] HEVC/H.265 stateless support for V4L2 and Cedrus

2019-09-27 Thread Paul Kocialkowski
HEVC/H.265 stateless support for V4L2 and Cedrus This is early support for HEVC/H.265 stateless decoding in V4L2, including both definitions and driver support for the Cedrus VPU driver, which concerns Allwinner devices. A specific pixel format is introduced for the HEVC slice format and controls

[PATCH v8 2/3] media: pixfmt: Document the HEVC slice pixel format

2019-09-27 Thread Paul Kocialkowski
Document the current state of the HEVC slice pixel format. The format will need to evolve in the future, which is why it is not part of the public API. Signed-off-by: Paul Kocialkowski --- .../media/uapi/v4l/pixfmt-compressed.rst | 23 +++ 1 file changed, 23 insertions(+) d

[PATCH v8 3/3] media: cedrus: Add HEVC/H.265 decoding support

2019-09-27 Thread Paul Kocialkowski
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with both uni-directional and bi-directional prediction modes supported. Field-coded (interlaced) pictures, custom quantization matrices and 10-bit output are not supported at this point. Signed-off-by: Paul Kocialkowski --- drive

[PATCH v8 1/3] media: v4l: Add definitions for HEVC stateless decoding

2019-09-27 Thread Paul Kocialkowski
This introduces the required definitions for HEVC decoding support with stateless VPUs. The controls associated to the HEVC slice format provide the required meta-data for decoding slices extracted from the bitstream. They are not exported to the public V4L2 API since reworking this API will likel

Re: [PATCH 1/1] arm64/sve: Fix wrong free for task->thread.sve_state

2019-09-27 Thread Masayoshi Mizuma
Hi Julien and Dave, Thank you for your comments! Dave's suggestion looks good for me, many thanks! I'll post it as v2. - Masa On Fri, Sep 27, 2019 at 01:52:30PM +0100, Dave Martin wrote: > On Thu, Sep 26, 2019 at 03:08:46PM -0400, Masayoshi Mizuma wrote: > > From: Masayoshi Mizuma > > > > The

[PATCH] mm: fix struct member name in function comments

2019-09-27 Thread Hao Lee
The member in struct zonelist is _zonerefs instead of zones. Signed-off-by: Hao Lee --- include/linux/mmzone.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 3f38c30d2f13..6d44a49b3f29 100644 --- a/include/linux/mmzone.h

Re: [PATCH] KVM: Don't shrink/grow vCPU halt_poll_ns if host side polling is disabled

2019-09-27 Thread Sean Christopherson
On Fri, Sep 27, 2019 at 04:27:02PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Don't waste cycles to shrink/grow vCPU halt_poll_ns if host > side polling is disabled. > > Cc: Marcelo Tosatti > Signed-off-by: Wanpeng Li > --- > virt/kvm/kvm_main.c | 28 +++- > 1 fi

[PATCH V2] Remove dead url and added active url .

2019-09-27 Thread Bhaskar Chowdhury
The below links/urls leads to "server not found" error, that means , those sites are not maintained anymore. We should induct these below urls to look for the config. Dead Url for Gmail Settings : http://dev.mutt.org/trac/wiki/UseCases/Gmail (we need to remove it) Act

Re: [PATCH V9 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-27 Thread Rob Herring
On Wed, 25 Sep 2019 02:09:08 +, Peng Fan wrote: > From: Peng Fan > > The ARM SMC/HVC mailbox binding describes a firmware interface to trigger > actions in software layers running in the EL2 or EL3 exception levels. > The term "ARM" here relates to the SMC instruction as part of the ARM > inst

Re: [RFC PATCH 05/27] containers: Open a socket inside a container

2019-09-27 Thread Eric W. Biederman
Alun Evans writes: > Hi Eric, > > > On Tue, 19 Feb 2019, Eric W. Biederman wrote: >> >> David Howells writes: >> >> > Provide a system call to open a socket inside of a container, using that >> > container's network namespace. This allows netlink to be used to manage >> > the container. >> > >

Re: [PATCH v3 00/11] Introduces new count-based method for monitoring lockless pagetable walks

2019-09-27 Thread Leonardo Bras
John Hubbard writes: > Hi Leonardo, > > Thanks for adding linux-mm to CC for this next round of reviews. For the > benefit > of any new reviewers, I'd like to add that there are some issues that were > discovered > while reviewing the v2 patchset, that are not (yet) addressed in this v3 > seri

Re: [PATCH 1/2] KVM: nVMX: Always write vmcs02.GUEST_CR3 during nested VM-Enter

2019-09-27 Thread Liran Alon
> On 27 Sep 2019, at 17:27, Sean Christopherson > wrote: > > On Fri, Sep 27, 2019 at 03:06:02AM +0300, Liran Alon wrote: >> >> >>> On 27 Sep 2019, at 0:43, Sean Christopherson >>> wrote: >>> >>> Write the desired L2 CR3 into vmcs02.GUEST_CR3 during nested VM-Enter >>> isntead of deferrin

Re: genetlink: prevent memory leak in netlbl_unlabel_defconf

2019-09-27 Thread Paul Moore
On Fri, Sep 27, 2019 at 9:15 AM Markus Elfring wrote: > > > > In netlbl_unlabel_defconf if netlbl_domhsh_add_default fails the > > > allocated entry should be released. > … > > That said, netlbl_unlabel_defconf() *should* clean up here just on > > principal if nothing else. > > How do you think ab

Re: [PATCH v2 2/2] ptp: Add a ptp clock driver for IDT ClockMatrix.

2019-09-27 Thread Andrew Lunn
> >> +static void set_default_function_pointers(struct idtcm *idtcm) > >> +{ > >> + idtcm->_idtcm_gettime = _idtcm_gettime; > >> + idtcm->_idtcm_settime = _idtcm_settime; > >> + idtcm->_idtcm_rdwr = idtcm_rdwr; > >> + idtcm->_sync_pll_output = sync_pll_output; > >> +} > > > >Why does this indir

Re: [PATCH v5] tpm_crb: fix fTPM on AMD Zen+ CPUs

2019-09-27 Thread Jarkko Sakkinen
On Thu, Sep 26, 2019 at 12:56:46AM +0300, ivan.laz...@gmail.com wrote: > +struct tpm_crb_resources { > + struct resource iores[TPM_CRB_MAX_RESOURCES]; > + void __iomem *iobase[TPM_CRB_MAX_RESOURCES]; > + int num; > +}; Do not add a new struct. > + > static bool crb_wait_for_reg_32(u3

[PATCH v2 0/3] Fix irq_domain vs. irq user race

2019-09-27 Thread Sverdlin, Alexander (Nokia - DE/Ulm)
From: Alexander Sverdlin Seems that the discovered race was here since adapting the PowerPC code into genirq in 2012. I was surprized it went unnoticed all this time, but it turns out, device registration (being it DT or ACPI) is mostly sequential in kernel. In our case probe deferring was involv

[PATCH v2 3/3] genirq/irqdomain: Detect type race in irq_create_fwspec_mapping()

2019-09-27 Thread Sverdlin, Alexander (Nokia - DE/Ulm)
From: Alexander Sverdlin irq_create_fwspec_mapping() can race with itself during IRQ trigger type configuration. Possible scenarios include: - Mapping exists, two irq_create_fwspec_mapping() running in parallel do not detect type mismatch, IRQ remains configured with one of the different tri

[PATCH v2 2/3] genirq/irqdomain: Re-check mapping after associate in irq_create_mapping()

2019-09-27 Thread Sverdlin, Alexander (Nokia - DE/Ulm)
From: Alexander Sverdlin If two irq_create_mapping() calls perform a mapping of the same hwirq on two CPU cores in parallel they both will get 0 from irq_find_mapping(), both will allocate unique virq using irq_domain_alloc_descs() and both will finally irq_domain_associate() it. Giving different

[PATCH v2 1/3] genirq/irqdomain: Check for existing mapping in irq_domain_associate()

2019-09-27 Thread Sverdlin, Alexander (Nokia - DE/Ulm)
From: Alexander Sverdlin irq_domain_associate() is the only place where irq_find_mapping() can be used reliably (under irq_domain_mutex) to make a decision if the mapping shall be created or not. Other calls to irq_find_mapping() (not under any lock) cannot be used for this purpose and lead to ra

Re: [PATCH 1/2] KVM: nVMX: Always write vmcs02.GUEST_CR3 during nested VM-Enter

2019-09-27 Thread Sean Christopherson
On Fri, Sep 27, 2019 at 05:44:53PM +0300, Liran Alon wrote: > > > On 27 Sep 2019, at 17:27, Sean Christopherson > > wrote: > > > > On Fri, Sep 27, 2019 at 03:06:02AM +0300, Liran Alon wrote: > >> > >>> On 27 Sep 2019, at 0:43, Sean Christopherson > >>> wrote: > >>> > >>> + /* > >>> + * Imm

Re: [PATCH] i40e: prevent memory leak in i40e_setup_macvlans

2019-09-27 Thread Markus Elfring
> In i40e_setup_macvlans if i40e_setup_channel fails the allocated memory > for ch should be released. I suggest to improve also this change description. > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -7168,6 +7168,7 @@ static int i40e_setup_macvlans(struct i40e_vsi *vsi, > u16 macvla

Re: [PATCH 1/1] arm64/sve: Fix wrong free for task->thread.sve_state

2019-09-27 Thread Dave Martin
On Fri, Sep 27, 2019 at 10:38:02AM -0400, Masayoshi Mizuma wrote: > Hi Julien and Dave, > > Thank you for your comments! > Dave's suggestion looks good for me, many thanks! > I'll post it as v2. Please add Fixes and Cc: stable tags as appropriate. (I'm happy not to push this patch myself, but I

Re: [PATCH v4] dt-bindings: at24: convert the binding document to yaml

2019-09-27 Thread Bartosz Golaszewski
pt., 27 wrz 2019 o 15:42 Rob Herring napisał(a): > > From: Bartosz Golaszewski > > Convert the binding document for at24 EEPROMs from txt to yaml. The > compatible property uses a regex pattern to address all the possible > combinations of "vendor,model" strings. > > Signed-off-by: Bartosz Golasz

Re: [PATCH] tracing/probe: Test nr_args match in looking for same probe events

2019-09-27 Thread Steven Rostedt
On Fri, 27 Sep 2019 19:08:53 +0530 Srikar Dronamraju wrote: \> > --- > > kernel/trace/trace_kprobe.c | 2 ++ > > kernel/trace/trace_uprobe.c | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > > index 402dc3ce88d3..d2543a4

Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids

2019-09-27 Thread Cezary Rojewski
On 2019-09-27 15:14, Pierre-Louis Bossart wrote: On 9/26/19 9:55 PM, Navid Emamdoost wrote: On Wed, Sep 25, 2019 at 12:05:28PM -0500, Pierre-Louis Bossart wrote: On 9/25/19 11:19 AM, Navid Emamdoost wrote: In snd_skl_parse_uuids if allocation for module->instance_id fails, the allocated memory

Re: [PREEMPT_RT PATCH 2/3] i915: convert all irq_locks spinlocks to raw spinlocks

2019-09-27 Thread Sean V Kelley
> On Sep 27, 2019, at 7:58 AM, Clark Williams wrote: > > I'm running v5.2.17-rt9 now and have not seen any i915 related splats. I > think we're good to drop my patches > > On Fri, Sep 27, 2019 at 7:29 AM Sebastian Andrzej Siewior > wrote: > On 2019-09-16 14:21:22 [-0700], Sean V Kelley wro

Re: [PATCH] clk/ti/adpll: allocate room for terminating null

2019-09-27 Thread Tony Lindgren
* Stephen Kitt [190927 15:13]: > The buffer allocated in ti_adpll_clk_get_name doesn't account for the > terminating null. This patch adds the extra byte, and switches to > snprintf to avoid overflowing. > > Signed-off-by: Stephen Kitt > --- > drivers/clk/ti/adpll.c | 7 --- > 1 file change

[PATCH] selftests/ftrace: Fix same probe error test

2019-09-27 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The "same probe" selftest that tests that adding the same probe fails doesn't add the same probe and passes, which fails the test. Fixes: b78b94b82122 ("selftests/ftrace: Update kprobe event error testcase") Signed-off-by: Steven Rostedt (VMware) --- .../selft

Re: [PATCH] mtd: onenand: prevent memory leak in onenand_scan

2019-09-27 Thread Markus Elfring
> In onenand_scan if scan_bbt fails the allocated buffers should be released. Will an other change description be more appropriate? How do you think about to add the tag “Fixes” here? Regards, Markus

Re: [PATCH] scsi: core: Log SCSI command age with errors

2019-09-27 Thread Martin Wilck
On Mon, 2019-09-23 at 11:31 +0530, Milan P. Gandhi wrote: > Couple of users had requested to print the SCSI command age along > with command failure errors. This is a small change, but allows > users to get more important information about the command that was > failed, it would help the users

Re: [PATCH] perf llvm: don't access out-of-scope array

2019-09-27 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 26, 2019 at 03:00:18PM -0700, Ian Rogers escreveu: > test_dir is assigned to the release array which is out-of-scope 3 lines > later. Extend the scope of the release array so that an out-of-scope > array isn't accessed. > Bug detected by clang's address sanitizer. This one is really ir

Re: [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids

2019-09-27 Thread Andy Shevchenko
On Fri, Sep 27, 2019 at 05:10:18PM +0200, Cezary Rojewski wrote: > I'm fine with solution #1 as I guess asking to wait for refactor is not an > option. Code deployment is delayed due to range of administrative decisions, > some of which should be uncovered on alsa-devel soon enough. The problem w

[PATCH] clk/ti/adpll: allocate room for terminating null

2019-09-27 Thread Stephen Kitt
The buffer allocated in ti_adpll_clk_get_name doesn't account for the terminating null. This patch adds the extra byte, and switches to snprintf to avoid overflowing. Signed-off-by: Stephen Kitt --- drivers/clk/ti/adpll.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH] perf map: fix overlapped map handling

2019-09-27 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 20, 2019 at 09:46:15PM +, Steve MacLean escreveu: > >>after->start = map->end; > >> + after->pgoff = pos->map_ip(pos, map->end); > > > > So is this equivalent to what __split_vma() does in the kernel, i.e.: > > > >if (new_below) > >

Re: [PATCH] vsock/virtio: add support for MSG_PEEK

2019-09-27 Thread Matias Ezequiel Vara Larsen
On Fri, Sep 27, 2019 at 06:37:00AM -0700, Eric Dumazet wrote: > > > On 9/27/19 1:55 AM, Stefano Garzarella wrote: > > > Good catch! > > > > Maybe we can solve in this way: > > > > list_for_each_entry(pkt, &vvs->rx_queue, list) { > > size_t off = pkt->off; > > > > i

st: EIO upon almost full tape?

2019-09-27 Thread Richard Weinberger
Hi! Recently I got access to a tape library and as a side project I try to turn it into something useful. First tests showed that it seems to work fine until it tried to fill a tape: dd if=/dev/urandom of=/dev/st0 ibs=1M obs=512K After around 1.8TiB dd terminates with EIO and in dmesg I see: [53

Re: [PATCH] checkpatch: Warn if DT bindings are not in schema format

2019-09-27 Thread Rob Herring
On Fri, Sep 27, 2019 at 9:29 AM Joe Perches wrote: > > On Fri, 2019-09-27 at 09:02 -0500, Rob Herring wrote: > > On Fri, Sep 13, 2019 at 4:48 PM Joe Perches wrote: > > > On Fri, 2019-09-13 at 16:13 -0500, Rob Herring wrote: > > > > DT bindings are moving to using a json-schema based schema format

[PATCH v2] arm64/sve: Fix wrong free for task->thread.sve_state

2019-09-27 Thread Masayoshi Mizuma
From: Masayoshi Mizuma The system which has SVE feature crashed because of the memory pointed by task->thread.sve_state was destroyed by someone. That is because sve_state is freed while the forking the child process. The child process has the pointer of sve_state which is same as the parent's b

[PATCH] net: mac80211: Disable preeemption when updating stat counters

2019-09-27 Thread Aaron Hill
The mac80211 subsystem maintains per-cpu stat counters for receive and transmit operations. Previously, preemption was not disabled when updating these counters. This creates a race condition where two cpus could attempt to update the same counters using non-atomic operations. This was causing a '

Re: [PATCH] tpm: Detach page allocation from tpm_buf

2019-09-27 Thread Jarkko Sakkinen
On Thu, Sep 26, 2019 at 08:23:24PM +0300, Jarkko Sakkinen wrote: > As has been seen recently, binding the buffer allocation and tpm_buf > together is sometimes far from optimal. The buffer might come from the > caller namely when tpm_send() is used by another subsystem. In addition we > can stabili

Re: perf build failed on linux -next on i386 build

2019-09-27 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 27, 2019 at 02:05:32AM +0530, Naresh Kamboju escreveu: > On Thu, 26 Sep 2019 at 23:06, Arnaldo Carvalho de Melo > wrote: > > > > Em Thu, Sep 26, 2019 at 10:59:41PM +0530, Naresh Kamboju escreveu: > > > perf build failed on linux -next on i386 build > > > > > > build error: > > > perf-i

Re: [PATCH 7/7] nsdeps: make generated patches independent of locale

2019-09-27 Thread Masahiro Yamada
On Fri, Sep 27, 2019 at 10:27 PM Matthias Maennich wrote: > > On Fri, Sep 27, 2019 at 06:36:03PM +0900, Masahiro Yamada wrote: > >scripts/nsdeps automatically generates a patch to add MODULE_IMPORT_NS > >tags, and what is nicer, it sorts the lines alphabetically with the > >"sort" command. However

Re: [PATCH 0/7] module: various bug-fixes and clean-ups for module namespace

2019-09-27 Thread Masahiro Yamada
Hi Matthias, On Fri, Sep 27, 2019 at 10:41 PM Matthias Maennich wrote: > > On Fri, Sep 27, 2019 at 06:35:56PM +0900, Masahiro Yamada wrote: > > > >I was hit by some problems caused by the module namespace feature > >that was merged recently. At least, the breakage of > >external module builds is

Re: [PATCH v4] dt-bindings: at24: convert the binding document to yaml

2019-09-27 Thread Rob Herring
On Fri, Sep 27, 2019 at 10:06 AM Bartosz Golaszewski wrote: > > pt., 27 wrz 2019 o 15:42 Rob Herring napisał(a): > > > > From: Bartosz Golaszewski > > > > Convert the binding document for at24 EEPROMs from txt to yaml. The > > compatible property uses a regex pattern to address all the possible

[PATCH v1] xen/balloon: Set pages PageOffline() in balloon_add_region()

2019-09-27 Thread David Hildenbrand
We are missing a __SetPageOffline(), which is why we can get !PageOffline() pages onto the balloon list, where alloc_xenballooned_pages() will complain: page:ea0003e7ffc0 refcount:1 mapcount:0 mapping: index:0x0 flags: 0xe1000(reserved) raw: 000e1000 dead000

Re: [PATCH] sparc: vdso: fix build error of vdso32

2019-09-27 Thread Masahiro Yamada
On Sun, Sep 22, 2019 at 8:36 PM Masahiro Yamada wrote: > > Since commit 54b8ae66ae1a ("kbuild: change *FLAGS_.o to > take the path relative to $(obj)"), sparc allmodconfig fails to build > as follows: > > CC arch/sparc/vdso/vdso32/vclock_gettime.o > unrecognized e_machine 18 arch/sparc/vdso

Re: [PATCH 2/2] perf/pmu_events: Use s390 machine name instead of type 8561

2019-09-27 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 27, 2019 at 10:11:47AM +0200, Thomas Richter escreveu: > In the pmu-events directory for JSON file definitions use the > official machine name IBM z15 instead of machine type number > 8561. This is consistent with previous machines. Thanks, applied both patches. - Arnaldo > Signed-o

Re: [PATCH v8 2/7] nfc: pn532: Add uart phy docs and rename it

2019-09-27 Thread Rob Herring
On Thu, Sep 19, 2019 at 11:16:39AM +0200, Lars Poeschel wrote: > This adds documentation about the uart phy to the pn532 binding doc. As > the filename "pn533-i2c.txt" is not appropriate any more, rename it to > the more general "pn532.txt". > This also documents the deprecation of the compatible s

[PATCH] KVM: selftests: x86: clarify what is reported on KVM_GET_MSRS failure

2019-09-27 Thread Vitaly Kuznetsov
When KVM_GET_MSRS fail the report looks like Test Assertion Failure lib/x86_64/processor.c:1089: r == nmsrs pid=28775 tid=28775 - Argument list too long 1 0x0040a55f: vcpu_save_state at processor.c:1088 (discriminator 3) 2 0x004010e3: main at state_test.c

Re: [PATCH] KVM: VMX: Set VMENTER_L1D_FLUSH_NOT_REQUIRED if !X86_BUG_L1TF

2019-09-27 Thread Borislav Petkov
On Thu, Sep 26, 2019 at 01:29:28PM -0400, Waiman Long wrote: > On 8/26/19 3:30 PM, Waiman Long wrote: > > The l1tf_vmx_mitigation is only set to VMENTER_L1D_FLUSH_NOT_REQUIRED > > when the ARCH_CAPABILITIES MSR indicates that L1D flush is not required. > > However, if the CPU is not affected by L1T

[v2, 2/2] gpio: dts: aspeed: Add SGPIO driver

2019-09-27 Thread Hongwei Zhang
Thanks Linus, > > I sent a separate patch to fix this up the way I want it with the file named > gpio-aspeed-sgpio.c and > CONFIG_GPIO_ASPEED_SGPIO. > > I don't want to mix up the namespaces of something Aspeed-generic with the > namespace of the GPIO > subsystem. SGPIO is the name of a spec

Re: Do we need to correct barriering in circular-buffers.rst?

2019-09-27 Thread Peter Zijlstra
On Fri, Sep 27, 2019 at 02:49:29PM +0200, Peter Zijlstra wrote: > On Fri, Sep 27, 2019 at 11:51:07AM +0200, Andrea Parri wrote: > > > For the record, the LKMM doesn't currently model "order" derived from > > control dependencies to a _plain_ access (even if the plain access is > > a write): in par

Re: [PATCH] KVM: VMX: Set VMENTER_L1D_FLUSH_NOT_REQUIRED if !X86_BUG_L1TF

2019-09-27 Thread Paolo Bonzini
On 26/08/19 21:30, Waiman Long wrote: > The l1tf_vmx_mitigation is only set to VMENTER_L1D_FLUSH_NOT_REQUIRED > when the ARCH_CAPABILITIES MSR indicates that L1D flush is not required. > However, if the CPU is not affected by L1TF, l1tf_vmx_mitigation will > still be set to VMENTER_L1D_FLUSH_AUTO.

Re: [PATCH] KVM: selftests: x86: clarify what is reported on KVM_GET_MSRS failure

2019-09-27 Thread Jim Mattson
On Fri, Sep 27, 2019 at 8:54 AM Vitaly Kuznetsov wrote: > > When KVM_GET_MSRS fail the report looks like > > Test Assertion Failure > lib/x86_64/processor.c:1089: r == nmsrs > pid=28775 tid=28775 - Argument list too long > 1 0x0040a55f: vcpu_save_state at processor.c:10

Re: [PATCH] KVM: VMX: Set VMENTER_L1D_FLUSH_NOT_REQUIRED if !X86_BUG_L1TF

2019-09-27 Thread Paolo Bonzini
On 27/09/19 17:55, Borislav Petkov wrote: > I'd move that logic with the if (boot_cpu_has(X86_BUG_L1TF)) check inside > vmx_setup_l1d_flush() so that I have this: > > if (!boot_cpu_has_bug(X86_BUG_L1TF)) { > l1tf_vmx_mitigation = VMENTER_L1D_FLUSH_NOT_REQUIRED; >

[PATCH v2] KVM: VMX: Set VMENTER_L1D_FLUSH_NOT_REQUIRED if !X86_BUG_L1TF

2019-09-27 Thread Paolo Bonzini
From: Waiman Long The l1tf_vmx_mitigation is only set to VMENTER_L1D_FLUSH_NOT_REQUIRED when the ARCH_CAPABILITIES MSR indicates that L1D flush is not required. However, if the CPU is not affected by L1TF, l1tf_vmx_mitigation will still be set to VMENTER_L1D_FLUSH_AUTO. This is certainly not the

Re: [PATCH] usbip: clean up an indentation issue

2019-09-27 Thread shuah
On 9/27/19 3:20 AM, Colin King wrote: From: Colin Ian King There is a return statement that is indented incorrectly, fix this. Please include the warn you are fixing in the commit log Signed-off-by: Colin Ian King --- drivers/usb/usbip/stub_tx.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: Linux 5.3-rc8

2019-09-27 Thread Linus Torvalds
On Fri, Sep 27, 2019 at 6:57 AM Lennart Poettering wrote: > > Doing the random seed in the boot loader is nice for two reasons: > > 1. It runs very very early, so that the OS can come up with fully >initialized entropy right from the beginning. Oh, that part I love. But I don't believe in yo

Re: [PATCH] KVM: selftests: x86: clarify what is reported on KVM_GET_MSRS failure

2019-09-27 Thread Paolo Bonzini
On 27/09/19 17:54, Vitaly Kuznetsov wrote: > When KVM_GET_MSRS fail the report looks like > > Test Assertion Failure > lib/x86_64/processor.c:1089: r == nmsrs > pid=28775 tid=28775 - Argument list too long > 10x0040a55f: vcpu_save_state at processor.c:1088 > (di

Re: [PATCH] tools: libbpf: Add bpf_object__open_buffer_xattr

2019-09-27 Thread Andrii Nakryiko
On Fri, Sep 27, 2019 at 6:11 AM KP Singh wrote: > > From: KP Singh > > Introduce struct bpf_object_open_buffer_attr and an API function, > bpf_object__open_xattr, as the existing API, bpf_object__open_buffer, > doesn't provide a way to specify neither the "needs_kver" nor > the "flags" parameter

Re: [GIT PULL] integrity subsystem updates for v5.4

2019-09-27 Thread Mimi Zohar
On Mon, 2019-09-16 at 18:13 -0400, Mimi Zohar wrote: > On Mon, 2019-09-16 at 13:38 -0700, Linus Torvalds wrote: > > On Wed, Sep 11, 2019 at 2:29 PM Mimi Zohar wrote: > > > > > > The major feature in this pull request is IMA support for measuring > > > and appraising appended file signatures. In a

Re: [PATCH 1/2] Modify cpupower to schedule itself on cores it is reading MSRs from

2019-09-27 Thread Natarajan, Janakarajan
On 9/18/2019 11:34 AM, Natarajan, Janakarajan wrote: > Modify cpupower to schedule itself on each of the cpus in the system and > then get the APERF/MPERF register values. > > This is advantageous because an IPI is not generated when a read_msr() is > executed on the local logical CPU thereby reduc

Re: [PATCH v22 05/24] x86/sgx: Add ENCLS architectural error codes

2019-09-27 Thread Jarkko Sakkinen
On Fri, Sep 27, 2019 at 12:20:13PM +0200, Borislav Petkov wrote: > On Tue, Sep 03, 2019 at 05:26:36PM +0300, Jarkko Sakkinen wrote: > > Document ENCLS architectural error codes. These error codes are returned by > > the SGX opcodes. Make the header as part of the uapi so that they can be > > used i

Re: [PATCH] staging: rtl8192u: fix multiple memory leaks on error path

2019-09-27 Thread Markus Elfring
> In rtl8192_tx on error handling path allocated urbs and also skb should > be released. Can this change description be improved? How do you think about to add the tag “Fixes” here? > @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct > sk_buff *skb) > RT_TRACE(COMP_

Re: [PATCH v2] KVM: VMX: Set VMENTER_L1D_FLUSH_NOT_REQUIRED if !X86_BUG_L1TF

2019-09-27 Thread Waiman Long
On 9/27/19 12:05 PM, Paolo Bonzini wrote: > From: Waiman Long > > The l1tf_vmx_mitigation is only set to VMENTER_L1D_FLUSH_NOT_REQUIRED > when the ARCH_CAPABILITIES MSR indicates that L1D flush is not required. > However, if the CPU is not affected by L1TF, l1tf_vmx_mitigation will > still be set

Re: [PATCH v6 2/2] dt/bindings: Add bindings for Layerscape external irqs

2019-09-27 Thread Rob Herring
On Mon, Sep 23, 2019 at 12:15:13PM +0200, Kurt Kanzenbach wrote: > From: Rasmus Villemoes > > This adds Device Tree binding documentation for the external interrupt > lines with configurable polarity present on some Layerscape SOCs. > > Signed-off-by: Rasmus Villemoes > Signed-off-by: Kurt Kanz

Re: [PATCH v22 02/24] x86/cpufeatures: x86/msr: Intel SGX Launch Control hardware bits

2019-09-27 Thread Jarkko Sakkinen
On Wed, Sep 25, 2019 at 10:18:24AM -0700, Sean Christopherson wrote: > > I wouldn't be too surprised if this happened. BIOS is very inventive. > > Given the number of steps BIOS needs to take to enable SGX, that'd be one > "inventive" BIOS. :-) > > Anyways, adding logic to opportunistically set F

[PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists()

2019-09-27 Thread Kaitao Cheng
There is no need to make the 'node_order' variable static since new value always be assigned before use it. Signed-off-by: Kaitao Cheng Signed-off-by: Muchun Song --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3334

Re: [v5,1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties

2019-09-27 Thread Rob Herring
On Thu, 19 Sep 2019 09:45:19 +0800, Biwen Li wrote: > Add some properties for pcf85263/pcf85363 as follows: > - nxp,rtc-interrupt-type: integer type > - nxp,rtc-interrupt-output-pin: string type > - quartz-load-femtofarads: integer type > - quartz-drive-strength-ohms: integer type > - nxp

Re: genetlink: prevent memory leak in netlbl_unlabel_defconf

2019-09-27 Thread David Miller
From: Paul Moore Date: Fri, 27 Sep 2019 10:48:54 -0400 > From what I've seen the "Fixes" tag is typically used by people who > are backporting patches, e.g. the -stable folks, to help decide what > they need to backport. Fixes: tags say what commit introduced the code being fixed, whether it man

Re: [PATCH v2] arm64/sve: Fix wrong free for task->thread.sve_state

2019-09-27 Thread Dave Martin
On Fri, Sep 27, 2019 at 11:39:49AM -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > The system which has SVE feature crashed because of > the memory pointed by task->thread.sve_state was destroyed > by someone. > > That is because sve_state is freed while the forking the > child proce

[PATCH] keys: Add Jarkko Sakkinen as co-maintainer

2019-09-27 Thread David Howells
From: Jarkko Sakkinen To address a major procedural concern on Linus's part the keyrings needs a co-maintainer. Cc: Linus Torvalds Suggested-by: David Howells Signed-off-by: Jarkko Sakkinen Signed-off-by: David Howells --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [PATCH v5] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

2019-09-27 Thread Rob Herring
On Wed, 25 Sep 2019 15:26:28 +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > Convert Samsung I2S controller to newer dt-schema format. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Marek Szyprowski > --- > v5: > - Removed '#clock-cells' property from required properties > -

Re: [PATCH v4] dt-bindings: iommu: Convert Samsung Exynos IOMMU H/W, System MMU to dt-schema

2019-09-27 Thread Rob Herring
On Thu, 19 Sep 2019 15:19:44 +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > Convert Samsung Exynos IOMMU H/W, System Memory Management Unit > to newer dt-schema format. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Andrzej Hajda > Signed-off-by: Marek Szyprowski > --- > v4

[PATCH v3] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-09-27 Thread Douglas Anderson
As per the centithread on ksummit-discuss [1], there are folks who feel that if a Change-Id is present in a developer's local commit that said Change-Id could be interesting to include in upstream posts. Specifically if two commits are posted with the same Change-Id there's a reasonable chance that

[PATCH] tools/power/cpupower: Fix initializer override in hsw_ext_cstates

2019-09-27 Thread Nathan Chancellor
When building cpupower with clang, the following warning appears: utils/idle_monitor/hsw_ext_idle.c:42:16: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] .desc = N_("Processor Package C2"),

Re: [PATCH v22 06/24] x86/sgx: Add SGX microarchitectural data structures

2019-09-27 Thread Borislav Petkov
On Tue, Sep 03, 2019 at 05:26:37PM +0300, Jarkko Sakkinen wrote: > Define the SGX microarchitectural data structures used by various SGX > opcodes. This is not an exhaustive representation of all SGX data > structures but only those needed by the kernel. > > [1] Intel SDM: 37.6 INTEL® SGX DATA STR

Re: [PATCH v4 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema

2019-09-27 Thread Rob Herring
On Fri, 20 Sep 2019 14:52:22 -0700, Amit Kucheria wrote: > Older IP only supports the 'uplow' interrupt, but newer IP supports > 'uplow' and 'critical' interrupts. Document interrupt support in the > tsens driver by converting over to a YAML schema. > > Suggested-by: Stephen Boyd > Signed-off-by:

<    1   2   3   4   5   6   7   >