Re: [PATCH v3 1/5] dt-bindings: Add Xylon vendor prefix

2019-09-27 Thread Rob Herring
On Fri, 27 Sep 2019 12:04:03 +0200, Paul Kocialkowski wrote: > Xylon is an electronics company that produces FPGA hardware block designs > optimized for Xilinx FPGAs. > > Signed-off-by: Paul Kocialkowski > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 i

[PATCH] iwlwifi: fix memory leaks in iwl_pcie_ctxt_info_gen3_init

2019-09-27 Thread Navid Emamdoost
In iwl_pcie_ctxt_info_gen3_init there are cases that the allocated dma memory is leaked in case of error. DMA memories prph_scratch, prph_info, and ctxt_info_gen3 are allocated and initialized to be later assigned to trans_pcie. But in any error case before such assignment the allocated memories sh

Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER

2019-09-27 Thread Andy Lutomirski
On Tue, Sep 3, 2019 at 3:27 PM Palmer Dabbelt wrote: > > On Wed, 28 Aug 2019 10:52:05 PDT (-0700), l...@amacapital.net wrote: > > > > > >> On Aug 25, 2019, at 2:59 PM, Kees Cook wrote: > >> > >>> On Thu, Aug 22, 2019 at 01:55:22PM -0700, David Abdurachmanov wrote: > >>> This patch was extensively

[PATCH v2 2/4] irqchip: Add Aspeed SCU interrupt controller

2019-09-27 Thread Eddie James
The Aspeed SOCs provide some interrupts through the System Control Unit registers. Add an interrupt controller that provides these interrupts to the system. Signed-off-by: Eddie James --- Changes since v1: - add a spinlock to protect read-modify-write operation for irq masking - use readl/write

[PATCH v2 4/4] ARM: dts: aspeed: ast2600: Add SCU interrupt controllers

2019-09-27 Thread Eddie James
Add nodes for the interrupt controllers provided by the SCU. Signed-off-by: Eddie James --- arch/arm/boot/dts/aspeed-g6.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi index 3a1422f..d89f1e6 100644 -

[PATCH v2 0/4] irqchip: Add Aspeed SCU Interrupt Controller

2019-09-27 Thread Eddie James
The Aspeed SOCs provide some interrupts through the System Control Unit registers. Add an interrupt controller that provides these interrupts to the system. Add the interrupt controller to the AST25XX and AST26XX devicetrees. Changes since v1: - add a spinlock to protect read-modify-write operati

[PATCH v2 3/4] ARM: dts: aspeed: ast2500: Add SCU interrupt controller

2019-09-27 Thread Eddie James
Add a node for the interrupt controller provided by the SCU. Signed-off-by: Eddie James --- arch/arm/boot/dts/aspeed-g5.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index e8feb8b..450c2d2

[PATCH v2 1/4] dt-bindings: interrupt-controller: Add Aspeed SCU interrupt controller

2019-09-27 Thread Eddie James
Document the Aspeed SCU interrupt controller and add an include file for the interrupts it provides. Signed-off-by: Eddie James --- .../interrupt-controller/aspeed,ast2xxx-scu-ic.txt | 26 ++ MAINTAINERS| 7 ++ .../interrupt-contro

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-27 Thread Andrew Morton
On Fri, 27 Sep 2019 15:47:03 -0400 Qian Cai wrote: > On architectures like s390, arch_free_page() could mark the page unused > (set_page_unused()) and any access later would trigger a kernel panic. > Fix it by moving arch_free_page() after all possible accessing calls. > > Hardware name: IBM 29

Re: [PATCH v1] powerpc/pseries: CMM: Drop page array

2019-09-27 Thread Michael Ellerman
On 27 September 2019 9:19:49 pm AEST, David Hildenbrand wrote: >On 25.09.19 09:37, David Hildenbrand wrote: >> On 10.09.19 18:39, David Hildenbrand wrote: >>> We can simply store the pages in a list (page->lru), no need for a >>> separate data structure (+ complicated handling). This is how mo

Re: [Patch v4 6/8] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-27 Thread Lad, Prabhakar
Hi Benoit, thank you for the patch. On Fri, Sep 27, 2019 at 7:49 PM Benoit Parrot wrote: > > On some board it is possible that the sensor 'powerdown' and or 'reset' > pin might be controlled by gpio instead of being tied. > > To implement we add pm_runtime support which will handle the power > u

Re: [Patch v4 8/8] media: i2c: ov2659: Switch to SPDX Licensing

2019-09-27 Thread Lad, Prabhakar
On Fri, Sep 27, 2019 at 7:46 PM Benoit Parrot wrote: > > Switch to SPDX licensing and drop the redundant GPL text. > > Signed-off-by: Benoit Parrot > --- > drivers/media/i2c/ov2659.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > Acked-by: Lad, Prabhakar Cheers, --Pra

[PATCH] perf tools: avoid sample_reg_masks being const + weak

2019-09-27 Thread Ian Rogers
Being const + weak breaks with some compilers that constant-propagate from the weak symbol. This behavior is outside of the specification, but in LLVM is chosen to match GCC's behavior. LLVM's implementation was set in this patch: https://github.com/llvm/llvm-project/commit/f49573d1eedcf1e44893d5a

Re: [PATCH net 8/8] net: stmmac: xgmac: Fix RSS not writing all Keys to HW

2019-09-27 Thread Nick Desaulniers
On Fri, Sep 27, 2019 at 12:49 AM Jose Abreu wrote: > > The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it. I think the warning was from -Wsizeof-array-div. > > Reported-by: kbuild test robot > Reported-by: Nick Desaulniers I may have reported the kbuild link, but scanning my email, there

Re: [PATCH] tools: bpf: Use !building_out_of_srctree to determine srctree

2019-09-27 Thread Song Liu
> On Sep 27, 2019, at 12:03 PM, Shuah Khan wrote: > > On 9/27/19 12:44 PM, Song Liu wrote: >> On Thu, Sep 26, 2019 at 6:14 PM Shuah Khan wrote: >>> >>> make TARGETS=bpf kselftest fails with: >>> >>> Makefile:127: tools/build/Makefile.include: No such file or directory >>> >>> When the bpf

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-27 Thread Qian Cai
On Fri, 2019-09-27 at 13:48 -0700, Andrew Morton wrote: > On Fri, 27 Sep 2019 15:47:03 -0400 Qian Cai wrote: > > > On architectures like s390, arch_free_page() could mark the page unused > > (set_page_unused()) and any access later would trigger a kernel panic. > > Fix it by moving arch_free_page

Re: [PATCH v6 2/2] dt/bindings: Add bindings for Layerscape external irqs

2019-09-27 Thread Rasmus Villemoes
On 27/09/2019 18.11, Rob Herring wrote: > On Mon, Sep 23, 2019 at 12:15:13PM +0200, Kurt Kanzenbach wrote: >> From: Rasmus Villemoes >> >> This adds Device Tree binding documentation for the external interrupt >> lines with configurable polarity present on some Layerscape SOCs. >> >> Signed-off-by

Re: [PATCH] nvme: fix an error code in nvme_init_subsystem()

2019-09-27 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[PATCH v3] platform/x86: dell-laptop: disable kbd backlight on Inspiron 10xx

2019-09-27 Thread Pacien TRAN-GIRARD
This patch adds a quirk disabling keyboard backlight support for the Dell Inspiron 1012 and 1018. Those models wrongly report supporting keyboard backlight control features (through SMBIOS tokens) even though they're not equipped with a backlit keyboard. This led to broken controls being exposed t

Re: [PATCH v8 17/17] Documentation/x86/64: Add documentation for GS/FS addressing mode

2019-09-27 Thread Randy Dunlap
Hi, Some doc comments/fixes below... On 9/12/19 1:06 PM, Chang S. Bae wrote: > From: Thomas Gleixner > > Explain how the GS/FS based addressing can be utilized in user space > applications along with the differences between the generic prctl() based > GS/FS base control and the FSGSBASE version

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-27 Thread Qian Cai
On Fri, 2019-09-27 at 14:02 -0700, Andrew Morton wrote: > On Fri, 27 Sep 2019 15:47:03 -0400 Qian Cai wrote: > > > On architectures like s390, arch_free_page() could mark the page unused > > (set_page_unused()) and any access later would trigger a kernel panic. > > Fix it by moving arch_free_page

Re: [PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format

2019-09-27 Thread Daniel Xu
Hi Jiri, On Tue Sep 24, 2019 at 10:33 AM Jiri Olsa wrote: > On Tue, Sep 17, 2019 at 06:30:52AM -0700, Daniel Xu wrote: > > SNIP > > > + PERF_FORMAT_MAX = 1U << 5, /* non-ABI */ > > }; > > > > #define PERF_ATTR_SIZE_VER064 /* sizeof first published > > struct */ >

Re: [PATCH v3] nfp: abm: fix memory leak in nfp_abm_u32_knode_replace

2019-09-27 Thread Jakub Kicinski
On Fri, 27 Sep 2019 14:12:42 +0200, Markus Elfring wrote: > > Updated other gotos to have correct errno returned, too. > > How do you think about to add a jump target here? > > > > +++ b/drivers/net/ethernet/netronome/nfp/abm/cls.c > > @@ -176,8 +176,10 @@ nfp_abm_u32_knode_replace(struct nfp_

[PATCH v2] perf tools: avoid sample_reg_masks being const + weak

2019-09-27 Thread Ian Rogers
Being const + weak breaks with some compilers that constant-propagate from the weak symbol. This behavior is outside of the specification, but in LLVM is chosen to match GCC's behavior. LLVM's implementation was set in this patch: https://github.com/llvm/llvm-project/commit/f49573d1eedcf1e44893d5a

Re: [PATCH v6 4/5] pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage

2019-09-27 Thread Sean Wang
Hi, On Thu, Sep 26, 2019 at 10:02 PM Light Hsieh wrote: > > Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to > previous Mediatek's bias-pull usage. MediaTek > In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins > with 2 pull resistors can be specifie

[PATCH] staging: rtl8188eu: fix null dereference when kzalloc fails

2019-09-27 Thread Connor Kuehl
If kzalloc() returns NULL, the error path doesn't stop the flow of control from entering rtw_hal_read_chip_version() which dereferences the null pointer. Fix this by adding a 'goto' to the error path to more gracefully handle the issue and avoid proceeding with initialization steps that we're no lo

Re: [PATCH v5 4/7] hugetlb: disable region_add file_region coalescing

2019-09-27 Thread Mike Kravetz
On 9/19/19 3:24 PM, Mina Almasry wrote: > A follow up patch in this series adds hugetlb cgroup uncharge info the > file_region entries in resv->regions. The cgroup uncharge info may > differ for different regions, so they can no longer be coalesced at > region_add time. So, disable region coalescin

Re: [PATCH v2] nvme-pci: Save PCI state before putting drive into deepest state

2019-09-27 Thread Christoph Hellwig
Looks sensible to me: Reviewed-by: Christoph Hellwig

[PATCH v2 5/8] KVM: x86: Add WARNs to detect out-of-bounds register indices

2019-09-27 Thread Sean Christopherson
Add WARN_ON_ONCE() checks in kvm_register_{read,write}() to detect reg values that would cause KVM to overflow vcpu->arch.regs. Change the reg param to an 'int' to make it clear that the reg index is unverified. Open code the RIP and RSP accessors so as to avoid pointless overhead of WARN_ON_ONCE

[PATCH v2 7/8] KVM: x86: Add helpers to test/mark reg availability and dirtiness

2019-09-27 Thread Sean Christopherson
Add helpers to prettify code that tests and/or marks whether or not a register is available and/or dirty. Suggested-by: Vitaly Kuznetsov Signed-off-by: Sean Christopherson --- arch/x86/kvm/kvm_cache_regs.h | 45 +-- arch/x86/kvm/vmx/nested.c | 4 ++-- arch/x

[PATCH v2 6/8] KVM: x86: Fold 'enum kvm_ex_reg' definitions into 'enum kvm_reg'

2019-09-27 Thread Sean Christopherson
Now that indexing into arch.regs is either protected by WARN_ON_ONCE or done with hardcoded enums, combine all definitions for registers that are tracked by regs_avail and regs_dirty into 'enum kvm_reg'. Having a single enum type will simplify additional cleanup related to regs_avail and regs_dirt

[PATCH v2 1/8] KVM: nVMX: Always write vmcs02.GUEST_CR3 during nested VM-Enter

2019-09-27 Thread Sean Christopherson
Write the desired L2 CR3 into vmcs02.GUEST_CR3 during nested VM-Enter instead of deferring the VMWRITE until vmx_set_cr3(). If the VMWRITE is deferred, then KVM can consume a stale vmcs02.GUEST_CR3 when it refreshes vmcs12->guest_cr3 during nested_vmx_vmexit() if the emulated VM-Exit occurs withou

[PATCH v2 8/8] KVM: x86: Fold decache_cr3() into cache_reg()

2019-09-27 Thread Sean Christopherson
Handle caching CR3 (from VMX's VMCS) into struct kvm_vcpu via the common cache_reg() callback and drop the dedicated decache_cr3(). The name decache_cr3() is somewhat confusing as the caching behavior of CR3 follows that of GPRs, RFLAGS and PDPTRs, (handled via cache_reg()), and has nothing in com

[PATCH v2 4/8] KVM: VMX: Optimize vmx_set_rflags() for unrestricted guest

2019-09-27 Thread Sean Christopherson
Rework vmx_set_rflags() to avoid the extra code need to handle emulation of real mode and invalid state when unrestricted guest is disabled. The primary reason for doing so is to avoid the call to vmx_get_rflags(), which will incur a VMREAD when RFLAGS is not already available. When running neste

[PATCH v2 3/8] KVM: VMX: Consolidate to_vmx() usage in RFLAGS accessors

2019-09-27 Thread Sean Christopherson
Capture struct vcpu_vmx in a local variable to improve the readability of vmx_{g,s}et_rflags(). No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/arch/x86/kvm/vmx

[PATCH v2 2/8] KVM: VMX: Skip GUEST_CR3 VMREAD+VMWRITE if the VMCS is up-to-date

2019-09-27 Thread Sean Christopherson
Skip the VMWRITE to update GUEST_CR3 if CR3 is not available, i.e. has not been read from the VMCS since the last VM-Enter. If vcpu->arch.cr3 is stale, kvm_read_cr3(vcpu) will refresh vcpu->arch.cr3 from the VMCS, meaning KVM will do a VMREAD and then VMWRITE the value it just pulled from the VMCS

[PATCH v2 0/8] KVM: x86: nVMX GUEST_CR3 bug fix, and then some...

2019-09-27 Thread Sean Christopherson
*sigh* v2 was shaping up to be a trivial update, until I started working on Vitaly's suggestion to add a helper to test for register availability. The primary purpose of this series is to fix a CR3 corruption in L2 reported by Reto Buerki when running with HLT interception disabled in L1. On a ne

Re: [PATCH 1/2] Modify cpupower to schedule itself on cores it is reading MSRs from

2019-09-27 Thread Thomas Renninger
On Friday, September 27, 2019 6:07:56 PM CEST Natarajan, Janakarajan wrote: > On 9/18/2019 11:34 AM, Natarajan, Janakarajan wrote: > > This is advantageous because an IPI is not generated when a read_msr() is > > executed on the local logical CPU thereby reducing the chance of having > > APERF a

Re: [PATCH v8 17/17] Documentation/x86/64: Add documentation for GS/FS addressing mode

2019-09-27 Thread Bae, Chang Seok
> On Sep 27, 2019, at 14:25, Randy Dunlap wrote: > > Hi, > Some doc comments/fixes below... > > On 9/12/19 1:06 PM, Chang S. Bae wrote: >> From: Thomas Gleixner >> [snip] >> +There exist two mechanisms to read and write the FS/FS base address: > >

Re: Do we need to correct barriering in circular-buffers.rst?

2019-09-27 Thread Nick Desaulniers
On Fri, Sep 27, 2019 at 1:43 PM Nick Desaulniers wrote: > > On Fri, Sep 27, 2019 at 5:49 AM Peter Zijlstra wrote: > > Barring LTO the above works for perf because of inter-translation-unit > > function calls, which imply a compiler barrier. > > > > Now, when the compiler inlines, it looses that s

Re: [PATCH v3] platform/x86: dell-laptop: disable kbd backlight on Inspiron 10xx

2019-09-27 Thread Pali Rohár
On Friday 27 September 2019 23:19:03 Pacien TRAN-GIRARD wrote: > This patch adds a quirk disabling keyboard backlight support for the > Dell Inspiron 1012 and 1018. > > Those models wrongly report supporting keyboard backlight control > features (through SMBIOS tokens) even though they're not equi

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-27 Thread Andrew Morton
On Fri, 27 Sep 2019 17:28:06 -0400 Qian Cai wrote: > > > > So I think you've moved the arch_free_page() to be after the final > > thing which can access page contents, yes? If so, we should have a > > comment in free_pages_prepare() to attmept to prevent this problem from > > reoccurring as the

Re: [PATCH v5 0/7] hugetlb_cgroup: Add hugetlb_cgroup reservation limits

2019-09-27 Thread Mike Kravetz
On 9/26/19 5:55 PM, Mina Almasry wrote: > Provided we keep the existing controller untouched, should the new > controller track: > > 1. only reservations, or > 2. both reservations and allocations for which no reservations exist > (such as the MAP_NORESERVE case)? > > I like the 'both' approach.

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-09-27 Thread Nick Desaulniers
On Fri, Sep 27, 2019 at 3:43 AM Nicolas Saenz Julienne wrote: > > On Fri, 2019-08-30 at 12:43 +0900, Masahiro Yamada wrote: > > Commit 9012d011660e ("compiler: allow all arches to enable > > CONFIG_OPTIMIZE_INLINING") allowed all architectures to enable > > this option. A couple of build errors we

Re: [PATCH v6 5/5] pinctrl: mediatek: Add support for pin configuration dump via debugfs.

2019-09-27 Thread Sean Wang
Hi, On Thu, Sep 26, 2019 at 10:02 PM Light Hsieh wrote: > > Add support for pin configuration dump via catting > /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins. > pinctrl framework had already support such dump. This patch implement the > operation function pointer to fullfill th

Re: [PATCH v3 4/5] dt-bindings: gpio: Document the Xylon LogiCVC GPIO controller

2019-09-27 Thread Rob Herring
On Fri, 27 Sep 2019 12:04:06 +0200, Paul Kocialkowski wrote: > The Xylon LogiCVC display controller exports some GPIOs, which are > exposed as a separate entity. > > Signed-off-by: Paul Kocialkowski > --- > .../bindings/gpio/xylon,logicvc-gpio.yaml | 69 +++ > 1 file changed,

Re: [PATCH v3 2/5] dt-bindings: mfd: Document the Xylon LogiCVC multi-function device

2019-09-27 Thread Rob Herring
On Fri, Sep 27, 2019 at 12:04:04PM +0200, Paul Kocialkowski wrote: > The LogiCVC is a display engine which also exposes GPIO functionality. > For this reason, it is described as a multi-function device that is expected > to provide register access to its children nodes for gpio and display. > > Si

Re: [PATCH] mm/page_alloc: fix a crash in free_pages_prepare()

2019-09-27 Thread Alexander Duyck
On Fri, Sep 27, 2019 at 2:59 PM Andrew Morton wrote: > > On Fri, 27 Sep 2019 17:28:06 -0400 Qian Cai wrote: > > > > > > > So I think you've moved the arch_free_page() to be after the final > > > thing which can access page contents, yes? If so, we should have a > > > comment in free_pages_prepar

Re: [PATCH v2 0/3] Add support for SBI v0.2

2019-09-27 Thread Christoph Hellwig
On Thu, Sep 26, 2019 at 05:09:12PM -0700, Atish Patra wrote: > The Supervisor Binary Interface(SBI) specification[1] now defines a > base extension that provides extendability to add future extensions > while maintaining backward compatibility with previous versions. > The new version is defined as

Re: [PATCH v2 1/3] RISC-V: Mark existing SBI as 0.1 SBI.

2019-09-27 Thread Christoph Hellwig
On Thu, Sep 26, 2019 at 05:09:13PM -0700, Atish Patra wrote: > -#define SBI_CALL(which, arg0, arg1, arg2, arg3) ({ \ > +#define SBI_CALL(which, arg0, arg1, arg2, arg3) ({ \ Spurious whitespace change.

Re: [PATCH v2 3/3] RISC-V: Move SBI related macros under uapi.

2019-09-27 Thread Christoph Hellwig
On Thu, Sep 26, 2019 at 05:09:15PM -0700, Atish Patra wrote: > All SBI related macros can be reused by KVM RISC-V and userspace tools > such as kvmtool, qemu-kvm. SBI calls can also be emulated by userspace > if required. Any future vendor extensions can leverage this to emulate > the specific exte

Re: [GIT PULL] RISC-V additional updates for v5.4-rc1

2019-09-27 Thread Christoph Hellwig
On Fri, Sep 27, 2019 at 11:25:13AM -0700, Paul Walmsley wrote: > Atish Patra (1): > RISC-V: Export kernel symbols for kvm None of these have any current users, they should go in with the kvm series once the virtualization spec has been finalized.

Re: [PATCH] RISC-V: Clear load reservations while restoring hart contexts

2019-09-27 Thread Christoph Hellwig
On Tue, Sep 24, 2019 at 05:15:56PM -0700, Palmer Dabbelt wrote: > This is almost entirely a comment. The bug is unlikely to manifest on > existing hardware because there is a timeout on load reservations, but > manifests on QEMU because there is no timeout. Given how many different lines of RISC-

Re: [PATCH 1/4] riscv: avoid kernel hangs when trapped in BUG()

2019-09-27 Thread Christoph Hellwig
On Mon, Sep 23, 2019 at 08:45:14AM +0800, Vincent Chen wrote: > When the CONFIG_GENERIC_BUG is disabled by disabling CONFIG_BUG, if a > kernel thread is trapped by BUG(), the whole system will be in the > loop that infinitely handles the ebreak exception instead of entering the > die function. To f

Re: [alsa-devel] [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids

2019-09-27 Thread Pierre-Louis Bossart
On 9/27/19 3:39 PM, Andy Shevchenko wrote: On Fri, Sep 27, 2019 at 7:39 PM Pierre-Louis Bossart wrote: The problem with solution #1 is freeing orphaned pointer. It will work, but it's simple is not okay from object life time prospective. ?? I don't get your point at all Andy. Two allocations

Re: [PATCH 2/4] rsicv: avoid sending a SIGTRAP to a user thread trapped in WARN()

2019-09-27 Thread Christoph Hellwig
On Mon, Sep 23, 2019 at 08:45:15AM +0800, Vincent Chen wrote: > On RISC-V, when the kernel runs code on behalf of a user thread, and the > kernel executes a WARN() or WARN_ON(), the user thread will be sent > a bogus SIGTRAP. Fix the RISC-V kernel code to not send a SIGTRAP when > a WARN()/WARN_ON

Re: [PATCH v5 4/7] hugetlb: disable region_add file_region coalescing

2019-09-27 Thread Mina Almasry
On Fri, Sep 27, 2019 at 2:44 PM Mike Kravetz wrote: > > On 9/19/19 3:24 PM, Mina Almasry wrote: > > A follow up patch in this series adds hugetlb cgroup uncharge info the > > file_region entries in resv->regions. The cgroup uncharge info may > > differ for different regions, so they can no longer

[PATCH] net/mlx5: fix memory leak in mlx5_fw_fatal_reporter_dump

2019-09-27 Thread Navid Emamdoost
In mlx5_fw_fatal_reporter_dump if mlx5_crdump_collect fails the allocated memory for cr_data must be released otherwise there will be memory leak. To fix this, this commit changes the return instruction into goto error handling. Fixes: 9b1f29823605 ("net/mlx5: Add support for FW fatal reporter dum

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-09-27 Thread Linus Torvalds
On Fri, Sep 27, 2019 at 3:08 PM Nick Desaulniers wrote: > > So get_user() was passed a bad value/pointer from userspace? Do you > know which of the tree calls to get_user() from sock_setsockopt() is > failing? (It's not immediately clear to me how this patch is at > fault, vs there just being a b

Re: [PATCH 3/4] riscv: Correct the handling of unexpected ebreak in do_trap_break()

2019-09-27 Thread Christoph Hellwig
Looks ok: Reviewed-by: Christoph Hellwig

Re: [GIT PULL] nfsd changes for 5.4

2019-09-27 Thread Linus Torvalds
On Fri, Sep 27, 2019 at 1:08 PM J. Bruce Fields wrote: > > Please pull nfsd changes from: > > git://linux-nfs.org/~bfields/linux.git tags/nfsd-5.4 Hmm. I styarted to pull, but then realized that the description doesn't match the content at all. You say: > Highlights: > > - add a new k

Re: [PATCH 4/4] riscv: remove the switch statement in do_trap_break()

2019-09-27 Thread Christoph Hellwig
On Mon, Sep 23, 2019 at 08:45:17AM +0800, Vincent Chen wrote: > To make the code more straightforward, replacing the switch statement > with if statement. > > Suggested-by: Paul Walmsley > Signed-off-by: Vincent Chen > --- > arch/riscv/kernel/traps.c | 23 --- > 1 file chang

Re: [PATCH v5 0/7] hugetlb_cgroup: Add hugetlb_cgroup reservation limits

2019-09-27 Thread Mina Almasry
On Fri, Sep 27, 2019 at 2:59 PM Mike Kravetz wrote: > > On 9/26/19 5:55 PM, Mina Almasry wrote: > > Provided we keep the existing controller untouched, should the new > > controller track: > > > > 1. only reservations, or > > 2. both reservations and allocations for which no reservations exist > >

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-27 Thread Christoph Hellwig
On Thu, Aug 22, 2019 at 06:26:35AM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 19 Aug 2019 08:26:19 +0200 > Christoph Hellwig escreveu: > > > On Mon, Aug 19, 2019 at 08:09:04AM +0200, Borislav Petkov wrote: > > > On Sun, Aug 18, 2019 at 10:29:35AM +0200, Christoph Hellwig wrote: > > > > The s

Re: [PATCH 2/4] rsicv: avoid sending a SIGTRAP to a user thread trapped in WARN()

2019-09-27 Thread Christoph Hellwig
Oh and s/rsicv/riscv/ in the subject, please.

Re: [PATCH v2 0/3] Add support for SBI v0.2

2019-09-27 Thread Atish Patra
On Fri, 2019-09-27 at 15:19 -0700, Christoph Hellwig wrote: > On Thu, Sep 26, 2019 at 05:09:12PM -0700, Atish Patra wrote: > > The Supervisor Binary Interface(SBI) specification[1] now defines a > > base extension that provides extendability to add future extensions > > while maintaining backward c

Re: [PATCH v5 0/7] hugetlb_cgroup: Add hugetlb_cgroup reservation limits

2019-09-27 Thread Mike Kravetz
On 9/27/19 3:51 PM, Mina Almasry wrote: > On Fri, Sep 27, 2019 at 2:59 PM Mike Kravetz wrote: >> >> On 9/26/19 5:55 PM, Mina Almasry wrote: >>> Provided we keep the existing controller untouched, should the new >>> controller track: >>> >>> 1. only reservations, or >>> 2. both reservations and all

Re: [GIT PULL] 9p updates for 5.4

2019-09-27 Thread pr-tracker-bot
The pull request you sent on Fri, 27 Sep 2019 16:27:26 +0200: > https://github.com/martinetd/linux tags/9p-for-5.4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9977b1a71488742606376c09e19e0074e4403cdf Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kern

Re: [GIT PULL] add virtio-fs

2019-09-27 Thread pr-tracker-bot
The pull request you sent on Thu, 26 Sep 2019 10:43:40 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git > tags/virtio-fs-5.4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8f744bdee4fefb17fac052c7418b830de2b59ac8 Thank you! -- Deet-doot-dot,

[PATCH] virt: vbox: fix memory leak in hgcm_call_preprocess_linaddr

2019-09-27 Thread Navid Emamdoost
In hgcm_call_preprocess_linaddr memory is allocated for bounce_buf but is not released if copy_form_user fails. The release is added. Fixes: 579db9d45cb4 ("virt: Add vboxguest VMMDEV communication code") Signed-off-by: Navid Emamdoost --- drivers/virt/vboxguest/vboxguest_utils.c | 4 +++- 1 fil

Re: [PATCH] namespace: fix namespace.pl script to support relative paths

2019-09-27 Thread Randy Dunlap
re: https://lore.kernel.org/lkml/20190129204319.15238-1-jacob.e.kel...@intel.com/ Did anything happen with this patch? Please send it to linux-kbu...@vger.kernel.org and Cc: Masahiro Yamada You can also add: Acked-by: Randy Dunlap Tested-by: Randy Dunlap I was just about to fix this scri

[PATCH v2] riscv: Fix memblock reservation for device tree blob

2019-09-27 Thread Albert Ou
This fixes an error with how the FDT blob is reserved in memblock. An incorrect physical address calculation exposed the FDT header to unintended corruption, which typically manifested with of_fdt_raw_init() faulting during late boot after fdt_totalsize() returned a wrong value. Systems with smalle

Re: [PATCH] PCI: mobiveil: Fix csr_read/write build issue

2019-09-27 Thread Christoph Hellwig
On Thu, Sep 26, 2019 at 10:29:34AM +0100, Andrew Murray wrote: > Though I'd be just as happy if the csr_[read,write][l,] functions were > renamed to mobiveil_csr_[read,write][l,]. Please do that instead, using such generic names as csr_* in a driver is a bad idea, with or without a __ prefix.

RE: [PATCH] namespace: fix namespace.pl script to support relative paths

2019-09-27 Thread Keller, Jacob E
> -Original Message- > From: Randy Dunlap [mailto:rdun...@infradead.org] > Sent: Friday, September 27, 2019 4:12 PM > To: Keller, Jacob E > Cc: intel-wired-...@lists.osuosl.org; linux-kernel@vger.kernel.org; > linux-kbuild kbu...@vger.kernel.org>; Masahiro Yamada > Subject: Re: [PATCH]

Re: [PATCH v3 00/11] Introduces new count-based method for monitoring lockless pagetable walks

2019-09-27 Thread Leonardo Bras
On Fri, 2019-09-27 at 11:46 -0300, Leonardo Bras wrote: > I am not sure if it would be ok to use irq_{save,restore} in real mode, > I will do some more reading of the docs before addressing this. It looks like it's unsafe to merge irq_{save,restore} in {start,end}_lockless_pgtbl_walk(), due to a

RE: [PATCH] namespace: fix namespace.pl script to support relative paths

2019-09-27 Thread Keller, Jacob E
> -Original Message- > From: Randy Dunlap [mailto:rdun...@infradead.org] > Sent: Friday, September 27, 2019 4:12 PM > To: Keller, Jacob E > Cc: intel-wired-...@lists.osuosl.org; linux-kernel@vger.kernel.org; > linux-kbuild kbu...@vger.kernel.org>; Masahiro Yamada > Subject: Re: [PATCH]

[PATCH 3/3] perf annotate: Improve handling of corrupted ~/.debug

2019-09-27 Thread Andi Kleen
From: Andi Kleen Sometimes ~/.debug can get corrupted and contain files that still have symbol tables, but which objdump cannot handle. Add a fallback to read the "original" file in such a case. This might be wrong too if it's different, but in many cases when profiling on the same host it will w

[PATCH 2/3] perf jevents: Fix period for Intel fixed counters

2019-09-27 Thread Andi Kleen
From: Andi Kleen The Intel fixed counters use a special table to override the JSON information. During this override the period information from the JSON file got dropped, which results in inst_retired.any and similar running with frequency mode instead of a period. Just specify the expected peri

[PATCH 1/3] perf script brstackinsn: Fix recovery from LBR/binary mismatch

2019-09-27 Thread Andi Kleen
From: Andi Kleen When the LBR data and the instructions in a binary do not match the loop printing instructions could get confused and print a long stream of bogus instructions. The problem was that if the instruction decoder cannot decode an instruction it ilen wasn't initialized, so the loop

Re: [PATCH v2 1/8] KVM: nVMX: Always write vmcs02.GUEST_CR3 during nested VM-Enter

2019-09-27 Thread Jim Mattson
On Fri, Sep 27, 2019 at 2:45 PM Sean Christopherson wrote: > > Write the desired L2 CR3 into vmcs02.GUEST_CR3 during nested VM-Enter > instead of deferring the VMWRITE until vmx_set_cr3(). If the VMWRITE > is deferred, then KVM can consume a stale vmcs02.GUEST_CR3 when it > refreshes vmcs12->gues

[PATCH v4 01/11] powerpc/mm: Adds counting method to monitor lockless pgtable walks

2019-09-27 Thread Leonardo Bras
It's necessary to monitor lockless pagetable walks, in order to avoid doing THP splitting/collapsing during them. Some methods rely on local_irq_{save,restore}, but that can be slow on cases with a lot of cpus are used for the process. In order to speedup some cases, I propose a refcount-based ap

[PATCH v4 00/11] Introduces new count-based method for monitoring lockless pagetable walks

2019-09-27 Thread Leonardo Bras
If a process (qemu) with a lot of CPUs (128) try to munmap() a large chunk of memory (496GB) mapped with THP, it takes an average of 275 seconds, which can cause a lot of problems to the load (in qemu case, the guest will lock for this time). Trying to find the source of this bug, I found out most

[PATCH v4 09/11] powerpc/kvm/book3s_64: Applies counting method to monitor lockless pgtbl walks

2019-09-27 Thread Leonardo Bras
Applies the counting-based method for monitoring all book3s_64-related functions that do lockless pagetable walks. Adds comments explaining that some lockless pagetable walks don't need protection due to guest pgd not being a target of THP collapse/split, or due to being called from Realmode + MSR

[PATCH v4 02/11] asm-generic/pgtable: Adds dummy functions to monitor lockless pgtable walks

2019-09-27 Thread Leonardo Bras
There is a need to monitor lockless pagetable walks, in order to avoid doing THP splitting/collapsing during them. Some methods rely on local_irq_{save,restore}, but that can be slow on cases with a lot of cpus are used for the process. In order to speedup these cases, I propose a refcount-based

[PATCH v4 03/11] mm/gup: Applies counting method to monitor gup_pgd_range

2019-09-27 Thread Leonardo Bras
As decribed, gup_pgd_range is a lockless pagetable walk. So, in order to monitor against THP split/collapse with the couting method, it's necessary to bound it with {start,end}_lockless_pgtbl_walk. There are dummy functions, so it is not going to add any overhead on archs that don't use this metho

[PATCH v4 10/11] powerpc/book3s_64: Enables counting method to monitor lockless pgtbl walk

2019-09-27 Thread Leonardo Bras
Enables count-based monitoring method for lockless pagetable walks on PowerPC book3s_64. Other architectures/platforms fallback to using generic dummy functions. Signed-off-by: Leonardo Bras --- arch/powerpc/include/asm/book3s/64/pgtable.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v4 05/11] powerpc/perf: Applies counting method to monitor lockless pgtbl walks

2019-09-27 Thread Leonardo Bras
Applies the counting-based method for monitoring lockless pgtable walks on read_user_stack_slow. Signed-off-by: Leonardo Bras --- arch/powerpc/perf/callchain.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/perf/callchain.c b/arch/powerpc/perf/callchain.c in

[PATCH v4 04/11] powerpc/mce_power: Applies counting method to monitor lockless pgtbl walks

2019-09-27 Thread Leonardo Bras
Applies the counting-based method for monitoring lockless pgtable walks on addr_to_pfn(). Signed-off-by: Leonardo Bras --- arch/powerpc/kernel/mce_power.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/mce_power.c b/arch/powerpc/kernel/mce_

[PATCH v4 07/11] powerpc/kvm/e500: Applies counting method to monitor lockless pgtbl walks

2019-09-27 Thread Leonardo Bras
Applies the counting-based method for monitoring lockless pgtable walks on kvmppc_e500_shadow_map(). Fixes the place where local_irq_restore() is called: previously, if ptep was NULL, local_irq_restore() would never be called. Signed-off-by: Leonardo Bras --- arch/powerpc/kvm/e500_mmu_host.c |

[PATCH v4 08/11] powerpc/kvm/book3s_hv: Applies counting method to monitor lockless pgtbl walks

2019-09-27 Thread Leonardo Bras
Applies the counting-based method for monitoring all book3s_hv related functions that do lockless pagetable walks. Adds comments explaining that some lockless pagetable walks don't need protection due to guest pgd not being a target of THP collapse/split, or due to being called from Realmode + MSR

[PATCH v4 06/11] powerpc/mm/book3s64/hash: Applies counting method to monitor lockless pgtbl walks

2019-09-27 Thread Leonardo Bras
Applies the counting-based method for monitoring all hash-related functions that do lockless pagetable walks. hash_page_mm: Adds comment that explain that there is no need to local_int_disable/save given that it is only called from DataAccess interrupt, so interrupts are already disabled. Signed-

[PATCH v4 11/11] powerpc/mm/book3s64/pgtable: Uses counting method to skip serializing

2019-09-27 Thread Leonardo Bras
Skips slow part of serialize_against_pte_lookup if there is no running lockless pagetable walk. Signed-off-by: Leonardo Bras --- arch/powerpc/mm/book3s64/pgtable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book3s64

Re: [GIT PULL] nfsd changes for 5.4

2019-09-27 Thread J. Bruce Fields
On Fri, Sep 27, 2019 at 03:44:02PM -0700, Linus Torvalds wrote: > But then the actual code is just one single small commit: > > > Dave Wysochanski (1): > > SUNRPC: Track writers of the 'channel' file to improve > > cache_listeners_exist And that's also all that was in the diffstat in my pu

Re: [PATCH v3 01/10] sched/fair: clean up asym packing

2019-09-27 Thread Rik van Riel
On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote: > Clean up asym packing to follow the default load balance behavior: > - classify the group by creating a group_asym_packing field. > - calculate the imbalance in calculate_imbalance() instead of > bypassing it. > > We don't need to test tw

Re: [PATCH v3 02/10] sched/fair: rename sum_nr_running to sum_h_nr_running

2019-09-27 Thread Rik van Riel
On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote: > Rename sum_nr_running to sum_h_nr_running because it effectively > tracks > cfs->h_nr_running so we can use sum_nr_running to track rq- > >nr_running > when needed. > > There is no functional changes. > > Signed-off-by: Vincent Guittot

Re: [PATCH v3 03/10] sched/fair: remove meaningless imbalance calculation

2019-09-27 Thread Rik van Riel
On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote: > clean up load_balance and remove meaningless calculation and fields > before > adding new algorithm. > > Signed-off-by: Vincent Guittot Yay. Acked-by: Rik van Riel -- All Rights Reversed. signature.asc Description: This is a digit

[PATCH] staging: rtl8723bs: Variable rf_type in function rtw_cfg80211_init_wiphy() could be uninitialized

2019-09-27 Thread Yizhuo
In function rtw_cfg80211_init_wiphy(), local variable "rf_type" could be uninitialized if function rtw_hal_get_hwreg() fails to initialize it. However, this value is used in function rtw_cfg80211_init_ht_capab() and used to decide the value writing to ht_cap, which is potentially unsafe. Signed-of

Re: [PATCH v2] Input: atmel_mxt_ts - Disable IRQ across suspend

2019-09-27 Thread Dmitry Torokhov
Hi Evan, On Tue, Sep 24, 2019 at 02:52:38PM -0700, Evan Green wrote: > Across suspend and resume, we are seeing error messages like the following: > > atmel_mxt_ts i2c-PRP0001:00: __mxt_read_reg: i2c transfer failed (-121) > atmel_mxt_ts i2c-PRP0001:00: Failed to read T44 and T5 (-121) > > This

Re: Summary of Crash/Panic Behaviors in Linux Kernel

2019-09-27 Thread 김동현
2019년 9월 27일 (금) 오전 5:01, 慕冬亮 님이 작성: > > Dear all, > > Is there any summary of crash/panic behaviors in the Linux Kernel? For > example, GPF (general protection fault), Kernel BUG (BUG_ON). There are a number of blogs and material which describe the behavior the kernel panic. Talking about Androi

[PATCH] iio: adc: imx25-gcq: Variable could be uninitialized if regmap_read() fails

2019-09-27 Thread Yizhuo
In function mx25_gcq_irq(), local variable "stats" could be uninitialized if function regmap_read() returns -EINVAL. However, this value is used in if statement, which is potentially unsafe. The same case applied to the variable "data" in function mx25_gcq_get_raw_value() in the same file. Signed-

<    1   2   3   4   5   6   7   >