[BACKPORT 4.14.y v3 3/3] power: supply: sysfs: ratelimit property read error message

2019-09-25 Thread Baolin Wang
From: David Lechner [Upstream commit 87a2b65fc855e6be50f791c2ebbb492541896827] This adds rate limiting to the message that is printed when reading a power supply property via sysfs returns an error. This will prevent userspace applications from unintentionally dDOSing the system by continuously

[PATCH] ASoC: rt5663: clean up indentation issues

2019-09-25 Thread Colin King
From: Colin Ian King There are two break statements that are indented one level too deeply, remove the extraneous tabs. Signed-off-by: Colin Ian King --- sound/soc/codecs/rt5663.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt5663.c b/sound/soc/code

[PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-25 Thread Anson Huang
The SCU firmware does NOT always have return value stored in message header's function element even the API has response data, those special APIs are defined as void function in SCU firmware, so they should be treated as return success always. Signed-off-by: Anson Huang --- - This patch i

Re: [PATCH] usb: hub: Minor refactoring in usb_hub_init()

2019-09-25 Thread Austin Kim
> If you really want to fix up this subroutine, you could change the two > "return -1" statements. They should return an appropriate error code, > not just -1. > > Alan Stern > Thanks for valuable feedback over the patch. If I generate new patch later, let me make sure to contain an appropriate e

Re: [PATCH v2 00/22] mtd: spi-nor: Quad Enable and (un)lock methods

2019-09-25 Thread Tudor.Ambarus
Hi, Jonas, s25fl512s is impacted by this patch set. Would you please do a little test to see if everything is ok for your flash with these patches applied? I don't have the flash, so I can't do the tests by myself. There is a possible test method described below in the cover letter. You can find

[PATCH] regulator: pbias: Use of_device_get_match_data

2019-09-25 Thread Axel Lin
Use of_device_get_match_data to simplify the code a bit. Signed-off-by: Axel Lin --- drivers/regulator/pbias-regulator.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/pbias-regulator.c b/drivers/regulator/pbias-regulator.c index 92b41a6a4dc2..a59811

Re: [PATCH] scsi: qedf: Remove always false 'tmp_prio < 0' statement

2019-09-25 Thread Austin Kim
2019년 9월 24일 (화) 오전 11:32, Martin K. Petersen 님이 작성: > > > Austin, [...] > > So remove 'always false' statement. > > Applied to 5.4/scsi-fixes, thanks! > Good, thanks for information. > -- > Martin K. Petersen Oracle Linux Engineering

Re: WireGuard to port to existing Crypto API

2019-09-25 Thread Jason A. Donenfeld
Hi Dave, On Wed, Sep 25, 2019 at 12:03 PM David Miller wrote: > I didn't say "must" anything, I suggested this as a more smoothe > and efficient way forward. s/must/should/g? However it's characterized, I think your jugements and opinions are generally sound, and I intend to put them into action

[PATCH 1/3] tpm: migrate pubek_show to struct tpm_buf

2019-09-25 Thread Jarkko Sakkinen
commit da379f3c1db0c9a1fd27b11d24c9894b5edc7c75 upstream Migrated pubek_show to struct tpm_buf and cleaned up its implementation. Previously the output parameter structure was declared but left completely unused. Now it is used to refer different fields of the output. We can move it to tpm-sysfs.c

[PATCH 0/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-09-25 Thread Jarkko Sakkinen
commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream This backport is for v4.14 and v4.19 The backport requires non-racy behaviour from TPM 1.x sysfs code. Thus, the dependecies for that are included. NOTE: 1/3 is only needed for v4.14. Cc: linux-integr...@vger.kernel.org Cc: Greg KH Cc: Va

[PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-09-25 Thread Jarkko Sakkinen
From: Vadim Sukhomlinov commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that fu

[PATCH 2/3] tpm: use tpm_try_get_ops() in tpm-sysfs.c.

2019-09-25 Thread Jarkko Sakkinen
commit 2677ca98ae377517930c183248221f69f771c921 upstream Use tpm_try_get_ops() in tpm-sysfs.c so that we can consider moving other decorations (locking, localities, power management for example) inside it. This direction can be of course taken only after other call sites for tpm_transmit() have be

RE: [PATCH] ACPICA: make acpi_load_table() return table index

2019-09-25 Thread Nikolaus Voss
On Tue, 24 Sep 2019, Moore, Robert wrote: How about this: Go back to using acpi_tb_install_and_load_table(), but then call acpi_ns_initialize_objects afterwards This is what acpi_load_table does. ACPI_INFO (("Host-directed Dynamic ACPI Table Load:")); Status = AcpiTbInstallAndLoadTable (

Re: [PATCH] ACPICA: Introduce acpi_load_table_with_index()

2019-09-25 Thread Nikolaus Voss
On Tue, 24 Sep 2019, Shevchenko, Andriy wrote: On Tue, Sep 24, 2019 at 03:07:34PM +0300, Shevchenko, Andriy wrote: On Mon, Sep 23, 2019 at 11:47:01AM +0200, Nikolaus Voss wrote: For unloading an ACPI table, it is necessary to provide the index of the table. The method intended for dynamically l

Re: [PATCH v2] x86, realmode: explicitly set entry via command line

2019-09-25 Thread Borislav Petkov
+ some more people who did the unified realmode thing. On Tue, Sep 24, 2019 at 12:33:08PM -0700, Nick Desaulniers wrote: > Linking with ld.lld via $ make LD=ld.lld produces the warning: > ld.lld: warning: cannot find entry symbol _start; defaulting to 0x1000 > > Linking with ld.bfd shows the defa

Re: [PATCH] ACPICA: Introduce acpi_load_table_with_index()

2019-09-25 Thread Nikolaus Voss
On Tue, 24 Sep 2019, Andy Shevchenko wrote: On Mon, Sep 23, 2019 at 11:47:01AM +0200, Nikolaus Voss wrote: For unloading an ACPI table, it is necessary to provide the index of the table. The method intended for dynamically loading or hotplug addition of tables, acpi_load_table(), does not provid

RE: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-25 Thread Jianyong Wu (Arm Technology China)
Hi Paolo, > -Original Message- > From: Paolo Bonzini > Sent: Tuesday, September 24, 2019 10:20 PM > To: Jianyong Wu (Arm Technology China) ; > net...@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; > t...@linutronix.de; sean.j.christopher...@intel.com; m...@kernel.org; > richa

Re: [PATCH net-next] tuntap: Fallback to automq on TUNSETSTEERINGEBPF prog negative return

2019-09-25 Thread Michael S. Tsirkin
On Sun, Sep 22, 2019 at 03:46:19PM -0700, Matt Cover wrote: > Unless of course we can simply state via > documentation that any negative return > for which a define doesn't exist is > undefined behavior. In which case, > there is no old vs new behavior and > no need for an ioctl. Simply the > under

Greetings My Dear Friend,

2019-09-25 Thread mohamed
Greetings My Dear Friend, Before I introduce myself, I wish to inform you that this letter is not a hoax mail and I urge you to treat it serious.This letter must come to you as a big surprise, but I believe it is only a day that people meet and become great friends and business partners. Pl

Re: [PATCH] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids

2019-09-25 Thread Andy Shevchenko
On Tue, Sep 24, 2019 at 11:08:38PM -0500, Navid Emamdoost wrote: > In snd_skl_parse_uuids if allocation for module->instance_id fails, the > allocated memory for module shoulde be released. Since it's using devm_*() for the second allocation it would be cleaner to either switch it to regular kcall

Re: [PATCH] ACPICA: make acpi_load_table() return table index

2019-09-25 Thread Shevchenko, Andriy
On Wed, Sep 25, 2019 at 12:18:11PM +0200, Nikolaus Voss wrote: > On Tue, 24 Sep 2019, Moore, Robert wrote: > > How about this: > > Go back to using acpi_tb_install_and_load_table(), but then call > > acpi_ns_initialize_objects afterwards This is what acpi_load_table does. > > > > > >ACPI_INF

[PATCH net] of: mdio: Fix a signedness bug in of_phy_get_and_connect()

2019-09-25 Thread Dan Carpenter
The "iface" variable is an enum and in this context GCC treats it as an unsigned int so the error handling is never triggered. Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect") Signed-off-by: Dan Carpenter --- drivers/of/of_mdio.c | 2 +- 1 file changed, 1 insertion(+

[PATCH] usb: typec: tcpm: Fix a signedness bug in tcpm_fw_get_caps()

2019-09-25 Thread Dan Carpenter
The "port->typec_caps.data" and "port->typec_caps.type" variables are enums and in this context GCC will treat them as an unsigned int so they can never be less than zero. Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together") Signed-off-by: Dan Carpenter --- drivers/usb/typec/tc

Re: pstore does not work under xen

2019-09-25 Thread James Dingwall
On Mon, Sep 23, 2019 at 08:41:05PM -0400, Boris Ostrovsky wrote: > On 9/23/19 6:59 PM, Kees Cook wrote: > > On Mon, Sep 23, 2019 at 03:42:27PM +, James Dingwall wrote: > >> On Thu, Sep 19, 2019 at 12:37:40PM -0400, Boris Ostrovsky wrote: > >>> On 9/19/19 12:14 PM, James Dingwall wrote: > O

[PATCH] power: supply: sbs-battery: Fix a signedness bug in sbs_get_battery_capacity()

2019-09-25 Thread Dan Carpenter
The "mode" variable is an enum and in this context GCC treats it as an unsigned int so the error handling is never triggered. Fixes: 51d075660457 ("bq20z75: Add support for charge properties") Signed-off-by: Dan Carpenter --- drivers/power/supply/sbs-battery.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH 1/2] powerpc/mm: Add a helper to select PAGE_KERNEL_RO or PAGE_READONLY

2019-09-25 Thread Michael Ellerman
On Wed, 2019-08-21 at 10:20:00 UTC, Christophe Leroy wrote: > In a couple of places there is a need to select whether read-only > protection of shadow pages is performed with PAGE_KERNEL_RO or with > PAGE_READONLY. > > Add a helper to avoid duplicating the choice. > > Signed-off-by: Christophe Le

[PATCH] mm, vmpressure: Fix a signedness bug in vmpressure_register_event()

2019-09-25 Thread Dan Carpenter
The "mode" and "level" variables are enums and in this context GCC will treat them as unsigned ints so the error handling is never triggered. I also removed the bogus initializer because it isn't required any more and it's sort of confusing. Fixes: 3cadfa2b9497 ("mm/vmpressure.c: convert to use m

Re: [PATCH v3 2/2] crypto: sun4i-ss: enable pm_runtime

2019-09-25 Thread Maxime Ripard
On Tue, Sep 24, 2019 at 10:08:32AM +0200, Corentin Labbe wrote: > This patch enables power management on the Security System. > sun4i-ss now depends on PM because it simplify code and prevent some ifdef. > But this is not a problem since arch maintainer want ARCH_SUNXI to > depend on PM in the futu

Re: [PATCH v3 1/2] powperc/mm: read TLB Block Invalidate Characteristics

2019-09-25 Thread Michael Ellerman
On Fri, 2019-09-20 at 13:05:22 UTC, Laurent Dufour wrote: > The PAPR document specifies the TLB Block Invalidate Characteristics which > tells for each pair of segment base page size, actual page size, the size > of the block the hcall H_BLOCK_REMOVE supports. > > These characteristics are loaded

[PATCH] ASoC: topology: Fix a signedness bug in soc_tplg_dapm_widget_create()

2019-09-25 Thread Dan Carpenter
The "template.id" variable is an enum and in this context GCC will treat it as an unsigned int so it can never be less than zero. Fixes: 8a9782346dcc ("ASoC: topology: Add topology core") Signed-off-by: Dan Carpenter --- sound/soc/soc-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] ASoC: wcd9335: clean up indentation issue

2019-09-25 Thread Colin King
From: Colin Ian King There is an if statement that is indented one level too deeply, remove the extraneous tabs. Signed-off-by: Colin Ian King --- sound/soc/codecs/wcd9335.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/co

[PATCH] firmware: turris-mox-rwtm: clean up indentation issue

2019-09-25 Thread Colin King
From: Colin Ian King There is a statement that is indented one level too deeply, remove the extraneous tab. Signed-off-by: Colin Ian King --- drivers/firmware/turris-mox-rwtm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/fir

[PATCH] HID: alps: clean up indentation issue

2019-09-25 Thread Colin King
From: Colin Ian King There is an if statement that is indented one level too deeply, remove the extraneous tab. Signed-off-by: Colin Ian King --- drivers/hid/hid-alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index ae7

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SC7180

2019-09-25 Thread Taniya Das
Hi Stephen, Please find my comments. On 9/25/2019 4:42 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-09-23 01:01:11) Hi Stephen, Thanks for your comments. On 9/19/2019 3:09 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-09-18 02:50:18) diff --git a/drivers/clk/qcom/gcc-sc7180.c b/driv

[RFC PATCH 1/2] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor

2019-09-25 Thread Shubhrajyoti Datta
Add dt bindings for flexnoc Performance Monitor. The flexnoc counters for read and write response and requests are supported. Signed-off-by: Shubhrajyoti Datta --- .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644

[RFC PATCH 2/2] misc: xilinx_flex: Add support for the flex noc Performance Monitor

2019-09-25 Thread Shubhrajyoti Datta
Add support for the FlexNoc Performance Monitor. Adds support for various port setting and monitoring the packets transactions. It supports LPD and FPD monitoring counters for read and write transaction requests and responses. Signed-off-by: Shubhrajyoti Datta --- drivers/misc/Kconfig |

[PATCH] ASoC: stm32: sai: clean up indentation issue

2019-09-25 Thread Colin King
From: Colin Ian King There is a statement that is indented one level too deeply, remove the extraneous tab. Signed-off-by: Colin Ian King --- sound/soc/stm/stm32_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai.c b/sound/soc/stm/stm32_sai.c inde

RE: [PATCH v5 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-09-25 Thread Robin Gong
On 2019-9-24 21:28 Schrempf Frieder wrote: > > Hi Robin, > > > From: Robin Gong > > > > Because the number of ecspi1 rx event on i.mx8mm is 0, the condition > > check ignore such special case without dma channel enabled, which > > caused > > ecspi1 rx works failed. Actually, no need to check ev

Re: [RFC 1/2] mmc: sdhci-msm: Add support for bus bandwidth voting

2019-09-25 Thread ppvk
On 2019-09-12 22:15, Bjorn Andersson wrote: On Fri 06 Sep 05:47 PDT 2019, Pradeep P V K wrote: Vote for the MSM bus bandwidth required by SDHC driver based on the clock frequency and bus width of the card. Otherwise,the system clocks may run at minimum clock speed and thus affecting the perform

Re: [RFC PATCH 2/2] misc: xilinx_flex: Add support for the flex noc Performance Monitor

2019-09-25 Thread Greg KH
On Wed, Sep 25, 2019 at 04:53:07PM +0530, Shubhrajyoti Datta wrote: > Add support for the FlexNoc Performance Monitor. > Adds support for various port setting and monitoring > the packets transactions. It supports LPD and FPD monitoring > counters for read and write transaction requests and respons

[PATCH v4 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence

2019-09-25 Thread Kai-Heng Feng
A driver may want to know the existence of _PR3, to choose different runtime suspend behavior. A user will be add in next patch. This is mostly the same as nouveau_pr3_present(). Signed-off-by: Kai-Heng Feng --- v4: - Let caller to find its upstream port device. drivers/pci/pci.c | 16 ++

[PATCH v4 2/2] ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a driver

2019-09-25 Thread Kai-Heng Feng
Nvidia proprietary driver doesn't support runtime power management, so when a user only wants to use the integrated GPU, it's a common practice to let dGPU not to bind any driver, and let its upstream port to be runtime suspended. At the end of runtime suspension the port uses platform power manage

Re: [PATCH 1/5] powerpc: Add OPAL calls for LPC memory alloc/release

2019-09-25 Thread Andrew Donnellan
On 17/9/19 3:42 am, Alastair D'Silva wrote: From: Alastair D'Silva Add OPAL calls for LPC memory alloc/release Signed-off-by: Alastair D'Silva This needs rebasing, but apart from that. Acked-by: Andrew Donnellan --- arch/powerpc/include/asm/opal-api.h| 4 +++- arch/powerpc/in

Re: [PATCH] hdlc: Simplify code in 'pvc_xmit()'

2019-09-25 Thread David Miller
From: Christophe JAILLET Date: Sat, 21 Sep 2019 08:17:38 +0200 > Use __skb_pad instead of rewriting it, this saves some LoC. > > Signed-off-by: Christophe JAILLET > --- > Compile tested only. Please test this code and resubmit for net-next, thank you.

[PATCH v5 1/2] PCI: Add pci_pr3_present() helper to check Power Resource for D3hot

2019-09-25 Thread Kai-Heng Feng
Add pci_pr3_present() to check whether the platform supplies _PR3 to tell us which power resources the device depends on when in D3hot. This information is useful to let drivers choose different runtime suspend behavior. A user will be add in next patch. This is mostly the same as nouveau_pr3_pres

[PATCH] can: m_can: add support for one shot mode

2019-09-25 Thread Pankaj Sharma
According to the CAN Specification (see ISO 11898-1:2015, 8.3.4 Recovery Management), the M_CAN provides means for automatic retransmission of frames that have lost arbitration or that have been disturbed by errors during transmission. By default automatic retransmission is enabled. The Bosch MCAN

Re: [PATCH] HID: core: clean up indentation issue

2019-09-25 Thread Dan Carpenter
On Mon, Sep 23, 2019 at 01:04:13PM +0200, Jiri Kosina wrote: > On Sun, 22 Sep 2019, Colin King wrote: > > > From: Colin Ian King > > > > There is an if statement that is indented by one extra space, > > fix this by removing the extraneous space. > > > > Signed-off-by: Colin Ian King > > --- >

Re: [PATCH] atm: he: clean up an indentation issue

2019-09-25 Thread David Miller
From: Colin King Date: Sun, 22 Sep 2019 13:42:16 +0200 > From: Colin Ian King > > There is a statement that is indented one level too many, remove > the extraneous tab. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH net] gianfar: Make reset_gfar static

2019-09-25 Thread David Miller
From: YueHaibing Date: Mon, 23 Sep 2019 14:16:03 +0800 > Fix sparse warning: > > drivers/net/ethernet/freescale/gianfar.c:2070:6: > warning: symbol 'reset_gfar' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Applied, thanks.

[PATCH V2 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

2019-09-25 Thread Balasubramani Vivekanandan
> Find a completely untested patch below Thanks for the patch. I tested your patch and it is working fine. I do not notice the rcu stall warnings anymore. I have just updated the formatting of brackets. Please check and apply

Re: [PATCH net v2] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-25 Thread David Miller
From: Jose Abreu Date: Mon, 23 Sep 2019 09:49:08 +0200 > The Flow Control selftest is also available with ASYM Pause. Lets add > this check to the test and fix eventual false positive failures. > > Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") > Signed-off-by: Jose Abreu App

[PATCH 0/2] add Amlogic A1 clock controller driver

2019-09-25 Thread Jian Hu
add support for Amlogic A1 clock driver, the clock includes three parts: peripheral clocks, pll clocks, CPU clocks. sys pll and CPU clocks will be sent in next patch. Unlike the previous series, there is no EE/AO domain in A1 clock controllers. Jian Hu (2): dt-bindings: clock: meson: add A1 cl

[PATCH 2/2] clk: meson: a1: add support for Amlogic A1 clock driver

2019-09-25 Thread Jian Hu
The Amlogic A1 clock includes three parts: peripheral clocks, pll clocks, CPU clocks. sys pll and CPU clocks will be sent in next patch. Unlike the previous series, there is no EE/AO domain in A1 CLK controllers. Signed-off-by: Jian Hu Signed-off-by: Jianxin Pan --- arch/arm64/Kconfig.platform

[PATCH 1/2] dt-bindings: clock: meson: add A1 clock controller bindings

2019-09-25 Thread Jian Hu
Add the documentation to support Amlogic A1 clock driver, and add A1 clock controller bindings. Signed-off-by: Jian Hu Signed-off-by: Jianxin Pan --- .../devicetree/bindings/clock/amlogic,a1-clkc.yaml | 65 + include/dt-bindings/clock/a1-clkc.h| 102

[PATCH V2 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

2019-09-25 Thread Balasubramani Vivekanandan
When a cpu requests broadcasting, before starting the tick broadcast hrtimer, bc_set_next() checks if the timer callback (bc_handler) is active using hrtimer_try_to_cancel(). But hrtimer_try_to_cancel() does not provide the required synchronization when the callback is active on other core. The cal

Re: [Regression] MacBook Pro - suspend does not power off - reaches dangerously hot temps

2019-09-25 Thread Eric Blau
On Mon, Aug 12, 2019 at 5:44 PM Eric Blau wrote: > > Hi all, > > I have a MacBook Pro 12,1 model where I've hit a regression since > upgrading to 5.2.x. When I enter hybrid-sleep mode with "systemctl > hybrid-sleep", the laptop appears to enter suspend (screen turns off > and keyboard backlights g

Re: [PATCH v3] PCI: aardvark: Fix PCI_EXP_RTCTL register configuration

2019-09-25 Thread Thomas Petazzoni
On Fri, 14 Jun 2019 12:10:59 +0200 Remi Pommarel wrote: > PCI_EXP_RTCTL is used to activate PME interrupt only, so writing into it > should not modify other interrupts' mask. The ISR mask polarity was also > inverted, when PCI_EXP_RTCTL_PMEIE is set PCIE_MSG_PM_PME_MASK mask bit > should actually

Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI

2019-09-25 Thread Ursula Braun
On 9/24/19 4:52 PM, David Miller wrote: > From: Eugene Syromiatnikov > Date: Fri, 20 Sep 2019 17:41:47 +0200 > >> As of now, it's a bit difficult to use SMC protocol, as significant part >> of definitions related to it are defined in private headers and are not >> part of UAPI. The following c

Re: [PATCH 07/17] KVM: monolithic: x86: adjust the section prefixes

2019-09-25 Thread Andrea Arcangeli
Hello, On Mon, Sep 23, 2019 at 12:15:23PM +0200, Paolo Bonzini wrote: > On 20/09/19 23:24, Andrea Arcangeli wrote: > > Adjusts the section prefixes of some KVM common code function because > > with the monolithic methods the section checker can now do a more > > accurate analysis at build time and

Re: [PATCH v2] mm: don't expose page to fast gup prematurely

2019-09-25 Thread Kirill A. Shutemov
On Tue, Sep 24, 2019 at 04:05:50PM -0600, Yu Zhao wrote: > On Tue, Sep 24, 2019 at 02:23:16PM +0300, Kirill A. Shutemov wrote: > > On Sat, Sep 14, 2019 at 01:05:18AM -0600, Yu Zhao wrote: > > > We don't want to expose page to fast gup running on a remote CPU > > > before all local non-atomic ops on

Re: [PATCH 07/17] KVM: monolithic: x86: adjust the section prefixes

2019-09-25 Thread Paolo Bonzini
On 25/09/19 14:13, Andrea Arcangeli wrote: > > The __exit removed from unsetup is because kvm_arch_hardware_unsetup > is called by kvm_init, so unless somehow kvm_init can go in the exit > section and be dropped too during the final kernel link (which would > prevent KVM to initialize in the first

Re: [PATCH v3] PCI: aardvark: Use LTSSM state to build link training flag

2019-09-25 Thread Thomas Petazzoni
Hello Remi, On Wed, 22 May 2019 23:33:51 +0200 Remi Pommarel wrote: > Aardvark's PCI_EXP_LNKSTA_LT flag in its link status register is not > implemented and does not reflect the actual link training state (the > flag is always set to 0). In order to support link re-training feature > this flag h

[PATCH] iio: gyro: clean up indentation issue

2019-09-25 Thread Colin King
From: Colin Ian King There is a return statement that is indented incorrectly, add in the missing tab. Signed-off-by: Colin Ian King --- drivers/iio/gyro/itg3200_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/itg3200_core.c b/drivers/iio/gyro/itg320

[PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir

2019-09-25 Thread Yunfeng Ye
After the commit 76128326f97c ("toplevel: Move ipc/ to kernel/ipc/: move the files"), we met some error messages: ./scripts/checkpatch.pl: "Must be run from the top-level dir. of a kernel tree" ./scripts/get_maintainer.pl: "The current directory does not appear to be a linux kernel source

WARN_ON_ONCE in qla2x00_status_cont_entry

2019-09-25 Thread Daniel Wagner
Hi, While testing an update of the qla2xxx driver (10.01.00.19-k) in our downstream kernel, I noticed that the WARN_ON_ONCE in qla2x00_status_cont_entry() is triggered. It was introduced by 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") This happens

[PATCH] async: Let kfree() out of the critical area of the lock

2019-09-25 Thread Yunfeng Ye
It's not necessary to put kfree() in the critical area of the lock, so let it out. Signed-off-by: Yunfeng Ye --- kernel/async.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/async.c b/kernel/async.c index 4f9c1d6..1de270d 100644 --- a/kernel/async.c +++ b/kerne

Re: [PATCH v2] mm: implement write-behind policy for sequential file writes

2019-09-25 Thread Theodore Y. Ts'o
On Wed, Sep 25, 2019 at 05:18:54PM +1000, Dave Chinner wrote: > > > ANd, really such strict writebehind behaviour is going to cause all > > > sorts of unintended problesm with filesystems because there will be > > > adverse interactions with delayed allocation. We need a substantial > > > amount of

WARNING in pvr2_i2c_core_done

2019-09-25 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d9e63adc usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=16b5fcd560 kernel config: https://syzkaller.appspot.com/x/.

[PATCH v2] i2c: at91: Send bus clear command if SCL or SDA is down

2019-09-25 Thread Codrin Ciubotariu
After a transfer timeout, some faulty I2C slave devices might hold down the SCL or the SDA pins. We can generate a bus clear command, hoping that the slave might release the pins. Signed-off-by: Codrin Ciubotariu Acked-by: Ludovic Desroches --- Changes in v2: - added '.has_clear_cmd' struct me

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SC7180

2019-09-25 Thread Stephen Boyd
Quoting Taniya Das (2019-09-25 04:20:07) > Hi Stephen, > > Please find my comments. > > On 9/25/2019 4:42 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2019-09-23 01:01:11) > >> Hi Stephen, > >> > >> Thanks for your comments. > >> > >> On 9/19/2019 3:09 AM, Stephen Boyd wrote: > >>> Quoting Tan

Re: [PATCH] mm, vmpressure: Fix a signedness bug in vmpressure_register_event()

2019-09-25 Thread Andy Shevchenko
On Wed, Sep 25, 2019 at 02:04:49PM +0300, Dan Carpenter wrote: > The "mode" and "level" variables are enums and in this context GCC will > treat them as unsigned ints so the error handling is never triggered. > > I also removed the bogus initializer because it isn't required any more > and it's so

[PATCH] arm64: Allow disabling of the compat vDSO

2019-09-25 Thread Catalin Marinas
The compat vDSO building requires a cross-compiler than produces AArch32 binaries, defined via CONFIG_CROSS_COMPILE_COMPAT_VDSO or the CROSS_COMPILE_COMPAT environment variable. If none of these is defined, building the kernel always prints a warning as there is no way to deselect the compat vDSO.

[PATCH] sunrpc: clean up indentation issue

2019-09-25 Thread Colin King
From: Colin Ian King There are statements that are indented incorrectly, remove the extraneous spacing. Signed-off-by: Colin Ian King --- net/sunrpc/svc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index 220b79988000..d11b70552c3

[PATCH] KVM: selftests: fix ucall on x86

2019-09-25 Thread Vitaly Kuznetsov
After commit e8bb4755eea2("KVM: selftests: Split ucall.c into architecture specific files") selftests which use ucall on x86 started segfaulting and apparently it's gcc to blame: it "optimizes" ucall() function throwing away va_start/va_end part because it thinks the structure is not being used. Pr

[PATCH] efi: make unexported efi_rci2_sysfs_init static

2019-09-25 Thread Ben Dooks
The efi_rci2_sysfs_init() is not used outside of rci2-table.c so make it static to silence the following sparse warning: drivers/firmware/efi/rci2-table.c:79:12: warning: symbol 'efi_rci2_sysfs_init' was not declared. Should it be static? Signed-off-by: Ben Dooks --- drivers/firmware/efi/rci2-

Re: [PATCH 2/2] clk: meson: a1: add support for Amlogic A1 clock driver

2019-09-25 Thread Stephen Boyd
Quoting Jian Hu (2019-09-25 04:44:48) > The Amlogic A1 clock includes three parts: > peripheral clocks, pll clocks, CPU clocks. > sys pll and CPU clocks will be sent in next patch. > > Unlike the previous series, there is no EE/AO domain > in A1 CLK controllers. > > Signed-off-by: Jian Hu > Sign

[PATCH v2] dt-bindings: riscv: Fix CPU schema errors

2019-09-25 Thread Rob Herring
Fix the errors in the RiscV CPU DT schema: Documentation/devicetree/bindings/riscv/cpus.example.dt.yaml: cpu@0: 'timebase-frequency' is a required property Documentation/devicetree/bindings/riscv/cpus.example.dt.yaml: cpu@1: 'timebase-frequency' is a required property Documentation/devicetree/bi

Re: [PATCH] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-09-25 Thread Leonard Crestez
On 25.09.2019 13:09, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success always. > > Si

Re: [PATCH] KVM: selftests: fix ucall on x86

2019-09-25 Thread Paolo Bonzini
On 25/09/19 15:12, Vitaly Kuznetsov wrote: > After commit e8bb4755eea2("KVM: selftests: Split ucall.c into architecture > specific files") selftests which use ucall on x86 started segfaulting and > apparently it's gcc to blame: it "optimizes" ucall() function throwing away > va_start/va_end part be

RE: [PATCH] KVM: vmx: fix a build warning in hv_enable_direct_tlbflush() on i386

2019-09-25 Thread Vitaly Kuznetsov
Tianyu Lan writes: > There is another warning in the report. > > arch/x86/kvm/vmx/vmx.c: In function 'hv_enable_direct_tlbflush': > arch/x86/kvm/vmx/vmx.c:507:20: warning: cast from pointer to integer of > different size [-Wpointer-to-int-cast] > evmcs->hv_vm_id = (u64)vcpu->kvm; >

RE: [PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on Inspiron 10xx

2019-09-25 Thread Mario.Limonciello
> -Original Message- > From: Pacien TRAN-GIRARD > Sent: Wednesday, September 25, 2019 4:48 AM > Cc: Pali Rohár; Limonciello, Mario; Matthew Garrett; Darren Hart; Andy > Shevchenko; Platform Driver; Linux Kernel Mailing List > Subject: [PATCH v2] platform/x86: dell-laptop: fix broken kbd ba

[PATCH v5] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

2019-09-25 Thread Marek Szyprowski
From: Maciej Falkowski Convert Samsung I2S controller to newer dt-schema format. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- v5: - Removed '#clock-cells' property from required properties - Added deprecated property to 'clock-output-names' and removed corresponding comm

Re: [RFC PATCH] interconnect: Replace of_icc_get() with icc_get() and reduce DT binding

2019-09-25 Thread Stephen Boyd
Quoting Bjorn Andersson (2019-09-24 22:59:33) > On Tue 24 Sep 22:41 PDT 2019, Stephen Boyd wrote: > > > The DT binding could also be simplified somewhat. Currently a path needs > > to be specified in DT for each and every use case that is possible for a > > device to want. Typically the path is to

Re: [PATCH v2 0/5] KVM: VMX: Optimize VMX instrs error/fault handling

2019-09-25 Thread Paolo Bonzini
On 19/07/19 22:41, Sean Christopherson wrote: > A recent commit reworked __kvm_handle_fault_on_reboot() to play nice with > objtool. An unfortunate side effect is that JMP is now inserted after > most VMX instructions so that the reboot macro can use an actual CALL to > kvm_spurious_fault() instea

[PATCH v2] KVM: vmx: fix build warnings in hv_enable_direct_tlbflush() on i386

2019-09-25 Thread Vitaly Kuznetsov
The following was reported on i386: arch/x86/kvm/vmx/vmx.c: In function 'hv_enable_direct_tlbflush': arch/x86/kvm/vmx/vmx.c:503:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] pr_debugs() in this function are more or less useless, let's just remove them.

Re: [PATCH v2] KVM: vmx: fix build warnings in hv_enable_direct_tlbflush() on i386

2019-09-25 Thread Paolo Bonzini
On 25/09/19 15:30, Vitaly Kuznetsov wrote: > The following was reported on i386: > > arch/x86/kvm/vmx/vmx.c: In function 'hv_enable_direct_tlbflush': > arch/x86/kvm/vmx/vmx.c:503:10: warning: cast from pointer to integer of > different size [-Wpointer-to-int-cast] > > pr_debugs() in this fun

Re: [PATCH V2 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

2019-09-25 Thread Balasubramani Vivekanandan
+ Peter Zijlstra, linux-renesas-soc

Re: [PATCH] async: Let kfree() out of the critical area of the lock

2019-09-25 Thread gre...@linuxfoundation.org
On Wed, Sep 25, 2019 at 08:52:26PM +0800, Yunfeng Ye wrote: > It's not necessary to put kfree() in the critical area of the lock, so > let it out. > > Signed-off-by: Yunfeng Ye > --- > kernel/async.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/async.c b

Re: [PATCH v4 1/8] dt-bindings: timer: Convert Exynos MCT bindings to json-schema

2019-09-25 Thread Marek Szyprowski
Hi Krzysztof, On 23.09.2019 18:14, Krzysztof Kozlowski wrote: > Convert Samsung Exynos Soc Multi Core Timer bindings to DT schema format > using json-schema. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v3: > 1. Use interrupts-extended instead of interrupts-map. > > Changes si

[PATCH 2/2] brcmfmac: fix suspend/resume when power is cut off

2019-09-25 Thread Adrian Ratiu
brcmfmac assumed the wifi device always remains powered on and thus hardcoded the MMC_PM_KEEP_POWER flag expecting the wifi device to remain on even during suspend/resume cycles. This is not always the case, some appliances cut power to everything connected via SDIO for efficiency reasons and this

[PATCH 1/2] brcmfmac: don't WARN when there are no requests

2019-09-25 Thread Adrian Ratiu
When n_reqs == 0 there is nothing to do so it doesn't make sense to search for requests and issue a warning because none is found. Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 4 1 file changed, 4 insertions(+) diff -

Re: For review: pidfd_send_signal(2) manual page

2019-09-25 Thread Michael Kerrisk (man-pages)
Hello Daniel, On 9/24/19 11:08 PM, Daniel Colascione wrote: > On Tue, Sep 24, 2019 at 2:00 PM Michael Kerrisk (man-pages) > wrote: >> >> Hello Christian, >> > If you're the parent of the process you can do this without CLONE_PIDFD: > pid = fork(); > pidfd = pidfd_open(); > ret = p

Re: For review: pidfd_send_signal(2) manual page

2019-09-25 Thread Michael Kerrisk (man-pages)
On 9/24/19 11:53 PM, Christian Brauner wrote: > On Tue, Sep 24, 2019 at 11:00:03PM +0200, Michael Kerrisk (man-pages) wrote: >> Hello Christian, >> > If you're the parent of the process you can do this without CLONE_PIDFD: > pid = fork(); > pidfd = pidfd_open(); > ret = pidfd_send_s

Re: [PATCH] async: Let kfree() out of the critical area of the lock

2019-09-25 Thread Yunfeng Ye
On 2019/9/25 21:38, gre...@linuxfoundation.org wrote: > On Wed, Sep 25, 2019 at 08:52:26PM +0800, Yunfeng Ye wrote: >> It's not necessary to put kfree() in the critical area of the lock, so >> let it out. >> >> Signed-off-by: Yunfeng Ye >> --- >> kernel/async.c | 6 +++--- >> 1 file changed, 3

[PATCH] tpm: Detach page allocation from tpm_buf

2019-09-25 Thread Jarkko Sakkinen
As has been seen recently, binding the buffer allocation and tpm_buf together is sometimes far from optimal. The buffer might come from the caller namely when tpm_send() is used by another subsystem. In addition we can stability in call sites w/o rollback (e.g. power events)> Take allocation out o

Re: For review: pidfd_send_signal(2) manual page

2019-09-25 Thread Florian Weimer
* Michael Kerrisk: >If these conditions don't hold true, then the child process should >instead be created using clone(2) with the CLONE_PID flag. I think this should be CLONE_PIDFD.

Re: For review: pidfd_send_signal(2) manual page

2019-09-25 Thread Christian Brauner
On Wed, Sep 25, 2019 at 03:46:26PM +0200, Michael Kerrisk (man-pages) wrote: > On 9/24/19 11:53 PM, Christian Brauner wrote: > > On Tue, Sep 24, 2019 at 11:00:03PM +0200, Michael Kerrisk (man-pages) wrote: > >> Hello Christian, > >> > > If you're the parent of the process you can do this withou

Re: For review: pidfd_send_signal(2) manual page

2019-09-25 Thread Michael Kerrisk (man-pages)
On 9/25/19 3:51 PM, Florian Weimer wrote: > * Michael Kerrisk: > >>If these conditions don't hold true, then the child process should >>instead be created using clone(2) with the CLONE_PID flag. > > I think this should be CLONE_PIDFD. Thanks Florian. Fixed. Cheers, Michael --

Re: [PATCH] tpm: Detach page allocation from tpm_buf

2019-09-25 Thread James Bottomley
On Wed, 2019-09-25 at 16:48 +0300, Jarkko Sakkinen wrote: [...] > + data_page = alloc_page(GFP_HIGHUSER); > + if (!data_page) > + return -ENOMEM; > + > + data_ptr = kmap(data_page); I don't think this is such a good idea. On 64 bit it's no different from GFP_KERNEL and on

Re: [BACKPORT 4.14.y v3 1/3] locking/lockdep: Add debug_locks check in __lock_downgrade()

2019-09-25 Thread Waiman Long
On 9/25/19 6:01 AM, Baolin Wang wrote: > From: Waiman Long > > [Upstream commit 513e1073d52e55b8024b4f238a48de7587c64ccf] > > Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" > warning right after a previous lockdep warning. It is likely that the > previous warning turned of

<    1   2   3   4   5   6   7   8   >