[PATCH v3] nvme: allow 64-bit results in passthru commands

2019-09-24 Thread Marta Rybczynska
It is not possible to get 64-bit results from the passthru commands, what prevents from getting for the Capabilities (CAP) property value. As a result, it is not possible to implement IOL's NVMe Conformance test 4.3 Case 1 for Fabrics targets [1] (page 123). This issue has been already discussed

Re: [Linux-kernel-mentees] [PATCH] fs: direct-io: Fixed a Documentation build warn

2019-09-24 Thread Shuah Khan
On 9/24/19 6:23 AM, Matthew Wilcox wrote: On Tue, Sep 24, 2019 at 05:49:25PM +0530, Madhuparna Bhowmik wrote: Adds the description about offset within the code. Why? @@ -255,6 +254,7 @@ void dio_warn_stale_pagecache(struct file *filp) */ static ssize_t dio_complete(struct dio *dio, ssiz

Re: [PATCH v2] memcg: Only record foreign writebacks with dirty pages when memcg is not disabled

2019-09-24 Thread Michal Hocko
On Tue 24-09-19 21:04:58, Baoquan He wrote: > On 09/24/19 at 02:27pm, Michal Hocko wrote: > > On Tue 24-09-19 19:11:51, Baoquan He wrote: > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > index f3c15bb07cce..84e3fdb1ccb4 100644 > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > >

Re: WARNING: locking bug in selinux_netlbl_socket_connect

2019-09-24 Thread Paul Moore
On Tue, Sep 24, 2019 at 4:21 AM Dmitry Vyukov wrote: > On Tue, Sep 24, 2019 at 4:14 AM Paul Moore wrote: > > On Sat, Sep 21, 2019 at 11:50 AM syzbot > > wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:f97c81dc Merge tag 'armsoc-late' of > > > git

Urgent

2019-09-24 Thread Mr. Kabiru Wahid
Dear Friend! I Know That This Mail Will Come To You As A Surprise As We Never Met Before. I Need Your Urgent Assistance in Transferring the Sum Of ($15.5m) Into Your Bank Account, After Hearing from You I Will Give You More Details about the Transaction. Your full data's will be required.(kwprivof

Re: [PATCH v5 11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-09-24 Thread Schrempf Frieder
Hi Robin, > From: Robin Gong > > Because the number of ecspi1 rx event on i.mx8mm is 0, the condition > check ignore such special case without dma channel enabled, which caused > ecspi1 rx works failed. Actually, no need to check event_id0/event_id1 > and replace checking 'event_id1' with 'DMA_D

Re: [PATCH] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule

2019-09-24 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 24 Sep 2019 14:55:04 +0200 > On Tue, Sep 24, 2019 at 2:53 PM David Miller wrote: >> Please make such test cases integratabe into the selftests area for >> networking >> and submit it along with this fix. > > That link is for a WireGuard test-case. When we

Re: [RFC] mm: memcg: add priority for soft limit reclaiming

2019-09-24 Thread Michal Hocko
On Tue 24-09-19 15:36:42, Hillf Danton wrote: > > On Mon, 23 Sep 2019 21:28:34 Michal Hocko wrote: > > > > On Mon 23-09-19 21:04:59, Hillf Danton wrote: > > > > > > On Thu, 19 Sep 2019 21:32:31 +0800 Michal Hocko wrote: > > > > > > > > On Thu 19-09-19 21:13:32, Hillf Danton wrote: > > > > > > > >

RE: [PATCH 2/3] clk: let init callback return an error code

2019-09-24 Thread Ankur Tyagi
Hi, I am no expert here but just looked at the patch and found few discrepancy that I have mentioned inline. > -Original Message- > From: linux-omap-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Jerome Brunet > Sent: Wednesday, 25 September 2019 12:40 AM > To: Michael Turquet

Re: [RFC] mm: Proactive compaction

2019-09-24 Thread Vlastimil Babka
On 9/20/19 1:37 AM, Nitin Gupta wrote: > On Tue, 2019-08-20 at 10:46 +0200, Vlastimil Babka wrote: >> >> That's a lot of control knobs - how is an admin supposed to tune them to >> their >> needs? > > > Yes, it's difficult for an admin to get so many tunable right unless > targeting a very specif

Re: [PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-24 Thread Jean-Jacques Hiblot
On 23/09/2019 23:03, Jacek Anaszewski wrote: Hi Jean, On 9/23/19 11:14 AM, Jean-Jacques Hiblot wrote: Hi Jacek, On 20/09/2019 23:10, Jacek Anaszewski wrote: Hi Jean, On 9/20/19 2:25 PM, Jean-Jacques Hiblot wrote: Making led_set_brightness_sync() use led_set_brightness_nosleep() has 2 adva

Re: [PATCH v2] memcg: Only record foreign writebacks with dirty pages when memcg is not disabled

2019-09-24 Thread Baoquan He
On 09/24/19 at 03:16pm, Michal Hocko wrote: > On Tue 24-09-19 21:04:58, Baoquan He wrote: > > On 09/24/19 at 02:27pm, Michal Hocko wrote: > > > On Tue 24-09-19 19:11:51, Baoquan He wrote: > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > > index f3c15bb07cce..84e3fdb1ccb4 100644 > > > >

Re: [PATCH v2] memcg: Only record foreign writebacks with dirty pages when memcg is not disabled

2019-09-24 Thread Michal Hocko
On Tue 24-09-19 21:43:52, Baoquan He wrote: > On 09/24/19 at 03:16pm, Michal Hocko wrote: > > On Tue 24-09-19 21:04:58, Baoquan He wrote: > > > On 09/24/19 at 02:27pm, Michal Hocko wrote: > > > > On Tue 24-09-19 19:11:51, Baoquan He wrote: > > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c >

Re: [PATCH] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule

2019-09-24 Thread Jason A. Donenfeld
On Tue, Sep 24, 2019 at 3:30 PM David Miller wrote > I'm asking you to make a non-wireguard test that triggers the problem. Oh, gotcha. No problem. > > Or would you like a situation you're interested in to break from time > to time. My test suite should catch it in the future now that it's there,

Re: [PATCH v2 00/14] dmaengine/soc: Add Texas Instruments UDMA support

2019-09-24 Thread Peter Ujfalusi
Hi, On 30/07/2019 12.34, Peter Ujfalusi wrote: > Changes since v1 > (https://patchwork.kernel.org/project/linux-dmaengine/list/?series=114105&state=*) > - Added support for j721e > - Based on 5.3-rc2 > - dropped ti_sci API patch for RM management as it is already upstream > - dropped dmadev_get_sl

Re: [PATCH RT v3 3/5] sched: migrate_dis/enable: Use rt_invol_sleep

2019-09-24 Thread Scott Wood
On Tue, 2019-09-24 at 13:21 +0200, Sebastian Andrzej Siewior wrote: > On 2019-09-23 19:52:33 [+0200], To Scott Wood wrote: > > I made dis: > > diff --git a/kernel/cpu.c b/kernel/cpu.c > index 885a195dfbe02..25afa2bb1a2cf 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -308,7 +308,9 @@ void

Re: [PATCH v2 2/3] KVM: X86: Fix userspace set broken combinations of CPUID and CR4

2019-09-24 Thread Paolo Bonzini
On 17/09/19 19:32, Sean Christopherson wrote: > > Paolo, can you provide an "official" ruling on how KVM_SET_SREGS should > interact with reserved bits? It's not at all clear from the git history > if skipping the checks was intentional or an oversight. It's okay to make it fail as long as KVM a

Re: [PATCH 1/3] dt-bindings: dma: Add documentation for DMA domains

2019-09-24 Thread Peter Ujfalusi
On 16/09/2019 14.21, Peter Ujfalusi wrote: > > > On 13/09/2019 17.36, Rob Herring wrote: >> On Tue, Sep 10, 2019 at 02:50:35PM +0300, Peter Ujfalusi wrote: >>> On systems where multiple DMA controllers available, non Slave (for example >>> memcpy operation) users can not be described in DT as

Re: + mm-thp-extract-split_queue_-into-a-struct.patch added to -mm tree

2019-09-24 Thread Michal Hocko
Do we really need this if deferred list is going to be shrunk more pro-actively as discussed already - I am sorry I do not have a link handy but in short the deferred list would be drained from a kworker context more pro-actively rather than wait for the memory pressure to happen. On Mon 23-09-19

Re: [PATCH v3] bonding: force enable lacp port after link state recovery for 802.3ad

2019-09-24 Thread David Miller
From: Date: Wed, 18 Sep 2019 21:06:20 +0800 > From: Sha Zhang > > After the commit 334031219a84 ("bonding/802.3ad: fix slave link > initialization transition states") merged, > the slave's link status will be changed to BOND_LINK_FAIL > from BOND_LINK_DOWN in the following scenario: > - Driver

[PATCH V2 7/8] virtio: introduce a mdev based transport

2019-09-24 Thread Jason Wang
This patch introduces a new mdev transport for virtio. This is used to use kernel virtio driver to drive the mediated device that is capable of populating virtqueue directly. A new virtio-mdev driver will be registered to the mdev bus, when a new virtio-mdev device is probed, it will register the

[PATCH v2] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule

2019-09-24 Thread Jason A. Donenfeld
Commit 7d9e5f422150 removed references from certain dsts, but accounting for this never translated down into the fib6 suppression code. This bug was triggered by WireGuard users who use wg-quick(8), which uses the "suppress-prefix" directive to ip-rule(8) for routing all of their internet traffic w

[PATCH 0/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-09-24 Thread Jarkko Sakkinen
commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream This backport is for v4.14 and v4.19 The backport requires non-racy behaviour from TPM 1.x sysfs code. Thus, the dependecies for that are included. NOTE: 1/3 is only needed for v4.14. Cc: linux-integr...@vger.kernel.org Cc: Greg KH Cc: Va

[PATCH 1/3] tpm: migrate pubek_show to struct tpm_buf

2019-09-24 Thread Jarkko Sakkinen
commit da379f3c1db0c9a1fd27b11d24c9894b5edc7c75 upstream Migrated pubek_show to struct tpm_buf and cleaned up its implementation. Previously the output parameter structure was declared but left completely unused. Now it is used to refer different fields of the output. We can move it to tpm-sysfs.c

[PATCH 2/3] tpm: use tpm_try_get_ops() in tpm-sysfs.c.

2019-09-24 Thread Jarkko Sakkinen
commit 2677ca98ae377517930c183248221f69f771c921 upstream Use tpm_try_get_ops() in tpm-sysfs.c so that we can consider moving other decorations (locking, localities, power management for example) inside it. This direction can be of course taken only after other call sites for tpm_transmit() have be

[PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

2019-09-24 Thread Jarkko Sakkinen
From: Vadim Sukhomlinov commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that fu

Re: INFO: rcu detected stall in sys_exit_group

2019-09-24 Thread Petr Mladek
On Fri 2019-09-20 19:22:10, Tetsuo Handa wrote: > Calling printk() people. > > On 2019/09/20 16:50, Dmitry Vyukov wrote: > >>> How it runs on top of an interrupt? > >> > >> It is not running on top of an interrupt. Its stack was dumped > >> separately. > > > > I

Re: [PATCH 1/2] x86,sched: Add support for frequency invariance

2019-09-24 Thread Peter Zijlstra
On Tue, Sep 17, 2019 at 04:27:46PM +0200, Giovanni Gherdovich wrote: > Hello Quentin, > > On Sat, 2019-09-14 at 12:57 +0200, Quentin Perret wrote: > > Hi Giovanni > > > > On Monday 09 Sep 2019 at 04:42:15 (+0200), Giovanni Gherdovich wrote: > > > +static inline long arch_scale_freq_capacity(int c

Re: [PATCH RESEND v2] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-09-24 Thread Heiher
Hi, On Mon, Sep 23, 2019 at 11:34 PM Jason Baron wrote: > > > > On 9/20/19 12:00 PM, Jason Baron wrote: > > On 9/19/19 5:24 AM, hev wrote: > >> From: Heiher > >> > >> Take the case where we have: > >> > >> t0 > >> | (ew) > >> e0 > >> | (et) > >> e1 > >>

RE: [PATCH] slab, memcontrol: undefined reference to `memcg_kmem_get_cache'

2019-09-24 Thread Mircea CIRJALIU - MELIU
> On Tue 24-09-19 08:46:48, Mircea CIRJALIU - MELIU wrote: > > Having CONFIG_MEMCG turned off causes these issues: > > mm/slub.o: In function `slab_pre_alloc_hook': > > /home/mircea/build/mm/slab.h:425: undefined reference to > `memcg_kmem_get_cache' > > mm/slub.o: In function `slab_pos

Re: [PATCH 3/3] perf, stat: Fix free memory access / memory leaks in metrics

2019-09-24 Thread Andi Kleen
> > expr__ctx_init(&pctx); > > + /* Must be first id entry */ > > + expr__add_id(&pctx, name, avg); > > hum, shouldn't u instead use strdup(name) instead of name? The cleanup loop later skips freeing the first entry. -Andi

Re: [PATCH] sched: fix migration to invalid cpu in __set_cpus_allowed_ptr

2019-09-24 Thread Dietmar Eggemann
On 9/23/19 6:06 PM, Valentin Schneider wrote: > On 23/09/2019 16:43, Dietmar Eggemann wrote: >> I'm not sure that CONFIG_DEBUG_PER_CPU_MAPS=y will help you here. >> >> __set_cpus_allowed_ptr(...) >> { >> ... >> dest_cpu = cpumask_any_and(...) >> ... >> } >> >> With: >> >> #define cpumas

RE: [PATCH 2/3] clk: let init callback return an error code

2019-09-24 Thread Jerome Brunet
On Tue 24 Sep 2019 at 13:38, Ankur Tyagi wrote: > Hi, > > I am no expert here but just looked at the patch and found few > discrepancy that I have mentioned inline. > [...] > > Aren't all functions returning 0 always? > Yes, on purpose. This patch is an API conversion to let the init() callbac

[PATCH] RDMA/iw_cgxb4: Fix an error handling path in 'c4iw_connect()'

2019-09-24 Thread Christophe JAILLET
We should jump to fail3 in order to undo the 'xa_insert_irq()' call. Signed-off-by: Christophe JAILLET --- Not sure which Fixes tag to use because of the many refactorings in this area. So I've choosen to use none :). The issue was already there in 4a740838bf44c. This commit has renamed all label

Re: [RFC] mm: Proactive compaction

2019-09-24 Thread Khalid Aziz
On 9/24/19 7:39 AM, Vlastimil Babka wrote: > On 9/20/19 1:37 AM, Nitin Gupta wrote: >> On Tue, 2019-08-20 at 10:46 +0200, Vlastimil Babka wrote: >>> >>> That's a lot of control knobs - how is an admin supposed to tune them to >>> their >>> needs? >> >> >> Yes, it's difficult for an admin to get so

general protection fault in open_rio

2019-09-24 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d9e63adc usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=1602b30360 kernel config: https://syzkaller.appspot.com/x/.

Re: [PATCH 0/6] Add the Mobiveil EP and Layerscape Gen4 EP driver support

2019-09-24 Thread Russell King - ARM Linux admin
On Mon, Sep 16, 2019 at 10:17:36AM +0800, Xiaowei Bao wrote: > This patch set are for adding Mobiveil EP driver and adding PCIe Gen4 > EP driver of NXP Layerscape platform. > > This patch set depends on: > https://patchwork.kernel.org/project/linux-pci/list/?series=159139 > > Xiaowei Bao (6): >

Re: [PATCH xfstests] overlay: Enable character device to be the base fs partition

2019-09-24 Thread Zhihao Cheng
As far as I know, _require_scratch_shutdown() is called after _overay_config_override(), at this moment, FSTYP equals to base fs. According the implementation of _require_scratch_shutdown: 3090 _require_scratch_shutdown() 3091 { 3092 [ -x src/godown ] || _notrun "src/godown executable not fou

Re: general protection fault in open_rio

2019-09-24 Thread Andrey Konovalov
On Tue, Sep 24, 2019 at 4:19 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:d9e63adc usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=1602

Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.

2019-09-24 Thread Paolo Bonzini
On 23/09/19 06:57, Jianyong Wu (Arm Technology China) wrote: >> On 19/09/19 11:46, Jianyong Wu (Arm Technology China) wrote: On 18/09/19 11:57, Jianyong Wu (Arm Technology China) wrote: > Paolo Bonzini wrote: >> This is not Y2038-safe. Please use ktime_get_real_ts64 instead, >> an

Re: [PATCH v10 0/6] mm / virtio: Provide support for unused page reporting

2019-09-24 Thread Michal Hocko
On Wed 18-09-19 10:52:25, Alexander Duyck wrote: [...] > In order to try and keep the time needed to find a non-reported page to > a minimum we maintain a "reported_boundary" pointer. This pointer is used > by the get_unreported_pages iterator to determine at what point it should > resume searching

Re: printk meeting at LPC

2019-09-24 Thread Petr Mladek
On Wed 2019-09-18 12:48:01, Steven Rostedt wrote: > On Wed, 18 Sep 2019 18:41:55 +0200 > Petr Mladek wrote: > > > Regarding SysRq. I could imagine introducing another SysRq that > > would just call panic(). I mean that it would try to flush the > > logs and reboot in the most safe way. > > You m

NACK: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-24 Thread Connor Kuehl
I'm sending a V2 with the loop removed. Thanks, Connor

[PATCH RESEND v3] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-09-24 Thread hev
From: Heiher Take the case where we have: t0 | (ew) e0 | (et) e1 | (lt) s0 t0: thread 0 e0: epoll fd 0 e1: epoll fd 1 s0: socket fd 0 ew: epoll_wait et: edge-trigger lt: level-trigger When s0 fires an event, e1 catches the event, and t

[PATCH v2] staging: rtl8188eu: remove dead code/vestigial do..while loop

2019-09-24 Thread Connor Kuehl
The local variable 'bcmd_down' is always set to true almost immediately before the do-while's condition is checked. As a result, !bcmd_down evaluates to false which short circuits the logical AND operator meaning that the second operand is never reached and is therefore dead code. Furthermore, the

Re: [PATCH V5 1/1] perf: event preserve and create across cpu hotplug

2019-09-24 Thread Mukesh Ojha
On 8/12/2019 4:12 PM, Jiri Olsa wrote: On Fri, Aug 02, 2019 at 12:16:53AM +0530, Mukesh Ojha wrote: Perf framework doesn't allow preserving CPU events across CPU hotplugs. The events are scheduled out as and when the CPU walks offline. Moreover, the framework also doesn't allow the clients to

Re: general protection fault in open_rio

2019-09-24 Thread Alan Stern
On Tue, 24 Sep 2019, Andrey Konovalov wrote: > On Tue, Sep 24, 2019 at 4:19 PM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:d9e63adc usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com/google/kasan.git usb-fuzzer

Re: [PATCH 1/4] dma: Add PTDMA Engine driver support

2019-09-24 Thread Randy Dunlap
On 9/24/19 12:31 AM, Mehta, Sanju wrote: > From: Sanjay R Mehta > > This is the driver for the AMD passthrough DMA Engine > > Signed-off-by: Sanjay R Mehta > Reviewed-by: Shyam Sundar S K > Reviewed-by: Rajesh Kumar > --- > diff --git a/drivers/dma/ptdma/Kconfig b/drivers/dma/ptdma/Kconfig >

Re: [PATCH] slab, memcontrol: undefined reference to `memcg_kmem_get_cache'

2019-09-24 Thread Michal Hocko
On Tue 24-09-19 14:08:33, Mircea CIRJALIU - MELIU wrote: > > On Tue 24-09-19 08:46:48, Mircea CIRJALIU - MELIU wrote: > > > Having CONFIG_MEMCG turned off causes these issues: > > > mm/slub.o: In function `slab_pre_alloc_hook': > > > /home/mircea/build/mm/slab.h:425: undefined reference to > >

Re: general protection fault in open_rio

2019-09-24 Thread Andrey Konovalov
On Tue, Sep 24, 2019 at 4:33 PM Alan Stern wrote: > > On Tue, 24 Sep 2019, Andrey Konovalov wrote: > > > On Tue, Sep 24, 2019 at 4:19 PM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:d9e63adc usb-fuzzer: main usb gadget fuzzer dr

[PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-24 Thread David Hildenbrand
Since commit 3f906ba23689 ("mm/memory-hotplug: switch locking to a percpu rwsem") we do a cpus_read_lock() in mem_hotplug_begin(). This was introduced to fix a potential deadlock between get_online_mems() and get_online_cpus() - the memory and cpu hotplug lock. The root issue was that build_all_zon

Re: [PATCH v2 2/2] rtc: wilco-ec: Fix license to GPL from GPLv2

2019-09-24 Thread Nick Crews
On Tue, Sep 24, 2019 at 1:55 AM Pavel Machek wrote: > > On Sun 2019-09-22 22:43:53, Alexandre Belloni wrote: > > On 22/09/2019 22:29:48+0200, Pavel Machek wrote: > > > On Mon 2019-09-16 12:12:17, Nick Crews wrote: > > > > Signed-off-by: Nick Crews > > > > --- > > > > drivers/rtc/rtc-wilco-ec.c |

Re: general protection fault in open_rio

2019-09-24 Thread Greg Kroah-Hartman
On Tue, Sep 24, 2019 at 10:33:12AM -0400, Alan Stern wrote: > On Tue, 24 Sep 2019, Andrey Konovalov wrote: > > > On Tue, Sep 24, 2019 at 4:19 PM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:d9e63adc usb-fuzzer: main usb gadget f

Re: [PATCH 1/3] dt-bindings: dma: Add documentation for DMA domains

2019-09-24 Thread Rob Herring
On Mon, Sep 16, 2019 at 6:21 AM Peter Ujfalusi wrote: > > > > On 13/09/2019 17.36, Rob Herring wrote: > > On Tue, Sep 10, 2019 at 02:50:35PM +0300, Peter Ujfalusi wrote: > >> On systems where multiple DMA controllers available, non Slave (for example > >> memcpy operation) users can not be describ

Re: [PATCH 3/3] perf, stat: Fix free memory access / memory leaks in metrics

2019-09-24 Thread Jiri Olsa
On Tue, Sep 24, 2019 at 07:08:56AM -0700, Andi Kleen wrote: > > > expr__ctx_init(&pctx); > > > + /* Must be first id entry */ > > > + expr__add_id(&pctx, name, avg); > > > > hum, shouldn't u instead use strdup(name) instead of name? > > The cleanup loop later skips freeing the first entry. aaa

Re: [PATCH] dimlib: make DIMLIB a hidden symbol

2019-09-24 Thread David Miller
From: Uwe Kleine-König Date: Fri, 20 Sep 2019 15:31:15 +0200 > According to Tal Gilboa the only benefit from DIM comes from a driver > that uses it. So it doesn't make sense to make this symbol user visible, > instead all drivers that use it should select it (as is already the case > AFAICT). >

Re: [PATCH v8 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2019-09-24 Thread Dan Murphy
Rob On 9/23/19 4:42 PM, Jacek Anaszewski wrote: Dan, On 9/23/19 5:28 PM, Dan Murphy wrote: Jacek On 9/21/19 10:13 AM, Jacek Anaszewski wrote: Dan, On 9/20/19 7:41 PM, Dan Murphy wrote: Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 RGB LE

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-24 Thread Michal Hocko
On Tue 24-09-19 16:36:15, David Hildenbrand wrote: > Since commit 3f906ba23689 ("mm/memory-hotplug: switch locking to a percpu > rwsem") we do a cpus_read_lock() in mem_hotplug_begin(). This was > introduced to fix a potential deadlock between get_online_mems() and > get_online_cpus() - the memory

Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI

2019-09-24 Thread David Miller
From: Eugene Syromiatnikov Date: Fri, 20 Sep 2019 17:41:47 +0200 > As of now, it's a bit difficult to use SMC protocol, as significant part > of definitions related to it are defined in private headers and are not > part of UAPI. The following commits move some definitions to UAPI, > making them

Re: [rcu:dev.2019.09.23a 65/77] kernel//rcu/tree.c:2770:3: error: implicit declaration of function 'kfree'; did you mean 'kvfree'?

2019-09-24 Thread Paul E. McKenney
On Tue, Sep 24, 2019 at 10:21:54AM +0800, kbuild test robot wrote: > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > dev.2019.09.23a > head: 97de53b94582c208ee239178b208b8e8b9472585 > commit: 06b68648e6084488b79de47a2cfa307a1b9668b9 [65/77] rcu: Remove

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-24 Thread David Hildenbrand
On 24.09.19 16:48, Michal Hocko wrote: > On Tue 24-09-19 16:36:15, David Hildenbrand wrote: >> Since commit 3f906ba23689 ("mm/memory-hotplug: switch locking to a percpu >> rwsem") we do a cpus_read_lock() in mem_hotplug_begin(). This was >> introduced to fix a potential deadlock between get_online_

[PATCH] dt-bindings: sound: Convert Samsung Exynos5433 TM2(E) audio complex with WM5110 codec to dt-schema

2019-09-24 Thread Marek Szyprowski
From: Maciej Falkowski Convert Samsung Exynos5433 TM2(E) audio complex with WM5110 codec to newer dt-schema format. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- .../bindings/sound/samsung,tm2-audio.txt | 42 -- .../bindings/sound/samsung,tm2-audio.yaml

Re: [rcu:dev.2019.09.23a 61/77] htmldocs: kernel/rcu/tree.c:2706: warning: Function parameter or member 'krcp' not described in 'kfree_rcu_cpu_work'

2019-09-24 Thread Paul E. McKenney
On Tue, Sep 24, 2019 at 10:24:24AM +0800, kbuild test robot wrote: > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > dev.2019.09.23a > head: 97de53b94582c208ee239178b208b8e8b9472585 > commit: 3cc794ad18bfc6e46d58411b53f2784388d5bb85 [61/77] rcu: Add mu

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-24 Thread Qian Cai
On Tue, 2019-09-24 at 16:36 +0200, David Hildenbrand wrote: > Since commit 3f906ba23689 ("mm/memory-hotplug: switch locking to a percpu > rwsem") we do a cpus_read_lock() in mem_hotplug_begin(). This was > introduced to fix a potential deadlock between get_online_mems() and > get_online_cpus() - th

Re: [PATCH v2 2/4] mm, page_owner: record page owner for each subpage

2019-09-24 Thread Vlastimil Babka
On 9/24/19 1:31 PM, Kirill A. Shutemov wrote: > On Tue, Aug 20, 2019 at 03:18:26PM +0200, Vlastimil Babka wrote: >> Currently, page owner info is only recorded for the first page of a >> high-order >> allocation, and copied to tail pages in the event of a split page. With the >> plan to keep previ

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-24 Thread Michal Hocko
On Tue 24-09-19 11:03:21, Qian Cai wrote: [...] > While at it, it might be a good time to rethink the whole locking over there, > as > it right now read files under /sys/kernel/slab/ could trigger a possible > deadlock anyway. > [...] > [  442.452090][ T5224] -> #0 (mem_hotplug_lock.rw_sem){}

Re: [PATCH] ACPICA: Introduce acpi_load_table_with_index()

2019-09-24 Thread Andy Shevchenko
On Mon, Sep 23, 2019 at 11:47:01AM +0200, Nikolaus Voss wrote: > For unloading an ACPI table, it is necessary to provide the > index of the table. The method intended for dynamically > loading or hotplug addition of tables, acpi_load_table(), > does not provide this information, so a new function >

Re: [PATCH v2 4/4] mm, page_owner, debug_pagealloc: save and dump freeing stack trace

2019-09-24 Thread Vlastimil Babka
On 9/24/19 1:42 PM, Kirill A. Shutemov wrote: >> --- a/mm/page_owner.c >> +++ b/mm/page_owner.c >> @@ -24,6 +24,9 @@ struct page_owner { >> short last_migrate_reason; >> gfp_t gfp_mask; >> depot_stack_handle_t handle; >> +#ifdef CONFIG_DEBUG_PAGEALLOC >> +depot_stack_handle_t fre

Re: [PATCH v2 2/4] mm, page_owner: record page owner for each subpage

2019-09-24 Thread Kirill A. Shutemov
On Tue, Sep 24, 2019 at 05:10:59PM +0200, Vlastimil Babka wrote: > On 9/24/19 1:31 PM, Kirill A. Shutemov wrote: > > On Tue, Aug 20, 2019 at 03:18:26PM +0200, Vlastimil Babka wrote: > >> Currently, page owner info is only recorded for the first page of a > >> high-order > >> allocation, and copied

[PATCH] MIPS: init: Fix reservation of memory between PHYS_OFFSET and mem start

2019-09-24 Thread Thomas Bogendoerfer
Fix calculation of the size for reserving memory between PHYS_OFFSET and real memory start. Fixes: a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") Signed-off-by: Thomas Bogendoerfer --- arch/mips/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/kernel/s

Re: [PATCH RESEND v2] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

2019-09-24 Thread Jason Baron
On 9/24/19 10:06 AM, Heiher wrote: > Hi, > > On Mon, Sep 23, 2019 at 11:34 PM Jason Baron wrote: >> >> >> >> On 9/20/19 12:00 PM, Jason Baron wrote: >>> On 9/19/19 5:24 AM, hev wrote: From: Heiher Take the case where we have: t0 | (ew)

Re: [PATCH] dt-bindings: sound: Convert Samsung Exynos5433 TM2(E) audio complex with WM5110 codec to dt-schema

2019-09-24 Thread Krzysztof Kozlowski
On Tue, Sep 24, 2019 at 05:01:46PM +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > Convert Samsung Exynos5433 TM2(E) audio complex with WM5110 codec to newer > dt-schema format. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Marek Szyprowski > --- > .../bindings/sound/samsu

Re: [PATCH v10 0/6] mm / virtio: Provide support for unused page reporting

2019-09-24 Thread Alexander Duyck
On Tue, Sep 24, 2019 at 7:23 AM Michal Hocko wrote: > > On Wed 18-09-19 10:52:25, Alexander Duyck wrote: > [...] > > In order to try and keep the time needed to find a non-reported page to > > a minimum we maintain a "reported_boundary" pointer. This pointer is used > > by the get_unreported_pages

[PATCH] MIPS: init: Prevent adding memory before PHYS_OFFSET

2019-09-24 Thread Thomas Bogendoerfer
On some SGI machines (IP28 and IP30) a small region of memory is mirrored to pyhsical address 0 for exception vectors while rest of the memory is reachable at a higher physical address. ARC PROM marks this region as reserved, but with commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") this chunk

Re: [PATCH v1] mm/memory_hotplug: Don't take the cpu_hotplug_lock

2019-09-24 Thread David Hildenbrand
On 24.09.19 17:03, Qian Cai wrote: > On Tue, 2019-09-24 at 16:36 +0200, David Hildenbrand wrote: >> Since commit 3f906ba23689 ("mm/memory-hotplug: switch locking to a percpu >> rwsem") we do a cpus_read_lock() in mem_hotplug_begin(). This was >> introduced to fix a potential deadlock between get_on

Re: [PATCH v2 4/4] mm, page_owner, debug_pagealloc: save and dump freeing stack trace

2019-09-24 Thread Kirill A. Shutemov
On Tue, Sep 24, 2019 at 05:15:01PM +0200, Vlastimil Babka wrote: > On 9/24/19 1:42 PM, Kirill A. Shutemov wrote: > >> --- a/mm/page_owner.c > >> +++ b/mm/page_owner.c > >> @@ -24,6 +24,9 @@ struct page_owner { > >>short last_migrate_reason; > >>gfp_t gfp_mask; > >>depot_stack_handle_t h

Re: [PATCH RT v3 3/5] sched: migrate_dis/enable: Use rt_invol_sleep

2019-09-24 Thread Sebastian Andrzej Siewior
On 2019-09-24 08:53:43 [-0500], Scott Wood wrote: > As I pointed out in the "[PATCH RT 6/8] sched: migrate_enable: Set state to > TASK_RUNNING" discussion, we can get here inside the rtmutex code (e.g. from > debug_rt_mutex_print_deadlock) where saved_state is already holding > something -- plus, t

Re: NACK: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step

2019-09-24 Thread Dan Carpenter
This email is fine, but I just want to make sure that you don't think it's required. We all assumed that you would send a v2. I sort of hate the word NACK as well because it sounds like shouting or ducks and those are my two pet peeves. Sometimes people send a v2 patch without any replies to th

[PATCH v3] mfd: mt6360: add pmic mt6360 driver

2019-09-24 Thread Gene Chen
From: Gene Chen Add mfd driver for mt6360 pmic chip include Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck Signed-off-by: Gene Chen +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +/* reg 0 -> 0 ~ 7 */ +#define MT6360_CHG_TREG_EVT

Re: [PATCH v22 01/24] x86/cpufeatures: x86/msr: Add Intel SGX hardware bits

2019-09-24 Thread Borislav Petkov
On Tue, Sep 03, 2019 at 05:26:32PM +0300, Jarkko Sakkinen wrote: > diff --git a/arch/x86/include/asm/cpufeatures.h > b/arch/x86/include/asm/cpufeatures.h > index 998c2cc08363..c5582e766121 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -222,12 +22

Re: [Tree, v2] De-clutter the top level directory, move ipc/ => kernel/ipc/, samples/ => Documentation/samples/ and sound/ => drivers/sound/

2019-09-24 Thread Eric W. Biederman
Ingo Molnar writes: > - Split it into finer grained steps (3 instead of 2 patches per >movement), for easier review and bisection testing: > > toplevel: Move ipc/ to kernel/ipc/: move the files > toplevel: Move ipc/ to kernel/ipc/: adjust the build system > toplevel: Move ipc

Re: [PATCH v8 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-24 Thread Jia He
Hi Catalin On 2019/9/24 18:33, Catalin Marinas wrote: On Tue, Sep 24, 2019 at 06:43:06AM +, Justin He (Arm Technology China) wrote: Catalin Marinas wrote: On Sat, Sep 21, 2019 at 09:50:54PM +0800, Jia He wrote: @@ -2151,21 +2163,53 @@ static inline void cow_user_page(struct page *dst, s

[PATCH] KVM: CPUID: Fix IA32_XSS support in CPUID(0xd,i) enumeration

2019-09-24 Thread Yang Weijiang
The control bits in IA32_XSS MSR are being used for new features, but current CPUID(0xd,i) enumeration code doesn't support them, so fix existing code first. The supervisor states in IA32_XSS haven't been used in public KVM code, so set KVM_SUPPORTED_XSS to 0 now, anyone who's developing IA32_XSS

Re: [GIT PULL] MIPS changes

2019-09-24 Thread Linus Torvalds
On Tue, Sep 24, 2019 at 5:40 AM David Howells wrote: > > Linus Torvalds wrote: > > > In honesty, I actually do have one warning in my tree: > > > > samples/vfs/test-statx.c:24:15: warning: ‘struct foo’ declared > > inside parameter list > > Were there any note lines from the compiler associated

Re: [PATCH v10 0/6] mm / virtio: Provide support for unused page reporting

2019-09-24 Thread David Hildenbrand
On 24.09.19 16:23, Michal Hocko wrote: > On Wed 18-09-19 10:52:25, Alexander Duyck wrote: > [...] >> In order to try and keep the time needed to find a non-reported page to >> a minimum we maintain a "reported_boundary" pointer. This pointer is used >> by the get_unreported_pages iterator to determ

[PATCH] ASoC: sdm845: remove unnecessary goto

2019-09-24 Thread Chetan Kankotiya
There is no specific handling in the error path of sdm845_tdm_snd_hw_params, remove the unnecessary goto and label. As there is no specific handling in error path return with error code directly. Signed-off-by: Chetan Kankotiya --- sound/soc/qcom/sdm845.c | 11 +-- 1 file changed, 5 inse

[PATCH 0/7] clk: meson: axg-audio: add sm1 support

2019-09-24 Thread Jerome Brunet
The purpose of this patchset is to add the sm1 support to the amlogic audio clock controller. The line count is lot higher than what I hoped for. Even if extremely similar, there is a shift in the register address on the sm1 which makes a bit of a mess. I could have patched the address on the fly

[PATCH 2/7] dt-bindings: clock: meson: add sm1 resets to the axg-audio controller

2019-09-24 Thread Jerome Brunet
Add the reset id of the sm1 audio clock controller Signed-off-by: Jerome Brunet --- .../reset/amlogic,meson-g12a-audio-reset.h| 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-audio-reset.h b/include/dt-bindings/reset/amlog

[PATCH 3/7] clk: meson: axg-audio: remove useless defines

2019-09-24 Thread Jerome Brunet
Defining the number of each input type is no longer necessary since we are not using the clk-input hack anymore Fixes: 282420eed23f ("clk: meson: axg-audio: migrate to the new parent description method") Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg-audio.c | 4 1 file changed, 4

[PATCH 7/7] clk: meson: axg_audio: add sm1 support

2019-09-24 Thread Jerome Brunet
Add sm1 support the axg audio clock controllers. This new version is indeed derived from the previous generation, as always, adding a few new clocks to the mix. The number of gates now exceeds 32 and do not fit in a single register. Unfortunately, designers chose to introduce the new gate register

[PATCH 4/7] clk: meson: axg-audio: fix regmap last register

2019-09-24 Thread Jerome Brunet
Since the addition of the g12a, the last register is AUDIO_CLK_SPDIFOUT_B_CTRL. Fixes: 075001385c66 ("clk: meson: axg-audio: add g12a support") Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg-audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/meson/axg

[PATCH 6/7] clk: meson: axg-audio: provide clk top signal name

2019-09-24 Thread Jerome Brunet
The peripheral clock on the sm1 goes through some muxes and dividers before reaching the audio gates. To model that, without repeating our self too much, the "top" clock signal is introduced and will serve as a the parent of the gates. On the axg and g12a, the top clock is just a pass-through to t

[PATCH 1/7] dt-bindings: clk: axg-audio: add sm1 bindings

2019-09-24 Thread Jerome Brunet
Add the compatible and clock ids of the sm1 audio clock controller Signed-off-by: Jerome Brunet --- .../bindings/clock/amlogic,axg-audio-clkc.txt | 3 ++- include/dt-bindings/clock/axg-audio-clkc.h | 10 ++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --gi

[PATCH 5/7] clk: meson: axg-audio: prepare sm1 addition

2019-09-24 Thread Jerome Brunet
Rearrange the macro definition of the clocks of the axg-audio controller. Also, the sm1 variant will feature tiny modification of different blocks in this controller. Because of that, we need to fallback to the old way of defining parent for some of the clocks, using signal name. Signed-off-by: Je

Re: [PATCH] mfd: mt6360: add pmic mt6360 driver

2019-09-24 Thread Gene Chen
2019-09-19 15:18 GMT+08:00, Lee Jones : > On Thu, 19 Sep 2019, Gene Chen wrote: > >> Lee Jones 於 2019年9月18日 週三 下午6:51寫道: >> > >> > On Wed, 18 Sep 2019, Gene Chen wrote: >> > >> > > From: Gene Chen >> > > >> > > Add mfd driver for mt6360 pmic chip include >> > > Battery Charger/USB_PD/Flash LED/RG

Re: [PATCH v2] media: vimc: fla: Add virtual flash subdevice

2019-09-24 Thread Dafna Hirschfeld
Hi, On Sun, 2019-09-15 at 15:44 -0300, Lucas A. M. Magalhães wrote: > From: Lucas A. M. Magalhaes > > Add a virtual subdevice to simulate the flash control API. > Those are the supported controls: > v4l2-ctl -d /dev/v4l-subdev6 -L > Flash Controls > >led_mode 0x009c0901

Re: [PATCH v4 05/10] mm: Return faster for non-fatal signals in user mode faults

2019-09-24 Thread Matthew Wilcox
On Tue, Sep 24, 2019 at 11:19:08AM +0800, Peter Xu wrote: > On Mon, Sep 23, 2019 at 07:54:47PM -0700, Matthew Wilcox wrote: > > On Tue, Sep 24, 2019 at 10:47:21AM +0800, Peter Xu wrote: > > > On Mon, Sep 23, 2019 at 11:03:49AM -0700, Linus Torvalds wrote: > > > > On Sun, Sep 22, 2019 at 9:26 PM Pet

Re: [PATCH RT v3 3/5] sched: migrate_dis/enable: Use rt_invol_sleep

2019-09-24 Thread Scott Wood
On Tue, 2019-09-24 at 17:25 +0200, Sebastian Andrzej Siewior wrote: > On 2019-09-24 08:53:43 [-0500], Scott Wood wrote: > > As I pointed out in the "[PATCH RT 6/8] sched: migrate_enable: Set state > > to > > TASK_RUNNING" discussion, we can get here inside the rtmutex code (e.g. > > from > > debug_

Re: [PATCH v10 0/6] mm / virtio: Provide support for unused page reporting

2019-09-24 Thread Nitesh Narayan Lal
On 9/24/19 11:32 AM, David Hildenbrand wrote: > On 24.09.19 16:23, Michal Hocko wrote: >> On Wed 18-09-19 10:52:25, Alexander Duyck wrote: >> [...] >>> In order to try and keep the time needed to find a non-reported page to >>> a minimum we maintain a "reported_boundary" pointer. This pointer is

Re: [PATCH 0/6] Add the Mobiveil EP and Layerscape Gen4 EP driver support

2019-09-24 Thread Russell King - ARM Linux admin
On Tue, Sep 24, 2019 at 03:18:47PM +0100, Russell King - ARM Linux admin wrote: > On Mon, Sep 16, 2019 at 10:17:36AM +0800, Xiaowei Bao wrote: > > This patch set are for adding Mobiveil EP driver and adding PCIe Gen4 > > EP driver of NXP Layerscape platform. > > > > This patch set depends on: > >

<    1   2   3   4   5   6   7   8   9   >