KASAN: use-after-free Write in iowarrior_disconnect

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=168ec15660 kernel config: https://syzkaller.appspot.com/x/.

[PATCH v1 3/3] clk: rockchip: Add clock controller for the RK3308

2019-09-03 Thread Finley Xiao
Add the clock tree definition for the new RK3308 SoC. Signed-off-by: Finley Xiao --- drivers/clk/rockchip/Makefile | 1 + drivers/clk/rockchip/clk-rk3308.c | 955 ++ drivers/clk/rockchip/clk.h| 13 + 3 files changed, 969 insertions(+) create mo

KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=174761b660 kernel config: https://syzkaller.appspot.com/x/.

general protection fault in usb_autopm_put_interface

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=165e551e60 kernel config: https://syzkaller.appspot.com/x/.

[PATCH v1 1/3] dt-bindings: Add bindings for rk3308 clock controller

2019-09-03 Thread Finley Xiao
Add devicetree bindings for Rockchip cru which found on Rockchip SoCs. Signed-off-by: Finley Xiao --- .../devicetree/bindings/clock/rockchip,rk3308.txt | 58 ++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3308.txt

WARNING: ODEBUG bug in usbhid_disconnect (2)

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=173983ac60 kernel config: https://syzkaller.appspot.com/x/.

general protection fault in pk_probe

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=14c3589e60 kernel config: https://syzkaller.appspot.com/x/.

WARNING: ODEBUG bug in appledisplay_probe

2019-09-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=101b49ea60 kernel config: https://syzkaller.appspot.com/x/.

[PATCH -next] media: max2175: Fix build error without CONFIG_REGMAP_I2C

2019-09-03 Thread YueHaibing
If CONFIG_REGMAP_I2C is not set, building fails: drivers/media/i2c/max2175.o: In function `max2175_probe': max2175.c:(.text+0x1404): undefined reference to `__devm_regmap_init_i2c' Select REGMAP_I2C to fix this. Reported-by: Hulk Robot Fixes: b47b79d8a231 ("[media] media: i2c: max2175: Add MAX2

[PATCH -next] usb: typec: tps6598x: Fix build error without CONFIG_REGMAP_I2C

2019-09-03 Thread YueHaibing
If CONFIG_REGMAP_I2C is not set, building fails: drivers/usb/typec/tps6598x.o: In function `tps6598x_probe': tps6598x.c:(.text+0x5f0): undefined reference to `__devm_regmap_init_i2c' Select REGMAP_I2C to fix this. Reported-by: Hulk Robot Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x

Re: [PATCH 5/6] dt-bindings: timer: renesas: tmu: Document r8a774a1 bindings

2019-09-03 Thread Geert Uytterhoeven
Hi Daniel, On Mon, Sep 2, 2019 at 10:42 AM Daniel Lezcano wrote: > On 02/09/2019 10:39, Geert Uytterhoeven wrote: > > On Mon, Sep 2, 2019 at 10:32 AM Simon Horman wrote: > >> On Fri, Aug 30, 2019 at 10:37:54AM +, Fabrizio Castro wrote: > >>> This patch has been reviewed by Geert, Simon, and

[PATCH] befs: Delete an unnecessary check before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 14:04:05 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/befs/btr

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread Matthew Wilcox
On Tue, Sep 03, 2019 at 01:57:48PM +0200, Michal Hocko wrote: > On Mon 02-09-19 03:23:40, William Kucharski wrote: > > Add an 'order' argument to __page_cache_alloc() and > > do_read_cache_page(). Ensure the allocated pages are compound pages. > > Why do we need to touch all the existing callers a

Re: [PATCH] regmap: fix writes to non incrementing registers

2019-09-03 Thread Mark Brown
On Tue, Sep 03, 2019 at 10:42:59AM +0100, Ben Whitten wrote: > You mentioned that we likely have breakage elsewhere, I believe that > regmap_noinc_write probably shouldn't ever have been calling > _regmap_raw_write. > Whilst regmap_noinc_read calls _regmap_raw_read, this function doesn't > do any

Re: general protection fault in usb_autopm_put_interface

2019-09-03 Thread Andrey Konovalov
On Tue, Sep 3, 2019 at 2:08 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=165e5

Re: KASAN: use-after-free Read in usbhid_close

2019-09-03 Thread Andrey Konovalov
On Tue, Sep 3, 2019 at 2:08 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=140a7

Re: KASAN: use-after-free Write in usbhid_open

2019-09-03 Thread Andrey Konovalov
On Tue, Sep 3, 2019 at 2:08 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=16ab9

Re: KASAN: use-after-free Write in iowarrior_disconnect

2019-09-03 Thread Andrey Konovalov
On Tue, Sep 3, 2019 at 2:08 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=168ec

Re: [PATCH v5 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP

2019-09-03 Thread Michal Hocko
On Mon 02-09-19 03:23:41, William Kucharski wrote: > Add filemap_huge_fault() to attempt to satisfy page > faults on memory-mapped read-only text pages using THP when possible. This deserves much more description of how the thing is implemented and expected to work. For one thing it is not really

Re: WARNING: ODEBUG bug in usbhid_disconnect (2)

2019-09-03 Thread Andrey Konovalov
On Tue, Sep 3, 2019 at 2:08 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:eea39f24 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=17398

Re: [PATCH v5 1/2] mm: Allow the page cache to allocate large pages

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 05:11:55, Matthew Wilcox wrote: > On Tue, Sep 03, 2019 at 01:57:48PM +0200, Michal Hocko wrote: > > On Mon 02-09-19 03:23:40, William Kucharski wrote: > > > Add an 'order' argument to __page_cache_alloc() and > > > do_read_cache_page(). Ensure the allocated pages are compound pages.

Re: [PATCH v5 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP

2019-09-03 Thread Matthew Wilcox
On Tue, Sep 03, 2019 at 02:14:24PM +0200, Michal Hocko wrote: > On Mon 02-09-19 03:23:41, William Kucharski wrote: > > Add filemap_huge_fault() to attempt to satisfy page > > faults on memory-mapped read-only text pages using THP when possible. > > This deserves much more description of how the th

Re: [PATCH -next] usb: typec: tps6598x: Fix build error without CONFIG_REGMAP_I2C

2019-09-03 Thread Heikki Krogerus
On Tue, Sep 03, 2019 at 08:10:26PM +0800, YueHaibing wrote: > If CONFIG_REGMAP_I2C is not set, building fails: > > drivers/usb/typec/tps6598x.o: In function `tps6598x_probe': > tps6598x.c:(.text+0x5f0): undefined reference to `__devm_regmap_init_i2c' > > Select REGMAP_I2C to fix this. > > Report

[PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM

2019-09-03 Thread Safford, David (GE Global Research, US)
> > > > First, you only force the remap if the overlap is with NVS, but I > > > > have systems where the overlap is with other reserved regions. You > > > > should force the remap regardless, but if it is NVS, grab the space back > > > > from NVS. > > > > > > I didn't know about that. I just found

Re: [GIT PULL] ARM: at91: SoC for 5.4

2019-09-03 Thread Arnd Bergmann
On Sun, Aug 25, 2019 at 10:32 PM Alexandre Belloni wrote: > AT91 SoC for 5.4 > > - MAINTAINERS updates > - a generated headers parallel build fix > > > Masahiro Yamada (1): > ARM: at91: move platform-specific asm-offset.h to

[PATCH][spi-next] spi: npcm-fiu: fix spelling mistake "frequancy" -> "frequency"

2019-09-03 Thread Colin King
From: Colin Ian King There is a spelling mistake in a dev_warning message. Fix it. Also break line to clear up checkpatch warning. Signed-off-by: Colin Ian King --- drivers/spi/spi-npcm-fiu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-npcm-fiu.c b/dri

[PATCH] efs: Delete unnecessary checks before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 14:24:38 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the tests around the shown calls are not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs

[PATCH] efs: Delete unnecessary checks before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 14:24:38 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the tests around the shown calls are not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs

Re: [PATCH V3 08/10] dt-bindings: interconnect: add MT8183 interconnect dt-bindings

2019-09-03 Thread Henry Chen
On Mon, 2019-09-02 at 14:38 +0100, Rob Herring wrote: Hi Rob, > On Wed, Aug 28, 2019 at 08:28:46PM +0800, Henry Chen wrote: > > Add interconnect provider dt-bindings for MT8183. > > > > Signed-off-by: Henry Chen > > --- > > .../devicetree/bindings/soc/mediatek/dvfsrc.txt| 9 + >

Re: [PATCH] media: vimc: Implement debayer control for mean window size

2019-09-03 Thread André Almeida
Hello Arthur and Laís, Thanks for your patch! On 9/1/19 4:40 PM, Arthur Moraes do Lago wrote: > Add mean window size parameter for debayer filter as a control in > vimc-debayer. > > vimc-debayer was patched to allow changing mean windows parameter > of the filter without needing to reload the dr

Re: "fs/namei.c: keep track of nd->root refcount status" causes boot panic

2019-09-03 Thread Al Viro
On Tue, Sep 03, 2019 at 12:21:36AM -0400, Qian Cai wrote: > The linux-next commit "fs/namei.c: keep track of nd->root refcount status” > [1] causes boot panic on all > architectures here on today’s linux-next (0902). Reverted it will fix the > issue. OK, I see what's going on. Incremental to

Good Morning

2019-09-03 Thread Stella Adams
Thanks for your urgent response. My name is Stella Adams, a personal secretary to John Paul. My boss left an envelope which contain bank card worth of $800,000.00. The bank card will be used at any ATM machine across the globe. Courier delivery company will deliver the parcel to your doorstep. All

Re: [GIT PULL 3/3] ARM: dts: exynos: DT for v5.4

2019-09-03 Thread Arnd Bergmann
On Wed, Aug 21, 2019 at 9:52 AM Krzysztof Kozlowski wrote: > On Fri, 16 Aug 2019 at 18:30, Krzysztof Kozlowski wrote: > > > > Samsung DTS ARM changes for v5.4 > > > > 1. Add AHCI to Exynos5250, > > 2. Add camera and GPU power domain

Re: [PATCH] iio: imu: st_lsm6dsx: replace underscore with hyphen in device name

2019-09-03 Thread Jonathan Cameron
+CC Greg as fix for a patch in my outstanding pull request. On Tue, 3 Sep 2019 07:18:02 +0200 Martin Kepplinger wrote: > With the underscore character in the lsm9ds1_imu device name, we get the > following error below, so use a dash, just like the other device names do too. > > [3.961399] U

[PATCH] ext2: Delete an unnecessary check before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 14:40:18 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/ext2/sup

Re: [PATCH] usb: storage: Add ums-cros-aoa driver

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 12:04:03PM +0200, Oliver Neukum wrote: > Am Dienstag, den 03.09.2019, 11:19 +0200 schrieb Greg KH: > > On Tue, Sep 03, 2019 at 10:46:14AM +0200, Oliver Neukum wrote: > > > Am Montag, den 02.09.2019, 18:47 +0200 schrieb Greg KH: > > > > > > > > This should work just fine tod

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-09-03 Thread Dafna Hirschfeld
Hi, Thank you for working on the patchset. Since there is only one module now, the section in the vimc Documentation regarding module params should be changed: In the file Documentation/media/v4l-drivers/vimc.rst The following text should be removed: ``` You should pass those arguments to each s

Re: [PATCH v5 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 05:22:08, Matthew Wilcox wrote: > On Tue, Sep 03, 2019 at 02:14:24PM +0200, Michal Hocko wrote: > > On Mon 02-09-19 03:23:41, William Kucharski wrote: > > > Add filemap_huge_fault() to attempt to satisfy page > > > faults on memory-mapped read-only text pages using THP when possible

Re: [PATCH] iio: imu: st_lsm6dsx: replace underscore with hyphen in device name

2019-09-03 Thread Martin Kepplinger
On 03.09.19 14:43, Jonathan Cameron wrote: > +CC Greg as fix for a patch in my outstanding pull request. > > On Tue, 3 Sep 2019 07:18:02 +0200 > Martin Kepplinger wrote: > >> With the underscore character in the lsm9ds1_imu device name, we get the >> following error below, so use a dash, just li

Re: [PATCH 02/12] media: hantro: Do not reorder H264 scaling list

2019-09-03 Thread Philipp Zabel
On Tue, 2019-09-03 at 07:54 +, Jonas Karlman wrote: [...] > After a closer look both ffmpeg and rkmpp only apply zig-zag scan and not > field scan, > ffmpeg will memcpy the scaling_matrix4/8 as is for vaapi, vdpau and nvdec, > for dxva2 there is a workaround flag that controls if zig-zag shoul

[PATCH 1/1] Fix ARI enabling for a NVME devices

2019-09-03 Thread Andrei Leonvikov
From: Andrei Leonchikov Signed-off-by: Andrei Leonchikov --- drivers/pci/pci.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 1b27b5af3..ed5f0888c 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3149,9 +3149,12

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-09-03 Thread Shuah Khan
On 9/3/19 6:50 AM, Dafna Hirschfeld wrote: Hi, Thank you for working on the patchset. Since there is only one module now, the section in the vimc Documentation regarding module params should be changed: In the file Documentation/media/v4l-drivers/vimc.rst The following text should be removed:

[PATCH] fat: Delete an unnecessary check before brelse()

2019-09-03 Thread Markus Elfring
From: Markus Elfring Date: Tue, 3 Sep 2019 14:56:16 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/fat/dir.

Re: [RFC PATCH 2/2] livepatch: Clear relocation targets on a module removal

2019-09-03 Thread Miroslav Benes
On Mon, 2 Sep 2019, Joe Lawrence wrote: > On 9/2/19 12:13 PM, Miroslav Benes wrote: > >> I can easily foresee more problems like those in the future. Going > >> forward we have to always keep track of which special sections are > >> needed for which architectures. Those special sections can chan

Re: [PATCH -next v2] sched/fair: fix -Wunused-but-set-variable warnings

2019-09-03 Thread Qian Cai
Ingo or Peter, please take a look at this trivial patch. Still see the warning in linux-next every day. On Tue, 2019-08-20 at 14:40 -0400, Qian Cai wrote: > The linux-next commit "sched/fair: Fix low cpu usage with high > throttling by removing expiration of cpu-local slices" [1] introduced a > fe

Re: "fs/namei.c: keep track of nd->root refcount status" causes boot panic

2019-09-03 Thread Christoph Hellwig
On Tue, Sep 03, 2019 at 01:37:19PM +0100, Al Viro wrote: > On Tue, Sep 03, 2019 at 12:21:36AM -0400, Qian Cai wrote: > > The linux-next commit "fs/namei.c: keep track of nd->root refcount status” > > [1] causes boot panic on all > > architectures here on today’s linux-next (0902). Reverted it will

Re: [PATCH v2 3/6] powerpc: Convert flush_icache_range & friends to C

2019-09-03 Thread Segher Boessenkool
Hi! On Tue, Sep 03, 2019 at 03:23:57PM +1000, Alastair D'Silva wrote: > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > +#if !defined(CONFIG_PPC_8xx) & !defined(CONFIG_PPC64) Please write that as &&? That is more usual, and thus, easier to read. > +static void flush_dcache_icache_

[PATCHv5 0/4] add Intel Stratix10 remote system update driver

2019-09-03 Thread richard . gong
From: Richard Gong This is the 5th submission of Intel Stratix10 remote system update (RSU) driver. Intel Stratix10 remote system update driver patches have been reviewed by Alan Tull and other colleagues at Intel. The Intel Stratix10 Remote System Update driver exposes interfaces access throug

Re: [PATCH v4 10/11] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-09-03 Thread Petr Mladek
On Mon 2019-09-02 11:32:39, Sakari Ailus wrote: > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to > support printing full path of the node, including its name ("f") and only > the node's name ("P") in the printk family of functions. The two flags > have equivalent function

[PATCHv5 2/4] firmware: add Intel Stratix10 remote system update driver

2019-09-03 Thread richard . gong
From: Richard Gong The Intel Remote System Update (RSU) driver exposes interfaces access through the Intel Service Layer to user space via sysfs interface. The RSU interfaces report and control some of the optional RSU features on Intel Stratix 10 SoC. The RSU feature provides a way for customer

Re: [PATCH 3/3] task: Clean house now that tasks on the runqueue are rcu protected

2019-09-03 Thread Oleg Nesterov
On 09/02, Eric W. Biederman wrote: > > @@ -1644,7 +1644,7 @@ static void task_numa_compare(struct task_numa_env *env, > return; > > rcu_read_lock(); > - cur = task_rcu_dereference(&dst_rq->curr); > + cur = rcu_dereference(dst_rq->curr); > if (cur && ((cur->flags

[PATCHv5 1/4] firmware: stratix10-svc: extend svc to support new RSU features

2019-09-03 Thread richard . gong
From: Richard Gong Extend Intel Stratix10 service layer driver to support new RSU notify and MAX_RETRY with watchdog event. RSU is used to provide our customers with protection against loading bad bitstream onto their devices when those devices are booting from flash RSU notifies provides users

[PATCHv5 3/4] firmware: rsu: document sysfs interface

2019-09-03 Thread richard . gong
From: Richard Gong Describe Intel Stratix10 Remote System Update (RSU) device attributes Signed-off-by: Richard Gong Reviewed-by: Alan Tull --- v2: changed to use tab everywhere and wrap lines at 72 columns s/soc:firmware:svc:rsu/stratix10-rsu.0 added for watchdog v3: s/KernelVersion:5

Re: [PATCH v2] rtlwifi: fix non-kerneldoc comment in usb.c

2019-09-03 Thread Kalle Valo
"Valdis wrote: > Fix spurious warning message when building with W=1: > > CC [M] drivers/net/wireless/realtek/rtlwifi/usb.o > drivers/net/wireless/realtek/rtlwifi/usb.c:243: warning: Cannot understand * > on line 243 - I thought it was a doc line > drivers/net/wireless/realtek/rtlwifi/usb.c:

[PATCHv5 4/4] MAINTAINERS: add maintainer for Intel Stratix10 FW drivers

2019-09-03 Thread richard . gong
From: Richard Gong Add myself as maintainer for the newly created Intel Stratix10 firmware drivers. Signed-off-by: Richard Gong Reviewed-by: Alan Tull --- v2: removed RSU binding text file v3: no change v4: no change v5: s/richard.g...@intel.com/richard.g...@linux.intel.com --- MAINTAINERS |

[PATCH 1/4] ethtool: implement Energy Detect Powerdown support via phy-tunable

2019-09-03 Thread Alexandru Ardelean
The `phy_tunable_id` has been named `ETHTOOL_PHY_EDPD` since it looks like this feature is common across other PHYs (like EEE), and defining `ETHTOOL_PHY_ENERGY_DETECT_POWER_DOWN` seems too long. The way EDPD works, is that the RX block is put to a lower power mode, except for link-pulse detection

[PATCH 2/4] net: phy: adin: implement Energy Detect Powerdown mode via phy-tunable

2019-09-03 Thread Alexandru Ardelean
This driver becomes the first user of the kernel's `ETHTOOL_PHY_EDPD` phy-tunable feature. EDPD is also enabled by default on PHY config_init, but can be disabled via the phy-tunable control. When enabling EDPD, it's also a good idea (for the ADIN PHYs) to enable TX periodic pulses, so that in cas

[PATCH 3/4] [ethtool] ethtool: sync ethtool-copy.h: adds support for EDPD (3rd Sep 2019)

2019-09-03 Thread Alexandru Ardelean
This change syncs the `ethtool-copy.h` file with Linux net-next to add support for Energy Detect Powerdown control via phy tunable. Some formatting also changes with this sync. Signed-off-by: Alexandru Ardelean --- ethtool-copy.h | 13 + 1 file changed, 9 insertions(+), 4 deletions(

[PATCH 0/4] ethtool: implement Energy Detect Powerdown support via phy-tunable

2019-09-03 Thread Alexandru Ardelean
This patch series is actually 2 series in 1. First 2 patches implement the kernel support for controlling Energy Detect Powerdown support via phy-tunable, and the next 2 patches implement the ethtool user-space control. Hopefully, this combination of 2 series is an acceptable approach; if not, I a

[PATCH 4/4] [ethtool] ethtool: implement support for Energy Detect Power Down

2019-09-03 Thread Alexandru Ardelean
This change adds control for enabling/disabling Energy Detect Power Down mode, as well as configuring wake-up intervals for TX pulses, via the new ETHTOOL_PHY_EDPD control added in PHY tunable, in the kernel. Signed-off-by: Alexandru Ardelean --- ethtool.8.in | 28 + ethtool.c

Hello

2019-09-03 Thread John Harold
Hello get back to me urgently

Re: [PREEMPT_RT PATCH 2/3] i915: convert all irq_locks spinlocks to raw spinlocks

2019-09-03 Thread Sebastian Andrzej Siewior
On 2019-09-03 10:03:35 [+0200], To Clark Williams wrote: > anything in a brief test. What I saw however is that switching to > fullscreen while playing a video gives me ~0.5 to ~2ms latency. This is > has nothing to do with this change, I have to dig deeper… It might be > one of the preempt_disable

Re: [PATCH 1/2] dt-bindings: power: syscon-reboot: Convert bindings to json-schema

2019-09-03 Thread Rob Herring
On Tue, Sep 3, 2019 at 12:44 PM Krzysztof Kozlowski wrote: > > On Tue, 3 Sep 2019 at 11:00, Rob Herring wrote: > > > > On Tue, Sep 3, 2019 at 8:47 AM Krzysztof Kozlowski wrote: > > > > > > On Tue, 3 Sep 2019 at 09:14, Rob Herring wrote: > > > > > > > > On Mon, Sep 2, 2019 at 4:03 PM Krzysztof K

Re: [PATCH 1/1] Fix ARI enabling for a NVME devices

2019-09-03 Thread Christoph Hellwig
On Tue, Sep 03, 2019 at 12:53:15PM +, Andrei Leonvikov wrote: > + if ((dev->driver != NULL) && (strncmp(dev->driver->name, "nvme", 4) == > 0)) { > + // for NVME device this field always zero, but ARI can be > enabled > + pcie_capability_read_dword(bridge, PCI_EXP_D

Re: usb dma_mask fixups

2019-09-03 Thread Greg Kroah-Hartman
On Tue, Sep 03, 2019 at 10:46:09AM +0200, Christoph Hellwig wrote: > Hi all, > > the first patch fixes the ohci-sm501 regression that Guenther reported > due to the platform device dma_mask changes. The second one ports that > fix to another driver that works the same way. The rest cleans up > v

Re: [PATCH 1/1] mm/migrate: fix list corruption in migration of non-LRU movable pages

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 16:27:46, sunqiuyang wrote: > From: Qiuyang Sun > > Currently, after a page is migrated, it > 1) has its PG_isolated flag cleared in move_to_new_page(), and > 2) is deleted from its LRU list (cc->migratepages) in unmap_and_move(). > However, between steps 1) and 2), the page could

[PATCH] iommu: Don't use sme_active() in generic code

2019-09-03 Thread Joerg Roedel
On Tue, Sep 03, 2019 at 03:28:49PM +1000, Stephen Rothwell wrote: > Hi all, > > On Mon, 2 Sep 2019 14:26:40 + "Lendacky, Thomas" > wrote: > > Maybe we should make this mem_encrypt_active(), since this will probably > > be needed if/when an IOMMU device is eventually added to a guest, and the

Re: [RFC 08/12] media: hantro: Fix H264 decoding of field encoded content

2019-09-03 Thread Philipp Zabel
On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: > This need code cleanup and formatting > > Signed-off-by: Jonas Karlman The previous patches all work, but this patch breaks decoding of progressive content for me (i.MX8MQ with FFmpeg based on Ezequiel's branch). regards Philipp > --- >

Re: [PATCH] net/skbuff: silence warnings under memory pressure

2019-09-03 Thread Michal Hocko
On Fri 30-08-19 18:15:22, Eric Dumazet wrote: > If there is a risk of flooding the syslog, we should fix this generically > in mm layer, not adding hundred of __GFP_NOWARN all over the places. We do already ratelimit in warn_alloc. If it isn't sufficient then we can think of a different parameters

About compiler memory barrier for atomic_set/atomic_read on x86

2019-09-03 Thread Yin, Fengwei
Hi Peter, There is one question regarding following commit: commit 69d927bba39517d0980462efc051875b7f4db185 Author: Peter Zijlstra Date: Wed Apr 24 13:38:23 2019 +0200 x86/atomic: Fix smp_mb__{before,after}_atomic() Recent probing at the Linux Kernel Memory Model uncovered a 'sur

Re: [PATCH v1 0/4] cpuidle, haltpoll: governor switching on idle register

2019-09-03 Thread Joao Martins
On 9/3/19 12:39 PM, Joao Martins wrote: > Hey, > > Presented herewith a series with aims to tie in together the haltpoll > idle driver and governor, without sacrificing previous governor setups. > In addition, there are a few fixes with respect to module loading for > cpuidle-haltpoll. > > The s

[PATCH v2 1/4] cpuidle: allow governor switch on cpuidle_register_driver()

2019-09-03 Thread Joao Martins
The recently introduced haltpoll driver is largely only useful with haltpoll governor. To allow drivers to associate with a particular idle behaviour, add a @governor property to 'struct cpuidle_driver' and thus allow a cpuidle driver to switch to a *preferred* governor on idle driver registration.

[PATCH v2 3/4] cpuidle-haltpoll: return -ENODEV on modinit failure

2019-09-03 Thread Joao Martins
When a user loads cpuidle-haltpoll on a non KVM guest the module will successfully load, even though idle driver registration didn't take place. We should instead return -ENODEV signaling the user that the driver can't be loaded, like other error paths in haltpoll_init(). An example of such error

[PATCH v2 0/4] cpuidle, haltpoll: governor switching on idle register

2019-09-03 Thread Joao Martins
Hey, Presented herewith a series with aims to tie in together the haltpoll idle driver and governor, without sacrificing previous governor setups. In addition, there are a few fixes with respect to module loading for cpuidle-haltpoll. The series is organized as follows: Patch 1: Allows idle dr

Re: [PATCH] fs: omfs: Use kmemdup rather than duplicating its implementation in omfs_get_imap

2019-09-03 Thread Bob Copeland
On Tue, Sep 03, 2019 at 02:39:44PM +0800, zhong jiang wrote: > kmemdup contains the kmalloc + memcpy. hence it is better to use kmemdup > directly. Just replace it. > > Signed-off-by: zhong jiang This same patch was already sent to me by someone else and I acked it: https://lore.kernel.org/lkml

[PATCH v2 4/4] cpuidle-haltpoll: do not set an owner to allow modunload

2019-09-03 Thread Joao Martins
cpuidle-haltpoll can be built as a module to allow optional late load. Given we are setting @owner to THIS_MODULE, cpuidle will attempt to grab a module reference every time a cpuidle_device is registered -- so essentially all online cpus get a reference. This prevents for the module to be unloade

Re: [btrfs] 3ae92b3782: xfstests.generic.269.fail

2019-09-03 Thread Josef Bacik
On Tue, Sep 03, 2019 at 04:06:33PM +0800, kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-7): > > commit: 3ae92b3782182d282a92573abe95c96d34ca6e73 ("btrfs: change the minimum > global reserve size") > https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/li

[PATCH v2 2/4] cpuidle-haltpoll: set haltpoll as preferred governor

2019-09-03 Thread Joao Martins
Right now, guest current governors have the following ratings: * ladder-> 10 * teo -> 19 * menu -> 20 * haltpoll -> 21 * ladder + nohz=off -> 25 haltpoll governor got introduced and it is now the default governor given its highest rating -- wit

[PATCH v5 4/4] ftrace: Add an option for tracing console latencies

2019-09-03 Thread Viktor Rosendahl
This new trace option "console-latency" will enable the latency tracers to trace the console latencies. Previously this has always been implicitely disabled. I guess this is because they are considered to be well known and unavoidable. However, for some organizations it may nevertheless be desirab

[PATCH v5 0/4] Some new features for the preempt/irqsoff tracers

2019-09-03 Thread Viktor Rosendahl
Hello all, Changes in v5: - [PATCH 1/4]: * trace_disable_fsnotify() => latency_fsnotify_disable(), in order to avoid naming conflicts with trace points. * Using more appropriate operations for the percpu variables. * Moved around the calls to latency_fsnotify_enable/disable() a bit.

[PATCH v5 3/4] Add the latency-collector to tools

2019-09-03 Thread Viktor Rosendahl
This is a tool that is intended to work around the fact that the preemptoff, irqsoff, and preemptirqsoff tracers only work in overwrite mode. The idea is to act randomly in such a way that we do not systematically lose any latencies, so that if enough testing is done, all latencies will be captured

[PATCH v5 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-03 Thread Viktor Rosendahl
This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications through the fsnotify framework when a new latency is available. One particularly interesting use of this facility is when enabling threshold tracing, t

[PATCH v5 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-09-03 Thread Viktor Rosendahl
This burst feature enables the user to generate a burst of preempt/irqsoff latencies. This makes it possible to test whether we are able to detect latencies that systematically occur very close to each other. The maximum burst size is 10. We also create 10 identical test functions, so that we get

Re: [PATCH 1/6] usb/ohci-sm501: remove the HCD_DMA flag

2019-09-03 Thread Greg Kroah-Hartman
On Tue, Sep 03, 2019 at 10:46:10AM +0200, Christoph Hellwig wrote: > This driver doesn't support normal DMA, only direct access to its > local memory. Remove the HCD_DMA flag to properly express that fact. > > Fixes: 1e4946c4412e ("usb: add a HCD_DMA flag instead of guestimating DMA > capabiliti

Re: [PATCH] rtlwifi: remove unused variables 'RTL8712_SDIO_EFUSE_TABLE' and 'MAX_PGPKT_SIZE'

2019-09-03 Thread Kalle Valo
YueHaibing wrote: > drivers/net/wireless/realtek/rtlwifi/efuse.c:16:31: > warning: RTL8712_SDIO_EFUSE_TABLE defined but not used > [-Wunused-const-variable=] > drivers/net/wireless/realtek/rtlwifi/efuse.c:9:17: > warning: MAX_PGPKT_SIZE defined but not used [-Wunused-const-variable=] > > They

Re: [PATCH] powerpc/powernv: fix a W=1 compilation warning

2019-09-03 Thread Qian Cai
I saw Christ start to remove npu-dma.c code [1] [1] https://lore.kernel.org/linuxppc-dev/20190625145239.2759-4-...@lst.de/ Should pnv_npu_dma_set_32() be removed too? It was only called by pnv_npu_try_dma_set_bypass() but the later is not used anywhere in the kernel tree. If that is a case, I do

Re: [PATCH 1/2] dt-bindings: power: syscon-reboot: Convert bindings to json-schema

2019-09-03 Thread Krzysztof Kozlowski
On Tue, 3 Sep 2019 at 15:12, Rob Herring wrote: > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: syscon-reboot: > > {'regmap': [[9]], 'mask': [[1]], '$nodename': ['syscon-reboot'], > > 'value': [[1]], 'offset': [[1024]], 'compatible': ['syscon-reboot']} > > is valid under each of {'required':

Re: [PATCH] powerpc/powernv: fix a W=1 compilation warning

2019-09-03 Thread Christoph Hellwig
On Tue, Sep 03, 2019 at 09:29:14AM -0400, Qian Cai wrote: > I saw Christ start to remove npu-dma.c code [1] > > [1] https://lore.kernel.org/linuxppc-dev/20190625145239.2759-4-...@lst.de/ > > Should pnv_npu_dma_set_32() be removed too? > > It was only called by pnv_npu_try_dma_set_bypass() but th

Re: "fs/namei.c: keep track of nd->root refcount status" causes boot panic

2019-09-03 Thread Al Viro
On Tue, Sep 03, 2019 at 01:37:19PM +0100, Al Viro wrote: > On Tue, Sep 03, 2019 at 12:21:36AM -0400, Qian Cai wrote: > > The linux-next commit "fs/namei.c: keep track of nd->root refcount status” > > [1] causes boot panic on all > > architectures here on today’s linux-next (0902). Reverted it will

Re: Thunderbolt DP oddity on v5.2.9 on iMac 12,2

2019-09-03 Thread Mika Westerberg
On Tue, Sep 03, 2019 at 08:54:02PM +0800, Brad Campbell wrote: > On 3/9/19 7:55 pm, Mika Westerberg wrote: > > On Tue, Sep 03, 2019 at 07:11:32PM +0800, Brad Campbell wrote: > > > > I think the problem is that for some reason, probably because this is > > first generation hardware with all the bug

Re: [PATCH] rtw88: remove redundant assignment to pointer debugfs_topdir

2019-09-03 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Pointer debugfs_topdir is initialized to a value that is never read > and it is re-assigned later. The initialization is redundant and can > be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Patch applied to wire

Re: [PATCH] brcm80211: Avoid possible null-pointer dereferences in wlc_phy_radio_init_2056()

2019-09-03 Thread Kalle Valo
Jia-Ju Bai wrote: > In wlc_phy_radio_init_2056(), regs_SYN_2056_ptr, regs_TX_2056_ptr and > regs_RX_2056_ptr may be not assigned, and thus they are still NULL. > Then, they are used on lines 20042-20050: > wlc_phy_init_radio_regs(pi, regs_SYN_2056_ptr, (u16) RADIO_2056_SYN); > wlc_phy_i

[PATCH 1/2] linux/kernel.h: add yesno(), onoff(), enableddisabled(), plural() helpers

2019-09-03 Thread Jani Nikula
The kernel has plenty of ternary operators to choose between constant strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : "s": $ git grep '? "yes" : "no"' | wc -l 258 $ git grep '? "on" : "off"' | wc -l 204 $ git grep '? "enabled" : "disabled"' | wc -l 196 $ git grep '? "" : "s

[PATCH 2/2] drm: convert to use yesno(), onoff(), enableddisabled(), plural() helpers

2019-09-03 Thread Jani Nikula
THIS IS NOT FOR MERGING; DEMO FOR PREVIOUS PATCH ONLY! Further conversion should be done incrementally and by driver/subsystem. This here is the result of running the following on the below cocci patch: $ spatch --sp-file yesno.cocci --in-place --dir drivers/gpu/drm I wish I knew how to not dupl

[PATCH 1/1] s390: vfio-ap: fix warning reset not completed

2019-09-03 Thread Halil Pasic
The intention seems to be to warn once when we don't wait enough for the reset to complete. Let's use the right retry counter to accomplish that semantic. Signed-off-by: Halil Pasic --- drivers/s390/crypto/vfio_ap_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH] bcma: remove two unused variables

2019-09-03 Thread Kalle Valo
YueHaibing wrote: > drivers/bcma/driver_mips.c:70:18: warning: > ipsflag_irq_shift defined but not used [-Wunused-const-variable=] > drivers/bcma/driver_mips.c:62:18: warning: > ipsflag_irq_mask defined but not used [-Wunused-const-variable=] > > They are never used, so can be removed. > > Re

Re: [PATCH v4 11/11] lib/test_printf: Add tests for %pfw printk modifier

2019-09-03 Thread Petr Mladek
On Mon 2019-09-02 11:32:40, Sakari Ailus wrote: > Add a test for the %pfw printk modifier using software nodes. > > Signed-off-by: Sakari Ailus > Reviewed-by: Andy Shevchenko > --- > lib/test_printf.c | 37 + > 1 file changed, 37 insertions(+) > > diff --git

Re: [PATCH] brcmfmac: remove redundant assignment to pointer hash

2019-09-03 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The pointer hash is being initialized with a value that is never read > and is being re-assigned a little later on. The assignment is > redundant and hence can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Pa

Re: [PATCH] airo: fix memory leaks

2019-09-03 Thread Kalle Valo
Wenwen Wang wrote: > In proc_BSSList_open(), 'file->private_data' is allocated through kzalloc() > and 'data->rbuffer' is allocated through kmalloc(). In the following > execution, if an error occurs, they are not deallocated, leading to memory > leaks. To fix this issue, free the allocated memor

Re: [RFC 5/5] ARM: dts: omap3-beagle: make explicitly compatible to ti,omap34xx

2019-09-03 Thread Tony Lindgren
* H. Nikolaus Schaller [190902 10:56]: > Matching the ti-cpufreq driver needs to specify explicitly if > a board uses an omap34xx or omap36xx chip. > > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/omap3-beagle.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

<    1   2   3   4   5   6   7   8   9   10   >