Re: [PATCH v2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-31 Thread Miguel Ojeda
On Thu, Aug 29, 2019 at 8:13 PM Masahiro Yamada wrote: > > +# W=1 - warnings that may be relevant and does not occur too often s/does/do/ Acked-by: Miguel Ojeda Cheers, Miguel

[PATCH] net: seeq: Fix the function used to release some memory in an error handling path

2019-08-31 Thread Christophe JAILLET
In commit 99cd149efe82 ("sgiseeq: replace use of dma_cache_wback_inv"), a call to 'get_zeroed_page()' has been turned into a call to 'dma_alloc_coherent()'. Only the remove function has been updated to turn the corresponding 'free_page()' into 'dma_free_attrs()'. The error hndling path of the probe

Re: [PATCH] ARM: ARM_ERRATA_775420: Spelling s/date/data/

2019-08-31 Thread Simon Horman
On Wed, Aug 28, 2019 at 03:31:51PM +0200, Geert Uytterhoeven wrote: > Caching dates is never a good idea ;-) > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/ar

[PATCH][next] net: hns3: remove redundant assignment to pointer reg_info

2019-08-31 Thread Colin King
From: Colin Ian King Pointer reg_info is being initialized with a value that is never read and is being re-assigned a little later on. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns

[PATCH] staging: rts5208: Fix checkpath warning

2019-08-31 Thread P SAI PRASANTH
This patch fixes the following checkpath warning in file drivers/staging/rts5208/xd.c:1754 WARNING: line over 80 characters + index, offset, DMA_TO_DEVICE, chip->xd_timeout); Signed-off-by: P SAI PRASANTH --- drivers/staging/rts5208/xd.c | 3 ++- 1 file

[PATCH][smartpqi-next] scsi: smartpqi: clean up indentation of a statement

2019-08-31 Thread Colin King
From: Colin Ian King There is a statement that is indented one level too deeply, remove the tab, re-join broken line and remove some empty lines. Addresses-Coverity: ("Indentation does not match nesting") Signed-off-by: Colin Ian King --- drivers/scsi/smartpqi/smartpqi_init.c | 5 + 1 file

Re: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-08-31 Thread Simon Horman
On Thu, Aug 29, 2019 at 03:11:24PM +0200, Wolfram Sang wrote: > On Wed, Aug 28, 2019 at 04:52:20PM +0800, Zhang Rui wrote: > > On Fri, 2019-06-14 at 12:52 +0200, Daniel Lezcano wrote: > > > Hi Nathan, > > > > > > On 13/06/2019 23:12, Nathan Huckleberry wrote: > > > > Clang produces the following w

[PATCH] staging: rts5208: Fixed checkpatch warning.

2019-08-31 Thread Prakhar Sinha
This patch solves the following checkpatch.pl's messages in drivers/staging/rts5208/sd.c WARNING: line over 80 characters 4517: FILE: drivers/staging/rts5208/sd.c:4517: + sd_card->sd_lock_status &= ~(SD_UNLOCK_POW_ON | SD_SDR_RST); WARNING: line over

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-31 Thread Russell King - ARM Linux admin
On Sat, Aug 31, 2019 at 09:49:45AM +0800, Jing Xiangfeng wrote: > On 2019/8/30 21:35, Russell King - ARM Linux admin wrote: > > On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: > >> The function do_alignment can handle misaligned address for user and > >> kernel space. If it is a use

Re: [PATCH] net: seeq: Fix the function used to release some memory in an error handling path

2019-08-31 Thread Thomas Bogendoerfer
On Sat, 31 Aug 2019 09:17:51 +0200 Christophe JAILLET wrote: > In commit 99cd149efe82 ("sgiseeq: replace use of dma_cache_wback_inv"), > a call to 'get_zeroed_page()' has been turned into a call to > 'dma_alloc_coherent()'. Only the remove function has been updated to turn > the corresponding 'fr

[PATCH v3 2/2] w1: add DS2501, DS2502, DS2505 EPROM device driver

2019-08-31 Thread Thomas Bogendoerfer
Add a 1-Wire slave driver to support DS250x EPROM deivces. This slave driver attaches the devices to the NVMEM subsystem for an easy in-kernel usage. Signed-off-by: Thomas Bogendoerfer --- drivers/w1/slaves/Kconfig | 6 + drivers/w1/slaves/Makefile| 1 + drivers/w1/slaves/w1_ds250x.c

[PATCH v3 0/2] W1 drivers for devices used in SGI systems

2019-08-31 Thread Thomas Bogendoerfer
These patches add two W1 drivers. One is a driver for the W1 master in SGI ASICs, which is used in various machine starting with SGI Origin systems. The other is a W1 slave driver for Dallas/Maxim EPROM devices used in the same type of SGI machines. Changes in v3: - dropped include of asm/sn/type

[PATCH v3 1/2] w1: add 1-wire master driver for IP block found in SGI ASICs

2019-08-31 Thread Thomas Bogendoerfer
Starting with SGI Origin machines nearly every new SGI ASIC contains an 1-Wire master. They are used for attaching One-Wire prom devices, which contain information about part numbers, revision numbers, serial number etc. and MAC addresses for ethernet interfaces. This patch adds a master driver to

[PATCH] ACPICA: Namespace: fix the no brace needed warning

2019-08-31 Thread tiantao
for if else statements having single block no braces are needed fixed the following checkpatch warning WARNING: braces {} are not necessary for any arm of this statement + if (!prev_node) { [...] + } else { [...] Signed-off-by: tiantao --- drivers/acpi/acpica/nsacces

[PATCH v3 2/2] Bluetooth: btrtl: Add firmware version print

2019-08-31 Thread Alex Lu
From: Alex Lu This patch is used to print fw version for debug convenience Signed-off-by: Alex Lu --- Changes in v3 - Remove the pointless rtl: prefix in the format string Changes in v2 - Re-order the code so that no forward declaration is needed drivers/bluetooth/btrtl.c | 56 +++

[PATCH 1/2] Bluetooth: btrtl: Remove redundant prefix from calls to rtl_dev macros

2019-08-31 Thread Alex Lu
From: Alex Lu the rtl: or RTL: prefix in the string is pointless. The rtl_dev_* macros already does that. Signed-off-by: Alex Lu --- drivers/bluetooth/btrtl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c

[PATCH 2/2] Bluetooth: btrtl: Remove trailing newline from calls to rtl_dev macros

2019-08-31 Thread Alex Lu
From: Alex Lu These printing macros already add a trailing newline, so drop these unnecessary additional newlines. Signed-off-by: Alex Lu --- drivers/bluetooth/btrtl.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/bluetoot

Re: linux-next: build failure after merge of the pci tree

2019-08-31 Thread Lorenzo Pieralisi
On Sat, Aug 31, 2019 at 09:51:05AM +0530, Vidya Sagar wrote: > On 8/30/2019 6:00 PM, Bjorn Helgaas wrote: > > [+cc Krzysztof] > > > > On Thu, Aug 29, 2019 at 10:23 PM Stephen Rothwell > > wrote: > > > > > > Hi all, > > > > > > After merging the pci tree, today's linux-next build (x86_64 allmod

Re: [PATCH v2 0/4] atomic: Fixes to smp_mb__{before,after}_atomic() and mips.

2019-08-31 Thread Peter Zijlstra
On Thu, Jun 13, 2019 at 03:43:17PM +0200, Peter Zijlstra wrote: > Hi, > > This all started when Andrea Parri found a 'surprising' behaviour for x86: > > http://lkml.kernel.org/r/20190418125412.GA10817@andrea > > Basically we fail for: > > *x = 1; > atomic_inc(u); > smp_mb__a

[tip: perf/urgent] perf/x86/intel: Restrict period on Nehalem

2019-08-31 Thread tip-bot2 for Josh Hunt
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 44d3bbb6f5e501b873218142fe08cdf62a4ac1f3 Gitweb: https://git.kernel.org/tip/44d3bbb6f5e501b873218142fe08cdf62a4ac1f3 Author:Josh Hunt AuthorDate:Mon, 19 Aug 2019 19:13:31 -04:00 Committer:

[tip: perf/urgent] perf/x86/amd/ibs: Fix sample bias for dispatched micro-ops

2019-08-31 Thread tip-bot2 for Kim Phillips
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 0f4cd769c410e2285a4e9873a684d90423f03090 Gitweb: https://git.kernel.org/tip/0f4cd769c410e2285a4e9873a684d90423f03090 Author:Kim Phillips AuthorDate:Mon, 26 Aug 2019 14:57:30 -05:00 Committe

Re: [RESEND PATCH V3 3/8] perf/x86/intel: Support hardware TopDown metrics

2019-08-31 Thread Stephane Eranian
Andi, On Fri, Aug 30, 2019 at 5:31 PM Andi Kleen wrote: > > > the same manner. It would greatly simplify the kernel implementation. > > I tried that originally. It was actually more complicated. > > You can't really do deltas on raw metrics, and a lot of the perf > infrastructure is built around

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-31 Thread Jing Xiangfeng
On 2019/8/31 15:55, Russell King - ARM Linux admin wrote: > On Sat, Aug 31, 2019 at 09:49:45AM +0800, Jing Xiangfeng wrote: >> On 2019/8/30 21:35, Russell King - ARM Linux admin wrote: >>> On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: The function do_alignment can handle misa

[PATCH v2] xfs: revise function comment for xfs_trans_ail_delete

2019-08-31 Thread yu kuai
Since xfs_trans_ail_delete_bulk no longer exists, revising the comment for new function xfs_trans_ail_delete. Fix following warning: make W=1 fs/xfs/xfs_trans_ail.o fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or member 'ailp' not described in 'xfs_trans_ail_delete' fs/xfs/xfs_trans_ai

Re: [RESEND PATCH V3 3/8] perf/x86/intel: Support hardware TopDown metrics

2019-08-31 Thread Peter Zijlstra
On Thu, Aug 29, 2019 at 12:56:02PM -0400, Liang, Kan wrote: > On 8/29/2019 9:52 AM, Peter Zijlstra wrote: > > What what? The PERF_METRICS contents depends on the FIXCTR3 value ?! > > Yes. > > For current implementation, PERF_METRIC MSR is composed by four fields, > backend bound, frontend bound,

Re: [RESEND PATCH V3 3/8] perf/x86/intel: Support hardware TopDown metrics

2019-08-31 Thread Peter Zijlstra
On Wed, Aug 28, 2019 at 12:04:45PM -0700, Andi Kleen wrote: > > > NMI > > > == > > > > > > The METRICS register may be overflow. The bit 48 of STATUS register > > > will be set. If so, update all active slots and metrics events. > > > > that happen? It would be useful to get that METRIC_OVF

Re: [RESEND PATCH V3 3/8] perf/x86/intel: Support hardware TopDown metrics

2019-08-31 Thread Peter Zijlstra
On Sat, Aug 31, 2019 at 02:13:05AM -0700, Stephane Eranian wrote: > With PERF_METRICS, the delta is always since previous read. If you read > frequently enough you do not lose precision. You always loose precision, the whole fraction of 255 looses the fractional part; consider: 255 * 1 / 8 31.87

Re: [PATCH][next] zd1211rw: zd_usb: Use struct_size() helper

2019-08-31 Thread kbuild test robot
linux/commits/Gustavo-A-R-Silva/zd1211rw-zd_usb-Use-struct_size-helper/20190831-161121 config: mips-allmodconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chm

Re: [PATCH] printf: add support for printing symbolic error codes

2019-08-31 Thread kbuild test robot
/Rasmus-Villemoes/printf-add-support-for-printing-symbolic-error-codes/20190831-162013 config: x86_64-randconfig-b002-201934 (attached as .config) compiler: gcc-7 (Debian 7.4.0-11) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue

Re: [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability

2019-08-31 Thread Wolfram Sang
Hi Ray, > > With all the limitations in place, I wonder if it might be easier to > > implement an smbus_xfer callback instead? What is left that makes this > > controller more than SMBus and real I2C? > > > > Right. But what is the implication of using smbus_xfer instead of > master_xfer in our

Asus VivoBook Flip TP202NA-EH012T EMMC problem

2019-08-31 Thread Óvári
Hello, As per https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1818407/comments/26 here is an email. Information is provided at https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1818407/comments/32 Please advise what else you require. Thank you Óvári

Re: [PATCH v2 0/4] atomic: Fixes to smp_mb__{before,after}_atomic() and mips.

2019-08-31 Thread Paul Burton
Hi Peter, On Sat, Aug 31, 2019 at 11:00:55AM +0200, Peter Zijlstra wrote: > On Thu, Jun 13, 2019 at 03:43:17PM +0200, Peter Zijlstra wrote: > > Hi, > > > > This all started when Andrea Parri found a 'surprising' behaviour for x86: > > > > http://lkml.kernel.org/r/20190418125412.GA10817@andrea

[RFC PATCH v2 07/10] powerpc/8xx: split breakpoint exception

2019-08-31 Thread Christophe Leroy
Breakpoint exception is big. Split it to support future growth on exception prolog. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/head_8xx.S | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/he

[RFC PATCH v2 00/10] Enable CONFIG_VMAP_STACK on PPC32

2019-08-31 Thread Christophe Leroy
The purpose of this serie is to enable CONFIG_VMAP_STACK on PPC32. For the time being we have something working on 8xx. Further work I'm working on: - Fix stack overflow detection (doesn't work all the time yet, with the LKDTM STACK_EXHAUST test it hang). - Add support to powerpc 603 - Add suppo

[RFC PATCH v2 04/10] powerpc/8xx: Use alternative scratch registers in DTLB miss handler

2019-08-31 Thread Christophe Leroy
In preparation of handling CONFIG_VMAP_STACK, we need DTLB miss handler to use different scratch registers than other exception handlers in order to not jeopardise exception entry on stack DTLB misses. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/head_8xx.S | 28 +++---

[RFC PATCH v2 05/10] powerpc/8xx: drop exception entries for non-existing exceptions

2019-08-31 Thread Christophe Leroy
head_8xx.S has entries for all exceptions from 0x100 to 0x1f00. Several of them do not exist and are never generated by the 8xx in accordance with the documentation. Remove those entry points to make some room for future growing exception code. Signed-off-by: Christophe Leroy --- arch/powerpc/k

[RFC PATCH v2 02/10] powerpc/32: Add EXCEPTION_PROLOG_0 in head_32.h

2019-08-31 Thread Christophe Leroy
This patch creates a macro for the very first part of exception prolog, this will help when implementing CONFIG_VMAP_STACK Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/head_32.S | 4 +--- arch/powerpc/kernel/head_32.h | 9 ++--- arch/powerpc/kernel/head_8xx.S | 9 ++--- 3 fi

[RFC PATCH v2 09/10] powerpc: align stack to 2 * THREAD_SIZE with VMAP_STACK

2019-08-31 Thread Christophe Leroy
In order to ease stack overflow detection, align stack to 2 * THREAD_SIZE when using VMAP_STACK. This allow overflow detection using a single bit check. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/thread_info.h | 13 + arch/powerpc/kernel/setup_32.c | 2 +-

[RFC PATCH v2 10/10] powerpc/32: Add stack overflow detection with VMAP stack.

2019-08-31 Thread Christophe Leroy
To avoid recursive faults, stack overflow detection has to be performed before writing in the stack in exception prologs. Do it by checking the alignment. If the stack pointer alignment is wrong, it means it is pointing to the following or preceding page. Signed-off-by: Christophe Leroy --- arc

[RFC PATCH v2 08/10] powerpc/8xx: Enable CONFIG_VMAP_STACK

2019-08-31 Thread Christophe Leroy
This patch enables CONFIG_VMAP_STACK. For that, a few changes are done in head_8xx.S. Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig | 1 + arch/powerpc/kernel/head_8xx.S | 47 +- 2 files changed, 47 insertions(+), 1 deletion(-) diff

[RFC PATCH v2 06/10] powerpc/8xx: move DataStoreTLBMiss perf handler

2019-08-31 Thread Christophe Leroy
Move DataStoreTLBMiss perf handler in order to cope with future growing exception prolog. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/head_8xx.S | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerp

[RFC PATCH v2 01/10] powerpc/32: replace MTMSRD() by mtmsr

2019-08-31 Thread Christophe Leroy
On PPC32, MTMSRD() is simply defined as mtmsr. Replace MTMSRD(reg) by mtmsr reg in files dedicated to PPC32, this makes the code less obscure. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/entry_32.S | 18 +- arch/powerpc/kernel/head_32.h | 4 ++-- 2 files changed, 1

[RFC PATCH v2 03/10] powerpc/32: prepare for CONFIG_VMAP_STACK

2019-08-31 Thread Christophe Leroy
To support CONFIG_VMAP_STACK, the kernel has to activate Data MMU Translation for accessing the stack. Before doing that it must save SRR0, SRR1 and DAR in order to not loose them in case there is a Data TLB Miss once the translation is reactivated. This patch defines fields in the thread struct f

Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

2019-08-31 Thread Valdis Klētnieks
On Fri, 30 Aug 2019 23:46:16 -0700, Christoph Hellwig said: > Since when did Linux kernel submissions become "show me a better patch" > to reject something obviously bad? Well, do you even have a *suggestion* for a better idea? Other than "just rip it out"? Keeping in mind that: > As I said th

Re: [PATCH] staging: exfat: remove redundant goto

2019-08-31 Thread Valdis Klētnieks
On Fri, 30 Aug 2019 19:15:23 +0100, Colin King said: > From: Colin Ian King > > The goto after a return is never executed, so it is redundant and can > be removed. > > Addresses-Coverity: ("Structurally dead code") > Signed-off-by: Colin Ian King Good catch > - if (dentry < -1) { > +

Re: [PATCH] staging: exfat: add exfat filesystem code to staging

2019-08-31 Thread Valdis Klētnieks
On Sat, 31 Aug 2019 07:54:10 +1000, Dave Chinner said: > The correct place for new filesystem review is where all the > experienced filesystem developers hang out - that's linux-fsdevel, > not the driver staging tree. So far everything's been cc'ed to linux-fsdevel, which has been spending more t

Re: [PATCH] ext4 crypto: fix to check feature status before get policy

2019-08-31 Thread Chao Yu
Hi, Is this change not necessary? A month has passed... Thanks, On 2019/8/4 17:56, Chao Yu wrote: > From: Chao Yu > > When getting fscrypto policy via EXT4_IOC_GET_ENCRYPTION_POLICY, if > encryption feature is off, it's better to return EOPNOTSUPP instead > of ENODATA, so let's add ext4_has_fe

RE: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread maowenan
[] skb_peek_tail include/linux/skbuff.h:1516 [inline] [] tcp_write_queue_tail include/net/tcp.h:1478 [inline] [] tcp_rtx_queue_tail include/net/tcp.h:1543 [inline] [] tcp_fragment+0xc64/0xce8 net/ipv4/tcp_output.c:1175 [] tcp_write_wakeup+0x3f8/0x4a0 net/ipv4/tcp_output.c:3496 [] tcp_send_probe0+0x

[for-linus][PATCH 7/7] tracing: Correct kdoc formats

2019-08-31 Thread Steven Rostedt
From: Jakub Kicinski Fix the following kdoc warnings: kernel/trace/trace.c:1579: warning: Function parameter or member 'tr' not described in 'update_max_tr_single' kernel/trace/trace.c:1579: warning: Function parameter or member 'tsk' not described in 'update_max_tr_single' kernel/trace/trace.

[for-linus][PATCH 6/7] ftrace/x86: Remove mcount() declaration

2019-08-31 Thread Steven Rostedt
From: Jisheng Zhang Commit 562e14f72292 ("ftrace/x86: Remove mcount support") removed the support for using mcount, so we could remove the mcount() declaration to clean up. Link: http://lkml.kernel.org/r/20190826170150.10f101ba@xhacker.debian Signed-off-by: Jisheng Zhang Signed-off-by: Steven

Recall: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread maowenan
maowenan would like to recall the message, "[PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue".

[for-linus][PATCH 0/7] tracing: Updates for 5.3

2019-08-31 Thread Steven Rostedt
Various fixes for tracing. Denis Efremov (1): tracing: Make exported ftrace_set_clr_event non-static Jakub Kicinski (1): tracing: Correct kdoc formats Jisheng Zhang (1): ftrace/x86: Remove mcount() declaration Naveen N. Rao (2): ftrace: Fix NULL pointer dereference in t

[for-linus][PATCH 1/7] ftrace: Fix NULL pointer dereference in t_probe_next()

2019-08-31 Thread Steven Rostedt
From: "Naveen N. Rao" LTP testsuite on powerpc results in the below crash: Unable to handle kernel paging request for data at address 0x Faulting instruction address: 0xc029d800 Oops: Kernel access of bad area, sig: 11 [#1] LE SMP NR_CPUS=2048 NUMA PowerNV ... CPU: 68

[for-linus][PATCH 5/7] tracing/probe: Fix null pointer dereference

2019-08-31 Thread Steven Rostedt
From: Xinpeng Liu BUG: KASAN: null-ptr-deref in trace_probe_cleanup+0x8d/0xd0 Read of size 8 at addr by task syz-executor.0/9746 trace_probe_cleanup+0x8d/0xd0 free_trace_kprobe.part.14+0x15/0x50 alloc_trace_kprobe+0x23e/0x250 Link: http://lkml.kernel.org/r/1565220563-980-1-git-

[for-linus][PATCH 3/7] ftrace: Check for successful allocation of hash

2019-08-31 Thread Steven Rostedt
From: "Naveen N. Rao" In register_ftrace_function_probe(), we are not checking the return value of alloc_and_copy_ftrace_hash(). The subsequent call to ftrace_match_records() may end up dereferencing the same. Add a check to ensure this doesn't happen. Link: http://lkml.kernel.org/r/26e92574f25

[for-linus][PATCH 4/7] tracing: Make exported ftrace_set_clr_event non-static

2019-08-31 Thread Steven Rostedt
From: Denis Efremov The function ftrace_set_clr_event is declared static and marked EXPORT_SYMBOL_GPL(), which is at best an odd combination. Because the function was decided to be a part of API, this commit removes the static attribute and adds the declaration to the header. Link: http://lkml.k

[for-linus][PATCH 2/7] ftrace: Check for empty hash and comment the race with registering probes

2019-08-31 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The race between adding a function probe and reading the probes that exist is very subtle. It needs a comment. Also, the issue can also happen if the probe has has the EMPTY_HASH as its func_hash. Cc: sta...@vger.kernel.org Fixes: 7b60f3d876156 ("ftrace: Dynamical

[GIT PULL] tracing: Various tracing fixes

2019-08-31 Thread Steven Rostedt
Linus, Small fixes and minor cleanups for Tracing - Make exported ftrace function not static - Fix NULL pointer dereference in reading probes as they are created - Fix NULL pointer dereference in k/uprobe clean up path - Various documentation fixes Please pull the latest trace-v5.3-rc6 tr

Re: [alsa-devel] [PATCH 2/3] ASoC: es8316: Add clock control of MCLK

2019-08-31 Thread Katsuhiro Suzuki
Hello Mark, On 2019/08/30 20:18, Mark Brown wrote: On Fri, Aug 30, 2019 at 02:32:04AM +0900, Katsuhiro Suzuki wrote: + es8316->mclk = devm_clk_get(component->dev, "mclk"); + if (PTR_ERR(es8316->mclk) == -EPROBE_DEFER) + return -EPROBE_DEFER; If we don't get a clock

Re: [PATCH v3 06/11] wimax/i2400m: remove unlikely() from WARN*() condition

2019-08-31 Thread Markus Elfring
pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0); - if (unlikely(WARN_ON(pad_buf == NULL -|| pad_buf == TAIL_FULL))) { + if (WARN_ON(pad_buf == NULL || pad_buf == TAIL_FULL)) { How do you think about to use the f

[PULL REQUEST] i2c for 5.3

2019-08-31 Thread Wolfram Sang
Linus, I2C has a bunch of driver fixes and a core improvement to make the on-going API transition more robust. Pleas pull. Thanks, Wolfram The following changes since commit a55aa89aab90fae7c815b0551b07be37db359d76: Linux 5.3-rc6 (2019-08-25 12:01:23 -0700) are available in the Git rep

Re: [PATCH v3 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter

2019-08-31 Thread Wolfram Sang
On Tue, Jul 09, 2019 at 01:19:33PM +, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Some i2c controllers have a built-in digital or analog filter. > This is specifically required depending on the hardware PCB/board. > Some controllers also allow specifying the maximum width of

RE: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread maowenan
Tim Can you share the reproduce steps for this issue? C or syzkaller is ok. Thanks a lot.

[PATCH] staging:kpc2000: Fix long constant sparse warning

2019-08-31 Thread Harsh Jain
It fixed following warning in kpc2000 driver "constant is so big it is unsigned long" Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc2000/cell_probe.c | 18 +- drivers/staging/kpc2000/kpc2000/core.c | 18 +- drivers/staging/kpc2000/kpc_dma/fil

Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering

2019-08-31 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-at91-core.c > b/drivers/i2c/busses/i2c-at91-core.c > index a663a7a..62610af 100644 > --- a/drivers/i2c/busses/i2c-at91-core.c > +++ b/drivers/i2c/busses/i2c-at91-core.c > @@ -68,6 +68,7 @@ static struct at91_twi_pdata at91rm9200_config = { > .has_unre_f

Re: [GIT] Crypto Fixes for 5.3

2019-08-31 Thread Herbert Xu
On Fri, Aug 30, 2019 at 07:01:42PM -0700, Linus Torvalds wrote: > > It could be in the subject line (ie change the "[GIT]" to "[GIT > PULL]") but it could also be anywhere in the email body (ie a "please > pull" or something like that). Sure I'll do that for the next pull request. I used to have

Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering

2019-08-31 Thread Wolfram Sang
> > + dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node, > > +"i2c-dig-filter"); > > + > > What do you think of the idea to introduce 'flags' to struct i2c_timings > and parse the bindings in the core, too? Then you'd have sth like: >

Re: [PATCH v3 0/9] i2c: add support for filters

2019-08-31 Thread Wolfram Sang
> > What is the plan for this patch series? > > I hope to review it this weekend and my hope it is good to go for 5.4. Series looks good basically. Just a few comments for some patches. See there. Thanks! signature.asc Description: PGP signature

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread Sasha Levin
On Sat, Aug 24, 2019 at 08:03:51AM +0200, Tim Froidcoeur wrote: Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") triggers following stack trace: [25244.848046] kernel BUG at ./include/linux/skbuff.h:1406! [25244.859335] RIP: 0010:skb_queue_prev+0x9/0xc [25244.888167] Call Trace: [2

Re: [PATCH v3 2/2] Bluetooth: btrtl: Add firmware version print

2019-08-31 Thread Marcel Holtmann
Hi Alex, > This patch is used to print fw version for debug convenience > > Signed-off-by: Alex Lu > --- > Changes in v3 > - Remove the pointless rtl: prefix in the format string > Changes in v2 > - Re-order the code so that no forward declaration is needed > > drivers/bluetooth/btrtl.c | 56

Re: [PATCH 2/2] Bluetooth: btrtl: Remove trailing newline from calls to rtl_dev macros

2019-08-31 Thread Marcel Holtmann
Hi Alex, > These printing macros already add a trailing newline, so drop these > unnecessary additional newlines. > > Signed-off-by: Alex Lu > --- > drivers/bluetooth/btrtl.c | 56 +++ > 1 file changed, 28 insertions(+), 28 deletions(-) patch has been applied

Re: [PATCH 1/2] Bluetooth: btrtl: Remove redundant prefix from calls to rtl_dev macros

2019-08-31 Thread Marcel Holtmann
Hi Alex, > the rtl: or RTL: prefix in the string is pointless. The rtl_dev_* macros > already does that. > > Signed-off-by: Alex Lu > --- > drivers/bluetooth/btrtl.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) patch has been applied to bluetooth-next tree. Regards Marc

[PATCH -next] scsi: ufs: Use kmemdup in ufshcd_read_string_desc()

2019-08-31 Thread YueHaibing
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/scsi/ufs/ufshcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index acf298da054c..6d5e2f5d8468 100644 --- a/drivers/scsi/uf

[PATCH -next] PCI: Use GFP_ATOMIC in resource_alignment_store()

2019-08-31 Thread YueHaibing
When allocating memory, the GFP_KERNEL cannot be used during the spin_lock period. It may cause scheduling when holding spin_lock. Fixes: f13755318675 ("PCI: Move pci_[get|set]_resource_alignment_param() into their callers") Signed-off-by: YueHaibing --- drivers/pci/pci.c | 2 +- 1 file changed

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-31 Thread kbuild test robot
/commits/Jing-Xiangfeng/arm-fix-page-faults-in-do_alignment/20190831-173417 base: git://git.armlinux.org.uk/~rmk/linux-arm.git for-next config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests

[PATCH -next] scsi: smartpqi: remove set but not used variable 'ctrl_info'

2019-08-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/smartpqi/smartpqi_init.c: In function 'pqi_driver_version_show': drivers/scsi/smartpqi/smartpqi_init.c:6164:24: warning: variable 'ctrl_info' set but not used [-Wunused-but-set-variable] commit 6d90615f1346 ("scsi: smartpqi: add sysfs e

Re: [PATCH v7 4/6] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-31 Thread Michal Suchánek
On Fri, 30 Aug 2019 23:03:41 +0200 Michal Suchanek wrote: > There are numerous references to 32bit functions in generic and 64bit > code so ifdef them out. > > Signed-off-by: Michal Suchanek > --- > v2: > - fix 32bit ifdef condition in signal.c > - simplify the compat ifdef condition in vdso.c

Re: lockdep warning on thunderbolt docking

2019-08-31 Thread Mika Westerberg
Hi Dominik, On Fri, Aug 30, 2019 at 02:58:48PM +0200, Dominik Brodowski wrote: > When connecting a thunderbolt-enabled docking station to my work laptop, > the following lockdep warning is reported on v5.3.0-rc6+ as of Thursday > morning (can look up the exact git id if so required): Thanks for r

Re: [PATCH] riscv: add arch/riscv/Kbuild

2019-08-31 Thread Masahiro Yamada
On Sat, Aug 31, 2019 at 12:53 AM Christoph Hellwig wrote: > > On Tue, Aug 27, 2019 at 02:14:59PM +0900, Masahiro Yamada wrote: > > There is a small documentation about "Makefile" vs "Kbuild" > > in Documentation/kbuild/modules.rst section 3.2 > > I know that part. > > > > > It is talking about ext

Re: [PATCH 4.14] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-31 Thread Matthieu Baerts
Hi Sasha, Thank you for your reply! On 31/08/2019 14:20, Sasha Levin wrote: > On Sat, Aug 24, 2019 at 08:03:51AM +0200, Tim Froidcoeur wrote: >> Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") >> triggers following stack trace: >> >> [25244.848046] kernel BUG at ./include/linux/skb

Re: [PATCH 2/2] mtd: spi-nor: intel-spi: add support for Intel Cannon Lake SPI flash

2019-08-31 Thread Mika Westerberg
Hi Jethro, On Sat, Aug 31, 2019 at 05:50:34AM +, Jethro Beekman wrote: > (apologies, resending without S/MIME signature) > > Now that SPI flash controllers without a software sequencer are > supported, it's trivial to add support for CNL and its PCI ID. > > Signed-off-by: Jethro Beekman > -

[GIT PULL] Thunderbolt changes for v5.4

2019-08-31 Thread Mika Westerberg
Hi Greg, The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d: Linux 5.3-rc3 (2019-08-04 18:40:12 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git tags/thunderbolt-for-v5.4 for you to fetch changes

Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

2019-08-31 Thread Andy Shevchenko
On Sat, Aug 31, 2019 at 1:26 PM Valdis Klētnieks wrote: > [/usr/src/linux-next] git log -- fs/ext4 | awk '/^commit/ {merge=0} /^Merge: > / {merge=1} /^Author:/ { if (!merge) {print $0}}' | sort | uniq -c | sort -t: > -k 1,1nr -k 2 Side note: % git shortlog -n --no-merges -- fs/ext4 | grep '^[

Re: linux-next: build failure after merge of the pci tree

2019-08-31 Thread Bjorn Helgaas
On Sat, Aug 31, 2019 at 3:49 AM Lorenzo Pieralisi wrote: > > On Sat, Aug 31, 2019 at 09:51:05AM +0530, Vidya Sagar wrote: > > On 8/30/2019 6:00 PM, Bjorn Helgaas wrote: > > > [+cc Krzysztof] > > > > > > On Thu, Aug 29, 2019 at 10:23 PM Stephen Rothwell > > > wrote: > > > > > > > > Hi all, > > >

Re: [RFC][PATCH 01/13] sched/deadline: Impose global limits on sched_attr::sched_period

2019-08-31 Thread Alessio Balsini
Right! Verified that sysctl_sched_dl_period_max and sysctl_sched_dl_period_min values are now always consistent. I spent some time in trying to figure out if not having any mutex in __checkparam_dl() is safe. There can surely happen that "max < min", e.g.: | |

Re: [PATCH v2 2/2] PTP: add support for one-shot output

2019-08-31 Thread Richard Cochran
On Fri, Aug 30, 2019 at 11:00:20AM +0300, Felipe Balbi wrote: > >> @@ -177,9 +177,8 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int > >> cmd, unsigned long arg) > >>err = -EFAULT; > >>break; > >>} > >> - if ((req.perout.flags || r

Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

2019-08-31 Thread Valdis Klētnieks
On Sat, 31 Aug 2019 17:24:47 +0300, Andy Shevchenko said: > Side note: > > % git shortlog -n --no-merges -- fs/ext4 | grep '^[^ ]' > > kinda faster and groups by name. Thanks... I rarely do statistical analyses of this sort of thing, so 'git shortlog' isn't on my list of most-used git subcommands

Re: [PATCH v2 2/2] PTP: add support for one-shot output

2019-08-31 Thread Richard Cochran
On Fri, Aug 30, 2019 at 11:00:20AM +0300, Felipe Balbi wrote: > seems like this should be defined together with the other flags? If > that's the case, it seems like we would EXTTS and PEROUT masks. Yes, let's make the meanings of the bit fields clear... --- ptp_clock.h --- /* * Bits of the ptp_

Re: [PATCH v4 3/4] watchdog/aspeed: add support for dual boot

2019-08-31 Thread Guenter Roeck
On Wed, Aug 28, 2019 at 01:24:01PM +0300, Ivan Mikhaylov wrote: > Set WDT_CLEAR_TIMEOUT_AND_BOOT_CODE_SELECTION into WDT_CLEAR_TIMEOUT_STATUS > to clear out boot code source and re-enable access to the primary SPI flash > chip while booted via wdt2 from the alternate chip. > > AST2400 datasheet sa

Re: [PATCH v4 4/4] aspeed/watchdog: Add access_cs0 option for alt-boot

2019-08-31 Thread Guenter Roeck
On Wed, Aug 28, 2019 at 01:24:02PM +0300, Ivan Mikhaylov wrote: > The option for the ast2400/2500 to get access to CS0 at runtime. > > Signed-off-by: Ivan Mikhaylov Reviewed-by: Guenter Roeck > --- > .../ABI/testing/sysfs-class-watchdog | 34 +++ > 1 file changed, 34

Re: [PATCH] ext4 crypto: fix to check feature status before get policy

2019-08-31 Thread Eric Biggers
On Sat, Aug 31, 2019 at 06:32:28PM +0800, Chao Yu wrote: > Hi, > > Is this change not necessary? A month has passed... > > Thanks, > > On 2019/8/4 17:56, Chao Yu wrote: > > From: Chao Yu > > > > When getting fscrypto policy via EXT4_IOC_GET_ENCRYPTION_POLICY, if > > encryption feature is off,

[PATCH] media: siano: Use the correct style for SPDX License Identifier

2019-08-31 Thread Nishad Kamdar
This patch corrects the SPDX License Identifier style in header file related to Siano Mobile Silicon Digital TV. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used) Changes made by using a script provided by

Re: [PATCH v3 09/11] Input: alps - remove unlikely() from IS_ERR*() condition

2019-08-31 Thread Pali Rohár
On Thursday 29 August 2019 10:50:39 Dmitry Torokhov wrote: > On Thu, Aug 29, 2019 at 07:50:23PM +0300, Denis Efremov wrote: > > "unlikely(IS_ERR_OR_NULL(x))" is excessive. IS_ERR_OR_NULL() already uses > > unlikely() internally. > > The keyword here is _internally_. > > https://lore.kernel.org/lk

Re: [PATCH] MAINTAINERS: update entry of firewire audio drivers

2019-08-31 Thread Takashi Iwai
On Fri, 30 Aug 2019 15:24:46 +0200, Takashi Sakamoto wrote: > > This commit adds myself as one of maintainers for firewire audio > drivers and IEC 61883-1/6 packet streaming engine. I call them ALSA > firewire stack as a whole. > > 6 years ago I joined in development for this category of drivers

Re: [PATCH 2/2] mtd: spi-nor: intel-spi: add support for Intel Cannon Lake SPI flash

2019-08-31 Thread Jethro Beekman
On 2019-08-31 06:36, Mika Westerberg wrote: Looks like some white space damage. There are couple of similar below as well. Oops. I will fix this in a v2 or resend later. + ispi->sregs = NULL; + ispi->pregs = ispi->base + CNL_PR; + ispi->nregions = CNL

Re: [PATCH] nvme-core: Fix subsystem instance mismatches

2019-08-31 Thread Keith Busch
On Fri, Aug 30, 2019 at 06:01:39PM -0600, Logan Gunthorpe wrote: > To fix this, assign the subsystem's instance based on the instance > number of the controller's instance that first created it. There should > always be fewer subsystems than controllers so the should not be a need > to create extra

Re: [fs/namei.c] e013ec23b8: WARNING:at_fs/dcache.c:#dentry_free

2019-08-31 Thread Al Viro
On Sat, Aug 31, 2019 at 09:09:17PM +0800, kernel test robot wrote: > [ 13.886602] WARNING: CPU: 0 PID: 541 at fs/dcache.c:338 > dentry_free+0x7f/0x90 > [ 13.889208] Modules linked in: > [ 13.890276] CPU: 0 PID: 541 Comm: readlink Not tainted > 5.3.0-rc1-8-ge013ec23b8231 #1 > [ 13.892

Re: [PATCH 2/2] mtd: spi-nor: intel-spi: add support for Intel Cannon Lake SPI flash

2019-08-31 Thread Mika Westerberg
On Sat, Aug 31, 2019 at 03:29:21PM +, Jethro Beekman wrote: > > > + ispi->sregs = NULL; > > > + ispi->pregs = ispi->base + CNL_PR; > > > + ispi->nregions = CNL_FREG_NUM; > > > + ispi->pr_num = CNL_PR_NUM; > > > > Does CNL really have a different number of PR and

[PATCH] Ext4 Docs: Add missing bigalloc documentation.

2019-08-31 Thread Ayush Ranjan
There was a broken link for bigalloc. The page https://ext4.wiki.kernel.org/index.php/Bigalloc was not migrated into the current documentation sources. This patch adds the contents of that missing page into the section for Bigalloc itself. Signed-off-by: Ayush Ranjan --- Please note that I have n

Re: [PATCH] tracing: silence noisy warnings about struct inode

2019-08-31 Thread Steven Rostedt
On Thu, 29 Aug 2019 14:34:18 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > Fix 30 warnings for missing "struct inode" declaration (like these) by > adding a forward reference for it. > These warnings come from 'headers_check' (CONFIG_HEADERS_CHECK): > CC include/trace/events/iomap.h

  1   2   >