RE: [PATCH v3 06/12] Drivers: hv: vmbus: Add a helper function is_sub_channel()

2019-08-23 Thread Michael Kelley
From: Dexuan Cui Sent: Monday, August 19, 2019 6:52 PM > > The existing method of telling if a channel is sub-channel in > vmbus_process_offer() is cumbersome. This new simple helper function > is preferred in future. > > Signed-off-by: Dexuan Cui > --- > include/linux/hyperv.h | 10 +-

Re: [PATCH 1/7] fs: introduce kernel_pread_file* support

2019-08-23 Thread Scott Branden
Hi Takashi On 2019-08-23 5:29 a.m., Takashi Iwai wrote: On Thu, 22 Aug 2019 21:24:45 +0200, Scott Branden wrote: Add kernel_pread_file* support to kernel to allow for partial read of files with an offset into the file. Existing kernel_read_file functions call new kernel_pread_file functions wi

[PATCH] leds: ti-lmu-common: Fix coccinelle issue in TI LMU

2019-08-23 Thread Dan Murphy
Fix the coccinelle issues found in the TI LMU common code drivers/leds/leds-ti-lmu-common.c:97:20-29: WARNING: Unsigned expression compared with zero: ramp_down < 0 drivers/leds/leds-ti-lmu-common.c:97:5-12: WARNING: Unsigned expression compared with zero: ramp_up < 0 Fixes: f717460ba4d7 ("leds

RE: [PATCH v3 08/12] Drivers: hv: vmbus: Ignore the offers when resuming from hibernation

2019-08-23 Thread Michael Kelley
From: Dexuan Cui Sent: Monday, August 19, 2019 6:52 PM > > When the VM resumes, the host re-sends the offers. We should not add the > offers to the global vmbus_connection.chn_list again. > > This patch assumes the RELIDs of the channels don't change across > hibernation. Actually this is not a

Re: [PATCH 3/3] firmware: add mutex fw_lock_fallback for race condition

2019-08-23 Thread Scott Branden
On 2019-08-23 8:43 a.m., Luis Chamberlain wrote: On Fri, Aug 23, 2019 at 12:31:40PM +0200, Takashi Iwai wrote: So, if any, we'd need put a mutex around the fallback loader code. And, the mutex should be rather per device, not a global one. Or we may trick it by appending the second parallel c

[PATCH] net/mlx5: fix a -Wstringop-truncation warning

2019-08-23 Thread Qian Cai
In file included from ./arch/powerpc/include/asm/paca.h:15, from ./arch/powerpc/include/asm/current.h:13, from ./include/linux/thread_info.h:21, from ./include/asm-generic/preempt.h:5, from ./arch/powerpc/include/generated/asm/pree

Re: [PATCH v6 4/4] net: phy: realtek: Add LED configuration support for RTL8211E

2019-08-23 Thread Florian Fainelli
On 8/16/19 3:39 PM, Doug Anderson wrote: > Hi, > > On Fri, Aug 16, 2019 at 3:12 PM Florian Fainelli wrote: >> >> On 8/16/19 2:27 PM, Matthias Kaehlcke wrote: >>> On Fri, Aug 16, 2019 at 10:13:42PM +0200, Pavel Machek wrote: On Tue 2019-08-13 12:11:47, Matthias Kaehlcke wrote: > Add a .co

Re: [PATCH] sched/fair: don't assign runtime for throttled cfs_rq

2019-08-23 Thread bsegall
Liangyan writes: > do_sched_cfs_period_timer() will refill cfs_b runtime and call > distribute_cfs_runtime() to unthrottle cfs_rq, sometimes cfs_b->runtime > will allocate all quota to one cfs_rq incorrectly. > This will cause other cfs_rq can't get runtime and will be throttled. > We find that o

RE: [PATCH v3 10/12] Drivers: hv: vmbus: Clean up hv_sock channels by force upon suspend

2019-08-23 Thread Michael Kelley
From: Dexuan Cui Sent: Monday, August 19, 2019 6:52 PM > > Fake RESCIND_CHANNEL messages to clean up hv_sock channels by force for > hibernation. There is no better method to clean up the channels since > some of the channels may still be referenced by the userspace apps when > hiberantin is trig

Re: [PATCH 2/7] firmware: add offset to request_firmware_into_buf

2019-08-23 Thread Scott Branden
Hi Luis, Thanks for helping on this. Enjoy your time off an we can work on it when you're back. comments below. On 2019-08-23 8:47 a.m., Luis Chamberlain wrote: On Thu, Aug 22, 2019 at 04:30:37PM -0700, Scott Branden wrote: On 2019-08-22 2:12 p.m., Luis Chamberlain wrote: On Thu, Aug 22, 2

RE: [PATCH v3 11/12] Drivers: hv: vmbus: Suspend after cleaning up hv_sock and sub channels

2019-08-23 Thread Michael Kelley
From: Dexuan Cui Sent: Monday, August 19, 2019 6:52 PM > > Before suspend, Linux must make sure all the hv_sock channels have been > properly cleaned up, because a hv_sock connection can not persist across > hibernation, and the user-space app must be properly notified of the > state change of th

RE: [PATCH v3 12/12] Drivers: hv: vmbus: Resume after fixing up old primary channels

2019-08-23 Thread Michael Kelley
From: Dexuan Cui Sent: Monday, August 19, 2019 6:52 PM > > When the host re-offers the primary channels upon resume, the host only > guarantees the Instance GUID doesn't change, so vmbus_bus_suspend() > should invalidate channel->offermsg.child_relid and figure out the > number of primary channe

Re: [patch] perf tool buffer overflow in perf_header__read_build_ids

2019-08-23 Thread Vince Weaver
On Fri, 26 Jul 2019, Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 23, 2019 at 04:42:30PM -0400, Vince Weaver escreveu: > > my perf_tool_fuzzer has found another issue, this one a buffer overflow > > in perf_header__read_build_ids. The build id filename is read in with a > > filename length read

Re: [PATCH v3] vfio_pci: Restore original state on release

2019-08-23 Thread Alex Williamson
On Thu, 22 Aug 2019 11:35:19 +0800 hexin wrote: > vfio_pci_enable() saves the device's initial configuration information > with the intent that it is restored in vfio_pci_disable(). However, > the commit referenced in Fixes: below replaced the call to > __pci_reset_function_locked(), which is no

Re: [PATCH v2 1/2] vfio-mdev/mtty: Simplify interrupt generation

2019-08-23 Thread Alex Williamson
On Thu, 8 Aug 2019 09:12:54 -0500 Parav Pandit wrote: > While generating interrupt, mdev_state is already available for which > interrupt is generated. > Instead of doing indirect way from state->device->uuid-> to searching > state linearly in linked list on every interrupt generation, > directl

Re: [PATCH v2] vfio: re-arrange vfio region definitions

2019-08-23 Thread Alex Williamson
On Wed, 14 Aug 2019 11:52:14 -0600 Alex Williamson wrote: > On Tue, 6 Aug 2019 11:30:00 +0200 > Cornelia Huck wrote: > > > It is easy to miss already defined region types. Let's re-arrange > > the definitions a bit and add more comments to make it hopefully > > a bit clearer. > > > > No funct

Re: [PATCH] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-23 Thread Christoph Paasch
On 23/08/19 - 14:50:54, Tim Froidcoeur wrote: > Commit 8c3088f895a0 ("tcp: be more careful in tcp_fragment()") > triggers following stack trace: > > [25244.848046] kernel BUG at ./include/linux/skbuff.h:1406! > [25244.859335] RIP: 0010:skb_queue_prev+0x9/0xc > [25244.888167] Call Trace: > [25244.8

Re: [PATCH 3/3] arm64: dts: meson-g12b-ugoos-am6: add initial device-tree

2019-08-23 Thread Kevin Hilman
Christian Hewitt writes: > Tested-by: Oleg Ivanov > Signed-off-by: Christian Hewitt nit: empty changelog. I'd rather see the changelog from patch2 here. > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../boot/dts/amlogic/meson-g12b-ugoos-am6.dts | 567 >

[PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-23 Thread Sean Christopherson
Don't advance RIP or inject a single-step #DB if emulation signals a fault. This logic applies to all state updates that are conditional on clean retirement of the emulation instruction, e.g. updating RFLAGS was previously handled by commit 38827dbd3fb85 ("KVM: x86: Do not update EFLAGS on faultin

Re: [PATCH v2 2/5] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when it's not ours

2019-08-23 Thread Mark Brown
On Fri, Aug 23, 2019 at 03:06:52PM +0300, Vladimir Oltean wrote: > - You left change requests in the initial patchset I submitted, but > you partially applied the series anyway. You didn't give me a chance > to respin the whole series and put the shared IRQ fix on top, so it > applies on old trees

[PATCH 1/2] perf report: Use timestamp__scnprintf_nsec for time sort key

2019-08-23 Thread Andi Kleen
From: Andi Kleen Use timestamp__scnprintf_nsec to print nanoseconds for the time sort key, instead of open coding. Signed-off-by: Andi Kleen --- tools/perf/util/sort.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c

[PATCH 2/2] perf report: Fix --ns time sort key output

2019-08-23 Thread Andi Kleen
From: Andi Kleen If the user specified --ns, the column to print the sort time stamp wasn't wide enough to actually print the full nanoseconds. Widen the time key column width when --ns is specified. Before: % perf record -a sleep 1 % perf report --sort time,overhead,symbol --stdio --ns ...

Re: [PATCH 1/7] fs: introduce kernel_pread_file* support

2019-08-23 Thread Luis Chamberlain
On Fri, Aug 23, 2019 at 12:55:30PM -0700, Scott Branden wrote: > Hi Takashi > > On 2019-08-23 5:29 a.m., Takashi Iwai wrote: > > On Thu, 22 Aug 2019 21:24:45 +0200, > > Scott Branden wrote: > > > Add kernel_pread_file* support to kernel to allow for partial read > > > of files with an offset into

Re: [PATCH net 0/9] rxrpc: Fix use of skb_cow_data()

2019-08-23 Thread David Miller
From: David Howells Date: Fri, 23 Aug 2019 09:52:28 +0100 > Question for you: how likely is a newly received buffer, through a UDP socket, > to be 'cloned'? Very unlikely, I'd say.

Re: [PATCH] wimax/i2400m: fix calculation of index, remove sizeof

2019-08-23 Thread David Miller
From: Colin Ian King Date: Fri, 23 Aug 2019 12:27:00 +0100 > On 23/08/2019 12:23, Dan Carpenter wrote: >> On Fri, Aug 23, 2019 at 09:52:30AM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> The subtraction of the two pointers is automatically scaled by the >>> size of the size of the ob

Re: [PATCH net-next v4 0/2] r8152: save EEE

2019-08-23 Thread David Miller
From: Hayes Wang Date: Fri, 23 Aug 2019 15:33:39 +0800 > v4: > For patch #2, remove redundant calling of "ocp_reg_write(tp, OCP_EEE_ADV, 0)". > > v3: > For patch #2, fix the mistake caused by copying and pasting. > > v2: > Adjust patch #1. The EEE has been disabled in the beginning of > r8153_h

[PATCH] KVM: VMX: Handle single-step #DB for EMULTYPE_SKIP on EPT misconfig

2019-08-23 Thread Sean Christopherson
VMX's EPT misconfig flow to handle fast-MMIO path falls back to decoding the instruction to determine the instruction length when running as a guest (Hyper-V doesn't fill VMCS.VM_EXIT_INSTRUCTION_LEN because it's technically not defined for EPT misconfigs). Rather than implement the slow skip in V

Re: [PATCH net 2/2] r8152: avoid using napi_disable after netif_napi_del.

2019-08-23 Thread David Miller
From: Hayes Wang Date: Fri, 23 Aug 2019 16:53:02 +0800 > Exchange netif_napi_del() and unregister_netdev() in rtl8152_disconnect() > to avoid using napi_disable() after netif_napi_del(). > > Signed-off-by: Hayes Wang > --- > drivers/net/usb/r8152.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-23 Thread Nadav Amit
> On Aug 23, 2019, at 1:55 PM, Sean Christopherson > wrote: > > Don't advance RIP or inject a single-step #DB if emulation signals a > fault. This logic applies to all state updates that are conditional on > clean retirement of the emulation instruction, e.g. updating RFLAGS was > previously ha

Re: [PATCH] tcp: fix tcp_rtx_queue_tail in case of empty retransmit queue

2019-08-23 Thread David Miller
All networking patches must be sent CC:'d to net...@vger.kernel.org Thank you.

[PATCH] gpiolib: acpi: Add gpiolib_acpi_run_edge_events_on_boot option and blacklist

2019-08-23 Thread Hans de Goede
Another day; another DSDT bug we need to workaround... Since commit ca876c7483b6 ("gpiolib-acpi: make sure we trigger edge events at least once on boot") we call _AEI edge handlers at boot. In some rare cases this causes problems. One example of this is the Minix Neo Z83-4 mini PC, this device ha

Re: [RESEND PATCH 04/13] KVM: x86: Drop EMULTYPE_NO_UD_ON_FAIL as a standalone type

2019-08-23 Thread Sean Christopherson
On Fri, Aug 23, 2019 at 04:32:05PM +0300, Liran Alon wrote: > > > On 23 Aug 2019, at 16:21, Liran Alon wrote: > > > >> On 23 Aug 2019, at 4:07, Sean Christopherson > >> wrote: > >> > >> The "no #UD on fail" is used only in the VMWare case, and for the VMWare > >> scenario it really means "#GP

WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-23 Thread Adric Blake
Synopsis: A WARN_ON_ONCE is hit twice in set_task_reclaim_state under the following conditions: - a memory cgroup has been created and a task assigned it it - memory.limit_in_bytes has been set - memory has filled up, likely from cache In my usage, I create a cgroup under the current session scope

Re: [PATCH 5.2 000/135] 5.2.10-stable review

2019-08-23 Thread Sasha Levin
On Fri, Aug 23, 2019 at 12:41:03PM -0600, shuah wrote: On 8/22/19 11:05 AM, Sasha Levin wrote: This is the start of the stable review cycle for the 5.2.10 release. There are 135 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being appl

Re: [patch V2 25/38] posix-cpu-timers: Provide array based sample functions

2019-08-23 Thread Frederic Weisbecker
On Wed, Aug 21, 2019 at 09:09:12PM +0200, Thomas Gleixner wrote: > Instead of using task_cputime and doing the addition of utime and stime at > all call sites, it's way simpler to have a sample array which allows > indexed based checks against the expiry cache array. > > Signed-off-by: Thomas Glei

Re: [PATCH] net/mlx5: fix a -Wstringop-truncation warning

2019-08-23 Thread David Miller
Saeed, I assume I'll get this from you.

Re: [patch V2 26/38] posix-cpu-timers: Make expiry checks array based

2019-08-23 Thread Frederic Weisbecker
On Wed, Aug 21, 2019 at 09:09:13PM +0200, Thomas Gleixner wrote: > The expiry cache is an array indexed by clock ids. The new sample functions > allow to retrieve a corresponding array of samples. > > Convert the fastpath expiry checks to make use of the new sample functions > and do the compariso

Re: [PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-23 Thread Andy Lutomirski
On Fri, Aug 23, 2019 at 1:55 PM Sean Christopherson wrote: > > Don't advance RIP or inject a single-step #DB if emulation signals a > fault. This logic applies to all state updates that are conditional on > clean retirement of the emulation instruction, e.g. updating RFLAGS was > previously handl

Re: [patch V2 27/38] posix-cpu-timers: Remove cputime_expires

2019-08-23 Thread Frederic Weisbecker
On Wed, Aug 21, 2019 at 09:09:14PM +0200, Thomas Gleixner wrote: > The last users of the magic struct cputime based expiry cache are > gone. Remove the leftovers. > > Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker

Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER

2019-08-23 Thread Carlos Eduardo de Paula
On Thu, Aug 22, 2019 at 5:56 PM David Abdurachmanov wrote: > > This patch was extensively tested on Fedora/RISCV (applied by default on > top of 5.2-rc7 kernel for <2 months). The patch was also tested with 5.3-rc > on QEMU and SiFive Unleashed board. > > libseccomp (userspace) was rebased: > http

Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER

2019-08-23 Thread Carlos Eduardo de Paula
On Thu, Aug 22, 2019 at 5:56 PM David Abdurachmanov wrote: > > This patch was extensively tested on Fedora/RISCV (applied by default on > top of 5.2-rc7 kernel for <2 months). The patch was also tested with 5.3-rc > on QEMU and SiFive Unleashed board. > > libseccomp (userspace) was rebased: > http

Re: [PATCH] sched/fair: don't assign runtime for throttled cfs_rq

2019-08-23 Thread Valentin Schneider
On 23/08/2019 21:00, bseg...@google.com wrote: [...] > Could you mention in the message that this a throttled cfs_rq can have > account_cfs_rq_runtime called on it because it is throttled before > idle_balance, and the idle_balance calls update_rq_clock to add time > that is accounted to the task.

[PATCH v7 3/8] PCI/DPC: Add dpc_process_error() wrapper function

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan With Error Disconnect Recover (EDR) support, we need to support processing DPC event either from DPC IRQ or ACPI EDR event. So create a wrapper function dpc_process_error() and move common error handling code in to it. It will be used to process the DPC event in b

[PATCH v7 5/8] PCI/AER: Allow clearing Error Status Register in FF mode

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per PCI firmware specification r3.2 Downstream Port Containment Related Enhancements ECN, sec 4.5.1, table 4-6, Error Disconnect Recover (EDR) support allows OS to handle error recovery and clearing Error Registers even in FF mode. So remove FF mode checks in p

[PATCH v7 7/8] PCI/DPC: Clear AER registers in EDR mode

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per PCI firmware specification r3.2 Downstream Port Containment Related Enhancements ECN, OS is responsible for clearing the AER registers in EDR mode. So clear AER registers in dpc_process_error() function. Signed-off-by: Kuppuswamy Sathyanarayanan Acked-by

[PATCH v7 6/8] PCI/DPC: Update comments related to DPC recovery on NON_FATAL errors

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently, in native mode, DPC driver is configured to trigger DPC only for FATAL errors and hence it only supports port recovery for FATAL errors. But with Error Disconnect Recover (EDR) support, DPC configuration is done by firmware, and hence we should expect D

[PATCH v7 8/8] PCI/ACPI: Enable EDR support

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per PCI firmware specification r3.2 Downstream Port Containment Related Enhancements ECN, sec 4.5.1, OS must implement following steps to enable/use EDR feature. 1. OS can use bit 7 of _OSC Control Field to negotiate control over Downstream Port Containment (D

[PATCH v7 0/8] Add Error Disconnect Recover (EDR) support

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan This patchset adds support for following features: 1. Error Disconnect Recover (EDR) support. 2. _OSC based negotiation support for DPC. You can find EDR spec in the following link. https://members.pcisig.com/wg/PCI-SIG/document/12614 Changes since v6: * Modi

[PATCH v7 1/8] PCI/ERR: Update error status after reset_link()

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") uses reset_link() to recover from fatal errors. But, if the reset is successful there is no need to continue the rest of the error recovery checks. Also, during fatal error recovery, if the initial value

[PATCH v7 4/8] PCI/DPC: Add Error Disconnect Recover (EDR) support

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per ACPI specification r6.3, sec 5.6.6, when firmware owns Downstream Port Containment (DPC), its expected to use the "Error Disconnect Recover" (EDR) notification to alert OSPM of a DPC event and if OS supports EDR, its expected to handle the software state in

[PATCH v7 2/8] PCI/DPC: Allow dpc_probe() even if firmware first mode is enabled

2019-08-23 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per ACPI specification v6.3, sec 5.6.6, Error Disconnect Recover (EDR) notification used by firmware to let OS know about the DPC event and permit OS to perform error recovery when processing the EDR notification. Also, as per PCI firmware specification r3.2 Do

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-23 Thread Roman Gushchin
On Fri, Aug 16, 2019 at 05:47:26PM -0700, Roman Gushchin wrote: > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > with the hierarchical ones") effectively decreased the precision of > per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. > > That's good for

Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

2019-08-23 Thread Thomas Gleixner
Sebastian, On Sun, 28 Jul 2019, Sebastian Mayr wrote: sorry for the delay.. > 32-bit processes running on a 64-bit kernel are not always detected > correctly, causing the process to crash when uretprobes are installed. > The reason for the crash is that in_ia32_syscall() is used to determine > t

Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

2019-08-23 Thread Thomas Gleixner
On Sat, 24 Aug 2019, Thomas Gleixner wrote: > On Sun, 28 Jul 2019, Sebastian Mayr wrote: > > > -static inline int sizeof_long(void) > > +static inline int sizeof_long(struct pt_regs *regs) > > { > > - return in_ia32_syscall() ? 4 : 8; > > This wants a comment. > > > + return user_64bit_mo

RE: [PATCH v2 01/10] PCI: designware-ep: Add multiple PFs support for DWC

2019-08-23 Thread Xiaowei Bao
> -Original Message- > From: Andrew Murray > Sent: 2019年8月23日 21:25 > To: Xiaowei Bao > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; kis...@ti.com; > lorenzo.pieral...@arm.co; a...@arndb.de; gre...@linuxfoundation.org; M.h. > Lian ;

RE: [PATCH v2 02/10] PCI: designware-ep: Add the doorbell mode of MSI-X in EP mode

2019-08-23 Thread Xiaowei Bao
> -Original Message- > From: Andrew Murray > Sent: 2019年8月23日 21:36 > To: Xiaowei Bao > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; kis...@ti.com; > lorenzo.pieral...@arm.co; a...@arndb.de; gre...@linuxfoundation.org; M.h. > Lian ;

Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

2019-08-23 Thread Andy Lutomirski
> On Aug 23, 2019, at 4:44 PM, Thomas Gleixner wrote: > >> On Sat, 24 Aug 2019, Thomas Gleixner wrote: >>> On Sun, 28 Jul 2019, Sebastian Mayr wrote: >>> >>> -static inline int sizeof_long(void) >>> +static inline int sizeof_long(struct pt_regs *regs) >>> { >>> -return in_ia32_syscall() ?

RE: [PATCH v2 05/10] PCI: layerscape: Fix some format issue of the code

2019-08-23 Thread Xiaowei Bao
> -Original Message- > From: Andrew Murray > Sent: 2019年8月23日 21:45 > To: Xiaowei Bao > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; kis...@ti.com; > lorenzo.pieral...@arm.co; a...@arndb.de; gre...@linuxfoundation.org; M.h. > Lian ;

Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

2019-08-23 Thread Thomas Gleixner
On Fri, 23 Aug 2019, Andy Lutomirski wrote: > > On Aug 23, 2019, at 4:44 PM, Thomas Gleixner wrote: > > > >> On Sat, 24 Aug 2019, Thomas Gleixner wrote: > >>> On Sun, 28 Jul 2019, Sebastian Mayr wrote: > >>> > >>> -static inline int sizeof_long(void) > >>> +static inline int sizeof_long(struct p

Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

2019-08-23 Thread Thomas Gleixner
On Sat, 24 Aug 2019, Thomas Gleixner wrote: > On Fri, 23 Aug 2019, Andy Lutomirski wrote: > > > On Aug 23, 2019, at 4:44 PM, Thomas Gleixner wrote: > > > > > >> On Sat, 24 Aug 2019, Thomas Gleixner wrote: > > >>> On Sun, 28 Jul 2019, Sebastian Mayr wrote: > > >>> > > >>> -static inline int sizeo

Re: [PATCH 01/15] sched: introduce task_se_h_load helper

2019-08-23 Thread Rik van Riel
On Fri, 2019-08-23 at 20:13 +0200, Dietmar Eggemann wrote: > > > > @@ -1668,7 +1668,7 @@ static void task_numa_compare(struct > > task_numa_env *env, > > /* > > * In the overloaded case, try and keep the load balanced. > > */ > > - load = task_h_load(env->p) - task_h_load(cur); >

RE: [PATCH v2 07/10] PCI: layerscape: Modify the MSIX to the doorbell way

2019-08-23 Thread Xiaowei Bao
> -Original Message- > From: Andrew Murray > Sent: 2019年8月23日 21:58 > To: Xiaowei Bao > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; kis...@ti.com; > lorenzo.pieral...@arm.co; a...@arndb.de; gre...@linuxfoundation.org; M.h. > Lian ;

Re: [RFC PATCH v2 00/19] RDMA/FS DAX truncate proposal V1,000,002 ;-)

2019-08-23 Thread Dave Chinner
On Fri, Aug 23, 2019 at 09:04:29AM -0300, Jason Gunthorpe wrote: > On Fri, Aug 23, 2019 at 01:23:45PM +1000, Dave Chinner wrote: > > > > But the fact that RDMA, and potentially others, can "pass the > > > pins" to other processes is something I spent a lot of time trying to > > > work out. > > >

RE: [PATCH 3/3] nvme: complete request in work queue on CPU with flooded interrupts

2019-08-23 Thread Long Li
>>>Subject: Re: [PATCH 3/3] nvme: complete request in work queue on CPU >>>with flooded interrupts >>> >>> Sagi, Here are the test results. Benchmark command: fio --bs=4k --ioengine=libaio --iodepth=64 -- >>>filename=/dev/nvme0n1:/dev/nvme1n1:/dev/nvme2n1:/dev/nvm

Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

2019-08-23 Thread Andy Lutomirski
> On Aug 23, 2019, at 5:03 PM, Thomas Gleixner wrote: > >> On Sat, 24 Aug 2019, Thomas Gleixner wrote: >> On Fri, 23 Aug 2019, Andy Lutomirski wrote: On Aug 23, 2019, at 4:44 PM, Thomas Gleixner wrote: >> On Sat, 24 Aug 2019, Thomas Gleixner wrote: >> On Sun, 28 Jul 2019, S

RE: [PATCH v2 08/10] PCI: layerscape: Add EP mode support for ls1088a and ls2088a

2019-08-23 Thread Xiaowei Bao
> -Original Message- > From: Andrew Murray > Sent: 2019年8月23日 22:28 > To: Xiaowei Bao > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; kis...@ti.com; > lorenzo.pieral...@arm.co; a...@arndb.de; gre...@linuxfoundation.org; M.h. > Lian ;

Re: [RFC PATCH v2 00/19] RDMA/FS DAX truncate proposal V1,000,002 ;-)

2019-08-23 Thread Dave Chinner
On Fri, Aug 23, 2019 at 10:15:04AM -0700, Ira Weiny wrote: > On Fri, Aug 23, 2019 at 10:59:14AM +1000, Dave Chinner wrote: > > On Wed, Aug 21, 2019 at 11:02:00AM -0700, Ira Weiny wrote: > > > On Tue, Aug 20, 2019 at 08:55:15AM -0300, Jason Gunthorpe wrote: > > > > On Tue, Aug 20, 2019 at 11:12:10AM

RE: [PATCH v2 03/10] PCI: designware-ep: Move the function of getting MSI capability forward

2019-08-23 Thread Xiaowei Bao
> -Original Message- > From: Andrew Murray > Sent: 2019年8月23日 21:39 > To: Xiaowei Bao > Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; kis...@ti.com; > lorenzo.pieral...@arm.co; a...@arndb.de; gre...@linuxfoundation.org; M.h. > Lian ;

Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

2019-08-23 Thread Thomas Gleixner
On Fri, 23 Aug 2019, Andy Lutomirski wrote: > > On Aug 23, 2019, at 5:03 PM, Thomas Gleixner wrote: > > > >> On Sat, 24 Aug 2019, Thomas Gleixner wrote: > >> On Fri, 23 Aug 2019, Andy Lutomirski wrote: > On Aug 23, 2019, at 4:44 PM, Thomas Gleixner wrote: > > >> On Sat, 24 Aug 201

[PATCH] ARM: dts: vf610-zii-scu4-aib: Configure IRQ line for GPIO expander

2019-08-23 Thread Andrey Smirnov
Configure IRQ line for SX1503 GPIO expander. We already have appropriate pinmux entry and all that is missing is "interrupt-parent" and "interrupts" properties. Add them. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Cory Tusar Cc: Fabio Estevam Cc: linux-arm-ker...@lists.in

Re: [PATCH] pwm: mxs: use devm_platform_ioremap_resource() to simplify code

2019-08-23 Thread Uwe Kleine-König
Hello, On Tue, Aug 20, 2019 at 05:56:40AM +, Anson Huang wrote: > Gentle ping... My impression[1] is that Thierry collects patches in bulk once or twice per release cycle. The last two such bulks were between 5.2-rc6 and 5.2-rc7 and in the 5.2 merge window. So given we're at v5.3-rc5 now I ex

[PATCH] ARM: dts: vf610-zii-scu4-aib: Use generic names for DT nodes

2019-08-23 Thread Andrey Smirnov
The devicetree specification recommends using generic node names. Some ZII dts files already follow such recommendation, but some don't, so use generic node names for consistency among the ZII dts files. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Cory Tusar Cc: Fabio Este

[PATCH 1/2] media: imx: Move capture device init to registered

2019-08-23 Thread Steve Longerbeam
If the CSI is unregistered and then registered again without the driver being removed and re-probed (which will happen when the media device is removed and re-probed without also removing/re-probing the CSI), the result is the kobject error and backtrace "tried to init an initialized object". This

[PATCH 2/2] media: imx: Move pads init to probe

2019-08-23 Thread Steve Longerbeam
If a subdevice is unregistered and then registered again without the driver being removed and re-probed (which will happen when the media device is removed and re-probed without also removing/re-probing the subdevice), media_device_register_entity() is called with a non-zero entity->num_pads, and t

Re: [PATCH v5 01/13] pwm: mediatek: add a property "num-pwms"

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:31PM +0800, Sam Shih wrote: > From: Ryder Lee > > This adds a property "num-pwms" to avoid having an endless > list of compatibles with no differences for the same driver. > > Signed-off-by: Ryder Lee > Signed-off-by: Sam Shih Reviewed-by: Uwe Kleine-König Than

Re: [PATCH v5 02/13] pwm: mediatek: droping the check for of_device_get_match_data

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:32PM +0800, Sam Shih wrote: > This patch drop the check for of_device_get_match_data. > Due to the only way call driver probe is compatible match. > The .data pointer which point to the SoC specify data is > directly set by driver, and it should not be NULL in our case

Re: [PATCH 0/2] coresight: Add barrier packet when moving offset forward

2019-08-23 Thread Yabin Cui
Thanks for fixing this problem. I didn't realize it because I usually use a buffer size >= the default ETR buffer size, which is harder to reproduce the problem. The patches LGTM, maybe you also want to fix the problem commented by Leo Yan. I tested the patches by recording etm data with a buffer s

Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER

2019-08-23 Thread Paul Walmsley
On Thu, 22 Aug 2019, David Abdurachmanov wrote: > There is one failing kernel selftest: global.user_notification_signal Is this the only failing test? Or are the rest of the selftests skipped when this test fails, and no further tests are run, as seems to be shown here: https://lore.kernel

[CFP] Real-Time Summit 2019 Call for Presentations

2019-08-23 Thread Daniel Bristot de Oliveira
The Real-Time Summit is organized by the Linux Foundation Real-Time Linux (RTL) collaborative project. The event is intended to gather developers and users of Linux as a Real-Time Operating System. The main intent is to provide room for discussion between developers, tooling experts, and users. Th

Re: [PATCH v5 03/13] pwm: mediatek: add a property "clock-frequency"

2019-08-23 Thread Uwe Kleine-König
Hello Sam, On Thu, Aug 22, 2019 at 02:58:33PM +0800, Sam Shih wrote: > This fix mt7628 pwm during configure from userspace. The SoC > is legacy MIPS and has no complex clock tree. This patch add property > clock-frequency to the SoC specific data and legacy MIPS SoC need to > configure it in DT. T

Re: [PATCH v5 04/13] pwm: mediatek: allocate the clks array dynamically

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:34PM +0800, Sam Shih wrote: > Instead of using fixed size of arrays, allocate the memory for them > based on the information we get from the DT. > > Also remove the check for num_pwms, due to dynamically allocate pwm > should not cause array index out of bound. > > S

Re: [PATCH v5 05/13] pwm: mediatek: use pwm_mediatek as common prefix

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:35PM +0800, Sam Shih wrote: > Use pwm_mediatek as common prefix to match the filename. > No functional change intended. > > Signed-off-by: Ryder Lee > Signed-off-by: Sam Shih > --- > Changes since v5: > - Follow reviewers's comments > The license stuff is a separate

Re: [PATCH v5 06/13] pwm: mediatek: update license and switch to SPDX tag

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:36PM +0800, Sam Shih wrote: > Add SPDX identifiers to pwm-mediatek.c > Update license to GNU General Public License v2.0 > > Signed-off-by: Ryder Lee > Signed-off-by: Sam Shih Reviewed-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K.

Re: [PATCH v5 08/13] dt-bindings: pwm: update bindings for MT7628 SoC

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 04:12:20PM +0800, Yingjoe Chen wrote: > On Thu, 2019-08-22 at 14:58 +0800, Sam Shih wrote: > > This updates bindings for MT7628 pwm controller. > > > > Signed-off-by: Sam Shih > > --- > > Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 4 > > 1 file changed,

Re: [PATCH v5 09/13] arm64: dts: mt7622: add a property "num-pwms" for PWM

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:39PM +0800, Sam Shih wrote: > From: Ryder Lee > > This adds a property "num-pwms" for PWM controller. > > Signed-off-by: Ryder Lee > Signed-off-by: Sam Shih > --- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

Re: [PATCH v5 10/13] arm: dts: mt7623: add a property "num-pwms" for PWM

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:40PM +0800, Sam Shih wrote: > From: Ryder Lee > > This adds a property "num-pwms" for PWM controller. > > Signed-off-by: Ryder Lee > Signed-off-by: Sam Shih > --- > arch/arm/boot/dts/mt7623.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/b

Re: [PATCH v5 11/13] dt-bindings: pwm: update bindings for MT7629 SoC

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:41PM +0800, Sam Shih wrote: > From: Ryder Lee > > This updates bindings for MT7629 pwm controller. > > This patch is the same as > https://patchwork.kernel.org/patch/10769381/ > and it has a Reviewed-by tag in v1 This paragraph doesn't belong in the commit log. >

Re: [PATCH v5 12/13] pwm: mediatek: remove a property "has-clock"

2019-08-23 Thread Uwe Kleine-König
On Thu, Aug 22, 2019 at 02:58:42PM +0800, Sam Shih wrote: > Due to we added clock-frequency property to fix > mt7628 pwm during configure from userspace. > We can alos use this property to determine whether > the complex clock tree exists in the SoC or not. > So we can safety remove has-clock prope

Re: [PATCH V5 1/3] riscv: Add perf callchain support

2019-08-23 Thread Guo Ren
Please check CONFIG_FRAME_POINTER 1 *frame = *((struct stackframe *)frame->fp - 1); This code is origionally from riscv/kernel/stacktrace.c: walk_stackframe In linux/Makefile it'll involve the options for gcc to definitely store ra & prev_fp in fp pointer. ifdef CONFIG_FRAME_POINTER KBUILD_CFLAGS

Re: [PATCH v2] x86/mm/pti: in pti_clone_pgtable(), increase addr properly

2019-08-23 Thread Thomas Gleixner
On Wed, 21 Aug 2019, Thomas Gleixner wrote: > On Wed, 21 Aug 2019, Song Liu wrote: > > > On Aug 20, 2019, at 1:23 PM, Song Liu wrote: > > > > > > Before 32-bit support, pti_clone_pmds() always adds PMD_SIZE to addr. > > > This behavior changes after the 32-bit support: pti_clone_pgtable() > > >

Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage

2019-08-23 Thread Yang Shi
On 8/23/19 3:00 PM, Adric Blake wrote: Synopsis: A WARN_ON_ONCE is hit twice in set_task_reclaim_state under the following conditions: - a memory cgroup has been created and a task assigned it it - memory.limit_in_bytes has been set - memory has filled up, likely from cache In my usage, I cre

Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER

2019-08-23 Thread David Abdurachmanov
nning selftests, but SECCOMP is disabled and thus it's failing. Is there another CI which tracks selftests? https://qa-reports.linaro.org/lkft/linux-next-oe/tests/kselftest/seccomp_seccomp_bpf?top=next-20190823 > > > - Paul

Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER

2019-08-23 Thread David Abdurachmanov
. > > Well the code states ".. and hope that it doesn't break when there > is actually a signal :)". Maybe we are just unlucky. I don't have results > from other architectures to compare. > > I found that Linaro is running selftests, but SECCOMP is disabled > and

Re: [PATCH 11/15] sched,fair: flatten hierarchical runqueues

2019-08-23 Thread Rik van Riel
On Fri, 2019-08-23 at 20:14 +0200, Dietmar Eggemann wrote: > > Looks like with the se->depth related code gone here in > pick_next_task_fair() and the call to find_matching_se() in > check_preempt_wakeup() you could remove se->depth entirely. > > [...] I've just done that in a separate patch in

Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER

2019-08-23 Thread Paul Walmsley
On Fri, 23 Aug 2019, David Abdurachmanov wrote: > On Fri, Aug 23, 2019 at 5:30 PM Paul Walmsley > wrote: > > > > On Thu, 22 Aug 2019, David Abdurachmanov wrote: > > > > > There is one failing kernel selftest: global.user_notification_signal > > > > Is this the only failing test? Or are the rest

Re: [PATCH 5.2 000/135] 5.2.10-stable review

2019-08-23 Thread Sasha Levin
On Fri, Aug 23, 2019 at 10:36:27AM -0700, Greg KH wrote: On Fri, Aug 23, 2019 at 02:28:53AM -0400, Sasha Levin wrote: On Fri, Aug 23, 2019 at 02:42:48AM +0200, Stefan Lippers-Hollmann wrote: > Hi > > On 2019-08-22, Greg KH wrote: > > On Fri, Aug 23, 2019 at 12:05:27AM +0200, Stefan Lippers-Hollm

Re: [PATCH 00/14] per memcg lru_lock

2019-08-23 Thread Hugh Dickins
On Wed, 21 Aug 2019, Alex Shi wrote: > 在 2019/8/21 上午2:24, Hugh Dickins 写道: > > I'll set aside what I'm doing, and switch to rebasing ours to v5.3-rc > > and/or mmotm. Then compare with what Alex has, to see if there's any > > good reason to prefer one to the other: if no good reason to prefer our

Re: [PATCH v2] x86/mm/pti: in pti_clone_pgtable(), increase addr properly

2019-08-23 Thread Song Liu
> On Aug 23, 2019, at 5:59 PM, Thomas Gleixner wrote: > > On Wed, 21 Aug 2019, Thomas Gleixner wrote: >> On Wed, 21 Aug 2019, Song Liu wrote: On Aug 20, 2019, at 1:23 PM, Song Liu wrote: Before 32-bit support, pti_clone_pmds() always adds PMD_SIZE to addr. This behavior c

Re: [PATCH V3 0/3] riscv: Add perf callchain support

2019-08-23 Thread Paul Walmsley
On Mon, 19 Aug 2019, Mao Han wrote: > PS: I got some compile error while compiling glibc 2.30 with linux > v5.3-rc4 header. vfork.S include linux/sched.h(./include/uapi/linux/sched.h) > which has a struct clone_args inside, added by > 7f192e3cd316ba58c88dfa26796cf77789dd9872. Noticed that also.

Re: [PATCH] PCI: Add missing link delays required by the PCIe spec

2019-08-23 Thread Bjorn Helgaas
Hi Mika, I'm trying to figure out specifically why we need this and where it should go. Questions below. On Wed, Aug 21, 2019 at 03:45:19PM +0300, Mika Westerberg wrote: > Currently Linux does not follow PCIe spec regarding the required delays > after reset. A concrete example is a Thunderbolt a

<    3   4   5   6   7   8   9   >