Re: [PATCH -rcu/dev] Please squash: fixup! rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Paul Walmsley
On Sat, 17 Aug 2019, Joel Fernandes (Google) wrote: > xchg() on a bool is causing issues on riscv and arm32. Indeed, it seems best not to use xchg() on any type that's not 32 bits long or that's not the CPU's native word size. Probably we should update the documentation. > Please squash this

Re: [PATCH -rcu/dev] Please squash: fixup! rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Joel Fernandes
On Fri, Aug 16, 2019 at 09:38:54PM -0700, Paul Walmsley wrote: > On Sat, 17 Aug 2019, Joel Fernandes (Google) wrote: > > > xchg() on a bool is causing issues on riscv and arm32. > > Indeed, it seems best not to use xchg() on any type that's not 32 bits > long or that's not the CPU's native word

Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

2019-08-16 Thread Paul E. McKenney
On Fri, Aug 16, 2019 at 03:57:43PM -0700, Linus Torvalds wrote: [ . . . ] > We add READ_ONCE and WRITE_ONCE annotations when they make sense. Not > because of some theoretical "compiler is free to do garbage" > arguments. If such garbage happens, we need to fix the compiler, the > same way we alr

Re: [PATCH v4 1/2] rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Paul E. McKenney
On Sat, Aug 17, 2019 at 12:30:24AM -0400, Joel Fernandes wrote: > On Fri, Aug 16, 2019 at 08:56:37PM -0700, Paul E. McKenney wrote: > > On Fri, Aug 16, 2019 at 09:32:23PM -0400, Joel Fernandes wrote: > > > Hi Paul, > > > > > > On Fri, Aug 16, 2019 at 3:16 PM Paul E. McKenney > > > wrote: > > > >

[PATCH] media: cpia2_usb: fix memory leaks

2019-08-16 Thread Wenwen Wang
In submit_urbs(), 'cam->sbuf[i].data' is allocated through kmalloc_array(). However, it is not deallocated if the following allocation for urbs fails. To fix this issue, free 'cam->sbuf[i].data' if usb_alloc_urb() fails. Signed-off-by: Wenwen Wang --- drivers/media/usb/cpia2/cpia2_usb.c | 4

Re: [PATCH v4 1/2] rcu/tree: Add basic support for kfree_rcu() batching

2019-08-16 Thread Joel Fernandes
On Fri, Aug 16, 2019 at 10:20:23PM -0700, Paul E. McKenney wrote: > On Sat, Aug 17, 2019 at 12:30:24AM -0400, Joel Fernandes wrote: > > On Fri, Aug 16, 2019 at 08:56:37PM -0700, Paul E. McKenney wrote: > > > On Fri, Aug 16, 2019 at 09:32:23PM -0400, Joel Fernandes wrote: > > > > Hi Paul, > > > > >

Re: [PATCH 15/15] drivers: thermal: tsens: Add interrupt support

2019-08-16 Thread Stephen Boyd
Quoting Amit Kucheria (2019-07-25 15:18:50) > diff --git a/drivers/thermal/qcom/tsens-common.c > b/drivers/thermal/qcom/tsens-common.c > index 13a875b99094..f94ef79c37bc 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -13,6 +13,22 @@ > #include

Re: [PATCH v2 10/14] dt-bindings: power: avs: Add support for CPR (Core Power Reduction)

2019-08-16 Thread Stephen Boyd
Quoting Niklas Cassel (2019-07-25 03:41:38) > + cpr@b018000 { > + compatible = "qcom,qcs404-cpr", "qcom,cpr"; > + reg = <0x0b018000 0x1000>; > + interrupts = <0 15 IRQ_TYPE_EDGE_RISING>; > + clocks = <&xo_board>; > + clock-

[PATCH] media: usb: cx231xx-417: fix a memory leak bug

2019-08-16 Thread Wenwen Wang
In cx231xx_load_firmware(), 'p_buffer' is allocated through vmalloc() to hold the firmware. However, after the usage, it is not deallocated, leading to a memory leak bug. Signed-off-by: Wenwen Wang --- drivers/media/usb/cx231xx/cx231xx-417.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-16 Thread Greg KH
On Fri, Aug 16, 2019 at 05:47:26PM -0700, Roman Gushchin wrote: > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > with the hierarchical ones") effectively decreased the precision of > per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. > > That's good for

[PATCH] clk: Remove extraneous 'for' word in comments

2019-08-16 Thread Rishi Gupta
An extra 'for' word is grammatically incorrect in the comment 'verifying ops for multi-parent clks'. This commit removes this extra for word. Signed-off-by: Rishi Gupta --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c

[PATCH] media: dvb-frontends: fix memory leaks

2019-08-16 Thread Wenwen Wang
In dib7000pc_detection(), 'tx' and 'rx' are allocated through kzalloc() respectively. However, if DiB7000PC is detected, they are not deallocated, leading to memory leaks. To fix this issue, create a label to free 'tx' and 'rx' before returning from the function. Signed-off-by: Wenwen Wang --- d

Re: cleanup the walk_page_range interface

2019-08-16 Thread Stephen Rothwell
Hi all, On Fri, 16 Aug 2019 14:06:23 -0700 Andrew Morton wrote: > > On Fri, 16 Aug 2019 14:32:58 +0200 Christoph Hellwig wrote: > > > On Fri, Aug 16, 2019 at 11:57:40AM +, Jason Gunthorpe wrote: > > > Are there conflicts with trees other than hmm? > > > > > > We can put it on a topic br

Re: cleanup the walk_page_range interface

2019-08-16 Thread Christoph Hellwig
On Sat, Aug 17, 2019 at 04:41:24PM +1000, Stephen Rothwell wrote: > I certainly prefer that method of API change :-) > (see the current "keys: Replace uid/gid/perm permissions checking with > an ACL" in linux-next and the (currently) three merge fixup patches I > am carrying. Its not bad when peop

[PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue

2019-08-16 Thread Matthew Hanzelik
Fixed an unnamed parameter style issue. Signed-off-by: Matthew Hanzelik --- drivers/staging/speakup/spk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h index a2fc72c29894..afa64eb9afb4 100644 -

Re: [PATCH] Fix an OOB bug in uac_mixer_unit_bmControls

2019-08-16 Thread Takashi Iwai
On Sat, 17 Aug 2019 06:32:07 +0200, Hui Peng wrote: > > `uac_mixer_unit_get_channels` calls `uac_mixer_unit_bmControls` > to get pointer to bmControls field. The current implementation of > `uac_mixer_unit_get_channels` does properly check the size of > uac_mixer_unit_descriptor descriptor and may

Re: cleanup the walk_page_range interface

2019-08-16 Thread Stephen Rothwell
Hi Christoph, On Sat, 17 Aug 2019 08:43:01 +0200 Christoph Hellwig wrote: > > On Sat, Aug 17, 2019 at 04:41:24PM +1000, Stephen Rothwell wrote: > > I certainly prefer that method of API change :-) > > (see the current "keys: Replace uid/gid/perm permissions checking with > > an ACL" in linux-next

<    4   5   6   7   8   9