Re: [PATCHv6 10/36] kernel: Add do_timens_ktime_to_host() helper

2019-08-15 Thread Thomas Gleixner
On Thu, 15 Aug 2019, Dmitry Safonov wrote: > +ktime_t do_timens_ktime_to_host(clockid_t clockid, ktime_t tim, > + struct timens_offsets *ns_offsets) > +{ > + ktime_t offset; > + > + switch (clockid) { > + case CLOCK_MONOTONIC: > + offset = timespe

Re: [PATCH] Fix a stack buffer overflow bug check_input_term

2019-08-15 Thread Takashi Iwai
On Thu, 15 Aug 2019 19:19:10 +0200, Hui Peng wrote: > > Hi, Takashi: > > One point I want to be clear: if an endless recursive loop is detected, should > we return 0, or a negative error code?  An error might be more appropriate, but it's no big deal, as you'll likely hit other errors sooner or

Re: [PATCH v2] asm-generic: fix variable 'p4d' set but not used

2019-08-15 Thread Guenter Roeck
On Tue, Aug 06, 2019 at 07:29:17PM -0400, Qian Cai wrote: > A compiler throws a warning on an arm64 system since the > commit 9849a5697d3d ("arch, mm: convert all architectures to use > 5level-fixup.h"), > > mm/kasan/init.c: In function 'kasan_free_p4d': > mm/kasan/init.c:344:9: warning: variable

Re: [RFC PATCH 2/2] mm/gup: introduce vaddr_pin_pages_remote()

2019-08-15 Thread John Hubbard
On 8/15/19 10:32 AM, Ira Weiny wrote: > On Thu, Aug 15, 2019 at 03:35:10PM +0200, Jan Kara wrote: >> On Thu 15-08-19 15:26:22, Jan Kara wrote: >>> On Wed 14-08-19 20:01:07, John Hubbard wrote: On 8/14/19 5:02 PM, John Hubbard wrote: Hold on, I *was* forgetting something: this was a t

Re: [PATCHv6 14/36] hrtimers: Prepare hrtimer_nanosleep() for time namespaces

2019-08-15 Thread Thomas Gleixner
On Thu, 15 Aug 2019, Dmitry Safonov wrote: > --- > include/linux/hrtimer.h | 2 +- > kernel/time/hrtimer.c | 8 > kernel/time/posix-stubs.c | 4 ++-- You forgot to convert the caller in posix-timers.c which breaks bisectability. Please make sure, that every patch compiles and boots.

Re: [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-08-15 Thread Laurent Pinchart
Hi Helen, Thank you for the patch. On Wed, Aug 07, 2019 at 10:37:55AM -0300, Helen Koike wrote: > On 8/7/19 10:05 AM, Sakari Ailus wrote: > > On Tue, Jul 30, 2019 at 03:42:46PM -0300, Helen Koike wrote: > >> From: Jacob Chen > >> > >> This commit adds a subdev driver for Rockchip MIPI Synopsys D

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Borislav Petkov
On Thu, Aug 15, 2019 at 10:21:59AM -0700, Luck, Tony wrote: > Like this? Actually, I was thinking you'd put it above the defines in the file intel-family.h itself so that *everyone* who wants to add a model, sees it first and while that explanation below is very nice... > +The CPU model number on

RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-15 Thread Leo Li
> -Original Message- > From: Biwen Li > Sent: Wednesday, August 14, 2019 11:15 PM > To: Leo Li ; a.zu...@towertech.it; > alexandre.bell...@bootlin.com > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock

Re: clk/clk-next boot bisection: v5.3-rc1-79-g31f58d2f58cb on sun8i-h3-libretech-all-h3-cc

2019-08-15 Thread Stephen Boyd
Quoting Mark Brown (2019-08-15 04:26:14) > On Wed, Aug 14, 2019 at 09:02:20PM -0700, Stephen Boyd wrote: > > Quoting kernelci.org bot (2019-08-14 20:35:25) > > > > clk/clk-next boot bisection: v5.3-rc1-79-g31f58d2f58cb on > > > sun8i-h3-libretech-all-h3-cc > > > If this is the only board that fa

Re: [PATCHv6 25/36] vdso: Introduce vdso_static_branch_unlikely()

2019-08-15 Thread Thomas Gleixner
On Thu, 15 Aug 2019, Dmitry Safonov wrote: > From: Andrei Vagin > > As it has been discussed on timens RFC, adding a new conditional branch > `if (inside_time_ns)` on VDSO for all processes is undesirable. > > Addressing those problems, there are two versions of VDSO's .so: > for host tasks (wi

[RFC] drm: Bump encoder limit from 32 to 64

2019-08-15 Thread Lyude Paul
Assuming that GPUs would never have even close to 32 separate video encoders is quite honestly a pretty reasonable assumption. Unfortunately we do not live in a reasonable world, as it looks like it is actually possible to find devices that will create more drm_encoder objects then this. Case in po

Re: [PATCH 04/15] mm: remove the pgmap field from struct hmm_vma_walk

2019-08-15 Thread Jerome Glisse
On Wed, Aug 14, 2019 at 07:48:28AM -0700, Dan Williams wrote: > On Wed, Aug 14, 2019 at 6:28 AM Jason Gunthorpe wrote: > > > > On Wed, Aug 14, 2019 at 09:38:54AM +0200, Christoph Hellwig wrote: > > > On Tue, Aug 13, 2019 at 06:36:33PM -0700, Dan Williams wrote: > > > > Section alignment constraint

[PATCH] wimax/i2400m: fix a memory leak bug

2019-08-15 Thread Wenwen Wang
In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup() to hold the original command line options. Then, the options are parsed. However, if an error occurs during the parsing process, 'options_orig' is not deallocated, leading to a memory leak bug. To fix this issue, free 'option

Re: INFO: task hung in tls_sw_release_resources_tx

2019-08-15 Thread syzbot
syzbot has bisected this bug to: commit 130b392c6cd6b2aed1b7eb32253d4920babb4891 Author: Dave Watson Date: Wed Jan 30 21:58:31 2019 + net: tls: Add tls 1.3 support bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=118e8dee60 start commit: 6d5afe20 sctp: fix memleak i

Re: [PATCH v5 05/18] watchdog: cpwd: use generic compat_ptr_ioctl

2019-08-15 Thread Guenter Roeck
On Wed, Aug 14, 2019 at 10:42:32PM +0200, Arnd Bergmann wrote: > The cpwd_compat_ioctl() contains a bogus mutex that dates > back to a leftover BKL instance. > > Simplify the implementation by using the new compat_ptr_ioctl() > helper function that will do the right thing for all calls > here. >

Re: [PATCH v2 3/9] drm: Rename drm_bridge_timings to drm_timings

2019-08-15 Thread Laurent Pinchart
Hi Greg, On Thu, Aug 15, 2019 at 04:53:00PM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 15, 2019 at 02:31:26PM +, Fabrizio Castro wrote: > > On 15 August 2019 15:15, Laurent Pinchart wrote: > > > On Thu, Aug 15, 2019 at 04:04:00PM +0200, Greg Kroah-Hartman wrote: > > > > On Thu, Aug 15, 201

Re: [PATCH v2 04/22] watchdog: ziirave_wdt: Don't bail out on unexpected timeout value

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:48PM -0700, Andrey Smirnov wrote: > Reprogramming bootloader on watchdog MCU will result in reported > default timeout value of "0". That in turn will be unnecessarily > rejected by the driver as invalid device (-ENODEV). Simplify probe to > read stored timeout value,

Re: [PATCH v8 11/14] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

2019-08-15 Thread Laurent Pinchart
Hi Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42:53PM -0300, Helen Koike wrote: > From: Jacob Chen > > Add DT bindings documentation for Rockchip MIPI D-PHY RX > > Signed-off-by: Jacob Chen > Reviewed-by: Rob Herring > [update for upstream] > Signed-off-by: Helen Koike > >

Re: [PATCH v2 06/22] watchdog: ziirave_wdt: Simplify ziirave_firm_write_pkt()

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:50PM -0700, Andrey Smirnov wrote: > There no reason why ziirave_firm_write_pkt() has to take firmware > data via 'struct ihex_binrec' and it can just take address, data pointer > and data length as individual arguments. Make this change to allow us > to drastically sim

Re: [PATCH v2 07/22] watchdog: ziirave_wdt: Check packet length only once

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:51PM -0700, Andrey Smirnov wrote: > We don't need to check for packet length more than once, so drop the > extra check in ziirave_firm_upload(). While at it move the check at > the very start of __ziirave_firm_write_pkt(), as to not waste any time > preparing a packet

Re: [PATCH RFC tip/core/rcu 14/14] rcu/nohz: Make multi_cpu_stop() enable tick on all online CPUs

2019-08-15 Thread Joel Fernandes
On Thu, Aug 15, 2019 at 10:23:51AM -0700, Paul E. McKenney wrote: > On Thu, Aug 15, 2019 at 11:07:35AM -0400, Joel Fernandes wrote: > > On Wed, Aug 14, 2019 at 03:05:16PM -0700, Paul E. McKenney wrote: > > [snip] > > > > > If so, perhaps that monitoring could periodically invoke an RCU > > > > > f

Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use

2019-08-15 Thread Kees Cook
On Wed, Jul 31, 2019 at 01:02:07PM -0700, Kees Cook wrote: > On Wed, Jul 31, 2019 at 08:48:32PM +0200, Peter Zijlstra wrote: > > On Wed, Jul 31, 2019 at 11:24:36AM -0700, h...@zytor.com wrote: > > > >> > +/* > > > >> > + * Add the pseudo keyword 'fallthrough' so case statement blocks > > > >> > + *

Re: [PATCH v2 08/22] watchdog: ziirave_wdt: Skip zeros when calculating checksum

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:52PM -0700, Andrey Smirnov wrote: > Zeros don't contribute anything to checksum value, so we can skip > unused portion of the packet when calculating its checksum. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc:

Re: [PATCH v2 09/22] watchdog: ziirave_wdt: Fix incorrect use of ARRAY_SIZE

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:53PM -0700, Andrey Smirnov wrote: > Both memset() and ziirave_firm_write_block_data() expect length in > bytes as an argument, not a number of elements in array. It just > happens that in this particular case both values are equal. Modify the > code to use sizeof() ins

Re: [PATCH v2 10/22] watchdog: ziirave_wdt: Zero out only what's necessary

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:54PM -0700, Andrey Smirnov wrote: > Instead of zeroing out all of the packet and then overwriting a > significant portion of those zeros via memcpy(), zero out only a > portion of the packet that is known to not contain any data. > > Signed-off-by: Andrey Smirnov > C

Re: [PATCH v3 1/9] soc: samsung: Add exynos chipid driver support

2019-08-15 Thread Krzysztof Kozlowski
On Tue, Aug 13, 2019 at 05:08:19PM +0200, Sylwester Nawrocki wrote: > From: Pankaj Dubey > > Exynos SoCs have Chipid, for identification of product IDs and SoC > revisions. This patch intends to provide initialization code for all > these functionalities, at the same time it provides some sysfs e

Re: [PATCH v2 11/22] watchdog: ziirave_wdt: Make use of put_unaligned_le16

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:55PM -0700, Andrey Smirnov wrote: > Instead of doing this explicitly use put_unaligned_le16() to place > 16-bit address value into command payload. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc: linux-watch...@v

Re: [PATCH v2 12/22] watchdog: ziirave_wdt: Don't check if ihex record length is zero

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:56PM -0700, Andrey Smirnov wrote: > Ihex_next_binrec() will return NULL if next record's 'len' is zero, so > explicit checks for that in the driver are unnecessary. Drop them. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramste

Re: [PATCH v2 13/22] watchdog: ziirave_wdt: Don't read out more than 'len' firmware bytes

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:57PM -0700, Andrey Smirnov wrote: > We only compare first 'len' bytes of read firmware, so we don't need > to read more that that. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc: linux-watch...@vger.kernel.org >

[PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang

2019-08-15 Thread Nathan Huckleberry
Clang is updating to support -Wimplicit-fallthrough on C https://reviews.llvm.org/D64838. Since clang does not support the comment version of fallthrough annotations this update causes an additional 50k warnings. Most of these warnings (>49k) are duplicates from header files. This patch is intende

Re: [PATCH v2 14/22] watchdog: ziirave_wdt: Don't try to program readonly flash

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:58PM -0700, Andrey Smirnov wrote: > Bootloader code will ignore any attempts to write data to any flash > area outside of [ZIIRAVE_FIRM_FLASH_MEMORY_START; > ZIIRAVE_FIRM_FLASH_MEMORY_END]. Firmware update code already have an > appropriate check to skip those areas wh

Re: [PATCH v2 15/22] watchdog: ziirave_wdt: Fix misleading error message

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:08:59PM -0700, Andrey Smirnov wrote: > Fix misleading error message in ziirave_wdt_init_duration(). Saying > "unable to set ..." implies that an attempt at communication with > watchdog device has taken palce and was not successful. In this case, > however, all it indicat

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

2019-08-15 Thread Krzysztof Kozlowski
On Tue, Aug 13, 2019 at 05:08:20PM +0200, Sylwester Nawrocki wrote: > Convert the driver to use regmap API in order to allow other > drivers, like ASV, to access the CHIPID registers. > > This patch adds definition of selected CHIPID register offsets > and register bit fields for Exynos5422 SoC. >

Re: [PATCH v2 16/22] watchdog: ziirave_wdt: Fix JUMP_TO_BOOTLOADER payload

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:09:00PM -0700, Andrey Smirnov wrote: > Bootloader firmware expects the following traffic for > JUMP_TO_BOOTLOADER: > > S Addr Wr [A] 0x0c [A] 0x01 [A] P > > using ziirave_firm_write_byte() will result in > > S Addr Wr [A] 0x0c [A] 0x01 [A] 0x01 [A] P > > which happens

Re: [PATCH bpf-next v2 2/3] xdp: xdp_umem: replace kmap on vmap for umem map

2019-08-15 Thread Jonathan Lemon
On 15 Aug 2019, at 5:13, Ivan Khoronzhuk wrote: For 64-bit there is no reason to use vmap/vunmap, so use page_address as it was initially. For 32 bits, in some apps, like in samples xdpsock_user.c when number of pgs in use is quite big, the kmap memory can be not enough, despite on this, kmap lo

Re: [PATCH v2 17/22] watchdog: ziirave_wdt: Fix DOWNLOAD_END payload

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:09:01PM -0700, Andrey Smirnov wrote: > Bootloader firmware expects the following traffic for DOWNLOAD_END: > > S Addr Wr [A] 0x11 [A] P > > using ziirave_firm_write_byte() will result in > > S Addr Wr [A] 0x11 [A] 0x01 [A] 0x01 [A] P > > which happens to work because

Re: [PATCH v2 18/22] watchdog: ziirave_wdt: Fix RESET_PROCESSOR payload

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:09:02PM -0700, Andrey Smirnov wrote: > Bootloader firmware expects the following traffic for > RESET_PROCESSOR: > > S Addr Wr [A] 0x0b [A] 0x01 [A] P > > using ziirave_firm_write_byte() will result in > > S Addr Wr [A] 0x0b [A] 0x01 [A] 0x01 [A] P > > which happens to

Re: [PATCH v2 19/22] watchdog: ziirave_wdt: Drop status polling code

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:09:03PM -0700, Andrey Smirnov wrote: > Bootloader firmware doesn't implement DOWNLOAD_START or > DOWNLOAD_PACKET in a non-blocking way. It will stretch the clock of > the first status byte read until the operation is complete. Polling > for the status is not really necess

Re: [PATCH v2 21/22] watchdog: ziirave_wdt: Drop ziirave_firm_write_block_data()

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:09:05PM -0700, Andrey Smirnov wrote: > There's only one user of ziirave_firm_write_block_data(), so we may as > well inline it. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc: linux-watch...@vger.kernel.org > Cc: li

Re: [PATCH v2 20/22] watchdog: ziirave_wdt: Fix DOWNLOAD_START payload

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:09:04PM -0700, Andrey Smirnov wrote: > Bootloader firmware expects the following traffic for DOWNLOAD_END: > > S Addr Wr [A] 0x10 [A] P > > using ziirave_firm_write_byte() will result in > > S Addr Wr [A] 0x10 [A] 0x01 [A] 0x01 [A] P > > which happens to work because

Re: [PATCH v3 7/9] soc: samsung: Update the CHIP ID DT binding documentation

2019-08-15 Thread Krzysztof Kozlowski
On Tue, Aug 13, 2019 at 05:08:25PM +0200, Sylwester Nawrocki wrote: > This patch adds documentation of a new optional "samsung,asv-bin" > property in the chipid device node and documents requirement of > "syscon" compatible string. These additions are needed to support > Exynos ASV (Adaptive Suppl

Re: [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-15 Thread Jason Gunthorpe
On Thu, Aug 15, 2019 at 07:42:07PM +0200, Michal Hocko wrote: > On Thu 15-08-19 13:56:31, Jason Gunthorpe wrote: > > On Thu, Aug 15, 2019 at 06:00:41PM +0200, Michal Hocko wrote: > > > > > > AFAIK 'GFP_NOWAIT' is characterized by the lack of __GFP_FS and > > > > __GFP_DIRECT_RECLAIM.. > > > > > >

Re: [PATCH v2 22/22] watchdog: ziirave_wdt: Update checked I2C functionality mask

2019-08-15 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 01:09:06PM -0700, Andrey Smirnov wrote: > Update checked I2C functionality mask to reflect all of the SMBus > primitives used by this driver. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Guenter Roeck > Cc: Rick Ramstetter > Cc: linux-watch...@vger.kernel.o

Re: [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-08-15 Thread Heiko Stübner
Hi Laurent, Am Donnerstag, 15. August 2019, 19:54:40 CEST schrieb Laurent Pinchart: > On Wed, Aug 07, 2019 at 10:37:55AM -0300, Helen Koike wrote: > > On 8/7/19 10:05 AM, Sakari Ailus wrote: > > > On Tue, Jul 30, 2019 at 03:42:46PM -0300, Helen Koike wrote: > > >> From: Jacob Chen > > >> > > >> T

Re: [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-15 Thread Jerome Glisse
On Thu, Aug 15, 2019 at 03:01:59PM -0300, Jason Gunthorpe wrote: > On Thu, Aug 15, 2019 at 01:39:22PM -0400, Jerome Glisse wrote: > > On Thu, Aug 15, 2019 at 02:35:57PM -0300, Jason Gunthorpe wrote: > > > On Thu, Aug 15, 2019 at 06:25:16PM +0200, Daniel Vetter wrote: > > > > > > > I'm not really w

Re: [PATCH v3 4/9] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS

2019-08-15 Thread Krzysztof Kozlowski
On Tue, Aug 13, 2019 at 05:08:22PM +0200, Sylwester Nawrocki wrote: > From: Pankaj Dubey > > As now we have chipid driver to initialize SoC related information > let's include it in build by default. > > Signed-off-by: Pankaj Dubey > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Bartlomiej

Re: [PATCH v3 5/9] ARM64: EXYNOS: enable exynos_chipid for ARCH_EXYNOS

2019-08-15 Thread Krzysztof Kozlowski
On Tue, Aug 13, 2019 at 05:08:23PM +0200, Sylwester Nawrocki wrote: > From: Pankaj Dubey > > This patch enables exynos_chipid driver for ARCH_EXYNOS > based SoC. > > Signed-off-by: Pankaj Dubey > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Sylwester Nawrocki > --- > Changes sinc

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Luck, Tony
On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > On Thu, Aug 15, 2019 at 10:21:59AM -0700, Luck, Tony wrote: > > Like this? > > Actually, I was thinking you'd put it above the defines in the file > intel-family.h itself so that *everyone* who wants to add a model, sees > it first

[GIT PULL 2/3] bcm2835-defconfig-next-2019-08-15

2019-08-15 Thread Stefan Wahren
Hi Florian, The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the git repository at: git://github.com/anholt/linux tags/bcm2835-defconfig-next-2019-08-15 for you to fetch changes up to 4c6f5d4038af2c73326

[GIT PULL 1/3] bcm2835-dt-next-2019-08-15

2019-08-15 Thread Stefan Wahren
Hi Florian, The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the git repository at: git://github.com/anholt/linux tags/bcm2835-dt-next-2019-08-15 for you to fetch changes up to 60c833d5664e1b3f71c4471233

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Alex Deucher
On Thu, Aug 15, 2019 at 12:19 PM wrote: > > > -Original Message- > > From: Takashi Iwai > > Sent: Thursday, August 15, 2019 9:57 AM > > To: Alex Deucher > > Cc: Karol Herbst; Limonciello, Mario; nouveau; Rafael J . Wysocki; LKML; > > dri-devel; > > Linux ACPI Mailing List; Alex Hung; Ben

Re: [PATCH v2] selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue

2019-08-15 Thread David Miller
From: Anders Roxell Date: Thu, 15 Aug 2019 09:58:26 +0200 > When running tcp_fastopen_backup_key.sh the following issue was seen in > a busybox environment. > ./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected > > Shellcheck showed the following issue. > $ shellcheck tools/te

[GIT PULL 3/3] bcm2835-defconfig-64-next-2019-08-15

2019-08-15 Thread Stefan Wahren
Hi Florian, The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the git repository at: git://github.com/anholt/linux tags/bcm2835-defconfig-64-next-2019-08-15 for you to fetch changes up to e2dd73ac4440f714

Re: [PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-15 Thread Borislav Petkov
On Thu, Aug 15, 2019 at 11:30:55AM -0700, Luck, Tony wrote: > On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > > On Thu, Aug 15, 2019 at 10:21:59AM -0700, Luck, Tony wrote: > > > Like this? > > > > Actually, I was thinking you'd put it above the defines in the file > > intel-fami

Re: [PATCH RFC tip/core/rcu 14/14] rcu/nohz: Make multi_cpu_stop() enable tick on all online CPUs

2019-08-15 Thread Paul E. McKenney
On Thu, Aug 15, 2019 at 02:15:00PM -0400, Joel Fernandes wrote: > On Thu, Aug 15, 2019 at 10:23:51AM -0700, Paul E. McKenney wrote: > > On Thu, Aug 15, 2019 at 11:07:35AM -0400, Joel Fernandes wrote: > > > On Wed, Aug 14, 2019 at 03:05:16PM -0700, Paul E. McKenney wrote: > > > [snip] > > > > > > If

Re: [PATCH] wimax/i2400m: fix a memory leak bug

2019-08-15 Thread Liam R. Howlett
* Wenwen Wang [190815 14:05]: > In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup() > to hold the original command line options. Then, the options are parsed. > However, if an error occurs during the parsing process, 'options_orig' is > not deallocated, leading to a memory le

[PATCH v3] coresight: tmc-etr: Fix perf_data check.

2019-08-15 Thread Yabin Cui
When tracing etm data of multiple threads on multiple cpus through perf interface, each cpu has a unique etr_perf_buffer while sharing the same etr device. There is no guarantee that the last cpu starts etm tracing also stops last. This makes perf_data check fail. Fix it by checking etr_buf instea

Re: [PATCH v8 03/14] media: rkisp1: Add user space ABI definitions

2019-08-15 Thread Laurent Pinchart
Hi Helen, Thank you ofor the patch. On Tue, Jul 30, 2019 at 03:42:45PM -0300, Helen Koike wrote: > From: Jeffy Chen > > Add the header for userspace > > Signed-off-by: Jeffy Chen > Signed-off-by: Jacob Chen > [update for upstream] > Signed-off-by: Helen Koike > > --- > Hi, > > I don't hav

Re: [PATCH net-next] page_pool: remove unnecessary variable init

2019-08-15 Thread David Miller
From: Yunsheng Lin Date: Thu, 15 Aug 2019 20:41:00 +0800 > Remove variable initializations in functions that > are followed by assignments before use > > Signed-off-by: Yunsheng Lin Applied.

Re: [PATCH v5 2/2] RISC-V: Setup initial page tables in two stages

2019-08-15 Thread Alistair Francis
On Wed, 2019-07-10 at 17:05 -0700, Paul Walmsley wrote: > On Fri, 7 Jun 2019, Anup Patel wrote: > > > Currently, the setup_vm() does initial page table setup in one-shot > > very early before enabling MMU. Due to this, the setup_vm() has to > > map > > all possible kernel virtual addresses since i

Re: Add Ingenic X1000 SoC Support

2019-08-15 Thread Zhou Yanjie
Hi PrasannaKumar I am also trying to add a series of Ingenic's processors. I tested your code with the X1000 development board and it will get stuck in "Run /linuxrc as init process." As you speculate, last year the sold more than 500Ks of X1000/X1000E, and customers have big companies like Hone

Re: [PATCH v5 2/2] RISC-V: Setup initial page tables in two stages

2019-08-15 Thread David Abdurachmanov
On Thu, Aug 15, 2019 at 11:57 AM Alistair Francis wrote: > > On Wed, 2019-07-10 at 17:05 -0700, Paul Walmsley wrote: > > On Fri, 7 Jun 2019, Anup Patel wrote: > > > > > Currently, the setup_vm() does initial page table setup in one-shot > > > very early before enabling MMU. Due to this, the setup_

[PATCH] fsi: scom: Don't abort operations for minor errors

2019-08-15 Thread Eddie James
The scom driver currently fails out of operations if certain system errors are flagged in the status register; system checkstop, special attention, or recoverable error. These errors won't impact the ability of the scom engine to perform operations, so the driver should continue under these conditi

Re: [PATCH 0/3] software node: Introduce software_node_find_by_name()

2019-08-15 Thread Hans de Goede
Hi, On 15-08-19 13:28, Heikki Krogerus wrote: Hi, This helper makes it much more easier to access "external" nodes. This series looks good and I've also tested it and it works as it should (the usb role-sw is still found and controlled properly) on a device using the intel_cht_int33fe driver

Re: Add Ingenic X1000 SoC Support

2019-08-15 Thread Zhou Yanjie
Hi PrasannaKumar I am also trying to add a series of Ingenic's processors. I tested your code with the X1000 development board and it will get stuck in "Run /linuxrc as init process." As you speculate, last year the sold more than 500Ks of X1000/X1000E, and customers have big companies like Hone

Re: [PATCH bpf-next v2 2/3] xdp: xdp_umem: replace kmap on vmap for umem map

2019-08-15 Thread Ivan Khoronzhuk
On Thu, Aug 15, 2019 at 11:23:16AM -0700, Jonathan Lemon wrote: On 15 Aug 2019, at 5:13, Ivan Khoronzhuk wrote: For 64-bit there is no reason to use vmap/vunmap, so use page_address as it was initially. For 32 bits, in some apps, like in samples xdpsock_user.c when number of pgs in use is quite

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Arnd Bergmann
On Thu, Aug 15, 2019 at 4:04 PM Christoph Hellwig wrote: > > On Thu, Aug 15, 2019 at 10:15:12PM +1000, Dave Chinner wrote: > > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-ioctl-table > > > > Lots to like in that handful of patches. :) > > > > It can easily go before or aft

Re: [PATCHv6 22/36] x86/vdso: Add offsets page in vvar

2019-08-15 Thread Thomas Gleixner
On Thu, 15 Aug 2019, Dmitry Safonov wrote: > --- > arch/Kconfig | 5 +++ > arch/x86/Kconfig | 1 + > arch/x86/entry/vdso/vdso-layout.lds.S | 9 - > arch/x86/entry/vdso/vdso2c.c | 3 ++ > arch/x86/entry/vdso/vma.c | 12 +

Re: [PATCHv6 28/36] posix-clocks: Add align for timens_offsets

2019-08-15 Thread Thomas Gleixner
On Thu, 15 Aug 2019, Dmitry Safonov wrote: > Align offsets so that time namespace will work for ia32 applications on > x86_64 host. That's true for any 64 bit arch which supports 32bit user space and should be folded into the patch which introduces the offset store. > +/* > + * Time offsets need

Re: [RFC][Patch v12 1/2] mm: page_reporting: core infrastructure

2019-08-15 Thread Nitesh Narayan Lal
On 8/15/19 9:15 AM, Nitesh Narayan Lal wrote: > On 8/14/19 12:11 PM, Alexander Duyck wrote: >> On Wed, Aug 14, 2019 at 8:49 AM Nitesh Narayan Lal wrote: >>> On 8/12/19 2:47 PM, Alexander Duyck wrote: On Mon, Aug 12, 2019 at 6:13 AM Nitesh Narayan Lal wrote: > This patch introduce

Re: [PATCHv2] mm/migrate: clean up useless code in migrate_vma_collect_pmd()

2019-08-15 Thread Ralph Campbell
On 8/15/19 10:19 AM, Jerome Glisse wrote: On Wed, Aug 07, 2019 at 04:41:12PM +0800, Pingfan Liu wrote: Clean up useless 'pfn' variable. NAK there is a bug see below: Signed-off-by: Pingfan Liu Cc: "Jérôme Glisse" Cc: Andrew Morton Cc: Mel Gorman Cc: Jan Kara Cc: "Kirill A. Shutemov"

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Darrick J. Wong
On Thu, Aug 15, 2019 at 09:20:32PM +0200, Arnd Bergmann wrote: > On Thu, Aug 15, 2019 at 4:04 PM Christoph Hellwig wrote: > > > > On Thu, Aug 15, 2019 at 10:15:12PM +1000, Dave Chinner wrote: > > > > http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xfs-ioctl-table > > > > > > Lots to

Re: [PATCH] net/ncsi: Ensure 32-bit boundary for data cksum

2019-08-15 Thread David Miller
From: "Terry S. Duncan" Date: Tue, 13 Aug 2019 18:18:40 -0700 > The NCSI spec indicates that if the data does not end on a 32 bit > boundary, one to three padding bytes equal to 0x00 shall be present to > align the checksum field to a 32-bit boundary. > > Signed-off-by: Terry S. Duncan > --- >

Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration

2019-08-15 Thread Jason Gunthorpe
On Thu, Aug 15, 2019 at 11:26:46AM +0800, Jason Wang wrote: > > On 2019/8/13 下午7:57, Jason Gunthorpe wrote: > > On Tue, Aug 13, 2019 at 04:31:07PM +0800, Jason Wang wrote: > > > > > What kind of issues do you see? Spinlock is to synchronize GUP with MMU > > > notifier in this series. > > A GUP th

Re: [PATCH bpf-next v2 2/3] xdp: xdp_umem: replace kmap on vmap for umem map

2019-08-15 Thread Jonathan Lemon
On 15 Aug 2019, at 12:19, Ivan Khoronzhuk wrote: On Thu, Aug 15, 2019 at 11:23:16AM -0700, Jonathan Lemon wrote: On 15 Aug 2019, at 5:13, Ivan Khoronzhuk wrote: For 64-bit there is no reason to use vmap/vunmap, so use page_address as it was initially. For 32 bits, in some apps, like in sa

Re: [PATCH bpf-next v2 2/3] xdp: xdp_umem: replace kmap on vmap for umem map

2019-08-15 Thread Jonathan Lemon
On 15 Aug 2019, at 5:13, Ivan Khoronzhuk wrote: > For 64-bit there is no reason to use vmap/vunmap, so use page_address > as it was initially. For 32 bits, in some apps, like in samples > xdpsock_user.c when number of pgs in use is quite big, the kmap > memory can be not enough, despite on this

Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-15 Thread David Miller
From: Wenwen Wang Date: Tue, 13 Aug 2019 20:33:45 -0500 > In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and > 'rx_old' are not deallocated, leading to memory leaks. To fix this issue, > move the free statements after the if branch. > > Signed-off-by: Wenwen Wang Why wo

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-15 Thread Laurent Pinchart
Hi Hans, On Wed, Aug 07, 2019 at 12:39:17PM +0200, Hans Verkuil wrote: > On 8/6/19 8:51 PM, Helen Koike wrote: > > On 7/30/19 3:42 PM, Helen Koike wrote: > >> From: Jacob Chen > >> > >> Add the subdev driver for rockchip isp1. > >> > >> Signed-off-by: Jacob Chen > >> Signed-off-by: Shunqian Zhen

Re: [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-15 Thread Michal Hocko
On Thu 15-08-19 16:18:10, Jason Gunthorpe wrote: > On Thu, Aug 15, 2019 at 09:05:25PM +0200, Michal Hocko wrote: > > > This is what you claim and I am saying that fs_reclaim is about a > > restricted reclaim context and it is an ugly hack. It has proven to > > report false positives. Maybe it can

Re: [PATCH 4.19 00/91] 4.19.67-stable review

2019-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2019 at 08:58:55AM -0500, Daniel Díaz wrote: > Hello! > > On Thu, 15 Aug 2019 at 08:29, Guenter Roeck wrote: > > > > On 8/14/19 10:00 AM, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.19.67 release. > > > There are 91 patches in this series

Re: /sys/devices/system/cpu/vulnerabilities/ doesn't show all known CPU vulnerabilities

2019-08-15 Thread Kernel User
On Thu, 15 Aug 2019 11:03:35 +0200 (CEST) Thomas Gleixner wrote: > It's used to denote vulnerability classes and their mitigations: > > - Spectre v1 > - Spectre v2 > - Meltdown > - SSB > - L1TF > - MDS In the Wikipedia article there are: + Bounds Check Bypass (Spectre, Variant 1) +

Re: [PATCH] liquidio: add cleanup in octeon_setup_iq()

2019-08-15 Thread David Miller
From: Wenwen Wang Date: Wed, 14 Aug 2019 00:14:49 -0500 > If oct->fn_list.enable_io_queues() fails, no cleanup is executed, leading > to memory/resource leaks. To fix this issue, invoke > octeon_delete_instr_queue() before returning from the function. > > Signed-off-by: Wenwen Wang Applied.

Re: [PATCH 5.2 000/144] 5.2.9-stable review

2019-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2019 at 08:18:22AM -0700, Guenter Roeck wrote: > On Wed, Aug 14, 2019 at 06:59:16PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.2.9 release. > > There are 144 patches in this series, all will be posted as a response > > to this one. I

Re: [GIT PULL] xfs: fixes for 5.3-rc5

2019-08-15 Thread Linus Torvalds
Pulled. Just a quick note: On Thu, Aug 15, 2019 at 10:13 AM Darrick J. Wong wrote: > > - Convert more directory corruption debugging asserts to actual > EFSCORRUPTED returns instead of blowing up later on. The proper error code looks like an obvious improvement, but I do wonder if there should

Re: [PATCHv2] mm/migrate: clean up useless code in migrate_vma_collect_pmd()

2019-08-15 Thread Jerome Glisse
On Thu, Aug 15, 2019 at 12:23:44PM -0700, Ralph Campbell wrote: > > On 8/15/19 10:19 AM, Jerome Glisse wrote: > > On Wed, Aug 07, 2019 at 04:41:12PM +0800, Pingfan Liu wrote: > > > Clean up useless 'pfn' variable. > > > > NAK there is a bug see below: > > > > > > > > Signed-off-by: Pingfan Liu

[PATCH v2 2/2] media: vimc: Fix gpf in rmmod path when stream is active

2019-08-15 Thread Shuah Khan
If vimc module is removed while streaming is in progress, sensor subdev unregister runs into general protection fault when it tries to unregister media entities. This is a common subdev problem related to releasing pads from v4l2_device_unregister_subdev() before calling unregister. Unregister refe

[PATCH v2 0/2] Collapse vimc into single monolithic driver

2019-08-15 Thread Shuah Khan
vimc uses Component API to split the driver into functional components. The real hardware resembles a monolith structure than component and component structure added a level of complexity making it hard to maintain without adding any real benefit. The sensor is one vimc component that would makes

[PATCH v2 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-08-15 Thread Shuah Khan
vimc uses Component API to split the driver into functional components. The real hardware resembles a monolith structure than component and component structure added a level of complexity making it hard to maintain without adding any real benefit. The sensor is one vimc component that would makes

Re: [PATCH] KVM: x86/MMU: Zap all when removing memslot if VM has assigned device

2019-08-15 Thread Alex Williamson
On Thu, 15 Aug 2019 08:12:28 -0700 Sean Christopherson wrote: > Alex Williamson reported regressions with device assignment when KVM > changed its memslot removal logic to zap only the SPTEs for the memslot > being removed. The source of the bug is unknown at this time, and root > causing the is

Re: [PATCH RFC tip/core/rcu 14/14] rcu/nohz: Make multi_cpu_stop() enable tick on all online CPUs

2019-08-15 Thread Joel Fernandes
On Thu, Aug 15, 2019 at 11:39:37AM -0700, Paul E. McKenney wrote: > On Thu, Aug 15, 2019 at 02:15:00PM -0400, Joel Fernandes wrote: > > On Thu, Aug 15, 2019 at 10:23:51AM -0700, Paul E. McKenney wrote: > > > > [snip] > > > > > > > If so, perhaps that monitoring could periodically invoke an RCU > >

Re: [GIT PULL] xfs: fixes for 5.3-rc5

2019-08-15 Thread pr-tracker-bot
The pull request you sent on Thu, 15 Aug 2019 10:13:47 -0700: > git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-5.3-fixes-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a69e90512d9def6bd8064d84cff9ffd8b15eaa1b Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH] net: myri10ge: fix memory leaks

2019-08-15 Thread David Miller
From: Wenwen Wang Date: Wed, 14 Aug 2019 01:38:39 -0500 > In myri10ge_probe(), myri10ge_alloc_slices() is invoked to allocate slices > related structures. Later on, myri10ge_request_irq() is used to get an irq. > However, if this process fails, the allocated slices related structures are > not de

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-15 Thread Arnd Bergmann
On Thu, Aug 15, 2019 at 9:28 PM Darrick J. Wong wrote: > > On Thu, Aug 15, 2019 at 09:20:32PM +0200, Arnd Bergmann wrote: > > On Thu, Aug 15, 2019 at 4:04 PM Christoph Hellwig > > wrote: > > > > > > On Thu, Aug 15, 2019 at 10:15:12PM +1000, Dave Chinner wrote: > > > > > http://git.infradead.org/

Re: [PATCH 04/22] media: Move v4l2_fwnode_parse_link from v4l2 to driver base

2019-08-15 Thread Steve Longerbeam
On 8/14/19 4:15 PM, Russell King - ARM Linux admin wrote: On Wed, Aug 14, 2019 at 04:00:30PM -0700, Steve Longerbeam wrote: On 8/14/19 3:04 PM, Russell King - ARM Linux admin wrote: On Wed, Aug 14, 2019 at 12:04:41PM -0700, Steve Longerbeam wrote: On 8/14/19 3:30 AM, Russell King - ARM Lin

[PATCHSET v2] writeback, memcg: Implement foreign inode flushing

2019-08-15 Thread Tejun Heo
Hello, Changes from v1[1]: * More comments explaining the parameters. * 0003-writeback-Separate-out-wb_get_lookup-from-wb_get_create.patch added and avoid spuriously creating missing wbs for foreign flushing. There's an inherent mismatch between memcg and writeback. The former trackes owne

Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-15 Thread Wenwen Wang
On Thu, Aug 15, 2019 at 3:34 PM David Miller wrote: > > From: Wenwen Wang > Date: Tue, 13 Aug 2019 20:33:45 -0500 > > > In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and > > 'rx_old' are not deallocated, leading to memory leaks. To fix this issue, > > move the free statem

Re: /sys/devices/system/cpu/vulnerabilities/ doesn't show all known CPU vulnerabilities

2019-08-15 Thread Thomas Gleixner
On Thu, 15 Aug 2019, Kernel User wrote: > On Thu, 15 Aug 2019 11:03:35 +0200 (CEST) Thomas Gleixner wrote: > > > It's used to denote vulnerability classes and their mitigations: > > > > - Spectre v1 > > - Spectre v2 > > - Meltdown > > - SSB > > - L1TF > > - MDS > > In the Wikipedia a

Re: [GIT PULL] xfs: fixes for 5.3-rc5

2019-08-15 Thread Darrick J. Wong
On Thu, Aug 15, 2019 at 12:38:33PM -0700, Linus Torvalds wrote: > Pulled. Just a quick note: > > On Thu, Aug 15, 2019 at 10:13 AM Darrick J. Wong wrote: > > > > - Convert more directory corruption debugging asserts to actual > > EFSCORRUPTED returns instead of blowing up later on. > > The prop

Re: [PATCH] wimax/i2400m: fix a memory leak bug

2019-08-15 Thread Wenwen Wang
On Thu, Aug 15, 2019 at 2:45 PM Liam R. Howlett wrote: > > * Wenwen Wang [190815 14:05]: > > In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup() > > to hold the original command line options. Then, the options are parsed. > > However, if an error occurs during the parsing pr

RE: [PATCH v2 0/7] AMD64 EDAC fixes

2019-08-15 Thread Ghannam, Yazen
> -Original Message- > From: linux-edac-ow...@vger.kernel.org On > Behalf Of Borislav Petkov > Sent: Friday, August 2, 2019 9:46 AM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 0/7] AMD64 EDAC fixes > ... > > So this still

<    1   2   3   4   5   6   7   8   9   >