[PATCH v2 5/6] irqchip/irq-pruss-intc: Implement irq_{get,set}_irqchip_state ops

2019-07-31 Thread Suman Anna
From: David Lechner This implements the irq_get_irqchip_state and irq_set_irqchip_state callbacks for the TI PRUSS INTC driver. The set callback can be used by drivers to "kick" a PRU by enabling a PRU system event. Example: irq_set_irqchip_state(irq, IRQCHIP_STATE_PENDING, true); Signed-o

[PATCH v2 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts

2019-07-31 Thread Suman Anna
The PRUSS INTC has a fixed number of output interrupt lines that are connected to a number of processors or other PRUSS instances or other devices (like DMA) on the SoC. The output interrupt lines 2 through 9 are usually connected to the main Arm host processor and are referred to as host interrupt

[PATCH v2 2/6] irqchip/irq-pruss-intc: Add a PRUSS irqchip driver for PRUSS interrupts

2019-07-31 Thread Suman Anna
From: "Andrew F. Davis" The Programmable Real-Time Unit Subsystem (PRUSS) contains a local interrupt controller (INTC) that can handle various system input events and post interrupts back to the device-level initiators. The INTC can support upto 64 input events with individual control configurati

Re: KASAN: invalid-free in tls_sk_proto_cleanup

2019-07-31 Thread Jakub Kicinski
On Wed, 31 Jul 2019 01:29:05 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:fde50b96 Add linux-next specific files for 20190726 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=15ea7f3fa0 > kernel config: htt

[PATCH] scsi: snic: remove redundant assignment to variable ret

2019-07-31 Thread Colin King
From: Colin Ian King Variable ret is being assigned with a value that is never read as there is return statement immediately afterwards. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/scsi/snic/snic_disc.c |

Re: [PATCH] tipc: compat: allow tipc commands without arguments

2019-07-31 Thread David Miller
Jon et al., please review. Thank you.

[PATCH] perf tools: Fix include paths in ui

2019-07-31 Thread Ian Rogers
These paths point to the wrong location but still work because they get picked up by a -I flag that happens to direct to the correct file. Fix paths to point to the correct location without -I flags. Signed-off-by: Ian Rogers --- tools/perf/ui/browser.c | 9 + tools/perf/ui/tui/prog

Re: [PATCH v2] net: phy: phy_led_triggers: Fix a possible null-pointer dereference in phy_led_trigger_change_speed()

2019-07-31 Thread David Miller
From: Jia-Ju Bai Date: Tue, 30 Jul 2019 16:08:13 +0800 > In phy_led_trigger_change_speed(), there is an if statement on line 48 > to check whether phy->last_triggered is NULL: > if (!phy->last_triggered) > > When phy->last_triggered is NULL, it is used on line 52: > led_trigger_event(&p

Re: [PATCH v6] PM / wakeup: show wakeup sources stats in sysfs

2019-07-31 Thread Tri Vo
On Wed, Jul 31, 2019 at 3:42 PM Rafael J. Wysocki wrote: > > On Thursday, August 1, 2019 12:31:16 AM CEST Tri Vo wrote: > > On Wed, Jul 31, 2019 at 3:17 PM Rafael J. Wysocki > > wrote: > > > > > > On Wednesday, July 31, 2019 11:59:32 PM CEST Stephen Boyd wrote: > > > > Quoting Tri Vo (2019-07-31

Re: [PATCH v6] PM / wakeup: show wakeup sources stats in sysfs

2019-07-31 Thread Rafael J. Wysocki
On Thu, Aug 1, 2019 at 12:42 AM Rafael J. Wysocki wrote: > > On Thursday, August 1, 2019 12:31:16 AM CEST Tri Vo wrote: > > On Wed, Jul 31, 2019 at 3:17 PM Rafael J. Wysocki > > wrote: > > > > > > On Wednesday, July 31, 2019 11:59:32 PM CEST Stephen Boyd wrote: > > > > Quoting Tri Vo (2019-07-31

Re: WARNING in __mmdrop

2019-07-31 Thread Jason Gunthorpe
On Wed, Jul 31, 2019 at 04:49:32PM +0800, Jason Wang wrote: > Yes, looking at the synchronization implemented by other MMU notifiers. > Vhost is even the simplest. I think that is only because it calls gup under a spinlock, which is, IMHO, not great. Jason

Re: [PATCH RFC 2/2] futex: Implement mechanism to wait on any of several futexes

2019-07-31 Thread Zebediah Figura
On 7/31/19 5:39 PM, Thomas Gleixner wrote: On Wed, 31 Jul 2019, Zebediah Figura wrote: On 7/31/19 7:06 AM, Peter Zijlstra wrote: On Tue, Jul 30, 2019 at 06:06:02PM -0400, Gabriel Krisman Bertazi wrote: This is a new futex operation, called FUTEX_WAIT_MULTIPLE, which allows a thread to wait on

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-31 Thread Rashmica Gupta
On Wed, 2019-07-31 at 14:08 +0200, Michal Hocko wrote: > On Tue 02-07-19 18:52:01, Rashmica Gupta wrote: > [...] > > > 2) Why it was designed, what is the goal of the interface? > > > 3) When it is supposed to be used? > > > > > > > > There is a hardware debugging facility (htm) on some power chi

Re: [PATCH v7 07/20] clk: tegra: clk-periph: Add save and restore support

2019-07-31 Thread Sowjanya Komatineni
On 7/31/19 3:44 AM, Dmitry Osipenko wrote: 31.07.2019 12:50, Dmitry Osipenko пишет: 31.07.2019 3:20, Sowjanya Komatineni пишет: This patch implements save and restore context for peripheral fixed clock ops, peripheral gate clock ops, sdmmc mux clock ops, and peripheral clock ops. During syst

Re: [PATCH v6] PM / wakeup: show wakeup sources stats in sysfs

2019-07-31 Thread Rafael J. Wysocki
On Thu, Aug 1, 2019 at 12:59 AM Tri Vo wrote: > > On Wed, Jul 31, 2019 at 3:42 PM Rafael J. Wysocki wrote: > > > > On Thursday, August 1, 2019 12:31:16 AM CEST Tri Vo wrote: > > > On Wed, Jul 31, 2019 at 3:17 PM Rafael J. Wysocki > > > wrote: > > > > > > > > On Wednesday, July 31, 2019 11:59:32

Re: [PATCH] net: stmmac: Use netif_tx_napi_add() for TX polling function

2019-07-31 Thread David Miller
From: Bartosz Golaszewski Date: Tue, 30 Jul 2019 13:38:14 +0200 > From: Frode Isaksen > > This variant of netif_napi_add() should be used from drivers > using NAPI to exclusively poll a TX queue. > > Signed-off-by: Frode Isaksen > Tested-by: Bartosz Golaszewski > Signed-off-by: Bartosz Golas

Re: [PATCH 1/2] arm64: dts: ls1028a: Fix GPIO work fail.

2019-07-31 Thread Li Yang
On Thu, Jul 18, 2019 at 4:59 AM Hui Song wrote: > Change the title to be something like: arm64: dts: ls1028a: fix gpio nodes > From: Song Hui > > Add ls1028a device specify compatible. Please submit a separate patch to update the device tree binding too. > Make gpio as little-endian deal. "U

RE: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-31 Thread Doug Smythies
On 2019.07.31 Viresh Kumar wrote: > To avoid reducing the frequency of a CPU prematurely, we skip reducing > the frequency if the CPU had been busy recently. > > This should not be done when the limits of the policy are changed, for > example due to thermal throttling. We should always get the freq

Re: [PATCH 3/3] arm64: dts: ls1088a: Revise gpio registers to little-endian

2019-07-31 Thread Li Yang
On Wed, May 29, 2019 at 3:32 AM Chuanhua Han wrote: > > Since fsl-ls1088a Soc GPIO registers are used as little endian, > the patch adds the little-endian attribute to each gpio node. > > Signed-off-by: Chuanhua Han Acked-by: Li Yang > --- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 4

Re: [PATCH v6] PM / wakeup: show wakeup sources stats in sysfs

2019-07-31 Thread Tri Vo
On Wed, Jul 31, 2019 at 4:10 PM Rafael J. Wysocki wrote: > > On Thu, Aug 1, 2019 at 12:59 AM Tri Vo wrote: > > > > On Wed, Jul 31, 2019 at 3:42 PM Rafael J. Wysocki > > wrote: > > > > > > On Thursday, August 1, 2019 12:31:16 AM CEST Tri Vo wrote: > > > > On Wed, Jul 31, 2019 at 3:17 PM Rafael J

[PATCH] ACPI: PM: Fix regression in acpi_device_set_power()

2019-07-31 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Commit f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in special cases") overlooked the fact that acpi_power_transition() may change the power.state value for the target device and if that happens, it may confuse acpi_device_set_power() and cause it to omit the

Re: [PATCH RFC 1/2] futex: Split key setup from key queue locking and read

2019-07-31 Thread Thomas Gleixner
On Tue, 30 Jul 2019, Gabriel Krisman Bertazi wrote: > split the futex key setup from the queue locking and key reading. This > is useful to support the setup of multiple keys at the same time, like > what is done in futex_requeue() and what will be done for the What has this to do with futex_req

[PATCH v3 3/4] nvmet-file: fix nvmet_file_flush() always returning an error

2019-07-31 Thread Logan Gunthorpe
Presently, nvmet_file_flush() always returns a call to errno_to_nvme_status() but that helper doesn't take into account the case when errno=0. So nvmet_file_flush() always returns an error code. All other callers of errno_to_nvme_status() check for success before calling it. To fix this, ensure e

[PATCH v3 2/4] nvmet-loop: Flush nvme_delete_wq when removing the port

2019-07-31 Thread Logan Gunthorpe
After calling nvme_loop_delete_ctrl(), the controllers will not yet be deleted because nvme_delete_ctrl() only schedules work to do the delete. This means a race can occur if a port is removed but there are still active controllers trying to access that memory. To fix this, flush the nvme_delete_

[PATCH v3 4/4] nvme-core: Fix extra device_put() call on error path

2019-07-31 Thread Logan Gunthorpe
In the error path for nvme_init_subsystem(), nvme_put_subsystem() will call device_put(), but it will get called again after the mutex_unlock(). The device_put() only needs to be called if device_add() fails. This bug caused a KASAN use-after-free error when adding and removing subsytems in a loo

[PATCH v3 1/4] nvmet: Fix use-after-free bug when a port is removed

2019-07-31 Thread Logan Gunthorpe
When a port is removed through configfs, any connected controllers are still active and can still send commands. This causes a use-after-free bug which is detected by KASAN for any admin command that dereferences req->port (like in nvmet_execute_identify_ctrl). To fix this, disconnect all active c

[PATCH v3 0/4] Varios NVMe Fixes

2019-07-31 Thread Logan Gunthorpe
Hey, These patches are just a resend of a bunch I've sent that haven't been picked up yet. I don't want them to get forgotten. Thanks, Logan -- Logan Gunthorpe (4): nvmet: Fix use-after-free bug when a port is removed nvmet-loop: Flush nvme_delete_wq when removing the port nvmet-file: fi

Re: [PATCH] watchdog:alim1535_wdt: Fix data race in ali_settimer() concerning ali_timeout_bits variable.

2019-07-31 Thread Mark Balantzyan
Hi Guenter, all, I don't really understand this focus on fixing theoretic/irrelevant race conditions in drivers which no one uses anymore. Maybe someone can enlighten me ? In conjunction with linuxtesting.org and The Linux Foundation, I've been enlisted to test and work

Re: [PATCH RFC 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction()

2019-07-31 Thread Sean Christopherson
On Wed, Jul 31, 2019 at 01:27:53PM -0700, Jim Mattson wrote: > On Wed, Jul 31, 2019 at 9:37 AM Paolo Bonzini wrote: > > > > On 31/07/19 15:50, Vitaly Kuznetsov wrote: > > > Jim Mattson writes: > > > > > >> On Thu, Jun 20, 2019 at 4:02 AM Vitaly Kuznetsov > > >> wrote: > > >>> > > >>> Regardless

Re: [PATCH RFC 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction()

2019-07-31 Thread Jim Mattson
On Wed, Jul 31, 2019 at 4:37 PM Sean Christopherson wrote: > At a glance, the full emulator models behavior correctly, e.g. see > toggle_interruptibility() and setters of ctxt->interruptibility. > > I'm pretty sure that leaves the EPT misconfig MMIO and APIC access EOI > fast paths as the only (V

Re: [PATCH v6] PM / wakeup: show wakeup sources stats in sysfs

2019-07-31 Thread Stephen Boyd
Quoting Rafael J. Wysocki (2019-07-31 16:10:38) > On Thu, Aug 1, 2019 at 12:59 AM Tri Vo wrote: > > > > On Wed, Jul 31, 2019 at 3:42 PM Rafael J. Wysocki > > wrote: > > > > > > That's not my point (see below). > > > > > > > > > > + if (id < 0) > > > > > > > + return id; > > >

Re: [PATCH v3 1/4] nvmet: Fix use-after-free bug when a port is removed

2019-07-31 Thread Chaitanya Kulkarni
Looks good. Reviewed-by : Chaitanya Kulkarni On 07/31/2019 04:36 PM, Logan Gunthorpe wrote: > When a port is removed through configfs, any connected controllers > are still active and can still send commands. This causes a > use-after-free bug which is detected by KASAN for any admin command > t

Re: [PATCH v3 2/4] nvmet-loop: Flush nvme_delete_wq when removing the port

2019-07-31 Thread Chaitanya Kulkarni
Looks good. Reviewed-by : Chaitanya Kulkarni On 07/31/2019 04:35 PM, Logan Gunthorpe wrote: > After calling nvme_loop_delete_ctrl(), the controllers will not > yet be deleted because nvme_delete_ctrl() only schedules work > to do the delete. > > This means a race can occur if a port is removed b

Re: [PATCH v3 4/4] nvme-core: Fix extra device_put() call on error path

2019-07-31 Thread Chaitanya Kulkarni
Looks good. Reviewed-by : Chaitanya Kulkarni On 07/31/2019 04:36 PM, Logan Gunthorpe wrote: > In the error path for nvme_init_subsystem(), nvme_put_subsystem() > will call device_put(), but it will get called again after the > mutex_unlock(). > > The device_put() only needs to be called if devic

Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use

2019-07-31 Thread Miguel Ojeda
On Wed, Jul 31, 2019 at 11:01 PM wrote: > > The standard is moving toward adding this as an attribute with the > [[fallthrough]] syntax; it is in C++17, not sure when it will be in C be if > it isn't already. Not yet, but it seems to be coming: http://www.open-std.org/jtc1/sc22/wg14/www/docs

Re: [PATCH RFC 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction()

2019-07-31 Thread Sean Christopherson
On Wed, Jul 31, 2019 at 04:45:21PM -0700, Jim Mattson wrote: > On Wed, Jul 31, 2019 at 4:37 PM Sean Christopherson > wrote: > > > At a glance, the full emulator models behavior correctly, e.g. see > > toggle_interruptibility() and setters of ctxt->interruptibility. > > > > I'm pretty sure that le

Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use

2019-07-31 Thread Miguel Ojeda
On Thu, Aug 1, 2019 at 12:07 AM Joe Perches wrote: > > Note also that this doesn't actually _use_ fallthrough > it just reserves it. If we are reserving it, we should be giving a compile error instead. I don't see how users will understand they shouldn't use it just yet (it is the same as adding

Re: [PATCH RFC 1/2] futex: Split key setup from key queue locking and read

2019-07-31 Thread Gabriel Krisman Bertazi
Thomas Gleixner writes: > On Tue, 30 Jul 2019, Gabriel Krisman Bertazi wrote: > >> split the futex key setup from the queue locking and key reading. This >> is useful to support the setup of multiple keys at the same time, like >> what is done in futex_requeue() and what will be done for the > >

Re: [PATCH RFC 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction()

2019-07-31 Thread Paolo Bonzini
On 01/08/19 01:56, Sean Christopherson wrote: > On Wed, Jul 31, 2019 at 04:45:21PM -0700, Jim Mattson wrote: >> On Wed, Jul 31, 2019 at 4:37 PM Sean Christopherson >> wrote: >> >>> At a glance, the full emulator models behavior correctly, e.g. see >>> toggle_interruptibility() and setters of ctxt-

Re: [PATCH] powerpc: Support CMDLINE_EXTEND

2019-07-31 Thread Chris Packham
On Wed, 2019-07-31 at 09:23 +0200, Christophe Leroy wrote: > > Le 30/07/2019 à 23:10, Chris Packham a écrit : > > > > Hi Christophe, > > > > On Tue, 2019-07-30 at 09:02 +0200, Christophe Leroy wrote: > > > > > > > > > Le 24/07/2019 à 07:33, Chris Packham a écrit : > > > > > > > > > > > > Dev

Re: [PATCH RFC 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction()

2019-07-31 Thread Jim Mattson
On Wed, Jul 31, 2019 at 5:13 PM Paolo Bonzini wrote: > > On 01/08/19 01:56, Sean Christopherson wrote: > > On Wed, Jul 31, 2019 at 04:45:21PM -0700, Jim Mattson wrote: > >> On Wed, Jul 31, 2019 at 4:37 PM Sean Christopherson > >> wrote: > >> > >>> At a glance, the full emulator models behavior co

Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf

2019-07-31 Thread Scott Branden
Hi Greg, I am now back from leave to continue this patch.  Comment below. On 2019-05-23 10:22 p.m., Greg Kroah-Hartman wrote: On Thu, May 23, 2019 at 10:01:38PM -0700, Scott Branden wrote: On 2019-05-23 9:54 a.m., Greg Kroah-Hartman wrote: On Thu, May 23, 2019 at 09:36:02AM -0700, Scott Brand

RE: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-31 Thread Doug Smythies
Hi Viresh, Summary: The old way, using UINT_MAX had two purposes: first, as a "need to do a frequency update" flag; but also second, to force any subsequent old/new frequency comparison to NOT be "the same, so why bother actually updating" (see: sugov_update_next_freq). All patches so far have be

[RFC 1/9] platform/x86: huawei-wmi: Rename guid and driver name

2019-07-31 Thread Ayman Bagabas
Use WMI device UID, AMW0 has a UID of HWMI. WMI0 is the device name and doesn't have a UID so keep it as it is. Change module description to reflect the upcoming changes. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei-wmi.c | 14 -- 1 file changed, 8 insertions(+), 6 d

Re: [PATCH RFC 1/2] futex: Split key setup from key queue locking and read

2019-07-31 Thread Gabriel Krisman Bertazi
Gabriel Krisman Bertazi writes: > Thomas Gleixner writes: >> What has this to do with futex_requeue()? Absolutely nothing unleass you >> can reused that code there, which I doubt. > >I think it could be reused there Though I admit to not having tried it out. I suppose I can just drop the refer

Re: [PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications

2019-07-31 Thread Paul Moore
On Wed, Jul 31, 2019 at 1:26 PM Casey Schaufler wrote: > On 7/31/2019 8:34 AM, Aaron Goidel wrote: > > As of now, setting watches on filesystem objects has, at most, applied a > > check for read access to the inode, and in the case of fanotify, requires > > CAP_SYS_ADMIN. No specific security hook

Re: [PATCH RFC 1/2] futex: Split key setup from key queue locking and read

2019-07-31 Thread Thomas Gleixner
On Wed, 31 Jul 2019, Gabriel Krisman Bertazi wrote: > Thomas Gleixner writes: > > > On Tue, 30 Jul 2019, Gabriel Krisman Bertazi wrote: > > > >> split the futex key setup from the queue locking and key reading. This > >> is useful to support the setup of multiple keys at the same time, like > >>

Re: [PATCH RFC 2/2] futex: Implement mechanism to wait on any of several futexes

2019-07-31 Thread Thomas Gleixner
On Tue, 30 Jul 2019, Gabriel Krisman Bertazi wrote: > + retry: > + for (i = 0; i < count; i++) { > + qs[i].key = FUTEX_KEY_INIT; > + qs[i].bitset = wb[i].bitset; > + > + ret = get_futex_key(wb[i].uaddr, flags & FLAGS_SHARED, > +

Re: [PATCH v6] PM / wakeup: show wakeup sources stats in sysfs

2019-07-31 Thread Stephen Boyd
Quoting Stephen Boyd (2019-07-31 16:45:31) > > This approach also nicely detects duplicate wakeup source names in the > case that the string passed in to wakeup_source_register() is already > used on the virtual bus. This was clearly untested! Here's a better one. This is what I see on my device

RE: [PATCH v2 net] hv_sock: Fix hang when a connection is closed

2019-07-31 Thread Sunil Muthuswamy
> -Original Message- > From: Dexuan Cui > Sent: Tuesday, July 30, 2019 6:26 PM > To: Sunil Muthuswamy ; David Miller > ; net...@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; Michael Kelley > ; linux-hyp...@vger.kernel.org; linux- > ker.

[PATCH v3 2/5] RISC-V: Add riscv_isa reprensenting ISA features common across CPUs

2019-07-31 Thread Atish Patra
From: Anup Patel This patch adds riscv_isa integer to represent ISA features common across all CPUs. The riscv_isa is not same as elf_hwcap because elf_hwcap will only have ISA features relevant for user-space apps whereas riscv_isa will have ISA features relevant to both kernel and user-space ap

[PATCH v3 5/5] dt-bindings: Update the riscv,isa string description

2019-07-31 Thread Atish Patra
Since the RISC-V specification states that ISA description strings are case-insensitive, there's no functional difference between mixed-case, upper-case, and lower-case ISA strings. Thus, to simplify parsing, specify that the letters present in "riscv,isa" must be all lowercase. Suggested-by: Paul

[PATCH v3 3/5] RISC-V: Fix unsupported isa string info.

2019-07-31 Thread Atish Patra
Currently, kernel prints a info warning if any of the extensions from "mafdcsu" is missing in device tree. This is not entirely correct as Linux can boot with "f or d" extensions if kernel is configured accordingly. Moreover, it will continue to print the info string for future extensions such as h

[PATCH v3 1/5] RISC-V: Remove per cpu clocksource

2019-07-31 Thread Atish Patra
There is only one clocksource in RISC-V. The boot cpu initializes that clocksource. No need to keep a percpu data structure. Signed-off-by: Atish Patra --- drivers/clocksource/timer-riscv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clocksource/timer-riscv.

[PATCH v3 4/5] RISC-V: Export few kernel symbols

2019-07-31 Thread Atish Patra
Export few symbols used by kvm module. Without this, kvm can not be compiled as a module. Signed-off-by: Atish Patra --- arch/riscv/kernel/smp.c | 2 +- arch/riscv/kernel/time.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.

[PATCH v3 0/5] Miscellaneous fixes

2019-07-31 Thread Atish Patra
This patch series have some unrelated fixes related to clocksource, dt-bindings and isa strings. I combined them into series as most of them are prerequisite for kvm patch series. Changes from v2->v3: 1. Updated commit text of dt binding patch. 2. Removed couple of remaining uppercase usage. Cha

Re: [PATCH v3 0/4] Varios NVMe Fixes

2019-07-31 Thread Sagi Grimberg
Thanks, applied to nvme-5.3-rc

[patch V2 4/7] fs/jbd2: Remove jbd_trylock_bh_state()

2019-07-31 Thread Thomas Gleixner
No users. Signed-off-by: Thomas Gleixner Cc: linux-e...@vger.kernel.org Cc: "Theodore Ts'o" Cc: Jan Kara --- include/linux/jbd2.h |5 - 1 file changed, 5 deletions(-) --- a/include/linux/jbd2.h +++ b/include/linux/jbd2.h @@ -347,11 +347,6 @@ static inline void jbd_lock_bh_state(str

[patch V2 2/7] fs/buffer: Move BH_Uptodate_Lock locking into wrapper functions

2019-07-31 Thread Thomas Gleixner
Bit spinlocks are problematic if PREEMPT_RT is enabled, because they disable preemption, which is undesired for latency reasons and breaks when regular spinlocks are taken within the bit_spinlock locked region because regular spinlocks are converted to 'sleeping spinlocks' on RT. So RT replaces the

[patch V2 6/7] fs/jbd2: Make state lock a spinlock

2019-07-31 Thread Thomas Gleixner
Bit-spinlocks are problematic on PREEMPT_RT if functions which might sleep on RT, e.g. spin_lock(), alloc/free(), are invoked inside the lock held region because bit spinlocks disable preemption even on RT. A first attempt was to replace state lock with a spinlock placed in struct buffer_head and

[patch V2 0/7] fs: Substitute bit-spinlocks for PREEMPT_RT and debugging

2019-07-31 Thread Thomas Gleixner
Bit spinlocks are problematic if PREEMPT_RT is enabled. They disable preemption, which is undesired for latency reasons and breaks when regular spinlocks are taken within the bit_spinlock locked region because regular spinlocks are converted to 'sleeping spinlocks' on RT. Bit spinlocks are also no

[patch V2 1/7] locking/lockdep: Add Kconfig option for bit spinlocks

2019-07-31 Thread Thomas Gleixner
Some usage sites of bit spinlocks have a substitution with regular spinlocks which depends on CONFIG_PREEMPT_RT. But this substitution can also be used to expose these locks to the regular lock debugging infrastructure, e.g. lockdep. As this increases the size of affected data structures significa

[patch V2 3/7] fs/buffer: Substitute BH_Uptodate_Lock for RT and bit spinlock debugging

2019-07-31 Thread Thomas Gleixner
Bit spinlocks are problematic if PREEMPT_RT is enabled. They disable preemption, which is undesired for latency reasons and breaks when regular spinlocks are taken within the bit_spinlock locked region because regular spinlocks are converted to 'sleeping spinlocks' on RT. Substitute the BH_Uptodat

[patch V2 5/7] fs/jbd2: Simplify journal_unmap_buffer()

2019-07-31 Thread Thomas Gleixner
journal_unmap_buffer() checks first whether the buffer head is a journal. If so it takes locks and then invokes jbd2_journal_grab_journal_head() followed by another check whether this is journal head buffer. The double checking is pointless. Replace the initial check with jbd2_journal_grab_journa

[patch V2 7/7] fs/jbd2: Free journal head outside of locked region

2019-07-31 Thread Thomas Gleixner
On PREEMPT_RT bit-spinlocks have the same semantics as on PREEMPT_RT=n, i.e. they disable preemption. That means functions which are not safe to be called in preempt disabled context on RT trigger a might_sleep() assert. The journal head bit spinlock is mostly held for short code sequences with tr

Re: [PATCH 4.19 077/113] f2fs: avoid out-of-range memory access

2019-07-31 Thread Chao Yu
On 2019/8/1 3:11, Pavel Machek wrote: > Hi! > >> [ Upstream commit 56f3ce675103e3fb9e631cfb4131fc768bc23e9a ] >> >> blkoff_off might over 512 due to fs corrupt or security >> vulnerability. That should be checked before being using. >> >> Use ENTRIES_IN_SUM to protect invalid value in cur_data_blk

Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

2019-07-31 Thread Michael Ellerman
Nick Desaulniers writes: > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: > in function `_iwl_fw_dbg_apply_point': > dbg.c:(.text+0x827a): undefined reference to `__compiletime_assert_2387' This breakage is also seen in ol

Re: [PATCH RFC 2/2] futex: Implement mechanism to wait on any of several futexes

2019-07-31 Thread Zebediah Figura
On 7/31/19 7:45 PM, Thomas Gleixner wrote: If I assume a maximum of 65 futexes which got mentioned in one of the replies then this will allocate 7280 bytes alone for the futex_q array with a stock debian config which has no debug options enabled which would bloat the struct. Adding the futex_wait

Re: Build regressions/improvements in v5.3-rc2

2019-07-31 Thread Michael Ellerman
Geert Uytterhoeven writes: > Below is the list of build error/warning regressions/improvements in > v5.3-rc2[1] compared to v5.2[2]. > > Summarized: > - build errors: +10/-1 > - build warnings: +136/-133 > > JFYI, when comparing v5.3-rc2[1] to v5.3-rc1[3], the summaries are: > - build errors

[PATCH] ima: Allow to import the blacklisted cert signed by secondary CA cert

2019-07-31 Thread Jia Zhang
Similar to .ima, the cert imported to .ima_blacklist is able to be authenticated by a secondary CA cert. Signed-off-by: Jia Zhang --- include/keys/system_keyring.h| 6 ++ security/integrity/digsig.c | 6 -- security/integrity/ima/ima_mok.c | 2 +- 3 files changed, 7 insertions(+

[PATCH] enetc: Select PHYLIB while CONFIG_FSL_ENETC_VF is set

2019-07-31 Thread YueHaibing
Like FSL_ENETC, when CONFIG_FSL_ENETC_VF is set, we should select PHYLIB, otherwise building still fails: drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_open': enetc.c:(.text+0x2744): undefined reference to `phy_start' enetc.c:(.text+0x282c): undefined reference to `phy_disconnec

Re: [PATCH RFC 2/2] futex: Implement mechanism to wait on any of several futexes

2019-07-31 Thread Zebediah Figura
On 7/31/19 8:22 PM, Zebediah Figura wrote: On 7/31/19 7:45 PM, Thomas Gleixner wrote: If I assume a maximum of 65 futexes which got mentioned in one of the replies then this will allocate 7280 bytes alone for the futex_q array with a stock debian config which has no debug options enabled which w

[PATCH -next] intel_th: msu: Fix possible memory leak in mode_store()

2019-07-31 Thread Wei Yongjun
'mode' is malloced in mode_store() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: 615c164da0eb ("intel_th: msu: Introduce buffer interface") Signed-off-by: Wei Yongjun --- drivers/hwtracing/intel_th/msu.c | 4 +++- 1 file changed, 3

Re: [PATCH v2 08/22] staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES

2019-07-31 Thread Chao Yu
On 2019/7/31 23:57, Gao Xiang wrote: > CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting > and users have no idea about the change in behaviour. > > Let's remove the setting currently and could turn it > into a module parameter if it's really needed. > > Suggested-by: David Sterba > Signed-

Re: [RFC PATCH 0/7] xfs: add reflink & dedupe support for fsdax.

2019-07-31 Thread Shiyang Ruan
On 8/1/19 4:33 AM, Goldwyn Rodrigues wrote: On 19:49 31/07, Shiyang Ruan wrote: This patchset aims to take care of this issue to make reflink and dedupe work correctly in XFS. It is based on Goldwyn's patchsets: "v4 Btrfs dax support" and "Btrfs iomap". I picked up some patches related and

Re: [linux-sunxi] Re: [PATCH 1/1] nvmem: sunxi_sid: fix A64 SID controller support

2019-07-31 Thread Vasily Khoruzhick
On Wed, Jul 31, 2019 at 1:43 AM Chen-Yu Tsai wrote: > > On Wed, Jul 31, 2019 at 3:15 PM Stefan Mavrodiev wrote: > > > > Like in H3, A64 SID controller doesn't return correct data > > when using direct access. It appears that on A64, SID needs > > 8 bytes of word_size. > > > > Workaround is to ena

Re: [PATCH] ocfs: further debugfs cleanups

2019-07-31 Thread Joseph Qi
On 19/7/31 21:21, Greg Kroah-Hartman wrote: > There is no need to check return value of debugfs_create functions, but > the last sweep through ocfs missed a number of places where this was > happening. There is also no need to save the individual dentries for > the debugfs files, as everything

Re: [PATCH RFC 2/2] futex: Implement mechanism to wait on any of several futexes

2019-07-31 Thread Pierre-Loup A. Griffais
On 7/31/19 6:32 PM, Zebediah Figura wrote: On 7/31/19 8:22 PM, Zebediah Figura wrote: On 7/31/19 7:45 PM, Thomas Gleixner wrote: If I assume a maximum of 65 futexes which got mentioned in one of the replies then this will allocate 7280 bytes alone for the futex_q array with a stock debian conf

[PATCH -next] staging: rtl8723bs: remove set but not used variable 'bEEPROMCheck'

2019-07-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs//hal/odm_CfoTracking.c: In function 'odm_SetCrystalCap': drivers/staging/rtl8723bs//hal/odm_CfoTracking.c:14:7: warning: variable 'bEEPROMCheck' set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-

linux-next: build warnings after merge of the crypto tree

2019-07-31 Thread Stephen Rothwell
Hi all, After merging the crypto tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: scripts/Makefile.asm-generic:25: redundant generic-y found in arch/arm/include/asm/Kbuild: simd.h Introduced by commit 82cb54856874 ("asm-generic: make simd.h a mandatory include/a

[PATCH v2] powerpc: Support CMDLINE_EXTEND

2019-07-31 Thread Chris Packham
Bring powerpc in line with other architectures that support extending or overriding the bootloader provided command line. The current behaviour is most like CMDLINE_FROM_BOOTLOADER where the bootloader command line is preferred but the kernel config can provide a fallback so CMDLINE_FROM_BOOTLOADE

[PATCH] asm-generic: Remove redundant arch-specific rules for simd.h

2019-07-31 Thread Herbert Xu
On Thu, Aug 01, 2019 at 11:53:46AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the crypto tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > scripts/Makefile.asm-generic:25: redundant generic-y found in > arch/arm/include/asm/Kbuild: simd.h > > I

Re: [PATCH RFC] modpost: Support I2C Aliases from OF tables

2019-07-31 Thread Masahiro Yamada
Hi. On Thu, Aug 1, 2019 at 4:44 AM Wolfram Sang wrote: > > Hi Javier, > > thank you for providing the extra information. > > (And Kieran, thanks for the patch!) > > > The other option is to remove i2c_of_match_device() and don't make OF match > > to fallback to i2c_of_match_device_sysfs(). This i

Re: [PATCH v4] modpost: check for static EXPORT_SYMBOL* functions

2019-07-31 Thread Masahiro Yamada
On Wed, Jul 31, 2019 at 5:54 PM Masahiro Yamada wrote: > > Hi. > > > > On Wed, Jul 31, 2019 at 3:12 AM Denis Efremov wrote: > > > > This patch adds a check to warn about static EXPORT_SYMBOL* functions > > during the modpost. In most of the cases, a static symbol marked for > > exporting is an od

Re: [PATCH 2/2] cnic: Use refcount_t for refcount

2019-07-31 Thread Chuhong Yuan
Michael Chan 于2019年8月1日周四 上午1:58写道: > > On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote: > > > static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32 > > val) > > @@ -494,7 +494,7 @@ int cnic_register_driver(int ulp_type, struct > > cnic_ulp_ops *ulp_ops) > > } > >

Re: [PATCH] libfdt: reduce the number of headers included from libfdt_env.h

2019-07-31 Thread Masahiro Yamada
On Tue, Jun 18, 2019 at 1:21 AM Masahiro Yamada wrote: > > Currently, libfdt_env.h includes just for INT_MAX. > > pulls in a lots of broat. > > Thanks to commit 54d50897d544 ("linux/kernel.h: split *_MAX and *_MIN > macros into "), can be replaced with > . > > This saves including dozens of hea

Re: [PATCH v6 19/57] iio: Remove dev_err() usage after platform_get_irq()

2019-07-31 Thread Phil Reid
G'day Stephen, One comment below. On 31/07/2019 22:32, Stephen Boyd wrote: Quoting Phil Reid (2019-07-30 23:42:16) G'day Stephen, A comment unrelated to your change. On 31/07/2019 02:15, Stephen Boyd wrote: diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c index 32f

linux-next: manual merge of the sound-asoc tree with the sound tree

2019-07-31 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the sound-asoc tree got conflicts in: sound/soc/intel/skylake/skl-nhlt.c sound/soc/intel/skylake/skl.h between commit: 1169cbf6b98e ("ASoC: Intel: Skylake: use common NHLT module") from the sound tree and commit: bcc2a2dc3ba8 ("ASoC: Intel: Skylake:

Re: [PATCH] linux/bits.h: Add compile time sanity check of GENMASK inputs

2019-07-31 Thread Masahiro Yamada
On Thu, Aug 1, 2019 at 4:04 AM Rikard Falkeborn wrote: > > GENMASK() and GENMASK_ULL() are supposed to be called with the high bit > as the first argument and the low bit as the second argument. Mixing > them will return a mask with zero bits set. > > Recent commits show getting this wrong is not

Re: [PATCH v3] kbuild: Check for unknown options with cc-option usage in Kconfig and clang

2019-07-31 Thread Masahiro Yamada
On Wed, Jul 31, 2019 at 1:51 AM Masahiro Yamada wrote: > > On Wed, Jul 31, 2019 at 1:50 AM Nathan Chancellor > wrote: > > > > On Tue, Jul 30, 2019 at 09:48:03AM -0700, Stephen Boyd wrote: > > > If the particular version of clang a user has doesn't enable > > > -Werror=unknown-warning-option by de

Re: [PATCH] linux/bits.h: Add compile time sanity check of GENMASK inputs

2019-07-31 Thread Joe Perches
On Thu, 2019-08-01 at 11:50 +0900, Masahiro Yamada wrote: > On Thu, Aug 1, 2019 at 4:04 AM Rikard Falkeborn > wrote: > > GENMASK() and GENMASK_ULL() are supposed to be called with the high bit > > as the first argument and the low bit as the second argument. Mixing > > them will return a mask with

Re: [v7 2/2] gpio: aspeed: Add SGPIO driver

2019-07-31 Thread Andrew Jeffery
On Thu, 1 Aug 2019, at 05:32, Hongwei Zhang wrote: > Add SGPIO driver support for Aspeed AST2500 SoC. > > Signed-off-by: Hongwei Zhang > Reviewed-by: Andrew Jeffery Adding my Reviewed-by tag is a bit keen, I only gave it for the bindings on v6. However, having looked over the patch you've

Re: [RFC 2/2] arm64/mm: Enable device memory allocation and free for vmemmap mapping

2019-07-31 Thread Anshuman Khandual
On 07/31/2019 09:41 PM, Will Deacon wrote: > On Fri, Jun 28, 2019 at 10:14:43AM +0530, Anshuman Khandual wrote: >> This enables vmemmap_populate() and vmemmap_free() functions to incorporate >> struct vmem_altmap based device memory allocation and free requests. With >> this device memory with spec

[PATCH] tomoyo: Fix incorrect return value from tomoyo_find_next_domain()

2019-07-31 Thread Takeshi Misawa
When filename exceeds PATH_MAX, tomoyo_find_next_domain() retval is not ENAMETOOLONG, but ENOENT. Fix this by retuen kern_path() error. Signed-off-by: Takeshi Misawa --- Dear Tetsuo Handa I found unexpected return value from TOMOYO and try to create a patch. If this is not acceptable for securi

Re: [RFC 1/2] mm/sparsemem: Add vmem_altmap support in vmemmap_populate_basepages()

2019-07-31 Thread Anshuman Khandual
On 07/31/2019 09:40 PM, Will Deacon wrote: > On Fri, Jun 28, 2019 at 10:14:42AM +0530, Anshuman Khandual wrote: >> Generic vmemmap_populate_basepages() is used across platforms for vmemmap >> as standard or as fallback when huge pages mapping fails. On arm64 it is >> used for configs with ARM64_

Re: [PATCH v2 2/2] ARM: dts: aspeed: Add Mihawk BMC platform

2019-07-31 Thread Andrew Jeffery
Hi Ben, Comments inline below. Also apologies for the IBM/IPS mixup in the previous review, I've been corrected :) On Wed, 31 Jul 2019, at 17:17, Ben Pai wrote: > The Mihawk BMC is an ASPEED ast2500 based BMC that is part of an > OpenPower Power9 server. > > Signed-off-by: Ben Pai > --- > arch

[PATCH] perf tools: Fix a typo in Makefile

2019-07-31 Thread Masanari Iida
This patch fix a spelling typo in Makefile. Signed-off-by: Masanari Iida --- tools/perf/Documentation/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile index 6d148a40551c..adc5a7e44b98 100644 --- a/

[PATCH v3 1/3] KVM: Fix leak vCPU's VMCS value into other pCPU

2019-07-31 Thread Wanpeng Li
From: Wanpeng Li After commit d73eb57b80b (KVM: Boost vCPUs that are delivering interrupts), a five years old bug is exposed. Running ebizzy benchmark in three 80 vCPUs VMs on one 80 pCPUs Skylake server, a lot of rcu_sched stall warning splatting in the VMs after stress testing: INFO: rcu_s

[PATCH v3 2/3] KVM: LAPIC: Don't need to wakeup vCPU twice afer timer fire

2019-07-31 Thread Wanpeng Li
From: Wanpeng Li kvm_set_pending_timer() will take care to wake up the sleeping vCPU which has pending timer, don't need to check this in apic_timer_expired() again. Cc: Paolo Bonzini Cc: Radim Krčmář Signed-off-by: Wanpeng Li --- arch/x86/kvm/lapic.c | 8 1 file changed, 8 deletion

[PATCH v3 3/3] KVM: Check preempted_in_kernel for involuntary preemption

2019-07-31 Thread Wanpeng Li
From: Wanpeng Li preempted_in_kernel is updated in preempt_notifier when involuntary preemption ocurrs, it can be stale when the voluntarily preempted vCPUs are taken into account by kvm_vcpu_on_spin() loop. This patch lets it just check preempted_in_kernel for involuntary preemption. Cc: Pa

<    5   6   7   8   9   10   11   12   13   14   >