On 31/07/2019 16:34, Aurélien Aptel wrote:
> "Dan Carpenter" writes:
>> You're just turning off GCC's static analysis (and introducing false
>> positives) when you do that. We have seen bugs caused by this and never
>> seen any bugs prevented by this style.
>
> You've never seen bugs prevented b
On Wed, 2019-07-31 at 11:28 +0300, Leon Romanovsky wrote:
> On Wed, Jul 31, 2019 at 09:01:44AM +0100, Colin King wrote:
> > From: Colin Ian King
> >
> > There is a spelling mistake in a warning message, fix it.
> >
> > Signed-off-by: Colin Ian King
> > ---
> > drivers/infiniband/core/netlink.c
From: YueHaibing
While do COMPILE_TEST build without CONFIG_NETDEVICES,
we get Kconfig warning:
WARNING: unmet direct dependencies detected for PHYLIB
Depends on [n]: NETDEVICES [=n]
Selected by [y]:
- OCTEON_ETHERNET [=y] && STAGING [=y] && (CAVIUM_OCTEON_SOC && NETDEVICES
[=n] || COMPIL
Hi,
After commit "ACPI: PM: Allow transitions to D0 to occur in special cases”,
Thunderbolt on XPS 9380 spews the following when it runtime resumes:
[ 36.136554] pci_raw_set_power_state: 25 callbacks suppressed
[ 36.136558] pcieport :03:00.0: Refused to change power state,
currently
On Wed, Jul 31, 2019 at 8:22 AM Chuhong Yuan wrote:
>
> refcount_t is better for reference counters since its
> implementation can prevent overflows.
> So convert atomic_t ref counters to refcount_t.
>
> Signed-off-by: Chuhong Yuan
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 8 --
On Wed, Jul 31, 2019 at 01:32:16PM +0200, Ludovic Desroches wrote:
> > drivers/mmc/host/atmel-mci.c:2426:40: warning: this statement may fall
> > through [-Wimplicit-fallthrough=]
> >host->caps.need_notbusy_for_read_ops = 1;
> >~^~~
> > drivers/mmc/host/
From: Greg KH
Date: Wed, 31 Jul 2019 18:02:19 +0200
> From: YueHaibing
>
> While do COMPILE_TEST build without CONFIG_NETDEVICES,
> we get Kconfig warning:
>
> WARNING: unmet direct dependencies detected for PHYLIB
> Depends on [n]: NETDEVICES [=n]
> Selected by [y]:
> - OCTEON_ETHERNET
On Tue, Jul 16, 2019 at 07:13:00PM +0800, Leo Yan wrote:
> This patch implement regs_set_return_value() and
> override_function_with_return() to support function error injection
> for arm64.
>
> In the exception flow, arm64's general register x30 contains the value
> for the link register; so we c
the patch make some bugs because
> it's rather tricky.
>
> Could you test this patch?
It does help the situation a bit, but the recover speed is still way slower than
just reverting the commit "mm: account nr_isolated_xxx in
[isolate|putback]_lru_page". For example, on thi
On Fri, Jun 28, 2019 at 10:14:42AM +0530, Anshuman Khandual wrote:
> Generic vmemmap_populate_basepages() is used across platforms for vmemmap
> as standard or as fallback when huge pages mapping fails. On arm64 it is
> used for configs with ARM64_SWAPPER_USES_SECTION_MAPS applicable both for
> ARM
On Fri, Jun 28, 2019 at 10:14:43AM +0530, Anshuman Khandual wrote:
> This enables vmemmap_populate() and vmemmap_free() functions to incorporate
> struct vmem_altmap based device memory allocation and free requests. With
> this device memory with specific atlmap configuration can be hot plugged
> a
On Wed, Jul 31, 2019 at 07:42:35AM -0700, Mark Balantzyan wrote:
> This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
Checkpatch complains about the line length here.
Also, s/This patch rewrites the pc87413_wdt/Rewrite/
It is obvious that the description applies to this
I've actually been seeing worse behavior, in that I can't get Thunderbolt to
work at all with 5.3rc1 or 5.3rc2 on the 9380 system I have on hand, similar
messages related to link timeouts.
On Wed, Jul 31, 2019 at 03:35:20PM +0200, Geert Uytterhoeven wrote:
> Some TIF_* flags are documented in the comment block at the top, some
> next to their definitions, some in both places.
>
> Move all documentation to the individual definitions for consistency,
> and for easy lookup.
>
> Signed
On 07/28, Song Liu wrote:
>
> @@ -525,6 +527,9 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe,
> struct mm_struct *mm,
>
> /* dec_mm_counter for old_page */
> dec_mm_counter(mm, MM_ANONPAGES);
> +
> +
On Wed, Jul 31, 2019 at 05:30:35PM +0300, Alexander Shishkin wrote:
> +static void perf_put_aux_event(struct perf_event *event)
> +{
> + struct perf_event_context *ctx = event->ctx;
> + struct perf_cpu_context *cpuctx = __get_cpu_context(ctx);
> + struct perf_event *iter = NULL;
> +
> +
Hi Guenter,
If it's not too much too ask, I also propose to rewrite alim1535_wdt to
use the watchdog subsystem as I believe we are making progress toward the
similar end in pc87413_wdt, as my evaluation ends in some weeks.
Thank you,
Mark
The current make-install procedure leaves lots of garbage files that
aren't really firmware files in /lib/firmware.
Instead of copy-all-and-prune approach, copy only the listed files and
links in WHENCE by make-install for assuring only the proper firmware
files.
Signed-off-by: Takashi Iwai
---
On Wed, Jul 31, 2019 at 05:30:35PM +0300, Alexander Shishkin wrote:
> +static void perf_put_aux_event(struct perf_event *event)
> +{
> + struct perf_event_context *ctx = event->ctx;
> + struct perf_cpu_context *cpuctx = __get_cpu_context(ctx);
> + struct perf_event *iter = NULL;
> +
> +
On Mon, Jul 29, 2019 at 01:54:21PM +0100, Vincenzo Frascino wrote:
> Using an old .config in combination with "make oldconfig" can cause
> an incorrect detection of the compat compiler:
>
> $ grep CROSS_COMPILE_COMPAT .config
> CONFIG_CROSS_COMPILE_COMPAT_VDSO=""
>
> $ make oldconfig && make
> ar
Zdravstvujte! Vas interesuyut klientskie bazy dannyh?
On Tue, Jul 30, 2019 at 10:11:19AM -0700, Kees Cook wrote:
> On Sun, Jul 28, 2019 at 12:58:41AM +0900, Joonwon Kang wrote:
> > Before this, there were false negatives in the case where a struct
> > contains other structs which contain only function pointers because
> > of unreachable code in is_pur
Hello all,
I know this is a bit of an old thread, so apologies for being late to
the party. :-)
I would have a question about this:
> > > On 7/12/19 2:36 PM, Peter Zijlstra wrote:
> > > > On Fri, Jul 12, 2019 at 02:17:20PM +0200, Alexandre Chartre
> > > > wrote:
> > > > > On 7/12/19 1:44 PM, Pet
On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote:
> On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote:
> > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote:
> > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote:
> > > > fallthrough may become a pseudo reserved keyword
Hi,
On 31-Jul-19 2:06 PM, Anil Varughese wrote:
> Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify()
> because if UFSHCD resets the controller ip because of
> phy or device related errors then CDNS_UFS_REG_HCLKDIV
> is reset to default value and .setup_clock() is not
> called later in the sequ
On 31/07/19 15:50, Vitaly Kuznetsov wrote:
> Jim Mattson writes:
>
>> On Thu, Jun 20, 2019 at 4:02 AM Vitaly Kuznetsov wrote:
>>>
>>> Regardless of the way how we skip instruction, interrupt shadow needs to be
>>> cleared.
>>
>> This change is definitely an improvement, but the existing code see
> On Jul 31, 2019, at 9:16 AM, Oleg Nesterov wrote:
>
> On 07/28, Song Liu wrote:
>>
>> @@ -525,6 +527,9 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe,
>> struct mm_struct *mm,
>>
>> /* dec_mm_counter for old_page */
>> dec_
On 7/28/19 7:01 PM, Pavel Machek wrote:
> Hi!
>
>> Abstract
>>
>>
>> The modern servers allows multiple cores to run at range of frequencies
>> higher than rated range of frequencies. But the power budget of the system
>> inhibits sustaining these higher frequencies for longer duration
From: Thor Thayer
Newer versions (V2) of Altera/Intel FPGAs CvP have different PCI
Vendor Specific Capability offsets than the older (V1) Altera/FPGAs.
Most of the CvP registers and their bitfields remain the same
between both the older parts and the newer parts.
This patchset implements change
From: Thor Thayer
Newer Intel FPGAs have different Vendor Specific offsets than
legacy parts. Use PCI discovery to find the CvP registers.
Since the register positions remain the same, change the hard
coded address to a more flexible way of indexing registers
from the offset.
Adding new PCI read
From: Thor Thayer
Add Stratix10 specific functions that use a credit mechanism
to throttle data to the CvP FIFOs. Add a private structure
with function pointers for V1 vs V2 functions.
Signed-off-by: Thor Thayer
---
v2 Remove inline function declaration
Reverse Christmas Tree format for loca
From: Thor Thayer
In preparation for adding newer V2 parts that use a FIFO,
reorganize altera_cvp_chk_error() and change the write
function to block based.
V2 parts have a block size matching the FIFO while older
V1 parts write a 32 bit word at a time.
Signed-off-by: Thor Thayer
---
v2 Remove i
On 31/07/19 15:14, Vitaly Kuznetsov wrote:
> Paolo Bonzini writes:
>
>> On 31/07/19 13:27, Wanpeng Li wrote:
>>> From: Wanpeng Li
>>>
>>> kvm_set_pending_timer() will take care to wake up the sleeping vCPU which
>>> has pending timer, don't need to check this in apic_timer_expired() again.
>>
>
This tests clone3() with set_tid to see if all desired PIDs are working
as expected. The test tries to clone3() with a set_tid of -1, 1,
pid_max, a PID which is already in use and an unused PID. The same
tests are also running in PID namespace.
Signed-off-by: Adrian Reber
---
tools/testing/selft
The main motivation to add CLONE_SET_TID to clone3() is CRIU.
To restore a process with the same PID/TID CRIU currently uses
/proc/sys/kernel/ns_last_pid. It writes the desired (PID - 1) to
ns_last_pid and then (quickly) does a clone(). This works most of the
time, but it is racy. It is also slow
Some of the mipi dsi resets were called
IMX8MQ_RESET_MIPI_DIS_
instead of
IMX8MQ_RESET_MIPI_DSI_
Since they're DSI related this looks like a typo.
Guido Günther (2):
dt-bindings: reset: Fix typo in imx8mq resets
reset: imx7: Fix IMX8MQ_RESET_MIPI_DSI_ defines
drivers/reset/reset-imx7
Hi Mark,
On Wed, Jul 31, 2019 at 09:17:13AM -0700, Mark Balantzyan wrote:
> Hi Guenter,
>
> If it's not too much too ask, I also propose to rewrite alim1535_wdt to use
> the watchdog subsystem as I believe we are making progress toward the
> similar end in pc87413_wdt, as my evaluation ends in so
Some of the mipi dsi resets were called
IMX8MQ_RESET_MIPI_DIS__
instead of
IMX8MQ_RESET_MIPI_DSI__
Since they're DSI related this looks like a typo.
Signed-off-by: Guido Günther
---
include/dt-bindings/reset/imx8mq-reset.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Some of the mipi dsi resets were called
IMX8MQ_RESET_MIPI_DIS_
instead of
IMX8MQ_RESET_MIPI_DSI_
Since they're DSI related this looks like a typo.
I wasn't sure if this should be a single patch since it otherwise breaks
bisectability. I couldn't find any device trees using this yet.
Signe
Am Mittwoch, den 31.07.2019, 18:43 +0200 schrieb Guido Günther:
> Some of the mipi dsi resets were called
>
> IMX8MQ_RESET_MIPI_DIS_
>
> instead of
>
> IMX8MQ_RESET_MIPI_DSI_
>
> Since they're DSI related this looks like a typo.
>
> I wasn't sure if this should be a single patch since it o
Hi Adrian,
On 7/31/19 5:12 PM, Adrian Reber wrote:
[..]
> @@ -2530,14 +2530,12 @@ noinline static int copy_clone_args_from_user(struct
> kernel_clone_args *kargs,
> struct clone_args __user *uargs,
> size_t si
On Wed, Jul 31, 2019 at 05:30:36PM +0300, Alexander Shishkin wrote:
> diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
> index cfe256ca76df..6cf2a7ba822a 100644
> --- a/arch/x86/events/core.c
> +++ b/arch/x86/events/core.c
> @@ -1006,6 +1006,28 @@ static int collect_events(struct cpu_hw
On Wed, Jul 31, 2019 at 8:07 AM Martin Kaiser wrote:
>
> Add a binding for the Maxim Integrated MAX5432-MAX5435 family of digital
> potentiometers.
>
> Signed-off-by: Martin Kaiser
> ---
> changes in v4
> - fix the dt bindings
>- replace ic20 with i2c
>- document the reg property
>-
On Wed, Jul 31, 2019 at 6:40 AM Neil Armstrong wrote:
>
> Add a specific compatible for the Amlogic G12B bases A311D SoC used
> in the Khadas VIM3.
>
> Signed-off-by: Neil Armstrong
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 5 +
> 1 file changed, 5 insertions(+)
Reviewed-
On Wed, Jul 31, 2019 at 6:40 AM Neil Armstrong wrote:
>
> Add a specific compatible for the Amlogic G12B family based S922X SoC
> to differentiate with the A311D SoC from the same family.
>
> Signed-off-by: Neil Armstrong
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 1 +
> 1 file
On 7/31/19 5:49 PM, Dmitry Safonov wrote:
> Hi Adrian,
>
> On 7/31/19 5:12 PM, Adrian Reber wrote:
> [..]
>> @@ -2530,14 +2530,12 @@ noinline static int copy_clone_args_from_user(struct
>> kernel_clone_args *kargs,
>>struct clone_args __user *uargs,
>>
On Wed, Jul 31, 2019 at 6:40 AM Neil Armstrong wrote:
>
> From: Christian Hewitt
>
> The Khadas VIM3 uses the Amlogic S922X or A311S SoC, both based on the
> Amlogic G12B SoC family, on a board with the same form factor as the
> VIM/VIM2 models. It ships in two variants; basic and
> pro which dif
Hi Will,
Thanks for reviewing.
On Wed, Jul 31, 2019 at 05:08:37PM +0100, Will Deacon wrote:
> On Tue, Jul 16, 2019 at 07:13:00PM +0800, Leo Yan wrote:
> > This patch implement regs_set_return_value() and
> > override_function_with_return() to support function error injection
> > for arm64.
> >
>
--
Hello dear Friend i am Major. John Wayne Troxell, Write to me back on
the below email ( troxellj...@gmail.com )
On Wed, Jul 31, 2019 at 6:44 AM Neil Armstrong wrote:
>
> On 31/07/2019 14:14, Guillaume La Roque wrote:
> > Adding the devicetree binding documentation for the Amlogic temperature
> > sensor found in the Amlogic Meson G12 SoCs.
> > the G12A and G12B SoCs are supported.
> >
> > Signed-off-by: Gui
My employer (and yes, I am working for the Linux Foundation) has me
working on analysing race condition warnings in the Linux kernel. They
have a driver verification project running under the umbrella of the ELISA
project involved in the research, investigation, experimentation, and
establishme
On 7/26/19 4:19 PM, Walter Wu wrote:
> On Fri, 2019-07-26 at 15:52 +0300, Andrey Ryabinin wrote:
>>
>> On 7/26/19 3:28 PM, Walter Wu wrote:
>>> On Fri, 2019-07-26 at 15:00 +0300, Andrey Ryabinin wrote:
>>>
>
>
> I remember that there are already the lists which you concern. Mayb
On 2019-07-31 12:30 a.m., Greentime Hu wrote:
> I look this issue more closely.
> I found it always sets each memblock region to node 0. Does this make sense?
> I am not sure if I understand this correctly. Do you have any idea for
> this? Thank you. :)
Yes, I think this is normal. When we talk
On Wed, Jul 31, 2019 at 05:47:48PM +0200, Nicolas Saenz Julienne wrote:
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 1c4ffabbe1cb..f5279ef85756 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -50,6 +50,13 @@
> s64 memstart_addr __ro_after_init = -1;
> E
On Wed, 2019-07-31 at 15:17 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic
> should
> never do something different based on this.
>
> Also, if a debugfs call fails, userspace is
Quoting Rafael J. Wysocki (2019-07-31 04:58:36)
> On Wednesday, July 31, 2019 10:34:11 AM CEST Rafael J. Wysocki wrote:
> > On Wed, Jul 31, 2019 at 1:41 AM Stephen Boyd wrote:
> > >
> >
> > > We can run into the same problem when two buses name their devices the
> > > same name and then we attemp
On Tue 2019-07-30 22:35:18, Joe Perches wrote:
> Reserve the pseudo keyword 'fallthrough' for the ability to convert the
> various case block /* fallthrough */ style comments to appear to be an
> actual reserved word with the same gcc case block missing fallthrough
> warning capability.
Acked-by:
On Mon, Jul 29, 2019 at 01:54:21PM +0100, Vincenzo Frascino wrote:
> Using an old .config in combination with "make oldconfig" can cause
> an incorrect detection of the compat compiler:
>
> $ grep CROSS_COMPILE_COMPAT .config
> CONFIG_CROSS_COMPILE_COMPAT_VDSO=""
>
> $ make oldconfig && make
> ar
> On 31 Jul 2019, at 11.41, Hans Holmberg wrote:
>
> Now that there no module users left of bio_map_kern, stop
> exporting the symbol.
>
> Signed-off-by: Hans Holmberg
> ---
> block/bio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/bio.c b/block/bio.c
> index 299a0e7651ec..96c
On Tue, Jul 30, 2019 at 05:23:48PM -0400, Qian Cai wrote:
> GCC throws out this warning on arm64.
>
> drivers/firmware/efi/libstub/arm-stub.c: In function 'efi_entry':
> drivers/firmware/efi/libstub/arm-stub.c:132:22: warning: variable 'si'
> set but not used [-Wunused-but-set-variable]
>
> Fix i
On Wed, Jul 31, 2019 at 04:41:14PM +0200, Michal Hocko wrote:
> On Wed 31-07-19 17:21:29, Mike Rapoport wrote:
> > On Wed, Jul 31, 2019 at 03:00:37PM +0200, Michal Hocko wrote:
> > >
> > > I am sorry, but I still do not follow. Who is consuming that node id
> > > information when NUMA=n. In other
On Wed, Jul 31, 2019 at 10:13:57AM -0700, Stephen Boyd wrote:
> Quoting Rafael J. Wysocki (2019-07-31 04:58:36)
> > On Wednesday, July 31, 2019 10:34:11 AM CEST Rafael J. Wysocki wrote:
> > > On Wed, Jul 31, 2019 at 1:41 AM Stephen Boyd wrote:
> > > >
> > >
> > > > We can run into the same proble
On Thu, Jul 25, 2019 at 05:16:15PM +0900, Masami Hiramatsu wrote:
> Make debug exceptions visible from RCU so that synchronize_rcu()
> correctly track the debug exception handler.
>
> This also introduces sanity checks for user-mode exceptions as same
> as x86's ist_enter()/ist_exit().
>
> The de
On 7/31/2019 8:34 AM, Aaron Goidel wrote:
> As of now, setting watches on filesystem objects has, at most, applied a
> check for read access to the inode, and in the case of fanotify, requires
> CAP_SYS_ADMIN. No specific security hook or permission check has been
> provided to control the setting
On 29.07.19 20:43, Dmitry Torokhov wrote:
Hi,
https://patchwork.kernel.org/cover/11042915/
Thanks.
I tried putting you on CC list there, did you not get them?
hmm, maybe it went to one of the dozens of mailboxes where I didn't
look at careful enough ... I'm currently just sorting by maili
Everyone:
This series contains fixes/improvements to LPUART dirver I came up
with recently as well as fixes picked up from Toradex and NXP Vybrid
repos.
Feedback is welcome!
Changes since [v1]:
- Dropped "tty: serial: fsl_lpuart: Drop unnecessary sg_set_buf()
call" due to being a duplicate
From: Stefan Agner
After overruns the FIFO pointers become misaligned. This
typically shows by characters still being stuck in the FIFO
despite the empty flag being asserted. After the first
assertion of the overrun flag the empty flag still seems to
indicate FIFO state correctly and all data can
Switching baud rate might cause bogus data to appear in HW
FIFO. Add code to do a HW FIFO flush to .flush_buffer callback to
avoid that.
Signed-off-by: Fugang Duan
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri S
Fix bogus indentation in rx_dma_timer_init().
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc: linux-ser...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/tty/serial/f
From: Stefan Agner
When using DMA framing error get cleared properly. However, due
to the additional read from the data register, an underflow in
the receive FIFO buffer occurs (the FIFO pointer gets out of
sync).
Clear the FIFO in case an underflow has occurred. Also disable the
receiver during
Although I haven't observed this bug in practice, it seems that the
code for handling x_char of LPUART is pretty much identical to that of
i.MX. So the fix found in commit 7e2fb5aa8d81 ("serial: imx: Fix issue
in software flow control"):
serial: imx: Fix issue in software flow control
Aft
Drop unnecessary extra parenthesis in the driver.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc: linux-ser...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/tty/seri
By the time lpuart_shutdown() calls lpuart_stop_tx() UARTCR2_TE and
UARTCR2_TIE (which the latter will clear) are already cleared, so that
function call should effectively be a no-op. Moreso, lpuart_stop_tx()
is expected to be executed with port spinlock held, which the caller
doesn't. Given all th
Busy polling on a bit in a register is used in multiple places in the
driver. Move it into a shared function.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc: linux-ser...@vger.kerne
The check for termios->c_cflag & CRTSCTS ensure that if we reach else
branch, CRTSCTS in termios->c_cflag is already going to be
cleard. Doing so explicitly there is not necessary. Drop it.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg
While sharing code for Tx interrupt handler between 8 and 32 bit
variant of the peripheral saves a bit of code duplication it also adds
quite a number of lpuart_is_32() checks which makes it harder to
understand. Move shared bits back into corresponding
lpuart*_transmit_buffer functions, split lpua
The check for
uart_circ_empty(xmit) || uart_tx_stopped(&sport->port)
appears in multiple places in the driver. Move it into a helper
function.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-
When dealing with 32-bit variant of LPUART IP block appropriate I/O
helpers have to be used to properly deal with endianness
differences. Change all of the offending code to do that.
Fixes: a5fa2660d787 ("tty/serial/fsl_lpuart: Add CONSOLE_POLL support
for lpuart32.")
Signed-off-by: Andrey Smirnov
Code configure DMA TX path in lpuart_startup(), lpuart32_startup() and
lpuart_resume() is doing exactly the same thing, so move it into a
standalone subroutine.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Code doing initial DMA RX configuration in lpuart_startup() and
lpuart32_startup() is exactly the same, so move it into a standalone
subroutine.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@
Use cpu_relax() instead of barrier() in a tight polling loops to make
them a bit more idiomatic. Should also improve things on ARM64 a bit
since cpu_relax() will expand into "yield" instruction there.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Code doing final steps of TX/RX configuration in lpuart32_startup()
and lpuart_resume() is identical, so move it into a standalone
subroutine.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nx
Last steps of .shutdown() code are identical for lpuart and lpuart32
cases, so move it all into a standalone subroutine.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc: linux-ser...
Clearing CSTOPB bit if it is set is functionally equivalent to jsut
clearing it unconditionally. Drop unnecessary check.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc: linux-ser...
It appears that lpuart_rxint, lpuart_txint and lpuart32_rxint were
modelled after identical function found in UART driver for
i.MX. However, while said functions are used as individual IRQ
handlers in i.MX driver (in case of i.MX1), it is not the case for
LPUART. Given that, there's no need for us
Hi!
> >> Abstract
> >>
> >>
> >> The modern servers allows multiple cores to run at range of frequencies
> >> higher than rated range of frequencies. But the power budget of the system
> >> inhibits sustaining these higher frequencies for longer durations.
> >
> > Thermal budget?
>
> Ri
Uart_write_wakeup() will already be called as a part of
lpuart*_transmit_buffer() call, so there doesn't seem to be a reason
to call it again right after.
It also appears that second uart_write_wakeup() might potentially
cause unwanted write wakeup when transmitting an x_char. See commit
5e42e9a30
Most users of lpuart*_setup_watermark() enable identical set of flags
right after the call, so combine those two action into a subroutine
and make use of it.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
C
On 7/30/19 9:21 AM, Peter Zijlstra wrote:
> On Tue, Jul 30, 2019 at 08:41:15AM +0200, Juri Lelli wrote:
>> On 29/07/19 18:49, Peter Zijlstra wrote:
>>> On Fri, Jul 26, 2019 at 09:27:55AM +0100, Dietmar Eggemann wrote:
Remove BUG_ON() in __enqueue_dl_entity() since there is already one in
In a mixed DMA/IRQ use-case (e.g.: DMA for TX, IRQ for RX), interrupt
handler might try to handle Rx/Tx condition it shouldn't. Change the
code to only handle TX/RX event if corresponding path isn't being
handled by DMA.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tu
On Wed, Jul 31, 2019 at 02:05:23AM -0400, Alex Ghiti wrote:
> On 7/30/19 1:51 AM, Alexandre Ghiti wrote:
> >In order to avoid wasting user address space by using bottom-up mmap
> >allocation scheme, prefer top-down scheme when possible.
> >
> >Before:
> >root@qemuriscv64:~# cat /proc/self/maps
> >0
Enabling TIE in .startup() callback causes the driver to start (or at
least try) to transmit data before .start_tx() is called. Which, while
harmless (since TIE handler will immediately disable it), is a no-op
and shouldn't really happen. Drop UARTCR2_TIE from list of bits set in
lpuart_startup().
Implement .device_synchronize callback in order to be able to use
dmaengine_terminate_sync() and other primitives relying on said
callback.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Vinod Koul
Cc: linux-...@nxp.com
Cc: dmaeng...@vger.kernel.org
Cc: linux-kernel@vger.ke
On 07/31, Adrian Reber wrote:
>
> Extending clone3() to support CLONE_SET_TID makes it possible restore a
> process using CRIU without accessing /proc/sys/kernel/ns_last_pid and
> race free (as long as the desired PID/TID is available).
I personally like this... but please see the question below.
Everyone,
This series contains various fixes/improvements for ziirave_wdt
driver. Hopefully each commit is self-explanatory.
Feedback is welcome!
Thanks,
Andrey Smirnov
Andrey Smirnov (5):
watchdog: ziirave_wdt: Add missing newline
watchdog: ziirave_wdt: Be verbose about errors in probe()
Add missing newline.
Signed-off-by: Andrey Smirnov
Cc: Chris Healy
Cc: Guenter Roeck
Cc: Rick Ramstetter
Cc: linux-watch...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/watchdog/ziirave_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/
Reprogramming bootloader on watchdog MCU will result in reported
default timeout value of "0". That in turn will be unnecesarily
rejected by the driver as invalid device (-ENODEV). Simplify probe to
just read stored timeout value, clamp it to an acceptable range and
program the value unconditionall
Log bootloader/firmware info during probe. This information is
available via sysfs already, but it's really helpful to have this in
kernel log during startup as well.
Signed-off-by: Andrey Smirnov
Cc: Chris Healy
Cc: Guenter Roeck
Cc: Rick Ramstetter
Cc: linux-watch...@vger.kernel.org
Cc: linu
The driver is quite silent in case of probe failure, which makes it
more difficult to diagnose problem from the kernel log. Add logging to
all of the silent error paths ziirave_wdt_probe() to improve that.
Signed-off-by: Andrey Smirnov
Cc: Chris Healy
Cc: Guenter Roeck
Cc: Rick Ramstetter
Cc:
Add more error logging to ziirave_firm_upload() for diagnostics.
Signed-off-by: Andrey Smirnov
Cc: Chris Healy
Cc: Guenter Roeck
Cc: Rick Ramstetter
Cc: linux-watch...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/watchdog/ziirave_wdt.c | 8 ++--
1 file changed, 6 insertion
501 - 600 of 1303 matches
Mail list logo
