linux-next: manual merge of the net-next tree with the net tree

2019-07-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/can/flexcan.c between commit: e9f2a856e102 ("can: flexcan: fix an use-after-free in flexcan_setup_stop_mode()") from the net tree and commit: 915f9666421c ("can: flexcan: add support for DT property 'w

Re: [PATCH 5.1 000/371] 5.1.20-stable review

2019-07-24 Thread Jiunn Chang
On Wed, Jul 24, 2019 at 09:15:52PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.1.20 release. > There are 371 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: How to turn scheduler tick on for current nohz_full CPU?

2019-07-24 Thread Paul E. McKenney
On Wed, Jul 24, 2019 at 04:30:13PM +0200, Frederic Weisbecker wrote: > On Wed, Jul 24, 2019 at 06:52:19AM -0700, Paul E. McKenney wrote: > > On Wed, Jul 24, 2019 at 03:22:59PM +0200, Frederic Weisbecker wrote: > > > On Wed, Jul 24, 2019 at 04:53:31AM -0700, Paul E. McKenney wrote: > > > > Hello! >

Re: [PATCH v3 1/3] mm: document zone device struct page field usage

2019-07-24 Thread Jason Gunthorpe
On Wed, Jul 24, 2019 at 04:26:58PM -0700, Ralph Campbell wrote: > Struct page for ZONE_DEVICE private pages uses the page->mapping and > and page->index fields while the source anonymous pages are migrated to > device private memory. This is so rmap_walk() can find the page when > migrating the ZON

Re: [PATCH v8 0/7] Unify CPU topology across ARM & RISC-V

2019-07-24 Thread Atish Patra
On 7/22/19 12:25 PM, Paul Walmsley wrote: On Fri, 12 Jul 2019, Paul Walmsley wrote: On Thu, 27 Jun 2019, Atish Patra wrote: The cpu-map DT entry in ARM can describe the CPU topology in much better way compared to other existing approaches. RISC-V can easily adopt this binding to represent its

[PATCH] pata_ali: check the pci_get_device failure

2019-07-24 Thread Navid Emamdoost
pci_get_device may fail and return NULL. This eventually will be dereferenced in __pci_register_driver. So null check is necessary. Signed-off-by: Navid Emamdoost --- drivers/ata/pata_ali.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c inde

Re: [PATCH] trace: fix header include guards

2019-07-24 Thread Steven Rostedt
On Sat, 20 Jul 2019 19:39:43 +0900 Masahiro Yamada wrote: > These include guards are broken. > > Match the #if !define() and #define lines so that they work correctly. Thanks, this all looks legit to me. I'll pull this in through my tree. -- Steve > > Signed-off-by: Masahiro Yamada > --- >

Re: [PATCH] carl9170: remove set but not used variable 'udev'

2019-07-24 Thread Yuehaibing
On 2019/7/25 3:42, Christian Lamparter wrote: > On Wed, Jul 24, 2019 at 3:48 AM YueHaibing wrote: >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/wireless/ath/carl9170/usb.c: In function >> 'carl9170_usb_disconnect': >> drivers/net/wireless/ath/carl9170/usb.c:1110:21: warni

[PATCH] mm/hugetlb.c: check the failure case for find_vma

2019-07-24 Thread Navid Emamdoost
find_vma may fail and return NULL. The null check is added. Signed-off-by: Navid Emamdoost --- mm/hugetlb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index ede7e7f5d1ab..9c5e8b7a6476 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4743,6 +4743,9 @@ void

Re: [PATCH 1/2] arm64: Add support for function error injection

2019-07-24 Thread Leo Yan
On Tue, Jul 16, 2019 at 07:13:00PM +0800, Leo Yan wrote: > This patch implement regs_set_return_value() and > override_function_with_return() to support function error injection > for arm64. > > In the exception flow, arm64's general register x30 contains the value > for the link register; so we c

Re: [PATCH 2/2] arm: Add support for function error injection

2019-07-24 Thread Leo Yan
Hi Russell, On Tue, Jul 16, 2019 at 07:13:01PM +0800, Leo Yan wrote: > This patch implement regs_set_return_value() and > override_function_with_return() to support function error injection > for arm. > > In the exception flow, we can update pt_regs::ARM_pc with > pt_regs::ARM_lr so that can over

[PATCH] net: mscc: ocelot: null check devm_kcalloc

2019-07-24 Thread Navid Emamdoost
devm_kcalloc may fail and return NULL. Added the null check. Signed-off-by: Navid Emamdoost --- drivers/net/ethernet/mscc/ocelot_board.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mscc/ocelot_board.c b/drivers/net/ethernet/mscc/ocelot_board.c index 58bde1a9eacb..

Re: [PATCH 1/2] mmc: sdhci: Add PLL Enable support to internal clock setup

2019-07-24 Thread Michael K. Johnson
On Wed, Jul 24, 2019 at 09:19:30AM +0200, Ulf Hansson wrote: > > Genesys Logic Email Confidentiality Notice: > > This mail and any attachments may contain information that is confidential, > > proprietary, privileged or otherwise protected by law. The mail is intended > > solely for the named add

Re: [PATCH net-next 04/11] net: hns3: fix mis-counting IRQ vector numbers issue

2019-07-24 Thread tanhuazhong
On 2019/7/25 2:28, Saeed Mahameed wrote: On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: From: Yonglong Liu The num_msi_left means the vector numbers of NIC, but if the PF supported RoCE, it contains the vector numbers of NIC and RoCE(Not expected). This may cause interrupts lost in

Re: [PATCH net-next 08/11] net: hns3: add interrupt affinity support for misc interrupt

2019-07-24 Thread Yunsheng Lin
On 2019/7/25 3:24, Saeed Mahameed wrote: > On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: >> From: Yunsheng Lin >> >> The misc interrupt is used to schedule the reset and mailbox >> subtask, and a 1 sec timer is used to schedule the service >> subtask, which does periodic work. >> >> This

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 18:13, Eric Dumazet wrote: > > > On 7/24/19 12:01 PM, Eric Dumazet wrote: >> >> >> On 7/24/19 11:17 AM, Mao Wenan wrote: >>> There is one report about tcp_write_xmit use-after-free with version >>> 4.4.136: >> >> Current stable 4.4 is 4.4.186 >> >> Can you check the bug is still

[PATCH] ALSA: echoaudio: Replace kmalloc + memcpy with kmemdup

2019-07-24 Thread Chuhong Yuan
Instead of using kmalloc + memcpy, use kmemdup to simplify the code. Signed-off-by: Chuhong Yuan --- sound/pci/echoaudio/echoaudio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c index b612a536a5a1..ca91

Re: [PATCH 1/1] x86/boot: clear some fields explicitly

2019-07-24 Thread hpa
On July 24, 2019 4:15:28 PM PDT, john.hubb...@gmail.com wrote: >From: John Hubbard > >Recent gcc compilers (gcc 9.1) generate warnings about an >out of bounds memset, if you trying memset across several fields >of a struct. This generated a couple of warnings on x86_64 builds. > >Because struct bo

Re: [PATCH v2] sys_prctl(): remove unsigned comparision with less than zero

2019-07-24 Thread Andrew Morton
On Wed, 24 Jul 2019 10:11:48 +0800 Yang Xu wrote: > Currently, when calling prctl(PR_SET_TIMERSLACK, arg2), arg2 is an > unsigned long value, arg2 will never < 0. Negative judgment is > meaningless, so remove it. > > ... > > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -2372,7 +2372,7 @@ SYSCALL

[PATCH] dt-bindings: clock: imx8mn: Fix tab indentation for yaml file

2019-07-24 Thread Anson . Huang
From: Anson Huang YAML file can NOT contain tab as indentation, fix it. Fixes: 6d6062553e3d ("dt-bindings: imx: Add clock binding doc for i.MX8MN") Signed-off-by: Anson Huang --- Documentation/devicetree/bindings/clock/imx8mn-clock.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

RE: [PATCH V5 1/5] dt-bindings: imx: Add clock binding doc for i.MX8MN

2019-07-24 Thread Anson Huang
> On Sun, Jul 21, 2019 at 7:51 PM Shawn Guo wrote: > > > > On Wed, Jun 19, 2019 at 01:52:43PM +0800, anson.hu...@nxp.com wrote: > > > From: Anson Huang > > > > > > Add the clock binding doc for i.MX8MN. > > > > > > Signed-off-by: Anson Huang > > > Reviewed-by: Maxime Ripard > > > > Applied al

Re: [PATCH] net: sctp: fix memory leak in sctp_send_reset_streams

2019-07-24 Thread Marcelo Ricardo Leitner
On Wed, Jul 24, 2019 at 03:56:40PM +0800, Xin Long wrote: > On Sun, Jun 2, 2019 at 9:36 PM Xin Long wrote: > > > > On Sun, Jun 2, 2019 at 6:52 PM Neil Horman wrote: > > > > > > On Sun, Jun 02, 2019 at 11:44:29AM +0800, Hillf Danton wrote: > > > > > > > > syzbot found the following crash on: > > >

Re: [PATCH V36 27/29] tracefs: Restrict tracefs when the kernel is locked down

2019-07-24 Thread Steven Rostedt
On Thu, 18 Jul 2019 12:44:13 -0700 Matthew Garrett wrote: > @@ -387,6 +412,7 @@ struct dentry *tracefs_create_file(const char *name, > umode_t mode, > struct dentry *parent, void *data, > const struct file_operations *fops) > { >

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-07-24 Thread Viresh Kumar
On 24-07-19, 15:10, Marek Szyprowski wrote: > Hi Viresh, > > On 2019-07-23 04:04, Viresh Kumar wrote: > > On 18-07-19, 16:30, Sylwester Nawrocki wrote: > >> This is second iteration of patch series adding ASV (Adaptive Supply > >> Voltage) support for Exynos SoCs. The first one can be found at: >

Re: [PATCH V2 2/4] opp: of: Support multiple suspend OPPs defined in DT

2019-07-24 Thread Viresh Kumar
On 09-07-19, 16:00, anson.hu...@nxp.com wrote: > From: Anson Huang > > With property "opp-supported-hw" introduced, the OPP table > in DT could be a large OPP table and ONLY a subset of OPPs > are available, based on the version of the hardware running > on. That introduces restriction of using "

Re: [PATCH V2 1/4] dt-bindings: opp: Support multiple opp-suspend properties

2019-07-24 Thread Viresh Kumar
On 09-07-19, 16:00, anson.hu...@nxp.com wrote: > From: Anson Huang > > Update opp-suspend property's description to support multiple > opp-suspend properties defined in DT, the OPP with highest opp-hz > and with opp-suspend property present will be used as suspend opp. > > Signed-off-by: Anson H

Re: [PATCH v4 0/5] Add required-opps support to devfreq passive gov

2019-07-24 Thread Viresh Kumar
On 23-07-19, 18:42, Saravana Kannan wrote: > The devfreq passive governor scales the frequency of a "child" device based > on the current frequency of a "parent" device (not parent/child in the > sense of device hierarchy). As of today, the passive governor requires one > of the following to work c

linux-next: build failure after merge of the leds tree

2019-07-24 Thread Stephen Rothwell
mprove LED and LED flash class registration API") interacting with commit 5be102eb161a ("leds: max77650: Add LEDs support") I have used the leds tree from next-20190724 for today. -- Cheers, Stephen Rothwell pgpUZiaYrofMY.pgp Description: OpenPGP digital signature

Re: [PATCH v2 0/4] per-cgroup numa suite

2019-07-24 Thread 王贇
Hi, Peter Now we have all these stuff in cpu cgroup, with the new statistic folks should be able to estimate their per-cgroup workloads on numa platform, and numa group + cling would help to address the issue when their workloads can't be settled on one node. How do you think about this version :

Re: [PATCH] mm: replace list_move_tail() with add_page_to_lru_list_tail()

2019-07-24 Thread Andrew Morton
On Tue, 16 Jul 2019 15:24:36 -0600 Yu Zhao wrote: > This is a cleanup patch that replaces two historical uses of > list_move_tail() with relatively recent add_page_to_lru_list_tail(). > Looks OK to me. > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -515,7 +515,6 @@ static void lru_deactivate_file_fn

Re: [PATCH net-next 06/11] net: hns3: modify firmware version display format

2019-07-24 Thread tanhuazhong
On 2019/7/25 2:34, Saeed Mahameed wrote: On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote: From: Yufeng Mo This patch modifies firmware version display format in hclge(vf)_cmd_init() and hns3_get_drvinfo(). Also, adds some optimizations for firmware version display format. Signed-off-

Re: [PATCH v6 1/2] mm/vmalloc: do not keep unpurged areas in the busy tree

2019-07-24 Thread Andrew Morton
On Tue, 16 Jul 2019 23:26:55 +0800 Pengfei Li wrote: > From: "Uladzislau Rezki (Sony)" > > The busy tree can be quite big, even though the area is freed > or unmapped it still stays there until "purge" logic removes > it. > > 1) Optimize and reduce the size of "busy" tree by removing a > node

[PATCH] x86/speculation/mds: Apply more accurate check on hypervisor platform

2019-07-24 Thread Zhenzhong Duan
X86_HYPER_NATIVE isn't accurate for checking if running on native platform, e.g. CONFIG_HYPERVISOR_GUEST isn't set or "nopv" is enabled. Checking cpu flag X86_FEATURE_HYPERVISOR to determine if it's running on native platform is more accurate. This still doesn't consider the old platform where ev

[PATCH] perf/x86: Apply more accurate check on hypervisor platform

2019-07-24 Thread Zhenzhong Duan
check_msr is used to fix a bug report in guest where KVM doesn't support LBR MSR and cause #GP. The msr check is bypassed on real HW to workaround a false failure, see commit d0e1a507bdc7 ("perf/x86/intel: Disable check_msr for real HW") When running a guest with CONFIG_HYPERVISOR_GUEST not set o

[PATCH v2] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-24 Thread Chuhong Yuan
Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- drivers/staging/wilc1000/wilc_mon.c | 3 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- drivers/staging/wilc1000/wilc_wlan.c

Re: [PATCH net-next v2 3/3] netlink: add validation of NLA_F_NESTED flag

2019-07-24 Thread David Ahern
On 7/23/19 1:57 AM, Thomas Haller wrote: > Does this flag and strict validation really provide any value? Commonly a > netlink message > is a plain TLV blob, and the meaning depends entirely on the policy. Strict checking enables kernel side filtering and other features that require passing attri

Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case

2019-07-24 Thread Andrew Morton
On Sat, 13 Jul 2019 04:49:04 +0800 Yang Shi wrote: > When running ltp's oom test with kmemleak enabled, the below warning was > triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is > passed in: > > ... > > The mempool_alloc_slab() clears __GFP_DIRECT_RECLAIM, kmemleak has > __

Re: [PATCH] rtlwifi: remove unneeded function _rtl_dump_channel_map()

2019-07-24 Thread Pkshih
On Wed, 2019-07-24 at 22:10 +0800, YueHaibing wrote: > Now _rtl_dump_channel_map() does not do any actual > thing using the channel. So remove it. > > Signed-off-by: YueHaibing > --- >  drivers/net/wireless/realtek/rtlwifi/regd.c | 18 -- >  1 file changed, 18 deletions(-) > > dif

[PATCH v2] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

2019-07-24 Thread Chuhong Yuan
Merge the combo use of memcpy and le32_to_cpus. Use get_unaligned_le32 instead. This simplifies the code. Signed-off-by: Chuhong Yuan --- Changes in v2: - Merge the previous two patches which have the same subject line. drivers/staging/wilc1000/wilc_mon.c | 3 +-- drivers/st

[PATCH 0/2] fix kernel panic due to use uninitialized struct pages

2019-07-24 Thread Toshiki Fukasawa
A kernel panic was observed during reading /proc/kpageflags for first few pfns allocated by pmem namespace: BUG: unable to handle page fault for address: fffe [ 114.495280] #PF: supervisor read access in kernel mode [ 114.495738] #PF: error_code(0x) - not-present page [ 114.4962

[PATCH 2/2] /proc/kpageflags: do not use uninitialized struct pages

2019-07-24 Thread Toshiki Fukasawa
A kernel panic was observed during reading /proc/kpageflags for first few pfns allocated by pmem namespace: BUG: unable to handle page fault for address: fffe [ 114.495280] #PF: supervisor read access in kernel mode [ 114.495738] #PF: error_code(0x) - not-present page [ 114.4962

[PATCH 1/2] /proc/kpageflags: prevent an integer overflow in stable_page_flags()

2019-07-24 Thread Toshiki Fukasawa
stable_page_flags() returns kpageflags info in u64, but it uses "1 << KPF_*" internally which is considered as int. This type mismatch causes no visible problem now, but it will if you set bit 32 or more as done in a subsequent patch. So use BIT_ULL in order to avoid future overflow issues. Signed

Re: [PATCH v3 2/5] OPP: Add function to look up required OPP's for a given OPP

2019-07-24 Thread Viresh Kumar
On 23-07-19, 17:23, Saravana Kannan wrote: > On Tue, Jul 23, 2019 at 2:53 AM Viresh Kumar wrote: > > > > On 17-07-19, 15:23, Saravana Kannan wrote: > > > Add a function that allows looking up required OPPs given a source OPP > > > table, destination OPP table and the source OPP. > > > > > > Signed

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-24 Thread liuyonglong
> Revert "net: hns: fix LED configuration for marvell phy" > This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. > > Andrew Lunn says this should be handled another way. > > Signed-off-by: David S. Miller Hi Andrew: I see this patch have been reverted, can you tell me the better way t

Re: [PATCH v3 5/5] PM / devfreq: Add required OPPs support to passive governor

2019-07-24 Thread Viresh Kumar
On 23-07-19, 17:26, Saravana Kannan wrote: > On Tue, Jul 23, 2019 at 3:04 AM Viresh Kumar wrote: > > On 17-07-19, 15:23, Saravana Kannan wrote: > > > /* > > > @@ -56,13 +56,20 @@ static int devfreq_passive_get_target_freq(struct > > > devfreq *devfreq, > > >* list of parent device.

Re: [PATCH] xtensa: remove free_initrd_mem

2019-07-24 Thread Max Filippov
On Wed, Jul 24, 2019 at 7:11 AM Mike Rapoport wrote: > > The xtensa free_initrd_mem() verifies that initrd is mapped and then > frees its memory using free_reserved_area(). > > The initrd is considered mapped when its memory was successfully reserved > with mem_reserve(). > > Resetting initrd_star

Re: [PATCH v4] mmc: host: sdhci-sprd: Fix the incorrect soft reset operation when runtime resuming

2019-07-24 Thread Baolin Wang
On Wed, 24 Jul 2019 at 20:56, Adrian Hunter wrote: > > On 24/07/19 5:21 AM, Baolin Wang wrote: > > On Tue, 23 Jul 2019 at 20:39, Ulf Hansson wrote: > >> > >> On Tue, 23 Jul 2019 at 05:05, Baolin Wang wrote: > >>> > >>> Hi Ulf, > >>> > >>> On Mon, 22 Jul 2019 at 19:54, Ulf Hansson wrote: >

[PATCH] staging: media: hantro: Remove call to memset after dma_alloc_coherent

2019-07-24 Thread Hariprasad Kelam
fix below issue reported by coccicheck /drivers/staging/media/hantro/hantro_vp8.c:149:16-34: WARNING: dma_alloc_coherent use in aux_buf -> cpu already zeroes out memory, so memset is not needed Signed-off-by: Hariprasad Kelam --- drivers/staging/media/hantro/hantro_vp8.c | 2 -- 1 file changed,

Re: [PATCH v2] checkpatch.pl: warn on invalid commit id

2019-07-24 Thread Andrew Morton
On Thu, 11 Jul 2019 02:16:40 +0200 Matteo Croce wrote: > It can happen that a commit message refers to an invalid commit id, because > the referenced hash changed following a rebase, or simply by mistake. > Add a check in checkpatch.pl which checks that an hash referenced by > a Fixes tag, or jus

Re: [PATCH v3 3/5] OPP: Improve require-opps linking

2019-07-24 Thread Viresh Kumar
On 23-07-19, 07:47, Saravana Kannan wrote: > On Tue, Jul 23, 2019, 3:28 AM Viresh Kumar wrote: > > > $subject doesn't have correct property name. > > > > On 17-07-19, 15:23, Saravana Kannan wrote: > > > Currently, the linking of required-opps fails silently if the > > > destination OPP table hasn

[PATCH] ipip: validate header length in ipip_tunnel_xmit

2019-07-24 Thread Haishuang Yan
We need the same checks introduced by commit cb9f1b783850 ("ip: validate header length on virtual device xmit") for ipip tunnel. Signed-off-by: Haishuang Yan --- net/ipv4/ipip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index 43adfc1..2f01cf6 100644

[PATCH] ipip: validate header length in ipip_tunnel_xmit

2019-07-24 Thread Haishuang Yan
We need the same checks introduced by commit cb9f1b783850 ("ip: validate header length on virtual device xmit") for ipip tunnel. Signed-off-by: Haishuang Yan --- net/ipv4/ipip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index 43adfc1..2f01cf6 100644

[PATCH v6 1/8] KVM: VMX: Define CET VMCS fields and control bits

2019-07-24 Thread Yang Weijiang
CET(Control-flow Enforcement Technology) is an upcoming Intel(R) processor feature that blocks Return/Jump-Oriented Programming(ROP) attacks. It provides the following capabilities to defend against ROP/JOP style control-flow subversion attacks: Shadow Stack (SHSTK): A second stack for program w

[PATCH v6 3/8] KVM: x86: Implement CET CPUID enumeration for Guest

2019-07-24 Thread Yang Weijiang
CPUID.(EAX=7, ECX=0):ECX[bit 7] and EDX[bit 20] correspond to CET SHSTK and IBT respectively. CET xsave components for supervisor and user mode are reported via CPUID.(EAX=0xD, ECX=1):ECX[bit 11] and ECX[bit 12] respectively. Co-developed-by: Zhang Yi Z Signed-off-by: Zhang Yi Z Signed-off-by: Y

[PATCH v6 4/8] KVM: VMX: Pass through CET related MSRs to Guest

2019-07-24 Thread Yang Weijiang
CET MSRs pass through Guest directly to enhance performance. CET runtime control settings are stored in MSR_IA32_{U,S}_CET, Shadow Stack Pointer(SSP) are stored in MSR_IA32_PL{0,1,2,3}_SSP, SSP table base address is stored in MSR_IA32_INT_SSP_TAB, these MSRs are defined in kernel and re-used here.

[PATCH v6 6/8] KVM: x86: Add CET bits setting in CR4 and XSS

2019-07-24 Thread Yang Weijiang
CR4.CET(bit 23) is master enable bit for CET feature. Previously, KVM did not support setting any bits in XSS so it's hardcoded to check and inject a #GP if Guest attempted to write a non-zero value to XSS, now it supports CET related bits setting. Co-developed-by: Zhang Yi Z Signed-off-by: Zhang

[PATCH v6 5/8] KVM: VMX: Load Guest CET via VMCS when CET is enabled in Guest

2019-07-24 Thread Yang Weijiang
"Load Guest CET state" bit controls whether Guest CET states will be loaded at Guest entry. Before doing that, KVM needs to check if CPU CET feature is enabled on host and available to Guest. Note: SHSTK and IBT features share one control MSR: MSR_IA32_{U,S}_CET, which means it's difficult to hide

[PATCH v6 8/8] KVM: x86: Add user-space access interface for CET MSRs

2019-07-24 Thread Yang Weijiang
There're two different places storing Guest CET states, the states managed with XSAVES/XRSTORS, as restored/saved in previous patch, can be read/write directly from/to the MSRs. For those stored in VMCS fields, they're access via vmcs_read/ vmcs_write. Signed-off-by: Yang Weijiang --- arch/x86/k

[PATCH v6 0/8] Introduce support for Guest CET feature

2019-07-24 Thread Yang Weijiang
Control-flow Enforcement Technology (CET) provides protection against Return/Jump-Oriented Programming (ROP/JOP) attack. It includes two sub-features: Shadow Stack (SHSTK) and Indirect Branch Tracking (IBT). KVM modification is required to support Guest CET feature. This patch serial implemented C

Re: [PATCH v2] sys_prctl(): remove unsigned comparision with less than zero

2019-07-24 Thread Yang Xu
on 2019/07/25 10:14, Andrew Morton wrote: On Wed, 24 Jul 2019 10:11:48 +0800 Yang Xu wrote: Currently, when calling prctl(PR_SET_TIMERSLACK, arg2), arg2 is an unsigned long value, arg2 will never< 0. Negative judgment is meaningless, so remove it. ... --- a/kernel/sys.c +++ b/kernel/sys.c

[PATCH v6 7/8] KVM: x86: Load Guest fpu state when accessing MSRs managed by XSAVES

2019-07-24 Thread Yang Weijiang
From: Sean Christopherson A handful of CET MSRs are not context switched through "traditional" methods, e.g. VMCS or manual switching, but rather are passed through to the guest and are saved and restored by XSAVES/XRSTORS, i.e. the guest's FPU state. Load the guest's FPU state if userspace is a

[PATCH v6 2/8] KVM: x86: Add a helper function for CPUID(0xD,n>=1) enumeration

2019-07-24 Thread Yang Weijiang
To make the code look clean, wrap CPUID(0xD,n>=1) enumeration code in a helper function now. Signed-off-by: Yang Weijiang --- arch/x86/kvm/cpuid.c | 44 1 file changed, 44 insertions(+) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 4

[PATCH v5] mmc: host: sdhci: Fix the incorrect soft reset operation when runtime resuming

2019-07-24 Thread Baolin Wang
The SD host controller specification defines 3 types software reset: software reset for data line, software reset for command line and software reset for all. Software reset for all means this reset affects the entire Host controller except for the card detection circuit. In sdhci_runtime_resume_h

Re: [PATCH] asm-generic: fix -Wtype-limits compiler warnings

2019-07-24 Thread Qian Cai
> On Jul 24, 2019, at 5:49 PM, David Howells wrote: > > Qian Cai wrote: > >> I have GCC 8.2.1 which works fine. > > But you need to check the minimum version, i.e. 4.6: > > #if GCC_VERSION < 40600 > I did check gcc version 4.1.2 20080704 and it works fine.

[PATCH] staging: rtl8723bs: hal: Remove unneeded variable pU1Tmp

2019-07-24 Thread Hariprasad Kelam
Both pu8 and pU1Tmp are of same data type u8. So replace pU1Tmp with u8. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging

Re: Reminder: 99 open syzbot bugs in net subsystem

2019-07-24 Thread Theodore Y. Ts'o
On Wed, Jul 24, 2019 at 01:09:28PM -0700, David Miller wrote: > From: Eric Biggers > Date: Wed, 24 Jul 2019 11:37:12 -0700 > > > We can argue about what words to use to describe this situation, but > > it doesn't change the situation itself. > > And we should argue about those words because it m

Re: [PATCH v4 0/5] Add required-opps support to devfreq passive gov

2019-07-24 Thread Saravana Kannan
On Wed, Jul 24, 2019 at 7:30 PM Viresh Kumar wrote: > > On 23-07-19, 18:42, Saravana Kannan wrote: > > The devfreq passive governor scales the frequency of a "child" device based > > on the current frequency of a "parent" device (not parent/child in the > > sense of device hierarchy). As of today,

Re: WARNING in __mmdrop

2019-07-24 Thread Jason Wang
On 2019/7/25 上午2:25, Michael S. Tsirkin wrote: On Wed, Jul 24, 2019 at 06:08:05PM +0800, Jason Wang wrote: On 2019/7/24 下午4:05, Michael S. Tsirkin wrote: On Wed, Jul 24, 2019 at 10:17:14AM +0800, Jason Wang wrote: On 2019/7/23 下午11:02, Michael S. Tsirkin wrote: On Tue, Jul 23, 2019 at 09:34

Re: [PATCH v3 2/5] OPP: Add function to look up required OPP's for a given OPP

2019-07-24 Thread Saravana Kannan
On Wed, Jul 24, 2019 at 7:58 PM Viresh Kumar wrote: > > On 23-07-19, 17:23, Saravana Kannan wrote: > > On Tue, Jul 23, 2019 at 2:53 AM Viresh Kumar > > wrote: > > > > > > On 17-07-19, 15:23, Saravana Kannan wrote: > > > > Add a function that allows looking up required OPPs given a source OPP > >

Re: [PATCH] devfreq: Correct devm_devfreq_remove_device() documentation

2019-07-24 Thread Chanwoo Choi
On 19. 7. 25. 오전 3:59, Krzysztof Kozlowski wrote: > Correct the documentation for devm_devfreq_remove_device() argument. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/devfreq/devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-07-24 Thread Gregory Nowak
On Fri, Jul 12, 2019 at 05:46:23PM -0700, Gregory Nowak wrote: > On Fri, Jul 12, 2019 at 11:23:19AM +0200, Samuel Thibault wrote: > > Hello, > > > > To readers of the linux-speakup: could you help on this so we can get > > Speakup in mainline? Neither Okash or I completely know what user > > cons

Re: [PATCH v3 5/5] PM / devfreq: Add required OPPs support to passive governor

2019-07-24 Thread Saravana Kannan
On Wed, Jul 24, 2019 at 8:01 PM Viresh Kumar wrote: > > On 23-07-19, 17:26, Saravana Kannan wrote: > > On Tue, Jul 23, 2019 at 3:04 AM Viresh Kumar > > wrote: > > > On 17-07-19, 15:23, Saravana Kannan wrote: > > > > /* > > > > @@ -56,13 +56,20 @@ static int devfreq_passive_get_target_freq(

Re: [PATCH v3 3/5] OPP: Improve require-opps linking

2019-07-24 Thread Saravana Kannan
On Wed, Jul 24, 2019 at 8:07 PM Viresh Kumar wrote: > > On 23-07-19, 07:47, Saravana Kannan wrote: > > On Tue, Jul 23, 2019, 3:28 AM Viresh Kumar wrote: > > > > > $subject doesn't have correct property name. > > > > > > On 17-07-19, 15:23, Saravana Kannan wrote: > > > > Currently, the linking of

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-07-24 Thread Chris Brannon
Gregory Nowak writes: > keymap > I believe this is the currently active kernel keymap. I'm not sure of > the format, probably what dumpkeys(1) and showkey(1) use. Echoing > different values here should allow for remapping speakup's review > commands besides remapping the keyboard as a whole. AFA

Re: WARNING in ovl_real_fdget_meta

2019-07-24 Thread syzbot
syzbot has bisected this bug to: commit 387e3746d01c34457d6a73688acd90428725070b Author: Amir Goldstein Date: Fri Jun 7 14:24:38 2019 + locks: eliminate false positive conflicts for write lease bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15a7959460 start commit:

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-24 Thread Andrew Lunn
On Thu, Jul 25, 2019 at 11:00:08AM +0800, liuyonglong wrote: > > Revert "net: hns: fix LED configuration for marvell phy" > > This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. > > > > Andrew Lunn says this should be handled another way. > > > > Signed-off-by: David S. Miller > > > Hi

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-24 Thread maowenan
On 2019/7/24 22:07, Eric Dumazet wrote: > > > On 7/24/19 12:46 PM, maowenan wrote: >> >> >> On 2019/7/24 17:45, Eric Dumazet wrote: >>> >>> >>> On 7/24/19 11:17 AM, Mao Wenan wrote: There is one report about tcp_write_xmit use-after-free with version 4.4.136: BUG: KASAN: u

mmotm 2019-07-24-21-39 uploaded

2019-07-24 Thread akpm
The mm-of-the-moment snapshot 2019-07-24-21-39 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You wi

Re: Reminder: 99 open syzbot bugs in net subsystem

2019-07-24 Thread Eric Biggers
On Wed, Jul 24, 2019 at 11:39:13PM -0400, Theodore Y. Ts'o wrote: > On Wed, Jul 24, 2019 at 01:09:28PM -0700, David Miller wrote: > > From: Eric Biggers > > Date: Wed, 24 Jul 2019 11:37:12 -0700 > > > > > We can argue about what words to use to describe this situation, but > > > it doesn't change

Re: [PATCH 4.19 000/271] 4.19.61-stable review

2019-07-24 Thread Naresh Kamboju
On Thu, 25 Jul 2019 at 01:35, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.61 release. > There are 271 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Re

linux-next: run time BUG after merge of the vfs-fixes tree?

2019-07-24 Thread Stephen Rothwell
Hi all, During my qemu boot tests (powerpc64 pseries_le_defconfig) today, I got the following BUG: # halt # Stopping network...Saving random seed... [6.515368] random: dd: uninitialized urandom read (512 bytes read) done. Stopping logging: OK [6.796972] BUG: Unable to handle kernel data

Re: CFP: LPC Testing and Fuzzing microconference.

2019-07-24 Thread Dhaval Giani
On Tue, Jul 2, 2019 at 1:12 PM Dhaval Giani wrote: > > Hi folks, > > I am pleased to announce the Testing Microconference has been accepted > at LPC this year. > > The CfP process is now open, and please submit your talks on the LPC > website. It can be found at > https://linuxplumbersconf.org/eve

linux-next: Tree for Jul 25

2019-07-24 Thread Stephen Rothwell
Hi all, Changes since 20190724: New tree: fpga The vfs-fixes tree prodices a BUG in my qemu tests, so I have reverted a commit for today. The jc_docs tree gained a conflict against Linus' tree. The net-next tree gained conflicts against the net and jc_docs trees. The leds tree gained a

Re: [PATCH 5.1 000/371] 5.1.20-stable review

2019-07-24 Thread Naresh Kamboju
On Thu, 25 Jul 2019 at 01:14, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.1.20 release. > There are 371 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

RE: [PATCH V2 1/4] dt-bindings: opp: Support multiple opp-suspend properties

2019-07-24 Thread Anson Huang
Hi, Shawn > On 09-07-19, 16:00, anson.hu...@nxp.com wrote: > > From: Anson Huang > > > > Update opp-suspend property's description to support multiple > > opp-suspend properties defined in DT, the OPP with highest opp-hz and > > with opp-suspend property present will be used as suspend opp. > > >

[PATCH 2/2] Drivers: hv: util: Specify ring buffer size using Hyper-V page size

2019-07-24 Thread Himadri Pandya
VMbus ring buffers are sized based on the 4K page size used by Hyper-V. The Linux guest page size may not be 4K on all architectures so use the Hyper-V page size to specify the ring buffer size. Signed-off-by: Himadri Pandya --- drivers/hv/hv_util.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 0/2] Drivers: hv: Specify buffer size using Hyper-V page size

2019-07-24 Thread Himadri Pandya
recv_buffer and VMbus ring buffers are sized based on guest page size which Hyper-V assumes to be 4KB. It might not be the case for some architectures. Hence instead use the Hyper-V page size. Himadri Pandya (2): Drivers: hv: Specify receive buffer size using Hyper-V page size Drivers: hv: uti

Re: [PATCH] [v2 net-next] ipvs: reduce kernel stack usage

2019-07-24 Thread Julian Anastasov
Hello, On Mon, 22 Jul 2019, Arnd Bergmann wrote: > With the new CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL option, the stack > usage in the ipvs debug output grows because each instance of > IP_VS_DBG_BUF() now has its own buffer of 160 bytes that add up > rather than reusing the stack slot

Re: general protection fault in __pm_runtime_resume

2019-07-24 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:6a3599ce usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=108edb6860 kernel config: https://syzkaller.ap

[PATCH 1/2] Drivers: hv: Specify receive buffer size using Hyper-V page size

2019-07-24 Thread Himadri Pandya
The recv_buffer is used to retrieve data from the VMbus ring buffer. VMbus ring buffers are sized based on the guest page size which Hyper-V assumes to be 4KB. But it may be different on some architectures. So use the Hyper-V page size to allocate the recv_buffer and set the maximum size to receive

Re: Reminder: 99 open syzbot bugs in net subsystem

2019-07-24 Thread Eric Dumazet
On 7/24/19 11:09 PM, Eric Biggers wrote: > On Wed, Jul 24, 2019 at 01:09:28PM -0700, David Miller wrote: >> From: Eric Biggers >> Date: Wed, 24 Jul 2019 11:37:12 -0700 >> >>> We can argue about what words to use to describe this situation, but >>> it doesn't change the situation itself. >> >> A

[PATCH 1/1] power: supply: sbs-battery: Add ability to force load a battery via the devicetree

2019-07-24 Thread Richard Tresidder
Add the ability to force load a hot pluggable battery during boot where there is no gpio detect method available and the module is statically built. Normal polling will then occur on that battery when it is inserted. Signed-off-by: Richard Tresidder --- Notes: Add the ability to force load a

Re: WARNING in __mmdrop

2019-07-24 Thread Michael S. Tsirkin
On Thu, Jul 25, 2019 at 11:44:27AM +0800, Jason Wang wrote: > > On 2019/7/25 上午2:25, Michael S. Tsirkin wrote: > > On Wed, Jul 24, 2019 at 06:08:05PM +0800, Jason Wang wrote: > > > On 2019/7/24 下午4:05, Michael S. Tsirkin wrote: > > > > On Wed, Jul 24, 2019 at 10:17:14AM +0800, Jason Wang wrote: >

Re: [PATCH 1/2] media: ir-kbd-i2c: prevent potential NULL pointer access

2019-07-24 Thread Sean Young
On Mon, Jul 22, 2019 at 07:26:31PM +0200, Wolfram Sang wrote: > i2c_new_dummy() can fail returning a NULL pointer. The code does not > bail out in this case and the returned pointer is blindly used. I don't see how. The existing code tries to set up the tx part; if i2c_new_dummy() return NULL then

Re: [PATCH] mm: replace list_move_tail() with add_page_to_lru_list_tail()

2019-07-24 Thread Minchan Kim
Hi Andrew, On Wed, Jul 24, 2019 at 07:32:49PM -0700, Andrew Morton wrote: > On Tue, 16 Jul 2019 15:24:36 -0600 Yu Zhao wrote: > > > This is a cleanup patch that replaces two historical uses of > > list_move_tail() with relatively recent add_page_to_lru_list_tail(). > > > > Looks OK to me. > >

[PATCH] hv_sock: use HV_HYP_PAGE_SIZE instead of PAGE_SIZE_4K

2019-07-24 Thread Himadri Pandya
Older windows hosts require the hv_sock ring buffer to be defined using 4K pages. This was achieved by using the symbol PAGE_SIZE_4K defined specifically for this purpose. But now we have a new symbol HV_HYP_PAGE_SIZE defined in hyperv-tlfs which can be used for this. This patch removes the defini

Re: [PATCH v3 3/5] OPP: Improve require-opps linking

2019-07-24 Thread Viresh Kumar
On 24-07-19, 21:09, Saravana Kannan wrote: > On Wed, Jul 24, 2019 at 8:07 PM Viresh Kumar wrote: > > We should be doing this whenever a new OPP table is created, and see > > if someone else was waiting for this OPP table to come alive. > > Searching the global OPP table list seems a ton more wast

Re: [PATCH] kbuild: Check for unknown options with cc-option and clang in Kbuild

2019-07-24 Thread Nathan Chancellor
Hi Stephen, Was the second Kbuild in the subject line supposed to be Kconfig? On Wed, Jul 24, 2019 at 04:50:30PM -0700, Stephen Boyd wrote: > If the particular version of clang a user has doesn't enable > -Werror=unknown-warning-option by default, even though it is the > default[1], then make sur

Re: [PATCH 5/6] vhost: mark dirty pages during map uninit

2019-07-24 Thread Michael S. Tsirkin
On Tue, Jul 23, 2019 at 09:19:33PM +0800, Jason Wang wrote: > > On 2019/7/23 下午5:17, Michael S. Tsirkin wrote: > > On Tue, Jul 23, 2019 at 03:57:17AM -0400, Jason Wang wrote: > > > We don't mark dirty pages if the map was teared down outside MMU > > > notifier. This will lead untracked dirty pages

Re: [PATCH v4 0/5] Add required-opps support to devfreq passive gov

2019-07-24 Thread Viresh Kumar
On 24-07-19, 20:40, Saravana Kannan wrote: > On Wed, Jul 24, 2019 at 7:30 PM Viresh Kumar wrote: > > > > On 23-07-19, 18:42, Saravana Kannan wrote: > > > The devfreq passive governor scales the frequency of a "child" device > > > based > > > on the current frequency of a "parent" device (not pare

<    3   4   5   6   7   8   9   10   11   12   >