Re: [PATCH v3 0/3] kernel/notifier.c: avoid duplicate registration

2019-07-16 Thread Vasily Averin
On 7/16/19 5:00 AM, Xiaoming Ni wrote: > On 2019/7/15 13:38, Vasily Averin wrote: >> On 7/14/19 5:45 AM, Xiaoming Ni wrote: >>> On 2019/7/12 22:07, gre...@linuxfoundation.org wrote: On Fri, Jul 12, 2019 at 09:11:57PM +0800, Xiaoming Ni wrote: > On 2019/7/11 21:57, Vasily Averin wrote:

Re: [PATCH v3 2/5] locking/qspinlock: Refactor the qspinlock slow path

2019-07-16 Thread Peter Zijlstra
On Mon, Jul 15, 2019 at 03:25:33PM -0400, Alex Kogan wrote: > +/* > + * set_locked_empty_mcs - Try to set the spinlock value to _Q_LOCKED_VAL, > + * and by doing that unlock the MCS lock when its waiting queue is empty > + * @lock: Pointer to queued spinlock structure > + * @val: Current value of

Re: [PATCH v3 1/5] locking/qspinlock: Make arch_mcs_spin_unlock_contended more generic

2019-07-16 Thread Peter Zijlstra
On Mon, Jul 15, 2019 at 03:25:32PM -0400, Alex Kogan wrote: > diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c > index e14b32c69639..961781624638 100644 > --- a/kernel/locking/qspinlock.c > +++ b/kernel/locking/qspinlock.c > @@ -558,7 +558,7 @@ void queued_spin_lock_slowpath(st

[v5,2/2] Documentation: dt: binding: rtc: add binding for ftm alarm driver

2019-07-16 Thread Biwen Li
The patch adds binding for ftm alarm driver Signed-off-by: Biwen Li --- Change in v5: - None Change in v4: - add note about dts and kernel options - add aliases in example Change in v3: - remove reg-names property - correct cells number Change in v2: - repla

[v5,1/2] rtc/fsl: add FTM alarm driver as the wakeup source

2019-07-16 Thread Biwen Li
For the paltforms including LS1012A, LS1021A, LS1028A, LS1043A, LS1046A, LS1088A, LS208xA that has the FlexTimer module, implementing alarm functions within RTC subsystem to wakeup the system when system going to sleep (work with RCPM driver). Signed-off-by: Biwen Li --- Change in v5: - repla

Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-16 Thread Bharath Vedartham
On Mon, Jul 15, 2019 at 03:01:43PM -0700, John Hubbard wrote: > On 7/15/19 2:47 PM, Matt Sickler wrote: > > It looks like Outlook is going to absolutely trash this email. Hopefully > > it comes through okay. > > > ... > >> > >> Because this is a common pattern, and because the code here doesn't

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

2019-07-16 Thread Chanwoo Choi
Hi Bartlomiej, On 19. 7. 16. 오후 7:13, Bartlomiej Zolnierkiewicz wrote: > > Hi Chanwoo, > > On 7/16/19 5:56 AM, Chanwoo Choi wrote: >> Hi Kamil, >> >> Looks good to me. But, this patch has some issue. >> I added the detailed reviews. >> >> I recommend that you make the separate patches as followi

Re: [PATCH v2 3/4] ARM: dts: exynos: add initial data for coupled regulators for Exynos5422/5800

2019-07-16 Thread Bartlomiej Zolnierkiewicz
On 7/16/19 11:22 AM, Krzysztof Kozlowski wrote: > On Mon, 15 Jul 2019 at 14:04, Kamil Konieczny > wrote: >> >> Declare Exynos5422/5800 voltage ranges for opp points for big cpu core and >> bus wcore and couple their voltage supllies as vdd_arm and vdd_int should >> be in 300mV range. >> >> Signe

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-16 Thread Viresh Kumar
On 15-07-19, 15:24, Niklas Cassel wrote: > This was actually my initial thought when talking to you 6+ months ago. > However, the problem was that, from the CPR drivers' perspective, it > only sees the CPR OPP table. > > > So this is the order things are called, > from qcom-cpufreq-nvmem.c perspe

Re: [PATCH] s390: enable detection of kernel version from bzImage

2019-07-16 Thread Petr Tesarik
On Tue, 16 Jul 2019 00:12:19 +0200 Vasily Gorbik wrote: > Extend "parmarea" to include an offset of the version string, which is > stored as 8-byte big endian value. > > To retrieve version string from bzImage reliably, one should check the > presence of "S390EP" ascii string at 0x10008 (availab

Re: [PATCH v3] mmc: host: sdhci-sprd: Fix the incorrect soft reset operation when runtime resuming

2019-07-16 Thread Adrian Hunter
On 16/07/19 11:39 AM, Baolin Wang wrote: > In sdhci_runtime_resume_host() function, we will always do software reset > for all, which will cause Spreadtrum host controller work abnormally after > resuming. > > Thus for Spreadtrum platform that do not power down the SD/eMMC card during > runtime su

RE: [PATCH] habanalabs: add comments on INFO IOCTL

2019-07-16 Thread Omer Shpigelman
From: Oded Gabbay Sent: Tuesday, 16 July 2019 12:02 > This patch adds some in-code documentation on the different opcodes of > the INFO IOCTL. > > Signed-off-by: Oded Gabbay Reviewed-by: Omer Shpigelman

Re: [PATCH] opp: Return genpd virtual devices from dev_pm_opp_attach_genpd()

2019-07-16 Thread Niklas Cassel
On Mon, Jul 08, 2019 at 11:30:11AM +0530, Viresh Kumar wrote: > The cpufreq drivers don't need to do runtime PM operations on the > virtual devices returned by dev_pm_domain_attach_by_name() and so the > virtual devices weren't shared with the callers of > dev_pm_opp_attach_genpd() earlier. > > Bu

Re: [RESEND PATCH next v2 0/6] ARM: keystone: update dt and enable cpts support

2019-07-16 Thread grygorii
On 06/07/2019 05:18, santosh.shilim...@oracle.com wrote: On 7/5/19 8:12 AM, Grygorii Strashko wrote: Hi Santosh, This series is set of platform changes required to enable NETCP CPTS reference clock selection and final patch to enable CPTS for Keystone 66AK2E/L/HK SoCs. Those patches were po

Re: [PATCH 12/12] closures: fix a race on wakeup from closure_sync

2019-07-16 Thread Coly Li
Hi Kent, On 2019/6/11 3:14 上午, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet Acked-by: Coly Li And also I receive report for suspicious closure race condition in bcache, and people ask for having this patch into Linux v5.3. So before this patch gets merged into upstream, I plan to re

Re: [PATCH v2 2/2] leds: Add control of the voltage/current regulator to the LED core

2019-07-16 Thread Daniel Thompson
On Mon, Jul 15, 2019 at 05:56:57PM +0200, Jean-Jacques Hiblot wrote: > A LED is usually powered by a voltage/current regulator. Let the LED core This is almost certainly nitpicking but since there's enough other review comments that you will have to respin anyway ;-) Is an LED really "usually pow

Re: [PATCH 0/3] perf: Use capabilities instead of uid and euid

2019-07-16 Thread Alexey Budankov
On 03.07.2019 3:10, Igor Lubashev wrote: > Kernel is using capabilities instead of uid and euid to restrict access to > kernel pointers and tracing facilities. This patch series updates the perf to > better match the security model used by the kernel. > > This series enables instructions in > Do

Re: [PATCH v3] mmc: host: sdhci-sprd: Fix the incorrect soft reset operation when runtime resuming

2019-07-16 Thread Baolin Wang
On Tue, 16 Jul 2019 at 18:40, Adrian Hunter wrote: > > On 16/07/19 11:39 AM, Baolin Wang wrote: > > In sdhci_runtime_resume_host() function, we will always do software reset > > for all, which will cause Spreadtrum host controller work abnormally after > > resuming. > > > > Thus for Spreadtrum pla

Re: [PATCH 11/13] arm64: dts: qcom: qcs404: Add CPR and populate OPP table

2019-07-16 Thread Niklas Cassel
On Tue, Jul 16, 2019 at 04:04:36PM +0530, Viresh Kumar wrote: > On 15-07-19, 15:24, Niklas Cassel wrote: > > This was actually my initial thought when talking to you 6+ months ago. > > However, the problem was that, from the CPR drivers' perspective, it > > only sees the CPR OPP table. > > > > >

Re: [PATCH v7 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable

2019-07-16 Thread Juergen Gross
On 11.07.19 14:02, Zhenzhong Duan wrote: .. as "nopv" support needs it to be changeable at boot up stage. Checkpatch report warning, so move variable declarations from hypervisor.c to hypervisor.h Signed-off-by: Zhenzhong Duan Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc:

Re: [PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller

2019-07-16 Thread Benjamin Herrenschmidt
On Tue, 2019-07-16 at 11:33 +0200, Christoph Hellwig wrote: > > >So back to the version > > > you circulated to me in private mail that just sets q->sqes and has a > > > comment that this is magic for The Apple controller. If/when we get > > > standardized large SQE support we'll need to disco

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

2019-07-16 Thread Bartlomiej Zolnierkiewicz
On 7/16/19 12:33 PM, Chanwoo Choi wrote: > Hi Bartlomiej, > > On 19. 7. 16. 오후 7:13, Bartlomiej Zolnierkiewicz wrote: >> >> Hi Chanwoo, >> >> On 7/16/19 5:56 AM, Chanwoo Choi wrote: >>> Hi Kamil, >>> >>> Looks good to me. But, this patch has some issue. >>> I added the detailed reviews. >>> >>>

Re: [PATCH v3 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-07-16 Thread Peter Zijlstra
On Mon, Jul 15, 2019 at 05:30:01PM -0400, Waiman Long wrote: > On 7/15/19 3:25 PM, Alex Kogan wrote: > > /* > > - * On 64-bit architectures, the mcs_spinlock structure will be 16 bytes in > > - * size and four of them will fit nicely in one 64-byte cacheline. For > > - * pvqspinlock, however, we n

Re: [PATCH v3 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-07-16 Thread Peter Zijlstra
On Mon, Jul 15, 2019 at 03:25:34PM -0400, Alex Kogan wrote: > +/** > + * find_successor - Scan the main waiting queue looking for the first > + * thread running on the same node as the lock holder. If found (call it > + * thread T), move all threads in the main queue between the lock holder > + * a

Re: [PATCH v3 10/11] mm/memory_hotplug: Make unregister_memory_block_under_nodes() never fail

2019-07-16 Thread David Hildenbrand
On 16.07.19 10:46, Oscar Salvador wrote: > On Mon, Jul 15, 2019 at 01:10:33PM +0200, David Hildenbrand wrote: >> On 01.07.19 12:27, Michal Hocko wrote: >>> On Mon 01-07-19 11:36:44, Oscar Salvador wrote: On Mon, Jul 01, 2019 at 10:51:44AM +0200, Michal Hocko wrote: > Yeah, we do not allow

Re: [PATCH v3 10/11] mm/memory_hotplug: Make unregister_memory_block_under_nodes() never fail

2019-07-16 Thread David Hildenbrand
On 16.07.19 10:46, Oscar Salvador wrote: > On Mon, Jul 15, 2019 at 01:10:33PM +0200, David Hildenbrand wrote: >> On 01.07.19 12:27, Michal Hocko wrote: >>> On Mon 01-07-19 11:36:44, Oscar Salvador wrote: On Mon, Jul 01, 2019 at 10:51:44AM +0200, Michal Hocko wrote: > Yeah, we do not allow

Re: [PATCH] dt-bindings: Ensure child nodes are of type 'object'

2019-07-16 Thread Mark Brown
On Mon, Jul 15, 2019 at 05:04:57PM -0600, Rob Herring wrote: > Properties which are child node definitions need to have an explict > type. Otherwise, a matching (DT) property can silently match when an > error is desired. Fix this up tree-wide. Once this is fixed, the > meta-schema will enforce thi

Re: [PATCH] net: sctp: fix warning "NULL check before some freeing functions is not needed"

2019-07-16 Thread Neil Horman
On Tue, Jul 16, 2019 at 07:50:02AM +0530, Hariprasad Kelam wrote: > This patch removes NULL checks before calling kfree. > > fixes below issues reported by coccicheck > net/sctp/sm_make_chunk.c:2586:3-8: WARNING: NULL check before some > freeing functions is not needed. > net/sctp/sm_make_chunk.c:

Re: [PATCH 04/13] cpufreq: qcom: Refactor the driver to make it easier to extend

2019-07-16 Thread Niklas Cassel
On Wed, Jul 10, 2019 at 12:00:26PM +0530, Viresh Kumar wrote: > On 05-07-19, 11:57, Niklas Cassel wrote: > > + drv->opp_tables = kcalloc(num_possible_cpus(), sizeof(*drv->opp_tables), > > + GFP_KERNEL); > > + if (!drv->opp_tables) { > > + ret = -ENOMEM; > >

Re: [PATCH 02/13] cpufreq: qcom: Re-organise kryo cpufreq to use it for other nvmem based qcom socs

2019-07-16 Thread Niklas Cassel
On Wed, Jul 10, 2019 at 11:48:39AM +0530, Viresh Kumar wrote: > On 05-07-19, 11:57, Niklas Cassel wrote: > > -static struct platform_driver qcom_cpufreq_kryo_driver = { > > - .probe = qcom_cpufreq_kryo_probe, > > - .remove = qcom_cpufreq_kryo_remove, > > +static struct platform_driver qcom_cpuf

[PATCH 0/2] arm/arm64: Add support for function error injection

2019-07-16 Thread Leo Yan
This small patch set is to add support for function error injection; this can be used to eanble more advanced debugging feature, e.g. CONFIG_BPF_KPROBE_OVERRIDE. I only tested the first patch on arm64 platform Juno-r2 with below steps; the second patch is for arm arch, but I absent the platform fo

[PATCH 2/2] arm: Add support for function error injection

2019-07-16 Thread Leo Yan
This patch implement regs_set_return_value() and override_function_with_return() to support function error injection for arm. In the exception flow, we can update pt_regs::ARM_pc with pt_regs::ARM_lr so that can override the probed function return. Signed-off-by: Leo Yan --- arch/arm/Kconfig

[PATCH 1/2] arm64: Add support for function error injection

2019-07-16 Thread Leo Yan
This patch implement regs_set_return_value() and override_function_with_return() to support function error injection for arm64. In the exception flow, arm64's general register x30 contains the value for the link register; so we can just update pt_regs::pc with it rather than redirecting execution

Re: [PATCH v5] net: netfilter: Fix rpfilter dropping vrf packets by mistake

2019-07-16 Thread Pablo Neira Ayuso
On Tue, Jul 02, 2019 at 03:59:36AM +, Miaohe Lin wrote: > When firewalld is enabled with ipv4/ipv6 rpfilter, vrf > ipv4/ipv6 packets will be dropped. Vrf device will pass > through netfilter hook twice. One with enslaved device > and another one with l3 master device. So in device may > dismatc

Re: [PATCH] ARM64/irqchip: Make ACPI_IORT depend on PCI again

2019-07-16 Thread Sasha Levin
On Tue, Jul 16, 2019 at 12:13:23AM -0400, Sinan Kaya wrote: On 7/16/2019 12:04 AM, Sasha Levin wrote: ACPI_IORT lost it's explicit dependency on PCI in c6bb8f89fa6df ("ARM64/irqchip: Update ACPI_IORT symbol selection logic") where the author has relied on the general dependency of ACPI on PCI.

[PATCH] eeprom: make older eeprom drivers select NVMEM_SYSFS

2019-07-16 Thread Arseny Solokha
misc/eeprom/{at24,at25,eeprom_93xx46} drivers all register their corresponding devices in the nvmem framework in compat mode which requires nvmem sysfs interface to be present. The latter, however, has been split out from nvmem under a separate Kconfig in commit ae0c2d725512 ("nvmem: core: add NVME

Re: linux-next: Fixes tag needs some work in the hyperv-fixes tree

2019-07-16 Thread Sasha Levin
On Mon, Jul 15, 2019 at 08:01:59AM +1000, Stephen Rothwell wrote: Hi Randy, On Sun, 14 Jul 2019 08:02:11 -0700 Randy Dunlap wrote: > Please do not split Fixes tags over more than one line. Also do not > include blank lines among the tag lines. Hm, so you are saying that the Fixes: line shou

Re: [PATCH V13 12/12] PCI: tegra: Add Tegra194 PCIe support

2019-07-16 Thread Lorenzo Pieralisi
On Sat, Jul 13, 2019 at 12:34:34PM +0530, Vidya Sagar wrote: [...] > > > > > +static int tegra_pcie_bpmp_set_ctrl_state(struct tegra_pcie_dw *pcie, > > > > > + bool enable) > > > > > +{ > > > > > + struct mrq_uphy_response resp; > > > > > + struct teg

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

2019-07-16 Thread Chanwoo Choi
Hi, On 19. 7. 16. 오후 7:59, Bartlomiej Zolnierkiewicz wrote: > > On 7/16/19 12:33 PM, Chanwoo Choi wrote: >> Hi Bartlomiej, >> >> On 19. 7. 16. 오후 7:13, Bartlomiej Zolnierkiewicz wrote: >>> >>> Hi Chanwoo, >>> >>> On 7/16/19 5:56 AM, Chanwoo Choi wrote: Hi Kamil, Looks good to me. B

Re: [PATCH v4 01/24] PM / devfreq: tegra30: Change irq type to unsigned int

2019-07-16 Thread Chanwoo Choi
Hi Dmitry, On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > IRQ numbers are always positive, hence the corresponding variable should > be unsigned to keep types consistent. This is a minor change that cleans > up code a tad more. > > Suggested-by: Thierry Reding > Acked-by: MyungJoo Ham > Signed-

Re: [PATCH v3 04/24] dmaengine: qcom_hidma: Remove call to memset after dmam_alloc_coherent

2019-07-16 Thread Robin Murphy
On 15/07/2019 16:17, Sinan Kaya wrote: On 7/15/2019 1:43 AM, Fuqian Huang wrote: Should I rewrite the commit log? Just mention that dma_alloc_coherent has already zeroed the memory and not to reference the commit? I'd like to hear from Robin Murphy that arm smmu driver follows this as well.

Coca Cola Award,

2019-07-16 Thread Nadia Ouedraogo
Coca Cola Award, Your email account have emerged as one of the lucky winner for $3.5,000.000.00USD which you're to contact below person to enable him process the transfer to you through ATM card transfer. For more Inquiries Contact; Name: Ms. Grace Avonkwu Country: Burkina Faso Email: ms.graceav

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

2019-07-16 Thread Bartlomiej Zolnierkiewicz
On 7/16/19 1:26 PM, Chanwoo Choi wrote: > Hi, > > On 19. 7. 16. 오후 7:59, Bartlomiej Zolnierkiewicz wrote: >> >> On 7/16/19 12:33 PM, Chanwoo Choi wrote: >>> Hi Bartlomiej, >>> >>> On 19. 7. 16. 오후 7:13, Bartlomiej Zolnierkiewicz wrote: Hi Chanwoo, On 7/16/19 5:56 AM, Chanwoo

Re: [PATCH] MIPS: fix some more fall through errors in arch/mips

2019-07-16 Thread Paul Burton
Hello, Stephen Rothwell wrote: > Fix these errors: > > arch/mips/cavium-octeon/executive/cvmx-pko.c:489:7: error: this statement may > fall through [-Werror=implicit-fallthrough=] > arch/mips/bcm63xx/dev-flash.c:89:3: error: this statement may fall through > [-Werror=implicit-fallthrough=] > ar

Re: [PATCH v4 02/24] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped

2019-07-16 Thread Chanwoo Choi
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > There is no real need to keep interrupt always-enabled, will be nicer > to keep it disabled while governor is inactive. > > Suggested-by: Thierry Reding > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/tegra30-devfreq.c | 43 +++

Re: [PATCH v3 0/5] Add NUMA-awareness to qspinlock

2019-07-16 Thread Nicholas Piggin
Alex Kogan's on July 16, 2019 5:25 am: > Our evaluation shows that CNA also improves performance of user > applications that have hot pthread mutexes. Those mutexes are > blocking, and waiting threads park and unpark via the futex > mechanism in the kernel. Given that kernel futex chains, which

Re: [PATCH v4 03/24] PM / devfreq: tegra30: Handle possible round-rate error

2019-07-16 Thread Chanwoo Choi
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > The EMC clock rate rounding technically could fail, hence let's handle > the error cases properly. > > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/tegra30-devfreq.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-

Re: [PATCH v4 04/24] PM / devfreq: tegra30: Drop write-barrier

2019-07-16 Thread Chanwoo Choi
Hi Dmitry, On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > There is no need in a write-barrier now, given that interrupt masking is > handled by CPU's GIC now. Hence we know exactly that interrupt won't fire > after stopping the devfreq's governor. In other cases we don't care about > potential buf

Re: [PATCH v4 06/24] PM / devfreq: tegra30: Tune up boosting thresholds

2019-07-16 Thread Chanwoo Choi
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > Now that average-sustain coefficient / multiplier is gone, it won't hurt > to re-tune the boosting thresholds to get a bit harder boosting for MCALL > clients, resulting in a more reactive governing in a case of multimedia > applications usage like 3d

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

2019-07-16 Thread Bartlomiej Zolnierkiewicz
On 7/16/19 1:39 PM, Bartlomiej Zolnierkiewicz wrote: > > On 7/16/19 1:26 PM, Chanwoo Choi wrote: [...] >>> Doesn't seem to be needed, care to explain it more? >> >> In order to fix the sequence problem between clock and regulator >> with dev_pm_opp_set_regualtor() and want to keep two function

[PATCH v2 1/1] mm/vmalloc: do not keep unpurged areas in the busy tree

2019-07-16 Thread Uladzislau Rezki (Sony)
The busy tree can be quite big, even though the area is freed or unmapped it still stays there until "purge" logic removes it. 1) Optimize and reduce the size of "busy" tree by removing a node from it right away as soon as user triggers free paths. It is possible to do so, because the allocation i

Re: [PATCH v3 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-16 Thread Cheng-yi Chiang
On Fri, Jul 12, 2019 at 6:48 PM Russell King - ARM Linux admin wrote: > > On Fri, Jul 12, 2019 at 06:04:40PM +0800, Cheng-Yi Chiang wrote: > > Allow codec driver register callback function for plug event. > > > > The callback registration flow: > > dw-hdmi <--- hw-hdmi-i2s-audio <--- hdmi-codec >

Re: [PATCH v4 07/24] PM / devfreq: tegra30: Use CPUFreq notifier

2019-07-16 Thread Chanwoo Choi
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > The CPU's client need to take into account that CPUFreq may change > while memory activity not, staying high. Thus an appropriate frequency > notifier should be used in addition to the clk-notifier. > > Signed-off-by: Dmitry Osipenko > --- > drivers

[PATCH v2 0/1] do not keep unpurged areas in the busy tree

2019-07-16 Thread Uladzislau Rezki (Sony)
The aim of this patch is to split "unpurged" objects and allocated ones, that gives us some boost in performance, because of less number of objects in the "busy" tree, i.e. insert/lookup/remove operations become faster, what is obvious. The splitting is possible because "purge list", "busy tree" an

Re: [PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller

2019-07-16 Thread Christoph Hellwig
On Tue, Jul 16, 2019 at 08:58:28PM +1000, Benjamin Herrenschmidt wrote: > The main risk is if existing controllers return crap in SQES and we try > to then use that crap. The rest should essentially be NOPs. > > Maybe I should add some kind of printk to warn in case we use/detect a > non-standard

Re: [v2 PATCH 2/2] mm: mempolicy: handle vma with unmovable pages mapped correctly in mbind

2019-07-16 Thread Vlastimil Babka
On 6/22/19 2:20 AM, Yang Shi wrote: > @@ -969,10 +975,21 @@ static long do_get_mempolicy(int *policy, nodemask_t > *nmask, > /* > * page migration, thp tail pages can be passed. > */ > -static void migrate_page_add(struct page *page, struct list_head *pagelist, > +static int migrate_page_add(

Re: [PATCH v4 08/24] PM / devfreq: tegra30: Move clk-notifier's registration to governor's start

2019-07-16 Thread Chanwoo Choi
Hi Dmitiry, On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > There is no point in receiving of the notifications while governor is > stopped, let's keep them disabled like we do for the CPU freq-change > notifications. This also fixes a potential use-after-free bug if > notification happens after de

Re: [PATCH v4 09/24] PM / devfreq: tegra30: Reset boosting on startup

2019-07-16 Thread Chanwoo Choi
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > Governor could be stopped while boosting is active. We have assumption > that everything is reset on governor's restart, including the boosting > value, which was missed. > > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/tegra30-devfreq.c |

Re: cma_remap when using dma_alloc_attr :- DMA_ATTR_NO_KERNEL_MAPPING

2019-07-16 Thread Christoph Hellwig
On Tue, Jul 16, 2019 at 01:02:19PM +0100, Robin Murphy wrote: >> Lets say 4k video allocation required 300MB cma memory but not required >> virtual mapping for all the 300MB, its require only 20MB virtually mapped >> at some specific use case/point of video, and unmap virtual mapping after >> uses,

Re: [PATCH v4 10/24] PM / devfreq: tegra30: Don't enable consecutive-down interrupt on startup

2019-07-16 Thread Chanwoo Choi
Hi Dmitry, On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > The consecutive-down event tells that we should perform frequency > de-boosting, but boosting is in a reset state on start and hence the > event won't do anything useful for us and it will be just a dummy > interrupt request. > > Signed-of

Re: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

2019-07-16 Thread Michael Ellerman
Segher Boessenkool writes: > On Mon, Jul 15, 2019 at 05:05:34PM +1000, Michael Ellerman wrote: >> Segher Boessenkool writes: >> > Yes, that is why I used the environment variable, all binutils work >> > with that. There was no --target option in GNU ar before 2.22. >> >> Yeah, we're not very go

Re: [PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller

2019-07-16 Thread Benjamin Herrenschmidt
On Tue, 2019-07-16 at 14:05 +0200, Christoph Hellwig wrote: > On Tue, Jul 16, 2019 at 08:58:28PM +1000, Benjamin Herrenschmidt wrote: > > The main risk is if existing controllers return crap in SQES and we try > > to then use that crap. The rest should essentially be NOPs. > > > > Maybe I should a

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-16 Thread Chanwoo Choi
Hi Dmitry, Usually, the kernel log print for all users such as changing the frequency, fail or success. But, if the log just show the register dump, it is not useful for all users. It is just used for only specific developer. I recommend that you better to add more exception handling code on man

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-16 Thread Chanwoo Choi
Hi Dmitry, I'm not sure that it is necessary. As I knew, usally, the 'inline' is used on header file to define the empty functions. Do we have to change it with 'inline' keyword? On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > Depending on a kernel's configuration, a single line functions may not

Re: [PATCHv4 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2019-07-16 Thread Nicolas Dufresne
Le lundi 15 juillet 2019 à 14:12 +0200, Maxime Jourdan a écrit : > On Tue, Jun 11, 2019 at 10:29 AM Hans Verkuil > wrote: > > On 6/10/19 9:54 PM, Nicolas Dufresne wrote: > > > Hi Hans, > > > > > > I went through it, and I think we are close to ready. Unfortunately, I > > > believe the SOURCE_CHA

Re: [PATCH v4 13/24] PM / devfreq: tegra30: Constify structs

2019-07-16 Thread Chanwoo Choi
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > Constify unmodifiable structs for consistency. > > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/tegra30-devfreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c > b/driver

Re: [PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller

2019-07-16 Thread Christoph Hellwig
On Tue, Jul 16, 2019 at 10:17:56PM +1000, Benjamin Herrenschmidt wrote: > If we're going to do that, then I can move it back to pci.c and leave > core.c alone then I suppose. Up to you. I'm just doing that for fun, no > beef in that game :-) let me know how you want it. Sounds safest to me.

Re: linux-next: manual merge of the rdma tree with the v4l-dvb-next tree

2019-07-16 Thread Jason Gunthorpe
On Tue, Jul 16, 2019 at 10:46:14AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rdma tree got a conflict in: > > Documentation/index.rst > > between commit: > > 09fdc957ad0d ("docs: leds: add it to the driver-api book") > (and others following) > > from the

Re: [PATCH v4 14/24] PM / devfreq: tegra30: Ensure that target freq won't overflow

2019-07-16 Thread Chanwoo Choi
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > Potentially very high boosting could cause an integer overflow for a > highly clocked memory after conversion to MHz. > > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/tegra30-devfreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --gi

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-16 Thread David Hildenbrand
On 02.07.19 08:42, Rashmica Gupta wrote: > Hi David, > > Sorry for the late reply. Hi, sorry I was on PTO :) > > On Wed, 2019-06-26 at 10:28 +0200, David Hildenbrand wrote: >> On 26.06.19 10:15, Oscar Salvador wrote: >>> On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote: B

Re: [PATCH v4 15/24] PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out

2019-07-16 Thread Chanwoo Choi
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > There is another kHz-conversion bug in the code, resulting in integer > overflow. Although, this time the resulting value is 4294966296 and it's > close to ULONG_MAX, which is okay in this case. > > Signed-off-by: Dmitry Osipenko > --- > drivers/dev

Re: [PATCH] Fix perf test data race for tsan build

2019-07-16 Thread Peter Zijlstra
On Tue, Jul 16, 2019 at 11:10:39AM +0200, Jiri Olsa wrote: > On Wed, Jul 10, 2019 at 03:16:20PM -0700, Numfor Mbiziwo-Tiapo wrote: > > The tsan build of perf gives a data race warning in > > hi, > what's 'tsan build of perf' ? Thread Sanitizer, from the group that brought us KASAN and UBSAN. I'd

Re: [PATCH 4/4] debian: add generic rule file

2019-07-16 Thread Theodore Y. Ts'o
On Tue, Jul 16, 2019 at 05:58:49PM +0900, Masahiro Yamada wrote: > I want debian/ to be kept as a drop-in directory > for packagers, without replacing the upstream debian/rules. > > If a check-in source file is modified in anyway, > scripts/setlocalversion would set -dirty flag, > which I want to

cgroups v2: issues faced attempting to setup cpu limiting

2019-07-16 Thread Kaiwan N Billimoria
Hi, Am facing some issues getting CPU limiting working with cgroups v2. Pl read on for the details; a solution is much appreciated! Env: custom 5.0.0 Linux kernel on x86_64 Fedora 29 When attempting to setup CPU limiting using cgroups v2, I effectively disabled cgroups v1 by passing cgroup_n

Re: linux-next: manual merge of the rdma tree with the v4l-dvb-next tree

2019-07-16 Thread Mauro Carvalho Chehab
Em Tue, 16 Jul 2019 12:26:40 + Jason Gunthorpe escreveu: > On Tue, Jul 16, 2019 at 10:46:14AM +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the rdma tree got a conflict in: > > > > Documentation/index.rst > > > > between commit: > > > > 09fdc957ad0d ("

Re: [kbuild:kbuild 5/19] drivers/atm/eni.o: warning: objtool: eni_init_one()+0xe42: indirect call found in RETPOLINE build

2019-07-16 Thread Seth Forshee
On Tue, Jul 16, 2019 at 03:57:24PM +0900, Masahiro Yamada wrote: > (+ Josh Poimboeuf) > > On Tue, Jul 16, 2019 at 8:44 AM kbuild test robot wrote: > > > > tree: > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git > > kbuild > > head: 0ff0c3753e06c0420c80d

Re: [PATCH v2] futex: generic arch_futex_atomic_op_inuser() cleanup

2019-07-16 Thread Arnd Bergmann
On Tue, Jul 16, 2019 at 8:22 AM Vasily Averin wrote: > > generic smp version of arch_futex_atomic_op_inuser() always returns -ENOSYS > > Signed-off-by: Vasily Averin Acked-by: Arnd Bergmann I see what you mean now, I got confused earlier when I looked at the non-SMP version of the same functio

kbuild: Fail if gold linker is detected

2019-07-16 Thread Thomas Gleixner
The gold linker has known issues of failing the build in random and predictible ways. H.J. stated: "Since building a workable kernel for different kernel configurations isn't a requirement for gold, I don't recommend gold for kernel." So instead of dealing with attempts to duct tape gold sup

Re: kbuild: Fail if gold linker is detected

2019-07-16 Thread Peter Zijlstra
On Tue, Jul 16, 2019 at 02:47:56PM +0200, Thomas Gleixner wrote: > The gold linker has known issues of failing the build in random and > predictible ways. H.J. stated: > > "Since building a workable kernel for different kernel configurations >isn't a requirement for gold, I don't recommend g

Re: [PATCH v4 02/24] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped

2019-07-16 Thread Dmitry Osipenko
16.07.2019 14:47, Chanwoo Choi пишет: > On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: >> There is no real need to keep interrupt always-enabled, will be nicer >> to keep it disabled while governor is inactive. >> >> Suggested-by: Thierry Reding >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/

Re: [PATCH v4 03/24] PM / devfreq: tegra30: Handle possible round-rate error

2019-07-16 Thread Dmitry Osipenko
16.07.2019 14:50, Chanwoo Choi пишет: > On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: >> The EMC clock rate rounding technically could fail, hence let's handle >> the error cases properly. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/devfreq/tegra30-devfreq.c | 17 +++-- >> 1

Re: [PATCH] s390: enable detection of kernel version from bzImage

2019-07-16 Thread Vasily Gorbik
On Tue, Jul 16, 2019 at 10:30:14AM +, Petr Tesarik wrote: > On Tue, 16 Jul 2019 00:12:19 +0200 > Vasily Gorbik wrote: > > > Extend "parmarea" to include an offset of the version string, which is > > stored as 8-byte big endian value. > > > > To retrieve version string from bzImage reliably,

Re: [PATCH v4 07/24] PM / devfreq: tegra30: Use CPUFreq notifier

2019-07-16 Thread Dmitry Osipenko
16.07.2019 15:08, Chanwoo Choi пишет: > On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: >> The CPU's client need to take into account that CPUFreq may change >> while memory activity not, staying high. Thus an appropriate frequency >> notifier should be used in addition to the clk-notifier. >> >> Sign

Re: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

2019-07-16 Thread Sven Van Asbroeck
Hi Andy, On Mon, Jul 15, 2019 at 10:02 PM Andy Duan wrote: > > the phylib already can handle mii bus reset and phy device reset That's a great suggestion, thank you !! I completely overlooked that code. What will happen to the legacy phy reset code in fec? Are there many users left?

Re: [PATCH v4 09/24] PM / devfreq: tegra30: Reset boosting on startup

2019-07-16 Thread Dmitry Osipenko
16.07.2019 15:13, Chanwoo Choi пишет: > On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: >> Governor could be stopped while boosting is active. We have assumption >> that everything is reset on governor's restart, including the boosting >> value, which was missed. >> >> Signed-off-by: Dmitry Osipenko

[PATCH] ocfs2: remove set but not used variable 'last_hash'

2019-07-16 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: fs/ocfs2/xattr.c: In function ocfs2_xattr_bucket_find: fs/ocfs2/xattr.c:3828:6: warning: variable last_hash set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing --- fs/ocfs2/xattr.c | 3 --- 1

RE: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-16 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Fri, Jul 12, 2019 at 21:03:20 > On Fri, 12 Jul 2019 18:40:14 + > Vitor Soares wrote: > > > From: Boris Brezillon > > Date: Fri, Jul 12, 2019 at 17:43:23 > > > > > On Fri, 12 Jul 2019 16:28:02 + > > > Vitor Soares wrote: > > > > > > > From: Bo

[PATCH v5 0/2] mm/vmalloc.c: improve readability and rewrite vmap_area

2019-07-16 Thread Pengfei Li
v4 -> v5 * Base on next-20190716 * patch 1: From Uladzislau Rezki (Sony) (author) - https://lkml.org/lkml/2019/7/16/276 * patch 2: Use v3 v3 -> v4: * Base on next-20190711 * patch 1: From: Uladzislau Rezki (Sony) (author) - https://lkml.org/lkml/2019/7/3/661 * patch 2: Modify the lay

Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

2019-07-16 Thread Dmitry Osipenko
16.07.2019 15:23, Chanwoo Choi пишет: > Hi Dmitry, > > Usually, the kernel log print for all users > such as changing the frequency, fail or success. > > But, if the log just show the register dump, > it is not useful for all users. It is just used > for only specific developer. > > I recommend

[PATCH v5 1/2] mm/vmalloc: do not keep unpurged areas in the busy tree

2019-07-16 Thread Pengfei Li
From: "Uladzislau Rezki (Sony)" The busy tree can be quite big, even though the area is freed or unmapped it still stays there until "purge" logic removes it. 1) Optimize and reduce the size of "busy" tree by removing a node from it right away as soon as user triggers free paths. It is possible

[PATCH v5 2/2] mm/vmalloc: modify struct vmap_area to reduce its size

2019-07-16 Thread Pengfei Li
Objective - The current implementation of struct vmap_area wasted space. After applying this commit, sizeof(struct vmap_area) has been reduced from 11 words to 8 words. Description --- 1) Pack "subtree_max_size", "vm" and "purge_list". This is no problem because A) "subtree_ma

[PATCH] libertas_tf: Use correct channel range in lbtf_geo_init

2019-07-16 Thread YueHaibing
It seems we should use 'range' instead of 'priv->range' in lbtf_geo_init(), because 'range' is the corret one related to current regioncode. Reported-by: Hulk Robot Fixes: 691cdb49388b ("libertas_tf: command helper functions for libertas_tf") Signed-off-by: YueHaibing --- drivers/net/wireless/m

[PATCH 2/2] kbuild: update header compile-test list for v5.3-rc1

2019-07-16 Thread Masahiro Yamada
Some headers graduated from the blacklist. Let hyperv_timer.h join the header-test when CONFIG_X86=y. Add CONFIG guards to nf_tables*.h because they can be compiled when CONFIG_NF_TABLES is enabled. Add a new entry for nf_tables_offload.h to fix the build error for the combination of CONFIG_NF_T

[PATCH 1/2] kbuild: test headers listed in header-test-m as well

2019-07-16 Thread Masahiro Yamada
It will be useful to control the header-test by a tristate option. If CONFIG_FOO is a tristate option, you can write like this: header-test-$(CONFIG_FOO) += foo.h Signed-off-by: Masahiro Yamada --- scripts/Makefile.build | 2 +- scripts/Makefile.lib | 2 +- 2 files changed, 2 insertions(+

Re: [PATCH v2 17/19] drm: rcar-du: crtc: Enable and disable CMMs

2019-07-16 Thread Ulrich Hecht
> On July 6, 2019 at 4:07 PM Jacopo Mondi wrote: > > > Enable/disable the CMM associated with a CRTC at crtc start and stop > time and enable the CMM unit through the Display Extensional Functions > register at group setup time. > > Signed-off-by: Jacopo Mondi > --- > drivers/gpu/drm/rcar-d

Re: [PATCH v2] printk: Do not lose last line in kmsg buffer dump

2019-07-16 Thread Petr Mladek
On Sat 2019-07-13 15:03:00, Sergey Senozhatsky wrote: > On (07/12/19 15:11), Petr Mladek wrote: > > > Looks correct to me as well. > > > > > > Reviewed-by: Sergey Senozhatsky > > > > The patch has been committed into printk.git, branch for-5.3-fixes. > > > > I am still a bit undecided whether t

Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

2019-07-16 Thread Dmitry Osipenko
16.07.2019 15:26, Chanwoo Choi пишет: > Hi Dmitry, > > I'm not sure that it is necessary. > As I knew, usally, the 'inline' is used on header file > to define the empty functions. > > Do we have to change it with 'inline' keyword? The 'inline' attribute tells compiler that instead of jumping int

[PATCH RFC v2] PM / devfreq: Add cpu based scaling support to passive_governor

2019-07-16 Thread Sibi Sankar
From: Saravana Kannan Many CPU architectures have caches that can scale independent of the CPUs. Frequency scaling of the caches is necessary to make sure that the cache is not a performance bottleneck that leads to poor performance and power. The same idea applies for RAM/DDR. To achieve this,

Re: [PATCH] libertas_tf: Use correct channel range in lbtf_geo_init

2019-07-16 Thread Yuehaibing
Pls ignore this, sorry On 2019/7/16 21:25, YueHaibing wrote: > It seems we should use 'range' instead of 'priv->range' > in lbtf_geo_init(), because 'range' is the corret one > related to current regioncode. > > Reported-by: Hulk Robot > Fixes: 691cdb49388b ("libertas_tf: command helper function

Re: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-16 Thread Boris Brezillon
On Tue, 16 Jul 2019 13:22:25 + Vitor Soares wrote: > Hi Boris, > > From: Boris Brezillon > Date: Fri, Jul 12, 2019 at 21:03:20 > > > On Fri, 12 Jul 2019 18:40:14 + > > Vitor Soares wrote: > > > > > From: Boris Brezillon > > > Date: Fri, Jul 12, 2019 at 17:43:23 > > > > > > > On

<    1   2   3   4   5   6   7   >