On Thu, Jul 4, 2019 at 7:00 PM Colin King wrote:
>
> From: Colin Ian King
>
> The variable is_empty is being initialized with a value that is never
> read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
On Thu, 4 Jul 2019, Shijith Thotton wrote:
> On 7/4/19 12:13 AM, Julien Thierry wrote:
> > Looking at handle_percpu_irq(), I think this might be acceptable. But
> > does it make sense to only have kstats for percpu NMIs?
> >
>
> It would be better to have stats for both.
>
> handle_fasteoi_nmi()
Miklos Szeredi wrote:
> Ping? Have you had a chance of looking at this series?
Yeah, through due to time pressure, I haven't managed to do much with it.
I don't agree with all your changes, and also I'd like them to wait till after
the branch of mount API filesystem conversions that I've given
Deallocate the buffer when no longer required.
Signed-off-by: Jorge Ramirez-Ortiz
---
drivers/misc/fastrpc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 98603e235cf0..af8fd2101a1d 100644
--- a/drivers/misc/fastrpc.c
On 7/4/19 9:19 AM, Thomas Gleixner wrote:
> On Thu, 4 Jul 2019, Shijith Thotton wrote:
>> On 7/4/19 12:13 AM, Julien Thierry wrote:
>>> Looking at handle_percpu_irq(), I think this might be acceptable. But
>>> does it make sense to only have kstats for percpu NMIs?
>>>
>>
>> It would be better to
The patch
regulator: implement selector stepping
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.3
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) an
The patch
regulator: max77650: use vsel_step
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.3
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and se
In course of developing shorthand based IPI support issues with the
function which tries to clear eventually pending ISR bits in the local APIC
were observed.
1) O-day testing triggered the WARN_ON() in apic_pending_intr_clear().
This warning is emitted when the function fails to clear pen
Not used outside of the UV apic source.
Signed-off-by: Thomas Gleixner
---
V2: New patch
---
arch/x86/include/asm/apic.h|2 --
arch/x86/kernel/apic/x2apic_uv_x.c |2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/a
Only used locally.
Signed-off-by: Thomas Gleixner
---
arch/x86/include/asm/apic_flat_64.h |8
arch/x86/kernel/apic/apic_flat_64.c |2 +-
arch/x86/kernel/apic/apic_flat_64.h |8
arch/x86/kernel/apic/apic_numachip.c |2 +-
4 files changed, 10 insertions(+), 10
apic->send_IPI_allbutself() takes a vector number as argument.
APIC_DM_NMI is clearly not a vector number. It's defined to 0x400 which is
outside the vector space.
Use NMI_VECTOR instead as that's what it is intended to be.
Fixes: 82da3ff89dc2 ("x86: kgdb support")
Signed-off-by: Thomas Gleixner
All callers of apic->send_IPI_all() and apic->send_IPI_allbutself() contain
the decision logic for shorthand invocation already and invoke
send_IPI_mask() if the prereqisites are not satisfied.
Remove the now redundant decision logic in the 32bit implementation.
Signed-off-by: Thomas Gleixner
--
The 64bit implementations need the same wrappers around
__default_send_IPI_shortcut() as 32bit.
Move them out of the 32bit section.
Signed-off-by: Thomas Gleixner
---
V2: New patch
---
arch/x86/kernel/apic/ipi.c | 30 +++---
arch/x86/kernel/apic/local.h |6 +++---
In order to support IPI/NMI broadcasting via the shorthand mechanism side
effects of shorthands need to be mitigated:
Shorthand IPIs and NMIs hit all CPUs including unplugged CPUs
Neither of those can be handled on unplugged CPUs for obvious reasons.
It would be trivial to just fully disable th
Only used locally.
Signed-off-by: Thomas Gleixner
---
arch/x86/include/asm/ipi.h | 90 ---
arch/x86/kernel/apic/apic_flat_64.c |3 -
arch/x86/kernel/apic/apic_numachip.c |3 -
arch/x86/kernel/apic/bigsmp_32.c |9 ---
arch/x86/kernel/ap
All callers of apic->send_IPI_all() and apic->send_IPI_allbutself() contain
the decision logic for shorthand invocation already and invoke
send_IPI_mask() if the prereqisites are not satisfied.
Remove the now redundant decision logic in the APIC code and the duplicate
helper in probe_64.c.
Signed
Move it where it belongs. That allows to keep all the shorthand logic in
one place.
No functional change.
Signed-off-by: Thomas Gleixner
---
V2: New patch
---
arch/x86/include/asm/smp.h |1 +
arch/x86/kernel/apic/ipi.c | 40
arch/x86/kernel/smp.c
All callers of apic->send_IPI_all() and apic->send_IPI_allbutself() contain
the decision logic for shorthand invocation already and invoke
send_IPI_mask() if the prereqisites are not satisfied.
Implement shorthand support for x2apic.
Signed-off-by: Thomas Gleixner
---
V2: Remove the decision log
To support IPI shorthands wrap invocations of apic->send_IPI_allbutself()
in a helper function, so the static key controlling the shorthand mode is
only in one place.
Fixup all callers.
Signed-off-by: Thomas Gleixner
---
V2: New patch
---
arch/x86/include/asm/apic.h |2 ++
arch/x86/kernel/a
The IPI shorthand functionality delivers IPI/NMI broadcasts to all CPUs in
the system. This can have similar side effects as the MCE broadcasting when
CPUs are waiting in the BIOS or are offlined.
The kernel tracks already the state of offlined CPUs whether they have been
brought up at least once
Nadav noticed that the cpumask allocations in native_send_call_func_ipi()
are noticeable in microbenchmarks.
Use the new cpumask_or_equal() function to simplify the decision whether
the supplied target CPU mask is either equal to cpu_online_mask or equal to
cpu_online_mask except for the CPU on wh
All of these APIC files include the world and some more. Remove the
unneeded cruft.
Signed-off-by: Thomas Gleixner
---
arch/x86/kernel/apic/apic_flat_64.c | 15 ---
arch/x86/kernel/apic/apic_noop.c | 18 +-
arch/x86/kernel/apic/apic_numachip.c |6 +++--
For the upcoming shorthand support for all APIC incarnations the command
line option needs to be available for 64 bit as well.
While at it, rename the control variable, make it static and mark it
__ro_after_init.
Signed-off-by: Thomas Gleixner
---
arch/x86/kernel/apic/ipi.c | 29
The SDM states:
"The destination shorthand field of the ICR allows the delivery mode to be
by-passed in favor of broadcasting the IPI to all the processors on the
system bus and/or back to itself (see Section 10.6.1, Interrupt Command
Register (ICR)). Three destination shorthands are su
To support NMI shorthand broadcasts add the safe wait for ICR idle for NMI
vector delivery.
Signed-off-by: Thomas Gleixner
---
arch/x86/kernel/apic/ipi.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/arch/x86/kernel/apic/ipi.c
+++ b/arch/x86/kernel/apic/ipi.c
@@ -30,7 +30,1
The IPI code of x86 needs to evaluate whether the target cpumask is equal
to the cpu_online_mask or equal except for the calling CPU.
To replace the current implementation which requires the usage of a
temporary cpumask, which might involve allocations, add a new function
which compares a cpumask
No point in having them in an header file.
Signed-off-by: Thomas Gleixner
---
arch/x86/include/asm/ipi.h | 19 ---
arch/x86/kernel/apic/ipi.c | 16 +---
2 files changed, 13 insertions(+), 22 deletions(-)
--- a/arch/x86/include/asm/ipi.h
+++ b/arch/x86/include/asm
arch_smt_update() will be used to control IPI/NMI broadcasting via the
shorthand mechanism. Keeping it in the bugs file and calling the apic
function from there is possible, but not really intuitive.
Move it to a neutral place and invoke the bugs function from there.
No functional change.
Signed
The recent discussion about using HPET as NMI watchdog made me look into
IPI shorthand support. Also Nadav wanted to look into shorthands to speed
up certain TLB operations.
The support for IPI shorthands is rather limited right now and basically
got rendered useless by making it depend on CPU_HOT
The booted once information which is required to deal with the MCE
broadcast issue on X86 correctly is stored in the per cpu hotplug state,
which is perfectly fine for the intended purpose.
X86 needs that information for supporting NMI broadcasting via shortcuts,
but retrieving it from per cpu dat
Now there are three small local headers. Some contain functions which are
only used in one source file.
Move all the inlines and declarations into a single local header and the
inlines which are only used in one source file into that.
Signed-off-by: Thomas Gleixner
---
arch/x86/kernel/apic/apic
If the APIC is soft disabled then unmasking an LVT entry does not work and
the write is ignored. perf_events_lapic_init() tries to do so.
Move the invocation after the point where the APIC has been enabled.
Signed-off-by: Thomas Gleixner
---
arch/x86/kernel/apic/apic.c |5 ++---
1 file chan
If the APIC was already enabled on entry of setup_local_APIC() then
disabling it soft via the SPIV register makes a lot of sense.
That masks all LVT entries and brings it into a well defined state.
Otherwise previously enabled LVTs which are not touched in the setup
function stay unmasked and mig
On Wed 03-07-19 08:47:00, Matthew Wilcox wrote:
> On Mon, Jul 01, 2019 at 02:11:19PM +0200, Jan Kara wrote:
> > BTW, looking into the xarray code, I think I found another difference
> > between the old radix tree code and the new xarray code that could cause
> > issues. In the old radix tree code i
On 7/4/19 6:55 AM, Chris Chiu wrote:
> The WiFi tx power of RTL8723BU is extremely low after booting. So
> the WiFi scan gives very limited AP list and it always fails to
> connect to the selected AP. This module only supports 1x1 antenna
> and the antenna is switched to bluetooth due to some incor
Jesper recently removed page_pool_destroy() (from driver invocation) and
moved shutdown and free of page_pool into xdp_rxq_info_unreg(), in-order to
handle in-flight packets/pages. This created an asymmetry in drivers
create/destroy pairs.
This patch reintroduce page_pool_destroy and add page_pool
On Wed 03-07-19 20:27:28, Matthew Wilcox wrote:
> On Wed, Jul 03, 2019 at 02:28:41PM -0700, Dan Williams wrote:
> > On Wed, Jul 3, 2019 at 12:53 PM Matthew Wilcox wrote:
> > > @@ -211,7 +215,8 @@ static void *get_unlocked_entry(struct xa_state *xas)
> > > for (;;) {
> > > e
Hello Helen,
On 7/3/19 4:08 PM, Helen Koike wrote:
> From: Jacob Chen
>
> This commit add document for rkisp1 meta buffer format
>
> Signed-off-by: Jacob Chen
> Acked-by: Hans Verkuil
> [update for upstream]
> Signed-off-by: Helen Koike
>
> ---
>
> Changes in v7:
> - s/correspond/corresponding
Hello Helen,
On 7/3/19 4:09 PM, Helen Koike wrote:
> From: Jacob Chen
>
> Add DT bindings documentation for Rockchip ISP1
>
> Signed-off-by: Jacob Chen
> Reviewed-by: Rob Herring
> [update for upstream]
> Signed-off-by: Helen Koike
>
> ---
>
> Changes in v7:
> - update document with new design
Fix DVBFE_ALGO_RECOVERY and DVBFE_ALGO_SEARCH_ERROR to use U cast which
fixes undefined behavior error by certain compilers.
Signed-off-by: Luke Nowakowski-Krijger
---
include/media/dvb_frontend.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/media/dvb_frontend
Hello Helen,
On 7/3/19 4:09 PM, Helen Koike wrote:
> From: Jacob Chen
>
> Add DT bindings documentation for Rockchip MIPI D-PHY RX
>
> Signed-off-by: Jacob Chen
> Reviewed-by: Rob Herring
> [update for upstream]
> Signed-off-by: Helen Koike
>
> ---
>
> Changes in v7:
> - updated doc with new d
On Thu, Jul 04, 2019 at 01:50:27PM +0100, Colin King wrote:
> From: Colin Ian King
>
> The variable ret is being initialized with a value that is never
> read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused va
The pull request you sent on Thu, 04 Jul 2019 11:50:55 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-5.2
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/c212ddaee2fd21e8d756dbc3c6119e3259b38fd0
Thank you!
--
Deet-doot-dot, I am a b
On Thu, Jul 04, 2019 at 02:41:44PM +0200, Jesper Dangaard Brouer wrote:
On Thu, 4 Jul 2019 13:22:40 +0300
Ivan Khoronzhuk wrote:
On Wed, Jul 03, 2019 at 07:40:13PM +0200, Jesper Dangaard Brouer wrote:
>On Wed, 3 Jul 2019 13:18:59 +0300
>Ivan Khoronzhuk wrote:
>
>> First of all, it is an abso
On Thu, Jul 04, 2019 at 06:47:07PM +0200, Jesper Dangaard Brouer wrote:
Have trouble with inet today...I will pick up it as my changes depend on it.
And send probably in couple hours after verification.
--
Regards,
Ivan Khoronzhuk
On Wed, Jul 3, 2019 at 8:17 PM Kris Van Hees wrote:
>
> This initial implementation of a tiny subset of DTrace functionality
> provides the following options:
>
> dtrace [-lvV] [-b bufsz] -s script
> -b set trace buffer size
> -l list probes (only works with '-s s
The function ftrace_set_clr_event is declared static and marked
EXPORT_SYMBOL_GPL(), which is at best an odd combination. Because the
function was decided to be a part of API, this commit removes the static
attribute and adds the declaration to the header.
Fixes: f45d1225adb04 ("tracing: Kernel ac
How are you? I hope you're fine, I sent you a message earlier, but there was no
response from you, did you receive my first email to you? I urge you to confirm
receipt of my previous letter and contact me by email
Hi Jesper,
> Jesper recently removed page_pool_destroy() (from driver invocation) and
> moved shutdown and free of page_pool into xdp_rxq_info_unreg(), in-order to
> handle in-flight packets/pages. This created an asymmetry in drivers
> create/destroy pairs.
>
> This patch reintroduce page_pool_d
Hi Ivan,
>
> Have trouble with inet today...I will pick up it as my changes depend on it.
> And send probably in couple hours after verification.
Maybe you'd like to add your signed-off on this one since it was based on your
patchset?
Regards
/Ilias
On Mon, Jun 24, 2019 at 01:24:15PM -0400, Alan Stern wrote:
> On Mon, 24 Jun 2019, Suwan Kim wrote:
>
> > > > + hcd->self.sg_tablesize = ~0;
> > > > + hcd->self.no_sg_constraint = 1;
> > >
> > > You probably shouldn't do this, for two reasons. First, sg_tablesize
> > > of the server'
Hello,
syzbot found the following crash on:
HEAD commit:16c474c9 Add linux-next specific files for 20190704
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=17f8b463a0
kernel config: https://syzkaller.appspot.com/x/.config?x=983f02aae1ef31b6
Hello Helen,
On 7/3/19 4:09 PM, Helen Koike wrote:
> From: Jacob Chen
>
> This is the capture device interface driver that provides the v4l2
> user interface. Frames can be received from ISP1.
>
> Signed-off-by: Jacob Chen
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Yichong Zhong
> Signed
From: Maarten ter Huurne
The SADC component can run at up to 8 MHz on JZ4725B, but is fed
a 12 MHz input clock (EXT). Divide it by two to get 6 MHz, then
set up another divider to match, to produce a 10us clock.
If the clock dividers are left on their power-on defaults (a divider
of 1), the SADC
Hi,
On 04/07/2019 01:16, Lei Wang wrote:
>> #include ?
>>
>> It's best to keep this list sorted, it makes it easier for the maintainer to
>> resolve
>> conflicts when header files get split/moved-around.
>
> It builds fine in our distro. The header seems to have been inherited
> from some othe
On Thu, Jul 04, 2019 at 12:34:30AM -0400, Joel Fernandes (Google) wrote:
> It is possible that the rcuperf kernel test runs concurrently with init
> starting up. During this time, the system is running all grace periods
> as expedited. However, rcuperf can also be run for normal GP tests.
> Right
On 03.07.19 17:59, Greg KH wrote:
>> That's sad, because in embedded world we often have to care about
>> code size, so making those devices optional would be of great help.
>
> Really? are you sure? Try it and see what you really end up saving.
Just in 8250_pci.c alone, I could (depending on
On Thu, 4 Jul 2019 at 09:52, Linus Walleij wrote:
>
> On Wed, Jul 3, 2019 at 3:50 PM Marc Zyngier wrote:
> > On 03/07/2019 13:26, Linus Walleij wrote:
> > > On Wed, Jul 3, 2019 at 11:24 AM tip-bot for Ard Biesheuvel
> > > wrote:
> > >
> > >> Committer: Marc Zyngier
> > >> CommitDate: Wed, 29 M
On Wed 03 Jul 23:46 PDT 2019, YueHaibing wrote:
> If QCOM_Q6V5_MSS is set but QCOM_MDT_LOADER is not,
> building will fails:
>
> drivers/remoteproc/qcom_q6v5_mss.o: In function `q6v5_start':
> qcom_q6v5_mss.c:(.text+0x3260): undefined reference to
> `qcom_mdt_read_metadata'
>
> Add QCOM_MDT_LOA
On Fri, Jun 28, 2019 at 03:57:05PM +0200, Johannes Berg wrote:
> On Wed, 2019-06-26 at 21:34 -0600, Shuah Khan wrote:
> > On 6/26/19 9:25 PM, Jiunn Chang wrote:
> > > Shifting signed 32-bit value by 31 bits is undefined. Changing most
> > > significant bit to unsigned.
> > >
> > > Changes include
On 03-Jul-19 11:44 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 07/03/2019 07:41 AM, Vignesh Raghavendra wrote:
>
Cypress' HyperBus is Low Signal Count, High Performance Double Data Rate
Bus interface between a host system master and one or more slave
interfaces. HyperBus is used
Hi Luke,
On Thu, Jul 4, 2019 at 3:22 PM Luke Nowakowski-Krijger
wrote:
>
> Fix DVBFE_ALGO_RECOVERY and DVBFE_ALGO_SEARCH_ERROR to use U cast which
> fixes undefined behavior error by certain compilers.
>
> Signed-off-by: Luke Nowakowski-Krijger
> ---
> include/media/dvb_frontend.h | 4 ++--
> 1
On Thu, 2019-07-04 at 17:40 +0800, Miles Chen wrote:
> This change adds 3 Kconfig default value tests:
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3005,6 +3005,27 @@ sub process {
>"Use of boolean is deprecated, please use bool
> instead.\n"
On Wed, 26 Jun 2019 20:35:51 -0700 Andrew Morton
wrote:
> > Let me know and I can help orchestate this.
>
> Well. Whatever works. In this situation I'd stage the patches after
> linux-next and would merge them up after the prereq patches have been
> merged into mainline. Easy.
All right, wh
Please use a better subject line.
On 03/07/2019 18:48:16+0200, Frank Wunderlich wrote:
> From: Josef Friedl
>
> add documentation for pmic, rtc and power/reset devicetree bindings
>
> Suggested-by: Frank Wunderlich
> Signed-off-by: Josef Friedl
> Signed-off-by: Frank Wunderlich
> ---
> .../
On Thu, 2019-07-04 at 13:44 +0300, Gilad Ben-Yossef wrote:
> Add *_NOTIFIER_HEAD as variable definition to avoid code like this:
>
> ATOMIC_NOTIFIER_HEAD(foo);
> EXPORT_SYMBOL_GPL(foo);
>
> From triggering the the following warning:
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its fun
Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
handler finished".
fixes below issue reported by coccicheck
sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
Signed-off-by: Hariprasad Kelam
---
sound/soc/co
From: Colin King
Date: Thu, 4 Jul 2019 13:36:51 +0100
> From: Colin Ian King
>
> The variable err is being assigned with a value that is never
> read and it is being updated in the next statement with a new value.
> The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unu
On Thu, Jul 04, 2019 at 06:54:50PM +0200, Jan Kara wrote:
> On Wed 03-07-19 20:27:28, Matthew Wilcox wrote:
> > So I think we're good for all current users.
>
> Agreed but it is an ugly trap. As I already said, I'd rather pay the
> unnecessary cost of waiting for pte entry and have an easy to unde
Hi!
Suspend is broken in next-20190704 on Thinkpad X60. It very very
probably worked ok in 20190701.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
On Thu, 4 Jul 2019 18:03:01 +0200 Oleg Nesterov wrote:
> swap_readpage() sets waiter = bio->bi_private even if synchronous = F,
> this means that the caller can get the spurious wakeup after return. This
> can be fatal if blk_wake_io_task() does set_current_state(TASK_RUNNING)
> after the caller
From: Voon Weifeng
Date: Thu, 4 Jul 2019 00:59:10 +0800
> From: Weifeng Voon
>
> Enable GMAC v4.xx and beyond to support 16KiB buffer.
>
> Signed-off-by: Weifeng Voon
> Signed-off-by: Ong Boon Leong
Applied.
While the individual CHARLCD_BL_xxx options have help texts, the
menu itself does not. Fix this.
Signed-off-by: Mans Rullgard
---
drivers/auxdisplay/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index c52c738e554a..62bf0ef6
From: Pawel Dembicki
Date: Wed, 3 Jul 2019 19:19:20 +0200
> Main goal of this patch series is to add support for parallel bus in
> Vitesse VSC73xx switches. Existing driver supports only SPI mode.
>
> Second change is needed for devices in unmanaged state.
Please respin with the documentation
On 7/3/19 4:08 PM, Helen Koike wrote:
> Hello,
>
> I'm re-sending a new version of ISP(Camera) v4l2 driver for rockchip
> rk3399 SoC.
>
> It is not perfect yet (see known issues below), but I'm sending in case
> some other people already wants to start playing with it.
> I believe de main desi
Debian-based distributions place libc header files in a machine
specific directory (/usr/include/) instead of
/usr/include/asm to support installation of the linux-libc-dev
package from multiple architectures. Move headers installed by
"make headers_install" accordingly using Debian's tuple from
dp
Em Thu, Jul 04, 2019 at 07:21:28PM +0800, liwei (GF) escreveu:
> Hi Arnaldo,
> I found this issue has not been fixed in mainline now, please take a glance
> at this.
See below.
> On 2019/5/23 10:50, Namhyung Kim wrote:
> > On Wed, May 22, 2019 at 08:08:23AM -0300, Arnaldo Carvalho de Melo wrote
On Thu, 2019-07-04 at 21:42 +0200, Cedric Hombourger wrote:
> Debian-based distributions place libc header files in a machine
> specific directory (/usr/include/) instead of
> /usr/include/asm to support installation of the linux-libc-dev
> package from multiple architectures. Move headers installe
> >> This is correct but missing that the above 'return ret' is broken, too.
> >> ret is initialized but 0 in that case.
> >
> > Nice catch! Oh well, given enough eyeballs, ...
>
> I don't think ret is initialized, reg is, not ret .
It is initialized for the broken 'return ret' *above* the one
On Thu, Jul 04, 2019 at 11:53:24AM -0700, Andrew Morton wrote:
> On Wed, 26 Jun 2019 20:35:51 -0700 Andrew Morton
> wrote:
>
> > > Let me know and I can help orchestate this.
> >
> > Well. Whatever works. In this situation I'd stage the patches after
> > linux-next and would merge them up aft
Hey Mimi!
On 2019-07-04 11:46:41, Mimi Zohar wrote:
> Hi Jarkko,
>
> On Thu, 2019-07-04 at 07:48 -0400, Mimi Zohar wrote:
> > On Thu, 2019-07-04 at 13:28 +0200, Roberto Sassu wrote:
> > > On 7/4/2019 12:03 PM, Jarkko Sakkinen wrote:
> > > > On Mon, 2019-07-01 at 15:15 +0200, Michal Suchanek wrote
The one paravirt read_cr2() implementation (Xen) is actually quite
trivial and doesn't need to clobber anything other than the return
register. By making read_cr2() CALLEE_SAVE we avoid all the PUSH/POP
nonsense and allow more convenient use from assembly.
Reviewed-by: Juergen Gross
Signed-off-by
Signed-off-by: Peter Zijlstra (Intel)
---
arch/x86/entry/entry_64.S | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -913,15 +913,16 @@ apicinterrupt IRQ_WORK_VECTOR irq_work
/**
By adding one more option to SAVE_ALL we can make use of it in
common_exception and simplify things. This saves duplication later
where page_fault will no longer use common_exception.
Signed-off-by: Peter Zijlstra (Intel)
---
arch/x86/entry/entry_32.S | 36 +---
There's a bunch of duplication in idtentry, namely the
.Lfrom_usermode_switch_stack is a paranoid=0 copy of the normal flow.
Make this explicit by creating a idtentry_part helper macro.
Signed-off-by: Peter Zijlstra (Intel)
---
arch/x86/entry/entry_64.S | 100 +-
TODO: 32bit, Xen
Signed-off-by: Peter Zijlstra (Intel)
---
arch/x86/entry/entry_64.S | 13 +++---
arch/x86/include/asm/idtentry.h | 49
arch/x86/include/asm/traps.h|1
arch/x86/kernel/cpu/mce/core.c |2 -
arch/x86/kernel/kvm.c
Despire the current efforts to read CR2 before tracing happens there
still exist a number of possible holes:
idtentry page_fault do_page_fault has_error_code=1
call error_entry
TRACE_IRQS_OFF
call trace_hardirqs_off*
#PF // modifies CR2
CA
Since INT3/#BP no longer runs on an IST, this workaround is no longer
required.
Tested by running lockdep+ftrace as described in the initial commit:
5963e317b1e9 ("ftrace/x86: Do not change stacks in DEBUG when calling
lockdep")
Signed-off-by: Peter Zijlstra (Intel)
---
arch/x86/entry/entry
Hi,
Eiichi-san re-discovered the bug earlier found by He Zhe which we've failed to
fix due to getting distracted by discussing how to untangle entry_64.S.
These 3 patches are basically a completion of the initial approach I suggested
in that earlier thread:
https://lkml.kernel.org/r/2019032022
On Thu, 2019-07-04 at 13:34 -0500, Jiunn Chang wrote:
> Would you like me to send v3 with the change log in the patch description?
>
No no, like I said, it's not very useful in this case anyway.
johannes
On 7/4/2019 12:05 AM, Linus Walleij wrote:
> On Wed, Jul 3, 2019 at 7:21 PM Pawel Dembicki wrote:
>
>> This commit introduce how to use vsc73xx platform driver.
>>
>> Signed-off-by: Pawel Dembicki
>
> Nice!
>
>> +If Platform driver is used, the device tree node is an platform device so it
>
On 7/3/2019 10:19 AM, Pawel Dembicki wrote:
> This driver (currently) only takes control of the switch chip over
> SPI and configures it to route packages around when connected to a
> CPU port. But Vitesse chip support also parallel interface.
>
> This patch split driver into two parts: core an
On 7/3/2019 10:19 AM, Pawel Dembicki wrote:
> Driver allow to use devices with disabled iCPU only.
>
> Some devices have pre-initialised iCPU by bootloader.
> That state make switch unmanaged. This patch force reset
> if device is in unmanaged state. In the result chip lost
> internal firmware
Greetings,
On 7/4/2019 9:49 PM, Ben Hutchings wrote:
On Thu, 2019-07-04 at 21:42 +0200, Cedric Hombourger wrote:
Debian-based distributions place libc header files in a machine
specific directory (/usr/include/) instead of
/usr/include/asm to support installation of the linux-libc-dev
package f
Revaluating the bitmap wheight of the online cpus bitmap in every
invocation of num_online_cpus() over and over is a pretty useless
exercise. Especially when num_online_cpus() is used in code pathes like the
IPI delivery of x86 or the membarrier code.
Cache the number of online CPUs in the core an
On Thu, 4 Jul 2019 17:38:02 +0200, Sebastian Andrzej Siewior wrote:
> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
>
> Use spinlock_t for spinlock's definition.
>
> Cc: Jakub Kicinski
Acked-by: Jakub Kicinski
> Cc: "David S. Miller"
> Cc: oss-driv...@netro
On 03/07/2019 18:48:18+0200, Frank Wunderlich wrote:
> @@ -271,14 +268,11 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, rtc);
>
> - rtc->rtc_dev = devm_rtc_allocate_device(rtc->dev);
> - if (IS_ERR(rtc->rtc_dev))
> - return PTR_
Klientskie bazy. Email: proda...@armyspy.com Uznajte podrobnee!
Detect fast REP MOVSB support and use it for page copying.
Inline copy_page(), this saves alternative entry and a function call
overhead which should hopefully improve code generation.
Signed-off-by: Alexey Dobriyan
---
Makefile | 3 +++
arch/x86/include/asm/page_64
I'm tired of rebasing it, so...
"-march=native" has been available in userspace for a long time and is
trivial to enable in Gentoo:
$ grep -e ^CFLAGS /etc/portage/make.conf
CFLAGS="-march=native -O2 -pipe"
Patchset enables kernel compile with "-march=native" and do additional
opt
401 - 500 of 652 matches
Mail list logo
