On Thu, Jul 4, 2019 at 11:47 AM Greg Kroah-Hartman
wrote:
>
> Platform drivers now have the option to have the platform core create
> and remove any needed sysfs attribute files. So take advantage of that
> and do not register "by hand" a bunch of sysfs files.
>
Acked-by: Andy Shevchenko
> Cc:
On Thu, Jul 4, 2019 at 11:47 AM Greg Kroah-Hartman
wrote:
>
> Platform drivers now have the option to have the platform core create
> and remove any needed sysfs attribute files. So take advantage of that
> and do not register "by hand" a sysfs file.
>
> Cc: Darren Hart
> Cc: Andy Shevchenko
>
From: Colin Ian King
The variable is_empty is being initialized with a value that is never
read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/staging/greybus/aud
v2 -> v3:
* patch 1-4: Abandoned
* patch 5:
- Eliminate "flags" (suggested by Uladzislau Rezki)
- Based on https://lkml.org/lkml/2019/6/6/455
and https://lkml.org/lkml/2019/7/3/661
v1 -> v2:
* patch 3: Rename __find_vmap_area to __search_va_in_busy_tree
instead of __search_va_fr
Objective
-
The current implementation of struct vmap_area wasted space.
After applying this commit, sizeof(struct vmap_area) has been
reduced from 11 words to 8 words.
Description
---
1) Pack "subtree_max_size", "vm" and "purge_list".
It is correct because these three variables a
From: Colin Ian King
The variable ret is being initialized with a value that is never
read and it is being updated later with a new value. The
initialization is redundant and can be removed. Also move { brace
to the conventional coding style location.
Addresses-Coverity: ("Unused value")
Signed
On Thu, Jul 4, 2019 at 12:02 PM Florian Eckert wrote:
>
> This patchset adds the following changes to this pcengines-apuv2
> platform device.
>
Before doing anything to this driver, what is the plan for previously
upstreamed:
drivers/leds/leds-apu.c
arch/x86/platform/geode/alix.c
?
> * Add mpc
From: Fugang Duan
The lpuart of imx8ulp is basically the same as imx7ulp, but it
has new feature support based on imx7ulp, like it can assert a
DMA request on EOP(end-of-packet). imx8ulp lpuart use two clocks,
one is ipg bus clock that is used to access registers, the other
is baud clock that is
2019年7月4日(木) 18:36 YueHaibing :
>
> REGMAP_SCCB is selected by ov772x and ov9650 drivers,
> but CONFIG_REGMAP may not, so building will fails:
>
> rivers/media/i2c/ov772x.c: In function ov772x_probe:
> drivers/media/i2c/ov772x.c:1360:22: error: variable ov772x_regmap_config has
> initializer but i
On Thu, Jul 04, 2019 at 09:40:07PM +0800, fugang.d...@nxp.com wrote:
> From: Fugang Duan
>
> The lpuart of imx8ulp is basically the same as imx7ulp, but it
> has new feature support based on imx7ulp, like it can assert a
> DMA request on EOP(end-of-packet). imx8ulp lpuart use two clocks,
> one is
From: Fugang Duan
Add the baud clock requirement for imx8qxp.
Signed-off-by: Fugang Duan
---
Documentation/devicetree/bindings/serial/fsl-lpuart.txt | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt
b/Documentation/
On Thu, Jul 04, 2019 at 06:05:23AM +, Voon, Weifeng wrote:
> > > > > @@ -155,22 +171,26 @@ static int stmmac_mdio_read(struct mii_bus
> > > > > *bus,
> > > > int phyaddr, int phyreg)
> > > > > struct stmmac_priv *priv = netdev_priv(ndev);
> > > > > unsigned int mii_address = priv->h
On Thu, Jun 27, 2019 at 02:44:46PM +0100, Lee Jones wrote:
> On Wed, 26 Jun 2019, Andy Shevchenko wrote:
>
> > On Wed, Jun 26, 2019 at 11:17:27AM +0100, Lee Jones wrote:
> > > On Wed, 26 Jun 2019, Andy Shevchenko wrote:
> > > > On Mon, Jun 24, 2019 at 05:13:48PM +0100, Lee Jones wrote:
> > > > > O
> On 04-Jul-2019, at 5:29 PM, Mimi Zohar wrote:
>
> On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote:
>> The nr_allocated_banks and allocated banks are initialized as part of
>> tpm_chip_register. Currently, this is done as part of auto startup
>> function. However, some drivers, like the ib
On Thu, Jul 04, 2019 at 04:00:00PM +0300, Boaz Harrosh wrote:
> On 04/07/2019 06:27, Matthew Wilcox wrote:
> > On Wed, Jul 03, 2019 at 02:28:41PM -0700, Dan Williams wrote:
> >>> +#ifdef CONFIG_XARRAY_MULTI
> >>> + unsigned int sibs = xas->xa_sibs;
> >>> +
> >>> + while (sibs) {
> >>> +
Hello Andy,
thanks for feedback
This patchset adds the following changes to this pcengines-apuv2
platform device.
Before doing anything to this driver, what is the plan for previously
upstreamed:
drivers/leds/leds-apu.c
I think we can remove the related APU2/APU3 code stuff from this driv
On Wed, Jul 3, 2019 at 11:39 PM Andrzej Hajda wrote:
>
> On 30.06.2019 15:14, Rob Clark wrote:
> > From: Rob Clark
> >
> > If we are going to -EPROBE_DEFER due to panel/bridge not probed yet, we
> > want to do it before we start touching hardware.
>
>
> As the evidence shows, if the driver create
From: Jian Shen
For revision 0x20, the broadcast promisc is enabled by firmware,
it's unnecessary to enable it when initializing VF.
For revision 0x21, it's necessary to enable broadcast promisc mode
when initializing or re-initializing VF, otherwise, it will be
unable to send and receive promis
From: Peng Li
The value of param type is always not changed in
hclgevf_bind_ring_to_vector, move the assignment to
front of "for {}" can reduce the redundant assignment.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 5 ++---
This patch-set includes cleanups and bugfixes for
the HNS3 ethernet controller driver.
[patch 1/9] fixes VF's broadcast promisc mode not enabled after
initializing.
[patch 2/9] adds hints for fibre port not support flow control.
[patch 3/9] fixes a port capbility updating issue.
[patch 4/9 - 9/
From: Weihang Li
The value of msg_data may be NULL in some cases, which will cause
errors reported by some compiler.
So this patch adds a check to fix it.
Signed-off-by: Weihang Li
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.
From: Jian Shen
Flow control autoneg is unsupported for fibre port. It takes no
effect for flow control when restart autoneg. This patch fixes
it, return -EOPNOTSUPP when user tries to enable flow control
autoneg.
Signed-off-by: Jian Shen
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
From: Peng Li
Currently, the HNS3 driver just defines part of IMP return code,
This patch supplements all the remaining IMP return code, and adds
a function to convert this code to the error number.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
.../net/ethernet/hisilicon/hns3/hns3pf/
From: Peng Li
If HCLGE_MBX_MAX_RESP_DATA_SIZE > HCLGE_MBX_MAX_RESP_DATA_SIZE,
the memcpy will cause out of memory. So this patch just set
resp_data_len to the maximum length for this case.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_
From: Yonglong Liu
There are some bitwise operator used signed type, this patch fixes
them with unsigned type.
Signed-off-by: Yonglong Liu
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 9 +++--
drivers/net/ethernet/hisilicon/hns3
From: Jian Shen
Currently, the driver queries the media port information, and
updates the port capability periodically. But it sets an error
mac->speed_type value, which stops update port capability.
Fixes: 88d10bd6f730 ("net: hns3: add support for multiple media type")
Signed-off-by: Jian Shen
Rename it as well as __do_cpuid_ent and __do_cpuid_ent_emulated to have
"func" in its name, and drop the index parameter which is always 0.
Signed-off-by: Paolo Bonzini
---
arch/x86/kvm/cpuid.c | 89 +---
1 file changed, 42 insertions(+), 47 deletions(-)
From: Peng Li
This patch adds default value for tc_size and tc_offset, or it may
get random value and used later.
Signed-off-by: Peng Li
Signed-off-by: Huazhong Tan
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
do_cpuid_1_ent is typically called in two places by __do_cpuid_func
for CPUID functions that have subleafs. Both places have to set
the KVM_CPUID_FLAG_SIGNIFCANT_INDEX. Set that flag, and
KVM_CPUID_FLAG_STATEFUL_FUNC as well, directly in do_cpuid_1_ent.
Signed-off-by: Paolo Bonzini
---
arch/x8
CPUID function 7 has multiple subleafs. Instead of having nested
switch statements, move the logic to filter supported features to
a separate function, and call it for each subleaf.
Signed-off-by: Paolo Bonzini
---
Here you would have something like entry->eax = min(entry->eax, 1)
do_cpuid_1_ent does not do the entire processing for a CPUID entry, it
only retrieves the host's values. Rename it to match reality.
Signed-off-by: Paolo Bonzini
---
arch/x86/kvm/cpuid.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kvm/cpuid.c b/
The has_leaf_count member was originally added for KVM's paravirtualization
CPUID leaves. However, since then the leaf count _has_ been added to those
leaves as well, so we can drop that special case.
Signed-off-by: Paolo Bonzini
---
arch/x86/kvm/cpuid.c | 11 +++
1 file changed, 3 inse
While reviewing the AVX512_BF16, Jing Liu and I noted that the handling of
CPUID leaf 7 is quite messy, and in general the handling of multi-index
CPUID leaves is confusing. These patches clean the code to prepare
for adding CPUID leaf 7 subleaf 1.
Paolo Bonzini (5):
KVM: cpuid: do_cpuid_ent wo
syzbot has found a reproducer for the following crash on:
HEAD commit:7829a896 usb-fuzzer: main usb gadget fuzzer driver
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=12e5bf93a0
kernel config: https://syzkaller.ap
On Thu, 4 Jul 2019 at 08:26, Fuqian Huang wrote:
>
> Several drivers cast a struct device pointer to a struct
> platform_device pointer only to then call platform_get_drvdata().
> To improve readability, these constructs can be simplified
> by using dev_get_drvdata() directly.
>
> Signed-off-by: F
On Thu, Jul 04, 2019 at 03:57:19PM +0300, Denis Efremov wrote:
> The functions torture_onoff_cleanup, torture_shuffle_cleanup are declared
> as static and marked as EXPORT_SYMBOL. It's a bit confusing for an
> internal function to be exported. The area of visibility for such function
> is its .c fi
Completion queue address reservation could not be undone.
In case of bad 'queue_id' or skb allocation failure, reserved entry
will be leaked reducing the total capacity of completion queue.
Fix that by moving reservation to the point where failure is not
possible. Additionally, 'queue_id' checking
On Thu, Jul 04, 2019 at 04:29:40PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 4, 2019 at 11:47 AM Greg Kroah-Hartman
> wrote:
> >
> > Platform drivers now have the option to have the platform core create
> > and remove any needed sysfs attribute files. So take advantage of that
> > and do not re
> On Thu, Jul 04, 2019 at 07:03:52PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Today's linux-next merge of the hmm tree got a conflict in:
>>
>> include/linux/ioport.h
>>
>> between commit:
>>
>> ae9e13d621d6 ("x86/e820, ioport: Add a new I/O resource descriptor
>> IORES_DESC_RESERVED"
On Thu, Jul 4, 2019 at 5:00 PM Florian Eckert wrote:
>
> Hello Andy,
>
> thanks for feedback
>
> >> This patchset adds the following changes to this pcengines-apuv2
> >> platform device.
> >>
> >
> > Before doing anything to this driver, what is the plan for previously
> > upstreamed:
> >
> > driv
From: Fugang Duan
iMX8 fuse word index represent as one 4-bytes word,
it should not be divided by 4.
Exp:
- MAC0 address layout in fuse:
offset 708: MAC[3] MAC[2] MAC[1] MAC[0]
offset 709: XX xx MAC[5] MAC[4]
Signed-off-by: Fugang Duan
---
drivers/nvmem/imx-ocotp-scu.c | 6 +++---
1 f
From: Fugang Duan
i.MX8QM efuse table has some difference with i.MX8QXP platform,
so add i.MX8QM platform support.
Signed-off-by: Fugang Duan
---
drivers/nvmem/imx-ocotp-scu.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu
> OK, here I guess I see what you mean. You're saying if ethtool were to
> send a value/mask of "0..0100/0..0111" you wouldn't know what to do with
> BIT(4) as long as the kernel knows about that bit?
>
> I guess the difference now is depending on the operation. NLA_BITFIELD32
> is sort of built o
On 04/07/2019 16:58, Matthew Wilcox wrote:
> On Thu, Jul 04, 2019 at 04:00:00PM +0300, Boaz Harrosh wrote:
<>
>> Matthew you must be kidding an ilog2 in binary is zero clocks
>> (Return the highest bit or something like that)
>
> You might want to actually check the documentation instead of just
>
Two patches addressing bugs in ftrace function probe handling. The first
patch addresses a NULL pointer dereference reported by LTP tests, while
the second one is a trivial patch to address a missing check for return
value, found by code inspection.
- Naveen
Naveen N. Rao (2):
ftrace: Fix N
In register_ftrace_function_probe(), we are not checking the return
value of alloc_and_copy_ftrace_hash(). The subsequent call to
ftrace_match_records() may end up dereferencing the same. Add a check to
ensure this doesn't happen.
Signed-off-by: Naveen N. Rao
---
kernel/trace/ftrace.c | 5 +
LTP testsuite on powerpc results in the below crash:
Unable to handle kernel paging request for data at address 0x
Faulting instruction address: 0xc029d800
Oops: Kernel access of bad area, sig: 11 [#1]
LE SMP NR_CPUS=2048 NUMA PowerNV
...
CPU: 68 PID: 96584 Comm: cat Kd
From: Jesper Dangaard Brouer
> The page_pool_request_shutdown() API return indication if there are any
> in-flight frames/pages, to know when it is safe to call
> page_pool_free(), which you are also missing a call to.
>
> This page_pool_request_shutdown() is only intended to be called from
> xd
> I reworked the commit message as follows, so could you please check
> to make sure that I didn't fold, spindle, or otherwise mutilate
> something?
>
> Thanx, Paul
Perfect, thanks!
Denis
Hi Petr,
On 2019-07-04, Petr Mladek wrote:
> This is POC that implements the lockless printk ringbuffer slightly
> different way. I believe that it is worth considering because it looks
> much easier to deal with. The reasons are:
>
> + The state of each entry is always clear.
>
> + T
From: Colin Ian King
The variable retval is being initialized with a value that is never
read and it is being updated later with a new value. The
initialization is redundant and can be removed. Also remove a blank
line.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
dr
Commit a993db88d17d ("net: stmmac: Enable support for > 32 Bits
addressing in XGMAC"), introduced support for > 32 bits addressing in
XGMAC but the conversion of descriptors to dma_addr_t was left out.
As some devices assing coherent memory in regions > 32 bits we need to
set lower and upper value
Add support for coalescing RX path by specifying number of frames which
don't need to have interrupt on completion bit set.
This is only available when RX Watchdog is enabled.
Acked-by: Jakub Kicinski
Signed-off-by: Jose Abreu
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Ale
Some performace improvements (01/03 and 03/03) and a fix (02/03), all for -next.
Cc: Joao Pinto
Cc: David S. Miller
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (3):
net: stmmac: Implement RX Coalesce Frames setting
net: stmmac: Fix descriptors address being in > 32 bits address
Mapping and unmapping DMA region is an high bottleneck in stmmac driver,
specially in the RX path.
This commit introduces support for Page Pool API and uses it in all RX
queues. With this change, we get more stable troughput and some increase
of banwidth with iperf:
- MAC1000 - 950 Mbps
On Thu, 4 Jul 2019 14:45:59 +
Jose Abreu wrote:
> From: Jesper Dangaard Brouer
>
> > The page_pool_request_shutdown() API return indication if there are any
> > in-flight frames/pages, to know when it is safe to call
> > page_pool_free(), which you are also missing a call to.
> >
> > This
On 7/4/19 4:09 AM, Michal Hocko wrote:
> On Wed 03-07-19 16:54:35, Mike Kravetz wrote:
>> On 7/3/19 2:43 AM, Mel Gorman wrote:
>>> Indeed. I'm getting knocked offline shortly so I didn't give this the
>>> time it deserves but it appears that part of this problem is
>>> hugetlb-specific when one nod
From: Jesper Dangaard Brouer
> You can just use page_pool_free() (p.s I'm working on reintroducing
> page_pool_destroy wrapper). As you say, you will not have in-flight
> frames/pages in this driver use-case.
Well, if I remove the request_shutdown() it will trigger the "API usage
violation" WA
From: Andrew Lunn
> Yes, that is all clear. The stmmac_mdio_c45_setup() does part of this
> setup. There is also a write to mii_address which i snipped out when
> replying. But why do you need to write to the data registers during a
> read? C22 does not need this write. Are there some bits in the
On 7/4/19 2:10 PM, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Thu, Jul 4, 2019 at 2:08 PM Wolfram Sang wrote:
>> On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote:
>>> gcc-9 complains about a blatant uninitialized variable use that
>>> all earlier compiler versions missed:
>>>
>>>
> > > > > > @@ -155,22 +171,26 @@ static int stmmac_mdio_read(struct
> > > > > > mii_bus *bus,
> > > > > int phyaddr, int phyreg)
> > > > > > struct stmmac_priv *priv = netdev_priv(ndev);
> > > > > > unsigned int mii_address = priv->hw->mii.addr;
> > > > > > unsigned int mii_data = priv
On Thu, Jul 04, 2019 at 07:56:45AM +0200, Greg Kroah-Hartman wrote:
> This is a driver, do not call "raw" sysfs functions, instead call driver
> core ones. Specifically convert the use of sysfs_create_files() and
> sysfs_remove_files() to use device_add_groups() and
> device_remove_groups()
Hi Gr
On Thu, 4 Jul 2019 19:26:36 +0530
Sachin Sant wrote:
> > On 04-Jul-2019, at 5:29 PM, Mimi Zohar wrote:
> >
> > On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote:
> >> The nr_allocated_banks and allocated banks are initialized as part of
> >> tpm_chip_register. Currently, this is done as par
On 7/2/19 2:37 AM, Maximilian Luz wrote:
+static int soc_device_check_MSHW0040(struct device *dev)
+{
+ acpi_handle handle = ACPI_HANDLE(dev);
+ union acpi_object *result;
+ u64 oem_platform_rev = 0;
+ int gpios;
+
+ // get OEM platform revision
+ result = acpi
On Thu, 4 Jul 2019 15:18:19 +
Jose Abreu wrote:
> From: Jesper Dangaard Brouer
>
> > You can just use page_pool_free() (p.s I'm working on reintroducing
> > page_pool_destroy wrapper). As you say, you will not have in-flight
> > frames/pages in this driver use-case.
>
> Well, if I remov
This series contains a minor fix for the AMD PLL USB quirk plus
some clean up to the related code.
Ryan Kennedy (2):
usb: pci-quirks: Correct AMD PLL quirk detection
usb: pci-quirks: Minor cleanup for AMD PLL quirk
drivers/usb/host/ehci-pci.c | 4 ++--
drivers/usb/host/ohci-pci.c | 2 +
usb_amd_find_chipset_info() is used for chipset detection for
several quirks. It is strange that its return value indicates
the need for the PLL quirk, which means it is often ignored.
This patch adds a function specifically for checking the PLL
quirk like the other ones. Additionally, rename probe
The AMD PLL USB quirk is incorrectly enabled on newer Ryzen
chipsets. The logic in usb_amd_find_chipset_info currently checks
for unaffected chipsets rather than affected ones. This broke
once a new chipset was added in e788787ef. It makes more sense
to reverse the logic so it won't need to be upda
Just a small series to clean up various "struct spinlock" user and make
them use "spinlock_t" instead.
Sebastian
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".
Use spinlock_t for spinlock's definition.
Cc: Jakub Kicinski
Cc: "David S. Miller"
Cc: oss-driv...@netronome.com
Cc: net...@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/net/ethernet/netronom
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".
Use spinlock_t for spinlock's definition.
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: linux-cry...@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/crypto/ux500/cryp/cryp.h | 4 ++--
drivers/cr
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".
Use spinlock_t for spinlock's definition.
Cc: Wim Van Sebroeck
Cc: Guenter Roeck
Cc: linux-watch...@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/watchdog/ie6xx_wdt.c | 2 +-
1 file changed,
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".
Use spinlock_t for spinlock's definition.
Cc: Greg Kroah-Hartman
Cc: Christian Gromm
Cc: de...@driverdev.osuosl.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/staging/most/net/net.c | 3 +--
drivers/s
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".
Use spinlock_t for spinlock's definition.
Cc: linux...@kvack.org
Cc: Andrew Morton
Signed-off-by: Sebastian Andrzej Siewior
---
include/linux/vmpressure.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Thu, 4 Jul 2019 17:04:14 +0200
Jose Abreu wrote:
> @@ -1498,8 +1480,9 @@ static void free_dma_rx_desc_resources(struct
> stmmac_priv *priv)
> sizeof(struct dma_extended_desc),
> rx_q->dma_erx, rx_q->dma_rx_phy);
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".
Use spinlock_t for spinlock's definition.
Cc: Linus Walleij
Cc: Bartosz Golaszewski
Cc: linux-g...@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/gpio/gpiolib.h | 2 +-
1 file changed, 1 inser
From: Sebastian Andrzej Siewior
> Sent: 04 July 2019 16:38
>
> Just a small series to clean up various "struct spinlock" user and make
> them use "spinlock_t" instead.
I thought it was policy to avoid typedefs?
Probably because you can only define them once.
David
-
Registered Address
From: Colin Ian King
The variable rc is being initialized with a value that is never
read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c
From: Jesper Dangaard Brouer
> This code is okay, but I would likely write it as:
>
> if (rx_q->page_pool) {
> page_pool_request_shutdown(rx_q->page_pool));
> page_pool_free(rx_q->page_pool);
> }
>
> Because (as you noticed) page_pool_free() have some API misuse checks,
> that w
On 2019-07-04 15:39:41 [+], David Laight wrote:
> I thought it was policy to avoid typedefs?
> Probably because you can only define them once.
We don't have many of them but we have them and should stick to them.
|$ git grep -A4 "spinlock de" scripts/
|scripts/checkpatch.pl:# check for struct
Hi,
On Thu, 4 Jul 2019 22:20:15 +0800 fugang.d...@nxp.com wrote:
> From: Fugang Duan
>
> iMX8 fuse word index represent as one 4-bytes word,
> it should not be divided by 4.
>
> Exp:
> - MAC0 address layout in fuse:
> offset 708: MAC[3] MAC[2] MAC[1] MAC[0]
> offset 709: XX xx MAC[5] M
AMD and Intel both have serializing lfence (X86_FEATURE_LFENCE_RDTSC).
They've both had it for a long time, and AMD has had it enabled in Linux
since Spectre v1 was announced.
Back then, there was a proposal to remove the serializing mfence feature
bit (X86_FEATURE_MFENCE_RDTSC), since both AMD an
Hi Jarkko,
On Thu, 2019-07-04 at 07:48 -0400, Mimi Zohar wrote:
> On Thu, 2019-07-04 at 13:28 +0200, Roberto Sassu wrote:
> > On 7/4/2019 12:03 PM, Jarkko Sakkinen wrote:
> > > On Mon, 2019-07-01 at 15:15 +0200, Michal Suchanek wrote:
> > >> This reverts commit 0b6cf6b97b7ef1fa3c7fefab0cac897a1c4a
> Yes, the top 16 bit of the data register only valid when C45 is enable.
> It contains the Register address which MDIO c45 frame intended for.
I think there is too much passing variables around by reference than
by value, to make this code easy to understand.
Maybe a better structure would be
s
On 11:25-20190704, Felipe Balbi wrote:
[...]
> This is what I get for trusting people to do their part. I couldn't even
> compile test this since I don't have ARM compilers anymore (actually,
> just installed to test). Your customer, however, uses ARM cores so I
> would
Hi Linus,
I'm sending an early pull request for 5.3 as I'll be on holiday for the
next two weeks. The PTRACE_SYSEMU patches touch powerpc and x86 lightly
(the acks are in place). There are a few conflicts but nothing
complicated, the resolution is as per linux-next. If anything goes
wrong, Will is
On Thu, Jul 04, 2019 at 02:30:31PM +0100, Colin King wrote:
> From: Colin Ian King
>
> The variable is_empty is being initialized with a value that is never
> read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unus
From: Adrian Hunter
Add aux_source attribute flag to match the kernel's perf_event.h file.
Signed-off-by: Adrian Hunter
Signed-off-by: Alexander Shishkin
---
tools/include/uapi/linux/perf_event.h | 3 ++-
tools/perf/util/evsel.c | 1 +
2 files changed, 3 insertions(+), 1 deletio
In some cases, ordinary (non-AUX) events can generate data for AUX events.
For example, PEBS events can come out as records in the Intel PT stream
instead of their usual DS records, if configured to do so.
One requirement for such events is to consistently schedule together, to
ensure that the dat
From: Adrian Hunter
Process synth_opts.other_events and attr.aux_source to set up for
synthesizing PEBs via Intel PT events.
Signed-off-by: Adrian Hunter
Signed-off-by: Alexander Shishkin
---
tools/perf/arch/x86/util/intel-pt.c | 23 +++
tools/perf/util/intel-pt.c
Hi Peter,
Second attempt at the PEBS-via-PT feature. The previous one is here [1].
This one depends on the legitimacy including exclusive events (PT, in this
case) in groups, as I posted earlier [2]. Although, it will work without
that patch, because this kind of grouping wasn't really disallowed.
On 07/03, Hugh Dickins wrote:
>
> Thank you, Oleg. But, with respect, I'd caution against making it cleverer
> at the last minute: what you posted already is understandable, works, has
> Jen's Reviewed-by and my Acked-by: it just lacks a description and signoff.
OK, agreed. I am sending that patch
From: Adrian Hunter
Expose the aux_source attribute flag to the user to configure, by adding a
config term 'aux-source'. For events that support it, selection of
'aux-source' causes the generation of AUX records instead of event records.
This requires that an AUX area event is also provided.
Sig
If PEBS declares ability to output its data to Intel PT stream, use the
aux_source attribute bit to enable PEBS data output to PT. This requires
a PT event to be present and scheduled in the same context. Unlike the
DS area, the kernel does not extract PEBS records from the PT stream to
generate co
From: Adrian Hunter
Add itrace option 'o' to synthesize events recorded in the AUX area due to
the use of perf record's aux-source config term.
Signed-off-by: Adrian Hunter
Signed-off-by: Alexander Shishkin
---
tools/perf/Documentation/itrace.txt | 2 ++
tools/perf/util/auxtrace.c |
From: Adrian Hunter
Document how to select PEBS via Intel PT and how to display synthesized
PEBS samples.
Signed-off-by: Adrian Hunter
Signed-off-by: Alexander Shishkin
---
tools/perf/Documentation/intel-pt.txt | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tools/perf/Do
Hi Tyler,
>-Original Message-
>From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi-
>ow...@vger.kernel.org] On Behalf Of Tyler Baicar OS
>Sent: 02 July 2019 17:52
>To: Open Source Submission ; linux-arm-
>ker...@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
>a...@vger.ker
swap_readpage() sets waiter = bio->bi_private even if synchronous = F,
this means that the caller can get the spurious wakeup after return. This
can be fatal if blk_wake_io_task() does set_current_state(TASK_RUNNING)
after the caller does set_special_state(), in the worst case the kernel
can crash
From: Lothar Waßmann Sent: Thursday, July 4, 2019
11:46 PM
> Hi,
>
> On Thu, 4 Jul 2019 22:20:15 +0800 fugang.d...@nxp.com wrote:
> > From: Fugang Duan
> >
> > iMX8 fuse word index represent as one 4-bytes word, it should not be
> > divided by 4.
> >
> > Exp:
> > - MAC0 address layout in fuse:
Arnaldo Carvalho de Melo writes:
>> Awaiting V2, here is a link to the patches:
>>
>>
>> https://lore.kernel.org/lkml/20190502105022.15534-1-alexander.shish...@linux.intel.com/
>
> yeah, I saw those and PeterZ's comments, that is why I asked about them
> :-)
>
>> There is also still a fe
301 - 400 of 652 matches
Mail list logo
