Re: [PATCH] time/tick-broadcast: Fix tick_broadcast_offline() lockdep complaint

2019-06-21 Thread Paul E. McKenney
On Fri, Jun 21, 2019 at 12:55:03PM +0200, Peter Zijlstra wrote: > On Thu, Jun 20, 2019 at 03:13:36PM -0700, Paul E. McKenney wrote: > > So how about the following patch, which passes very light rcutorture > > testing but should otherwise be regarded as being under suspicion? > > Looks good to me,

Re: [RFC PATCH v2 1/2] printk-rb: add a new printk ringbuffer implementation

2019-06-21 Thread Andrea Parri
> > FWIW (and as anticipated time ago in a private email), when I see code > > like this I tend to look elsewhere... ;-/ > > Do you really mean "code" or are you just referring to "code comments"? > If you really mean code, then I'd appreciate some feedback about what > should change. I really j

[PATCH] scsi: ufshdc-pci: Add Intel PCI Ids for EHL

2019-06-21 Thread Adrian Hunter
Add more Intel PCI Ids. Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c index ffe6f82182ba..3b19de3ae9a3 100644 --- a/drivers/scsi/ufs/ufshcd-pci.c +++ b/drivers/scs

Re: [PATCH v6 4/7] i2c: core: Make i2c_acpi_get_irq available to the rest of the I2C core

2019-06-21 Thread Andy Shevchenko
On Fri, Jun 21, 2019 at 11:08:12AM +0100, Charles Keepax wrote: > In preparation for more refactoring make i2c_acpi_get_irq available > outside i2c-core-acpi.c. > > Signed-off-by: Charles Keepax > --- > > Changes since v5: > - Pass a struct device rather than acpi_device to i2c_acpi_get_irq, >

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-21 Thread Maciej W. Rozycki
On Fri, 21 Jun 2019, Arnd Bergmann wrote: > > > The other property of packet memory and similar things is that you > > > basically want memcpy()-behavior with no byteswaps. This is one > > > of the few cases in which __raw_readq() is actually the right accessor > > > in (mostly) portable code. > >

Re: [PATCH -next v2] mm/page_alloc: fix a false memory corruption

2019-06-21 Thread Qian Cai
On Fri, 2019-06-21 at 12:39 +0200, Alexander Potapenko wrote: > On Fri, Jun 21, 2019 at 3:01 AM Kees Cook wrote: > > > > On Thu, Jun 20, 2019 at 04:46:06PM -0400, Qian Cai wrote: > > > The linux-next commit "mm: security: introduce init_on_alloc=1 and > > > init_on_free=1 boot options" [1] introd

Re: [PATCH] time/tick-broadcast: Fix tick_broadcast_offline() lockdep complaint

2019-06-21 Thread Peter Zijlstra
On Fri, Jun 21, 2019 at 05:16:30AM -0700, Paul E. McKenney wrote: > A pair of full hangs at boot (TASKS03 and TREE04), no console output > whatsoever. Not sure how these changes could cause that, but suspicion > falls on sched_tick_offload_init(). Though even that is a bit strange > because if so

[PATCH V2 2/4] iio: adc: ad7124: Add buffered input support

2019-06-21 Thread Mircea Caprioru
This patch adds the option to enable the buffered mode for positive and negative inputs. Each option can be enabled independently. In buffered mode, the input channel feeds into a high impedance input stage of the buffer amplifier. Therefore, the input can tolerate significant source impedances an

Re: [PATCH modules v2 0/2] Fix handling of exit unwinding sections (on ARM)

2019-06-21 Thread Matthias Schiffer
On Fri, 2019-06-07 at 12:49 +0200, Matthias Schiffer wrote: > For some time (050d18d1c651 "ARM: 8650/1: module: handle negative > R_ARM_PREL31 addends correctly", v4.11+), building a kernel without > CONFIG_MODULE_UNLOAD would lead to module loads failing on ARM > systems with > certain memory layo

Re: [PATCH 0/5] BT scheduling class

2019-06-21 Thread Peter Zijlstra
On Fri, Jun 21, 2019 at 03:45:52PM +0800, xiaoggc...@tencent.com wrote: > From: chen xiaoguang > > This patch set introduces a new scheduler, we name it BT scheduler > for the moment. > The BT scheduler is similar with the CFS scheduler. We also use the > rb-tree as the run queue to save the run

[PATCH V2 3/4] iio: adc: ad7124: Shift to dynamic allocation for channel configuration

2019-06-21 Thread Mircea Caprioru
This patch changes the channel configuration member of the device structure from a fixed size array to a dynamic allocated one with a size equal to the number of channels specified in the device tree. This will ensure a more flexibility for compatible devices. Ex. ad7124-4 - can have 4 differentia

[PATCH V2 1/4] iio: adc: ad7124: Remove input number limitation

2019-06-21 Thread Mircea Caprioru
The driver limits the user to use only 4/8 differential inputs, but this device has the option to use pseudo-differential channels. This will increase the number of channels to be equal with the number of inputs so 8 channels for ad7124-4 and 16 for ad7124-8. This patch removes the check between c

Re: [PATCH v4 3/5] mm, thp: introduce FOLL_SPLIT_PMD

2019-06-21 Thread Kirill A. Shutemov
On Thu, Jun 13, 2019 at 10:57:45AM -0700, Song Liu wrote: > @@ -419,6 +419,11 @@ static struct page *follow_pmd_mask(struct > vm_area_struct *vma, > put_page(page); > if (pmd_none(*pmd)) > return no_page_table(vma, flags); >

[PATCH V2 4/4] dt-bindings: iio: adc: Convert ad7124 documentation to YAML

2019-06-21 Thread Mircea Caprioru
Convert AD7124 bindings documentation to YAML format. Signed-off-by: Mircea Caprioru --- Changelog v2: - modified SPDX license to GPL-2.0 OR BSD-2-Clause - added regex for a range from 0 to 15 - added minimum and maximum constraints for reg property - set type and range of values for adi,referen

Re: [PATCH v4 5/5] uprobe: collapse THP pmd after removing all uprobes

2019-06-21 Thread Kirill A. Shutemov
On Thu, Jun 13, 2019 at 10:57:47AM -0700, Song Liu wrote: > After all uprobes are removed from the huge page (with PTE pgtable), it > is possible to collapse the pmd and benefit from THP again. This patch > does the collapse. > > An issue on earlier version was discovered by kbuild test robot. >

Re: [PATCH V6 3/3] arm64/mm: Enable memory hot remove

2019-06-21 Thread Anshuman Khandual
On 06/19/2019 09:47 AM, Anshuman Khandual wrote: > +#ifdef CONFIG_MEMORY_HOTPLUG > + /* > + * FIXME: We should have called remove_pagetable(start, end, true). > + * vmemmap and vmalloc virtual range might share intermediate kernel > + * page table entries. Removing vmemmap rang

Re: [PATCH -next] slub: play init_on_free=1 well with SLAB_RED_ZONE

2019-06-21 Thread Qian Cai
On Thu, 2019-06-20 at 18:19 -0700, Kees Cook wrote: > On Thu, Jun 20, 2019 at 06:14:33PM -0700, Kees Cook wrote: > > On Thu, Jun 20, 2019 at 03:28:01PM -0400, Qian Cai wrote: > > > diff --git a/mm/slub.c b/mm/slub.c > > > index a384228ff6d3..787971d4fa36 100644 > > > --- a/mm/slub.c > > > +++ b/mm/

[PATCH v1] mfd: intel-lpss: release ida resources

2019-06-21 Thread Andy Shevchenko
ida instances allocate some internal memory for ->free_bitmap in addition to the base 'struct ida'. Use ida_destroy() to release that memory at module_exit(). Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices") Signed-off-by: Andy Shevchenko --- drivers/mfd/intel-lpss.c

WARNING in is_bpf_text_address

2019-06-21 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:abf02e29 Merge tag 'pm-5.2-rc6' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15336041a0 kernel config: https://syzkaller.appspot.com/x/.config?x=28ec3437a5394ee0 da

memory leak in llc_ui_create (2)

2019-06-21 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:abf02e29 Merge tag 'pm-5.2-rc6' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14cc10b1a0 kernel config: https://syzkaller.appspot.com/x/.config?x=56f1da14935c3cce da

KASAN: use-after-free Write in validate_chain

2019-06-21 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:abf02e29 Merge tag 'pm-5.2-rc6' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=128b8be6a0 kernel config: https://syzkaller.appspot.com/x/.config?x=28ec3437a5394ee0 da

BUG: unable to handle kernel paging request in cpuacct_account_field

2019-06-21 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:abf02e29 Merge tag 'pm-5.2-rc6' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=164d94f6a0 kernel config: https://syzkaller.appspot.com/x/.config?x=e5c77f8090a3b96b da

[PATCH v1] mfd: intel-lpss: Add Intel Elkhart Lake PCH PCI IDs

2019-06-21 Thread Andy Shevchenko
Intel Elkhart Lake has the same LPSS than Intel Broxton. Add the new IDs to the list of supported devices. Signed-off-by: Andy Shevchenko --- drivers/mfd/intel-lpss-pci.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pc

Re: [PATCH 0/5] BT scheduling class

2019-06-21 Thread Peter Zijlstra
On Fri, Jun 21, 2019 at 03:45:52PM +0800, xiaoggc...@tencent.com wrote: > First only server application exists in the system and the success > rate is 99.998% and the average cpu use is only 25%. Have you guys looked at this series: https://lkml.kernel.org/r/cover.1556182964.git.viresh.ku...@l

Re: [PATCH v5 6/6] mm,thp: avoid writes to file with THP in pagecache

2019-06-21 Thread Kirill A. Shutemov
On Thu, Jun 20, 2019 at 01:53:48PM -0700, Song Liu wrote: > In previous patch, an application could put part of its text section in > THP via madvise(). These THPs will be protected from writes when the > application is still running (TXTBSY). However, after the application > exits, the file is ava

[PATCH 4/4] dm: add zone open, close and finish support

2019-06-21 Thread Matias Bjørling
From: Ajay Joshi Implement REQ_OP_ZONE_OPEN, REQ_OP_ZONE_CLOSE and REQ_OP_ZONE_FINISH support to allow explicit control of zone states. Signed-off-by: Ajay Joshi --- drivers/md/dm-flakey.c| 7 +++ drivers/md/dm-linear.c| 2 +- drivers/md/dm.c | 5 +++-- include/linux/blk_

Re: [PATCH 4/4] rts5208: Fix usleep range is preferred over udelay

2019-06-21 Thread Lukas Schneider
Am 21.06.2019 um 13:04 schrieb Pavel Machek: On Wed 2019-06-19 17:46:48, Lukas Schneider wrote: This patch fixes the issue reported by checkpatch: CHECK: usleep_range is preferred over udelay; see Doucmentation/timers/timers-howto.txt It's save to sleep here instead of using busy waiting, be

Re: [PATCH v5 6/6] mm,thp: avoid writes to file with THP in pagecache

2019-06-21 Thread Song Liu
> On Jun 21, 2019, at 6:07 AM, Kirill A. Shutemov wrote: > > On Thu, Jun 20, 2019 at 01:53:48PM -0700, Song Liu wrote: >> In previous patch, an application could put part of its text section in >> THP via madvise(). These THPs will be protected from writes when the >> application is still runn

Re: [PATCH 02/25] vfs: Allow fsinfo() to query what's in an fs_context [ver #13]

2019-06-21 Thread David Howells
Christian Brauner wrote: > > static int vfs_fsinfo_fd(unsigned int fd, struct fsinfo_kparams *params) > > { > > struct fd f = fdget_raw(fd); > > You're using fdget_raw() which means you want to allow O_PATH fds but > below you're checking whether the f_ops correspond to > fscontext_fops. I

Re: [PATCH 02/25] vfs: Allow fsinfo() to query what's in an fs_context [ver #13]

2019-06-21 Thread Christian Brauner
On June 21, 2019 3:12:43 PM GMT+02:00, David Howells wrote: >Christian Brauner wrote: > >> > static int vfs_fsinfo_fd(unsigned int fd, struct fsinfo_kparams >*params) >> > { >> >struct fd f = fdget_raw(fd); >> >> You're using fdget_raw() which means you want to allow O_PATH fds but >> bel

Re: [PATCH 01/16] mm: use untagged_addr() for get_user_pages_fast addresses

2019-06-21 Thread Jason Gunthorpe
On Tue, Jun 11, 2019 at 04:40:47PM +0200, Christoph Hellwig wrote: > This will allow sparc64 to override its ADI tags for > get_user_pages and get_user_pages_fast. > > Signed-off-by: Christoph Hellwig > --- > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jaso

Re: [PATCH v3 0/5] net: macb: cover letter

2019-06-21 Thread Andrew Lunn
On Fri, Jun 21, 2019 at 09:33:57AM +0100, Parshuram Thombare wrote: > Hello ! > > 2. 0002-net-macb-add-support-for-sgmii-MAC-PHY-interface.patch >This patch add support for SGMII mode. Hi Parshuram What PHYs are using to test this? You mention TI PHY DP83867, but that seems to be a plain old

Re: [patch 0/5] *** DMA based UART driver for AST2500 ***

2019-06-21 Thread Greg KH
On Fri, Jun 21, 2019 at 04:47:30PM +0530, sudheer.v wrote: > From: sudheer veliseti > > Hi, > AST2500 has dedicated Uart DMA controller which has 12 sets of > Tx and RX channels connected to UART controller directly. > Since the DMA controller have dedicated buffers and registers, > there would b

Re: [PATCH v3 3/5] net: macb: add support for c45 PHY

2019-06-21 Thread Andrew Lunn
On Fri, Jun 21, 2019 at 09:34:59AM +0100, Parshuram Thombare wrote: > This patch modify MDIO read/write functions to support > communication with C45 PHY. > > Signed-off-by: Parshuram Thombare Reviewed-by: Andrew Lunn Andrew

Re: [PATCH -next v2] mm/hotplug: fix a null-ptr-deref during NUMA boot

2019-06-21 Thread Qian Cai
Sigh... I don't see any benefit to keep the broken commit, "x86, numa: always initialize all possible nodes" for so long in linux-next that just prevent x86 NUMA machines with any memory- less node from booting. Andrew, maybe it is time to drop this patch until Michal found some time to fix it

Re: [PATCH v4 5/5] uprobe: collapse THP pmd after removing all uprobes

2019-06-21 Thread Song Liu
> On Jun 21, 2019, at 5:48 AM, Kirill A. Shutemov wrote: > > On Thu, Jun 13, 2019 at 10:57:47AM -0700, Song Liu wrote: >> After all uprobes are removed from the huge page (with PTE pgtable), it >> is possible to collapse the pmd and benefit from THP again. This patch >> does the collapse. >>

Re: [RFC 0/5] livepatch: new API to track system state changes

2019-06-21 Thread Joe Lawrence
On Tue, Jun 11, 2019 at 03:56:22PM +0200, Petr Mladek wrote: > Hi, > > this is another piece in the puzzle that helps to maintain more > livepatches. > > Especially pre/post (un)patch callbacks might change a system state. > Any newly installed livepatch has to somehow deal with system state > mo

Re: [PATCH] [media] media: mtk-mdp: fix reference count on old device tree

2019-06-21 Thread Greg KH
On Fri, Jun 21, 2019 at 01:32:50PM +0200, Matthias Brugger wrote: > of_get_next_child() increments the reference count of the returning > device_node. Decrement it in the check if we are using the old or the > new DTB. > > Fixes: ba1f1f70c2c0 ("[media] media: mtk-mdp: Fix mdp device tree") > Signe

[PATCH 2/6] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-21 Thread Daniel Lezcano
Currently the function cpufreq_cooling_register() returns a cooling device pointer which is used back as a pointer to call the function cpufreq_cooling_unregister(). Even if it is correct, it would make sense to not leak the structure inside a cpufreq driver and keep the code thermal code self-enca

[PATCH 1/6] cpufreq: Use existing stub functions instead of IS_ENABLED macro

2019-06-21 Thread Daniel Lezcano
The functions stub already exist for the condition the IS_ENABLED is trying to avoid. Remove the IS_ENABLED macros as they are pointless. Signed-off-by: Daniel Lezcano --- drivers/cpufreq/cpufreq.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/cpufreq

[PATCH 6/6] thermal/drivers/ti: Remove cooling device usage

2019-06-21 Thread Daniel Lezcano
The cpufreq_cooling_unregister() function uses now the policy to unregister itself. The only purpose of the cooling device pointer is to unregister the cpu cooling device. As there is no more need of this pointer, remove it. Signed-off-by: Daniel Lezcano --- drivers/thermal/ti-soc-thermal/ti-th

[PATCH 5/6] thermal/drivers/imx: Remove cooling device usage

2019-06-21 Thread Daniel Lezcano
The cpufreq_cooling_unregister() function uses now the policy to unregister itself. The only purpose of the cooling device pointer is to unregister the cpu cooling device. As there is no more need of this pointer, remove it. Signed-off-by: Daniel Lezcano --- drivers/thermal/imx_thermal.c | 8 ++

[PATCH 4/6] cpufreq: Remove cooling device usage

2019-06-21 Thread Daniel Lezcano
The cpufreq_cooling_unregister() function uses now the policy to unregister itself. The only purpose of the cooling device pointer is to unregister the cpu cooling device. As there is no more need of this pointer, remove it. Signed-off-by: Daniel Lezcano --- drivers/cpufreq/cpufreq.c | 6 ++

RE: [LINUX PATCH v16] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2019-06-21 Thread Naga Sureshkumar Relli
Hi Helmut, > -Original Message- > From: Helmut Grohne > Sent: Friday, June 21, 2019 2:12 PM > To: Naga Sureshkumar Relli > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com; vigne...@ti.com; linux- > m...@lists.infrad

[PATCH 3/6] cpufreq/drivers/arm_big_little: Remove cooling device usage

2019-06-21 Thread Daniel Lezcano
The cpufreq_cooling_unregister() function uses now the policy to unregister itself. The only purpose of the cooling device pointer is to unregister the cpu cooling device. As there is no more need of this pointer, remove it. Signed-off-by: Daniel Lezcano --- drivers/cpufreq/arm_big_little.c | 7

Re: [PATCH 0/5] BT scheduling class

2019-06-21 Thread Valentin Schneider
On 21/06/2019 14:03, Peter Zijlstra wrote: > On Fri, Jun 21, 2019 at 03:45:52PM +0800, xiaoggc...@tencent.com wrote: > >> First only server application exists in the system and the success >> rate is 99.998% and the average cpu use is only 25%. > > Have you guys looked at this series: > > http

Re: [PATCH 02/25] vfs: Allow fsinfo() to query what's in an fs_context [ver #13]

2019-06-21 Thread Christian Brauner
On Fri, Jun 21, 2019 at 03:16:04PM +0200, Christian Brauner wrote: > On June 21, 2019 3:12:43 PM GMT+02:00, David Howells > wrote: > >Christian Brauner wrote: > > > >> > static int vfs_fsinfo_fd(unsigned int fd, struct fsinfo_kparams > >*params) > >> > { > >> > struct fd f = fdget_raw

Re: [PATCH 2/3] Emulate simple x86 instructions in userspace

2019-06-21 Thread Alexander Graf
On 12.06.19 17:19, samc...@amazon.com wrote: On 5/31/19 10:38 AM, Alexander Graf wrote: On 21.05.19 17:39, Sam Caccavale wrote: +static void dump_state_after(const char *desc, struct state *state) +{ +    debug(" -- State after %s --\n", desc); +    debug("mode: %s\n", x86emul_mode_string[st

Re: [PATCH v3 1/5] net: macb: add phylink support

2019-06-21 Thread Russell King - ARM Linux admin
On Fri, Jun 21, 2019 at 09:34:44AM +0100, Parshuram Thombare wrote: > @@ -438,115 +439,145 @@ static void macb_set_tx_clk(struct clk *clk, int > speed, struct net_device *dev) > netdev_err(dev, "adjusting tx_clk failed.\n"); > } > > -static void macb_handle_link_change(struct net_

Re: linux-next: unexpected file in the usb tree

2019-06-21 Thread Greg KH
On Fri, Jun 21, 2019 at 09:24:23PM +1000, Stephen Rothwell wrote: > Hi Greg, > > Commit > > ecefae6db042 ("docs: usb: rename files to .rst and add them to drivers-api") > > added this unexpected file: > > Documentation/index.rst.rej Ugh, that's what I get for having to manually apply a pat

Re: [v2, 0/4] x86 instruction emulator fuzzing

2019-06-21 Thread Alexander Graf
On 12.06.19 17:35, Sam Caccavale wrote: Dear all, This series aims to provide an entrypoint for, and fuzz KVM's x86 instruction emulator from userspace. It mirrors Xen's application of the AFL fuzzer to it's instruction emulator in the hopes of discovering vulnerabilities. Since this entrypoi

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-21 Thread Ard Biesheuvel
On Fri, 21 Jun 2019 at 11:44, Arnd Bergmann wrote: > > On Thu, Jun 20, 2019 at 7:36 PM Kees Cook wrote: > > > > On Tue, Jun 18, 2019 at 11:47:13AM +0200, Arnd Bergmann wrote: > > > The combination of KASAN_STACK and GCC_PLUGIN_STRUCTLEAK_BYREF_ALL > > > leads to much larger kernel stack usage, as

Re: [v2, 1/4] Build target for emulate.o as a userspace binary

2019-06-21 Thread Alexander Graf
On 12.06.19 17:35, Sam Caccavale wrote: This commit contains the minimal set of functionality to build afl-harness around arch/x86/emulate.c which allows exercising code in that source file, like x86_emulate_insn. Resolving the dependencies was done via GCC's -H flag by get_headers.py. CR: ht

Re: [PATCH] time/tick-broadcast: Fix tick_broadcast_offline() lockdep complaint

2019-06-21 Thread Paul E. McKenney
On Fri, Jun 21, 2019 at 02:29:27PM +0200, Peter Zijlstra wrote: > On Fri, Jun 21, 2019 at 05:16:30AM -0700, Paul E. McKenney wrote: > > A pair of full hangs at boot (TASKS03 and TREE04), no console output > > whatsoever. Not sure how these changes could cause that, but suspicion > > falls on sched

Re: [PATCH v4 5/5] uprobe: collapse THP pmd after removing all uprobes

2019-06-21 Thread Kirill A. Shutemov
On Fri, Jun 21, 2019 at 01:17:05PM +, Song Liu wrote: > > > > On Jun 21, 2019, at 5:48 AM, Kirill A. Shutemov > > wrote: > > > > On Thu, Jun 13, 2019 at 10:57:47AM -0700, Song Liu wrote: > >> After all uprobes are removed from the huge page (with PTE pgtable), it > >> is possible to collap

Re: [PATCH] s390/cio: introduce driver_override on the css bus

2019-06-21 Thread Halil Pasic
On Fri, 21 Jun 2019 11:56:04 +0200 Cornelia Huck wrote: > On Thu, 13 Jun 2019 13:08:15 +0200 > Cornelia Huck wrote: > > > Sometimes, we want to control which of the matching drivers > > binds to a subchannel device (e.g. for subchannels we want to > > handle via vfio-ccw). > > > > For pci devi

[PATCH v14 2/7] virtio-pmem: Add virtio pmem driver

2019-06-21 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this into sy

Re: [PATCH 3/6] usb: bdc: driver may fail to get USB PHY

2019-06-21 Thread Alan Cooper
It's been very useful to have the DEFER debug message so I'd like to leave in the check for DEFER. I should not be skipping the clock disable, so I'll "goto clk_cleanup" for both cases. Thanks Al On Fri, Jun 21, 2019 at 1:39 AM Chunfeng Yun wrote: > > On Thu, 2019-06-20 at 17:09 -0400, Al Cooper

[PATCH v14 3/7] libnvdimm: add dax_dev sync flag

2019-06-21 Thread Pankaj Gupta
This patch adds 'DAXDEV_SYNC' flag which is set for nd_region doing synchronous flush. This later is used to disable MAP_SYNC functionality for ext4 & xfs filesystem for devices don't support synchronous flush. Signed-off-by: Pankaj Gupta --- drivers/dax/bus.c| 2 +- drivers/dax/sup

Re: [PATCH 01/16] mm: use untagged_addr() for get_user_pages_fast addresses

2019-06-21 Thread Jason Gunthorpe
On Tue, Jun 11, 2019 at 04:40:47PM +0200, Christoph Hellwig wrote: > This will allow sparc64 to override its ADI tags for > get_user_pages and get_user_pages_fast. > > Signed-off-by: Christoph Hellwig > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup

[PATCH v14 5/7] dax: check synchronous mapping is supported

2019-06-21 Thread Pankaj Gupta
This patch introduces 'daxdev_mapping_supported' helper which checks if 'MAP_SYNC' is supported with filesystem mapping. It also checks if corresponding dax_device is synchronous. Virtio pmem device is asynchronous and does not not support VM_SYNC. Suggested-by: Jan Kara Signed-off-by: Pankaj Gup

Re:Re: [PATCH] kexec: fix warnig of crash_zero_bytes in crash.c

2019-06-21 Thread Tiezhu Yang
At 2019-06-21 00:39:00, "Borislav Petkov" wrote: >On Sat, Jun 15, 2019 at 07:18:20AM +0800, Tiezhu Yang wrote: >> This patch fixes the following sparse warning: > >Avoid having "This patch" or "This commit" in the commit message. It is >tautologically useless. > >Also, do > >$ git grep 'This patch

Re: [PATCH v5 6/6] mm,thp: avoid writes to file with THP in pagecache

2019-06-21 Thread Kirill A. Shutemov
On Fri, Jun 21, 2019 at 01:10:54PM +, Song Liu wrote: > > > > On Jun 21, 2019, at 6:07 AM, Kirill A. Shutemov > > wrote: > > > > On Thu, Jun 20, 2019 at 01:53:48PM -0700, Song Liu wrote: > >> In previous patch, an application could put part of its text section in > >> THP via madvise(). Th

Re: [PATCH 02/16] mm: simplify gup_fast_permitted

2019-06-21 Thread Jason Gunthorpe
On Tue, Jun 11, 2019 at 04:40:48PM +0200, Christoph Hellwig wrote: > Pass in the already calculated end value instead of recomputing it, and > leave the end > start check in the callers instead of duplicating them > in the arch code. > > Signed-off-by: Christoph Hellwig > --- > arch/s390/include

Re: [v2, 2/4] Emulate simple x86 instructions in userspace

2019-06-21 Thread Alexander Graf
On 12.06.19 17:35, Sam Caccavale wrote: Added the minimal subset of code to run afl-harness with a binary file as input. These bytes are used to populate the vcpu structure and then as an instruction stream for the emulator. It does not attempt to handle exceptions an only supports very simpl

Re: [RFC 2/5] livepatch: Basic API to track system state changes

2019-06-21 Thread Joe Lawrence
On Tue, Jun 11, 2019 at 03:56:24PM +0200, Petr Mladek wrote: > This is another step how to help maintaining more livepatches. > > One big help was the atomic replace and cumulative livepatches. These > livepatches replaces the already installed ones. Therefore it should nit: s/replaces/replaces

Re: [PATCH 2/6] usb: bdc: Cleanup clock support

2019-06-21 Thread Alan Cooper
> > diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c > > b/drivers/usb/gadget/udc/bdc/bdc_core.c > > index ccbd1d34eb2a..11a43de6c1c6 100644 > > --- a/drivers/usb/gadget/udc/bdc/bdc_core.c > > +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c > > @@ -490,8 +490,14 @@ static int bdc_probe(struct platfo

Re: [PATCH 1/5] lib: logic_pio: Fix RCU usage

2019-06-21 Thread Bjorn Helgaas
On Thu, Jun 20, 2019 at 06:31:52PM +0800, John Garry wrote: > The traversing of io_range_list with list_for_each_entry_rcu() > is not properly protected by rcu_read_lock(), so add it. > > In addition, the list traversing used in logic_pio_register_range() > does not need to use the rcu variant. N

Re: [PATCH v5 6/6] mm,thp: avoid writes to file with THP in pagecache

2019-06-21 Thread Song Liu
> On Jun 21, 2019, at 6:39 AM, Kirill A. Shutemov wrote: > > On Fri, Jun 21, 2019 at 01:10:54PM +, Song Liu wrote: >> >> >>> On Jun 21, 2019, at 6:07 AM, Kirill A. Shutemov >>> wrote: >>> >>> On Thu, Jun 20, 2019 at 01:53:48PM -0700, Song Liu wrote: In previous patch, an applicat

Re: [v2, 3/4] Demonstrating unit testing via simple-harness

2019-06-21 Thread Alexander Graf
On 12.06.19 17:35, Sam Caccavale wrote: Simple-harness.c uses inline asm support to generate asm and then has the emulator emulate this code. This may be useful as a form of testing for the emulator. CR: https://code.amazon.com/reviews/CR-8591638 --- tools/fuzz/x86ie/Makefile | 7

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-21 Thread Arnd Bergmann
On Fri, Jun 21, 2019 at 3:32 PM Ard Biesheuvel wrote: > On Fri, 21 Jun 2019 at 11:44, Arnd Bergmann wrote: > > On Thu, Jun 20, 2019 at 7:36 PM Kees Cook wrote: > > > On Tue, Jun 18, 2019 at 11:47:13AM +0200, Arnd Bergmann wrote: > > > > The combination of KASAN_STACK and GCC_PLUGIN_STRUCTLEAK_BY

[PATCH] net/sched: cbs: Fix error path of cbs_module_init

2019-06-21 Thread YueHaibing
If register_qdisc fails, we should unregister netdevice notifier. Reported-by: Hulk Robot Fixes: e0a7683d30e9 ("net/sched: cbs: fix port_rate miscalculation") Signed-off-by: YueHaibing --- net/sched/sch_cbs.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net/sched

Re: [PATCH 03/16] mm: lift the x86_32 PAE version of gup_get_pte to common code

2019-06-21 Thread Jason Gunthorpe
On Tue, Jun 11, 2019 at 04:40:49PM +0200, Christoph Hellwig wrote: > The split low/high access is the only non-READ_ONCE version of > gup_get_pte that did show up in the various arch implemenations. > Lift it to common code and drop the ifdef based arch override. > > Signed-off-by: Christoph Hellw

Re: [PATCH v4 5/5] uprobe: collapse THP pmd after removing all uprobes

2019-06-21 Thread Song Liu
> On Jun 21, 2019, at 6:36 AM, Kirill A. Shutemov wrote: > > On Fri, Jun 21, 2019 at 01:17:05PM +, Song Liu wrote: >> >> >>> On Jun 21, 2019, at 5:48 AM, Kirill A. Shutemov >>> wrote: >>> >>> On Thu, Jun 13, 2019 at 10:57:47AM -0700, Song Liu wrote: After all uprobes are removed

Re: [PATCH 6/6] usb: bdc: Update compatible match strings

2019-06-21 Thread Alan Cooper
> > Remove "brcm,bdc-v0.16" because it was never used on any system. > > You're not really removing it, are you? Whoops, it was supposed to be removed. Thanks Al On Fri, Jun 21, 2019 at 4:28 AM Sergei Shtylyov wrote: > > Hello! > > On 21.06.2019 0:09, Al Cooper wrote: > > > Remove "brcm,bdc-

Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-21 Thread Greg Kroah-Hartman
On Thu, Jun 20, 2019 at 11:13:32AM -0700, Kees Cook wrote: > On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > > From: Colin Ian King > > > > The variable ret is being initialized with the value -EINVAL however > > this value is never read and ret is being re-assigned later on. Hence

Re: [PATCH] structleak: disable BYREF_ALL in combination with KASAN_STACK

2019-06-21 Thread Ard Biesheuvel
On Fri, 21 Jun 2019 at 15:44, Arnd Bergmann wrote: > > On Fri, Jun 21, 2019 at 3:32 PM Ard Biesheuvel > wrote: > > On Fri, 21 Jun 2019 at 11:44, Arnd Bergmann wrote: > > > On Thu, Jun 20, 2019 at 7:36 PM Kees Cook wrote: > > > > On Tue, Jun 18, 2019 at 11:47:13AM +0200, Arnd Bergmann wrote: > >

Re: [PATCH 2/5] lib: logic_pio: Add logic_pio_unregister_range()

2019-06-21 Thread Bjorn Helgaas
On Thu, Jun 20, 2019 at 06:31:53PM +0800, John Garry wrote: > Add a function to unregister a logical PIO range. > > The method used to allocate LOGIC_PIO_CPU_MMIO regions during registration > is slightly modified to ensure that we get no overlap when regions are > unregistered. This is needed bec

Re: [v2, 4/4] Added scripts for filtering, building, deploying

2019-06-21 Thread Alexander Graf
On 12.06.19 17:36, Sam Caccavale wrote: bin.sh produces output which diagnoses whether the crash was expected. coalesce.sh, gen_output.sh, and summarize.sh are useful for parsing the large crash directories that afl produces. deploy_remote.sh does all of the setup to launch a fuzz run via inst

[PATCH -next] platform/chrome: wilco_ec: Use kmemdup in enqueue_events()

2019-06-21 Thread YueHaibing
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/platform/chrome/wilco_ec/event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c index c975b76e6

Re: [PATCH -next v2] mm/hotplug: fix a null-ptr-deref during NUMA boot

2019-06-21 Thread Michal Hocko
On Fri 21-06-19 09:17:58, Qian Cai wrote: > Sigh... > > I don't see any benefit to keep the broken commit, > > "x86, numa: always initialize all possible nodes" > > for so long in linux-next that just prevent x86 NUMA machines with any memory- > less node from booting. > > Andrew, maybe it is t

Re: [PATCH 4/5] bus: hisi_lpc: Add .remove method to avoid driver unbind crash

2019-06-21 Thread Bjorn Helgaas
[+cc Rafael, linux-acpi] On Thu, Jun 20, 2019 at 06:31:55PM +0800, John Garry wrote: > The original driver author seemed to be under the impression that a driver > cannot be removed if it does not have a .remove method. Or maybe if it is > a built-in platform driver. > > This is not true. This cr

Re: [PATCH v10 11/16] sched/fair: uclamp: Add uclamp support to energy_compute()

2019-06-21 Thread Peter Zijlstra
On Fri, Jun 21, 2019 at 09:42:12AM +0100, Patrick Bellasi wrote: > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index ce2da8b9ff8c..f81e8930ff19 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -2322,7 +2322,6 @@ static inline unsigned long capacity_orig_of(int c

Re: [PATCH] mips: Remove q-accessors from non-64bit platforms

2019-06-21 Thread Arnd Bergmann
On Fri, Jun 21, 2019 at 2:24 PM Maciej W. Rozycki wrote: > On Fri, 21 Jun 2019, Arnd Bergmann wrote: > > > > The other property of packet memory and similar things is that you > > > > basically want memcpy()-behavior with no byteswaps. This is one > > > > of the few cases in which __raw_readq() is

Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-21 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with the value -EINVAL however > this value is never read and ret is being re-assigned later on. Hence > the initialization is redundant and can be removed. > > Addresses-

Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates

2019-06-21 Thread Bjorn Helgaas
[+cc Stephen] On Fri, Jun 21, 2019 at 03:16:04PM +0530, Puranjay Mohan wrote: > This patch series removes the private duplicates of PCI definitions in > favour of generic definitions defined in pci_regs.h. > > This driver only uses some of the generic PCI definitons, > which are included from pci

Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-21 Thread Greg Kroah-Hartman
On Fri, Jun 21, 2019 at 04:03:47PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > > From: Colin Ian King > > > > The variable ret is being initialized with the value -EINVAL however > > this value is never read and ret is being re-assigned later o

Re: [PATCH 04/16] MIPS: use the generic get_user_pages_fast code

2019-06-21 Thread Jason Gunthorpe
On Tue, Jun 11, 2019 at 04:40:50PM +0200, Christoph Hellwig wrote: > diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h > index 4ccb465ef3f2..7d27194e3b45 100644 > +++ b/arch/mips/include/asm/pgtable.h > @@ -20,6 +20,7 @@ > #include > #include > #include > +#includ

Re: [PATCH] s390/cio: introduce driver_override on the css bus

2019-06-21 Thread Cornelia Huck
On Fri, 21 Jun 2019 15:37:11 +0200 Halil Pasic wrote: > On Fri, 21 Jun 2019 11:56:04 +0200 > Cornelia Huck wrote: > > > On Thu, 13 Jun 2019 13:08:15 +0200 > > Cornelia Huck wrote: > > > > > Sometimes, we want to control which of the matching drivers > > > binds to a subchannel device (e.g.

Re: [RFC PATCH v2 1/2] printk-rb: add a new printk ringbuffer implementation

2019-06-21 Thread Petr Mladek
Hi John, I am still scratching head around this. Anyway, I wanted to write something. I am sorry that the answer is really long. I do not know how to write it more effectively. First, the documentation helped a lot. Also I found several ideas that were important to make it working a lockless way.

Re: [PATCH] mm: fix setting the high and low watermarks

2019-06-21 Thread Bharath Vedartham
On Fri, Jun 21, 2019 at 02:09:31PM +0200, Vlastimil Babka wrote: > On 6/21/19 1:43 PM, Alan Jenkins wrote: > > When setting the low and high watermarks we use min_wmark_pages(zone). > > I guess this is to reduce the line length. But we forgot that this macro > > includes zone->watermark_boost. We

Re: [RE-RESEND PATCH v3 1/4] dt-bindings: memory: jz4780: Add compatible string for JZ4740 SoC

2019-06-21 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2019 at 04:30:15PM +0200, Paul Cercueil wrote: > Add a compatible string to support the memory controller built into the > JZ4740 SoC from Ingenic. > > Signed-off-by: Paul Cercueil > Reviewed-by: Boris Brezillon > Reviewed-by: Rob Herring > --- > > Notes: > v2: No change >

Re: [RFC 3/5] livepatch: Allow to distinguish different version of system state changes

2019-06-21 Thread Joe Lawrence
On Tue, Jun 11, 2019 at 03:56:25PM +0200, Petr Mladek wrote: > The atomic replace runs pre/post (un)install callbacks only from the new > livepatch. There are several reasons for this: > > + Simplicity: clear ordering of operations, no interactions between > old and new callbacks. > > +

[PATCH] RDMA/core: Fix race when resolving IP address

2019-06-21 Thread Dag Moxnes
Use neighbour lock when copying MAC address from neighbour data struct in dst_fetch_ha. When not using the lock, it is possible for the function to race with neigh_update, causing it to copy an invalid MAC address. It is possible to provoke this error by calling rdma_resolve_addr in a tight loop,

Re: [PATCH v4 3/5] mm, thp: introduce FOLL_SPLIT_PMD

2019-06-21 Thread Song Liu
> On Jun 21, 2019, at 5:44 AM, Kirill A. Shutemov wrote: > > On Thu, Jun 13, 2019 at 10:57:45AM -0700, Song Liu wrote: >> @@ -419,6 +419,11 @@ static struct page *follow_pmd_mask(struct >> vm_area_struct *vma, >> put_page(page); >> if (pmd_none(*pmd))

RE: input: Device Tree Properties for Captouch Button Device Registers

2019-06-21 Thread Ken Sloat
> -Original Message- > From: Ken Sloat > Sent: Wednesday, June 19, 2019 8:55 AM > To: dmitry.torok...@gmail.com > Cc: Kasun Beddewela ; linux- > in...@vger.kernel.org; linux-kernel@vger.kernel.org; Ken Sloat > > Subject: input: Device Tree Properties for Captouch Button Device Registers >

Re: WARN_ON: userstacktrace on irq events

2019-06-21 Thread Masami Hiramatsu
On Fri, 5 Apr 2019 09:32:09 -0400 Steven Rostedt wrote: > On Fri, 5 Apr 2019 10:12:27 +0200 (CEST) > Thomas Gleixner wrote: > > > > BOOM! Warn on. > > > > > > Can we make that access_ok() call in the copy_stack_frame not trigger > > > the warning just if we are in an interrupt? > > > > You

Re: [PATCH 1/5] lib: logic_pio: Fix RCU usage

2019-06-21 Thread John Garry
On 21/06/2019 14:43, Bjorn Helgaas wrote: On Thu, Jun 20, 2019 at 06:31:52PM +0800, John Garry wrote: Hi Bjorn, The traversing of io_range_list with list_for_each_entry_rcu() is not properly protected by rcu_read_lock(), so add it. Functions rcu_read_lock() and rcu_read_unlock() mark the c

Re: [PATCH V7 04/11] misc: xilinx_sdfec: Store driver config and state

2019-06-21 Thread Greg KH
On Tue, Jun 11, 2019 at 06:29:38PM +0100, Dragan Cvetic wrote: > Stores configuration based on parameters from the DT > node and values from the SD-FEC core plus reads > the default state from the SD-FEC core. To obtain > values from the core register read, write capabilities > have been added plus

Re: [RFC 4/5] livepatch: Documentation of the new API for tracking system state changes

2019-06-21 Thread Joe Lawrence
On Tue, Jun 11, 2019 at 03:56:26PM +0200, Petr Mladek wrote: > Documentation explaining the motivation, capabilities, and usage > of the new API for tracking system state changes. > > Signed-off-by: Petr Mladek > --- > Documentation/livepatch/index.rst| 1 + > Documentation/livepatch/sy

<    1   2   3   4   5   6   7   8   9   >