Re: [PATCH] sh: dma: Add missing IS_ERR test

2019-06-08 Thread Geert Uytterhoeven
Hi Rolf, Thanks for your patch! On Fri, Jun 7, 2019 at 2:04 PM Rolf Evers-Fischer wrote: > get_dma_channel may return ERR_PTR, so a check is added. It may also return NULL... > --- a/arch/sh/drivers/dma/dma-api.c > +++ b/arch/sh/drivers/dma/dma-api.c > @@ -94,7 +94,7 @@ int get_dma_residue(uns

[PATCH net] mpls: fix af_mpls dependencies

2019-06-08 Thread Matteo Croce
MPLS routing code relies on sysctl to work, so let it select PROC_SYSCTL. Reported-by: Randy Dunlap Suggested-by: David Ahern Signed-off-by: Matteo Croce --- net/mpls/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig index d9391beea980..2b802a48d5a

Re: [PATCH] iio:core: Fix bug in length of event info_mask and catch unhandled bits set in masks.

2019-06-08 Thread Jonathan Cameron
On Thu, 6 Jun 2019 08:59:10 + "Ardelean, Alexandru" wrote: > On Tue, 2019-06-04 at 20:40 +0800, Young Xiao wrote: > > [External] > > > > > > The incorrect limit for the for_each_set_bit loop was noticed whilst fixing > > this other case. Note that as we only have 3 possible entries a the m

Re: [PATCH] iio: light: stk3310: Add support for stk3335

2019-06-08 Thread Jonathan Cameron
On Mon, 3 Jun 2019 21:20:39 +0200 Luca Weiss wrote: > From: Martijn Braam > > The stk3335 light/proximity sensor is similar to the stk3310 and stk3311 > sensors and works with the stk3310 driver. > > Signed-off-by: Martijn Braam > Signed-off-by: Luca Weiss Applied to the togreg branch of ii

Re: [PATCH 34/34] usb: typec: tcpm: fusb302: simplify getting the adapter of a client

2019-06-08 Thread Guenter Roeck
On 6/8/19 3:56 AM, Wolfram Sang wrote: We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang Reviewed-by: Guenter Roeck --- Please apply to your subsystem tree. drivers/usb/typec/tcpm/fusb302.c | 3 +-- 1 file c

Re: [PATCH V4 RESEND 1/3] dt-bindings: watchdog: move i.MX system controller watchdog binding to SCU

2019-06-08 Thread Guenter Roeck
On Mon, May 27, 2019 at 03:03:15PM +0800, anson.hu...@nxp.com wrote: > From: Anson Huang > > i.MX system controller watchdog depends on SCU driver to support > interrupt function, so it needs to be subnode of SCU node in DT, > binding doc should be moved to fsl,scu.txt as well. > > Signed-off-by

Re: [PATCH 1/3] Documentation: dt-bindings: add the Amlogic Meson Temperature Sensor

2019-06-08 Thread Jonathan Cameron
On Tue, 4 Jun 2019 16:47:12 +0200 Guillaume La Roque wrote: > This adds the devicetree binding documentation for the Temperature > Sensor found in the Amlogic Meson G12 SoCs. > Currently only the G12A SoCs are supported. > > Signed-off-by: Guillaume La Roque Hi Guillaume, I'm afraid we decid

Re: [PATCH 1/3] Documentation: dt-bindings: add the Amlogic Meson Temperature Sensor

2019-06-08 Thread Jonathan Cameron
On Thu, 6 Jun 2019 21:16:37 +0200 Martin Blumenstingl wrote: > Hi Guillaume, > > thank you for working on this! On comment from me inline. Thanks, Jonathan > > On Tue, Jun 4, 2019 at 4:47 PM Guillaume La Roque > wrote: > > > > This adds the devicetree binding documentation for the Temperat

Re: [PATCH RESEND V4 3/3] watchdog: imx_sc: Add pretimeout support

2019-06-08 Thread Guenter Roeck
On 6/8/19 2:32 AM, Anson Huang wrote: Hi, Guenter -Original Message- From: Guenter Roeck On Behalf Of Guenter Roeck Sent: Saturday, June 8, 2019 1:41 AM To: Anson Huang Cc: robh...@kernel.org; mark.rutl...@arm.com; w...@linux-watchdog.org; shawn...@kernel.org; s.ha...@pengutronix.de;

Re: [PATCH 3/3] iio: temperature: add a driver for the temperature sensor found in Amlogic Meson G12 SoCs

2019-06-08 Thread Jonathan Cameron
On Tue, 4 Jun 2019 16:47:14 +0200 Guillaume La Roque wrote: > The code is based on Amlogic source code. No public datasheet for this. > Currently the G12A SoCs are supported. > > Supported features: > - possibility to set an automatic reboot temperature > > Signed-off-by: Guillaume La Roque A

Re: [PATCH] counter: ftm-quaddec: needs HAS_IOMEM

2019-06-08 Thread Jonathan Cameron
On Sat, 1 Jun 2019 23:38:05 +0200 Thomas Meyer wrote: > the driver fails for UML with: > drivers/counter/ftm-quaddec.c:301: undefined reference to `devm_ioremap' > > Fix it by depending on HAS_IOMEM Missing Signed-off-by. Unfortunately I came across another patch for this before yours so alrea

Re: [PATCH] xhci: clear port_remote_wakeup after resume failure

2019-06-08 Thread Nicolas Saenz Julienne
On Tue, 2019-06-04 at 16:53 +0300, Mathias Nyman wrote: > On 27.5.2019 14.28, Nicolas Saenz Julienne wrote: > > Hi Matthias, > > thanks for the review. > > > > On Mon, 2019-05-27 at 14:16 +0300, Mathias Nyman wrote: > > > On 24.5.2019 17.52, Nicolas Saenz Julienne wrote: > > > > This was seen on a

Re: [Patch v2] USB: sisusbvga: Remove unneeded variable

2019-06-08 Thread Greg Kroah-Hartman
On Fri, Jun 07, 2019 at 07:26:58AM +0530, Hariprasad Kelam wrote: > fix below warning reported by coccicheck > > drivers/usb/misc/sisusbvga/sisusb.c:1753:5-8: Unneeded variable: "ret". > Return "0" on line 1877 > > Signed-off-by: Hariprasad Kelam > - > changes in v2: Change return type of si

Re: [PATCH] MIPS: lb60: Fix pin mappings

2019-06-08 Thread Linus Walleij
On Sat, Jun 8, 2019 at 12:14 PM Paul Cercueil wrote: > Le sam. 8 juin 2019 à 0:10, Linus Walleij a > écrit : > > On Tue, Jun 4, 2019 at 6:34 PM Paul Cercueil > > wrote: > > > >> The pin mappings introduced in commit 636f8ba67fb6 > >> ("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for sever

Re: [PATCH v7 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-06-08 Thread Greg KH
On Wed, Jun 05, 2019 at 11:03:46AM +0100, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_addres

Re: [PATCH v6 1/2] iio: frequency: adf4371: Add support for ADF4371 PLL

2019-06-08 Thread Jonathan Cameron
On Tue, 4 Jun 2019 17:58:02 +0300 Stefan Popa wrote: > The ADF4371 is a frequency synthesizer with an integrated voltage > controlled oscillator (VCO) for phase-locked loops (PLLs). The ADF4371 > has an integrated VCO with a fundamental output frequency ranging from > 4000 MHz to 8000 MHz. In add

Re: [PATCH 1/2] staging: kpc2000: kpc2000_i2c: void* -> void *

2019-06-08 Thread Geordan Neukum
On Sat, Jun 08, 2019 at 03:27:46PM +0800, Hao Xu wrote: > modify void* to void * for #define inb_p(a) readq((void*)a) > and #define outb_p(d,a) writeq(d,(void*)a) > > Signed-off-by: Hao Xu > --- > drivers/staging/kpc2000/kpc2000_i2c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH v6 2/2] dt-bindings: iio: frequency: Add docs for ADF4371 PLL

2019-06-08 Thread Jonathan Cameron
On Tue, 4 Jun 2019 17:58:21 +0300 Stefan Popa wrote: > Document support for Analog Devices ADF4371 SPI Wideband Synthesizer. > > Signed-off-by: Stefan Popa > Reviewed-by: Rob Herring Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thank

[PATCH] blk-mq: fix coding style

2019-06-08 Thread Soonwoo Hong
Add a space before colon in ternary operator Singed-off-by: Soonwoo Hong --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index ce0f5f4ede70..374b13e89bb1 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1377,7 +1377,7 @@

Re: [PATCH v2] dt-bindings: iio: accel: adxl372: switch to YAML bindings

2019-06-08 Thread Jonathan Cameron
On Thu, 6 Jun 2019 08:49:53 + "Ardelean, Alexandru" wrote: > On Fri, 2019-05-31 at 17:11 -0300, Lucas Oshiro wrote: > > [External] > > > > > > Convert the old device tree documentation to yaml format. > > > > Signed-off-by: Lucas Oshiro > > Signed-off-by: Rodrigo Ribeiro > > Co-developed

[PATCH] Staging: rts5208: fixed brace coding style issue

2019-06-08 Thread xabi1500
From: Xabier Etxezarreta Fixed a coding style issue checked with checkpatch.pl Signed-off-by: Xabier Etxezarreta --- drivers/staging/rts5208/rtsx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index fa59

Re: [PATCH v6 2/2] dt-bindings: iio: frequency: Add docs for ADF4371 PLL

2019-06-08 Thread Jonathan Cameron
On Tue, 4 Jun 2019 17:58:21 +0300 Stefan Popa wrote: > Document support for Analog Devices ADF4371 SPI Wideband Synthesizer. > > Signed-off-by: Stefan Popa > Reviewed-by: Rob Herring Applied, Thanks Jonathan > --- > Changes in v2: > - Nothing changed. > Changes in v3: > - Nothin

Re: [PATCH] ARM: davinci: da850-evm: call regulator_has_full_constraints()

2019-06-08 Thread Linus Walleij
On Fri, Jun 7, 2019 at 11:02 AM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The BB expander at 0x21 i2c bus 1 fails to probe on da850-evm because > the board doesn't set has_full_constraints to true in the regulator > API. > > Call regulator_has_full_constraints() at the end of bo

Re: [PATCH trivial] dt-bindings: pinctrl: pic32: Spelling s/configuraion/configuration/

2019-06-08 Thread Linus Walleij
On Fri, Jun 7, 2019 at 1:06 PM Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven Patch applied. Yours, Linus Walleij

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-08 Thread Konstantin Khlebnikov
On 08.06.2019 12:12, Konstantin Khlebnikov wrote: On 07.06.2019 19:58, Martin K. Petersen wrote: Konstantin, +    if (dev->horkage & ATA_HORKAGE_NOTRIM) +    trim_status = "backlisted"; blacklisted Oops. My bad. +    else +    trim_status = "

Re: [PATCH v2 3/8] pinctrl: msm: Add ability for drivers to supply a reserved GPIO list

2019-06-08 Thread Linus Walleij
On Fri, Jun 7, 2019 at 1:10 PM Ard Biesheuvel wrote: > On Fri, 7 Jun 2019 at 10:29, Lee Jones wrote: > > > > When booting MSM based platforms with Device Tree or some ACPI > > implementations, it is possible to provide a list of reserved pins > > via the 'gpio-reserved-ranges' and 'gpios' propert

KMSAN: uninit-value in bcmp

2019-06-08 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d062d017 usb-fuzzer: main usb gadget fuzzer driver git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=119daa0ca0 kernel config: https://syzkaller.appspot.com/x/.config?x=67ebf8b3cce62ce7 dashboard link:

[tip:ras/urgent] RAS/CEC: Convert the timer callback to a workqueue

2019-06-08 Thread tip-bot for Cong Wang
Commit-ID: 0ade0b6240c4853cf9725924c46c10f4251639d7 Gitweb: https://git.kernel.org/tip/0ade0b6240c4853cf9725924c46c10f4251639d7 Author: Cong Wang AuthorDate: Tue, 16 Apr 2019 14:33:51 -0700 Committer: Borislav Petkov CommitDate: Fri, 7 Jun 2019 23:21:39 +0200 RAS/CEC: Convert the timer

Re: rcu_read_lock lost its compiler barrier

2019-06-08 Thread Paul E. McKenney
On Thu, Jun 06, 2019 at 10:19:43AM -0400, Alan Stern wrote: > On Thu, 6 Jun 2019, Andrea Parri wrote: > > > This seems a sensible change to me: looking forward to seeing a patch, > > on top of -rcu/dev, for further review and testing! > > > > We could also add (to LKMM) the barrier() for rcu_read

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Paul E. McKenney
On Fri, Jun 07, 2019 at 09:19:42AM -0700, Linus Torvalds wrote: > On Fri, Jun 7, 2019 at 8:26 AM Eric Dumazet wrote: > > > > There is common knowledge among us programmers that bit fields > > (or bool) sharing a common 'word' need to be protected > > with a common lock. > > > > Converting all bit

Re: [PATCH v2 for 5.2 08/12] rseq/selftests: arm: use udf instruction for RSEQ_SIG

2019-06-08 Thread Mathieu Desnoyers
- On Jun 6, 2019, at 8:02 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On May 3, 2019, at 3:38 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> Use udf as the guard instruction for the restartable sequence abort >> handler. >> >> Previously, the chos

Re: [PATCH] Staging: rts5208: fixed brace coding style issue

2019-06-08 Thread Greg KH
On Sat, Jun 08, 2019 at 03:53:35PM +0200, xabi1...@gmail.com wrote: > From: Xabier Etxezarreta > > Fixed a coding style issue checked with checkpatch.pl > > Signed-off-by: Xabier Etxezarreta > --- > drivers/staging/rts5208/rtsx.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > >

Re: [PATCH] blk-mq: fix coding style

2019-06-08 Thread Greg KH
On Sat, Jun 08, 2019 at 10:47:28PM +0900, Soonwoo Hong wrote: > Add a space before colon in ternary operator > > Singed-off-by: Soonwoo Hong > --- > block/blk-mq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) $ ./scripts/get_maintainer.pl --file block/blk-mq.c Jens Axboe (maintainer

Re: [PATCH] blk-mq: fix coding style

2019-06-08 Thread Greg KH
On Sat, Jun 08, 2019 at 05:54:46PM +0200, Greg KH wrote: > On Sat, Jun 08, 2019 at 10:47:28PM +0900, Soonwoo Hong wrote: > > Add a space before colon in ternary operator > > > > Singed-off-by: Soonwoo Hong > > --- > > block/blk-mq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: rcu_read_lock lost its compiler barrier

2019-06-08 Thread Alan Stern
On Sat, 8 Jun 2019, Paul E. McKenney wrote: > On Thu, Jun 06, 2019 at 10:19:43AM -0400, Alan Stern wrote: > > On Thu, 6 Jun 2019, Andrea Parri wrote: > > > > > This seems a sensible change to me: looking forward to seeing a patch, > > > on top of -rcu/dev, for further review and testing! > > > >

Re: [PATCH v3] vt: Fix a missing-check bug in con_init()

2019-06-08 Thread Gen Zhang
On Tue, May 28, 2019 at 08:45:29AM +0800, Gen Zhang wrote: > In function con_init(), the pointer variable vc_cons[currcons].d, vc and > vc->vc_screenbuf is allocated by kzalloc(). And they are used in the > following codes. However, kzalloc() returns NULL when fails, and null > pointer dereferenc

Re: [PATCH] tegra-hsp: fix a missing-check bug in tegra_hsp_doorbell_create()

2019-06-08 Thread Gen Zhang
On Thu, May 30, 2019 at 09:19:20AM +0800, Gen Zhang wrote: > In tegra_hsp_doorbell_create(), 'db->name' is allocated by > devm_kstrdup_const(). It returns NULL when fails. So 'db->name' should > be checked. > > Signed-off-by: Gen Zhang > Acked-by: Thierry Reding > --- > diff --git a/drivers/mai

Re: [PATCH v3] vt: Fix a missing-check bug in con_init()

2019-06-08 Thread Greg KH
On Sun, Jun 09, 2019 at 12:01:38AM +0800, Gen Zhang wrote: > On Tue, May 28, 2019 at 08:45:29AM +0800, Gen Zhang wrote: > > In function con_init(), the pointer variable vc_cons[currcons].d, vc and > > vc->vc_screenbuf is allocated by kzalloc(). And they are used in the > > following codes. However

Re: [PATCH v3] vt: Fix a missing-check bug in con_init()

2019-06-08 Thread Greg KH
On Sun, Jun 09, 2019 at 12:01:38AM +0800, Gen Zhang wrote: > On Tue, May 28, 2019 at 08:45:29AM +0800, Gen Zhang wrote: > > In function con_init(), the pointer variable vc_cons[currcons].d, vc and > > vc->vc_screenbuf is allocated by kzalloc(). And they are used in the > > following codes. However

Re: [PATCH v3] vt: Fix a missing-check bug in con_init()

2019-06-08 Thread Gen Zhang
On Sat, Jun 08, 2019 at 06:21:27PM +0200, Greg KH wrote: > On Sun, Jun 09, 2019 at 12:01:38AM +0800, Gen Zhang wrote: > > On Tue, May 28, 2019 at 08:45:29AM +0800, Gen Zhang wrote: > > > In function con_init(), the pointer variable vc_cons[currcons].d, vc and > > > vc->vc_screenbuf is allocated by

Re: [PATCH v3] vt: Fix a missing-check bug in con_init()

2019-06-08 Thread Gen Zhang
On Sat, Jun 08, 2019 at 06:22:19PM +0200, Greg KH wrote: > On Sun, Jun 09, 2019 at 12:01:38AM +0800, Gen Zhang wrote: > > On Tue, May 28, 2019 at 08:45:29AM +0800, Gen Zhang wrote: > > > In function con_init(), the pointer variable vc_cons[currcons].d, vc and > > > vc->vc_screenbuf is allocated by

Re: rcu_read_lock lost its compiler barrier

2019-06-08 Thread Paul E. McKenney
On Sat, Jun 08, 2019 at 11:56:04AM -0400, Alan Stern wrote: > On Sat, 8 Jun 2019, Paul E. McKenney wrote: > > > On Thu, Jun 06, 2019 at 10:19:43AM -0400, Alan Stern wrote: > > > On Thu, 6 Jun 2019, Andrea Parri wrote: > > > > > > > This seems a sensible change to me: looking forward to seeing a p

Re: [PATCH v3] vt: Fix a missing-check bug in con_init()

2019-06-08 Thread Gen Zhang
On Sat, Jun 08, 2019 at 06:21:27PM +0200, Greg KH wrote: > On Sun, Jun 09, 2019 at 12:01:38AM +0800, Gen Zhang wrote: > > On Tue, May 28, 2019 at 08:45:29AM +0800, Gen Zhang wrote: > > > In function con_init(), the pointer variable vc_cons[currcons].d, vc and > > > vc->vc_screenbuf is allocated by

Re: [PATCH HACK RFC] cpu: Prevent late-arriving interrupts from disrupting offline

2019-06-08 Thread Paul E. McKenney
On Tue, Jun 04, 2019 at 03:29:32PM +0200, Dietmar Eggemann wrote: > On 6/4/19 9:45 AM, Paul E. McKenney wrote: > >On Mon, Jun 03, 2019 at 03:39:18PM +0200, Dietmar Eggemann wrote: > >>On 6/3/19 1:44 PM, Mark Rutland wrote: > >>>On Mon, Jun 03, 2019 at 10:38:48AM +0200, Peter Zijlstra wrote: > O

Re: powerpc hugepage leak caused by 576ed913 "block: use bio_add_page in bio_iov_iter_get_pages"

2019-06-08 Thread Ming Lei
On Fri, Apr 26, 2019 at 12:41 PM David Gibson wrote: > > On Fri, Apr 26, 2019 at 11:05:17AM +1000, David Gibson wrote: > > On Thu, Apr 25, 2019 at 08:19:58AM +0200, Christoph Hellwig wrote: > > > Just curious: What exact trees do you see this with? This area > > > changed a lot with the multipag

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Linus Torvalds
On Sat, Jun 8, 2019 at 8:32 AM Paul E. McKenney wrote: > > On Fri, Jun 07, 2019 at 09:19:42AM -0700, Linus Torvalds wrote: > > > > - bitfields obviously do need locks. 'char' does not. > > > > If there's somebody who really notices the alpha issue in PRACTICE, we > > can then bother to fix it. Bu

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Linus Torvalds
On Sat, Jun 8, 2019 at 10:42 AM Linus Torvalds wrote: > > There are no atomic rmw sequences that have reasonable performance for > the bitfield updates themselves. Note that this is purely about the writing side. Reads of bitfield values can be (and generally _should_ be) atomic, and hopefully C1

Re: [PATCH v3 1/5] arch: riscv: add support for building DTB files from DT source data

2019-06-08 Thread Palmer Dabbelt
On Thu, 06 Jun 2019 22:12:05 PDT (-0700), Paul Walmsley wrote: On Tue, 4 Jun 2019, Loys Ollivier wrote: Always build it ? Any particular reason to drop ARCH_SIFIVE ? Palmer had some reservations about it, so I dropped it for now. But then as I was thinking about it, I remembered that I also

[PATCH v2 01/14] pwm: meson: unify the parameter list of meson_pwm_{enable,disable}

2019-06-08 Thread Martin Blumenstingl
This is a preparation for a future cleanup. Pass struct pwm_device instead of passing the individual values required by each function as these can be obtained for each struct pwm_device instance. As a nice side-effect the driver now uses "switch (pwm->hwpwm)" everywhere. Before some functions used

[PATCH v2 02/14] pwm: meson: use devm_clk_get_optional() to get the input clock

2019-06-08 Thread Martin Blumenstingl
Simplify the code which fetches the input clock for a PWM channel by using devm_clk_get_optional(). This comes with a small functional change: previously all errors except EPROBE_DEFER were ignored. Now all other errors are also treated as errors. If no input clock is present devm_clk_get_optional(

[PATCH v2 12/14] pwm: meson: don't cache struct pwm_state internally

2019-06-08 Thread Martin Blumenstingl
The PWM core already caches the "current struct pwm_state" as the "current state of the hardware registers" inside struct pwm_device. Drop the struct pwm_state from struct meson_pwm_channel in favour of the struct pwm_state in struct pwm_device. While here also drop any checks based on the pwm_sta

[PATCH v2 14/14] pwm: meson: add documentation to the driver

2019-06-08 Thread Martin Blumenstingl
Add a link to the datasheet and a short summary how the hardware works. The goal is to make it easier for other developers to understand why the pwm-meson driver is implemented the way it is. Suggested-by: Uwe Kleine-König Co-authored-by: Neil Armstrong Signed-off-by: Martin Blumenstingl Review

[PATCH v2 06/14] pwm: meson: pass struct pwm_device to meson_pwm_calc()

2019-06-08 Thread Martin Blumenstingl
meson_pwm_calc() is the last function that accepts a struct meson_pwm_channel. meson_pwm_enable(), meson_pwm_disable() and meson_pwm_apply() for example are all taking a struct pwm_device as parameter. When they need the struct meson_pwm_channel these functions simply call pwm_get_chip_data() inter

[PATCH v2 08/14] pwm: meson: add the per-channel register offsets and bits in a struct

2019-06-08 Thread Martin Blumenstingl
Introduce struct meson_pwm_channel_data which contains the per-channel offsets for the PWM register and REG_MISC_AB bits. Replace the existing switch (pwm->hwpwm) statements with an access to the new struct. This simplifies the code and will make it easier to implement pwm_ops.get_state() because

[PATCH v2 11/14] pwm: meson: read the full hardware state in meson_pwm_get_state()

2019-06-08 Thread Martin Blumenstingl
Update the meson_pwm_get_state() implementation to take care of all information in the registers instead of only reading the "enabled" state. The PWM output is only enabled if two conditions are met: 1. the per-channel clock is enabled 2. the PWM output is enabled Calculate the PWM period and dut

[PATCH v2 10/14] pwm: meson: simplify the calculation of the pre-divider and count

2019-06-08 Thread Martin Blumenstingl
Replace the loop to calculate the pre-divider and count with two separate div64_u64() calculations. This makes the code easier to read and improves the precision. Three example cases: 1) 32.768kHz LPO clock for the SDIO wifi chip on Khadas VIM clock input: 500MHz (FCLK_DIV4) period: 30518ns

[PATCH v2 07/14] pwm: meson: add the meson_pwm_channel data to struct meson_pwm

2019-06-08 Thread Martin Blumenstingl
Make struct meson_pwm_channel accessible from struct meson_pwm. PWM core has a limitation: per-channel data can only be set after pwmchip_add() is called. However, pwmchip_add() internally calls pwm_ops.get_state(). If pwm_ops.get_state() needs access to the per-channel data it has to obtain it fr

[PATCH v2 04/14] pwm: meson: change MISC_CLK_SEL_WIDTH to MISC_CLK_SEL_MASK

2019-06-08 Thread Martin Blumenstingl
MISC_CLK_SEL_WIDTH is only used in one place where it's converted into a bit-mask. Rename and change the macro to be a bit-mask so that conversion is not needed anymore. No functional changes intended. Signed-off-by: Martin Blumenstingl Reviewed-by: Neil Armstrong --- drivers/pwm/pwm-meson.c |

[PATCH v2 09/14] pwm: meson: move pwm_set_chip_data() to meson_pwm_request()

2019-06-08 Thread Martin Blumenstingl
All existing PWM drivers (except pwm-meson and two other ones) call pwm_set_chip_data() from their pwm_ops.request() callback. Now that we can access the struct meson_pwm_channel from struct meson_pwm we can do the same. Move the call to pwm_set_chip_data() to meson_pwm_request() and drop the cust

[PATCH v2 03/14] pwm: meson: use GENMASK and FIELD_PREP for the lo and hi values

2019-06-08 Thread Martin Blumenstingl
meson_pwm_calc() ensures that "lo" is always less than 16 bits wide (otherwise it would overflow into the "hi" part of the REG_PWM_{A,B} register). Use GENMASK and FIELD_PREP for the lo and hi values to make it easier to spot how wide these are internally. Additionally this is a preparation step fo

[PATCH v2 13/14] pwm: meson: add support PWM_POLARITY_INVERSED when disabling

2019-06-08 Thread Martin Blumenstingl
meson_pwm_apply() has to consider the PWM polarity when disabling the output. With enabled=false and polarity=PWM_POLARITY_NORMAL the output needs to be LOW. The driver already supports this. With enabled=false and polarity=PWM_POLARITY_INVERSED the output needs to be HIGH. Implement this in the dr

[PATCH v2 00/14] pwm-meson: cleanups and improvements

2019-06-08 Thread Martin Blumenstingl
This series consists of various cleanups and improvements for the pwm-meson driver. Patches 1 to 6 are small code cleanups with the goal of making the code easier to read. Patches 7 to 9 are reworking the way the per-channel settings are accessed. This is a first preparation step for adding full

[PATCH v2 05/14] pwm: meson: don't duplicate the polarity internally

2019-06-08 Thread Martin Blumenstingl
Let meson_pwm_calc() use the polarity from struct pwm_state directly. This removes a level of indirection where meson_pwm_apply() first had to set a driver-internal inverter mask which was then only used by meson_pwm_calc(). Instead of adding the polarity as parameter to meson_pwm_calc() switch to

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Paul E. McKenney
On Sat, Jun 08, 2019 at 10:42:41AM -0700, Linus Torvalds wrote: > On Sat, Jun 8, 2019 at 8:32 AM Paul E. McKenney wrote: > > > > On Fri, Jun 07, 2019 at 09:19:42AM -0700, Linus Torvalds wrote: > > > > > > - bitfields obviously do need locks. 'char' does not. > > > > > > If there's somebody who re

Re: [PATCH 4.14 00/69] 4.14.124-stable review

2019-06-08 Thread Guenter Roeck
On 6/7/19 8:38 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.124 release. There are 69 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [RFC net-next 2/2] net: stmmac: Convert to phylink

2019-06-08 Thread Andrew Lunn
> I am not exactly sure removing this is strictly equivalent here, but the > diff makes it hard to review. Yes, diff is doing a poor job here. I already asked Jose if a better diff could be produced by passing extra options. > - add support for PHYLINK (parts of this patch) but without plugging i

Re: [PATCH 4.19 00/73] 4.19.49-stable review

2019-06-08 Thread Guenter Roeck
On 6/7/19 8:38 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.49 release. There are 73 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made b

Re: [PATCH 5.1 00/85] 5.1.8-stable review

2019-06-08 Thread Guenter Roeck
On 6/7/19 8:38 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.1.8 release. There are 85 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Paul E. McKenney
On Sat, Jun 08, 2019 at 10:50:51AM -0700, Linus Torvalds wrote: > On Sat, Jun 8, 2019 at 10:42 AM Linus Torvalds > wrote: > > > > There are no atomic rmw sequences that have reasonable performance for > > the bitfield updates themselves. > > Note that this is purely about the writing side. Reads

[PATCH v3 0/3] meson-gpio-irqc: Add support for the Meson-G12A SoC

2019-06-08 Thread Martin Blumenstingl
This series adds GPIO interrupt controller support for Meson-G12A SoCs. Although the total number of pins is the same as the Meson-AXG SoC, the GPIO banks and IRQ numbers are different. Add a new compatible string to avoid confusion when using it. I am re-sending this update because v2 looked good

[PATCH v3 2/3] irqchip/meson-gpio: Add support for Meson-G12A SoC

2019-06-08 Thread Martin Blumenstingl
From: Xingyu Chen The Meson-G12A SoC uses the same GPIO interrupt controller IP block as the other Meson SoCs, A totle of 100 pins can be spied on, which is the sum of: - 223:100 undefined (no interrupt) - 99:97 3 pins on bank GPIOE - 96:77 20 pins on bank GPIOX - 76:61 16 pins on bank GPI

[PATCH v3 1/3] dt-bindings: interrupt-controller: New binding for Meson-G12A SoC

2019-06-08 Thread Martin Blumenstingl
From: Xingyu Chen Update the dt-binding document to support new compatible string for the GPIO interrupt controller which found in Amlogic's Meson-G12A SoC. Signed-off-by: Xingyu Chen Signed-off-by: Jianxin Pan Signed-off-by: Martin Blumenstingl --- .../bindings/interrupt-controller/amlogic,

[PATCH v3 3/3] arm64: dts: meson: g12a: add the GPIO interrupt controller

2019-06-08 Thread Martin Blumenstingl
GPIO interrupts are used for the external Ethernet RGMII PHY interrupt line. Add the GPIO interrupt controller so we can describe that connection in the dts files. Signed-off-by: Martin Blumenstingl --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 9 + 1 file changed, 9 insertions(+) d

[GIT PULL] Ceph fixes for 5.2-rc4

2019-06-08 Thread Ilya Dryomov
Hi Linus, The following changes since commit f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a: Linux 5.2-rc3 (2019-06-02 13:55:33 -0700) are available in the Git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-5.2-rc4 for you to fetch changes up to 7b2f936fc8282ab56d4d21247f2f

Re: [PATCH 4.14 00/69] 4.14.124-stable review

2019-06-08 Thread Naresh Kamboju
On Sat, 8 Jun 2019 at 15:03, Greg Kroah-Hartman wrote: > > On Fri, Jun 07, 2019 at 05:38:41PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.124 release. > > There are 69 patches in this series, all will be posted as a response > > to this one. If a

memory leak in create_ctx

2019-06-08 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:79c3ba32 Merge tag 'drm-fixes-2019-06-07-1' of git://anong.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=170e0bfea0 kernel config: https://syzkaller.appspot.com/x/.config?x=d5c73825cbdc7326 da

general protection fault in mm_update_next_owner

2019-06-08 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:38e406f6 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=10c90fbaa0 kernel config: https://syzkaller.appspot.com/x/.config?x=60564cb52ab29d5b dashboa

Re: [RFC PATCH 1/6] ASoC: core: add support to snd_soc_dai_get_sdw_stream()

2019-06-08 Thread Cezary Rojewski
On 2019-06-07 10:56, Srinivas Kandagatla wrote: On platforms which have smart speaker amplifiers connected via soundwire and modeled as aux devices in ASoC, in such usecases machine driver should be able to get sdw master stream from dai so that it can use the runtime stream to setup slave stream

Re: [GIT PULL] SCSI fixes for 5.2-rc3

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Fri, 07 Jun 2019 23:05:26 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1b02caa319cf73ae89aced8714066a3a5bbe648b Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [GIT PULL] Kselftest second fixes update for Linux 5.2-rc4

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Fri, 7 Jun 2019 20:11:05 -0600: > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest > tags/linux-kselftest-5.2-rc4-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0ad43e29b6e845758f0ceb80e3c1d1a9cebfad06 Thank you! --

RE: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-06-08 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday 7 June 2019 16:58 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger.kernel.org; > linux-ker

Re: [PATCH v2 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support

2019-06-08 Thread Mark Brown
On Sat, Jun 08, 2019 at 09:26:31AM +0530, keerthy wrote: > mfd patches are on linux-next already. Hope you can pull this one now that > dependencies are met. Someone will need to send me a copy of the patch, if I acked it I was expecting it to go in with the MFD changes. signature.asc Descripti

[PATCH 0/7] Add SD/MMC driver for Actions Semi S900 SoC

2019-06-08 Thread Manivannan Sadhasivam
Hello, This patchset adds SD/MMC driver for Actions Semi S900 SoC from Owl family SoCs. There are 4 SD/MMC controller present in this SoC but only 2 are enabled currently for Bubblegum96 board to access uSD and onboard eMMC. SDIO support for this driver is not currently implemented. Note: Current

[PATCH 1/7] clk: actions: Fix factor clk struct member access

2019-06-08 Thread Manivannan Sadhasivam
Since the helper "owl_factor_helper_round_rate" is shared between factor and composite clocks, using the factor clk specific helper function like "hw_to_owl_factor" to access its members will create issues when called from composite clk specific code. Hence, pass the "factor_hw" struct pointer dire

[PATCH 6/7] MAINTAINERS: Add entry for Actions Semi SD/MMC driver and binding

2019-06-08 Thread Manivannan Sadhasivam
Add MAINTAINERS entry for Actions Semi SD/MMC driver with its binding. Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a6954776a37e..11d6937c4688 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1336,6 +1336

[PATCH 4/7] arm64: dts: actions: Add uSD and eMMC support for Bubblegum96

2019-06-08 Thread Manivannan Sadhasivam
Add uSD and eMMC support for Bubblegum96 board based on Actions Semi Owl SoC. SD0 is connected to uSD slot and SD2 is connected to eMMC. Since there is no PMIC support added yet, fixed regulator has been used as a regulator node. Signed-off-by: Manivannan Sadhasivam --- .../boot/dts/actions/s900

[PATCH 7/7] arm64: configs: Enable Actions Semi platform in defconfig

2019-06-08 Thread Manivannan Sadhasivam
Since the Actions Semi platform can now boot a distro, enable it in ARM64 defconfig. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 4d583514258c..e0b5f4f8c

[PATCH 2/7] dt-bindings: mmc: Add Actions Semi SD/MMC/SDIO controller binding

2019-06-08 Thread Manivannan Sadhasivam
Add devicetree binding for Actions Semi Owl SoC's SD/MMC/SDIO controller. Signed-off-by: Manivannan Sadhasivam --- .../devicetree/bindings/mmc/owl-mmc.txt | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/mmc/owl-mmc.txt diff

[PATCH 5/7] mmc: Add Actions Semi Owl SoCs SD/MMC driver

2019-06-08 Thread Manivannan Sadhasivam
Add SD/MMC driver for Actions Semi Owl SoCs. This driver currently supports standard, high speed, SDR12, SDR25 and SDR50. DDR50 mode is supported but it is untested. There is no SDIO support for now. Signed-off-by: Manivannan Sadhasivam --- drivers/mmc/host/Kconfig | 8 + drivers/mmc/host/Ma

[PATCH 3/7] arm64: dts: actions: Add MMC controller support for S900

2019-06-08 Thread Manivannan Sadhasivam
Add MMC controller support for Actions Semi S900 SoC. There are 4 MMC controllers in this SoC which can be used for accessing SD/MMC/SDIO cards. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900.dtsi | 45 +++ 1 file changed, 45 insertions(+) diff

Re: 32-bit Amlogic (ARM) SoC: kernel BUG in kfree()

2019-06-08 Thread Martin Blumenstingl
Hi Liang, On Thu, Apr 11, 2019 at 5:00 AM Liang Yang wrote: > > Hi Martin, > On 2019/4/11 1:54, Martin Blumenstingl wrote: > > Hi Liang, > > > > On Wed, Apr 10, 2019 at 1:08 PM Liang Yang wrote: > >> > >> Hi Martin, > >> > >> On 2019/4/5 12:30, Martin Blumenstingl wrote: > >>> Hi Liang, > >>> >

Re: [alsa-devel] [RFC PATCH 3/6] soundwire: core: define SDW_MAX_PORT

2019-06-08 Thread Cezary Rojewski
On 2019-06-07 14:31, Pierre-Louis Bossart wrote: On 6/7/19 3:56 AM, Srinivas Kandagatla wrote: This patch adds SDW_MAX_PORT so that other driver can use it. Signed-off-by: Srinivas Kandagatla ---   include/linux/soundwire/sdw.h | 1 +   1 file changed, 1 insertion(+) diff --git a/include/lin

Re: [GIT PULL]: dmaengine fixes for v5.2-rc4

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Sat, 8 Jun 2019 14:39:08 +0530: > git://git.infradead.org/users/vkoul/slave-dma.git tags/dmaengine-fix-5.2-rc4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/66b59f2b5e48969de862908c2d32c8b3d3724738 Thank you! -- Deet-doot-dot, I am a bo

Re: [GIT PULL] Char/Misc driver fixes for 5.2-rc4

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Sat, 8 Jun 2019 11:58:22 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > char-misc-5.2-rc4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1ce2c85137b1db5b0e4158d558cb93dcff7674df Thank you! -- Deet-doot-dot

Re: [GIT PULL] SPDX update for 5.2-rc4

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Sat, 8 Jun 2019 11:58:00 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > tags/spdx-5.2-rc4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9331b6740f86163908de69f4008e434fe0c27691 Thank you! -- Deet-doot-d

Re: [PULL REQUEST] i2c for 5.2

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Sat, 8 Jun 2019 10:54:10 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/902b2edfca34f88b04b86e605087e200e7e79880 Thank you! -- Deet-doot-dot, I am a bot

From Mrs. Ayesha Al-Qaddafi,

2019-06-08 Thread Ayesha Al-Gaddafi
Peace be upon you Dear Friend, It’s my pleasure to contact you through this media as i am in need of your urgent assistance. My names are Mrs. Ayesha Al-Qaddafi a single Mother and a Widow with three Children. I am the only biological Daughter of late Libyan President (Late Colonel Muammar Al-Qad

Re: [GIT PULL] MIPS fixes

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Sat, 8 Jun 2019 06:40:08 +: > git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git > tags/mips_fixes_5.2_1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d0cc617affbf2e31696adf37d153c550c5bef662 Thank you! -- Deet-doot-dot,

Re: [GIT PULL] s390 updates for 5.2-rc4

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Sat, 8 Jun 2019 13:21:51 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git tags/s390-5.2-4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3d4645bf7a76886c70a482a1c6742bac98553f47 Thank you! -- Deet-doot-dot, I am a bo

Re: [GIT PULL] xen: fix for 5.2-rc4

2019-06-08 Thread pr-tracker-bot
The pull request you sent on Sat, 8 Jun 2019 13:43:26 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.2b-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8e61f6f7c308a828f8402db6651f6e38ba66c009 Thank you! -- Deet-doot-dot, I

<    1   2   3   4   5   >