[PATCH v5 0/4] Some cleanups for the KVA/vmalloc

2019-06-06 Thread Uladzislau Rezki (Sony)
v4->v5: - base on next-20190606 - embed preloading directly into alloc_vmap_area(). [2] patch - update the commit message of [2]. - if RB_EMPTY_NODE(), generate warning and return; [4] patch v3->v4: - Replace BUG_ON by WARN_ON() in [4]; - Update the commit message

[PATCH v5 1/4] mm/vmalloc.c: remove "node" argument

2019-06-06 Thread Uladzislau Rezki (Sony)
Remove unused argument from the __alloc_vmap_area() function. Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Andrew Morton Reviewed-by: Roman Gushchin --- mm/vmalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index bed6a065f73a..6

Re: [PATCH 01/16] firmware: ti_sci: Add resource management APIs for ringacc, psi-l and udma

2019-06-06 Thread Peter Ujfalusi
Hi Lokesh, On 06/06/2019 9.00, Lokesh Vutla wrote: > Hi Peter, > > On 06/05/19 6:04 PM, Peter Ujfalusi wrote: >> Signed-off-by: Peter Ujfalusi > > Patch has the following checkpatch warnings and checks which can be fixed: > > WARNING: Missing commit description - Add an appropriate one How di

[PATCH v5 3/4] mm/vmalloc.c: get rid of one single unlink_va() when merge

2019-06-06 Thread Uladzislau Rezki (Sony)
It does not make sense to try to "unlink" the node that is definitely not linked with a list nor tree. On the first merge step VA just points to the previously disconnected busy area. On the second step, check if the node has been merged and do "unlink" if so, because now it points to an object t

[PATCH v5 4/4] mm/vmalloc.c: switch to WARN_ON() and move it under unlink_va()

2019-06-06 Thread Uladzislau Rezki (Sony)
Trigger a warning if an object that is about to be freed is detached. We used to have a BUG_ON(), but even though it is considered as faulty behaviour that is not a good reason to break a system. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 25 ++--- 1 file chang

[PATCH v5 2/4] mm/vmalloc.c: preload a CPU with one object for split purpose

2019-06-06 Thread Uladzislau Rezki (Sony)
Refactor the NE_FIT_TYPE split case when it comes to an allocation of one extra object. We need it in order to build a remaining space. The preload is done per CPU in non-atomic context with GFP_KERNEL flags. More permissive parameters can be beneficial for systems which are suffer from high memor

Re: [PATCH V2] i2c: busses: tegra: Add suspend-resume support

2019-06-06 Thread Dmitry Osipenko
06.06.2019 8:54, Bitan Biswas пишет: > Post suspend I2C registers have power on reset values. Before any > transfer initialize I2C registers to prevent I2C transfer timeout > and implement suspend and resume callbacks needed. Fix below errors > post suspend: > > 1) Tegra I2C transfer timeout durin

Re: [PATCH v7 1/6] dt-bindings: add binding for USBSS-DRD controller.

2019-06-06 Thread Roger Quadros
Pawel, On 05/06/2019 13:03, Pawel Laszczak wrote: > This patch aim at documenting USB related dt-bindings for the > Cadence USBSS-DRD controller. > > Signed-off-by: Pawel Laszczak > Reviewed-by: Rob Herring > > --- > .../devicetree/bindings/usb/cdns-usb3.txt | 30 +++ > 1

Re: [PATCH v8 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-06-06 Thread Sakari Ailus
Hi Vishal, On Thu, Jun 06, 2019 at 11:54:19AM +, Vishal Sagar wrote: > Hi Sakari, > > > -Original Message- > > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > > Sent: Wednesday, June 05, 2019 12:54 AM > > To: Vishal Sagar > > Cc: Hyun Kwon ; laurent.pinch...@ideasonboard.c

Re: [PATCH v7 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-06-06 Thread Roger Quadros
Pawel, On 05/06/2019 13:03, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to Linux kernel. > > The Cadence USBSS DRD Driver is a highly configurable IP Core which > can be instantiated as Dual-Role Device (DRD), Peripheral Only and > Host Only (XHCI)configurations. >

Re: [PATCH] ASoC: msm8916-wcd-digital: Add sidetone support

2019-06-06 Thread Srinivas Kandagatla
Thanks for the review, On 06/06/2019 12:54, Mark Brown wrote: On Thu, Jun 06, 2019 at 12:40:02PM +0100, Srinivas Kandagatla wrote: + default: + pr_err("%s: event = %d not expected\n", __func__, event); + } dev_err() please (and a break; as well, it isn't strictly ne

[PATCH 1/2] habanalabs: add rate-limit to an error message

2019-06-06 Thread Oded Gabbay
This patch changes the print of an error message about mis-configuration of the debug infrastructure to be rate-limited, to prevent flooding of kernel log, as these configuration requests can come at a high rate. Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/habanalabs_ioctl.c | 2 +- 1

[PATCH 2/2] docs/habanalabs: update text for some entries in sysfs

2019-06-06 Thread Oded Gabbay
This patch updates the description of some entries in sysfs for the habanalabs driver. Signed-off-by: Oded Gabbay --- .../ABI/testing/sysfs-driver-habanalabs | 42 +++ 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-driver-hab

RE: [PATCH v8 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-06-06 Thread Vishal Sagar
Hi Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Thursday, June 06, 2019 5:43 PM > To: Vishal Sagar > Cc: Vishal Sagar ; Hyun Kwon ; > laurent.pinch...@ideasonboard.com; mche...@kernel.org; > robh...@kernel.org; mark.rutl...@arm.com; Micha

Re: rcu_read_lock lost its compiler barrier

2019-06-06 Thread Paul E. McKenney
On Thu, Jun 06, 2019 at 05:28:55PM +0800, Herbert Xu wrote: > On Thu, Jun 06, 2019 at 02:06:19AM -0700, Paul E. McKenney wrote: > > > > Or is your point instead that given the initial value of "a" being > > zero and the value stored to "a" being one, there is no way that > > any possible load and s

[PATCH] hwmon: nct7904: fix error check on register read

2019-06-06 Thread Colin King
From: Colin Ian King Currently the return from the call to nct7904_read is being masked and so and negative error returns are being stripped off and the error check is always false. Fix this by checking on err first and then masking the return value in ret. Addresses-Coverity: ("Logically dead

Re: [PATCH v8 2/3] media: meson: add v4l2 m2m video decoder driver

2019-06-06 Thread Hans Verkuil
On 6/5/19 6:18 PM, Maxime Jourdan wrote: > Amlogic SoCs feature a powerful video decoder unit able to > decode many formats, with a performance of usually up to 4k60. > > This is a driver for this IP that is based around the v4l2 m2m framework. > > It features decoding for: > - MPEG 1 > - MPEG 2

[PATCH] KVM: x86: move MSR_IA32_POWER_CTL handling to common code

2019-06-06 Thread Paolo Bonzini
Make it available to AMD hosts as well, just in case someone is trying to use an Intel processor's CPUID setup. Suggested-by: Sean Christopherson Signed-off-by: Paolo Bonzini --- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/vmx/vmx.c | 6 -- arch/x86/kvm/vmx/vmx.h |

Re: [PATCH] KVM: x86: move MSR_IA32_POWER_CTL handling to common code

2019-06-06 Thread Liran Alon
> On 6 Jun 2019, at 15:33, Paolo Bonzini wrote: > > Make it available to AMD hosts as well, just in case someone is trying > to use an Intel processor's CPUID setup. I’m actually quite surprised that such a setup works properly. > > Suggested-by: Sean Christopherson > Signed-off-by: Paolo B

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 12:54, Peter Ujfalusi wrote: > > > On 06/06/2019 13.49, Jon Hunter wrote: >> >> On 06/06/2019 11:22, Peter Ujfalusi wrote: >> >> ... >> >> It does sounds like that FIFO_SIZE == src/dst_maxburst in your case as >> well. > Not exactly equal. > ADMA burst_size can ran

[PATCH] net: Fix hang while unregistering device bound to xdp socket

2019-06-06 Thread Ilya Maximets
Device that bound to XDP socket will not have zero refcount until the userspace application will not close it. This leads to hang inside 'netdev_wait_allrefs()' if device unregistering requested: # ip link del p1 < hang on recvmsg on netlink socket > # ps -x | grep ip 5126 pts/0D+

Re: [PATCH -mm 0/1] signal: simplify set_user_sigmask/restore_user_sigmask

2019-06-06 Thread Oleg Nesterov
On 06/06, David Laight wrote: > > Some of this code is hard to grep through :-) I'd suggest to simply read the kernel code once and memorise it, after that you will not need to use grep. > > When signal handler returns it does sys_rt_sigreturn() which restores > > the original mask saved in uc_si

RE: [PATCH v8 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

2019-06-06 Thread Vishal Sagar
Hi Hans, Thanks for reviewing. > -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Wednesday, June 05, 2019 6:14 PM > To: Vishal Sagar ; Hyun Kwon ; > laurent.pinch...@ideasonboard.com; mche...@kernel.org; > robh...@kernel.org; mark.rutl...@arm.com; Michal Simek

[PATCH v2] mfd: stmfx: Uninitialized variable in stmfx_irq_handler()

2019-06-06 Thread Dan Carpenter
The problem is that on 64bit systems then we don't clear the higher bits of the "pending" variable. So when we do: ack = pending & ~BIT(STMFX_REG_IRQ_SRC_EN_GPIO); if (ack) { the if (ack) condition relies on uninitialized data. The fix it that I've changed "pending" from an unsi

[PATCH v2] ASoC: msm8916-wcd-digital: Add sidetone support

2019-06-06 Thread Srinivas Kandagatla
This patch adds sidetone support via one of the 3 RX Mix paths using IIR1 and IIR2. IIR1 can be feed by any Decimators or RX paths, and IIRx can also be looped back to RX mixers to provide sidetone functionality. Two IIR filters are used for Side tone equalization and each filter is 5 stage. Signe

Re: [PATCH 3/7] media: cedrus: Fix decoding for some H264 videos

2019-06-06 Thread Dan Carpenter
On Mon, Jun 03, 2019 at 05:37:17PM +0200, Jernej Škrabec wrote: > Dne ponedeljek, 03. junij 2019 ob 13:55:36 CEST je Maxime Ripard napisal(a): > > int current = 0; > > > > while (current < num) { > > int tmp = min(num - current, 32); > > > > cedrus_write(dev, VE_H264_TRIGGER_TYPE, 0x3 | (

Re: [PATCH 4.19 249/276] media: si2165: fix a missing check of return value

2019-06-06 Thread Pavel Machek
Hi! > [ Upstream commit 0ab34a08812a3334350dbaf69a018ee0ab3d2ddd ] > > si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find > that "val_tmp" will be an uninitialized value when regmap_read() fails. > "val_tmp" is then assigned to "val". So if si2165_readreg8() fails, > "val" w

Re: [PATCH 0/6] mailbox: arm_mhu: add support to use in doorbell mode

2019-06-06 Thread Sudeep Holla
On Wed, Jun 05, 2019 at 07:51:12PM -0500, Jassi Brar wrote: > On Wed, Jun 5, 2019 at 2:46 PM Mark Brown wrote: > > > > On Tue, Jun 04, 2019 at 10:44:24AM +0100, Sudeep Holla wrote: > > > On Mon, Jun 03, 2019 at 08:39:46PM +0100, Mark Brown wrote: > > > > > > > > > It feels like the issues with sha

Re: [PATCH 4.19 237/276] scsi: lpfc: avoid uninitialized variable warning

2019-06-06 Thread Pavel Machek
Hi! > [ Upstream commit faf5a744f4f8d76e7c03912b5cd381ac8045f6ec ] > > clang -Wuninitialized incorrectly sees a variable being used without > initialization: > > drivers/scsi/lpfc/lpfc_nvme.c:2102:37: error: variable 'localport' is > uninitialized when used here > [-Werror,-Wuninitialized

Re: [alsa-devel] [PATCH 02/14] ALSA: hdac: fix memory release for SST and SOF drivers

2019-06-06 Thread Amadeusz Sławiński
On Wed, 5 Jun 2019 10:06:47 -0500 Pierre-Louis Bossart wrote: > On 6/5/19 8:45 AM, Amadeusz Sławiński wrote: > > During the integration of HDaudio support, we changed the way in > > which we get hdev in snd_hdac_ext_bus_device_init() to use one > > preallocated with devm_kzalloc(), however it sti

Re: [PATCH 4/7] staging: kpc2000: use __func__ in debug messages in core.c

2019-06-06 Thread Greg KH
On Tue, Jun 04, 2019 at 12:29:13AM +0200, Simon Sandström wrote: > Fixes checkpatch.pl warning "Prefer using '"%s...", __func__' to using > '', this function's name, in a string". > > Signed-off-by: Simon Sandström > --- > drivers/staging/kpc2000/kpc2000/core.c | 10 +- > 1 file changed,

Re: [PATCH v2] mfd: stmfx: Uninitialized variable in stmfx_irq_handler()

2019-06-06 Thread Amelie DELAUNAY
On 6/6/19 2:41 PM, Dan Carpenter wrote: > The problem is that on 64bit systems then we don't clear the higher > bits of the "pending" variable. So when we do: > > ack = pending & ~BIT(STMFX_REG_IRQ_SRC_EN_GPIO); > if (ack) { > > the if (ack) condition relies on uninitialized da

Re: [PATCH v4 17/30] coresight: Make device to CPU mapping generic

2019-06-06 Thread Suzuki K Poulose
On 03/06/2019 11:07, Mike Leach wrote: Hi, On Wed, 22 May 2019 at 11:37, Suzuki K Poulose wrote: The CoreSight components ETM and CPU-Debug are always associated with CPUs. Replace the of_coresight_get_cpu() with a platform agnostic helper, in preparation to add ACPI support. Reviewed-by:

Re: [PATCH] staging: rtl8188eu: core: Replace function rtw_free_network_nolock

2019-06-06 Thread Greg KH
On Tue, Jun 04, 2019 at 01:42:22PM +0530, Nishka Dasgupta wrote: > Remove function rtw_free_network_nolock, as all it does is call > _rtw_free_network_nolock, and rename _rtw_free_network_nolock to > rtw_free_network_nolock. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/rtl8188eu/co

Re: [PATCH 08/13] IB/iser: set virt_boundary_mask in the scsi host

2019-06-06 Thread Jason Gunthorpe
On Thu, Jun 06, 2019 at 08:24:41AM +0200, Christoph Hellwig wrote: > On Wed, Jun 05, 2019 at 05:22:35PM -0300, Jason Gunthorpe wrote: > > On Wed, Jun 05, 2019 at 09:08:31PM +0200, Christoph Hellwig wrote: > > > This ensures all proper DMA layer handling is taken care of by the > > > SCSI midlayer.

Re: [PATCH v3 1/4] coresight: tmc-etr: Do not call smp_processor_id() from preemptible

2019-06-06 Thread Suzuki K Poulose
On 03/06/2019 20:29, Mathieu Poirier wrote: On Thu, May 30, 2019 at 05:54:24PM +0100, Suzuki K Poulose wrote: Instead of using smp_processor_id() to figure out the node, use the numa_node_id() for the current CPU node to avoid splats like : I was in the process of applying this set when I n

Re: [PATCH v3 1/4] staging: rtl8712: Fixed CamelCase for EepromAddressSize and removed unused variable

2019-06-06 Thread Greg KH
On Tue, Jun 04, 2019 at 09:51:33AM +0530, Deepak Mishra wrote: > This patch renames CamelCase EepromAddressSizefrom to eeprom_address_size in > struct _adapter and in related files drv_types.h, rtl871x_eeprom.c, usb_intf.c > > CHECK: Avoid CamelCase: > > This patch removed unused variable ImrCon

Re: [PATCH v3 2/4] staging: rtl8712: Fixed CamelCase cmdThread rename to cmd_thread

2019-06-06 Thread Greg KH
On Tue, Jun 04, 2019 at 09:51:34AM +0530, Deepak Mishra wrote: > This patch renames CamelCase cmdThread to cmd_thread in struct _adapter and > related > files drv_types.h,os_intfs.c > CHECK: Avoid CamelCase: What is this "CHECK:" line from? thanks, greg k-h

Re: [PATCH v3 4/4] staging: rtl8712: Fixed CamelCase wkFilterRxFF0 and lockRxFF0Filter

2019-06-06 Thread Greg KH
On Tue, Jun 04, 2019 at 09:51:36AM +0530, Deepak Mishra wrote: > This patch renames CamelCase variable wkFilterRxFF0 to wk_filter_rx_ff0 > in drv_types.h and related files rtl871x_xmit.c and xmit_linux.c as > reported by checkpatch.pl > > This patch renames CamelCase variable lockRxFF0Filter to lo

Re: [PATCH] staging: rtl8723bs: CleanUp to remove the error reported by checkpatch

2019-06-06 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2019 at 06:59:52PM -0700, Shobhit Kukreti wrote: > Cleaned up the code to remove the error "(foo*)" should be "(foo *)" > reported by checkpatch from the file rtl8723bs/os_dep/ioctl_linux.c Your subject line shoudl give a hint as to what the error you are fixing is. Also, no need

Re: [PATCH 4.19 208/276] x86/ia32: Fix ia32_restore_sigcontext() AC leak

2019-06-06 Thread Pavel Machek
Hi! (stable removed from cc). > [ Upstream commit 67a0514afdbb8b2fc70b771b8c77661a9cb9d3a9 ] > > Objtool spotted that we call native_load_gs_index() with AC set. > Re-arrange the code to avoid that. Does this introduce undefined behaviour? > > @@ -72,6 +71,7 @@ static int ia32_restore_sigconte

[PATCH][next] ixgbe: fix potential u32 overflow on shift

2019-06-06 Thread Colin King
From: Colin Ian King The u32 variable rem is being shifted using u32 arithmetic however it is being passed to div_u64 that expects the expression to be a u64. The 32 bit shift may potentially overflow, so cast rem to a u64 before shifting to avoid this. Addresses-Coverity: ("Unintentional intege

Re: [PATCH 4.19 189/276] iio: adc: ti-ads7950: Fix improper use of mlock

2019-06-06 Thread Pavel Machek
(stable removed from cc list) > Indio->mlock is used for protecting the different iio device modes. > It is currently not being used in this way. Replace the lock with > an internal lock specifically used for protecting the SPI transfer > buffer. > > Signed-off-by: Justin Chen > Signed-off-by: J

Re: KASAN: use-after-free Read in unregister_shrinker

2019-06-06 Thread J. Bruce Fields
On Thu, Jun 06, 2019 at 10:47:43AM +0300, Kirill Tkhai wrote: > This may be connected with that shrinker unregistering is forgotten on error > path. I was wondering about that too. Seems like it would be hard to hit reproduceably though: one of the later allocations would have to fail, then late

Re: [PATCH 4.19 163/276] mmc: core: make pwrseq_emmc (partially) support sleepy GPIO controllers

2019-06-06 Thread Pavel Machek
Hi! (stable removed from cc list) > static void mmc_pwrseq_emmc_reset(struct mmc_host *host) > { > struct mmc_pwrseq_emmc *pwrseq = to_pwrseq_emmc(host->pwrseq); > > - __mmc_pwrseq_emmc_reset(pwrseq); > + gpiod_set_value_cansleep(pwrseq->reset_gpio, 1); > + udelay(1); > +

Re: [git pull] habanalabs fixes for 5.2-rc4/5

2019-06-06 Thread Greg KH
On Thu, Jun 06, 2019 at 10:32:16AM +0300, Oded Gabbay wrote: > Hi Greg, > > This is a pull request containing fixes to be merged to 5.2-rc4/5. > > It contains 3 bug fixes. See the tag comment for more details. > > Thanks, > Oded > > The following changes since commit 8aa75b72e3e6f0f566cd963606e

Linux 4.9.180 build fails with gcc 9 and 'cleanup_module' specifies less restrictive attribute than its target …

2019-06-06 Thread Rolf Eike Beer
I have at least these 2 instances: In file included from /tmp/e2/build/linux-4.9.180/include/drm/drm_vma_manager.h:28, from /tmp/e2/build/linux-4.9.180/include/drm/drmP.h:78, from /tmp/e2/build/linux-4.9.180/include/drm/drm_modeset_helper.h:26,

Re: [PATCH v12 1/5] can: m_can: Create a m_can platform framework

2019-06-06 Thread Dan Murphy
Marc Bump On 5/31/19 6:51 AM, Dan Murphy wrote: Marc On 5/15/19 3:54 PM, Dan Murphy wrote: Marc On 5/9/19 11:11 AM, Dan Murphy wrote: Create a m_can platform framework that peripheral devices can register to and use common code and register sets. The peripheral devices may provide read/writ

[PATCH RFC tip/core/rcu] Restore barrier() to rcu_read_lock() and rcu_read_unlock()

2019-06-06 Thread Paul E. McKenney
Commit bb73c52bad36 ("rcu: Don't disable preemption for Tiny and Tree RCU readers") removed the barrier() calls from rcu_read_lock() and rcu_write_lock() in CONFIG_PREEMPT=n&&CONFIG_PREEMPT_COUNT=n kernels. Within RCU, this commit was OK, but it failed to account for things like get_user() that can

Re: [alsa-devel] [PATCH v2] ASoC: msm8916-wcd-digital: Add sidetone support

2019-06-06 Thread Amadeusz Sławiński
On Thu, 6 Jun 2019 13:42:42 +0100 Srinivas Kandagatla wrote: > This patch adds sidetone support via one of the 3 RX Mix paths > using IIR1 and IIR2. > IIR1 can be feed by any Decimators or RX paths, and IIRx can also be > looped back to RX mixers to provide sidetone functionality. > Two IIR filt

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-06 Thread Andre Przywara
On Mon, 3 Jun 2019 09:32:42 -0700 Florian Fainelli wrote: Hi, > On 6/3/19 1:30 AM, peng@nxp.com wrote: > > From: Peng Fan > > > > This mailbox driver implements a mailbox which signals transmitted data > > via an ARM smc (secure monitor call) instruction. The mailbox receiver > > is implem

RE: [PATCH -mm 0/1] signal: simplify set_user_sigmask/restore_user_sigmask

2019-06-06 Thread David Laight
From: Oleg Nesterov > Sent: 06 June 2019 13:41 > On 06/06, David Laight wrote: > > > > Some of this code is hard to grep through :-) > > I'd suggest to simply read the kernel code once and memorise it, after > that you will not need to use grep. Unfortunately all the available buffer space is ful

Re: [PATCH v3 net-next 0/7] net: ethernet: ti: cpsw: Add XDP support

2019-06-06 Thread Ivan Khoronzhuk
On Thu, Jun 06, 2019 at 10:08:50AM +0200, Jesper Dangaard Brouer wrote: On Wed, 05 Jun 2019 12:14:50 -0700 (PDT) David Miller wrote: From: Ivan Khoronzhuk Date: Wed, 5 Jun 2019 16:20:02 +0300 > This patchset adds XDP support for TI cpsw driver and base it on > page_pool allocator. It was ve

Re: [PATCH v8 2/3] media: meson: add v4l2 m2m video decoder driver

2019-06-06 Thread Maxime Jourdan
Hi Hans, On Thu, Jun 6, 2019 at 2:32 PM Hans Verkuil wrote: > > While preparing this series for merging I came across the following checkpatch > and sparse warnings: > > checkpatch: > > CHECK: Alignment should match open parenthesis > #159: FILE: drivers/staging/media/meson/vdec/codec_mpeg12.c:83:

Re: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver

2019-06-06 Thread Greg KH
On Sat, May 25, 2019 at 12:37:15PM +0100, Dragan Cvetic wrote: > Implements an platform driver that matches with xlnx, > sd-fec-1.1 device tree node and registers as a character > device, including: > - SD-FEC driver binds to sdfec DT node. > - creates and initialise an initial driver dev structure

Re: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-06-06 Thread Greg KH
On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote: > Add char device interface per DT node present and support > file operations: > - open(), > - close(), > - unlocked_ioctl(), > - compat_ioctl(). > > Tested-by: Dragan Cvetic > Signed-off-by: Derek Kiernan > Signed-off-by: Dragan Cve

Re: [PATCH 3/3] livepatch: Use static buffer for debugging messages under rq lock

2019-06-06 Thread Petr Mladek
On Fri 2019-05-31 14:39:08, Josh Poimboeuf wrote: > On Fri, May 31, 2019 at 09:41:47AM +0200, Petr Mladek wrote: > > The err_buf array uses 128 bytes of stack space. Move it off the stack > > by making it static. It's safe to use a shared buffer because > > klp_try_switch_task() is called under k

Re: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-06-06 Thread Greg KH
On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote: > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr) > +{ > + return 0; > +} > + > +static int xsdfec_dev_release(struct inode *iptr, struct file *fptr) > +{ > + return 0; > +} empty open/close functions are nev

Re: [alsa-devel] [PATCH v2] ASoC: msm8916-wcd-digital: Add sidetone support

2019-06-06 Thread Srinivas Kandagatla
On 06/06/2019 14:24, Amadeusz Sławiński wrote: + SOC_SINGLE_SX_TLV("IIR1 INP1 Volume", LPASS_CDC_IIR1_GAIN_B1_CTL, + 0, -84, 40, digital_gain), + SOC_SINGLE_SX_TLV("IIR1 INP2 Volume", LPASS_CDC_IIR1_GAIN_B2_CTL, + 0, -84, 40, digital_ga

Re: [PATCH v2 1/4] perf trace: Exit when build eBPF program failure

2019-06-06 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 06, 2019 at 05:48:42PM +0800, Leo Yan escreveu: > On my Juno board with ARM64 CPUs, perf trace command reports the eBPF > program building failure but the command will not exit and continue to > run. If we define an eBPF event in config file, the event will be > parsed with below flow:

Re: [PATCH 1/2] media: dt-bindings: media: Add r8a77965 DRIF bindings

2019-06-06 Thread Simon Horman
On Tue, Apr 23, 2019 at 12:50:46PM +0200, Simon Horman wrote: > On Tue, Apr 23, 2019 at 07:09:58PM +0900, Nguyen An Hoan wrote: > > From: Hoan Nguyen An > > > > Add r8a77965 DRIF bindings. > > > > Signed-off-by: Hoan Nguyen An > > According to the User's Manual Hardware, v1.50 Nov 20 2019, > t

Re: [PATCH v2 1/4] perf trace: Exit when build eBPF program failure

2019-06-06 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 06, 2019 at 10:30:19AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 06, 2019 at 05:48:42PM +0800, Leo Yan escreveu: > > +++ b/tools/perf/builtin-trace.c > > @@ -3664,6 +3664,14 @@ static int trace__config(const char *var, const char > > *value, void *arg) > >

Re: [PATCH v8 08/13] drivers: memory: add DMC driver for Exynos5422

2019-06-06 Thread Lukasz Luba
On 6/6/19 1:45 PM, Krzysztof Kozlowski wrote: > On Thu, 6 Jun 2019 at 12:38, Lukasz Luba wrote: >> Hi Krzysztof, +/** + * exynos5_dmc_init_clks() - Initialize clocks needed for DMC operation. + * @dmc: DMC structure containing needed fields + * + * Get the needed clo

[GIT PULL] fuse fixes for 5.2-rc4

2019-06-06 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git tags/fuse-fixes-5.2-rc4 This fixes a leaked inode lock in an error cleanup path and a data consistency issue with copy_file_range(). It also adds a new flag for the WRITE request that allows userspace

Re: [PATCH v2 3/4] perf augmented_raw_syscalls: Support arm64 raw syscalls

2019-06-06 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 06, 2019 at 05:48:44PM +0800, Leo Yan escreveu: > This patch adds support for arm64 raw syscall numbers so that we can use > it on arm64 platform. > > After applied this patch, we need to specify macro -D__aarch64__ or > -D__x86_64__ in compilation option so Clang can use the correspon

Re: rcu_read_lock lost its compiler barrier

2019-06-06 Thread Herbert Xu
On Thu, Jun 06, 2019 at 03:58:17AM -0700, Paul E. McKenney wrote: > > I cannot immediately think of a way that the compiler could get this > wrong even in theory, but similar code sequences can be messed up. > The reason for this is that in theory, the compiler could use the > stored-to location as

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-06 Thread Vladimir Oltean
On Thu, 6 Jun 2019 at 06:11, Richard Cochran wrote: > > On Wed, Jun 05, 2019 at 09:08:54PM +0300, Vladimir Oltean wrote: > > Currently I'm using a cyclecounter, but I *will* need actual PHC > > manipulations for the time-based shaping and policing features that > > the switch has in hardware. > >

[PATCH v9 1/3] dt-bindings: media: add Amlogic Video Decoder Bindings

2019-06-06 Thread Maxime Jourdan
Add documentation for the meson vdec dts node. Signed-off-by: Maxime Jourdan Reviewed-by: Rob Herring --- .../bindings/media/amlogic,vdec.txt | 71 +++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/amlogic,vdec.txt diff -

[PATCH v9 2/3] media: meson: add v4l2 m2m video decoder driver

2019-06-06 Thread Maxime Jourdan
Amlogic SoCs feature a powerful video decoder unit able to decode many formats, with a performance of usually up to 4k60. This is a driver for this IP that is based around the v4l2 m2m framework. It features decoding for: - MPEG 1 - MPEG 2 Supported SoCs are: GXBB (S905), GXL (S905X/W/D), GXM (S

[PATCH v9 3/3] MAINTAINERS: Add meson video decoder

2019-06-06 Thread Maxime Jourdan
Add an entry for the meson video decoder for amlogic SoCs. Signed-off-by: Maxime Jourdan --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b8fbf41865c2..7cf3ece9f0cb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10222,6 +10222,14 @@ S:

[PATCH v9 0/3] Add Amlogic video decoder driver

2019-06-06 Thread Maxime Jourdan
Hi everyone, [V7] The Driver was moved to staging until it can pass future specification & compliance tools. [V6] Good news, the firmware situation is resolved. We have received a redistributable license from Amlogic and the firmwares have been merged in linux-firmware[5]. [V5] It's been a while

Re: [PATCH RFC tip/core/rcu] Restore barrier() to rcu_read_lock() and rcu_read_unlock()

2019-06-06 Thread Herbert Xu
On Thu, Jun 06, 2019 at 06:19:33AM -0700, Paul E. McKenney wrote: > Commit bb73c52bad36 ("rcu: Don't disable preemption for Tiny and Tree > RCU readers") removed the barrier() calls from rcu_read_lock() and > rcu_write_lock() in CONFIG_PREEMPT=n&&CONFIG_PREEMPT_COUNT=n kernels. > Within RCU, this c

[GIT PULL] overlayfs fixes for 5.2-rc4

2019-06-06 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git tags/ovl-fixes-5.2-rc4 Here's one fix for a class of bugs triggered by syzcaller, and one that makes xfstests fail less. Thanks, Miklos

Re: KASAN: use-after-free Read in unregister_shrinker

2019-06-06 Thread Kirill Tkhai
On 06.06.2019 16:13, J. Bruce Fields wrote: > On Thu, Jun 06, 2019 at 10:47:43AM +0300, Kirill Tkhai wrote: >> This may be connected with that shrinker unregistering is forgotten on error >> path. > > I was wondering about that too. Seems like it would be hard to hit > reproduceably though: one

Re: [PATCH v2 net-next] net: stmmac: move reset gpio parse & request to stmmac_mdio_register

2019-06-06 Thread Andrew Lunn
On Thu, Jun 06, 2019 at 10:31:56AM +, Jisheng Zhang wrote: > Move the reset gpio dt parse and request to stmmac_mdio_register(), > thus makes the mdio code straightforward. > > This patch also replace stack var mdio_bus_data with data to simplify > the code. Hi Jisheng Please split this into

Re: [PATCH v3] coredump: Split pipe command whitespace before expanding template

2019-06-06 Thread Neil Horman
On Tue, May 28, 2019 at 01:11:42PM +0800, Paul Wise wrote: > Save the offsets of the start of each argument to avoid having to > update pointers to each argument after every corename krealloc and > to avoid having to duplicate the memory for the dump command. > > Executable names containing spaces

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 15:37, Jon Hunter пишет: > > On 06/06/2019 12:54, Peter Ujfalusi wrote: >> >> >> On 06/06/2019 13.49, Jon Hunter wrote: >>> >>> On 06/06/2019 11:22, Peter Ujfalusi wrote: >>> >>> ... >>> >>> It does sounds like that FIFO_SIZE == src/dst_maxburst in your case as >>> well. >>

Re: [PATCH v2 3/4] perf augmented_raw_syscalls: Support arm64 raw syscalls

2019-06-06 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 06, 2019 at 10:38:38AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 06, 2019 at 05:48:44PM +0800, Leo Yan escreveu: > > This patch adds support for arm64 raw syscall numbers so that we can use > > it on arm64 platform. > > > > After applied this patch, we need to specify mac

Re: rcu_read_lock lost its compiler barrier

2019-06-06 Thread Paul E. McKenney
On Thu, Jun 06, 2019 at 09:38:24PM +0800, Herbert Xu wrote: > On Thu, Jun 06, 2019 at 03:58:17AM -0700, Paul E. McKenney wrote: > > > > I cannot immediately think of a way that the compiler could get this > > wrong even in theory, but similar code sequences can be messed up. > > The reason for this

Re: [PATCH RFC tip/core/rcu] Restore barrier() to rcu_read_lock() and rcu_read_unlock()

2019-06-06 Thread Paul E. McKenney
On Thu, Jun 06, 2019 at 09:42:33PM +0800, Herbert Xu wrote: > On Thu, Jun 06, 2019 at 06:19:33AM -0700, Paul E. McKenney wrote: > > Commit bb73c52bad36 ("rcu: Don't disable preemption for Tiny and Tree > > RCU readers") removed the barrier() calls from rcu_read_lock() and > > rcu_write_lock() in CO

KMSAN: uninit-value in r871xu_drv_init

2019-06-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f75e4cfe kmsan: use kmsan_handle_urb() in urb.c git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=153453dea0 kernel config: https://syzkaller.appspot.com/x/.config?x=602468164ccdc30a dashboard link: ht

KASAN: slab-out-of-bounds Read in usage_accumulate

2019-06-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:156c0591 Merge tag 'linux-kselftest-5.2-rc4' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15f2095aa0 kernel config: https://syzkaller.appspot.com/x/.config?x=60564cb52ab29d5b da

[PATCH 2/2] btrfs: convert snapshot/nocow exlcusion to drw lock

2019-06-06 Thread Nikolay Borisov
This patch removes all haphazard code implementing nocow writers exclusion from pending snapshot creation and switches to using the drw lock to ensure this invariant still holds. "Readers" are snapshot creators from create_snapshot and 'writers' are nocow writers from buffered write path or btrfs_s

KASAN: slab-out-of-bounds Read in corrupted (2)

2019-06-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:156c0591 Merge tag 'linux-kselftest-5.2-rc4' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13512d51a0 kernel config: https://syzkaller.appspot.com/x/.config?x=60564cb52ab29d5b da

[PATCH 1/2] btrfs: Implement DRW lock

2019-06-06 Thread Nikolay Borisov
A (D)ouble (R)eader (W)riter lock is a locking primitive that allows to have multiple readers or multiple writers but not multiple readers and writers holding it concurrently. The code is factored out from the existing open-coded locking scheme used to exclude pending snapshots from nocow writers a

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 16:45, Dmitry Osipenko пишет: > 06.06.2019 15:37, Jon Hunter пишет: >> >> On 06/06/2019 12:54, Peter Ujfalusi wrote: >>> >>> >>> On 06/06/2019 13.49, Jon Hunter wrote: On 06/06/2019 11:22, Peter Ujfalusi wrote: ... It does sounds like that FIFO_SIZE == s

Re: [PATCH V1] i2c: busses: tegra: Add suspend-resume support

2019-06-06 Thread Bitan Biswas
On 6/6/19 4:52 AM, Dmitry Osipenko wrote: 06.06.2019 8:43, Bitan Biswas пишет: On 5/31/19 5:43 AM, Dmitry Osipenko wrote: 31.05.2019 11:50, Bitan Biswas пишет: On 5/30/19 4:27 AM, Dmitry Osipenko wrote: 30.05.2019 8:55, Bitan Biswas пишет: Post suspend I2C registers have power on rese

Re: [PATCH v2 1/4] perf trace: Exit when build eBPF program failure

2019-06-06 Thread Leo Yan
Hi Arnaldo, On Thu, Jun 06, 2019 at 10:30:19AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 06, 2019 at 05:48:42PM +0800, Leo Yan escreveu: > > On my Juno board with ARM64 CPUs, perf trace command reports the eBPF > > program building failure but the command will not exit and continue to >

Re: [PATCH v8 00/13] Exynos5 Dynamic Memory Controller driver

2019-06-06 Thread Sylwester Nawrocki
On 6/5/19 18:53, Lukasz Luba wrote: > Lukasz Luba (13): > clk: samsung: add needed IDs for DMC clocks in Exynos5420 > clk: samsung: add new clocks for DMC for Exynos5422 SoC > clk: samsung: add BPLL rate table for Exynos 5422 SoC > dt-bindings: ddr: rename lpddr2 directory > dt-bindings:

[PATCH] powerpc/cacheflush: fix variable set but not used

2019-06-06 Thread Qian Cai
The powerpc's flush_cache_vmap() is defined as a macro and never use both of its arguments, so it will generate a compilation warning, lib/ioremap.c: In function 'ioremap_page_range': lib/ioremap.c:203:16: warning: variable 'start' set but not used [-Wunused-but-set-variable] Fix it by making it

Re: [PATCH V2] i2c: busses: tegra: Add suspend-resume support

2019-06-06 Thread Bitan Biswas
On 6/6/19 5:06 AM, Dmitry Osipenko wrote: 06.06.2019 8:54, Bitan Biswas пишет: Post suspend I2C registers have power on reset values. Before any transfer initialize I2C registers to prevent I2C transfer timeout and implement suspend and resume callbacks needed. Fix below errors post suspend:

[PATCH v2 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-06 Thread Vitor Soares
Currently the I3C framework limits SCL frequency to FM speed when dealing with a mixed slow bus, even if all I2C devices are FM+ capable. The core was also not accounting for I3C speed limitations when operating in mixed slow mode and was erroneously using FM+ speed as the max I2C speed when opera

[PATCH v2 3/3] i3c: dw: add limited bus mode support

2019-06-06 Thread Vitor Soares
This patch add limited bus mode support for DesignWare i3c master Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: --- Changes in v2: None drivers/i3c/master/dw-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3

[PATCH v2 2/3] i3c: add mixed limited bus mode

2019-06-06 Thread Vitor Soares
The i3c bus spec defines a bus configuration where i2c devices don't have a 50ns filter but support SCL running at SDR max rate (12.5MHz). This patch introduces the limited bus mode so that users can use a higher speed in presence of i2c devices index 1. Signed-off-by: Vitor Soares Cc: Boris Bre

Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-06 Thread Adrian Hunter
On 3/06/19 9:37 PM, Douglas Anderson wrote: > There are certain cases, notably when transitioning between sleep and > active state, when Broadcom SDIO WiFi cards will produce errors on the > SDIO bus. This is evident from the source code where you can see that > we try commands in a loop until we

Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Bitan Biswas
On 6/6/19 4:39 AM, Dmitry Osipenko wrote: 06.06.2019 10:35, Bitan Biswas пишет: Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. Replace BUG() with error handling code. Define I2C_ERR_UNEXPECTED_STATUS for err

Re: [PATCH 1/5] mm/hmm: Update HMM documentation

2019-06-06 Thread Jason Gunthorpe
On Mon, May 06, 2019 at 04:29:38PM -0700, rcampb...@nvidia.com wrote: > From: Ralph Campbell > > Update the HMM documentation to reflect the latest API and make a few minor > wording changes. > > Signed-off-by: Ralph Campbell > Reviewed-by: Jérôme Glisse > Cc: John Hubbard > Cc: Ira Weiny >

Re: [PATCH v2 3/4] perf augmented_raw_syscalls: Support arm64 raw syscalls

2019-06-06 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 06, 2019 at 10:46:24AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 06, 2019 at 10:38:38AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Jun 06, 2019 at 05:48:44PM +0800, Leo Yan escreveu: > > > This patch adds support for arm64 raw syscall numbers so that we can use

Re: [RFC][PATCH 00/10] Mount, FS, Block and Keyrings notifications [ver #3]

2019-06-06 Thread Stephen Smalley
On 6/6/19 9:16 AM, David Howells wrote: Stephen Smalley wrote: This might be easier to discuss if you can reply to: https://lore.kernel.org/lkml/5393.1559768...@warthog.procyon.org.uk/ which is on the ver #2 posting of this patchset. Sorry for being late to the party. Not sure whet

Re: [PATCH v2 4/4] perf augmented_raw_syscalls: Document clang configuration

2019-06-06 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 06, 2019 at 05:48:45PM +0800, Leo Yan escreveu: > To build this program successfully with clang, there have three > compiler options need to be specified: > > - Header file path: tools/perf/include/bpf; > - Specify architecture; > - Define macro __NR_CPUS__. So, this shouldn't b

<    1   2   3   4   5   6   7   8   9   10   >