Re: [PATCH bpf v3] libbpf: Return btf_fd for load_sk_storage_btf

2019-05-29 Thread Andrii Nakryiko
On Wed, May 29, 2019 at 9:35 AM Michal Rostecki wrote: > > Before this change, function load_sk_storage_btf expected that > libbpf__probe_raw_btf was returning a BTF descriptor, but in fact it was > returning an information about whether the probe was successful (0 or > 1). load_sk_storage_btf was

[PATCH] soc: aspeed: lpc-ctrl: make parameter optional

2019-05-29 Thread Vijay Khemka
Makiing memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka --- drivers/soc/aspeed/aspeed-lpc-ctrl.c | 58 +--- 1 file changed, 36 insertions(+), 22

Re: [PATCH] misc: aspeed-lpc-ctrl: make parameter optional

2019-05-29 Thread Vijay Khemka
On 5/24/19, 8:59 AM, "Greg Kroah-Hartman" wrote: On Wed, May 01, 2019 at 03:34:11PM -0700, Vijay Khemka wrote: > Makiing memory-region and flash as optional parameter in device > tree if user needs to use these parameter through ioctl then > need to define in devicetree. >

Re: [RFT PATCH v5 3/5] cpu-topology: Move cpu topology code to common code.

2019-05-29 Thread Atish Patra
On 5/29/19 3:48 AM, Sudeep Holla wrote: On Thu, May 23, 2019 at 05:06:50PM -0700, Atish Patra wrote: Both RISC-V & ARM64 are using cpu-map device tree to describe their cpu topology. It's better to move the relevant code to a common place instead of duplicate code. I couldn't test this on any

Re: Testing the recent RISC-V DT patchsets

2019-05-29 Thread Troy Benjegerdes
> On May 29, 2019, at 5:04 AM, Loys Ollivier wrote: > > On Wed 29 May 2019 at 00:50, Atish Patra wrote: > >> On 5/28/19 8:36 AM, Karsten Merker wrote: >>> On Tue, May 28, 2019 at 05:10:42PM +0200, Loys Ollivier wrote: On Tue 28 May 2019 at 01:32, Paul Walmsley wrote: >

Re: Oops caused by race between livepatch and ftrace

2019-05-29 Thread Jessica Yu
+++ Josh Poimboeuf [21/05/19 11:42 -0500]: On Tue, May 21, 2019 at 10:42:04AM -0400, Steven Rostedt wrote: On Tue, 21 May 2019 09:16:29 -0500 Josh Poimboeuf wrote: > > Hmm, this may blow up with lockdep, as I believe we already have a > > locking dependency of: > > > > text_mutex -> ftrace_lo

Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
On Wed, 29 May 2019, Josh Poimboeuf wrote: > I still have the question about whether we could make mwait_play_dead() > monitor a fixed address. If we could get that to work, that seems more > robust to me. Hmm, does it really? That'd mean the resumer and resumee must have the same fixmap. How

Re: kernel BUG at mm/swap_state.c:170!

2019-05-29 Thread Mikhail Gavrilov
On Wed, 29 May 2019 at 09:05, Mikhail Gavrilov wrote: > > Hi folks. > I am observed kernel panic after update to git tag 5.2-rc2. > This crash happens at memory pressing when swap being used. > > Unfortunately in journalctl saved only this: > Now I captured better trace. : page:d6d34dff

Re: [PATCH] platform/x86: asus-wmi: Only Tell EC the OS will handle display hotkeys from asus_nb_wmi

2019-05-29 Thread João Paulo Rechi Vita
On Wed, May 29, 2019 at 1:55 AM Hans de Goede wrote: > > Hi João, > > On 5/28/19 11:22 PM, João Paulo Rechi Vita wrote: > > On Mon, May 20, 2019 at 11:28 PM Hans de Goede wrote: > >> > >> Commit 78f3ac76d9e5 ("platform/x86: asus-wmi: Tell the EC the OS will > >> handle the display off hotkey") ca

Re: Oops caused by race between livepatch and ftrace

2019-05-29 Thread Josh Poimboeuf
On Wed, May 29, 2019 at 07:29:04PM +0200, Jessica Yu wrote: > +++ Josh Poimboeuf [21/05/19 11:42 -0500]: > > On Tue, May 21, 2019 at 10:42:04AM -0400, Steven Rostedt wrote: > > > On Tue, 21 May 2019 09:16:29 -0500 > > > Josh Poimboeuf wrote: > > > > > > > > Hmm, this may blow up with lockdep, as

Re: [PATCH] ptrace: restore smp_rmb() in __ptrace_may_access()

2019-05-29 Thread Jann Horn
On Wed, May 29, 2019 at 6:21 PM Oleg Nesterov wrote: > On 05/29, Jann Horn wrote: > > (I have no clue whatsoever what the relevant tree for this is, but I > > guess Oleg is the relevant maintainer?) > > we usually route ptrace changes via -mm tree, plus I lost my account on korg. > > > --- a/kerne

RE: [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio support

2019-05-29 Thread Voon, Weifeng
> > +static void stmmac_mdio_c45_setup(struct stmmac_priv *priv, int phyreg, > > + u32 *val, u32 *data) > > +{ > > + unsigned int reg_shift = priv->hw->mii.reg_shift; > > + unsigned int reg_mask = priv->hw->mii.reg_mask; > > Reverse christmas tree here. You also sho

Re: [PATCH] mm/slab_common.c: fix possible spectre-v1 in kmalloc_slab()

2019-05-29 Thread Michal Hocko
On Thu 30-05-19 00:39:53, Dianzhang Chen wrote: > It's come from `192+1`. > > > The more code fragment is: > > > if (size <= 192) { > > if (!size) > > return ZERO_SIZE_PTR; > > size = array_index_nospec(size, 193); > > index = size_index[size_index_elem(size)]; > > } O

Re: [PATCH 14/21] EDAC, ghes: Extract numa node information for each dimm

2019-05-29 Thread James Morse
Hi Robert, On 29/05/2019 09:44, Robert Richter wrote: > In a later patch we want to have one mc device per node. This patch > extracts the numa node information for each dimm. This is done by > collecting the physical address ranges from the DMI table (Memory > Array Mapped Address - Type 19 of SM

Re: ERROR: "hdac_hdmi_jack_port_init" [sound/soc/intel/boards/snd-soc-sof_rt5682.ko] undefined!

2019-05-29 Thread Randy Dunlap
On 5/28/19 2:54 AM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: cd6c84d8f0cdc911df435bb075ba22ce3c605b07 > commit: f70abd75b7c6c04d3219d0b3a0f3f15411b042fb ASoC: Intel: add sof-rt5682 > machine driver > date: 4 weeks a

[Patch v2] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL

2019-05-29 Thread Hariprasad Kelam
dont acquire lock before calling wd719x_chip_init. Issue identified by coccicheck Signed-off-by: Hariprasad Kelam - changes in v1: Replace GFP_KERNEL with GFP_ATOMIC. changes in v2: Call wd719x_chip_init without lock as suggested in review --- drivers/scsi/wd719x.c | 3

RE: [PATCH net-next v4 5/5] net: stmmac: add EHL SGMII 1Gbps PCI info and PCI ID

2019-05-29 Thread Voon, Weifeng
> > > + plat->axi->axi_lpi_en = 0; > > + plat->axi->axi_xit_frm = 0; > > + plat->axi->axi_wr_osr_lmt = 0; > > This is not a valid value. Can you please explained why is not a valid value? And what should be the recommended value? Databook mentioned that "Maximum outstanding requests = WR_

[PATCH] drivers/media/dvb-frontends: Implement probe/remove for stv090x

2019-05-29 Thread Tobias Klausmann
Move common code into a new function. This provides the needed functionality to use dvb_module_probe() instead of dvb_attach()! Signed-off-by: Tobias Klausmann --- drivers/media/dvb-frontends/stv090x.c | 198 +++-- drivers/media/dvb-frontends/stv090x.h | 3 + drivers

RE: [PATCH net-next v3 0/5] net: stmmac: enable EHL SGMII

2019-05-29 Thread Voon, Weifeng
> > > Did you rebase this series against latest net-next tree ? > > > > > > Because you are missing MMC module in your HWIF table entry. This > > > module was recently added with the addition of selftests. > > > > No, the base is on last Thursday. Let me rebased on the latest net-next and > submit

Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

2019-05-29 Thread Jiri Kosina
On Wed, 29 May 2019, Jiri Kosina wrote: > The target kernel only onlines the CPUs which were online at the time of > hibernation (and are therefore in frozen_cpus mask). Hm, there is a catch though. After resume, the SMT siblings are now in hlt instead of mwait. Which means that the resumed ke

Re: [PATCH v2] mm: add account_locked_vm utility function

2019-05-29 Thread Ira Weiny
On Fri, May 24, 2019 at 01:50:45PM -0400, Daniel Jordan wrote: [snip] > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 0e8834ac32b7..72c1034d2ec7 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1564,6 +1564,25 @@ long get_user_pages_unlocked(unsigned long start,

Re: [PATCH, RFC 43/62] syscall/x86: Wire up a system call for MKTME encryption keys

2019-05-29 Thread Alison Schofield
On Wed, May 29, 2019 at 10:21:37AM +0300, Mike Rapoport wrote: > On Wed, May 08, 2019 at 05:44:03PM +0300, Kirill A. Shutemov wrote: > > From: Alison Schofield > > > > encrypt_mprotect() is a new system call to support memory encryption. > > > > It takes the same parameters as legacy mprotect, p

Re: [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support

2019-05-29 Thread Martin Blumenstingl
On Wed, May 29, 2019 at 12:25 PM Neil Armstrong wrote: > > On 27/05/2019 20:36, Martin Blumenstingl wrote: > > On Mon, May 27, 2019 at 3:22 PM Neil Armstrong > > wrote: > >> > >> From: Christian Hewitt > >> > >> - Remove serial1 alias > >> - Add support for uart_A rts/cts > >> - Add bluetooth u

Re: kernel BUG at mm/swap_state.c:170!

2019-05-29 Thread Michal Hocko
On Wed 29-05-19 22:32:08, Mikhail Gavrilov wrote: > On Wed, 29 May 2019 at 09:05, Mikhail Gavrilov > wrote: > > > > Hi folks. > > I am observed kernel panic after update to git tag 5.2-rc2. > > This crash happens at memory pressing when swap being used. > > > > Unfortunately in journalctl saved on

Re: [PATCH, RFC 57/62] x86/mktme: Overview of Multi-Key Total Memory Encryption

2019-05-29 Thread Alison Schofield
On Wed, May 29, 2019 at 10:21:48AM +0300, Mike Rapoport wrote: > On Wed, May 08, 2019 at 05:44:17PM +0300, Kirill A. Shutemov wrote: > > From: Alison Schofield > > > > Provide an overview of MKTME on Intel Platforms. > > > > Signed-off-by: Alison Schofield > > Signed-off-by: Kirill A. Shutemov

[PATCH v3 0/8] drivers/soc: Add Aspeed XDMA Engine Driver

2019-05-29 Thread Eddie James
The XDMA engine embedded in the AST2500 SOC performs PCI DMA operations between the SOC (acting as a BMC) and a host processor in a server. This series adds a driver to control the XDMA engine in order to easily perform DMA operations to and from the host processor. Changes since v2: - Switch to

[PATCH v3 2/8] drivers/soc: Add Aspeed XDMA Engine Driver

2019-05-29 Thread Eddie James
The XDMA engine embedded in the AST2500 SOC performs PCI DMA operations between the SOC (acting as a BMC) and a host processor in a server. This commit adds a driver to control the XDMA engine and adds functions to initialize the hardware and memory and start DMA operations. Signed-off-by: Eddie

[PATCH v3 7/8] ARM: dts: aspeed: Add XDMA Engine

2019-05-29 Thread Eddie James
Add a node for the XDMA engine with all the necessary information. Signed-off-by: Eddie James --- arch/arm/boot/dts/aspeed-g5.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index 5b1ca26..bfc8328 100644 --- a/a

[PATCH v3 8/8] ARM: dts: aspeed: witherspoon: Enable XDMA Engine

2019-05-29 Thread Eddie James
Enable the XDMA engine node. Signed-off-by: Eddie James --- arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts index 85b9e40..ad7ccf1 100644

[PATCH v3 4/8] Documentation: ABI: Add aspeed-xdma sysfs documentation

2019-05-29 Thread Eddie James
Document the pcidev sysfs attribute used by the aspeed-xdma driver. Signed-off-by: Eddie James --- Documentation/ABI/testing/sysfs-devices-platform-aspeed-xdma | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-devices-platform-aspeed-xdma dif

[PATCH v3 3/8] drivers/soc: xdma: Add user interface

2019-05-29 Thread Eddie James
This commits adds a miscdevice to provide a user interface to the XDMA engine. The interface provides the write operation to start DMA operations. The DMA parameters are passed as the data to the write call. The actual data to transfer is NOT passed through write. Note that both directions of DMA o

[PATCH v3 5/8] drivers/soc: xdma: Add PCI device configuration sysfs

2019-05-29 Thread Eddie James
The AST2500 has two PCI devices embedded. The XDMA engine can use either device to perform DMA transfers. Users need the capability to choose which device to use. This commit therefore adds two sysfs files that toggle the AST2500 and XDMA engine between the two PCI devices. Signed-off-by: Eddie Ja

[PATCH v3 6/8] drivers/soc: xdma: Add debugfs entries

2019-05-29 Thread Eddie James
Add debugfs entries for the relevant XDMA engine registers and for dumping the AST2500 reserved memory space. Signed-off-by: Eddie James --- drivers/soc/aspeed/aspeed-xdma.c | 94 1 file changed, 94 insertions(+) diff --git a/drivers/soc/aspeed/aspeed-xd

[PATCH v3 1/8] dt-bindings: soc: Add Aspeed XDMA engine binding documentation

2019-05-29 Thread Eddie James
Document the bindings. Signed-off-by: Eddie James --- .../devicetree/bindings/soc/aspeed/xdma.txt| 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/xdma.txt diff --git a/Documentation/devicetree/bindings/soc/asp

Re: [RFC PATCH v3] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-29 Thread Daniel Drake
Hi Chris, On Tue, May 28, 2019 at 11:03 PM Chris Chiu wrote: > + /* > +* Single virtual interface permitted since the driver supports > STATION > +* mode only. I think you can be a bit more explicit by saying e.g.: Only one virtual interface permitted because only STA mod

Re: [PATCH v4 3/3] arm64: dts: meson: Add minimal support for Odroid-N2

2019-05-29 Thread Martin Blumenstingl
Hi Neil, On Wed, May 29, 2019 at 12:09 PM Neil Armstrong wrote: > > On 27/05/2019 16:02, Neil Armstrong wrote: > > This patch adds basic support for : > > - Amlogic G12B, which is very similar to G12A > > - The HardKernel Odroid-N2 based on the S922X SoC > > > > The Amlogic G12B SoC is very simil

Re: [PATCH V2 02/12] pinctrl: tegra: add suspend and resume support

2019-05-29 Thread Sowjanya Komatineni
On 5/29/19 8:29 AM, Dmitry Osipenko wrote: 29.05.2019 2:08, Sowjanya Komatineni пишет: This patch adds suspend and resume support for Tegra pinctrl driver and registers them to syscore so the pinmux settings are restored before the devices resume. Signed-off-by: Sowjanya Komatineni --- dri

Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-05-29 Thread Jagan Teki
On Wed, May 29, 2019 at 8:24 PM Maxime Ripard wrote: > > On Fri, May 24, 2019 at 03:48:51PM +0530, Jagan Teki wrote: > > On Fri, May 24, 2019 at 2:04 AM Maxime Ripard > > wrote: > > > > > > On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan Teki wrote: > > > > According to "DRM kernel-internal disp

Re: [PATCH 3/4] staging: kpc2000: add missing spaces in core.c

2019-05-29 Thread Dan Carpenter
On Wed, May 29, 2019 at 05:54:19PM +0200, Simon Sandström wrote: > On Mon, May 27, 2019 at 10:31:59AM +0300, Dan Carpenter wrote: > > On Fri, May 24, 2019 at 01:08:01PM +0200, Simon Sandström wrote: > > > [..] > > > - ret = copy_to_user((void*)ioctl_param, (void*)&temp, > > > sizeof(temp))

Re: [PATCH, RFC 00/62] Intel MKTME enabling

2019-05-29 Thread Alison Schofield
On Wed, May 29, 2019 at 10:30:07AM +0300, Mike Rapoport wrote: > On Wed, May 08, 2019 at 05:43:20PM +0300, Kirill A. Shutemov wrote: > > = Intro = > > > > The patchset brings enabling of Intel Multi-Key Total Memory Encryption. > > It consists of changes into multiple subsystems: > > > > * Core

Re: [PATCH] time/tick-broadcast: Fix tick_broadcast_offline() lockdep complaint

2019-05-29 Thread Paul E. McKenney
On Tue, May 28, 2019 at 01:07:29PM -0700, Thomas Gleixner wrote: > On Mon, 27 May 2019, Paul E. McKenney wrote: > > > The TASKS03 and TREE04 rcutorture scenarios produce the following > > lockdep complaint: > > > > > > WARNING: inconsistent lock state > > 5.2.0-rc

Re: [RFC PATCH v3] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-05-29 Thread Larry Finger
On 5/29/19 12:03 AM, Chris Chiu wrote: We have 3 laptops which connect the wifi by the same RTL8723BU. The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. They have the same problem with the in-kernel rtl8xxxu driver, the iperf (as a client to an ethernet-connected server) gets ~1Mb

[PATCH] arm: vdso: pass --be8 to linker if necessary

2019-05-29 Thread Jason A. Donenfeld
The commit fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to link VDSO") removed the passing of CFLAGS, since ld doesn't take those directly. However, prior, big-endian ARM was relying on gcc to translate its -mbe8 option into ld's --be8 option. Lacking this, ld generated be32 code, m

Re: [RFC 2/3] preempt_tracer: Disable IRQ while starting/stopping due to a preempt_counter change

2019-05-29 Thread Peter Zijlstra
On Wed, May 29, 2019 at 03:51:31PM +0200, Daniel Bristot de Oliveira wrote: > On 29/05/2019 12:20, Peter Zijlstra wrote: > > I'm not sure I follow, IRQs disabled fully implies !preemptible. I don't > > see how the model would be more pessimistic than reality if it were to > > use this knowledge. >

Re: pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask())

2019-05-29 Thread Deepa Dinamani
On Wed, May 29, 2019 at 9:12 AM Oleg Nesterov wrote: > > Al, Linus, Eric, please help. > > The previous discussion was very confusing, we simply can not understand each > other. > > To me everything looks very simple and clear, but perhaps I missed something > obvious? Please correct me. > > I thi

[PATCH bpf v4] libbpf: Return btf_fd for load_sk_storage_btf

2019-05-29 Thread Michal Rostecki
Before this change, function load_sk_storage_btf expected that libbpf__probe_raw_btf was returning a BTF descriptor, but in fact it was returning an information about whether the probe was successful (0 or 1). load_sk_storage_btf was using that value as an argument of the close function, which was

Re: [PATCH] usb: dwc2: Fix DMA cache alignment issues

2019-05-29 Thread Doug Anderson
Hi, On Sun, Feb 17, 2019 at 10:37 PM Martin Schiller wrote: > > Insert a padding between data and the stored_xfer_buffer pointer to > ensure they are not on the same cache line. > > Otherwise, the stored_xfer_buffer gets corrupted for IN URBs on > non-cache-coherent systems. (In my case: Lantiq x

Re: Oops caused by race between livepatch and ftrace

2019-05-29 Thread Jessica Yu
+++ Josh Poimboeuf [29/05/19 12:39 -0500]: On Wed, May 29, 2019 at 07:29:04PM +0200, Jessica Yu wrote: +++ Josh Poimboeuf [21/05/19 11:42 -0500]: > On Tue, May 21, 2019 at 10:42:04AM -0400, Steven Rostedt wrote: > > On Tue, 21 May 2019 09:16:29 -0500 > > Josh Poimboeuf wrote: > > > > > > Hmm, t

Re: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-05-29 Thread Kees Cook
On Wed, May 29, 2019 at 10:13:43AM +, Reshetova, Elena wrote: > Not sure about ideal params for the whole combination here since security > and performance are basically conflicting with each other (as usual). > So, that's why I was trying to propose to have two version of this: > - one with t

Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()

2019-05-29 Thread Nathan Chancellor
rks. Let me know if you need anythnig from me. Cheers, Nathan git bisect start # good: [9fb67d643f6f1892a08ee3a04ea54022d1060bb0] Merge tag 'pinctrl-v5.2-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl git bisect good 9fb67d643f6f1892a08ee3a04ea54022d1060bb0 # b

Re: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-05-29 Thread Kees Cook
On Wed, May 29, 2019 at 10:13:43AM +, Reshetova, Elena wrote: > On related note: the current prng we have in kernel (prandom) is based on a > *very old* style of prngs, which is basically 4 linear LFSRs xored together. > Nowadays, we have much more powerful prngs that show much better > statis

Re: [PATCH v5] mfd: cros_ec_dev: Register cros_ec_accel_legacy driver as a subdevice

2019-05-29 Thread Gwendal Grignou
On Wed, May 29, 2019 at 4:44 AM Lee Jones wrote: > > On Tue, 28 May 2019, Gwendal Grignou wrote: > > > On Mon, Apr 1, 2019 at 8:46 PM Lee Jones wrote: > > > > > > On Wed, 27 Feb 2019, Gwendal Grignou wrote: > > > > > > > From: Enric Balletbo i Serra > > > > > > > > With this patch, the cros_ec_c

Re: [PATCH v2] mm: add account_locked_vm utility function

2019-05-29 Thread Daniel Jordan
On Wed, May 29, 2019 at 11:05:48AM -0700, Ira Weiny wrote: > On Fri, May 24, 2019 at 01:50:45PM -0400, Daniel Jordan wrote: > > +static inline int account_locked_vm(struct mm_struct *mm, unsigned long > > pages, > > + bool inc) > > +{ > > + int ret; > > + > > + if

Re: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()

2019-05-29 Thread Deepa Dinamani
On Wed, May 29, 2019 at 9:57 AM Oleg Nesterov wrote: > > On 05/28, Deepa Dinamani wrote: > > > > I agree that signal handller being called and return value not being > > altered is an issue with other syscalls also. I was just wondering if > > some userspace code assumption would be assuming this.

Re: [PATCH v2] drivers/media/dvb-frontends: Implement probe/remove for stv6110x

2019-05-29 Thread Joe Perches
On Wed, 2019-05-29 at 18:56 +0200, Tobias Klausmann wrote: > Refactor out the common parts of stv6110x_probe() and stv6110x_attach() > into separate functions. > > This provides the needed functionality to use dvb_module_probe() instead > of dvb_attach()! > > v2: > - Impovments based on comments

Re: [PATCH v1] mm: hugetlb: soft-offline: fix wrong return value of soft offline

2019-05-29 Thread Mike Kravetz
On 5/26/19 11:06 PM, Naoya Horiguchi wrote: > Soft offline events for hugetlb pages return -EBUSY when page migration > succeeded and dissolve_free_huge_page() failed, which can happen when > there're surplus hugepages. We should judge pass/fail of soft offline by > checking whether the raw error p

Re: [PATCH AUTOSEL 5.1 004/375] NFS: make nfs_match_client killable

2019-05-29 Thread Sasha Levin
On Thu, May 23, 2019 at 11:02:39AM -0400, Benjamin Coddington wrote: Hi Sasha, if you take this one, you'll need the fix for it: c260121a97a3 ("NFS: Fix a double unlock from nfs_match,get_client") I didn't see this fix go through my inbox for your stable tree, so apologies if maybe I missed i

Re: [PATCH AUTOSEL 5.1 011/375] ip6: fix skb leak in ip6frag_expire_frag_queue()

2019-05-29 Thread Sasha Levin
On Thu, May 23, 2019 at 09:47:23AM +0200, Stefan Bader wrote: On 22.05.19 21:15, Sasha Levin wrote: From: Eric Dumazet [ Upstream commit 47d3d7fdb10a21c223036b58bd70ffdc24a472c4 ] Since ip6frag_expire_frag_queue() now pulls the head skb from frag queue, we should no longer use skb_get(), sinc

Re: pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask())

2019-05-29 Thread Eric Wong
David Laight wrote: > From: Oleg Nesterov > > Sent: 29 May 2019 17:12 > > Al, Linus, Eric, please help. > > > > The previous discussion was very confusing, we simply can not understand > > each > > other. > > > > To me everything looks very simple and clear, but perhaps I missed something > > o

Re: [PATCH AUTOSEL 5.1 025/375] orangefs: truncate before updating size

2019-05-29 Thread Sasha Levin
On Wed, May 22, 2019 at 05:44:37PM -0400, mar...@omnibond.com wrote: I don't think it makes much sense to put this one in stable. Without the rest of the pagecache patches the race doesn't exist. Dropped it, thank you! -- Thanks, Sasha

Re: [PATCH AUTOSEL 5.1 033/375] leds: avoid races with workqueue

2019-05-29 Thread Sasha Levin
On Sat, May 25, 2019 at 12:55:05AM +0200, Pavel Machek wrote: Hi! Could we hold this patch for now? Sure, dropped. Thanks! -- Thanks, Sasha

Re: PROBLEM: oops spew with Linux 5.1.5 (NFS regression?)

2019-05-29 Thread Olga Kornievskaia
On Wed, May 29, 2019 at 1:14 PM Trond Myklebust wrote: > > On Wed, 2019-05-29 at 11:10 -0400, Nick Bowler wrote: > > Hi, > > > > I upgraded to Linux 5.1.5 on one machine yesterday, and this morning > > I > > happened noticed a large amount of backtraces in the log. It appears > > that the system

Re: [PATCH] ptrace: restore smp_rmb() in __ptrace_may_access()

2019-05-29 Thread Kees Cook
On Wed, May 29, 2019 at 01:31:57PM +0200, Jann Horn wrote: > Restore the read memory barrier in __ptrace_may_access() that was deleted > a couple years ago. Also add comments on this barrier and the one it pairs > with to explain why they're there (as far as I understand). > > Fixes: bfedb589252c

Re: [PATCH AUTOSEL 5.1 077/375] USB: serial: fix initial-termios handling

2019-05-29 Thread Sasha Levin
On Thu, May 23, 2019 at 07:26:00AM +0200, Johan Hovold wrote: Hi Sasha, On Wed, May 22, 2019 at 03:16:17PM -0400, Sasha Levin wrote: From: Johan Hovold [ Upstream commit 579bebe5dd522580019e7b10b07daaf500f9fb1e ] The USB-serial driver init_termios callback is used to override the default ini

Re: [PATCH v2] mm: add account_locked_vm utility function

2019-05-29 Thread Alex Williamson
On Tue, 28 May 2019 11:04:24 -0400 Daniel Jordan wrote: > On Sat, May 25, 2019 at 02:51:18PM -0700, Andrew Morton wrote: > > On Fri, 24 May 2019 13:50:45 -0400 Daniel Jordan > > wrote: > > > > > locked_vm accounting is done roughly the same way in five places, so > > > unify them in a helper

Re: [PATCH AUTOSEL 5.0 070/317] driver core: platform: Fix the usage of platform device name(pdev->name)

2019-05-29 Thread Sasha Levin
On Wed, May 22, 2019 at 10:04:52PM +0200, Greg Kroah-Hartman wrote: On Wed, May 22, 2019 at 03:19:31PM -0400, Sasha Levin wrote: From: Venkata Narendra Kumar Gutta [ Upstream commit edb16da34b084c66763f29bee42b4e6bb33c3d66 ] Platform core is using pdev->name as the platform device name to do

Re: [PATCH AUTOSEL 5.0 095/317] mlxsw: spectrum_router: Prevent ipv6 gateway with v4 route via replace and append

2019-05-29 Thread Sasha Levin
On Wed, May 22, 2019 at 01:27:41PM -0600, David Ahern wrote: On 5/22/19 1:19 PM, Sasha Levin wrote: From: David Ahern [ Upstream commit 7973d9e76727aa42f0824f5569e96248a572d50b ] mlxsw currently does not support v6 gateways with v4 routes. Commit 19a9d136f198 ("ipv4: Flag fib_info with a fib_

Re: ERROR: "hdac_hdmi_jack_port_init" [sound/soc/intel/boards/snd-soc-sof_rt5682.ko] undefined!

2019-05-29 Thread Pierre-Louis Bossart
On 5/29/19 12:54 PM, Randy Dunlap wrote: On 5/28/19 2:54 AM, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cd6c84d8f0cdc911df435bb075ba22ce3c605b07 commit: f70abd75b7c6c04d3219d0b3a0f3f15411b042fb ASoC: Intel: add sof-rt5682

Re: [PATCH v2] drivers/media/dvb-frontends: Implement probe/remove for stv6110x

2019-05-29 Thread Tobias Klausmann
On 29.05.19 20:45, Joe Perches wrote: On Wed, 2019-05-29 at 18:56 +0200, Tobias Klausmann wrote: Refactor out the common parts of stv6110x_probe() and stv6110x_attach() into separate functions. This provides the needed functionality to use dvb_module_probe() instead of dvb_attach()! v2: - Im

[PATCH] livepatch: Fix ftrace module text permissions race

2019-05-29 Thread Josh Poimboeuf
It's possible for livepatch and ftrace to be toggling a module's text permissions at the same time, resulting in the following panic: BUG: unable to handle page fault for address: c005b1d9 #PF: supervisor write access in kernel mode #PF: error_code(0x0003) - permissions violation P

[PATCH] mm/page_io: fix a crash in do_task_dead()

2019-05-29 Thread Qian Cai
The commit 0619317ff8ba ("block: add polled wakeup task helper") replaced wake_up_process() with blk_wake_io_task() in end_swap_bio_read() which triggers a crash when running heavy swapping workloads. [T114538] kernel BUG at kernel/sched/core.c:3462! [T114538] Process oom01 (pid: 114538, stack lim

Re: memory leak in sctp_process_init

2019-05-29 Thread Neil Horman
On Tue, May 28, 2019 at 07:15:50AM -0400, Neil Horman wrote: > On Mon, May 27, 2019 at 10:36:00PM -0300, Marcelo Ricardo Leitner wrote: > > On Mon, May 27, 2019 at 05:48:06PM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:9c7db500 Me

[PATCH 1/2] add typeof_member() macro

2019-05-29 Thread Alexey Dobriyan
Add typeof_member() macro so that types can be exctracted without introducing dummy variables. Signed-off-by: Alexey Dobriyan --- include/linux/kernel.h |2 ++ 1 file changed, 2 insertions(+) --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -88,6 +88,8 @@ */ #define FIELD_SI

[PATCH 2/2] proc: use typeof_member() macro

2019-05-29 Thread Alexey Dobriyan
Don't repeat function signatures twice. This is a kind-of-precursor for "struct proc_ops". Note: typeof(pde->proc_fops->...) ...; can't be used because ->proc_fops is "const struct file_operations *". "const" prevents assignment down the code and it can't be deleted in the type system.

Re: [PATCH v4] perf record: collect user registers set jointly with dwarf stacks

2019-05-29 Thread Arnaldo Carvalho de Melo
Em Wed, May 29, 2019 at 05:30:49PM +0300, Alexey Budankov escreveu: > > When dwarf stacks are collected jointly with user specified register > set using --user-regs option like below the full register context is > still captured on a sample: > > $ perf record -g --call-graph dwarf,1024 --user-r

Re: [PATCH v4 08/14] arm: Use generic mmap top-down layout and brk randomization

2019-05-29 Thread Kees Cook
On Sun, May 26, 2019 at 09:47:40AM -0400, Alexandre Ghiti wrote: > arm uses a top-down mmap layout by default that exactly fits the generic > functions, so get rid of arch specific code and use the generic version > by selecting ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT. > As ARCH_WANT_DEFAULT_TOPDOWN_

Re: kernel BUG at mm/swap_state.c:170!

2019-05-29 Thread Mikhail Gavrilov
On Wed, 29 May 2019 at 23:09, Michal Hocko wrote: > > On Wed 29-05-19 22:32:08, Mikhail Gavrilov wrote: > > On Wed, 29 May 2019 at 09:05, Mikhail Gavrilov > > wrote: > > > > > > Hi folks. > > > I am observed kernel panic after update to git tag 5.2-rc2. > > > This crash happens at memory pressing

Re: [PATCH V2 02/12] pinctrl: tegra: add suspend and resume support

2019-05-29 Thread Dmitry Osipenko
29.05.2019 21:14, Sowjanya Komatineni пишет: > > On 5/29/19 8:29 AM, Dmitry Osipenko wrote: >> 29.05.2019 2:08, Sowjanya Komatineni пишет: >>> This patch adds suspend and resume support for Tegra pinctrl driver >>> and registers them to syscore so the pinmux settings are restored >>> before the de

[PATCH] staging: kpc2000: replace bogus variable name in core.c

2019-05-29 Thread Simon Sandström
"struct kp2000_regs temp" has nothing to do with temperatures, so replace it with the more proper name "regs". Signed-off-by: Simon Sandström --- drivers/staging/kpc2000/kpc2000/core.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/stagin

[PATCH] usbip: usbip_host: fix stub_dev lock context imbalance regression

2019-05-29 Thread Shuah Khan
Fix the following sparse context imbalance regression introduced in a patch that fixed sleeping function called from invalid context bug. kbuild test robot reported on: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus Regressions in current branch: drivers

Re: [PATCH] mm/slab_common.c: fix possible spectre-v1 in kmalloc_slab()

2019-05-29 Thread Matthew Wilcox
On Wed, May 29, 2019 at 08:37:28PM +0800, Dianzhang Chen wrote: > The `size` in kmalloc_slab() is indirectly controlled by userspace via > syscall: poll(defined in fs/select.c), hence leading to a potential > exploitation of the Spectre variant 1 vulnerability. > The `size` can be controlled from

Re:

2019-05-29 Thread Alex Williamson
On Sun, 26 May 2019 13:44:04 +0200 "Thomas Meyer" wrote: > From tho...@m3y3r.de Sun May 26 00:13:26 2019 > Subject: [PATCH] vfio-pci/nvlink2: Use vma_pages function instead of explicit > computation > To: alex.william...@redhat.com, k...@vger.kernel.org, > linux-kernel@vger.kernel.org > Content

Re: [PATCH v1 0/5] Solve postboot supplier cleanup and optimize probe ordering

2019-05-29 Thread Saravana Kannan
Sending again because email client somehow reverted to HTML. Frank, Rob, Mark, Gentle reminder. I've replied to your emails spread across the different patches in the series. Hoping they address your questions and concerns. Please let me know what you think. Thanks, Saravana On Wed, May 29, 201

Re: [PATCH v4 04/14] arm64, mm: Move generic mmap layout functions to mm

2019-05-29 Thread Kees Cook
On Sun, May 26, 2019 at 09:47:36AM -0400, Alexandre Ghiti wrote: > arm64 handles top-down mmap layout in a way that can be easily reused > by other architectures, so make it available in mm. > It then introduces a new config ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT > that can be set by other architect

Re: [PATCH V2 02/12] pinctrl: tegra: add suspend and resume support

2019-05-29 Thread Sowjanya Komatineni
On 5/29/19 12:32 PM, Dmitry Osipenko wrote: 29.05.2019 21:14, Sowjanya Komatineni пишет: On 5/29/19 8:29 AM, Dmitry Osipenko wrote: 29.05.2019 2:08, Sowjanya Komatineni пишет: This patch adds suspend and resume support for Tegra pinctrl driver and registers them to syscore so the pinmux sett

[PATCH] vfio-pci/nvlink2: Use vma_pages function instead of explicit computation

2019-05-29 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c --- a/drivers/vfio/pci/vfio_pci_nvlink2.c +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c @@ -161,7 +161,7 @@ st

Cocci spatch "vma_pages" - v5.2-rc1

2019-05-29 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Run against version v5.2-rc1 P.S. If you find this email unwanted, set up a procmail rule junking on the header: X-Patch: Cocci

Re: [PATCH v4 05/14] arm64, mm: Make randomization selected by generic topdown mmap layout

2019-05-29 Thread Kees Cook
On Sun, May 26, 2019 at 09:47:37AM -0400, Alexandre Ghiti wrote: > This commits selects ARCH_HAS_ELF_RANDOMIZE when an arch uses the generic > topdown mmap layout functions so that this security feature is on by > default. > Note that this commit also removes the possibility for arm64 to have elf >

Re: [PATCH v4 11/14] mips: Adjust brk randomization offset to fit generic version

2019-05-29 Thread Kees Cook
On Sun, May 26, 2019 at 09:47:43AM -0400, Alexandre Ghiti wrote: > This commit simply bumps up to 32MB and 1GB the random offset > of brk, compared to 8MB and 256MB, for 32bit and 64bit respectively. > > Suggested-by: Kees Cook > Signed-off-by: Alexandre Ghiti Reviewed-by: Kees Cook -Kees >

Re: [PATCH v4 13/14] mips: Use generic mmap top-down layout and brk randomization

2019-05-29 Thread Kees Cook
On Sun, May 26, 2019 at 09:47:45AM -0400, Alexandre Ghiti wrote: > mips uses a top-down layout by default that exactly fits the generic > functions, so get rid of arch specific code and use the generic version > by selecting ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT. > As ARCH_WANT_DEFAULT_TOPDOWN_MMAP

Re: [PATCH v4 12/14] mips: Replace arch specific way to determine 32bit task with generic version

2019-05-29 Thread Kees Cook
On Sun, May 26, 2019 at 09:47:44AM -0400, Alexandre Ghiti wrote: > Mips uses TASK_IS_32BIT_ADDR to determine if a task is 32bit, but > this define is mips specific and other arches do not have it: instead, > use !IS_ENABLED(CONFIG_64BIT) || is_compat_task() condition. > > Signed-off-by: Alexandre

Re: [PATCH v4 00/14] Provide generic top-down mmap layout functions

2019-05-29 Thread Kees Cook
On Sun, May 26, 2019 at 09:47:32AM -0400, Alexandre Ghiti wrote: > This series introduces generic functions to make top-down mmap layout > easily accessible to architectures, in particular riscv which was > the initial goal of this series. > The generic implementation was taken from arm64 and used

[PATCH] elf: delete stale comment

2019-05-29 Thread Alexey Dobriyan
"passed_fileno" variable was deleted 11 years ago in 2.6.25. Fixes: d20894a23708 ("Remove a.out interpreter support in ELF loader") Signed-off-by: Alexey Dobriyan --- fs/binfmt_elf.c |1 - 1 file changed, 1 deletion(-) --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1129,7 +1129,6 @@ stati

[PATCH] scsi: lpfc: Use *_pool_zalloc rather than *_pool_alloc

2019-05-29 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -4114,14 +4114,13 @@ lpfc_new_io_buf(struct

[PATCH] scsi: pmcraid: Use *_pool_zalloc rather than *_pool_alloc

2019-05-29 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -4668,18 +4668,14 @@ static int pmcraid_allocate_control_bloc

Cocci spatch "pool_zalloc-simple" - v5.2-rc1

2019-05-29 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Run against version v5.2-rc1 P.S. If you find this email unwanted, set up a procmail rule junking on the header: X-Patch: Cocci

Re: [PATCH net-next 1/5] timecounter: Add helper for reconstructing partial timestamps

2019-05-29 Thread Vladimir Oltean
On Wed, 29 May 2019 at 05:14, John Stultz wrote: > > On Tue, May 28, 2019 at 4:58 PM Vladimir Oltean wrote: > > > > Some PTP hardware offers a 64-bit free-running counter whose snapshots > > are used for timestamping, but only makes part of that snapshot > > available as timestamps (low-order bit

Re: [PATCH] usbip: usbip_host: fix stub_dev lock context imbalance regression

2019-05-29 Thread Greg KH
On Wed, May 29, 2019 at 01:46:15PM -0600, Shuah Khan wrote: > Fix the following sparse context imbalance regression introduced in > a patch that fixed sleeping function called from invalid context bug. > > kbuild test robot reported on: > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH][next] qed: fix spelling mistake "inculde" -> "include"

2019-05-29 Thread David Miller
From: Colin King Date: Tue, 28 May 2019 07:52:17 +0100 > From: Colin Ian King > > There is a spelling mistake in a DP_INFO message. Fix it. > > Signed-off-by: Colin Ian King Applied.

[PATCH] block: fix a crash in do_task_dead()

2019-05-29 Thread Qian Cai
The commit 0619317ff8ba ("block: add polled wakeup task helper") replaced wake_up_process() with blk_wake_io_task() in end_swap_bio_read() which triggers a crash when running heavy swapping workloads. [T114538] kernel BUG at kernel/sched/core.c:3462! [T114538] Process oom01 (pid: 114538, stack lim

<    2   3   4   5   6   7   8   9   10   11   >