[RESEND 12/18] clk: imx: Switch wrappers to clk_hw based API

2019-05-29 Thread Abel Vesa
Switch all the wrappers to clk_hw based API and rename them to indicate that. Add macros for clk based legacy users. This allows us to move closer to a clear split between consumer and provider clk APIs. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk.h | 91

[RESEND 15/18] clk: imx6sx: Switch to clk_hw based API

2019-05-29 Thread Abel Vesa
Switch the entire clk-imx6sx driver to clk_hw based API. This allows us to move closer to a clear split between consumer and provider clk APIs. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk-imx6sx.c | 654 ++- 1 file changed, 334 insertions(+), 320 dele

[RESEND 09/18] clk: imx: clk-gate-exclusive: Switch to clk_hw based API

2019-05-29 Thread Abel Vesa
Switch the imx_clk_gate_exclusive function to clk_hw based API, rename accordingly and add a macro for clk based legacy. This allows us to move closer to a clear split between consumer and provider clk APIs. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk-gate-exclusive.c | 17 +++--

[RESEND 05/18] clk: imx: clk-cpu: Switch to clk_hw based API

2019-05-29 Thread Abel Vesa
Switch the clk_cpu clock registering function to clk_hw based API and add a macro for clk based legacy. This allows us to move closer to a clear split between consumer and provider clk APIs. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk-cpu.c | 14 +- drivers/clk/imx/clk.h |

[RESEND 18/18] clk: imx6sll: Switch to clk_hw based API

2019-05-29 Thread Abel Vesa
Switch the entire clk-imx6sll driver to clk_hw based API. This allows us to move closer to a clear split between consumer and provider clk APIs. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk-imx6sll.c | 430 ++ 1 file changed, 222 insertions(+), 208 del

[RESEND 06/18] clk: imx: clk-gate2: Switch to clk_hw based API

2019-05-29 Thread Abel Vesa
Switch the clk_register_gate2 function to clk_hw based API, rename accordingly and add a macro for clk based legacy. This allows us to move closer to a clear split between consumer and provider clk APIs. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk-gate2.c | 14 +- drivers/clk/im

[RESEND 17/18] clk: imx7d: Switch to clk_hw based API

2019-05-29 Thread Abel Vesa
Switch the entire clk-imx7d driver to clk_hw based API. This allows us to move closer to a clear split between consumer and provider clk APIs. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk-imx7d.c | 983 ++-- 1 file changed, 499 insertions(+), 484 delet

[RESEND 03/18] clk: imx6q: Do not reparent uninitialized IMX6QDL_CLK_PERIPH2 clock

2019-05-29 Thread Abel Vesa
The clock is registered later than these two re-parentings. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk-imx6q.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index 077276b..d90d54b 100644 --- a/drivers/clk/imx/clk-imx6q.

[RESEND 16/18] clk: imx6ul: Switch to clk_hw based API

2019-05-29 Thread Abel Vesa
Switch the entire clk-imx6ul driver to clk_hw based API. This allows us to move closer to a clear split between consumer and provider clk APIs. Signed-off-by: Abel Vesa --- drivers/clk/imx/clk-imx6ul.c | 574 ++- 1 file changed, 290 insertions(+), 284 dele

Re: [PATCH v2 2/3] KVM: X86: Implement PV sched yield hypercall

2019-05-29 Thread Liran Alon
> On 28 May 2019, at 3:53, Wanpeng Li wrote: > > From: Wanpeng Li > > The target vCPUs are in runnable state after vcpu_kick and suitable > as a yield target. This patch implements the sched yield hypercall. > > 17% performace increase of ebizzy benchmark can be observed in an > over-subs

Re: [PATCH] binfmt_flat: make load_flat_shared_library() work

2019-05-29 Thread Greg Ungerer
On 29/5/19 10:05 pm, Arnd Bergmann wrote: On Tue, May 28, 2019 at 12:56 PM Greg Ungerer wrote: On 27/5/19 11:38 pm, Jann Horn wrote: On Sat, May 25, 2019 at 11:43 PM Andrew Morton wrote: On Fri, 24 May 2019 22:18:17 +0200 Jann Horn wrote: load_flat_shared_library() is broken: It only cal

Re: Oops caused by race between livepatch and ftrace

2019-05-29 Thread Josh Poimboeuf
On Wed, May 29, 2019 at 08:06:48AM -0400, Steven Rostedt wrote: > On Wed, 29 May 2019 13:17:21 +0200 (CEST) > Jiri Kosina wrote: > > > > > From: Josh Poimboeuf > > > > Subject: [PATCH] livepatch: Fix ftrace module text permissions race > > > > > > Thanks, > > > > > > I'll try to find some ti

Re: [PATCH 1/4] ipv4: ipv6: netfilter: Adjust the frag mem limit when truesize changes

2019-05-29 Thread Stefan Bader
On 29.05.19 12:37, Greg KH wrote: > On Wed, May 29, 2019 at 12:25:39PM +0200, Stefan Bader wrote: >> From: Jiri Wiesner >> >> The *_frag_reasm() functions are susceptible to miscalculating the byte >> count of packet fragments in case the truesize of a head buffer changes. >> The truesize member m

Re: need company for kernel upgrade

2019-05-29 Thread Enrico Weigelt, metux IT consult
On 29.05.19 10:04, walter harms wrote: Hi, >> basic rule: don't use vendor kernels for production, unless you >> *really* *really* have to. > > we have custom hardware, so this was needed. Custom hardware doesn't necessarily need a vendor kernel. Most cases should be happy w/ board specific DT

Re: [PATCH] binfmt_flat: make load_flat_shared_library() work

2019-05-29 Thread John Paul Adrian Glaubitz
On 5/28/19 12:56 PM, Greg Ungerer wrote: >> Maybe... but I didn't want to rip it out without having one of the >> maintainers confirm that this really isn't likely to be used anymore. > > I have not used shared libraries on m68k non-mmu setups for > a very long time. At least 10 years I would thin

Re: [RFC 4/7] arm64: pmu: Add function implementation to update event index in userpage.

2019-05-29 Thread Peter Zijlstra
On Wed, May 29, 2019 at 01:25:46PM +0100, Raphael Gault wrote: > Hi Robin, Hi Peter, > > On 5/29/19 11:50 AM, Robin Murphy wrote: > > On 29/05/2019 11:46, Raphael Gault wrote: > > > Hi Peter, > > > > > > On 5/29/19 10:46 AM, Peter Zijlstra wrote: > > > > On Tue, May 28, 2019 at 04:03:17PM +0100,

[PATCH 0/4] arm64/mm: Fixes and cleanups for do_page_fault()

2019-05-29 Thread Anshuman Khandual
This series contains some fixes and cleanups for page fault handling in do_page_fault(). This has been boot tested on arm64 platform along with some stress test but just build tested on others. Cc: Catalin Marinas Cc: Will Deacon Cc: Mark Rutland Cc: James Morse Cc: Andrey Konovalov Anshuman

[PATCH 1/4] arm64/mm: Drop mmap_sem before calling __do_kernel_fault()

2019-05-29 Thread Anshuman Khandual
There is an inconsistency between down_read_trylock() success and failure paths while dealing with kernel access for non exception table areas where it calls __do_kernel_fault(). In case of failure it just bails out without holding mmap_sem but when it succeeds it does so while holding mmap_sem. Fi

[PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault()

2019-05-29 Thread Anshuman Khandual
__do_page_fault() is over complicated with multiple goto statements. This cleans up code flow and while there drops the vm_fault_t argument. Signed-off-by: Anshuman Khandual Cc: Catalin Marinas Cc: Will Deacon Cc: Mark Rutland Cc: James Morse Cc: Andrey Konovalov --- arch/arm64/mm/fault.c

[PATCH 3/4] arm64/mm: Consolidate page fault information capture

2019-05-29 Thread Anshuman Khandual
This consolidates page fault information capture and move them bit earlier. While here it also adds an wrapper is_write_abort(). It also saves some cycles by replacing multiple user_mode() calls into a single one earlier during the fault. Signed-off-by: Anshuman Khandual Cc: Catalin Marinas Cc:

[PATCH 2/4] arm64/mm: Drop task_struct argument from __do_page_fault()

2019-05-29 Thread Anshuman Khandual
The task_struct argument is not getting used in __do_page_fault(). Hence just drop it and use current or cuurent->mm instead where ever required. This does not change any functionality. Signed-off-by: Anshuman Khandual Cc: Catalin Marinas Cc: Will Deacon Cc: Mark Rutland Cc: James Morse Cc:

Re: [PATCH] binfmt_flat: make load_flat_shared_library() work

2019-05-29 Thread Jann Horn
On Wed, May 29, 2019 at 2:32 PM John Paul Adrian Glaubitz wrote: > On 5/28/19 12:56 PM, Greg Ungerer wrote: > >> Maybe... but I didn't want to rip it out without having one of the > >> maintainers confirm that this really isn't likely to be used anymore. > > > > I have not used shared libraries on

[PATCH v3] PCI: xilinx-nwl: Fix Multi MSI data programming

2019-05-29 Thread Bharat Kumar Gogada
The current Multi MSI data programming fails if multiple end points requesting MSI and multi MSI are connected with switch, i.e the current multi MSI data being given is not considering the number of vectors being requested in case of multi MSI. Ex: Two EP's connected via switch, EP1 requesting sin

Re: [RFC 2/3] preempt_tracer: Disable IRQ while starting/stopping due to a preempt_counter change

2019-05-29 Thread Steven Rostedt
On Wed, 29 May 2019 12:20:38 +0200 Peter Zijlstra wrote: > On Wed, May 29, 2019 at 11:40:34AM +0200, Daniel Bristot de Oliveira wrote: > > On 29/05/2019 10:33, Peter Zijlstra wrote: > > > On Tue, May 28, 2019 at 05:16:23PM +0200, Daniel Bristot de Oliveira > > > wrote: > > >> The preempt_dis

[PATCH] mm/slab_common.c: fix possible spectre-v1 in kmalloc_slab()

2019-05-29 Thread Dianzhang Chen
The `size` in kmalloc_slab() is indirectly controlled by userspace via syscall: poll(defined in fs/select.c), hence leading to a potential exploitation of the Spectre variant 1 vulnerability. The `size` can be controlled from: poll -> do_sys_poll -> kmalloc -> __kmalloc -> kmalloc_slab. Fix thi

Re: [RFC 4/7] arm64: pmu: Add function implementation to update event index in userpage.

2019-05-29 Thread Raphael Gault
Hi Peter, On 5/29/19 1:32 PM, Peter Zijlstra wrote: On Wed, May 29, 2019 at 01:25:46PM +0100, Raphael Gault wrote: Hi Robin, Hi Peter, On 5/29/19 11:50 AM, Robin Murphy wrote: On 29/05/2019 11:46, Raphael Gault wrote: Hi Peter, On 5/29/19 10:46 AM, Peter Zijlstra wrote: On Tue, May 28, 201

Re: [PATCH] binfmt_flat: make load_flat_shared_library() work

2019-05-29 Thread Greg Ungerer
On 29/5/19 10:32 pm, John Paul Adrian Glaubitz wrote: On 5/28/19 12:56 PM, Greg Ungerer wrote: Maybe... but I didn't want to rip it out without having one of the maintainers confirm that this really isn't likely to be used anymore. I have not used shared libraries on m68k non-mmu setups for

Re: [PATCH 0/4] arm64/mm: Fixes and cleanups for do_page_fault()

2019-05-29 Thread Will Deacon
Hi Anshuman, On Wed, May 29, 2019 at 06:04:41PM +0530, Anshuman Khandual wrote: > This series contains some fixes and cleanups for page fault handling in > do_page_fault(). This has been boot tested on arm64 platform along with > some stress test but just build tested on others. These all seem to

Re: [PATCH 1/2] power: supply: Add HWMON compatibility layer

2019-05-29 Thread Guenter Roeck
On 5/29/19 12:11 AM, Andrey Smirnov wrote: Add code implementing HWMON adapter/compatibility layer to allow expositing various sensors present on power supply devices via HWMON subsystem. This is done in order to allow userspace to use single ABI/library(libsensors) to access/manipulate all of th

Re: [PATCH] binfmt_flat: make load_flat_shared_library() work

2019-05-29 Thread John Paul Adrian Glaubitz
On 5/29/19 2:38 PM, Jann Horn wrote: >>> I have not used shared libraries on m68k non-mmu setups for >>> a very long time. At least 10 years I would think. >> We use shared libraries in Debian on m68k and Andreas Schwab uses them >> on openSUSE/m68k. > > And you're using FLAT shared libraries, not

Re: [PATCH, RFC 05/62] mm/page_alloc: Handle allocation for encrypted memory

2019-05-29 Thread Kirill A. Shutemov
On Wed, May 29, 2019 at 10:21:25AM +0300, Mike Rapoport wrote: > Shouldn't it be EXPORT_SYMBOL? We don't have callers outside core-mm at the moment. I'll add kerneldoc in the next submission. -- Kirill A. Shutemov

WARNING in submit_rx_urb/usb_submit_urb

2019-05-29 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:69bbe8c7 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=143d5972a0 kernel config: https://syzkaller.appspot.com/x/.

Re: [PATCH v2] PCI: qcom: Ensure that PERST is asserted for at least 100 ms

2019-05-29 Thread Bjorn Helgaas
On Wed, May 29, 2019 at 11:43:52AM +0200, Niklas Cassel wrote: > Currently, there is only a 1 ms sleep after asserting PERST. > > Reading the datasheets for different endpoints, some require PERST to be > asserted for 10 ms in order for the endpoint to perform a reset, others > require it to be as

RE: [PATCH v2 08/10] Input: elan_i2c - export true width/height

2019-05-29 Thread 廖崇榮
-Original Message- From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] Sent: Wednesday, May 29, 2019 3:17 PM To: Sean O'Brien; Peter Hutterer Cc: Harry Cutts; Dmitry Torokhov; 廖崇榮; Rob Herring; Aaron Ma; Hans de Goede; open list:HID CORE LAYER; lkml; devicet...@vger.kernel.

Re: [PATCH] perf: Fix oops when kthread execs user process

2019-05-29 Thread Peter Zijlstra
On Wed, May 29, 2019 at 11:20:22AM +0100, Will Deacon wrote: > Anyway, you can add my ack to your patch, but I bet we can remove that mm > check :D I've ended up with the below. Ravi, can you test if that does indeed obsolete your PPC patch? --- Subject: perf: Fix perf_sample_regs_user() From: Pe

Re: [PATCH 0/4] arm64/mm: Fixes and cleanups for do_page_fault()

2019-05-29 Thread Anshuman Khandual
On 05/29/2019 06:11 PM, Will Deacon wrote: > Hi Anshuman, > > On Wed, May 29, 2019 at 06:04:41PM +0530, Anshuman Khandual wrote: >> This series contains some fixes and cleanups for page fault handling in >> do_page_fault(). This has been boot tested on arm64 platform along with >> some stress t

Re: [PATCH 4/7] vfs: Add superblock notifications

2019-05-29 Thread David Howells
Jann Horn wrote: > It might make sense to require that the path points to the root inode > of the superblock? That way you wouldn't be able to do this on a bind > mount that exposes part of a shared filesystem to a container. Why prevent that? It doesn't prevent the container denizen from watch

Re: [PATCH bpf] libbpf: Return btf_fd in libbpf__probe_raw_btf

2019-05-29 Thread Michal Rostecki
On Wed, May 29, 2019 at 12:53:42PM +0300, Sergei Shtylyov wrote: > Hello! > > On 29.05.2019 11:29, Michal Rostecki wrote: > > > Function load_sk_storage_btf expects that libbpf__probe_raw_btf is > > returning a btf descriptor, but before this change it was returning > > an information about wheth

Re: [PATCH] perf: Fix oops when kthread execs user process

2019-05-29 Thread Will Deacon
On Wed, May 29, 2019 at 02:55:57PM +0200, Peter Zijlstra wrote: > On Wed, May 29, 2019 at 11:20:22AM +0100, Will Deacon wrote: > > Anyway, you can add my ack to your patch, but I bet we can remove that mm > > check :D > > I've ended up with the below. Ravi, can you test if that does indeed > obsol

[PATCH net-next 2/3] udp: introduce a new tracepoint for udp_queue_rcv_skb

2019-05-29 Thread Tony Lu
This introduces a new tracepoint trace_udp_queue_rcv, it will trace UDP packets that are going to be queued on the socket receive queue. Signed-off-by: Tony Lu --- include/trace/events/udp.h | 7 +++ net/ipv4/udp.c | 1 + net/ipv6/udp.c | 1 + 3 files changed, 9 inser

[PATCH net-next 3/3] tcp: remove redundant new line from tcp_event_sk_skb

2019-05-29 Thread Tony Lu
This removes '\n' from trace event class tcp_event_sk_skb to avoid redundant new blank line and make output compact. Signed-off-by: Tony Lu --- include/trace/events/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h i

[PATCH net-next 0/3] introduce two new tracepoints for udp

2019-05-29 Thread Tony Lu
This series introduces two new tracepoints trace_udp_send and trace_udp_queue_rcv, and removes redundant new line from tcp_event_sk_skb. Tony Lu (3): udp: introduce a new tracepoint for udp_send_skb udp: introduce a new tracepoint for udp_queue_rcv_skb tcp: remove redundant new line from tcp

Re: [PATCH 5/5] drm/msm/mdp5: Use the interconnect API

2019-05-29 Thread Georgi Djakov
On 5/8/19 23:42, Rob Clark wrote: > From: Georgi Djakov > Let's put some text in the commit message: The interconnect API provides an interface for consumer drivers to express their bandwidth needs in the SoC. This data is aggregated and the on-chip interconnect hardware is configured to the mo

[PATCH net-next 1/3] udp: introduce a new tracepoint for udp_send_skb

2019-05-29 Thread Tony Lu
This introduces a new tracepoint trace_udp_send, it will trace UDP packets that are going to be send to the IP layer. This exposes src and dst IP addresses and ports of the connection. We could use kprobe or tcpdump to do similar things, however using tracepoint makes it easier to use and to integ

[PATCH] staging: octeon-usb: Remove return variable

2019-05-29 Thread Nishka Dasgupta
Remove return variable result and return the value directly. Issue found using Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/octeon-usb/octeon-hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/o

[PATCH] media: davinci: vpif_capture: fix memory leak in vpif_probe()

2019-05-29 Thread Young Xiao
If vpif_probe() fails on vpif_probe_complete(), then memory allocated at initialize_vpif() for global vpif_obj.dev[i] become unreleased. The patch adds deallocation of vpif_obj.dev[i] on the error path. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/media/platform/davinci/vpif_captu

[PATCH] staging: kpc2000: Change to use DIV_ROUND_UP

2019-05-29 Thread Nishka Dasgupta
Use macro DIV_ROUND_UP instead of an equivalent sequence of operations. Signed-off-by: Nishka Dasgupta --- drivers/staging/kpc2000/kpc_dma/fileops.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dm

Re: [PATCH 1/7] General notification queue with user mmap()'able ring buffer [ver #13]

2019-05-29 Thread David Howells
Miklos Szeredi wrote: > Would it make sense to use relayfs for the implementation of the > mapped ring buffer? Note that I reposted the notification patches under the correct cover note later. Could you repost your response there. Subject: [RFC][PATCH 0/7] Mount, FS, Block and Keyrings notific

Re: [GIT PULL] SPDX update for 5.2-rc1 - round 1

2019-05-29 Thread Alexandre Belloni
Hello, On 21/05/2019 15:32:57+0200, Greg KH wrote: > - Add GPL-2.0-only or GPL-2.0-or-later tags to files where our scan I'm very confused by those two tags because they are not mentioned in the SPDX 2.1 specification or the kernel documentation and seem to just be from https://spdx.org/ids-how

Re: [PATCH 8/8] ceph: hold i_ceph_lock when removing caps for freeing inode

2019-05-29 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.1.4, v5.0.18, v4.19.45, v4.14.121, v4.9.178, v4.4.180, v3.18.140. v5.1.4: Build

[PATCH] staging: rts5208: Remove negations

2019-05-29 Thread Nishka Dasgupta
Previously return variable fake_para was being negated before return. For simplification, fake_para can be changed to valid_para, which is returned without negation (corresponding values swapped accordingly). Further, the function names check_sd_current_prior and check_sd_speed_prior can be changed

Re: [PATCH] binfmt_flat: make load_flat_shared_library() work

2019-05-29 Thread Andreas Schwab
On Mai 29 2019, John Paul Adrian Glaubitz wrote: > On 5/28/19 12:56 PM, Greg Ungerer wrote: >>> Maybe... but I didn't want to rip it out without having one of the >>> maintainers confirm that this really isn't likely to be used anymore. >> >> I have not used shared libraries on m68k non-mmu setu

Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height

2019-05-29 Thread Benjamin Tissoires
On Wed, May 29, 2019 at 2:56 PM 廖崇榮 wrote: > > > > -Original Message- > From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] > Sent: Wednesday, May 29, 2019 3:17 PM > To: Sean O'Brien; Peter Hutterer > Cc: Harry Cutts; Dmitry Torokhov; 廖崇榮; Rob Herring; Aaron Ma; Hans de Goede;

Re: [PATCH] binfmt_flat: make load_flat_shared_library() work

2019-05-29 Thread John Paul Adrian Glaubitz
On 5/29/19 3:16 PM, Andreas Schwab wrote: >>> I have not used shared libraries on m68k non-mmu setups for >>> a very long time. At least 10 years I would think. >> We use shared libraries in Debian on m68k and Andreas Schwab uses them >> on openSUSE/m68k. > > Nope, I don't use non-mmu. Sorry, I m

[PATCH bpf v2] libbpf: Return btf_fd in libbpf__probe_raw_btf

2019-05-29 Thread Michal Rostecki
Function load_sk_storage_btf expects that libbpf__probe_raw_btf is returning a BTF descriptor, but before this change it was returning an information about whether the probe was successful (0 or 1). load_sk_storage_btf was using that value as an argument of the close function, which was resulting i

[PATCH] staging: rtl8712: Remove unnecessary variable in rtl8712_recv.c

2019-05-29 Thread Nishka Dasgupta
Remove unnecessary variable last_evm in rtl8712_recv.c and use its value directly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 5 ++--- drivers/staging/rtl8712/rtl871x_cmd.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) di

Re: [RFC 2/3] preempt_tracer: Disable IRQ while starting/stopping due to a preempt_counter change

2019-05-29 Thread Peter Zijlstra
On Wed, May 29, 2019 at 08:39:30AM -0400, Steven Rostedt wrote: > I believe I see what Daniel is talking about, but I hate the proposed > solution ;-) > > First, if you care about real times that the CPU can't preempt > (preempt_count != 0 or interrupts disabled), then you want the > preempt_irqso

Re: [PATCH v15 05/17] arms64: untag user pointers passed to memory syscalls

2019-05-29 Thread Catalin Marinas
On Wed, May 29, 2019 at 01:42:25PM +0100, Dave P Martin wrote: > On Tue, May 28, 2019 at 05:34:00PM +0100, Catalin Marinas wrote: > > On Tue, May 28, 2019 at 04:56:45PM +0100, Dave P Martin wrote: > > > On Tue, May 28, 2019 at 04:40:58PM +0100, Catalin Marinas wrote: > > > > > > [...] > > > > > >

[PATCH] staging: rtl8712: Remove return variable of different type

2019-05-29 Thread Nishka Dasgupta
The local return variable ret may be replaced directly by its value, especially since its type (uint) is not the same as the function's return type (int). Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 4 ++-- 1 file changed, 2 ins

Re: [PATCH] perf: Fix oops when kthread execs user process

2019-05-29 Thread Peter Zijlstra
On Wed, May 29, 2019 at 02:05:21PM +0100, Will Deacon wrote: > On Wed, May 29, 2019 at 02:55:57PM +0200, Peter Zijlstra wrote: > > if (user_mode(regs)) { > > Hmm, so it just occurred to me that Mark's observation is that the regs > can be junk in some cases. In which case, should we be checki

Re: [RFC 2/3] preempt_tracer: Disable IRQ while starting/stopping due to a preempt_counter change

2019-05-29 Thread Peter Zijlstra
On Wed, May 29, 2019 at 03:19:57PM +0200, Peter Zijlstra wrote: > On Wed, May 29, 2019 at 08:39:30AM -0400, Steven Rostedt wrote: > > I believe I see what Daniel is talking about, but I hate the proposed > > solution ;-) > > > > First, if you care about real times that the CPU can't preempt > > (p

[PATCH] staging: rtl8712: Remove initialisations

2019-05-29 Thread Nishka Dasgupta
Remove initialisations of multiple variables as these initial values are never used. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_mp.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8712/rtl

[PATCH 01/41] perf-with-kcore.sh: Always allow fix_buildid_cache_permissions

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter The user's buildid cache may contain entries added by root even if root has its own home directory (e.g. by using perfconfig to specify the same buildid dir), so remove that validation. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20190412113830

[GIT PULL] perf/core improvements and fixes for 5.3

2019-05-29 Thread Arnaldo Carvalho de Melo
at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-5.3-20190529 for you to fetch changes up to 14f1cfd4f7b4794e2f9d2ae214bcf049654b0b5c: perf intel-pt: Rationalize intel_pt_sync_switch()'s use of next_tid (2019-05-28

[PATCH 02/41] perf intel-pt: Fix itrace defaults for perf script

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Commit 4eb068157121 ("perf script: Make itrace script default to all calls") does not work because 'use_browser' is being used to determine whether to default to periodic sampling (i.e. better for perf report). The result is that nothing but CBR events display for perf script

[PATCH 05/41] perf machine: Keep zero in pgoff BPF map

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa With pgoff set to zero, the map__map_ip function will return BPF addresses based from 0, which is what we need when we read the data from a BPF DSO. Adding BPF symbols with mapped IP addresses as well. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexande

[PATCH 06/41] perf tools: Preserve eBPF maps when loading kcore

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We need to preserve eBPF maps even if they are covered by kcore, because we need to access eBPF dso for source data. Add the map_groups__merge_in function to do that. It merges a map into map_groups by splitting the new map within the existing map regions. Suggested-by: Adrian

[PATCH 04/41] perf intel-pt: Fix itrace defaults for perf script intel-pt documentation

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Fix intel-pt documentation to reflect the change of itrace defaults for perf script. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Cc: sta...@vger.kernel.org Fixes: 4eb068157121 ("perf script: Make itrace script default to all calls") Link: http://lkml.kernel.org/r/20190520113

[PATCH 03/41] perf auxtrace: Fix itrace defaults for perf script

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Commit 4eb068157121 ("perf script: Make itrace script default to all calls") does not work for the case when '--itrace' only is used, because default_no_sample is not being passed. Example: Before: $ perf record -e intel_pt/cyc/u ls $ perf script --itrace > cmp1.txt

[PATCH 07/41] perf augmented_raw_syscalls: Fix up comment

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Cut'n'paste error, the second comment is about the syscalls that have as its second arg a string. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-zo5s6rloy42u41acsf6q3...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo

[PATCH 08/41] perf beauty: Add generator for 'move_mount' flags argument

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/move_mount_flags.sh static const char *move_mount_flags[] = { [ilog2(0x0001) + 1] = "F_SYMLINKS", [ilog2(0x0002) + 1] = "F_AUTOMOUNTS", [ilog2(0x0004) + 1] = "F_EMPTY_PATH", [ilog2(0x0

[PATCH 12/41] perf beauty: Add generator for fsconfig's 'cmd' arg values

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/fsconfig.sh static const char *fsconfig_cmds[] = { [0] = "SET_FLAG", [1] = "SET_STRING", [2] = "SET_BINARY", [3] = "SET_PATH", [4] = "SET_PATH_EMPTY", [5] = "SET_FD",

[PATCH 13/41] perf trace: Beautify 'fsconfig' arguments

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first arg, fd, assigned using the heuristic that looks for syscall arg names and associates SCA_FD with 'fd' named argumes, and wire up the recently introduced fsconfig cmd table generator. Now it should be possible to just use:

[PATCH 14/41] perf beauty: Add generator for fsmount's 'attr_flags' arg values

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/fsmount.sh static const char *fsmount_attr_flags[] = { [ilog2(0x0001) + 1] = "RDONLY", [ilog2(0x0002) + 1] = "NOSUID", [ilog2(0x0004) + 1] = "NODEV", [ilog2(0x0008) + 1] = "NOEXEC"

[PATCH 11/41] perf trace: Beautify 'fspick' arguments

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first 2 args (dfd, path) and wire up the recently introduced fspick flags table generator. Now it should be possible to just use: perf trace -e fspick As root and see all move_mount syscalls with its args beautified, either usi

[PATCH 15/41] perf trace: Introduce syscall_arg__scnprintf_strarray_flags

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo So that one can just define a strarray and process it as a set of flags, similar to syscall_arg__scnprintf_strarray() with plain arrays. Cc: Adrian Hunter Cc: Brendan Gregg Cc: Jiri Olsa Cc: Luis Cláudio Gonçalves Cc: Namhyung Kim Link: https://lkml.kernel.org

[PATCH 10/41] perf beauty: Add generator for fspick's 'flags' arg values

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/fspick.sh static const char *fspick_flags[] = { [ilog2(0x0001) + 1] = "CLOEXEC", [ilog2(0x0002) + 1] = "SYMLINK_NOFOLLOW", [ilog2(0x0004) + 1] = "NO_AUTOMOUNT", [ilog2(0x0008) + 1]

[PATCH 16/41] perf trace: Beautify 'fsmount' arguments

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first arg, fd, assigned using the heuristic that looks for syscall arg names and associates SCA_FD with 'fd' named argumes, and wire up the recently introduced fsmount attr_flags table generator. Now it should be possible to just us

[PATCH 09/41] perf trace: Beautify 'move_mount' arguments

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first 4 args (to/from fds, pathnames) and wire up the recently introduced move_mount flags table generator. Now it should be possible to just use: perf trace -e move_mount As root and see all move_mount syscalls with its arg

[PATCH 20/41] perf top: Add --namespaces option

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim Since 'perf record' already have this option, let's have it for 'perf top' as well. Signed-off-by: Namhyung Kim Cc: Hari Bathini Cc: Jiri Olsa Cc: Krister Johansen Link: http://lkml.kernel.org/r/20190522053250.207156-4-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de

[PATCH 19/41] perf trace: Beautify 'sync_file_range' arguments

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Use existing beautifiers for the first arg, fd, assigned using the heuristic that looks for syscall arg names and associates SCA_FD with 'fd' named argumes, and wire up the recently introduced sync_file_range flags table generator. Now it should be possible to just

[PATCH 18/41] perf beauty: Add generator for sync_file_range's 'flags' arg values

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo $ tools/perf/trace/beauty/sync_file_range.sh static const char *sync_file_range_flags[] = { [ilog2(1) + 1] = "WAIT_BEFORE", [ilog2(2) + 1] = "WRITE", [ilog2(4) + 1] = "WAIT_AFTER", }; $ When all are the above are present, then

[PATCH 21/41] perf tools: Remove const from thread read accessors

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim The namespaces and comm fields of a thread are protected by rwsem and require write access for it. So it ended up using a cast to remove the const qualifier. Let's get rid of the const then. Signed-off-by: Namhyung Kim Suggested-by: Arnaldo Carvalho de Melo Cc: Hari Bathin

[PATCH 23/41] perf dso: Separate generic code in dso_cache__read

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Move the file specific code in the dso_cache__read function to a separate file_read function. I'll add BPF specific code in the following patches. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter

[PATCH 17/41] perf trace beauty clone: Handle CLONE_PIDFD

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo In addition to the older flags. This will allow something like this to be implemented in 'perf trace" perf trace -e clone/PIDFD in flags/ I.e. ask for strace like tracing, system wide, looking for 'clone' syscalls that have the CLONE_PIDFD bit set in the 'flags'

[PATCH 24/41] perf dso: Simplify dso_cache__read function

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no need for the while loop now, also we can connect two (ret > 0) condition legs together. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Song Liu Cc: Stanislav Fomichev

[PATCH 26/41] perf script: Pad DSO name for --call-trace

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Pad the DSO name in --call-trace so we don't have the indent screwed by different DSO name lengths, as now for kernel there's also BPF code displayed. # perf-with-kcore record pt -e intel_pt//ku -- sleep 1 # perf-core/perf-with-kcore script pt --call-trace Before: sleep

[PATCH 25/41] perf dso: Add BPF DSO read and size hooks

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add BPF related code into DSO reading paths to return size (bpf_size) and read the BPF code (bpf_read). Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stanislav Fomichev Link: htt

[PATCH 22/41] perf dso: Separate generic code in dso__data_file_size()

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Moving file specific code in dso__data_file_size function into separate file_size function. I'll add bpf specific code in following patches. Signed-off-by: Jiri Olsa Acked-by: Song Liu Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Andi Kleen Cc: Namhyung Kim Cc: Peter Zijlst

[PATCH 27/41] perf tests: Add map_groups__merge_in test

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add map_groups__merge_in test to test the map_groups__merge_in function usage - merging kcore maps into existing eBPF maps. Committer testing: # perf test merge 59: map_groups__merge_in : Ok # perf test -v merge 59: map_groups__merge_in

[PATCH 28/41] perf script: Add --show-bpf-events to show eBPF related events

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add the --show-bpf-events command line option to show the eBPF related events: PERF_RECORD_KSYMBOL PERF_RECORD_BPF_EVENT Usage: # perf record -a ... # perf script --show-bpf-events ... swapper 0 [000] 0.00: PERF_RECORD_KSYMBOL ksymbol event with addr

[PATCH 32/41] perf annotate TUI browser: Do not use member from variable within its own initialization

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Some compilers will complain when using a member of a struct to initialize another member, in the same struct initialization. For instance: debian:8 Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0) oraclelinux:7 clang version

[PATCH 29/41] perf script: Remove superfluous BPF event titles

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no need to display "ksymbol event with" text for the PERF_RECORD_KSYMBOL event and "bpf event with" test for the PERF_RECORD_BPF_EVENT event. Remove it so it also goes along with other side-band events display. Before: # perf script --show-bpf-events ... swapper

[PATCH 31/41] perf machine: Return NULL instead of null-terminating /proc/version array

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Donald Yandt Return NULL instead of null-terminating version char array when fgets fails due to end-of-file or error. Signed-off-by: Donald Yandt Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Peter Zijlstra Cc: Yanmin Zhang Fixes: 30ba5b0e66c8 ("perf machine: Null-terminate version char ar

[PATCH 30/41] perf version: Append 12 git SHA chars to the version string

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Bumping it from just 4: Before: $ perf -v perf version 5.2.rc1.g80978f $ After: $ perf -v perf version 5.2.rc1.g80978fc864c5 $ Requested-by: Ingo Molnar Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-p4yun2n

[PATCH 33/41] perf python: Remove -fstack-protector-strong if clang doesn't have it

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Some distros put -fstack-protector-strong in the compiler flags to be used to build python extensions, but then, the clang version in that distro doesn't know about that, only gcc does. Check if that is the case and remove it from the set of options used to build t

[PATCH 34/41] perf top: Lower message level for failure on synthesizing events for pre-existing BPF programs

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Move it from being a pr_warning() to a pr_debug(). Also capitalize BPF and explain what gets missing when we're not able to synthesize these events: we'll not be able to resolve symbols, etc. Reported-by: Ingo Molnar Cc: Adrian Hunter Cc: Alexei Starovoitov Cc:

[PATCH 36/41] perf scripts python: exported-sql-viewer.py: Use argparse module for argument parsing

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter The argparse module makes it easier to add new arguments. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20190412113830.4126-3-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- .../scripts/python/exported-sql-viewer.py | 21

[PATCH 35/41] perf scripts python: exported-sql-viewer.py: Change python2 to python

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Now that there is also support for python3, there is no need to specify python2 explicitly. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20190412113830.4126-2-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/scrip

[PATCH 39/41] perf scripts python: export-to-postgresql.py: Add support for pyside2

2019-05-29 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter pyside2 is the future for pyside support. Note pyside use Qt4 whereas pyside2 uses Qt5. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20190412113830.4126-6-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- .../scripts/python/

<    1   2   3   4   5   6   7   8   9   10   >